⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 30, 2022:

7:42 PM Changeset in webkit [293650] by Andres Gonzalez
  • 15 edits in trunk/Source/WebCore

Code cleanup in preparation for refactoring of computing relationships between AXObjects.
​https://bugs.webkit.org/show_bug.cgi?id=239848
<rdar://problem/92455544>

Reviewed by Chris Fleizach and Tyler Wilcock.

No new functionality.

AccessibilityObject::ariaElementsFromAttribute() and
ariaElementsReferencedByAttribute() are the methods that currently
compute the relationships between objects. These methods now return a
vector of the related objects instead of taking an out parameter.
In addition, all ariaXXXElements and ariaXXXReferencingElements methods
are renamed to better reflect the relationships they retrieve. Note that
the prefix aria is removed from all method names because ARIA is one way
of establishing relationships between objects, but not necessarily the
only way. These changes make the code more concise and clearer.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::textUnderElement const):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaElementsFromAttribute const):
(WebCore::AccessibilityObject::ariaElementsReferencedByAttribute const):
(WebCore::AccessibilityObject::isActiveDescendantOfFocusedContainer const):
(WebCore::AccessibilityObject::activeDescendantOfObjects const):
(WebCore::AccessibilityObject::controlledObjects const):
(WebCore::AccessibilityObject::controllers const):
(WebCore::AccessibilityObject::describedByObjects const):
(WebCore::AccessibilityObject::descriptionForObjects const):
(WebCore::AccessibilityObject::detailedByObjects const):
(WebCore::AccessibilityObject::detailsForObjects const):
(WebCore::AccessibilityObject::errorMessageObjects const):
(WebCore::AccessibilityObject::errorMessageForObjects const):
(WebCore::AccessibilityObject::flowToObjects const):
(WebCore::AccessibilityObject::flowFromObjects const):
(WebCore::AccessibilityObject::labelledByObjects const):
(WebCore::AccessibilityObject::labelForObjects const):
(WebCore::AccessibilityObject::ownedObjects const):
(WebCore::AccessibilityObject::owners const):
(WebCore::AccessibilityObject::ariaActiveDescendantReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaControlsElements const): Deleted.
(WebCore::AccessibilityObject::ariaControlsReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaDescribedByElements const): Deleted.
(WebCore::AccessibilityObject::ariaDescribedByReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaDetailsElements const): Deleted.
(WebCore::AccessibilityObject::ariaDetailsReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaErrorMessageElements const): Deleted.
(WebCore::AccessibilityObject::ariaErrorMessageReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaFlowToElements const): Deleted.
(WebCore::AccessibilityObject::ariaFlowToReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaLabelledByElements const): Deleted.
(WebCore::AccessibilityObject::ariaLabelledByReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaOwnsElements const): Deleted.
(WebCore::AccessibilityObject::ariaOwnsReferencingElements const): Deleted.

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityObjectInterface.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::linkedUIElements const):
(WebCore::AccessibilityRenderObject::targetElementForActiveDescendant const):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::columnHeaders):
(WebCore::AccessibilityTableCell::ariaOwnedByParent const):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::addChildren):

  • accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::relationMap const):

  • accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::activeDescendantOfObjects const):
(WebCore::AXIsolatedObject::controllers const):
(WebCore::AXIsolatedObject::describedByObjects const):
(WebCore::AXIsolatedObject::descriptionForObjects const):
(WebCore::AXIsolatedObject::detailsForObjects const):
(WebCore::AXIsolatedObject::errorMessageForObjects const):
(WebCore::AXIsolatedObject::flowFromObjects const):
(WebCore::AXIsolatedObject::labelledByObjects const):
(WebCore::AXIsolatedObject::labelForObjects const):
(WebCore::AXIsolatedObject::owners const):
(WebCore::AXIsolatedObject::ariaActiveDescendantReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaControlsReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaDescribedByElements const): Deleted.
(WebCore::AXIsolatedObject::ariaDescribedByReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaDetailsReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaErrorMessageReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaFlowToReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaLabelledByElements const): Deleted.
(WebCore::AXIsolatedObject::ariaLabelledByReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaOwnsReferencingElements const): Deleted.

  • accessibility/isolatedtree/AXIsolatedObject.h:
  • accessibility/isolatedtree/AXIsolatedTree.h:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

9:57 AM Changeset in webkit [293649] by commit-queue@webkit.org
  • 3 edits in trunk

[WPE][GTK] Enable MEDIA_SESSION by default
​https://bugs.webkit.org/show_bug.cgi?id=239931

Patch by Philippe Normand <​pnormand@igalia.com> on 2022-04-30
Reviewed by Michael Catanzaro.

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:

Canonical link: ​https://commits.webkit.org/250153@main

9:50 AM Changeset in webkit [293648] by commit-queue@webkit.org
  • 6 edits in trunk

REGRESSION(r283437) a number of media tests fail/timeout on the test bots
​https://bugs.webkit.org/show_bug.cgi?id=231811
<rdar://problem/84552871>

Patch by Philippe Normand <​pnormand@igalia.com> on 2022-04-30
Reviewed by Michael Catanzaro.

Disable DBus MPRIS notifications when running the tests, these leak to the host when running
on desktop and trigger timeouts on under-powered bots.

  • platform/audio/glib/MediaSessionGLib.cpp:

(WebCore::MediaSessionGLib::create):
(WebCore::MediaSessionGLib::MediaSessionGLib):
(WebCore::MediaSessionGLib::emitPositionChanged):
(WebCore::MediaSessionGLib::updateNowPlaying):
(WebCore::MediaSessionGLib::playbackStatusChanged):

  • platform/audio/glib/MediaSessionManagerGLib.h:

(WebCore::MediaSessionManagerGLib::setDBusNotificationsEnabled):
(WebCore::MediaSessionManagerGLib::areDBusNotificationsEnabled const):

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):

LayoutTests:

  • platform/glib/TestExpectations: Unflag tests now passing.

Canonical link: ​https://commits.webkit.org/250152@main

9:30 AM Changeset in webkit [293647] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Only stretch the percent height <body> when it is the document element's child
​https://bugs.webkit.org/show_bug.cgi?id=239932
<rdar://92257660>

Reviewed by Antti Koivisto.

This IE quirk should only be applied to when the body is actually the document element's child (stretching case).

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight const):

  • rendering/RenderBox.h:

(WebCore::RenderBox::parentBox const):

8:30 AM Changeset in webkit [293646] by Alan Bujtas
  • 5 edits
    2 adds in trunk

ASSERTION FAILED: *trailingRunIndex >= overflowingRunIndex in WebCore::Layout::InlineContentBreaker::tryBreakingNextOverflowingRuns
​https://bugs.webkit.org/show_bug.cgi?id=239838
<rdar://problem/92455051>

Reviewed by Antti Koivisto.

Source/WebCore:

Take partial text overflow into account when computing intrinsic width.

Test: fast/inline/overflowing-content-inside-inline-box-crash.html

  • layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):

  • layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::computedIntrinsicWidth):

  • layout/formattingContexts/inline/InlineLineBuilder.h:

LayoutTests:

  • fast/inline/overflowing-content-inside-inline-box-crash-expected.txt: Added.
  • fast/inline/overflowing-content-inside-inline-box-crash.html: Added.
6:11 AM Changeset in webkit [293645] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC][IFC] Introduce LineBuilder::PartialContent
​https://bugs.webkit.org/show_bug.cgi?id=239886

Reviewed by Antti Koivisto.

This patch is in preparation for adding partial content support for intrinsic width computation.

  1. Use a dedicated PartialContent structure to store partial overflowing information (output of current line breaking, input to next line).
  2. Decouple partial overflowing width (see above) and the "let's not measure the wrapped content again on the next line as leading content" cached value.
  • layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::lineLayout):

  • layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::initialize):

  • layout/formattingContexts/inline/InlineLineBuilder.h:

(WebCore::Layout::LineBuilder::PartialContent::PartialContent):

6:01 AM Changeset in webkit [293644] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][IFC] Do not wrap </span> to the next line when it is preceded by overflowing text
​https://bugs.webkit.org/show_bug.cgi?id=239879
<rdar://problem/92497176>

Reviewed by Antti Koivisto.

Source/WebCore:

This patch makes sure that inline content run(s) ("X") followed by inline box end run(s) (</span></span>)
don't get separated when they overflow the line (e.g. width: 0px).

Test: fast/inline/overflowing-content-inside-inline-box.html

  • layout/formattingContexts/inline/InlineContentBreaker.cpp:

(WebCore::Layout::InlineContentBreaker::processOverflowingContent const):

LayoutTests:

  • fast/inline/overflowing-content-inside-inline-box-expected.html: Added.
  • fast/inline/overflowing-content-inside-inline-box.html: Added.
12:26 AM Changeset in webkit [293643] by jer.noble@apple.com
  • 3 edits in trunk/Source/ThirdParty/libwebrtc

[Mac] VTVideoDecoderClass object pointers can become unaligned on x86
​https://bugs.webkit.org/show_bug.cgi?id=239916
<rdar://92445366>

Reviewed by Eric Carlson.

Both the base class and the derived class must be 4-byte aligned on x86, or there
is a chance that a pointer member of that struct will cross a page boundary, and
dereferencing that pointer will fail.

  • Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
  • Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:

Apr 29, 2022:

11:07 PM Changeset in webkit [293642] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r290770): element.scrollIntoViewIfNeeded() scrolls to top even when element is already in viewport
​https://bugs.webkit.org/show_bug.cgi?id=238985

Patch by Rob Buis <​rbuis@igalia.com> on 2022-04-29
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/css/cssom-view/scrollintoview-zero-height-item-expected.txt: Added.
  • web-platform-tests/css/cssom-view/scrollintoview-zero-height-item.html: Added.

Source/WebCore:

This mostly reverts to the code as it was before r290770, but adds code to
treat non-intersections as hidden, including zero width/height rects.

Test: imported/w3c/web-platform-tests/css/cssom-view/scrollintoview-zero-height-item.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::getRectToExpose const):

8:37 PM Changeset in webkit [293641] by don.olmstead@sony.com
  • 2 edits in trunk/Source/WebCore

The isYahooMail quirk is specific to PLATFORM(IOS_FAMILY)
​https://bugs.webkit.org/show_bug.cgi?id=239914

Reviewed by Simon Fraser.

The isYahooMail check is incorrectly guarded by ENABLE(PUBLIC_SUFFIX_LIST) when the only
using this function is guarded by ENABLE(IOS_TOUCH_EVENTS) and PLATFORM(IOS_FAMILY). Use
PLATFORM(IOS_FAMILY) since ENABLE(IOS_TOUCH_EVENTS) implies that anyways.

Fixes an unused function warning for other ports.

  • page/Quirks.cpp:
6:37 PM Changeset in webkit [293640] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[ Monterey WK2 ] media/media-source/media-source-webm-vorbis-partial.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=239308
rdar://91719356

Patch by Jean-Yves Avenard <​jean-yves.avenard@apple.com> on 2022-04-29
Reviewed by Jer Noble.

The test disabled the GPU process, and sandboxing rules prevent from
calling CoreMedia in the content process.

  • media/media-source/media-source-webm-vorbis-partial.html:

# Please populate the above commit message. Lines starting
# with '#' will be ignored

# Reviewed by Jer Noble.

# On branch 239308
# Your branch is ahead of 'origin/main' by 1 commit.
# (use "git push" to publish your local commits)
#
# Changes to be committed:
# (use "git restore --staged <file>..." to unstage)
# modified: LayoutTests/ChangeLog
#

Canonical link: ​https://commits.webkit.org/250144@main

5:47 PM Changeset in webkit [293639] by Chris Dumez
  • 12 edits in trunk

Unreviewed, reverting r293621.

Reverting patch while we fix internal EWS issues, will reland
Source/JavaScriptCore:

after.

Reverted changeset:

​https://commits.webkit.org/r293621

Source/WTF:

after

Reverted changeset:

​https://commits.webkit.org/r293621

Tools:

after

Reverted changeset:

​https://commits.webkit.org/r293621

5:18 PM Changeset in webkit [293638] by Wenson Hsieh
  • 4 edits in trunk

[Mail compose] Images with data URLs should be pasted or dropped as attachments
​https://bugs.webkit.org/show_bug.cgi?id=239911
rdar://91658665

Reviewed by Tim Horton.

Source/WebCore:

Effectively revert the changes in r226340, which prevented data-URL and http-family-URL images from being
converted into attachments when pasting or dropping into Mail compose. The original intent behind this change
may have been to save Mail storage space (in the server and in the on-disk cache) by excluding remote images,
but this was changed in r291261 due to being a regression in behavior compared to legacy WebKit compose
behavior, which creates attachments when pasting or dropping both data and remote images.

Furthermore, the space-saving rationale never really made sense for image data URLs, which are encoded in base
64, since this base 64 representation is always going to be larger than the raw binary representation that we
would otherwise use for a normal attachment.

Test: WKAttachmentTests.InsertDataURLImagesAsAttachments

  • editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::shouldReplaceSubresourceURLWithBlobDuringSanitization):

Remove the argument flag enum altogether, and rename this method to clarify that it is just about blob URL
replacement for sanitizing pasted/dropped fragments (rather than attachment replacement).

(WebCore::replaceRichContentWithAttachments):
(WebCore::sanitizeMarkupWithArchive):
(WebCore::WebContentReader::readHTML):
(WebCore::WebContentMarkupReader::readHTML):
(WebCore::shouldReplaceSubresourceURL): Deleted.

Tools:

Adjust expectations for an existing API test.

  • TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::TEST):

4:23 PM Changeset in webkit [293637] by Chris Dumez
  • 16 edits in trunk/Source

Reduce usage of std::unique_ptr<HashSet> / std::unique_ptr<HashMap>
​https://bugs.webkit.org/show_bug.cgi?id=239903

Reviewed by Yusuke Suzuki.

Reduce usage of std::unique_ptr<HashSet> / std::unique_ptr<HashMap> as HashSet / HashMap
are already essentially pointers. This avoids some unnecessary dereferencing.

  • Source/JavaScriptCore/heap/Heap.cpp:

(JSC::Heap::addCoreConstraints):

  • Source/JavaScriptCore/heap/Heap.h:
  • Source/JavaScriptCore/heap/HeapInlines.h:
  • Source/WebKit/WebProcess/WebCoreSupport/WebPasteboardOverrides.cpp:

(WebKit::WebPasteboardOverrides::addOverride):
(WebKit::WebPasteboardOverrides::removeOverride):
(WebKit::WebPasteboardOverrides::overriddenTypes):
(WebKit::WebPasteboardOverrides::getDataForOverride const):

  • Source/WebKit/WebProcess/WebCoreSupport/WebPasteboardOverrides.h:
  • Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::creatingDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::doneDeletingDatabase):
(WebCore::DatabaseTracker::isDeletingDatabase):
(WebCore::DatabaseTracker::canDeleteOrigin):

  • Source/WebCore/Modules/webdatabase/DatabaseTracker.h:
  • Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::wrapForDeprecatedCSSOM):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::didMutate):

  • Source/WebCore/css/PropertySetCSSStyleDeclaration.h:
  • Source/WebCore/dom/MutationObserver.cpp:

(WebCore::MutationObserver::deliver):

  • Source/WebCore/dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::takeTransientRegistrations):
(WebCore::MutationObserverRegistration::isReachableFromOpaqueRoots const):

  • Source/WebCore/dom/MutationObserverRegistration.h:

(WebCore::MutationObserverRegistration::hasTransientRegistrations const):

  • Source/WebCore/platform/graphics/GlyphMetricsMap.h:

(WebCore::GlyphMetricsMap<T>::locatePageSlowCase):

  • Source/WebCore/rendering/RenderBlock.cpp:

(WebCore::insertIntoTrackedRendererMaps):
(WebCore::removeFromTrackedRendererMaps):
(WebCore::removeBlockFromPercentageDescendantAndContainerMaps):

  • Source/WebCore/style/StyleScope.cpp:

(WebCore::Style::Scope::updateActiveStyleSheets):
(WebCore::Style::Scope::activeStyleSheetsContains const):

  • Source/WebCore/style/StyleScope.h:

Canonical link: ​https://commits.webkit.org/250141@main

4:15 PM Changeset in webkit [293636] by Chris Dumez
  • 7 edits in trunk/Source/WebKit

[GPUProcess] Stop using a synchronous IPC for marking layers as volatile
​https://bugs.webkit.org/show_bug.cgi?id=239901
<rdar://91663593>

Reviewed by Geoffrey Garen.

Stop using a synchronous IPC to the GPUProcess for marking layers as volatile. Instead,
use an asynchronous IPC for the request and another asynchronous one for the response.
Ideally, we'd be using a sendWithAsyncReply(), like the FIXME comment in the code
suggested. However, this is not supported yet by our new "streaming" IPC.

  • Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::markSurfacesVolatile):

  • Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
  • Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
  • Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::~RemoteRenderingBackendProxy):
(WebKit::RemoteRenderingBackendProxy::markSurfacesVolatile):
(WebKit::RemoteRenderingBackendProxy::didMarkLayersAsVolatile):

  • Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
  • Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in:
  • Source/WebKit/WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::tryMarkLayersVolatileCompletionHandler):

Canonical link: ​https://commits.webkit.org/250140@main

3:54 PM Changeset in webkit [293635] by Devin Rousso
  • 2 edits in trunk/Source/WebCore

increase transient activation duration to 5s
​https://bugs.webkit.org/show_bug.cgi?id=239832

Reviewed by Geoffrey Garen.

This matches other user agents and gives a bit more time for asynchronous work to be done.

Spec: <​https://html.spec.whatwg.org/multipage/interaction.html#transient-activation-duration>

  • page/DOMWindow.cpp:
3:40 PM Changeset in webkit [293634] by Alan Coon
  • 19 edits in branches/safari-613-branch/Source

Cherry-pick r287877. rdar://problem/92357915

Non-unified build fixes, early January 2022 edition
​https://bugs.webkit.org/show_bug.cgi?id=235013

Unreviewed non-unified build fixes.

Source/JavaScriptCore:

  • wasm/js/JSWebAssemblyModule.cpp: Add missing JSWebAssemblyLinkError.h header.
  • wasm/js/JSWebAssemblyModule.h: Add missing forward declaration for the JSC::OptimizingCallLinkInfo type.

Source/WebCore:

No new tests needed.

  • Modules/fetch/FetchBodyConsumer.cpp: Add missing FormData.h header.
  • Modules/fetch/FormDataConsumer.h: Add missing ExceptionOr.h header, and forward declaration for the WebCore::ScriptExecutionContext type.
  • animation/CSSAnimation.cpp: Add missing KeyframeEffect.h header.
  • animation/KeyframeEffect.cpp: Add missing StyledElement.h header.
  • html/HTMLFormElement.cpp: Add missing PseudoClassChangeInvalidation.h header.
  • platform/network/SynchronousLoaderClient.cpp: Add missing SharedBuffer.h header.
  • rendering/svg/RenderSVGBlock.cpp: Add missing SVGRenderSupport.h header.
  • rendering/svg/RenderSVGForeignObject.cpp: Ditto.
  • rendering/svg/RenderSVGInline.cpp: Ditto.
  • rendering/svg/RenderSVGModelObject.cpp: Add missing SVGElementInlines.h header.
  • rendering/svg/SVGInlineTextBox.cpp: Add missing FloatConversion.h header.
  • svg/SVGViewElement.cpp: Add missing RenderElement.h header.
  • workers/service/context/ServiceWorkerFetch.h: Add missing forward declaration for the WebCore::SharedBuffer type, remove unused one for WebCore::FragmentedSharedBuffer.

Source/WebKit:

  • Platform/IPC/SharedBufferCopy.cpp: Add missing WebCoreArgumentCoders.h header, remove now unneeded ArgumentCoders.h header.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@287877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:40 PM Changeset in webkit [293633] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Unreviewed, reverting r293481.
​https://bugs.webkit.org/show_bug.cgi?id=239908

Introduced perf regression

Reverted changeset:

"Adjust what we consider to be private relayed"
​https://bugs.webkit.org/show_bug.cgi?id=239784
​https://commits.webkit.org/r293481

3:26 PM Changeset in webkit [293632] by Russell Epstein
  • 1 copy in tags/WebKit-7614.1.11.1

Tag WebKit-7614.1.11.1.

2:50 PM Changeset in webkit [293631] by Patrick Angle
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Regression(r267038) Import a timeline does not render the timeline, only lists the events
​https://bugs.webkit.org/show_bug.cgi?id=239872

Reviewed by Devin Rousso.

Two issues existed after r267038 that prevented the timeline overview from rendering correctly for imported
recordings. The first is that the timeline view itself was not visible as the result of assuming that we would
already be in middle of layout when inside WI.TimelineRecordingContentView.prototype._updateTimes, which isn't
true for the updating of times when importing a recording. In that case, syncronously attempting to lay out the
view means that the layout, including initial layout, will be performed before the view is attached, which means
we are unable to get the clientWidth of the view's element during layout, which in turn prevents us from
painting the timeline ruler.

The second issue is that when importing a timeline, we should ignore the current capturing state when setting
the current, start, and end times, otherwise not all the values will be kept.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):
(WI.TimelineRecordingContentView.prototype._updateTimes):

2:38 PM Changeset in webkit [293630] by Alan Coon
  • 2 edits in trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy

Corrected spelling of edited in webkitscmpy.

1:05 PM Changeset in webkit [293629] by ysuzuki@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

[JSC] Use FixedVector in JumpReplacements and VariableEventStream
​https://bugs.webkit.org/show_bug.cgi?id=239892

Reviewed by Mark Lam.

  1. Introduce DFG::VariableEventStreamBuilder. And construct DFG::VariableEventStream from that

builder when finailizing code generation. We also make it FixedVector.

  1. Use FixedVector for JumpReplacements.
  • Source/JavaScriptCore/dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::shrinkToFit):

  • Source/JavaScriptCore/dfg/DFGCommonData.h:
  • Source/JavaScriptCore/dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::noticeOSRBirth):
(JSC::DFG::GenerationInfo::use):
(JSC::DFG::GenerationInfo::spill):
(JSC::DFG::GenerationInfo::setSpilled):
(JSC::DFG::GenerationInfo::fillGPR):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillInt32):
(JSC::DFG::GenerationInfo::fillInt52):
(JSC::DFG::GenerationInfo::fillStrictInt52):
(JSC::DFG::GenerationInfo::fillBoolean):
(JSC::DFG::GenerationInfo::fillDouble):
(JSC::DFG::GenerationInfo::fillStorage):
(JSC::DFG::GenerationInfo::appendBirth):
(JSC::DFG::GenerationInfo::appendFill):
(JSC::DFG::GenerationInfo::appendSpill):

  • Source/JavaScriptCore/dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::shrinkToFit):
(JSC::DFG::JITCode::reconstruct):

  • Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::exceptionCheck):

  • Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:

(JSC::DFG::SlowPathGenerator::SlowPathGenerator):

  • Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::emitInvalidationPoint):
(JSC::DFG::SpeculativeJIT::addSlowPathGeneratorLambda):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::compileDeleteById):
(JSC::DFG::SpeculativeJIT::compileDeleteByVal):
(JSC::DFG::SpeculativeJIT::compileInById):
(JSC::DFG::SpeculativeJIT::compileInByVal):
(JSC::DFG::SpeculativeJIT::compileHasPrivate):
(JSC::DFG::SpeculativeJIT::noticeOSRBirth):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::compilePutByVal):

  • Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::finalizeEventStream):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::recordSetLocal):

  • Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileGetByVal):

  • Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::fillSpeculateBigInt32):
(JSC::DFG::SpeculativeJIT::compileGetByVal):
(JSC::DFG::SpeculativeJIT::compile):

  • Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStreamBuilder::logEvent):
(JSC::DFG::VariableEventStream::reconstruct const):
(JSC::DFG::VariableEventStream::logEvent): Deleted.

  • Source/JavaScriptCore/dfg/DFGVariableEventStream.h:

(JSC::DFG::VariableEventStream::VariableEventStream):
(JSC::DFG::VariableEventStreamBuilder::appendAndLog):
(JSC::DFG::VariableEventStreamBuilder::size const):
(JSC::DFG::VariableEventStreamBuilder::finalize):
(JSC::DFG::VariableEventStream::appendAndLog): Deleted.

  • Source/JavaScriptCore/ftl/FTLLink.cpp:

(JSC::FTL::link):

  • Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

  • Source/JavaScriptCore/ftl/FTLState.h:

Canonical link: ​https://commits.webkit.org/250135@main

12:41 PM Changeset in webkit [293628] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Unreviewed, reverting r293591.
​https://bugs.webkit.org/show_bug.cgi?id=239907

Did not resolve perf issue

Reverted changeset:

"Set top origin of CORS preflight requests"
​https://bugs.webkit.org/show_bug.cgi?id=239869
​https://commits.webkit.org/r293591

12:41 PM Changeset in webkit [293627] by Chris Dumez
  • 9 edits in trunk/Source

Update toExistingAtomString() to return an AtomString
​https://bugs.webkit.org/show_bug.cgi?id=239904

Reviewed by Darin Adler.

Update toExistingAtomString() to return an AtomString instead of a RefPtr<AtomStringImpl>
as it is a bit less awkward to use.

  • Source/JavaScriptCore/dfg/DFGOperations.cpp:

(JSC::DFG::JSC_DEFINE_JIT_OPERATION):

  • Source/JavaScriptCore/jit/JITOperations.cpp:

(JSC::getByVal):
(JSC::JSC_DEFINE_JIT_OPERATION):

  • Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

  • Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:

(JSC::JSC_DEFINE_COMMON_SLOW_PATH):

  • Source/JavaScriptCore/runtime/JSString.h:

(JSC::JSString::toExistingAtomString const):

  • Source/WTF/wtf/text/StringView.h:

(WTF::StringView::toExistingAtomString const):

  • Source/WebCore/bindings/js/JSDOMConvertStrings.h:

(WebCore::Converter<IDLRequiresExistingAtomStringAdaptor<T>>::convert):

  • Source/WebCore/dom/TreeScope.cpp:

(WebCore::TreeScope::getElementById const):

  • Source/WebCore/platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::loadResourceSynchronously):

Canonical link: ​https://commits.webkit.org/250133@main

12:25 PM Changeset in webkit [293626] by Simon Fraser
  • 2 edits in trunk/Tools

REGRESSION (249864@main): [ iOS ] TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrunkUI is failing
​https://bugs.webkit.org/show_bug.cgi?id=239867

Reviewed by Sam Weinig.

Use values that are representative of iPhone 8, which is the model used for running
API tests.

  • TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:

(TestWebKitAPI::TEST):

11:55 AM Changeset in webkit [293625] by yurys@chromium.org
  • 20 edits
    2 adds in trunk

Format time zone name using ICU instead of platform calls
​https://bugs.webkit.org/show_bug.cgi?id=239865

Reviewed by Yusuke Suzuki.

JSTests:

Added new tests that ensure Date's timezone is formatted using preferred
language.

  • complex.yaml:
  • complex/timezone-format-de.js: Added.

(shouldBe):

  • complex/timezone-format-en.js: Added.

(shouldBe):

Source/JavaScriptCore:

formatDateTime now uses cached display name of the timezone.

  • runtime/DateConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • runtime/DateConversion.cpp:

(JSC::formatDateTime):

  • runtime/DateConversion.h:
  • runtime/DatePrototype.cpp:

(JSC::formateDateInstance):

  • runtime/JSDateMath.cpp:

(JSC::toICUTimeZone): Encapsulate bitwise_cast into typesafe functions.
(JSC::toOpaqueICUTimeZone):
(JSC::OpaqueICUTimeZoneDeleter::operator()):
(JSC::DateCache::calculateLocalTimeOffset):
(JSC::DateCache::defaultTimeZone):
(JSC::DateCache::timeZoneDisplayName): Both standard and daylight names are computed
once on the first access as ICU methods internally acquire locks.
(JSC::DateCache::timeZoneCacheSlow):
(JSC::DateCache::resetIfNecessary):

  • runtime/JSDateMath.h:

LayoutTests:

Rebased existing layout tests to reflect new format (which is the same as in other
browsers now).

  • storage/indexeddb/modern/date-basic-expected.txt:
  • storage/indexeddb/modern/date-basic-private-expected.txt:
  • storage/indexeddb/modern/get-keyrange-expected.txt:
  • storage/indexeddb/modern/get-keyrange-private-expected.txt:
  • storage/indexeddb/modern/idbobjectstore-delete-1-expected.txt:
  • storage/indexeddb/modern/idbobjectstore-delete-1-private-expected.txt:
11:13 AM Changeset in webkit [293624] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r291998): [GTK] test accessibility/gtk/menu-list-unfocused-notifications.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=239888

Change the delay between changes to the combobox value to 1ms to ensure that an
accessibility event is consistently generated for both changes.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-04-29
Reviewed by Martin Robinson.

  • accessibility/gtk/menu-list-unfocused-notifications.html:
11:11 AM Changeset in webkit [293623] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, remove unused variable
​https://bugs.webkit.org/show_bug.cgi?id=239828

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

11:08 AM Changeset in webkit [293622] by Oriol Brufau
  • 5 edits in trunk/Source/WebCore

[css-cascade] Sort shorthand properties at the end of CSSPropertyID enum
​https://bugs.webkit.org/show_bug.cgi?id=238888

Reviewed by Darin Adler.

Only longhands should matter during the CSS Cascade, so by sorting
shorthands at the end, and ignoring them, we can save some memory and
avoid some iterations.

No test since now there should be no observable change in behavior.

  • css/StylePropertyShorthand.cpp:

(WebCore::isShorthandCSSProperty): Deleted.

  • css/StylePropertyShorthand.h:

(WebCore::isShorthandCSSProperty):
Turn function into a simple constexpr comparison.

  • css/makeprop.pl:

(addProperty):
(sortByDescendingPriorityAndName):
Sort shorthand properties at the end.

  • style/PropertyCascade.h:

Update comment.

10:47 AM Changeset in webkit [293621] by Chris Dumez
  • 9 edits in trunk

Drop StringImpl::createFromLiteral()
​https://bugs.webkit.org/show_bug.cgi?id=239792

Reviewed by Darin Adler.

Drop StringImpl::createFromLiteral().

Call sites that have an ASCIILiteral can now simply call StringImpl::create(ASCIILiteral).
Call sites that have raw characters can call the existing StringImpl::createWithoutCopying().

This simplifies our API a bit.

Also inline part of the createWithoutCopying() functions so that the 0-length check is
inline. This allows the compiler to optimize the check out when the length is known at
compile time (which is often the case with literals).

  • Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::TEST):

  • Source/JavaScriptCore/API/JSScriptRef.cpp:
  • Source/JavaScriptCore/Scripts/wkbuiltins/builtins_templates.py:
  • Source/JavaScriptCore/builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::BuiltinExecutables):

  • Source/JavaScriptCore/runtime/IntlObject.cpp:

(JSC::availableUnits):

  • Source/WTF/wtf/text/StringImpl.cpp:

(WTF::StringImpl::createWithoutCopyingNonEmpty):
(WTF::StringImpl::createFromLiteral): Deleted.
(WTF::StringImpl::createWithoutCopying): Deleted.

  • Source/WTF/wtf/text/StringImpl.h:

(WTF::StringImpl::create):
(WTF::StringImpl::createWithoutCopying):
(WTF::StringImpl::createFromLiteral): Deleted.

  • Source/WTF/wtf/text/WTFString.h:

(WTF::String::String):

Canonical link: ​https://commits.webkit.org/250127@main

10:40 AM Changeset in webkit [293620] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r290548) [GTK][WPE] test LayoutTests/fast/events/node-event-anchor-lock.html fails
​https://bugs.webkit.org/show_bug.cgi?id=239890

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-04-29
Reviewed by Martin Robinson.

  • fast/events/node-event-anchor-lock.html: Disable scroll animation for this test.
9:36 AM Changeset in webkit [293619] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

REGRESSION(r293608): [GTK][WPE] Broke clang builds
​https://bugs.webkit.org/show_bug.cgi?id=239899

Patch by Philippe Normand <​pnormand@igalia.com> on 2022-04-29
Reviewed by Michael Catanzaro.

  • wtf/StdLibExtras.h: Restrict std::remove_cvref hacks to GCC.

Canonical link: ​https://commits.webkit.org/250125@main

9:26 AM Changeset in webkit [293618] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Video on twitch.tv shifts to top of screen when toggling playback in fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=239884
<rdar://92367060>

Reviewed by Eric Carlson.

Twitch will cause the HTMLMediaElement to recreate the MediaPlayer when resuming playback
after pausing. If this happens in fullscreen, VideoLayerManagerObjC::setVideoLayer() will
be called with the new video layer, however it will be laid out pinned to the top-left
corner of the screen (rather than centered), as setVideoLayer() will call -setFrame with
an explicit 0,0 position argument.

Rather than pin the layer to the top-left, use the full value of m_videoFullscreenFrame
when setting the video layer frame, both in setVideoLayer() as well as
setVideoFullscreenLayer().

Its currently impossible to write an test for this behavior, as TestWebKitAPI is not a UI
application, and therefore cannot enter fullscreen mode.

  • platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:

(WebCore::VideoLayerManagerObjC::setVideoLayer):
(WebCore::VideoLayerManagerObjC::setVideoFullscreenLayer):

8:59 AM Changeset in webkit [293617] by Wenson Hsieh
  • 2 edits in trunk

Unreviewed, add my GitHub account name to contributors.json

I also ran validate-committer-lists --canonicalize to fix up some minor style inconsistencies in this file
after some other recent additions.

  • metadata/contributors.json:
8:45 AM Changeset in webkit [293616] by jer.noble@apple.com
  • 2 edits in trunk

Unreviewed; add my github account to contributors.json.

  • metadata/contributors.json:
8:35 AM Changeset in webkit [293615] by Jonathan Bedard
  • 6 edits in trunk/Tools

[git-webkit] Redact bug title in branch name on alternate remotes
​https://bugs.webkit.org/show_bug.cgi?id=239826
<rdar://problem/92418512>

Rubber-stamped by Aakash Jain.

  • Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:

(Branch.main): Allow caller to redact bug title in branch name.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:

(PullRequest.pull_request_branch_point): Redact bug title in branch name
for non-origin remotes.

  • Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py:

(TestBranch.test_redacted):

Canonical link: ​https://commits.webkit.org/250121@main

8:24 AM Changeset in webkit [293614] by Jonathan Bedard
  • 2 edits in trunk/Tools

[ews-build.webkit.org] Link to PRs with undefined title
​https://bugs.webkit.org/show_bug.cgi?id=239820
<rdar://problem/92416554>

Reviewed by Aakash Jain.

  • CISupport/ews-build/steps.py:

(ConfigureBuild.add_pr_details):

Canonical link: ​https://commits.webkit.org/250120@main

8:11 AM Changeset in webkit [293613] by ntim@apple.com
  • 2 edits in trunk/Source/WebCore

Add background-clip: text to CSSProperties.json

Unreviewed fix.

  • css/CSSProperties.json:
7:31 AM Changeset in webkit [293612] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Fix ASAN build after "IPC testing API should have the ability to test IPC::Connection send and receive through IPC::Connection"
​https://bugs.webkit.org/show_bug.cgi?id=239894

Unreviewed build fix.
Add a return for function which does ASSERT_NOT_REACHED().

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-04-29

  • WebProcess/WebPage/IPCTestingAPI.cpp:

(WebKit::IPCTestingAPI::JSIPCConnection::didReceiveSyncMessage):

4:20 AM WebKitGTK/Debugging edited by Philippe Normand
(diff)
3:42 AM Changeset in webkit [293611] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK][WPE] media/video-with-alpha.html is failing and skipped
​https://bugs.webkit.org/show_bug.cgi?id=226484

Patch by Philippe Normand <​pnormand@igalia.com> on 2022-04-29
Unreviewed, gardening.

  • platform/glib/TestExpectations: The SDK ships GStreamer 1.20, mark

media/video-with-alpha.html as passing.

Canonical link: ​https://commits.webkit.org/250117@main

12:59 AM Changeset in webkit [293610] by Diego Pino Garcia
  • 6 edits in trunk/Source/WebKit

[macOS] Unreviewed, non-unified build fixes
​https://bugs.webkit.org/show_bug.cgi?id=239889

  • UIProcess/API/Cocoa/_WKDataTask.h:
  • UIProcess/API/Cocoa/_WKDataTask.mm:
  • UIProcess/API/Cocoa/_WKInspectorConfigurationInternal.h:
  • UIProcess/Cocoa/ModalContainerControlClassifier.h:
  • UIProcess/Cocoa/ModalContainerControlClassifier.mm:
12:57 AM Changeset in webkit [293609] by youenn@apple.com
  • 4 edits
    2 adds in trunk

HTMLMediaElement can get multiple interruptions for invisible autoplay
​https://bugs.webkit.org/show_bug.cgi?id=239842
<rdar://91809550>

Reviewed by Eric Carlson.

Source/WebCore:

A media element may be interrupted for invisible autoplay.
In some cases, like by calling play on the media element, the media element will no longer be in interrupted state.
This will lead to multiple invisible autoplay interruptions to be added to the same media element.
There will be only one end of interruption for invisible autoplay, which will lead to the media element to not restart as expected.

To prevent this, we store a boolean in HTMLMediaElement that tells us whether the media element has an ongoing invisible autoplay interruption.
Based on that, we make sure to always balance invisible autoplay interruption begin and end.

Test: media/video-mediastream-restricted-invisible-autoplay-not-allowed.html

  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:

LayoutTests:

  • fast/mediastream/video-mediastream-restricted-invisible-autoplay-not-allowed-expected.txt: Added.
  • fast/mediastream/video-mediastream-restricted-invisible-autoplay-not-allowed.html: Added.
12:50 AM Changeset in webkit [293608] by Diego Pino Garcia
  • 5 edits in trunk

[GCC] std::remove_cvref is undefined in GCC8.4
​https://bugs.webkit.org/show_bug.cgi?id=239881

Reviewed by Žan Doberšek.

r293505 changed the guard that added std::remove_cvref if not defined
by GCC, checking cplusplus <= 201703L.

However in Ubuntu GCC8.4 this flag's value is 201709L. Thus, the
evaluation of this flag cannot reliably determine whether the compiler
has to define std::remove_cvref or not.

Instead of relying on a predefined compiler flag, what the patch does is
to attempt to compile a small snippet of code to check whether std::remove_cvref
is supported by the compiler. If successful, the flag 'HAVE_STD_REMOVE_CVREF' is defined.

.:

  • Source/cmake/OptionsCommon.cmake: Set and expose HAVE_STD_REMOVE_CVREF if needed.
  • Source/cmake/WebKitCompilerFlags.cmake: Check whether GCC supports std::remove_cvref.

Source/WTF:

  • wtf/StdLibExtras.h: Define std::remove_cvref if not defined by GCC.
12:14 AM Changeset in webkit [293607] by youenn@apple.com
  • 4 edits in trunk

Make sure to fail importScripts as per ​https://w3c.github.io/ServiceWorker/#importscripts step 4
​https://bugs.webkit.org/show_bug.cgi?id=239847

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/import-scripts-updated-flag.https-expected.txt:

Source/WebCore:

Once a service worker is installed, the service worker should not be able to call importScript on new URLs.
Covered by updated test.

  • workers/WorkerScriptLoader.cpp:
Note: See TracTimeline for information about the timeline view.