Context Navigation

← Previous Period
Next Period →

Timeline

May 2, 2022:

11:11 PM Changeset in webkit [293717] by youenn@apple.com

5 edits in trunk

URL.createObjectURL should not be exposed in service worker contexts
https://bugs.webkit.org/show_bug.cgi?id=239972

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/interface-requirements-sw.https-expected.txt:

Source/WebCore:

Covered by rebased test.

bindings/scripts/CodeGeneratorJS.pm:

Add support for DedicatedWorker and SharedWorker in binding generator for function scope expsure.
(GenerateRuntimeEnableConditionalStringForExposeScope):

html/DOMURL.idl:

Update WebIDL as per spec.

10:26 PM Changeset in webkit [293716] by timothy_horton@apple.com

2 edits
2 adds in trunk/Source/WebKit

REGRESSION (r292351): Processes no longer get the right jetsam priority on iOS
https://bugs.webkit.org/show_bug.cgi?id=239992
<rdar://problem/92644672>

Reviewed by Chris Dumez.

FeatureFlags/WebKit.plist: Added.
WebKit.xcodeproj/project.pbxproj:

Temporarily reinstate RB_full_manage_WK_jetsam, since it is being
read by a different project.

10:19 PM Changeset in webkit [293715] by Robert Jenner

2 edits in trunk/LayoutTests

[ Monterey wk1 GuardMalloc ] fast/borders/hidpi-3x-input-hairline-border.html is timing out
<rdar://problem/81996454>

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/250204@main

10:07 PM Changeset in webkit [293714] by ysuzuki@apple.com

23 edits
1 add in trunk

[JSC] Introduce unlinked version of invalidation
https://bugs.webkit.org/show_bug.cgi?id=239887

Reviewed by Saam Barati.

This patch makes invalidation mechanism unlinked for unlinked DFG.

We always use CheckTraps instead of InvalidationPoint with VMTraps so that we do not need

to repatch existing code.

We introduce load-and-branch based InvalidationPoint for unlinked DFG so that we do not need

to repatch it to jump to OSR exit when watchpoint fires. We store this condition in DFG::JITData
so that code can quickly access to that.

We make isStillValid conditions in DFG::CommonData always true for unlinked DFG code. Instead,

we check isJettisoned() condition of CodeBlock since it will become eventually per CodeBlock
information (while this CodeBlock gets invalidated, unlinked DFG code itself can be used for
the other CodeBlock).

After this change, now, jumpReplacements for unlinked DFG becomes empty. We no longer repatch these invalidation points.

Source/JavaScriptCore/bytecode/CodeBlock.cpp:

(JSC::CodeBlock::jettison):
(JSC::CodeBlock::hasInstalledVMTrapsBreakpoints const):
(JSC::CodeBlock::canInstallVMTrapBreakpoints const):
(JSC::CodeBlock::installVMTrapBreakpoints):
(JSC::CodeBlock::hasInstalledVMTrapBreakpoints const): Deleted.

Source/JavaScriptCore/bytecode/CodeBlock.h:
Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

Source/JavaScriptCore/dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::invalidate):
(JSC::DFG::CommonData::~CommonData):
(JSC::DFG::CommonData::installVMTrapBreakpoints):
(JSC::DFG::CommonData::isVMTrapBreakpoint):

Source/JavaScriptCore/dfg/DFGCommonData.h:

(JSC::DFG::CommonData::CommonData):
(JSC::DFG::CommonData::hasInstalledVMTrapsBreakpoints const):
(JSC::DFG::CommonData::isStillValid const):

Source/JavaScriptCore/dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

Source/JavaScriptCore/dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::JITCode):

Source/JavaScriptCore/dfg/DFGJITCode.h:
Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

Source/JavaScriptCore/dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):
(JSC::DFG::prepareCatchOSREntry):

Source/JavaScriptCore/dfg/DFGPlan.cpp:

(JSC::DFG::Plan::finalize):

Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInvalidationPoint):
(JSC::DFG::SpeculativeJIT::compileCheckTraps):
(JSC::DFG::SpeculativeJIT::emitInvalidationPoint): Deleted.

Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:
Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Source/JavaScriptCore/ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::JITCode):

Source/JavaScriptCore/ftl/FTLJITCode.h:

(JSC::FTL::JITCode::isUnlinked const):

Source/JavaScriptCore/ftl/FTLOSREntry.cpp:

(JSC::FTL::prepareOSREntry):

Source/JavaScriptCore/jit/JITCode.cpp:

(JSC::JITCode::isUnlinked const):

Source/JavaScriptCore/jit/JITCode.h:
Source/JavaScriptCore/runtime/VMTraps.cpp:

(JSC::VMTraps::tryInstallTrapBreakpoints):
(JSC::VMTraps::handleTraps):

Canonical link: https://commits.webkit.org/250203@main

9:38 PM Changeset in webkit [293713] by Robert Jenner

2 edits in trunk/LayoutTests

[ iOS macOS wk2 ]compositing/video/video-bo rder-radius-clipping.html is a flakey image failure
https://bugs.webkit.org/show_bug.cgi?id=224690

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/250202@main

9:15 PM Changeset in webkit [293712] by Robert Jenner

2 edits in trunk/LayoutTests

[ iOS macOS wk2 ]compositing/video/video-bo rder-radius-clipping.html is a flakey image failure
https://bugs.webkit.org/show_bug.cgi?id=224690

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/250201@main

8:43 PM Changeset in webkit [293711] by Yijia Huang

2 edits in trunk

Update yijia's info in constributors
https://bugs.webkit.org/show_bug.cgi?id=239994

Unreviewed.

metadata/contributors.json:

8:02 PM Changeset in webkit [293710] by ysuzuki@apple.com

15 edits in trunk/Source/JavaScriptCore

[JSC] Introduce shifting Structure encoding
https://bugs.webkit.org/show_bug.cgi?id=239957

Reviewed by Mark Lam.

For platforms which have limited amount of virtual address space (<= 36 bits), this patch introduces
shifting Structure encoding. We align Structure on a 32-bytes boundary instead of 16 bytes so that
we can ensure that lower 5 bits are zero. Then, we can use 1 bit for nuke, and shifting 4 bits to
convert 36 bit address to 32 bit StructureID. By using this mechanism, we do not need to allocate
large virtual address space for these platforms. If we an address can have more than 36 bits, then
we should just reserve a larger address region since we have enough address space. Current Structure
size is 112 bytes, which is 3.5 atoms at 32 bytes / atom. Hence, this alignment costs us 16 bytes per
Structure.
Relanding with debug build failure & crash on static atomSize assumption in IsoSubspace.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

heap/Heap.cpp:
heap/IsoSubspace.h:

(JSC::GCClient::IsoSubspace::allocatorFor):

heap/IsoSubspaceInlines.h:

(JSC::GCClient::IsoSubspace::allocate):

heap/StructureAlignedMemoryAllocator.cpp:

(JSC::StructureMemoryManager::StructureMemoryManager):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitNonNullDecodeStructureID):

llint/LLIntOfflineAsmConfig.h:
llint/LowLevelInterpreter64.asm:
runtime/JSCell.h:
runtime/JSCellInlines.h:

(JSC::JSCell::JSCell):

runtime/Structure.cpp:

(JSC::Structure::Structure):

runtime/Structure.h:
runtime/StructureID.h:

(JSC::StructureID::decode const):
(JSC::StructureID::tryDecode const):
(JSC::StructureID::encode):

tools/IntegrityInlines.h:

(JSC::Integrity::auditStructureID):

7:08 PM Changeset in webkit [293709] by Chris Dumez

1 edit in trunk/Tools/TestWebKitAPI/Tests/WTF/Ref.cpp

Add API tests for ref-counting churn in static_reference_cast<>()
https://bugs.webkit.org/show_bug.cgi?id=239987

Reviewed by Darin Adler.

Add API tests for ref-counting churn in static_reference_cast<>().
This covers the fix made in r293682.

Tools/TestWebKitAPI/Tests/WTF/Ref.cpp:

(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/250198@main

6:55 PM Changeset in webkit [293708] by ysuzuki@apple.com

8 edits in trunk

[JSC] Add ISO8601 based Temporal.PlainDate getters
https://bugs.webkit.org/show_bug.cgi?id=239949

Reviewed by Ross Kirsling and Dean Jackson.

This patch adds missing getters of Temporal.PlainDate. Currently, we are not querying to Calendar.
It will be wired once we bake Calendar completely.

JSTests/stress/temporal-plaindate.js:

(print):
(shouldBe):

Source/JavaScriptCore/runtime/ISO8601.cpp:

(JSC::ISO8601::dayOfWeek):
(JSC::ISO8601::dayOfYear):
(JSC::ISO8601::weekOfYear):
(JSC::ISO8601::daysInMonth):
(JSC::ISO8601::monthCode):

Source/JavaScriptCore/runtime/ISO8601.h:
Source/JavaScriptCore/runtime/TemporalPlainDate.cpp:

(JSC::TemporalPlainDate::from):
(JSC::TemporalPlainDate::monthCode const):
(JSC::TemporalPlainDate::dayOfWeek const):
(JSC::TemporalPlainDate::dayOfYear const):
(JSC::TemporalPlainDate::weekOfYear const):

Source/JavaScriptCore/runtime/TemporalPlainDate.h:
Source/JavaScriptCore/runtime/TemporalPlainDatePrototype.cpp:

(JSC::JSC_DEFINE_CUSTOM_GETTER):

Canonical link: https://commits.webkit.org/250197@main

6:32 PM Changeset in webkit [293707] by gnavamarino@apple.com

2 edits in trunk/Source/WebKit

Crash in WebKit::ModelElementController::modelElementCreateRemotePreview
https://bugs.webkit.org/show_bug.cgi?id=239985

Reviewed by Dean Jackson.

Add a check before using m_modelElementController, as it's not guaranteed
to be initialized in the constructor, and can be invalidated in WebPageProxy::resetState.

Test: fast/html/model-element-controller-crash.html

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::modelElementGetCamera):
(WebKit::WebPageProxy::modelElementSetCamera):
(WebKit::WebPageProxy::modelElementIsPlayingAnimation):
(WebKit::WebPageProxy::modelElementSetAnimationIsPlaying):
(WebKit::WebPageProxy::modelElementIsLoopingAnimation):
(WebKit::WebPageProxy::modelElementSetIsLoopingAnimation):
(WebKit::WebPageProxy::modelElementAnimationDuration):
(WebKit::WebPageProxy::modelElementAnimationCurrentTime):
(WebKit::WebPageProxy::modelElementSetAnimationCurrentTime):
(WebKit::WebPageProxy::modelElementHasAudio):
(WebKit::WebPageProxy::modelElementIsMuted):
(WebKit::WebPageProxy::modelElementSetIsMuted):
(WebKit::WebPageProxy::takeModelElementFullscreen):
(WebKit::WebPageProxy::modelElementSetInteractionEnabled):
(WebKit::WebPageProxy::modelElementCreateRemotePreview):
(WebKit::WebPageProxy::modelElementLoadRemotePreview):
(WebKit::WebPageProxy::modelElementDestroyRemotePreview):
(WebKit::WebPageProxy::modelElementSizeDidChange):
(WebKit::WebPageProxy::handleMouseDownForModelElement):
(WebKit::WebPageProxy::handleMouseMoveForModelElement):
(WebKit::WebPageProxy::handleMouseUpForModelElement):
(WebKit::WebPageProxy::modelInlinePreviewUUIDs):

5:59 PM Changeset in webkit [293706] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

WebInspector: Improve rendering of GLbitfield in WebGL canvas recordings.
https://bugs.webkit.org/show_bug.cgi?id=239589

Patch by Dan Glastonbury <djg@apple.com> on 2022-05-02
Reviewed by Devin Rousso.

UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.bitfieldNamesForParameter.test_and_clear_bit):
(WI.RecordingAction.bitfieldNamesForParameter): Split known
bitfields into an array of valid named representation for each
bit. Unknown bits are returned as hexadecimal formatted string.

UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._generateDOM.createParameterElement):
(WI.RecordingActionTreeElement._generateDOM): If param has a
non-null, array of strings, render the array as
context.FIELD1|context.FIELD2

Canonical link: https://commits.webkit.org/250195@main

5:55 PM Changeset in webkit [293705] by Alan Coon

1 copy in tags/WebKit-7613.2.7.0.7

Tag WebKit-7613.2.7.0.7.

5:53 PM Changeset in webkit [293704] by Alan Coon

1 copy in tags/WebKit-7613.2.7.1.8

Tag WebKit-7613.2.7.1.8.

5:37 PM Changeset in webkit [293703] by Chris Dumez

22 edits in trunk

Drop some unused StringImpl / AtomStringImpl / AtomString API
https://bugs.webkit.org/show_bug.cgi?id=239912

Reviewed by Yusuke Suzuki.

Simplifies our API a bit and encourages people to write more efficient
code.

Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WTF/StringOperators.cpp:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::TEST):

Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:

(TestWebKitAPI::TEST):

Source/JavaScriptCore/API/JSValue.mm:

(createStructHandlerMap):

Source/JavaScriptCore/runtime/CachedTypes.cpp:

(JSC::CachedUniquedStringImplBase::decode const):

Source/JavaScriptCore/runtime/Identifier.cpp:

(JSC::Identifier::addLiteral): Deleted.

Source/JavaScriptCore/runtime/Identifier.h:

(JSC::Identifier::Identifier):
(JSC::Identifier::add):

Source/JavaScriptCore/runtime/ObjectPrototype.cpp:

(JSC::inferBuiltinTag):
(JSC::objectPrototypeToString):

Source/JavaScriptCore/runtime/SmallStrings.cpp:

(JSC::SmallStrings::initializeCommonStrings):
(JSC::SmallStrings::initialize):

Source/JavaScriptCore/runtime/SmallStrings.h:
Source/WTF/wtf/text/AtomString.h:

(WTF::AtomString::AtomString):

Source/WTF/wtf/text/AtomStringImpl.cpp:

(WTF::CStringTranslator::hash): Deleted.
(WTF::CStringTranslator::equal): Deleted.
(WTF::CStringTranslator::translate): Deleted.

Source/WTF/wtf/text/AtomStringImpl.h:
Source/WTF/wtf/text/StringImpl.cpp:
Source/WTF/wtf/text/StringImpl.h:

(WTF::StringImpl::create):
(WTF::StringImpl::createFromCString):
(WTF::lengthOfNullTerminatedString): Deleted.

Source/WTF/wtf/text/WTFString.cpp:

(WTF::String::String):

Source/WTF/wtf/text/WTFString.h:
Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

Canonical link: https://commits.webkit.org/250194@main

5:04 PM Changeset in webkit [293702] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[ iOS ][ macOS ] css3/calc/transitions-dependent.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239990

Unreviewed test gardening.

LayoutTests/platform/ios-simulator/TestExpectations:
LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/250193@main

5:01 PM Changeset in webkit [293701] by Chris Dumez

31 edits in trunk/Source

Move starAtom() / xmlAtom() / xmlnsAtom() from WTF to WebCore https://bugs.webkit.org/show_bug.cgi?id=239969

Reviewed by Darin Adler.

Move starAtom() / xmlAtom() / xmlnsAtom() from WTF to WebCore since
they are not useful outside WebCore.

Source/WTF/wtf/text/AtomString.cpp:

(WTF::AtomString::init):

Source/WTF/wtf/text/AtomString.h:

(WTF::emptyAtom):
(WTF::starAtom): Deleted.
(WTF::xmlAtom): Deleted.
(WTF::xmlnsAtom): Deleted.

Source/WebCore/css/CSSPageRule.cpp:
Source/WebCore/css/CSSSelector.cpp:
Source/WebCore/css/CSSSelectorList.cpp:
Source/WebCore/css/SelectorChecker.cpp:
Source/WebCore/css/SelectorFilter.cpp:
Source/WebCore/css/StyleSheetContents.cpp:
Source/WebCore/css/parser/CSSSelectorParser.cpp:
Source/WebCore/cssjit/SelectorCompiler.cpp:
Source/WebCore/dom/Attr.cpp:
Source/WebCore/dom/Attribute.h:
Source/WebCore/dom/ContainerNode.cpp:
Source/WebCore/dom/Node.cpp:
Source/WebCore/dom/NodeRareData.h:
Source/WebCore/dom/QualifiedName.cpp:
Source/WebCore/dom/SelectorQuery.cpp:
Source/WebCore/dom/TagCollection.h:
Source/WebCore/editing/MarkupAccumulator.cpp:
Source/WebCore/html/LabelableElement.cpp:
Source/WebCore/html/LabelsNodeList.cpp:
Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
Source/WebCore/platform/CommonAtomStrings.h:
Source/WebCore/style/PageRuleCollector.cpp:
Source/WebCore/style/RuleData.cpp:
Source/WebCore/style/RuleFeature.h:
Source/WebCore/style/RuleSet.cpp:
Source/WebCore/xml/NativeXPathNSResolver.cpp:
Source/WebCore/xml/XPathStep.cpp:
Source/WebCore/xml/parser/XMLDocumentParser.cpp:
Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:

Canonical link: https://commits.webkit.org/250192@main

4:33 PM Changeset in webkit [293700] by Alan Bujtas

4 edits in trunk/Source/WebCore

[Quirks] REGRESSION (r286874): Menu is Cut Off After Pressing Search Icon on Hotels.com
https://bugs.webkit.org/show_bug.cgi?id=239980
<rdar://91992835>

Reviewed by Simon Fraser.

Disable resolution media query on www.hotels.com.

css/MediaQueryEvaluator.cpp:

(WebCore::resolutionEvaluate):

page/Quirks.cpp:

(WebCore::Quirks::shouldUseResolutionMedia const):

page/Quirks.h:

4:25 PM Changeset in webkit [293699] by Alan Coon

3 edits in branches/safari-613-branch/Source/WebKit

Apply patch. rdar://problem/92617943

4:11 PM Changeset in webkit [293698] by Alan Coon

3 edits in branches/safari-613.2.7.1-branch/Source/WebKit

Apply patch. rdar://problem/92617943

4:04 PM Changeset in webkit [293697] by achristensen@apple.com

3 edits in trunk/Source/WebKit

Revert all use of _setPrivacyProxyFailClosedForUnreachableNonMainHosts
https://bugs.webkit.org/show_bug.cgi?id=239977
<rdar://92617943>

Reviewed by John Wilander.

Due to what is likely confusion about internal integration processes,
the powers that be have decided that the best course of action for now
is to restore the status quo and accept any consequences that may entail.

NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::createWebSocketTask):

4:04 PM Changeset in webkit [293696] by Russell Epstein

1 copy in tags/WebKit-7614.1.11.5

Tag WebKit-7614.1.11.5.

4:01 PM Changeset in webkit [293695] by Alan Coon

9 edits in branches/safari-613.2.7.1-branch/Source

Versioning.

WebKit-7613.2.7.1.8

4:01 PM Changeset in webkit [293694] by Russell Epstein

9 edits in branches/safari-614.1.11-branch/Source

Versioning.

WebKit-7614.1.11.5

3:58 PM Changeset in webkit [293693] by ysuzuki@apple.com

2 edits in trunk/Source/JavaScriptCore

[JSC] Fix ASan crash due to CString ownership
https://bugs.webkit.org/show_bug.cgi?id=239981

Reviewed by Darin Adler and Mark Lam.

We need to ensure that CString is kept alive.

runtime/JSDateMath.cpp:

(JSC::DateCache::timeZoneDisplayName):

Canonical link: https://commits.webkit.org/250189@main

3:49 PM Changeset in webkit [293692] by Russell Epstein

3 edits in branches/safari-613.2.7.0-branch/Source/WebKit

Apply patch. rdar://problem/92617943

3:48 PM Changeset in webkit [293691] by achristensen@apple.com

8 edits in trunk/LayoutTests/imported/w3c

Update some wpt tests with control characters in cookies
https://bugs.webkit.org/show_bug.cgi?id=239966
<rdar://92300855>

Reviewed by Chris Dumez.

This reflects a change in https://github.com/httpwg/http-extensions/issues/1531

web-platform-tests/cookies/name/name-ctl-expected.txt:
web-platform-tests/cookies/name/name-ctl.html:
web-platform-tests/cookies/resources/cookie-test.js:
web-platform-tests/cookies/value/value-ctl-expected.txt:
web-platform-tests/cookies/value/value-ctl.html:
web-platform-tests/html/dom/documents/resource-metadata-management/document-cookie-expected.txt:
web-platform-tests/html/dom/documents/resource-metadata-management/document-cookie.html:

3:46 PM Changeset in webkit [293690] by Russell Epstein

9 edits in branches/safari-613.2.7.0-branch/Source

Versioning.

WebKit-7613.2.7.0.7

3:35 PM Changeset in webkit [293689] by Oriol Brufau

11 edits in trunk

[cssom] Don't index 'all' shorthand in computed styles
https://bugs.webkit.org/show_bug.cgi?id=239669

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update test expectations.

web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

Source/WebCore:

Computed styles should provide getters for both longhands and shorthands,
but only the former should be indexed.

However, the 'all' shorthand was being indexed as if it was a longhand.

Tests: imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html

imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html

css/makeprop.pl:

(skippedFromComputedStyle):

LayoutTests:

Update test expectations.

platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

3:33 PM Changeset in webkit [293688] by Justin Michaud

4 edits in trunk/Source

Add option to JSC shell to wait for a USR2 signal before exiting to aid in collection of vmmaps
https://bugs.webkit.org/show_bug.cgi?id=239919

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

jsc.cpp:

(main):

Source/WTF:

wtf/threads/Signals.h:

(WTF::toSystemSignal):

3:22 PM Changeset in webkit [293687] by Russell Epstein

1 copy in tags/WebKit-7614.1.11.4

Tag WebKit-7614.1.11.4.

3:19 PM Changeset in webkit [293686] by Russell Epstein

9 edits in branches/safari-614.1.11-branch/Source

Versioning.

WebKit-7614.1.11.4

2:56 PM Changeset in webkit [293685] by commit-queue@webkit.org

13 edits in trunk/Source/JavaScriptCore

Unreviewed, reverting r293680.
https://bugs.webkit.org/show_bug.cgi?id=239983

crash on iOS

Reverted changeset:

"[JSC] Introduce shifting Structure encoding"
https://bugs.webkit.org/show_bug.cgi?id=239957
https://commits.webkit.org/r293680

2:52 PM Changeset in webkit [293684] by Devin Rousso

4 edits
3 adds in trunk

[Modern Media Controls] REGRESSION(?) tapping a video to start playing for the first time doesn't start playing
https://bugs.webkit.org/show_bug.cgi?id=239918
<rdar://problem/91329117>

Reviewed by Jer Noble.

Source/WebCore:

This happens on iOS because the <video> has a GestureRecognizer that will attempt to
play(), and then the PlayPauseButton (which also has a GestureRecognizer) will attempt
to togglePlayback() (via PlaybackSupport), which will pause() because the <video> is
not paused.

When a <video> is play() for the first time, it may not actually start playing for a
moment (e.g. buffering) even though it will say it's paused.

Test: media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-shows-start-button.html

Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype.togglePlayback):
Also check hasPlayed to decide whether to play() or pause(), as it's set when the first
"play" event is handled, as until then we're still not playing yet and should play().

This could also be fixed in PlaybackSupport (and/or StartSupport), but doing it in
togglePlayback is a more general solution that fixes all present (and future) callsites.

LayoutTests:

media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-shows-start-button.html: Added.
media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-shows-start-button-expected.txt: Added.

TestExpectations:

2:18 PM Changeset in webkit [293683] by Chris Dumez

8 edits
1 add in trunk/Source/WebKit

Use a strongly typed identifier for requests to mark surfaces as volatile
https://bugs.webkit.org/show_bug.cgi?id=239974

Reviewed by Simon Fraser.

Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::markSurfacesVolatile):

Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
Source/WebKit/Scripts/webkit/messages.py:

(types_that_cannot_be_forward_declared):

Source/WebKit/Shared/MarkSurfacesAsVolatileRequestIdentifier.h: Added.
Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::markSurfacesVolatile):
(WebKit::RemoteRenderingBackendProxy::didMarkLayersAsVolatile):

Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in:

Canonical link: https://commits.webkit.org/250183@main

1:31 PM Changeset in webkit [293682] by Chris Dumez

1 edit in trunk/Source/WTF/wtf/Ref.h

static_reference_cast(const Ref<X, Y>&) causes unnecessary ref-counting churn
https://bugs.webkit.org/show_bug.cgi?id=239970

Reviewed by Geoffrey Garen.

This function was calling copyRef() to get a non-const Ref<> and then calling Ref::get() to construct a
new Ref<> of the destination type. The copyRef() would increase the ref count by 1, constructing the
new destination Ref<> would increase the ref count by 1 again and then the temporary Ref going out of
scope would decrease the ref count by one.

We now call static_reference_cast(Ref<X, Y>&&) with the result of the copyRef(), which will leak
the pointer from the Ref<> and adopt it in the destination Ref, thus avoiding unnecessary churn.

Also drop the static_reference_cast(Ref<X, Y>&) overload as it is no longer more efficient than the
static_reference_cast(const Ref<X, Y>&) one.

Source/WTF/wtf/Ref.h:

(WTF::static_reference_cast):

Canonical link: https://commits.webkit.org/250182@main

1:29 PM Changeset in webkit [293681] by Wenson Hsieh

10 edits
1 add in trunk

[macOS] The "Markup Image" services menu item should be gated on image analysis results
https://bugs.webkit.org/show_bug.cgi?id=239933
rdar://92348202

Reviewed by Kate Cheney.

Source/WebKit:

Adjust some macOS-specific logic for appending the "Markup Image" menu item in the services menu, such that we
only add this new item in the case where the relevant image analysis APIs come back with a valid cropped image
result. See below for more details.

Test: ImageAnalysisTests.MarkupImageItemInServicesMenu

UIProcess/WebContextMenuProxy.h:

(WebKit::WebContextMenuProxy::croppedImageResult const):

Move m_croppedImageForContextMenu into WebContextMenuProxyMac as m_croppedImageResult, so that it can be
easily used for both the new "Copy Cropped Image" and "Markup Image" items. This also allows us to simplify some
logic for resetting this cached image result since the whole m_activeContextMenu is always destroyed upon
presenting a context menu, so there's no need to separately clear out m_croppedImageResult.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showContextMenu):

UIProcess/WebPageProxy.h:
UIProcess/mac/WebContextMenuProxyMac.h:
UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):
(WebKit::WebContextMenuProxyMac::appendMarkupItemToControlledImageMenuIfNeeded):

Pull this logic out into a separate helper method, and change it so that:

We run the image analysis prior to creating and adding the item.
Only add the item if the image analysis returned a non-null CGImageRef.
Store the CGImageRef on m_croppedImageResult, for use if the menu item is invoked.

(WebKit::WebContextMenuProxyMac::applyMarkupToControlledImage):
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::handleContextMenuCopyCroppedImage):
(WebKit::WebPageProxy::setCroppedImageForContextMenu): Deleted.

Tools:

Add an API test to simulate clicking on the services menu button in an attachment-backed image element while
swizzling the relevant image analysis APIs to return a valid CGImageRef; verify that the "Markup Image" menu
item eventually shows up.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:

(TestWebKitAPI::createWebViewWithTextRecognitionEnhancements):
(TestWebKitAPI::iconImage):

Make this testing helper function work on both macOS and iOS.

(TestWebKitAPI::TEST):
(TestWebKitAPI::runMarkupTest):

TestWebKitAPI/Tests/WebKitCocoa/image-controls.html: Added.

1:15 PM Changeset in webkit [293680] by ysuzuki@apple.com

13 edits in trunk/Source/JavaScriptCore

[JSC] Introduce shifting Structure encoding
https://bugs.webkit.org/show_bug.cgi?id=239957

Reviewed by Mark Lam.

Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

Source/JavaScriptCore/heap/Heap.cpp:
Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:
Source/JavaScriptCore/jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitNonNullDecodeStructureID):

Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h:
Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:
Source/JavaScriptCore/runtime/JSCConfig.h:
Source/JavaScriptCore/runtime/JSCell.h:

(JSC::JSCell::atomSize):

Source/JavaScriptCore/runtime/Structure.h:

(JSC::Structure::atomSize):

Source/JavaScriptCore/runtime/StructureID.h:

(JSC::StructureID::decode const):
(JSC::StructureID::tryDecode const):
(JSC::StructureID::encode):

Source/JavaScriptCore/tools/IntegrityInlines.h:

(JSC::Integrity::auditStructureID):

Canonical link: https://commits.webkit.org/250179@main

1:15 PM Changeset in webkit [293679] by youenn@apple.com

12 edits in trunk

Cancel response stream if load is being cancelled by the web page
https://bugs.webkit.org/show_bug.cgi?id=239968

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/fetch-event-respond-with-readable-stream.https-expected.txt:

Source/WebCore:

Add a cancel callback and use it to get the fetch client cancelling notification
to cancel the response body stream or response body load.

Covered by rebased test.

Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::cancelStream):

Modules/fetch/FetchResponse.h:
bindings/js/ReadableStream.cpp:

(WebCore::ReadableStream::cancel):

bindings/js/ReadableStream.h:
workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::processResponse):

workers/service/context/ServiceWorkerFetch.h:

Source/WebKit:

Use the cancel callback to pipe the order to cancel the stream.

WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:

(WebKit::WebServiceWorkerFetchTaskClient::cancel):
(WebKit::WebServiceWorkerFetchTaskClient::setCancelledCallback):

WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:

1:06 PM Changeset in webkit [293678] by Russell Epstein

1 copy in tags/WebKit-7614.1.11.3

Tag WebKit-7614.1.11.3.

12:56 PM Changeset in webkit [293677] by Russell Epstein

9 edits in branches/safari-614.1.11-branch/Source

Versioning.

WebKit-7614.1.11.3

12:46 PM Changeset in webkit [293676] by youenn@apple.com

6 edits in trunk

PWA in iOS use old assets after publish new servicerWorker/assets
https://bugs.webkit.org/show_bug.cgi?id=199110
<rdar://problem/51992077>

Reviewed by Chris Dumez.

Source/WebCore:

In case a service worker is updated, its state will be waiting until activated.
In case we suspend clients and network process, the newly installed service worker wil remain waiting.
We will wait for the service worker to get activated when network process gets unsuspended, which might not happen if the network process gets stopped by the OS.
To prevent this, we now update the service worker registration as soon as the service worker install job is finished.
The migration from waiting to activated upon network process crash is not ideal: in theory we should fire an activate event on the waiting service worker.
That said, this is still somehow allowed, as failing to activate (say if service worker process is crashing when handling the event) is allowed.

Covered by new API test.

workers/service/server/SWServer.cpp:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
TestWebKitAPI/cocoa/HTTPServer.h:
TestWebKitAPI/cocoa/HTTPServer.mm:

12:44 PM Changeset in webkit [293675] by achristensen@apple.com

2 edits in trunk/Source/WebGPU

Fix tvOS build
https://bugs.webkit.org/show_bug.cgi?id=239973
<rdar://problem/92599361>

WebGPU/HardwareCapabilities.mm:

12:15 PM Changeset in webkit [293674] by mmaxfield@apple.com

2 edits in trunk/Source/WebGPU

[WebGPU] [tvOS] Neither MTLGPUFamilyApple6 nor MTLGPUFamilyApple7 exist on tvOS
https://bugs.webkit.org/show_bug.cgi?id=239973
<rdar://problem/92599361>

Unreviewed build fix.

WebGPU/HardwareCapabilities.mm:

(WebGPU::rawHardwareCapabilities):

12:12 PM Changeset in webkit [293673] by Ziran Sun

5 edits in trunk

[selection] Set correct selection range for TEXTAREA when updating default value
https://bugs.webkit.org/show_bug.cgi?id=237525

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-extra-expected.txt:

Source/WebCore:

Updating defaultValue should keep selectionStart/End. We need clamp them if the new value is shorter than the
selectionStart/End. This change is to be in line with [1] & [2].

[1] https://html.spec.whatwg.org/multipage/form-elements.html#the-textarea-element:dom-textarea-defaultvalue-2
[2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#textFieldSelection:concept-textarea/input-relevant-value

Part of this change is an import of Chromium CL at
https://github.com/chromium/chromium/commit/bb27a500d07f8b3c567e84857a40c3ce42fa454a

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::childrenChanged):
(WebCore::HTMLTextAreaElement::setValueCommon):

html/HTMLTextFormControlElement.h:

12:01 PM Changeset in webkit [293672] by Fujii Hironori

3 edits
2 adds in trunk

HTML Parser: Wrong column number in CR-LF line ending style (DOS EOL style) HTML files
https://bugs.webkit.org/show_bug.cgi?id=239947

Reviewed by Myles C. Maxfield.

Source/WebCore:

JS stack trace reported wrong column numbers in CR-LF line ending
HTML files. m_numberOfCharactersConsumedPriorToCurrentLine was the
number of characters included the preceding CR but the following
LF in those files.

In SegmentedString::advance, startNewLine() is called after
decrementing m_currentSubstring.length. In
SegmentedString::advancePastNewline, however, startNewLine() was
called before calling decrementAndCheckLength(). startNewLine()
should be called after decrementing.

Test: js/dom/line-column-numbers-cr-lf.html

platform/text/SegmentedString.h:

(WebCore::SegmentedString::advancePastNewline):
Call startNewLine() after decrementAndCheckLength() is called.

LayoutTests:

js/dom/line-column-numbers-cr-lf-expected.txt: Added.
js/dom/line-column-numbers-cr-lf.html: Added.

11:35 AM Changeset in webkit [293671] by eric.carlson@apple.com

4 edits
1 add in trunk

[Cocoa] Allow more mime types in captive portal mode
https://bugs.webkit.org/show_bug.cgi?id=239859
rdar://91830683

Reviewed by Brent Fulgham.

Source/WTF:

Scripts/Preferences/WebPreferences.yaml:

Tools:

TestWebKitAPI/Tests/WebKit/cocoa/start-offset.ts: Added.
TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:

(TestWebKitAPI::runVideoTest):
(TestWebKitAPI::testTransportStreamBytes):
(TestWebKitAPI::TEST):

11:05 AM Changeset in webkit [293670] by Oriol Brufau

13 edits
1 delete in trunk

[cssom] Enumerate all logical longhands in the computed style
https://bugs.webkit.org/show_bug.cgi?id=239910

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update test expectations.

web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

Source/WebCore:

Bug 210695 made computed styles enumerate most logical longhands, but
only the ones thefined in the css-logical spec were included. Other
specs, like css-scroll-snap, can also define logical longhands.

This patch fixes the logic, and instead of checking the spec, it checks
the "logical-property-group" field.

Tests: imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html

imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html

css/makeprop.pl:

(isLogical):

LayoutTests:

Update test expectations.
all-prop-initial-xml-expected.txt for ios was clearly outdated, so just
removing it.

platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Removed.
platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:

10:21 AM Changeset in webkit [293669] by Russell Epstein

1 copy in tags/WebKit-7614.1.11.2

Tag WebKit-7614.1.11.2.

10:15 AM Changeset in webkit [293668] by Russell Epstein

9 edits in branches/safari-614.1.11-branch/Source

Versioning.

WebKit-7614.1.11.2

9:57 AM Changeset in webkit [293667] by Jonathan Bedard

4 edits in trunk/Tools

[git-webkit] log should support ranges
https://bugs.webkit.org/show_bug.cgi?id=239510
<rdar://problem/92031167>

Reviewed by Ryan Haddad.

Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:

(FilteredCommand.replace): Break logic converting a substring into a revision or hash into a function.
(FilteredCommand.main): If an argument can be split by ..., convert it's substrings into revisions/hashes.

Canonical link: https://commits.webkit.org/250171@main

9:52 AM Changeset in webkit [293666] by Angelos Oikonomopoulos

2 edits in trunk/JSTests

new-largeish-contiguous-array-with-size.js: pick up leakFactor
https://bugs.webkit.org/show_bug.cgi?id=239963

Unreviewed gardening.

The @ directives are implemented imperatively, so requireOptions
only has any effect if it precedes the run* statement. Also,
s/var leakFactor/leakFactor/ to avoid running into this:

Exception: SyntaxError: Can't create duplicate variable: 'leakFactor'

With this fix, the leakFactor works as intended -- no failures in 200+
iterations.

stress/new-largeish-contiguous-array-with-size.js:

9:29 AM Changeset in webkit [293665] by youenn@apple.com

7 edits in trunk

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/claim-shared-worker-fetch.https-expected.txt:

Source/WebCore:

Make sure to register shared workers as service worker clients at launch time or when recreating the network process connection.

Covered by rebased test.

workers/shared/context/SharedWorkerThread.cpp:
workers/shared/context/SharedWorkerThreadProxy.cpp:
workers/shared/context/SharedWorkerThreadProxy.h:

9:15 AM Changeset in webkit [293664] by youenn@apple.com

3 edits in trunk/Source/WebCore

VPIO requires the same sample rate for microphone and speaker formats
https://bugs.webkit.org/show_bug.cgi?id=239956

Reviewed by Eric Carlson.

VPIO requires the speaker sample rate and microphone sample rate to be the same.
This is not guaranteed to be true : getUserMedia/applyConstraints may set the microphone sample rate to different values.
If audio rendering already started at capture start time, we use the audio rendering sample rate.
This is not strictly compliant, given required constraints but they are not widely used.
Applications that want to make sure to use a specific sample rate would need to pause audio rendering when starting to capture.
We reset exposed settings when starting to capture to expose the actual sample rate to JavaScript through MediaStreamTrack.getSettings().

Manually tested.

platform/mediastream/mac/BaseAudioSharedUnit.h:
platform/mediastream/mac/CoreAudioCaptureSource.cpp:

8:55 AM Changeset in webkit [293663] by Wenson Hsieh

8 edits in trunk

[iOS] Add support for the "Markup Image" action when right clicking an image in editable content
https://bugs.webkit.org/show_bug.cgi?id=239948
rdar://92064672

Reviewed by Tim Horton.

Source/WebKit:

Insert a "Markup Image" menu action when right clicking an editable image element on iPad via trackpad, but only
when the image has relevant image analysis markup results. See below for more details.

Test: ImageAnalysisTests.MarkupImageUsingContextMenu

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView prepareSelectionForContextMenuWithLocationInView:completionHandler:]):

In the case where a single image is selected in editable content, make this method additionally wait until we've
finished analyzing the selected image, such that the subsequent call to -buildMenuForWebViewWithBuilder: which
populates items in the right click context menu will include the "Markup Image" item if there are relevant
results.

(-[WKContentView buildMenuForWebViewWithBuilder:]):

Also move the location of this item to before the Format (B/I/U) menu items in both the callout bar and the
editing context menu.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::prepareSelectionForContextMenuWithLocationInView):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::prepareSelectionForContextMenuWithLocationInView):

In the case where an image element is clicked, just select the image element instead of trying to detect a
nearby word or link. We also immediately send a full editor state update here, such that the editor state's
selectedEditableImage will be up to date when the completion handler in the UI process is invoked.

Tools:

Add an API test to verify that the "Markup Image" is included in the context menu when right clicking an image
element inside an editable web view.

TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:

(TestWebKitAPI::simulateEditContextMenuAppearance):
(TestWebKitAPI::TEST):

8:08 AM Changeset in webkit [293662] by Antti Koivisto

3 edits in trunk/LayoutTests

REGRESSION: fast/css/stylesheet-candidate-nodes-crash.xhtml is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=239960
rdar://92293472

Reviewed by Alan Bujtas.

XML parser update has changed error reporting output slightly.
Remove the error report from the test output since testing that is not the purpose of this test.

fast/css/stylesheet-candidate-nodes-crash-expected.txt:
fast/css/stylesheet-candidate-nodes-crash.xhtml:

3:56 AM Changeset in webkit [293661] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GStreamer][Debug] media-recorder tests hitting an ASSERT
https://bugs.webkit.org/show_bug.cgi?id=239942

Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-02
Reviewed by Xabier Rodriguez-Calvar.

Delay the track observing stopping until InternalSources are destroyed. Doing so during
PAUSED->READY was not safe in MediaRecording pipelines, because the transcoder changes its
state from a secondary thread.

platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:

(webkitMediaStreamSrcChangeState):

Canonical link: https://commits.webkit.org/250165@main

2:31 AM Changeset in webkit [293660] by commit-queue@webkit.org

4 edits in trunk

[GLib] Make WebKitSettings XSS auditor functions no-op
https://bugs.webkit.org/show_bug.cgi?id=239651

Patch by Michael Catanzaro <Michael Catanzaro> on 2022-05-02
Reviewed by Adrian Perez de Castro.

Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):

Canonical link: https://commits.webkit.org/250164@main

May 1, 2022:

10:46 PM Changeset in webkit [293659] by Said Abou-Hallawa

15 edits in trunk/Source

REGRESSION(r282117): RemoteRenderingBackend::willDestroyImageBuffer() can crash if the RemoteRenderingBackend has already been destroyed
https://bugs.webkit.org/show_bug.cgi?id=239107
rdar://91608298

Reviewed by Darin Adler.

Source/WebCore:

-- IOSurfacePool will be RefCounted.

-- ImageBufferIOSurfaceBackend::create() will pass the surfacePool

of the CreationContext to ImageBufferIOSurfaceBackend constructor.

-- ImageBufferIOSurfaceBackend will hold a RefPtr<IOSurfacePool>.

-- ImageBufferIOSurfaceBackend destructor will call IOSurface::moveToPool()

to return its surface to the IOSurfacePool if it was set.

platform/graphics/ConcreteImageBuffer.h:
platform/graphics/ImageBuffer.h:
platform/graphics/ImageBufferBackend.h:

(WebCore::ImageBufferBackend::releaseGraphicsContext):
(WebCore::ImageBufferBackend::releaseBufferToPool): Deleted.

platform/graphics/cg/IOSurfacePool.cpp:

(WebCore::IOSurfacePool::create):

platform/graphics/cg/IOSurfacePool.h:
platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:

(WebCore::ImageBufferIOSurfaceBackend::create):
(WebCore::ImageBufferIOSurfaceBackend::ImageBufferIOSurfaceBackend):
(WebCore::ImageBufferIOSurfaceBackend::~ImageBufferIOSurfaceBackend):
(WebCore::ImageBufferIOSurfaceBackend::releaseBufferToPool): Deleted.

platform/graphics/cg/ImageBufferIOSurfaceBackend.h:

Source/WebKit:

After r282117, the assumption that RemoteRenderingBackend will outlive
all its RemoteImageBuffers became wrong. The RemoteRenderingBackend can
get destroyed under GPUConnectionToWebProcess::didClose() before the
callOnMainThread() of the ThreadSafeRefcounted image buffers have run.

This solution is to make the ImageBufferIOSurfaceBackend be responsible
of returning its IOSurface to the IOSurfacePool. So no need to call
willDestroyImageBuffer() from the RemoteImageBuffer destructor.

GPUProcess/graphics/RemoteGraphicsContextGL.h:
GPUProcess/graphics/RemoteImageBuffer.h:

(WebKit::RemoteImageBuffer::RemoteImageBuffer):
(WebKit::RemoteImageBuffer::m_renderingResourcesRequest):
(WebKit::RemoteImageBuffer::~RemoteImageBuffer):

GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::willDestroyImageBuffer): Deleted.

GPUProcess/graphics/RemoteRenderingBackend.h:

(WebKit::RemoteRenderingBackend::ioSurfacePool const):

Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::Buffer::discard):

WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp:

(WebKit::ImageBufferShareableMappedIOSurfaceBackend::create):

6:48 PM Changeset in webkit [293658] by Devin Rousso

4 edits in trunk/Source/WebCore

[Modern Media Controls] the overflow button sometimes flickers
https://bugs.webkit.org/show_bug.cgi?id=239921
<rdar://problem/91329468>

Reviewed by Eric Carlson.

There are two things that control the visibility of the OverflowButton:

whether any of the "default" actions (e.g. playback speed, chapters, etc.) are possible
if any other buttons that have contextMenuOptions are dropped (i.e. there's not enough

room for it because the <video> is narrow or there are already too many buttons)

(1) is recalculated for most JS media events (e.g. whenever tracks are changed, if
the readyState changes, etc.).

(2) is recalculated in layout of MediaControls, which is (relatively) less frequent.

In the case that the only contextmenu options are provided by (2) (i.e. none of the "default"
actions are possible), the frequent recalculation of (1) will combined with the fact that
layout uses a requestAnimationFrame to delay/batch work will cause there to be a short
period of time after the recalculation of (1) and before the recalculation of (2) where
there are no contextmenu options, resulting in the OverflowButton being hidden.

Modules/modern-media-controls/controls/overflow-button.js:

(OverflowButton):
(OverflowButton.prototype.set visible):
(OverflowButton.prototype.set visible.isEmpty): Added.
(OverflowButton.prototype.get contextMenuOptions):
(OverflowButton.prototype.addExtraContextMenuOptions): Renamed from addContextMenuOptions.
(OverflowButton.prototype.clearExtraContextMenuOptions): Renamed from clearContextMenuOptions.
(OverflowButton.prototype.set defaultContextMenuOptions):

Modules/modern-media-controls/controls/inline-media-controls.js:

(InlineMediaControls.prototype.layout):

Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:

(MacOSFullscreenMediaControls.prototype.layout):
Instead of having a single _contextMenuOptions that is modified by both (1) and (2), have
a separate member variable for each. This way, the recalculation of (1) doesn't also clear
the state left over from the last time (2) was calculated (which will be recalculated by (2)
shortly thereafter). Use both member variables to decide whether the OverflowButton should
be visible, allowing (1) and (2) to update independent of eachother.

6:17 PM Changeset in webkit [293657] by ysuzuki@apple.com

5 edits in trunk/Source/JavaScriptCore

[JSC] Revive JSC's guard against speculation collection
https://bugs.webkit.org/show_bug.cgi?id=239939

Reviewed by Mark Lam.

r288815 dropped JSC's guard against structures in speculation collection, but this is wrong.
This patch reverts it back.

Source/JavaScriptCore/bytecode/SpeculatedType.cpp:

(JSC::speculationFromCell):

Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:

(JSC::StructureMemoryManager::StructureMemoryManager):
(JSC::StructureMemoryManager::tryMallocStructureBlock):
(JSC::StructureMemoryManager::freeStructureBlock):
(JSC::StructureAlignedMemoryAllocator::initializeStructureAddressSpace):

Source/JavaScriptCore/runtime/JSCConfig.h:
Source/JavaScriptCore/runtime/StructureID.h:

(JSC::StructureID::tryDecode const):

Canonical link: https://commits.webkit.org/250161@main

5:17 PM Changeset in webkit [293656] by Chris Dumez

178 edits in trunk/Source

Prepare the rest of WebCore for making the AtomString(const String&) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=239917

Reviewed by Darin Adler.

Prepare the rest of WebCore for making the AtomString(const String&) constructor explicit.
This helps find suboptimal patterns in our code base, where we may be doing unnecessary
String allocations.

Source/WebCore/PAL/pal/FileSizeFormatter.cpp:

(PAL::fileSizeDescription):

Source/WebCore/PAL/pal/FileSizeFormatter.h:
Source/WebCore/PAL/pal/cocoa/FileSizeFormatterCocoa.mm:

(PAL::fileSizeDescription):

Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl:
Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.idl:
Source/WebCore/Modules/encryptedmedia/MediaKeySession.idl:
Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl:
Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl:
Source/WebCore/Modules/mediarecorder/MediaRecorderErrorEvent.idl:
Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl:
Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.idl:
Source/WebCore/Modules/mediastream/RTCErrorEvent.idl:
Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.idl:
Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.idl:
Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl:
Source/WebCore/Modules/mediastream/RTCTrackEvent.idl:
Source/WebCore/Modules/mediastream/RTCTransformEvent.idl:
Source/WebCore/Modules/notifications/NotificationEvent.idl:
Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.idl:
Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEvent.idl:
Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.idl:
Source/WebCore/Modules/speech/SpeechRecognitionErrorEvent.idl:
Source/WebCore/Modules/speech/SpeechRecognitionEvent.idl:
Source/WebCore/Modules/speech/SpeechSynthesisEvent.idl:
Source/WebCore/Modules/webxr/XRInputSourceEvent.idl:
Source/WebCore/Modules/webxr/XRInputSourcesChangeEvent.idl:
Source/WebCore/Modules/webxr/XRReferenceSpaceEvent.idl:
Source/WebCore/Modules/webxr/XRSessionEvent.idl:
Source/WebCore/bindings/IDLTypes.h:

(WebCore::IDLString::isNullValue):

Source/WebCore/bindings/js/JSDOMConvertStrings.h:

(WebCore::propertyNameToString):
(WebCore::Converter<IDLLegacyNullToEmptyAtomStringAdaptor<T>>::convert):
(WebCore::JSConverter<IDLLegacyNullToEmptyAtomStringAdaptor<T>>::convert):
(WebCore::JSConverter<IDLAtomStringAdaptor<T>>::convert):
(WebCore::JSConverter<IDLAtomStringAdaptor<IDLUSVString>>::convert):

Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeGetterBodyDefinition):
(GetAnnotatedIDLType):

Source/WebCore/bindings/scripts/test/TestPromiseRejectionEvent.idl:
Source/WebCore/css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyValue):

Source/WebCore/css/CSSProperties.json:
Source/WebCore/css/DOMCSSCustomPropertyDescriptor.h:
Source/WebCore/css/DOMCSSCustomPropertyDescriptor.idl:
Source/WebCore/css/MediaQueryExpression.cpp:

(WebCore::consumeFirstValue):

Source/WebCore/css/MediaQueryListEvent.idl:
Source/WebCore/css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::setCustomProperty):

Source/WebCore/css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseValueWithVariableReferences):

Source/WebCore/css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseTypedCustomPropertyValue):

Source/WebCore/css/parser/CSSPropertyParser.h:
Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeFamilyNameRaw):

Source/WebCore/dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocumentType):
(WebCore::DOMImplementation::createDocument):

Source/WebCore/dom/DOMImplementation.h:
Source/WebCore/dom/DOMImplementation.idl:
Source/WebCore/dom/Document+HTMLObsolete.idl:
Source/WebCore/dom/Document.cpp:

(WebCore::Document::createElementNS):
(WebCore::Document::formElementsState const):
(WebCore::Document::setStateForNewFormElements):
(WebCore::Document::parseQualifiedName):
(WebCore::Document::createAttributeNS):
(WebCore::Document::getCachedLocale):
(WebCore::Document::setBgColor):
(WebCore::Document::setFgColor):
(WebCore::Document::setAlinkColor):
(WebCore::Document::setLinkColorForBindings):
(WebCore::Document::setVlinkColor):

Source/WebCore/dom/Document.h:
Source/WebCore/dom/Document.idl:
Source/WebCore/dom/Element.cpp:

(WebCore::Element::toggleAttribute):
(WebCore::Element::didAddAttribute):
(WebCore::Element::didModifyAttribute):
(WebCore::Element::didRemoveAttribute):

Source/WebCore/dom/KeyboardEvent.idl:
Source/WebCore/dom/MutationObserver.h:
Source/WebCore/dom/MutationObserver.idl:
Source/WebCore/dom/QualifiedName.h:

(WebCore::QualifiedName::toAtomString const):

Source/WebCore/dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestModuleScript):

Source/WebCore/editing/ApplyStyleCommand.cpp:

(WebCore::joinWithSpace):

Source/WebCore/editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::inputEventTypeName const):

Source/WebCore/editing/CompositeEditCommand.h:
Source/WebCore/editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply):

Source/WebCore/editing/EditCommand.cpp:

(WebCore::inputTypeNameForEditingAction):

Source/WebCore/editing/EditCommand.h:
Source/WebCore/editing/EditingStyle.cpp:

(WebCore::StyleChange::extractTextStyles):

Source/WebCore/editing/EditingStyle.h:

(WebCore::StyleChange::fontColor):
(WebCore::StyleChange::fontFace):
(WebCore::StyleChange::fontSize):

Source/WebCore/editing/Editor.cpp:

(WebCore::Editor::applyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::insertAttachment):
(WebCore::Editor::styleForSelectionStart):

Source/WebCore/editing/Editor.h:
Source/WebCore/editing/EditorCommand.cpp:

(WebCore::executeFormatBlock):
(WebCore::executeInsertHorizontalRule):
(WebCore::executeInsertImage):

Source/WebCore/editing/MarkupAccumulator.cpp:

(WebCore::shouldAddNamespaceElement):
(WebCore::MarkupAccumulator::generateUniquePrefix):

Source/WebCore/editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::replace):

Source/WebCore/editing/TypingCommand.cpp:

(WebCore::TypingCommand::inputEventTypeName const):

Source/WebCore/editing/TypingCommand.h:
Source/WebCore/editing/WebContentReader.h:
Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::createFragmentForImageAttachment):
(WebCore::replaceRichContentWithAttachments):
(WebCore::createFragmentAndAddResources):
(WebCore::sanitizeMarkupWithArchive):
(WebCore::attachmentForFilePath):
(WebCore::attachmentForData):
(WebCore::WebContentReader::readURL):
(WebCore::WebContentReader::readDataBuffer):

Source/WebCore/editing/markup.cpp:

(WebCore::AttributeChange::AttributeChange):
(WebCore::completeURLs):
(WebCore::replaceSubresourceURLs):
(WebCore::StyledMarkupAccumulator::appendCustomAttributes):
(WebCore::createFragmentForImageAndURL):

Source/WebCore/history/HistoryItem.cpp:

(WebCore::HistoryItem::setDocumentState):
(WebCore::HistoryItem::documentState const):

Source/WebCore/history/HistoryItem.h:
Source/WebCore/html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::createTDForFilename):

Source/WebCore/html/FileInputType.cpp:

(WebCore::FileInputType::saveFormControlState const):

Source/WebCore/html/FormController.cpp:

(WebCore::StringVectorReader::consumeString):
(WebCore::StringVectorReader::consumeSubvector):
(WebCore::appendSerializedFormControlState):
(WebCore::FormController::formElementsState const):
(WebCore::FormController::setStateForNewFormElements):
(WebCore::FormController::parseStateVector):
(WebCore::FormController::referencedFilePaths):

Source/WebCore/html/FormController.h:
Source/WebCore/html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

Source/WebCore/html/HTMLAreaElement.idl:
Source/WebCore/html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::setFile):
(WebCore::HTMLAttachmentElement::updateAttributes):
(WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):

Source/WebCore/html/HTMLAttachmentElement.h:
Source/WebCore/html/HTMLBaseElement.idl:
Source/WebCore/html/HTMLButtonElement.idl:
Source/WebCore/html/HTMLCollection.cpp:

(WebCore::HTMLCollection::isSupportedPropertyName):

Source/WebCore/html/HTMLCollection.h:
Source/WebCore/html/HTMLFormControlElementWithState.h:
Source/WebCore/html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::namedItemOrItems const):

Source/WebCore/html/HTMLFormControlsCollection.h:
Source/WebCore/html/HTMLFormElement.idl:
Source/WebCore/html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::openURL):

Source/WebCore/html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::shouldLoadFrameLazily):

Source/WebCore/html/HTMLIFrameElement.idl:
Source/WebCore/html/HTMLImageElement.idl:
Source/WebCore/html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

Source/WebCore/html/HTMLInputElement.idl:
Source/WebCore/html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::parseAttribute):

Source/WebCore/html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setPreload):

Source/WebCore/html/HTMLMediaElement.h:
Source/WebCore/html/HTMLMediaElement.idl:
Source/WebCore/html/HTMLOrForeignElement.idl:
Source/WebCore/html/HTMLSelectElement.idl:
Source/WebCore/html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::saveFormControlState const):

Source/WebCore/html/HTMLTextAreaElement.idl:
Source/WebCore/html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::HTMLVideoElement):

Source/WebCore/html/HiddenInputType.cpp:

(WebCore::HiddenInputType::saveFormControlState const):
(WebCore::HiddenInputType::restoreFormControlState):
(WebCore::HiddenInputType::setValue):

Source/WebCore/html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

Source/WebCore/html/InputType.cpp:

(WebCore::InputType::saveFormControlState const):

Source/WebCore/html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):

Source/WebCore/html/ModelDocument.cpp:

(WebCore::ModelDocumentParser::createDocumentStructure):

Source/WebCore/html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

Source/WebCore/html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createAutoFillButton):
(WebCore::TextFieldInputType::updateAutoFillButton):

Source/WebCore/html/canvas/WebGLContextEvent.idl:
Source/WebCore/html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::processMeta):
(WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):

Source/WebCore/html/parser/HTMLMetaCharsetParser.h:
Source/WebCore/html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

Source/WebCore/html/parser/HTMLTreeBuilder.cpp:

(WebCore::createForeignAttributesMap):

Source/WebCore/html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldCancelButtonElement::create):

Source/WebCore/html/track/AudioTrack.cpp:

(WebCore::AudioTrack::updateKindFromPrivate):

Source/WebCore/html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack):
(WebCore::LoadableTextTrack::create):

Source/WebCore/html/track/LoadableTextTrack.h:
Source/WebCore/html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::setId):

Source/WebCore/html/track/TextTrackCue.h:

(WebCore::TextTrackCue::id const):

Source/WebCore/html/track/TextTrackCue.idl:
Source/WebCore/html/track/TrackEvent.idl:
Source/WebCore/html/track/VideoTrack.cpp:

(WebCore::VideoTrack::updateKindFromPrivate):

Source/WebCore/html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::collectWebVTTBlock):
(WebCore::WebVTTParser::collectCueId):
(WebCore::WebVTTParser::resetCueValues):

Source/WebCore/html/track/WebVTTParser.h:
Source/WebCore/inspector/DOMEditor.cpp:

(WebCore::DOMEditor::setAttribute):
(WebCore::DOMEditor::removeAttribute):

Source/WebCore/inspector/DOMEditor.h:
Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp:

(WebCore::InspectorAuditAccessibilityObject::getComputedProperties):

Source/WebCore/inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::drawRulers):

Source/WebCore/inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheetForInlineStyle::setStyleText):

Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::interceptWithResponse):
(WebCore::InspectorNetworkAgent::interceptRequestWithResponse):

Source/WebCore/loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadPostRequest):

Source/WebCore/loader/HistoryController.cpp:

(WebCore::FrameLoader::HistoryController::recursiveSetProvisionalItem):

Source/WebCore/loader/PolicyChecker.cpp:

(WebCore::FrameLoader::PolicyChecker::checkNewWindowPolicy):

Source/WebCore/loader/PolicyChecker.h:
Source/WebCore/page/PageSerializer.cpp:

(WebCore::isCharsetSpecifyingNode):

Source/WebCore/platform/Pasteboard.h:

(WebCore::PasteboardWebContentReader::readDataBuffer):

Source/WebCore/platform/graphics/InbandGenericCue.h:

(WebCore::GenericCueData::GenericCueData):
(WebCore::GenericCueData::decode):
(WebCore::InbandGenericCue::id const):
(WebCore::InbandGenericCue::setId):

Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVFObjC.mm:

(WebCore::InbandChapterTrackPrivateAVFObjC::processChapters):

Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp:

(WebCore::ISOWebVTTCue::ISOWebVTTCue):
(WebCore::ISOWebVTTCue::parse):

Source/WebCore/platform/graphics/iso/ISOVTTCue.h:
Source/WebCore/platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::read):

Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp:

(WebCore::RealtimeVideoCaptureSource::RealtimeVideoCaptureSource):

Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h:
Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):

Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.h:
Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:

(WebCore::MockRealtimeVideoSource::create):
(WebCore::MockRealtimeVideoSourceMac::createForMockDisplayCapturer):
(WebCore::MockRealtimeVideoSourceMac::MockRealtimeVideoSourceMac):

Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockDisplayCapturer::MockDisplayCapturer):

Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::create):
(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):

Source/WebCore/platform/mock/MockRealtimeVideoSource.h:
Source/WebCore/style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertStringOrAutoAtom):
(WebCore::Style::BuilderConverter::convertStringOrNoneAtom):

Source/WebCore/style/StyleBuilderCustom.h:

(WebCore::Style::BuilderCustom::applyValueContent):

Source/WebCore/testing/Internals.cpp:

(WebCore::Internals::shadowPseudoId):
(WebCore::Internals::setShadowPseudoId):
(WebCore::Internals::formControlStateOfPreviousHistoryItem):
(WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::highlightPseudoElementColor):

Source/WebCore/testing/Internals.h:
Source/WebCore/testing/Internals.idl:
Source/WebCore/testing/MockCDMFactory.cpp:

(WebCore::MockCDMFactory::setSupportedRobustness): Deleted.

Source/WebCore/testing/MockCDMFactory.h:

(WebCore::MockCDMFactory::setSupportedRobustness):

Source/WebCore/testing/MockCDMFactory.idl:

Canonical link: https://commits.webkit.org/250160@main

1:16 PM Changeset in webkit [293655] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[GLIB] Update test expectations. Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=239945

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-05-01

platform/glib/TestExpectations:
platform/gtk/TestExpectations:

8:08 AM Changeset in webkit [293654] by zan@falconsigh.net

2 edits in trunk/Source/JavaScriptCore

[RISCV64] Implement MacroAssembler::probe(), ctiMasmProbeTrampoline
https://bugs.webkit.org/show_bug.cgi?id=239938

Reviewed by Yusuke Suzuki.

Implement MacroAssembler::probe() for RISCV64, along with the
ctiMasmProbeTrampoline operation. The implementation follows the process
of implementations for other platforms, with incoming, outgoing and
return-address-restoration records used to store register values during
setup and breakdown of the probe.

Going into the probe and back out of it, the general-purpose and
floating-point registers are stored, with the exception of global and
thread registers (x3 and x4). After the probe, if the probe state on the
stack is broken, the complete state is re-established before the
registers are reloaded, with the stack pointer and return address
registers set up last.

Covered by probing-related unit tests in testmasm.

assembler/MacroAssemblerRISCV64.cpp:

(JSC::MacroAssembler::probe):

8:05 AM Changeset in webkit [293653] by zan@falconsigh.net

2 edits in trunk/Source/JavaScriptCore

[RISCV64] Enable testmasm execution
https://bugs.webkit.org/show_bug.cgi?id=239937

Reviewed by Yusuke Suzuki.

In testmasm, enable some additional sets of tests for RISCV64 that cover
already-functioning behavior. In isSpecialGPR(), the function returns
true under CPU(RISCV64) for the appropriate registers.

In invoke(), when targeting RISCV64 and invoking JIT-produced code whose
return type is a 32-bit integer, the resulting value is manually
sign-extended to paper over the mismatch between zero-extended 32-bit
values that are used and produced in JSC JIT and the sign-extended
32-bit values that are expected in the RV64 calling convention.

assembler/testmasm.cpp:

(JSC::isSpecialGPR):
(JSC::invoke):
(JSC::testProbePreservesGPRS):
(JSC::testLoadBaseIndex):
(JSC::testStoreBaseIndex):

7:18 AM Changeset in webkit [293652] by commit-queue@webkit.org

2 edits
1 delete in trunk/LayoutTests

[GStreamer] tests gardening
https://bugs.webkit.org/show_bug.cgi?id=239943

Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-01
Unreviewed, update a couple media-recorder and media-capabilities expectations.

platform/glib/TestExpectations:
platform/wpe/http/wpt/mediarecorder/MediaRecorder-dataavailable-expected.txt: Removed.
platform/wpe/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable-expected.txt: Removed.

Canonical link: https://commits.webkit.org/250156@main

1:51 AM Changeset in webkit [293651] by commit-queue@webkit.org

2 edits in trunk/Tools

[WPE][GTK] Built product archives include old library files
https://bugs.webkit.org/show_bug.cgi?id=239928

Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-01
Reviewed by Adrian Perez de Castro.

CISupport/built-product-archive: Exclude old WPE/GTK files from built product zip archives.

Canonical link: https://commits.webkit.org/250155@main

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed