Timeline

May 11, 2022:

11:39 PM Changeset in webkit [294096] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[GPU Process] webrtc/vp8-then-h264-gpu-process-crash.html flaky fails after turning DOM in GPUP on by default
​https://bugs.webkit.org/show_bug.cgi?id=236926

Patch by John Cunningham <​johncunningham@apple.com> on 2022-05-11
Reviewed by Youenn Fablet.

• platform/wpe/TestExpectations:

10:41 PM Changeset in webkit [294095] by Diego Pino Garcia

• 2 edits in trunk/Source/WebCore

[WPE] Unreviewed, build fix after r293816
​https://bugs.webkit.org/show_bug.cgi?id=240330

Build was broken when ENABLE_ORIENTATION_EVENTS=ON

• dom/DeviceOrientationEvent.idl:

10:14 PM Changeset in webkit [294094] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Some RenderStyle::diff() optimizations
​https://bugs.webkit.org/show_bug.cgi?id=240323

Reviewed by Alan Bujtas.

Some LengthBox operator== stuff was showing up on profiles, which we can avoid by
first testing m_surroundData pointer equality.

scrollPadding and scrollSnapType live in rareNonInheritedData, so we can move their
comparisons into rareNonInheritedDataChangeRequiresLayout().

changeRequiresRepaint() can check for m_backgroundData and m_surroundData pointer
equality before doing more expensive tests.

These changes reduce the time in RenderStyle::diff() in the MotionMark Design
subtest by ~40%.

• rendering/style/RenderStyle.cpp:

(WebCore::rareNonInheritedDataChangeRequiresLayout):
(WebCore::RenderStyle::changeRequiresLayout const):
(WebCore::RenderStyle::changeRequiresLayerRepaint const):
(WebCore::RenderStyle::changeRequiresRepaint const):

9:49 PM Changeset in webkit [294093] by Russell Epstein

• 1 copy in tags/WebKit-7614.1.13.3

Tag WebKit-7614.1.13.3.

9:46 PM Changeset in webkit [294092] by Russell Epstein

• 2 edits in branches/safari-7614.1.13-branch/Source/WebKit

Cherry-pick r293945. rdar://problem/92859012

Fix another internal build
​https://bugs.webkit.org/show_bug.cgi?id=240201
<rdar://92859012>

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-05-06
Reviewed by Alexey Proskuryakov.

Bug 240184 introduced a classic "but I have spaces in my path" bug.

• Configurations/adattributiond.xcconfig:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:46 PM Changeset in webkit [294091] by Russell Epstein

• 2 edits in branches/safari-7614.1.13-branch/Source/WebKit

Cherry-pick r293936. rdar://problem/92859012

Fix adattributiond build in internal build on older macOS
​https://bugs.webkit.org/show_bug.cgi?id=240184
<rdar://92859012>

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-05-06
Reviewed by Alexey Proskuryakov.

We need to search for WK_OVERRIDE_FRAMEWORKS_DIR to find the right frameworks

• Configurations/adattributiond.xcconfig:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:33 PM Changeset in webkit [294090] by Russell Epstein

• 4 edits
  1 add in branches/safari-7614.1.13-branch/Source/WebGPU

Cherry-pick r293937. rdar://problem/92524485

[WebGPU] Fix build on downlevel OSes in Apple's build system
​https://bugs.webkit.org/show_bug.cgi?id=240159
<rdar://problem/92524485>

Reviewed by Alexey Proskuryakov.

Some variables from WebKitTargetConditionals.xcconfig and
PlatformSupport.xcconfig are used, so we have to make sure
we include them. Also refactor the INSTALL_PATH variable a
bit.

• Configurations/Base.xcconfig:
• Configurations/WebGPU.xcconfig:
• Configurations/WebKitTargetConditionals.xcconfig: Added.
• WebGPU.xcodeproj/project.pbxproj:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:27 PM Changeset in webkit [294089] by Russell Epstein

• 9 edits in branches/safari-7614.1.13-branch/Source

Versioning.

WebKit-7614.1.13.3

9:05 PM Changeset in webkit [294088] by Wenson Hsieh

• 6 edits in trunk

ImageAnalysisQueue should extract and analyze images inside of subframes
​https://bugs.webkit.org/show_bug.cgi?id=240328
rdar://93134975

Reviewed by Tim Horton.

Teach ImageAnalysisQueue to recursively find all images on the page (including images in of subframe content)
and queue them for analysis. To do this, we refactor enqueueAllImages to call into a new recursive helper
method, enqueueAllImagesRecursive, to look for more candidate image elements that exist inside frame owner
elements (e.g. iframe).

Test: ImageAnalysisTests.AnalyzeImagesInSubframes

• page/ImageAnalysisQueue.cpp:

(WebCore::ImageAnalysisQueue::enqueueAllImages):
(WebCore::ImageAnalysisQueue::enqueueAllImagesRecursive):

• page/ImageAnalysisQueue.h:

ImageAnalysisQueue should extract and analyze images inside of subframes
​https://bugs.webkit.org/show_bug.cgi?id=240328
rdar://93134975

Reviewed by Tim Horton.

Add an API test to verify that we extract and analyze images inside of subframes, in addition to images in the
main frame.

• TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/multiple-images.html:

Canonical link: ​https://commits.webkit.org/250478@main

7:06 PM Changeset in webkit [294087] by sbarati@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Better handle clobbered registers in O0 register allocation
​https://bugs.webkit.org/show_bug.cgi?id=240205
<rdar://87220688>

Reviewed by Yusuke Suzuki.

This patch makes Air's O0 register allocator better handle clobbered
registers. We now model both early and late clobber directly, and use
this to perform a basic interference analysis when allocating a register
to a Tmp. An early clobber interferes with any Use in an instruction, and
any early Defs. A late clobber interferes with any Defs in an instruction,
and any late Uses. What this enables is an early Use can be allocated
to a register that is only late clobbered. And a result can be allocated
to a register that is only early clobbered.

Prior to this, the algorithm had a bug where a Use may be allocated to
a register that is early clobbered.

• b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:

(JSC::B3::Air::GenerateAndAllocateRegisters::buildLiveRanges):
(JSC::B3::Air::GenerateAndAllocateRegisters::alloc):
(JSC::B3::Air::GenerateAndAllocateRegisters::freeDeadTmpsIfNeeded):
(JSC::B3::Air::GenerateAndAllocateRegisters::assignTmp):
(JSC::B3::Air::GenerateAndAllocateRegisters::prepareForGeneration):
(JSC::B3::Air::GenerateAndAllocateRegisters::generate):

• b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:
• b3/air/testair.cpp:
• jit/RegisterSet.h:

Canonical link: ​https://commits.webkit.org/250477@main

6:44 PM Changeset in webkit [294086] by yousuke.kimoto@sony.com

• 2 edits in trunk/Source/WebKit

[WinCairo] Fix a compile error due to InspectorResourceURLSchemeHandler
​https://bugs.webkit.org/show_bug.cgi?id=239490

Reviewed by Yusuke Suzuki.

• UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp:

Canonical link: ​https://commits.webkit.org/250476@main

6:36 PM Changeset in webkit [294085] by Alan Coon

• 9 edits in branches/safari-7614.1.12-branch/Source

Versioning.

WebKit-7614.1.12.3

5:56 PM Changeset in webkit [294084] by Ben Nham

• 14 edits in trunk

Re-send connection configuration if webpushd dies
​https://bugs.webkit.org/show_bug.cgi?id=240286

Reviewed by Geoffrey Garen.

If webpushd dies, all future communication with it from NetworkProcess fails because we
don't re-send the connection configuration to the daemon after the connection is
interrupted. This manifests itself as an "invalid sender" AbortError from various
PushManager methods because webpushd doesn't know the bundle identifier of the UIProcess it
is working on behalf of.

To fix this, I moved the responsibility for sending the configuration from
NetworkNotificationManager to WebPushD::Connection, and WebPushD::Connection re-sends the
configuration every time a new XPC connection is created.

Covered by a new API test.

Source/WebKit:

• NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::NetworkSession):

• NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::webPushDaemonUsesMockBundlesForTesting const): Deleted.

• NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm:

(WebKit::WebPushD::Connection::newConnectionWasInitialized const):

• NetworkProcess/Notifications/NetworkNotificationManager.cpp:

(WebKit::NetworkNotificationManager::NetworkNotificationManager):
(WebKit::NetworkNotificationManager::sendMessage const):
(WebKit::NetworkNotificationManager::sendMessageWithReply const):
(WebKit::NetworkNotificationManager::maybeSendConnectionConfiguration const): Deleted.

• NetworkProcess/Notifications/NetworkNotificationManager.h:
• NetworkProcess/Notifications/WebPushDaemonConnection.cpp:

(WebKit::WebPushD::Connection::Connection):

• NetworkProcess/Notifications/WebPushDaemonConnection.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:

(TestWebKitAPI::testWebPushDaemonPList):
(TestWebKitAPI::setUpTestWebPushD):
(TestWebKitAPI::restartTestWebPushD):
(TestWebKitAPI::WebPushDTest::WebPushDTest):

• TestWebKitAPI/cocoa/DaemonTestUtilities.h:
• TestWebKitAPI/cocoa/DaemonTestUtilities.mm:

(TestWebKitAPI::restartService):

Canonical link: ​https://commits.webkit.org/250475@main

5:54 PM Changeset in webkit [294083] by Alan Coon

• 1 copy in tags/WebKit-7613.3.1.1.2

Tag WebKit-7613.3.1.1.2.

5:31 PM Changeset in webkit [294082] by Patrick Angle

• 44 edits in trunk

Web Inspector: Parse InjectedScriptSource as a built-in to get guaranteed non-user-overriden JSC built-ins
​https://bugs.webkit.org/show_bug.cgi?id=152294

Reviewed by Devin Rousso.

Source/JavaScriptCore:

Covered by existing tests, and new test cases in LayoutTests/inspector/injected-script/observable.html

• CMakeLists.txt:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Build InjectedScriptSource.js as a builtin, not as a plain header file containing its source code.

• Scripts/wkbuiltins/builtins_model.py:

(BuiltinFunction.fromString):
(BuiltinsCollection._parse_functions):

• InspectorInjectedScript contains unbalanced curly brackets inside quotes. The generation of builtins is now

hardened against this. Previously all curly brackets were counted, which meant that the source code would be cut
off earlier than the actual end of the function.

• builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createExecutable):

• CommandLineAPIModuleSource.js uses destructuring to get the RemoteObject and CommandLineAPI classes at

instantiation. We need to treat this destructure as a single parameter, otherwise debug assertions will catch
the discrepancy between parameter counts.

• builtins/BuiltinNames.h:
• bytecode/LinkTimeConstant.h:
• Add symbols that we need to have a private version of, and for some of those symbols make them link-time constants.

• builtins/IteratorHelpers.js:

(globalPrivate.builtinSetIterable):
(globalPrivate.builtinMapIterable):

• Add reusable helpers for getting builtin iterators for Maps and Sets. This is done with private symbols that

represent the same function that the iterator would have returned. We create a new wrapper object to allow usage
to follow the same pattern at dealing with an unwrapped iterable object.

• inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::createInjectedScript):
(Inspector::InjectedScriptManager::injectedScriptFor):
(Inspector::InjectedScriptManager::injectedScriptSource): Deleted.

• inspector/InjectedScriptManager.h:
• Use the new link-time constant for the Injected Script creation function.

• inspector/InjectedScriptModule.cpp:

(Inspector::InjectedScriptModule::ensureInjected):

• inspector/InjectedScriptModule.h:
• Injected modules are now provided as a JSFunction, not raw source code.

• inspector/InjectedScriptSource.js:
• Use private symbols throughout to ensure we get non-observable, non-overridden versions of functions and values.
• In many cases, this is a 1:1 mapping where the new symbol is just prefixed with an @.
• For pushing values to arrays, use @arrayPush, the builtin way of pushing a value into an array.
• For the Symbol constructor, just use the existing @createPrivateSymbol instead of exposing a private

version of the Symbol constructor..

• Symbol.toStringTag is converted to @@toStringTag, the private version of that symbol.
• Math.max in RemoteObject.prototype._generatePreview now uses a helper function that performs a comparison

instead of exposing both Math and Math.max as private builtins.

• Create objects as prototype-less using the new builtin helper @createPrototypelessObject, which can also take

arguments that are key value pairs for near-parity with normal Object creation via {}.

• Create arrays as prototype-less using the new builtin helper @createPrototypelessArray, which can also take

arguments which are entries to put into the array.

• For spreading arguments (for the console commandline functions) we should create a new prototypeless array to

spread instead of spreading the raw arguments to avoid interacting with a potentially modified iterator.

• parser/Parser.h:

(JSC::parse):

• Add the line number to builtin compilation logging to help identify where sometimes ambiguous errors occurred.

• runtime/ArrayConstructor.cpp:
• runtime/ArrayPrototype.cpp:
• runtime/MapPrototype.cpp:
• runtime/ObjectConstructor.cpp:
• runtime/SetPrototype.cpp:
• runtime/StringPrototype.cpp:
• Expose necessary functions/constructors via their private name for use in InjectedScriptSource.js and

CommandLineAPIModuleSource.js

• runtime/JSGlobalObject.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSGlobalObject::init):

• runtime/JSGlobalObject.h:
• Add a link-time constant for the String constructor.
• Add helpers for JSON parsing/serialization.

Source/WebCore:

• CMakeLists.txt:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Headers.cmake:
• WebCore.xcodeproj/project.pbxproj:
• Build CommandLineAPIModuleSource.js as a builtin, not as a plain header file containing its source code.

• inspector/CommandLineAPIModule.cpp:

(WebCore::CommandLineAPIModule::injectModuleFunction const):
(WebCore::CommandLineAPIModule::source const): Deleted.

• inspector/CommandLineAPIModule.h:
• Provide a JSFunction for module injection instead of raw source code.

• inspector/CommandLineAPIModuleSource.js:
• Similar to JavaScriptCore/inspector/InjectedScriptSource.js, use private names for properties and functions

throughout to get non-user-overridden builtins.

• In normalizeEventTypes use a Set instead of an array, since we are processing user-provided types that may

be repeated. This means that we need to iterate over all the types to insert them in the set, but since
@arrayPush doesn't support pushing multiple values at the same time this is no more work than using an Array.

LayoutTests:

• inspector/injected-script/observable-expected.txt:
• inspector/injected-script/observable.html:
• Add several more test cases for overriding functions and entire objects.

• inspector/debugger/pause-for-internal-scripts-expected.txt:
• inspector/debugger/pause-for-internal-scripts.html:
• Changed to test a custom internal script snippet since the inspector injected script is now a builtin.

• inspector/debugger/scriptParsed-expected.txt:
• inspector/debugger/scriptParsed.html:
• The inspector injected script (and modules) will no longer appear as scripts in Web Inspector.

• inspector/model/remote-object/error-expected.txt:
• inspector/timeline/line-column.html:
• inspector/timeline/line-column-expected.txt:
• platform/gtk/inspector/timeline/line-column-expected.txt:
• Inspector injected script line numbers are different between release and debug builds, so filter those out.

5:02 PM Changeset in webkit [294081] by Alan Coon

• 1 copy in tags/WebKit-7613.3.1.0.2

Tag WebKit-7613.3.1.0.2.

4:58 PM Changeset in webkit [294080] by Russell Epstein

• 1 copy in tags/WebKit-7614.1.13.2

Tag WebKit-7614.1.13.2.

4:52 PM Changeset in webkit [294079] by Chris Dumez

• 11 edits
  2 adds in trunk

fast/text/international/system-language/navigator-language/navigator-language-fr.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=240104
<rdar://problem/92765233>

Reviewed by Per Arne Vollan and Myles Maxfield.

The test was flaky and navigator.language would sometimes return "fr" and sometimes "fr-FR".
The reason for this is that Cocoa ports used 2 separate mechanisms to override the system
language:

1. The override languages were used to set the AppleLanguages NSUserDefaults, causing APIs such as CFLocaleCopyPreferredLanguages() to return the overriden languages.
2. During process initialization we would also call WTF::overrideUserPreferredLanguages() which would add the override languages to an override Vector in WTF.

The test was setting the override language to "fr". When method 2 would succeed,
navigator.language would return "fr", from preferredLanguagesOverride().

However, Internals::resetToConsistentState() would reset WTF::preferredLanguagesOverride()
shortly after the test starts running. As a result, the override Vector in WTF would often
end up being empty and we would end up calling CFLocaleCopyPreferredLanguages().
However, CFLocaleCopyPreferredLanguages() return "fr-FR", which is equivalent but not
exactly the same.

To address the issue, I made the following changes:

1. Use a single method for overriding languages for Cocoa ports. We are now using the AppleLanguages user default exclusively and not the WTF::preferredLanguagesOverride() Vector.
2. We now call Internals::resetToConsistentState() only after running the test in WebKitTestRunner, not at the beginning of the test. This is consistent to what we were already doing in DumpRenderTree. Because Internals::resetToConsistentState() resets the languages, we don't want it to run at the beginning of the test. This is because some tests specify their languages in their header and WKTR ends up setting those languages via TestOptions, before actually running the test. We don't want those to get cleared.

• Tools/WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Only ask the injected bundle to reset after running the test and not before. This is
consistent with what DumpRenderTree was already doing. The injected bundle would call
Internals::resetToConsistentState() when receiving this reset message.

• Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::setAppleLanguagesPreference):
Move the logic to set the AppleLanguages user default from the WebKit2 layer to WTF,
inside LanguageCocoa.mm and use it inside WTF::overrideUserPreferredLanguages().

• Source/WTF/wtf/Language.cpp:

(WTF::overrideUserPreferredLanguages):

• Source/WTF/wtf/cocoa/LanguageCocoa.mm:

(WTF::overrideUserPreferredLanguages):
Stop using the WTF::preferredLanguagesOverride() Vector on Cocoa and set the AppleLanguages
user default instead. WebKit2 was using both AppleLanguages and this Vector, which would give
inconsistent results, especially when resetting the Vector but not the user default. Using
the user default is also more realistic then the fake override Vector as we end up calling
into the usual CF APIs to retrieve the languages.

• Source/WebCore/platform/graphics/FontDescription.cpp:

(WebCore::computeSpecializedChineseLocale):

• Source/WebCore/platform/graphics/FontGenericFamilies.cpp:

(WebCore::computeUserPrefersSimplified):
Add some FIXME comments. These functions do locale matching but use minimized locales which
may cause the matching to fail. This is causing fast/text/international/generic-font-family-language-traditional.html
to fail. We didn't notice before because our test infrastructure storing language overrides in
a vector in WTF, which doesn't get minimized, unlike locales we get from the system.

• Source/WebCore/testing/Internals.cpp:

(WebCore::Internals::userPreferredLanguages const):
Stop minimizing the locales returned by internals.userPreferredLanguages(). It used to not matter because
locales set by the test would be set in the WTF::overrideUserPreferredLanguages() Vector and locales from
that vector would get returned un-minimized, even when requesting minimized locales. However, now that we
are no longer using this vector and using the regular code path instead, locales would get minimized and
this would cause a test to fail. The test was checking that the values returned by
internals.userPreferredLanguages() are exactly the same as the ones set via internals.setUserPreferredLanguages().

• LayoutTests/fast/harness/user-preferred-language.html:

Tweak test to use call internals.setUserPreferredLanguages() with proper locales instead of using
non-locales. This used to not matter because we were storing them in the WTF::overrideUserPreferredLanguages()
Vector and internals.userPreferredLanguages() would return then as-is from the vector.
However, now that we actually set the AppleLanguages user default and actually call the CF APIs to retrieve
the locales, having properly formatted locales is required.

• LayoutTests/platform/gtk/fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt: Added.

We used to clear the language override shortly after starting the test so the test was actually getting the system language
instead of "en" which is the override that the test sets.

• LayoutTests/platform/ios/TestExpectations:
• LayoutTests/platform/mac/TestExpectations:

Mark fast/text/international/generic-font-family-language-traditional.html as failing since language minimization
is causing it to fail. This is not a regression from this patch. This is an issue in shipping code that is now
exposed because our test infrastructure for locale overriding is now closer to real life.

Canonical link: ​https://commits.webkit.org/250473@main

3:32 PM Changeset in webkit [294078] by Alan Coon

• 1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 145

Added a tag for Safari Technology Preview release 145.

2:57 PM Changeset in webkit [294077] by yurys@chromium.org

• 9 edits in trunk

[WinCairo] Support file downloads
​https://bugs.webkit.org/show_bug.cgi?id=240293

Reviewed by Fujii Hironori.

.:

• Source/cmake/OptionsWin.cmake: enable DOWNLOAD_ATTRIBUTE by default in WinCairo.

Source/WebCore:

Properly convert suggested file name to utf8.

Coverred by LayoutTests/http/tests/download/literal-utf-8.html.

• platform/network/curl/ResourceResponseCurl.cpp:

(WebCore::ResourceResponse::platformSuggestedFilename const):

Source/WebKit:

Hooked up Curl calls to Download callbacks. Added basic support for
file downloads in Curl.

• NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::cancel):
(WebKit::NetworkDataTaskCurl::curlDidReceiveData):
(WebKit::NetworkDataTaskCurl::curlDidComplete):
(WebKit::NetworkDataTaskCurl::deleteDownloadFile):
(WebKit::NetworkDataTaskCurl::curlDidFailWithError):
(WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse):

• NetworkProcess/curl/NetworkDataTaskCurl.h:

LayoutTests:

• platform/wincairo/TestExpectations: enable downloads tests.

2:57 PM Changeset in webkit [294076] by Alan Coon

• 9 edits in branches/safari-7613.3.1.1-branch/Source

Versioning.

WebKit-7613.3.1.1.2

2:56 PM Changeset in webkit [294075] by Alan Coon

• 9 edits in branches/safari-7613.3.1.0-branch/Source

Versioning.

WebKit-7613.3.1.0.2

2:47 PM Changeset in webkit [294074] by Jonathan Bedard

• 2 edits in trunk

Remove Subversion references from ReadMe
​https://bugs.webkit.org/show_bug.cgi?id=240316
<rdar://problem/93127701>

Reviewed by Geoffrey Garen.

• ReadMe.md:

Canonical link: ​https://commits.webkit.org/250471@main

2:43 PM Changeset in webkit [294073] by Alan Coon

• 1 copy in tags/WebKit-7613.3.1.1.1

Tag WebKit-7613.3.1.1.1.

2:41 PM Changeset in webkit [294072] by msaboff@apple.com

• 3 edits in trunk/Source/WebKit

Need to add DYLD_LIBRARY_PATH for XPC services
​https://bugs.webkit.org/show_bug.cgi?id=240289

Reviewed by Alexey Proskuryakov.

Set DYLD_LIBRARY_PATH / DYLD_VERSIONED_LIBRARY_PATH for XPC services depending on the value of USE_STAGING_INSTALL_PATH.
Also added DYLD_LIBRARY_PATH to the XPC environment for webpushd.

• Configurations/BaseTarget.xcconfig:
• webpushd/webpushtool/WebPushToolMain.mm:

(registerDaemonWithLaunchD):

2:37 PM Changeset in webkit [294071] by Alan Coon

• 1 copy in tags/WebKit-7613.3.1.0.1

Tag WebKit-7613.3.1.0.1.

1:40 PM Changeset in webkit [294070] by Alan Coon

• 12 edits
  1 add in branches/safari-613-branch/Source

Cherry-pick r293804. rdar://92717726

Crash under WebCore: WebCore::CachedResourceClientWalker<WebCore::CachedImageClient>::next()
​https://bugs.webkit.org/show_bug.cgi?id=240072
<rdar://92717726>

Reviewed by Geoff Garen.

Have CachedResource and CachedResourceClientWalker hold the clients via WeakPtrs instead of
raw pointers and null check them before usage. This is a lot safer.

• Source/WTF/WTF.xcodeproj/project.pbxproj:
• Source/WTF/wtf/WeakHashCountedSet.h: Added.

(WTF::WeakHashCountedSet::begin):
(WTF::WeakHashCountedSet::end):
(WTF::WeakHashCountedSet::begin const):
(WTF::WeakHashCountedSet::end const):
(WTF::WeakHashCountedSet::find):
(WTF::WeakHashCountedSet::find const):
(WTF::WeakHashCountedSet::contains const):
(WTF::WeakHashCountedSet::computeSize const):
(WTF::WeakHashCountedSet::clear):
(WTF::Counter>::add):
(WTF::Counter>::remove):

• Source/WebCore/html/HTMLLinkElement.h:
• Source/WebCore/loader/DocumentThreadableLoader.h:
• Source/WebCore/loader/ImageLoader.h:
• Source/WebCore/loader/LinkLoader.h:
• Source/WebCore/loader/cache/CachedImage.cpp:

(WebCore::CachedImage::addClientWaitingForAsyncDecoding):

• Source/WebCore/loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::switchClientsToRevalidatedResource):

• Source/WebCore/loader/cache/CachedResource.h:

(WebCore::CachedResource::hasClients const):
(WebCore::CachedResource::hasClient):
(WebCore::CachedResource::numberOfClients const):

• Source/WebCore/loader/cache/CachedResourceClient.h:
• Source/WebCore/loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
(WebCore::CachedResourceClientWalker::next):

• Source/WebCore/rendering/RenderObject.h:

Canonical link: ​https://commits.webkit.org/245886.562@safari-7613.3.1.0-branch

1:40 PM Changeset in webkit [294069] by Alan Coon

• 3 edits
  3 adds in branches/safari-613-branch

Cherry-pick r293736. rdar://80891555

StorageMap::removeItem may fail to remove item from map
​https://bugs.webkit.org/show_bug.cgi?id=239982
rdar://80891555

Reviewed by Chris Dumez.

Source/WebCore:

We may have updated m_impl, but we don't update iterator for removal. In this case, item is not removed from
map, but currentSize is updated. The mismatch between currentSize and actual size of the map may lead to
underflow and overflow in currentSize when item is added or removed later.

Test: storage/domstorage/sessionstorage/window-open-remove-item.html

• storage/StorageMap.cpp:

(WebCore::StorageMap::removeItem):

LayoutTests:

• storage/domstorage/sessionstorage/resources/window-open-remove-item.html: Added.
• storage/domstorage/sessionstorage/window-open-remove-item-expected.txt: Added.
• storage/domstorage/sessionstorage/window-open-remove-item.html: Added.

Canonical link: ​https://commits.webkit.org/245886.561@safari-7613.3.1.0-branch

1:40 PM Changeset in webkit [294068] by Alan Coon

• 9 edits in branches/safari-613-branch/Source

Versioning.

WebKit-7613.3.1.0.1

Canonical link: ​https://commits.webkit.org/245886.560@safari-7613.3.1.0-branch

1:35 PM Changeset in webkit [294067] by Antti Koivisto

• 50 edits in trunk

REGRESSION (r291788): MotionMark Suits subtest is 9% regressed
​https://bugs.webkit.org/show_bug.cgi?id=240112
rdar://92409900

Reviewed by Alan Bujtas.

Source/WebCore:

Add mechanism to safely update SVG renderer from element without triggering an unnecessary style resolution.

• dom/Document.cpp:

(WebCore::Document::removedLastRef):
(WebCore::Document::resolveStyle):
(WebCore::Document::updateTextRenderer):
(WebCore::Document::updateSVGRenderer):

Use the same mechanism as text updates to schedule SVG rendering updates.

(WebCore::Document::ensurePendingRenderTreeUpdate):
(WebCore::Document::needsStyleRecalc const):
(WebCore::Document::destroyRenderTree):

Ensure any remaining style update get deleted along with the render tree.

• dom/Document.h:
• dom/ElementData.h:

(WebCore::ElementData::svgResourcesInAncestorChainAreDirty const): Deleted.
(WebCore::ElementData::setSVGResourcesInAncestorChainAreDirty const): Deleted.

Not needed anymore, Style::Update remembers what needs updating.

• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateElementRenderer):

Schedule an update. Currently this really just schedules a layout which pulls in the changes from the element.

• style/StyleUpdate.cpp:

(WebCore::Style::Update::addElement):
(WebCore::Style::Update::addSVGRendererUpdate):

Add a bit to ElementUpdate to indicate that SVG update is needed.

• style/StyleUpdate.h:
• svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::applyResultsToTarget):

• svg/SVGClipPathElement.cpp:

(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):

• svg/SVGElement.cpp:

(WebCore::SVGElement::updateSVGRendererForElementChange):
(WebCore::SVGElement::setSVGResourcesInAncestorChainAreDirty): Deleted.
(WebCore::SVGElement::invalidateSVGResourcesInAncestorChainIfNeeded): Deleted.

Replace setSVGResourcesInAncestorChainAreDirty with the new mechanism. Don't invalidate style.

• svg/SVGElement.h:
• svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::svgAttributeChanged):

• svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::svgAttributeChanged):

• svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::svgAttributeChanged):

• svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::setOrder):
(WebCore::SVGFEConvolveMatrixElement::setKernelUnitLength):
(WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):

• svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):

• svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):

• svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::setStdDeviation):
(WebCore::SVGFEDropShadowElement::svgAttributeChanged):

• svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::setStdDeviation):
(WebCore::SVGFEGaussianBlurElement::svgAttributeChanged):

• svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::buildPendingResource):
(WebCore::SVGFEImageElement::svgAttributeChanged):

• svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::setRadius):
(WebCore::SVGFEMorphologyElement::svgAttributeChanged):

• svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::svgAttributeChanged):

• svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::svgAttributeChanged):

• svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::svgAttributeChanged):

• svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::svgAttributeChanged):
(WebCore::SVGFilterElement::childrenChanged):

• svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::invalidateFilterPrimitiveParent):

• svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::svgAttributeChanged):

• svg/SVGGeometryElement.cpp:

(WebCore::SVGGeometryElement::svgAttributeChanged):

• svg/SVGGradientElement.cpp:

(WebCore::SVGGradientElement::svgAttributeChanged):
(WebCore::SVGGradientElement::childrenChanged):

• svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::svgAttributeChanged):

• svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::svgAttributeChanged):

• svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::svgAttributeChanged):

• svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::svgAttributeChanged):

• svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::svgAttributeChanged):
(WebCore::SVGMarkerElement::childrenChanged):

• svg/SVGMaskElement.cpp:

(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):

• svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::svgAttributeChanged):

• svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::svgAttributeChanged):
(WebCore::SVGPatternElement::childrenChanged):

• svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::svgAttributeChanged):

• svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::svgAttributeChanged):

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::updateCurrentTranslate):
(WebCore::SVGSVGElement::svgAttributeChanged):

• svg/SVGStopElement.cpp:

(WebCore::SVGStopElement::svgAttributeChanged):

• svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::svgAttributeChanged):

• svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::svgAttributeChanged):

• svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::svgAttributeChanged):

• svg/SVGTextPositioningElement.cpp:

(WebCore::SVGTextPositioningElement::svgAttributeChanged):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::svgAttributeChanged):

• svg/SVGViewElement.cpp:

(WebCore::SVGViewElement::svgAttributeChanged):

LayoutTests:

• svg/animations/animation-leak-list-property-instances.html:

Do a rendering update before checking for leaks.

1:25 PM Changeset in webkit [294066] by Alan Coon

• 7 edits in branches/safari-613-branch

Revert r292888. rdar://problem/80059355

This reverts commit 8c9dcc208cc2be524c3b836f02e4fadc7df788f9/r293995.

1:20 PM Changeset in webkit [294065] by Russell Epstein

• 9 edits in branches/safari-7614.1.13-branch/Source

Versioning.

WebKit-7614.1.13.2

11:47 AM Changeset in webkit [294064] by Jonathan Bedard

• 1 edit in trunk/metadata/contributors.json

Add my GitHub account name to contributors.json.

Reviewed by Jonathan Bedard.

• metadata/contributors.json:

Canonical link: ​https://commits.webkit.org/250468@main

11:35 AM Changeset in webkit [294063] by Wenson Hsieh

• 4 edits in trunk

[Webpage Translation] Avoid removing elements with no children during text manipulation
​https://bugs.webkit.org/show_bug.cgi?id=240287
rdar://91882797

Reviewed by Tim Horton.

After invoking webpage translation on a particular website, the entire page becomes blank and unusable when
scrolling. This happens because of an uncaught JavaScript exception that's thrown when this page's script
attempts to remove an element from its parent using p.removeChild(c), where the node p is not a parent of
the given node c; this, in turn, happens because TextManipulationController has already unparented c from
p while performing text replacement during translation.

In this particular case, the former child node c is an empty div element with no text or children. As such,
it's unnecessary to flag this element for removal in the first place, since doing so isn't necessary to fill in
translated text.

We can avoid this issue by simply skipping over such nodes (i.e. containers that contain no text, no child
elements, and also are not replaced elements) to avoid this and similar compatibility issues that arise when
the DOM is mutated underneath the page, during translation.

Test: TextManipulation.CompleteTextManipulationSkipsEmptyContainers

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::replace):
[Webpage Translation] Avoid removing elements with no children during text manipulation
​https://bugs.webkit.org/show_bug.cgi?id=240287
rdar://91882797

Reviewed by Tim Horton.

Add a new API test to exercise the change.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TestWebKitAPI::TEST):

Canonical link: ​https://commits.webkit.org/250467@main

11:18 AM Changeset in webkit [294062] by sihui_liu@apple.com

• 2 edits in trunk

Unreviewed, add github info to contributors.json.

• metadata/contributors.json:

10:58 AM Changeset in webkit [294061] by Ben Nham

• 2 edits in trunk/LayoutTests

Rebaseline WK1 notifications test expectations after r293921
​https://bugs.webkit.org/show_bug.cgi?id=240153

Unreviewed test gardening.

• platform/mac-wk1/imported/w3c/web-platform-tests/notifications/idlharness.https.any-expected.txt:

10:51 AM Changeset in webkit [294060] by pvollan@apple.com

• 3 edits in trunk/Source/WebKit

[WP] Remove obsolete message filters
​https://bugs.webkit.org/show_bug.cgi?id=240242

Reviewed by Chris Dumez.

Remove obsolete message filters in the WebContent process' sandbox. This filtering is now done in other parts of the system.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

10:46 AM Changeset in webkit [294059] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

Add a webshare quirk for youtube
​https://bugs.webkit.org/show_bug.cgi?id=240303
<rdar://93042649>

Reviewed by Tim Horton.

Manually tested.

• page/Quirks.cpp:

(WebCore::isYouTubeDocument):
(WebCore::Quirks::shouldDisableWebSharePolicy const):

10:44 AM Changeset in webkit [294058] by youenn@apple.com

• 19 edits in trunk/Source

MediaPlayerPrivateRemote::nativeImageForCurrentTime should not use IOSurfaces
​https://bugs.webkit.org/show_bug.cgi?id=240226
<rdar://problem/92969905>

Reviewed by Eric Carlson.

Source/WebCore:

Add a way for MediaPlayer to pass the VideoFrame related to the given frame metadata.

Covered by existing tests, in particular:

• LayoutTests/media/video-canvas-createPattern.html
• LayoutTests/media/video-canvas-drawing.html
• LayoutTests/media/video-canvas-drawing-output.html

• platform/graphics/MediaPlayer.cpp:
• platform/graphics/MediaPlayer.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
• platform/mediastream/libwebrtc/VideoFrameLibWebRTC.h:

Source/WebKit:

On GPUProcess side, when receiving notification of a new frame, create a remote frame
in RemoteMediaPlayerProxy::mediaPlayerOnNewVideoFrameMetadata
and send it to MediaPlayerPrivateRemote::pushVideoFrameMetadata on WebProcess side.
When being asked to create a NativeImage, MediaPlayerPrivateRemote can use that remote image
to get a NativeImage using its videoFrameObjectHeapProxy.
If the remote video frame is not available, get it through videoFrameForCurrentTime and convert it in the same way.
This creates in that case a double IPC. We should probably remove these two IPCs and use VideoFrame as much as we can in follow-up patches.

• GPUProcess/media/RemoteMediaPlayerProxy.h:
• GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
• GPUProcess/media/RemoteVideoFrameObjectHeap.h:
• GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in:
• GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
• WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
• WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
• WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
• WebProcess/GPU/webrtc/SharedVideoFrame.h:

10:20 AM Changeset in webkit [294057] by youenn@apple.com

• 9 edits in trunk/Source

Introduce a canvas-drawImage specific method to get a NativeImage from a video element
​https://bugs.webkit.org/show_bug.cgi?id=240275

Reviewed by Eric Carlson.

Source/WebCore:

Introduce shouldGetNativeImageForCanvasDrawing in HTMLVideoElement/MediaPlayer/MediaPlayerPrivate.
If returning true, we call videoFrameForCurrentTime when drawing a video to canvas.
Otherwise, we directly use video.paintCurrentFrameInContext code path.
This allows skipping a code path where videoFrameForCurrentTime is less efficient than video.paintCurrentFrameInContext.

Covered by existing canvas tests.

• html/HTMLVideoElement.cpp:
• html/HTMLVideoElement.h:
• platform/graphics/MediaPlayer.cpp:
• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayerPrivate.h:

Source/WebKit:

Implement shouldGetNativeImageForCanvasDrawing in MediaPlayerPrivateRemote to return false.
This allows to not do sync IPC in the code path where everything can be done in GPUProcess.

• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:

10:13 AM Changeset in webkit [294056] by Russell Epstein

• 1 copy in tags/WebKit-7614.1.11.9

Tag WebKit-7614.1.11.9.

10:09 AM Changeset in webkit [294055] by Alan Coon

• 1 edit in branches/safari-7613.3.1.1-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

Apply patch. rdar://problem/92780272

8:54 AM Changeset in webkit [294054] by Karl Rackler

• 2 edits in trunk/LayoutTests

[Gardening][ macOS Debug wk2 ] fast/css/variables/test-suite/168.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=239822

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/250460@main

8:16 AM Changeset in webkit [294053] by Karl Rackler

• 2 edits in trunk/LayoutTests

[Gardening][ macOS Debug wk2 ] fast/css/variables/test-suite/168.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=239822

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/250459@main

7:56 AM Changeset in webkit [294052] by Karl Rackler

• 3 edits in trunk/LayoutTests

[Gardening][ iOS ][ macOS Debug wk1 ] webaudio/AudioBuffer/huge-buffer.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=240081

Unreviewed test gardening.

• LayoutTests/platform/ios/TestExpectations:
• LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: ​https://commits.webkit.org/250458@main

7:27 AM Changeset in webkit [294051] by aakash_jain@apple.com

• 4 edits in trunk/Tools/CISupport/build-webkit-org

[build.webkit.org] Allow users to specify custom revision to checkout
​https://bugs.webkit.org/show_bug.cgi?id=240307

Reviewed by Ryan Haddad.

• Tools/CISupport/build-webkit-org/factories.py:

(Factory.init):

• Tools/CISupport/build-webkit-org/loadConfig.py:

(loadBuilderConfig):

• Tools/CISupport/build-webkit-org/steps.py:

(CheckOutSpecificRevision):
(CheckOutSpecificRevision.init):
(CheckOutSpecificRevision.doStepIf):
(CheckOutSpecificRevision.hideStepIf):
(CheckOutSpecificRevision.start):
(ShowIdentifier.start):
(ShowIdentifier.evaluateCommand):

Canonical link: ​https://commits.webkit.org/250457@main

May 10, 2022:

9:27 PM Changeset in webkit [294050] by Ross Kirsling

• 4 edits in trunk

[Temporal] Years 0-999 should be canonically represented with 4 digits, not 6
​https://bugs.webkit.org/show_bug.cgi?id=240294

Reviewed by Yusuke Suzuki.

This patch implements the spec change of ​https://github.com/tc39/proposal-temporal/issues/2082:
The range for 4-digit years in ISO8601 date strings should be 0-9999, not 1000-9999.

• test262/expectations.yaml:

Mark four test cases as passing.

• runtime/TemporalInstant.cpp:

Canonical link: ​https://commits.webkit.org/250456@main

6:07 PM Changeset in webkit [294049] by Alan Coon

• 3 edits
  3 adds in branches/safari-7613.3.1.1-branch

Cherry-pick r293736. rdar://problem/80891555

StorageMap::removeItem may fail to remove item from map
​https://bugs.webkit.org/show_bug.cgi?id=239982
rdar://80891555

Reviewed by Chris Dumez.

Source/WebCore:

We may have updated m_impl, but we don't update iterator for removal. In this case, item is not removed from
map, but currentSize is updated. The mismatch between currentSize and actual size of the map may lead to
underflow and overflow in currentSize when item is added or removed later.

Test: storage/domstorage/sessionstorage/window-open-remove-item.html

• storage/StorageMap.cpp: (WebCore::StorageMap::removeItem):

LayoutTests:

• storage/domstorage/sessionstorage/resources/window-open-remove-item.html: Added.
• storage/domstorage/sessionstorage/window-open-remove-item-expected.txt: Added.
• storage/domstorage/sessionstorage/window-open-remove-item.html: Added.

Canonical link: ​https://commits.webkit.org/250224@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:07 PM Changeset in webkit [294048] by Alan Coon

• 3 edits in branches/safari-7613.3.1.1-branch/Source/ThirdParty/libwebrtc

Cherry-pick r293643. rdar://problem/92445366

[Mac] VTVideoDecoderClass object pointers can become unaligned on x86
​https://bugs.webkit.org/show_bug.cgi?id=239916
<rdar://92445366>

Reviewed by Eric Carlson.

Both the base class and the derived class must be 4-byte aligned on x86, or there
is a chance that a pointer member of that struct will cross a page boundary, and
dereferencing that pointer will fail.

• Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
• Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:

Canonical link: ​https://commits.webkit.org/250147@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:00 PM Changeset in webkit [294047] by ysuzuki@apple.com

• 3 edits
  2 adds in trunk

Upstream TypedArray.prototype.fill speedup from bun
​https://bugs.webkit.org/show_bug.cgi?id=239891

Reviewed by Saam Barati.

This patch imports bun's improvement in TypedArray#fill[1], bun is MIT licensed.
We use memset and its variant to fill TypedArray if possible.
Microbenchmarks show 5x improvement.

ToT Patched

typed-array-fill 1092.0348+-6.2496 ^{221.3430+-9.1261} definitely 4.9337x faster

[1]: ​https://github.com/Jarred-Sumner/WebKit/commit/b06577c1f1de19d2ef3d4a87d14ea41909ddf5fc

• JSTests/microbenchmarks/typed-array-fill.js: Added.
• JSTests/stress/typed-array-fill-complicated.js: Added.

(shouldBe):
(throw.new.Error):

• Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::speciesConstruct):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncIncludes):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate):

Canonical link: ​https://commits.webkit.org/250455@main

5:53 PM Changeset in webkit [294046] by Alan Coon

• 1 copy in tags/WebKit-7614.1.13.1

Tag WebKit-7614.1.13.1.

5:42 PM Changeset in webkit [294045] by Alan Coon

• 9 edits in branches/safari-7614.1.13-branch/Source

Versioning.

WebKit-7614.1.13.1

5:35 PM Changeset in webkit [294044] by Alan Coon

• 9 edits in branches/safari-614.1.11-branch/Source

Versioning.

WebKit-7614.1.11.9

5:26 PM Changeset in webkit [294043] by Alan Coon

• 9 edits in branches/safari-7613.3.1.1-branch/Source

Versioning.

WebKit-7613.3.1.1.1

5:09 PM Changeset in webkit [294042] by Alan Coon

• 12 edits
  1 add in branches/safari-7613.3.1.0-branch/Source

Cherry-pick r293804. rdar://92717726

Crash under WebCore: WebCore::CachedResourceClientWalker<WebCore::CachedImageClient>::next()
​https://bugs.webkit.org/show_bug.cgi?id=240072
<rdar://92717726>

Reviewed by Geoff Garen.

Have CachedResource and CachedResourceClientWalker hold the clients via WeakPtrs instead of
raw pointers and null check them before usage. This is a lot safer.

• Source/WTF/WTF.xcodeproj/project.pbxproj:
• Source/WTF/wtf/WeakHashCountedSet.h: Added.

(WTF::WeakHashCountedSet::begin):
(WTF::WeakHashCountedSet::end):
(WTF::WeakHashCountedSet::begin const):
(WTF::WeakHashCountedSet::end const):
(WTF::WeakHashCountedSet::find):
(WTF::WeakHashCountedSet::find const):
(WTF::WeakHashCountedSet::contains const):
(WTF::WeakHashCountedSet::computeSize const):
(WTF::WeakHashCountedSet::clear):
(WTF::Counter>::add):
(WTF::Counter>::remove):

• Source/WebCore/html/HTMLLinkElement.h:
• Source/WebCore/loader/DocumentThreadableLoader.h:
• Source/WebCore/loader/ImageLoader.h:
• Source/WebCore/loader/LinkLoader.h:
• Source/WebCore/loader/cache/CachedImage.cpp:

(WebCore::CachedImage::addClientWaitingForAsyncDecoding):

• Source/WebCore/loader/cache/CachedResource.cpp:

(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::switchClientsToRevalidatedResource):

• Source/WebCore/loader/cache/CachedResource.h:

(WebCore::CachedResource::hasClients const):
(WebCore::CachedResource::hasClient):
(WebCore::CachedResource::numberOfClients const):

• Source/WebCore/loader/cache/CachedResourceClient.h:
• Source/WebCore/loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
(WebCore::CachedResourceClientWalker::next):

• Source/WebCore/rendering/RenderObject.h:

Canonical link: ​https://commits.webkit.org/250278@main

5:09 PM Changeset in webkit [294041] by Alan Coon

• 3 edits
  3 adds in branches/safari-7613.3.1.0-branch

Cherry-pick r293736. rdar://80891555

StorageMap::removeItem may fail to remove item from map
​https://bugs.webkit.org/show_bug.cgi?id=239982
rdar://80891555

Reviewed by Chris Dumez.

Source/WebCore:

We may have updated m_impl, but we don't update iterator for removal. In this case, item is not removed from
map, but currentSize is updated. The mismatch between currentSize and actual size of the map may lead to
underflow and overflow in currentSize when item is added or removed later.

Test: storage/domstorage/sessionstorage/window-open-remove-item.html

• storage/StorageMap.cpp:

(WebCore::StorageMap::removeItem):

LayoutTests:

• storage/domstorage/sessionstorage/resources/window-open-remove-item.html: Added.
• storage/domstorage/sessionstorage/window-open-remove-item-expected.txt: Added.
• storage/domstorage/sessionstorage/window-open-remove-item.html: Added.

Canonical link: ​https://commits.webkit.org/250224@main

4:56 PM Changeset in webkit [294040] by Alan Coon

• 1 copy in tags/WebKit-7614.1.13

Tag WebKit-7614.1.13.

4:45 PM Changeset in webkit [294039] by Alan Coon

• 9 edits in branches/safari-7613.3.1.0-branch/Source

Versioning.

WebKit-7613.3.1.0.1

4:31 PM Changeset in webkit [294038] by Jonathan Bedard

• 4 edits in trunk/Tools

[git-webkit] Fail quickly for invalid bugzilla credentials
​https://bugs.webkit.org/show_bug.cgi?id=240182
<rdar://problem/92879251>

Reviewed by Stephanie Lewis.

• Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:

(Branch.main): Check credentials before creating an issue, exit
program if issue creation fails.

Canonical link: ​https://commits.webkit.org/250454@main

4:26 PM Changeset in webkit [294037] by Alan Coon

• 1 delete in branches/safari-613.3.1.0-branch

Delete branch.

4:26 PM Changeset in webkit [294036] by Alan Coon

• 1 delete in branches/safari-613.3.1.1-branch

Delete branch.

4:26 PM Changeset in webkit [294035] by Alan Coon

• 1 copy in branches/safari-7613.3.1.1-branch

New branch.

4:25 PM Changeset in webkit [294034] by Alan Coon

• 1 copy in branches/safari-7613.3.1.0-branch

New branch.

4:13 PM Changeset in webkit [294033] by Alan Coon

• 1 copy in branches/safari-613.3.1.1-branch

New branch.

4:13 PM Changeset in webkit [294032] by Alan Coon

• 1 copy in branches/safari-613.3.1.0-branch

New branch.

4:10 PM Changeset in webkit [294031] by Alan Coon

• 1 delete in branches/safari-613.3.1.1-branch

Delete branch.

4:10 PM Changeset in webkit [294030] by Alan Coon

• 1 delete in branches/safari-613.3.1.0-branch

Delete branch.

3:53 PM Changeset in webkit [294029] by Truitt Savell

• 2 edits in trunk/LayoutTests

Rebase inspector/timeline/line-column.html for Mac
​https://bugs.webkit.org/show_bug.cgi?id=240291

Unreviewed test gardening.

• LayoutTests/inspector/timeline/line-column-expected.txt:

Canonical link: ​https://commits.webkit.org/250453@main

3:30 PM Changeset in webkit [294028] by Alan Coon

• 1 copy in branches/safari-613.3.1.1-branch

New branch.

3:30 PM Changeset in webkit [294027] by Alan Coon

• 1 copy in branches/safari-613.3.1.0-branch

New branch.

3:30 PM Changeset in webkit [294026] by Alan Coon

• 1 delete in branches/safari-613.3.1.1-branch

Delete branch.

3:29 PM Changeset in webkit [294025] by Alan Coon

• 1 delete in branches/safari-613.3.1.0-branch

Delete branch.

3:28 PM Changeset in webkit [294024] by Alan Coon

• 1 copy in branches/safari-613.3.1.1-branch

New branch.

3:28 PM Changeset in webkit [294023] by Alan Coon

• 1 copy in branches/safari-613.3.1.0-branch

New branch.

3:28 PM Changeset in webkit [294022] by Alan Coon

• 1 delete in branches/safari-613.3.0-branch

Delete branch.

3:28 PM Changeset in webkit [294021] by Alan Coon

• 1 delete in branches/safari-613.3.1-branch

Delete branch.

3:26 PM Changeset in webkit [294020] by Alan Coon

• 1 copy in branches/safari-613.3.1-branch

New branch.

3:26 PM Changeset in webkit [294019] by Alan Coon

• 1 copy in branches/safari-613.3.0-branch

New branch.

3:19 PM Changeset in webkit [294018] by Chris Dumez

• 56 edits
  1 add
  25 deletes in trunk

Unreviewed, revert r288307 as it caused correctness issues
​https://bugs.webkit.org/show_bug.cgi?id=240280
<rdar://92641509>

Revert r288307 again since it introduced some bad regressions, identified
on the radar.

Canonical link: ​https://commits.webkit.org/250452@main

2:55 PM Changeset in webkit [294017] by mark.lam@apple.com

• 24 edits in trunk/Source/JavaScriptCore

Add optional Integrity checks at JSC API boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=240264

Reviewed by Yusuke Suzuki.

1. Defined ENABLE_EXTRA_INTEGRITY_CHECKS in Integrity.h. JSC developers can enable this for their local build if they want to enable more prolific Integrity audits. This is disabled by default.

This feature is currently only supported for USE(JSVALUE64) targets.

The following changes only take effect if ENABLE(EXTRA_INTEGRITY_CHECKS) is enabled.
Otherwise, these are no-ops.

2. Added Integrity audits to all toJS and toRef conversion functions in APICast.h. This will help us detect if bad values are passed across the API boundary.

3. Added some Integrity audits in JSValue.mm where the APICast ones were insufficient.

The following changes are in effect even when ENABLE(EXTRA_INTEGRITY_CHECKS) is
disabled. Some of these were made to support ENABLE(EXTRA_INTEGRITY_CHECKS), and
some are just clean up in related code that I had to touch along the way.

4. Moved isSanePointer() to Integrity.h so that it can be used in more places.

5. Changed VM registration with the VMInspector so that it's registered earlier and removed later. Integrity audits may need to audit VM pointers while the VM is being constructed and destructed.

6. Added VM::m_isInService to track when the VM is fully constructed or about to be destructed since the VM is now registered with the VMInspector differently (see (4) above). Applied this check in places that need it.

7. Fixed VMInspector::isValidExecutableMemory() to check the ExecutableAllocator directly without iterating VMs (which is completely unnecessary).

8. Fixed VMInspector::isValidExecutableMemory() and VMInspector::codeBlockForMachinePC() to use AdoptLock. This fixes a race condition where the lock can be contended after ensureIsSafeToLock() succeeds.

9. Added VMInspector::isValidVM() to check if a VM pointer is registered or not. VMInspector caches the most recently added or found VM so that isValidVM() can just check the cache for its fast path.

10. Moved the implementation of VMInspector::verifyCell() to Integrity::analyzeCell()

and add more checks to it. VMInspector::verifyCell() now calls Integrity::verifyCell()
which uses Integrity::analyzeCell() to do the real cell analysis.

11. Also strengten Integrity::auditStructureID() so that it will check if a

Structure's memory has been released. This change is enabled on Debug builds
by default as well as when ENABLE(EXTRA_INTEGRITY_CHECKS). It is disabled
on Release builds.

• API/APICast.h:

(toJS):
(toJSForGC):
(uncheckedToJS):
(toRef):
(toGlobalRef):

• API/JSContext.mm:
• API/JSContextRef.cpp:
• API/JSScript.mm:
• API/JSValue.mm:

(ObjcContainerConvertor::convert):
(objectToValueWithoutCopy):
(objectToValue):

• API/JSVirtualMachine.mm:
• API/JSWeakPrivate.cpp:
• API/glib/JSCContext.cpp:
• API/glib/JSCWrapperMap.cpp:
• API/tests/JSObjectGetProxyTargetTest.cpp:
• bytecode/SpeculatedType.cpp:

(JSC::speculationFromCell):
(JSC::isSanePointer): Deleted.

• heap/HeapFinalizerCallback.cpp:
• heap/WeakSet.h:
• runtime/Structure.h:
• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):

• runtime/VM.h:

(JSC::VM::isInService const):

• tools/HeapVerifier.cpp:

(JSC::HeapVerifier::checkIfRecorded):

• tools/Integrity.cpp:

(JSC::Integrity::Random::reloadAndCheckShouldAuditSlow):
(JSC::Integrity::auditCellMinimallySlow):
(JSC::Integrity::doAudit):
(JSC::Integrity::Analyzer::analyzeVM):
(JSC::Integrity::Analyzer::analyzeCell):
(JSC::Integrity::doAuditSlow):
(JSC::Integrity::verifyCell):
(): Deleted.
(JSC::Integrity::auditCellFully): Deleted.

• tools/Integrity.h:

(JSC::isSanePointer):
(JSC::Integrity::auditCell):
(JSC::Integrity::audit):

• tools/IntegrityInlines.h:

(JSC::Integrity::auditCell):
(JSC::Integrity::auditCellFully):
(JSC::Integrity::auditStructureID):
(JSC::Integrity::doAudit):

• tools/VMInspector.cpp:

(JSC::VMInspector::add):
(JSC::VMInspector::remove):
(JSC::VMInspector::isValidVMSlow):
(JSC::VMInspector::dumpVMs):
(JSC::VMInspector::isValidExecutableMemory):
(JSC::VMInspector::codeBlockForMachinePC):
(JSC::ensureIsSafeToLock): Deleted.

• tools/VMInspector.h:

(JSC::VMInspector::isValidVM):
(): Deleted.
(JSC::VMInspector::unusedVerifier): Deleted.

• tools/VMInspectorInlines.h:

(JSC::VMInspector::verifyCell):
(JSC::VMInspector::verifyCellSize): Deleted.

2:15 PM Changeset in webkit [294016] by Brent Fulgham

• 4 edits in trunk/Source/WebCore

Remove the unneeded StylePropertiesBase after Bug 240244
​https://bugs.webkit.org/show_bug.cgi?id=240282

Reviewed by Antti Koivisto.

Now that we have removed the abandoned CSSDeferredParser, we no longer need the
StylePropertiesBase class. This patch removes this layer to simplify the code.

• css/StyleProperties.h:

(WebCore::StyleProperties::type const):
(WebCore::StyleProperties::cssParserMode const):
(WebCore::StyleProperties::StyleProperties):
(WebCore::StyleProperties::deref const):
(isType):
(WebCore::StylePropertiesBase::type const): Deleted.
(WebCore::StylePropertiesBase::cssParserMode const): Deleted.
(WebCore::StylePropertiesBase::StylePropertiesBase): Deleted.
(WebCore::StylePropertiesBase::deref const): Deleted.

• css/StyleRule.cpp:

(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::create):
(WebCore::StyleRule::properties const): Deleted.

• css/StyleRule.h:

1:52 PM Changeset in webkit [294015] by Said Abou-Hallawa

• 2 edits in trunk/Source/WebCore

[GPU Process] [Filters] FilterImages can be leaked
​https://bugs.webkit.org/show_bug.cgi?id=240274

Reviewed by Simon Fraser.

When a FilterEffect is dynamically updated we clear its result FilterImage.
We also need to clear all the result FilterImages of all the FilterEffects
recursively which takes this changing FilterEffect as an input.

Clearing the result FilterImage of the changing FilterEffect happens by
removing the entry from FilterResults::m_results.

Clearing the FilterImages of the dependent FilterEffects happens by using
FilterResults::m_resultReferences.

What is missing is removing the FilterImage entry itself from
FilterResults::m_resultReferences.

• platform/graphics/filters/FilterResults.h:

(WebCore::FilterResults::clearEffectResult):

1:22 PM Changeset in webkit [294014] by Jonathan Bedard

• 2 edits in trunk/Tools

Patch is merged via merge-queue, but bugzilla is not closed
​https://bugs.webkit.org/show_bug.cgi?id=240155
<rdar://problem/93045114>

Reviewed by Aakash Jain.

• CISupport/ews-build/steps.py:

(UpdatePullRequest): Allow subsequent steps to run if we fail to update a PR.

Canonical link: ​https://commits.webkit.org/250448@main

12:58 PM Changeset in webkit [294013] by Jonathan Bedard

• 4 edits in trunk/Websites/webkit.org

[webkit.org] Replace svn.webkit.org with GitHub
​https://bugs.webkit.org/show_bug.cgi?id=240093
<rdar://problem/92760014>

Reviewed by Ryan Haddad, Aakash Jain and Dewei Zhu.

• wp-content/themes/webkit/css-status.php: Replace svn.webkit.org with raw.githubusercontent.com.
• wp-content/themes/webkit/status.php: Ditto.
• wp-content/themes/webkit/team.php: Ditto.

Canonical link: ​https://commits.webkit.org/250447@main

11:42 AM Changeset in webkit [294012] by ntim@apple.com

• 4 edits
  3 adds in trunk

Fix inertness of pseudo-elements
​https://bugs.webkit.org/show_bug.cgi?id=239831

Reviewed by Antti Koivisto.

When we adjust style for a pseudo-element, m_element and document().activeModalDialog() are both null. So we accidentally reset inertness to false in those cases.

Fix this by making checking for m_element's existence too.

LayoutTests/imported/w3c:

• web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
• web-platform-tests/inert/inert-pseudo-element-hittest.html: Added.

Source/WebCore:

Test: imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest.html

• style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjust const):

LayoutTests:

• platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.

11:04 AM Changeset in webkit [294011] by Jonathan Bedard

• 7 edits
  1 add in trunk/Tools

[GitHub] git commit generates a nicely formatted commit log but is missing bug information
​https://bugs.webkit.org/show_bug.cgi?id=240254
<rdar://93033766 >

Reviewed by Chris Dumez.

• Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/init.py: Add "commit" program.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:

(Branch.main): Invoke Commit.bug_urls.

• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:

(FilteredCommand.parser): Typo fix in log message.

• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/commit.py: Added.

(Commit.parser):
(Commit.bug_urls): Extract a list of bug URLs from an issue.
(Commit.main): Extract commit message information from issue.

• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py:

Canonical link: ​https://commits.webkit.org/250445@main

10:28 AM Changeset in webkit [294010] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Optimize Replayer::applyItem() slightly
​https://bugs.webkit.org/show_bug.cgi?id=240258

Reviewed by Wenson Hsieh.

Convert a series of if statements into a switch.

De-templatize applyFontItem<> since DrawGlyphs is the only instantiation, and the
name was confusing.

• platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::applyDrawGlyphs):
(WebCore::DisplayList::Replayer::applyItem):
(WebCore::DisplayList::applyFontItem): Deleted.

10:00 AM Changeset in webkit [294009] by Alan Coon

• 1 copy in tags/WebKit-7614.1.12.2

Tag WebKit-7614.1.12.2.

9:53 AM Changeset in webkit [294008] by Alan Coon

• 9 edits in branches/safari-7614.1.12-branch/Source

Versioning.

WebKit-7614.1.12.2

9:48 AM Changeset in webkit [294007] by Brent Fulgham

• 29 edits
  3 deletes in trunk

Remove abandoned CSSDeferredParser implementation and feature flag
​https://bugs.webkit.org/show_bug.cgi?id=240244

Reviewed by Antti Koivisto.

This patch rolls out the abandoned CSSDeferredParser implementation added in Bug 165743.

Source/WebCore:

• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::keyframes const):
(WebCore::StyleRuleKeyframes::wrapperAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperRemoveKeyframe):
(WebCore::StyleRuleKeyframes::findKeyframeIndex const):
(WebCore::StyleRuleKeyframes::parseDeferredRulesIfNeeded const): Deleted.

• css/CSSKeyframesRule.h:
• css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::MutableStyleProperties):
(WebCore::StyleProperties::PropertyReference::cssText const):
(WebCore::DeferredStyleProperties::create): Deleted.
(WebCore::DeferredStyleProperties::DeferredStyleProperties): Deleted.
(WebCore::DeferredStyleProperties::parseDeferredProperties): Deleted.

• css/StyleProperties.h:

(WebCore::StylePropertiesBase::deref const):
(isType):

• css/StyleRule.cpp:

(WebCore::StyleRule::properties const):
(WebCore::StyleRuleGroup::childRules const):
(WebCore::StyleRuleGroup::wrapperInsertRule):
(WebCore::StyleRuleGroup::wrapperRemoveRule):
(WebCore::DeferredStyleGroupRuleList::DeferredStyleGroupRuleList): Deleted.
(WebCore::DeferredStyleGroupRuleList::parseDeferredRules): Deleted.
(WebCore::DeferredStyleGroupRuleList::parseDeferredKeyframes): Deleted.
(WebCore::StyleRuleGroup::parseDeferredRulesIfNeeded const): Deleted.

• css/StyleRule.h:

(WebCore::StyleRule::propertiesWithoutDeferredParsing const): Deleted.
(WebCore::StyleRuleGroup::childRulesWithoutDeferredParsing const): Deleted.

• css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):
(WebCore::traverseRulesInVector):
(WebCore::StyleSheetContents::traverseSubresources const):

• css/parser/CSSDeferredParser.cpp: Removed.
• css/parser/CSSDeferredParser.h: Removed.
• css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):

• css/parser/CSSParser.h:
• css/parser/CSSParserContext.cpp:

(WebCore::operator==):
(WebCore::add):

• css/parser/CSSParserContext.h:
• css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::CSSParserImpl):
(WebCore::CSSParserImpl::parseStyleSheet):
(WebCore::CSSParserImpl::consumeMediaRule):
(WebCore::CSSParserImpl::consumeSupportsRule):
(WebCore::CSSParserImpl::consumeKeyframesRule):
(WebCore::CSSParserImpl::consumeLayerRule):
(WebCore::CSSParserImpl::consumeContainerRule):
(WebCore::CSSParserImpl::consumeStyleRule):
(WebCore::CSSParserImpl::createDeferredStyleProperties): Deleted.
(WebCore::CSSParserImpl::parseDeferredDeclaration): Deleted.
(WebCore::CSSParserImpl::parseDeferredRuleList): Deleted.
(WebCore::CSSParserImpl::parseDeferredKeyframeList): Deleted.
(WebCore::CSSParserImpl::adoptTokenizerEscapedStrings): Deleted.

• css/parser/CSSParserImpl.h:

(WebCore::CSSParserImpl::tokenizer const):
(WebCore::CSSParserImpl::deferredParser const): Deleted.

• style/ElementRuleCollector.cpp:

(WebCore::Style::ElementRuleCollector::collectMatchingRulesForList):

• style/StyleInvalidator.cpp:

(WebCore::Style::shouldDirtyAllStyle):

• testing/Internals.cpp:

(WebCore::deferredStyleRulesCountForList): Deleted.
(WebCore::Internals::deferredStyleRulesCount): Deleted.
(WebCore::deferredGroupRulesCountForList): Deleted.
(WebCore::Internals::deferredGroupRulesCount): Deleted.
(WebCore::deferredKeyframesRulesCountForList): Deleted.
(WebCore::Internals::deferredKeyframesRulesCount): Deleted.

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDeferredCSSParserEnabled): Deleted.
(WKPreferencesGetDeferredCSSParserEnabled): Deleted.

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Source/WTF:

• Scripts/Preferences/WebPreferences.yaml:

LayoutTests:

• fast/css/deferred-parsing/dynamic-external-style-expected.txt: Removed.
• fast/css/deferred-parsing/dynamic-external-style.html: Removed.
• fast/css/deferred-parsing/dynamic-style-in-document-expected.txt: Removed.
• fast/css/deferred-parsing/dynamic-style-in-document.html: Removed.
• fast/css/deferred-parsing/hover-test-expected.txt: Removed.
• fast/css/deferred-parsing/hover-test.html: Removed.
• fast/css/deferred-parsing/keyframes-rule-expected.txt: Removed.
• fast/css/deferred-parsing/keyframes-rule.html: Removed.
• fast/css/deferred-parsing/media-print-expected.txt: Removed.
• fast/css/deferred-parsing/media-print.html: Removed.
• fast/css/deferred-parsing/nth-of-type-expected.txt: Removed.
• fast/css/deferred-parsing/nth-of-type.html: Removed.
• fast/css/deferred-parsing/resources/basic-sheet.css: Removed.
• fast/css/deferred-parsing/simple-external-style-expected.txt: Removed.
• fast/css/deferred-parsing/simple-external-style.html: Removed.
• fast/css/deferred-parsing/simple-style-in-document-expected.txt: Removed.
• fast/css/deferred-parsing/simple-style-in-document.html: Removed.
• fast/css/deferred-parsing/supports-rule-expected.txt: Removed.
• fast/css/deferred-parsing/supports-rule.html: Removed.
• platform/ios-wk2/TestExpectations:
• platform/ios/TestExpectations:

3:13 AM Changeset in webkit [294006] by youenn@apple.com

• 3 edits in trunk/Source/WebCore

Create a stopped CacheStorageConnection for workers in case of detached documents
​https://bugs.webkit.org/show_bug.cgi?id=240224
<rdar://problem/92853663>

Reviewed by Chris Dumez.

A worker might not always have a main thread connection as its document may be detached.
In that case, we now create a StoppedCacheStorageConnection that will always return Error::Stopped to any callback.

Covered by existing tests.

• Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::StoppedCacheStorageConnection::create):
(WebCore::createMainThreadConnection):
(WebCore::WorkerCacheStorageConnection::WorkerCacheStorageConnection):
(WebCore::WorkerCacheStorageConnection::~WorkerCacheStorageConnection):
(WebCore::WorkerCacheStorageConnection::create): Deleted.

• Modules/cache/WorkerCacheStorageConnection.h:

1:52 AM Changeset in webkit [294005] by youenn@apple.com

• 6 edits in trunk/Source/WebKit

RemoteVideoFrameObjectHeapProxyProcessor binary semaphore usage might trigger deadlocks in case of GPUProcess crash
​https://bugs.webkit.org/show_bug.cgi?id=240161
<rdar://problem/92849827>

Reviewed by Eric Carlson.

In case of GPUProcess crash when waiting for a converted buffer, we would never call the semaphore signal method.
This would hang the main thread since this code path is main thread only.
To prevent this, we use synchronous IPC to send the buffer conversion order.
Once it is done, we use the binary semaphore to synchronize the main thread with the work queue on which we are receiving the converted buffer.
It is ok to use a binary semaphore at that point since we know the web process has or is processing the converted buffer IPC messages.
We also make sure to recreate the SharedVideoFrameWriter in case it was disabled due the GPUProcess connection being closed.

Covered by existing tests, in particular LayoutTests/webrtc/captureCanvas-webrtc.html.

• GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:

(WebKit::RemoteVideoFrameObjectHeap::convertBuffer):

• GPUProcess/media/RemoteVideoFrameObjectHeap.h:
• GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in:
• WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:

(WebKit::RemoteVideoFrameObjectHeapProxyProcessor::getNativeImage):

• WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.h:
• WebProcess/GPU/webrtc/SharedVideoFrame.h:

(WebKit::SharedVideoFrameWriter::isDisabled const):

12:45 AM Changeset in webkit [294004] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

com.apple.WebKit.GPU leaks CMBlockBuffer
​https://bugs.webkit.org/show_bug.cgi?id=240267
rdar://92655222

Patch by Jean-Yves Avenard <​jean-yves.avenard@apple.com> on 2022-05-09
Reviewed by Jer Noble.

• platform/graphics/cocoa/CMUtilities.mm:

(WebCore::toCMSampleBuffer): adopt newly created CMBlockBuffer rather than increase the refcount.

# Please populate the above commit message. Lines starting
# with '#' will be ignored

# com.apple.WebKit.GPU leaks CMBlockBuffer
# ​https://bugs.webkit.org/show_bug.cgi?id=240267
# rdar://92655222
#
# Reviewed by Jer Noble.
#
# * platform/graphics/cocoa/CMUtilities.mm:
# (WebCore::toCMSampleBuffer): adopt newly created CMBlockBuffer rather than increase the refcount.

# On branch bz/240267
# Your branch is ahead of 'origin/main' by 1 commit.
# (use "git push" to publish your local commits)
#
# Changes to be committed:
# (use "git restore --staged <file>..." to unstage)
# modified: Source/WebCore/ChangeLog
#

# Please populate the above commit message. Lines starting
# with '#' will be ignored

# On branch bz/240267
# Your branch is ahead of 'origin/main' by 1 commit.
# (use "git push" to publish your local commits)
#
# nothing to commit, working tree clean

Canonical link: ​https://commits.webkit.org/250440@main