⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 30, 2022:

11:43 PM Changeset in webkit [295044] by commit-queue@webkit.org
  • 2 edits in trunk/Source

RemoteVideoFrameProxy::pixelBuffer should properly compute canUseIOSurface
​https://bugs.webkit.org/show_bug.cgi?id=241100

Patch by Youenn Fablet <​youennf@gmail.com> on 2022-05-30
Reviewed by Eric Carlson.

We can use IOSurface when doing WebGL in WebProcess, instead of when doing WebGL in GPUProcess.
Update canUseIOSurface accordingly.
Add error logging when creating a CVPixelBufferRef.

  • Source/WebCore/platform/graphics/cv/CVUtilities.mm:

(WebCore::createCVPixelBuffer):

  • Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:

(WebKit::RemoteVideoFrameProxy::pixelBuffer const):

Canonical link: ​https://commits.webkit.org/251139@main

10:49 PM Changeset in webkit [295043] by Brandon
  • 1 edit in trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c

[libpas] Build fix macOS
​https://bugs.webkit.org/show_bug.cgi?id=241116

Reviewed by Yusuke Suzuki.

Convert from int to uint64_t. Line should always be a positive number.

  • Source/bmalloc/libpas/src/libpas/pas_utils.c:

(pas_assertion_failed_no_inline):
(pas_assertion_failed_no_inline_with_extra_detail):

Canonical link: ​https://commits.webkit.org/251138@main

9:50 PM Changeset in webkit [295042] by ysuzuki@apple.com
  • 1 edit in trunk/.clangd

Clangd should always interpret headers as C++
​https://bugs.webkit.org/show_bug.cgi?id=241118

Reviewed by Saam Barati.

Attach -xc++ flag to headers in .clangd to interpret all headers as C++ by default.

  • .clangd:

Canonical link: ​https://commits.webkit.org/251137@main

9:18 PM Changeset in webkit [295041] by Fujii Hironori
  • 1 edit in trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp

REGRESSION(251043@main): "ASSERTION FAILED: channel" in WebCore::ThreadableWebSocketChannel::create
​https://bugs.webkit.org/show_bug.cgi?id=241087

Reviewed by Don Olmstead.

Since 251043@main, WinCairo WK1 was crashing for WebSocket tests.
channel variable was null in ThreadableWebSocketChannel::create.
In the case, it should call WebSocketChannel::create like Mac port
does.

  • Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::create):

Canonical link: ​https://commits.webkit.org/251136@main

9:13 PM Changeset in webkit [295040] by ysuzuki@apple.com
  • 6 edits in trunk/Source

[JSC] Make VMEntryScope cheap
​https://bugs.webkit.org/show_bug.cgi?id=241091

Reviewed by Mark Lam.

This patch makes VMEntryScope cheap. In some microbenchmarks, we observe repeated execution of VMEntryScope
because of many ticks driven by microtasks. And currently VMEntryScope is designed to be non-cheap based on
the assumption that this is not frequently executed.

  1. We add isJSThread flag to Thread so that we can skip some of unnecessary initializations.
  2. Appropriately set UNLIKELY / LIKELY for the major path.
  3. Make DateCache::resetIfNecessary fast path inlined.

ToT
Time(doxbee-async-es2017-native): 24 ms.
Time(doxbee-promises-es2015-native): 44.9 ms.
Time(fibonacci-async-es2017-native): 197.6 ms.
Time(parallel-async-es2017-native): 109.1 ms.
Time(parallel-promises-es2015-native): 80.4 ms.

Patched
Time(doxbee-async-es2017-native): 21.4 ms.
Time(doxbee-promises-es2015-native): 36.4 ms.
Time(fibonacci-async-es2017-native): 168.1 ms.
Time(parallel-async-es2017-native): 103.7 ms.
Time(parallel-promises-es2015-native): 70.9 ms.

  • Source/JavaScriptCore/runtime/JSDateMath.cpp:

(JSC::DateCache::resetIfNecessarySlow):
(JSC::DateCache::resetIfNecessary): Deleted.

  • Source/JavaScriptCore/runtime/JSDateMath.h:

(JSC::DateCache::resetIfNecessary):

  • Source/JavaScriptCore/runtime/VM.h:

(JSC::VM::firePrimitiveGigacageEnabledIfNecessary):

  • Source/JavaScriptCore/runtime/VMEntryScope.cpp:

(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):

  • Source/WTF/wtf/Threading.cpp:

(WTF::Thread::registerJSThread):

  • Source/WTF/wtf/Threading.h:

Canonical link: ​https://commits.webkit.org/251135@main

6:26 PM Changeset in webkit [295039] by Alan Bujtas
  • 5 edits
    1 copy
    1 add in trunk/Source/WebCore

Move core flex layout to FlexLayout
​https://bugs.webkit.org/show_bug.cgi?id=241106

Reviewed by Antti Koivisto.

  • Source/WebCore/Headers.cmake:
  • Source/WebCore/Sources.txt:
  • Source/WebCore/WebCore.xcodeproj/project.pbxproj:
  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::FlexFormattingContext::computeAvailableLogicalVerticalSpace const): Deleted.
(WebCore::Layout::FlexFormattingContext::computeAvailableLogicalHorizontalSpace const): Deleted.
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForStretchingFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::alignFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::justifyFlexItems): Deleted.

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp: Added.

(WebCore::Layout::FlexLayout::FlexLayout):
(WebCore::Layout::FlexLayout::computeAvailableLogicalVerticalSpace const):
(WebCore::Layout::FlexLayout::computeAvailableLogicalHorizontalSpace const):
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexLayout::alignFlexItems):
(WebCore::Layout::FlexLayout::justifyFlexItems):
(WebCore::Layout::FlexLayout::layout):

  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.h: Copied from Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h.

(WebCore::Layout::FlexLayout::formattingState const):
(WebCore::Layout::FlexLayout::flexBoxStyle const):

Canonical link: ​https://commits.webkit.org/251134@main

4:59 PM Changeset in webkit [295038] by mmaxfield@apple.com
  • 1 edit in trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp

[Cocoa] Rename [de]normalizeWeight() to [de]normalizeGXWeight()
​https://bugs.webkit.org/show_bug.cgi?id=241112

Reviewed by Alan Bujtas.

Weights are measured in 3 different scales:

  1. CSS weights (1 - 999)
  2. Core Text weights (-1.0 - 1.0)
  3. TrueType GX weights (0.0ish to 2.0ish, it's not really defined, only the "default" value

of 1.0 is defined).

Our current functions convert between CSS weights and TrueType GX weights, so this makes that more
clear. A subsequent patch will add conversions between CSS weights and Core Text weights.

No new tests because there is no behavior change.

  • Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::normalizeGXWeight):
(WebCore::denormalizeGXWeight):
(WebCore::preparePlatformFont):
(WebCore::variationCapabilitiesForFontDescriptor):
(WebCore::normalizeWeight): Deleted.
(WebCore::denormalizeWeight): Deleted.

Canonical link: ​https://commits.webkit.org/251132@main

4:58 PM Changeset in webkit [295037] by commit-queue@webkit.org
  • 1 edit in trunk/Source/WTF/wtf/RAMSize.cpp

Include <sys/sysinfo.h> on FreeBSD too
​https://bugs.webkit.org/show_bug.cgi?id=241099

Patch by Leonardo Taccari <​leot@NetBSD.org> on 2022-05-30
Reviewed by Fujii Hironori.

sysinfo(2)/sysinfo(3) is used also in FreeBSD, include corresponding
<sys/sysinfo.h> header too.

  • Source/WTF/wtf/RAMSize.cpp:

Canonical link: ​https://commits.webkit.org/251132@main

4:41 PM Changeset in webkit [295036] by ysuzuki@apple.com
  • 3 edits in trunk/Source/JavaScriptCore/heap

[JSC] Make Strong::set cheap
​https://bugs.webkit.org/show_bug.cgi?id=241090

Reviewed by Mark Lam.

HandleSet::writeBarrier is frequently called because it is called every time we set a value in Strong<>.
This patch optimizes it,

  1. We should make it inline function since it has a super fast path major use can be covered. And this function is small.
  2. We should not always remove a node from the list first. We should insert / remove it only when necessary.
  3. Remove m_immediateList since it is not necessary.
  4. Make HandleNode as a derived class of BasicRawSentinelNode to make implementation simpler.

This change improves promise benchmarks score since promise uses microtasks which hold values via Strong<>.

ToT
Time(doxbee-async-bluebird): 42.8 ms.
Time(doxbee-async-es2017-babel): 36.4 ms.
Time(doxbee-async-es2017-native): 28.3 ms.
Time(doxbee-promises-bluebird): 514.2 ms.
Time(doxbee-promises-es2015-native): 44.8 ms.
Time(fibonacci-async-es2017-babel): 380.5 ms.
Time(fibonacci-async-es2017-native): 218.2 ms.
Time(parallel-async-bluebird): 648.8 ms.
Time(parallel-async-es2017-babel): 116.9 ms.
Time(parallel-async-es2017-native): 115.6 ms.
Time(parallel-promises-bluebird): 638 ms.
Time(parallel-promises-es2015-native): 82 ms.

Patched
Time(doxbee-async-bluebird): 38 ms.
Time(doxbee-async-es2017-babel): 27 ms.
Time(doxbee-async-es2017-native): 19.5 ms.
Time(doxbee-promises-bluebird): 508.3 ms.
Time(doxbee-promises-es2015-native): 33.3 ms.
Time(fibonacci-async-es2017-babel): 349.1 ms.
Time(fibonacci-async-es2017-native): 151 ms.
Time(parallel-async-bluebird): 639.6 ms.
Time(parallel-async-es2017-babel): 100.9 ms.
Time(parallel-async-es2017-native): 101.9 ms.
Time(parallel-promises-bluebird): 614 ms.
Time(parallel-promises-es2015-native): 70.9 ms.

  • Source/JavaScriptCore/heap/HandleSet.cpp:

(JSC::HandleSet::writeBarrier): Deleted.

  • Source/JavaScriptCore/heap/HandleSet.h:

(JSC::HandleSet::heapFor):
(JSC::HandleSet::allocate):
(JSC::HandleSet::deallocate):
(JSC::HandleSet::writeBarrier):
(JSC::HandleSet::toHandle): Deleted.
(JSC::HandleSet::toNode): Deleted.
(JSC::HandleNode::HandleNode): Deleted.
(JSC::HandleNode::setPrev): Deleted.
(JSC::HandleNode::prev): Deleted.
(JSC::HandleNode::setNext): Deleted.
(JSC::HandleNode::next): Deleted.

  • Source/JavaScriptCore/heap/Strong.h:

(JSC::Strong::set):

Canonical link: ​https://commits.webkit.org/251131@main

3:10 PM Changeset in webkit [295035] by Antti Koivisto
  • 9 edits
    12 adds in trunk

Fix invalidation with scope breaking :is/not()
​https://bugs.webkit.org/show_bug.cgi?id=241098

Reviewed by Alan Bujtas.

Selector like :has(:is(foo bar)) can be affected by mutations outside the :has scope.

  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/child-indexed-pseudo-classes-in-has-expected.txt: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/child-indexed-pseudo-classes-in-has.html: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/empty-pseudo-in-has-expected.txt: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/empty-pseudo-in-has.html: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-adjacent-position.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-ancestor-position.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-parent-position.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-sibling-position.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/is-pseudo-containing-complex-in-has-expected.txt: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/is-pseudo-containing-complex-in-has.html: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/link-pseudo-in-has-expected.txt: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/link-pseudo-in-has.html: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/not-pseudo-containing-complex-in-has-expected.txt: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/not-pseudo-containing-complex-in-has.html: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/typed-child-indexed-pseudo-classes-in-has-expected.txt: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/typed-child-indexed-pseudo-classes-in-has.html: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/w3c-import.log:

Reimport selector invalidation tests.

  • Source/WebCore/style/ChildChangeInvalidation.cpp:

(WebCore::Style::ChildChangeInvalidation::invalidateForChangedElement):
(WebCore::Style::needsDescendantTraversal):

  • Source/WebCore/style/RuleFeature.cpp:

(WebCore::Style::isSiblingOrSubject):
(WebCore::Style::isHasPseudoClassMatchElement):
(WebCore::Style::computeNextMatchElement):
(WebCore::Style::computeHasPseudoClassMatchElement):
(WebCore::Style::computeSubSelectorMatchElement):
(WebCore::Style::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):

Detect the case and fall back to very wide invalidation (same a non-subject :has() for now).

  • Source/WebCore/style/RuleFeature.h:

(WebCore::Style::RuleFeatureSet::usesHasPseudoClass const):

  • Source/WebCore/style/StyleInvalidator.cpp:

(WebCore::Style::Invalidator::invalidateStyleWithMatchElement):

Canonical link: ​https://commits.webkit.org/251130@main

3:03 PM Changeset in webkit [295034] by Fujii Hironori
  • 4 edits in trunk

WebKitTestRunner shouldn't link object files of JavaScriptCore and WebCore
​https://bugs.webkit.org/show_bug.cgi?id=241002

Reviewed by Don Olmstead.

243269@main removed WebKit from WebKitTestRunner_FRAMEWORKS for
WPE. But, it should be there not to link object files of
JavaScriptCore and WebCore to WebKitTestRunner. In WPE builds,
JavaScriptCore and WebCore API are exported from WebKit shared
library. WebKit consumers shouldn't link with object files of
JavaScriptCore and WebCore.

However, adding WebKit to WebKitTestRunner_FRAMEWORKS introduced a
new problem that the object file of LowLevelInterpreter.cpp was linked
into WebKitTestRunner. This problem was fixed by changing
LowLevelInterpreterLib to a STATIC library.

  • Source/JavaScriptCore/CMakeLists.txt:
  • Tools/WebKitTestRunner/CMakeLists.txt:
  • Tools/WebKitTestRunner/PlatformGTK.cmake:
  • Tools/WebKitTestRunner/PlatformWin.cmake:

Canonical link: ​https://commits.webkit.org/251129@main

2:59 PM Changeset in webkit [295033] by commit-queue@webkit.org
  • 1 edit in trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp

Include <sys/sysinfo.h> only on FreeBSD and Linux
​https://bugs.webkit.org/show_bug.cgi?id=241077

Patch by Leonardo Taccari <​leot@NetBSD.org> on 2022-05-30
Reviewed by Fujii Hironori.

sysinfo(2)/sysinfo(3) is used only on FreeBSD and Linux and could be not
available in other Unix-like operating systems.

  • Source/bmalloc/bmalloc/AvailableMemory.cpp:

Canonical link: ​https://commits.webkit.org/251128@main

11:07 AM Changeset in webkit [295032] by Alan Bujtas
  • 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Add support for justify-content: space-evenly
​https://bugs.webkit.org/show_bug.cgi?id=241085

Reviewed by Antti Koivisto.

Distribute items evenly. Items have equal space around them.

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::justifyFlexItems):

Canonical link: ​https://commits.webkit.org/251127@main

9:48 AM Changeset in webkit [295031] by commit-queue@webkit.org
  • 17 edits in trunk

MediaStreamTrack.getConstraints is empty object
​https://bugs.webkit.org/show_bug.cgi?id=240569

Patch by Youenn Fablet <​youennf@gmail.com> on 2022-05-30
Reviewed by Eric Carlson.

Cover audio and video constraints in UserMediaRequest.
Set these constraints on the created tracks at promise resolution time.

Make a refactoring to move from using RefPtr<MediaStreamTrack> to Ref<MediaStreamTrack>.
Remove use of MediaStream::getTracks since it is not efficient.

Covered by updated tests.

  • Source/WebCore/Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::getUserMedia):
(WebCore::MediaDevices::getDisplayMedia):

  • Source/WebCore/Modules/mediastream/MediaDevices.h:
  • Source/WebCore/Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::getFirstAudioTrack const):
(WebCore::MediaStream::getFirstVideoTrack const):
(WebCore::MediaStream::getTracks const):
(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::internalTakeTrack):
(WebCore::MediaStream::mediaState const):
(WebCore::MediaStream::updateActiveState):
(WebCore::MediaStream::filteredTracks const):

  • Source/WebCore/Modules/mediastream/MediaStream.h:
  • Source/WebCore/Modules/mediastream/MediaStreamTrack.h:

(WebCore::MediaStreamTrack::setConstraints):

  • Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::allow):

  • Source/WebCore/Modules/mediastream/UserMediaRequest.h:
  • LayoutTests/fast/mediastream/getDisplayMedia-max-constraints3.html:
  • LayoutTests/fast/mediastream/getUserMedia-webaudio.html:
  • LayoutTests/fast/mediastream/mediastreamtrack-video-clone.html:

Canonical link: ​https://commits.webkit.org/251126@main

9:44 AM Changeset in webkit [295030] by Alan Bujtas
  • 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Add support for justify-content: space-around
​https://bugs.webkit.org/show_bug.cgi?id=241084

Reviewed by Antti Koivisto.

Distribute items evenly. Items have a half-size space on either end.

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::justifyFlexItems):

Canonical link: ​https://commits.webkit.org/251125@main

8:20 AM Changeset in webkit [295029] by Pablo Saavedra
  • 1 edit in trunk/Source/WebCore/platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h

[GPU Process][Filters] Don't use Uint8ClampedArray in software filter appliers also for FEGaussianBlurNEON
​https://bugs.webkit.org/show_bug.cgi?id=240964

Reviewed by Said Abou-Hallawa.

This complement the changes done in r250982 by adapting the specific
method used for ARMv7 NEON.

  • Source/WebCore/platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h:

(WebCore::boxBlurNEON):

Canonical link: ​https://commits.webkit.org/251124@main

7:18 AM Changeset in webkit [295028] by Diego Pino Garcia
  • 34 edits in trunk/Source

Unreviewed, non-unified build fixes after 251082@main

  • Source/WebCore/bindings/js/JSAttrCustom.cpp:
  • Source/WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp:
  • Source/WebCore/bindings/js/JSCSSRuleCustom.cpp:
  • Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:
  • Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:
  • Source/WebCore/bindings/js/JSDocumentCustom.cpp:
  • Source/WebCore/bindings/js/JSFetchEventCustom.cpp:
  • Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:
  • Source/WebCore/bindings/js/JSHTMLTemplateElementCustom.cpp:
  • Source/WebCore/bindings/js/JSIDBCursorCustom.cpp:
  • Source/WebCore/bindings/js/JSIntersectionObserverCustom.cpp:
  • Source/WebCore/bindings/js/JSIntersectionObserverEntryCustom.cpp:
  • Source/WebCore/bindings/js/JSMessageChannelCustom.cpp:
  • Source/WebCore/bindings/js/JSMessagePortCustom.cpp:
  • Source/WebCore/bindings/js/JSNodeCustom.cpp:
  • Source/WebCore/bindings/js/JSNodeIteratorCustom.cpp:
  • Source/WebCore/bindings/js/JSPaintRenderingContext2DCustom.cpp:
  • Source/WebCore/bindings/js/JSResizeObserverEntryCustom.cpp:
  • Source/WebCore/bindings/js/JSSVGViewSpecCustom.cpp:
  • Source/WebCore/bindings/js/JSStyleSheetCustom.cpp:
  • Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:
  • Source/WebCore/bindings/js/JSUndoItemCustom.cpp:
  • Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp:
  • Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp:
  • Source/WebCore/bindings/js/JSWebXRSessionCustom.cpp:
  • Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp:
  • Source/WebCore/bindings/js/JSWorkerNavigatorCustom.cpp:
  • Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:
  • Source/WebCore/bindings/js/JSXPathResultCustom.cpp:
  • Source/WebCore/html/HTMLCanvasElement.cpp:
  • Source/WebCore/page/DOMWindowProperty.h:
  • Source/WebCore/page/UndoManager.h:
  • Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:

Canonical link: ​https://commits.webkit.org/251123@main

7:10 AM Changeset in webkit [295027] by Alan Bujtas
  • 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Add support for justify-content: space-between
​https://bugs.webkit.org/show_bug.cgi?id=241080

Reviewed by Antti Koivisto.

Distribute items evenly. The first item is flush with the start, the last is flush with the end.

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::justifyFlexItems):

  • Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForFlexLayout):

Canonical link: ​https://commits.webkit.org/251122@main

7:05 AM Changeset in webkit [295026] by commit-queue@webkit.org
  • 11 edits
    1 copy
    6 adds in trunk

REGRESSION (r293885): [ macOS wk2 ] webrtc/canvas-to-peer-connection.html is a consistent failure
​https://bugs.webkit.org/show_bug.cgi?id=240814

Patch by Youenn Fablet <​youennf@gmail.com> on 2022-05-30
Reviewed by Eric Carlson.

With r293885, we stopped using a pixel conformer to convert frames to YUV.
Instead, we used libyuv routines.
Libyuv is using BT.601 while our pixel conformer was using BT.709.
BT.709 is preferred in WebRTC so we now simply remove our conversion routine from RealtimeOutgoingVideoSourceCocoa.
Our hardware codecs can directly take RGB and convert it to YUV using BT.709.
To ensure we use the proper conversion routine, we add a RGB -> YUV conformer in LibWebRTCCodecsProxy.

Libvpx will use BT.601 routine so we do not have a very good story with VP8.
A follow-up should fix this. We add dedicated tests for both H264 and VP8.
We skip the new tests in glib as GTK bots do not like it.

  • LayoutTests/platform/glib/TestExpectations:
  • LayoutTests/platform/ios-simulator/TestExpectations:
  • LayoutTests/platform/mac-wk2/TestExpectations:
  • LayoutTests/webrtc/canvas-to-peer-connection.html:
  • LayoutTests/webrtc/routines.js:
  • Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:

(WebCore::RealtimeOutgoingVideoSourceCocoa::videoFrameAvailable):

  • Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.h:
  • Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:

(WebCore::RealtimeOutgoingVideoSourceCocoa::pixelBufferPool): Deleted.

  • Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
  • Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:

Canonical link: ​https://commits.webkit.org/251121@main

6:54 AM Changeset in webkit [295025] by ysuzuki@apple.com
  • 3 edits in trunk/Source/bmalloc/libpas/src/libpas

Unreviewed, build fix on Linux
​https://bugs.webkit.org/show_bug.cgi?id=240331

  • Source/bmalloc/libpas/src/libpas/pas_heap_config.h:
  • Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:

(pas_probabilistic_guard_malloc_debug_info):

  • Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h:

Canonical link: ​https://commits.webkit.org/251120@main

6:00 AM Changeset in webkit [295024] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore/accessibility

Fix a11y build warnings
​https://bugs.webkit.org/show_bug.cgi?id=241044

Patch by Michael Catanzaro <​mcatanzaro@redhat.com> on 2022-05-30
Reviewed by Adrian Perez de Castro.

  • Source/WebCore/accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::symmetricRelation):

  • Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

Canonical link: ​https://commits.webkit.org/251119@main

3:02 AM Changeset in webkit [295023] by ysuzuki@apple.com
  • 1 edit in trunk/Source/WTF/wtf/CompactPtr.h

Unreviewed, build fix for iOS debug build

  • Source/WTF/wtf/CompactPtr.h:

(WTF::CompactPtr::encode):
(WTF::CompactPtr::decode):
(WTF::CompactPtr::decode const): Deleted.

Canonical link: ​https://commits.webkit.org/251118@main

3:00 AM Changeset in webkit [295022] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore/runtime

[JSC] Shrink BrandedStructure
​https://bugs.webkit.org/show_bug.cgi?id=241092

Reviewed by Mark Lam.

Use CompactRefPtr and WriteBarrierStructureID to shrink sizeof(BrandedStructure) from 112 to 104.
While it is not enough for 32byte alignment, anyway we can make it smaller, and if we make it 8byte
smaller further, it will become 96bytes.

  • Source/JavaScriptCore/runtime/BrandedStructure.cpp:

(JSC::BrandedStructure::BrandedStructure):

  • Source/JavaScriptCore/runtime/BrandedStructure.h:

Canonical link: ​https://commits.webkit.org/251117@main

1:29 AM Changeset in webkit [295021] by ntim@apple.com
  • 45 edits
    1 delete in trunk

Unprefix -webkit-text-align-last and add match-parent value support
​https://bugs.webkit.org/show_bug.cgi?id=229083
<rdar://82176885>

Reviewed by Antti Koivisto.

We do not keep support for the prefixed version since no other browser supports it, and WebKit never exposed it on macOS/iOS.
Also, unprefix WPTs where prefixes were added automatically by the test importer.

Note that serialization of the match-parent value isn't as specified in the spec, but the behavior matches other browsers.

Original patch by Brent Fulgham.

  • LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-expected.txt: Removed.
  • LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited-expected.txt: Removed.
  • LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html: Removed.
  • LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html: Removed.

These tests are redundant with the parsing ones on WPT.

  • LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html:
  • LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-text-align-expected.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-text-align-ref.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-text-align.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-percent-001-expected.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-percent-001.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-bidi-003.xht:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-last-computed-expected.txt:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-last-valid-expected.txt:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-001.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-002.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-003.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-004.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-005.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-006.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-007.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-008.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-009.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-010.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-011.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-012.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-013.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-014.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-empty-inline.html:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-wins-001.html:
  • LayoutTests/imported/w3c/web-platform-tests/svg/styling/required-properties-expected.txt:
  • LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
  • LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • Source/WebCore/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • Source/WebCore/css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

  • Source/WebCore/css/CSSProperties.json:
  • Source/WebCore/css/StyleProperties.cpp:
  • Source/WebCore/css/parser/CSSParserContext.cpp:

(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):

  • Source/WebCore/css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

  • Source/WebCore/rendering/style/RenderStyle.h:

(WebCore::RenderStyle::textAlignLast const):
(WebCore::RenderStyle::textIndentType const):
(WebCore::RenderStyle::setTextAlignLast):
(WebCore::RenderStyle::setTextIndentType):
(WebCore::RenderStyle::initialTextAlignLast):
(WebCore::RenderStyle::initialTextIndentType):

  • Source/WebCore/style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertTextAlignLast):

  • Source/WebCore/style/StyleBuilderCustom.h:

(WebCore::Style::BuilderCustom::applyInitialTextAlignLast):
(WebCore::Style::BuilderCustom::applyValueTextAlignLast):

  • Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
  • Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js:
  • Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:

Canonical link: ​https://commits.webkit.org/251116@main

12:19 AM Changeset in webkit [295020] by commit-queue@webkit.org
  • 1 edit in trunk/Tools/Scripts/update-angle

Avoid staging autogenerated commit-message.txt
​https://bugs.webkit.org/show_bug.cgi?id=240967

Patch by Kenneth Russell <​kbr@chromium.org> on 2022-05-29
Unstage the autogenerated commit-message.txt before exiting the
update-angle script to make it easier for the user to remove.

Reviewed by Kimmo Kinnunen.

  • Source/ThirdParty/ANGLE/commit-message.txt: Added.
  • Tools/Scripts/update-angle:

Canonical link: ​https://commits.webkit.org/251115@main

May 29, 2022:

12:56 PM Changeset in webkit [295019] by ntim@apple.com
  • 1 edit in trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt

[Gardening] Rebaseline fast/dom/HTMLMeterElement/meter-element-markup.html after 9a73643
​https://bugs.webkit.org/show_bug.cgi?id=240930

Unreviewed test gardening.

Just reflects the new unprefixed style.

  • LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:

Canonical link: ​https://commits.webkit.org/251114@main

10:10 AM Changeset in webkit [295018] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore/layout/formattingContexts/inline

LineBuilder::initialConstraintsForLine needs to know whether there is previous line and if it ended with line break
​https://bugs.webkit.org/show_bug.cgi?id=241062

Reviewed by Antti Koivisto.

No need to pass in the PreviousLine struct.

  • Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::initialConstraintsForLine const):

  • Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:

Canonical link: ​https://commits.webkit.org/251112@main

10:09 AM Changeset in webkit [295017] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Add basic support for justify-content
​https://bugs.webkit.org/show_bug.cgi?id=241073

Reviewed by Antti Koivisto.

"justify-content" property defines how space is distributed between and around flex items along the main-axis.

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::justiftFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:

Canonical link: ​https://commits.webkit.org/251112@main

8:34 AM Changeset in webkit [295016] by Alan Bujtas
  • 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Add support for align-self
​https://bugs.webkit.org/show_bug.cgi?id=241071

Reviewed by Antti Koivisto.

Align-items behavior can be overwritten for individual flex items by applying the align-self property to them.

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::alignFlexItems):

Canonical link: ​https://commits.webkit.org/251111@main

7:03 AM Changeset in webkit [295015] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Compute available space when ConstraintsForFlexContent does not provide one
​https://bugs.webkit.org/show_bug.cgi?id=241070

Reviewed by Antti Koivisto.

e.g. if the flex box does not have fixed height in the cross axis direction, all flex items become as tall as the tallest flex item.

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeAvailableLogicalVerticalSpace const):
(WebCore::Layout::FlexFormattingContext::computeAvailableLogicalHorizontalSpace const):
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexFormattingContext::alignFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::availableLogicalVerticalSpace): Deleted.
(WebCore::Layout::availableLogicalHorizontalSpace): Deleted.

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:

Canonical link: ​https://commits.webkit.org/251110@main

6:44 AM Changeset in webkit [295014] by Alan Bujtas
  • 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

Add support for flex-start/flex-end/start/end alignment
​https://bugs.webkit.org/show_bug.cgi?id=241067

Reviewed by Antti Koivisto.

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexFormattingContext::alignFlexItems):

Canonical link: ​https://commits.webkit.org/251109@main

6:22 AM Changeset in webkit [295013] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Introduce FlexFormattingContext::alignFlexItems
​https://bugs.webkit.org/show_bug.cgi?id=241064

Reviewed by Antti Koivisto.

This is cross axis alignment (add support for 'center' to showcase).

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexFormattingContext::alignFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:

Canonical link: ​https://commits.webkit.org/251108@main

1:24 AM Changeset in webkit [295012] by commit-queue@webkit.org
  • 1 edit in trunk/Source/WTF/wtf/CompactPtr.h

REGRESSION(251103@main): Broke GTK/WPE
​https://bugs.webkit.org/show_bug.cgi?id=241076

Patch by Philippe Normand <​philn@igalia.com> on 2022-05-29
Unreviewed. Fix GTK/WPE build.

  • Source/WTF/wtf/CompactPtr.h:

(WTF::CompactPtr::swap):

Canonical link: ​https://commits.webkit.org/251107@main

1:14 AM Changeset in webkit [295011] by ysuzuki@apple.com
  • 10 edits
    1 add in trunk

[JSC] Async / Await should not wrap awaited value with one tick
​https://bugs.webkit.org/show_bug.cgi?id=241072

Reviewed by Saam Barati.

This patch integrates spec change[1], which removes one level tick count when resolving promise with await.
Previously, regardless of whether the value is promise or not, we are always using resolveWithoutPromise,
but it introduces one tick before the handlers are resolved. The spec change makes it that we can call
performPromiseThen directly if the input value is promise, so we can skip one tick which looks up "then"
and register handlers.

This is beneficial for await performance and it also fixes a bug tested via test262 and attached test due
to the spec change.

We observed performance improvement in async + native promise tests.

ToT
Time(doxbee-async-es2017-native): 35.6 ms.
Time(fibonacci-async-es2017-native): 292.3 ms.
Time(parallel-async-es2017-native): 117.3 ms.

Patched
Time(doxbee-async-es2017-native): 24.2 ms.
Time(fibonacci-async-es2017-native): 198.1 ms.
Time(parallel-async-es2017-native): 109.5 ms.

[1]: ​https://github.com/tc39/ecma262/pull/1250

  • JSTests/stress/async-await-basic.js:
  • JSTests/stress/async-await-tick-count.js: Added.

(shouldBe):
(async returnDirectPrimitive):
(async returnAwaitPrimitive):
(async returnDirectPromisePrimitive):
(async returnAwaitPromisePrimitive):
(async test):
(async tests):
(globalThis.setUnhandledRejectionCallback.setUnhandledRejectionCallback):

  • JSTests/test262/expectations.yaml:
  • LayoutTests/inspector/canvas/recording-bitmaprenderer-frameCount-expected.txt:
  • LayoutTests/inspector/canvas/recording-bitmaprenderer-full-expected.txt:
  • LayoutTests/inspector/canvas/recording-bitmaprenderer-memoryLimit-expected.txt:
  • LayoutTests/inspector/console/message-stack-trace-expected.txt:
  • Source/JavaScriptCore/builtins/AsyncFromSyncIteratorPrototype.js:
  • Source/JavaScriptCore/builtins/AsyncFunctionPrototype.js:

(globalPrivate.asyncFunctionResume):

  • Source/JavaScriptCore/builtins/AsyncGeneratorPrototype.js:

(globalPrivate.awaitValue):
(globalPrivate.asyncGeneratorResumeNext):

  • Source/JavaScriptCore/builtins/PromiseOperations.js:

(globalPrivate.newPromiseCapabilitySlow):
(globalPrivate.promiseResolve):
(globalPrivate.promiseResolveSlow):
(globalPrivate.promiseRejectSlow):
(globalPrivate.resolvePromiseWithFirstResolvingFunctionCallCheck):
(globalPrivate.fulfillPromiseWithFirstResolvingFunctionCallCheck):
(globalPrivate.rejectPromiseWithFirstResolvingFunctionCallCheck):
(globalPrivate.resolveWithoutPromiseForAsyncAwait):

Canonical link: ​https://commits.webkit.org/251106@main

12:57 AM Changeset in webkit [295010] by commit-queue@webkit.org
  • 35 edits in trunk

Replace CSS3_TEXT build flag with Experimental feature settings
​https://bugs.webkit.org/show_bug.cgi?id=121875

Patch by Kiet Ho <Kiet Ho> on 2022-05-29
Reviewed by Tim Nguyen and Myles C. Maxfield.

Currently, -webkit-text-align-last and -webkit-text-justify are gated behind
the ENABLE(CSS3_TEXT) build flag. EWS bots doesn't enable it, hence the properties
aren't tested even though tests are available for them. This patch replaces the build
flag with two experimental settings, which is on during layout tests, allowing the
properties to be tested.

  • LayoutTests/TestExpectations:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
  • LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
  • LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
  • LayoutTests/platform/win/TestExpectations:
  • LayoutTests/platform/wincairo/TestExpectations:
  • LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
  • Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
  • Source/WTF/wtf/PlatformEnable.h:
  • Source/WebCore/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
Temporarily mark -webkit-text-align-last and -webkit-text-justify as not animatable
to avoid the assert. CSS animations for those properties will be implemented in
webkit.org/b/240591.

  • Source/WebCore/css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

  • Source/WebCore/css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator TextJustify const):

  • Source/WebCore/css/CSSProperties.json:
  • Source/WebCore/css/StyleProperties.cpp:
  • Source/WebCore/css/parser/CSSParserContext.cpp:

(WebCore::operator==):
(WebCore::add):
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):

  • Source/WebCore/css/parser/CSSParserContext.h:
  • Source/WebCore/css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

  • Source/WebCore/rendering/LegacyLineLayout.cpp:

(WebCore::LegacyLineLayout::textAlignmentForLine const):

  • Source/WebCore/rendering/style/RenderStyle.cpp:

(WebCore::rareInheritedDataChangeRequiresLayout):

  • Source/WebCore/rendering/style/RenderStyle.h:

(WebCore::RenderStyle::textIndentType const):
(WebCore::RenderStyle::textJustify const):
(WebCore::RenderStyle::setTextIndentType):
(WebCore::RenderStyle::setTextJustify):
(WebCore::RenderStyle::initialTextIndentType):
(WebCore::RenderStyle::initialTextJustify):

  • Source/WebCore/rendering/style/RenderStyleConstants.h:
  • Source/WebCore/rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

  • Source/WebCore/rendering/style/StyleRareInheritedData.h:
  • Source/WebKitLegacy/win/WebPreferences.cpp:

(WebPreferences::cssTextAlignLastEnabled):
(WebPreferences::cssTextJustifyEnabled):

  • Source/WebKitLegacy/win/WebPreferences.h:
  • Source/WebKitLegacy/win/WebView.cpp:

(WebView::notifyPreferencesChanged):

  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
  • Tools/DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):

  • Tools/Scripts/webkitperl/FeatureList.pm:

Canonical link: ​https://commits.webkit.org/251105@main

Note: See TracTimeline for information about the timeline view.