Timeline

Jun 1, 2022:

10:05 PM Changeset in webkit [295120] by ntim@apple.com

• 2 edits in trunk

text-align: match-parent on root handles direction incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=241164

Reviewed by Myles C. Maxfield.

The spec says the initial containing block's direction should be used when the element has no parent.

Regarding the computed value, Chrome & Firefox computes to start for this case.
This may change in ​https://github.com/w3c/csswg-drafts/issues/6542 to left/right.

Test: imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-rtl.html

• LayoutTests/TestExpectations:
• Source/WebCore/style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertTextAlign):

Canonical link: ​https://commits.webkit.org/251211@main

9:05 PM Changeset in webkit [295119] by achristensen@apple.com

• 1 edit in trunk/Source/WebCore/svg/SVGGeometryElement.cpp

Clamp distance earlier in SVGGeometryElement::getPointAtLength
​https://bugs.webkit.org/show_bug.cgi?id=241212

Reviewed by Chris Dumez.

• LayoutTests/fast/svg/get-point-at-length-layout-expected.txt: Added.
• LayoutTests/fast/svg/get-point-at-length-layout.html: Added.
• Source/WebCore/svg/SVGGeometryElement.cpp:

(WebCore::SVGGeometryElement::getPointAtLength const):

Canonical link: ​https://commits.webkit.org/251210@main

9:02 PM Changeset in webkit [295118] by Chris Dumez

• 1 edit in trunk/Source/WebCore/bindings/js/DOMPromiseProxy.h

DOMPromiseProxyWithResolveCallback<IDLType>::promise() should not use |this| after calling resolve() / reject()
​https://bugs.webkit.org/show_bug.cgi?id=241195

Reviewed by Alex Christensen.

• Source/WebCore/bindings/js/DOMPromiseProxy.h:

(WebCore::DOMPromiseProxyWithResolveCallback<IDLType>::promise):

Canonical link: ​https://commits.webkit.org/251209@main

8:56 PM Changeset in webkit [295117] by sihui_liu@apple.com

• 2 edits in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa

[iOS] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is consistently timing out on release
​https://bugs.webkit.org/show_bug.cgi?id=240886

Reviewed by Chris Dumez.

Modify the test to make it less flaky and easier to debug. The changes including:

1. "Continue" message is sent from web page after first operation completes, instead of database is opened, so we can

make sure transaction is started before _sendNetworkProcessWillSuspendImminently.

2. Call _sendNetworkProcessDidResume after first transaction is aborted ("Abort" message is received), so we can make

sure network process has handled suspend message.

3. The test pages create only two different transactions: the first is a long transaction, which keeps running until it

gets aborted by suspension; the second is a short transaction, which is only used to prove that not all transactions
will be aborted by suspension. We used to create 10 identical transactions and it could be any of them gets aborted.

• Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html:
• Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm:

(TEST):

Canonical link: ​https://commits.webkit.org/251208@main

8:51 PM Changeset in webkit [295116] by achristensen@apple.com

• 3 edits in trunk/Source/WebCore/html/canvas

CanvasGradient should store a strong reference instead of a CanvasBase&
​https://bugs.webkit.org/show_bug.cgi?id=241211

Reviewed by Chris Dumez.

• LayoutTests/fast/canvas/add-color-stop-after-gc-expected.txt: Added.
• LayoutTests/fast/canvas/add-color-stop-after-gc.html: Added.
• Source/WebCore/html/canvas/CanvasGradient.cpp:

(WebCore::CanvasGradient::CanvasGradient):
(WebCore::m_context):
(WebCore::CanvasGradient::create):
(WebCore::CanvasGradient::addColorStop):
(WebCore::m_canvas): Deleted.

• Source/WebCore/html/canvas/CanvasGradient.h:
• Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::createLinearGradient):
(WebCore::CanvasRenderingContext2DBase::createRadialGradient):
(WebCore::CanvasRenderingContext2DBase::createConicGradient):

Canonical link: ​https://commits.webkit.org/251207@main

8:22 PM Changeset in webkit [295115] by achristensen@apple.com

• 1 edit in trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp

Set PluginView::Stream::m_loader before calling NetscapePlugInStreamLoader::cancel
​https://bugs.webkit.org/show_bug.cgi?id=241210

Reviewed by Chris Dumez.

• ../../Source/WebKit/WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::cancel):

Canonical link: ​https://commits.webkit.org/251206@main

6:24 PM Changeset in webkit [295114] by Chris Dumez

• 2 edits in trunk/Tools/TestWebKitAPI/Tests/WTF

REGRESSION (250986@main): ASSERTION FAILED: isASCII(characters[I]) in WTF::ASCIILiteral WTF::StringLiterals::operator""_s()
​https://bugs.webkit.org/show_bug.cgi?id=241207
<rdar://94256662>

Unreviewed, a few URL API tests were using ""_s with non-ASCII characters, which is
not supported. Use StringView::fromLatin1() instead to restore pre-existing behavior.

• Tools/TestWebKitAPI/Tests/WTF/URL.cpp:

(TestWebKitAPI::TEST_F):

• Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:

(TestWebKitAPI::TEST_F):

Canonical link: ​https://commits.webkit.org/251205@main

6:07 PM Changeset in webkit [295113] by Said Abou-Hallawa

• 61 edits
  1 add in trunk/Source

[GPU Process] [Filters] Make PixelBuffer a RefCounted class
​https://bugs.webkit.org/show_bug.cgi?id=240807
rdar://94040771

Reviewed by Simon Fraser.

The plan is to hide the underlying memory of PixelBuffer. GPUProcess needs to
allocate shared memory and attribute it to the WebProcess.

Currently the PixelBuffer is created as std::optional<PixelBuffer> which does
not allow sub-classing it. We need to create PixelBuffer as a pointer.

The patch follows these simple replacement rules:

1. std::optional<PixelBuffer> will be replaced by RefPtr<PixelBuffer>
2. PixelBuffer will be replaced by Ref<PixelBuffer> and Ref<PixelBuffer>&&
3. PixelBuffer&& will be replaced by Ref<PixelBuffer>&&

A new IPC class named PixelBufferReference will be added to allow sending and
receiving a Ref<PixelBuffer> through IPC.

• Source/WebCore/html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toVideoFrame):

• Source/WebCore/html/ImageData.cpp:

(WebCore::ImageData::create):
(WebCore::ImageData::pixelBuffer const):

• Source/WebCore/html/ImageData.h:
• Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::getImageData const):

• Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::paintRenderingResultsToPixelBuffer):

• Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
• Source/WebCore/platform/graphics/ConcreteImageBuffer.h:
• Source/WebCore/platform/graphics/GraphicsContextGL.h:
• Source/WebCore/platform/graphics/ImageBuffer.h:
• Source/WebCore/platform/graphics/ImageBufferBackend.cpp:

(WebCore::ImageBufferBackend::getPixelBuffer const):

• Source/WebCore/platform/graphics/ImageBufferBackend.h:
• Source/WebCore/platform/graphics/PixelBuffer.cpp:

(WebCore::PixelBuffer::tryCreateForDecoding):
(WebCore::PixelBuffer::tryCreate):
(WebCore::PixelBuffer::create):
(WebCore::PixelBuffer::createScratchPixelBuffer const):
(WebCore::PixelBuffer::deepClone const): Deleted.

• Source/WebCore/platform/graphics/PixelBuffer.h:

(WebCore::PixelBuffer::decode):

• Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::readPixelsForPaintResults):
(WebCore::GraphicsContextGLANGLE::readRenderingResults):
(WebCore::GraphicsContextGLANGLE::paintRenderingResultsToCanvas):
(WebCore::GraphicsContextGLANGLE::paintCompositedResultsToCanvas):
(WebCore::GraphicsContextGLANGLE::paintRenderingResultsToPixelBuffer):
(WebCore::GraphicsContextGLANGLE::readRenderingResultsForPainting):
(WebCore::GraphicsContextGLANGLE::readCompositedResultsForPainting):

• Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:
• Source/WebCore/platform/graphics/cg/GraphicsContextGLCG.cpp:

(WebCore::GraphicsContextGL::paintToCanvas):

• Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.cpp:

(WebCore::ImageBufferCGBitmapBackend::getPixelBuffer const):

• Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.h:
• Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:

(WebCore::ImageBufferIOSurfaceBackend::getPixelBuffer const):

• Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
• Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:

(WebCore::GraphicsContextGLANGLE::readCompositedResults):

• Source/WebCore/platform/graphics/cv/VideoFrameCV.h:
• Source/WebCore/platform/graphics/cv/VideoFrameCV.mm:

(WebCore::VideoFrameCV::createFromPixelBuffer):

• Source/WebCore/platform/graphics/filters/FilterImage.cpp:

(WebCore::getConvertedPixelBuffer):
(WebCore::FilterImage::pixelBufferSlot):
(WebCore::FilterImage::pixelBuffer):
(WebCore::FilterImage::getPixelBuffer):
(WebCore::FilterImage::copyPixelBuffer):

• Source/WebCore/platform/graphics/filters/FilterImage.h:
• Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:

(WebCore::FEGaussianBlurSoftwareApplier::applyPlatform):

• Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.h:
• Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::readCompositedResults):
(WebCore::GraphicsContextGLOpenGL::readRenderingResults):
(WebCore::GraphicsContextGLOpenGL::paintRenderingResultsToPixelBuffer):
(WebCore::GraphicsContextGLOpenGL::readRenderingResultsForPainting):
(WebCore::GraphicsContextGLOpenGL::readCompositedResultsForPainting):

• Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:
• Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:

(WebKit::RemoteGraphicsContextGL::paintPixelBufferToImageBuffer):

• Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h:
• Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
• Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:

(paintRenderingResultsToPixelBuffer):

• Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::putPixelBufferForImageBuffer):

• Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
• Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
• Source/WebKit/Platform/IPC/PixelBufferReference.h: Added.

(IPC::PixelBufferReference::PixelBufferReference):
(IPC::PixelBufferReference::takePixelBuffer):
(IPC::PixelBufferReference::encode const):
(IPC::PixelBufferReference::decode):

• Source/WebKit/Scripts/webkit/messages.py:

(types_that_cannot_be_forward_declared):

• Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:

(WebKit::CGDisplayListImageBufferBackend::getPixelBuffer const):

• Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h:
• Source/WebKit/Shared/WebCoreArgumentCoders.h:
• Source/WebKit/WebKit.xcodeproj/project.pbxproj:
• Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:

(WebKit::ImageBufferShareableBitmapBackend::getPixelBuffer const):

• Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
• Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
• Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:

(WebKit::RemoteGraphicsContextGLProxy::paintRenderingResultsToPixelBuffer):

• Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
• Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::putPixelBufferForImageBuffer):

• Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.cpp:

(WebKit::ImageBufferRemoteIOSurfaceBackend::getPixelBuffer const):

• Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.h:

Canonical link: ​https://commits.webkit.org/251204@main

5:39 PM Changeset in webkit [295112] by Alan Coon

• 1 copy in tags/WebKit-7614.1.14.10.10

Tag WebKit-7614.1.14.10.10.

5:36 PM Changeset in webkit [295111] by Alan Coon

• 9 edits in branches/safari-7614.1.14.10-branch/Source

Versioning.

WebKit-7614.1.14.10.10

5:17 PM Changeset in webkit [295110] by mark.lam@apple.com

• 1 edit in trunk/Source/JavaScriptCore/dfg/DFGJITCode.h

Speculative build fix for Mac Catalyst.
​https://bugs.webkit.org/show_bug.cgi?id=241206

Unreviewed.

• Source/JavaScriptCore/dfg/DFGJITCode.h:

Canonical link: ​https://commits.webkit.org/251203@main

5:15 PM Changeset in webkit [295109] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

WebGL extensions code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=241185

Patch by Alexey Knyazev <​3479527+lexaknyazev@users.noreply.github.com> on 2022-06-01
Reviewed by Kenneth Russell.

Sorted extensions in the same order everywhere, added new macros.

Drive-by fixes:

• WebGLRenderingContextBase::extensionIsEnabled for EXT_texture_filter_anisotropic
• WebGLRenderingContextBase::extensionIsEnabled for WEBGL_compressed_texture_pvrtc
• WebGLRenderingContextBase::loseExtensions for WEBGL_compressed_texture_s3tc_srgb
• WebGLRenderingContextBase::loseExtensions for WEBGL_multi_draw

• Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

• Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

• Source/WebCore/html/canvas/WebGLExtension.h:
• Source/WebCore/html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

• Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::loseExtensions):

• Source/WebCore/html/canvas/WebGLRenderingContextBase.h:

Canonical link: ​https://commits.webkit.org/251202@main

4:16 PM WebKitGTK/2.36.x edited by Adrian Perez de Castro

(diff)

3:30 PM Changeset in webkit [295108] by Alan Coon

• 1 copy in tags/WebKit-7614.1.15

Tag WebKit-7614.1.15.

3:21 PM Changeset in webkit [295107] by Jon Davis

• 1 edit in trunk/Websites/webkit.org/wp-content/themes/webkit/header.php

Add privacy-friendly usage statistics reporting for webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=241200

Reviewed by Devin Rousso.

• Websites/webkit.org/wp-content/themes/webkit/header.php:

Canonical link: ​https://commits.webkit.org/251201@main

2:59 PM Changeset in webkit [295106] by Russell Epstein

• 1 edit in branches/safari-613-branch/Source/WebCore/dom/Document.cpp

Unreviewed build fix.

error: no member named 'isResolvingContainerQueries' in 'WebCore::Document'

2:42 PM Changeset in webkit [295105] by Wenson Hsieh

• 5 edits
  2 adds in trunk

[macOS] Only allow the active, visible tab to trigger -_focusWebView:
​https://bugs.webkit.org/show_bug.cgi?id=241108
rdar://93973632

Reviewed by Chris Dumez.

To address <​https://webkit.org/b/233686>, Safari removed their implementation of the UI delegate
method -_focusWebView:, which is invoked when a webpage uses window.open() with a target, and
which Safari previously handled by making the web view the active tab. However, this breaks a valid
use case in which a webpage uses window.open() to open itself in a new tab, and later use it again
to return to the original tab. To address this, we'll restore Safari's implementation of the
WKWebView focus delegate method, but will change WebKit to only allow this method call to bubble
up into the client layer in the case where the page that's calling window.open() is already active
and visible.

• Source/WebCore/loader/FrameLoader.cpp:

(WebCore::isInVisibleAndActivePage):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::createWindow):

• Source/WebCore/page/DOMWindow.cpp:

(WebCore::DOMWindow::focus):

Check that the opener (or source) frame that's triggering the call to open() is in a page that's
visible and active.

• Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• Tools/TestWebKitAPI/Tests/mac/FocusWebView.mm: Added.

(TestWebKitAPI::TEST):

Add an API test to verify that -_focusWebView: is not called when opening a window once the web
page containing the frame that's calling window.open() is unparented from its window.

• Tools/TestWebKitAPI/Tests/mac/open-in-new-tab.html: Added.
• Tools/TestWebKitAPI/cocoa/TestUIDelegate.h:
• Tools/TestWebKitAPI/cocoa/TestUIDelegate.mm:

(-[TestUIDelegate _focusWebView:]):

Canonical link: ​https://commits.webkit.org/251200@main

1:36 PM Changeset in webkit [295104] by dino@apple.com

• 1 edit in trunk/Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm

Relax the assertions for min/max unobscured size
​https://bugs.webkit.org/show_bug.cgi?id=241083

Reviewed by Tim Horton.

The assertions in _setMinimumUnobscuredSizeOverride and
_setMaximumUnobscuredSizeOverride often trigger when the current bounds are

0. This is handled acceptably, and the assertion is not necessary in that

case.

• Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _setMinimumUnobscuredSizeOverride:]):
(-[WKWebView _setMaximumUnobscuredSizeOverride:]):

Canonical link: ​https://commits.webkit.org/251199@main

1:17 PM Changeset in webkit [295103] by Wenson Hsieh

• 3 edits in trunk/Source/WebKit

Avoid triggering image analysis when the user has disabled Live Text
​https://bugs.webkit.org/show_bug.cgi?id=241193

Reviewed by Aditya Keerthi.

• Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.h:
• Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm:

(WebKit::canStartImageAnalysis):

• Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _startImageAnalysis:target:]):

Canonical link: ​https://commits.webkit.org/251198@main

1:15 PM Changeset in webkit [295102] by Jonathan Bedard

• 1 edit in trunk/Source/bmalloc/libpas/Documentation.md

[libpas] add documentation (Follow-up)
​https://bugs.webkit.org/show_bug.cgi?id=236385
<rdar://88704094>

Reviewed by Mark Lam.

• Source/bmalloc/libpas/Documentation.md: Convert hashes and revisions to identifiers.

Canonical link: ​https://commits.webkit.org/251196@main

1:15 PM Changeset in webkit [295101] by achristensen@apple.com

• 2 edits in trunk

Allow decidePolicyForNavigation* decisionHandlers to be called on non-main runloops
​https://bugs.webkit.org/show_bug.cgi?id=241157
<rdar://94130705>

Reviewed by Brady Eidson.

Wouldn't it be nice if all apps used your APIs exactly how you want them to?
This is not the case. People call decision handlers on non-main threads.
When this happens, just hop to the main thread to avoid threading issues.

• Source/WebKit/UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):

Canonical link: ​https://commits.webkit.org/251196@main

11:52 AM Changeset in webkit [295100] by Patrick Angle

• 4 edits in trunk

Web Inspector: Even after r293565, button/select elements created after Web Inspector is open are considered Flexbox containers
​https://bugs.webkit.org/show_bug.cgi?id=241054
rdar://94063718

Reviewed by Devin Rousso.

r293565 updated the logic for determining the layout type for RenderObjects, but that fix did not account for the fact
that InspectorCSSAgent::nodeLayoutContextTypeChanged is called during the creation of RenderFlexibleBox, at which
point the creation of subclass-specific bits, including overrides will not have occurred, including isFlexibleBoxImpl
which we use to determine if the flexbox container is a "real" flexbox container, or an internal implementation detail.
We should instead determine the layout context type later just before we send the event to the frontend (it is already
delayed specifically because nodeLayoutContextTypeChanged can be called in destructors, which can be the result of
garbage collection). This doesn't change when the frontend receives any information, only adjust when we resolve the
layout context type.

• LayoutTests/inspector/css/nodeLayoutContextTypeChanged-expected.txt:
• LayoutTests/inspector/css/nodeLayoutContextTypeChanged.html:
• Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:
• Source/WebCore/inspector/agents/InspectorCSSAgent.h:

Canonical link: ​https://commits.webkit.org/251195@main

11:51 AM Changeset in webkit [295099] by Patrick Angle

• 6 edits in trunk/Source/WebInspectorUI/UserInterface/Views

Web Inspector: Color swatches for layout container overlays allow format changes via context menu
​https://bugs.webkit.org/show_bug.cgi?id=241055
rdar://94063968

Reviewed by Devin Rousso.

NodeOverlayListSection already signaled that the color swatches it creates should not allow changing formats (although
it expressed this as preventing Shift+Clicking to change the format). This only makes sense if we prevent the context
menu from being shown as well, which current allows changing the color format for these swatches. Because currently we
only support sRGB color for overlays anyways, this is unnecessary and confusing.

• Source/WebInspectorUI/UserInterface/Views/InlineSwatch.js:

(WI.InlineSwatch):

• Add an option to prevent changing color formats and convert read-only to an option as well.
• Don't add the context menu click handler for color swatches when changing formats is disabled.

(WI.InlineSwatch.prototype._allowChangingColorFormats):
(WI.InlineSwatch.prototype.set shiftClickColorEnabled): Deleted.
(WI.InlineSwatch.prototype._swatchElementClicked):

• Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:

(WI.AnimationDetailsSidebarPanel.prototype._refreshEffectSection.optionsForType):
(WI.AnimationDetailsSidebarPanel.prototype._refreshEffectSection):

• Source/WebInspectorUI/UserInterface/Views/NodeOverlayListSection.js:

(WI.NodeOverlayListSection.prototype.layout):

• Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._createSwatchForColorParameters):

• Source/WebInspectorUI/UserInterface/Views/RecordingStateDetailsSidebarPanel.js:

(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D):
(WI.RecordingStateDetailsSidebarPanel):

• Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):

• Adopt new WI.InlineSwatch constructor.

Canonical link: ​https://commits.webkit.org/251194@main

11:32 AM Changeset in webkit [295098] by Aditya Keerthi

• 2 edits in trunk

[iOS] WKWebViews can get into a state with multiple find overlays
​https://bugs.webkit.org/show_bug.cgi?id=241163
rdar://93904570

Reviewed by Devin Rousso.

When -[WKWebView didEndTextSearchOperation] and -[WKWebView didBeginTextSearchOperation]
are called in quick succession, the web view can get into a state with multiple
find overlays. This state occurs because didBeginTextSearchOperation nulls out
the find overlay before the fade out animation has finished.
didBeginTextSearchOperation then observes that there is no find overlay, and
adds another overlay.

To fix, the page overlay member should be nulled out at the right time.

• Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp:

(WebKit::WebFoundTextRangeController::didBeginTextSearchOperation):

If there is already a find overlay, cancel its removal if it is being
uninstalled. This ensures that calling end/begin in quick succession will preserve
the overlay.

(WebKit::WebFoundTextRangeController::didEndTextSearchOperation):

Do not null out the page overlay immediately when uninstalling. Nulling out
the member is handled in willMoveToPage, which is called after the animation
is finished.

• Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:

(traverseLayerTree):
(overlayCount):
(TestWebKitAPI::TEST):

Added an API test to ensure at most one find overlay is in the layer tree at
any time.

Canonical link: ​https://commits.webkit.org/251193@main

10:50 AM Changeset in webkit [295097] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations

[Gardening]: REGRESSION (250044@main?): [ Monterey Debug wk2 ] webgl/1.0.3/conformance/attribs/gl-vertexattribpointer-offsets.html is an almost consistent timeout
​https://bugs.webkit.org/show_bug.cgi?id=241191
<rdar://94231182>

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/251192@main

10:41 AM Changeset in webkit [295096] by Jonathan Bedard

• 3 edits in trunk/Tools/Scripts/libraries/webkitscmpy

[git-webkit] Append -- to git log commands
​https://bugs.webkit.org/show_bug.cgi?id=241161
<rdar://problem/94185199>

Reviewed by Alexey Proskuryakov.

• Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:

(Git.Cache.populate): Append -- to git log command.
(Git.commit): Ditto.
(Git.commits): Ditto.
(Git.checkout): Append -- to git checkout command.

Canonical link: ​https://commits.webkit.org/251191@main

10:32 AM Changeset in webkit [295095] by Ryan Haddad

• 2 edits in trunk

Revert "Allow decidePolicyForNavigation* decisionHandlers to be called on non-main runloops"

Unreviewed, this reverts commit 251175@main.

Canonical link: ​https://commits.webkit.org/251190@main

10:26 AM Changeset in webkit [295094] by Alan Bujtas

• 1 edit
  2 adds in trunk

Spacing after some posts is too large on Dead by Daylight forums
​https://bugs.webkit.org/show_bug.cgi?id=241104
<rdar://88110302>

Reviewed by Antti Koivisto.

Do not cross containing block boundary while resolving fill-available. If the containing block does not specify the constraint value for the fill-available descendant, we should just return "can't resolve" instead of climbing the containing block tree and potentially hit the ICB as the first container with fixed height(width).

• LayoutTests/fast/block/fill-available-with-no-specified-containing-block-height-expected.html: Added.
• LayoutTests/fast/block/fill-available-with-no-specified-containing-block-height.html: Added.
• Source/WebCore/rendering/RenderBox.cpp:

(WebCore::isOrthogonal):
(WebCore::RenderBox::computeIntrinsicLogicalContentHeightUsing const):

Canonical link: ​https://commits.webkit.org/251189@main

10:04 AM Changeset in webkit [295093] by Ryan Haddad

• 45 edits in trunk/Source

Revert "[Xcode] Prevent STP and other self-contained builds from overwriting content in the macOS SDK"

Unreviewed, this reverts commit 251168@main to fix internal builds.

Canonical link: ​https://commits.webkit.org/251188@main

9:58 AM Changeset in webkit [295092] by Chris Dumez

• 3 edits in trunk

WeakHashMap::ensure() may crash if the map contains null references ​https://bugs.webkit.org/show_bug.cgi?id=241162

Reviewed by Geoffrey Garen.

WeakHashMap::ensure() may crash if the map contains null references, because
the WeakHashMap iterator destructor can clear null references and the AddResult
constructor copies and destroys the input iterator.

I find it very error-prone that destroying an iterator would modify the hash
map and thus invalidate other iterators (or even itself if the iterator was
merely copied). As a result, I removed this logic from the
WeakHashMapIteratorBase destructor. Instead, I now increase
WeakHashMap::m_operationCountSinceLastCleanup whenever the iterator gets
incremented so that null references will be removed the next time the hash map
is modified.

I also updated other read-only operations (such as get() / find() / contains())
to just increment m_operationCountSinceLastCleanup without actually clearing
null references for the same reason as above. Having such read-only operations
invalidate existing iterators is just too error-prone.

Finally, I updated the AddResult constructor to avoid copying the
WeakHashMapIterator it is passed, given that the WeakHashMapIterator
constructor and destructor do some work.

• Source/WTF/wtf/WeakHashMap.h:
• Source/WebCore/dom/Element.cpp:

(WebCore::Element::identifier const):

• Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:

(TestWebKitAPI::TEST):

Canonical link: ​https://commits.webkit.org/251187@main

9:55 AM Changeset in webkit [295091] by commit-queue@webkit.org

• 1 edit
  1 add in trunk

Fix Wasm referenced function calculation for globals
​https://bugs.webkit.org/show_bug.cgi?id=239588

Patch by Asumu Takikawa <​asumu@igalia.com> on 2022-06-01
Reviewed by Keith Miller.

JSTests:

• wasm/regress/239588.js: Added.

(module):

Source/JavaScriptCore:

• wasm/WasmSectionParser.cpp:

(JSC::Wasm::SectionParser::parseInitExpr):

Canonical link: ​https://commits.webkit.org/251186@main

9:20 AM Changeset in webkit [295090] by Tyler Wilcock

• 5 edits
  2 adds in trunk

AX: inert attribute doesn't cause display:contents element to be ignored
​https://bugs.webkit.org/show_bug.cgi?id=241022

Reviewed by Chris Fleizach.

Prior to this patch, the inert attribute didn't cause node-only objects
(like those with display:contents) to be ignored. This was because
AccessibilityObject::defaultObjectInclusion only checked effectiveInert
for elements with renderers, even though you only need an element to
have style (not a renderer).

This patch fixes this by adding a new AccessibilityObject::style()
method which uses AccessibilityObject::element() to get
Element::computedStyle() and checking effectiveInert on that, which
works for both renderer and renderer-less objects.

• LayoutTests/accessibility/node-only-inert-object-expected.txt: Added.
• LayoutTests/accessibility/node-only-inert-object.html: Added.
• LayoutTests/platform/ios/TestExpectations: Enable new test.
• LayoutTests/platform/mac-wk1/TestExpectations: Skip new test.
• Source/WebCore/accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::style const): Added.
(WebCore::AccessibilityObject::defaultObjectInclusion const):

• Source/WebCore/accessibility/AccessibilityObject.h:

Canonical link: ​https://commits.webkit.org/251185@main

8:36 AM Changeset in webkit [295089] by Patrick Angle

• 1 edit
  4 adds in trunk/LayoutTests/platform/mac-wk1

[Mac] http/tests/inspector/network/har/har-page.html constant failure on wk1
​https://bugs.webkit.org/show_bug.cgi?id=229458
rdar://82301476

Reviewed by Devin Rousso.

This test ensures that the _serverPort, _priority, and request cookies are as-expected when exporting a HAR, but that
data is part of AdditionalNetworkLoadMetricsForWebInspector internally, which is not implemented for WK1. In order to
defend the rest of the results going forward, create WK1-specific expectations that exclude those three specific pieces
of data that are unavailable.

• LayoutTests/platform/mac-wk1/TestExpectations:
• LayoutTests/platform/mac-wk1/http/tests/inspector/network/har/har-page-expected.txt: Added.

Canonical link: ​https://commits.webkit.org/251184@main

8:06 AM Changeset in webkit [295088] by commit-queue@webkit.org

• 19 edits in trunk/Source

Firing a fetch event should not be blocked on main thread
​https://bugs.webkit.org/show_bug.cgi?id=241096

Patch by Youenn Fablet <​youennf@gmail.com> on 2022-06-01
Reviewed by Chris Dumez.

The main thread might be blocked by work done by the web page, like executing JavaScript.
This might delay fetch events handling. This can cause PLT regressions when serving content through a service worker.
To limit the perf penalty, we are now hopping to a work queue to process all WebSWContextManagerConnection messages.
For fetch events and message events, we directly go from that thread to the service worker thread.
For install/activate/push/notification events, we keep going through the main thread as they are not as perf crtical.
Also install/activate should follow the same flow as other events like updatefound which are served through WebSWClientConnection.
We change skipWaiting accordingly to remove races in case the reply would go to main thread directly instead of going through the background work queue.

We do some refactoring to allow getting a ServiceWorkerThreadProxy from a background queue.

• Source/WebCore/workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::didSaveScriptsToDisk): Deleted.

• Source/WebCore/workers/service/context/SWContextManager.h:
• Source/WebCore/workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::skipWaiting): Deleted.

• Source/WebCore/workers/service/server/SWServerToContextConnection.h:
• Source/WebCore/workers/service/server/SWServerWorker.h:
• Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::ServiceWorkerThreadProxy::startFetch):
(WebCore::ServiceWorkerThreadProxy::convertFetchToDownload):
(WebCore::ServiceWorkerThreadProxy::continueDidReceiveFetchResponse):
(WebCore::ServiceWorkerThreadProxy::fireMessageEvent):
(WebCore::ServiceWorkerThreadProxy::didSaveScriptsToDisk):
(WebCore::ServiceWorkerThreadProxy::firePushEvent):
(WebCore::ServiceWorkerThreadProxy::firePushSubscriptionChangeEvent):
(WebCore::ServiceWorkerThreadProxy::fireNotificationEvent):
(WebCore::ServiceWorkerThreadProxy::willPostTaskToFireMessageEvent): Deleted.

• Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.h:
• Source/WebKit/Shared/WebPreferencesStore.h
• Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::skipWaiting):

• Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
• Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
• Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::~WebSWContextManagerConnection):
(WebKit::WebSWContextManagerConnection::cancelFetch):
(WebKit::WebSWContextManagerConnection::continueDidReceiveFetchResponse):
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorker):
(WebKit::WebSWContextManagerConnection::didSaveScriptsToDisk):
(WebKit::WebSWContextManagerConnection::convertFetchToDownload):
(WebKit::WebSWContextManagerConnection::skipWaiting):
(WebKit::WebSWContextManagerConnection::skipWaitingCompleted):

• Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h:
• Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in:

Canonical link: ​https://commits.webkit.org/251183@main

8:04 AM Changeset in webkit [295087] by pvollan@apple.com

• 12 edits in trunk/Source/WebKit

[iOS][GPUP] Apply workaround for invalid Mobile Gestalt cache
​https://bugs.webkit.org/show_bug.cgi?id=241036
<rdar://93614152>

Reviewed by Geoffrey Garen.

In the WebContent process on iOS, we have a workaround to repopulate the Mobile Gestalt cache in case
the disk version is invalid. This workaround should be applied to the GPU process as well.

• Source/WebKit/GPUProcess/GPUProcessCreationParameters.cpp:

(WebKit::GPUProcessCreationParameters::encode const):
(WebKit::GPUProcessCreationParameters::decode):

• Source/WebKit/GPUProcess/GPUProcessCreationParameters.h:
• Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:
• Source/WebKit/Shared/AuxiliaryProcess.h:
• Source/WebKit/Shared/AuxiliaryProcess.cpp:

(WebKit::AuxiliaryProcess::populateMobileGestaltCache):

• Source/WebKit/Shared/ios/AuxiliaryProcessIOS.cpp:

(WebKit::AuxiliaryProcess::populateMobileGestaltCache):

• Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::createMobileGestaltSandboxExtensionIfNeeded const):

• Source/WebKit/UIProcess/AuxiliaryProcessProxy.h:
• Source/WebKit/UIProcess/Cocoa/GPUProcessProxyCocoa.mm:

(WebKit::GPUProcessProxy::platformInitializeGPUProcessParameters):

• Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: ​https://commits.webkit.org/251182@main

4:29 AM Changeset in webkit [295086] by Antti Koivisto

• 15 edits
  43 adds in trunk/LayoutTests

Re-import container query WPTs
​https://bugs.webkit.org/show_bug.cgi?id=241168

Reviewed by Tim Nguyen.

• LayoutTests/TestExpectations:
• LayoutTests/imported/w3c/resources/resource-files.json:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/canvas-as-container-001-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/canvas-as-container-001.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/canvas-as-container-002-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/canvas-as-container-002.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/canvas-as-container-003-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/canvas-as-container-003.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/canvas-as-container-004-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/canvas-as-container-004.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-cue-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-cue-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-cue.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-longhand-animation-type-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-longhand-animation-type.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-computed-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-computed.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-size-invalidation-after-load-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-size-invalidation-after-load.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-gradient-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-gradient-invalidation-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-gradient-invalidation.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-gradient-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-gradient.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-media-queries-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-media-queries.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-shadow-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-shadow.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-svglength-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-svglength.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/br-crash.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/columns-in-table-002-crash.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/container-in-canvas-crash.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/orthogonal-replaced-crash.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/w3c-import.log:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/deep-nested-inline-size-containers.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-in-container-invalidation-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-in-container-invalidation.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inner-first-line-non-matching-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inner-first-line-non-matching-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inner-first-line-non-matching.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-002-expected.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-002-ref.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-002.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-003.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-004-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-004.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/style-change-in-container.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/support/cq-testcommon.js:

(polyfill_declarative_shadow_dom):

• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/support/test.vtt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/support/w3c-import.log:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/svg-foreignobject-child-container-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/svg-foreignobject-child-container.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/svg-g-no-size-container-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/svg-g-no-size-container-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/svg-g-no-size-container.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/w3c-import.log:

Canonical link: ​https://commits.webkit.org/251181@main

4:05 AM Changeset in webkit [295085] by commit-queue@webkit.org

• 1 edit in trunk/Tools/wpe/backends/PlatformWPE.cmake

WPEToolingsBackend requires linking against libgobject
​https://bugs.webkit.org/show_bug.cgi?id=241180

Patch by Žan Doberšek <​zdobersek@igalia.com> on 2022-06-01
Unreviewed, WPEToolingsBackend library should link against the GObject library
as required by ATK code, avoiding linking issues that only pop up at the point
of linking the WebKitTestRunner binary, and in only some specific
configurations.

• Tools/wpe/backends/PlatformWPE.cmake:

Have the WPEToolingsBackend link against GObject libraries.

Canonical link: ​https://commits.webkit.org/251180@main

3:30 AM Changeset in webkit [295084] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebCore/platform

Non-unified build fixes, early June 2022 edition
​https://bugs.webkit.org/show_bug.cgi?id=241170

Unreviewed non-unified build fix.

• Source/WebCore/platform/audio/MultiChannelResampler.cpp: Add missing wtf/PrintStream.h inclusion.
• Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: Add missing inclusion of the <functional> stdlib header.

Canonical link: ​https://commits.webkit.org/251179@main

1:54 AM Changeset in webkit [295083] by Antti Koivisto

• 1 edit
  2 adds in trunk

Assertion in RenderTreeBuilder::attachToRenderElementInternal
​https://bugs.webkit.org/show_bug.cgi?id=239823
<rdar://92390285>

Reviewed by Alan Bujtas.

• LayoutTests/fast/css/display-content-with-pending-stylesheet-crash-expected.txt: Added.
• LayoutTests/fast/css/display-content-with-pending-stylesheet-crash.html: Added.
• Source/WebCore/style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):

We can't skip resolution for elements that we have already computed style for. This includes elements with display:contents.

Canonical link: ​https://commits.webkit.org/251178@main

12:04 AM Changeset in webkit [295082] by commit-queue@webkit.org

• 4 edits in trunk/Source/ThirdParty/ANGLE

Improve performance of many render passes.
​https://bugs.webkit.org/show_bug.cgi?id=234008

Patch by Dan Glastonbury <​djg@apple.com> on 2022-05-31
Reviewed by Kimmo Kinnunen.

Through experimentation, it was found that reducing the number of render passes
inflight in the system improves performance. Breaking command buffers with a
large number of render passes into smaller chunks, of at most 16 render passes,
brought the frame rate of ANGLE metal backend inline with ANGLE opengl on macOS
and iOS.

• Source/ThirdParty/ANGLE/changes.diff:
• Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.h:
• Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:

(rx::ContextMtl::flushCommandBuffer):
(rx::ContextMtl::flushCommandBufferIfNeeded):
(rx::ContextMtl::present):
(rx::ContextMtl::getRenderPassCommandEncoder):

• Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_common.h:

Canonical link: ​https://commits.webkit.org/251177@main

May 31, 2022:

10:27 PM Changeset in webkit [295081] by Alan Bujtas

• 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

DOM order may not be sufficient when constructing the LogicalFlexItemList
​https://bugs.webkit.org/show_bug.cgi?id=241166

Reviewed by Antti Koivisto.

We need to hold on to a reference to the layout box in case logical order != DOM order.

• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):

Canonical link: ​https://commits.webkit.org/251176@main

10:00 PM Changeset in webkit [295080] by achristensen@apple.com

• 2 edits in trunk

Allow decidePolicyForNavigation* decisionHandlers to be called on non-main runloops
​https://bugs.webkit.org/show_bug.cgi?id=241157
<rdar://94130705>

Reviewed by Brady Eidson.

Wouldn't it be nice if all apps used your APIs exactly how you want them to?
This is not the case. People call decision handlers on non-main threads.
When this happens, just hop to the main thread to avoid threading issues.

• Source/WebKit/UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):

Canonical link: ​https://commits.webkit.org/251175@main

8:00 PM Changeset in webkit [295079] by commit-queue@webkit.org

• 32 edits
  25 adds in trunk/LayoutTests

Import css/css-text/text-align tests from WPT
​https://bugs.webkit.org/show_bug.cgi?id=241160

Patch by Kiet Ho <Kiet Ho> on 2022-05-31
Reviewed by Tim Nguyen.

Imported from WPT commit 9a7bbe40439176ace294a65474b3a9fed2f8b2d3.

• LayoutTests/TestExpectations:
• LayoutTests/imported/w3c/resources/resource-files.json:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-006-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-006.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-007-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-007.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-008.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-inline-end-crash.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-shy-001-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-shy-001.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-001-expected.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-001.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-002-expected.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-002.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-003-expected.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-003.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-004-expected.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-004.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-005-expected.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-005.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-006-expected.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-006.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-001.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-002.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-003.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-004.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-005.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-006.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-007.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-008.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-009.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-010-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-010.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-011.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-012.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-013.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-014.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-interpolation-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-interpolation.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-01-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-01.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-02-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-02.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-03-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-03.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-04-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-04.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-ltr-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-ltr-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-ltr.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-rtl-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-rtl-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-rtl.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-webkit-match-parent-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-webkit-match-parent.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/w3c-import.log:

Canonical link: ​https://commits.webkit.org/251174@main

7:07 PM Changeset in webkit [295078] by commit-queue@webkit.org

• 1 edit in trunk/Source/ThirdParty/ANGLE/changes.diff

Regenerate Source/ThirdParty/ANGLE/changes.diff
​https://bugs.webkit.org/show_bug.cgi?id=241165

Patch by Dan Glastonbury <​djg@apple.com> on 2022-05-31
Reviewed by Dean Jackson.

• Source/ThirdParty/ANGLE/changes.diff:

Output of update-angle --regenerate-changes-diff

Canonical link: ​https://commits.webkit.org/251173@main

6:53 PM Changeset in webkit [295077] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Move conformance[2]/textures/image_bitmap_from_image_bitmap/ suppressions to top level
​https://bugs.webkit.org/show_bug.cgi?id=241145

Patch by Kenneth Russell <​kbr@chromium.org> on 2022-05-31
Unreviewed test gardening. Move suppressions from
webgl/TestExpectations to top-level TestExpectations.

• LayoutTests/TestExpectations:
• LayoutTests/webgl/TestExpectations:

Canonical link: ​https://commits.webkit.org/251172@main

6:33 PM Changeset in webkit [295076] by Devin Rousso

• 1 edit in trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

Web Inspector: CSS autocomplete: enable experimental feature for initial hint being the most commonly used property of the matching suggestions
​https://bugs.webkit.org/show_bug.cgi?id=241146

Reviewed by Patrick Angle.

• Source/WebInspectorUI/UserInterface/Base/Setting.js:

Canonical link: ​https://commits.webkit.org/251171@main

6:25 PM Changeset in webkit [295075] by Devin Rousso

• 1 edit in trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

Web Inspector: Debugger: blackbox breakpoint evaluations by default
​https://bugs.webkit.org/show_bug.cgi?id=241143

Reviewed by Patrick Angle.

According to <​https://webkit.org/web-inspector/script-blackboxing/>

Script blackboxing is the ability to mark a <script> in Web Inspector so that it is ignored by
the JavaScript debugger, meaning that any JavaScript execution pauses that would happen in that
<script> are instead deferred until JavaScript execution has continued outside of that <script>.

Based on that, developers will likely expect that breakpoint evaluations fall under the category of
"things that the JavaScript debugger does" and would therefore expect that they're ignored/deferred.

• Source/WebInspectorUI/UserInterface/Base/Setting.js:

Canonical link: ​https://commits.webkit.org/251170@main

6:16 PM Changeset in webkit [295074] by Devin Rousso

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines Tab: Screenshots: enable by default
​https://bugs.webkit.org/show_bug.cgi?id=241144

Reviewed by Patrick Angle.

• Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
• Source/WebInspectorUI/UserInterface/Base/Setting.js:
• Source/WebInspectorUI/UserInterface/Models/ScreenshotsInstrument.js:

(WI.ScreenshotsInstrument.supported):

• Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

Canonical link: ​https://commits.webkit.org/251169@main

4:42 PM Changeset in webkit [295073] by Elliott Williams

• 45 edits in trunk/Source

[Xcode] Prevent STP and other self-contained builds from overwriting content in the macOS SDK
​https://bugs.webkit.org/show_bug.cgi?id=240408

Reviewed by Alexey Proskuryakov.

When building with WK_OVERRIDE_FRAMEWORKS_DIR, we assume that WebKit is
being built as part of a self-contained application, e.g. Safari
Technology Preview. This means that most content is installed to the
override directory, instead of the normal /System/Library/Frameworks
directory.

However, static library content (e.g. headers and archives
for bmalloc, webrtc, WTF) is _not_ installed to the override directory,
as it is not needed at runtime. It was being installed to the default
/usr/local prefix, where it would merge with and overwrite whatever
WebKit content was already present.

To prevent overwrites and other sorts of conflict with the
system-provided WebKit, introduce WK_LIBRARY_HEADERS_FOLDER_PATH and
WK_LIBRARY_INSTALL_PATH, which expand to /usr/local/include/safari-sdk
and /usr/local/lib/safari-sdk respectively when building in this mode.
Static library headers and archives are built to these locations, where
they're still in the expected SDK location, but won't clobber system
WebKit.

• Source/bmalloc/Configurations/Base.xcconfig:
• Source/bmalloc/Configurations/bmalloc.xcconfig:
• Source/bmalloc/Configurations/mbmalloc.xcconfig:
• Source/JavaScriptCore/Configurations/Base.xcconfig:
• Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
• Source/JavaScriptCore/DerivedSources.make:
• Source/JavaScriptCore/Scripts/generate-unified-sources.sh:
• Source/JavaScriptCore/offlineasm/config.rb:
• Source/JavaScriptCore/offlineasm/parser.rb:
• Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:
• Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig:
• Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/boringssl.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig:
• Source/WebCore/PAL/Configurations/Base.xcconfig:
• Source/WebCore/PAL/Configurations/PAL.xcconfig:
• Source/WebGPU/Configurations/Base.xcconfig:
• Source/WebGPU/Configurations/WGSL.xcconfig:
• Source/WebGPU/Configurations/WGSLUnitTests.xcconfig:
• Source/WebGPU/Configurations/WebGPU.xcconfig:
• Source/WebKit/Configurations/Base.xcconfig:
• Source/WebKit/Configurations/BaseTarget.xcconfig:
• Source/WebKit/Configurations/SandboxProfiles.xcconfig:
• Source/WebKit/WebKit.xcodeproj/project.pbxproj:
• Source/WebKitLegacy/scripts/generate-unified-sources.sh:
• Source/WebKitLegacy/mac/Configurations/Base.xcconfig:
• Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:
• Source/WTF/Configurations/Base.xcconfig:
• Source/WTF/Configurations/WTF.xcconfig:
• Source/WTF/Configurations/icu.xcconfig:
• Source/WebCore/Configurations/Base.xcconfig:
• Source/WebCore/Configurations/WebCore.xcconfig:
• Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:
• Source/WebCore/DerivedSources.make:
• Source/WebCore/Scripts/generate-unified-sources.sh:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: ​https://commits.webkit.org/251168@main

4:05 PM Changeset in webkit [295072] by Elliott Williams

• 3 edits in trunk/Source

Fix whitespace paths in "Copy Profiling Data"
​https://bugs.webkit.org/show_bug.cgi?id=240285

Unreviewed build fix. JAVASCRIPTCORE_PRIVATE_HEADERS_DIR may contain
spaces, so when we're invoking copy-profiling-data.sh from that
directory we need to defensively quote it.

• Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:
• Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: ​https://commits.webkit.org/251167@main

3:43 PM Changeset in webkit [295071] by Karl Rackler

• 40 edits in trunk/Source

Revert "Perform media networking operations off the main thread"

This reverts commit be35d3c403e1c80fbc18a7a9c0389633448758ac.

Unreviewed revert due to causing 25 consistent crashes on bot.

Canonical link: ​https://commits.webkit.org/251166@main

3:24 PM Changeset in webkit [295070] by J Pascoe

• 1 edit in trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

[WebAuthn][ios] weakThis not checked before clearing ASCProxy
​https://bugs.webkit.org/show_bug.cgi?id=241029
rdar://93932684

Reviewed by Brent Fulgham.

This issue causes crashes after cancelling some types of requests. This change
has been tested on device to verify it fixes the crash.

• Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

Canonical link: ​https://commits.webkit.org/251165@main

3:22 PM Changeset in webkit [295069] by commit-queue@webkit.org

• 1 edit in trunk/metadata/contributors.json

Add Nikita Vasilyev's GitHub username to contributors.json
​https://bugs.webkit.org/show_bug.cgi?id=241158

Patch by Nikita Vasilyev <​me@elv1s.ru> on 2022-05-31
Reviewed by Jonathan Bedard.

• metadata/contributors.json:

Canonical link: ​https://commits.webkit.org/251164@main

3:08 PM Changeset in webkit [295068] by Brent Fulgham

• 1 edit in trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.mm

PopUpSOAuthorization::initSecretWebView modifies parent web view configuration
​https://bugs.webkit.org/show_bug.cgi?id=241155
<rdar://94176551>

Reviewed by Chris Dumez.

The AppSSO flows that create a new WKWebView pass through the method
'PopUpSOAuthorizationSession::initSecretWebView'. This conducts SSO flows in
an invisible Window for cases where other UI handles the actual authentication,
but a web view is needed to handle server interactions. It deactivates AppSSO
in the hidden view so that normal server authentication can happen without AppSSO
being triggered a second time.

This method made the common mistake of assuming that performing 'copy' on the
configuration member of the paren't WKWebView yielded a deep copy that could bei
manipulated to control the invisible view independently of the parent view. While
the method correctly disabled AppSSO for the hidden view, it also deactivated it
for the parent view.

This bug could lead to cases where someone who mistakenly terminated an AppSSO flow
would be unable to start the process a second time, as the view would now be
configured to block access to AppSSO authentication.

This patch corrects that bug.

Tested by SOAuthorizationPopUp.InterceptionSucceedTwice.

• Source/WebKit/UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.mm:

(WebKit::PopUpSOAuthorizationSession::initSecretWebView):

Canonical link: ​https://commits.webkit.org/251163@main

2:47 PM Changeset in webkit [295067] by Elliott Williams

• 4 edits
  1 add in trunk/Source/WebKit

[Xcode] Fix dependency cycles caused by Safari header imports
​https://bugs.webkit.org/show_bug.cgi?id=240285

Reviewed by Tim Horton.

We were including headers produced by targets which depend on WebKit.
For Xcode engineering builds, this is not a valid dependency, because
an engineering build does not distinguish between a "header"
dependency and a regular target dependency. These errors have survived
in the codebase because:

• Xcode doesn't recognize header imports as "implicit dependencies",

so the build system hasn't traditionally known these dependencies
exist, except in some incremental builds.

• These headers are available in internal SDKs, so it's possible for

the targets to build out-of-order but build successfully (as long as
the first target to build can use a possibly-outdated version of the
code from the SDK).

When building targets in parallel, we are emitting more information to
recognize these as implicit dependencies (revealing the cycle) and the
build system is laying down framework bundle directories earlier on in
the build (preventing reliance on SDK frameworks).

• Source/WebKit/WebKit.xcodeproj/project.pbxproj: WebKit needs to build after AuthenticationServicesCore in internal builds. Add it as a product dependency.
• Source/WebKit/Configurations/WebKit.xcconfig: Because AuthenticationServicesCore.framework is not available externally, add it to EXCLUDED_SOURCE_FILE_NAMES. The build system still honors the product dependency ordering, but won't fail when it's missing.

• Source/WebKit/Platform/spi/ios/SafariServicesSPI.h: Added, contains interface declarations for needed SSReadingList API. Technically not SPI, but follows the convention of similar platform redeclaration headers.
• Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm: WebKit cannot depend on SafariServices. Replace the import of SSReadingList.h with SafariServicesSPI.h.
• Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: WebKit cannot depend on AuthenticationServices.framework. Thankfully, this import was unused. Delete it.
• Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm: WebKit cannot depend on SafariServices. Replace the import of SSReadingList.h with SafariServicesSPI.h.

Canonical link: ​https://commits.webkit.org/251162@main

2:22 PM Changeset in webkit [295066] by msaboff@apple.com

• 3 edits
  1 add in trunk

ASSERTION FAILED: regExp->isValid() LLIntSlowPaths.cpp(625)
​https://bugs.webkit.org/show_bug.cgi?id=241107
<rdar://93369481>

Reviewed by Mark Lam.

We can remove this ASSERT(regExp->isValid()) and others like it that are used for NewRegExp
bytecode processing because subsequent code already must handle the invalid case. These code
paths may create a new RegExp or retrieve a cached RegExp. For the case where a RegExp is
created for the first time it is valid or we wouldn't have generated the NewRegExp bytecode.
This valid RegExp can subsequently be marked with an error if it fails YARR RegExp engine JIT
code or interpreter bytecode generation. Matching with a RegExp with one of these generation
errors properly throws a Syntax error. These ASSERTs fail when the NewRegExp processing
retrieves an already cached RegExp, with a generation error. The matching code will still
throw a Syntax Error.

• JSTests/stress/regexp-late-compilation-error.js: Added.

(testRegExp1):
(testRegExp2):
(test):

• Source/JavaScriptCore/dfg/DFGOperations.cpp:

(JSC::DFG::JSC_DEFINE_JIT_OPERATION):

• Source/JavaScriptCore/jit/JITOperations.cpp:

(JSC::JSC_DEFINE_JIT_OPERATION):

• Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

Canonical link: ​https://commits.webkit.org/251161@main

2:18 PM Changeset in webkit [295065] by Elliott Williams

• 6 edits
  1 add in trunk/Source

Refer to correct profiling data in WebCore and WebKit
​https://bugs.webkit.org/show_bug.cgi?id=239681

Reviewed by Alexey Proskuryakov.

Revert "Unreviewed, revert "[Xcode] Compute PGO profdata paths instead of searching for them at build time""
This reverts commit 2ee0d9d171e2ff7daa94d1a15727033a994e6414.

A bad copy-paste led to WebCore and WebKit's production builds using PGO
data from JavaScriptCore. Fix it, and add back a check that ensures
production builds fail instead of falling back to stub profiling data.

• Source/WebCore/Configurations/WebCore.xcconfig:
• Source/WebKit/Configurations/BaseTarget.xcconfig:

Canonical link: ​https://commits.webkit.org/251160@main

2:13 PM Changeset in webkit [295064] by J Pascoe

• 2 edits in trunk/Source/WebKit/UIProcess/API/Cocoa

Remove setUsernameForLocalCredentialWithGroupAndID SPI
​https://bugs.webkit.org/show_bug.cgi?id=240829
<rdar://93366441>

Reviewed by Brent Fulgham.

This SPI is no longer used internally and can be removed.

• Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
• Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithID:username:]): Deleted.
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithGroupAndID:credential:username:]): Deleted.

Canonical link: ​https://commits.webkit.org/251159@main

1:53 PM Changeset in webkit [295063] by Chris Dumez

• 1 edit in trunk/Source/WebCore/dom/Element.cpp

REGRESSION (251042@main):[ iOS Debug ] ASSERTION FAILED: m_ptr in Ref.h(115) : T *WTF::Ref<WTF::WeakPtrImpl<>>::operator->() const [T = WTF::WeakPtrImpl<>, Traits = WTF::RawPtrTraits<WTF::WeakPtrImpl<>>]
​https://bugs.webkit.org/show_bug.cgi?id=241141
<rdar://94168551>

Unreviewed, remove null references in the WeakHashMap before calling
WeakHashMap::ensure() to address assertion hits on iOS Debug bots.

This seems to indicate a potential WeakHashMap bug where
WeakHashMap::ensure() can get confused if the WeakMapHash contains
null references but I'll investigate separately.

• Source/WebCore/dom/Element.cpp:

(WebCore::Element::identifier const):

Canonical link: ​https://commits.webkit.org/251158@main

1:19 PM Changeset in webkit [295062] by Wenson Hsieh

• 1 edit
  2 adds in trunk

[macOS] Include text context menu actions when right clicking on selected Live Text in a link
​https://bugs.webkit.org/show_bug.cgi?id=241069
rdar://91606522

Reviewed by Devin Rousso.

Currently, when right clicking selected text inside of an image that's inside of a link, we only
show context menu actions for the link and image. While it's still possible to copy this selected
text using the Menu Bar (Edit > Copy), this should be reflected in the context menu as well.

To fix this, we adjust a bit of macOS-specific logic in ContextMenuController to include the set
of text actions as well, in this scenario.

• LayoutTests/fast/images/text-recognition/mac/context-menu-for-image-in-link-contains-copy-expected.txt: Added.
• LayoutTests/fast/images/text-recognition/mac/context-menu-for-image-in-link-contains-copy.html: Added.

Add a layout test to verify the change.

• Source/WebCore/page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

Always show selected text options for selected Live Text. Additionally, simplify a bit of nearby
code to take advantage of "if statements with initializers".

Canonical link: ​https://commits.webkit.org/251157@main

12:14 PM Changeset in webkit [295061] by Chris Dumez

• 2 edits in trunk/Source/JavaScriptCore/runtime

Simplify Structure::checkOffsetConsistency()
​https://bugs.webkit.org/show_bug.cgi?id=241025

Reviewed by Geoffrey Garen.

Drop redundant isCompilationThread() check in checkOffsetConsistency() before calling
checkOffsetConsistency(PropertyTable*, const DetailsFunc&) since the callee already
does this check. Hopefully, the compiler was already optimizing out the duplicate
check but it is better to be sure given that this check shows on speedometer profiles,
mostly under checkOffsetConsistency().

Also drop the return value since no caller makes use of it.

• Source/JavaScriptCore/runtime/Structure.h:
• Source/JavaScriptCore/runtime/StructureInlines.h:

(JSC::Structure::checkOffsetConsistency const):

Canonical link: ​https://commits.webkit.org/251156@main

11:09 AM Changeset in webkit [295060] by Devin Rousso

• 9 edits in trunk

Web Inspector: Open Resource dialog should support matching file paths
​https://bugs.webkit.org/show_bug.cgi?id=178152
<rdar://problem/34925656>

Reviewed by Patrick Angle.

• Source/WebInspectorUI/UserInterface/Controllers/ResourceQueryController.js:

(WI.ResourceQueryController.prototype.executeQuery):
(WI.ResourceQueryController.prototype._findSpecialCharacterIndicesInDisplayName): Added.
(WI.ResourceQueryController.prototype._findSpecialCharacterIndicesInURL): Added.
(WI.ResourceQueryController.prototype._findSpecialCharacterIndices): Deleted.
Do a second search for the entire URL. Use the result that has the better rank.

• Source/WebInspectorUI/UserInterface/Controllers/QueryController.js:

(WI.QueryController.prototype.findSpecialCharacterIndices): Added.

• Source/WebInspectorUI/UserInterface/Controllers/CSSQueryController.js:

(WI.CSSQueryController.prototype.executeQuery):
(WI.CSSQueryController.prototype._findSpecialCharacterIndicesInPropertyName): Added.
(WI.CSSQueryController.prototype._findSpecialCharacterIndices): Deleted.
Move the shared _findSpecialCharacterIndices to the base class to avoid repeated logic.

• Source/WebInspectorUI/UserInterface/Models/ResourceQueryResult.js:

(WI.ResourceQueryResult):
(WI.ResourceQueryResult.prototype.get searchString): Added.
Include the string for the matches so callers can reason about what was matched.

• Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js:

(WI.OpenResourceDialog.prototype._populateResourceTreeOutline):
(WI.OpenResourceDialog.prototype._populateResourceTreeOutline.createHighlightedTitleFragment):
Shift the matches if it was for the entire URL, so that highlights still appear for the display name.

• LayoutTests/inspector/unit-tests/css-query-controller.html:
• LayoutTests/inspector/unit-tests/css-query-controller-expected.txt:
• LayoutTests/inspector/unit-tests/resource-query-controller.html:
• LayoutTests/inspector/unit-tests/resource-query-controller-expected.txt:

Canonical link: ​https://commits.webkit.org/251155@main

11:00 AM Changeset in webkit [295059] by Chris Dumez

• 2 edits in trunk/Source/WebCore/dom

Avoid GCReacheableRefMap lookup inside JSNodeOwner::isReachableFromOpaqueRoots()
​https://bugs.webkit.org/show_bug.cgi?id=241063

Reviewed by Geoffrey Garen.

Avoid GCReacheableRefMap lookup inside JSNodeOwner::isReachableFromOpaqueRoots()
by leveraging a flag on Node. According to A/B testing this is a ~0.5%
progression on Speedometer on Apple Silicon.

• Source/WebCore/dom/GCReachableRef.h:

(WebCore::GCReachableRefMap::contains):
(WebCore::GCReachableRefMap::add):
(WebCore::GCReachableRefMap::remove):

• Source/WebCore/dom/Node.h:

(WebCore::Node::isInGCReacheableRefMap const):
(WebCore::Node::setIsInGCReacheableRefMap):

Canonical link: ​https://commits.webkit.org/251154@main

10:12 AM Changeset in webkit [295058] by Brent Fulgham

• 3 edits in trunk

REGRESSION (250981@main): Two SOAuthorization API tests failing
​https://bugs.webkit.org/show_bug.cgi?id=240979
<rdar://93996565>

Reviewed by Chris Dumez.

In Bug 240739 I modified AppSSO to lazily initialize the SOAuthenticationCoordinator. This introduced
two problems in the API Tests:

1. SOAuthorizationRedirect.InterceptionSucceed3 expected SOAuthentiationCoordinator initialization to happen as soon as the WKWebsiteDataStore was created, but this is now too soon. The assertion just needed to be made after an AppSSO operation was called that would construct the SSO object.
2. SOAuthorizationPopUp.InterceptionSucceedTwice revealed a real bug. We almost never start an AppSSO flow, then turn off the feature -- except in the case of a pop-up authentication, which creates a secret hidden window without AppSSO turned on. Hitting this test case caused a crash that needed to be addressed by checking for this rare case, and making sure we didn't dereference a nullptr.

• Source/WebKit/UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.mm:

(WebKit::PopUpSOAuthorizationSession::initSecretWebView): Properly disable AppSSO through the WKPreference,
rather than reaching into the object to modify WebKit internal state.

• Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::trySOAuthorization): Don't attempt to dereference the SOAuthenticationCoordinator when the
AppSSO feature is turned off for a pop-up window.

• Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:

(TestWebKitAPI::TEST): Move the assertion to after AppSSO initialization is complete.

Canonical link: ​https://commits.webkit.org/251153@main

10:05 AM Changeset in webkit [295057] by commit-queue@webkit.org

• 2 edits in trunk/Source/cmake

[WPE][GTK] Expose ENABLE_VIDEO build option
​https://bugs.webkit.org/show_bug.cgi?id=241128

Patch by Michael Catanzaro <​mcatanzaro@redhat.com> on 2022-05-31
Reviewed by Philippe Normand.

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsWPE.cmake:

Canonical link: ​https://commits.webkit.org/251151@main

10:05 AM Changeset in webkit [295056] by sihui_liu@apple.com

• 17 edits in trunk

Remove some WebSQL code from WebKit
​https://bugs.webkit.org/show_bug.cgi?id=240857

Reviewed by Chris Dumez.

• Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bubblewrapSpawn):

• Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

• Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):

• Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::resolvedMediaKeysDirectory const):
(WebKit::WebsiteDataStore::resolvedDatabaseDirectory const): Deleted.

• Source/WebKit/UIProcess/WebsiteData/playstation/WebsiteDataStorePlayStation.cpp:

(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

• Source/WebKit/UIProcess/WebsiteData/win/WebsiteDataStoreWin.cpp:

(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

• Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp:

(WebKit::WebProcessProxy::platformGetLaunchOptions):

• Source/WebKit/UIProcess/glib/WebsiteDataStoreGLib.cpp:

(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

• Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleClearAllDatabases): Deleted.

• Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
• Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota): Deleted.

• Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
• Source/WebKit/WebProcess/WebProcess.cpp:

(WebKit::WebProcess::prepareToSuspend):

• Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.html:
• Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(runWebsiteDataStoreCustomPaths):

• Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

• Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::clearAllDatabases):

Canonical link: ​https://commits.webkit.org/251151@main

9:59 AM Changeset in webkit [295055] by Devin Rousso

• 1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineOverviewGraph.css

Web Inspector: Timelines Tab: Screenshots: the selected image should be on top in the overview
​https://bugs.webkit.org/show_bug.cgi?id=240878

Reviewed by Patrick Angle.

• Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineOverviewGraph.css:

(.timeline-overview-graph.screenshots > img.selected):

Canonical link: ​https://commits.webkit.org/251150@main

9:08 AM Changeset in webkit [295054] by fred.wang@free.fr

• 5 edits in trunk/Source/WebCore/svg/properties

Handle start/stop conflicts with multiple SVG animators
​https://bugs.webkit.org/show_bug.cgi?id=241121

Reviewed by Said Abou-Hallawa.

While animating an SVG property from multiple animators, and if there
are multiple instance of this property, then starting or stopping a
specific animator can override the shared m_animVal. This patch fixes
that issue by allowing instanceStartAnimation/instanceStopAnimation
to modify m_animVal only in the case where there are no other animators
for this property. The change is performed for each SVG type (Value,
Primitive, Decorated and List).

• Source/WebCore/svg/properties/SVGAnimatedDecoratedProperty.h: Do not touch m_animVal if there are other animators for this property.
• Source/WebCore/svg/properties/SVGAnimatedPrimitiveProperty.h: Ditto.
• Source/WebCore/svg/properties/SVGAnimatedProperty.h: Ditto.
• Source/WebCore/svg/properties/SVGAnimatedPropertyList.h: Ditto.
• Source/WebCore/svg/properties/SVGAnimatedValueProperty.h: Fix a typo.

Canonical link: ​https://commits.webkit.org/251149@main

8:41 AM Changeset in webkit [295053] by aakash_jain@apple.com

• 1 edit in trunk/Tools/CISupport/ews-build/steps.py

EWS should email PR author in case Merge-Queue silently fails on their PR
​https://bugs.webkit.org/show_bug.cgi?id=241101

Reviewed by Jonathan Bedard.

• Tools/CISupport/ews-build/steps.py:

(ValidateChange.validate_github):
(ValidateChange.send_email_for_github_failure):

Canonical link: ​https://commits.webkit.org/251148@main

8:22 AM Changeset in webkit [295052] by Wenson Hsieh

• 9 edits in trunk/Source

[iOS] Refactor some logic around VideoFullscreenInterfaceAVKit
​https://bugs.webkit.org/show_bug.cgi?id=241113

Reviewed by Eric Carlson.

Adjust the window level of VideoFullscreenInterfaceAVKit's window. No change in behavior.

• Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:

(VideoFullscreenInterfaceAVKit::doSetup):

• Source/WebKit/UIProcess/PageClient.h:
• Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didEnterFullscreen):
(WebKit::WebPageProxy::didExitFullscreen):

Also refactor WebPageProxy::did(Enter|Exit)Fullscreen, such that we implement
didExitFullscreen(PlaybackSessionContextIdentifier) in the case where
ENABLE(VIDEO_PRESENTATION_MODE) is enabled, and didExitFullscreen() (with no arguments) in the
case where it's disabled.

Currently both versions of did(Enter|Exit)Fullscreen() exist if ENABLE(VIDEO_PRESENTATION_MODE)
is set, even though we only expect to call into did(Enter|Exit)Fullscreen() from outside of
WebPageProxy.

• Source/WebKit/UIProcess/WebPageProxy.h:
• Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
• Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didEnterFullscreen):
(WebKit::PageClientImpl::didExitFullscreen):

• Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _didEnterFullscreen]):
(-[WKContentView _didExitFullscreen]):

• Source/WebKit/UIProcess/mac/PageClientImplMac.h:

Canonical link: ​https://commits.webkit.org/251147@main

6:41 AM Changeset in webkit [295051] by Alan Bujtas

• 3 edits in trunk/Source/WebCore/layout

Add support for margin: auto
​https://bugs.webkit.org/show_bug.cgi?id=241111

Reviewed by Antti Koivisto.

Auto margins take up all of the space that they can in their axis.

1. compute the space 'margin: auto' can take
2. distribute it among flex items with 'margin: auto'
3. adjust final top/left with the computed margin

• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::computedAutoMarginValueForFlexItems):
(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):

• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:

Canonical link: ​https://commits.webkit.org/251146@main

6:39 AM Changeset in webkit [295050] by Oriol Brufau

• 3 edits in trunk/Source/WebCore

Ensure logical properties have skip-builder
​https://bugs.webkit.org/show_bug.cgi?id=241105

Reviewed by Tim Nguyen.

Builder::applyProperty resolves logical properties into physical ones.
So there is no need to define BuilderCustom methods for them.
Thus, most already have skip-builder:true. This patch covers the only
two exceptions.

No test since there should be no change in behavior.

• Source/WebCore/css/CSSProperties.json:

Flag contain-intrinsic-block-size and contain-intrinsic-inline-size with
skip-builder:true.

• Source/WebCore/css/makeprop.pl:

Require logical properties to have skip-builder:true.

• Source/WebCore/style/StyleBuilderCustom.h:

(WebCore::Style::BuilderCustom::applyInitialContainIntrinsicBlockSize): Deleted.
(WebCore::Style::BuilderCustom::applyInheritContainIntrinsicBlockSize): Deleted.
(WebCore::Style::BuilderCustom::applyValueContainIntrinsicBlockSize): Deleted.
(WebCore::Style::BuilderCustom::applyInitialContainIntrinsicInlineSize): Deleted.
(WebCore::Style::BuilderCustom::applyInheritContainIntrinsicInlineSize): Deleted.
(WebCore::Style::BuilderCustom::applyValueContainIntrinsicInlineSize): Deleted.
Remove unnecessary logic.

Canonical link: ​https://commits.webkit.org/251145@main

6:24 AM Changeset in webkit [295049] by ntim@apple.com

• 32 edits
  27 adds
  1 delete in trunk

Unprefix -webkit-text-justify and add inter-character value
​https://bugs.webkit.org/show_bug.cgi?id=229084
<rdar://82177456>

Reviewed by Antti Koivisto.

This is still disabled by default behind the cssTextJustifyEnabled setting.
We don't keep support for the -webkit- prefix, since only Firefox ships text-justify (without the prefix) and it was never enabled in WebKit for macOS/iOS.

distribute and inter-character are aliases, with distribute being the legacy one. The spec specifies it as parse-time, but we implement it compute-time (like Chrome).

​https://github.com/w3c/csswg-drafts/issues/7322 is filed about potentially removing 'distribute' from the spec.

• LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-expected.txt: Removed.
• LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited-expected.txt: Removed.
• LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html: Removed.
• LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html: Removed.

Removed parsing tests redundant with WPT.

• LayoutTests/fast/css3-text/css3-text-justify/text-justify-none.html:
• LayoutTests/fast/text/text-combine-crash.html:
• LayoutTests/TestExpectations:
• LayoutTests/imported/w3c/resources/resource-files.json:
• LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-allowed-properties-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-allowed-properties-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-justify-computed-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-justify-valid-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-bidi-003.xht:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-001.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-002.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-003.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-004.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-005.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-006.html:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/distribute-alias.tentative-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/distribute-alias.tentative.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-001-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-001.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-002-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-002.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-003-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-003.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-004-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-004.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-005-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-005.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-006-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-006.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-distribute-001-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-distribute-001.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-character-001-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-character-001-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-character-001.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-word-001-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-word-001-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-word-001.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-interpolation-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-interpolation.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-none-001-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-none-001-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-none-001.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/w3c-import.log:
• LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
• LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
• LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

Import new WPT from 6aa9a39, remove prefixes automatically added by the importer, and rebaseline tests.

• Source/WebCore/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

• Source/WebCore/css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

• Source/WebCore/css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextJustify const):

• Source/WebCore/css/CSSProperties.json:
• Source/WebCore/css/StyleProperties.cpp:
• Source/WebCore/css/parser/CSSParserContext.cpp:

(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):

• Source/WebCore/css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

• Source/WebCore/rendering/LegacyLineLayout.cpp:

(WebCore::LegacyLineLayout::textAlignmentForLine const):

• Source/WebCore/rendering/style/RenderStyleConstants.h:
• Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:

Canonical link: ​https://commits.webkit.org/251144@main

6:02 AM Changeset in webkit [295048] by commit-queue@webkit.org

• 5 edits
  1 add in trunk/Source/WebCore/platform

[Linux] TextureMapperPlatformLayerProxyDMABuf should support different colorspaces
​https://bugs.webkit.org/show_bug.cgi?id=240633

Patch by Žan Doberšek <​zdobersek@igalia.com> on 2022-05-31
Reviewed by Miguel Gomez and Philippe Normand.

Add the DMABufColorSpace enumeration, covering different colorspaces we
currently can support between decoded GStreamer data and the TextureMapper
DMABuf integration.

DMABufObject gains a DMABufColorSpace member variable, initially of an invalid
value but that can be overridden by whoever is constructing the object.

In MediaPlayerPrivateGStreamer, the desired colorspace can be retrieved from the
GstVideoInfo colorimetry information and set on the DMABufObject.

The colorspace is now respected in TextureMapperPlatformLayerProxyDMABuf,
choosing between different YUV-to-RGB matrices that are to be used when sampling
from the set of plane-assigned textures. The default is the BT.601 conversion
matrix. For RGBA-like formats, no conversion is required, so an assert is placed
to ensure that the colorspace is either unspecified or specified as SRGB.

• Source/WebCore/platform/TextureMapper.cmake:
• Source/WebCore/platform/graphics/gbm/DMABufColorSpace.h: Added.
• Source/WebCore/platform/graphics/gbm/DMABufObject.h:

(WebCore::DMABufObject::encode const):
(WebCore::DMABufObject::encode):
(WebCore::DMABufObject::decode):

• Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp:
• Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::colorSpaceForColorimetry):
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):

• Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp:

(WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::paintToTextureMapper):

Canonical link: ​https://commits.webkit.org/251143@main

5:33 AM Changeset in webkit [295047] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit/WebProcess/WebPage

[WPE][GTK] Build broken with ENABLE_VIDEO=OFF after r292252
​https://bugs.webkit.org/show_bug.cgi?id=241123

Reviewed by Philippe Normand.

• Source/WebKit/WebProcess/WebPage/WebPage.cpp: Add missing ENABLE(VIDEO) guard.
• Source/WebKit/WebProcess/WebPage/WebPage.h: Ditto.

Canonical link: ​https://commits.webkit.org/251142@main

3:38 AM Changeset in webkit [295046] by commit-queue@webkit.org

• 1 edit in trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp

[GStreamer] DMABufVideoSink fails to list NV21 as a supported format
​https://bugs.webkit.org/show_bug.cgi?id=241119

Patch by Žan Doberšek <​zdobersek@igalia.com> on 2022-05-31
Reviewed by Miguel Gomez and Philippe Normand.

• Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:

NV12 is listed twice in the DMABufVideoSink's list of supported formats. This
is a typo, one of those was supposed to be NV21, a different-but-similar format
that works just fine.

Canonical link: ​https://commits.webkit.org/251141@main

1:22 AM WebKitGTK/2.36.x edited by Adrian Perez de Castro

Started section of merges for the 2.36.x releases (diff)

1:15 AM Changeset in webkit [295045] by Adrian Perez de Castro

• 1 edit in trunk/Source/WebCore/bindings/js/JSDOMMapLike.cpp

[GTK][WPE] Build failure when cross-building for 64-bit ARM
​https://bugs.webkit.org/show_bug.cgi?id=241109

Unreviewed build fix.

• Source/WebCore/bindings/js/JSDOMMapLike.cpp: Add missing JavaScriptCore/HashMapImplInlines.h header inclusion.

Canonical link: ​https://commits.webkit.org/251140@main