⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 4, 2022:

11:59 PM Changeset in webkit [295270] by Chris Dumez
  • 380 edits in trunk

Drop operator==() overload for comparing a String to a const char*
https://bugs.webkit.org/show_bug.cgi?id=241285

Reviewed by Darin Adler.

Drop operator==() overload for comparing a String to a const char*. This
encourages people to use ""_s for string literals.

  • Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEqualityOpImpl):

  • Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode):

  • Source/JavaScriptCore/inspector/ScriptCallFrame.cpp:

(Inspector::ScriptCallFrame::isNative const):

  • Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::handleEvent):

  • Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:

(CppProtocolTypesImplementationGenerator):

  • Source/JavaScriptCore/jit/ExecutableAllocator.cpp:

(JSC::isJITEnabled):
(JSC::ExecutableAllocator::setJITEnabled):

  • Source/JavaScriptCore/jsc.cpp:

(dumpException):

  • Source/JavaScriptCore/runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):

  • Source/JavaScriptCore/runtime/IntlObject.cpp:

(JSC::removeUnicodeLocaleExtension):

  • Source/JavaScriptCore/runtime/JSObject.cpp:

(JSC::JSObject::calculatedClassName):

  • Source/JavaScriptCore/runtime/Options.cpp:

(JSC::canUseJITCage):

  • Source/JavaScriptCore/runtime/StringPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

  • Source/JavaScriptCore/runtime/TypeSet.cpp:

(JSC::StructureShape::leastCommonAncestor):

  • Source/JavaScriptCore/tools/JSDollarVM.cpp:
  • Source/JavaScriptCore/yarr/YarrUnicodeProperties.cpp:

(JSC::Yarr::unicodeMatchPropertyValue):

  • Source/WTF/wtf/URL.cpp:

(WTF::URL::setProtocol):

  • Source/WTF/wtf/cocoa/Entitlements.h:
  • Source/WTF/wtf/cocoa/Entitlements.mm:

(WTF::hasEntitlement):
(WTF::processHasEntitlement):
(WTF::hasEntitlementValue):

  • Source/WTF/wtf/text/WTFString.h:
  • Source/WebCore/Modules/applepay/PaymentRequestValidator.mm:

(WebCore::validateCountryCode):
(WebCore::validateCurrencyCode):

  • Source/WebCore/Modules/async-clipboard/ios/ClipboardImageReaderIOS.mm:

(WebCore::ClipboardImageReader::readBuffer):

  • Source/WebCore/Modules/async-clipboard/mac/ClipboardImageReaderMac.mm:

(WebCore::ClipboardImageReader::readBuffer):

  • Source/WebCore/Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::requestFromInfo):

  • Source/WebCore/Modules/cache/DOMCacheEngine.cpp:

(WebCore::DOMCacheEngine::matchURLs):

  • Source/WebCore/Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):

  • Source/WebCore/Modules/fetch/FetchRequest.cpp:

(WebCore::methodCanHaveBody):
(WebCore::FetchRequest::initializeOptions):
(WebCore::FetchRequest::referrer const):

  • Source/WebCore/Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::contentTypeShouldGenerateTimestamps):

  • Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::setContentHint):

  • Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp:

(WebCore::RTCRtpSFrameTransform::setEncryptionKey):

  • Source/WebCore/Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::dtmf):

  • Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:

(WebCore::GStreamerMediaEndpoint::createTransceiverBackends):

  • Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:

(WebCore::iceCandidateType):

  • Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp:

(WebCore::toRTCIceProtocol):
(WebCore::toRTCIceTcpCandidateType):
(WebCore::toRTCIceCandidateType):
(WebCore::parseIceCandidateSDP):

  • Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addTransceiver):

  • Source/WebCore/Modules/webauthn/cbor/CBORValue.cpp:

(cbor::CBORValue::CBORValue):

  • Source/WebCore/Modules/webauthn/cbor/CBORValue.h:
  • Source/WebCore/Modules/webauthn/fido/AuthenticatorGetInfoResponse.cpp:

(fido::encodeAsCBOR):

  • Source/WebCore/Modules/webauthn/fido/FidoConstants.h:
  • Source/WebCore/Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::setBinaryType):

  • Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp:

(PAL::WebGPU::AdapterImpl::requestDevice):

  • Source/WebCore/accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canSetValueAttribute const):

  • Source/WebCore/accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::currentState const):
(WebCore::AccessibilityObject::attributeValue const):

  • Source/WebCore/accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::isColumnHeaderCell const):
(WebCore::AccessibilityTableCell::isRowHeaderCell const):
(WebCore::AccessibilityTableCell::columnHeaders):
(WebCore::AccessibilityTableCell::rowHeaders):
(WebCore::AccessibilityTableCell::axRowSpan const):

  • Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::state const):

  • Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::textAttributes const):

  • Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::attributeValue const):

  • Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp:

(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue):

  • Source/WebCore/animation/KeyframeEffect.cpp:

(WebCore::IDLAttributeNameToAnimationPropertyName):

  • Source/WebCore/bindings/js/IDBBindingUtilities.cpp:

(WebCore::get):

  • Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSC_DEFINE_HOST_FUNCTION):

  • Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowInstanceFunction_openDatabaseBody):

  • Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:

(GenerateIsLegacyUnforgeablePropertyName):

  • Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp:

(WebCore::JSTestNamedSetterWithLegacyUnforgeableProperties::defineOwnProperty):

  • Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp:

(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns::defineOwnProperty):

  • Source/WebCore/contentextensions/ContentExtensionActions.cpp:

(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::parse):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::parse):

  • Source/WebCore/contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::loadAction):

  • Source/WebCore/crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::importKey):

  • Source/WebCore/crypto/algorithms/CryptoAlgorithmECDSA.cpp:

(WebCore::CryptoAlgorithmECDSA::importKey):

  • Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):

  • Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

  • Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::importKey):

  • Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::importKey):

  • Source/WebCore/crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::importJwk):

  • Source/WebCore/crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::importJwk):

  • Source/WebCore/crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::importJwk):

  • Source/WebCore/crypto/keys/CryptoKeyRSA.cpp:

(WebCore::CryptoKeyRSA::importJwk):

  • Source/WebCore/css/CSSBasicShapes.cpp:

(WebCore::buildInsetRadii):

  • Source/WebCore/css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const):

  • Source/WebCore/css/CSSPropertySourceData.cpp:

(WebCore::CSSPropertySourceData::toString const):

  • Source/WebCore/css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):

  • Source/WebCore/css/MediaQuery.cpp:

(WebCore::MediaQuery::serialize const):

  • Source/WebCore/css/SelectorCheckerTestFunctions.h:

(WebCore::matchesLangPseudoClass):

  • Source/WebCore/css/StyleProperties.cpp:

(WebCore::StyleProperties::borderPropertyValue const):
(WebCore::StyleProperties::asTextInternal const):

  • Source/WebCore/css/parser/CSSPropertyParser.cpp:

(WebCore::parseGridTemplateAreasRow):
(WebCore::CSSPropertyParser::canParseTypedCustomPropertyValue):
(WebCore::CSSPropertyParser::collectParsedCustomPropertyValueDependencies):
(WebCore::CSSPropertyParser::parseTypedCustomPropertyValue):

  • Source/WebCore/dom/DataTransfer.cpp:

(WebCore::DataTransfer::getDataForItem const):
(WebCore::DataTransfer::readStringFromPasteboard const):
(WebCore::DataTransfer::setDataFromItemList):
(WebCore::dragOpFromIEOp):
(WebCore::DataTransfer::dropEffect const):
(WebCore::DataTransfer::setDropEffect):

  • Source/WebCore/dom/DataTransfer.h:

(WebCore::DataTransfer::dropEffectIsUninitialized const):

  • Source/WebCore/dom/Document.cpp:

(WebCore::Document::originIdentifierForPasteboard const):

  • Source/WebCore/dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

  • Source/WebCore/dom/Range.cpp:

(WebCore::Range::expand):

  • Source/WebCore/dom/UIEventWithKeyState.cpp:

(WebCore::UIEventWithKeyState::getModifierState const):

  • Source/WebCore/editing/Editing.cpp:

(WebCore::isMailBlockquote):

  • Source/WebCore/editing/Editor.cpp:

(WebCore::Editor::handleTextEvent):
(WebCore::Editor::insertTextWithoutSendingTextEvent):

  • Source/WebCore/editing/HTMLInterchange.h:
  • Source/WebCore/editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::doApply):

  • Source/WebCore/editing/ReplaceSelectionCommand.cpp:

(WebCore::isInterchangeNewlineNode):
(WebCore::isInterchangeConvertedSpaceSpan):
(WebCore::isInlineNodeWithStyle):

  • Source/WebCore/editing/cocoa/HTMLConverter.mm:

(HTMLConverter::computedAttributesForElement):
(HTMLConverter::_addAttachmentForElement):
(HTMLConverter::_enterElement):
(HTMLConverter::_addTableForElement):
(HTMLConverter::_addTableCellForElement):
(HTMLConverter::_processElement):
(HTMLConverter::_exitElement):
(HTMLConverter::_processText):

  • Source/WebCore/editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendNodeToPreserveMSOList):
(WebCore::createFragmentFromText):
(WebCore::createFragmentForTransformToFragment):

  • Source/WebCore/html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::handleKeydownEvent):

  • Source/WebCore/html/BaseClickableWithKeyInputType.cpp:

(WebCore::BaseClickableWithKeyInputType::handleKeydownEvent):
(WebCore::BaseClickableWithKeyInputType::handleKeyupEvent):

  • Source/WebCore/html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::handleKeyupEvent):

  • Source/WebCore/html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine):

  • Source/WebCore/html/FormController.cpp:

(WebCore::FormController::SavedFormState::appendReferencedFilePaths const):

  • Source/WebCore/html/HTMLAnchorElement.cpp:

(WebCore::isEnterKeyKeydownEvent):

  • Source/WebCore/html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::parseAttribute):

  • Source/WebCore/html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::defaultEventHandler):

  • Source/WebCore/html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::is2dType):
(WebCore::HTMLCanvasElement::isWebGLType):
(WebCore::HTMLCanvasElement::toWebGLVersion):
(WebCore::HTMLCanvasElement::isBitmapRendererType):

  • Source/WebCore/html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseAttribute):

  • Source/WebCore/html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValueFromRenderer):

  • Source/WebCore/html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::collectPresentationalHintsForAttribute):

  • Source/WebCore/html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::collectPresentationalHintsForAttribute):

  • Source/WebCore/html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::collectPresentationalHintsForAttribute):

  • Source/WebCore/html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

  • Source/WebCore/html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

  • Source/WebCore/html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::defaultEventHandler):

  • Source/WebCore/html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setSelectionRange):

  • Source/WebCore/html/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

  • Source/WebCore/html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseTimeFragment):

  • Source/WebCore/html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::handleKeyupEvent):

  • Source/WebCore/html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

  • Source/WebCore/html/SearchInputType.cpp:

(WebCore::SearchInputType::handleKeydownEvent):

  • Source/WebCore/html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton):
(WebCore::TextFieldInputType::shouldSubmitImplicitly):

  • Source/WebCore/html/canvas/CanvasPattern.cpp:

(WebCore::CanvasPattern::parseRepetitionType):

  • Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::setLineCap):
(WebCore::CanvasRenderingContext2DBase::setLineJoin):

  • Source/WebCore/html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype):

  • Source/WebCore/html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):

  • Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp:

(WebCore::InspectorAuditAccessibilityObject::getComputedProperties):

  • Source/WebCore/inspector/InspectorCanvas.cpp:

(WebCore::shouldSnapshotBitmapRendererAction):
(WebCore::shouldSnapshotWebGLAction):
(WebCore::shouldSnapshotWebGL2Action):

  • Source/WebCore/inspector/InspectorFrontendHost.cpp:

(WebCore::dockSideFromString):
(WebCore::populateContextMenu):

  • Source/WebCore/inspector/InspectorStyleSheet.cpp:

(WebCore::buildArrayForGroupings):
(WebCore::InspectorStyle::shorthandValue const):

  • Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

  • Source/WebCore/loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestMethodAllowlist):
(WebCore::passesAccessControlCheck):

  • Source/WebCore/loader/DocumentLoader.cpp:

(WebCore::isRedirectToGetAfterPost):
(WebCore::DocumentLoader::isPostOrRedirectAfterPost):
(WebCore::DocumentLoader::responseReceived):

  • Source/WebCore/loader/FormSubmission.cpp:

(WebCore::FormSubmission::Attributes::updateEncodingType):

  • Source/WebCore/loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::addHTTPOriginIfNeeded):
(WebCore::createWindow):

  • Source/WebCore/loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::isMixedContent):

  • Source/WebCore/loader/PrivateClickMeasurement.cpp:

(WebCore::PrivateClickMeasurement::parseAttributionRequestQuery):

  • Source/WebCore/loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::loadDataURL):

  • Source/WebCore/loader/SubframeLoader.cpp:

(WebCore::FrameLoader::SubframeLoader::requestFrame):

  • Source/WebCore/loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::parseArchiveWithHeader):

  • Source/WebCore/loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::add):

  • Source/WebCore/loader/mac/LoaderNSURLExtras.mm:

(suggestedFilenameWithMIMEType):

  • Source/WebCore/mathml/MathMLElement.cpp:

(WebCore::convertMathSizeIfNeeded):

  • Source/WebCore/mathml/MathMLOperatorElement.cpp:

(WebCore::MathMLOperatorElement::computeDictionaryProperty):

  • Source/WebCore/mathml/MathMLPresentationElement.cpp:

(WebCore::MathMLPresentationElement::parseMathVariantAttribute):

  • Source/WebCore/mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::isMathMLEncoding):
(WebCore::MathMLSelectElement::isSVGEncoding):
(WebCore::MathMLSelectElement::isHTMLEncoding):
(WebCore::MathMLSelectElement::getSelectedActionChild):
(WebCore::MathMLSelectElement::defaultEventHandler):
(WebCore::MathMLSelectElement::willRespondToMouseClickEventsWithEditability const):

  • Source/WebCore/page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

  • Source/WebCore/page/EventHandler.cpp:

(WebCore::convertDropZoneOperationToDragOperation):
(WebCore::EventHandler::accessibilityPreventsEventPropagation):
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::isKeyboardOptionTab):

  • Source/WebCore/page/Performance.cpp:

(WebCore::Performance::getEntriesByType const):
(WebCore::Performance::getEntriesByName const):
(WebCore::Performance::appendBufferedEntriesByType const):

  • Source/WebCore/page/PerformanceEntry.cpp:

(WebCore::PerformanceEntry::parseEntryTypeString):

  • Source/WebCore/page/Quirks.cpp:

(WebCore::isTwitterDocument):
(WebCore::isYouTubeDocument):
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
(WebCore::Quirks::shouldDispatchedSimulatedMouseEventsAssumeDefaultPrevented const):
(WebCore::Quirks::shouldMakeTouchEventNonCancelableForTarget const):
(WebCore::Quirks::shouldEnableLegacyGetUserMediaQuirk const):
(WebCore::Quirks::shouldDisableElementFullscreenQuirk const):
(WebCore::Quirks::needsCanPlayAfterSeekedQuirk const):
(WebCore::Quirks::shouldAllowNavigationToCustomProtocolWithoutUserGesture):

  • Source/WebCore/page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canDisplay const):
(WebCore::SecurityOrigin::toString const):
(WebCore::areOriginsMatching):

  • Source/WebCore/page/SecurityOrigin.h:

(WebCore::SecurityOrigin::isHTTPFamily const):

  • Source/WebCore/page/SecurityOriginData.cpp:

(WebCore::SecurityOriginData::toString const):

  • Source/WebCore/page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::referrerToOriginString):

  • Source/WebCore/page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::matches const):

  • Source/WebCore/page/WindowFeatures.cpp:

(WebCore::boolFeature):

  • Source/WebCore/page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::ResourceUsageThread::platformCollectCPUData):

  • Source/WebCore/page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation const):

  • Source/WebCore/page/csp/ContentSecurityPolicySource.cpp:

(WebCore::ContentSecurityPolicySource::schemeMatches const):

  • Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp:

(WebCore::ResourceUsageThread::platformCollectCPUData):

  • Source/WebCore/platform/KeyboardScrollingAnimator.cpp:

(WebCore::keyboardScrollingKeyFromEvent):

  • Source/WebCore/platform/KeypressCommand.h:

(WebCore::KeypressCommand::KeypressCommand):

  • Source/WebCore/platform/LocalizedStrings.cpp:

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

  • Source/WebCore/platform/Pasteboard.cpp:

(WebCore::Pasteboard::isSafeTypeForDOMToReadAndWrite):

  • Source/WebCore/platform/RegistrableDomain.h:

(WebCore::RegistrableDomain::operator== const):

  • Source/WebCore/platform/Theme.cpp:

(WebCore::Theme::drawNamedImage const):

  • Source/WebCore/platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresChromeBrowser):
(WebCore::urlRequiresFirefoxBrowser):
(WebCore::urlRequiresMacintoshPlatform):
(WebCore::urlRequiresUnbrandedUserAgent):

  • Source/WebCore/platform/cocoa/ThemeCocoa.mm:

(WebCore::ThemeCocoa::drawNamedImage const):

  • Source/WebCore/platform/graphics/GLContext.cpp:

(WebCore::GLContext::version):

  • Source/WebCore/platform/graphics/Image.cpp:

(WebCore::Image::create):

  • Source/WebCore/platform/graphics/MIMETypeCache.cpp:

(WebCore::MIMETypeCache::shouldOverrideExtendedType):

  • Source/WebCore/platform/graphics/VP9Utilities.cpp:

(WebCore::parseVPCodecParameters):

  • Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::CDMPrivateMediaSourceAVFObjC::supportsMIMEType):

  • Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::shouldWaitForLoadingOfResource):

  • Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):

  • Source/WebCore/platform/graphics/cairo/ImageBufferUtilitiesCairo.cpp:

(WebCore::encodeImage):

  • Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoderCG::frameHasAlphaAtIndex const):
(WebCore::ImageDecoderCG::createFrameImageAtIndex):

  • Source/WebCore/platform/graphics/cg/ImageSourceCGWin.cpp:

(WebCore::MIMETypeForImageType):

  • Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm:

(WebCore::isVPCodecConfigurationRecordSupported):
(WebCore::createVideoInfoFromVPCodecConfigurationRecord):

  • Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::getFamilyNameStringFromFamily):

  • Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::isMediaDiskCacheDisabled):

  • Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::platformMaximumBufferSize const):

  • Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGL.cpp:

(WebCore::ExtensionsGLOpenGL::platformSupportsExtension):

  • Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:

(WebCore::ExtensionsGLOpenGLCommon::supports):
(WebCore::ExtensionsGLOpenGLCommon::ensureEnabled):
(WebCore::ExtensionsGLOpenGLCommon::isEnabled):

  • Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLES.cpp:

(WebCore::ExtensionsGLOpenGLES::isEnabled):
(WebCore::ExtensionsGLOpenGLES::platformSupportsExtension):

  • Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::checkVaryingsPacking const):

  • Source/WebCore/platform/gtk/PasteboardGtk.cpp:

(WebCore::selectionDataTypeFromHTMLClipboardType):

  • Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):

  • Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::platformPasteboardTypeForSafeTypeForDOMToReadAndWrite):

  • Source/WebCore/platform/ios/PreviewConverterIOS.mm:

(WebCore::PreviewConverter::isPlatformPasswordError const):

  • Source/WebCore/platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):

  • Source/WebCore/platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::platformPasteboardTypeForSafeTypeForDOMToReadAndWrite):

  • Source/WebCore/platform/mac/PublicSuffixMac.mm:

(WebCore::topPrivatelyControlledDomain):

  • Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.cpp:

(WebCore::RealtimeMediaSourceSettings::videoFacingModeEnum):

  • Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerH264Encoder::GStreamerH264Encoder):

  • Source/WebCore/platform/mock/MediaEngineConfigurationFactoryMock.cpp:

(WebCore::canDecodeMedia):
(WebCore::canSmoothlyDecodeMedia):
(WebCore::canPowerEfficientlyDecodeMedia):
(WebCore::canEncodeMedia):
(WebCore::canSmoothlyEncodeMedia):
(WebCore::canPowerEfficientlyEncodeMedia):

  • Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::supportsType):

  • Source/WebCore/platform/network/CacheValidation.cpp:

(WebCore::verifyVaryingRequestHeadersInternal):

  • Source/WebCore/platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::isMultipart const):

  • Source/WebCore/platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::cfStreamError const):

  • Source/WebCore/platform/network/curl/CookieJarDB.cpp:

(WebCore::CookieJarDB::checkDatabaseValidity):

  • Source/WebCore/platform/network/curl/CookieJarDB.h:

(WebCore::CookieJarDB::isOnMemory const):

  • Source/WebCore/platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::shouldRedirectAsGET):

  • Source/WebCore/platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::setupTransfer):

  • Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp:

(WebCore::topPrivatelyControlledDomain):

  • Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::shouldRedirectAsGET):

  • Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:

(WebCore::shouldUseQuickLookForMIMEType):

  • Source/WebCore/platform/soup/PublicSuffixSoup.cpp:

(WebCore::topPrivatelyControlledDomain):

  • Source/WebCore/platform/win/SearchPopupMenuDB.cpp:

(WebCore::SearchPopupMenuDB::checkDatabaseValidity):

  • Source/WebCore/rendering/RenderBlockFlow.cpp:

(WebCore::needsAppleMailPaginationQuirk):

  • Source/WebCore/rendering/RenderCounter.cpp:

(WebCore::planCounter):

  • Source/WebCore/rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::getAverageCharWidth):

  • Source/WebCore/rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::getAverageCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentLogicalWidth const):

  • Source/WebCore/rendering/RenderTreeAsText.cpp:

(WebCore::isEmptyOrUnstyledAppleStyleSpan):

  • Source/WebCore/svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

  • Source/WebCore/svg/SVGComponentTransferFunctionElement.h:

(WebCore::SVGPropertyTraits<ComponentTransferType>::fromString):

  • Source/WebCore/svg/SVGFEColorMatrixElement.h:

(WebCore::SVGPropertyTraits<ColorMatrixType>::fromString):

  • Source/WebCore/svg/SVGFECompositeElement.h:

(WebCore::SVGPropertyTraits<CompositeOperationType>::fromString):

  • Source/WebCore/svg/SVGFEConvolveMatrixElement.h:

(WebCore::SVGPropertyTraits<EdgeModeType>::fromString):

  • Source/WebCore/svg/SVGFEDisplacementMapElement.h:

(WebCore::SVGPropertyTraits<ChannelSelectorType>::fromString):

  • Source/WebCore/svg/SVGFEMorphologyElement.h:

(WebCore::SVGPropertyTraits<MorphologyOperatorType>::fromString):

  • Source/WebCore/svg/SVGFETurbulenceElement.h:

(WebCore::SVGPropertyTraits<SVGStitchOptions>::fromString):
(WebCore::SVGPropertyTraits<TurbulenceType>::fromString):

  • Source/WebCore/svg/SVGGradientElement.h:

(WebCore::SVGPropertyTraits<SVGSpreadMethodType>::fromString):

  • Source/WebCore/svg/SVGMarkerTypes.h:

(WebCore::SVGPropertyTraits<SVGMarkerUnitsType>::fromString):

  • Source/WebCore/svg/SVGTests.cpp:

(WebCore::SVGTests::hasFeatureForLegacyBindings):

  • Source/WebCore/svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::collectPresentationalHintsForAttribute):

  • Source/WebCore/svg/SVGTextContentElement.h:

(WebCore::SVGPropertyTraits<SVGLengthAdjustType>::fromString):

  • Source/WebCore/svg/SVGTextPathElement.h:

(WebCore::SVGPropertyTraits<SVGTextPathMethodType>::fromString):
(WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::fromString):

  • Source/WebCore/svg/SVGUnitTypes.h:

(WebCore::SVGPropertyTraits<SVGUnitTypes::SVGUnitType>::fromString):

  • Source/WebCore/svg/SVGZoomAndPanType.h:

(WebCore::SVGPropertyTraits<SVGZoomAndPanType>::fromString):

  • Source/WebCore/svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):

  • Source/WebCore/svg/properties/SVGPropertyTraits.h:

(WebCore::SVGPropertyTraits<bool>::fromString):

  • Source/WebCore/testing/Internals.cpp:

(WebCore::Internals::pseudoElement):
(WebCore::Internals::setViewBaseBackgroundColor):
(WebCore::Internals::setPagination):
(WebCore::parseFindOptions):
(WebCore::Internals::countMatchesForText):
(WebCore::Internals::setOverridePreferredDynamicRangeMode):
(WebCore::taskSourceFromString):
(WebCore::Internals::hasSandboxMachLookupAccessToGlobalName):
(WebCore::Internals::hasSandboxMachLookupAccessToXPCServiceName):

  • Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::createConnection):

  • Source/WebCore/workers/WorkerFontLoadRequest.cpp:

(WebCore::WorkerFontLoadRequest::load):

  • Source/WebCore/workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadAsynchronously):

  • Source/WebCore/workers/service/server/RegistrationDatabase.cpp:

(WebCore::stringToUpdateViaCache):
(WebCore::stringToWorkerType):

  • Source/WebCore/xml/DOMParser.cpp:

(WebCore::DOMParser::parseFromString):

  • Source/WebCore/xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::sendBytesData):
(WebCore::XMLHttpRequest::createRequest):

  • Source/WebCore/xml/XPathFunctions.cpp:

(WebCore::XPath::Function::setArguments):

  • Source/WebCore/xml/XPathParser.cpp:

(WebCore::XPath::Parser::nextTokenInternal):

  • Source/WebCore/xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

  • Source/WebCore/xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::transformToString):

  • Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::shouldAllowExternalLoad):
(WebCore::XMLDocumentParser::supportsXMLVersion):
(WebCore::externalSubsetHandler):

  • Source/WebDriver/CommandResult.cpp:

(WebDriver::CommandResult::CommandResult):

  • Source/WebDriver/Session.cpp:

(WebDriver::Session::newWindow):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::elementClick):

  • Source/WebDriver/WebDriverService.cpp:

(WebDriver::deserializeTimeouts):
(WebDriver::deserializeProxy):
(WebDriver::deserializePageLoadStrategy):
(WebDriver::deserializeUnhandledPromptBehavior):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::matchCapabilities const):
(WebDriver::WebDriverService::newWindow):
(WebDriver::isValidStrategy):
(WebDriver::findStrategyAndSelectorOrCompleteWithError):
(WebDriver::processNullAction):
(WebDriver::processKeyAction):
(WebDriver::processPointerMoveAction):
(WebDriver::processPointerAction):
(WebDriver::processWheelAction):
(WebDriver::processPointerParameters):
(WebDriver::processInputActionSequence):

  • Source/WebDriver/glib/WebDriverServiceGLib.cpp:

(WebDriver::WebDriverService::platformSupportProxyType const):

  • Source/WebDriver/gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):

  • Source/WebDriver/socket/HTTPParser.cpp:

(WebDriver::HTTPParser::expectedBodyLength const):

  • Source/WebDriver/socket/SessionHostSocket.cpp:

(WebDriver::SessionHost::parseTargetList):

  • Source/WebDriver/soup/HTTPServerSoup.cpp:

(WebDriver::soupServerListen):

  • Source/WebDriver/wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):

  • Source/WebGPU/WGSLUnitTests/WGSLParserTests.mm:

(-[WGSLParserTests testParsingStruct]):
(-[WGSLParserTests testParsingGlobalVariable]):
(-[WGSLParserTests testParsingFunctionDecl]):
(-[WGSLParserTests testTrivialGraphicsShader]):

  • Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:

(WebKit::ResourceLoadStatisticsStore::shouldSkip const):

  • Source/WebKit/NetworkProcess/DatabaseUtilities.cpp:

(WebKit::insertDistinctValuesInTableStatement):

  • Source/WebKit/NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::allowsPrivateClickMeasurementTestFunctionality const):

  • Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::isCrossOriginPrefetch const):

  • Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:

(WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask):

  • Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::getDirectorySize):

  • Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::queryCache):
(WebKit::CacheStorage::Cache::retrieveRecords):

  • Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeRetrieveDecision):
(WebKit::NetworkCache::makeStoreDecision):

  • Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::Entry):

  • Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::SpeculativeLoadManager::shouldRegisterLoad):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveSubresourcesEntry):

  • Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:

(WebKit::NetworkCache::SubresourcesEntry::SubresourcesEntry):

  • Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::isActingOnBehalfOfAFullWebBrowser):

  • Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::shouldRedirectAsGET):

  • Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm:

(WebKit::NetworkProcess::parentProcessHasServiceWorkerEntitlement const):

  • Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp:

(WebKit::isValidFileName):

  • Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:

(WebKit::OriginStorageManager::StorageBucket::isEmpty):

  • Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb:
  • Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb:
  • Source/WebKit/Shared/AuxiliaryProcess.h:
  • Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:

(WebKit::AuxiliaryProcess::parentProcessHasEntitlement):
(WebKit::AuxiliaryProcess::setPreferenceValue):

  • Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:

(WebKit::appBoundDomainsForTesting):
(WebKit::isParentProcessAFullWebBrowser):
(WebKit::isFullWebBrowser):

  • Source/WebKit/Shared/Cocoa/XPCEndpoint.mm:

(WebKit::XPCEndpoint::XPCEndpoint):

  • Source/WebKit/Shared/Cocoa/XPCEndpointClient.mm:

(WebKit::XPCEndpointClient::setEndpoint):

  • Source/WebKit/Shared/Daemon/DaemonUtilities.h:
  • Source/WebKit/Shared/Daemon/DaemonUtilities.mm:

(WebKit::startListeningForMachServiceConnections):

  • Source/WebKit/Shared/Databases/IndexedDB/IDBUtilities.cpp:

(WebKit::uniqueDatabaseIdentifier):

  • Source/WebKit/Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonEntryPoint.mm:

(WebKit::PCMDaemonMain):

  • Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
  • Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::checkEntitlements):
(WebKit::XPCServiceInitializerDelegate::hasEntitlement):

  • Source/WebKit/Shared/IPCTester.cpp:

(WebKit::messageTestDriver):

  • Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultMediaSessionCoordinatorEnabled):

  • Source/WebKit/Shared/glib/InputMethodState.cpp:

(WebKit::inputElementHasDigitsPattern):

  • Source/WebKit/Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebKeyboardEvent):

  • Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::tryApplyCachedSandbox):
(WebKit::AuxiliaryProcess::initializeSandbox):

  • Source/WebKit/UIProcess/API/C/WKMockMediaDevice.cpp:

(WKAddMockMediaDevice):

  • Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setupPageConfiguration:]):

  • Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:

(-[WKWebpagePreferences _setCaptivePortalModeEnabled:]):

  • Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferences.mm:

(+[_WKSystemPreferences isCaptivePortalModeEnabled]):
(+[_WKSystemPreferences setCaptivePortalModeEnabled:]):

  • Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferencesInternal.h:
  • Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp:

(parseProxyCapabilities):

  • Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:

(addOriginToMap):

  • Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp:

(WebKit::DropTarget::accept):

  • Source/WebKit/UIProcess/ApplicationStateTracker.mm:

(WebKit::applicationType):

  • Source/WebKit/UIProcess/Cocoa/MediaPermissionUtilities.mm:

(WebKit::applicationVisibleNameFromOrigin):

  • Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::collectKeyboardLayoutCommandsForEvent):

  • Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::DownloadProxyMap):

  • Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorClient.cpp:

(WebKit::debuggableType):

  • Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • Source/WebKit/UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::isDisplayingMarkupDocument const):

  • Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestAttachmentIcon):

  • Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::networkProcessHasEntitlementForTesting):

  • Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp:

(WebKit::WebsiteDataRecord::displayNameForCookieHostName):
(WebKit::WebsiteDataRecord::displayNameForOrigin):

  • Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:

(WebKit::isEGLImageAvailable):

  • Source/WebKit/UIProcess/gtk/Clipboard.cpp:

(WebKit::Clipboard::get):

  • Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:

(WebKit::WebDataListSuggestionsDropdownGtk::handleKeydownWithIdentifier):

  • Source/WebKit/UIProcess/gtk/WebDateTimePickerGtk.cpp:

(WebKit::WebDateTimePickerGtk::update):

  • Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:

(applicationHasAppLinkEntitlements):

  • Source/WebKit/UIProcess/ios/WKPDFView.mm:

(+[WKPDFView web_requiresCustomSnapshotting]):

  • Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):

  • Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:

(WebKit::WebDataListSuggestionsDropdownMac::handleKeydownWithIdentifier):
(-[WKDataListSuggestionsController moveSelectionByDirection:]):

  • Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::evaluateJavaScriptCallback):

  • Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:

(webkitWebPageDidReceiveMessage):

  • Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:

(WebKit::PDFPluginPasswordField::handleEvent):

  • Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::handleEvent):

  • Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::getActionTypeForKeyEvent):

  • Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

(WebKit::TextCheckingControllerProxy::removeAnnotationRelativeToSelection):

  • Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:

(WebKit::IPCTestingAPI::encodeArgument):

  • Source/WebKit/WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::setTextDirection):

  • Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::parentProcessHasServiceWorkerEntitlement const):
(WebKit::WebPage::focusedElementInformation):
(WebKit::WebPage::platformUserAgent const):

  • Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::executeKeypressCommandsInternal):
(WebKit::WebPage::handleEditingKeyboardEvent):
(WebKit::WebPage::performNonEditingBehaviorForSelector):

  • Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeProcess):
(WebKit::WebProcess::handlePreferenceChange):

  • Source/WebKit/webpushd/PushClientConnection.h:
  • Source/WebKit/webpushd/PushClientConnection.mm:

(WebPushD::ClientConnection::hostHasEntitlement):

  • Source/WebKitLegacy/cf/WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::inspectorAttachDisabled):
(WebInspectorClient::inspectorStartsAttached):

  • Source/WebKitLegacy/mac/Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage isQuickTimePlugIn]):

  • Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm:

(selectorForKeyEvent):

  • Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::transitionToCommittedForNewPage):

  • Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:

(-[WebHTMLView _executeSavedKeypressCommands]):

  • Source/WebKitLegacy/win/WebFrame.cpp:

(WebFrame::setTextDirection):
(WebFrame::canProvideDocumentSource):

  • Tools/DumpRenderTree/win/DumpRenderTree.cpp:

(runTest):

  • Tools/TestWebKitAPI/Tests/WTF/AtomString.cpp:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WTF/JSONValue.cpp:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.cpp:

(TEST):

  • Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.mm:

(TEST):

  • Tools/TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WebCore/FontShadowTests.cpp:

(TestWebKitAPI::TEST_F):

  • Tools/TestWebKitAPI/Tests/WebCore/LineBreaking.mm:

(breakingLocationsFromICU):

  • Tools/TestWebKitAPI/Tests/WebCore/NowPlayingInfoTests.cpp:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:

(TestWebKitAPI::TEST_F):

  • Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:

(TestWebKitAPI::TEST_F):

  • Tools/TestWebKitAPI/Tests/WebCore/StringWithDirection.cpp:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WebKit/MediaSessionCoordinatorTest.mm:

(TestWebKitAPI::TEST_F):

  • Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:

(TEST_F):

  • Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:

(TEST):

  • Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:

(TestWebKitAPI::TEST):

  • Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(TEST):

  • Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

(-[SyncScheme webView:startURLSchemeTask:]):

  • Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::dumpErrorDescriptionSuitableForTestResult):

  • Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:

(WTR::attributesOfElement):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::isPressActionSupported):

  • Tools/WebKitTestRunner/TestController.cpp:

(WTR::TestController::setPluginSupportedMode):

  • Tools/WebKitTestRunner/cocoa/CrashReporterInfo.mm:

(WTR::testPathFromURL):

  • Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:

(WTR::UIScriptControllerCocoa::overridePreference):

  • Tools/WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:

(WTR::UIScriptControllerGtk::overridePreference):

Canonical link: https://commits.webkit.org/251316@main

8:30 PM Changeset in webkit [295269] by timothy_horton@apple.com
  • 10 edits
    1 copy in trunk

Force Repaint menu item does not repaint compositing layers, only tiles
https://bugs.webkit.org/show_bug.cgi?id=241292

Reviewed by Simon Fraser.

  • Source/WebCore/page/Page.h:
  • Source/WebCore/page/Page.cpp:

(WebCore::Page::forceRepaintAllFrames):
Move forceRepaint to Page, and use repaintViewAndCompositedLayers instead of
TiledBacking::forceRepaint, so we hit all the compositing layers, not just the tiles.

  • Source/WebCore/platform/graphics/TiledBacking.h:
  • Source/WebCore/platform/graphics/ca/TileController.cpp:

(WebCore::TileController::forceRepaint): Deleted.

  • Source/WebCore/platform/graphics/ca/TileController.h:
  • Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp:

Get rid of this unused method.

  • Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::forceRepaint):

  • Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::forceRepaint):
Adopt forceRepaintAllFrames.

  • LayoutTests/fast/images/async-image-multiple-clients-repaint-expected.txt:
  • LayoutTests/platform/ios/fast/images/async-image-multiple-clients-repaint-expected.txt
  • LayoutTests/platform/win/fast/images/async-image-multiple-clients-repaint-expected.txt

Rebaseline this test, except on Windows.

Canonical link: https://commits.webkit.org/251315@main

1:59 PM Changeset in webkit [295268] by Chris Dumez
  • 11 edits in trunk/Source

Tweak HTMLToken / AtomHTMLToken data members for better packing
https://bugs.webkit.org/show_bug.cgi?id=241293

Reviewed by Darin Adler.

Tweak HTMLToken / AtomHTMLToken data members for better packing. Also use
Span<> more.

  • Source/WTF/wtf/text/StringView.h:
  • Source/WTF/wtf/text/WTFString.h:
  • Source/WebCore/html/parser/AtomHTMLToken.h:

(WebCore::AtomHTMLToken::hasDuplicateAttribute const):
(WebCore::AtomHTMLToken::name const):
(WebCore::AtomHTMLToken::setName):
(WebCore::AtomHTMLToken::selfClosing const):
(WebCore::AtomHTMLToken::attributes):
(WebCore::AtomHTMLToken::attributes const):
(WebCore::AtomHTMLToken::characters const):
(WebCore::AtomHTMLToken::charactersIsAll8BitData const):
(WebCore::AtomHTMLToken::comment const):
(WebCore::AtomHTMLToken::comment):
(WebCore::AtomHTMLToken::forceQuirks const):
(WebCore::AtomHTMLToken::publicIdentifier const):
(WebCore::AtomHTMLToken::initializeAttributes):
(WebCore::AtomHTMLToken::AtomHTMLToken):
(WebCore::AtomHTMLToken::charactersLength const): Deleted.

  • Source/WebCore/html/parser/HTMLConstructionSite.cpp:

(WebCore::setAttributes):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElementFromSavedToken):

  • Source/WebCore/html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):

  • Source/WebCore/html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):

  • Source/WebCore/html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):

  • Source/WebCore/html/parser/HTMLToken.h:

(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::makeEndOfFile):
(WebCore::HTMLToken::name const):
(WebCore::HTMLToken::appendToName):
(WebCore::HTMLToken::setForceQuirks):
(WebCore::HTMLToken::beginDOCTYPE):
(WebCore::HTMLToken::setPublicIdentifierToEmptyString):
(WebCore::HTMLToken::setSystemIdentifierToEmptyString):
(WebCore::HTMLToken::appendToPublicIdentifier):
(WebCore::HTMLToken::appendToSystemIdentifier):
(WebCore::HTMLToken::selfClosing const):
(WebCore::HTMLToken::setSelfClosing):
(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
(WebCore::HTMLToken::beginAttribute):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::attributes const):
(WebCore::HTMLToken::characters const):
(WebCore::HTMLToken::charactersIsAll8BitData const):
(WebCore::HTMLToken::appendToCharacter):
(WebCore::HTMLToken::comment const):
(WebCore::HTMLToken::commentIsAll8BitData const):
(WebCore::HTMLToken::beginComment):
(WebCore::HTMLToken::appendToComment):
(WebCore::HTMLToken::HTMLToken): Deleted.

  • Source/WebCore/html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::saveEndTagNameIfNeeded):
(WebCore::HTMLTokenizer::haveBufferedCharacterToken const):

  • Source/WebCore/html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndOfFileForInTemplateContents):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::insertPhoneNumberLink):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

  • Source/WebCore/html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

Canonical link: https://commits.webkit.org/251314@main

11:32 AM Changeset in webkit [295267] by Ryan Haddad
  • 2 edits in trunk/Tools/CISupport/build-webkit-org

Temporarily disable lldb-webkit-test on Monterey
https://bugs.webkit.org/show_bug.cgi?id=241294

Reviewed by Aakash Jain.

Temporarily disable lldb-webkit-test on Monterey until webkit.org/b/239463
can be resolved or worked around.

  • Tools/CISupport/build-webkit-org/factories.py:

(TestFactory.init):

  • Tools/CISupport/build-webkit-org/factories_unittest.py:

(TestExpectedBuildSteps):

Canonical link: https://commits.webkit.org/251313@main

7:26 AM Changeset in webkit [295266] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Add basic 'flex-wrap: wrap' support
https://bugs.webkit.org/show_bug.cgi?id=241300

Reviewed by Antti Koivisto.

  1. compute wrap positions by simply checking for overflow as walking the flex item list.
  2. let each function operate on the range instead of the entire list.
  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeWrappingPositions const):
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexLayout::alignFlexItems):
(WebCore::Layout::FlexLayout::justifyFlexItems):
(WebCore::Layout::FlexLayout::layout):

  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

Canonical link: https://commits.webkit.org/251312@main

7:01 AM Changeset in webkit [295265] by ntim@apple.com
  • 5 edits
    3 adds
    1 delete in trunk

[IFC] Support text-align-last: justify
https://bugs.webkit.org/show_bug.cgi?id=241301
<rdar://94384891>

Reviewed by Alan Bujtas.

text-align: justify already worked for the legacy line layout, but not in IFC. Add support for it and a corresponding WPT.

Also removed text-justify: none handling from legacy line layout, since IFC doesn't handle it, and legacy line layout also doesn't handle it correctly either. Thankfully text-justify is disabled by default.

  • LayoutTests/TestExpectations:
  • LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify-expected.html: Removed.
  • LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html: Removed.

Removed tests that were wrong, compared with other browsers to verify.

  • LayoutTests/imported/w3c/resources/resource-files.json:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-expected.html: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-ref.html: Added.
  • LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last.html: Added.

WPT is from Blink: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/fast/css3-text/css3-text-align-last/text-align-last.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63

Upstream WPT PR: https://github.com/web-platform-tests/wpt/pull/34308

  • Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::applyRunExpansion):

  • Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):

  • Source/WebCore/rendering/LegacyLineLayout.cpp:

(WebCore::LegacyLineLayout::textAlignmentForLine const):

Canonical link: https://commits.webkit.org/251311@main

6:23 AM Changeset in webkit [295264] by Antti Koivisto
  • 3 edits in trunk

Update query container layout unconditionally when ancestor style changes
https://bugs.webkit.org/show_bug.cgi?id=241302

Reviewed by Alan Bujtas.

In some cases we incorrectly optimize away the layout.

  • LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/display-none-expected.txt:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-004-expected.txt:
  • Source/WebCore/style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

Do the query container update even when shouldIterateChildren is false. While there is no reason to iterate children
now there may be after the query container layout has been updated.

Canonical link: https://commits.webkit.org/251310@main

5:48 AM Changeset in webkit [295263] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Introduce LineRange to be able to layout just a subset
https://bugs.webkit.org/show_bug.cgi?id=241299

Reviewed by Antti Koivisto.

This is in preparation for supporting flex-wrap: wrap.
LineRange keeps track of the flex items associated with the current line. In case of no-wrap, the range is [0, number of flex items].

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace): This is already coming in as logical.

  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeAvailableLogicalVerticalSpace const):
(WebCore::Layout::FlexLayout::computeAvailableLogicalHorizontalSpace const):
(WebCore::Layout::FlexLayout::computeWrappingPositions const):
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexLayout::alignFlexItems):
(WebCore::Layout::FlexLayout::justifyFlexItems):
(WebCore::Layout::FlexLayout::layout):

  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

Canonical link: https://commits.webkit.org/251309@main

5:45 AM Changeset in webkit [295262] by Darin Adler
  • 9 edits in trunk/Source/WebCore/html/parser

Try moving HTMLStackItem in the HTML parser instead of using reference counting
https://bugs.webkit.org/show_bug.cgi?id=240700

Reviewed by Chris Dumez.

A/B testing indicates that this is performance neutral on Speedometer
on an Apple Silicon Mac, and a 0.23% speedup on an Intel Mac. On that basis,
this simplfication seems worth doing.

  • Source/WebCore/html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): Use constructor
instead of create function.
(WebCore::HTMLConstructionSite::insertHTMLHeadElement): Ditto.
(WebCore::HTMLConstructionSite::insertHTMLBodyElement): Ditto.
(WebCore::HTMLConstructionSite::insertHTMLFormElement): Ditto.
(WebCore::HTMLConstructionSite::insertHTMLElement): Ditto.
(WebCore::HTMLConstructionSite::insertHTMLElementOrFindCustomElementInterface): Ditto.
(WebCore::HTMLConstructionSite::insertCustomElement): Ditto.
(WebCore::HTMLConstructionSite::insertFormattingElement): Ditto.
(WebCore::HTMLConstructionSite::insertScriptElement): Ditto.
(WebCore::HTMLConstructionSite::insertForeignElement): Ditto.
(WebCore::HTMLConstructionSite::insertAlreadyParsedChild): Ditto.
(WebCore::HTMLConstructionSite::takeAllChildrenAndReparent): Ditto.
(WebCore::HTMLConstructionSite::createElementFromSavedToken): Ditto.
(WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements): Ditto.

  • Source/WebCore/html/parser/HTMLConstructionSite.h: Changed return value

to be HTMLStackItem instead of Ref<HTMLStackItem> and changed headStackItem
to return HTMLStackItem&. Since HTMLStackItem now has a null value it does
not need to be a pointer.

  • Source/WebCore/html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::ElementRecord::ElementRecord): Take an HTMLStackItem&&
instead of a Ref<HTMLStackItem>&&.
(WebCore::HTMLElementStack::ElementRecord::replaceElement): Ditto.
(WebCore::HTMLElementStack::pushRootNode): Ditto.
(WebCore::HTMLElementStack::pushHTMLHtmlElement): Ditto.
(WebCore::HTMLElementStack::pushRootNodeCommon): Ditto.
(WebCore::HTMLElementStack::pushHTMLHeadElement): Ditto.
(WebCore::HTMLElementStack::pushHTMLBodyElement): Ditto.
(WebCore::HTMLElementStack::push): Ditto.
(WebCore::HTMLElementStack::insertAbove): Ditto.
(WebCore::HTMLElementStack::pushCommon): Ditto.

  • Source/WebCore/html/parser/HTMLElementStack.h: Updated for the above changes,

and changed the ElementRecord class to use HTMLStackItem. Maybe eventually we
could figure out how to optimize further by using a data structure other than
a singly linked list, to avoid having to allocate a memory block each time we
create one of these. Or at least find a way to recycle as we push and pop.

  • Source/WebCore/html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::closestElementInScopeWithName): Update
to use the reference instead of pointer.
(WebCore::HTMLFormattingElementList::swapTo): Take an HTMLStackItem&&
instead of a Ref<HTMLStackItem>&&. Also added a missing WTFMove in one case.
(WebCore::HTMLFormattingElementList::append): Ditto.
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
Changed to use a return value instead of an out argument.
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition): Updated
for the above and tweaked formatting a bit.

  • Source/WebCore/html/parser/HTMLFormattingElementList.h: Changed Entry

to store a HTMLStackItem instead of a RefPtr<HTMLStackItem>. Also
updated for the above.

  • Source/WebCore/html/parser/HTMLStackItem.h: Changed HTMLStackItem to

no longer derive from RefCounted. Got rid of the create functions and
replaced them with use of the constructor. Added a default constructor
and a null value. Added an elementOrNull function that is handy for Entry.
Removed the slightly peculiar double-const-ness of this class. We can
probably use const HTMLStackItem more; every member function is const.

  • Source/WebCore/html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Use HTMLStackItem constructor
instead of the create function.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): Ditto.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement): Removed const.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElementStackItem): Ditto.
(WebCore::HTMLTreeBuilder::processStartTag): Updated since headStackItem is a reference.
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency): Ditto.
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): Ditto.
(WebCore::HTMLTreeBuilder::adjustedCurrentStackItem): Ditto.

  • Source/WebCore/html/parser/HTMLTreeBuilder.h: Updated for the above.

Canonical link: https://commits.webkit.org/251308@main

3:12 AM Changeset in webkit [295261] by jh718.park@samsung.com
  • 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp

Unreviewed. Fix the build warning below since r295039.

warning: variable ‘accumulatedWidth’ set but not used [-Wunused-but-set-variable]

  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):

1:30 AM Changeset in webkit [295260] by Nikos Mouchtaris
  • 1 edit in trunk/Source/WebCore/platform/graphics/filters/FilterImage.cpp

Add checks for overflow in FilterImage::copyImageBytes
https://bugs.webkit.org/show_bug.cgi?id=241296
<rdar://89744102>

Reviewed by Said Abou-Hallawa.

Add overflow checks to copyImageBytes functions in FilterImage class.

  • Source/WebCore/platform/graphics/filters/FilterImage.cpp:

(WebCore::copyImageBytes):

Canonical link: https://commits.webkit.org/251306@main

Jun 3, 2022:

7:17 PM Changeset in webkit [295259] by Elliott Williams
  • 1 edit in trunk/Source/WebKit/Configurations/BaseTarget.xcconfig

Fix WebKit's PROFILE_DATA_PATH in internal release builds
https://bugs.webkit.org/show_bug.cgi?id=241297

Reviewed by Wenson Hsieh.

WebKit's PROFILE_DATA_PATH_INTERNAL_YES was missing WebKitAdditions/
in its path name. Just a typo here, WebCore and JavaScriptCore have
correct paths.

  • Source/WebKit/Configurations/BaseTarget.xcconfig:

Canonical link: https://commits.webkit.org/251305@main

7:09 PM Changeset in webkit [295258] by ysuzuki@apple.com
  • 2 edits
    1 add in trunk

[WTF] Handle "at" in Date parse heuristics to make Date picker work in CNBC.com
https://bugs.webkit.org/show_bug.cgi?id=241258
rdar://93920424

Reviewed by Darin Adler.

AppleICU changes Intl.DateTimeFormat's formatting result to align it to Apple HI. But we
observed regression in CNBC.com since it reparses Intl.DateTimeFormat's string with Date
constructor.

Strictly speaking, there is no guarantee that code works. Date constructor's parsing
is implementation-dependent, and the spec does not require that Intl.DateTimeFormat's output
should be accepted by Date constructor. And this works only for English case anyway even before
this AppleICU change: if date is formatted via ja-JP, then Date constructor does not accept it.
But previously, this English case was working by chance, but now, new ICU format inserts "at"
in the string, and it makes that string unaccepted in Date constructor.

To workaround this web-compatibility issue, we extend our Date parsing heuristics to
accept "at". This is OK since the goal of this heuristics is accepting wider range of date
strings. Also it is OK that accepting English word "at" since this heuristics already handle
weekday and month names in English.

  • JSTests/complex.yaml:
  • JSTests/complex/intl-date-time-format-date-parse.js: Added.

(shouldBe):

  • Source/WTF/wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

Canonical link: https://commits.webkit.org/251304@main

6:10 PM Changeset in webkit [295257] by Alan Coon
  • 1 copy in tags/WebKit-7614.1.14.10.11

Tag WebKit-7614.1.14.10.11.

6:06 PM Changeset in webkit [295256] by Alan Coon
  • 9 edits in branches/safari-7614.1.14.10-branch/Source

Versioning.

WebKit-7614.1.14.10.11

5:30 PM Changeset in webkit [295255] by Devin Rousso
  • 27 edits in trunk/Source

Web Inspector: remove unused InspectorFrontendHost attributes and methods
https://bugs.webkit.org/show_bug.cgi?id=241291

Reviewed by Patrick Angle.

  • Source/WebCore/inspector/InspectorFrontendHost.idl:
  • Source/WebCore/inspector/InspectorFrontendHost.h:
  • Source/WebCore/inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::port const): Deleted.
(WebCore::InspectorFrontendHost::append): Deleted.
(WebCore::InspectorFrontendHost::close): Deleted.

  • Source/WebCore/inspector/InspectorFrontendClient.h:
  • Source/WebCore/inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::append): Deleted.

  • Source/WebKit/WebProcess/Inspector/WebInspectorUI.messages.in:
  • Source/WebKit/WebProcess/Inspector/WebInspectorUI.h:
  • Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::didSave): Deleted.
(WebKit::WebInspectorUI::append): Deleted.
(WebKit::WebInspectorUI::didAppend): Deleted.

  • Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in:
  • Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h:
  • Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp:

(WebKit::WebInspectorUIProxy::append): Deleted.
(WebKit::WebInspectorUIProxy::platformAppend): Deleted.

  • Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp:

(WebKit::fileReplaceContentsCallback):
(WebKit::WebInspectorUIProxy::platformAppend): Deleted.

  • Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:

(WebKit::WebInspectorUIProxy::platformSave):
(WebKit::WebInspectorUIProxy::platformAppend): Deleted.

  • Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp:

(WebKit::WebInspectorUIProxy::platformAppend): Deleted.

  • Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.messages.in:
  • Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h:
  • Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::didSave): Deleted.
(WebKit::RemoteWebInspectorUI::didAppend): Deleted.
(WebKit::RemoteWebInspectorUI::append): Deleted.

  • Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.messages.in:
  • Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.h:
  • Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp:

(WebKit::RemoteWebInspectorUIProxy::append): Deleted.
(WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted.

  • Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp:

(WebKit::remoteFileReplaceContentsCallback):
(WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted.

  • Source/WebKit/UIProcess/Inspector/mac/RemoteWebInspectorUIProxyMac.mm:

(WebKit::RemoteWebInspectorUIProxy::platformSave):
(WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted.

  • Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted.

  • Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h:
  • Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append): Deleted.

  • Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorFrontendClient::append): Deleted.

  • Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.savedURL): Deleted.
(InspectorFrontendAPI.appendedToURL): Deleted.

Canonical link: https://commits.webkit.org/251303@main

4:59 PM Changeset in webkit [295254] by sihui_liu@apple.com
  • 1 edit in trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm

Regression (r294405): missing tiles during scrolling after foregrounding app
https://bugs.webkit.org/show_bug.cgi?id=241280

Reviewed by Chris Dumez.

Partially revert r294405 to disable ProcessStateMonitor that can make UI process fail to take foreground assertion after
app is foregrounded.

  • Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):

Canonical link: https://commits.webkit.org/251302@main

4:55 PM Changeset in webkit [295253] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore/platform/graphics/avfoundation/objc

[Cocoa][MSE] Frames are displayed "fast forward" during seek operations
https://bugs.webkit.org/show_bug.cgi?id=241234
<rdar://89387951>

Reviewed by Eric Carlson.

When MSE was moved into the GPU process, certain operations that used to be synchronous became
async. This includes seek operations, where the seek request is initiated by the HTMLMediaElement,
async dispatched to the MediaPlayer in the GPU process, and then async dispatched back to the
WebContent process and MediaSource. Immediately prior to this last dispatch, the
SourceBufferPrivateAVFObjC flushes its sample buffer renderers, and during the subsequent async
portion there is an opportunity for the sample buffers to request new data. When that request
occurs before the response to the async dispatch, incorrect samples (future samples from the
previous playback location) are enqueued. These are then flushed again during the async response,
and replaced by correct samples.

Add a new ivar to SourceBufferPrivateAVFObjC that tracks this state, blocking enqueing new samples
while there is a pending seek operation.

  • Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::willSeek):
(WebCore::SourceBufferPrivateAVFObjC::seekToTime):
(WebCore::SourceBufferPrivateAVFObjC::isSeeking const):

Canonical link: https://commits.webkit.org/251300@main

4:54 PM Changeset in webkit [295252] by Karl Rackler
  • 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations

[Gardening]: [ Monterey wk2 release ] imported/w3c/web-platform-tests/content-security-policy/inheritance/blob-url-inherits-from-initiator.sub.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=239307
<rdar://91719197>

Unreviewed test gardening.

  • LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/251300@main

4:49 PM Changeset in webkit [295251] by Devin Rousso
  • 1 edit in trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html

[ Mac ] http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html is a flaky text failure
https://bugs.webkit.org/show_bug.cgi?id=239091
<rdar://problem/91594397>

Unreviewed test fix.

  • LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html:

Only listen for "webkitfullscreenchange" once in case the <video> exiting fullscreen somehow
happens before the test fully finishes.

Canonical link: https://commits.webkit.org/251299@main

4:45 PM Changeset in webkit [295250] by mmaxfield@apple.com
  • 4 edits
    2 adds in trunk

[Cocoa] Mail compose doesn't use Bulgarian letter forms when the system language is set to Bulgarian
https://bugs.webkit.org/show_bug.cgi?id=241253
<rdar://problem/94295531>

Reviewed by Cameron McCormack.

Mail compose doesn't set lang, which causes us to have a null locale string.
String::createCFString() transforms a null string to CFSTR(""), which indicates to Core Text
that it shouldn't use the shaping from the system language. Instead, if the locale string
is null, we should give Core Text a null locale string, so they use the correct shaping.

  • LayoutTests/TestExpectations:
  • LayoutTests/fast/text/bulgarian-system-language-shaping-expected-mismatch.html: Added.
  • LayoutTests/fast/text/bulgarian-system-language-shaping.html: Added.
  • LayoutTests/platform/ios/TestExpectations:
  • LayoutTests/platform/mac/TestExpectations:
  • Source/WebCore/platform/graphics/coretext/FontCoreText.cpp:

(WebCore::Font::applyTransforms const):

Canonical link: https://commits.webkit.org/251298@main

4:39 PM Changeset in webkit [295249] by Alan Coon
  • 1 copy in tags/WebKit-7613.3.3

Tag WebKit-7613.3.3.

4:38 PM Changeset in webkit [295248] by Karl Rackler
  • 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations

[Gardening]: [ macOS Debug wk2 EWS ] fast/animation/request-animation-frame-throttling-lowPowerMode.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=241289
<rdar://94371800>

Unreviewed test gardening.

  • LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/251297@main

4:24 PM Changeset in webkit [295247] by Chris Dumez
  • 2 edits in trunk/Source/WebCore/html/parser

Optimize HTMLToken::appendToAttributeValue()
https://bugs.webkit.org/show_bug.cgi?id=241274

Reviewed by Darin Adler.

Optimize HTMLToken::appendToAttributeValue() by appending all characters at
once instead of one by one.

  • Source/WebCore/html/parser/HTMLToken.h:

(WebCore::HTMLToken::appendToAttributeValue):

  • Source/WebCore/html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::processToken):

Canonical link: https://commits.webkit.org/251296@main

4:22 PM Changeset in webkit [295246] by Russell Epstein
  • 18 edits in branches/safari-613-branch

Revert 57e001f8c81440562b765975b7ae2b633c8bc66d. rdar://problem/88904160

This reverts commit 57e001f8c81440562b765975b7ae2b633c8bc66d.

4:21 PM Changeset in webkit [295245] by Russell Epstein
  • 5 edits in branches/safari-613-branch/Source/WebKit

Revert 637d98e55c078fde1b8a5f7cff22da2cfda99187. rdar://problem/88904160

This reverts commit 637d98e55c078fde1b8a5f7cff22da2cfda99187.

4:21 PM Changeset in webkit [295244] by Russell Epstein
  • 4 edits in branches/safari-613-branch

Revert afffb32a8971addf23e6b2cea93a52cbb6199e54. rdar://problem/92015599

This reverts commit afffb32a8971addf23e6b2cea93a52cbb6199e54.

4:21 PM Changeset in webkit [295243] by Russell Epstein
  • 5 edits in branches/safari-613-branch

Revert 704644f751c332c5b1001936cf2cd0446f4bea18. rdar://problem/92380002

This reverts commit 704644f751c332c5b1001936cf2cd0446f4bea18.

4:21 PM Changeset in webkit [295242] by Russell Epstein
  • 4 edits in branches/safari-613-branch/Source/WebKit

Revert a56ea95c510fc523f36e6f179f2e6a9763418f4e. rdar://problem/88904160

This reverts commit a56ea95c510fc523f36e6f179f2e6a9763418f4e.

4:21 PM Changeset in webkit [295241] by Russell Epstein
  • 1 edit in branches/safari-613-branch/Source/WebCore/editing/BreakBlockquoteCommand.cpp

Unreviewed build fix. rdar://14839536

./editing/BreakBlockquoteCommand.cpp:29:10: fatal error: 'CommonAtomStrings.h' file not found

4:09 PM Changeset in webkit [295240] by Devin Rousso
  • 58 edits
    3 copies in trunk

Web Inspector: replace the two "Export Audit" and "Export Result" buttons with a single button that has a picker in the NSSavePanel
https://bugs.webkit.org/show_bug.cgi?id=241214
<rdar://problem/76775840>

Reviewed by Patrick Angle.

It's odd to have only one "Import" button but two "Export *" buttons in the Audits Tab, Graphics Tab,
etc. Ideally, there'd be just one "Export" button that lets the developer choose what kind of data
to save (i.e. all formats are provided up front, and the developer picks what's actually used).

  • Source/WebInspectorUI/UserInterface/Base/FileUtilities.js:

(WI.FileUtilities.canSave): Added.
(WI.FileUtilities.async save): Added.
(WI.FileUtilities.save): Deleted.

  • Source/WebCore/inspector/InspectorFrontendHost.idl:
  • Source/WebCore/inspector/InspectorFrontendHost.h:
  • Source/WebCore/inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canSave):
(WebCore::InspectorFrontendHost::save):
Introduce a new SaveMode that's used to both check for multi-format saving support and indicate
that a particular save operation has multiple formats. Always require an array of SaveData to be
provided when saving, but only expect a single item when the save operation is not multi-format.

  • Source/WebInspectorUI/UserInterface/Base/Main.js:

(WI._contextMenuRequested):
(WI._updateDownloadTabBarButton):
(WI._save):
(WI._saveAs):
(WI.archiveMainFrame):
(WI.canArchiveMainFrame):

  • Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype.export):
(WI.AuditManager.prototype.export.dataForObject): Added.

  • Source/WebInspectorUI/UserInterface/Debug/ProtocolTrace.js:

(WI.ProtocolTrace.prototype.get saveMode): Added.

  • Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js:

(WI.TimelineRecording.prototype.get exportMode): Added.
(WI.TimelineRecording.prototype.canExport):

  • Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js:

(WI.AuditTestContentView):
(WI.AuditTestContentView.prototype.get navigationItems):
(WI.AuditTestContentView.prototype.get supportsSave):
(WI.AuditTestContentView.prototype.get saveMode): Added.
(WI.AuditTestContentView.prototype.get saveData):
(WI.AuditTestContentView.prototype._export): Added.
(WI.AuditTestContentView.prototype._updateExportNavigationItems):
(WI.AuditTestContentView.prototype._handleExportTestButtonNavigationItemClicked):
(WI.AuditTestContentView.prototype._handleExportResultButtonNavigationItemClicked):
(WI.AuditTestContentView.prototype._handleExportButtonNavigationItemClicked): Added.
(WI.AuditTestContentView.prototype._exportResult): Deleted.

  • Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js:

(WI.AuditTreeElement.prototype.populateContextMenu):

  • Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js:

(WI.ClusterContentView.prototype.get supportsSave):
(WI.ClusterContentView.prototype.get saveMode): Added.
(WI.ClusterContentView.prototype.get saveData):

  • Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:

(WI.ConsoleMessageView.prototype._handleContextMenu):

  • Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):

  • Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView.prototype.get saveMode): Added.

  • Source/WebInspectorUI/UserInterface/Views/HeapSnapshotContentView.js:

(WI.HeapSnapshotContentView):
(WI.HeapSnapshotContentView.prototype._exportSnapshot):

  • Source/WebInspectorUI/UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.get saveMode): Added.
(WI.LogContentView.prototype._handleContextMenuEvent):

  • Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.get saveMode): Added.
(WI.NetworkTableContentView.prototype._canExportHAR):
(WI.NetworkTableContentView.prototype._exportHAR):

  • Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):
(WI.RecordingContentView.prototype.get supportsSave):
(WI.RecordingContentView.prototype.get saveMode): Added.
(WI.RecordingContentView.prototype.get saveData):
(WI.RecordingContentView.prototype._export): Added.
(WI.RecordingContentView.prototype._exportRecording):
(WI.RecordingContentView.prototype._exportReduction):
(WI.RecordingContentView.prototype._updateExportButton):
(WI.RecordingContentView.prototype._handleExportNavigationItemClicked):

  • Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView.prototype.get saveMode): Added.

  • Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js:

(WI.ScriptContentView.prototype.get saveMode): Added.

  • Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:

(WI.ShaderProgramContentView):
(WI.ShaderProgramContentView.prototype.get supportsSave):
(WI.ShaderProgramContentView.prototype.get saveMode): Added.
(WI.ShaderProgramContentView.prototype.get saveData):

  • Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._save):

  • Source/WebInspectorUI/UserInterface/Views/TextContentView.js:

(WI.TextContentView.prototype.get saveMode):

  • Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype.get saveData):

  • Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView.prototype.get saveMode):
(WI.TimelineRecordingContentView.prototype._exportTimelineRecording):
Indicate the kind of SaveMode that's used. When multi-format is supported, use it to unify the
export buttons (if applicable). Also make sure to only enable the export button(s) if the desired
SaveMode is supported.

  • Source/WebKit/WebProcess/Inspector/WebInspectorUI.h:
  • Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::save):
(WebKit::WebInspectorUI::canSave):

  • Source/WebKit/WebProcess/Inspector/gtk/WebInspectorUIGtk.cpp:

(WebKit::WebInspectorUI::canSave):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const): Deleted.

  • Source/WebKit/WebProcess/Inspector/mac/WebInspectorUIMac.mm:

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL const):
(WebKit::webInspectorUILocalizedStringsURL): Deleted.
(WebKit::RemoteWebInspectorUI::localizedStringsURL const): Deleted.

  • Source/WebKit/WebProcess/Inspector/win/WebInspectorUIWin.cpp:

(WebKit::WebInspectorUI::canSave):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const): Deleted.

  • Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h:
  • Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::save):
(WebKit::RemoteWebInspectorUI::canSave): Added.
(WebKit::RemoteWebInspectorUI::canLoad): Added.

  • Source/WebKit/WebProcess/Inspector/gtk/RemoteWebInspectorUIGtk.cpp: Added.

(WebKit::RemoteWebInspectorUI::canSave):
(WebKit::RemoteWebInspectorUI::canLoad):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const):

  • Source/WebKit/WebProcess/Inspector/mac/RemoteWebInspectorUIMac.mm: Added.

(WebKit::RemoteWebInspectorUI::canSave):
(WebKit::RemoteWebInspectorUI::canLoad):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const):

  • Source/WebKit/WebProcess/Inspector/win/RemoteWebInspectorUIWin.cpp: Added.

(WebKit::RemoteWebInspectorUI::canSave):
(WebKit::RemoteWebInspectorUI::canLoad):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const):
Currently, macOS supports both single and multi-format saving, GTK supports single format saving,
and windows supports neither.
Drive-by: Add RemoteWebInspectorProxy* files for each platform instead of shoving the code into

the related WebInspectorProxy* (of the same platform).

  • Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in:
  • Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h:
  • Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp:

(WebKit::WebInspectorUIProxy::save):
(WebKit::WebInspectorUIProxy::platformSave):

  • Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp:

(WebKit::WebInspectorUIProxy::platformSave):

  • Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:

(-[WKWebInspectorUISaveController initWithSaveDatas:savePanel:]): Added.
(-[WKWebInspectorUISaveController content]): Added.
(-[WKWebInspectorUISaveController base64Encoded]): Added.
(-[WKWebInspectorUISaveController _updateSavePanel]): Added.
(-[WKWebInspectorUISaveController _popUpButtonAction:]): Added.
(WebKit::WebInspectorUIProxy::showSavePanel):
(WebKit::WebInspectorUIProxy::platformSave): Added.

  • Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp:

(WebKit::WebInspectorUIProxy::platformSave):

  • Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.messages.in:
  • Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.h:
  • Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp:

(WebKit::RemoteWebInspectorUIProxy::save):
(WebKit::RemoteWebInspectorUIProxy::platformSave):

  • Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformSave):

  • Source/WebKit/UIProcess/Inspector/mac/RemoteWebInspectorUIProxyMac.mm:

(WebKit::RemoteWebInspectorUIProxy::platformSave):

  • Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformSave):
On macOS, create a shared function to show a NSSavePanel with an accessoryView that lets the
developer choose which format to save with. On GTK, there should only ever be a single SaveData
provided (since GTK only supports single format saving), so use that.

  • Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h:
  • Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::canSave):
(WebInspectorFrontendClient::save):

  • Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorFrontendClient::save):
WK1 only supports single format saving, meaning that there should only ever be a single SaveData
provided, so use that.

  • Source/WebCore/inspector/InspectorFrontendClient.h:

(WebCore::InspectorFrontendClient::SaveData::encode const):
(WebCore::InspectorFrontendClient::SaveData::decode):
IPC stuff.

  • Source/WebCore/inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::canSave):
(WebCore::InspectorFrontendClientLocal::save):
Testing code doesn't (need to) know how to save things.

  • Source/WebInspectorUI/UserInterface/Base/URLUtilities.js:

(WI.urlWithoutExtension): Added.

  • LayoutTests/inspector/unit-tests/url-utilities.html:
  • LayoutTests/inspector/unit-tests/url-utilities-expected.txt:

Drive-by: Added a utility method to help in a console.assert.

  • Source/WebCore/en.lproj/Localizable.strings:
  • Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
  • Source/WebKit/PlatformWin.cmake:
  • Source/WebKit/SourcesCocoa.txt:
  • Source/WebKit/SourcesGTK.txt:
  • Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/251295@main

3:29 PM Changeset in webkit [295239] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Properly implement text-align-last in legacy layout engine and IFC
https://bugs.webkit.org/show_bug.cgi?id=241050

Patch by Kiet Ho <Kiet Ho> on 2022-06-03
Reviewed by Alan Bujtas.

The alignment of the last line in a block always follows the alignment specified
by text-align-last. However, the legacy layout engine currently follows the old
spec, where text-align-last only takes effect when text-align was 'justify' (see [1]
where this was changed), and IFC does not honor text-align-last at all. Fix both the
legacy layout engine and IFC to align the last line according to text-align-last.

Manually tested by running run-webkit-tests with IFC enabled and disabled.

[1]: https://github.com/w3c/csswg-drafts/commit/c1f7023611f2c44d24d5a0647965817902651f58

  • LayoutTests/TestExpectations:
  • LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify-expected.html: Removed.
  • LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html:

Remove obsolete test that tests the old behavior of text-align-line.

  • Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:

(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::LineBoxBuilder::build):

  • Source/WebCore/rendering/LegacyLineLayout.cpp:

(WebCore::LegacyLineLayout::textAlignmentForLine const):

Canonical link: https://commits.webkit.org/251294@main

3:21 PM Changeset in webkit [295238] by Fujii Hironori
  • 2 edits in trunk/Tools

webkit-patch: git am strips []-enclosed prefixes (e.g. [CMake][WPE]) in a subject
https://bugs.webkit.org/show_bug.cgi?id=241114

Reviewed by Jonathan Bedard.

git-am removes all []-enclosed prefixes from a subject by default.
git-am has --keep-non-patch option that removes only "[PATCH]" prefix.

  • Tools/CISupport/ews-build/steps.py:

(run):

  • Tools/Scripts/webkitpy/common/checkout/checkout.py:

(apply_patch):
Use --keep-non-patch option for git am.

Canonical link: https://commits.webkit.org/251293@main

3:08 PM Changeset in webkit [295237] by Kate Cheney
  • 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm

REGRESSION: [ iOS ] Six TestWebKitAPI.AppPrivacyRep ort API tests are a consistent timeout (241233)
https://bugs.webkit.org/show_bug.cgi?id=241233
rdar://94298162

Reviewed by Ryan Haddad.

Avoid connecting to the internet in API tests.

  • Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:

(TEST):

Canonical link: https://commits.webkit.org/251292@main

3:02 PM Changeset in webkit [295236] by Karl Rackler
  • 1 edit in trunk/LayoutTests/platform/win/TestExpectations

[Gardening]: [Win] Update expectations for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=172437

Unreviewed test gardening.

  • LayoutTests/platform/win/TestExpectations:

Canonical link: https://commits.webkit.org/251291@main

2:44 PM Changeset in webkit [295235] by pvollan@apple.com
  • 1 edit in trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in

[iOS][GPUP] Add read access to Mobile asset font directory
https://bugs.webkit.org/show_bug.cgi?id=241276
<rdar://89592483>

Reviewed by Geoffrey Garen.

  • Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:

Canonical link: https://commits.webkit.org/251290@main

2:21 PM Changeset in webkit [295234] by pvollan@apple.com
  • 1 edit in trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

Enable HEIC decoding for all non-browser apps on macOS
https://bugs.webkit.org/show_bug.cgi?id=241271
<rdar://92983791>

Reviewed by Geoffrey Garen.

Enable HEIC decoding for all non-browser apps on macOS, since this capability is also needed for other apps besides Mail.
We do not want to enable it for Web browsers yet, since this currently requries an unconditional sandbox extension for
trustd.

  • Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/251289@main

2:12 PM Changeset in webkit [295233] by Fujii Hironori
  • 3 edits in trunk/Source/WebCore/platform/graphics/texmap

Remove TextureMapperLayer::setChildren(const Vector<GraphicsLayer*>&) to make TextureMapperLayer independent to GraphicsLayer and GraphicsLayerTextureMapper
https://bugs.webkit.org/show_bug.cgi?id=241248

Reviewed by Don Olmstead.

setChildren(const Vector<GraphicsLayer*>&) was taking GraphicsLayer
objects as an argument, and assuming the GraphicsLayer objects were
GraphicsLayerTextureMapper objects. This was a layer violation.
TextureMapperLayer doen't need to know about GraphicsLayer and
GraphicsLayerTextureMapper.

  • Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):

  • Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:
  • Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h:

Canonical link: https://commits.webkit.org/251288@main

2:08 PM Changeset in webkit [295232] by Devin Rousso
  • 28 edits
    11 adds
    8 deletes in trunk

Web Inspector: drop InspectorAdditionsEnabled in favor of new methods on InspectorFrontendhost
https://bugs.webkit.org/show_bug.cgi?id=241192

Reviewed by Patrick Angle.

This removes custom things from standardized IDLs and allows custom functionality necessary for Web
Inspector to be kept inside inspector objects (as well as the fact that InspectorFrontendHost is
guaranteed to exist, so there's no concern about this functionality not being available).

  • Source/WTF/Scripts/Preferences/WebPreferences.yaml:
  • Source/WebCore/page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setInspectorAdditionsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::inspectorAdditionsEnabled const): Deleted.

  • Source/WebKit/UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInspectorAdditionsEnabled): Deleted.
(WKPreferencesGetInspectorAdditionsEnabled): Deleted.

  • Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:
  • Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::enableFrontendFeatures):

  • Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h:
  • Source/WebKitLegacy/mac/WebView/WebPreferences.mm:

(-[WebPreferences inspectorAdditionsEnabled]): Deleted.
(-[WebPreferences setInspectorAdditionsEnabled:]): Deleted.

  • Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:
  • Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl:
  • Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h:
  • Source/WebKitLegacy/win/WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::inspectorAdditionsEnabled): Deleted.
(WebPreferences::setInspectorAdditionsEnabled): Deleted.

  • Source/WebKitLegacy/win/WebPreferences.h:
  • Source/WebKitLegacy/win/WebView.cpp:

(WebView::notifyPreferencesChanged):

  • Tools/DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):
Remove all things related to InspectorAdditionsEnabled.

  • Source/WebCore/html/canvas/CanvasPath.idl:
  • Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:
  • Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.idl:

Remove nonstandard functionality gated by InspectorAdditionsEnabled in standardized IDLs.

  • Source/WebCore/inspector/InspectorFrontendHost.h:
  • Source/WebCore/inspector/InspectorFrontendHost.idl:
  • Source/WebCore/inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::getPath const): Added.
(WebCore::InspectorFrontendHost::getCurrentX const): Added.
(WebCore::InspectorFrontendHost::getCurrentY const): Added.
(WebCore::InspectorFrontendHost::setPath const): Added.

  • Source/WebInspectorUI/UserInterface/Base/IDLExtensions.js: Added.

(File.prototype.getPath): Added.
(CanvasRenderingContext2D.prototype.currentX): Added.
(CanvasRenderingContext2D.prototype.currentY): Added.
(CanvasRenderingContext2D.prototype.getPath): Added.
(CanvasRenderingContext2D.prototype.setPath): Added.
Centralize all custom IDL extensions in a new file with the same name so it's very easy to find.

  • Source/WebInspectorUI/UserInterface/Base/ImageUtilities.js:

(WI.ImageUtilities.supportsCanvasPathDebugging): Deleted.

  • Source/WebInspectorUI/UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.process):

  • Source/WebInspectorUI/UserInterface/Models/RecordingState.js:

(WI.RecordingState.prototype.fromContext):

  • Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):
(WI.RecordingContentView.prototype.get navigationItems):
(WI.RecordingContentView.prototype.attached):
(WI.RecordingContentView.prototype._generateContentCanvas2D):

  • Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView.prototype.async _handleMapLocalResourceOverrideToFile):
Remove checks based on InspectorAdditionsEnabled (technically they check for the existence of the
custom functionality on the builtin prototype, but that's added based on InspectorAdditionsEnabled).

  • Source/WebInspectorUI/UserInterface/Main.html:
  • Source/WebInspectorUI/UserInterface/Test.html:
  • LayoutTests/fast/canvas/2d.currentPoint.html: Removed.
  • LayoutTests/fast/canvas/2d.currentPoint-expected.txt: Removed.
  • LayoutTests/fast/canvas/2d.getPath.modification.html: Removed.
  • LayoutTests/fast/canvas/2d.getPath.modification-expected.txt: Removed.
  • LayoutTests/fast/canvas/2d.getPath.newobject.html: Removed.
  • LayoutTests/fast/canvas/2d.getPath.newobject-expected.txt: Removed.
  • LayoutTests/fast/canvas/2d.setPath.html: Removed.
  • LayoutTests/fast/canvas/2d.setPath-expected.txt: Removed.
  • LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/getPath.html: Added.
  • LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/getPath-expected.txt: Added.
  • LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/get_currentX.html: Added.
  • LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/get_currentX-expected.txt: Added.
  • LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/get_currentY.html: Added.
  • LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/get_currentY-expected.txt: Added.
  • LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/setPath.html: Added.
  • LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/setPath-expected.txt: Added.

Canonical link: https://commits.webkit.org/251287@main

2:06 PM Changeset in webkit [295231] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit/Shared/RemoteLayerTree

Unreviewed build fix after r295149

  • Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:

(WebKit::CGDisplayListImageBufferBackend::getPixelBuffer const):

  • Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h:

Fix the build.

Canonical link: https://commits.webkit.org/251286@main

2:03 PM Changeset in webkit [295230] by achristensen@apple.com
  • 2 edits in trunk

HSTS synthesized redirect responses should not be blocked by CORS
https://bugs.webkit.org/show_bug.cgi?id=241003

Reviewed by Youenn Fablet.

If a cross-origin request is made to an http URL that would be upgraded to an https URL
because of HSTS, we synthesize a "response" to call willPerformHTTPRedirection with.
Unfortunately, this response can fail CORS checks causing the request to be unnecessarily blocked.
To prevent this, just add CORS headers to the synthesized responses for HSTS.

  • Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):

  • Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:

(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/251284@main

2:03 PM Changeset in webkit [295229] by Ryan Haddad
  • 3 edits in trunk/Tools/CISupport/build-webkit-org

Repurpose arm64 iOS simulator GPUP bot as a general arm64 iOS simulator tester
https://bugs.webkit.org/show_bug.cgi?id=241278

Reviewed by Aakash Jain.

  • Tools/CISupport/build-webkit-org/config.json:
  • Tools/CISupport/build-webkit-org/factories_unittest.py:

(TestExpectedBuildSteps):

  • Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

Canonical link: https://commits.webkit.org/251284@main

2:00 PM Changeset in webkit [295228] by Karl Rackler
  • 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations

[Gardening]: [ macOS Debug wk2 EWS ] fast/animation/request-animation-frame-throttling-detached-iframe.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=241283
<rdar://94364006>

Unreviewed test gardening.

  • LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/251283@main

1:52 PM Changeset in webkit [295227] by Said Abou-Hallawa
  • 31 edits
    2 adds in trunk

[GPU Process] [Filters] Make PixelBuffer an abstract class
https://bugs.webkit.org/show_bug.cgi?id=240809
<rdar://problem/94117981>

Reviewed by Simon Fraser.

Hide the current underlying memory of PixelBuffer which is 'Uint8ClampedArray'
and move it to a new subclass named ByteArrayPixelBuffer.

All clients should use the virtual methods 'bytes()' and 'sizeInBytes()' to have
access to the pixel bytes. All calls to 'PixelBuffer::tryCreate()' should be
replaced with 'ByteArrayPixelBuffer::tryCreate()'.

In future patches and when GPUProcess applies software filters, we are going to
create new subclass of PixelBuffer for the result FilterImages. This new sub-
class will use SharedMemory as its underlying pixel data and it will attribute
this SharedMemory to WebProcess.

  • Source/WebCore/Headers.cmake:
  • Source/WebCore/Sources.txt:
  • Source/WebCore/WebCore.xcodeproj/project.pbxproj:
  • Source/WebCore/bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpImageBitmap):
(WebCore::CloneDeserializer::readImageBitmap):

  • Source/WebCore/html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getImageData):

  • Source/WebCore/html/ImageData.cpp:

(WebCore::ImageData::create):
(WebCore::ImageData::pixelBuffer const):

  • Source/WebCore/html/ImageData.h:
  • Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::getImageData const):

  • Source/WebCore/page/PageColorSampler.cpp:

(WebCore::sampleColor):

  • Source/WebCore/platform/graphics/GraphicsContextGL.cpp:

(WebCore::GraphicsContextGL::extractPixelBuffer):

  • Source/WebCore/platform/graphics/ImageBufferAllocator.cpp:

(WebCore::ImageBufferAllocator::createPixelBuffer const):

  • Source/WebCore/platform/graphics/ImageBufferBackend.cpp:

(WebCore::ImageBufferBackend::convertToLuminanceMask):
(WebCore::ImageBufferBackend::getPixelBuffer const):
(WebCore::ImageBufferBackend::putPixelBuffer):

  • Source/WebCore/platform/graphics/PixelBuffer.cpp:

(WebCore::PixelBuffer::supportedPixelFormat):
(WebCore::PixelBuffer::PixelBuffer):
(WebCore::PixelBuffer::tryCreateForDecoding): Deleted.
(WebCore::PixelBuffer::tryCreate): Deleted.
(WebCore::PixelBuffer::create): Deleted.
(WebCore::PixelBuffer::bytes const): Deleted.
(WebCore::PixelBuffer::sizeInBytes const): Deleted.
(WebCore::PixelBuffer::createScratchPixelBuffer const): Deleted.
(WebCore::operator<<): Deleted.

  • Source/WebCore/platform/graphics/PixelBuffer.h:

(WebCore::PixelBuffer::size const):
(WebCore::PixelBuffer::isByteArrayPixelBuffer const):
(WebCore::PixelBuffer::data const): Deleted.
(WebCore::PixelBuffer::takeData): Deleted.
(WebCore::PixelBuffer::encode const): Deleted.
(WebCore::PixelBuffer::decode): Deleted.

  • Source/WebCore/platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::blurShadowBuffer):

  • Source/WebCore/platform/graphics/ByteArrayPixelBuffer.cpp: Added.

(WebCore::ByteArrayPixelBuffer::create):
(WebCore::ByteArrayPixelBuffer::tryCreate):
(WebCore::ByteArrayPixelBuffer::tryCreateForDecoding):
(WebCore::ByteArrayPixelBuffer::ByteArrayPixelBuffer):
(WebCore::ByteArrayPixelBuffer::bytes const):
(WebCore::ByteArrayPixelBuffer::sizeInBytes const):
(WebCore::ByteArrayPixelBuffer::createScratchPixelBuffer const):

  • Source/WebCore/platform/graphics/ByteArrayPixelBuffer.h: Added.

(WebCore::ByteArrayPixelBuffer::data const):
(WebCore::ByteArrayPixelBuffer::takeData):
(WebCore::ByteArrayPixelBuffer::encode const):
(WebCore::ByteArrayPixelBuffer::decode):
(isType):

  • Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::readPixelsForPaintResults):
(WebCore::GraphicsContextGLANGLE::paintRenderingResultsToPixelBuffer):

  • Source/WebCore/platform/graphics/cg/GraphicsContextGLCG.cpp:

(WebCore::GraphicsContextGL::paintToCanvas):

  • Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::ImageBufferCGBackend::copyCGImageForEncoding const):

  • Source/WebCore/platform/graphics/cg/ImageBufferUtilitiesCG.cpp:

(WebCore::encode):

  • Source/WebCore/platform/graphics/cv/VideoFrameCV.mm:

(WebCore::VideoFrameCV::createFromPixelBuffer):

  • Source/WebCore/platform/graphics/filters/FilterImage.cpp:

(WebCore::copyImageBytes):

  • Source/WebCore/rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

  • Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:

(WebKit::RemoteGraphicsContextGL::paintPixelBufferToImageBuffer):

  • Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::getPixelBufferForImageBuffer):

  • Source/WebKit/Platform/IPC/PixelBufferReference.h:

(IPC::PixelBufferReference::encode const):
(IPC::PixelBufferReference::decode):

  • Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
  • Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp:

(TestWebKitAPI::imageBufferPixelIs):

Canonical link: https://commits.webkit.org/251282@main

1:39 PM Changeset in webkit [295226] by Karl Rackler
  • 1 edit in trunk/LayoutTests/platform/win/TestExpectations

[Gardening]: [ Windows EWS ] webanimations/accelerated-animations-and-motion-path.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=241282
<rdar://94362852>

Unreviewed test gardening.

  • LayoutTests/platform/win/TestExpectations:

Canonical link: https://commits.webkit.org/251281@main

1:31 PM Changeset in webkit [295225] by Devin Rousso
  • 1 edit in trunk/LayoutTests/http/tests/inspector/network/copy-as-fetch.html

New test: http/tests/inspector/network/copy-as-fetch.html is a frequent / flaky failure
https://bugs.webkit.org/show_bug.cgi?id=241279
<rdar://problem/94361782>

Unreviewed text fix.

  • LayoutTests/http/tests/inspector/network/copy-as-fetch.html:

Canonical link: https://commits.webkit.org/251280@main

1:29 PM Changeset in webkit [295224] by Devin Rousso
  • 14 edits in trunk/Source/WebInspectorUI/UserInterface

Web Inspector: Sources: creating a local override when viewing a resource should automatically place the cursor where it was before
https://bugs.webkit.org/show_bug.cgi?id=218301
<rdar://problem/70773143>

Reviewed by Patrick Angle.

  • Source/WebInspectorUI/UserInterface/Base/Main.js:

(WI.showLocalResourceOverride):
If the overridden WI.Resource is also provided, grab the selected text and scroll position from
the WI.ContentView created for it (if it exists) and pass it along when showing the WI.ContentView
for the given WI.LocalResourceOverride.

  • Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):

  • Source/WebInspectorUI/UserInterface/Views/FontResourceContentView.js:

(WI.FontResourceContentView.prototype.dropZoneHandleDrop):

  • Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js:

(WI.ImageResourceContentView.prototype.dropZoneHandleDrop):

  • Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js:

(WI.LocalResourceOverrideTreeElement.prototype.willDismissPopover):

  • Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideWarningView.js:

(WI.LocalResourceOverrideWarningView.prototype.initialLayout):

  • Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView.prototype.async _createAndShowLocalResourceOverride):
(WI.ResourceContentView.prototype._handleImportLocalResourceOverride):
Pass along the overridden WI.Resource.

  • Source/WebInspectorUI/UserInterface/Views/TextEditor.js:

(WI.TextEditor.prototype.get scrollOffset): Added.
(WI.TextEditor.prototype.set scrollOffset): Added.
(WI.TextEditor.prototype.revealPosition):
(WI.TextEditor.prototype.revealPosition.revealAndHighlightLine):
(WI.TextEditor.prototype._updateAfterFormatting):
(WI.TextEditor.prototype._revealPendingPositionIfPossible):
Add a way for callers to get/set the scroll position.
Allow callers of revealPosition to also focus for instant editability.
Drive-by: Rework the structure of the parameters to make it easier to add new one.

  • Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:

(WI.ResourceClusterContentView.prototype.restoreFromCookie):
(WI.ResourceClusterContentView.prototype.showResponse):
(WI.ResourceClusterContentView.prototype._resourceLoadingDidFinish):
Teach restoreFromCookie how to pull out more things (e.g. WI.TextRange, WI.Point, etc.).
Drive-by: Remove parameters from showResponse as they're not used anywhere.

  • Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js:

(WI.ScriptContentView.prototype.revealPosition):
(WI.ScriptContentView.prototype.restoreFromCookie):

  • Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:

(WI.ShaderProgramContentView.prototype.revealPosition):

  • Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.dialogWasDismissedWithRepresentedObject):

  • Source/WebInspectorUI/UserInterface/Views/TextContentView.js:

(WI.TextContentView.prototype.revealPosition):

  • Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype.revealPosition):
Adjust revealPosition to simply pass along parameters instead of trying to do things with them.

Canonical link: https://commits.webkit.org/251279@main

1:24 PM Changeset in webkit [295223] by Wenson Hsieh
  • 5 edits in trunk/Source/WebKit/UIProcess

Allow the element fullscreen security heuristic to ignore certain touches
https://bugs.webkit.org/show_bug.cgi?id=241068

Reviewed by Eric Carlson.

  • Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
  • Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _shouldAvoidSecurityHeuristicScoreUpdates]):

  • Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
  • Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _shouldAvoidSecurityHeuristicScoreUpdates]):

  • Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController _touchDetected:]):

Canonical link: https://commits.webkit.org/251278@main

1:24 PM Changeset in webkit [295222] by Alan Coon
  • 1 edit in branches/safari-613-branch/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp

Unreviewed build fix. rdar://problem/92853663

FAILURE ./Modules/cache/WorkerCacheStorageConnection.cpp:125:107: error: non-virtual member function marked 'final' hides virtual member function
FAILURE ./Modules/cache/WorkerCacheStorageConnection.cpp:119:72: error: allocating an object of abstract class type 'WebCore::StoppedCacheStorageConnection'

1:24 PM Changeset in webkit [295221] by Alan Coon
  • 1 edit in branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp

Revert 41769648c46b. rdar://problem/93513759

This reverts commit dc0c4463e249c835881c42cc7446662a85914ae1.

1:19 PM Changeset in webkit [295220] by Karl Rackler
  • 1 edit in trunk/LayoutTests/platform/win/TestExpectations

[Gardening]: [ Windows ] two tests imported/blink and fast/layers are a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=241281
<rdar://94362021>
Unreviewed test gardening.

  • LayoutTests/platform/win/TestExpectations:

Canonical link: https://commits.webkit.org/251277@main

12:59 PM Changeset in webkit [295219] by achristensen@apple.com
  • 26 edits in trunk

Implement CSSNumericValue.to
https://bugs.webkit.org/show_bug.cgi?id=241167

Reviewed by Chris Dumez.

  • LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssRotate.tentative-expected.txt:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathValue.tentative-expected.txt:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/to.tentative-expected.txt:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/toSum.tentative-expected.txt:
  • Source/WebCore/css/CSSUnits.cpp:

(WebCore::canonicalUnitType): Deleted.

  • Source/WebCore/css/CSSUnits.h:
  • Source/WebCore/css/typedom/CSSNumericValue.cpp:

(WebCore::operationOnValuesOfSameUnit):
(WebCore::CSSNumericValue::multiplyInternal):
(WebCore::CSSNumericValue::min):
(WebCore::CSSNumericValue::max):
(WebCore::CSSNumericValue::to):

  • Source/WebCore/css/typedom/CSSNumericValue.h:
  • Source/WebCore/css/typedom/CSSUnitValue.cpp:

(WebCore::CSSUnitValue::parseUnit):
(WebCore::CSSUnitValue::create):
(WebCore::CSSUnitValue::CSSUnitValue):
(WebCore::conversionToCanonicalUnitsScaleFactor):
(WebCore::CSSUnitValue::convertTo const):
(WebCore::CSSUnitValue::toSumValue const):
(WebCore::numericType): Deleted.
(WebCore::parseUnit): Deleted.

  • Source/WebCore/css/typedom/CSSUnitValue.h:
  • Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp:

(WebCore::CSSMathInvert::toSumValue const):

  • Source/WebCore/css/typedom/numeric/CSSMathInvert.h:
  • Source/WebCore/css/typedom/numeric/CSSMathMax.cpp:

(WebCore::CSSMathMax::create):
(WebCore::CSSMathMax::CSSMathMax):
(WebCore::CSSMathMax::toSumValue const):

  • Source/WebCore/css/typedom/numeric/CSSMathMax.h:
  • Source/WebCore/css/typedom/numeric/CSSMathMin.cpp:

(WebCore::CSSMathMin::create):
(WebCore::CSSMathMin::CSSMathMin):
(WebCore::CSSMathMin::toSumValue const):

  • Source/WebCore/css/typedom/numeric/CSSMathMin.h:
  • Source/WebCore/css/typedom/numeric/CSSMathNegate.cpp:

(WebCore::CSSMathNegate::toSumValue const):

  • Source/WebCore/css/typedom/numeric/CSSMathNegate.h:
  • Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp:

(WebCore::CSSMathProduct::toSumValue const):

  • Source/WebCore/css/typedom/numeric/CSSMathProduct.h:
  • Source/WebCore/css/typedom/numeric/CSSMathSum.cpp:

(WebCore::CSSMathSum::toSumValue const):

  • Source/WebCore/css/typedom/numeric/CSSMathSum.h:
  • Source/WebCore/css/typedom/numeric/CSSNumericArray.cpp:

(WebCore::CSSNumericArray::forEach):

  • Source/WebCore/css/typedom/numeric/CSSNumericType.cpp:

(WebCore::CSSNumericType::create):
(WebCore::typeFromVector):

  • Source/WebCore/css/typedom/numeric/CSSNumericType.h:

(WebCore::CSSNumericType::operator!= const):

  • Source/WebCore/css/typedom/transform/CSSTransformValue.cpp:

(WebCore::CSSTransformValue::serialize const):

Canonical link: https://commits.webkit.org/251276@main

12:57 PM Changeset in webkit [295218] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebCore/html/canvas

WebGL extensions enable code cleanup
https://bugs.webkit.org/show_bug.cgi?id=241264

Patch by Alexey Knyazev <3479527+lexaknyazev@users.noreply.github.com> on 2022-06-03
Reviewed by Kenneth Russell.

  • Use extension ctors to enable them in ANGLE. It is safe to

call ensureExtensionEnabled even when ANGLE is not used

  • Do not request ARB-prefixed extensions from ANGLE
  • Fixed duplicated extension enable requests for
    • ANGLE_instanced_arrays
    • OES_fbo_render_mipmap
    • WEBGL_draw_buffers
  • Directly check for enabled extensions in

WebGL2RenderingContext::renderbufferStorageImpl and
WebGLRenderingContextBase::addExtensionSupportedFormatsAndTypes
instead of scanning through the list of strings

  • Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp:

(WebCore::ANGLEInstancedArrays::ANGLEInstancedArrays):

  • Source/WebCore/html/canvas/EXTBlendMinMax.cpp:

(WebCore::EXTBlendMinMax::EXTBlendMinMax):

  • Source/WebCore/html/canvas/EXTFragDepth.cpp:

(WebCore::EXTFragDepth::EXTFragDepth):

  • Source/WebCore/html/canvas/EXTShaderTextureLOD.cpp:

(WebCore::EXTShaderTextureLOD::EXTShaderTextureLOD):

  • Source/WebCore/html/canvas/EXTTextureCompressionBPTC.cpp:

(WebCore::EXTTextureCompressionBPTC::EXTTextureCompressionBPTC):

  • Source/WebCore/html/canvas/EXTTextureCompressionRGTC.cpp:

(WebCore::EXTTextureCompressionRGTC::EXTTextureCompressionRGTC):

  • Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.cpp:

(WebCore::EXTTextureFilterAnisotropic::EXTTextureFilterAnisotropic):

  • Source/WebCore/html/canvas/EXTTextureNorm16.cpp:

(WebCore::EXTTextureNorm16::EXTTextureNorm16):

  • Source/WebCore/html/canvas/EXTsRGB.cpp:

(WebCore::EXTsRGB::EXTsRGB):

  • Source/WebCore/html/canvas/OESElementIndexUint.cpp:

(WebCore::OESElementIndexUint::OESElementIndexUint):

  • Source/WebCore/html/canvas/OESStandardDerivatives.cpp:

(WebCore::OESStandardDerivatives::OESStandardDerivatives):

  • Source/WebCore/html/canvas/OESTextureFloatLinear.cpp:

(WebCore::OESTextureFloatLinear::OESTextureFloatLinear):

  • Source/WebCore/html/canvas/OESTextureHalfFloatLinear.cpp:

(WebCore::OESTextureHalfFloatLinear::OESTextureHalfFloatLinear):

  • Source/WebCore/html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::OESVertexArrayObject):

  • Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::renderbufferStorageImpl):

  • Source/WebCore/html/canvas/WebGLDepthTexture.cpp:

(WebCore::WebGLDepthTexture::WebGLDepthTexture):

  • Source/WebCore/html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):

  • Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::addExtensionSupportedFormatsAndTypes):

Canonical link: https://commits.webkit.org/251275@main

12:30 PM Changeset in webkit [295217] by Wenson Hsieh
  • 2 edits
    1 delete in trunk/LayoutTests

[iOS] editing/selection/ios/do-not-hide-selection-in-visible-container.html fails on iPhone 12 simulator
https://bugs.webkit.org/show_bug.cgi?id=241270
rdar://86025461

Reviewed by Tim Horton.

This test currently fails when run on iPhone 12 simulator. Due to the slightly wider screen size, the row of buttons at
the top of the page no longer wraps to the next line, which in turn causes the output text to have one less space
character when compared to the output on iPhone SE.

To fix this, make the test robust against this difference by removing each button before the end of the test. This also
causes the text ouput on iPad to now match the expected output on iPhone, so we no longer require test expectations that
are specific to iPad vs. iPhone.

  • LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt:
  • LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container.html:
  • LayoutTests/platform/ipad/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt: Removed.

Canonical link: https://commits.webkit.org/251274@main

10:11 AM Changeset in webkit [295216] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Fix a couple clang warnings related with DESTINATION_COLOR_SPACE_LINEAR_SRGB and atspi
https://bugs.webkit.org/show_bug.cgi?id=241269

Patch by Philippe Normand <philn@igalia.com> on 2022-06-03
Reviewed by Michael Catanzaro.

  • Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::postPlatformNotification): Add switch case for AXHasPopupChanged, stubbed for now.

  • Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp:

(WebCore::ImageBufferCairoBackend::transformToColorSpace): makr newColorSpace as unused when
DESTINATION_COLOR_SPACE_LINEAR_SRGB is disabled.

  • Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource): Move svgStyle declaration to
DESTINATION_COLOR_SPACE_LINEAR_SRGB code path.

Canonical link: https://commits.webkit.org/251273@main

9:30 AM Changeset in webkit [295215] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebCore

Remove last remnants of old Media Controls related sliders
https://bugs.webkit.org/show_bug.cgi?id=241226

Patch by Philippe Normand <philn@igalia.com> on 2022-06-03
Reviewed by Tim Nguyen.

The media-*-slider-*part theme parts are no longer used, so should be removed.

  • Source/WebCore/WebCore.order:
  • Source/WebCore/accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::orientation const):

  • Source/WebCore/css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • Source/WebCore/css/CSSValueKeywords.in:
  • Source/WebCore/css/mediaControls.css:

(:is(audio, video)::-webkit-media-controls-timeline):

  • Source/WebCore/css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

  • Source/WebCore/html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

  • Source/WebCore/html/shadow/ShadowPseudoIds.cpp:

(WebCore::ShadowPseudoIds::webkitMediaSliderThumb): Deleted.
(WebCore::ShadowPseudoIds::webkitMediaSliderContainer): Deleted.

  • Source/WebCore/html/shadow/ShadowPseudoIds.h:
  • Source/WebCore/html/shadow/SliderThumbElement.cpp:

(WebCore::hasVerticalAppearance):
(WebCore::SliderThumbElement::create):
(WebCore::SliderThumbElement::resolveCustomStyle):
(WebCore::SliderContainerElement::create):
(WebCore::SliderThumbElement::shadowPseudoId const): Deleted.
(WebCore::SliderContainerElement::resolveCustomStyle): Deleted.
(WebCore::SliderContainerElement::shadowPseudoId const): Deleted.

  • Source/WebCore/html/shadow/SliderThumbElement.h:

(WebCore::SliderThumbElement::create): Deleted.

  • Source/WebCore/platform/ThemeTypes.cpp:

(WebCore::operator<<):

  • Source/WebCore/platform/ThemeTypes.h:
  • Source/WebCore/rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::autoAppearanceForElement const):
(WebCore::RenderTheme::paint):

  • Source/WebCore/rendering/RenderTheme.h:

(WebCore::RenderTheme::paintMediaSliderTrack): Deleted.
(WebCore::RenderTheme::paintMediaSliderThumb): Deleted.
(WebCore::RenderTheme::paintMediaVolumeSliderTrack): Deleted.
(WebCore::RenderTheme::paintMediaVolumeSliderThumb): Deleted.
(WebCore::RenderTheme::paintMediaFullScreenVolumeSliderTrack): Deleted.
(WebCore::RenderTheme::paintMediaFullScreenVolumeSliderThumb): Deleted.

  • Source/WebCore/rendering/RenderThemeAdwaita.cpp:

(WebCore::parentMediaElement): Deleted.
(WebCore::RenderThemeAdwaita::paintMediaSliderTrack): Deleted.
(WebCore::RenderThemeAdwaita::paintMediaVolumeSliderTrack): Deleted.

  • Source/WebCore/rendering/RenderThemeAdwaita.h:
  • Source/WebCore/rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderTrack):

Canonical link: https://commits.webkit.org/251272@main

9:13 AM Changeset in webkit [295214] by Chris Dumez
  • 9 edits in trunk/Source

Drop unnecessary operator==() overloads for String
https://bugs.webkit.org/show_bug.cgi?id=241235

Reviewed by Alex Christensen.

  • Source/WTF/wtf/text/WTFString.h:

(WTF::operator==):
(WTF::operator!=):

Canonical link: https://commits.webkit.org/251271@main

8:55 AM Changeset in webkit [295213] by pvollan@apple.com
  • 6 edits in trunk/Source

Call function to restrict image decoders for all clients
https://bugs.webkit.org/show_bug.cgi?id=240958
<rdar://93794556>

Reviewed by Geoffrey Garen.

Call function to enable HEIC decoding for all clients on iOS. The main motivation behind this patch
is to avoid using IOKit when decoding HEIC or JPEGs with aux HEIC. Calling enableDecodingHEIC() will
make sure IOKit is not being used, as well as enabling HEIC decoding. We previously only did this for
Mail, but decoding of HEIC images should be possible for all clients. We are not enabling this for
all clients on macOS, since macOS is not blocking IOKit in the WebContent process. This patch also
renames the function, since the former name was not accurate.

  • Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::createImageSourceOptions):
(WebCore::ImageDecoderCG::enableDecodeHEIC):
(WebCore::ImageDecoderCG::decodeHEICEnabled):
(WebCore::ImageDecoderCG::enableRestrictedDecoding): Deleted.
(WebCore::ImageDecoderCG::restrictedDecodingEnabled): Deleted.

  • Source/WebCore/platform/graphics/cg/ImageDecoderCG.h:
  • Source/WebKit/Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Source/WebKit/Shared/WebProcessCreationParameters.h:
  • Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/251270@main

8:47 AM Changeset in webkit [295212] by Karl Rackler
  • 1 edit in trunk/LayoutTests/platform/win/TestExpectations

[Gardening]: [ Windows EWS ] webanimations/accelerated-transform-animation-from-scale-zero-and-implicit-to-kefyrame.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=241268
<rdar://94347232>

Unreviewed test gardening.

  • LayoutTests/platform/win/TestExpectations:

Canonical link: https://commits.webkit.org/251269@main

8:29 AM Changeset in webkit [295211] by Antti Koivisto
  • 10 edits in trunk

Disallow styles using container units from matched declarations cache
https://bugs.webkit.org/show_bug.cgi?id=241261

Reviewed by Alan Bujtas.

We may fail to invalidate styles using container units correctly on container size change
because they are getting cached.

  • LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation-expected.txt:
  • Source/WebCore/css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):

Mark styles that use container units.

  • Source/WebCore/css/CSSToLengthConversionData.cpp:

(WebCore::CSSToLengthConversionData::defaultViewportFactor const):
(WebCore::CSSToLengthConversionData::smallViewportFactor const):
(WebCore::CSSToLengthConversionData::largeViewportFactor const):
(WebCore::CSSToLengthConversionData::dynamicViewportFactor const):
(WebCore::CSSToLengthConversionData::setUsesContainerUnits const):

  • Source/WebCore/css/CSSToLengthConversionData.h:
  • Source/WebCore/dom/Document.cpp:

(WebCore::Document::updateViewportUnitsOnResize):

  • Source/WebCore/rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::isFullScreenIFrame const):

  • Source/WebCore/rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

  • Source/WebCore/rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setUsesViewportUnits):
(WebCore::RenderStyle::usesViewportUnits const):

Also rename hasViewportUnits -> usesViewportUnits for clarity.

(WebCore::RenderStyle::setUsesContainerUnits):
(WebCore::RenderStyle::usesContainerUnits const):
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::setHasViewportUnits): Deleted.
(WebCore::RenderStyle::hasViewportUnits const): Deleted.

  • Source/WebCore/style/MatchedDeclarationsCache.cpp:

(WebCore::Style::MatchedDeclarationsCache::isCacheable):

Disallow caching.

(WebCore::Style::MatchedDeclarationsCache::clearEntriesAffectedByViewportUnits):

  • Source/WebCore/style/StyleResolver.cpp:

(WebCore::Style::Resolver::styleForElement):
(WebCore::Style::Resolver::pseudoStyleForElement):

Canonical link: https://commits.webkit.org/251268@main

8:24 AM Changeset in webkit [295210] by commit-queue@webkit.org
  • 1 edit in trunk/Source/WebCore/html/HTMLMapElement.cpp

Allow image map adding/removing when in tree scope
https://bugs.webkit.org/show_bug.cgi?id=241263

Patch by Rob Buis <rbuis@igalia.com> on 2022-06-03
Reviewed by Ryosuke Niwa.

Allow image map adding/removing when in tree scope, even
when disconnected, to avoid insert/remove mismatches.

  • Source/WebCore/html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::parseAttribute):

Canonical link: https://commits.webkit.org/251267@main

8:13 AM Changeset in webkit [295209] by Karl Rackler
  • 1 edit in trunk/LayoutTests/platform/mac-wk1/TestExpectations

[Gardening]: [ macOS wk1 ] compositing/video/video-border-radius.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=241266

Unreviewed test gardening.

  • LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/251266@main

8:03 AM Changeset in webkit [295208] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore/layout

FlexLayout should not use non-logical intrinsic widths
https://bugs.webkit.org/show_bug.cgi?id=241256

Reviewed by Antti Koivisto.

This is in preparation for using logical-intrinsic widths in flex layout.

  • Source/WebCore/layout/FormattingState.h:
  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):

  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::FlexLayout):
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):

  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

(WebCore::Layout::FlexLayout::LogicalFlexItem::minimumContentWidth const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::LogicalFlexItem):
(WebCore::Layout::FlexLayout::formattingState const): Deleted.

Canonical link: https://commits.webkit.org/251265@main

7:41 AM Changeset in webkit [295207] by Chris Dumez
  • 2 edits in trunk/Source/WebCore/html/parser

Optimize HTMLToken::appendToComment()
https://bugs.webkit.org/show_bug.cgi?id=241250

Reviewed by Yusuke Suzuki.

Append several characters at once whenever possible instead of going one
character at a time. Also avoid updating the m_data8BitCheck data member
when the input characters are not UChars.

  • Source/WebCore/html/parser/HTMLToken.h:

(WebCore::HTMLToken::appendToComment):

  • Source/WebCore/html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::processToken):

Canonical link: https://commits.webkit.org/251264@main

7:16 AM Changeset in webkit [295206] by Karl Rackler
  • 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations

[Gardening]: [ macOS Debug wk2 EWS ] WebCore::RenderView::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
https://bugs.webkit.org/show_bug.cgi?id=241265
<rdar://94344274>

Unreviewed test gardening.

  • LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: https://commits.webkit.org/251263@main

7:00 AM Changeset in webkit [295205] by commit-queue@webkit.org
  • 114 edits
    2 adds in trunk/Source/ThirdParty/ANGLE

Update ANGLE to 2022-05-31 (b6a93d753bdd819ddc0dacb8cea554c86bc4c04e))
https://bugs.webkit.org/show_bug.cgi?id=241140

Patch by Kenneth Russell <kbr@chromium.org> on 2022-06-03
Reviewed by Kimmo Kinnunen.

Contains upstream commits:
git log --oneline 8291f2d3e72eca3a25826b689a013c292ef4ba94..b6a93d753bdd819ddc0dacb8cea554c86bc4c04e --pretty=%h %s
b6a93d753 GL: Temporarily enable validation for all GL calls.
d96cee668 Fix to invalidate cache when binding Transform Feedback.
86fce7a77 Roll SwiftShader from d070309f7d15 to 51c43dc015b7 (1 revision)
31c13df5d Revert "Initialize buffer contents separately from BufferImpl::setData"
213f669d3 Roll Chromium from 312583ebe76f to 85bb5555c93e (843 revisions)
0b533e64c Make GLProgram non-copyable.
9f4b9c650 Vulkan: Refactor command buffer retain calls.
ae74bdb3d Roll vulkan-deps from 528f7d8e618c to 59aa5963cf64 (8 revisions)
33b254fe8 Fix ValidateFragmentShaderColorBufferMaskMatch for indexed masks
e02848080 Roll SwiftShader from 5ca5b0ae5a7d to d070309f7d15 (5 revisions)
23f213d13 Vulkan: Make drawable size uniform
73019edeb Vulkan: SPIR-V Gen: No RelaxedPrecision on bitCount() and findLSB()
a2fe4445d Vulkan: Sync pipeline cache only when truly changed
9ea3967d3 Bug fix in GL_EXT_YUV_target
34cff1a14 Initialize buffer contents separately from BufferImpl::setData
2df17a127 Vulkan: Pack driver uniforms
98c2e169c Vulkan: Reduce pre-rotation spec const to bool
b267c009d Add support for comparison operator in FlatUnorderedSet
ee023e6af D3D11: fix constant buffer cache lookup.
cd42f669a Roll vulkan-deps from 6885957e17e7 to 528f7d8e618c (11 revisions)
5b74b1218 Roll SwiftShader from b5cb037f0292 to 5ca5b0ae5a7d (4 revisions)
aa2201725 Roll Chromium from f86f5d40df44 to 312583ebe76f (401 revisions)
c8989675e FramebufferTest: Add FramebufferConditionalFeedbackLoop test.
ae3de1a8c Add test for primitive state change
cd80b511e Metal: Upstream uniform limits from WebKit
54e08a5af Trace Tests: Remove Pixel 2 expectations.
757b84973 Vulkan: Fix reserve varying for xfb (take 2)
7495509b3 Roll vulkan-deps from c8893896acff to 6885957e17e7 (7 revisions)
7076ae5d0 Roll Chromium from 1f342b327faa to f86f5d40df44 (495 revisions)
891dd5b3d Vulkan: Fix mid-RP draw clear w.r.t growing scissor
7ad48b846 Revert "Add Vulkan backend support for texture labels"
fea195678 Vulkan: Remove removeEarlyFragmentTestsOpt flag
7b880204d Vulkan: Remove invalid ASSERT in DescriptorSetDesc.
4aa0975e6 Vulkan: Support Wayland EGL_DEFAULT_DISPLAY
4a20c9143 D3D: Fix race condition with parallel shader compile.
17750ab06 Roll vulkan-deps from 82a65519c521 to c8893896acff (10 revisions)
ccca0c25b libANGLE: Fix evaluating the sample count
2edb216bf Roll Chromium from d624307d6d25 to 1f342b327faa (484 revisions)
a81524477 Capture/Replay: Override eglCreateImage and eglDestroyImage
c608df696 Code Cleanup
802321922 Add ffz@google.com to OWNERS
615b2c685 D3D: implement whole-struct assignment in SSBOs.

Canonical link: https://commits.webkit.org/251261@main

6:59 AM Changeset in webkit [295204] by commit-queue@webkit.org
  • 1 edit in trunk/Source/WebCore/rendering/RenderTable.cpp

Layout table captions in simplified layout
https://bugs.webkit.org/show_bug.cgi?id=241262

Patch by Rob Buis <rbuis@igalia.com> on 2022-06-03
Reviewed by Alan Bujtas.

Layout table captions in simplified layout.

  • Source/WebCore/rendering/RenderTable.cpp:

(WebCore::RenderTable::simplifiedNormalFlowLayout):

Canonical link: https://commits.webkit.org/251261@main

6:31 AM Changeset in webkit [295203] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore/layout/formattingContexts/flex

FlexLayout::computeLogicalHeightForFlexItems should check if the logical height value is auto
https://bugs.webkit.org/show_bug.cgi?id=241255

Reviewed by Antti Koivisto.

FlexLayout should always operate on logical values even if just checking whether height/width is auto.

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):

  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):

  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

(WebCore::Layout::FlexLayout::LogicalFlexItem::setTop):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setLeft):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setWidth):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setHeight):
(WebCore::Layout::FlexLayout::LogicalFlexItem::rect const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::topLeft const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::top const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::bottom const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::left const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::right const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::width const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::height const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::isHeightAuto const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::LogicalFlexItem):

Canonical link: https://commits.webkit.org/251260@main

6:27 AM Changeset in webkit [295202] by commit-queue@webkit.org
  • 52 edits in trunk/Source/WebCore/html/canvas

WebGL extensions support code cleanup
https://bugs.webkit.org/show_bug.cgi?id=241229

Patch by Alexey Knyazev <3479527+lexaknyazev@users.noreply.github.com> on 2022-06-03
Reviewed by Kenneth Russell.

  • Add missing static functions, do not call supportsExtension directly
  • Use the same template for all WebGL extension classes
  • Remove redundant ENABLE(WEBGL) guards from various WebGL extension headers,

since those are already guarded elsewhere

  • Aligned includes in OESVertexArrayObject and WebGLCompressedTextureASTC
  • Source/WebCore/html/canvas/ANGLEInstancedArrays.h:
  • Source/WebCore/html/canvas/EXTBlendMinMax.cpp:

(WebCore::EXTBlendMinMax::supported):

  • Source/WebCore/html/canvas/EXTBlendMinMax.h:
  • Source/WebCore/html/canvas/EXTFragDepth.cpp:

(WebCore::EXTFragDepth::supported):

  • Source/WebCore/html/canvas/EXTFragDepth.h:
  • Source/WebCore/html/canvas/EXTShaderTextureLOD.cpp:

(WebCore::EXTShaderTextureLOD::supported):

  • Source/WebCore/html/canvas/EXTShaderTextureLOD.h:
  • Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.cpp:

(WebCore::EXTTextureFilterAnisotropic::supported):

  • Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.h:
  • Source/WebCore/html/canvas/EXTsRGB.cpp:

(WebCore::EXTsRGB::supported):

  • Source/WebCore/html/canvas/EXTsRGB.h:
  • Source/WebCore/html/canvas/KHRParallelShaderCompile.h:
  • Source/WebCore/html/canvas/OESElementIndexUint.cpp:

(WebCore::OESElementIndexUint::supported):

  • Source/WebCore/html/canvas/OESElementIndexUint.h:
  • Source/WebCore/html/canvas/OESFBORenderMipmap.h:
  • Source/WebCore/html/canvas/OESStandardDerivatives.cpp:

(WebCore::OESStandardDerivatives::supported):

  • Source/WebCore/html/canvas/OESStandardDerivatives.h:
  • Source/WebCore/html/canvas/OESTextureFloat.h:
  • Source/WebCore/html/canvas/OESTextureFloatLinear.cpp:

(WebCore::OESTextureFloatLinear::supported):

  • Source/WebCore/html/canvas/OESTextureFloatLinear.h:
  • Source/WebCore/html/canvas/OESTextureHalfFloat.cpp:
  • Source/WebCore/html/canvas/OESTextureHalfFloat.h:
  • Source/WebCore/html/canvas/OESTextureHalfFloatLinear.cpp:

(WebCore::OESTextureHalfFloatLinear::supported):

  • Source/WebCore/html/canvas/OESTextureHalfFloatLinear.h:
  • Source/WebCore/html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::supported):

  • Source/WebCore/html/canvas/OESVertexArrayObject.h:
  • Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

  • Source/WebCore/html/canvas/WebGLColorBufferFloat.h:
  • Source/WebCore/html/canvas/WebGLCompressedTextureASTC.cpp:
  • Source/WebCore/html/canvas/WebGLCompressedTextureASTC.h:
  • Source/WebCore/html/canvas/WebGLCompressedTextureATC.cpp:
  • Source/WebCore/html/canvas/WebGLCompressedTextureATC.h:
  • Source/WebCore/html/canvas/WebGLCompressedTextureETC.cpp:
  • Source/WebCore/html/canvas/WebGLCompressedTextureETC.h:
  • Source/WebCore/html/canvas/WebGLCompressedTextureETC1.cpp:
  • Source/WebCore/html/canvas/WebGLCompressedTextureETC1.h:
  • Source/WebCore/html/canvas/WebGLCompressedTexturePVRTC.cpp:
  • Source/WebCore/html/canvas/WebGLCompressedTexturePVRTC.h:
  • Source/WebCore/html/canvas/WebGLCompressedTextureS3TC.cpp:
  • Source/WebCore/html/canvas/WebGLCompressedTextureS3TC.h:
  • Source/WebCore/html/canvas/WebGLCompressedTextureS3TCsRGB.cpp:
  • Source/WebCore/html/canvas/WebGLCompressedTextureS3TCsRGB.h:
  • Source/WebCore/html/canvas/WebGLDebugRendererInfo.cpp:
  • Source/WebCore/html/canvas/WebGLDebugRendererInfo.h:
  • Source/WebCore/html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::supported):

  • Source/WebCore/html/canvas/WebGLDebugShaders.h:
  • Source/WebCore/html/canvas/WebGLDepthTexture.cpp:
  • Source/WebCore/html/canvas/WebGLDepthTexture.h:
  • Source/WebCore/html/canvas/WebGLDrawBuffers.h:
  • Source/WebCore/html/canvas/WebGLLoseContext.cpp:
  • Source/WebCore/html/canvas/WebGLLoseContext.h:
  • Source/WebCore/html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

Canonical link: https://commits.webkit.org/251259@main

5:43 AM Changeset in webkit [295201] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore/layout/formattingContexts/flex

FlexLayout::LogicalFlexItem should provide setters and getters
https://bugs.webkit.org/show_bug.cgi?id=241254

Reviewed by Antti Koivisto.

This is in preparation for adding more members to struct LogicalFlexItem.

  • Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):

  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeAvailableLogicalVerticalSpace const):
(WebCore::Layout::FlexLayout::computeAvailableLogicalHorizontalSpace const):
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexLayout::alignFlexItems):
(WebCore::Layout::FlexLayout::justifyFlexItems):

  • Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

(WebCore::Layout::FlexLayout::LogicalFlexItem::setTop):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setLeft):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setWidth):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setHeight):
(WebCore::Layout::FlexLayout::LogicalFlexItem::rect const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::topLeft const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::top const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::bottom const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::left const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::right const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::width const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::height const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::style const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::layoutBox const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::LogicalFlexItem):

Canonical link: https://commits.webkit.org/251258@main

2:54 AM Changeset in webkit [295200] by Antti Koivisto
  • 10 edits in trunk

Re-evaluate queries after subframe size changes
https://bugs.webkit.org/show_bug.cgi?id=241225

Reviewed by Alan Bujtas.

Container queries in frames don't react to frame size changes.

  • LayoutTests/TestExpectations:

Mark imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-size-bfc-floats.html as failure, it has ever
been passing by fluke (there are some containment issues with floats).

  • LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-in-container-invalidation-expected.txt:
  • LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-invalidation-expected.txt:
  • Source/WebCore/css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

Ensure we update layout when there are container queries in a subframe, similar to media queries.

  • Source/WebCore/dom/Document.cpp:

(WebCore::Document::resolveStyle):
(WebCore::Document::updateLayout):

  • Source/WebCore/page/FrameView.cpp:

(WebCore::FrameView::updateContentsSize):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

  • Source/WebCore/page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layout):

Move the container query invalidation loop to the main layout function so all paths are covered.

(WebCore::FrameViewLayoutContext::performLayout):

  • Source/WebCore/page/FrameViewLayoutContext.h:
  • Source/WebCore/style/StyleScopeRuleSets.cpp:

(WebCore::Style::ScopeRuleSets::hasContainerQueries const):

  • Source/WebCore/style/StyleScopeRuleSets.h:

Canonical link: https://commits.webkit.org/251257@main

1:29 AM Changeset in webkit [295199] by Diego Pino Garcia
  • 1 edit in trunk/Tools/jhbuild/jhbuild-minimal.modules

[JHBuild] Disable gnutls backend in glib-networking and enable openssl backend
https://bugs.webkit.org/show_bug.cgi?id=239324

Reviewed by Carlos Alberto Lopez Perez.

glib-networking uses gnutls backend by default. Ubuntu 18.04's gnutls
doesn't meet the minimal version required by glib-networking. Use
openssl instead.

  • jhbuild/jhbuild-minimal.modules: Use openssl backend in glib-networking.

Canonical link: https://commits.webkit.org/251256@main

Note: See TracTimeline for information about the timeline view.