Timeline
Jun 9, 2022:
- 11:29 PM Changeset in webkit [295447] by
-
- 3 edits2 adds in trunk
Add EnumeratedArray type
https://bugs.webkit.org/show_bug.cgi?id=241451
Reviewed by Cameron McCormack.
This is an std::array where the indices of the array are values of an enum (rather than a size_t).
This assumes the values of the enum start at 0 and monotonically increase by 1
(so the conversion function between size_t and the enum is just a simple static_cast).
EnumeratedArray includes almost all of the functions from std::array, except for a few which I
intentionally omitted.
- Source/WTF/WTF.xcodeproj/project.pbxproj:
- Source/WTF/wtf/EnumeratedArray.h: Added.
(WTF::EnumeratedArray::EnumeratedArray):
(WTF::EnumeratedArray::operator=):
(WTF::EnumeratedArray::at):
(WTF::EnumeratedArray::at const):
(WTF::EnumeratedArray::operator[]):
(WTF::EnumeratedArray::operator[] const):
(WTF::EnumeratedArray::front):
(WTF::EnumeratedArray::front const):
(WTF::EnumeratedArray::back):
(WTF::EnumeratedArray::back const):
(WTF::EnumeratedArray::fill):
(WTF::EnumeratedArray::operator== const):
(WTF::EnumeratedArray::operator!= const):
(WTF::EnumeratedArray::operator< const):
(WTF::EnumeratedArray::operator<= const):
(WTF::EnumeratedArray::operator> const):
(WTF::EnumeratedArray::operator>= const):
(WTF::EnumeratedArray::index):
- Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Tools/TestWebKitAPI/Tests/WTF/EnumeratedArray.cpp: Added.
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/251453@main
- 11:25 PM Changeset in webkit [295446] by
-
- 22 edits2 adds2 deletes in trunk
AX: Update the isolated tree in response to dynamic changes to aria-live, aria-relevant, and aria-atomic
https://bugs.webkit.org/show_bug.cgi?id=241444
Reviewed by Chris Fleizach.
With this patch, we now update the isolated tree in response to dynamic
aria-live, aria-relevant, and aria-atomic changes.
This patch also makes liveRegionStatus, liveRegionRelevant, and
liveRegionAtomic work on node-only objects (like those with display:contents).
- LayoutTests/accessibility/aria-busy-updates-after-dynamic-change-expected.txt: Removed.
- LayoutTests/accessibility/aria-busy-updates-after-dynamic-change.html: Removed.
- LayoutTests/accessibility/live-region-attributes-update-after-dynamic-change-expected.txt: Added.
- LayoutTests/accessibility/live-region-attributes-update-after-dynamic-change.html: Added.
- LayoutTests/platform/glib/TestExpectations:
- LayoutTests/platform/ios/TestExpectations:
- LayoutTests/platform/win/TestExpectations:
- Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
- Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
- Source/WebCore/accessibility/AXObjectCache.h:
- Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::liveRegionStatus const):
(WebCore::AccessibilityNodeObject::liveRegionRelevant const):
(WebCore::AccessibilityNodeObject::liveRegionAtomic const):
- Source/WebCore/accessibility/AccessibilityNodeObject.h:
- Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::liveRegionStatus const): Deleted.
(WebCore::AccessibilityRenderObject::liveRegionRelevant const): Deleted.
(WebCore::AccessibilityRenderObject::liveRegionAtomic const): Deleted.
- Source/WebCore/accessibility/AccessibilityRenderObject.h:
- Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
- Tools/DumpRenderTree/AccessibilityUIElement.cpp:
(getLiveRegionRelevantCallback):
(getLiveRegionStatusCallback):
(getIsAtomicLiveRegionCallback):
(AccessibilityUIElement::getJSClass):
- Tools/DumpRenderTree/AccessibilityUIElement.h:
- Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::liveRegionRelevant const):
(AccessibilityUIElement::liveRegionStatus const):
(AccessibilityUIElement::isAtomicLiveRegion const):
- Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp
(AccessibilityUIElement::liveRegionRelevant const):
(AccessibilityUIElement::liveRegionStatus const):
(AccessibilityUIElement::isAtomicLiveRegion const):
- Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::liveRegionRelevant const):
(AccessibilityUIElement::liveRegionStatus const):
(AccessibilityUIElement::isAtomicLiveRegion const):
- Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::liveRegionRelevant const):
(WTR::AccessibilityUIElement::liveRegionStatus const):
(WTR::AccessibilityUIElement::isAtomicLiveRegion const):
- Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::liveRegionStatus const):
(WTR::AccessibilityUIElement::liveRegionRelevant const):
(WTR::AccessibilityUIElement::isAtomicLiveRegion const):
- Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp
- Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp
Canonical link: https://commits.webkit.org/251452@main
- 9:58 PM Changeset in webkit [295445] by
-
- 1 edit in trunk/Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm
Revert r295422
https://bugs.webkit.org/show_bug.cgi?id=241502
Unreviewed, revert r295422.
- Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm:
(WebKit::LaunchServicesDatabaseObserver::LaunchServicesDatabaseObserver):
(WebKit::LaunchServicesDatabaseObserver::startObserving):
(WebKit::LaunchServicesDatabaseObserver::~LaunchServicesDatabaseObserver):
(WebKit::hasSystemContentDatabase): Deleted.
Canonical link: https://commits.webkit.org/251451@main
- 8:08 PM Changeset in webkit [295444] by
-
- 3 edits in trunk/Source/WebCore
computeUnderlineOffset should not take TextRun
https://bugs.webkit.org/show_bug.cgi?id=241471
Reviewed by Antti Koivisto.
This is in preparation for taking visual overflow for decoration into account in IFC.
- Source/WebCore/rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::paintBackgroundDecorations):
- Source/WebCore/style/InlineTextBoxStyle.cpp:
(WebCore::computeUnderlineOffset):
(WebCore::visualOverflowForDecorations):
- Source/WebCore/style/InlineTextBoxStyle.h:
Canonical link: https://commits.webkit.org/251450@main
- 8:06 PM Changeset in webkit [295443] by
-
- 46 edits9 copies2 moves11 adds in trunk
[Payment Request] upstream new features
https://bugs.webkit.org/show_bug.cgi?id=241389
<rdar://problem/94581707>
Reviewed by Tim Horton.
- Source/WTF/wtf/PlatformHave.h:
- Source/WTF/wtf/PlatformEnableCocoa.h:
Add new flags.
- Source/WebCore/Modules/applepay/ApplePayPaymentTiming.idl:
- Source/WebCore/Modules/applepay/ApplePayPaymentTiming.h:
- Source/WebCore/Modules/applepay/ApplePayLineItem.idl:
- Source/WebCore/Modules/applepay/ApplePayLineItem.h:
(WebCore::ApplePayLineItem::encode const):
(WebCore::ApplePayLineItem::decode):
- Source/WebCore/Modules/applepay/PaymentSummaryItems.h:
- Source/WebCore/Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm:
(WebCore::platformAutomaticReloadSummaryItem): Added.
(WebCore::platformSummaryItem):
Add a new line item type for automatic reload (i.e. "charge when balance drops low enough").
- Source/WebCore/Modules/applepay/ApplePayRecurringPaymentRequest.idl: Added.
- Source/WebCore/Modules/applepay/ApplePayRecurringPaymentRequest.h: Added.
(WebCore::ApplePayRecurringPaymentRequest::encode const):
(WebCore::ApplePayRecurringPaymentRequest::decode):
- Source/WebKit/Shared/ApplePay/RecurringPaymentRequest.h: Added.
- Source/WebKit/Shared/ApplePay/cocoa/RecurringPaymentRequestCocoa.mm: Added.
(WebKit::platformRecurringPaymentRequest):
Add additional details for configuring a recurring payment.
- Source/WebCore/Modules/applepay/ApplePayAutomaticReloadPaymentRequest.idl: Added.
- Source/WebCore/Modules/applepay/ApplePayAutomaticReloadPaymentRequest.h: Added.
(WebCore::ApplePayAutomaticReloadPaymentRequest::encode const):
(WebCore::ApplePayAutomaticReloadPaymentRequest::decode):
- Source/WebKit/Shared/ApplePay/AutomaticReloadPaymentRequest.h: Added.
- Source/WebKit/Shared/ApplePay/cocoa/AutomaticReloadPaymentRequestCocoa.mm: Added.
(WebKit::platformAutomaticReloadPaymentRequest):
Add additional details for configuring an automatic reload payment.
- Source/WebCore/Modules/applepay/ApplePayPaymentTokenContext.idl: Added.
- Source/WebCore/Modules/applepay/ApplePayPaymentTokenContext.h: Added.
(WebCore::ApplePayPaymentTokenContext::encode const):
(WebCore::ApplePayPaymentTokenContext::decode):
- Source/WebKit/Shared/ApplePay/PaymentTokenContext.h: Added.
- Source/WebKit/Shared/ApplePay/cocoa/PaymentTokenContextCocoa.mm: Added.
(WebKit::toDecimalNumber):
(WebKit::platformPaymentTokenContext):
(WebKit::platformPaymentTokenContexts):
Add additional details for configuring a multi-merchant payment (i.e. booking a vacation online
often aggregates multiple separate things (e.g. car, flights, hotel, etc.) into a single purchase).
- Source/WebCore/Modules/applepay/ApplePayPaymentOrderDetails.idl: Added.
- Source/WebCore/Modules/applepay/ApplePayPaymentOrderDetails.h: Added.
(WebCore::ApplePayPaymentOrderDetails::encode const):
(WebCore::ApplePayPaymentOrderDetails::decode):
Add additional details after a payment is complete for saving order details to iOS/macOS Wallet.
- Source/WebCore/Modules/applepay/ApplePayPaymentRequest.idl:
- Source/WebCore/Modules/applepay/ApplePayPaymentRequest.h:
- Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<WebCore::ApplePaySessionPaymentRequest>::encode):
(IPC::ArgumentCoder<WebCore::ApplePaySessionPaymentRequest>::decode):
- Source/WebCore/Modules/applepay/ApplePaySession.cpp:
(WebCore::convertAndValidate):
(WebCore::merge): Deleted.
- Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::show):
(WebCore::ApplePayPaymentHandler::computeShippingMethods const):
(WebCore::validate):
(WebCore::ApplePayPaymentHandler::shippingAddressUpdated):
(WebCore::ApplePayPaymentHandler::shippingOptionUpdated):
(WebCore::ApplePayPaymentHandler::paymentMethodUpdated):
(WebCore::convertAndValidate):
(WebCore::ApplePayPaymentHandler::complete):
(WebCore::merge): Deleted.
- Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h:
(WebCore::ApplePaySessionPaymentRequest::recurringPaymentRequest const): Added.
(WebCore::ApplePaySessionPaymentRequest::setRecurringPaymentRequest): Added.
(WebCore::ApplePaySessionPaymentRequest::automaticReloadPaymentRequest const): Added.
(WebCore::ApplePaySessionPaymentRequest::setAutomaticReloadPaymentRequest): Added.
(WebCore::ApplePaySessionPaymentRequest::multiTokenContexts const): Added.
(WebCore::ApplePaySessionPaymentRequest::setMultiTokenContexts): Added.
- Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.idl:
- Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.h:
(WebCore::ApplePayDetailsUpdateBase::encode const):
(WebCore::ApplePayDetailsUpdateBase::decodeBase):
- Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.h:
- Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.idl:
- Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizationResult.idl:
- Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizationResult.h:
(WebCore::ApplePayPaymentAuthorizationResult::encode const):
(WebCore::ApplePayPaymentAuthorizationResult::decode):
- Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentCompleteDetails.idl:
- Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentCompleteDetails.h:
(WebCore::ApplePayPaymentCompleteDetails::encode const):
(WebCore::ApplePayPaymentCompleteDetails::decode):
- Source/WebKit/Platform/cocoa/PaymentAuthorizationPresenter.mm:
(WebKit::PaymentAuthorizationPresenter::completePaymentMethodSelection):
(WebKit::PaymentAuthorizationPresenter::completePaymentSession):
(WebKit::PaymentAuthorizationPresenter::completeShippingContactSelection):
(WebKit::PaymentAuthorizationPresenter::completeShippingMethodSelection):
(WebKit::PaymentAuthorizationPresenter::completeCouponCodeChange):
(WebKit::merge): Deleted.
- Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest):
(WebKit::merge): Deleted.
- Source/WebKit/Platform/cocoa/WKPaymentAuthorizationDelegate.h:
- Source/WebKit/Platform/cocoa/WKPaymentAuthorizationDelegate.mm:
(-[WKPaymentAuthorizationDelegate completePaymentSession:errors:orderDetails:]): Added.
Pipe the above from the WebProcess to the UIProcess (to PassKit).
- Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h:
- Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm:
- Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:
Handle new PassKit symbols for the above.
- Source/WebCore/Modules/applepay/cocoa/PaymentAPIVersionCocoa.mm:
(WebCore::PaymentAPIVersion::current):
Use new flags for the new version.
- Source/WebCore/DerivedSources.make:
- Source/WebCore/DerivedSources-input.xcfilelist:
- Source/WebCore/DerivedSources-output.xcfilelist:
- Source/WebCore/PlatformMac.cmake:
- Source/WebCore/SourcesCocoa.txt:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebKit/SourcesCocoa.txt:
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Source/WebCore/testing/MockPaymentCoordinator.h:
- Source/WebCore/testing/MockPaymentCoordinator.idl:
- Source/WebCore/testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeShippingMethodSelection):
(WebCore::MockPaymentCoordinator::completeShippingContactSelection):
(WebCore::MockPaymentCoordinator::completePaymentMethodSelection):
(WebCore::MockPaymentCoordinator::completeCouponCodeChange):
(WebCore::MockPaymentCoordinator::merge): Deleted.
- LayoutTests/http/tests/paymentrequest/ApplePayModifier-automaticReloadPaymentRequest.https.html: Added.
- LayoutTests/http/tests/paymentrequest/ApplePayModifier-automaticReloadPaymentRequest.https-expected.txt: Added.
- LayoutTests/http/tests/paymentrequest/ApplePayModifier-multiTokenContexts.https.html: Added.
- LayoutTests/http/tests/paymentrequest/ApplePayModifier-multiTokenContexts.https-expected.txt: Added.
- LayoutTests/http/tests/paymentrequest/ApplePayModifier-recurringPaymentRequest.https.html: Added.
- LayoutTests/http/tests/paymentrequest/ApplePayModifier-recurringPaymentRequest.https-expected.txt: Added.
- LayoutTests/http/tests/paymentrequest/ApplePayPaymentCompleteDetails-orderDetails.https.html: Added.
- LayoutTests/http/tests/paymentrequest/ApplePayPaymentCompleteDetails-orderDetails.https-expected.txt: Added.
- LayoutTests/platform/ios-wk2/TestExpectations:
- LayoutTests/platform/mac-wk2/TestExpectations:
- Source/WebKit/Shared/mac/PasteboardTypes.mm:
- Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm:
Drive-by: Unified sources fixes.
Canonical link: https://commits.webkit.org/251449@main
- 5:31 PM Changeset in webkit [295442] by
-
- 1 edit in trunk/Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm
Build fix after r295422
https://bugs.webkit.org/show_bug.cgi?id=241494
Unreviewed, build fix.
- Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm:
Canonical link: https://commits.webkit.org/251448@main
- 5:14 PM Changeset in webkit [295441] by
-
- 1 edit in trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
[ iOS Debug ] ASSERTION FAILED: Attempt to access post layout data before receiving it on editing/editable-region/fixed-and-absolute-contenteditable-scrolled.html
https://bugs.webkit.org/show_bug.cgi?id=237541
rdar://89918871
Reviewed by Simon Fraser.
After the changes in r289876, this test started sometimes hitting an assertion when run immediately
afterediting/deleting/ios/backspace-last-character.html. By eliminating a sync IPC call to the
web content process when requesting autocorrection information, UIKit now requests selection-caret-
relative character information slightly earlier than it previously did when dismissing the keyboard,
which may occur after we've received an editor state update after blurring the focused element, but
before we've received post-layout data.
In this scenario, we already know that the focused element has been blurred and the selection is no
longer editable, so once the post-layout data does arrive, it would contain0for all of the
characters close to the selection caret.
As such, we can simply return 0 early before attempting to access post-layout data if the selection
is not a caret in editable content, since all of the relevant post-layout data members
(characterAfterSelection,characterBeforeSelectionandtwoCharacterBeforeSelection) are going
to be 0 anyways.
- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _characterInRelationToCaretSelection:]):
Canonical link: https://commits.webkit.org/251447@main
- 4:43 PM Changeset in webkit [295440] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm
[Cocoa] TestWebKitAPI.MediaLoading.CaptivePortalHLS times out
https://bugs.webkit.org/show_bug.cgi?id=241476
rdar://93270049
Reviewed by Jer Noble.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
(TestWebKitAPI::TEST): Return early if the SPI used for captive portal mode is not
implemented.
Canonical link: https://commits.webkit.org/251446@main
- 4:12 PM Changeset in webkit [295439] by
-
- 2 edits in trunk/Source/WebCore/platform/graphics
[iOS] iPhone fullscreen captions are sometimes duplicated
https://bugs.webkit.org/show_bug.cgi?id=241464
rdar://94261522
Reviewed by Jer Noble.
Clear the text track representation when the video layer is cleared.
- Source/WebCore/platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:
(WebCore::VideoLayerManagerObjC::didDestroyVideoLayer): Clear the text track representation.
- Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
(WebCore::TextTrackRepresentationCocoa::TextTrackRepresentationCocoa): Name the text
track representation layer to aid debugging in the future.
Canonical link: https://commits.webkit.org/251445@main
- 2:45 PM Changeset in webkit [295438] by
-
- 32 edits3 adds1 delete in trunk
[Modern Media Controls] upstream new features
https://bugs.webkit.org/show_bug.cgi?id=241390
<rdar://problem/94581729>
Reviewed by Eric Carlson.
- Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js:
(InlineMediaControls.prototype.layout):
(InlineMediaControls.prototype.topLeftContainerButtons): Renamed from_topLeftContainerButtons.
(InlineMediaControls.prototype.leftContainerButtons): Renamed from_leftContainerButtons.
(InlineMediaControls.prototype.centerContainerButtons): Renamed from_centerContainerButtons.
(InlineMediaControls.prototype.rightContainerButtons): Renamed from_rightContainerButtons.
(InlineMediaControls.prototype.droppableButtons): Renamed from_droppableButtons.
(InlineMediaControls.prototype.collapsableButtons): Renamed from_collapsableButtons.
Move these methods into// Protectedso subclasses can override.
- Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.js:
(IOSInlineMediaControls.prototype.layout): Added.
(IOSInlineMediaControls.prototype.centerContainerButtons): Added.
(IOSInlineMediaControls.prototype.leftContainerButtons): Added.
(IOSInlineMediaControls.prototype.droppableButtons): Added.
(IOSInlineMediaControls.prototype.get _shouldUseMultilineLayout): Added.
- Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css: Added.
(.media-controls.inline.ios:not(.audio)):
(.media-controls.inline.ios:not(.audio):is(:empty, .faded)):
(.media-controls.inline.ios:not(.audio) *):
(.media-controls.inline.ios:not(.audio) > .controls-bar:is(.top-left, .top-right)):
(.media-controls.inline.ios:not(.audio) > .controls-bar.center):
Only use the new UI for<video>.
- Source/WebCore/Modules/modern-media-controls/controls/slider.js:
(Slider):
(Slider.prototype.get allowsRelativeScrubbing): Added.
(Slider.prototype.set allowsRelativeScrubbing): Added.
(Slider.prototype.handleEvent):
(Slider.prototype._handlePointerdownEvent):
(Slider.prototype._handlePointermoveEvent): Added.
(Slider.prototype._handlePointerupEvent):
(Slider.prototype._playbackProgress): Added.
(Slider.prototype._valueWillStartChanging): Deleted.
(Slider.prototype._valueDidStopChanging): Deleted.
- Source/WebCore/Modules/modern-media-controls/controls/slider.css:
(.slider.allows-relative-scrubbing > .custom-slider): Added.
(.slider.allows-relative-scrubbing > .custom-slider.changing): Added.
(.slider.allows-relative-scrubbing > .custom-slider > .fill): Added.
(.slider.allows-relative-scrubbing > .custom-slider.changing > .fill.primary): Added.
(.slider.allows-relative-scrubbing > .custom-slider.changing > .fill.track): Added.
(.slider.allows-relative-scrubbing > .custom-slider.changing > .fill.secondary): Added.
(.slider.allows-relative-scrubbing > input): Added.
(.ios .slider > input):
(.ios .slider:not(.allows-relative-scrubbing) > input): Added.
- Source/WebCore/Modules/modern-media-controls/controls/adwaita-fullscreen-media-controls.js:
(AdwaitaFullscreenMediaControls):
- Source/WebCore/Modules/modern-media-controls/controls/adwaita-inline-media-controls.js:
(AdwaitaInlineMediaControls):
- Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
(MacOSFullscreenMediaControls):
- Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js:
(MacOSInlineMediaControls):
- Source/WebCore/Modules/modern-media-controls/controls/time-control.js:
(TimeControl):
Allow the user to use relative scrubbing instead of having to exactly tap/drag on the knob.
- Source/WebCore/Modules/modern-media-controls/controls/ios-layout-traits.js:
(IOSLayoutTraits.prototype.skipDuration):
Change to 10s.
- Source/WebCore/Modules/modern-media-controls/controls/overflow-button.js:
(OverflowButton):
- Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js:
(LayoutTraits.prototype.overflowButtonHasCircle): Deleted.
- Source/WebCore/Modules/modern-media-controls/controls/icon-service.js:
- Source/WebCore/Modules/modern-media-controls/images/iOS/Overflow.svg:
- Source/WebCore/Modules/modern-media-controls/images/iOS/OverflowCircle.svg: Removed.
Update iOS overflow button icon.
- Source/WebCore/CMakeLists.txt:
- Source/WebCore/DerivedSources-input.xcfilelist:
- Source/WebCore/DerivedSources.make:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- LayoutTests/fast/mediastream/MediaStream-video-element-video-tracks-disabled.html:
- LayoutTests/fast/mediastream/MediaStream-video-element-video-tracks-disabled-expected.html:
- LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-layout.html:
- LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-layout-expected.txt:
- LayoutTests/media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-added-after-play.html:
- LayoutTests/media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-added-after-play-expected.txt:
- LayoutTests/media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-shows-start-button.html:
- LayoutTests/media/modern-media-controls/skip-back-button/skip-back-button.html:
- LayoutTests/media/modern-media-controls/skip-back-button/skip-back-button-expected.txt:
- LayoutTests/media/modern-media-controls/skip-forward-button/skip-forward-button.html:
- LayoutTests/media/modern-media-controls/skip-forward-button/skip-forward-button-expected.txt:
- LayoutTests/media/modern-media-controls/slider/slider-constructor.html:
- LayoutTests/media/modern-media-controls/slider/slider-styles.html:
- LayoutTests/media/modern-media-controls/slider/slider-value.html:
- LayoutTests/platform/ios/media/track/track-css-visible-stroke-expected.html: Added.
Canonical link: https://commits.webkit.org/251444@main
- 2:41 PM Changeset in webkit [295437] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm
REGRESSION: [iOS] TestWebKitAPI.HSTS.ThirdParty is consistely failing
https://bugs.webkit.org/show_bug.cgi?id=241342
Reviewed by Kate Cheney.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:
(TestWebKitAPI::hstsWebViewAndDelegate):
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/251443@main
- 2:36 PM Changeset in webkit [295436] by
-
- 1 edit in trunk/Source/WebCore/html/HTMLInputElement.cpp
Fix invalid isInShadowRoot flag during input element removal
https://bugs.webkit.org/show_bug.cgi?id=241470
Reviewed by Ryosuke Niwa.
Style invalidation of input elements might rely on whether the element
is in the shadow tree, but during node removal the isInShadowRoot flag
might not be up-to-date. Ensure that the flag is updated by
letting Node::removedFromAncestor() be called up first in the
HTMLInputNode::removedFromAncestor() implementation, before
doing anything else with the node post-removal.
- Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::removedFromAncestor):
Canonical link: https://commits.webkit.org/251442@main
- 2:34 PM Changeset in webkit [295435] by
-
- 5 edits2 deletes in trunk/Source/WebKit
Remove _WKWebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=241387
Reviewed by Brady Eidson.
- Source/WebKit/SourcesCocoa.txt:
- Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): Deleted.
(-[WKWebViewConfiguration _setWebsiteDataStore:]): Deleted.
- Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm: Removed.
- Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreInternal.h: Removed.
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/251441@main
- 1:54 PM Changeset in webkit [295434] by
-
- 1 edit in trunk/Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm
Add missing include in ScreenCaptureKitCaptureSource.mm
https://bugs.webkit.org/show_bug.cgi?id=241479
<rdar://94747956>
Patch by Youssef Soliman <youssefdevelops@gmail.com> on 2022-06-09
Reviewed by Wenson Hsieh and Eric Carlson.
ScreenCaptureKitCaptureSource was missing the declaration for
CGDisplayModeGetPixelsWide and CGDisplayModeGetPixelsHigh which are
defined in <pal/spi/cg/CoreGraphicsSPI.h>, this was causing build failures
if the build order happened to change.
- Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
Canonical link: https://commits.webkit.org/251440@main
- 1:42 PM Changeset in webkit [295433] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm
REGRESSION(r292365): [ iOS ] TestWebKitAPI.GPUProcess.CanvasBasicCrashHandling is a constant failure on iOS
https://bugs.webkit.org/show_bug.cgi?id=239303
<rdar://problem/91715705>
Reviewed by Simon Fraser.
The test has been passing when running it locally. This should be fixed by other
changes so re-enable this api-test.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
(TEST):
Canonical link: https://commits.webkit.org/251439@main
- 1:30 PM Changeset in webkit [295432] by
-
- 2 edits in trunk/Source
Upstream linkage of ApplePushService
https://bugs.webkit.org/show_bug.cgi?id=241473
Reviewed by Wenson Hsieh.
- Source/WTF/wtf/PlatformHave.h:
- Source/WebKit/Configurations/WebKit.xcconfig:
Canonical link: https://commits.webkit.org/251438@main
- 1:13 PM Changeset in webkit [295431] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
Multisampling does not work on MTLGPUFamilyApple2 devices when using ANGLE Metal
https://bugs.webkit.org/show_bug.cgi?id=241456
<rdar://problem/90949957>
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-06-09
Reviewed by Dean Jackson.
Use OpenGL ES for WebGL for devices prior to MTLGPUFamilyApple3.
WebGL2 already was running OpenGL ES for these devices for different reasons.
The multisample codepath is not implemented for Apple2 which
does not support MTLStoreActionStoreAndMultisampleResolve.
- Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::platformSupportsMetal):
(WebCore::GraphicsContextGLCocoa::platformInitializeContext):
Canonical link: https://commits.webkit.org/251437@main
- 12:26 PM Changeset in webkit [295430] by
-
- 1 edit in trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
Need to check the context wasn't lost in WebGL2RenderingContext::readBuffer()
https://bugs.webkit.org/show_bug.cgi?id=241477
<rdar://94289317>
Patch by Antoine Quint <Antoine Quint> on 2022-06-09
Reviewed by Dean Jackson.
All other APIs exposed on WebGL2RenderingContext are guarded by isContextLostOrPending()
checks, and readBuffer() should be no exception.
- Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::readBuffer):
Canonical link: https://commits.webkit.org/251436@main
- 12:25 PM Changeset in webkit [295429] by
-
- 1 edit2 adds in trunk
TextureMtl.mm:108 (GetLayerMipIndex): \t! Unreachable reached
https://bugs.webkit.org/show_bug.cgi?id=240790
Reviewed by Darin Adler
Check texture valid before use.
- Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.mm:
(rx::mtl::Texture::MakeTexture):
Canonical link: https://commits.webkit.org/251435@main
- 12:05 PM Changeset in webkit [295428] by
-
- 1 edit1 add in trunk
jsc's settimeout should properly handle a delay
https://bugs.webkit.org/show_bug.cgi?id=240467
Reviewed by Yusuke Suzuki.
This patch makes it so that we properly handle a timeout passed to the JSC CLI setTimeout API. Previously we would just run the callback on the next runloop tick regardless of the passed value.
- Source/JavaScriptCore/jsc.cpp:
(JSC_DEFINE_HOST_FUNCTION):
Canonical link: https://commits.webkit.org/251434@main
- 11:57 AM Changeset in webkit [295427] by
-
- 1 edit in trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
Unreviewed, fix the internal iOS build
Add a missing header include (due to source unification order).
- Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
Canonical link: https://commits.webkit.org/251433@main
- 11:35 AM Changeset in webkit [295426] by
-
- 7 edits in trunk
Regression(r283217) : [ iOS 15 ] media/track/track-forced-subtitles-in-band.html is failing
https://bugs.webkit.org/show_bug.cgi?id=231333
rdar://83955154
Reviewed by Jer Noble.
- LayoutTests/media/track/track-forced-subtitles-in-band-expected.txt: Update.
- LayoutTests/media/track/track-forced-subtitles-in-band.html: Ditto.
- LayoutTests/media/video-test.js: Make waitForEventWithTimeout return a Promise rejection when it times out so failures can be caught.
- LayoutTests/platform/ios-wk2/TestExpectations: Remove updated test.
- LayoutTests/platform/mac/TestExpectations: Ditto.
- Source/WebCore/html/track/TextTrackCueGeneric.cpp: Add more logging to help future debugging.
- Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Ditto.
Canonical link: https://commits.webkit.org/251432@main
- 11:21 AM Changeset in webkit [295425] by
-
- 11 edits2 adds in trunk
convertingToLengthRequiresNonNullStyle needs to consider calc values
https://bugs.webkit.org/show_bug.cgi?id=241452
Reviewed by Antti Koivisto.
- LayoutTests/fast/css/matrix-translate-calc-units.html: Added.
- Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertingToLengthRequiresNonNullStyle const):
(WebCore::CSSPrimitiveValue::convertToLength const):
- Source/WebCore/css/TransformFunctions.cpp:
- Source/WebCore/css/calc/CSSCalcExpressionNode.h:
- Source/WebCore/css/calc/CSSCalcInvertNode.h:
- Source/WebCore/css/calc/CSSCalcNegateNode.h:
- Source/WebCore/css/calc/CSSCalcOperationNode.cpp:
(WebCore::CSSCalcOperationNode::convertingToLengthRequiresNonNullStyle const):
- Source/WebCore/css/calc/CSSCalcOperationNode.h:
- Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp:
(WebCore::CSSCalcPrimitiveValueNode::convertingToLengthRequiresNonNullStyle const):
- Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.h:
- Source/WebCore/css/calc/CSSCalcValue.cpp:
(WebCore::CSSCalcValue::convertingToLengthRequiresNonNullStyle const):
- Source/WebCore/css/calc/CSSCalcValue.h:
Canonical link: https://commits.webkit.org/251431@main
- 10:50 AM Changeset in webkit [295424] by
-
- 1 edit in trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml
Add MPEG2 and MP4 Audio to types allowed in Captive Portal mode
https://bugs.webkit.org/show_bug.cgi?id=241447
<rdar://93934656>
Reviewed by Eric Carlson.
Needed for playing back MP2TS streams and AAC audio.
- Source/WTF/Scripts/Preferences/WebPreferences.yaml:
Canonical link: https://commits.webkit.org/251430@main
- 10:20 AM Changeset in webkit [295423] by
-
- 1 edit in trunk/Source/JavaScriptCore/bytecode/Repatch.cpp
Repatch should be able to polymorphic call with arity fixup.
https://bugs.webkit.org/show_bug.cgi?id=240911
Reviewed by Saam Barati.
Right now repatch will emit a virtual call any time it has a case that requires arity fixup. Instead it should just pick the arity fixup entrypoint.
Canonical link: https://commits.webkit.org/251429@main
- 10:16 AM Changeset in webkit [295422] by
-
- 2 edits in trunk/Source
Adopt SPI to get default content of Launch Services database
https://bugs.webkit.org/show_bug.cgi?id=241286
<rdar://64528683>
Reviewed by Geoffrey Garen.
Adopt SPI to get system content of Launch Services database. If this SPI is available,
it will replace the SPI we currently use to retrieve the database in the Network process.
- Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h:
- Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm:
(WebKit::LaunchServicesDatabaseObserver::LaunchServicesDatabaseObserver):
(WebKit::LaunchServicesDatabaseObserver::startObserving):
(WebKit::LaunchServicesDatabaseObserver::~LaunchServicesDatabaseObserver):
Canonical link: https://commits.webkit.org/251428@main
- 8:58 AM Changeset in webkit [295421] by
-
- 3 edits in trunk
Replace uses of -webkit-gradient with standard linear-gradient.
https://bugs.webkit.org/show_bug.cgi?id=241066
rdar://94390714
Patch by Ryan Reno <rreno@apple.com> on 2022-06-09
Reviewed by Tim Nguyen.
Replace uses of the -webkit-gradient extension with the standardized
linear-gradient in internal CSS. This doesn't change functionality and
is covered by existing tests of the linear-gradient CSS function.
- Source/WebCore/Modules/mediacontrols/mediaControlsBase.css:
(video::-webkit-media-controls-panel,):
(video::-webkit-media-controls-panel .volume-box,):
(audio::-webkit-media-controls-volume-slider,):
(video::-webkit-media-controls-volume-slider::-webkit-slider-thumb,):
(video::-webkit-media-controls-volume-slider::-webkit-slider-thumb::-webkit-slider-thumb:active,):
(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-volume-slider):
- Source/WebCore/html/shadow/meterElementShadow.css:
(div#bar):
(div#value.optimum):
(div#value.suboptimum):
(div#value.even-less-good):
- LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
Canonical link: https://commits.webkit.org/251427@main
- 8:07 AM Changeset in webkit [295420] by
-
- 10 edits in trunk/Source/WebKit
Blame content process for media buffers allocated in the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=241455
<rdar://94674194>
Reviewed by Jer Noble.
After copying the media content sent by the content process into a SharedMemory,
we send its SharedMemory's handle back to the content process for it to blame the
content.
Covered by existing tests.
- Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.cpp:
(WebKit::RemoteMediaResourceManager::dataReceived):
- Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.h:
- Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.messages.in:
- Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::append):
- Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h:
- Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in:
- Source/WebKit/Platform/IPC/SharedBufferReference.cpp:
(IPC::SharedBufferReference::sharedCopy const):
- Source/WebKit/Platform/IPC/SharedBufferReference.h:
- Source/WebKit/WebProcess/GPU/media/RemoteMediaResourceProxy.cpp:
(WebKit::RemoteMediaResourceProxy::dataReceived):
- Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:
(WebKit::SourceBufferPrivateRemote::append):
Canonical link: https://commits.webkit.org/251426@main
- 7:08 AM Changeset in webkit [295419] by
-
- 1 edit in trunk/Source/WTF/wtf/text/AtomString.h
[GTK] Ubuntu LTS bot build failed after 251271@main
https://bugs.webkit.org/show_bug.cgi?id=241327
Reviewed by Darin Adler.
- Source/WTF/wtf/text/AtomString.h: Implement missing operator!=(const AtomString& a, ASCIILiteral b).
Canonical link: https://commits.webkit.org/251425@main
- 6:14 AM Changeset in webkit [295418] by
-
- 7 edits in trunk
Correctly resolve queries when container size is affected by a subsequent sibling
https://bugs.webkit.org/show_bug.cgi?id=241457
Reviewed by Alan Bujtas.
We currently only take style changes before the container into account.
This patch changes the query container resolution so that whenever we encounter a query container
we skip the subtree and restart the resolution from the main resolution loop. This way we
can optimize away unnecessary layouts while also handling backward dependencies.
- LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/sibling-layout-dependency-expected.txt:
- Source/WebCore/dom/Document.cpp:
(WebCore::Document::resolveStyle):
Loop also when there are no style changes to apply but there are unresolved container. In this case we just resume
the style resolution where we left it.
- Source/WebCore/dom/Element.cpp:
(WebCore::Element::invalidateForQueryContainerChange):
Invalidate all descendants when a query container is resized. In practice we ended up computing them all anyway.
- Source/WebCore/style/StyleChange.cpp:
(WebCore::Style::determineChange):
- Source/WebCore/style/StyleChange.h:
Add new Descendants value for when container type or name changes.
- Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::computeDescendantsToResolve):
(WebCore::Style::TreeResolver::pushParent):
(WebCore::Style::TreeResolver::popParent):
(WebCore::Style::TreeResolver::resolveComposedTree):
(WebCore::Style::TreeResolver::determineQueryContainerAction):
Use two buckets for unresolved and resolved containers. Use the resolved bucket to avoid
recomputing containers we have resolved already.
(WebCore::Style::TreeResolver::resolve):
Move the containers from the unresolved to resolved bucket in the beginning.
(WebCore::Style::TreeResolver::updateQueryContainer): Deleted.
- Source/WebCore/style/StyleTreeResolver.h:
Canonical link: https://commits.webkit.org/251424@main
- 5:05 AM Changeset in webkit [295417] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/gtk/SystemFontDatabaseGTK.cpp
REGRESSION(251416@main): Broke GTK...
https://bugs.webkit.org/show_bug.cgi?id=241460
Patch by Philippe Normand <philn@igalia.com> on 2022-06-09
Unreviewed, fix GTK build.
- Source/WebCore/platform/graphics/gtk/SystemFontDatabaseGTK.cpp:
(WebCore::SystemFontDatabase::platformSystemFontShorthandInfo):
Canonical link: https://commits.webkit.org/251423@main
- 4:30 AM Changeset in webkit [295416] by
-
- 1 edit in trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.asm
Don't save CSRs respected by the JIT ABI.
Patch by Geza Lore <Geza Lore> on 2022-06-09
https://bugs.webkit.org/show_bug.cgi?id=241369
Reviewed by Mark Lam.
It is not necessary to save and restore CSRs respected by the JIT ABI on
VM entry/exit. The compiler will preserve them. (r10 and r11 on ARMv7.)
- Source/JavaScriptCore/llint/LowLevelInterpreter.asm:
Canonical link: https://commits.webkit.org/251422@main
- 3:39 AM Changeset in webkit [295415] by
-
- 3 edits in trunk/Source/WebCore/html/canvas
Remove unused code from WebGL2RenderingContext
https://bugs.webkit.org/show_bug.cgi?id=241351
Patch by Alexey Knyazev <3479527+lexaknyazev@users.noreply.github.com> on 2022-06-09
Also removed unnecessary FALLTHROUGH attributes.
Reviewed by Kimmo Kinnunen.
- Source/WebCore/html/canvas/EXTTextureNorm16.cpp:
(WebCore::EXTTextureNorm16::supported):
- Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::initializeVertexArrayObjects):
(WebCore::WebGL2RenderingContext::getInternalformatParameter):
(WebCore::WebGL2RenderingContext::getTexParameter):
(WebCore::isRenderableInternalformat): Deleted.
(WebCore::WebGL2RenderingContext::validateTexStorageFuncParameters): Deleted.
(WebCore::WebGL2RenderingContext::baseInternalFormatFromInternalFormat): Deleted.
(WebCore::WebGL2RenderingContext::isIntegerFormat): Deleted.
- Source/WebCore/html/canvas/WebGL2RenderingContext.h:
Canonical link: https://commits.webkit.org/251421@main
- 3:06 AM WebKitEnablingFlatpakClangd edited by
- (diff)
Jun 8, 2022:
- 11:58 PM Changeset in webkit [295414] by
-
- 2 edits in trunk/Source/WebCore/svg/graphics/filters
[GPU Process] [Filters] Add SVGFilterGraph::visit()
https://bugs.webkit.org/show_bug.cgi?id=239984
<rdar://problem/92987766>
Reviewed by Cameron McCormack.
This will remove duplicate code in SVGFilterBuilder. The plan is to remove
SVGFilterBuilder and move its functions to SVGFilter.
- Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::buildFilterExpression):
(WebCore::buildFilterPrimitivesGraph):
(WebCore::SVGFilterBuilder::calculateFilterOutsets):
(WebCore::appendSubGraphToExpression): Deleted.
(WebCore::appendGraphToExpression): Deleted.
(WebCore::calculateSubGraphOutsets): Deleted.
(WebCore::calculateGraphOutsets): Deleted.
- Source/WebCore/svg/graphics/filters/SVGFilterGraph.h:
(WebCore::SVGFilterGraph::visit):
Canonical link: https://commits.webkit.org/251419@main
- 11:58 PM Changeset in webkit [295413] by
-
- 4 edits3 adds2 deletes in trunk
AX: The role of AccessibilityRole::TextField and AccessibilityRole::TextArea objects must be updated after dynamic changes to aria-multiline
https://bugs.webkit.org/show_bug.cgi?id=241428
Reviewed by Chris Fleizach.
The role value of AccessibilityRole::TextField and AccessibilityRole::TextArea
objects is dependent on their aria-multiline value. With this patch, we now
recompute the role of these objects when aria-multiline changes.
- LayoutTests/accessibility/aria-multiline-expected.txt: Added.
- LayoutTests/accessibility/aria-multiline.html: Added.
- LayoutTests/accessibility/mac/aria-multiline-expected.txt: Removed.
- LayoutTests/accessibility/mac/aria-multiline.html: Removed.
- LayoutTests/platform/ios/TestExpectations:
Enable aria-multiline.html.
- LayoutTests/platform/ios/accessibility/aria-multiline-expected.txt: Added.
- LayoutTests/platform/win/TestExpectations:
Disable aria-multiline.html.
- Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
Canonical link: https://commits.webkit.org/251419@main
- 11:45 PM Changeset in webkit [295412] by
-
- 1 edit in trunk/Tools/Scripts/test262/Runner.pm
test262-runner should compare slashes correctly on Windows
https://bugs.webkit.org/show_bug.cgi?id=241441
Reviewed by Mark Lam.
test262-runner was unable to detect skips and expected failures on Windows due to backslashes in paths.
This patch adds normalization when comparing against config.yaml and expectations.yaml.
- Tools/Scripts/test262/Runner.pm:
Canonical link: https://commits.webkit.org/251418@main
- 10:15 PM Changeset in webkit [295411] by
-
- 2 edits in trunk/Source
Upstream some camera-related sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=241446
Reviewed by Wenson Hsieh.
- Source/WTF/wtf/PlatformHave.h:
- Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:
Canonical link: https://commits.webkit.org/251417@main
- 10:12 PM Changeset in webkit [295410] by
-
- 15 edits9 adds in trunk/Source/WebCore
Cache system font shorthand information
https://bugs.webkit.org/show_bug.cgi?id=241404
Reviewed by Cameron McCormack.
This is the fourth piece of https://bugs.webkit.org/show_bug.cgi?id=237817.
System font shorthands are things like "font: caption" or "font: -apple-system-body".
There used to be a cache that was supposed to map each shorthand value to a CTFontDescriptor.
However, the cache didn't work, so I deleted it in
https://github.com/WebKit/WebKit/commit/6ead5274db5f92656360fa1fbae3e0091481fc4f. This patch
reimplements it, but does so in platform/graphics/SystemFontDatabase, which is the natural
place to put it.
One of the repercussions of putting it in platform/ is that it can't use real CSSValuesIDs
as keys into the cache (because it's a layering violation to make things in platform/ see
CSS things). Therefore, this patch creates its own enum, which lives in platform/, which
conveniently exactly matches the relevant values from CSSValueID.
The Cocoa ports already have a SystemFontDatabaseCoreText which does similar things, but this
new cache is not platform-specific, so I'm putting it in SystemFontDatabase instead of
SystemFontDatabaseCoreText. SystemFontDatabaseCoreText will now inherit from SystemFontDatabase,
with 0 virtual methods. I've also taken the existing code that populates the previous cache
and temporarily duplicated it in SystemFontDabase*.cpp to make it populate this cache.
This patch doesn't actually _call_ the new cache, because doing so is somewhat complicated and
deserves its own patch. This patch just implements the cache itself. Also, because callers
aren't migrated to use this new cache yet, this patch doesn't delete the old cache either.
Both of those things will come in a follow-up patch.
- Source/WebCore/PAL/pal/spi/cf/CoreTextSPI.h:
- Source/WebCore/PlatformPlayStation.cmake:
- Source/WebCore/PlatformWin.cmake:
- Source/WebCore/Sources.txt:
- Source/WebCore/SourcesCocoa.txt:
- Source/WebCore/SourcesGTK.txt:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebCore/platform/graphics/SystemFontDatabase.cpp: Added.
(WebCore::SystemFontDatabase::systemFontShorthandInfo const):
(WebCore::SystemFontDatabase::systemFontShorthandFamily):
(WebCore::SystemFontDatabase::systemFontShorthandSize):
(WebCore::SystemFontDatabase::systemFontShorthandWeight):
(WebCore::SystemFontDatabase::clear):
- Source/WebCore/platform/graphics/SystemFontDatabase.h: Added.
- Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::normalizeCTWeight):
(WebCore::denormalizeCTWeight):
- Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h:
- Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCocoa.mm: Added.
(WebCore::cocoaFontClass):
(WebCore::SystemFontDatabaseCoreText::smallCaptionFontDescriptor):
(WebCore::SystemFontDatabaseCoreText::menuFontDescriptor):
(WebCore::SystemFontDatabaseCoreText::statusBarFontDescriptor):
(WebCore::SystemFontDatabaseCoreText::miniControlFontDescriptor):
(WebCore::SystemFontDatabaseCoreText::smallControlFontDescriptor):
(WebCore::SystemFontDatabaseCoreText::controlFontDescriptor):
- Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabase::singleton):
(WebCore::SystemFontDatabaseCoreText::clear):
(WebCore::cssWeightOfSystemFontDescriptor):
(WebCore::SystemFontDatabase::platformSystemFontShorthandInfo):
- Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.h:
- Source/WebCore/platform/graphics/gtk/SystemFontDatabaseGTK.cpp: Added.
(WebCore::SystemFontDatabase::singleton):
(WebCore::SystemFontDatabase::platformSystemFontShorthandInfo):
- Source/WebCore/platform/graphics/playstation/SystemFontDatabasePlayStation.cpp: Added.
(WebCore::SystemFontDatabase::singleton):
(WebCore::SystemFontDatabase::platformSystemFontShorthandInfo):
- Source/WebCore/platform/graphics/win/SystemFontDatabaseWin.cpp: Added.
(WebCore::SystemFontDatabase::singleton):
(WebCore::SystemFontDatabase::platformSystemFontShorthandInfo):
- Source/WebCore/rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry const):
Canonical link: https://commits.webkit.org/251416@main
- 9:55 PM Changeset in webkit [295409] by
-
- 1 edit in trunk/Source/WebGPU/WebGPU/ShaderModule.mm
WebGPU::ShaderModule::convertCheckResult() should use std::forward
<https://webkit.org/b/241437>
<rdar://94662366>
Reviewed by Darin Adler.
- Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::ShaderModule::convertCheckResult):
- Switch from WTFMove() to std::forward().
Canonical link: https://commits.webkit.org/251415@main
- 6:42 PM Changeset in webkit [295408] by
-
- 5 edits in trunk/Source
Rename MAC_CATALYST_GRAMMAR_CHECKING to ENABLE_POST_EDITING_GRAMMAR_CHECKING for clarity.
https://bugs.webkit.org/show_bug.cgi?id=241434
Reviewed by Tim Horton.
After upstreaming, change the name of this flag, and also have it in open source for clarity.
- Source/WTF/wtf/PlatformEnableCocoa.h:
- Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markAndReplaceFor):
- Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:
(WebCore::grammarColor):
- Source/WebKit/Platform/spi/ios/UIKitSPI.h:
- Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:
(WebKit::mutableState):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::checkTextOfParagraph):
Canonical link: https://commits.webkit.org/251414@main
- 5:55 PM Changeset in webkit [295407] by
-
- 27 edits2 adds in trunk/Source
[WebAuthn] Support credProps extension and refactor extension handling
https://bugs.webkit.org/show_bug.cgi?id=241199
rdar://90281799
Reviewed by Brent Fulgham.
This patch implements the credProps Web Authentication extension specified here:
https://www.w3.org/TR/webauthn-2/#sctn-authenticator-credential-properties-extension
This extension provides information about the created credential to the relying party,
at this time this is only the resident key credential property. This is useful information
for RPs to enable passwordless flows.
The patch also refactors how we ferry extension inputs/outputs between WebKit and Authentication
Services. We now passthrough inputs and outputs as a cbor serialized blob. This is well specified
as described here: https://www.w3.org/TR/webauthn-2/#sctn-extensions-inputs-outputs
This extension is covered by the web platform test webauthn/createcredential-resident-key.https.html.
- Source/WebCore/Modules/webauthn/AuthenticationExtensionsClientInputs.cpp: Added.
(WebCore::AuthenticationExtensionsClientInputs::fromCBOR):
(WebCore::AuthenticationExtensionsClientInputs::toCBOR const):
- Source/WebCore/Modules/webauthn/AuthenticationExtensionsClientInputs.h:
- Source/WebCore/Modules/webauthn/AuthenticationExtensionsClientInputs.idl:
- Source/WebCore/Modules/webauthn/AuthenticationExtensionsClientOutputs.cpp: Added.
(WebCore::AuthenticationExtensionsClientOutputs::fromCBOR):
(WebCore::AuthenticationExtensionsClientOutputs::toCBOR const):
- Source/WebCore/Modules/webauthn/AuthenticationExtensionsClientOutputs.h:
(WebCore::AuthenticationExtensionsClientOutputs::encode const):
(WebCore::AuthenticationExtensionsClientOutputs::decode):
(WebCore::AuthenticationExtensionsClientOutputs::CredentialPropertiesOutput::encode const):
(WebCore::AuthenticationExtensionsClientOutputs::CredentialPropertiesOutput::decode):
- Source/WebCore/Modules/webauthn/AuthenticationExtensionsClientOutputs.idl:
- Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create const):
- Source/WebCore/Modules/webauthn/AuthenticatorResponse.cpp:
(WebCore::AuthenticatorResponse::tryCreate):
(WebCore::AuthenticatorResponse::data const):
- Source/WebCore/Modules/webauthn/AuthenticatorResponse.h:
- Source/WebCore/Modules/webauthn/AuthenticatorResponseData.h:
(WebCore::AuthenticatorResponseData::encode const):
(WebCore::AuthenticatorResponseData::decode):
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAssertionResponse.mm:
(-[_WKAuthenticatorAssertionResponse initWithClientDataJSON:rawId:extensionOutputsCBOR:authenticatorData:signature:userHandle:attachment:]):
- Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAssertionResponseInternal.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAttestationResponse.mm:
(-[_WKAuthenticatorAttestationResponse initWithClientDataJSON:rawId:extensionOutputsCBOR:attestationObject:attachment:transports:]):
- Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAttestationResponseInternal.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorResponse.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorResponse.mm:
(-[_WKAuthenticatorResponse initWithClientDataJSON:rawId:extensionOutputsCBOR:attachment:]):
- Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorResponseInternal.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.mm:
(-[_WKPublicKeyCredentialCreationOptions dealloc]):
- Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.mm:
(-[_WKPublicKeyCredentialRequestOptions dealloc]):
- Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(toNSData):
(+[_WKWebAuthenticationPanel convertToCoreCreationOptionsWithOptions:]):
(wkAuthenticatorAttestationResponse):
(wkAuthenticatorAssertionResponse):
(wkExtensionsClientOutputs): Deleted.
- Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.h:
- Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::processClientExtensions):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
- Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::configureRegistrationRequestContext):
(WebKit::configureAssertionOptions):
(WebKit::toExtensionOutputs):
(WebKit::continueAfterRequest):
- Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::CtapAuthenticator::continueMakeCredentialAfterResponseReceived):
Canonical link: https://commits.webkit.org/251413@main
- 5:50 PM Changeset in webkit [295406] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
[GARDENING]:Some layout tests are failing on EWS but not post commit testing due to a OS difference
https://bugs.webkit.org/show_bug.cgi?id=239564
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/251412@main
- 5:38 PM Changeset in webkit [295405] by
-
- 1 delete in trunk/LayoutTests/platform/ios/fast/events/ios/rotation/layout-viewport-during-safari-type-rotation-expected.txt
[Gardening]:[ iOS ] fast/events/ios/rotation/la yout-viewport-during-safari -type-rotation.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=231266
Unreviewed test gardening.
- LayoutTests/platform/ios/fast/events/ios/rotation/layout-viewport-during-safari-type-rotation-expected.txt: Removed.
Canonical link: https://commits.webkit.org/251411@main
- 5:36 PM Changeset in webkit [295404] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm
[Gardening]: REGRESSION (r293829): [ iOS ] TestWebKitAPI.GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCrashes is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=240692
<rdar://93611089>
Unreviewed test gardening.
I disabled API test while the issue is being investigated.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
(TEST):
Canonical link: https://commits.webkit.org/251410@main
- 5:25 PM Changeset in webkit [295403] by
-
- 1 delete in trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/webaudio
[Gardening][ BigSur+ wk2 ] imported/w3c/web-platform-t ests/webaudio/the-audio-api /the-mediaelementaudiosourc enode-interface/mediaElemen tAudioSourceToScriptProcess orTest.html is a flaky text failure
https://bugs.webkit.org/show_bug.cgi?id=221819
Unreviewed test gardening.
- LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt: Removed.
Canonical link: https://commits.webkit.org/251409@main
- 5:18 PM Changeset in webkit [295402] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r295372): [Win, WinCairo] 30 tests crash when creating ImageData
https://bugs.webkit.org/show_bug.cgi?id=241429
Reviewed by Simon Fraser.
It looks the move construct is different on Windows when we pass an xvalue
(such as WTFMove(pixelBuffer)) to a function which takes an lvalue
(such as Ref<JSC::Uint8ClampedArray> data(Ref<ByteArrayPixelBuffer>)). Or it
might be a compiler bug.
So revert the change which converted ByteArrayPixelBuffer::takeData() to
ByteArrayPixelBuffer::data() since it is not related to the fix of bug 240810.
- Source/WebCore/html/ImageData.cpp:
(WebCore::ImageData::create):
- Source/WebCore/platform/graphics/ByteArrayPixelBuffer.cpp:
(WebCore::ByteArrayPixelBuffer::data): Deleted.
- Source/WebCore/platform/graphics/ByteArrayPixelBuffer.h:
(WebCore::ByteArrayPixelBuffer::takeData):
Canonical link: https://commits.webkit.org/251408@main
- 4:50 PM Changeset in webkit [295401] by
-
- 2 edits in trunk/Tools/Scripts/libraries/webkitcorepy
Bump webkitcorepy version
Unreviewed package management.
- Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
- 4:26 PM Changeset in webkit [295400] by
-
- 1 edit in trunk/Source/WTF/wtf/CrossThreadCopier.h
WTF::CrossThreadCopierBase::copy() should use std::forward
<https://webkit.org/b/241426>
<rdar://94648592>
Reviewed by Darin Adler.
- Source/WTF/wtf/CrossThreadCopier.h:
(WTF::CrossThreadCopierBase::copy):
- Switch from WTFMove() to std::forward().
Canonical link: https://commits.webkit.org/251406@main
- 4:16 PM Changeset in webkit [295399] by
-
- 1 edit in trunk/Source/WebCore/rendering/RenderBox.h
Handle a disconnected view during applyTopLeftLocationOffset
https://bugs.webkit.org/show_bug.cgi?id=241355
<rdar://92432637>
Reviewed by Alan Bujtas.
It appears that we can sometimes end up in a state where the document's
view is disconnected during didLayout, which calls applyTopleftLocationOffset.
This just adds a null check to handle this case for now.
- Source/WebCore/rendering/RenderBox.h:
(WebCore::RenderBox::applyTopLeftLocationOffset const):
Canonical link: https://commits.webkit.org/251405@main
- 4:05 PM Changeset in webkit [295398] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm
[Gardening]: REGRESSION: [iOS] TestWebKitAPI.HSTS.ThirdParty is consistely failing
https://bugs.webkit.org/show_bug.cgi?id=241342
<rdar://94448628>
Unreviewed test gardening.
Disabling API test for iOS while the issue is being investigated.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:
Canonical link: https://commits.webkit.org/251404@main
- 3:38 PM Changeset in webkit [295397] by
-
- 2 edits in trunk/Source/WebCore/platform/mediastream/mac
Add missing includes in ScreenCaptureKit headers
https://bugs.webkit.org/show_bug.cgi?id=241440
<rdar://94669166>
Patch by Youssef Soliman <youssefdevelops@gmail.com> on 2022-06-08
Reviewed by Eric Carlson.
Two of the Mac ScreenCaptureKit headers are missing includes which
causes a build failure if the build order changes.
- Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h:
- Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.h:
Canonical link: https://commits.webkit.org/251403@main
- 3:32 PM Changeset in webkit [295396] by
-
- 4 edits in trunk
App-overridden WKScrollView deceleration is reset every time WebKit commits the layer tree
https://bugs.webkit.org/show_bug.cgi?id=241436
<rdar://problem/41019318>
Reviewed by Simon Fraser.
- Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView scrollViewWillBeginDragging:]):
- Source/WebKit/UIProcess/ios/WKScrollView.h:
- Source/WebKit/UIProcess/ios/WKScrollView.mm:
(-[WKScrollView setDecelerationRate:]):
(-[WKScrollView _setDecelerationRateInternal:]):
Like we do for many other properties, if the client sets the deceleration rate
on WKScrollView, stop overriding it internally.
- Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
(TEST):
Add an API test.
Canonical link: https://commits.webkit.org/251402@main
- 3:10 PM Changeset in webkit [295395] by
-
- 1 edit in trunk/Source/WebKitLegacy/WebKitLegacy.vcxproj/WebKitLegacy.proj
[Win] WebKitQuartzCoreAdditions.dll is not installed
https://bugs.webkit.org/show_bug.cgi?id=241430
<rdar://89637009>
Reviewed by Brent Fulgham.
WebKitQuartzCoreAdditions.dll is not copied to DSTROOT after build.
- Source/WebKitLegacy/WebKitLegacy.vcxproj/WebKitLegacy.proj:
Canonical link: https://commits.webkit.org/251401@main
- 2:23 PM Changeset in webkit [295394] by
-
- 2 edits2 adds in trunk
Allow keyboard smooth scrolling to take place in overflow:scroll regions
https://bugs.webkit.org/show_bug.cgi?id=228158
rdar://80911829
Patch by destra <destra@apple.com> on 2022-06-08
Reviewed by Tim Horton.
Test: LayoutTests/fast/scrolling/mac/keyboard-scrolling-overflow-scroll.html
Right now, keyboard smooth scrolling can only scroll the entire page and
cannot scroll overflow:scroll regions. To fix this, rather than always
obtaining ScrollingAnimator from m_frame->view(), which will only ever
scroll the whole page, the code should get ScrollingAnimator from
m_frame.document()->focusedElement() or m_mousePressNode if either one
of them is non-null, which indicates that a sub-scrollable region is
focused.
- LayoutTests/fast/scrolling/mac/keyboard-scrolling-overflow-scroll-expected.txt: Added.
- LayoutTests/fast/scrolling/mac/keyboard-scrolling-overflow-scroll.html: Added.
- Source/WebCore/page/EventHandler.cpp:
(Webcore::EventHandler::keyboardScrollingAnimatorForFocusedNode):
(WebCore::EventHandler::stopKeyboardScrolling):
(WebCore::EventHandler::startKeyboardScrolling):
- Source/WebCore/page/EventHandler.h:
Canonical link: https://commits.webkit.org/251400@main
- 2:02 PM Changeset in webkit [295393] by
-
- 1 edit in trunk/Source/WebCore/rendering/RenderImageResource.cpp
RenderImageResource::setCachedImage may produce a null renderer
https://bugs.webkit.org/show_bug.cgi?id=241435
<rdar://93714107>
Reviewed by Antti Koivisto.
This is a speculative fix to address null deref on the renderer.
- Source/WebCore/rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::setCachedImage):
Canonical link: https://commits.webkit.org/251399@main
- 1:58 PM Changeset in webkit [295392] by
-
- 1 edit in trunk/Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp
REGRESSION (250836@main): [iOS] Found text is not scrolled into view when highlighting the next/previous result
https://bugs.webkit.org/show_bug.cgi?id=241431
rdar://94584301
Reviewed by Wenson Hsieh.
250836@main switched to a model in which we update the selection asynchronously
in the case of having a non-user triggered change.
Scrolling to highlighted found text is done using TemporarySelectionChange,
which relies on selection updates being synchronous, as the previous selection
is restored once the object is destroyed.
Similar to the fix for App Highlights, included in 250836@main, treat the
selection change for scrolling to a found text range as a UserTriggered change,
so that it is performed synchronously, and the scroll actualy occurs.
This is covered by existing API tests, that are currently run on internal bots
only.
- Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp:
(WebKit::WebFoundTextRangeController::scrollTextRangeToVisible):
Canonical link: https://commits.webkit.org/251398@main
- 12:06 PM Changeset in webkit [295391] by
-
- 19 edits3 adds in trunk
Align ITP client side cookie cap with other script-writable storage
https://bugs.webkit.org/show_bug.cgi?id=240248
rdar://90468671
Reviewed by Alex Christensen.
- LayoutTests/http/tests/resourceLoadStatistics/capped-lifetime-for-cookie-set-in-js-24-hours.html: Added.
- LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration-js-cookie-checking.html: Added.
- LayoutTests/http/tests/resourceLoadStatistics/website-data-removal-for-site-without-user-interaction-js-cookie-checking.html: Added.
- LayoutTests/platform/mac-wk2/TestExpectations:
- LayoutTests/platform/wk2/TestExpectations:
Add new tests for this behavior. Skip them for now because they rely on internal bits.
This patch adds a slight behavior change for ITP with client side cookies set from a page that is a link decoration target in
that it deletes client side cookies either 24 hours after they are set OR after 7 days of no user interaction, whichever comes first.
This maintains the strictest level of privacy for client side cookies based on all heuristics.
- Source/WTF/wtf/PlatformEnableCocoa.h:
- Source/WebCore/platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::setAgeCapForClientSideCookies):
(WebCore::NetworkStorageSession::clientSideCookieCap const):
Update client-side cookie cap code to only handle the 24 hour link-decoration case now that we
no longer need the 7 day cap.
(WebCore::NetworkStorageSession::deleteCookiesForHostnames):
- Source/WebCore/platform/network/NetworkStorageSession.h:
- Source/WebCore/platform/network/cf/NetworkStorageSessionCFNetWin.cpp:
(WebCore::NetworkStorageSession::deleteCookiesForHostnames):
- Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::parseDOMCookie):
Update JS cookie code so that we mark cookies as set in javascript and can distinguish them
from server side cookies. Since there are some underlying assumptions in CFNetwork code about
NSHTTPCookie not being mutable, we need to re-create the cookie here with the JS bit set to true.
(WebCore::NetworkStorageSession::deleteCookiesForHostnames):
- Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:
(WebCore::NetworkStorageSession::deleteCookiesForHostnames):
- Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::deleteCookiesForHostnames):
- Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::merge):
(WebKit::ResourceLoadStatisticsDatabaseStore::logCrossSiteLoadWithLinkDecoration):
(WebKit::ResourceLoadStatisticsDatabaseStore::setIsScheduledForAllScriptWrittenStorageRemoval):
(WebKit::ResourceLoadStatisticsDatabaseStore::registrableDomainsToDeleteOrRestrictWebsiteDataFor):
(WebKit::ResourceLoadStatisticsDatabaseStore::setIsScheduledForAllButCookieDataRemoval): Deleted.
- Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
- Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::domainsToString):
(WebKit::ResourceLoadStatisticsStore::updateClientSideCookiesAgeCap):
(WebKit::ResourceLoadStatisticsStore::setAgeCapForClientSideCookies): Deleted.
- Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
- Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
(WebKit::RegistrableDomainsToDeleteOrRestrictWebsiteDataFor::isolatedCopy const):
(WebKit::RegistrableDomainsToDeleteOrRestrictWebsiteDataFor::isolatedCopy):
(WebKit::RegistrableDomainsToDeleteOrRestrictWebsiteDataFor::isEmpty const):
Rename "non cookie website data" to "script written storage" now that
we include client side cookies. This can't be done to the actual
database entry without a migration to a new database due to SQLite
restrictions around renames, so we will leave that one in place.
- Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
Use the values stored in domainsToDeleteAllScriptWritableStorageFor to know which domains to
delete script-writable cookies for when deleting website data, instead of just looking at domainsToDeleteAllCookiesFor.
(WebKit::NetworkProcess::setAgeCapForClientSideCookies): Deleted.
- Source/WebKit/NetworkProcess/NetworkProcess.h:
- Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
- Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::setAgeCapForClientSideCookies): Deleted.
- Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
Unused function.
Canonical link: https://commits.webkit.org/251397@main
- 11:37 AM Changeset in webkit [295390] by
-
- 1 edit in trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp
NetworkLoad audit token scope needs to match Span that points to it
https://bugs.webkit.org/show_bug.cgi?id=241422
Reviewed by Kate Cheney.
- Source/WebKit/NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::notifyDidReceiveResponse):
Canonical link: https://commits.webkit.org/251396@main
- 11:15 AM Changeset in webkit [295389] by
-
- 2 edits in trunk/Source/WTF/wtf/text
REGRESSION (251316@main): Release-configuration WTF::StringView is not usable from apps building in Debug
https://bugs.webkit.org/show_bug.cgi?id=241397
rdar://94587929
Reviewed by Alexey Proskuryakov.
251316@main / r295270 changed the logic of JavaScriptCore's scripts to generate inspector code,
such that the generated code now has a dependency on WTF::StringView. This is problematic for
configurations where an app uses these scripts to generate code then attempts to compile that
code in Debug configuration while linking against a Release-configuration WebKit stack. This
boils down to a disagreement between WTF and the app about how StringView's "underlyingString"
methods are implemented, resulting from a difference inCHECK_STRINGVIEW_LIFETIME. WTF doesn't
export StringView::underlyingStringIsValid() and StringView::setUnderlyingString(), but the
client expects to be able to link them.
Resolve this discrepancy by adjusting the implementation of these methods so that WTF always
exports symbols for these functionalities, even if they happen to be no-ops due to WTF itself
being built in Release.
- Source/WTF/wtf/text/StringView.h:
- Source/WTF/wtf/text/StringView.cpp:
(WTF::StringView::underlyingStringIsValidImpl const):
(WTF::StringView::setUnderlyingStringImpl):
(WTF::StringView::underlyingStringIsValid const): Deleted.
(WTF::StringView::setUnderlyingString): Deleted.
Canonical link: https://commits.webkit.org/251395@main
- 11:13 AM Changeset in webkit [295388] by
-
- 13 edits2 adds in trunk/Tools/Scripts
Add git-webkit squash and refactory mock git
https://bugs.webkit.org/show_bug.cgi?id=237664
rdar://90040109
This change will make the mock git support commits without setting any identifier.
mock git now will assume branch in git-repo.json will have a base commit for each branch.
Reviewed by Jonathan Bedard.
- Tools/Scripts/hooks/prepare-commit-msg: Add new env val to support adding message content
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/git-repo.json: Add a new branch for testing squash.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Make the mock more like real git, add rev-list which will resolve commits follow two dots and triple dots syntax.
(Git):
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:
(BitBucket):
(BitBucket.resolve_all_commits):
(BitBucket.commit):
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py:
(GitHub):
(GitHub.resolve_all_commits):
(GitHub.commit):
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/init.py:
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/squash.py: Added.
(Squash):
(Squash.parser):
(Squash.get_commits_hashes):
(Squash.undo_reset):
(Squash.squash_commit):
(Squash.main):
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py:
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_branches):
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:
(repository): Make sure all branch have a base commit.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/squash_unittest.py: Added.
(TestSquash):
(TestSquash.setUp):
(TestSquash.test_github_with_previous_history):
(TestSquash.test_github_without_previous_history):
(TestSquash.test_github_two_step):
(TestSquash.test_modified):
Canonical link: https://commits.webkit.org/251394@main
- 11:03 AM Changeset in webkit [295387] by
-
- 1 delete in branches/safari-7614.1.16-branch
Delete branch.
- 10:37 AM Changeset in webkit [295386] by
-
- 1 edit in trunk/Source/bmalloc/libpas/src/libpas/pas_random.h
Undo temporary libpas fix for PlayStation
https://bugs.webkit.org/show_bug.cgi?id=241425
Reviewed by Don Olmstead.
- Source/bmalloc/libpas/src/libpas/pas_random.h:
(pas_get_secure_random):
Remove ifdef, as this has now been addressed downstream.
Canonical link: https://commits.webkit.org/251393@main
- 10:23 AM Changeset in webkit [295385] by
-
- 3 edits2 adds in trunk
REGRESSION(r295200): Avoid style update when resolving container queries in other frames
https://bugs.webkit.org/show_bug.cgi?id=241409
<rdar://94536162>
Reviewed by Alan Bujtas.
- LayoutTests/fast/css/container-query-style-recursion-expected.txt: Added.
- LayoutTests/fast/css/container-query-style-recursion.html: Added.
- Source/WebCore/dom/Document.cpp:
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::isResolvingContainerQueriesForSelfOrAncestor const):
Also check ancestors.
- Source/WebCore/dom/Document.h:
- Source/WebCore/page/FrameViewLayoutContext.cpp:
(WebCore::FrameViewLayoutContext::performLayout):
Canonical link: https://commits.webkit.org/251392@main
- 10:22 AM Changeset in webkit [295384] by
-
- 10 edits in trunk
AX: Update the isolated tree in response to dynamic aria-valuemin, aria-valuemax, and aria-multiselectable changes
https://bugs.webkit.org/show_bug.cgi?id=241394
Reviewed by Chris Fleizach.
Add testcases to accessibility/aria-multiselectable-grid.html
and aria-slider-value.html to cover these changes.
- LayoutTests/accessibility/aria-multiselectable-grid-expected.txt:
- LayoutTests/accessibility/aria-multiselectable-grid.html:
- LayoutTests/accessibility/aria-slider-value-expected.txt:
- LayoutTests/accessibility/aria-slider-value.html:
- LayoutTests/platform/ios/TestExpectations:
Enable aria-slider-value.html on iOS.
- Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
- Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
- Source/WebCore/accessibility/AXObjectCache.h:
- Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
- Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperty):
Canonical link: https://commits.webkit.org/251391@main
- 10:20 AM Changeset in webkit [295383] by
-
- 1 edit in branches/safari-7614.1.16-branch/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm
Cherry-pick r295254. rdar://problem/94314081
Regression (r294405): missing tiles during scrolling after foregrounding app
https://bugs.webkit.org/show_bug.cgi?id=241280
Reviewed by Chris Dumez.
Partially revert r294405 to disable ProcessStateMonitor that can make UI process fail to take foreground assertion after
app is foregrounded.
- Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm: (-[WKProcessAssertionBackgroundTaskManager init]): (-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):
Canonical link: https://commits.webkit.org/251302@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:31 AM Changeset in webkit [295382] by
-
- 1 edit in trunk/Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp
REGRESSION(247105@main): Set protections on MAP_ALIGNED platforms too
https://bugs.webkit.org/show_bug.cgi?id=241386
Patch by Leonardo Taccari <leot@NetBSD.org> on 2022-06-08
Reviewed by Yusuke Suzuki.
Since the introduction of tryReserveUncommittedAligned() on platforms
that have MAP_ALIGNED via 247105@main, reserved pages via that
function never had the protections adjusted and will likely ends
up in SIGSEGV.
- Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp:
(WTF::OSAllocator::tryReserveUncommittedAligned):
Canonical link: https://commits.webkit.org/251390@main
- 8:50 AM Changeset in webkit [295381] by
-
- 2 edits in trunk/Source
Add NetBSD support for MachineContext
https://bugs.webkit.org/show_bug.cgi?id=241125
Patch by Leonardo Taccari <leot@NetBSD.org> on 2022-06-08
Reviewed by Yusuke Suzuki.
- Source/JavaScriptCore/runtime/MachineContext.h:
(JSC::MachineContext::stackPointerImpl):
(JSC::MachineContext::framePointerImpl):
(JSC::MachineContext::instructionPointerImpl):
(JSC::MachineContext::argumentPointer<1>):
(JSC::MachineContext::llintInstructionPointer):
- Source/WTF/wtf/PlatformHave.h:
Canonical link: https://commits.webkit.org/251389@main
- 8:19 AM Changeset in webkit [295380] by
-
- 1 edit in trunk/.github/CODEOWNERS
[Github] Code owner hints for GStreamer-related reviews
https://bugs.webkit.org/show_bug.cgi?id=241412
Patch by Philippe Normand <philn@igalia.com> on 2022-06-08
Reviewed by Jonathan Bedard.
- .github/CODEOWNERS: Hints for GStreamer-specific folders.
Canonical link: https://commits.webkit.org/251388@main
- 6:26 AM Changeset in webkit [295379] by
-
- 1 edit in trunk/Tools/flatpak/flatpakutils.py
[Flatpak SDK] Bump to clang 14
https://bugs.webkit.org/show_bug.cgi?id=241411
Patch by Philippe Normand <philn@igalia.com> on 2022-06-08
Reviewed by Adrian Perez de Castro.
The llvm14 extension recently appeared on Flathub. We already use clangd-14 so now both the compiler
and LSP server are on the same base.
- Tools/flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
(WebkitFlatpak._get_dependency_packages):
Canonical link: https://commits.webkit.org/251387@main
- 12:53 AM Changeset in webkit [295378] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm
Unreviewed build fix after r295376
https://bugs.webkit.org/show_bug.cgi?id=241406
- Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:
Canonical link: https://commits.webkit.org/251386@main
- 12:26 AM Changeset in webkit [295377] by
-
- 2 edits in trunk/Source/JavaScriptCore/runtime
[JSC] Clean up ArrayBufferContents
https://bugs.webkit.org/show_bug.cgi?id=241368
Reviewed by Mark Lam.
This patch simplifies ArrayBufferContents by using default member initializers and swap function.
- Remove ArrayBufferContents::destroy since it is no longer necessary.
- Move some of very small functions to header.
- Use swap function and default member initializers to implement move assignment operator and move constructor.
- Use non-Packed members. Originally it was effective since m_sizeInBytes was
unsigned. But now, it issize_t, so usingPackeddoes not save memory. - Remove ArrayBufferContents::transferTo since move constructor can do the same thing.
- Remove ArrayBufferContents::clear since it is no longer used.
- Source/JavaScriptCore/runtime/ArrayBuffer.cpp:
(JSC::ArrayBufferContents::transferTo):
(JSC::ArrayBuffer::ArrayBuffer):
(JSC::SharedArrayBufferContents::SharedArrayBufferContents): Deleted.
(JSC::SharedArrayBufferContents::~SharedArrayBufferContents): Deleted.
(JSC::ArrayBufferContents::ArrayBufferContents): Deleted.
(JSC::ArrayBufferContents::operator=): Deleted.
(JSC::ArrayBufferContents::~ArrayBufferContents): Deleted.
(JSC::ArrayBufferContents::clear): Deleted.
(JSC::ArrayBufferContents::destroy): Deleted.
(JSC::ArrayBufferContents::reset): Deleted.
- Source/JavaScriptCore/runtime/ArrayBuffer.h:
(JSC::SharedArrayBufferContents::data const): Deleted.
(JSC::ArrayBufferContents::operator bool): Deleted.
(JSC::ArrayBufferContents::data const): Deleted.
(JSC::ArrayBufferContents::dataWithoutPACValidation const): Deleted.
(JSC::ArrayBufferContents::sizeInBytes const): Deleted.
(JSC::ArrayBufferContents::isShared const): Deleted.
(JSC::ArrayBuffer::sharingMode const): Deleted.
(JSC::ArrayBuffer::isDetached): Deleted.
(JSC::ArrayBuffer::detachingWatchpointSet): Deleted.
(JSC::ArrayBuffer::offsetOfData): Deleted.
(JSC::ArrayBuffer::~ArrayBuffer): Deleted.
Canonical link: https://commits.webkit.org/251385@main
