Context Navigation

← Previous Period
Next Period →

Timeline

Jun 10, 2022:

11:23 PM Changeset in webkit [295473] by achristensen@apple.com

2 edits in trunk

CORS checks shouldn't unblock cookies
https://bugs.webkit.org/show_bug.cgi?id=241527

Reviewed by Brent Fulgham.

If cookies have been blocked, a request that has been made with {credentials: 'include'} shouldn't un-block the cookies.

Source/WebCore/loader/CrossOriginAccessControl.cpp:

(WebCore::updateRequestForAccessControl):

Tools/TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:

(TEST_F):

Canonical link: https://commits.webkit.org/251478@main

10:34 PM Changeset in webkit [295472] by Alan Bujtas

7 edits
2 adds in trunk

Repaint rect does not take into account text-underline-offset
https://bugs.webkit.org/show_bug.cgi?id=241442

Reviewed by Antti Koivisto.

This patch add support for text decoration ink overflow (IFC).

Collect decoration ink overflow (logical)
Update display box ink overflow (visual)

Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::build):
(WebCore::Layout::InlineDisplayContentBuilder::collectInkOverflowForInlineBoxes):
(WebCore::Layout::visualBottomForTextDecorationContent):
(WebCore::Layout::InlineDisplayContentBuilder::collectInkOverflowForTextDecorations):

Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
Source/WebCore/style/InlineTextBoxStyle.cpp:

(WebCore::visualOverflowForDecorations):
(WebCore::defaultGap):

Source/WebCore/style/InlineTextBoxStyle.h:

Canonical link: https://commits.webkit.org/251477@main

7:44 PM Changeset in webkit [295471] by Diego Pino Garcia

1 edit in trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py

[webkit-patch] Format patch without version signature
https://bugs.webkit.org/show_bug.cgi?id=240516

Reviewed by Jonathan Bedard.

By default 'git-format-patch' adds a signature at the bottom of a diff
patch with Git version number, which the DiffParser wrongly interprets as
a patch chunk.

Tools/Scripts/webkitpy/common/checkout/scm/git.py: Use knob '--no-signature' to emit patch without signature.

Canonical link: https://commits.webkit.org/251476@main

6:33 PM Changeset in webkit [295470] by Jonathan Bedard

5 edits in trunk/Tools/Scripts/libraries/webkitscmpy

[git-webkit] Make the default rebase behavior for git-webkit pr configurable
https://bugs.webkit.org/show_bug.cgi?id=239385
<rdar://problem/91811534>

Reviewed by Dewei Zhu.

Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:

(PullRequest.main): Check the webkitscmpy.auto-rebase-branch option to determine
if we should automatically rebase the branch.

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:

(Setup.git): Prompt user to set the automatic rebase behavior.

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:

Canonical link: https://commits.webkit.org/251475@main

5:35 PM Changeset in webkit [295469] by Jonathan Bedard

1 delete in trunk/Tools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl

[webkitperl] Remove ChangeLog test
https://bugs.webkit.org/show_bug.cgi?id=241481

Reviewed by Aakash J.

Tools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Removed.

Canonical link: https://commits.webkit.org/251474@main

4:26 PM Changeset in webkit [295468] by Wenson Hsieh

2 edits in trunk

[iOS] Specifying spellcheck="false" on a contentEditable element should suppress platform spellchecking
https://bugs.webkit.org/show_bug.cgi?id=241514
rdar://91123300

Reviewed by Devin Rousso.

Additionally set -[UITextInputTraits spellCheckingType] to UITextSpellCheckingTypeNo when
focusing editable fields with the DOM attribute spellcheck="false". This provides a hint to UIKit
that system spellchecking should be disabled when editing this field - among other things, this
allows us to avoid showing text candidates in the case where autocorrect="off" is additionally
specified.

If either spellcheck="true" is set or spellcheck is not specified, we fall back to the user's
preference by using UITextSpellCheckingTypeDefault.

Test: KeyboardInputTests.DisableSpellChecking

Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _updateTextInputTraits:]):

Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/251473@main

4:10 PM Changeset in webkit [295467] by Jonathan Bedard

2 edits in trunk/Tools/CISupport/ews-build

[EWS] Remove extra space from GitHub PR description links
https://bugs.webkit.org/show_bug.cgi?id=241522
<rdar://problem/94842283>

Reviewed by Ryan Haddad.

Tools/CISupport/ews-build/steps.py:

(UpdatePullRequest): Port changes from 250718@main to EWS.
(UpdatePullRequest.escape_html):

Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/251472@main

3:45 PM Changeset in webkit [295466] by yurys@chromium.org

1 edit in trunk/Source/WebKit/UIProcess/WebPageProxy.h

Unified build: error: reference to 'FontInfo' is ambiguous
https://bugs.webkit.org/show_bug.cgi?id=241524

Reviewed by Darin Adler.

Fix unified build error.

Source/WebKit/UIProcess/WebPageProxy.h: removed unused forward declaration.

It may cause name clash with ::FontInfo (from QD.framework/Headers/Quickdraw.h)
on Mac when this file is included into the same unified source as another .cpp
file declaring 'using namespace WebKit;'.

Canonical link: https://commits.webkit.org/251471@main

3:13 PM Changeset in webkit [295465] by Adrian Perez de Castro

1 edit in releases/WebKitGTK/webkit-2.36/Source/WebCore/rendering/RenderBox.h

Merge r295399 - Handle a disconnected view during applyTopLeftLocationOffset
https://bugs.webkit.org/show_bug.cgi?id=241355
<rdar://92432637>

Reviewed by Alan Bujtas.

It appears that we can sometimes end up in a state where the document's
view is disconnected during didLayout, which calls applyTopleftLocationOffset.
This just adds a null check to handle this case for now.

Source/WebCore/rendering/RenderBox.h:

(WebCore::RenderBox::applyTopLeftLocationOffset const):

Canonical link: https://commits.webkit.org/251405@main

2:49 PM Changeset in webkit [295464] by Wenson Hsieh

34 edits in trunk

Update TBA API availability macros for iOS 16 and macOS Ventura
https://bugs.webkit.org/show_bug.cgi?id=241482
rdar://94651561

Reviewed by Tim Horton.

Update WK_MAC_TBA and WK_IOS_TBA macros to 13.0 and 16.0, respectively.

Source/WebKit/Shared/API/Cocoa/WKMain.h:
Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h:
Source/WebKit/UIProcess/API/Cocoa/WKError.h:
Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h:
Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h:

Mark these two API properties as available since macOS 12.3 and iOS 15.4. These were first
introduced in these respective macOS and iOS versions, but with incorrect availability macros
indicating that they were available since 12.0 and 15.0.

Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
Source/WebKit/UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:
Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:

Also, mark setMinimumViewportInset:maximumViewportInset:, minimumViewportInset, and
maximumViewportInset as being available since iOS 15.5.

Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:

(-[WKWebView _dataTaskWithRequest:completionHandler:]):

Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferencesPrivate.h:
Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:
Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
Source/WebKit/UIProcess/API/Cocoa/_WKApplicationManifest.h:
Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorSelectionCriteria.h:
Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.h:
Source/WebKit/UIProcess/API/Cocoa/_WKContentRuleListAction.h:
Source/WebKit/UIProcess/API/Cocoa/_WKDataTask.h:
Source/WebKit/UIProcess/API/Cocoa/_WKDataTaskDelegate.h:
Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h:
Source/WebKit/UIProcess/API/Cocoa/_WKModalContainerInfo.h:
Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
Source/WebKit/UIProcess/API/Cocoa/_WKResidentKeyRequirement.h:
Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferences.h:
Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h:
Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInCSSStyleDeclarationHandle.h:
Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:
Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
Tools/Scripts/webkitpy/common/version_name_map.py:

(VersionNameMap.init):

Canonical link: https://commits.webkit.org/251470@main

2:44 PM Changeset in webkit [295463] by Devin Rousso

1 edit in trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp

Add PaymentHandler reference when validating the merchant
https://bugs.webkit.org/show_bug.cgi?id=241520
<rdar://problem/94609087>

Reviewed by Wenson Hsieh.

Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::completeMerchantValidation):

Canonical link: https://commits.webkit.org/251469@main

2:22 PM Changeset in webkit [295462] by Tyler Wilcock

2 edits in trunk/Tools/CISupport/build-webkit-org

Add post-commit build to run accessibility isolated tree mode layout tests
https://bugs.webkit.org/show_bug.cgi?id=235125

Reviewed by Aakash Jain.

Patch co-author is Aakash Jain.

Tools/CISupport/build-webkit-org/config.json:
Tools/CISupport/build-webkit-org/factories_unittest.py:

(TestExpectedBuildSteps):

Canonical link: https://commits.webkit.org/251468@main

1:36 PM Changeset in webkit [295461] by mmaxfield@apple.com

3 edits in trunk/Source

Adopt EnumeratedArray in SystemFontDatabase
https://bugs.webkit.org/show_bug.cgi?id=241506

Reviewed by Cameron McCormack.

This is why we created EnumeratedArray in the first place.

Source/WebCore/platform/graphics/SystemFontDatabase.cpp:

(WebCore::SystemFontDatabase::systemFontShorthandInfo const):

Source/WebCore/platform/graphics/SystemFontDatabase.h:

Canonical link: https://commits.webkit.org/251467@main

1:23 PM Changeset in webkit [295460] by dino@apple.com

1 edit in trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm

Safari crashes anytime any web links on a webpage are clicked on
https://bugs.webkit.org/show_bug.cgi?id=241500
rdar://94655829

Reviewed by Tim Horton.

In some VM scenarios, IOSurfaceAccelerator is not available, which
causes a crash when navigating (creating the back-forward images).
The solution is to check for null after attempting to create the
accelerator.

Source/WebCore/platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::convertToFormat): Add a null check and bail.

Canonical link: https://commits.webkit.org/251466@main

12:01 PM Changeset in webkit [295459] by caitp@igalia.com

5 edits in trunk/Source

[Shadow Realms] Add feature flag to enable Exposed=* web APIs in ShadowRealms
https://bugs.webkit.org/show_bug.cgi?id=241448

Reviewed by Yusuke Suzuki.

No longer expose Web APIs to ShadowRealm by default. Instead, we
enable this with a new setting WebAPIsInShadowRealmEnabled.

Because the HTML integration aspect of the specification is still in the
air, it's prudent to disable it by default, while still providing a
feature flag for web-platform-tests.

Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
Source/WebCore/bindings/scripts/preprocess-idls.pl:

(GenerateConstructorAttributes):

Source/WebCore/bindings/scripts/test/JS/JSShadowRealmGlobalScope.cpp:

(WebCore::JSShadowRealmGlobalScope::finishCreation):

Source/WebCore/bindings/scripts/test/ShadowRealmGlobalScopeConstructors.idl:

Canonical link: https://commits.webkit.org/251465@main

11:50 AM Changeset in webkit [295458] by Alan Bujtas

1 edit in trunk/Source/WebCore/style/InlineTextBoxStyle.cpp

Remove redundant OptionSet<TextDecorationLine> in InlineTextBoxStyle functions
https://bugs.webkit.org/show_bug.cgi?id=241499

Reviewed by Antti Koivisto.

Source/WebCore/style/InlineTextBoxStyle.cpp:

(WebCore::minLogicalTopForTextDecorationLine):
(WebCore::maxLogicalBottomForTextDecorationLine):
(WebCore::enclosingRendererWithTextDecoration):
(WebCore::textRunLogicalOffsetFromLineBottom):

Canonical link: https://commits.webkit.org/251464@main

11:19 AM Changeset in webkit [295457] by commit-queue@webkit.org

1 edit in trunk/Source/WebCore/dom/Document.cpp

Special case bitmap renderers in Document::getCSSCanvasContext
https://bugs.webkit.org/show_bug.cgi?id=241505

Patch by Rob Buis <rbuis@igalia.com> on 2022-06-10
Reviewed by Alex Christensen.

Special case bitmap renderers in Document::getCSSCanvasContext.

Source/WebCore/dom/Document.cpp:

(WebCore::Document::getCSSCanvasContext):

Canonical link: https://commits.webkit.org/251463@main

10:29 AM Changeset in webkit [295456] by Brent Fulgham

2 edits in trunk

[ macOS ][ iOS ] TestWebKitAPI.SOAuthorizationSubFrame.InterceptionError is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=241421
<rdar://problem/94641397>

Reviewed by Kate Cheney.

This test was timing out for the same reason as SOAuthorizationSubFrame.InterceptionErrorWithReferrer,
which Pascoe fixed in Bug 239311.

This change modifies all 'waitForMessage'-based tests to use the message listener delegate to
avoid the race conditions identified. I also changed the method swizzling code to remove
a bunch of copy/paste code that had to be kept in sync.

With these changes I can run the tests 1000 times on simulator without a timeout.

Source/WebKit/UIProcess/Cocoa/SOAuthorization/WKSOAuthorizationDelegate.mm:

(-[WKSOAuthorizationDelegate authorization:didCompleteWithError:]): Only emit an error log message
when there is an actual error. We pass through this flow in normal cases where a site wants to
use the web fallback instead of AppSSO based on user input.

Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:

(-[TestSOAuthorizationScriptMessageHandler extendExpectations:]):
(-[TestSOAuthorizationScriptMessageHandler resetExpectations:]):
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/251462@main

10:09 AM Changeset in webkit [295455] by Alan Bujtas

3 edits in trunk/Source/WebCore

Should be able to compute decoration overflow without InlineIterator::TextBoxIterator
https://bugs.webkit.org/show_bug.cgi?id=241490

Reviewed by Antti Koivisto.

This patch enables IFC codebase to compute visual overflow for decoration (even when TextBoxIterator is not available).

Source/WebCore/rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeAffectsVisualOverflow const):

Source/WebCore/style/InlineTextBoxStyle.cpp:

(WebCore::visualOverflowForDecorations):

Source/WebCore/style/InlineTextBoxStyle.h:

Canonical link: https://commits.webkit.org/251461@main

9:13 AM Changeset in webkit [295454] by commit-queue@webkit.org

2 edits in trunk/Source

[GLib] Validate proxy URLs passed to WebKitNetworkProxySettings
https://bugs.webkit.org/show_bug.cgi?id=241485

Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-06-10
Reviewed by Philippe Normand.

Validate that users pass only valid URLs to these APIs.

Source/WTF/wtf/URL.h: Opportunistic typo fix.
Source/WebKit/UIProcess/API/glib/WebKitNetworkProxySettings.cpp:

(webkit_network_proxy_settings_new):
(webkit_network_proxy_settings_add_proxy_for_scheme):

Canonical link: https://commits.webkit.org/251460@main

8:19 AM Changeset in webkit [295453] by Alan Bujtas

3 edits in trunk/Source/WebCore

computeUnderlineOffset should not take InlineIterator::LineBoxIterator
https://bugs.webkit.org/show_bug.cgi?id=241488

Reviewed by Antti Koivisto.

Let's precompute the text run's offset value so that we don't have to pass in a LineBoxIterator to computeUnderlineOffset.

Source/WebCore/rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::paintBackgroundDecorations):

Source/WebCore/style/InlineTextBoxStyle.cpp:

(WebCore::textRunLogicalOffsetFromLineBottom):
(WebCore::computeUnderlineOffset):
(WebCore::visualOverflowForDecorations):

Source/WebCore/style/InlineTextBoxStyle.h:

Canonical link: https://commits.webkit.org/251459@main

8:11 AM Changeset in webkit [295452] by pvollan@apple.com

1 edit in trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

Disable URL scheme check in Data Detectors for all clients
https://bugs.webkit.org/show_bug.cgi?id=241273

Reviewed by Geoffrey Garen.

We are seeing telmetry where also Web browser clients are attempting to connect to Launch Services when data detection
is trying to find an application to handle a URL with a custom scheme. Since Launch Services is blocked in the sandbox,
the WebContent process will be unable to determine if there is an application that can open this URL, and the link will
not be clickable. This can be addressed by disabling the URL scheme check in Data Detectors for all clients.

Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/251458@main

7:51 AM Changeset in webkit [295451] by Patrick Angle

6 edits in trunk

WebDriver: [Cocoa] Regression(r290743) Automated mouse movement does not result in JS mouse event being fired
https://bugs.webkit.org/show_bug.cgi?id=241484
rdar://94026001

Reviewed by Devin Rousso.

r290743 changed WKWebView on macOS to no longer forward NSEventTypeMouseMoved events to the underlying view
implementation since it does its own mouse tracking. Unfortuantely, this means that WebDriver on Cocoa platforms can not
just dispatch an event to the window and have that event reach the WKWebView's underlying view implementation. This
change was made because events for genuine cursor movement were being received twice by the underlying view previously.
We need to explicitly tell the underlying view about automated mouse movements (as well as the NSWindow to maintain any
existing behavior caused by the mouse move event being sent to the window).

This patch was verified by comparing WPT test results for tests in /webdriver/tests/perform_actions and
/webdriver/tests/release_actions and ensuring that results now match Safari 15.5 again, which does not have the
regressing change included.

Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:

(-[WKWebView _simulateMouseMove:]):

Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm:

(-[WKWebView _simulateMouseMove:]): Deleted.

Move _simulateMouseMove to be private instead of private for testing.

Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::WebAutomationSession::sendSynthesizedEventsToPage):

For mouse move events, make sure the view implementation receives the events.

Tools/WebKitTestRunner/mac/EventSenderProxy.mm:

Canonical link: https://commits.webkit.org/251457@main

5:26 AM Changeset in webkit [295450] by Alan Bujtas

1 edit in trunk/Source/WebCore/style/InlineTextBoxStyle.cpp

minLogicalTopForTextDecorationLine/maxLogicalBottomForTextDecorationLine should return the min/max value
https://bugs.webkit.org/show_bug.cgi?id=241474

Reviewed by Antti Koivisto.

This improves readability and also a preparation for making decoration visual overflow work with IFC.

Source/WebCore/style/InlineTextBoxStyle.cpp:

(WebCore::minLogicalTopForTextDecorationLine):
(WebCore::maxLogicalBottomForTextDecorationLine):
(WebCore::computeUnderlineOffset):

Canonical link: https://commits.webkit.org/251456@main

2:37 AM Changeset in webkit [295449] by commit-queue@webkit.org

60 edits
2 adds in trunk

Enable WasmLLInt on ARMv7

Patch by Geza Lore <Geza Lore> on 2022-06-10
Patch by Geza Lore <Geza Lore> on 2022-05-27
https://bugs.webkit.org/show_bug.cgi?id=221260

Reviewed by Saam Barati.

Patch by Geza Lore and Xan López.

Implement the LLInt tier of WebAssembly for ARMv7. A lot of the
work will be shared by any 32bit port, but the offlineassembler
has only been updated for ARMv7 so far.

Main highlights:

We have split the WebAssembly.asm file into three chunks,
following what LowLevelInterpreter.asm does. The common code
remains in WebAssembly.asm, and 32 and 64bit specific code (mostly
opcode implementations) goes into WebAssembly32_64.asm and
WebAssembly64.asm.

We have decided to use consecutive even/odd pairs of GPRs for every
type of wasm values, even if they are 32bit (i32/f32), with the odd
(higher) numbered GPR holding the more significant half. 32bit values
are held in the even (lower) numbered register. This makes the code
much simpler and allows us to share more code with the 64bit variant.
This is mostly relevant for argument passing, and given that every
value ends up in the stack anyway we do not think it is significant
from a performance POV.

We are reusing JSValueRegs to hold Wasm values too. Obviously they
are not really JSValues, so it might make sense to create a base
class that can be used for both JS and Wasm values.

We do not have enough registers to keep things like the memory
base pointer and size in pinned registers, so we are forced to
load them on each use.

We disable the 'Signaling' memory mode, since the current
implementation relies on being able to mprotect a 2^{32 + redzone

region of memory. This can be changed in the future but it's not a

priority at the moment.}

stress/sampling-profiler-wasm-name-section.js:
stress/sampling-profiler-wasm.js:
wasm/regress/llint-callee-saves-with-fast-memory.js:
CMakeLists.txt:
assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::vcvt_signedToFloatingPoint):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::convertInt32ToFloat):
(JSC::MacroAssemblerARMv7::threadSafePatchableNearCall):
(JSC::MacroAssemblerARMv7::callOperation):

b3/B3ValueRep.h:

(JSC::B3::ValueRep::ValueRep):

bytecode/BytecodeDumper.cpp:

(JSC::Wasm::BytecodeDumper::formatConstant const):

interpreter/CallFrame.h: adapt to new callee tagging format.

(JSC::CallFrame::callee const):
(JSC::CallFrame::unsafeCallee const):

interpreter/CalleeBits.h: add wasm tagging of callee values for

32bit.
(JSC::CalleeBits::CalleeBits):
(JSC::CalleeBits::operator=):
(JSC::CalleeBits::boxWasm):
(JSC::CalleeBits::isWasm const):
(JSC::CalleeBits::asWasmCallee const):

interpreter/Register.h:

(JSC::Register::unboxedFloat const):
(JSC::Register::asanUnsafeUnboxedFloat const):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::unboxDouble):

jit/RegisterAtOffsetList.cpp:

(JSC::RegisterAtOffsetList::RegisterAtOffsetList):

jit/RegisterAtOffsetList.h:

(JSC::RegisterAtOffsetList::sizeOfAreaInBytes const):

jit/RegisterSet.cpp:

(JSC::RegisterSet::macroScratchRegisters):

llint/LowLevelInterpreter32_64.asm:
llint/WebAssembly.asm:
llint/WebAssembly32_64.asm: Added.
llint/WebAssembly64.asm: Added.
offlineasm/arm.rb:
offlineasm/instructions.rb:
offlineasm/registers.rb:
offlineasm/risc.rb:
runtime/JSCJSValue.h:

(JSC::wasmUnboxedFloat):

runtime/JSCJSValueInlines.h:

(JSC::JSValue::JSValue):

wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::useSignalingMemory const):
(JSC::Wasm::AirIRGenerator::AirIRGenerator):
(JSC::Wasm::AirIRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::AirIRGenerator::addCall):

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::useSignalingMemory const):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::addArguments):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::memoryKind):
(JSC::Wasm::B3IRGenerator::addCall):

wasm/WasmBinding.cpp:

(JSC::Wasm::wasmToWasm):

wasm/WasmCallee.cpp:

(JSC::Wasm::LLIntCallee::calleeSaveRegisters):

wasm/WasmCalleeGroup.cpp:

(JSC::Wasm::CalleeGroup::isSafeToRun):

wasm/WasmCallingConvention.cpp:

(JSC::Wasm::jsCallingConvention):
(JSC::Wasm::wasmCallingConvention):

wasm/WasmCallingConvention.h:

(JSC::Wasm::CallInformation::computeResultsOffsetList):
(JSC::Wasm::WasmCallingConvention::WasmCallingConvention):
(JSC::Wasm::WasmCallingConvention::marshallLocationImpl const):
(JSC::Wasm::WasmCallingConvention::marshallLocation const):
(JSC::Wasm::JSCallingConvention::JSCallingConvention):
(JSC::Wasm::JSCallingConvention::marshallLocationImpl const):
(JSC::Wasm::JSCallingConvention::marshallLocation const):
(JSC::Wasm::JSCallingConvention::callInformationFor const):

wasm/WasmFormat.h:
wasm/WasmIndexOrName.cpp:

(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::makeString):

wasm/WasmIndexOrName.h:

(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::IndexOrName::isEmpty const):
(JSC::Wasm::IndexOrName::isIndex const):
(JSC::Wasm::IndexOrName::isName const):
(JSC::Wasm::IndexOrName::index const):
(JSC::Wasm::IndexOrName::name const):
(JSC::Wasm::IndexOrName::nameSection const):

wasm/WasmInstance.h:

(JSC::Wasm::Instance::updateCachedMemory):

wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::virtualRegisterForWasmLocal):
(JSC::Wasm::LLIntGenerator::callInformationForCaller):
(JSC::Wasm::LLIntGenerator::callInformationForCallee):
(JSC::Wasm::LLIntGenerator::addArguments):
(JSC::Wasm::LLIntGenerator::addLoop):

wasm/WasmLLIntPlan.cpp:

(JSC::Wasm::LLIntPlan::didCompleteCompilation):

wasm/WasmMemory.cpp:

(JSC::Wasm::MemoryHandle::~MemoryHandle):
(JSC::Wasm::Memory::tryCreate):
(JSC::Wasm::Memory::growShared):
(JSC::Wasm::Memory::grow):
(JSC::Wasm::Memory::copy):

wasm/WasmMemory.h:
wasm/WasmMemoryInformation.cpp:

(JSC::Wasm::PinnedRegisterInfo::get):

wasm/WasmMemoryInformation.h:

(JSC::Wasm::PinnedRegisterInfo::toSave const):

wasm/WasmMemoryMode.cpp:

(JSC::Wasm::makeString):

wasm/WasmMemoryMode.h:
wasm/WasmOpcodeOrigin.cpp:
wasm/WasmOpcodeOrigin.h:
wasm/WasmOperations.cpp:

(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):

wasm/WasmOperations.h:
wasm/WasmPageCount.h:
wasm/WasmParser.h:

(JSC::Wasm::Parser<SuccessType>::parseUInt32):
(JSC::Wasm::Parser<SuccessType>::parseUInt64):

wasm/WasmSlowPaths.cpp:

(JSC::LLInt::WASM_SLOW_PATH_DECL):
(JSC::LLInt::slow_path_wasm_popcount):
(JSC::LLInt::slow_path_wasm_popcountll):
(JSC::LLInt::slow_path_wasm_i32_div_s):
(JSC::LLInt::slow_path_wasm_i32_div_u):
(JSC::LLInt::slow_path_wasm_i32_rem_s):
(JSC::LLInt::slow_path_wasm_i32_rem_u):
(JSC::LLInt::slow_path_wasm_i64_div_s):
(JSC::LLInt::slow_path_wasm_i64_div_u):
(JSC::LLInt::slow_path_wasm_i64_rem_s):
(JSC::LLInt::slow_path_wasm_i64_rem_u):

wasm/WasmSlowPaths.h:
wasm/WasmValueLocation.cpp:

(JSC::Wasm::ValueLocation::dump const):
(WTF::printInternal):

wasm/WasmValueLocation.h:

(JSC::Wasm::ValueLocation::ValueLocation):
(JSC::Wasm::ValueLocation::isGPR const):
(JSC::Wasm::ValueLocation::isFPR const):
(JSC::Wasm::ValueLocation::isStack const):
(JSC::Wasm::ValueLocation::isStackArgument const):
(JSC::Wasm::ValueLocation::jsr const):
(JSC::Wasm::ValueLocation::fpr const):
(JSC::Wasm::ValueLocation::reg): Deleted.
(JSC::Wasm::ValueLocation::isReg const): Deleted.
(JSC::Wasm::ValueLocation::reg const): Deleted.
(JSC::Wasm::ValueLocation::gpr const): Deleted.

wasm/js/JSToWasm.cpp:

(JSC::Wasm::marshallJSResult):
(JSC::Wasm::createJSToWasmWrapper):

wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::previousInstanceOffset const):
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

wasm/js/WebAssemblyGlobalConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::initializeExports):

wtf/PlatformEnable.h: enable WebAssembly on ARMv7.
Scripts/run-jsc-stress-tests: allow to run the wasm tests on

armv7 even without jit support (for now).

Canonical link: https://commits.webkit.org/251455@main

1:04 AM Changeset in webkit [295448] by Nikos Mouchtaris

8 edits
2 adds in trunk

REGRESSION: CSS scroll-behavior: smooth with overflow: hidden breaks JS scrollTo/scrollLeft/scrollTop
https://bugs.webkit.org/show_bug.cgi?id=238497
<rdar://90990040>

Reviewed by Simon Fraser.

Add scrollable area to frame view's list of scrollable areas if necessary in scrollToOffset.
This is necessary as Document::runScrollSteps() looks through the list of scrollable areas
to service animations on the scrollable area. It is necessary to add the scrollable area
in scrollToOffset as for a scrollable area that is not user scrollable (such as a scrollable
area with overflow: hidden) it would not be added, so the animation would not occur.

LayoutTests/fast/scrolling/smooth-scroll-with-overflow-hidden-expected.txt: Added.
LayoutTests/fast/scrolling/smooth-scroll-with-overflow-hidden.html: Added.
Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const):

Source/WebCore/platform/ScrollableArea.h:

(WebCore::ScrollableArea::isVisibleToHitTesting const):

Source/WebCore/rendering/RenderLayerScrollableArea.cpp:

(WebCore::RenderLayerScrollableArea::clear):
(WebCore::RenderLayerScrollableArea::scrollToOffset):
(WebCore::RenderLayerScrollableArea::isVisibleToHitTesting const):
(WebCore::RenderLayerScrollableArea::updateScrollableAreaSet):
(WebCore::RenderLayerScrollableArea::registerScrollableArea):

Source/WebCore/rendering/RenderLayerScrollableArea.h:

Canonical link: https://commits.webkit.org/251454@main

Jun 9, 2022:

11:29 PM Changeset in webkit [295447] by mmaxfield@apple.com

3 edits
2 adds in trunk

Add EnumeratedArray type
https://bugs.webkit.org/show_bug.cgi?id=241451

Reviewed by Cameron McCormack.

This is an std::array where the indices of the array are values of an enum (rather than a size_t).
This assumes the values of the enum start at 0 and monotonically increase by 1
(so the conversion function between size_t and the enum is just a simple static_cast).

EnumeratedArray includes almost all of the functions from std::array, except for a few which I
intentionally omitted.

Source/WTF/WTF.xcodeproj/project.pbxproj:
Source/WTF/wtf/EnumeratedArray.h: Added.

(WTF::EnumeratedArray::EnumeratedArray):
(WTF::EnumeratedArray::operator=):
(WTF::EnumeratedArray::at):
(WTF::EnumeratedArray::at const):
(WTF::EnumeratedArray::operator[]):
(WTF::EnumeratedArray::operator[] const):
(WTF::EnumeratedArray::front):
(WTF::EnumeratedArray::front const):
(WTF::EnumeratedArray::back):
(WTF::EnumeratedArray::back const):
(WTF::EnumeratedArray::fill):
(WTF::EnumeratedArray::operator== const):
(WTF::EnumeratedArray::operator!= const):
(WTF::EnumeratedArray::operator< const):
(WTF::EnumeratedArray::operator<= const):
(WTF::EnumeratedArray::operator> const):
(WTF::EnumeratedArray::operator>= const):
(WTF::EnumeratedArray::index):

Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Tools/TestWebKitAPI/Tests/WTF/EnumeratedArray.cpp: Added.

(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/251453@main

11:25 PM Changeset in webkit [295446] by Tyler Wilcock

22 edits
2 adds
2 deletes in trunk

AX: Update the isolated tree in response to dynamic changes to aria-live, aria-relevant, and aria-atomic
https://bugs.webkit.org/show_bug.cgi?id=241444

Reviewed by Chris Fleizach.

With this patch, we now update the isolated tree in response to dynamic
aria-live, aria-relevant, and aria-atomic changes.

This patch also makes liveRegionStatus, liveRegionRelevant, and
liveRegionAtomic work on node-only objects (like those with display:contents).

LayoutTests/accessibility/aria-busy-updates-after-dynamic-change-expected.txt: Removed.
LayoutTests/accessibility/aria-busy-updates-after-dynamic-change.html: Removed.
LayoutTests/accessibility/live-region-attributes-update-after-dynamic-change-expected.txt: Added.
LayoutTests/accessibility/live-region-attributes-update-after-dynamic-change.html: Added.
LayoutTests/platform/glib/TestExpectations:
LayoutTests/platform/ios/TestExpectations:
LayoutTests/platform/win/TestExpectations:
Source/WebCore/accessibility/AXLogger.cpp:

(WebCore::operator<<):

Source/WebCore/accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):

Source/WebCore/accessibility/AXObjectCache.h:
Source/WebCore/accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::liveRegionStatus const):
(WebCore::AccessibilityNodeObject::liveRegionRelevant const):
(WebCore::AccessibilityNodeObject::liveRegionAtomic const):

Source/WebCore/accessibility/AccessibilityNodeObject.h:
Source/WebCore/accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::liveRegionStatus const): Deleted.
(WebCore::AccessibilityRenderObject::liveRegionRelevant const): Deleted.
(WebCore::AccessibilityRenderObject::liveRegionAtomic const): Deleted.

Source/WebCore/accessibility/AccessibilityRenderObject.h:
Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

Tools/DumpRenderTree/AccessibilityUIElement.cpp:

(getLiveRegionRelevantCallback):
(getLiveRegionStatusCallback):
(getIsAtomicLiveRegionCallback):
(AccessibilityUIElement::getJSClass):

Tools/DumpRenderTree/AccessibilityUIElement.h:
Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::liveRegionRelevant const):
(AccessibilityUIElement::liveRegionStatus const):
(AccessibilityUIElement::isAtomicLiveRegion const):

Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp

(AccessibilityUIElement::liveRegionRelevant const):
(AccessibilityUIElement::liveRegionStatus const):
(AccessibilityUIElement::isAtomicLiveRegion const):

Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::liveRegionRelevant const):
(AccessibilityUIElement::liveRegionStatus const):
(AccessibilityUIElement::isAtomicLiveRegion const):

Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
Tools/WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::liveRegionRelevant const):
(WTR::AccessibilityUIElement::liveRegionStatus const):
(WTR::AccessibilityUIElement::isAtomicLiveRegion const):

Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::liveRegionStatus const):
(WTR::AccessibilityUIElement::liveRegionRelevant const):
(WTR::AccessibilityUIElement::isAtomicLiveRegion const):

Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp
Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp

Canonical link: https://commits.webkit.org/251452@main

9:58 PM Changeset in webkit [295445] by pvollan@apple.com

1 edit in trunk/Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm

Revert r295422
https://bugs.webkit.org/show_bug.cgi?id=241502

Unreviewed, revert r295422.

Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm:

(WebKit::LaunchServicesDatabaseObserver::LaunchServicesDatabaseObserver):
(WebKit::LaunchServicesDatabaseObserver::startObserving):
(WebKit::LaunchServicesDatabaseObserver::~LaunchServicesDatabaseObserver):
(WebKit::hasSystemContentDatabase): Deleted.

Canonical link: https://commits.webkit.org/251451@main

8:08 PM Changeset in webkit [295444] by Alan Bujtas

3 edits in trunk/Source/WebCore

computeUnderlineOffset should not take TextRun
https://bugs.webkit.org/show_bug.cgi?id=241471

Reviewed by Antti Koivisto.

This is in preparation for taking visual overflow for decoration into account in IFC.

Source/WebCore/rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::paintBackgroundDecorations):

Source/WebCore/style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset):
(WebCore::visualOverflowForDecorations):

Source/WebCore/style/InlineTextBoxStyle.h:

Canonical link: https://commits.webkit.org/251450@main

8:06 PM Changeset in webkit [295443] by Devin Rousso

46 edits
9 copies
2 moves
11 adds in trunk

[Payment Request] upstream new features
https://bugs.webkit.org/show_bug.cgi?id=241389
<rdar://problem/94581707>

Reviewed by Tim Horton.

Source/WTF/wtf/PlatformHave.h:
Source/WTF/wtf/PlatformEnableCocoa.h:

Add new flags.

Source/WebCore/Modules/applepay/ApplePayPaymentTiming.idl:
Source/WebCore/Modules/applepay/ApplePayPaymentTiming.h:
Source/WebCore/Modules/applepay/ApplePayLineItem.idl:
Source/WebCore/Modules/applepay/ApplePayLineItem.h:

(WebCore::ApplePayLineItem::encode const):
(WebCore::ApplePayLineItem::decode):

Source/WebCore/Modules/applepay/PaymentSummaryItems.h:
Source/WebCore/Modules/applepay/cocoa/PaymentSummaryItemsCocoa.mm:

(WebCore::platformAutomaticReloadSummaryItem): Added.
(WebCore::platformSummaryItem):
Add a new line item type for automatic reload (i.e. "charge when balance drops low enough").

Source/WebCore/Modules/applepay/ApplePayRecurringPaymentRequest.idl: Added.
Source/WebCore/Modules/applepay/ApplePayRecurringPaymentRequest.h: Added.

(WebCore::ApplePayRecurringPaymentRequest::encode const):
(WebCore::ApplePayRecurringPaymentRequest::decode):

Source/WebKit/Shared/ApplePay/RecurringPaymentRequest.h: Added.
Source/WebKit/Shared/ApplePay/cocoa/RecurringPaymentRequestCocoa.mm: Added.

(WebKit::platformRecurringPaymentRequest):
Add additional details for configuring a recurring payment.

Source/WebCore/Modules/applepay/ApplePayAutomaticReloadPaymentRequest.idl: Added.
Source/WebCore/Modules/applepay/ApplePayAutomaticReloadPaymentRequest.h: Added.

(WebCore::ApplePayAutomaticReloadPaymentRequest::encode const):
(WebCore::ApplePayAutomaticReloadPaymentRequest::decode):

Source/WebKit/Shared/ApplePay/AutomaticReloadPaymentRequest.h: Added.
Source/WebKit/Shared/ApplePay/cocoa/AutomaticReloadPaymentRequestCocoa.mm: Added.

(WebKit::platformAutomaticReloadPaymentRequest):
Add additional details for configuring an automatic reload payment.

Source/WebCore/Modules/applepay/ApplePayPaymentTokenContext.idl: Added.
Source/WebCore/Modules/applepay/ApplePayPaymentTokenContext.h: Added.

(WebCore::ApplePayPaymentTokenContext::encode const):
(WebCore::ApplePayPaymentTokenContext::decode):

Source/WebKit/Shared/ApplePay/PaymentTokenContext.h: Added.
Source/WebKit/Shared/ApplePay/cocoa/PaymentTokenContextCocoa.mm: Added.

(WebKit::toDecimalNumber):
(WebKit::platformPaymentTokenContext):
(WebKit::platformPaymentTokenContexts):
Add additional details for configuring a multi-merchant payment (i.e. booking a vacation online
often aggregates multiple separate things (e.g. car, flights, hotel, etc.) into a single purchase).

Source/WebCore/Modules/applepay/ApplePayPaymentOrderDetails.idl: Added.
Source/WebCore/Modules/applepay/ApplePayPaymentOrderDetails.h: Added.

(WebCore::ApplePayPaymentOrderDetails::encode const):
(WebCore::ApplePayPaymentOrderDetails::decode):
Add additional details after a payment is complete for saving order details to iOS/macOS Wallet.

Source/WebCore/Modules/applepay/ApplePayPaymentRequest.idl:
Source/WebCore/Modules/applepay/ApplePayPaymentRequest.h:
Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::ApplePaySessionPaymentRequest>::encode):
(IPC::ArgumentCoder<WebCore::ApplePaySessionPaymentRequest>::decode):

Source/WebCore/Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):
(WebCore::merge): Deleted.

Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::show):
(WebCore::ApplePayPaymentHandler::computeShippingMethods const):
(WebCore::validate):
(WebCore::ApplePayPaymentHandler::shippingAddressUpdated):
(WebCore::ApplePayPaymentHandler::shippingOptionUpdated):
(WebCore::ApplePayPaymentHandler::paymentMethodUpdated):
(WebCore::convertAndValidate):
(WebCore::ApplePayPaymentHandler::complete):
(WebCore::merge): Deleted.

Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h:

(WebCore::ApplePaySessionPaymentRequest::recurringPaymentRequest const): Added.
(WebCore::ApplePaySessionPaymentRequest::setRecurringPaymentRequest): Added.
(WebCore::ApplePaySessionPaymentRequest::automaticReloadPaymentRequest const): Added.
(WebCore::ApplePaySessionPaymentRequest::setAutomaticReloadPaymentRequest): Added.
(WebCore::ApplePaySessionPaymentRequest::multiTokenContexts const): Added.
(WebCore::ApplePaySessionPaymentRequest::setMultiTokenContexts): Added.

Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.idl:
Source/WebCore/Modules/applepay/ApplePayDetailsUpdateBase.h:

(WebCore::ApplePayDetailsUpdateBase::encode const):
(WebCore::ApplePayDetailsUpdateBase::decodeBase):

Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.h:
Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.idl:
Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizationResult.idl:
Source/WebCore/Modules/applepay/ApplePayPaymentAuthorizationResult.h:

(WebCore::ApplePayPaymentAuthorizationResult::encode const):
(WebCore::ApplePayPaymentAuthorizationResult::decode):

Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentCompleteDetails.idl:
Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentCompleteDetails.h:

(WebCore::ApplePayPaymentCompleteDetails::encode const):
(WebCore::ApplePayPaymentCompleteDetails::decode):

Source/WebKit/Platform/cocoa/PaymentAuthorizationPresenter.mm:

(WebKit::PaymentAuthorizationPresenter::completePaymentMethodSelection):
(WebKit::PaymentAuthorizationPresenter::completePaymentSession):
(WebKit::PaymentAuthorizationPresenter::completeShippingContactSelection):
(WebKit::PaymentAuthorizationPresenter::completeShippingMethodSelection):
(WebKit::PaymentAuthorizationPresenter::completeCouponCodeChange):
(WebKit::merge): Deleted.

Source/WebKit/Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest):
(WebKit::merge): Deleted.

Source/WebKit/Platform/cocoa/WKPaymentAuthorizationDelegate.h:
Source/WebKit/Platform/cocoa/WKPaymentAuthorizationDelegate.mm:

(-[WKPaymentAuthorizationDelegate completePaymentSession:errors:orderDetails:]): Added.
Pipe the above from the WebProcess to the UIProcess (to PassKit).

Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.h:
Source/WebCore/PAL/pal/cocoa/PassKitSoftLink.mm:
Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:

Handle new PassKit symbols for the above.

Source/WebCore/Modules/applepay/cocoa/PaymentAPIVersionCocoa.mm:

(WebCore::PaymentAPIVersion::current):
Use new flags for the new version.

Source/WebCore/DerivedSources.make:
Source/WebCore/DerivedSources-input.xcfilelist:
Source/WebCore/DerivedSources-output.xcfilelist:
Source/WebCore/PlatformMac.cmake:
Source/WebCore/SourcesCocoa.txt:
Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Source/WebKit/SourcesCocoa.txt:
Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Source/WebCore/testing/MockPaymentCoordinator.h:
Source/WebCore/testing/MockPaymentCoordinator.idl:
Source/WebCore/testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeShippingMethodSelection):
(WebCore::MockPaymentCoordinator::completeShippingContactSelection):
(WebCore::MockPaymentCoordinator::completePaymentMethodSelection):
(WebCore::MockPaymentCoordinator::completeCouponCodeChange):
(WebCore::MockPaymentCoordinator::merge): Deleted.

LayoutTests/http/tests/paymentrequest/ApplePayModifier-automaticReloadPaymentRequest.https.html: Added.
LayoutTests/http/tests/paymentrequest/ApplePayModifier-automaticReloadPaymentRequest.https-expected.txt: Added.
LayoutTests/http/tests/paymentrequest/ApplePayModifier-multiTokenContexts.https.html: Added.
LayoutTests/http/tests/paymentrequest/ApplePayModifier-multiTokenContexts.https-expected.txt: Added.
LayoutTests/http/tests/paymentrequest/ApplePayModifier-recurringPaymentRequest.https.html: Added.
LayoutTests/http/tests/paymentrequest/ApplePayModifier-recurringPaymentRequest.https-expected.txt: Added.
LayoutTests/http/tests/paymentrequest/ApplePayPaymentCompleteDetails-orderDetails.https.html: Added.
LayoutTests/http/tests/paymentrequest/ApplePayPaymentCompleteDetails-orderDetails.https-expected.txt: Added.
LayoutTests/platform/ios-wk2/TestExpectations:
LayoutTests/platform/mac-wk2/TestExpectations:

Source/WebKit/Shared/mac/PasteboardTypes.mm:
Source/WebKit/Shared/mac/ScrollingAccelerationCurveMac.mm:

Drive-by: Unified sources fixes.

Canonical link: https://commits.webkit.org/251449@main

5:31 PM Changeset in webkit [295442] by pvollan@apple.com

1 edit in trunk/Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm

Build fix after r295422
https://bugs.webkit.org/show_bug.cgi?id=241494

Unreviewed, build fix.

Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm:

Canonical link: https://commits.webkit.org/251448@main

5:14 PM Changeset in webkit [295441] by Wenson Hsieh

1 edit in trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

[ iOS Debug ] ASSERTION FAILED: Attempt to access post layout data before receiving it on editing/editable-region/fixed-and-absolute-contenteditable-scrolled.html
https://bugs.webkit.org/show_bug.cgi?id=237541
rdar://89918871

Reviewed by Simon Fraser.

After the changes in r289876, this test started sometimes hitting an assertion when run immediately
after editing/deleting/ios/backspace-last-character.html. By eliminating a sync IPC call to the
web content process when requesting autocorrection information, UIKit now requests selection-caret-
relative character information slightly earlier than it previously did when dismissing the keyboard,
which may occur after we've received an editor state update after blurring the focused element, but
before we've received post-layout data.

In this scenario, we already know that the focused element has been blurred and the selection is no
longer editable, so once the post-layout data does arrive, it would contain 0 for all of the
characters close to the selection caret.

As such, we can simply return 0 early before attempting to access post-layout data if the selection
is not a caret in editable content, since all of the relevant post-layout data members
(characterAfterSelection, characterBeforeSelection and twoCharacterBeforeSelection) are going
to be 0 anyways.

Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _characterInRelationToCaretSelection:]):

Canonical link: https://commits.webkit.org/251447@main

4:43 PM Changeset in webkit [295440] by eric.carlson@apple.com

1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm

[Cocoa] TestWebKitAPI.MediaLoading.CaptivePortalHLS times out
https://bugs.webkit.org/show_bug.cgi?id=241476
rdar://93270049

Reviewed by Jer Noble.

Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:

(TestWebKitAPI::TEST): Return early if the SPI used for captive portal mode is not
implemented.

Canonical link: https://commits.webkit.org/251446@main

4:12 PM Changeset in webkit [295439] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore/platform/graphics

[iOS] iPhone fullscreen captions are sometimes duplicated
https://bugs.webkit.org/show_bug.cgi?id=241464
rdar://94261522

Reviewed by Jer Noble.

Clear the text track representation when the video layer is cleared.

Source/WebCore/platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:

(WebCore::VideoLayerManagerObjC::didDestroyVideoLayer): Clear the text track representation.

Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:

(WebCore::TextTrackRepresentationCocoa::TextTrackRepresentationCocoa): Name the text
track representation layer to aid debugging in the future.

Canonical link: https://commits.webkit.org/251445@main

2:45 PM Changeset in webkit [295438] by Devin Rousso

32 edits
3 adds
1 delete in trunk

[Modern Media Controls] upstream new features
https://bugs.webkit.org/show_bug.cgi?id=241390
<rdar://problem/94581729>

Reviewed by Eric Carlson.

Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js:

(InlineMediaControls.prototype.layout):
(InlineMediaControls.prototype.topLeftContainerButtons): Renamed from _topLeftContainerButtons.
(InlineMediaControls.prototype.leftContainerButtons): Renamed from _leftContainerButtons.
(InlineMediaControls.prototype.centerContainerButtons): Renamed from _centerContainerButtons.
(InlineMediaControls.prototype.rightContainerButtons): Renamed from _rightContainerButtons.
(InlineMediaControls.prototype.droppableButtons): Renamed from _droppableButtons.
(InlineMediaControls.prototype.collapsableButtons): Renamed from _collapsableButtons.
Move these methods into // Protected so subclasses can override.

Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.js:

(IOSInlineMediaControls.prototype.layout): Added.
(IOSInlineMediaControls.prototype.centerContainerButtons): Added.
(IOSInlineMediaControls.prototype.leftContainerButtons): Added.
(IOSInlineMediaControls.prototype.droppableButtons): Added.
(IOSInlineMediaControls.prototype.get _shouldUseMultilineLayout): Added.

Source/WebCore/Modules/modern-media-controls/controls/ios-inline-media-controls.css: Added.

(.media-controls.inline.ios:not(.audio)):
(.media-controls.inline.ios:not(.audio):is(:empty, .faded)):
(.media-controls.inline.ios:not(.audio) *):
(.media-controls.inline.ios:not(.audio) > .controls-bar:is(.top-left, .top-right)):
(.media-controls.inline.ios:not(.audio) > .controls-bar.center):
Only use the new UI for <video>.

Source/WebCore/Modules/modern-media-controls/controls/slider.js:

(Slider):
(Slider.prototype.get allowsRelativeScrubbing): Added.
(Slider.prototype.set allowsRelativeScrubbing): Added.
(Slider.prototype.handleEvent):
(Slider.prototype._handlePointerdownEvent):
(Slider.prototype._handlePointermoveEvent): Added.
(Slider.prototype._handlePointerupEvent):
(Slider.prototype._playbackProgress): Added.
(Slider.prototype._valueWillStartChanging): Deleted.
(Slider.prototype._valueDidStopChanging): Deleted.

Source/WebCore/Modules/modern-media-controls/controls/slider.css:

(.slider.allows-relative-scrubbing > .custom-slider): Added.
(.slider.allows-relative-scrubbing > .custom-slider.changing): Added.
(.slider.allows-relative-scrubbing > .custom-slider > .fill): Added.
(.slider.allows-relative-scrubbing > .custom-slider.changing > .fill.primary): Added.
(.slider.allows-relative-scrubbing > .custom-slider.changing > .fill.track): Added.
(.slider.allows-relative-scrubbing > .custom-slider.changing > .fill.secondary): Added.
(.slider.allows-relative-scrubbing > input): Added.
(.ios .slider > input):
(.ios .slider:not(.allows-relative-scrubbing) > input): Added.

Source/WebCore/Modules/modern-media-controls/controls/adwaita-fullscreen-media-controls.js:

(AdwaitaFullscreenMediaControls):

Source/WebCore/Modules/modern-media-controls/controls/adwaita-inline-media-controls.js:

(AdwaitaInlineMediaControls):

Source/WebCore/Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:

(MacOSFullscreenMediaControls):

Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js:

(MacOSInlineMediaControls):

Source/WebCore/Modules/modern-media-controls/controls/time-control.js:

(TimeControl):
Allow the user to use relative scrubbing instead of having to exactly tap/drag on the knob.

Source/WebCore/Modules/modern-media-controls/controls/ios-layout-traits.js:

(IOSLayoutTraits.prototype.skipDuration):
Change to 10s.

Source/WebCore/Modules/modern-media-controls/controls/overflow-button.js:

(OverflowButton):

Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js:

(LayoutTraits.prototype.overflowButtonHasCircle): Deleted.

Source/WebCore/Modules/modern-media-controls/controls/icon-service.js:
Source/WebCore/Modules/modern-media-controls/images/iOS/Overflow.svg:
Source/WebCore/Modules/modern-media-controls/images/iOS/OverflowCircle.svg: Removed.

Update iOS overflow button icon.

Source/WebCore/CMakeLists.txt:
Source/WebCore/DerivedSources-input.xcfilelist:
Source/WebCore/DerivedSources.make:
Source/WebCore/WebCore.xcodeproj/project.pbxproj:

LayoutTests/fast/mediastream/MediaStream-video-element-video-tracks-disabled.html:
LayoutTests/fast/mediastream/MediaStream-video-element-video-tracks-disabled-expected.html:
LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-layout.html:
LayoutTests/media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-layout-expected.txt:
LayoutTests/media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-added-after-play.html:
LayoutTests/media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-added-after-play-expected.txt:
LayoutTests/media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-shows-start-button.html:
LayoutTests/media/modern-media-controls/skip-back-button/skip-back-button.html:
LayoutTests/media/modern-media-controls/skip-back-button/skip-back-button-expected.txt:
LayoutTests/media/modern-media-controls/skip-forward-button/skip-forward-button.html:
LayoutTests/media/modern-media-controls/skip-forward-button/skip-forward-button-expected.txt:
LayoutTests/media/modern-media-controls/slider/slider-constructor.html:
LayoutTests/media/modern-media-controls/slider/slider-styles.html:
LayoutTests/media/modern-media-controls/slider/slider-value.html:
LayoutTests/platform/ios/media/track/track-css-visible-stroke-expected.html: Added.

Canonical link: https://commits.webkit.org/251444@main

2:41 PM Changeset in webkit [295437] by achristensen@apple.com

1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm

REGRESSION: [iOS] TestWebKitAPI.HSTS.ThirdParty is consistely failing
https://bugs.webkit.org/show_bug.cgi?id=241342

Reviewed by Kate Cheney.

Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:

(TestWebKitAPI::hstsWebViewAndDelegate):
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/251443@main

2:36 PM Changeset in webkit [295436] by Claudio Saavedra

1 edit in trunk/Source/WebCore/html/HTMLInputElement.cpp

Fix invalid isInShadowRoot flag during input element removal
https://bugs.webkit.org/show_bug.cgi?id=241470

Reviewed by Ryosuke Niwa.

Style invalidation of input elements might rely on whether the element
is in the shadow tree, but during node removal the isInShadowRoot flag
might not be up-to-date. Ensure that the flag is updated by
letting Node::removedFromAncestor() be called up first in the
HTMLInputNode::removedFromAncestor() implementation, before
doing anything else with the node post-removal.

Source/WebCore/html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::removedFromAncestor):

Canonical link: https://commits.webkit.org/251442@main

2:34 PM Changeset in webkit [295435] by achristensen@apple.com

5 edits
2 deletes in trunk/Source/WebKit

Remove _WKWebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=241387

Reviewed by Brady Eidson.

Source/WebKit/SourcesCocoa.txt:
Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration ALLOW_DEPRECATED_IMPLEMENTATIONS_END]): Deleted.
(-[WKWebViewConfiguration _setWebsiteDataStore:]): Deleted.

Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.h:
Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm: Removed.
Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreInternal.h: Removed.
Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/251441@main

1:54 PM Changeset in webkit [295434] by commit-queue@webkit.org

1 edit in trunk/Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm

Add missing include in ScreenCaptureKitCaptureSource.mm
https://bugs.webkit.org/show_bug.cgi?id=241479
<rdar://94747956>

Patch by Youssef Soliman <youssefdevelops@gmail.com> on 2022-06-09
Reviewed by Wenson Hsieh and Eric Carlson.

ScreenCaptureKitCaptureSource was missing the declaration for
CGDisplayModeGetPixelsWide and CGDisplayModeGetPixelsHigh which are
defined in <pal/spi/cg/CoreGraphicsSPI.h>, this was causing build failures
if the build order happened to change.

Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:

Canonical link: https://commits.webkit.org/251440@main

1:42 PM Changeset in webkit [295433] by Said Abou-Hallawa

1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm

REGRESSION(r292365): [ iOS ] TestWebKitAPI.GPUProcess.CanvasBasicCrashHandling is a constant failure on iOS
https://bugs.webkit.org/show_bug.cgi?id=239303
<rdar://problem/91715705>

Reviewed by Simon Fraser.

The test has been passing when running it locally. This should be fixed by other
changes so re-enable this api-test.

Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:

(TEST):

Canonical link: https://commits.webkit.org/251439@main

1:30 PM Changeset in webkit [295432] by timothy_horton@apple.com

2 edits in trunk/Source

Upstream linkage of ApplePushService
https://bugs.webkit.org/show_bug.cgi?id=241473

Reviewed by Wenson Hsieh.

Source/WTF/wtf/PlatformHave.h:
Source/WebKit/Configurations/WebKit.xcconfig:

Canonical link: https://commits.webkit.org/251438@main

1:13 PM Changeset in webkit [295431] by commit-queue@webkit.org

1 edit in trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm

Multisampling does not work on MTLGPUFamilyApple2 devices when using ANGLE Metal
https://bugs.webkit.org/show_bug.cgi?id=241456
<rdar://problem/90949957>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-06-09
Reviewed by Dean Jackson.

Use OpenGL ES for WebGL for devices prior to MTLGPUFamilyApple3.
WebGL2 already was running OpenGL ES for these devices for different reasons.

The multisample codepath is not implemented for Apple2 which
does not support MTLStoreActionStoreAndMultisampleResolve.

Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:

(WebCore::platformSupportsMetal):
(WebCore::GraphicsContextGLCocoa::platformInitializeContext):

Canonical link: https://commits.webkit.org/251437@main

12:26 PM Changeset in webkit [295430] by commit-queue@webkit.org

1 edit in trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp

Need to check the context wasn't lost in WebGL2RenderingContext::readBuffer()
https://bugs.webkit.org/show_bug.cgi?id=241477
<rdar://94289317>

Patch by Antoine Quint <Antoine Quint> on 2022-06-09
Reviewed by Dean Jackson.

All other APIs exposed on WebGL2RenderingContext are guarded by isContextLostOrPending()
checks, and readBuffer() should be no exception.

Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::readBuffer):

Canonical link: https://commits.webkit.org/251436@main

12:25 PM Changeset in webkit [295429] by Kyle Piddington

1 edit
2 adds in trunk

TextureMtl.mm:108 (GetLayerMipIndex): \t! Unreachable reached
https://bugs.webkit.org/show_bug.cgi?id=240790

Reviewed by Darin Adler

Check texture valid before use.

Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.mm:

(rx::mtl::Texture::MakeTexture):

Canonical link: https://commits.webkit.org/251435@main

12:05 PM Changeset in webkit [295428] by keith_miller@apple.com

1 edit
1 add in trunk

jsc's settimeout should properly handle a delay
https://bugs.webkit.org/show_bug.cgi?id=240467

Reviewed by Yusuke Suzuki.

This patch makes it so that we properly handle a timeout passed to the JSC CLI setTimeout API. Previously we would just run the callback on the next runloop tick regardless of the passed value.

Source/JavaScriptCore/jsc.cpp:

(JSC_DEFINE_HOST_FUNCTION):

Canonical link: https://commits.webkit.org/251434@main

11:57 AM Changeset in webkit [295427] by Wenson Hsieh

1 edit in trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm

Unreviewed, fix the internal iOS build

Add a missing header include (due to source unification order).

Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

Canonical link: https://commits.webkit.org/251433@main

11:35 AM Changeset in webkit [295426] by eric.carlson@apple.com

7 edits in trunk

Regression(r283217) : [ iOS 15 ] media/track/track-forced-subtitles-in-band.html is failing
https://bugs.webkit.org/show_bug.cgi?id=231333
rdar://83955154

Reviewed by Jer Noble.

LayoutTests/media/track/track-forced-subtitles-in-band-expected.txt: Update.
LayoutTests/media/track/track-forced-subtitles-in-band.html: Ditto.
LayoutTests/media/video-test.js: Make waitForEventWithTimeout return a Promise rejection when it times out so failures can be caught.
LayoutTests/platform/ios-wk2/TestExpectations: Remove updated test.
LayoutTests/platform/mac/TestExpectations: Ditto.

Source/WebCore/html/track/TextTrackCueGeneric.cpp: Add more logging to help future debugging.

Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Ditto.

Canonical link: https://commits.webkit.org/251432@main

11:21 AM Changeset in webkit [295425] by achristensen@apple.com

11 edits
2 adds in trunk

convertingToLengthRequiresNonNullStyle needs to consider calc values
https://bugs.webkit.org/show_bug.cgi?id=241452

Reviewed by Antti Koivisto.

LayoutTests/fast/css/matrix-translate-calc-units.html: Added.
Source/WebCore/css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertingToLengthRequiresNonNullStyle const):
(WebCore::CSSPrimitiveValue::convertToLength const):

Source/WebCore/css/TransformFunctions.cpp:
Source/WebCore/css/calc/CSSCalcExpressionNode.h:
Source/WebCore/css/calc/CSSCalcInvertNode.h:
Source/WebCore/css/calc/CSSCalcNegateNode.h:
Source/WebCore/css/calc/CSSCalcOperationNode.cpp:

(WebCore::CSSCalcOperationNode::convertingToLengthRequiresNonNullStyle const):

Source/WebCore/css/calc/CSSCalcOperationNode.h:
Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.cpp:

(WebCore::CSSCalcPrimitiveValueNode::convertingToLengthRequiresNonNullStyle const):

Source/WebCore/css/calc/CSSCalcPrimitiveValueNode.h:
Source/WebCore/css/calc/CSSCalcValue.cpp:

(WebCore::CSSCalcValue::convertingToLengthRequiresNonNullStyle const):

Source/WebCore/css/calc/CSSCalcValue.h:

Canonical link: https://commits.webkit.org/251431@main

10:50 AM Changeset in webkit [295424] by jer.noble@apple.com

1 edit in trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml

Add MPEG2 and MP4 Audio to types allowed in Captive Portal mode
https://bugs.webkit.org/show_bug.cgi?id=241447
<rdar://93934656>

Reviewed by Eric Carlson.

Needed for playing back MP2TS streams and AAC audio.

Source/WTF/Scripts/Preferences/WebPreferences.yaml:

Canonical link: https://commits.webkit.org/251430@main

10:20 AM Changeset in webkit [295423] by keith_miller@apple.com

1 edit in trunk/Source/JavaScriptCore/bytecode/Repatch.cpp

Repatch should be able to polymorphic call with arity fixup.
https://bugs.webkit.org/show_bug.cgi?id=240911

Reviewed by Saam Barati.

Right now repatch will emit a virtual call any time it has a case that requires arity fixup. Instead it should just pick the arity fixup entrypoint.

Canonical link: https://commits.webkit.org/251429@main

10:16 AM Changeset in webkit [295422] by pvollan@apple.com

2 edits in trunk/Source

Adopt SPI to get default content of Launch Services database
https://bugs.webkit.org/show_bug.cgi?id=241286
<rdar://64528683>

Reviewed by Geoffrey Garen.

Adopt SPI to get system content of Launch Services database. If this SPI is available,
it will replace the SPI we currently use to retrieve the database in the Network process.

Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h:
Source/WebKit/NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm:

Canonical link: https://commits.webkit.org/251428@main

8:58 AM Changeset in webkit [295421] by commit-queue@webkit.org

3 edits in trunk

Replace uses of -webkit-gradient with standard linear-gradient.
https://bugs.webkit.org/show_bug.cgi?id=241066
rdar://94390714

Patch by Ryan Reno <rreno@apple.com> on 2022-06-09
Reviewed by Tim Nguyen.

Replace uses of the -webkit-gradient extension with the standardized
linear-gradient in internal CSS. This doesn't change functionality and
is covered by existing tests of the linear-gradient CSS function.

Source/WebCore/Modules/mediacontrols/mediaControlsBase.css:

(video::-webkit-media-controls-panel,):
(video::-webkit-media-controls-panel .volume-box,):
(audio::-webkit-media-controls-volume-slider,):
(video::-webkit-media-controls-volume-slider::-webkit-slider-thumb,):
(video::-webkit-media-controls-volume-slider::-webkit-slider-thumb::-webkit-slider-thumb:active,):
(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-volume-slider):

Source/WebCore/html/shadow/meterElementShadow.css:

(div#bar):
(div#value.optimum):
(div#value.suboptimum):
(div#value.even-less-good):

LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:

Canonical link: https://commits.webkit.org/251427@main

8:07 AM Changeset in webkit [295420] by Jean-Yves Avenard

10 edits in trunk/Source/WebKit

Blame content process for media buffers allocated in the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=241455
<rdar://94674194>

Reviewed by Jer Noble.

After copying the media content sent by the content process into a SharedMemory,
we send its SharedMemory's handle back to the content process for it to blame the
content.

Covered by existing tests.

Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.cpp:

(WebKit::RemoteMediaResourceManager::dataReceived):

Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.h:
Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.messages.in:
Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp:

(WebKit::RemoteSourceBufferProxy::append):

Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h:
Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in:
Source/WebKit/Platform/IPC/SharedBufferReference.cpp:

(IPC::SharedBufferReference::sharedCopy const):

Source/WebKit/Platform/IPC/SharedBufferReference.h:
Source/WebKit/WebProcess/GPU/media/RemoteMediaResourceProxy.cpp:

(WebKit::RemoteMediaResourceProxy::dataReceived):

Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:

(WebKit::SourceBufferPrivateRemote::append):

Canonical link: https://commits.webkit.org/251426@main

7:08 AM Changeset in webkit [295419] by Diego Pino Garcia

1 edit in trunk/Source/WTF/wtf/text/AtomString.h

[GTK] Ubuntu LTS bot build failed after 251271@main
https://bugs.webkit.org/show_bug.cgi?id=241327

Reviewed by Darin Adler.

Source/WTF/wtf/text/AtomString.h: Implement missing operator!=(const AtomString& a, ASCIILiteral b).

Canonical link: https://commits.webkit.org/251425@main

6:14 AM Changeset in webkit [295418] by Antti Koivisto

7 edits in trunk

Correctly resolve queries when container size is affected by a subsequent sibling
https://bugs.webkit.org/show_bug.cgi?id=241457

Reviewed by Alan Bujtas.

We currently only take style changes before the container into account.

This patch changes the query container resolution so that whenever we encounter a query container
we skip the subtree and restart the resolution from the main resolution loop. This way we
can optimize away unnecessary layouts while also handling backward dependencies.

LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/sibling-layout-dependency-expected.txt:
Source/WebCore/dom/Document.cpp:

(WebCore::Document::resolveStyle):

Loop also when there are no style changes to apply but there are unresolved container. In this case we just resume
the style resolution where we left it.

Source/WebCore/dom/Element.cpp:

(WebCore::Element::invalidateForQueryContainerChange):

Invalidate all descendants when a query container is resized. In practice we ended up computing them all anyway.

Source/WebCore/style/StyleChange.cpp:

(WebCore::Style::determineChange):

Source/WebCore/style/StyleChange.h:

Add new Descendants value for when container type or name changes.

Source/WebCore/style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::computeDescendantsToResolve):
(WebCore::Style::TreeResolver::pushParent):
(WebCore::Style::TreeResolver::popParent):
(WebCore::Style::TreeResolver::resolveComposedTree):
(WebCore::Style::TreeResolver::determineQueryContainerAction):

Use two buckets for unresolved and resolved containers. Use the resolved bucket to avoid
recomputing containers we have resolved already.

(WebCore::Style::TreeResolver::resolve):

Move the containers from the unresolved to resolved bucket in the beginning.

(WebCore::Style::TreeResolver::updateQueryContainer): Deleted.

Source/WebCore/style/StyleTreeResolver.h:

Canonical link: https://commits.webkit.org/251424@main

5:05 AM Changeset in webkit [295417] by commit-queue@webkit.org

1 edit in trunk/Source/WebCore/platform/graphics/gtk/SystemFontDatabaseGTK.cpp

REGRESSION(251416@main): Broke GTK...
https://bugs.webkit.org/show_bug.cgi?id=241460

Patch by Philippe Normand <philn@igalia.com> on 2022-06-09
Unreviewed, fix GTK build.

Source/WebCore/platform/graphics/gtk/SystemFontDatabaseGTK.cpp:

(WebCore::SystemFontDatabase::platformSystemFontShorthandInfo):

Canonical link: https://commits.webkit.org/251423@main

4:30 AM Changeset in webkit [295416] by commit-queue@webkit.org

1 edit in trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.asm

Don't save CSRs respected by the JIT ABI.

Patch by Geza Lore <Geza Lore> on 2022-06-09
https://bugs.webkit.org/show_bug.cgi?id=241369

Reviewed by Mark Lam.

It is not necessary to save and restore CSRs respected by the JIT ABI on
VM entry/exit. The compiler will preserve them. (r10 and r11 on ARMv7.)

Source/JavaScriptCore/llint/LowLevelInterpreter.asm:

Canonical link: https://commits.webkit.org/251422@main

3:39 AM Changeset in webkit [295415] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore/html/canvas

Remove unused code from WebGL2RenderingContext
https://bugs.webkit.org/show_bug.cgi?id=241351

Patch by Alexey Knyazev <3479527+lexaknyazev@users.noreply.github.com> on 2022-06-09
Also removed unnecessary FALLTHROUGH attributes.

Reviewed by Kimmo Kinnunen.

Source/WebCore/html/canvas/EXTTextureNorm16.cpp:

(WebCore::EXTTextureNorm16::supported):

Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::initializeVertexArrayObjects):
(WebCore::WebGL2RenderingContext::getInternalformatParameter):
(WebCore::WebGL2RenderingContext::getTexParameter):
(WebCore::isRenderableInternalformat): Deleted.
(WebCore::WebGL2RenderingContext::validateTexStorageFuncParameters): Deleted.
(WebCore::WebGL2RenderingContext::baseInternalFormatFromInternalFormat): Deleted.
(WebCore::WebGL2RenderingContext::isIntegerFormat): Deleted.

Source/WebCore/html/canvas/WebGL2RenderingContext.h:

Canonical link: https://commits.webkit.org/251421@main

3:06 AM WebKitEnablingFlatpakClangd edited by Martin Robinson

(diff)

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed