Context Navigation

← Previous Period
Next Period →

Timeline

Jun 20, 2022:

11:42 PM Changeset in webkit [295681] by commit-queue@webkit.org

1 edit in trunk/Source/WebCore/loader/appcache/ApplicationCacheHost.cpp

ApplicationCacheHost::isApplicationCacheEnabled() should check for its page being null
https://bugs.webkit.org/show_bug.cgi?id=241776

Patch by Youenn Fablet <youennf@gmail.com> on 2022-06-20
Reviewed by Alex Christensen.

Source/WebCore/loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
Add page null check.

Canonical link: https://commits.webkit.org/251686@main

11:37 PM Changeset in webkit [295680] by mark.lam@apple.com

6 edits in trunk/Source

Enhance RawPointer to take function pointers as well.
https://bugs.webkit.org/show_bug.cgi?id=241773

Reviewed by Yusuke Suzuki.

Also add PageBlock::end and PageReservation::end methods to make code a little
more readable (motivated by a RawPointer use).

Source/JavaScriptCore/API/JSMarkingConstraintPrivate.cpp:

(JSContextGroupAddMarkingConstraint):

Source/JavaScriptCore/heap/HeapFinalizerCallback.cpp:

(JSC::HeapFinalizerCallback::dump const):

Source/JavaScriptCore/jit/ExecutableAllocator.cpp:

(JSC::initializeJITPageReservation):

Source/WTF/wtf/PageBlock.h:

(WTF::PageBlock::end const):

Source/WTF/wtf/PageReservation.h:
Source/WTF/wtf/RawPointer.h:

(WTF::RawPointer::RawPointer):

Canonical link: https://commits.webkit.org/251685@main

8:54 PM Changeset in webkit [295679] by Patrick Griffis

7 edits in trunk

[GLIB] Add API to set WebView's Content-Security-Policy
https://bugs.webkit.org/show_bug.cgi?id=240221

Reviewed by Michael Catanzaro and Adrian Perez de Castro.

This adds API to set the WebView's default policy as well as API to
indicate that the WebView is in a WebExtension. This changes the internal
behavior of CSP to block some options.

Both of these are required for a complete WebExtension implementation in
browsers such as Epiphany.

Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:

(testWebViewDefaultContentSecurityPolicy):
(testWebViewWebExtensionMode):
(beforeAll):

Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(WebViewTest::loadHtml):

Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextCreatePageForWebView):

Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
(webkit_web_view_get_web_extension_mode):
(webkit_web_view_get_default_content_security_policy):

Source/WebKit/UIProcess/API/gtk/WebKitWebView.h:
Source/WebKit/UIProcess/API/wpe/WebKitWebView.h:

Canonical link: https://commits.webkit.org/251684@main

5:29 PM Changeset in webkit [295678] by commit-queue@webkit.org

1 edit in trunk/Source/WebGPU/WGSL/SourceSpan.h

[WebGPU] Support equality comparison between SourceSpans
https://bugs.webkit.org/show_bug.cgi?id=241757

Patch by Kiet Ho <Kiet Ho> on 2022-06-20
Reviewed by Myles C. Maxfield.

Source/WebGPU/WGSL/SourceSpan.h:

(WGSL::SourceSpan::operator==):

Canonical link: https://commits.webkit.org/251683@main

5:02 PM Changeset in webkit [295677] by mark.lam@apple.com

1 edit in trunk/Source/JavaScriptCore/runtime/Options.cpp

Fix broken --useOSLog option.
https://bugs.webkit.org/show_bug.cgi?id=241790

Reviewed by Alexey Shvayka.

Internally, --useOSLog=0 is represented as OSLogType::None. Options::dumpAllOptionsInALine()
dumps this value as "none". When "none" is later passed back to Options::setOption(), it is
rejected because useOSLog's parse function wasn't expecting "none" as an input string. The
fix is simply to add "none" to the list of allowed input strings.

Also, since OSLogType::None is a thing, it makes sense that the option should allow value
"none". This issue was manifesting as a failure when running testapi.

Source/JavaScriptCore/runtime/Options.cpp:

(JSC::parse):

Canonical link: https://commits.webkit.org/251682@main

11:47 AM Changeset in webkit [295676] by commit-queue@webkit.org

9 edits in trunk/Source/WebKit

Fix spelling error in remote media players
https://bugs.webkit.org/show_bug.cgi?id=241786

Patch by Youssef Soliman <youssefdevelops@gmail.com> on 2022-06-20
Reviewed by Wenson Hsieh.

The word "identifier" was spelt wrong in both remote media player
header files and some supplemental media files.

Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h:
Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::identifier const): Deleted.

Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:

Canonical link: https://commits.webkit.org/251681@main

8:30 AM WebKitGTK/2.36.x edited by berto@igalia.com

(diff)

7:45 AM Changeset in webkit [295675] by Antti Koivisto

5 edits in trunk

[CSS Container Queries] Container units don't work in gradients
https://bugs.webkit.org/show_bug.cgi?id=241780

Reviewed by Tim Nguyen.

LayoutTests/TestExpectations:
Source/WebCore/css/CSSGradientValue.cpp:

(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):
(WebCore::CSSConicGradientValue::createGradient):

Provide the element to CSSToLengthConversionData so a container can be selected.

Source/WebCore/css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):

Source/WebCore/css/CSSToLengthConversionData.cpp:

(WebCore::CSSToLengthConversionData::CSSToLengthConversionData):

Source/WebCore/css/CSSToLengthConversionData.h:

(WebCore::CSSToLengthConversionData::elementForContainerUnitResolution const):
(WebCore::CSSToLengthConversionData::element const): Deleted.

Rename for clarity.

Canonical link: https://commits.webkit.org/251680@main

6:04 AM Changeset in webkit [295674] by commit-queue@webkit.org

1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm

[ iOS ] TestWebKitAPI.WebKit2.CrashGPUProcessWhileCapturing is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=239315

Patch by Youenn Fablet <youennf@gmail.com> on 2022-06-20
Unreviewed.

Reenable tests to gather EWS results.
We should at least reenable it in macOS if it still does not run well in iOS.

Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:

Canonical link: https://commits.webkit.org/251679@main

5:02 AM Changeset in webkit [295673] by commit-queue@webkit.org

1 edit in trunk/LayoutTests/platform/ios-wk2/TestExpectations

[ iOS ] 8 imported/w3c/web-platform-tests/fetch/api (layout-tests) are flaky text failures
https://bugs.webkit.org/show_bug.cgi?id=234278

Patch by Youenn Fablet <youennf@gmail.com> on 2022-06-20
Unreviewed.

LayoutTests/platform/ios-wk2/TestExpectations:

Tests no longer seem flaky in results.webkit.org.

Canonical link: https://commits.webkit.org/251678@main

4:29 AM Changeset in webkit [295672] by Antti Koivisto

1 edit in trunk/LayoutTests/TestExpectations

Enable imported/w3c/web-platform-tests/css/css-contain/container-queries/svg-foreignobject-no-size-container.html in release
https://bugs.webkit.org/show_bug.cgi?id=241779

Unreviewed test gardening.

It hits unrelated debug assert (bug 241778) but passes otherwise.

LayoutTests/TestExpectations:

Canonical link: https://commits.webkit.org/251677@main

2:02 AM Changeset in webkit [295671] by Diego Pino Garcia

1 edit in trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

REGRESSION(r295627): [GCC] Unreviewed, fix build error in Debian Stable

error: call to non-'constexpr' function 'void WTF::isIntegralOrPointerType()'.

Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::computeMinimumValue): Use
RELEASE_ASSERT_NOT_REACHED_UNDER_CONSTEXPR_CONTEXT

Canonical link: https://commits.webkit.org/251676@main

1:07 AM Changeset in webkit [295670] by commit-queue@webkit.org

2 edits
1 delete in trunk/Source/WebKit

IPC::FontReference is a redundant type alias in wrong software layer
https://bugs.webkit.org/show_bug.cgi?id=241712

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-06-20
Reviewed by Cameron McCormack and Wenson Hsieh.

Instead, use the aliased type Ref<Font>.

Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
Source/WebKit/Platform/IPC/FontReference.h: Removed.
Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/251675@main

12:43 AM Changeset in webkit [295669] by Cameron McCormack

3 edits in trunk/Source/WebCore/platform/graphics/displaylists

Remove unused display list item apply functions
https://bugs.webkit.org/show_bug.cgi?id=241771

Reviewed by Wenson Hsieh.

Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::apply):

Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::PaintFrameForMedia::PaintFrameForMedia):
(WebCore::DisplayList::DrawFilteredImageBuffer::apply const): Deleted.
(WebCore::DisplayList::PaintFrameForMedia::apply const): Deleted.

Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:

Canonical link: https://commits.webkit.org/251674@main

Jun 19, 2022:

9:51 PM Changeset in webkit [295668] by Diego Pino Garcia

2 edits in trunk/Tools/CISupport/build-webkit-org

Add new post-commit bot WPE-Linux-64-bit-Release-Clang-Build https://bugs.webkit.org/show_bug.cgi?id=241403

Reviewed by Jonathan Bedard and Aakash Jain.

Also rename 'GTK-Linux-64-bit-Release-Clang' to 'GTK-Linux-64-bit-Release-Clang-Build'
to respect naming convention.

Tools/CISupport/build-webkit-org/config.json:
Tools/CISupport/build-webkit-org/factories_unittest.py: Add new test for 'WPE-Linux-64-bit-Release-Clang-Build' bot.

Canonical link: https://commits.webkit.org/251673@main

9:27 PM Changeset in webkit [295667] by Cameron McCormack

10 edits
2 copies
1 add in trunk/Source/WebCore

Add debug output support for WebCore::Gradient
https://bugs.webkit.org/show_bug.cgi?id=241767

Reviewed by Sam Weinig.

Source/WebCore/Sources.txt:
Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Source/WebCore/platform/graphics/ColorInterpolationMethod.cpp: Added.

(WebCore::operator<<):

Source/WebCore/platform/graphics/ColorInterpolationMethod.h:
Source/WebCore/platform/graphics/Gradient.cpp:

(WebCore::operator<<):

Source/WebCore/platform/graphics/Gradient.h:
Source/WebCore/platform/graphics/GradientColorStop.cpp: Copied from Source/WebCore/platform/graphics/GradientColorStop.h.

(WebCore::operator<<):

Source/WebCore/platform/graphics/GradientColorStop.h:
Source/WebCore/platform/graphics/GradientColorStops.cpp: Copied from Source/WebCore/platform/graphics/GradientColorStop.h.

(WebCore::operator<<):

Source/WebCore/platform/graphics/GradientColorStops.h:
Source/WebCore/platform/graphics/GraphicsTypes.cpp:

(WebCore::operator<<):

Source/WebCore/platform/graphics/GraphicsTypes.h:

Canonical link: https://commits.webkit.org/251672@main

9:25 PM Changeset in webkit [295666] by Matt Woodrow

24 edits
1 add
1 delete in trunk

Make IPC::Attachment moveable on DARWIN
https://bugs.webkit.org/show_bug.cgi?id=241660

This makes the DARWIN implementation of IPC::Attachment use MachSendPort, since this
proper move handling, and lifetime management of the underlying mach_port_t.

This also removes the MachPort class, since this was largely just used as an intermediate
and is stricly worse than MachSendPort.

The primary bug fixed here is a case where the WebProcess sent a port to the UIProcess, and then
we failed to forward it to the GPUProcess since it had crashed. Previously we'd just leak the port (and
thus never notify the WebContent process that we'd failed), whereas now it gets released correctly.

Reviewed by Kimmo Kinnunen.

Source/WebKit/GPUProcess/GPUProcess.cpp:

(WebKit::asConnectionIdentifier):
(WebKit::GPUProcess::createGPUConnectionToWebProcess):

Source/WebKit/Platform/IPC/Attachment.cpp:

(IPC::Attachment::Attachment):
(IPC::Attachment::release): Deleted.

Source/WebKit/Platform/IPC/Attachment.h:

(IPC::Attachment::Attachment::customWriter const):
(IPC::Attachment::Attachment): Deleted.
(IPC::Attachment::type const): Deleted.
(IPC::Attachment::isNull const): Deleted.
(IPC::Attachment::size const): Deleted.
(IPC::Attachment::fd const): Deleted.
(IPC::Attachment::release): Deleted.
(IPC::Attachment::customWriter const): Deleted.
(IPC::Attachment::port const): Deleted.
(IPC::Attachment::disposition const): Deleted.
(IPC::Attachment::handle const): Deleted.

Source/WebKit/Platform/IPC/StreamServerConnection.cpp:

(IPC::StreamServerConnection::createWithDedicatedConnection):

Source/WebKit/Platform/IPC/cocoa/MachPort.h: Removed.
Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp:

(WebKit::SharedMemory::IPCHandle::encode const):
(WebKit::SharedMemory::IPCHandle::decode):

Source/WebKit/Scripts/webkit/parser_unittest.py:
Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp:

(IPC::messageArgumentDescriptions):

Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiver.messages.in:
Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp:
Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessages.h:

(Messages::TestWithLegacyReceiver::DidCreateWebProcessConnection::DidCreateWebProcessConnection):

Source/WebKit/Scripts/webkit/tests/TestWithoutAttributes.messages.in:
Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp:
Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessages.h:

(Messages::TestWithoutAttributes::DidCreateWebProcessConnection::DidCreateWebProcessConnection):

Source/WebKit/Shared/IPCConnectionTester.cpp:

(WebKit::asIdentifier):

Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<MachSendRight>::encode):
(IPC::ArgumentCoder<MachSendRight>::decode):

Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getNetworkProcessConnection):

Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Source/WebKit/WebProcess/Inspector/WebInspector.cpp:

(WebKit::WebInspector::setFrontendConnection):

Source/WebKit/WebProcess/Network/NetworkProcessConnectionInfo.h:

(WebKit::NetworkProcessConnectionInfo::identifier const):
(WebKit::NetworkProcessConnectionInfo::releaseIdentifier):

Converts IPC::Attachment to use MachSendPort instead of a port/disposition pair, and changes all
callsites to handle that.

Source/WebKit/Platform/IPC/cocoa/ConnectionCocoa.mm:

(IPC::Connection::open):
(IPC::Connection::sendOutgoingMessage):
(IPC::createMessageDecoder):
(IPC::Connection::receiveSourceEventHandler):
(IPC::Connection::createConnectionIdentifierPair):

Make serialization/deserialization handle IPC::Connection being a MachSendPort.

Also makes sure we explicity allocate a send right at the two places we allocate a receive right,
rather than relying on this happening during serialization (with the MAKE_SEND disposition).
This means if the caller ends up not sending the IPC::Connection due to an error, we'll still end
up deallocating a send right, and trigger the associated notifications.

Source/WebKit/Platform/IPC/cocoa/SharedFileHandleCocoa.cpp:

(IPC::SharedFileHandle::encode const):
(IPC::SharedFileHandle::decode):

Fixes a potential leak where we previously just passed our port to
fileport_makefd without then releasing our reference to it (which is now handled
via the MachSendPort destructor).

Source/WTF/wtf/cocoa/MachSendRight.cpp:

(WTF::MachSendRight::operator=):

Fixes a potential leak, where we were just overwriting the old m_port contents without releasing it.

Canonical link: https://commits.webkit.org/251671@main

8:57 PM Changeset in webkit [295665] by Alan Bujtas

4 edits
2 adds in trunk

REGRESSION (r294902): Content with continuation leaves decoration bits behind when removed
https://bugs.webkit.org/show_bug.cgi?id=241734
<rdar://95308322>

Reviewed by Simon Fraser.

This patch ensures that when a renderer is removed we always issue a repaint regardless of what the associated layer's repaint bit says.

after r294902, repaint is not issued anymore if either the associated or an ancestor layer have the "full repaint" bit set.
such layer-driven repaints happen after layout.

In some dynamic content cases, the layer may be removed before layout happens. This patch ensures that we preemptively issue such repaints.

LayoutTests/fast/repaint/force-repaint-when-layer-is-destroyed-expected.txt: Added.
LayoutTests/fast/repaint/force-repaint-when-layer-is-destroyed.html: Added.

Source/WebCore/rendering/RenderLayerModelObject.cpp: Force (full) repaint when the renderer is being destroyed (detached -> non-internal move).

(WebCore::RenderLayerModelObject::willBeRemovedFromTree):

Source/WebCore/rendering/RenderLayerModelObject.h:
Source/WebCore/rendering/RenderObject.cpp: move duplicated code from repaint() and repaintRectangle() to issueRepaint().

Canonical link: https://commits.webkit.org/251670@main

8:28 PM Changeset in webkit [295664] by Cameron McCormack