Timeline



May 15, 2002:

11:23 PM Changeset in webkit [1161] by darin
  • 8 edits in trunk/WebKit

Another quick events cleanup pass.

  • Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender sendNullEvents]): Use [IFPluginView getCarbonEvent:].
  • Plugins.subproj/IFPluginView.h: Make almost all methods private.
  • Plugins.subproj/IFPluginView.mm: (+[IFPluginView getCarbonEvent:]): New. (-[IFPluginView getCarbonEvent:]): New, calls class method. (-[IFPluginView modifiersForEvent:isMouseDown:]): Reversed sense of btnState. This flag is set if the mouse is up, not if the mouse is down. (-[IFPluginView getCarbonEvent:withEvent:isMouseDown:]): New. (-[IFPluginView getCarbonEvent:withEvent:]): New. (-[IFPluginView sendActivateEvent:]): Now takes parameter for activate vs. deactivate and uses [getCarbonEvent:]. (-[IFPluginView sendUpdateEvent]): Uses [getCarbonEvent:]. (-[IFPluginView becomeFirstResponder]): Uses [getCarbonEvent:]. (-[IFPluginView resignFirstResponder]): Uses [getCarbonEvent:]. (-[IFPluginView mouseDown:]): Uses [getCarbonEvent:withEvent:isMouseDown:]. (-[IFPluginView mouseUp:]): Uses [getCarbonEvent:withEvent:isMouseDown:]. (-[IFPluginView mouseEntered:]): Uses [getCarbonEvent:withEvent:]. (-[IFPluginView mouseExited:]): Uses [getCarbonEvent:withEvent:]. (-[IFPluginView keyUp:]): Uses [getCarbonEvent:withEvent:]. (-[IFPluginView keyDown:]): Uses [getCarbonEvent:withEvent:]. (-[IFPluginView start]): Call [sendActivateEvent:YES]. (-[IFPluginView windowBecameKey:]): Call [sendActivateEvent:YES]. (-[IFPluginView windowResignedKey:]): Call [sendActivateEvent:NO].
5:22 PM Changeset in webkit [1160] by rjw
  • 4 edits in trunk/WebKit

Fixed problem dealing w/ characters in range 0x7f - 0xa0.

4:58 PM Changeset in webkit [1159] by cblu
  • 10 edits in trunk/WebKit

Fixed Flash mouse-down, mouse-over Flash bug.
Added support for modifiers (control-click etc) (2884451).
A lot of events clean-up.

  • Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender sendNullEvents]):
  • Plugins.subproj/IFPluginView.h:
  • Plugins.subproj/IFPluginView.mm: (newCString): (-[IFPluginView initWithFrame:plugin:url:mime:arguments:mode:]): (-[IFPluginView start]): (-[IFPluginView drawRect:]): (-[IFPluginView isFlipped]): (-[IFPluginView currentModifiers]): (-[IFPluginView modifiersForEvent:isMouseDown:]): (-[IFPluginView sendActivateEvent]): (-[IFPluginView sendUpdateEvent]): (-[IFPluginView becomeFirstResponder]): (-[IFPluginView resignFirstResponder]): (-[IFPluginView mouseDown:]): (-[IFPluginView mouseUp:]): (-[IFPluginView mouseEntered:]): (-[IFPluginView mouseExited:]): (-[IFPluginView keyUp:]): (-[IFPluginView keyDown:]): (-[IFPluginView windowBecameKey:]): (-[IFPluginView windowResignedKey:]):

Case-sensitivity issue with an include.

  • WebView.subproj/IFWebView.mm:
4:21 PM Changeset in webkit [1158] by rjw
  • 4 edits in trunk/WebCore

Alerts, useful for validating that js handlers work.
Validated that onsubmit is working.

2:00 PM Changeset in webkit [1157] by darin
  • 1 edit in trunk/WebCore/khtml/ecma/kjs_window.cpp

Oops.

1:59 PM Changeset in webkit [1156] by darin
  • 7 edits in trunk/WebCore
  • kwq/qt/qguardedptr.h: Fix reversed sense of check in isNull. Fixes a bug that was causing a lot of DHTML not to work.
12:45 PM Changeset in webkit [1155] by kocienda
  • 4 edits in trunk/WebCore

2002-05-15 Kenneth Kocienda <​kocienda@apple.com>

  • kwq/KWQInvisibleButton.h: Changed an #include of Cocoa.h to an #import
12:03 PM Changeset in webkit [1154] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQListImpl.mm: (KWQListImpl::KWQListPrivate::copyList): Take out unnecessary line of code. (KWQListImpl::KWQListPrivate::~KWQListPrivate): Delete the iterator nodes also, not just the item nodes. Fixes a storage leak. (KWQListIteratorImpl::KWQListIteratorPrivate::KWQListIteratorPrivate): Change interface to take a list pointer so we don't rely on the undefined behavior of &* on a null pointer. (KWQListImpl::addIterator): Set up the prev pointer of the old head of the list. This was causing the crash I was debugging. (KWQListIteratorImpl::operator=): Simpler implementation.
10:05 AM Changeset in webkit [1153] by darin
  • 7 edits in trunk
  • Makefile.am: Use all-am and clean-am instead of all and clean because it's better and to make "make check" at the top level work right.

May 14, 2002:

8:35 PM Changeset in webkit [1152] by sullivan
  • 14 edits in trunk/WebKit

Work to support copying bookmarks, needed for drag & drop
in Bookmarks window.

  • Bookmarks.subproj/IFBookmark.h: Make IFBookmark conform to NSCopying.
  • Bookmarks.subproj/IFBookmark.m: (-[IFBookmark copyWithZone:]): insist that subclasses implement this.
  • Bookmarks.subproj/IFBookmarkGroup.h:
  • Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup insertBookmark:atIndex:ofBookmark:]): Removed this unnecessary method.
  • Bookmarks.subproj/IFBookmarkLeaf.m: (-[IFBookmarkLeaf copyWithZone:]): New method.
  • Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList copyWithZone:]): New method.

Fixed 2921730 -- Can't rearrange bookmarks in Bookmarks window

You can now drag and drop willy-nilly in the Bookmarks window to
rearrange items. It's currently using a private pasteboard type,
so you can't drop items from elsewhere or drag the bookmarks out
of the list. I know of one bug (dropping an item inside itself
makes it poof into nothingness) which I'll write up in a moment.

  • BookmarksController.m: (-[BookmarksController windowDidLoad]): register for our dragged type. (-[BookmarksController _anyAncestorOfRow:inArray:]): New helper method, used to avoid copying a folder deep and some of its children at the same time. (-[BookmarksController outlineView:writeItems:toPasteboard:]): Write list of rows to pasteboard, after eliminating items whose ancestors are also in set. (-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]): Move a drop on a leaf bookmark to be after the leaf bookmark. (-[BookmarksController outlineView:acceptDrop:item:childIndex:]): Do the move, by inserting copies of the moved items and then removing the originals.
  • OutlineViewPlus.m: (-[OutlineViewPlus setAcceptsFirstMouse:]): (-[OutlineViewPlus acceptsFirstMouse:]): Removed debugging messages I accidentally left in here.
7:32 PM Changeset in webkit [1151] by rjw
  • 4 edits in trunk/WebKit

Fixed exception in log code.

6:59 PM Changeset in webkit [1150] by rjw
  • 15 edits in trunk

Fixed 2926153, not getting correct messages after cancel.
Fixed leak of mouse events (Darin wanted this ASAP).

Added another symbol for stack based event constructor.
Change to support onLoad.

5:19 PM Changeset in webkit [1149] by cblu
  • 15 edits in trunk

WebCore:

Changed slotData to slotData(NSString *encoding, const char *bytes, int length)

  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.mm: (KHTMLPart::slotData):
  • libwebcore.exp:

WebKit:

Removed retain of the URL handle. This was causing everything to leak.

  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:part:]): (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): (-[IFMainURLHandleClient processData:isComplete:]):
5:08 PM Changeset in webkit [1148] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): Remove code that makes us the first responder. That's up to the higher levels, not the web view.
1:53 PM Changeset in webkit [1147] by darin
  • 4 edits in trunk/WebCore

Fixed 2925291 -- CSS2 test page causes infinite recursion, crash

  • khtml/rendering/render_container.cpp: (RenderContainer::addChild): Add code to detect the case of a render object that uses text cell style but is not itself a text style, and make sure we don't try to nest such an object inside an infinite number of tables.
12:16 PM Changeset in webkit [1146] by sullivan
  • 4 edits in trunk/WebKit
  • History.subproj/IFURIEntry.h: Oops, deleted the prototype for setLastVisitedDate accidentally, which made Jersey sad.
11:07 AM Changeset in webkit [1145] by sullivan
  • 9 edits
    1 delete in trunk/WebKit

Fixed 2919027 -- Need to remove unused code in WebKit/History.subproj

  • History.subproj/IFAttributedURL.h: Removed.
  • History.subproj/IFBackForwardList.h: Removed large #ifdef.
  • History.subproj/IFURIEntry.h,
  • History.subproj/IFURIEntry.m: Removed all mention of unused fields comment, creationDate, modificationDate
  • WebKit.pbproj/project.pbxproj: Updated for removed file.
6:52 AM Changeset in webkit [1144] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQListImpl.mm: (KWQListIteratorImpl::KWQListIteratorImpl): Add a missing check for a null pointer.
  • kwq/KWQGuardedPtr.mm: (KWQGuardedPtrBase::KWQGuardedPtrBase): Remove an unnecessary call to "toFirst", because new iterators already default to pointing to the first element of the list.

May 13, 2002:

11:16 PM Changeset in webkit [1143] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): Detach all the iterators from the list when the list is destroyed. I thought this was done before, but it seems not.
10:43 PM Changeset in webkit [1142] by cblu
  • 16 edits in trunk/WebKit

Added support for setting the content policy on the location change handler
and data source at any time instead of depending on an immediate response.

  • WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController haveContentPolicy:andPath:forLocationChangeHandler:]):
  • WebView.subproj/IFMainURLHandleClient.h:
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:part:]): (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient setContentPolicy:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): (-[IFMainURLHandleClient processData:isComplete:]):
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setContentPolicy:]):
  • WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]):
7:57 PM Changeset in webkit [1141] by darin
  • 13 edits in trunk/WebCore

Fixed bug 2922884 (JavaScript object leak creating Image object from JavaScript).
There was a reference loop created when a document contained a variable that
referenced an image, because images held references to the document; the C++
kind that do not participate in the JavaScript garbage collection.

  • khtml/ecma/kjs_html.h: Use a QGuardedPtr to the DocumentImpl instead of using a Document object.
  • khtml/ecma/kjs_html.cpp: (Image::tryPut): Change because the "doc" pointer is now a pointer to the DocumentImpl, not the Document. Also check for 0, since it's now a QGuardedPtr that can become 0. (Image::Image): Newly out of line. Changed because the "doc" pointer is now a pointer to the DocumentImpl, not the Document.

Since the solution used QGuardedPtr, I had to implement it.

  • kwq/qt/qguardedptr.h: Put the implementation in a new KWQGuardedPtrBase class, with only the bare minimum in a template. This new implementation uses iterators on a QPtrList, which means there's not much code needed.
  • kwq/KWQGuardedPtr.mm: (KWQGuardedPtrBase::KWQGuardedPtrBase): Rewrite to use a QPtrListIterator to a dummy list in the QObject. This reuses code nicely, but a custom-coded solution would be a bit more efficient.
  • kwq/qt/qobject.h:
  • kwq/KWQObject.mm: (QObject::QObject): Create the one-element list that's used by the QGuardedPtr instances.

Since the above code needed to copy a QPtrListIterator, I needed to support that.

  • kwq/qt/qlist.h: Move the iterator's copy constructor out of the private part, and implement it. This class was strange in that it has a public assignment operator, but a private unimplemented copy constructor. Implementing it was trivial, though, so this was no obstacle.
7:56 PM Changeset in webkit [1140] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/value.h: Fix comment typos.
7:30 PM Changeset in webkit [1139] by mjs
  • 3 edits in trunk/WebKit
  • Makefile.am: Make WebCore precompiled headers depend on config.h to fix build breakage from last change.

WebKit:

  • WebKitPrefix.h: Gratuitous change to make the prefix file rebuild.
5:27 PM Changeset in webkit [1138] by mjs
  • 5 edits
    2 deletes in trunk/WebCore

Removed libjpeg dependency. Turns out we don't need it.

  • configure.in: Don't check for libjpeg.
  • Updates/update: Don't bother with the libjpeg update.
  • Updates/install-libjpeg.sh: Removed.

WebCore:

Removed libjpeg dependency. Turns out we don't need it.

  • Makefile.am: Remove -ljpeg from link line.
  • khtml/misc/loader_jpeg.cpp: Removed.
  • khtml/misc/loader_jpeg.h: Removed.
  • khtml/misc/Makefile.am: Remve loader_jpeg from build.
11:22 AM Changeset in webkit [1137] by cblu
  • 11 edits in trunk/WebKit
  • WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController URLPolicyForURL:]):

Use [IFURLHandle canInitWithURL] instead of hard-coded URL schemes.

  • WebView.subproj/IFBaseWebControllerPrivate.mm: (-[IFBaseWebController _mainReceivedProgress:forResource:fromDataSource:]):
  • WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
  • WebView.subproj/IFWebDataSourcePrivate.h:
  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate init]): (-[IFWebDataSource _setDownloadPath:]):

Removed _contentPolicy as contentPolicy is public.

Initialize contentPolicy in [IFWebDataSourcePrivate init].

Note: See TracTimeline for information about the timeline view.