Timeline
May 21, 2002:
- 6:51 PM Changeset in webkit [1191] by
-
- 4 edits in trunk/WebKit
Fixed baseline regression. Obvious of sites that have tables w/ backgrounds,
i.e. www.slashdot.org.
- 5:36 PM Changeset in webkit [1190] by
-
- 19 edits in trunk
Lots of changes for DHTML.
Bugs fixes, and fixes to regressions.
Changes to support additional DHTML events.
- 2:54 PM Changeset in webkit [1189] by
-
- 5 edits in trunk/WebCore
2002-05-21 Kenneth Kocienda <kocienda@apple.com>
Fix for this bug:
Radar 2924728 (post form fails at pt.apple.com; succeeds at macosx.apple.com)
Posted forms are now submitted with the IFURLHandleFlagLoadFromOrigin
load flag set. This prevents a potential bug which may cause a page
with a form that uses itself as an action to be returned from the
cache without submitting.
- kwq/KWQKHTMLPart.mm: (KHTMLPart::submitForm)
- 1:48 PM Changeset in webkit [1188] by
-
- 8 edits in trunk/WebKit
WebFoundation:
Fix for 2925907 - [IFURLHandle resourceData] returns nil until load is complete
- CacheLoader.subproj/IFURLHandle.m: (-[IFURLHandle resourceData]):
WebKit:
Content policy can now be sent at a later time to avoid blocking.
- WebView.subproj/IFMainURLHandleClient.h:
- WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:part:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
- 10:25 AM Changeset in webkit [1187] by
-
- 5 edits in trunk/WebKit
Move the tracking rect after the view has moved.
- Plugins.subproj/IFPluginView.mm: (-[IFPluginView viewHasMoved:]):
Fixed logging.
- Plugins.subproj/npapi.m: (NPN_UserAgent): (NPN_MemAlloc): (NPN_MemFree): (NPN_MemFlush): (NPN_ReloadPlugins):
- 7:50 AM Changeset in webkit [1186] by
-
- 7 edits in trunk
2002-05-21 Kenneth Kocienda <kocienda@apple.com>
Merged these four include files into the precompiled header.
These are used for the enhanced assertion/debuggin support I
added yesterday.
<signal.h>
<sys/types.h>
<sys/time.h>
<sys/resource.h>
- WebCore/WebCorePrefix.h
- WebFoundation/WebFoundationPrefix.h
- WebKit/WebFoundationPrefix.h
- WebFoundation/WebFoundation.pbproj/project.pbxproj: PB decided that this file changed in some cryptic way.
May 20, 2002:
- 6:19 PM Changeset in webkit [1185] by
-
- 8 edits in trunk/WebKit
Added support for plug-ins to send URL requests to certain targets.
Added frameNamed to IFWebFrame.
- Plugins.subproj/IFPluginView.mm: (-[IFPluginView getURLNotify:target:notifyData:]): (-[IFPluginView postURLNotify:target:len:buf:file:notifyData:]):
- WebView.subproj/IFWebFrame.h:
- WebView.subproj/IFWebFrame.mm: (-[IFWebFrame frameNamed:]):
- 5:51 PM Changeset in webkit [1184] by
-
- 3 edits1 add in trunk/WebCore
Forgot one file.
- khtml/khtml_part.moc: Added.
- 5:30 PM Changeset in webkit [1183] by
-
- 47 edits25 adds2 deletes in trunk/WebCore
Use more of the original khtml_part.cpp; a step in the direction of factoring
our code out so more of it can go in WebKit and we don't need external.h.
- khtml/Makefile.am:
- khtml/khtml_part.cpp:
- khtml/khtml_part.h:
- khtml/khtmlpart_p.h: Start compiling khtml_part.cpp and using khtmlpart_p.h again.
- kwq/KWQKHTMLPart.mm: Remove code that was identical to khtml_part.cpp. We aren't going to use the "copy and hack our copy" approach on this class for the long termk, and this is the first step in cleaning things up.
- khtml/khtml_ext.h: Removed.
- khtml/khtml_factory.h: Removed.
- khtml/misc/loader.h:
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector): Remove some APPLE_CHANGES ifdefs we don't need any more.
- kwq/KWQDateTime.mm: Simplify things like copy constructors.
- kwq/kdeui/kcursor.h:
- kwq/KWQKCursor.mm: Add handCursor.
- kwq/KWQKHTMLFactory.mm: Put in real implementations, not just placeholders.
- kwq/KWQKHTMLPartBrowserExtension.mm:
- kwq/KWQKInstance.mm:
- kwq/KWQPart.mm:
- kwq/KWQbrowserextension.mm: Empty these files out, nothing in them is needed any more.
- kwq/khtml/khtml_settings.h:
- kwq/KWQKHTMLSettings.mm: (KHTMLSettings::isJavaEnabled): (KHTMLSettings::autoLoadImages): (KHTMLSettings::isPluginsEnabled): (KHTMLSettings::isJavaScriptEnabled): (KHTMLSettings::isJavaScriptDebugEnabled): Moved settings here from KWQKHTMLPart.mm
- kwq/kdecore/kurl.h:
- kwq/KWQKURL.mm: (KURL::encodedHtmlRef): (KURL::htmlRef): Placeholders for these two, called in KHTMLPart, but maybe not really needed.
- kwq/KWQKloader.mm: (Cache::preloadScript): (Cache::preloadStyleSheet): Empty functions for these, called in KHTMLPart but no implementation needed.
- kwq/qt/qtimer.h:
- kwq/KWQTimer.mm: (QTimer::isActive): (QTimer::start): (QTimer::stop): More timer functions.
- kwq/qt/qscrollview.h: Add one more function.
- kwq/kdecore/kinstance.h: Simplify.
- kwq/kdeui/kaction.h: Simplify.
- kwq/khtml/khtml_factory.h: Simplify.
- kwq/kparts/browserextension.h: Simplify.
- kwq/kparts/part.h: Simplify.
- kwq/qt/qdatetime.h: Simplify.
- kwq/kdecore/klibloader.h: Added.
- kwq/khtml/khtml_ext.h: Added.
- kwq/kparts/partmanager.h: Added. Nearly-empty files with just simple placeholders so we can compile more.
- kwq/dcop/kdatastream.h: Added.
- kwq/kdecore/kmultipledrag.h: Added.
- kwq/kdecore/ktempfile.h: Added.
- kwq/kdecore/kurldrag.h: Added.
- kwq/kdeui/kstdaction.h: Added.
- kwq/kdeui/kxmlguifactory.h: Added.
- kwq/khtml/khtml_find.h: Added.
- kwq/khtml/khtml_iface.h: Added.
- kwq/khtml/khtml_pagecache.h: Added.
- kwq/khtml/khtml_run.h: Added.
- kwq/kio/kssl/ksslcertchain.h: Added.
- kwq/kio/kssl/ksslinfodlg.h: Added.
- kwq/kio/ktrader.h: Added.
- kwq/qt/private/qucomextra_p.h: Added.
- kwq/qt/qclipboard.h: Added.
- kwq/qt/qmetaobject.h: Added. Empty files just so includes of these names will compile.
- libwebcoretests.exp: Remove one export that's no longer needed.
- 4:43 PM Changeset in webkit [1182] by
-
- 10 edits in trunk/WebCore
Added support for onChange and window.location, i.e.:
http://javascript.internet.com/navigation/menu-automatic.html
- 4:27 PM Changeset in webkit [1181] by
-
- 7 edits in trunk
2002-05-20 Kenneth Kocienda <kocienda@apple.com>
Now includes <sys/time.h> to prevent possible build breakage
in the inclusion of <sys/resource.h>
- WebCore/kwq/kwqdebug.h
- WebKit/Misc.subproj/WebKitDebug.h
- WebFoundation/Misc.subproj/WebFoundationDebug.h
- 3:42 PM Changeset in webkit [1180] by
-
- 4 edits in trunk/WebCore
2002-05-20 Kenneth Kocienda <kocienda@apple.com>
Changed assertion failure code to send a SIGQUIT instead
of raising an NSException.
- kwq/kwqdebug.h
- 3:24 PM Changeset in webkit [1179] by
-
- 3 edits in trunk/WebKit
2002-05-20 Kenneth Kocienda <kocienda@apple.com>
Changed assertion failure code to send a SIGQUIT instead
of raising an NSException.
- Misc.subproj/WebKitDebug.h
- 2:54 PM Changeset in webkit [1178] by
-
- 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m
2002-05-20 Kenneth Kocienda <kocienda@apple.com>
Reviewed by: John Sullivan
Fix for this bug:
Radar 2931078 (IFURLFileDatabase initialization is not threadsafe)
In addition, I have added several assertion checks to the code. Note
that each of these assertion checks is of the "failure should be impossible"
variety.
- Database.subproj/IFURLFileDatabase.m: (-[IFURLFileReader initWithPath:]): (-[IFURLFileDatabaseOp initWithCode:key:object:]): (-[IFURLFileDatabaseOp perform:]): (databaseInit): (-[IFURLFileDatabase initWithPath:]): (-[IFURLFileDatabase setObject:forKey:]): (-[IFURLFileDatabase removeObjectForKey:]): (-[IFURLFileDatabase objectForKey:]): (-[IFURLFileDatabase performSetObject:forKey:]): (-[IFURLFileDatabase performRemoveObjectForKey:]): (-[IFURLFileDatabase lazySync:]):
- 1:56 PM Changeset in webkit [1177] by
-
- 21 edits in trunk/WebKit
WebFoundation:
Added _IF_looksLikeAbsoluteURL.
- Misc.subproj/IFNSStringExtensions.h:
- Misc.subproj/IFNSStringExtensions.m: (-[NSString _IF_looksLikeAbsoluteURL]):
WebKit:
Summary:
- Drag & Drop support.
- A whole lot of plug-in clean-up and minor bug fixes.
Moved the following functions from npapi to IFPlugin.
- Plugins.subproj/IFPlugin.m: (functionPointerForTVector): (tVectorForFunctionPointer):
Only supply mouse coords when active.
- Plugins.subproj/IFPluginNullEventSender.h:
- Plugins.subproj/IFPluginNullEventSender.m: (-[IFPluginNullEventSender initializeWithNPP:functionPointer:window:]): (-[IFPluginNullEventSender dealloc]): (-[IFPluginNullEventSender sendNullEvents]):
Minor clean-ups
- Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream dealloc]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]):
Removed the isMouseDown flag from the following functions
as it was unnecessary.
Cleaned up logging.
- Plugins.subproj/IFPluginView.mm: (-[IFPluginView modifiersForEvent:]): (-[IFPluginView getCarbonEvent:withEvent:]): (-[IFPluginView sendUpdateEvent]): (-[IFPluginView becomeFirstResponder]): (-[IFPluginView resignFirstResponder]): (-[IFPluginView mouseDown:]): (-[IFPluginView mouseUp:]): (-[IFPluginView mouseExited:]): (-[IFPluginView setWindow]): (-[IFPluginView start]): (-[IFPluginView stop]):
URLForString now uses _IF_looksLikeAbsoluteURL.
(-[IFPluginView URLForString:]):
Implemented the following:
(-[IFPluginView invalidateRect:]):
(-[IFPluginView invalidateRegion:]):
(-[IFPluginView forceRedraw]):
Put implementation of GetValue SetValue in npapi.
- Plugins.subproj/npapi.h:
- Plugins.subproj/npapi.m: (NPN_GetValue): (NPN_SetValue):
Added drag & drop support.
- WebView.subproj/IFWebView.mm: (-[IFWebView initWithFrame:]): (-[IFWebView setCanDragFrom:]): (-[IFWebView canDragFrom]): (-[IFWebView setCanDragTo:]): (-[IFWebView canDragTo]): (-[IFWebView draggingEntered:]): (-[IFWebView prepareForDragOperation:]): (-[IFWebView performDragOperation:]):
- WebView.subproj/IFWebViewPrivate.h:
- WebView.subproj/IFWebViewPrivate.mm: (-[IFWebViewPrivate dealloc]):
- 12:15 PM Changeset in webkit [1176] by
-
- 17 edits4 adds in trunk/WebKit
- fixed 2923492 -- No way to put separators in Bookmarks menu
- fixed 2927561 -- Added child of bookmarks folder should be first, not last
- fixed 2927575 -- New bookmark should have blank URL
- fixed 2927589 -- "Modify" and "Remove" should be "Edit" and "Delete"
- fixed 2923220 -- Bookmarks window should reopen at launch if it was open at quit
- fixed bug where bookmark window would sometimes start with a horiz scrollbar
- fixed bug where deleting nested bookmark would leave last row selected
- PreferenceKeys.h: define ShowBookmarksPreferenceKey
- AppController.m: (-[AppController applicationDidFinishLaunching:]): Open bookmarks window if preference says to. (-[AppController _insertBookmark:intoMenu:atIndex:]): Handle separators.
- BookmarksController.m: (-[BookmarksController windowDidLoad]): Set self as delegate so we will receive windowWillClose:; setAutoresizesOutlineColumn:NO so column widths won't change at launch. (-[BookmarksController removeSelectedBookmarks:]): Reselect previously selected item if it's still valid (-[BookmarksController _newItemWithTitle:image:URLString:type:]): Change isLeaf parameter to bookmark type. Handle separators (don't edit title of newly-created separator). If expanded folder is selected, make new item first. (-[BookmarksController _newSeparator:]): Implemented. (-[BookmarksController outlineView:objectValueForTableColumn:byItem:]): Return "--" as string to represent separator, for now. (-[BookmarksController _newFolder:]), (-[BookmarksController _newBookmark:]): (-[BookmarksController outlineView:isItemExpandable:]): (-[BookmarksController outlineView:validateDrop:proposedItem:proposedChildIndex:]): (-[BookmarksController outlineView:shouldEditTableColumn:item:]): Replaced uses of isLeaf with bookmarkType. (-[BookmarksController toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): Handle separator item. (-[BookmarksController toolbarAllowedItemIdentifiers:]): Include "New Separator" item. (-[BookmarksController showWindow:]): Set "bookmarks showing" preference to YES. (-[BookmarksController windowWillClose:]): Set "bookmarks showing" preference to NO.
- BrowserDocument.m: (-[BrowserDocument addBookmark:]): Replaced use of isLeaf with bookmarkType.
- GlobalHistory.m: (-[GlobalHistory addSelectedItemsToBookmarks:]): Replaced use of isLeaf with bookmarkType.
- Resources/Images/new_separator.tiff: Added.
- WebBrowser.pbproj/project.pbxproj: Updated for new file.
May 19, 2002:
- 9:02 AM Changeset in webkit [1175] by
-
- 16 edits in trunk/WebCore
- khtml/rendering/render_object.cpp: (RenderObject::drawBorder): Add missing break statement so borders don't draw strangely.
- khtml/rendering/render_style.h: Remove unneeded QColor workaround, now that we handle invalid colors properly.
- kwq/KWQColor.mm: (createStaticConstructorAutoreleasePool): New solution to the problem of autorelease at static constructor time. (getNamedColors): Function that creates this dictionary when needed rather than creating it inside an init function. (QColor::QColor): Share code with setRgb, get rid of _initialize. (hex2int): Return -1 for bad digit rather than 0. (decodeColorFromHexColorString): Make more robust and simpler. (QColor::setNamedColor): Set color to invalid rather than black when the passed in name is empty or unrecognized. (QColor::red), (QColor::green), (QColor::blue): Round instead of truncating. (QColor::setRgb): Set color to invalid if r, g, or b is out of range. (QColor::operator=): Simplify. (QColor::operator==): Handle invalid colors correctly. (QColor::getNSColor): Return black of invalid colors.
- kwq/KWQCursor.mm: Simplify cursor globals.
- kwq/KWQPainter.mm: (QPainter::_setColorFromBrush): Use getNSColor() to handle invalid colors correctly. (QPainter::_setColorFromPen): Use getNSColor() to handle invalid colors correctly. (QPainter::drawLine): Add code to respect style and width and handle endpoints in a way that will make the lines look like Qt users expect. (QPainter::drawText): Use getNSColor() to handle invalid colors correctly. (QPainter::drawUnderlineForText): Use getNSColor() to handle invalid colors correctly. (QPainter::fillRect): Use getNSColor() to handle invalid colors correctly.
- kwq/KWQPen.mm: (QPen::QPen): (QPen::setStyle): Remove use of MPenStyle.
- kwq/KWQPixmap.mm: (QPixmap::QPixmap): Add comments.
- kwq/qt/qcolor.h: Simplify ifdefs, remove cname, _initialize, globals_init, and initGlobalColors.
- kwq/qt/qnamespace.h: Remove AlignTop, AlignBottom, SingleLine, ExpandTabs, DontPrint, DashDotLine, DashDotDotLine, MPenStyle, WResizeNoRease, WRepaintNoErase, color0, color1, darkRed, darkGreen, darkBlue, darkCyan, darkMagenta, darkYellow. Simplify the QColor and QCursor globals.
- kwq/qt/qpen.h: QPainter is no longer a friend class. Remove linest.