Timeline

May 30, 2002:

6:48 PM Changeset in webkit [1242] by rjw

• 6 edits in trunk/WebKit

API and comment cleanup.

5:41 PM Changeset in webkit [1241] by mjs

• 36 edits in trunk

WebCore:

WebCore part of fixes for:

Radar 2926169 - no support for window.open
Radar 2890469 - Preference to prevent JavaScript from automatically
opening new windows doesn't work
Radar 2938569 - link cursor does not appear on some pages

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): #ifdef'd out some parts of this code that are broken (but fortunately also unnecessary) in our project.
• kwq/KWQKConfigBase.mm: (KConfig::KConfig): Changes to support JavaScript window opening pref. (KConfig::readUnsignedNumEntry): Likewise.
• kwq/KWQKHTMLPart.mm: (KHTMLPart::openURLInFrame): Implemented.
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::KHTMLPartBrowserExtension): Implemented. (KHTMLPartBrowserExtension::openURLRequest): Implemented by calling openURLInFrame on the part. (KHTMLPartBrowserExtension::createNewWindow): Implemented by calling new WebController openNewWindowWIthURL method.
• kwq/KWQKHTMLSettings.mm: (KHTMLSettings::isJavaScriptEnabled): Handle renaming of pref.
• kwq/KWQView.mm: (-[KWQHTMLView setCursor:]): Fixes to set cursor properly even if none was set.
• kwq/external.h: Declare some new WebKit methods.
• kwq/kparts/browserextension.h: Make formerly empty methods pure virtual.
• kwq/khtml/khtml_ext.h: Declare some virtual methods.

WebKit:

WebKit parts of fixes for:

Radar 2926169 - no support for window.open
Radar 2890469 - Preference to prevent JavaScript from automatically
opening new windows doesn't work
Radar 2938569 - link cursor does not appear on some pages

• WebView.subproj/IFWebController.h: Added openNewWindowWithURL: method for the benefit of JavaScript.
• WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController openNewWindowWithURL:]): No-op default implementation.
• WebView.subproj/IFDynamicScrollBarsView.h:
• WebView.subproj/IFDynamicScrollBarsView.m: (-[IFDynamicScrollBarsView setCursor:]): Fix cursor handling. (-[IFDynamicScrollBarsView resetCursorRects]): Likewise.
• WebView.subproj/IFWebView.mm: (-[IFWebView mouseMovedNotification:]): Likewise. (-[IFWebView setCursor:]): Likewise.
• WebView.subproj/IFPreferences.h:
• WebView.subproj/IFPreferences.mm: (-[IFPreferences javaScriptEnabled]): Renamed from jScriptEnabled. (-[IFPreferences setJavaScriptEnabled:]): Renamed from setJScriptEnabled. (-[IFPreferences javaScriptCanOpenWindowsAutomatically]): New method. (-[IFPreferences setJavaScriptCanOpenWindowsAutomatically:]): Likewise.
• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:view:provisionalDataSource:controller:]): Create a dummy provisional data source if none is provided, so we always have a part for the frame.

WebBrowser:

2:52 PM Changeset in webkit [1240] by darin

• 61 edits
  6 adds
  1 delete in trunk

WebCore:

Cut down our copied and pasted code even more.

• WebCore.exp: Change what's exported for things that moved from KHTMLPart into KWQKHTMLPartImpl.

• khtml/.cvsignore:
• khtml/css/.cvsignore:
• khtml/dom/.cvsignore:
• khtml/ecma/.cvsignore:
• khtml/html/.cvsignore:
• khtml/java/.cvsignore:
• khtml/misc/.cvsignore:
• khtml/rendering/.cvsignore:
• khtml/xml/.cvsignore: Some .cvsignore hygiene.

• khtml/khtml_part.cpp: Use a lot more of this file, rather than using a copy inside the kwq directory. Now we have KWQKHTMLPartImpl for the part that does need to be in kwq.
• khtml/khtml_part.h: Add KWQKHTMLPartImpl pointer, remove most of the other APPLE_CHANGES.
• khtml/khtmlpart_p.h: Remove almost all of the APPLE_CHANGES.
• kwq/KWQKHTMLPart.mm: Changed everything from being part of KHTMLPart to be a separate KWQKHTMLPartImpl class. Minimized copied and pasted code; still more to do.
• kwq/KWQKHTMLPartImpl.h: Added. Interface so KHTMLPart can call into kwq as necessary.

• khtml/misc/Makefile.am: Added loader.cpp.
• khtml/misc/loader.cpp: Added from KDE 3.0. Rolled most of the changes from KWQKloader.mm in here. The kwq-specific part is now in a KWQLoaderImpl class.
• khtml/misc/loader.h: Replace LoaderPrivate with KWQLoaderImpl.
• khtml/misc/loader.moc: Added empty file.
• kwq/KWQKloader.mm: Changed everything to be a separate KWQLoaderImpl class. Minimized copied and pasted code.
• kwq/KWQLoaderImpl.h: Added. Interface so loader can call into kwq as necessary.
• kwq/loader.moc: Removed empty file.

• kwq/kparts/historyprovider.h: Add HistoryProvider::insert.
• kwq/KWQKHistoryProvider.mm: Add HistoryProvider::insert.

• kwq/KWQKLocale.mm: (KLocale::language): Simplify.

• kwq/KWQListBox.h:
• kwq/KWQNSTextField.h: Use import instead of include for Cocoa.h.

• kwq/KWQScrollView.mm: (QScrollView::contentsToViewport): Implement this.

• kwq/external.h: Add declarations so this can be included cleanly.

• kwq/khtml/khtml_pagecache.h: Put a no-op cache in here so we don't have to do so many APPLE_CHANGES ifdefs.

• kwq/kparts/part.h: Put ref/deref and event/customEvent in here so they don't need to be added to KHTMLPart.

• kwq/kio/scheduler.h: Add <qtimer.h> include to help us build (not sure if it's really needed.
• kwq/kparts/partmanager.h: Add <qdatetime.h> include to help us build (not sure if it's really needed.

WebKit:

Use methods in KWQKHTMLPartImpl that were moved there from KHTMLPart.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): (-[IFMainURLHandleClient processData:isComplete:allDataReceived:]):
• WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource documentText]):
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setController:]):
• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):
• WebView.subproj/IFWebView.mm: (-[IFWebView provisionalDataSourceChanged:]):

2:01 PM Changeset in webkit [1239] by mjs

• 4 edits in trunk/JavaScriptCore

• THANKS: Demangled.

11:55 AM Changeset in webkit [1238] by cblu

• 6 edits in trunk/WebKit

Use NSWorkspace methods instead of Launch Services and Finder functions.

• MIME.subproj/IFDownloadHandler.h:
• MIME.subproj/IFDownloadHandler.mm:
• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]):

9:15 AM Changeset in webkit [1237]

• 7 copies
  1 delete in tags/Alexander-7

This commit was manufactured by cvs2svn to create tag 'Alexander-7'.

9:15 AM Changeset in webkit [1236] by sheridan

• 8 edits in trunk

Alex-7 version

8:38 AM Changeset in webkit [1235] by rjw

• 4 edits in trunk/WebKit

Added 'canDraw' check to ensure that we can render
an image frame.

May 29, 2002:

10:13 PM Changeset in webkit [1234] by rjw

• 10 edits
  3 adds in trunk/WebCore

Changes to support animated image rendering.
Moved image rendering into webkit.

10:12 PM Changeset in webkit [1233] by rjw

• 13 edits
  8 adds in trunk/WebKit

Changes to support animated image rendering.
Moved image rendering into webkit.
Still need to implement preferences stubs and
start/stop stubs.

1:26 PM Changeset in webkit [1232] by sullivan

• 4 edits in trunk/WebKit

Removed acceptsFirstMouse override, this fixes at least:

2930713 -- clicking on an empty part of window to bring it to front
takes focus away from page address field

2938028 -- Link cursor doesn't appear when browser window not
frontmost, but clicks activate links

• WebView.subproj/IFWebView.mm:

May 28, 2002:

5:00 PM Changeset in webkit [1231] by rjw

• 6 edits in trunk/WebCore

Moved cancellation check before creation on job instance,
preventing leak.

4:55 PM Changeset in webkit [1230] by sullivan

• 16 edits in trunk/WebKit

Made -[IFBookmark group] and -[IFBookmark parent] public
methods, and renamed them to not use leading underscores,
as part of support for revealing a particular bookmark in
the Bookmarks window.

• Bookmarks.subproj/IFBookmark_Private.h: removed _group and _parent.

• Bookmarks.subproj/IFBookmark.h: added group and parent.

• fixed 2923488 -- Silent failure when bookmark URL is invalid URL
• fixed 2935830 (urls in Bookmarks should be "canonicalized" like urls in location field)
• fixed 2935388 (errors in Activity window shouldn't show numeric error codes)

• IFBookmarkAdditions.h: Added.
• IFBookmarkAdditions.m: Added. (-[IFBookmark goTo]): New category, adds browser-specific behavior to IFBookmark. The first and only method so far goes to the bookmark's address; if the address string can't be turned into a valid URL, the user is told and given an opportunity to fix the address.

• AppController.h:
• AppController.m: (-[AppController showBookmarks:]): Moved initialization of _bookmarksController ivar out of here. (-[AppController _takeLocationFromBookmark:]): Now calls -[IFBookmark goTo]. (-[AppController bookmarksController]): New public method, initializes _bookmarksController ivar if necessary.

• BookmarksController.h:
• BookmarksController.m: (-[BookmarksController _goToSelectedItem:]): Now calls -[IFBookmark goTo]. (-[BookmarksController _expandAncestorsOfBookmark:]): New method, ensures that each ancestor folder of the specified bookmark is expanded in the outline view. (-[BookmarksController revealBookmark:]): New method, expands the bookmark's ancestors, then selects the bookmark and scrolls to reveal as necessary. (-[BookmarksController _editSelectedColumnWithID:]): New helper method, edits the contents of the specified column for the selected row. (-[BookmarksController editSelectedAddress]), (-[BookmarksController editSelectedName]): New methods, they call _editSelectedColumnWithID: for different columns. (-[BookmarksController _toggleEdit:]): Now calls editSelectedName.

• IFErrorAdditions.m: (-[IFError errorSummary]): Removed error code from the string this method returns.

• WebBrowser.pbproj/project.pbxproj: Updated for new files; also added new WebKit Additions group and moved some existing files into it.

4:17 PM Changeset in webkit [1229] by rjw

• 7 edits in trunk/WebCore

Fixed edge case cancellation problem (actually happens a lot).
No new loads are allowed after a data source has been
set as "stopping".

3:11 PM Changeset in webkit [1228] by rjw

• 4 edits in trunk/WebKit

Backed out band-aid add to fixed malformed resources URLs.

3:10 PM Changeset in webkit [1227] by rjw

• 7 edits in trunk/WebCore

Fixed reporting of malformed resources URLs. This fixed
exceptions that were being thrown because nil handles were
being added to datasource handle array.

2:07 PM Changeset in webkit [1226] by cblu

• 4 edits in trunk/WebKit

* empty log message *

1:18 PM Changeset in webkit [1225] by rjw

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Fixed double free of mapped file bytes (it's freed
by munmap).

11:34 AM Changeset in webkit [1224] by cblu

• 15 edits in trunk

WebBrowser:

Drag & Drop of file and URL support for the location field.

• LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): Added URL and file drag types (-[LocationFieldEditor draggingEntered:]): new (-[LocationFieldEditor draggingUpdated:]): new (-[LocationFieldEditor prepareForDragOperation:]): new (-[LocationFieldEditor performDragOperation:]): new (-[LocationFieldEditor concludeDragOperation:]): support for URL and file types

WebKit:

• Plugins.subproj/IFPluginDatabase.h:
• Plugins.subproj/IFPluginDatabase.m: (-[IFPluginDatabase pluginForMimeType:]): renamed (-[IFPluginDatabase pluginForExtension:]): renamed (-[IFPluginDatabase pluginForFilename:]): renamed (findPlugins):
• WebCoreSupport.subproj/IFWebCoreViewFactory.m: support for above renamed (-[IFWebCoreViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[IFWebCoreViewFactory viewForJavaAppletWithArguments:]):
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _addURLHandle:]): fix for a nil handle being added to an array

WebCore:

Added framework-header-stamp

• .cvsignore:

WebFoundation:

Fix for 2938040 - This flash movie at macboy.com doesn't load

• Misc.subproj/IFNSStringExtensions.m: (-[NSString _IF_looksLikeAbsoluteURL]):

10:39 AM Changeset in webkit [1223] by darin

• 4 edits in trunk/WebKit

• WebCoreSupport.subproj/IFTextRenderer.m: (hasMissingGlyphs): Use recordSize instead of assuming records are sizeof(ATSLayoutRecord). (-[IFTextRenderer convertCharacters:length:toGlyphs:]): Free buffer after calling ATSUConvertCharToGlyphs; old code was using buffer after freeing it. (-[IFTextRenderer widthForString:]): Handle case where string is longer than LOCAL_GLYPH_BUFFER_SIZE. (-[IFTextRenderer slowPackGlyphsForCharacters:numCharacters:glyphBuffer:numGlyphs:]): (-[IFTextRenderer drawString:atPoint:withColor:]): Use recordSize instead of assuming records are sizeof(ATSLayoutRecord). (-[IFTextRenderer slowFloatWidthForCharacters:length:]): Use recordSize instead of assuming records are sizeof(ATSLayoutRecord). (-[IFTextRenderer floatWidthForCharacters:length:]): Remove extra rounding. The caller that converts the width to an integer already does the rounding. (-[IFTextRenderer extendCharacterToGlyphMapToInclude:]): Fix off by one error that caused us to include one extra character in each glyph map block. Also use recordSize instead of assuming records are sizeof(ATSLayoutRecord).