Timeline

Jun 17, 2002:

7:35 PM Changeset in webkit [1396] by rjw

• 20 edits in trunk

Fixed window.open regression.
Partial fix to targeting frame of new name.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::urlSelected):

Partial fix to frame not found problem.

• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):

Fix for window.open regression.

• kwq/WebCoreBridge.h: Changed return type of openNewWindowWithURL:

Fixed window.open regression.
Partial fix to targeting frame of new name.

• WebCoreSupport.subproj/IFWebCoreBridge.h:
• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge openNewWindowWithURL:]):

Return the newly created bridge.

(-[IFWebCoreBridge receivedData:withDataSource:]):

Use setDataSource: method

(-[IFWebCoreBridge startLoadingResource:withURL:]):

No change.

(-[IFWebCoreBridge setDataSource:]):

New method.

• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView mouseMovedNotification:]):

Selection support.

(-[IFHTMLView mouseDragged:]):

Selection support.

• WebView.subproj/IFWebController.mm: (-[IFWebController haveContentPolicy:andPath:forLocationChangeHandler:]): Only change representation if it hasn't been pre-bound, or if it's class changed.

• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]):

More hackery to support window.open.

• WebController.m: (-[WebController openNewWindowWithURL:]):

Cleanup.

4:49 PM Changeset in webkit [1395] by darin

• 24 edits in trunk

Fixed many of the reasons that we were leaking the world. But we still leak
KHTMLPart objects, so there must be more problems.

• WebCoreSupport.subproj/IFResourceURLHandleClient.m: (+[IFResourceURLHandleClient startLoadingResource:withURL:dataSource:]): Add missing autorelease. Without this, we leak the world. (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Weaken assert. It was firing before.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge receivedData:withDataSource:]): Don't retain the dataSource any more. Without this, we leak the world.

• WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate dealloc]): Release the policy handler too. Without this, we leak the world.

• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]): Release resourceData, representation, downloadPath, encoding, and contentType. Without this, we leak the world.

• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]): Release the dummy data source after setting it up so it doesn't leak.

• WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLViewPrivate dealloc]): Don't release the controller, we didn't retain it. (-[IFHTMLView _resetWidget]): Delete the provisional widget too.

• WebView.subproj/IFWebDataSourcePrivate.h: Remove unused "children" array.

• WebCoreSupport.subproj/IFImageRenderer.m: Fix comment.
• WebView.subproj/IFHTMLView.mm: Fix comments.

4:48 PM Changeset in webkit [1394] by darin

• 11 edits in trunk/WebCore

Fixed a storage leak.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge documentTextFromDOM]): Add a missing autorelease.

Remove a bunch of loader-related APPLE_CHANGES.

• khtml/misc/loader.h: Remove KWQURLLoadClient and KWQLoaderImpl.
• khtml/misc/loader.cpp: (Loader::Loader): Remove unneeded KWQLoaderImpl object. (Loader::~Loader): Remove unneeded KWQLoaderImpl object. (Loader::servePendingRequests): Call KWQServeRequest instead of KWQLoaderImpl::serveRequest. (Loader::slotFinished): Remove unneeded KWQLoaderImpl::objectFinished.

• kwq/KWQLoaderImpl.h:
• kwq/KWQKloader.mm: (KWQServeRequest): Replaces the KWQLoaderImpl class. The rest of what was in this class was obsolete.

3:45 PM Changeset in webkit [1393] by rjw

• 4 edits in trunk/WebKit

Fixed call to renamed progress method.

• Plugins.subproj/IFPluginStream.mm:

1:29 PM Changeset in webkit [1392] by cblu

• 6 edits in trunk/WebKit

WebBrowser:

Implemented save as.

• BrowserDocument.m: (-[BrowserDocument dataRepresentationOfType:]): return main data source's data

(-[BrowserDocument fileType]): added. Return [dataSource fileType]
(-[BrowserDocument _isDocumentHTML]): removed obsolete comments.

• WebBrowser.pbproj/project.pbxproj:

WebKit:

• WebView.subproj/IFWebDataSource.h:
• WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource contentType]): no changes (-[IFWebDataSource fileType]): added. Returns extension based on MIME.

1:23 PM Changeset in webkit [1391] by rjw

• 19 edits in trunk

Fixed www.2cpu.com regression. QWidget::_displayRect was displaying the wrong
view. This was a regression that would impact all DHTML.

• khtml/khtmlview.cpp: (KHTMLView::timerEvent):
• kwq/KWQScrollView.mm: (QScrollView::updateContents):
• kwq/KWQWidget.mm: (QWidget::QWidget): (QWidget::endEditing):
• kwq/qt/qwidget.h:

Added explicit complete check for resources, rather
than depend on bytesSoFar == totalToLoad.

• WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient receivedProgressWithHandle:complete:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidFinishLoading:data:]):
• WebView.subproj/IFWebControllerPrivate.h:
• WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:complete:]):

12:47 PM Changeset in webkit [1390] by cblu

• 4 edits in trunk/WebKit

Fix for 2939881. No more overwritting of one's files.

• Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler receivedData:]): (-[IFDownloadHandler finishedLoading]):

11:18 AM Changeset in webkit [1389] by rjw

• 11 edits in trunk/WebKit

Fixed IFImageViews not drawing correctly.

Changed compeletion to explicity use IFURLHandleResourceDidFinishLoading, rather
than depend on bytesSoFar == totalToLoad.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
• WebView.subproj/IFWebControllerPrivate.h:
• WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):

11:12 AM Changeset in webkit [1388] by darin

• 4 edits in trunk/WebCore

Fixed bug where some images would get left behind when scrolling. Turned out it
was all the tiled images that were getting left behind.

• kwq/KWQPainter.mm: (QPainter::drawTiledPixmap): Fixed to get the view for coordinates from [NSView focusView] the way drawPixmap does, rather than using data->widget->getView(), which gives the scroll view instead of the scrolled view.

Jun 16, 2002:

6:48 PM Changeset in webkit [1387] by darin

• 11 edits in trunk

WebCore:

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::frames): Fixed this function to get from frames to parts properly. It was still assuming that [WebCoreBridge childFrames] would return a list of WebCoreBridge objects, but now it returns WebCoreFrame objects.

• kwq/WebCoreFrame.h: Added [WebCoreFrame bridge] for the case above. Note that it always gives the "committed" bridge, not the provisional one.

WebKit:

• WebCoreSupport.subproj/IFWebCoreFrame.m: (-[IFWebCoreFrame bridge]): Added.

10:27 AM Changeset in webkit [1386] by darin

• 26 edits
  7 adds in trunk

WebCore:

Add a separate WebCoreFrame alongside WebCoreBridge to facilitate
handling of frames with no HTML content in them. This probably fixes
frames named "_blank".

Also fixed the build, because a clean build failed.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::openURLInFrame): (KWQKHTMLPartImpl::urlSelected): (KWQKHTMLPartImpl::requestFrame): (KWQKHTMLPartImpl::submitForm): (KWQKHTMLPartImpl::parentPart): Work with WebCoreFrame objects instead of WebCoreBridge objects when dealing with frame operations -- loading new URLs mainly.

• kwq/WebCoreBridge.h: Removed frame-related operations, now they are on WebCoreFrame. Broke out WebCoreResourceLoader into its own file. Added comments.

• kwq/WebCoreFrame.h: Added.

• kwq/WebCoreResourceLoader.h: Added.
• kwq/KWQKloader.mm: Include WebCoreResourceLoader.h now that it's broken out.

• WebCore-tests.exp: Tests still need QString::latin1(), although we don't need to export it for WebKit any more.

WebKit:

• WebCoreSupport.subproj/IFResourceURLHandleClient.m:
• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge frame]): Added. (-[IFWebCoreBridge parent]): Changed name from parentFrame, to emphasize that this gives a WebCoreBridge. (-[IFWebCoreBridge childFrames]): Return IFWebCoreFrame objects. (-[IFWebCoreBridge childFrameNamed:]): Return IFWebCoreFrame object. (-[IFWebCoreBridge descendantFrameNamed:]): Return IFWebCoreFrame object. (-[IFWebCoreBridge createChildFrameNamed:withURL:renderPart:khtml::allowsScrolling:marginWidth:marginHeight:]): Use the loadURL operation in IFWebCoreFrame. (-[IFWebCoreBridge mainFrame]): Return IFWebCoreFrame object. (-[IFWebCoreBridge frameNamed:]): Return IFWebCoreFrame object.

• WebCoreSupport.subproj/IFWebCoreFrame.h: Added.
• WebCoreSupport.subproj/IFWebCoreFrame.m: Added.
• WebKit.pbproj/project.pbxproj: Update for added files.

• WebView.subproj/IFHTMLViewPrivate.h: Made this includable from plain Objective C.

• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame initWithName:webView:provisionalDataSource:controller:]): Create the IFWebCoreFrame.

• WebView.subproj/IFWebFramePrivate.h: Add _bridgeFrame method for getting IFWebCoreFrame.
• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate dealloc]): Release the IFWebCoreFrame. (-[IFWebFrame _bridgeFrame]): Added.

12:46 AM Changeset in webkit [1385] by darin

• 3 edits in trunk/WebCore/kwq

Forgot to save file.

12:45 AM Changeset in webkit [1384] by darin

• 18 edits
  6 adds in trunk

WebCore:

Moved the IFURLHandleClient subclass to WebKit, so it can some day be merged
with the one for the frames themselves; this one is for resources.

• kwq/kio/jobclasses.h:
• kwq/KWQKjobclasses.mm: (TransferJob::setHandle): Replaced the old TransferJob::begin with this.

• kwq/KWQLoaderImpl.h: Remove setClient.
• kwq/KWQKloader.mm: (-[WebCoreResourceLoader initWithLoader:job:]): Added. (-[WebCoreResourceLoader dealloc]): Added. (-[WebCoreResourceLoader addData:]): Added. (-[WebCoreResourceLoader cancel]): Added. (-[WebCoreResourceLoader finish]): Added. (KWQLoaderImpl::serveRequest): Use [WebCoreBridge startLoadingResource:withURL:].
• khtml/misc/loader.cpp: (Loader::load): Removed unneeded call to setClient.

• kwq/WebCoreBridge.h: Remove unneeded methods. Added [WebCoreBridge startLoadingResource:withURL:].

WebKit:

Moved the IFURLHandleClient subclass here from WebCore, so it can some day be merged
with the one for the frames themselves; this one is for resources.

• WebCoreSupport.subproj/IFResourceURLHandleClient.h: Added.
• WebCoreSupport.subproj/IFResourceURLHandleClient.m: Added.
• WebKit.pbproj/project.pbxproj: Added IFResourceURLHandleClient.h and .m.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge startLoadingResource:withURL:]): Added. Removed all the old methods, with their guts moved into IFResourceURLHandleClient.

12:04 AM Changeset in webkit [1383] by darin

• 11 edits in trunk

WebCore:

Fix frame-related calls. I was always searching all the frames, which was disastrous.
Also do name changes.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::urlSelected): Use descendantFrameNamed rather than frameNamed. (KWQKHTMLPartImpl::requestFrame): Use childFrameNamed rather than frameNamed. (KWQKHTMLPartImpl::frameExists): Use childFrameNamed rather than frameNamed.

• kwq/KWQScrollView.mm: (QScrollView::addChild): Asserts I used while debugging.

• kwq/WebCoreBridge.h: Add new calls. Change names of old ones to include the word frame consistently. (Also bits of new work that will do no harm, but are not really needed yet.)

WebKit:

Update for frame-related changes in WebCore.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebFrame _bridge]): Look at provisional data source first. (-[IFWebCoreBridge dealloc]): Release the data source. (-[IFWebCoreBridge parentFrame]): Renamed. (-[IFWebCoreBridge childFrames]): Renamed. (-[IFWebCoreBridge childFrameNamed:]): Added. (-[IFWebCoreBridge descendantFrameNamed:]): Added. (-[IFWebCoreBridge didFinishLoadingWithHandle:]): Don't call _didStopLoading twice when we finish loading.

Also changed controller getters to call [dataSource controller] and got rid of the
[IFWebCoreBridge controller] method.

Jun 15, 2002:

10:27 PM Changeset in webkit [1382] by rjw

• 22 edits in trunk/WebKit

• Misc.subproj/IFNSViewExtras.h:
• Misc.subproj/IFNSViewExtras.m: (-[NSView _IF_superviewWithName:]): (-[NSView _IF_parentWebView]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView drawRect:]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

• Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): Call _receiveProgress instead of directly calling handler.
• Plugins.subproj/IFPluginView.mm: (-[IFPluginView start]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge loadURL:attributes:flags:inFrame:withParent:]):

Handle changing top frame correctly. Parent may be nil.

(-[IFWebCoreBridge didFinishLoadingWithHandle:]):

Added non-terminal error case.

• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceCommitted:]):

Replaced use of _IF_superviewWithName w/ safer _IF_parentWebView.

• WebView.subproj/IFMainURLHandleClient.mm:
• WebView.subproj/IFWebControllerPrivate.mm: Comment changes.

9:12 PM Changeset in webkit [1381] by darin

• 6 edits in trunk/WebCore

• kwq/KWQKloader.mm: (-[KWQURLLoadClient IFURLHandle:didRedirectToURL:]): Rolled out an assert I added by accident that will break Deployment builds.

9:03 PM Changeset in webkit [1380] by darin

• 4 edits in trunk/WebKit

• WebCoreSupport.subproj/IFWebCoreBridge.mm: Added a lot of assertions that I had used while debugging. (-[IFWebCoreBridge didRedirectWithHandle:fromURL:]): Commented out the line of code that calls [serverRedirectTo:forDataSource:]. Our old code was sending this to the web controller (that was a bug). But if we send it to the location change handler, then we confuse Alexander. We may return to this later, uncomment it, and change the interface so the client can tell what is being redirected. We'll need to do that if we want the activity window to show redirected URLs at the time of the redirect.

8:27 PM Changeset in webkit [1379] by darin

• 6 edits in trunk/WebCore

• kwq/KWQKloader.mm: (-[KWQURLLoadClient IFURLHandleResourceDidCancelLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidFinishLoading:data:]): (-[KWQURLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): Fixed the order so the URL handles are removed before we send notifications as before my change. This seems to fix the rest of the breakage.

7:31 PM Changeset in webkit [1378] by darin

• 6 edits in trunk/WebCore

• kwq/KWQKloader.mm: (-[KWQURLLoadClient initWithLoader:bridge:]): Fix bridge/m_bridge typo that was responsible for at least some of the breakage I caused.

3:15 PM Changeset in webkit [1377] by rjw

• 12 edits in trunk

2002-06-15 Richard Williamson <​rjw@apple.com>

Fixed factoring problem.

• kwq/KWQScrollView.mm: (-[NSView _IF_getDocumentView]): (-[NSView _IF_isScrollView]): (QScrollView::visibleWidth): (QScrollView::visibleHeight): (QScrollView::contentsWidth): (QScrollView::contentsHeight): (QScrollView::contentsX): (QScrollView::contentsY): (QScrollView::setContentsPos): (QScrollView::addChild): (QScrollView::resizeContents): (QScrollView::contentsToViewport): (QScrollView::viewportToContents):
• kwq/qt/qscrollview.h:

Fixed _bridge not accounting for provisional data source,
broke access to window.frames during load.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebFrame _bridge]): (-[IFWebCoreBridge children]):
• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]):

2:44 PM Changeset in webkit [1376] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Don't turn negative numbers into 0 for margins. This was a mistake.

2:44 PM Changeset in webkit [1375] by darin

• 4 edits in trunk/WebCore

• kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Implement the rule where a negative number means "don't set the margin".

2:34 PM Changeset in webkit [1374] by darin

• 109 edits
  2 deletes in trunk/WebCore

• kwq/kio/jobclasses.h: Removed import of WebFoundation.h.
• kwq/KWQKjobclasses.mm: Added import of IFURLHandle.h.
• kwq/KWQKloader.mm: Added import of IFError.h and IFURLHandle.h.

• kwq/WCLoadProgress.h: Removed.
• kwq/WCWebDataSource.h: Removed.
• kwq/KWQKHTMLPart.mm: Removed import of WCWebDataSource.h.

• *.mm: Changed all includes to imports using a perl script.

2:02 PM Changeset in webkit [1373] by darin

• 51 edits
  1 delete in trunk

WebCore:

• fixed 2942808 -- remove all calls to WebKit from WebCore

More work on the bridge. Now we don't call anything in WebKit explicitly,
although there are still implicit connections that need to be fixed.

• WebCore.exp: Remove exports that are no longer needed, now that WebKit is using the bridge to get at more things.

• khtml/misc/loader.h:
• khtml/misc/loader.cpp: (CachedCSSStyleSheet::CachedCSSStyleSheet): (CachedScript::CachedScript): (CachedImage::CachedImage): Remove the extra parameter to the CachedObject constructor. We don't need it any more, so we can remove all these APPLE_CHANGES.

• kwq/KWQKHTMLPart.mm: Remove getDataSource.

• kwq/KWQLoaderImpl.h: Remove destructor.
• kwq/KWQKloader.mm: (-[KWQURLLoadClient initWithLoader:bridge:]): Keep the bridge around instead of the data source. (-[KWQURLLoadClient dealloc]): Release the bridge instead of the data source. Also put another workaround for 2954901 here, like in WebKit. (-[KWQURLLoadClient IFURLHandleResourceDidBeginLoading:]): (-[KWQURLLoadClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[KWQURLLoadClient doneWithHandle:error:]): (-[KWQURLLoadClient IFURLHandleResourceDidCancelLoading:]): (-[KWQURLLoadClient IFURLHandleResourceDidFinishLoading:data:]): (-[KWQURLLoadClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[KWQURLLoadClient IFURLHandle:didRedirectToURL:]): (KWQLoaderImpl::setClient): (KWQLoaderImpl::serveRequest): Use the bridge to do all the heavy lifting, and put lots of common code into a doneWithHandle:error: method. Also store the URL so the redirect code works properly for multiple redirects and add asserts like the ones in IFMainURLHandleClient. (KWQLoaderImpl::objectFinished): Add a comment.

• kwq/WebCoreBridge.h: Make header so it can be included from plain Objective C, not just Objective C++. Add a bunch of methods for bridging in to WebCore as opposed to out of WebCore. Add new methods for bridging out from WebCore too for all the progress hooks. Put all the subclass responsibility methods into a protocol in such a way that we don't need to implement them in the base class, and subclasses can set things up so they get errors if they forget to implement anything.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:]): Added. (-[WebCoreBridge addData:withEncoding:]): Added. (-[WebCoreBridge closeURL]): Added. (-[WebCoreBridge end]): Added. (-[WebCoreBridge setURL:]): Added. (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Added. (-[WebCoreBridge documentTextFromDOM]): Added. (-[WebCoreBridge scrollToBaseAnchor]): Added.

• kwq/external.h: Removed.

WebKit:

• fixed 2942808 -- remove all calls to WebKit from WebCore

Update to use the WebCore bridge for more things, reducing
dependencies in both directions. Besides using the bridge for all the
remaining WebCore to WebKit calls, almost no WebKit code deals with
KHTMLPart directly any more, instead the other side of the bridge handles it.

• Plugins.subproj/IFPluginStream.mm: (-[IFPluginStream IFURLHandleResourceDidBeginLoading:]): Remove unneeded casts. (-[IFPluginStream IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFPluginStream IFURLHandleResourceDidFinishLoading:data:]): (-[IFPluginStream IFURLHandleResourceDidCancelLoading:]): (-[IFPluginStream IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFPluginStream IFURLHandle:didRedirectToURL:]): Use the new IFProgress methods to simplify code.

• WebCoreSupport.subproj/IFWebCoreBridge.h: Use the new WebCoreBridge protocol so we get a compiler error if we forget to implement anything. Add a method for IFWebDataSource that gets the WebCoreBridge if it has an IFHTMLRepresentation, and nil otherwise.
• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebDataSource _bridge]): Add; does checking so that it returns nil if the representation is not an IFHTMLRepresentation. This is now used almost everywhere so we don't have to do so much type casting. (-[IFWebCoreBridge loadURL:attributes:flags:inFrame:withParent:]): Remove a stray use of [IFWebCoreBridge dataSource] so we can remove it. (-[IFWebCoreBridge receivedData:withDataSource:]): Use the new [WebCoreBridge openURL:] and [WebCoreBridge addData:] methods from the other side of the bridge so we don't have to deal with the KHTMLPart directly. (-[IFWebCoreBridge addHandle:]): Added. (-[IFWebCoreBridge removeHandle:]): Added. (-[IFWebCoreBridge didStartLoadingWithHandle:]): Added. (-[IFWebCoreBridge receivedProgressWithHandle:]): Added. (-[IFWebCoreBridge didFinishLoadingWithHandle:]): Added. (-[IFWebCoreBridge didCancelLoadingWithHandle:]): Added. (-[IFWebCoreBridge didFailBeforeLoadingWithError:]): Added. (-[IFWebCoreBridge didFailToLoadWithHandle:error:]): Added. (-[IFWebCoreBridge didRedirectWithHandle:fromURL:]): Added.

• WebView.subproj/IFHTMLRepresentation.h: Remove unneeded declarations.
• WebView.subproj/IFHTMLRepresentation.mm: Remove [IFHTMLRepresentation part].
• WebView.subproj/IFHTMLRepresentationPrivate.h: Remove [IFHTMLRepresentation part].

• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Use the bridge.

• WebView.subproj/IFHTMLViewPrivate.mm: Remove a bunch of unused stuff that was there for the render and document tree viewers. I had removed it once before but it got re-added as a side effect of the reorganization process.

• WebView.subproj/IFLoadProgress.h: Remove the unused IFLoadType -- we can add it back if we find that it's needed. It didn't do much good to have it here and only partly implemented, and I don't think it's needed. Added some convenient interfaces for creating IFLoadProgress objects.

• WebView.subproj/IFLoadProgress.mm: Get rid of WCSetIFLoadProgressMakeFunc stuff. (-[IFLoadProgress init]): Added. (-[IFLoadProgress initWithBytesSoFar:totalToLoad:]): Remove type part. (-[IFLoadProgress initWithURLHandle:]): Added. (+[IFLoadProgress progress]): Added. (+[IFLoadProgress progressWithBytesSoFar:totalToLoad:]): Added. (+[IFLoadProgress progressWithURLHandle:]): Added.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient dealloc]): Add more workaround for 2954901. (-[IFMainURLHandleClient IFURLHandleResourceDidBeginLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): Remove unneeded type casts and simplify by using new IFLoadProgress methods. Also simplify access to _bridge by using [IFWebDataSource _bridge].

• WebView.subproj/IFWebControllerPrivate.mm:
• WebView.subproj/IFWebFrame.mm: Remove unneeded include of KHTMLPart header.

• WebView.subproj/IFWebDataSource.mm: (-[IFWebDataSource documentTextFromDOM]):
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _stopLoading]):
• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Use bridge.

1:04 PM Changeset in webkit [1372] by darin

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

• WebFoundation.pbproj/project.pbxproj: Removed explicit PFE_FILE_C_DIALECTS now that Project Builder handles this automatically. Removed explicit USE_GCC3 since that's implicit now.

• CacheLoader.subproj/IFHTTPURLProtocolHandler.m:
• CacheLoader.subproj/IFNetworkSettings.m:
• CacheLoader.subproj/IFURLLoad.m:
• CacheLoader.subproj/IFURLLoadManager.m:
• CookieManager.subproj/IFCookieManager.m:
• Database.subproj/IFURLFileDatabase.m:
• Misc.subproj/IFError.m:
• Misc.subproj/IFFileTypeMappings.m:
• Misc.subproj/IFNSThreadExtensions.m: Use PTHREAD_ONCE_INIT now that the warning is fixed; also make some minor improvements to how it's used, making some globals static rather than extern.

12:59 PM Changeset in webkit [1371] by darin

• 7 edits in trunk/JavaScriptCore

• JavaScriptCore.pbproj/project.pbxproj: Removed explicit PFE_FILE_C_DIALECTS now that Project Builder handles this automatically. Removed explicit USE_GCC3 since that's implicit now. Also, since this project is all C++, only use WARNING_CFLAGS with flags that are appropriate for C++; don't bother breaking out C vs. C++.

• kjs/collector.cpp: Now that the system warning is fixed, use PTHREAD_MUTEX_INITIALIZER and PTHREAD_COND_INITIALIZER.
• kjs/internal.cpp: Use PTHREAD_MUTEX_INITIALIZER.
• kjs/ustring.cpp: Use PTHREAD_ONCE_INIT.

4:55 AM Changeset in webkit [1370] by mjs

• 4 edits in trunk/WebCore

Get current bits per pixel from CoreGraphics, thereby fixing

Radar 2943736 - JavaScript screen.colorDepth and

screen.pixelDepth properties always returns 32,

regardless of real depth

• kwq/KWQPaintDeviceMetrics.mm: (QPaintDeviceMetrics::depth):

4:39 AM Changeset in webkit [1369] by mjs

• 7 edits in trunk

Made Development build mode mean what Unoptimized used to mean.

Removed Unoptimized build mode.

Added a Mixed build mode which does what Deployment used to. All

this to fix:

Radar 2955367 - Change default build style to "Unoptimized"

2:55 AM Changeset in webkit [1368] by mjs

• 5 edits in trunk/WebCore

Removed product and vendor properties, thereby fixing:

Radar 2943751 - JavaScript navigator.product property is

"Konqueror/khtml"

Radar 2943753 - JavaScript navigator.vendor property is "KDE"

• khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): Return undefined for the above

mentioned properties.

Implemented functionality needed for missing Screen properties,

thereby fixing the following

bugs:

Radar 2943730 - JavaScript screen.availHeight property is not

implemented

Radar 2943732 - JavaScript screen.availLeft property is not

implemented

Radar 2943734 - JavaScript screen.availTop property not implemented
Radar 2943735 - JavaScript screen.availWidth property is not

implemented

• kwq/KWQKWinModule.mm: (KWinModule::workArea): Return the correct screen size to fix the

above bugs.

2:42 AM Changeset in webkit [1367] by mjs

• 5 edits in trunk/WebKit

Added temporary workardound for Radar 2954901 by making the

assertion more lenient.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidCancelLoading:]):