Timeline

Jun 23, 2002:

11:17 AM Changeset in webkit [1418] by darin

• 4 edits in trunk/WebKit

• WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Use hasAlpha instead of isOpaque because the latter does not work (Radar 2966937).

Jun 21, 2002:

5:24 PM Changeset in webkit [1417] by darin

• 4 edits in trunk/WebKit

• WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Add back the higher-speed case where we draw directly for opaque animated images.

4:40 PM Changeset in webkit [1416] by darin

• 18 edits in trunk

WebCore:

• kwq/KWQFont.mm: Made it store a copy of the family name instead of storing a reference to the mutable CFString.

• kwq/KWQPainter.mm: (QPainter::drawPixmap): Simplified. (QPainter::drawTiledPixmap): Used the new [tileInRect:].

• kwq/WebCoreImageRenderer.h: Added [tileInRect:], removed [drawInRect:], and also removed view parameter from [beginAnimation].

• kwq/qt/qpixmap.h: Removed unneeded getImageRenderer().

WebKit:

Cache the patterns we make for tiled images for added speed.

• WebCoreSupport.subproj/IFImageRenderer.h: Removed declarations of methods inherited from WebCoreImageRenderer. Added patternColor field.

• WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer dealloc]): Release patternColor. (-[IFImageRenderer beginAnimationInRect:fromRect:]): Get the view with [NSView focusView] rather than taking a parameter that's used only for the animating case. (-[IFImageRenderer tileInRect:fromPoint:]): New. Caches the pattern in the patternColor field.

• WebView.subproj/IFImageView.m: (-[IFImageView drawRect:]): No need to pass view to image renderer any more.

10:38 AM Changeset in webkit [1415] by darin

• 3 edits in trunk/WebCore

Added bug number:

• fixed 2964718 -- crash in KWQCheckCacheObjectStatus

10:24 AM Changeset in webkit [1414] by darin

• 4 edits in trunk/WebKit

Fix rendering of non-opaque animated images.

• WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer nextFrame:]): Use [NSView displayRect:] instead of drawing explicitly so that views behind us get a chance to draw too. This is less efficient than just drawing for opaque images, but NSImage doesn't offer a way to find out if the image is opaque. Also, this changes things a bit because beginAnimationInView gets called again, so we don't have to reschedule the timer.

10:20 AM Changeset in webkit [1413] by darin

• 6 edits in trunk/WebCore

• kwq/KWQKloader.mm: (KWQCheckCacheObjectStatus): Handle case of nil object. Add comments. Remove questionable use of floating point abs() to convert always positive int to uint.