Timeline
Oct 7, 2013:
- 11:14 PM Changeset in webkit [157088] by
-
- 2 edits in trunk/LayoutTests
webaudio/javascriptaudionode-upmix2-8channel-input.html is flaky on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=120148
- platform/mac-wk2/TestExpectations: Removed a duplicate expectation that I overlooked
at first. Note that having separate expectations for Debug and Release doesn't
appear to work.
- 11:09 PM Changeset in webkit [157087] by
-
- 2 edits in trunk/LayoutTests
webaudio/javascriptaudionode-upmix2-8channel-input.html is flaky on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=120148
- platform/mac-wk2/TestExpectations: Updated expectations to cover debug assertions,
and that this is not limited to Lion.
- 11:03 PM Changeset in webkit [157086] by
-
- 2 edits in trunk/LayoutTests
Layout Test mathml/very-large-stretchy-operators.html is failing
https://bugs.webkit.org/show_bug.cgi?id=122490
- platform/mac/TestExpectations: Skipped the test. It's faiing with a timeout and
taking up to 80 seconds.
- 9:44 PM Changeset in webkit [157085] by
-
- 3 edits in trunk/Source/WebCore
EventDispatchBehavior is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=122483
Reviewed by Andreas Kling.
Removed EventDispatchBehavior and changed the return type of determineDispatchBehavior to bool.
Also renamed it to shouldEventCrossShadowBoundary to reflect the semantics more clear.
- dom/EventRetargeter.cpp:
(WebCore::shouldEventCrossShadowBoundary):
(WebCore::EventRetargeter::calculateEventPath):
- dom/EventRetargeter.h:
- 8:43 PM Changeset in webkit [157084] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests progress meter should update more quickly on older Rubies
https://bugs.webkit.org/show_bug.cgi?id=122459
Reviewed by Darin Adler.
- Scripts/run-jsc-stress-tests:
- 8:38 PM Changeset in webkit [157083] by
-
- 3 edits in trunk/Source/WebCore
Make buildRelatedNodeMap and findRelatedNode static to EventRetargeter.cpp
https://bugs.webkit.org/show_bug.cgi?id=122477
Reviewed by Antti Koivisto.
Make EventRetargeter::buildRelatedNodeMap and EventRetargeter::findRelatedNode static local functions
in EventRetargeter.cpp since they're only called in EventRetargeter::calculateAdjustedNodes and don't
depend on any oher member function or variable (EventRetarger doesn't have any member variables).
Also get rid of Vector local variables in both functions as they're redundant.
- dom/EventRetargeter.cpp:
(WebCore::buildRelatedNodeMap): Moved. Replaced Vector<Node*, 32> relatedNodeStack by a single pointer
since the only time we add an item to this Vector is when it's empty, and we always use or remove the
last item.
(WebCore::addRelatedNodeForUnmapedTreeScopes): Renamed from EventRetargeter::findRelatedNode. Removed
Vector<TreeScope*, 32> parentTreeScopes since it only contains the ancestor tree scopes of scope up to
a tree scope already in relatedNodeMap. We could simply remember this tree scope and re-traverse the
ancestor tree scopes in the second loop.
(WebCore::EventRetargeter::calculateAdjustedNodes):
- dom/EventRetargeter.h:
- 8:29 PM Changeset in webkit [157082] by
-
- 3 edits in trunk/Source/JavaScriptCore
Pass VM instead of ExecState to JSNotAnObject constructor.
<https://webkit.org/b/122474>
Reviewed by Sam Weinig.
JSNotAnObject was only using the ExecState to find the VM.
- 8:28 PM Changeset in webkit [157081] by
-
- 5 edits in trunk/Source/WebCore
CTTE: EditCommand always has a Document.
<https://webkit.org/b/122473>
Reviewed by Anders Carlsson.
Store a Ref<Document> in EditComment since it's never null.
Since Ref enforces more const consistency than RefPtr, I had to make
document() and frame() non-const here. Only a single method depended
on the old half-const behavior.
- 8:26 PM Changeset in webkit [157080] by
-
- 1 edit5 adds in trunk/LayoutTests
Gardening: add baselines for new tests.
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.png: Added.
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.png: Added.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.png: Added.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.png: Added.
- 7:49 PM Changeset in webkit [157079] by
-
- 2 edits in trunk/LayoutTests
Gardening: skip audio/video track tests, since those are not yet supported by our
media player.
- platform/gtk/TestExpectations:
- 7:40 PM Changeset in webkit [157078] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Marking svg/animations/svglengthlist-animation-3.html as flaky.
- platform/gtk/TestExpectations:
- 6:59 PM Changeset in webkit [157077] by
-
- 4 edits in trunk/Source/WTF
Improve HashMap::add comment and other similar comments
https://bugs.webkit.org/show_bug.cgi?id=122432
Reviewed by Andreas Kling.
- wtf/HashCountedSet.h:
- wtf/HashMap.h:
- wtf/HashSet.h:
Updated comment wording. They were a bit old and out of date.
They also featured the word "interator".
- 6:37 PM Changeset in webkit [157076] by
-
- 2 edits in trunk/Source/WebCore
Update test again.
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback):
- 6:34 PM Changeset in webkit [157075] by
-
- 29 edits in trunk/Source/WebCore
Unreviewed, rolling out r157061.
http://trac.webkit.org/changeset/157061
https://bugs.webkit.org/show_bug.cgi?id=122479
Broke worker tests (Requested by andersca on #webkit).
- Modules/webdatabase/Database.cpp:
(WebCore::DerefContextTask::create):
(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):
(WebCore::DeliverPendingCallbackTask::create):
(WebCore::DeliverPendingCallbackTask::performTask):
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask):
(WebCore::Database::scheduleTransactionCallback):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::DatabaseManager::openDatabase):
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::~WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
- bindings/js/JSCallbackData.h:
(WebCore::DeleteCallbackDataTask::create):
(WebCore::DeleteCallbackDataTask::performTask):
(WebCore::DeleteCallbackDataTask::isCleanupTask):
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
- dom/CrossThreadTask.h:
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask1::performTask):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask2::performTask):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask3::performTask):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask4::performTask):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask5::performTask):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask6::performTask):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask7::performTask):
(WebCore::CrossThreadTask8::create):
(WebCore::CrossThreadTask8::performTask):
(WebCore::createCallbackTask):
- dom/Document.cpp:
(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ProcessMessagesSoonTask::create):
(WebCore::ProcessMessagesSoonTask::performTask):
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
- dom/StringCallback.cpp:
(WebCore::StringCallback::scheduleCallback):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::CallCacheListenerTask::create):
(WebCore::CallCacheListenerTask::CallCacheListenerTask):
(WebCore::ApplicationCacheGroup::postListenerTask):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::SharedWorkerConnectTask::create):
(WebCore::SharedWorkerConnectTask::performTask):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
- workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::enqueueEvent):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
- workers/WorkerGlobalScope.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerGlobalScopeTask::create):
(WebCore::MessageWorkerGlobalScopeTask::performTask):
(WebCore::MessageWorkerTask::create):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerExceptionTask::performTask):
(WebCore::WorkerGlobalScopeDestroyedTask::create):
(WebCore::WorkerGlobalScopeDestroyedTask::performTask):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerTerminateTask::WorkerTerminateTask):
(WebCore::WorkerTerminateTask::performTask):
(WebCore::WorkerThreadActivityReportTask::create):
(WebCore::WorkerThreadActivityReportTask::performTask):
(WebCore::PostMessageToPageInspectorTask::create):
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::NotifyNetworkStateChangeTask::create):
(WebCore::NotifyNetworkStateChangeTask::NotifyNetworkStateChangeTask):
(WebCore::NotifyNetworkStateChangeTask::performTask):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::create):
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownFinishTask::isCleanupTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
- 6:28 PM Changeset in webkit [157074] by
-
- 4 edits in trunk/Source
Make Vector::insert work for move-only types
https://bugs.webkit.org/show_bug.cgi?id=122429
Reviewed by Anders Carlsson.
Source/WebCore:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::padDailyCountsForNewVisit): Call insertVector.
Also added some inline capacity, which should make this faster.
Source/WTF:
- wtf/Vector.h:
(WTF::Vector::insert): Take an rvalue reference instead of a const reference.
(WTF::Vector::insertVector): Renamed to avoid overloading troubles, analogous
to what we did for appendVector.
- 6:24 PM Changeset in webkit [157073] by
-
- 2 edits in trunk/Tools
[buildbot] parse tests that are reported as crashed correctly for GTK+
https://bugs.webkit.org/show_bug.cgi?id=122476
Reviewed by Martin Robinson.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
as a failure of the API tests.
- 6:21 PM Changeset in webkit [157072] by
-
- 2 edits in trunk/Tools
Unreviewed. Skipping API test that is causing the next one to crash,
see https://bugs.webkit.org/show_bug.cgi?id=121970.
- Scripts/run-gtk-tests:
(TestRunner):
- 6:04 PM Changeset in webkit [157071] by
-
- 2 edits in trunk/Source/WebCore
Update test results.
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback):
- 5:36 PM Changeset in webkit [157070] by
-
- 19 edits8 adds in trunk
[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416
Source/WebCore:
Reviewed by David Hyatt.
Tests: mathml/presentation/mo-minus.html
mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html
MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.
Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.
With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.
- css/mathml.css:
Not sure what this line-height:0 was here for, but it caused bugs with the new code
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::attach):
(WebCore):
(WebCore::MathMLTextElement::childrenChanged):
Need to update the anonymous render tree below <mo> elements when their
children change or when the renderer is first attached.
- mathml/MathMLTextElement.h:
(MathMLTextElement):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h:
Now that the preferred width doesn't depend on the height, we don't
need to override computePreferredLogicalWidths at all.
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
Need to update the anonymous renderers for the anonymous RenderMathMLOperators.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::expandedStretchHeight):
Store the non-expanded stretch height so that we can detect when the height
actually changed.
(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout
(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::computeLogicalHeight): Return the stretched operator height, if appropriate.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.
- rendering/mathml/RenderMathMLOperator.h: Update method declarations.
LayoutTests:
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-10-04
Reviewed by David Hyatt.
Add some reftests for stretchy operators.
- TestExpectations: The remaining MathML pixel tests are broken by this patch.
- LayoutTests/platform/gtk/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
- LayoutTests/platform/win/TestExpectations:
- mathml/presentation/mo-minus.html: Added.
- mathml/presentation/mo-stacked-glyphs-expected.html: Added.
- mathml/presentation/mo-stacked-glyphs.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar.html: Added.
- mathml/very-large-stretchy-operators-expected.txt: Added.
- mathml/very-large-stretchy-operators.html: Added.
- 4:56 PM Changeset in webkit [157069] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests does not distinguish between failure and crashes
https://bugs.webkit.org/show_bug.cgi?id=122135
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-07
Reviewed by Martin Robinson.
The GTK+ API test runner does not distinguish between failures and crashes. This change
makes it do that, so it's easier for us to spot the more important/higher priority crash
case.
- Scripts/run-gtk-tests:
(TestRunner._run_test_command): return the exit code instead of a boolean true/false,
so we have more information on how the process ended.
(TestRunner._run_test): check the exit code to distinguish between crashes and failures.
(TestRunner.run_tests): report crashes.
- 4:48 PM Changeset in webkit [157068] by
-
- 38 edits27 adds in trunk
[MediaStream API] update MediaStreamTrack object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121940
Reviewed by Jer Noble.
Source/WebCore:
No new tests, existing test updated.
Add new source files to the project:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
New capability dictionary objects:
- Modules/mediastream/AllAudioCapabilities.h: Added.
- Modules/mediastream/AllAudioCapabilities.idl: Added.
- Modules/mediastream/AllVideoCapabilities.h: Added.
- Modules/mediastream/AllVideoCapabilities.idl: Added.
- Modules/mediastream/AudioStreamTrack.cpp:
(WebCore::AudioStreamTrack::create): New version that takes a MediaStreamTrack*.
- Modules/mediastream/AudioStreamTrack.h:
New object for a capability range:
- Modules/mediastream/CapabilityRange.cpp: Added.
- Modules/mediastream/CapabilityRange.h: Added.
- Modules/mediastream/CapabilityRange.idl: Added.
- Modules/mediastream/MediaConstraintsImpl.h: Make initialize() public.
New object for the current states for a media source.
- Modules/mediastream/MediaSourceStates.cpp: Added.
- Modules/mediastream/MediaSourceStates.h: Added.
- Modules/mediastream/MediaSourceStates.idl: Added.
Don't call the media stream center to notify it when the state of other
objects change.
- Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack): Remove the stream source duplication hack.
(WebCore::createFromSourceVectors):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
- Modules/mediastream/MediaStream.h:
New object for the capabilities of a source.
- Modules/mediastream/MediaStreamCapabilities.cpp: Added.
- Modules/mediastream/MediaStreamCapabilities.h: Added.
- Modules/mediastream/MediaStreamCapabilities.idl: Added.
Update interface to match spec.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack): Define a copy constructor to use in clone().
(WebCore::MediaStreamTrack::setSource): Call removeObserver if the track already has a source.
Initialize m_muted from new source's muted state.
(WebCore::MediaStreamTrack::id): Allow source to provide ID as the spec suggests.
(WebCore::MediaStreamTrack::setEnabled): Add some spec text to clarify logic. Always call
source->setEnabled, it can figure out if nothing needs to be done.
(WebCore::MediaStreamTrack::muted): Don't call the stream center when muted changes, the
source can take care of notifying interested parties.
(WebCore::MediaStreamTrack::readonly): New.
(WebCore::MediaStreamTrack::remote): New.
(WebCore::MediaStreamTrack::constraints): New.
(WebCore::MediaStreamTrack::states): New.
(WebCore::MediaStreamTrack::capabilities): New.
(WebCore::MediaStreamTrack::applyConstraints): New.
(WebCore::MediaStreamTrack::clone): New.
(WebCore::MediaStreamTrack::stopProducingData): New.
(WebCore::MediaStreamTrack::sourceStateChanged): Renamed from sourceChangedState.
(WebCore::MediaStreamTrack::sourceMutedChanged): New.
(WebCore::MediaStreamTrack::sourceEnabledChanged): New.
(WebCore::MediaStreamTrack::configureTrackRendering): New.
(WebCore::MediaStreamTrack::stopped): New.
(WebCore::MediaStreamTrack::stop): Call stopProducingData.
(WebCore::MediaStreamTrack::scheduleEventDispatch): New.
(WebCore::MediaStreamTrack::dispatchQueuedEvents): New.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/MediaTrackConstraint.cpp: Added.
- Modules/mediastream/MediaTrackConstraint.h: Added.
- Modules/mediastream/MediaTrackConstraint.idl: Added.
Add empty classes/IDL for track constraint objects.
- Modules/mediastream/MediaTrackConstraintSet.cpp: Added.
- Modules/mediastream/MediaTrackConstraintSet.h: Added.
- Modules/mediastream/MediaTrackConstraintSet.idl: Added.
- Modules/mediastream/MediaTrackConstraints.cpp: Added.
- Modules/mediastream/MediaTrackConstraints.h: Added.
- Modules/mediastream/MediaTrackConstraints.idl: Added.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::callSuccessHandler): Don't call the stream center, the
stream can take care of notifying interested parties.
Add a constructor and create() that take a MediaStreamTrack*.
- Modules/mediastream/VideoStreamTrack.cpp:
(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack):
- Modules/mediastream/VideoStreamTrack.h:
Create a MediaStreamSource subclass for WebAudio
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource): Call isAudioStreamSource instead
of checking deviceID.
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): Create a
MediaStreamAudioSource instead of a MediaStreamSource.
- Modules/webaudio/MediaStreamAudioDestinationNode.h:
- Modules/webaudio/MediaStreamAudioSource.cpp: Added.
- Modules/webaudio/MediaStreamAudioSource.h: Added.
(WebCore::MediaStreamAudioSource::~MediaStreamAudioSource):
Add new generated files.
- bindings/js/JSMediaSourceStatesCustom.cpp: Added.
- bindings/js/JSMediaStreamCapabilitiesCustom.cpp: Added.
- dom/EventNames.h: Defined 'overconstrained' event.
- platform/mediastream/MediaStreamCenter.h: Get rid of all of the methods nobody uses.
It isn't clear that they are necessary, and we can add them back if/when we need them.
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::~MediaStreamDescriptor): Clear the all source streams.
(WebCore::MediaStreamDescriptor::removeSource): Clear the source stream.
- platform/mediastream/MediaStreamDescriptor.h:
Make MediaStreamSource an abstract base class, and remove everyting WebAudio-specific
to MediaStreamAudioSource.
- platform/mediastream/MediaStreamSource.cpp:
(WebCore::MediaStreamSource::MediaStreamSource): Remove readyState and requiresConsumer
parameters. Create new UUID for id if non was passed.
(WebCore::MediaStreamSource::reset): Reset internal state to just-constructed. Used for testing.
(WebCore::MediaStreamSource::setReadyState): sourceChangedState -> sourceStateChanged.
(WebCore::MediaStreamSource::setStream): Remove the ASSERT that check for a source being
added to a new stream. This is still a problem, but it is required for testing and will
be fixed as a part of bug 121954.
(WebCore::MediaStreamSource::setConstraints): Added.
(WebCore::MediaStreamSource::setMuted): Notify observers when muted changes.
(WebCore::MediaStreamSource::setEnabled): Notify observers when enabled changes.
(WebCore::MediaStreamSource::readonly): New.
(WebCore::MediaStreamSource::stop): New. Set state to Ended when all of the observers has
stopped.
- platform/mediastream/MediaStreamSource.h:
Define platform versions of the Capabilities classes.
- platform/mediastream/MediaStreamSourceCapabilities.h: Added.
Update the non-functional platform stream centers for the API changes.
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
- platform/mediastream/mac/MediaStreamCenterMac.cpp:
- platform/mediastream/mac/MediaStreamCenterMac.h:
Update the Mock stream center for the API changes. Add a concrete mock MediaStreamSource
subclass.
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::MockSource::MockSource): New, the mock media stream source.
(WebCore::MockSource::~MockSource):
(WebCore::MockSource::capabilities):
(WebCore::MockSource::states):
(WebCore::mockSourceMap):
(WebCore::mockAudioSourceID):
(WebCore::mockVideoSourceID):
(WebCore::initializeMockSources): Create one audio and one video mock source.
(WebCore::MockMediaStreamCenter::registerMockMediaStreamCenter): Call initializeMockSources.
(WebCore::MockMediaStreamCenter::createMediaStream): Use the already allocated mock media
sources.
(WebCore::MockMediaStreamCenter::getMediaStreamTrackSources): Ditto.
- platform/mock/MockMediaStreamCenter.h:
LayoutTests:
- fast/mediastream/MediaStreamTrack-expected.txt:
- fast/mediastream/MediaStreamTrack.html:
- fast/mediastream/MediaStreamTrack-getSources-expected.txt:
- fast/mediastream/MediaStreamTrack-getSources.html:
- 4:43 PM Changeset in webkit [157067] by
-
- 2 edits in trunk/Tools
[GTK] Missing packages for APT on install-dependencies
https://bugs.webkit.org/show_bug.cgi?id=121555
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-10-07
Reviewed by Martin Robinson.
- gtk/install-dependencies: add packages that are needed for
building WebKit itself and the jhbuild dependencies.
- 4:33 PM Changeset in webkit [157066] by
-
- 2 edits in trunk/Source/WTF
Fix Windows build.
- wtf/StdLibExtras.h:
(std::make_unique):
- 4:05 PM Changeset in webkit [157065] by
-
- 35 edits in trunk/Source/WebCore
CTTE: Live node lists always have an owner Node.
<https://webkit.org/b/122470>
Reviewed by Anders Carlsson.
Make LiveNodeListBase::m_ownerNode a Ref<Node> instead of a RefPtr
and have all constructors take Node&.
- 4:01 PM Changeset in webkit [157064] by
-
- 3 edits in trunk/Source/WebKit2
Reduce duplicated code in WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=122230
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> on 2013-10-07
Reviewed by Darin Adler.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): move duplicate code to resetState and call it.
(WebKit::WebPageProxy::resetState): new private method for code that is shared between
close and resetStateAfterProcessExited.
(WebKit::WebPageProxy::resetStateAfterProcessExited): move duplicate code to resetState
and call it.
- UIProcess/WebPageProxy.h:
- 3:58 PM Changeset in webkit [157063] by
-
- 3 edits in trunk/Tools
Fix test failures.
- Scripts/webkitpy/port/base.py:
(Port.to.start_helper):
- Scripts/webkitpy/port/mock_drt.py:
(MockDRTPort.start_helper):
- 3:46 PM Changeset in webkit [157062] by
-
- 4 edits in trunk/Source/JavaScriptCore
FTL memory allocator should be able to allocate data sections in non-executable memory
https://bugs.webkit.org/show_bug.cgi?id=116189
Reviewed by Sam Weinig.
Use a RefCountedArray<int64_t> for data sections. This works out great because
RefCountedArray<> knows its own size and because the reference counting makes passing
it around very easy (you don't have to stress out about ownership).
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::addDataSection):
- ftl/FTLJITCode.h:
(JSC::FTL::JITCode::dataSections):
- 3:37 PM Changeset in webkit [157061] by
-
- 29 edits in trunk/Source/WebCore
Clean up ScriptExecutionContext::Task and subclasses
https://bugs.webkit.org/show_bug.cgi?id=122469
Reviewed by Andreas Kling.
- Modules/webdatabase/Database.cpp:
(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask):
(WebCore::Database::scheduleTransactionCallback):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::DatabaseManager::openDatabase):
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
- bindings/js/JSCallbackData.h:
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):
- bindings/js/JSDOMGlobalObjectTask.h:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
- dom/CrossThreadTask.h:
(WebCore::createCallbackTask):
- dom/Document.cpp:
(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ProcessMessagesSoonTask::ProcessMessagesSoonTask):
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):
- dom/ScriptExecutionContext.h:
- dom/StringCallback.cpp:
(WebCore::StringCallback::scheduleCallback):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::CallCacheListenerTask::CallCacheListenerTask):
(WebCore::ApplicationCacheGroup::postListenerTask):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
- workers/WorkerEventQueue.cpp:
(WebCore::WorkerEventQueue::enqueueEvent):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
- workers/WorkerGlobalScope.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::WorkerThreadShutdownFinishTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
- 3:25 PM Changeset in webkit [157060] by
-
- 4 edits in trunk/Source
Modify WTF and JavaScriptCore makefiles for x64 build.
https://bugs.webkit.org/show_bug.cgi?id=122467.
<rdar://problem/15169174>.
Reviewed by Brent Fulgham.
- WTF.vcxproj/WTF.make:
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- 3:08 PM Changeset in webkit [157059] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: Optimize IsString(@2<String>) -> JSConst(true) + Phantom()
https://bugs.webkit.org/show_bug.cgi?id=122363
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-07
Reviewed by Filip Pizlo.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- 1:34 PM Changeset in webkit [157058] by
-
- 61 edits in trunk/Source
CTTE: Use references in and around DragController
https://bugs.webkit.org/show_bug.cgi?id=122427
Patch by Sam Weinig <sam@webkit.org> on 2013-10-07
Reviewed by Andreas Kling.
Source/WebCore:
Use references to indicate non-nullness of DragController related
objects.
Source/WebKit/efl:
- WebCoreSupport/DragClientEfl.cpp:
(WebCore::DragClientEfl::willPerformDragDestinationAction):
(WebCore::DragClientEfl::willPerformDragSourceAction):
(WebCore::DragClientEfl::actionMaskForDrag):
(WebCore::DragClientEfl::startDrag):
- WebCoreSupport/DragClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::willPerformDragDestinationAction):
(WebKit::DragClient::willPerformDragSourceAction):
(WebKit::DragClient::actionMaskForDrag):
(WebKit::DragClient::startDrag):
- WebCoreSupport/DragClientGtk.h:
- webkit/webkitwebview.cpp:
(dragExitedCallback):
(webkit_web_view_drag_motion):
(webkit_web_view_drag_data_received):
(webkit_web_view_drag_drop):
Source/WebKit/mac:
- WebCoreSupport/WebDragClient.h:
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::actionMaskForDrag):
(WebDragClient::willPerformDragDestinationAction):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
(WebDragClient::declareAndWriteDragImage):
- WebView/WebFrame.mm:
(-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
- WebView/WebView.mm:
(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):
Source/WebKit/win:
- WebCoreSupport/WebDragClient.cpp:
(WebDragClient::actionMaskForDrag):
(WebDragClient::willPerformDragDestinationAction):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
- WebCoreSupport/WebDragClient.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDragDataReceived):
(webkitWebViewBaseDragMotion):
(dragExitedCallback):
(webkitWebViewBaseDragDrop):
- UIProcess/API/mac/WKView.mm:
(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView performDragOperation:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDrag):
(WebKit::WebPageProxy::performDragControllerAction):
- UIProcess/WebPageProxy.h:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::willPerformDragDestinationAction):
(WebKit::WebDragClient::willPerformDragSourceAction):
(WebKit::WebDragClient::actionMaskForDrag):
(WebKit::WebDragClient::dragSourceActionMaskForPoint):
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/WebDragClient.h:
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
(WebKit::cachedImage):
(WebKit::WebDragClient::declareAndWriteDragImage):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
- 1:28 PM Changeset in webkit [157057] by
-
- 5 edits in trunk/Tools
Always force discrete mode when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=122465
Reviewed by Tim Horton.
This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Link with IOKit.
- DumpRenderTree/mac/LayoutTestHelper.m:
(installLayoutTestColorProfile):
Check installColorProfile.
(restoreUserColorProfile):
Check installColorProfile.
(lockDownDiscreteGraphics):
New function to force discrete graphics.
(main):
Add '--install-color-profile' option.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._set_up_run):
Always start the helper, but pass self._options.pixel_tests to it.
- Scripts/webkitpy/port/mac.py:
(MacPort.start_helper):
Pass --install-color-profile' to the helper if pixel_tests is true.
- 1:27 PM Changeset in webkit [157056] by
-
- 9 edits in trunk/Source
Animated images are not restarted when page visibility changes
https://bugs.webkit.org/show_bug.cgi?id=122464
<rdar://problem/14293474>
Reviewed by Simon Fraser.
Always kickstart animated images when the page visibility changes,
which can occur via window occlusion, and which is independent of in-window
state, which we were previously using to advance animation.
No new tests; attempts to make a test have resulted only in a flaky, timing-dependent test.
- page/Frame.cpp:
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
Move this call to resumeAnimatingImages() up to Page.
- page/FrameView.cpp:
(WebCore::FrameView::setIsInWindow):
Move this call to resumeAnimatingImages() up to Page.
- WebCore.exp.in
- page/FrameView.h:
- page/Page.h:
Move resumeAnimatingImages() itself up to Page.
- page/Page.cpp:
(WebCore::Page::setIsInWindow):
Resume animated images when we move in-window.
(WebCore::Page::setVisibilityState):
Resume animated images when we become visible.
This is the one we were previously missing.
(WebCore::Page::resumeActiveDOMObjectsAndAnimations):
Resume animated images when we're told to.
(WebCore::Page::resumeAnimatingImages):
Kickstart any animated images in all frames.
- 1:04 PM Changeset in webkit [157055] by
-
- 4 edits3 adds in trunk
[Mac] Drawing video into canvas doesn't work on the first attempt
https://bugs.webkit.org/show_bug.cgi?id=122404
Patch by Jer Noble <jer.noble@apple.com> on 2013-10-07
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-canvas-drawing.html
If creating and painting from an AVPlayerItemVideoOutput fails, fall back
to the (much slower) AVAssetImageGenerator path. Make sure to revert to the
AVPlayerItemVideoOutput path when that object begins to have available
images, however.
To do so, remove the "MAC_OS_X_VERSION_MIN_REQUIRED < 1080" check around
the AVAssetImageGenerator code, and allow both the image generator and video
output to exist simultaneously.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateAVFoundationObjC::videoOutputHasAvailableFrame):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
LayoutTests:
- media/video-canvas-drawing-expected.png: Added.
- media/video-canvas-drawing-expected.txt: Added.
- media/video-canvas-drawing.html: Added.
- 12:12 PM Changeset in webkit [157054] by
-
- 5 edits6 moves in trunk/Source/WebCore
URLMediaSource.idl and URLMediaStream.idl are wrong
https://bugs.webkit.org/show_bug.cgi?id=122301
Reviewed by Philippe Normand.
Rename URLMediaSource and URLMediaStream to DOMURLMediaSource and DOMURLMediaStream,
respectively.
Update the build files:
- CMakeLists.txt: Rename URL -> DOMURL.
- DerivedSources.make: Ditto.
- GNUmakefile.list.am: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
Rename the .idl and implementation files:
- Modules/mediasource/DOMURLMediaSource.cpp: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.cpp.
(WebCore::DOMURLMediaSource::createObjectURL):
- Modules/mediasource/DOMURLMediaSource.h: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.h.
- Modules/mediasource/DOMURLMediaSource.idl: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.idl.
- Modules/mediastream/DOMURLMediaStream.cpp: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.cpp.
(WebCore::DOMURLMediaStream::createObjectURL):
- Modules/mediastream/DOMURLMediaStream.h: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.h.
- Modules/mediastream/DOMURLMediaStream.idl: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.idl.
- 11:58 AM Changeset in webkit [157053] by
-
- 2 edits in trunk/LayoutTests
css3/images/cross-fade-svg-with-opacity.html fails with colorspace mismatch on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=122456
- platform/mac-wk2/TestExpectations:
Mark the test as failing for now.
- 11:52 AM Changeset in webkit [157052] by
-
- 3 edits in trunk/Tools
Properly count binding test failures as failures.
Fix the total for multiple failures in different steps too by avoiding undefined.
https://bugs.webkit.org/show_bug.cgi?id=122232
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
(BuildbotTestResults):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- 11:50 AM Changeset in webkit [157051] by
-
- 1 edit36 moves1 add in trunk/LayoutTests
[CSSRegions] Move region styling tests into fast/regions/region-styling
https://bugs.webkit.org/show_bug.cgi?id=122451
Reviewed by Sam Weinig.
Create region-styling folder under fast/regions and move related region styling tests.
- fast/regions/region-styling/parse-incomplete-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule-expected.txt.
- fast/regions/region-styling/parse-incomplete-region-rule.html: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule.html.
- fast/regions/region-styling/parsing-region-style-rule-expected.txt: Renamed from LayoutTests/fast/regions/parsing-region-style-rule-expected.txt.
- fast/regions/region-styling/parsing-region-style-rule.html: Renamed from LayoutTests/fast/regions/parsing-region-style-rule.html.
- fast/regions/region-styling/region-rule-nested-region-rule-expected.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule-expected.html.
- fast/regions/region-styling/region-rule-nested-region-rule.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule.html.
- fast/regions/region-styling/region-style-block-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color-expected.html.
- fast/regions/region-styling/region-style-block-background-color.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color.html.
- fast/regions/region-styling/region-style-block-background-color2-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2-expected.html.
- fast/regions/region-styling/region-style-block-background-color2.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2.html.
- fast/regions/region-styling/region-style-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-color-expected.html.
- fast/regions/region-styling/region-style-color.html: Renamed from LayoutTests/fast/regions/region-style-color.html.
- fast/regions/region-styling/region-style-image-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color-expected.html.
- fast/regions/region-styling/region-style-image-background-color.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color.html.
- fast/regions/region-styling/region-style-in-columns-expected.html: Renamed from LayoutTests/fast/regions/region-style-in-columns-expected.html.
- fast/regions/region-styling/region-style-in-columns.html: Renamed from LayoutTests/fast/regions/region-style-in-columns.html.
- fast/regions/region-styling/region-style-inline-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color-expected.html.
- fast/regions/region-styling/region-style-inline-background-color.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color.html.
- fast/regions/region-styling/region-style-not-supported-properties-expected.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties-expected.html.
- fast/regions/region-styling/region-style-not-supported-properties.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties.html.
- fast/regions/region-styling/region-style-rule-position-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-position-expected.html.
- fast/regions/region-styling/region-style-rule-position.html: Renamed from LayoutTests/fast/regions/region-style-rule-position.html.
- fast/regions/region-styling/region-style-rule-specificity-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity-expected.html.
- fast/regions/region-styling/region-style-rule-specificity.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity.html.
- fast/regions/region-styling/region-styling-mediaquery-expected.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery-expected.html.
- fast/regions/region-styling/region-styling-mediaquery.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery.html.
- fast/regions/region-styling/remove-leftover-anon-block-crash-expected.txt: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash-expected.txt.
- fast/regions/region-styling/remove-leftover-anon-block-crash.html: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash.html.
- fast/regions/region-styling/removed-element-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash-expected.txt.
- fast/regions/region-styling/removed-element-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash.html.
- fast/regions/region-styling/render-region-custom-style-mark-expected.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark-expected.html.
- fast/regions/region-styling/render-region-custom-style-mark.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark.html.
- fast/regions/region-styling/set-box-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash-expected.txt.
- fast/regions/region-styling/set-box-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash.html.
- fast/regions/region-styling/webkit-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/webkit-region-rule-expected.txt.
- fast/regions/region-styling/webkit-region-rule.html: Renamed from LayoutTests/fast/regions/webkit-region-rule.html.
- 11:20 AM Changeset in webkit [157050] by
-
- 17 edits in trunk/Source/JavaScriptCore
Transition stack check JITStubs to CCallHelper functions
https://bugs.webkit.org/show_bug.cgi?id=122289
Reviewed by Filip Pizlo.
Replaced jit stubs cti_stack_check, cti_op_call_arityCheck and cti_op_construct_arityCheck with
jit operations operationStackCheck, operationCallArityCheck & operationConstructArityCheck.
Added new callOperationWithCallFrameRollbackOnException() in baseline and DFG JITs to call
these new functions. Added code to unwind one frame in JIT::privateCompileExceptionHandlers()
and JITCompiler::compileExceptionHandlers() for these cases that need to throw exceptions in
their caller frame when the stack is exhausted.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::andPtr): Added to handle masking a pointer with a literal.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::and64): Added to handle masking a pointer with a literal.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::exceptionCheckWithCallFrameRollback):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperationWithCallFrameRollbackOnException):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnException):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnExceptionSetResult):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- interpreter/CallFrame.h:
(JSC::ExecState::hostCallFrameFlag):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::jitAssertIsNull):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::jitAssertIsNull):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JIT.h:
(JSC::JIT::exceptionCheckWithCallFrameRollback):
- jit/JITInlines.h:
(JSC::JIT::appendCallWithCallFrameRollbackOnException):
(JSC::JIT::callOperationWithCallFrameRollbackOnException):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 11:07 AM Changeset in webkit [157049] by
-
- 3 edits in trunk/Source/WTF
Remove passIn and passOut from HashTraits
https://bugs.webkit.org/show_bug.cgi?id=122452
Reviewed by Sam Weinig.
Change RefPtrHashMap to not use passOut (just like the regular HashMap) and get rid of the
passIn and passOut functions and related typedefs.
- wtf/HashTraits.h:
- wtf/RefPtrHashMap.h:
- 10:45 AM Changeset in webkit [157048] by
-
- 3 edits in trunk/Source/WebCore
Conditional support in bindings code generator for overloaded functions
https://bugs.webkit.org/show_bug.cgi?id=122443
Patch by Philippe Normand <pnormand@igalia.com> on 2013-10-07
Reviewed by Darin Adler.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateOverloadedFunction): Generate conditional for overloaded
function, if it's present in the idl.
(GenerateImplementation): Close the last overloaded function
conditional before generating the distpatch function.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
Rebaseline overloaded function tests.
- 10:42 AM Changeset in webkit [157047] by
-
- 4 edits in trunk
ASSERTION FAILED: isUInt32() in jsc-layout-tests.yaml/js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122419
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
AI was using JSValue::asUInt32() incorrectly. That method presumes that the input is
both a int32 and a uint32 (it's in the range [0, 231)). The UInt32ToNumber node is
instead dealing with an input that is always represented as a int32 but that has the
meaning of a uint32 - so AI should use JSValue::asInt32() and then do the cast.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
LayoutTests:
Reviewed by Oliver Hunt.
- js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js:
- 9:59 AM Changeset in webkit [157046] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Jump over maxJumpReplacementSize in revertJumpToMove.
https://bugs.webkit.org/show_bug.cgi?id=120007
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-07
Reviewed by Oliver Hunt.
Jump over maxJumpReplacementSize in revertJumpToMove, even if there is no constant
value within the area. This patch fixes debug ASSERTs failures for sh4 architecture.
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::revertJumpToMove):
- 9:48 AM Changeset in webkit [157045] by
-
- 3 edits2 adds in trunk
-webkit-cross-fade paints SVGs at full opacity during cross-fade
https://bugs.webkit.org/show_bug.cgi?id=122441
<rdar://problem/13973162>
Reviewed by Simon Fraser.
Test: css3/images/cross-fade-svg-with-opacity.html
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::drawCrossfadeSubimage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
Factor the image painting out into a function.
Conditionally use a transparency layer around painting if the image
we're drawing is an SVG (SVGImage is the only Image subclass that will
not respect the context's opacity).
Add a test that ensures that -cross-fade with SVG images draws correctly.
- css3/images/cross-fade-svg-with-opacity-expected.html: Added.
- css3/images/cross-fade-svg-with-opacity.html: Added.
- 9:26 AM Changeset in webkit [157044] by
-
- 251 edits in trunk/Source
Add OVERRIDE and virtual where appropriate
https://bugs.webkit.org/show_bug.cgi?id=122439
Reviewed by Antti Koivisto.
Source/JavaScriptCore:
- API/JSAPIWrapperObject.mm:
- API/JSCallbackObject.h:
(JSC::JSCallbackObjectData::~JSCallbackObjectData):
- API/JSManagedValue.mm:
- API/JSScriptRef.cpp:
(OpaqueJSScript::~OpaqueJSScript):
- bytecode/CodeBlock.h:
- bytecode/StructureStubClearingWatchpoint.h:
- dfg/DFGArrayifySlowPathGenerator.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
- dfg/DFGFailedFinalizer.h:
- dfg/DFGJITCode.h:
- dfg/DFGJITFinalizer.h:
- dfg/DFGSaneStringGetByValSlowPathGenerator.h:
- dfg/DFGSlowPathGenerator.h:
- dfg/DFGSpeculativeJIT64.cpp:
- heap/Heap.h:
- heap/IncrementalSweeper.h:
- heap/SuperRegion.h:
- jit/ClosureCallStubRoutine.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
- jit/GCAwareJITStubRoutine.h:
- jit/JITCode.h:
- jit/JITStubs.cpp:
- jit/JITToDFGDeferredCompilationCallback.h:
- jit/JumpReplacementWatchpoint.h:
- parser/Nodes.h:
- runtime/DataView.h:
- runtime/GCActivityCallback.h:
- runtime/GenericTypedArrayView.h:
- runtime/RegExpCache.h:
- runtime/SimpleTypedArrayController.h:
- runtime/WeakMapData.h:
Source/WebCore:
- Modules/encryptedmedia/MediaKeys.h:
- Modules/webaudio/AnalyserNode.h:
- Modules/webaudio/AudioBasicInspectorNode.h:
- Modules/webaudio/AudioBasicProcessorNode.h:
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioDestinationNode.h:
- Modules/webaudio/AudioProcessingEvent.h:
- Modules/webaudio/BiquadDSPKernel.h:
- Modules/webaudio/BiquadProcessor.h:
- Modules/webaudio/ChannelMergerNode.h:
- Modules/webaudio/ChannelSplitterNode.h:
- Modules/webaudio/ConvolverNode.h:
- Modules/webaudio/DelayDSPKernel.h:
- Modules/webaudio/DelayProcessor.h:
- Modules/webaudio/DynamicsCompressorNode.h:
- Modules/webaudio/GainNode.h:
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/OfflineAudioCompletionEvent.h:
- Modules/webaudio/OfflineAudioDestinationNode.h:
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/ScriptProcessorNode.h:
- Modules/webaudio/WaveShaperProcessor.h:
- accessibility/AccessibilityARIAGrid.h:
- accessibility/AccessibilityARIAGridCell.h:
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityList.h:
- accessibility/AccessibilityListBox.h:
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityMediaControls.h:
- accessibility/AccessibilityMenuList.h:
- accessibility/AccessibilityMenuListOption.h:
- accessibility/AccessibilityMenuListPopup.h:
- accessibility/AccessibilityMockObject.h:
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityProgressIndicator.h:
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilitySVGRoot.h:
- accessibility/AccessibilityScrollView.h:
- accessibility/AccessibilityScrollbar.h:
- accessibility/AccessibilitySlider.h:
- accessibility/AccessibilitySpinButton.h:
- accessibility/AccessibilityTable.h:
- accessibility/AccessibilityTableCell.h:
- accessibility/AccessibilityTableColumn.h:
- accessibility/AccessibilityTableHeaderContainer.h:
- accessibility/AccessibilityTableRow.h:
- bindings/js/JSEventListener.h:
- bindings/js/WebCoreTypedArrayController.h:
- bridge/c/c_class.h:
- bridge/c/c_instance.h:
- bridge/c/c_runtime.h:
- bridge/runtime_root.h:
- css/CSSBasicShapes.h:
- css/CSSComputedStyleDeclaration.h:
- css/CSSStyleSheet.h:
- dom/Attr.h:
- dom/BeforeTextInsertedEvent.h:
- dom/CDATASection.h:
- dom/ChildNodeList.h:
- dom/DatasetDOMStringMap.h:
- dom/Document.h:
- dom/DocumentEventQueue.h:
- dom/DocumentFragment.h:
- dom/Element.h:
- dom/ErrorEvent.h:
- dom/KeyboardEvent.h:
- dom/Node.h:
- dom/PageTransitionEvent.h:
- dom/ProgressEvent.h:
- dom/PseudoElement.h:
- dom/ScriptExecutionContext.h:
- dom/ShadowRoot.h:
- dom/StyledElement.h:
- dom/TagNodeList.h:
- dom/Text.h:
- dom/TextEvent.h:
- dom/TransitionEvent.h:
- dom/UIEvent.h:
- dom/WebKitAnimationEvent.h:
- dom/WebKitTransitionEvent.h:
- editing/ApplyBlockElementCommand.h:
- editing/ApplyStyleCommand.h:
- editing/BreakBlockquoteCommand.h:
- editing/CompositeEditCommand.h:
- editing/SpellingCorrectionCommand.h:
- fileapi/File.h:
- fileapi/FileThreadTask.h:
- history/BackForwardList.h:
- html/BaseCheckableInputType.h:
- html/HTMLAnchorElement.h:
- html/HTMLAreaElement.h:
- html/HTMLCanvasElement.h:
- html/HTMLCollection.h:
- html/HTMLElement.h:
- html/HTMLFieldSetElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLFormControlElementWithState.h:
- html/HTMLFormElement.h:
- html/HTMLFrameElementBase.h:
- html/HTMLImageElement.h:
- html/HTMLImageLoader.h:
- html/HTMLInputElement.h:
- html/HTMLLabelElement.h:
- html/HTMLLegendElement.h:
- html/HTMLMediaElement.h:
- html/HTMLMeterElement.h:
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLPlugInImageElement.h:
- html/HTMLProgressElement.h:
- html/HTMLSelectElement.h:
- html/HTMLTableElement.h:
- html/HTMLTextAreaElement.h:
- html/HTMLTextFormControlElement.h:
- html/HTMLVideoElement.h:
- html/canvas/CanvasRenderingContext2D.cpp:
- html/shadow/MediaControlElementTypes.h:
- html/shadow/MediaControlElements.h:
- html/shadow/SpinButtonElement.h:
- html/shadow/TextControlInnerElements.h:
- html/track/AudioTrackList.h:
- html/track/TextTrackList.h:
- html/track/TrackListBase.h:
- inspector/InspectorValues.h:
- loader/EmptyClients.h:
- loader/ImageLoader.h:
- loader/ResourceLoader.h:
- loader/SubresourceLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheGroup.h:
- loader/appcache/DOMApplicationCache.h:
- loader/archive/cf/LegacyWebArchive.h:
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedFont.h:
- loader/cache/CachedFontClient.h:
- loader/cache/CachedImageClient.h:
- loader/cache/CachedSVGDocumentClient.h:
- loader/cache/CachedStyleSheetClient.h:
- loader/cache/CachedXSLStyleSheet.h:
- page/Chrome.h:
- page/DOMWindow.h:
- page/FrameView.h:
- page/animation/ImplicitAnimation.h:
- platform/PODIntervalTree.h:
- platform/PODRedBlackTree.h:
- platform/ScrollView.h:
- platform/Scrollbar.h:
- platform/Timer.h:
- platform/animation/TimingFunction.h:
(WebCore::LinearTimingFunction::~LinearTimingFunction):
(WebCore::CubicBezierTimingFunction::~CubicBezierTimingFunction):
(WebCore::StepsTimingFunction::~StepsTimingFunction):
- platform/audio/AudioDSPKernelProcessor.h:
- platform/audio/HRTFPanner.h:
- platform/audio/mac/AudioDestinationMac.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/filters/FilterOperation.h:
- platform/network/ResourceHandle.h:
- rendering/AutoTableLayout.h:
- rendering/ClipPathOperation.h:
- rendering/InlineFlowBox.h:
- rendering/RenderBlock.h:
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.h:
- rendering/RenderButton.h:
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.h:
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlowThread.h:
- rendering/RenderFullScreen.h:
- rendering/RenderImage.h:
- rendering/RenderLayer.h:
- rendering/RenderLineBreak.h:
- rendering/RenderListBox.h:
- rendering/RenderListItem.h:
- rendering/RenderListMarker.h:
- rendering/RenderMenuList.h:
- rendering/RenderMeter.h:
- rendering/RenderObject.h:
- rendering/RenderReplaced.h:
- rendering/RenderSlider.h:
- rendering/RenderTable.h:
- rendering/RenderTableCell.h:
- rendering/RenderText.h:
- rendering/RenderTextControl.h:
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderTextFragment.h:
- rendering/RenderView.h:
- rendering/RootInlineBox.h:
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLFraction.h:
- rendering/mathml/RenderMathMLOperator.h:
- rendering/style/BasicShapes.h:
- rendering/svg/RenderSVGModelObject.h:
- rendering/svg/RenderSVGShape.h:
- svg/SVGAnimatedBoolean.h:
- svg/SVGAnimatedString.h:
- svg/SVGAnimatedTransformList.h:
- svg/SVGDocument.h:
- svg/SVGElement.h:
- svg/SVGElementInstance.h:
- svg/SVGFontElement.h:
- svg/SVGGElement.h:
- svg/SVGGraphicsElement.h:
- svg/SVGTransformable.h:
- svg/properties/SVGAnimatedListPropertyTearOff.h:
- svg/properties/SVGAnimatedPropertyMacros.h:
- svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
- svg/properties/SVGListPropertyTearOff.h:
- svg/properties/SVGPropertyTearOff.h:
- workers/WorkerGlobalScope.h:
Source/WTF:
- wtf/Compiler.h:
- wtf/FilePrintStream.h:
- wtf/StringPrintStream.h:
- 8:50 AM Changeset in webkit [157043] by
-
- 4 edits in trunk
Trap 5 (most likely int $3) in jsc-layout-tests.yaml/js/script-tests/integer-division-neg2tothe32-by-neg1.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122420
Source/JavaScriptCore:
Reviewed by Michael Saboff.
For the (-231/-1)|0 case, we were returning the left operand (i.e. -231) but we were
failing to account for the possibility that this operand has high-bit garbage and
int32Result() requires that the high bits are zero.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithDiv):
LayoutTests:
Reviewed by Michael Saboff.
- js/script-tests/integer-division-neg2tothe32-by-neg1.js:
- 8:47 AM Changeset in webkit [157042] by
-
- 3 edits in trunk/Source/WebKit/gtk
[GTK] UserMediaClientGtk needs API update
https://bugs.webkit.org/show_bug.cgi?id=122324
Reviewed by Martin Robinson.
Update UserMediaClientGtk API after changes made in the parent
class in r156473.
- WebCoreSupport/UserMediaClientGtk.cpp:
(WebKit::UserMediaClientGtk::requestPermission):
(WebKit::UserMediaClientGtk::cancelRequest):
- WebCoreSupport/UserMediaClientGtk.h:
- 8:32 AM Changeset in webkit [157041] by
-
- 3 edits in trunk/Source/WebCore
URLMediaStream is unguarded by ENABLE(MEDIA_STREAM)
https://bugs.webkit.org/show_bug.cgi?id=122444
Reviewed by Martin Robinson.
- Modules/mediastream/URLMediaStream.cpp: Added missing
conditional guards.
- Modules/mediastream/URLMediaStream.h: Ditto.
- 8:29 AM Changeset in webkit [157040] by
-
- 4 edits in trunk/Source/WebCore
[GTK] webkit_dom_html_style_element_{s,g}et_scoped was removed
https://bugs.webkit.org/show_bug.cgi?id=122446
Reviewed by Martin Robinson.
Added skeleton functions warning of removed functionality for
the <style scoped> GObject DOM binding.
- bindings/gobject/WebKitDOMCustom.cpp:
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols:
- 8:24 AM Changeset in webkit [157039] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed buildfix for GCC 4.6.
Changed override to OVERRIDE and final to FINAL.
- page/PageSerializer.cpp:
- workers/AbstractWorker.h:
- workers/SharedWorker.h:
- workers/Worker.h:
- 8:10 AM Changeset in webkit [157038] by
-
- 3 edits2 adds in trunk
AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress.
https://bugs.webkit.org/show_bug.cgi?id=122252
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When an author uses a control-type ARIA role (like button), but then hides a native control-type inside,
AXPress needs to operate on the inside node if possible.
Test: accessibility/axpress-on-aria-button.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::isNodeActionElement):
(WebCore::nativeActionElement):
(WebCore::AccessibilityNodeObject::actionElement):
LayoutTests:
- accessibility/axpress-on-aria-button-expected.txt: Added.
- accessibility/axpress-on-aria-button.html: Added.
- 7:51 AM Changeset in webkit [157037] by
-
- 2 edits in trunk/Tools
[GTK] Fails to build with jhbuild with newer system glib
https://bugs.webkit.org/show_bug.cgi?id=122132
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-07
Reviewed by Martin Robinson.
Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
started relying on. glib is not a dependency that should change test results, and is provided in
jhbuild with the intention of supporting the other bits that do, so using a newer stable release
should not be an issue.
- gtk/jhbuild.modules:
- 7:44 AM Changeset in webkit [157036] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
https://bugs.webkit.org/show_bug.cgi?id=122437
Reviewed by Antoine Quint.
- Scripts/run-jsc-stress-tests:
- 7:36 AM Changeset in webkit [157035] by
-
- 12 edits in trunk
ASSERTION FAILED: bitwise_cast<WriteBarrier<Unknown>*>(callFrame) == m_registers in jsc-layout-tests.yaml/js/script-tests/dfg-inline-arguments-capture-throw-exception.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122418
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This is pretty awesome. With stack compression, Arguments created in the DFG will point
their m_registers pointers into a different slab of stack than they would have in byte
code.
Hence OSR exit must repoint any Arguments objects' m_registers pointers. It previously
neglected to do so. This patch fixes that.
Fixing this unveiled another bug: the stack reversal broke the reification of inlined
phantom arguments.
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/Arguments.h:
(JSC::Arguments::offsetOfNumArguments):
(JSC::Arguments::offsetOfRegisters):
(JSC::Arguments::offsetOfSlowArgumentData):
(JSC::Arguments::offsetOfOverrodeLength):
LayoutTests:
- js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js:
- js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js:
- js/script-tests/dfg-arguments-osr-exit.js:
- js/script-tests/dfg-inline-arguments-capture-throw-exception.js:
- 4:37 AM Changeset in webkit [157034] by
-
- 2 edits in trunk/LayoutTests
context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901.
https://bugs.webkit.org/show_bug.cgi?id=122414
Unreviewed gardening.
- platform/mac/TestExpectations:
Similarly to r156990, mark context-menu-suggestions-subword-selection.html as flaky.
Change-Id: I787b1d5a5a328f747799434fd7b984eec6947cd1
- 2:01 AM Changeset in webkit [157033] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed debug build fix for ports enabling the <template> element support.
- html/HTMLTagNames.in: Generate type helpers for the <template> element as they're required
by the assertions in the Element type casts for HTMLTemplateElement.
- 1:26 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:48 AM Changeset in webkit [157032] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Build fix after r157002
https://bugs.webkit.org/show_bug.cgi?id=122434
Reviewed by Sam Weinig.
- editing/markup.cpp: Changed override to OVERRIDE.
- 12:29 AM Changeset in webkit [157031] by
-
- 9 edits in releases/WebKitGTK/webkit-2.2/Source
Merge r156345 - [GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE
https://bugs.webkit.org/show_bug.cgi?id=121782
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-09-24
Reviewed by Martin Robinson.
Disabled drag functions.
Source/WebCore:
- page/gtk/EventHandlerGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
Source/WebKit/gtk:
- WebCoreSupport/DragClientGtk.cpp:
- WebCoreSupport/DragClientGtk.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_class_init):
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
- 12:29 AM Changeset in webkit [157030] by
-
- 4 edits in trunk/Source/WebCore
MediaStreamTrack can't be FINAL
https://bugs.webkit.org/show_bug.cgi?id=122322
Reviewed by Darin Adler.
Marked the MediaStreamTrack subclasses as final.
- Modules/mediastream/AudioStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/VideoStreamTrack.h:
- 12:27 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:25 AM Changeset in webkit [157029] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r156287 - [GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
https://bugs.webkit.org/show_bug.cgi?id=121600
Reviewed by Gustavo Noronha Silva.
Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
an instance of NetscapePlugin. So the created GtkWidget remains visible.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformDestroy):
- 12:24 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:02 AM Changeset in webkit [157028] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore
Merge r156003 - DFG doesn't properly keep scope alive for op_put_to_scope
https://bugs.webkit.org/show_bug.cgi?id=121519
Reviewed by Michael Saboff.
This was a latent bug that can't actually occur in ToT. It was uncovered by causing slow
path calls in the baseline JIT for op_put_to_scope in places where we couldn't before (but
which were necessary for gen GC).
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- 12:01 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:01 AM Changeset in webkit [157027] by
-
- 3 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore
Merge r155495 - WebKit crashes when trying to send a msg via 'today's birthdays' dialogue box on Facebook
https://bugs.webkit.org/show_bug.cgi?id=120612#add_comment
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-09-10
Reviewed by Geoffrey Garen.
The codeBlock was assumed to exist when appendSourceToMessage was set.
This was an invalid assumption. I added a check to ensure that there is a
valid codeBlock before accessing it.
- API/tests/testapi.c:
(valueToObjectExceptionCallAsFunction):
(valueToObjectExceptionTest):
(main):
- runtime/VM.cpp:
(JSC::VM::throwException):
- 12:00 AM Changeset in webkit [157026] by
-
- 35 edits4 copies2 deletes in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore
Merge r154824 - CodeBlock compilation and installation should be simplified and rationalized
https://bugs.webkit.org/show_bug.cgi?id=120326
Reviewed by Oliver Hunt.
Rolling r154804 back in after fixing no-LLInt build.
Previously Executable owned the code for generating JIT code; you always had
to go through Executable. But often you also had to go through CodeBlock,
because ScriptExecutable couldn't have virtual methods, but CodeBlock could.
So you'd ask CodeBlock to do something, which would dispatch through a
virtual method that would select the appropriate Executable subtype's method.
This all meant that the same code would often be duplicated, because most of
the work needed to compile something was identical regardless of code type.
But then we tried to fix this, by having templatized helpers in
ExecutionHarness.h and JITDriver.h. The result was that if you wanted to find
out what happened when you asked for something to be compiled, you'd go on a
wild ride that started with CodeBlock, touched upon Executable, and then
ricocheted into either ExecutionHarness or JITDriver (likely both).
Another awkwardness was that for concurrent compiles, the DFG::Worklist had
super-special inside knowledge of what JITStubs.cpp's cti_optimize would have
done once the compilation finished.
Also, most of the DFG JIT drivers assumed that they couldn't install the
JITCode into the CodeBlock directly - instead they would return it via a
reference, which happened to be a reference to the JITCode pointer in
Executable. This was super weird.
Finally, there was no notion of compiling code into a special CodeBlock that
wasn't used for handling calls into an Executable. I'd like this for FTL OSR
entry.
This patch solves these problems by reducing all of that complexity into just
three primitives:
- Executable::newCodeBlock(). This gives you a new code block, either for call or for construct, and either to serve as the baseline code or the optimized code. The new code block is then owned by the caller; Executable doesn't register it anywhere. The new code block has no JITCode and isn't callable, but it has all of the bytecode.
- CodeBlock::prepareForExecution(). This takes the CodeBlock's bytecode and produces a JITCode, and then installs the JITCode into the CodeBlock. This method takes a JITType, and always compiles with that JIT. If you ask for JITCode::InterpreterThunk then you'll get JITCode that just points to the LLInt entrypoints. Once this returns, it is possible to call into the CodeBlock if you do so manually - but the Executable still won't know about it so JS calls to that Executable will still be routed to whatever CodeBlock is associated with the Executable.
- Executable::installCode(). This takes a CodeBlock and makes it the code-for- entry for that Executable. This involves unlinking the Executable's last CodeBlock, if there was one. This also tells the GC about any effect on memory usage and does a bunch of weird data structure rewiring, since Executable caches some of CodeBlock's fields for the benefit of virtual call fast paths.
This functionality is then wrapped around three convenience methods:
- Executable::prepareForExecution(). If there is no code block for that Executable, then one is created (newCodeBlock()), compiled (CodeBlock::prepareForExecution()) and installed (installCode()).
- CodeBlock::newReplacement(). Asks the Executable for a new CodeBlock that can serve as an optimized replacement of the current one.
- CodeBlock::install(). Asks the Executable to install this code block.
This patch allows me to kill *a lot* of code and to remove a lot of
specializations for functions vs. not-functions, and a lot of places where we
pass around JITCode references and such. ExecutionHarness and JITDriver are
both gone. Overall this patch has more red than green.
It also allows me to work on FTL OSR entry and tier-up:
- FTL tier-up: this will involve DFGOperations.cpp asking the DFG::Worklist to do some compilation, but it will require the DFG::Worklist to do something different than what JITStubs.cpp would want, once the compilation finishes. This patch introduces a callback mechanism for that purpose.
- FTL OSR entry: this will involve creating a special auto-jettisoned CodeBlock that is used only for FTL OSR entry. The new set of primitives allows for this: Executable can vend you a fresh new CodeBlock, and you can ask that CodeBlock to compile itself with any JIT of your choosing. Or you can take that CodeBlock and compile it yourself. Previously the act of producing a CodeBlock-for-optimization and the act of compiling code for it were tightly coupled; now you can separate them and you can create such auto-jettisoned CodeBlocks that are used for a one-shot OSR entry.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::prepareForExecutionImpl):
(JSC::CodeBlock::prepareForExecution):
(JSC::CodeBlock::prepareForExecutionAsynchronously):
(JSC::CodeBlock::install):
(JSC::CodeBlock::newReplacement):
(JSC::FunctionCodeBlock::jettisonImpl):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::hasBaselineJITProfiling):
- bytecode/DeferredCompilationCallback.cpp: Added.
(JSC::DeferredCompilationCallback::DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::~DeferredCompilationCallback):
- bytecode/DeferredCompilationCallback.h: Added.
- dfg/DFGDriver.cpp:
(JSC::DFG::tryCompile):
- dfg/DFGDriver.h:
(JSC::DFG::tryCompile):
- dfg/DFGFailedFinalizer.cpp:
(JSC::DFG::FailedFinalizer::finalize):
(JSC::DFG::FailedFinalizer::finalizeFunction):
- dfg/DFGFailedFinalizer.h:
- dfg/DFGFinalizer.h:
- dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
- dfg/DFGJITFinalizer.h:
- dfg/DFGOSRExitPreparation.cpp:
(JSC::DFG::prepareCodeOriginForOSRExit):
- dfg/DFGOperations.cpp:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):
- dfg/DFGPlan.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::completeAllReadyPlansForVM):
(JSC::DFG::Worklist::runThread):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalize):
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h:
- heap/Heap.h:
(JSC::Heap::isDeferred):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
- jit/JITDriver.h: Removed.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
- jit/JITToDFGDeferredCompilationCallback.cpp: Added.
(JSC::JITToDFGDeferredCompilationCallback::JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::~JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::create):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
- jit/JITToDFGDeferredCompilationCallback.h: Added.
- llint/LLIntEntrypoints.cpp:
(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):
- llint/LLIntEntrypoints.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::setUpCall):
- runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
- runtime/CommonSlowPaths.cpp:
- runtime/CompilationResult.cpp:
(WTF::printInternal):
- runtime/CompilationResult.h:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::installCode):
(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl):
- runtime/Executable.h:
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor):
(JSC::ExecutableBase::offsetOfNumParametersFor):
(JSC::ScriptExecutable::prepareForExecution):
(JSC::FunctionExecutable::jettisonOptimizedCodeFor):
- runtime/ExecutionHarness.h: Removed.
Oct 6, 2013:
- 11:56 PM Changeset in webkit [157025] by
-
- 90 edits in releases/WebKitGTK/webkit-2.2
Merge r154797 - Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Gardening of exception throws. The act of throwing an exception was being handled in
different ways depending on whether the code was running in the LLint, Baseline JIT,
or the DFG Jit. This made development in the vm exception and error objects difficult.
- runtime/VM.cpp:
(JSC::appendSourceToError):
This function moved from the interpreter into the VM. It views the developers code
(if there is a codeBlock) to extract what was trying to be evaluated when the error
occurred.
(JSC::VM::throwException):
This function takes in the error object and sets the following:
1: The VM's exception stack
2: The VM's exception
3: Appends extra information on the error message(via appendSourceToError)
4: The error object's line number
5: The error object's column number
6: The error object's sourceURL
7: The error object's stack trace (unless it already exists because the developer
created the error object).
(JSC::VM::getExceptionInfo):
(JSC::VM::setExceptionInfo):
(JSC::VM::clearException):
(JSC::clearExceptionStack):
- runtime/VM.h:
(JSC::VM::exceptionOffset):
(JSC::VM::exception):
(JSC::VM::addressOfException):
(JSC::VM::exceptionStack):
VM exception and exceptionStack are now private data members.
- interpreter/Interpreter.h:
(JSC::ClearExceptionScope::ClearExceptionScope):
Created this structure to temporarily clear the exception within the VM. This
needed to see if addition errors occur when setting the debugger as we are
unwinding the stack.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
Removed the code that would try to add error information if it did not exist.
All of this functionality has moved into the VM and all error information is set
at the time the error occurs.
The rest of these functions reference the new calling convention to throw an error.
- API/APICallbackFunction.h:
(JSC::APICallbackFunction::call):
- API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback):
- API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertySlot):
(JSC::::defaultValue):
(JSC::::put):
(JSC::::putByIndex):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::customHasInstance):
(JSC::::call):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):
- debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::callCheck):
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- interpreter/CallFrame.h:
(JSC::ExecState::clearException):
(JSC::ExecState::exception):
(JSC::ExecState::hadException):
- interpreter/Interpreter.cpp:
(JSC::eval):
(JSC::loadVarargs):
(JSC::stackTraceAsString):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
- interpreter/Interpreter.h:
(JSC::ClearExceptionScope::ClearExceptionScope):
- jit/JITCode.cpp:
(JSC::JITCode::execute):
- jit/JITExceptions.cpp:
(JSC::genericThrow):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_catch):
- jit/JITStubs.cpp:
(JSC::returnToThrowTrampoline):
(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
(JSC::putByVal):
(JSC::cti_vm_handle_exception):
- jit/SlowPathCall.h:
(JSC::JITSlowPathCall::call):
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
- jsc.cpp:
(functionRun):
(functionLoad):
(functionCheckSyntax):
- llint/LLIntExceptions.cpp:
(JSC::LLInt::doThrow):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::opIn):
- runtime/CommonSlowPathsExceptions.cpp:
(JSC::CommonSlowPaths::interpreterThrowInCaller):
- runtime/Completion.cpp:
(JSC::evaluate):
- runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwTypeError):
(JSC::throwSyntaxError):
- runtime/Error.h:
(JSC::throwVMError):
- runtime/ExceptionHelpers.cpp:
(JSC::throwOutOfMemoryError):
(JSC::throwStackOverflowError):
(JSC::throwTerminatedExecutionException):
- runtime/Executable.cpp:
(JSC::EvalExecutable::create):
(JSC::FunctionExecutable::produceCodeBlockFor):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::put):
(JSC::JSArray::push):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizePrototype):
(JSC::JSValue::putToPrimitive):
- runtime/JSFunction.cpp:
(JSC::JSFunction::defineOwnProperty):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::::create):
(JSC::::createUninitialized):
(JSC::::validateRange):
(JSC::::setWithSpecificType):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncProtoSetter):
- runtime/JSNameScope.cpp:
(JSC::JSNameScope::put):
- runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::defaultValue):
(JSC::JSObject::hasInstance):
(JSC::JSObject::defaultHasInstance):
(JSC::JSObject::defineOwnNonIndexProperty):
(JSC::throwTypeError):
- runtime/ObjectConstructor.cpp:
(JSC::toPropertyDescriptor):
- runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
- runtime/StringObject.cpp:
(JSC::StringObject::defineOwnProperty):
- runtime/StringRecursionChecker.cpp:
(JSC::StringRecursionChecker::throwStackOverflowError):
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Gets column information from the error object for reporting exceptions.
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackFromException):
Moved setting an exception into the vm, These functions changed to use the new functionality.
- bindings/js/JSAudioBufferSourceNodeCustom.cpp:
(WebCore::JSAudioBufferSourceNode::setBuffer):
- bindings/js/JSBiquadFilterNodeCustom.cpp:
(WebCore::JSBiquadFilterNode::setType):
- bindings/js/JSCryptoCustom.cpp:
(WebCore::JSCrypto::getRandomValues):
- bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::setFunctionVariableValue):
- bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::evaluate):
(WebCore::JSJavaScriptCallFrame::setVariableValue):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
- bindings/js/JSOscillatorNodeCustom.cpp:
(WebCore::JSOscillatorNode::setType):
- bindings/js/JSPannerNodeCustom.cpp:
(WebCore::JSPannerNode::setPanningModel):
(WebCore::JSPannerNode::setDistanceModel):
- bindings/js/JSSVGLengthCustom.cpp:
(WebCore::JSSVGLength::convertToSpecifiedUnits):
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter):
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
(WebCore::JSWebGLRenderingContext::getExtension):
(WebCore::JSWebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::JSWebGLRenderingContext::getParameter):
(WebCore::JSWebGLRenderingContext::getProgramParameter):
(WebCore::JSWebGLRenderingContext::getShaderParameter):
(WebCore::JSWebGLRenderingContext::getUniform):
(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneBase::throwStackOverflow):
(WebCore::CloneDeserializer::throwValidationError):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setException):
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::toJSPrimitive):
- bridge/objc/objc_instance.mm:
(ObjcInstance::invokeMethod):
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcArray::setValueAt):
(JSC::Bindings::ObjcArray::valueAt):
- bridge/objc/objc_utility.mm:
(JSC::Bindings::throwError):
- bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtField::valueFromInstance):
(JSC::Bindings::QtField::setValueToInstance):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::throwInvalidAccessError):
Source/WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Moved setting an exception into the vm, These functions changed to use the new functionality.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invokeMethod):
Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Moved setting an exception into the vm, These functions changed to use the new functionality.
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::throwInvalidAccessError):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::moveGlobalExceptionToExecState):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Column/line information was added into these results.
- fast/events/window-onerror4-expected.txt:
- fast/js/global-recursion-on-full-stack-expected.txt:
fixed a variable name in a case when shouldThrowType failed.
- fast/js/mozilla/resources/js-test-pre.js:
(shouldThrowType):
Sorted the properties to allow the results always show in the same order.
- fast/js/script-tests/exception-properties.js:
- fast/js/exception-properties-expected.txt:
This test needed to be modified to have the line numbers match on the output across
wk and wk2. This test is inherently flaky because is relies on size of the available
native stack. To account for the flakiness an additional call was made to force the
results to match.
This patch now records and outputs the line number where the errors were occurring.
This was causing the test results to no longer match because of the line numbers.
By changing how to account for the flakiness, the results match again.
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
- fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html:
- 11:39 PM Changeset in webkit [157024] by
-
- 10 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSCursorImageValue, CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue
https://bugs.webkit.org/show_bug.cgi?id=122408
Reviewed by Andreas Kling.
As a step to use toCSSFooValue, this patch generates toCSSFooValue() for CSSCursorImageValue,
CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue.
This will help to detect bad type cast.
No new tests, no behavior changes.
- css/CSSCursorImageValue.h:
- css/CSSTimingFunctionValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
- css/CSSUnicodeRangeValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyCursor::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssCursorImageValue):
- 9:48 PM Changeset in webkit [157023] by
-
- 2 edits in trunk/Source/WebKit
No? Okay, let's try that again..
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 9:35 PM Changeset in webkit [157022] by
-
- 2 edits in trunk/Source/WebKit
Attempt to fix the Windows build.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 9:34 PM Changeset in webkit [157021] by
-
- 2 edits in trunk/LayoutTests
Remove an unnecessary test expectation, as the test was removed
along with the code it tested.
- platform/mac/TestExpectations:
- 9:00 PM Changeset in webkit [157020] by
-
- 3 edits in trunk/LayoutTests
results.html doesn't support non-HTML reference tests or references with external resources
https://bugs.webkit.org/show_bug.cgi?id=122426
Reviewed by Ryosuke Niwa.
- fast/harness/results.html:
Factor splitExtension() out of stripExtension(), so we can retrieve
the extension as well as strip it.
Factor layoutTestsBasePath() out of testLink(), so we can use it for
ref test expectation files as well.
Use layoutTestsBasePath() to link to ref test expectation files, and
use the extension of the test for the expectation, instead of hardcoding
HTML reference files.
This will work on the bots because we already use the same mechanism for
the link to the test itself.
- fast/harness/resources/results-test.js:
Update the harness result viewer test results.
- 8:46 PM Changeset in webkit [157019] by
-
- 2 edits in trunk/Source/ThirdParty
Build against the Xcode default toolchain when targeting OS X 10.8.
This fixes the build after r156632 in configurations that use another toolchain
by default.
- gtest/xcode/Config/General.xcconfig:
- 8:39 PM Changeset in webkit [157018] by
-
- 38 edits in trunk/Source
Range constructors should take a Document&.
<https://webkit.org/b/122435>
Reviewed by Sam Weinig.
Source/WebCore:
Make all Range constructors take Document& instead of a PassRefPtr.
This removes one null check at every call site.
Also use a Ref<Document> for storage in Range.
Source/WTF:
Give Ref an assignment operator.
- 8:37 PM Changeset in webkit [157017] by
-
- 4 edits in trunk/LayoutTests
jsc-layout-tests.yaml/js/script-tests/dfg-arguments-osr-exit.js.layout-dfg-eager-no-cjit fails in release mode on the bots
https://bugs.webkit.org/show_bug.cgi?id=122436
Unreviewed, green the bots by not running the eager variants of these tests.
Will unskip when I land the fix for https://bugs.webkit.org/show_bug.cgi?id=122418.
- js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js:
- js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js:
- js/script-tests/dfg-arguments-osr-exit.js:
- 7:37 PM Changeset in webkit [157016] by
-
- 2 edits in trunk/Tools
Unreviewed, fix build on old Rubies.
- Scripts/run-jsc-stress-tests:
- 7:17 PM Changeset in webkit [157015] by
-
- 7 edits2 adds in trunk/Source/WebCore
Factor text paint style computation out from InlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=122433
Reviewed by Andreas Kling.
Move it to TextPaintStyle.h/cpp. Other parts of the code may use it in the future.
- 7:14 PM Changeset in webkit [157014] by
-
- 11 edits3 adds1 delete in trunk
Unified test infrastructure via the jsc shell
https://bugs.webkit.org/show_bug.cgi?id=120696
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
Add a mozilla-tests.yaml list. This is autogenerated by create-mozilla-js-test-list.
I think it's better to leave this checked in; we may even just edit it directly in
the future. Also generating it is not cheap.
Fix some low-hanging fruit bugs that I caught by introducing more test coverage.
- We were not emitting labels for CFA-unreachable blocks, which caused link errors. It's possible for a CFA-unreachable block to be jumped to, if the thing that causes it to be unreachable is a speculation in a Branch or peephole compare.
- The register allocation assertions didn't handle peephole branches correctly. Since the peephole branch handling returns early from compile(), the clearBlahbittyBlah() method wasn't being called.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- tests/mozilla/mozilla-tests.yaml: Added.
Tools:
Reviewed by Oliver Hunt.
Make run-jsc-stress-tests smart enough to be able to handle different styles of test
output (silent or noisy) and different styles of test failure (just bad exit code,
text diff, filtering for some magical text, etc.). This allows me to get rid of the
layout-test-helper. It also allows me to switch all of the old Mozilla tests to
running in run-jsc-stress-tests.
Also removes all of the code paths that defended against not having shellwords. Just
install the shellwords gem if you want to run tests.
Also removes the non-parallel test running code. No reason for it to exist anymore.
This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
as part of this patch, and left three more as new bugzillas.
- Scripts/create-mozilla-js-test-list: Added.
- Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
- Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
- Scripts/run-javascriptcore-tests:
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Oliver Hunt.
Suppress running the no-cjit and dfg-eager variants of these tests because there are
still some hard bugs to fix; they were revealed by the increase in test coverage.
- js/script-tests/dfg-inline-arguments-capture-throw-exception.js:
- js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js:
- js/script-tests/integer-division-neg2tothe32-by-neg1.js:
- 5:43 PM Changeset in webkit [157013] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Get rid of use of deleteAllValues in GtkDragAndDropHelper
https://bugs.webkit.org/show_bug.cgi?id=122417
Reviewed by Andreas Kling.
- platform/gtk/GtkDragAndDropHelper.cpp: Removed unneeded typedefs.
(WebCore::GtkDragAndDropHelper::~GtkDragAndDropHelper): Removed call to
deleteAllValues.
(WebCore::GtkDragAndDropHelper::handleDragEnd): Use remove directly instead
of using find then remove. I believe this fixes a storage leak.
(WebCore::GtkDragAndDropHelper::handleGetDragData): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragLeaveLater): Remove the explicit
delete since remove will automatically delete.
(WebCore::GtkDragAndDropHelper::handleDragLeave): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragMotion): Use add instead of a
combination of find and set. Also user nullptr instead of 0.
(WebCore::GtkDragAndDropHelper::handleDragDataReceived): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragDrop): Use get instead of find.
- platform/gtk/GtkDragAndDropHelper.h: Use nullptr instead of 0. Change value
type of m_droppingContexts to be a std::unique_ptr.
- 4:26 PM Changeset in webkit [157012] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix attempt.
- page/win/DragControllerWin.cpp:
(WebCore::DragController::declareAndWriteDragImage):
- 3:55 PM Changeset in webkit [157011] by
-
- 34 edits in trunk/Source/WebCore
Move paint() to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122371
Reviewed by Darin Adler.
RenderText does not paint itself (text is painted by line boxes). We can move paint() down
to RenderElement.
This also requires some type tightening elsewhere in the code.
- 3:28 PM Changeset in webkit [157010] by
-
- 3 edits in trunk/Source/WebCore
Don't try to dispatch resize events for SVG images
https://bugs.webkit.org/show_bug.cgi?id=122410
Reviewed by Darin Adler.
Tested by avoiding assertion in svg/custom/large-image-pattern-crash.html
- page/FrameView.cpp:
(WebCore::FrameView::sendResizeEventIfNeeded):
Bail out for SVG images. They have scripting disabled so the event wouldn't do anything anyway.
Use of FrameView mechanisms is just an implementation detail for SVG images, they are not
meant to act like real frames.
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::createTileImage):
Switch to Element iterator. This will take NoEventDispatchAssertion verifying the change.
- 3:07 PM Changeset in webkit [157009] by
-
- 2 edits in trunk/PerformanceTests
DoYouEvenBench: Make it work on Internet Explorer 11 Release Preview
https://bugs.webkit.org/show_bug.cgi?id=122406
Reviewed by Darin Adler.
On Internet Explorer 11, $(elem).closest('li').data('id') fails to find the containig li of elem once
the first item is marked complete or deleted until we get back to the event loop in the jQuery/TodoMVC.
Worked around this limitation by overriding app.getTodo to use each item's id computed in advance.
Also use $.text instead of execCommand('InsertText') in FlightJS/MailClient since Internet Explorer
doesn't support execCommand('InsertText'). Also select the recipient to avoid exceptions.
- DoYouEvenBench/benchmark.html:
- 2:29 PM Changeset in webkit [157008] by
-
- 5 edits in trunk/Source/WebCore
Element ancestor iterator should have a first() for convenience.
<https://webkit.org/b/122425>
Reviewed by Antti Koivisto.
Added an easy way to get the first element ancestor of a certain type
and put it to use in a few places.
- 2:07 PM Changeset in webkit [157007] by
-
- 8 edits in trunk/Source/WebCore
CTTE: FrameLoader::notifier() should return a reference.
<https://webkit.org/b/122424>
Reviewed by Anders Carlsson.
It was just returning the address of an inline member, so we should
use a reference instead. Also made the backpointer to Frame in
ResourceLoadNotifier a reference.
- 1:53 PM Changeset in webkit [157006] by
-
- 2 edits in trunk/Source/WebCore
Avoid layout in window.scroll{Y,X} when at topmost/leftmost position.
<https://webkit.org/b/122423>
Reviewed by Antti Koivisto.
Add a fast path for these properties to skip synchronous layout when
we are just going to return 0 anyway.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
- 1:11 PM Changeset in webkit [157005] by
-
- 7 edits in trunk/Source/WebCore
Clean up ContentData
https://bugs.webkit.org/show_bug.cgi?id=122421
Reviewed by Andreas Kling.
Replace uses of OwnPtr with std::unique_ptr and get rid of the ContentData::create overloads.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/ContentData.cpp:
(WebCore::ContentData::clone):
- rendering/style/ContentData.h:
(WebCore::ContentData::setNext):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::appendContent):
(WebCore::RenderStyle::setContent):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.h:
- 12:48 PM Changeset in webkit [157004] by
-
- 7 edits in trunk/Source/WebCore
Be a bit shouty about final classes while we look into why the bots don't like it.
- dom/Comment.h:
- dom/ProcessingInstruction.h:
- editing/markup.cpp:
- page/PageSerializer.cpp:
- workers/SharedWorker.h:
- workers/Worker.h:
- 12:35 PM Changeset in webkit [157003] by
-
- 3 edits in trunk/Source/WebCore
Fix windows build.
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeRangeToDataObject):
(WebCore::Pasteboard::writeSelection):
- 12:18 PM Changeset in webkit [157002] by
-
- 47 edits in trunk/Source
CTTE: Thread references through markup.h
https://bugs.webkit.org/show_bug.cgi?id=122403
Reviewed by Darin Adler and Andreas Kling.
Source/WebCore:
Highlights:
- Removed createFragmentFromMarkupWithContext(), it was unused.
- Moved createFragmentFromNodes() into its one caller (in WebKit/mac)
- Add a bunch more toFoo() overloads.
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
(-[DOMNode markupString]):
(-[DOMRange markupString]):
- WebView/WebFrame.mm:
(-[WebFrame _documentFragmentWithMarkupString:baseURLString:]):
(-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
- 12:01 PM Changeset in webkit [157001] by
-
- 55 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/Modules/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122281
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/Modules/.
- Modules/battery/BatteryManager.idl:
- Modules/encryptedmedia/MediaKeySession.idl:
- Modules/encryptedmedia/MediaKeys.idl:
- Modules/gamepad/GamepadList.idl:
- Modules/geolocation/Geolocation.idl:
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBFactory.idl:
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBKeyRange.idl:
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/indexeddb/IDBTransaction.idl:
- Modules/indexeddb/IDBVersionChangeEvent.idl:
- Modules/mediacontrols/MediaControlsHost.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediasource/WebKitMediaSource.idl:
- Modules/mediasource/WebKitSourceBuffer.idl:
- Modules/mediasource/WebKitSourceBufferList.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/RTCDTMFSender.idl:
- Modules/mediastream/RTCDataChannel.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/RTCStatsResponse.idl:
- Modules/networkinfo/NetworkInfoConnection.idl:
- Modules/notifications/Notification.idl:
- Modules/notifications/NotificationCenter.idl:
- Modules/proximity/DeviceProximityEvent.idl:
- Modules/quota/StorageInfo.idl:
- Modules/quota/StorageQuota.idl:
- Modules/speech/SpeechGrammarList.idl:
- Modules/speech/SpeechRecognition.idl:
- Modules/speech/SpeechRecognitionResult.idl:
- Modules/speech/SpeechRecognitionResultList.idl:
- Modules/speech/SpeechSynthesis.idl:
- Modules/webaudio/AnalyserNode.idl:
- Modules/webaudio/AudioBuffer.idl:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioListener.idl:
- Modules/webaudio/AudioNode.idl:
- Modules/webaudio/AudioParam.idl:
- Modules/webaudio/BiquadFilterNode.idl:
- Modules/webaudio/OscillatorNode.idl:
- Modules/webaudio/PannerNode.idl:
- Modules/webdatabase/Database.idl:
- Modules/webdatabase/DatabaseSync.idl:
- Modules/webdatabase/SQLResultSetRowList.idl:
- Modules/webdatabase/SQLTransaction.idl:
- Modules/webdatabase/SQLTransactionSync.idl:
- Modules/websockets/WebSocket.idl:
- 11:47 AM Changeset in webkit [157000] by
-
- 9 edits in trunk/Source/WebCore
Tighten AbstractWorker and subclasses a bit.
<https://webkit.org/b/122402>
Reviewed by Darin Adler.
- Make the Worker and SharedWorker classes final.
- Have constructors take ScriptExecutionContext by reference.
- Remove unnecessary AbstractWorker::contextDestroyed() override.
- Make eventTargetInterface() inline.
Inlining eventTargetInterface() is quite neat - since we only ever
call this on tightly typed pointers from generated code, combining
final and inline turns the virtual call into a compile-time constant.
- 11:18 AM Changeset in webkit [156999] by
-
- 49 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/html/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122280
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/html/.
- html/DOMFormData.idl:
- html/DOMSettableTokenList.idl:
- html/DOMTokenList.idl:
- html/DOMURL.idl:
- html/HTMLAllCollection.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLButtonElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLCollection.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLFormControlsCollection.idl:
- html/HTMLFormElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLKeygenElement.idl:
- html/HTMLMarqueeElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLOutputElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTableElement.idl:
- html/HTMLTableRowElement.idl:
- html/HTMLTableSectionElement.idl:
- html/HTMLTextAreaElement.idl:
- html/HTMLVideoElement.idl:
- html/MediaController.idl:
- html/RadioNodeList.idl:
- html/TimeRanges.idl:
- html/canvas/CanvasGradient.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/DOMPath.idl:
- html/canvas/EXTDrawBuffers.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLLoseContext.idl:
- html/canvas/WebGLRenderingContext.idl:
- html/track/AudioTrackList.idl:
- html/track/TextTrack.idl:
- html/track/TextTrackCue.idl:
- html/track/TextTrackCueList.idl:
- html/track/TextTrackList.idl:
- html/track/TextTrackRegionList.idl:
- html/track/VideoTrackList.idl:
- 11:16 AM Changeset in webkit [156998] by
-
- 7 edits in trunk/Source
Pass VM instead of ExecState to StringObject constructor.
<https://webkit.org/b/122395>
Reviewed by Sam Weinig.
StringObject() only uses the ExecState to find the VM.
- 11:10 AM Changeset in webkit [156997] by
-
- 32 edits in trunk/Source/WebCore
[WebIIDL] Annotate IDL interfaces under Source/WebCore/svg/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122279
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/svg/.
- svg/SVGAngle.idl:
- svg/SVGAnimationElement.idl:
- svg/SVGColor.idl:
- svg/SVGCursorElement.idl:
- svg/SVGDocument.idl:
- svg/SVGElement.idl:
- svg/SVGElementInstanceList.idl:
- svg/SVGException.idl:
- svg/SVGFEDropShadowElement.idl:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFilterElement.idl:
- svg/SVGGraphicsElement.idl:
- svg/SVGLength.idl:
- svg/SVGLengthList.idl:
- svg/SVGMarkerElement.idl:
- svg/SVGMaskElement.idl:
- svg/SVGMatrix.idl:
- svg/SVGNumberList.idl:
- svg/SVGPaint.idl:
- svg/SVGPathElement.idl:
- svg/SVGPathSegList.idl:
- svg/SVGPatternElement.idl:
- svg/SVGPoint.idl:
- svg/SVGPointList.idl:
- svg/SVGSVGElement.idl:
- svg/SVGStringList.idl:
- svg/SVGTests.idl:
- svg/SVGTextContentElement.idl:
- svg/SVGTransform.idl:
- svg/SVGTransformList.idl:
- 11:07 AM Changeset in webkit [156996] by
-
- 15 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/page/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122278
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/page/.
- page/Console.idl:
- page/Crypto.idl:
- page/DOMSecurityPolicy.idl:
- page/DOMSelection.idl:
- page/DOMWindow.idl:
- page/EventSource.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- page/Performance.idl:
- page/PerformanceEntryList.idl:
- page/SpeechInputResultList.idl:
- page/WindowBase64.idl:
- page/WindowTimers.idl:
- 10:58 AM Changeset in webkit [156995] by
-
- 1 edit6 moves in trunk/LayoutTests
[CSSRegions] Rename parsing tests to match current css properties
https://bugs.webkit.org/show_bug.cgi?id=122413
Reviewed by Sam Weinig.
Simple renaming of files, inline with the current stable version of properties.
- fast/regions/script-tests/webkit-flow-from-parsing.js: Renamed from LayoutTests/fast/regions/script-tests/content-webkit-from-flow-parsing.js.
- fast/regions/script-tests/webkit-flow-into-parsing.js: Renamed from LayoutTests/fast/regions/script-tests/webkit-flow-parsing.js.
- fast/regions/webkit-flow-from-parsing-expected.txt: Renamed from LayoutTests/fast/regions/content-webkit-from-flow-parsing-expected.txt.
- fast/regions/webkit-flow-from-parsing.html: Renamed from LayoutTests/fast/regions/content-webkit-from-flow-parsing.html.
- fast/regions/webkit-flow-into-parsing-expected.txt: Renamed from LayoutTests/fast/regions/webkit-flow-parsing-expected.txt.
- fast/regions/webkit-flow-into-parsing.html: Renamed from LayoutTests/fast/regions/webkit-flow-parsing.html.
- 10:52 AM Changeset in webkit [156994] by
-
- 2 edits in trunk/Source/WebCore
- rendering/RenderButton.cpp:
(WebCore::RenderButton::setupInnerStyle): Added a comment possibly relevant
to current failures seen on Windows bot.
- 10:44 AM Changeset in webkit [156993] by
-
- 9 edits in trunk/Source/WebCore
Unreviewed, rolling out r156988.
http://trac.webkit.org/changeset/156988
https://bugs.webkit.org/show_bug.cgi?id=122415
Broke debug build (Requested by ap on #webkit).
- css/CSSCursorImageValue.h:
- css/CSSTimingFunctionValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
- css/CSSUnicodeRangeValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyCursor::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssCursorImageValue):
- 10:41 AM Changeset in webkit [156992] by
-
- 2 edits in trunk/Source/WebKit
Try to fix the Windows build.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Removed export of non-existent Node::treeScope function returning
a TreeScope*. Probably will have to add an export to fix the next failure.
- 10:37 AM Changeset in webkit [156991] by
-
- 11 edits2 moves in trunk/Source/WebCore
Add *CSS* prefix to ShadowValue to generate toCSSShadowValue
https://bugs.webkit.org/show_bug.cgi?id=122409
Reviewed by Darin Adler.
To generate toCSSShadowValue(), we need to add *CSS* prefix to ShadowValue.
It is also to be sync with a naming rule of CSS child value.
No new tests, no behavior changes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForShadow):
- css/CSSParser.cpp:
(WebCore::ShadowParseContext::commitValue):
- css/CSSShadowValue.cpp: Renamed from Source/WebCore/css/ShadowValue.cpp.
(WebCore::CSSShadowValue::CSSShadowValue):
(WebCore::CSSShadowValue::customCSSText):
(WebCore::CSSShadowValue::equals):
- css/CSSShadowValue.h: Renamed from Source/WebCore/css/ShadowValue.h.
(WebCore::CSSShadowValue::create):
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::createFilterOperations):
- 10:29 AM Changeset in webkit [156990] by
-
- 2 edits in trunk/LayoutTests
Layout Test editing/spelling/context-menu-suggestions-multiword-selection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122414
- platform/mac/TestExpectations: Marked as such.
- 10:15 AM Changeset in webkit [156989] by
-
- 16 edits3 deletes in trunk/Source
Remove unneeded ScriptGCEvent class
https://bugs.webkit.org/show_bug.cgi?id=122390
Reviewed by Anders Carlsson.
Source/ThirdParty:
- gtest/xcode/gtest.xcodeproj/project.pbxproj: Let Xcode update this file.
Not really part of this bug fix, but good to land anyway.
Source/WebCore:
- GNUmakefile.list.am: Removed ScriptGCEvent files.
- Target.pri: Ditto.
- UseJSC.cmake: Ditto.
- WebCore.exp.in: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/ScriptGCEvent.cpp: Removed.
- bindings/js/ScriptGCEvent.h: Removed.
- inspector/InspectorMemoryAgent.cpp: Removed include.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start): Removed GC event listening.
Some day we might add it back, but for now it is dead code.
(WebCore::InspectorTimelineAgent::stop): Ditto.
(WebCore::usedHeapSize): Renamed from getUsedHeapSize and put the
implementation here instead of indirecting through ScriptGCEvent.
(WebCore::InspectorTimelineAgent::setDOMCounters): Updated for above changes.
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): Ditto.
(WebCore::InspectorTimelineAgent::pushCurrentRecord): Ditto.
- inspector/InspectorTimelineAgent.h: Removed include.
- inspector/ScriptGCEventListener.h: Removed.
- testing/MemoryInfo.h: Updated to get heap capacity and size directly
instead of going through ScriptGCEvent.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Replaced symbol from ScriptGCEvent with symbol from JSDOMWindowBase.
- 10:03 AM Changeset in webkit [156988] by
-
- 9 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSCursorImageValue, CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue
https://bugs.webkit.org/show_bug.cgi?id=122408
Reviewed by Darin Adler.
As a step to use toCSSFooValue, this patch generates toCSSFooValue() for CSSCursorImageValue,
CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue.
This will help to detect bad type cast.
No new tests, no behavior changes.
- css/CSSCursorImageValue.h:
- css/CSSTimingFunctionValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
- css/CSSUnicodeRangeValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyCursor::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssCursorImageValue):
- 1:37 AM Changeset in webkit [156987] by
-
- 5 edits in trunk/Source/WebCore
CTTE: Teach CompositeEditCommand that link Nodes are always Elements.
<https://webkit.org/b/122400>
Reviewed by Sam Weinig.
Make pushAnchorElementDown() take an Element& instead of a Node* and
tweak the surrounding code a tiny bit.
- 1:37 AM Changeset in webkit [156986] by
-
- 4 edits in trunk/Source/WebCore
CTTE: Node::enclosingLinkEventParentOrSelf() should return an Element.
<https://webkit.org/b/122401>
Reviewed by Sam Weinig.
Only Elements are ever linked, so make enclosingLinkEventParentOrSelf()
return an Element* instead of a Node*. The only call site was already
doing toElement() on the return value without checking, so this makes
things look a bit nicer.
- 12:33 AM Changeset in webkit [156985] by
-
- 10 edits2 moves in trunk/Source/WebCore
Add *CSS* prefix to FontFeatureValue to generate toCSSFontFeatureValue(), and use it
https://bugs.webkit.org/show_bug.cgi?id=122204
Reviewed by Darin Adler.
*CSS* prefix needs to be added to FontFeatureValue class in order to generate toCSSFontFeatureValue().
static_cast<FontFeatureValue*> is changed with toCSSFontFeatureValue() by using this change.
No new tests, no behavior changes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSFontFeatureValue.cpp: Renamed from Source/WebCore/css/FontFeatureValue.cpp.
(WebCore::CSSFontFeatureValue::CSSFontFeatureValue):
(WebCore::CSSFontFeatureValue::customCSSText):
(WebCore::CSSFontFeatureValue::equals):
- css/CSSFontFeatureValue.h: Renamed from Source/WebCore/css/FontFeatureValue.h.
(WebCore::CSSFontFeatureValue::create):
(WebCore::CSSFontFeatureValue::tag):
(WebCore::CSSFontFeatureValue::value):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFeatureTag):
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Oct 5, 2013:
- 9:22 PM Changeset in webkit [156984] by
-
- 51 edits4 adds in trunk/Source/JavaScriptCore
Compress DFG stack layout
https://bugs.webkit.org/show_bug.cgi?id=122024
Reviewed by Oliver Hunt.
The DFG needs to be able to store things at a known offset from frame pointer so that
the runtime can read those things. Prior to this patch, the DFG would use the exact
offsets that the bytecode asked for, even in the case of inlining, where it would use
the callsite stack offset to shift all of the inlined function's variables over just as
they would have been if a bytecode interpreter had really made the call.
But this won't work once WebKit-LLVM integration is complete. LLVM has no notion of
storing things at a fixed offset from the frame pointer. We could try to hack LLVM to do
that, but it would seriously complicate LLVM's stack layout. But what we might be able
to do is have LLVM tell us (via an addressof intrinsic and a side-channel) where some
alloca landed relative to the frame pointer. Hence if the DFG can put all of its flushed
variables in a contiguous range that can be expressed to LLVM as a struct that we
alloca, then all of this can still work just fine.
Previously the flushed variables didn't fit in a contiguous range, but this patch makes
them contiguous by allowing the stack layout to be compressed.
What this really means is that there is now a distinction between where the DFG saw a
variable stored in bytecode and where it will actually store it in the resulting machine
code. Henceforth when the DFG says "local" or "virtual register" it means the variable
according to bytecode (with the stack offsetting for inlined code as before), but when
it says "machine local" or "machine virtual register" it means the actual place where it
will store things in the resulting machine code. All of the OSR exit, inlined arguments,
captured variables, and various stack unwinding machine now knows about all of this.
Note that the DFG's abstract interpretation still uses bytecode variables rather than
machine variables. Same for CSE and abstract heaps. This makes sense since it means that
we don't have to decide on machine variable allocation just to do those optimizations.
The decision of what a local's machine location becomes is deferred to very late in
compilation. We only need to assign machine locations to variables that must be stored
to the stack. It's now mandatory to run some kind of "stack layout phase" that makes the
decision and updates all data structures.
So far the way that this is being used is just to compress the DFG stack layout, which
is something that we should have done anyway, a long time ago. And the compression isn't
even that good - the current StackLayoutPhase just identifies local indices that are
unused in machine code and slides all other variables towards zero. This doesn't achieve
particularly good compression but it is better than nothing. Note that this phase makes
it seem like the bytecode-machine mapping is based on bytecode local indices; for
example if bytecode local 4 is mapped to machine local 3 then it always will be. That's
true for the current StackLayoutPhase but it _will not_ be true for all possible stack
layout phases and it would be incorrect to assume that it should be true. This is why
the current data structures have each VariableAccessData hold its own copy of the
machine virtual register, and also have each InlineCallFrame report their own machine
virtual registers for the various things. The DFG backend is likely to always use the
dumb StackLayoutPhase since it is very cheap to run, but the FTL backend is likely to
eventually get a better one, where we do some kind of constraint-based coloring: we
institute constraints where some VariableAccessData's must have the same indices as some
other ones, and also must be right next to some other ones; then we process all
VariableAccessData's and attempt to assign them machine locals while preserving those
constraints. This could lead to two VariableAccessDatas for the same bytecode local
ending up with different machine locals.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::isCaptured):
(JSC::CodeBlock::framePointerOffsetToGetActivationRegisters):
(JSC::CodeBlock::machineSlowArguments):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::hasSlowArguments):
- bytecode/CodeOrigin.cpp:
(JSC::CodeOrigin::dump):
(JSC::InlineCallFrame::calleeForCallFrame):
(JSC::InlineCallFrame::dumpInContext):
- bytecode/CodeOrigin.h:
(JSC::InlineCallFrame::InlineCallFrame):
(JSC::InlineCallFrame::calleeConstant):
- bytecode/Operands.h:
(JSC::Operands::indexForOperand):
- dfg/DFGBasicBlock.cpp:
(JSC::DFG::BasicBlock::SSAData::SSAData):
- dfg/DFGBasicBlock.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCommon.h:
- dfg/DFGCommonData.h:
(JSC::DFG::CommonData::CommonData):
- dfg/DFGDesiredWriteBarriers.cpp:
(JSC::DFG::DesiredWriteBarrier::trigger):
- dfg/DFGDesiredWriteBarriers.h:
- dfg/DFGFlushLivenessAnalysisPhase.cpp:
(JSC::DFG::FlushLivenessAnalysisPhase::run):
(JSC::DFG::FlushLivenessAnalysisPhase::process):
(JSC::DFG::FlushLivenessAnalysisPhase::reportError):
- dfg/DFGFlushedAt.cpp: Added.
(JSC::DFG::FlushedAt::dump):
(JSC::DFG::FlushedAt::dumpInContext):
- dfg/DFGFlushedAt.h: Added.
(JSC::DFG::FlushedAt::FlushedAt):
(JSC::DFG::FlushedAt::operator!):
(JSC::DFG::FlushedAt::format):
(JSC::DFG::FlushedAt::virtualRegister):
(JSC::DFG::FlushedAt::operator==):
(JSC::DFG::FlushedAt::operator!=):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::bytecodeRegisterForArgument):
(JSC::DFG::Graph::argumentsRegisterFor):
(JSC::DFG::Graph::machineArgumentsRegisterFor):
(JSC::DFG::Graph::uncheckedArgumentsRegisterFor):
(JSC::DFG::Graph::activationRegister):
(JSC::DFG::Graph::uncheckedActivationRegister):
(JSC::DFG::Graph::machineActivationRegister):
(JSC::DFG::Graph::uncheckedMachineActivationRegister):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToGetLocalUnlinked):
(JSC::DFG::Node::convertToGetLocal):
(JSC::DFG::Node::machineLocal):
(JSC::DFG::Node::hasUnlinkedMachineLocal):
(JSC::DFG::Node::setUnlinkedMachineLocal):
(JSC::DFG::Node::unlinkedMachineLocal):
(JSC::DFG::Node::hasInlineStartData):
(JSC::DFG::Node::inlineStartData):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSREntry.h:
(JSC::DFG::OSREntryReshuffling::OSREntryReshuffling):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::ScoreBoard):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::calleeFrameOffset):
(JSC::DFG::SpeculativeJIT::callFrameSlot):
(JSC::DFG::SpeculativeJIT::argumentSlot):
(JSC::DFG::SpeculativeJIT::callFrameTagSlot):
(JSC::DFG::SpeculativeJIT::callFramePayloadSlot):
(JSC::DFG::SpeculativeJIT::argumentTagSlot):
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
(JSC::DFG::SpeculativeJIT::framePointerOffsetToGetActivationRegisters):
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::recordSetLocal):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStackLayoutPhase.cpp: Added.
(JSC::DFG::StackLayoutPhase::StackLayoutPhase):
(JSC::DFG::StackLayoutPhase::run):
(JSC::DFG::performStackLayout):
- dfg/DFGStackLayoutPhase.h: Added.
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::machineLocal):
(JSC::DFG::VariableAccessData::flushedAt):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- ftl/FTLExitValue.h:
(JSC::FTL::ExitValue::inJSStack):
(JSC::FTL::ExitValue::inJSStackAsInt32):
(JSC::FTL::ExitValue::inJSStackAsInt52):
(JSC::FTL::ExitValue::inJSStackAsDouble):
(JSC::FTL::ExitValue::virtualRegister):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetArgument):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLValueSource.cpp:
(JSC::FTL::ValueSource::dump):
- ftl/FTLValueSource.h:
(JSC::FTL::ValueSource::ValueSource):
(JSC::FTL::ValueSource::kind):
(JSC::FTL::ValueSource::operator!):
(JSC::FTL::ValueSource::node):
(JSC::FTL::ValueSource::virtualRegister):
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::readInlinedFrame):
(JSC::StackVisitor::Frame::createArguments):
(JSC::StackVisitor::Frame::existingArguments):
- interpreter/StackVisitor.h:
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::addressFor):
(JSC::AssemblyHelpers::tagFor):
(JSC::AssemblyHelpers::payloadFor):
(JSC::AssemblyHelpers::offsetOfArgumentsIncludingThis):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
- runtime/Arguments.h:
(JSC::Arguments::allocateSlowArguments):
(JSC::Arguments::tryDeleteArgument):
(JSC::Arguments::isDeletedArgument):
(JSC::Arguments::isArgument):
(JSC::Arguments::argument):
(JSC::Arguments::finishCreation):
- runtime/JSActivation.h:
(JSC::JSActivation::create):
(JSC::JSActivation::JSActivation):
- runtime/JSFunction.cpp:
(JSC::RetrieveArgumentsFunctor::operator()):
- 8:16 PM Changeset in webkit [156983] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests should be less verbose
https://bugs.webkit.org/show_bug.cgi?id=122397
Reviewed by Sam Weinig.
It now just prints something like:
965/1831 ....
Where the first number is the number of tests that completed, the second number is the
number of tests total, and the dots are the number of tests running right now - which is
useful towards the end when you're waiting for the last slow tests to finish.
It will also print out the output from failing tests and it will print a line for skipped
tests (to annoy you into getting them into a shape where they can be unskipped). For
example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
- Scripts/run-jsc-stress-tests:
- 7:32 PM Changeset in webkit [156982] by
-
- 3 edits in trunk/Source/WebCore
FrameSelection: Remove two unused member functions.
Rubber-stamped by Anders Carlsson.
- rootEditableElementOrTreeScopeRootNode()
- rootEditableElementRespectingShadowTree()
- 7:30 PM Changeset in webkit [156981] by
-
- 45 edits in trunk/Source/WebCore
CTTE: Node::treeScope() should return a reference.
<https://webkit.org/b/122399>
Reviewed by Superlative Sam.
Every Node belongs to a TreeScope. To enforce this, I've made
treeScope() return a TreeScope&, and setTreeScope() now takes a
TreeScope& so there is no way to clear it.
- 6:08 PM Changeset in webkit [156980] by
-
- 45 edits in trunk/Source/WebCore
CTTE: Use references more for the Document parser
https://bugs.webkit.org/show_bug.cgi?id=122398
Reviewed by Andreas Kling.
Clarify the construction semantics of Document parsers.
- 5:34 PM Changeset in webkit [156979] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Default initialize Settings::setFixedPositionCreatesStackingContext() to true
https://bugs.webkit.org/show_bug.cgi?id=122338
<rdar://problem/14908151>
Reviewed by Darin Adler.
On iOS we always want an element with a fixed position to create a stacking context.
See <rdar://problem/9813262> for more details.
- page/Settings.cpp: Define constant defaultFixedPositionCreatesStackingContext to
be true when building for iOS and false otherwise.
- page/Settings.in: Initialize the setting fixedPositionCreatesStackingContext with
the value of the constant defaultFixedPositionCreatesStackingContext.
- 4:59 PM Changeset in webkit [156978] by
-
- 17 edits in trunk/Source
CTTE: Pass DocumentWriter around as a reference
https://bugs.webkit.org/show_bug.cgi?id=122396
Reviewed by Andreas Kling.
../WebCore:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
- dom/DecodedDataDocumentParser.cpp:
(WebCore::DecodedDataDocumentParser::appendBytes):
(WebCore::DecodedDataDocumentParser::flush):
- dom/DecodedDataDocumentParser.h:
- dom/DocumentParser.h:
- dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::flush):
- html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::appendBytes):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::appendBytes):
(WebCore::MediaDocument::replaceMediaElementTimerFired):
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
(WebCore::PluginDocumentParser::appendBytes):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::overlayPage):
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::writer):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::addData):
(WebCore::DocumentWriter::end):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
- loader/SinkDocument.cpp:
(WebCore::SinkDocumentParser::appendBytes):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
../WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _canProvideDocumentSource]):
- 4:56 PM Changeset in webkit [156977] by
-
- 4 edits in trunk/Source/WebCore
FrameView: Remove code for disabling repaints.
<https://webkit.org/b/122393>
Reviewed by Sam Weinig.
Nobody uses this mode for anything so let's just remove it.
It was added back in r110469 to fix an issue with SVGImageCache
and its only user disappeard in the cache overhaul in r142765.
- 4:53 PM Changeset in webkit [156976] by
-
- 6 edits in trunk
Allow skipping of run-jsc-stress-tests that are configured using yaml files
https://bugs.webkit.org/show_bug.cgi?id=122385
Tools:
Reviewed by Sam Wieinig.
Make tests run via YAML be able to do the parse-for-commands trick that allows
us to skip tests and do other custom per-test stuff.
- Scripts/jsc-stress-test-helpers/layout-test-helper:
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Sam Weinig.
The way that we "skip" tests is by having a custom command at the top using @ notation,
and then use "@ skip". But the machinery to do that also allows us to do things like
run tests in a no-concurrent-JIT mode - so I've also implemented that in this patch.
Use the skip machinery to skip large-expressions.js.
- js/script-tests/large-expressions.js:
- jsc-layout-tests.yaml:
- 4:02 PM Changeset in webkit [156975] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Remove IFrameShimSupport, it was only used by dead ports.
Rubber-stamped by Anders Carlsson.
- plugins/IFrameShimSupport.cpp: Removed.
- plugins/IFrameShimSupport.h: Removed.
- 3:57 PM Changeset in webkit [156974] by
-
- 34 deletes in trunk
Remove remaining Qt files.
Rubber-stamped by Anders Carlsson.
- 2:57 PM Changeset in webkit [156973] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the GTK+ build.
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::platformInitialize):
- 2:53 PM Changeset in webkit [156972] by
-
- 19 edits in trunk/Source
Clean up MessageQueue.h
https://bugs.webkit.org/show_bug.cgi?id=122392
Reviewed by Andreas Kling.
Source/WebCore:
Update for changes to MessageQueue, mostly changing create functions to return std::unique_ptr.
I intentionally avoided using std::make_unique in a couple of places because I didn't want to make nested classes
public, and I believe that we can change some of this code to use std::function.
- Modules/webaudio/AsyncAudioDecoder.cpp:
(WebCore::AsyncAudioDecoder::decodeAsync):
(WebCore::AsyncAudioDecoder::runLoop):
(WebCore::AsyncAudioDecoder::DecodingTask::create):
- Modules/webaudio/AsyncAudioDecoder.h:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::tableNames):
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::openAndVerifyVersion):
(WebCore::DatabaseBackend::scheduleTransaction):
(WebCore::DatabaseBackend::scheduleTransactionStep):
- Modules/webdatabase/DatabaseTask.h:
(WebCore::DatabaseBackend::DatabaseOpenTask::create):
(WebCore::DatabaseBackend::DatabaseCloseTask::create):
(WebCore::DatabaseBackend::DatabaseTransactionTask::create):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::create):
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::scheduleTask):
(WebCore::DatabaseThread::scheduleImmediateTask):
(WebCore::SameDatabasePredicate::operator()):
- Modules/webdatabase/DatabaseThread.h:
- dom/default/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::EventData::create):
(WebCore::MessagePortChannel::tryGetMessageFromRemote):
- dom/default/PlatformMessagePortChannel.h:
(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
(WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
- fileapi/FileThread.cpp:
(WebCore::FileThread::postTask):
(WebCore::SameInstancePredicate::operator()):
(WebCore::FileThread::runLoop):
- fileapi/FileThread.h:
- fileapi/FileThreadTask.h:
(WebCore::createFileThreadTask):
- storage/StorageThread.cpp:
(WebCore::StorageThread::threadEntryPoint):
(WebCore::StorageThread::dispatch):
(WebCore::StorageThread::terminate):
- workers/WorkerRunLoop.cpp:
(WebCore::ModePredicate::operator()):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):
(WebCore::WorkerRunLoop::Task::create):
- workers/WorkerRunLoop.h:
Source/WTF:
Make MessageQueue use std::unique_ptr and change findIf and removeIf to take const references.
- wtf/Deque.h:
Change findIf to take an rvalue reference.
- wtf/MessageQueue.h:
(WTF::::append):
(WTF::::appendAndKill):
(WTF::::appendAndCheckEmpty):
(WTF::::prepend):
(WTF::::removeIf):
- 12:27 PM Changeset in webkit [156971] by
-
- 4 edits in trunk/Source/WebCore
[WebGL] program should not be able to link if a bad shader is attached
https://bugs.webkit.org/show_bug.cgi?id=94036
Reviewed by Darin Adler.
If you attempt to link a program when bad shaders are attached, the
link should fail. WebGL also requires that the previously linked
program should remain intact. We were doing the former, but not
the latter.
Fix this by not calling glLinkProgram if we know we have bad
shaders, and synthesize a bad link status instead.
Test: WebGL conformance test conformance/programs/program-test.html
(found in LayoutTests/webgl)
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::compileShader): Mark a shader as valid
if it compiled ok.
(WebCore::WebGLRenderingContext::linkProgram): Don't call into GraphicsContext3D::linkProgram
if we know that we don't have valid shaders.
- html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::WebGLShader): Initialize m_isValid.
- html/canvas/WebGLShader.h:
(WebCore::WebGLShader::isValid): New member variable getter and setter.
(WebCore::WebGLShader::setValid):
- 12:21 PM Changeset in webkit [156970] by
-
- 3 edits in trunk/Source/WebCore
Undo texture unit code refactoring - it is ok to bind a texture to multiple locations
https://bugs.webkit.org/show_bug.cgi?id=122369
<rdar://problem/15158465>
Reviewed by Darin Adler.
The optimisation in r152351 (http://webkit.org/b/117868) incorrectly
assumes that a texture cannot be bound to more than one location.
That's true only within the same program object. It's legal to
address TEXTURE_BINDING_2D and TEXTURE_BINDING_CUBE_MAP with the
same texture in different programs.
See https://github.com/KhronosGroup/WebGL/pull/391 for more information.
This change reverts the optimisation, but also does some minor
cleanup (0 -> nullptr, class -> struct).
Covered by the following Khronos WebGL 1.0.1 tests, which
now pass:
- conformance/more/functions/texImage2DHTML.html
- conformance/more/functions/texSubImage2D.html
- conformance/more/functions/texSubImage2DHTML.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::handleNPOTTextures):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
- html/canvas/WebGLRenderingContext.h:
- 12:02 PM Changeset in webkit [156969] by
-
- 2 edits in trunk/Source/WTF
Try to #define final to sealed when building with MSVC
https://bugs.webkit.org/show_bug.cgi?id=122386
Reviewed by Darin Adler.
- wtf/Compiler.h:
- 11:59 AM Changeset in webkit [156968] by
-
- 34 edits in trunk/Source
Remove createOwned
https://bugs.webkit.org/show_bug.cgi?id=122388
Reviewed by Darin Adler.
Source/JavaScriptCore:
- profiler/ProfilerDatabase.cpp:
(JSC::Profiler::Database::save):
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::createRenderTree):
(WebCore::Document::destroyRenderTree):
- dom/Document.h:
- page/Frame.cpp:
(WebCore::Frame::Frame):
- page/Frame.h:
- page/animation/AnimationController.cpp:
(WebCore::AnimationController::AnimationController):
- page/animation/AnimationController.h:
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h:
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC):
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack):
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:
(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC):
(WebCore::VideoTrackPrivateAVFObjC::setPlayerItemTrack):
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
- rendering/svg/RenderSVGResourceClipper.h:
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
- rendering/svg/RenderSVGResourceMasker.h:
Source/WebKit2:
- UIProcess/API/mac/WKView.mm:
(-[WKView _setFindIndicator:fadeOut:animate:]):
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(WKBundlePageOverlayCreate):
Source/WTF:
Since we're going with std::unique_ptr instead of OwnPtr, there's no need for makeOwned to exist.
Get rid of it and replace it with calls to std::make_unique.
- wtf/FilePrintStream.cpp:
(WTF::FilePrintStream::open):
- wtf/FilePrintStream.h:
- wtf/HashTable.h:
(WTF::::HashTable):
- wtf/ListHashSet.h:
(WTF::::ListHashSet):
- wtf/OwnPtr.h:
- wtf/Threading.cpp:
(WTF::compatEntryPoint):
(WTF::createThread):
- wtf/ThreadingPthreads.cpp:
(WTF::wtfThreadEntryPoint):
(WTF::createThreadInternal):
- wtf/unicode/Collator.h:
- wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault):
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
- 11:32 AM Changeset in webkit [156967] by
-
- 10 edits in trunk/Source
Remove COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES) since it's required now
https://bugs.webkit.org/show_bug.cgi?id=122387
Reviewed by Anders Carlsson.
Source/WebCore:
- html/canvas/CanvasStyle.h: Take out conditionals.
Source/WebKit2:
- UIProcess/API/cpp/WKRetainPtr.h: Take out conditionals.
Source/WTF:
- wtf/RefPtr.h:
- wtf/RetainPtr.h:
- wtf/Vector.h:
- wtf/text/AtomicString.h:
- wtf/text/WTFString.h:
Take out conditionals.
- 11:31 AM Changeset in webkit [156966] by
-
- 2 edits in trunk/Source/WebKit/gtk
Unreviewed GTK build fix after r156946. The framePolicyFunction is an attribute
on the WebKitWebPolicyDecisionPrivate object.
- webkit/webkitwebpolicydecision.cpp:
(webkit_web_policy_decision_use):
(webkit_web_policy_decision_ignore):
(webkit_web_policy_decision_download):
- 11:22 AM Changeset in webkit [156965] by
-
- 22 edits in trunk/Source
Add AtomicString::number and use it
https://bugs.webkit.org/show_bug.cgi?id=122384
Reviewed by Anders Carlsson.
Source/WebCore:
- css/CSSGrammar.y.in: Use AtomicString::number instead of String::number since
we are creating an AtomicString. This can save a memory allocation if the string
happens to already be in the atomic string table.
- dom/Element.cpp:
(WebCore::Element::setIntegralAttribute): Ditto.
(WebCore::Element::setUnsignedIntegralAttribute): Ditto.
- editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply): Ditto.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto): Use setIntegralAttribute instead of
a local homegrown equivalent.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::setHeight): Ditto.
(WebCore::HTMLCanvasElement::setWidth): Ditto.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setTabIndex): Ditto.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::setHeight): Ditto.
(WebCore::HTMLImageElement::setWidth): Ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setMaxLength): Ditto.
(WebCore::HTMLInputElement::setSize): Same, but setUnsignedIntegralAttribute.
(WebCore::HTMLInputElement::setHeight): Ditto.
(WebCore::HTMLInputElement::setWidth): Ditto.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerSetSize): Ditto.
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::setMin): More of the same.
(WebCore::HTMLMeterElement::setMax): Ditto.
(WebCore::HTMLMeterElement::setValue): Ditto.
(WebCore::HTMLMeterElement::setLow): Ditto.
(WebCore::HTMLMeterElement::setHigh): Ditto.
(WebCore::HTMLMeterElement::setOptimum): Ditto.
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::setStart): Ditto.
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::setValue): Ditto.
(WebCore::HTMLProgressElement::setMax): Ditto.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute): Ditto.
(WebCore::HTMLSelectElement::setSize): Ditto.
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::setColSpan): Ditto.
(WebCore::HTMLTableCellElement::setRowSpan): Ditto.
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::setSpan): Ditto.
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setMaxLength): Ditto.
(WebCore::HTMLTextAreaElement::setCols): Ditto.
(WebCore::HTMLTextAreaElement::setRows): Ditto.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::setDuration): Ditto.
Source/WTF:
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::number): Added.
- wtf/text/AtomicString.h: Ditto.
- wtf/text/IntegerToStringConversion.h: Simplify includes, renamed ConversionTrait to
IntegerToStringConversionTrait. Changed String version to use String since we no longer
need to use PassRefPtr to efficiently handle return values. Replaced UnsignedIntegerTrait
with std::make_unsigned. Added AtomicString support. Use nullptr instead of 0.
- 11:04 AM Changeset in webkit [156964] by
-
- 16 edits in trunk/Source
Cut down on use of String::number
https://bugs.webkit.org/show_bug.cgi?id=122382
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::putByIndex): Use Identifier::from instead of calling
String::number and creating an identifier from that. Can save creating and then
destroying a string if an identifier already exists.
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlotByIndex): Ditto.
(JSC::Arguments::getOwnPropertyNames): Ditto.
(JSC::Arguments::putByIndex): Ditto.
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::::getOwnPropertyNames): Ditto.
- runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames): Ditto.
Source/WebCore:
- css/CSSGradientValue.cpp:
(WebCore::CSSLinearGradientValue::customCSSText): Use StringBuilder::appendNumber,
instead of creating a string and then appending it.
(WebCore::CSSRadialGradientValue::customCSSText): Ditto.
- css/CSSParser.cpp:
(WebCore::CSSParser::createKeyframe): Ditto.
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI): Use ASCII literals instead of
converting numeric constants to strings at runtime with String::number.
(WebCore::DeleteButtonController::show): Ditto.
- svg/SVGNumberList.cpp:
(WebCore::SVGNumberList::valueAsString): Use StringBuilder::appendNumber.
- svg/SVGPointList.cpp:
(WebCore::SVGPointList::valueAsString): Ditto.
- svg/SVGRect.h: Ditto.
Source/WebKit2:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::dumpChangedLayers): Use StringBuilder::appendNumber.
Source/WTF:
- wtf/DateMath.cpp:
(WTF::appendTwoDigitNumber): Added. Replaces twoDigitStringFromNumber, which returned a
String and also allocated a temporary string for any number 10 or higher.
(WTF::makeRFC2822DateString): Updated to use the new function.
- 10:45 AM Changeset in webkit [156963] by
-
- 6 edits in trunk/Source
Test the waters and begin using lambdas
https://bugs.webkit.org/show_bug.cgi?id=121809
Reviewed by Andreas Kling.
Source/WebCore:
Use lambdas instead of static functions and function objects.
- css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery):
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::deliverAllMutations):
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::sortedTrackListForMenu):
Source/WTF:
- wtf/ListDump.h:
(WTF::sortedListDump):
Use std::less instead of a custom lessThan function.
- 10:07 AM Changeset in webkit [156962] by
-
- 2 edits8 adds in trunk/LayoutTests
[CSS Regions] Layout Test for selecting text ignoring region content
https://bugs.webkit.org/show_bug.cgi?id=122353
Reviewed by Darin Adler.
Add new reftests for selecting text in texts wrapping a region, where
the region content is ignored. It compares the behavior (highlighted
text and selected content) in regions and absolute positions.
Absolute positioned elements do not fill the gaps on the right during
the selection, unlike regular elements. This is the reason why some
regular elements are floated in order to avoid such problems in the
reftests.
Provided layout tests for different writing models.
- fast/regions/resources/region-style.css: New CSS classes required for these tests.
- fast/regions/selection/selecting-text-ignoring-region-expected.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-horiz-bt.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-vert-lr.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html: Added.
- fast/regions/selection/selecting-text-ignoring-region-vert-rl.html: Added.
- fast/regions/selection/selecting-text-ignoring-region.html: Added.
- 10:06 AM Changeset in webkit [156961] by
-
- 11 edits2 moves in trunk/Source/WebCore
Add *CSS* prefix to FontValue to generate toCSSFontValue()
https://bugs.webkit.org/show_bug.cgi?id=122201
Reviewed by Darin Adler.
*CSS* prefix needs to be added to FontValue class in order to generate toCSSFontValue().
static_cast<FontValue*> is changed with toCSSFontValue() by this change.
No new tests, no behavior changes.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSFontValue.cpp: Renamed from Source/WebCore/css/FontValue.cpp.
(WebCore::CSSFontValue::customCSSText):
(WebCore::CSSFontValue::equals):
- css/CSSFontValue.h: Renamed from Source/WebCore/css/FontValue.h.
(WebCore::CSSFontValue::create):
(WebCore::CSSFontValue::CSSFontValue):
- css/CSSParser.cpp:
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 10:02 AM Changeset in webkit [156960] by
-
- 2 edits in trunk/Source/WebKit2
Fix cut and paste errors.
- Configurations/WebKit2.xcconfig:
- 9:55 AM Changeset in webkit [156959] by
-
- 2 edits in trunk/Source/WebKit2
Add the rest of the std::function weak symbols in an attempt to fix the Lion build.
- Configurations/WebKit2.xcconfig:
- 9:48 AM Changeset in webkit [156958] by
-
- 2 edits in trunk/Tools
Unreviewed, fix tests on older Rubies.
- Scripts/run-jsc-stress-tests:
- 9:46 AM Changeset in webkit [156957] by
-
- 4 edits in trunk
Source/WebKit2: Another attempt at fixing the Lion build.
- Configurations/WebKit2.xcconfig:
Tools: Don't filter the weak symbols.
- Scripts/check-for-weak-vtables-and-externals:
- 9:32 AM Changeset in webkit [156956] by
-
- 2 edits in trunk/Source/WebKit2
Attempt to fix the Lion build.
- Configurations/WebKit2.xcconfig:
Try unexporting one of the weak symbols for now. If this succeeds, I'll add the rest.
- 9:27 AM Changeset in webkit [156955] by
-
- 4 edits2 adds in trunk
Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
https://bugs.webkit.org/show_bug.cgi?id=122376
Tools:
Reviewed by Mark Hahnenberg.
- Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
- Scripts/run-javascriptcore-tests:
(printThingsFound):
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Mark Hahnenberg.
Add a yaml file describing which directories contain JS LayoutTests. run-jsc-stress-tests
will use this file.
- jsc-layout-tests.yaml: Added.
- 8:55 AM Changeset in webkit [156954] by
-
- 34 edits in trunk/Source/WebCore
Unreviewed, rolling out r156952.
http://trac.webkit.org/changeset/156952
https://bugs.webkit.org/show_bug.cgi?id=122381
Made svg/custom/large-image-pattern-crash.html assert
(Requested by ap on #webkit).
- rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/PaintInfo.h:
(WebCore::PaintInfo::shouldPaintWithinRoot):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paint):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
- rendering/RenderBox.h:
- rendering/RenderElement.h:
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paint):
- rendering/RenderLineBreak.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paint):
- rendering/RenderObject.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
(WebCore::RenderReplaced::shouldPaint):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
(WebCore::RenderTable::paintBoxDecorations):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
(WebCore::RenderTableCell::paintBoxDecorations):
- rendering/RenderTableCol.h:
- rendering/RenderText.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::paint):
(WebCore::RenderView::paintBoxDecorations):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paintEllipsisBox):
(WebCore::RootInlineBox::paintCustomHighlight):
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::createTileImage):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::renderSubtreeToImageBuffer):
- rendering/svg/SVGRenderingContext.h:
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::rendererClipChild):
- svg/SVGUseElement.h:
- svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::platformApplySoftware):
- 8:01 AM Changeset in webkit [156953] by
-
- 5 edits2 adds in trunk
Need to check if some HTML child elements are HTMLUnknownElement
https://bugs.webkit.org/show_bug.cgi?id=120297
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/media/media-disable-crash.html
- dom/make_names.pl:
(printConstructorInterior): Added additional comments about the
wrapperOnlyIfMediaIsAvailable feature.
(printTypeHelpers): Added an isHTMLUnknownElement check to the check helper
functions for tags with the wrapperOnlyIfMediaIsAvailable feature.
(printWrapperFunctions): Instead of redoing the media player check and the
settings check, and possibly making a wrapper of the wrong type, call
isHTMUnknownElement, guaranteeing that the wrapper will match the element
it is wrapping.
- html/HTMLElement.h: Move HTMLElementTypeHelpers.h to the bottom of the
file so that functions from that file can be use the HTMLElement class and
other things defined in this file.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::paused): Added an assertion that made the regression
test reliably assert, rather than intermittently (for me, non-reproducibly) crash.
LayoutTests:
Based on a test written by Zan Dobersek <zdobersek@igalia.com>.
- fast/media/media-disable-crash-expected.txt: Added.
- fast/media/media-disable-crash.html: Added.
- 4:58 AM Changeset in webkit [156952] by
-
- 34 edits in trunk/Source/WebCore
Move paint() to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122371
Reviewed by Darin Adler.
RenderText does not paint itself (text is painted by line boxes). We can move paint() down
to RenderElement.
This also requires some type tightening elsewhere in the code.
- 2:41 AM Changeset in webkit [156951] by
-
- 2 edits28 adds in trunk/PerformanceTests
DoYouEvenBench: Add Facebook's React TodoMVC test case
https://bugs.webkit.org/show_bug.cgi?id=122379
Reviewed by Andreas Kling.
Add React/TodoMVC as a new test case. Somehow we beat Firefox on this one as well.
- DoYouEvenBench/benchmark.html:
- DoYouEvenBench/todomvc/labs: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower.json: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/LICENSE: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/README.md: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.min.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/ender.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/JSXTransformer.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/bower.json: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.min.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.css: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/bg.png: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/index.html: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/app.jsx: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/footer.jsx: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/todoItem.jsx: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/js/utils.jsx: Added.
- DoYouEvenBench/todomvc/labs/architecture-examples/react/readme.md: Added.
Oct 4, 2013:
- 11:54 PM Changeset in webkit [156950] by
-
- 2 edits in trunk/Source/WebCore
Fix an assertion failure introduced in r156925.
Add HTMLImageElement to the document-wide map only if it's in the document.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
- 11:40 PM Changeset in webkit [156949] by
-
- 2 edits in trunk/Source/WebKit/mac
Don't preflight spell checker when calling -setContinuousSpellCheckingEnabled repeatedly
https://bugs.webkit.org/show_bug.cgi?id=122329
Reviewed by Darin Adler.
- WebView/WebView.mm: (-[WebView setContinuousSpellCheckingEnabled:]): Don't do any
work if preference didn't change (continuousSpellCheckingEnabled is a static that
starts with false).
- 11:38 PM Changeset in webkit [156948] by
-
- 18 edits2 adds in trunk
text-transform: lowercase is not lang-dependent (Turkish languages : tr,az)
https://bugs.webkit.org/show_bug.cgi?id=21312
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/text/text-transform-turkish-and-azeri.html
This patch covers text-transform: uppercase and text-transform: lowercase.
More changes will be needed to cover text-transform: capitalize.
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchNode): Use String::upper instead of String::makeUpper.
- page/EventHandler.cpp:
(WebCore::findDropZone): Use String::lower instead of String::makeLower.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Use String::upper instead of String::makeUpper.
- platform/network/blackberry/rss/RSS10Parser.cpp: [Seriously, how is an RSS parser
part of WebKit's networking layer? Where are the tests that cover this? Seems wrong
to have this code in the project.]
(WebCore::RSS10Parser::parseXmlDoc): Use lower instead of makeLower.
(WebCore::RSS10Parser::parseItem): Ditto.
(WebCore::RSS10Parser::parseFeed): Ditto.
- platform/network/blackberry/rss/RSS20Parser.cpp:
(WebCore::RSS20Parser::parseXmlDoc): Ditto.
(WebCore::RSS20Parser::parseItem): Ditto.
(WebCore::RSS20Parser::parseFeed): Ditto.
(WebCore::RSS20Parser::parseEnclosure): Ditto.
- platform/network/blackberry/rss/RSSAtomParser.cpp:
(WebCore::RSSAtomParser::parseXmlDoc): Ditto.
(WebCore::RSSAtomParser::parseItem): Ditto.
(WebCore::RSSAtomParser::parseFeed): Ditto.
(WebCore::RSSAtomParser::parseLink): Ditto.
(WebCore::RSSAtomParser::parseContent): Ditto.
(WebCore::RSSAtomParser::parseAuthor): Ditto.
(WebCore::RSSAtomParser::parseCategory): Ditto.
- platform/text/win/LocaleWin.cpp:
(WebCore::convertLocaleNameToLCID): Use String::lower instead of String::makeLower.
- rendering/RenderText.cpp:
(WebCore::applyTextTransform): Use String::upper and String::lower instead of
String::makeUpper and String::makeLower, and also pass in the locale to each.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod): Changed this so it doesn't call
upper just to return an already known string constant.
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::doCommand): Use StringImpl::upper instead of
StringImpl::makeUpper.
Source/WTF:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::upper): Removed an extra call that would unnecessarily reallocate
a StringImpl in the general non-ASCII case. Added an overload that takes a locale identifier.
(WTF::StringImpl::lower): Ditto.
- wtf/text/StringImpl.h: Ditto.
- wtf/text/WTFString.cpp:
(WTF::String::lower): Ditto.
(WTF::String::upper): Ditto.
- wtf/text/WTFString.h: Ditto. Also deleted the makeLower and makeUpper functions since they
offer no advantages over the lower and upper functions. Also added a constructor that takes
a RefPtr<StringImpl> with move construction to help.
LayoutTests:
- fast/text/text-transform-turkish-and-azeri-expected.html: Added.
- fast/text/text-transform-turkish-and-azeri.html: Added.
- 11:32 PM Changeset in webkit [156947] by
-
- 19 edits8 deletes in trunk
Roll out r156930 and r156937, they caused 34 assertion failures on bots.
- 9:52 PM Changeset in webkit [156946] by
-
- 23 edits in trunk/Source
FramePolicyFunction should be an std::function
https://bugs.webkit.org/show_bug.cgi?id=122362
Reviewed by Darin Adler.
Source/WebCore:
This makes policy callback handling simpler inside WebKit.
- loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebCore::EmptyFrameLoaderClient::dispatchWillSubmitForm):
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
- loader/FrameLoaderClient.h:
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::checkContentPolicy):
Source/WebKit/efl:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::callPolicyFunction):
(WebCore::FrameLoaderClientEfl::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
- WebCoreSupport/FrameLoaderClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchWillSubmitForm):
(WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
- WebCoreSupport/FrameLoaderClientGtk.h:
- webkit/webkitwebpolicydecision.cpp:
(webkit_web_policy_decision_use):
(webkit_web_policy_decision_ignore):
(webkit_web_policy_decision_download):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::dispatchWillSubmitForm):
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::dispatchWillSubmitForm):
(WebFrameLoaderClient::receivedPolicyDecision):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::didReceivePolicyDecision):
- 9:48 PM Changeset in webkit [156945] by
-
- 6 edits in trunk/Source/WebCore
CTTE: IconController and IconLoader should have Frame& backpointer.
<https://webkit.org/b/122372>
Reviewed by Anders Carlsson.
Also slap IconLoader with FINAL glove.
- 9:30 PM Changeset in webkit [156944] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed EFL build fix after r156924
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::platformInitialize):
- 9:24 PM Changeset in webkit [156943] by
-
- 2 edits in trunk/Tools
It should be even easier to run and debug a failing JSC stress test
https://bugs.webkit.org/show_bug.cgi?id=122337
Reviewed by Oliver Hunt.
If a test fails, you can now just say:
sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
and get the reproduction. You don't have to set any environment variables like before.
Also if you want to debug the failing test you can now just say:
sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
Broadly, any arguments passed to the reproduction script are prepended to the command to
run the test. This is sort of quirky and won't work for some tests (for example the
profiler tests run a ruby script that runs some other stuff) but it'll work for most of
them and that's good enough for now.
- Scripts/run-jsc-stress-tests:
- 8:50 PM Changeset in webkit [156942] by
-
- 4 edits in trunk/Source/WebCore
CTTE: RenderScrollbar DOM owner is always an Element.
<https://webkit.org/b/122348>
Reviewed by Antti Koivisto.
When RenderScrollbar is owned by a DOM node, it's always Element.
Tighten the code a bit with this knowledge.
Also marked the class FINAL and beat it with the OVERRIDE stick.
- 8:34 PM Changeset in webkit [156941] by
-
- 7 edits in trunk/Source/WebCore
TypingCommand helpers should take Document&.
<https://webkit.org/b/122370>
Reviewed by Anders Carlsson.
Instead of taking a Document* and immediately asserting that it's
non-null, just take Document&.
- 7:59 PM Changeset in webkit [156940] by
-
- 18 edits in trunk/Source/WebCore
Use more references instead of pointers in DocumentOrderedMap
https://bugs.webkit.org/show_bug.cgi?id=122368
Reviewed by Andreas Kling.
Use AtomicStringImpl& instead of AtomicString* or AtomicString& to eliminate
assertions and nullity checks.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):
- dom/Document.cpp:
(WebCore::Document::addImageElementByLowercasedUsemap):
(WebCore::Document::removeImageElementByLowercasedUsemap):
(WebCore::Document::imageElementByLowercasedUsemap):
- dom/Document.h:
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesId):
(WebCore::keyMatchesName):
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::keyMatchesLabelForAttribute):
(WebCore::keyMatchesWindowNamedItem):
(WebCore::keyMatchesDocumentNamedItem):
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByName):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):
(WebCore::DocumentOrderedMap::getElementByWindowNamedItem):
(WebCore::DocumentOrderedMap::getElementByDocumentNamedItem):
(WebCore::DocumentOrderedMap::getAllElementsById):
- dom/DocumentOrderedMap.h:
(WebCore::DocumentOrderedMap::containsSingle):
(WebCore::DocumentOrderedMap::contains):
(WebCore::DocumentOrderedMap::containsMultiple):
- dom/Element.cpp:
(WebCore::Element::updateNameForTreeScope):
(WebCore::Element::updateNameForDocument):
(WebCore::Element::updateIdForTreeScope):
(WebCore::Element::updateIdForDocument):
(WebCore::Element::updateLabel):
- dom/IdTargetObserverRegistry.cpp:
(WebCore::IdTargetObserverRegistry::notifyObserversInternal):
- dom/IdTargetObserverRegistry.h:
(WebCore::IdTargetObserverRegistry::notifyObservers):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getElementById):
(WebCore::TreeScope::getAllElementsById):
(WebCore::TreeScope::addElementById):
(WebCore::TreeScope::removeElementById):
(WebCore::TreeScope::getElementByName):
(WebCore::TreeScope::addElementByName):
(WebCore::TreeScope::removeElementByName):
(WebCore::TreeScope::addImageMap):
(WebCore::TreeScope::removeImageMap):
(WebCore::TreeScope::getImageMap):
(WebCore::TreeScope::addLabel):
(WebCore::TreeScope::removeLabel):
(WebCore::TreeScope::labelElementForId):
- dom/TreeScope.h:
(WebCore::TreeScope::hasElementWithId):
(WebCore::TreeScope::containsMultipleElementsWithId):
(WebCore::TreeScope::hasElementWithName):
(WebCore::TreeScope::containsMultipleElementsWithName):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::namedItem):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::addDocumentNamedItem):
(WebCore::HTMLDocument::removeDocumentNamedItem):
(WebCore::HTMLDocument::addWindowNamedItem):
(WebCore::HTMLDocument::removeWindowNamedItem):
- html/HTMLDocument.h:
(WebCore::HTMLDocument::documentNamedItem):
(WebCore::HTMLDocument::hasDocumentNamedItem):
(WebCore::HTMLDocument::documentNamedItemContainsMultipleElements):
(WebCore::HTMLDocument::windowNamedItem):
(WebCore::HTMLDocument::hasWindowNamedItem):
(WebCore::HTMLDocument::windowNamedItemContainsMultipleElements):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::parseAttribute):
(WebCore::HTMLMapElement::insertedInto):
(WebCore::HTMLMapElement::removedFrom):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateDocNamedItem):
- 7:06 PM Changeset in webkit [156939] by
-
- 4 edits in trunk/Source/WebCore
CTTE: PolicyChecker backpointer to Frame should be a reference.
<https://webkit.org/b/122354>
Reviewed by Anders Carlsson.
PolicyChecker is tied to the lifetime of FrameLoader, which in turn
is tied to the lifetime of Frame.
- 6:06 PM Changeset in webkit [156938] by
-
- 3 edits in trunk/Source/WebCore
Editor should use reference-getting document() internally.
<https://webkit.org/b/122364>
Reviewed by Darin Adler.
Instead of grabbing at Editor::m_frame.document(), use the nice
Editor::document() helper that always returns a Document&.
Calling Editor methods on a Frame's editor() while there is no
Document in the Frame is a programming error and this is covered
by an assertion in document().
This removes a bunch of null checks and enables further cleanup.
- 6:03 PM Changeset in webkit [156937] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build after r156930.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::paintCharacter): Use ceilf and floorf to avoid issues
with overload collisions and implicit casts of LayoutUnits.
- 5:51 PM Changeset in webkit [156936] by
-
- 19 edits8 adds in trunk
Change ScriptDebugServer to use DebuggerCallFrame instead of JavaScriptCallFrame.
https://bugs.webkit.org/show_bug.cgi?id=121969.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
- ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
- Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
- DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
- DebuggerCallFrame's line() and column() now returns a base-zero int.
- WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
- Also removed evaluateInGlobalCallFrame() which is not used anywhere.
- debugger/Debugger.cpp:
- debugger/Debugger.h:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::callerFrame):
(JSC::DebuggerCallFrame::dynamicGlobalObject):
(JSC::DebuggerCallFrame::sourceId):
(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::type):
(JSC::DebuggerCallFrame::thisValue):
(JSC::DebuggerCallFrame::evaluate):
(JSC::DebuggerCallFrame::evaluateWithCallFrame):
(JSC::DebuggerCallFrame::invalidate):
(JSC::DebuggerCallFrame::positionForCallFrame):
(JSC::DebuggerCallFrame::sourceIdForCallFrame):
(JSC::DebuggerCallFrame::thisValueForCallFrame):
- debugger/DebuggerCallFrame.h:
(JSC::DebuggerCallFrame::create):
(JSC::DebuggerCallFrame::exec):
(JSC::DebuggerCallFrame::line):
(JSC::DebuggerCallFrame::column):
(JSC::DebuggerCallFrame::position):
(JSC::DebuggerCallFrame::isValid):
- interpreter/StackVisitor.cpp:
Source/WebCore:
Tests: inspector-protocol/debugger/call-frame-function-name.html
inspector-protocol/debugger/call-frame-this-host.html
inspector-protocol/debugger/call-frame-this-nonstrict.html
inspector-protocol/debugger/call-frame-this-strict.html
- Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
- ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
- Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
- DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
- DebuggerCallFrame's line() and column() now returns a base-zero int.
- WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
- Also removed evaluateInGlobalCallFrame() which is not used anywhere.
- bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::thisObject):
- bindings/js/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
(WebCore::JavaScriptCallFrame::caller):
- bindings/js/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::functionName):
(WebCore::JavaScriptCallFrame::type):
(WebCore::JavaScriptCallFrame::scopeChain):
(WebCore::JavaScriptCallFrame::dynamicGlobalObject):
(WebCore::JavaScriptCallFrame::thisValue):
(WebCore::JavaScriptCallFrame::evaluate):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::DebuggerCallFrameScope::DebuggerCallFrameScope):
(WebCore::DebuggerCallFrameScope::~DebuggerCallFrameScope):
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::evaluateBreakpointAction):
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::stepOverStatement):
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::currentDebuggerCallFrame):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::updateCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::pauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
- bindings/js/ScriptDebugServer.h:
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::willExecuteProgram):
Source/WebKit/mac:
- Make JavaScriptCallFrame a thin shell around the DebuggerCallFrame. DebuggerCallFrame now tracks whether it is valid instead of needing JavaScriptCallFrame do it.
- ScriptDebugServer now only instantiates an DebuggerCallFrame when needed just before it pauses and calls back to its client, and then invalidates it immediately when the callback returns. Every subsequent callback to the client will use a new instance of the DebuggerCallFrame.
- Similarly, ScriptDebugServer now only creates a JavaScriptCallFrame when it "pauses".
- DebuggerCallFrame only creates its caller DebuggerCallFrame when it is needed i.e. when the client calls callerFrame(). Similarly, JavaScriptCallFrame only creates its caller when it's requested.
- DebuggerCallFrame's line() and column() now returns a base-zero int.
- WebScriptDebugDelegate now only caches the functionName of the frame instead of the entire DebuggerCallFrame because that is all that is needed.
- Also removed evaluateInGlobalCallFrame() which is not used anywhere.
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFramePrivate dealloc]):
(-[WebScriptCallFrame _initWithGlobalObject:functionName:exceptionValue:JSC::]):
(-[WebScriptCallFrame functionName]):
(-[WebScriptCallFrame exception]):
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::exception):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector-protocol/debugger/call-frame-function-name-expected.txt: Added.
- inspector-protocol/debugger/call-frame-function-name.html: Added.
- inspector-protocol/debugger/call-frame-this-host-expected.txt: Added.
- inspector-protocol/debugger/call-frame-this-host.html: Added.
- inspector-protocol/debugger/call-frame-this-nonstrict-expected.txt: Added.
- inspector-protocol/debugger/call-frame-this-nonstrict.html: Added.
- inspector-protocol/debugger/call-frame-this-strict-expected.txt: Added.
- inspector-protocol/debugger/call-frame-this-strict.html: Added.
- inspector/debugger/pause-in-internal-script-expected.txt:
- 5:40 PM Changeset in webkit [156935] by
-
- 2 edits in trunk/Source/WTF
Remove Qt definitions from Platform.h
https://bugs.webkit.org/show_bug.cgi?id=122349
Reviewed by Anders Carlsson.
- wtf/Platform.h: Remove unused PLATFORM(QT) stanzas from file.
- 5:40 PM Changeset in webkit [156934] by
-
- 2 edits in trunk/Source/JavaScriptCore
Silence compiler warning when building 64-bit (on Windows)
Reviewed by Geoffrey Garen.
- jit/JSInterfaceJIT.h: Add a static cast for assignment.
- 5:35 PM Changeset in webkit [156933] by
-
- 2 edits in trunk/Source/WTF
[Win] Turn off FastMalloc on Windows
https://bugs.webkit.org/show_bug.cgi?id=122352
Reviewed by Darin Adler.
- wtf/Platform.h: Enable USE_SYSTEM_MALLOC when building on
Windows to stick to the MSVCRT allocator/deallocator.
- 5:35 PM Changeset in webkit [156932] by
-
- 18 edits in trunk/Source
Ref-ify more stack guards.
<https://webkit.org/b/122360>
Reviewed by Anders Carlsson.
Make another pass turning RefPtr<T> into Ref<T> where possible.
- 5:26 PM Changeset in webkit [156931] by
-
- 4 edits in trunk/Source/WTF
Remove WTF smart pointers 'const_pointer_cast'
https://bugs.webkit.org/show_bug.cgi?id=122325
Reviewed by Darin Adler.
Removed WTF smart pointers 'const_pointer_cast' functions as:
- they were not used
- their implementation was wrong as they tried to cast to a different pointer type
- wtf/PassOwnPtr.h:
- wtf/PassRefPtr.h:
- wtf/RefPtr.h:
- 5:08 PM Changeset in webkit [156930] by
-
- 19 edits8 adds in trunk
[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416
Source/WebCore:
Reviewed by David Hyatt.
Tests: mathml/presentation/mo-minus.html
mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html
MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.
Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.
With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.
- css/mathml.css:
Not sure what this line-height:0 was here for, but it caused bugs with the new code
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::attach):
(WebCore):
(WebCore::MathMLTextElement::childrenChanged):
Need to update the anonymous render tree below <mo> elements when their
children change or when the renderer is first attached.
- mathml/MathMLTextElement.h:
(MathMLTextElement):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h:
Now that the preferred width doesn't depend on the height, we don't
need to override computePreferredLogicalWidths at all.
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
Need to update the anonymous renderers for the anonymous RenderMathMLOperators.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::expandedStretchHeight):
Store the non-expanded stretch height so that we can detect when the height
actually changed.
(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout
(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.
- rendering/mathml/RenderMathMLOperator.h: Update method declarations.
LayoutTests:
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-10-04
Reviewed by David Hyatt.
Add some reftests for stretchy operators.
- TestExpectations: The remaining MathML pixel tests are broken by this patch.
- LayoutTests/platform/gtk/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
- LayoutTests/platform/win/TestExpectations:
- mathml/presentation/mo-minus.html: Added.
- mathml/presentation/mo-stacked-glyphs-expected.html: Added.
- mathml/presentation/mo-stacked-glyphs.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar.html: Added.
- mathml/very-large-stretchy-operators-expected.txt: Added.
- mathml/very-large-stretchy-operators.html: Added.
- 5:00 PM Changeset in webkit [156929] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r156925. It collided with r156903.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
- 4:58 PM Changeset in webkit [156928] by
-
- 2 edits in trunk/Tools
[Windows] Correct run-path when using 64-bit binaries.
Reviewed by David Kilzer.
- Scripts/webkitdirs.pm:
(determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
directory. Otherwise use the existing 'bin32' directory.
- 4:47 PM Changeset in webkit [156927] by
-
- 8 edits in trunk/Source/WebCore
Clean out some FrameLoaderClient hooks that no ports were using.
<https://webkit.org/b/122356>
Reviewed by Anders Carlsson.
Removed the following hooks that were leftovers from dead ports:
- didExhaustMemoryAvailableForScript
- didNotAllowScript
- didNotAllowPlugins
- willCheckAndDispatchMessageEvent
- didChangeName
- dispatchWillInsertBody
- dispatchDidChangeResourcePriority
- 4:34 PM Changeset in webkit [156926] by
-
- 2 edits in trunk/Tools
Teach webkitdirs.pm to honor the --64-bit flag
https://bugs.webkit.org/show_bug.cgi?id=122357
Reviewed by David Kilzer.
- Scripts/webkitdirs.pm:
(argumentsForConfiguration): Modify to check if --64-bit is supplied
by the user.
(findMatchingArguments): Added.
(hasArgument): Added.
(checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
findMatchingArguments subroutine.
- 4:33 PM Changeset in webkit [156925] by
-
- 8 edits in trunk/Source/WebCore
FocusController::advanceFocus spends a lot of time in HTMLMapElement::imageElement
https://bugs.webkit.org/show_bug.cgi?id=122313
Reviewed by Andreas Kling.
The bug was caused by HTMLMapElement::imageElement traversing the entire document to look for
the image element associated with a given map element. Because HTMLCollection used to find the
image element is not cached, it traversed the entire document on every area element we visit,
resulting in O(n2) behavior.
Fixed the bug by adding the name-to-image-element map on document to avoid the traversal in
HTMLMapElement::imageElement.
- dom/Document.cpp:
(WebCore::Document::addImageElementByLowercasedUsemap): Added.
(WebCore::Document::removeImageElementByLowercasedUsemap): Added.
(WebCore::Document::imageElementByLowercasedUsemap): Added.
- dom/Document.h: Added m_imagesByUsemap.
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesLowercasedUsemap): Added.
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap): Added.
- dom/DocumentOrderedMap.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute): Update the name-to-usemap map. The code to parse
the usemap attribute and strip # was moved from HTMLMapElement::imageElement.
(WebCore::HTMLImageElement::insertedInto): Ditto.
(WebCore::HTMLImageElement::removedFrom): Ditto.
(WebCore::HTMLImageElement::matchesLowercasedUsemap): Added; called by DocumentOrderedMap.
- html/HTMLImageElement.h:
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement): Call Document::imageElementByUsemap instead of
looking through all image elements in the document.
- 4:25 PM Changeset in webkit [156924] by
-
- 22 edits in trunk/Source
../WebCore: Unify rubberband control
https://bugs.webkit.org/show_bug.cgi?id=122341
Reviewed by Tim Horton.
- Consolidates the two ways we were passing state about whether to rubber-band on a particular edge down to one.
- WebCore.exp.in:
- page/Page.cpp:
- page/Page.h:
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::isRubberBandInProgress):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::setCanRubberBandState):
(WebCore::ScrollingTree::rubberBandsAtLeft):
(WebCore::ScrollingTree::rubberBandsAtRight):
(WebCore::ScrollingTree::rubberBandsAtBottom):
(WebCore::ScrollingTree::rubberBandsAtTop):
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
- page/scrolling/ScrollingTree.h:
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::shouldRubberBandInDirection):
../WebKit2: Unify rubber-band control
https://bugs.webkit.org/show_bug.cgi?id=122341
Reviewed by Tim Horton.
- Consolidates the two ways we were passing state about whether to rubber-band on a particular edge down to one.
- Adds SPI to control whether you can rubber band on the left or right edge.
- Add a linked-on-or-after check to control whether we use the legacy implicit rubber band control based on back/forward.
- UIProcess/API/C/WKPage.cpp:
(WKPageRubberBandsAtLeft):
(WKPageSetRubberBandsAtLeft):
(WKPageRubberBandsAtRight):
(WKPageSetRubberBandsAtRight):
(WKPageRubberBandsAtBottom):
(WKPageSetRubberBandsAtBottom):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::sendWheelEvent):
(WebKit::WebPageProxy::rubberBandsAtLeft):
(WebKit::WebPageProxy::setRubberBandsAtLeft):
(WebKit::WebPageProxy::rubberBandsAtRight):
(WebKit::WebPageProxy::setRubberBandsAtRight):
(WebKit::WebPageProxy::rubberBandsAtTop):
(WebKit::WebPageProxy::setRubberBandsAtTop):
(WebKit::WebPageProxy::rubberBandsAtBottom):
(WebKit::WebPageProxy::setRubberBandsAtBottom):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::shouldUseLegacyImplicitRubberBandControl):
(WebKit::WebPageProxy::platformInitialize):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebPage/EventDispatcher.messages.in:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 4:01 PM Changeset in webkit [156923] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: pressing the Cmd key over a CSS property should underline it immediately (jump to definition mode)
https://bugs.webkit.org/show_bug.cgi?id=119012
Reviewed by Joseph Pecoraro.
We add an "enabled" state to the tokenTrackingController to indicate that we're interested
in tracking hovered tokens. The tokenTrackingController is now only enabled in the
CSSStyleDeclarationTextEditor when the Cmd key is pressed and in the SourceCodeTextEditor
when either the Cmd key is pressed (NonSymbolTokens mode) or when the debugger is paused
(JavaScriptExpression mode).
The tokenTrackingController is now smarter about how it tracks mouse events when it's enabled,
tracking "mouseenter" and "mouseleave" events to enable tracking allowing immediate detection of
tokens being hovered or no longer being hovered even with quick mouse movements. Additioanlly,
using the new top-level mouse coordinates tracking, we can detect a hovered token as soon as
it's being enabled to provide instant feedback to the user.
This new top-level mouse coordinates tracking couple with tracking of modifier keys also fixes
http://webkit.org/b/119011.
- UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateJumpToSymbolTrackingMode):
Highlight the last known hovered candidate's range as soon as the Cmd key is pressed and enable
the tokenTrackingController if we're dealing with a non-read-only editor. When the Cmd key is
released, disable the tokenTrackingController.
- UserInterface/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController):
(WebInspector.CodeMirrorTokenTrackingController.prototype.get enabled):
(WebInspector.CodeMirrorTokenTrackingController.prototype.set enabled):
New enabled state for the tokenTrackingController which indicates whether it should be tracking
mouse events to track hovered tokens in the editor. Upon being enabled, the tokenTrackingController
looks up the mouse coordinates continuously tracked at the window level to check for a token
at the last known mouse coordinates in case we're already over a token that may be highlighted.
(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightLastHoveredRange):
New public method allowing to highlight the last know candidate range, if any. This is used from
editor code when the Cmd key is pressed and we want to force the last know candidate to be
highlighted.
(WebInspector.CodeMirrorTokenTrackingController.prototype._startTracking):
(WebInspector.CodeMirrorTokenTrackingController.prototype._stopTracking):
Make these two methods private now that they're automatically called by the "mouseenter" and
"mouseleave" event handling when we're in the "enabled" state. Additionally, the public
"tracking" property has been removed since it is no longer useful to the developer.
(WebInspector.CodeMirrorTokenTrackingController.prototype.handleEvent):
(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseEntered):
(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseLeft):
New handlers for the "mouseenter" and "mouseleave" events enabling tracking of hovered tokens.
(WebInspector.CodeMirrorTokenTrackingController.prototype._mouseMovedOverEditor):
(WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
Refactor _mouseMovedOverEditor() into two methods with the new _updateHoveredTokenInfo()
allowing to customize the mouse coordinates to be used since we may call
_updateHoveredTokenInfo() outside of the context of a mouse event (ie. a keypress event).
(WebInspector.CodeMirrorTokenTrackingController.prototype._windowLostFocus):
(WebInspector.CodeMirrorTokenTrackingController.prototype._resetTrackingStates):
New private method combining all the various states that need to be reset when tracking
is turned off, including the removal of the highlighted range if any. This is now called
when the window loses focus.
- UserInterface/Main.js:
(WebInspector.loaded):
(WebInspector._mouseMoved):
Add a new window-level "mousemove" event handler to always track mouse coordinates and key modifier
states. This ensures that we may have the most accurate information possible for key modifiers and
allow code to query the last recorded mouse position in situations where it wouldn't be possible
to have dealt with a mouse event, as is the case when the tokenTrackingController just started tracking.
- UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerEnabled):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
(WebInspector.SourceCodeTextEditor.prototype._enableJumpToSymbolTrackingModeSettings):
(WebInspector.SourceCodeTextEditor.prototype._disableJumpToSymbolTrackingModeSettings):
Update the "enabled" state on the tokenTrackingController when it may have changed based
on those two conditions: we should have either an active debugger call frame or the
Cmd key should have been pressed. This ensures we only track hovered tokens as needed.
(WebInspector.SourceCodeTextEditor.prototype._updateJumpToSymbolTrackingMode):
Highlight the last known hovered candidate's range as soon as the Cmd key is pressed.
- 3:49 PM Changeset in webkit [156922] by
-
- 4 edits in trunk/Source/WebCore
CTTE: SubframeLoader backpointer to Frame should be a reference.
<https://webkit.org/b/122350>
Reviewed by Anders Carlsson.
SubframeLoader is tied to the lifetime of FrameLoader, which in turn
is tied to the lifetime of Frame.
- 3:46 PM Changeset in webkit [156921] by
-
- 7 edits in trunk/Source
Remove some unneeded code from WidgetMac
https://bugs.webkit.org/show_bug.cgi?id=122355
Reviewed by Dan Bernstein.
Source/WebCore:
Remove code to manage the visible rect, it's not needed anymore.
- platform/Widget.h:
- platform/mac/WidgetMac.mm:
(WebCore::Widget::~Widget):
(WebCore::Widget::setFrameRect):
(WebCore::Widget::setPlatformWidget):
Source/WebKit/mac:
Remove code to handle the visible rect changing, it's not needed anymore since we always put Netscape plug-ins into their own layers now.
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm:
- 3:45 PM Changeset in webkit [156920] by
-
- 5 edits1 add in trunk/LayoutTests
Update all the tests, and include new file.
- 3:45 PM Changeset in webkit [156919] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL: Add support for ValueToInt32(bool(x))
https://bugs.webkit.org/show_bug.cgi?id=122346
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-04
Reviewed by Geoffrey Garen.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileValueToInt32):
- 3:41 PM Changeset in webkit [156918] by
-
- 24 edits8 adds in trunk/Source
[iOS] Upstream disk image cache
https://bugs.webkit.org/show_bug.cgi?id=121985
Reviewed by Joseph Pecoraro.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::isUsingDiskImageCache):
- loader/ResourceBuffer.h:
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::canUseDiskImageCache): Added.
(WebCore::CachedImage::useDiskImageCache): Added.
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::isSafeToMakePurgeable):
(WebCore::CachedResource::isUsingDiskImageCache): Added.
- loader/cache/CachedResource.h:
(WebCore::CachedResource::canUseDiskImageCache): Added.
(WebCore::CachedResource::useDiskImageCache): Added.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::flushCachedImagesToDisk): Added.
(WebCore::MemoryCache::TypeStatistic::addResource):
(WebCore::MemoryCache::dumpStats):
(WebCore::MemoryCache::dumpLRULists):
- loader/cache/MemoryCache.h:
(WebCore::MemoryCache::TypeStatistic::TypeStatistic):
- loader/ios/DiskImageCacheClientIOS.h: Added.
- loader/ios/DiskImageCacheIOS.h: Added.
- loader/ios/DiskImageCacheIOS.mm: Added.
- platform/Logging.h:
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::~SharedBuffer):
(WebCore::SharedBuffer::isAllowedToBeMemoryMapped): Added.
(WebCore::SharedBuffer::allowToBeMemoryMapped): Added.
(WebCore::SharedBuffer::failedMemoryMap): Added.
(WebCore::SharedBuffer::markAsMemoryMapped): Added.
(WebCore::SharedBuffer::memoryMappedNotificationCallbackData): Added.
(WebCore::SharedBuffer::memoryMappedNotificationCallback): Added.
(WebCore::SharedBuffer::setMemoryMappedNotificationCallback): Added.
(WebCore::SharedBuffer::data):
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::buffer):
(WebCore::SharedBuffer::getSomeData):
- platform/SharedBuffer.h:
(WebCore::SharedBuffer::isMemoryMapped): Added.
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::SharedBuffer):
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
- ios/WebCoreSupport/WebDiskImageCacheClientIOS.h: Added.
- ios/WebCoreSupport/WebDiskImageCacheClientIOS.mm: Added.
Source/WebKit/mac:
- Misc/WebCache.mm:
(+[WebCache statistics]):
- WebView/WebDataSource.mm:
(BufferMemoryMapped): Added.
(-[WebDataSource _setAllowToBeMemoryMapped]): Added.
(-[WebDataSource setDataSourceDelegate:]): Added.
(-[WebDataSource dataSourceDelegate]): Added.
(-[WebDataSource dealloc]):
- WebView/WebDataSourcePrivate.h: Declared private delegate
protocol, WebDataSourcePrivateDelegate.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences diskImageCacheEnabled]): Added.
(-[WebPreferences setDiskImageCacheEnabled:]): Added.
(-[WebPreferences diskImageCacheMinimumImageSize]): Added.
(-[WebPreferences setDiskImageCacheMinimumImageSize:]): Added.
(-[WebPreferences diskImageCacheMaximumCacheSize]): Added.
(-[WebPreferences setDiskImageCacheMaximumCacheSize:]): Added.
(-[WebPreferences _diskImageCacheSavedCacheDirectory]): Added.
(-[WebPreferences _setDiskImageCacheSavedCacheDirectory:]): Added.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _preferencesChanged:]):
- 3:25 PM Changeset in webkit [156917] by
-
- 2 edits in trunk/Tools
Update svn-config for new Visual Studio extensions
https://bugs.webkit.org/show_bug.cgi?id=122344
Reviewed by Brent Fulgham.
- svn-config: Add new Visual Studio extensions.
- 3:25 PM Changeset in webkit [156916] by
-
- 4 edits2 adds in trunk
[CSS Shapes] Basic shapes should be animatable for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=122343
Reviewed by Dirk Schulze.
Source/WebCore:
Test: fast/shapes/shape-outside-floats/shape-outside-animation.html
Add shape outside to the list of animatable properties. The infrastructure
is already in place for animating basic shapes on shape-inside and clipping
paths. See https://bugs.webkit.org/show_bug.cgi?id=101854.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
LayoutTests:
Add tests checking that shape-outside basic shape values correctly tween
between values.
- animations/resources/animation-test-helpers.js:
(getPropertyValue): Add shape-outside to list of properties that do not parse
with the default behavior.
(comparePropertyValue): Compare shape-outsides after parsing their shape notation.
- fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-animation.html: Added.
- 3:22 PM Changeset in webkit [156915] by
-
- 4 edits in trunk/Source/WebCore
Tighten typing in some RenderLayer code.
<https://webkit.org/b/122342>
Reviewed by Antti Koivisto.
Use tighter types instead of Node and RenderObject inside RenderLayer
where applicable.
- 2:59 PM Changeset in webkit [156914] by
-
- 3 edits6 adds in trunk/LayoutTests
[CSS Regions] Layout Tests for selecting text in 2 regions for other writing modes
https://bugs.webkit.org/show_bug.cgi?id=122327
Reviewed by Alexandru Chiculita.
Add versions for other writing modes (horizontal-bt, vertical-lr and
vertical-rl) for test
fast/regions/selection/selecting-text-in-2-regions.html.
- fast/regions/resources/helper.js:
(selectContentByIdsVert): Add new method when selecting context in a
vertical writing mode.
- fast/regions/resources/region-style.css: Add some new CSS classes for
vertical writing mode.
- fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions-horiz-bt.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:
Added.
- 2:52 PM Changeset in webkit [156913] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- 1:46 PM Changeset in webkit [156912] by
-
- 3 edits2 adds in trunk
Inserting a JS generated keyframe animation shouldn't trigger a whole document style recalc
https://bugs.webkit.org/show_bug.cgi?id=119479
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-10-04
Reviewed by Antti Koivisto.
Change CSSStyleSheet::didMutateRules to not invalidate all node's styles when inserting a
@-webkit-keyframes rule, and to instead insert the rule directly into the StyleResolver.
Test: animation/keyframes-dynamic.html: adds and removes keyframe rules using JavaScript and
validates that the correct elements are animated.
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::didMutateRules):
(WebCore::CSSStyleSheet::insertRule):
- css/CSSStyleSheet.h:
- 1:37 PM Changeset in webkit [156911] by
-
- 5 edits1 add in trunk/Tools
Made WinLauncher have better error handling, crash reporting, and modifiability.
https://bugs.webkit.org/show_bug.cgi?id=122319
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-04
Reviewed by Brent Fulgham.
- WinLauncher/WinLauncher.cpp:
(WinLauncherWebHost::didFailProvisionalLoadWithError):
Don't display the numerous "Cancelled" messages that are obviously from the user.
(createCrashReport): Added.
(dllLauncherEntryPoint):
Made main loop back into while loop and write a crash report if it crashes.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
Added WinLauncherReplace.h.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
Added linking to DbgHelp.lib.
- WinLauncher/WinLauncherReplace.h:
Added to make modifying WinLauncher behaviour and appearance easy.
(processCrashDump): Added.
- 1:35 PM Changeset in webkit [156910] by
-
- 29 edits11 adds in trunk
Support for-of syntax
https://bugs.webkit.org/show_bug.cgi?id=122339
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Add support for for-of syntax to JSC. As part of doing this I had to make
us support unique empty strings as identifiers. In a follow on patch i'm
going to remove the distinction entirely as it's purely a complicating
separation.
Otherwise the logic here is fairly self-explanatory.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitCall):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
(JSC::ForOfNode::emitBytecode):
- jit/JITOperations.cpp:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createForOfLoop):
- parser/NodeConstructors.h:
(JSC::EnumerationNode::EnumerationNode):
(JSC::ForInNode::ForInNode):
(JSC::ForOfNode::ForOfNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
- parser/Parser.h:
(JSC::Parser::isofToken):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createForOfLoop):
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::arrayIteratorPrototypeIterate):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::create):
(JSC::ArrayPrototype::finishCreation):
- runtime/ArrayPrototype.h:
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- runtime/Identifier.h:
(JSC::Identifier::from):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::dumpInContext):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSObject.cpp:
(JSC::JSObject::putDirectNativeFunction):
- runtime/PrivateName.h:
(JSC::PrivateName::PrivateName):
- runtime/PropertyName.h:
(JSC::PropertyName::PropertyName):
Source/WTF:
Update assertions and add a helper function to StringImpl
to save repeated unique or identifier calls.
- wtf/text/StringImpl.h:
(WTF::StringImpl::isIdentifierOrUnique):
(WTF::StringImpl::setIsIdentifier):
(WTF::StringImpl::setIsAtomic):
LayoutTests:
Add test cases for the one type that supports for-of so far
- js/basic-for-of-expected.txt: Added.
- js/basic-for-of.html: Added.
- js/regress/for-of-iterate-array-entries.html: Added.
- js/regress/for-of-iterate-array-keys.html: Added.
- js/regress/for-of-iterate-array-values.html: Added.
- js/regress/script-tests/for-of-iterate-array-entries.js: Added.
(foo):
- js/regress/script-tests/for-of-iterate-array-keys.js: Added.
(foo):
- js/regress/script-tests/for-of-iterate-array-values.js: Added.
(foo):
- 1:33 PM Changeset in webkit [156909] by
-
- 6 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122275
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/fileapi/.
- fileapi/Blob.idl:
- fileapi/FileException.idl:
- fileapi/FileList.idl:
- fileapi/FileReader.idl:
- fileapi/FileReaderSync.idl:
- 1:31 PM Changeset in webkit [156908] by
-
- 47 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/dom/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122271
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/dom/.
- dom/CharacterData.idl:
- dom/ChildNode.idl:
- dom/ClientRectList.idl:
- dom/Clipboard.idl:
- dom/CompositionEvent.idl:
- dom/CustomEvent.idl:
- dom/DOMCoreException.idl:
- dom/DOMImplementation.idl:
- dom/DOMNamedFlowCollection.idl:
- dom/DOMStringList.idl:
- dom/DOMStringMap.idl:
- dom/DataTransferItem.idl:
- dom/DataTransferItemList.idl:
- dom/DeviceMotionEvent.idl:
- dom/DeviceOrientationEvent.idl:
- dom/Document.idl:
- dom/DocumentFragment.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/EventException.idl:
- dom/EventListener.idl:
- dom/EventTarget.idl:
- dom/KeyboardEvent.idl:
- dom/MessageEvent.idl:
- dom/MessagePort.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/MutationObserver.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeFilter.idl:
- dom/NodeIterator.idl:
- dom/NodeList.idl:
- dom/Range.idl:
- dom/RangeException.idl:
- dom/ShadowRoot.idl:
- dom/Text.idl:
- dom/TextEvent.idl:
- dom/TouchEvent.idl:
- dom/TouchList.idl:
- dom/TreeWalker.idl:
- dom/UIEvent.idl:
- dom/WebKitNamedFlow.idl:
- dom/WheelEvent.idl:
- 1:22 PM Changeset in webkit [156907] by
-
- 12 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/xml/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122269
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/xml/.
- xml/DOMParser.idl:
- xml/XMLHttpRequest.idl:
- xml/XMLHttpRequestException.idl:
- xml/XMLHttpRequestUpload.idl:
- xml/XMLSerializer.idl:
- xml/XPathEvaluator.idl:
- xml/XPathException.idl:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
- xml/XPathResult.idl:
- xml/XSLTProcessor.idl:
- 12:36 PM Changeset in webkit [156906] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL::OSRExit::convertToForward() shouldn't misuse Operands<>::operator[]
https://bugs.webkit.org/show_bug.cgi?id=122336
Reviewed by Geoffrey Garen.
Changed code in change set r156900 to use the operand() accessor instead of operator[].
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExit::convertToForward):
- 12:31 PM Changeset in webkit [156905] by
-
- 4 edits4 adds in trunk
[CSS Shapes] Shape Outside should relayout when set dynamically
https://bugs.webkit.org/show_bug.cgi?id=122197
Reviewed by Alexandru Chiculita.
Source/WebCore:
Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html
fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html
When shape outside is modified, dependent content needs to relayout. This patch
removes the float from the float lists and marks dependents for layout using
RenderBox::removeFloatingOrPositionedChildFromBlockLists(). This is the same
method used when switching from float: left to float: right and vice versa
(see RenderElement::styleWillChange).
- rendering/RenderBox.cpp:
(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Mark shape-outside dependents
for layout.
- rendering/RenderBox.h:
(WebCore::RenderBox::markShapeOutsideDependentsForLayout): Mark all the items that may be
affected by this shape-outside for relayout.
LayoutTests:
Test that a shape can be dynamically added, modified, or removed and that
content does a proper relayout.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-overhang.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape.html: Added.
- 12:22 PM Changeset in webkit [156904] by
-
- 5 edits in trunk/Source/WebCore
Tighten markContainingBlocksForLayout
https://bugs.webkit.org/show_bug.cgi?id=122326
Reviewed by Anders Carlsson.
- 11:51 AM Changeset in webkit [156903] by
-
- 98 edits in trunk/Source/WebCore
Node: removedFrom() and insertedInto() should use references.
<https://webkit.org/b/122315>
Reviewed by Anders Carlsson.
ContainerNode* -> ContainerNode&
- 11:41 AM Changeset in webkit [156902] by
-
- 2 edits in trunk/Source/WebCore
Optimize strings copies in srcset parser
https://bugs.webkit.org/show_bug.cgi?id=121899
Patch by Romain Perier <Romain Perier> on 2013-10-04
Reviewed by Alexey Proskuryakov.
No new tests, covered by existing ones.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseImagesWithScaleFromSrcsetAttribute): Don't copy
image.imageURL at each loop iteration, save indexes instead.
(WebCore::bestFitSourceForImageAttributes): Make a String for
the URL only when the corresponding candidate is chosen
by the selection algorithm. It reduces the number of copies
significantly and improves performance
(around 30% with the "Release" profile and 60% with the "Debug" one).
- 11:40 AM Changeset in webkit [156901] by
-
- 14 edits4 moves in trunk/LayoutTests
Tests added in r141354 erroneously assume correction suggestion to be in the context menu
https://bugs.webkit.org/show_bug.cgi?id=113742
Reviewed by Ryosuke Niwa.
Tests from r141354 erroneously assume that all WebKit ports populate
spell checking suggestion in the context menu.
Remove verification of spell checking suggestion and all context menu stuff from tests
that do that unnecessarily. Instead of that check whether spelling markers behave correctly,
for example, after deleting a text, double click or selecting a misspellings.
However, two tests are adapted to verify spell checking suggestions (their availability
rather than correctness, similarly to context-menu-suggestions.html).
Those are useful for ports which populate spelling suggestion in the context menu.
- editing/spelling/resources/util.js:
(initSpellTest):
Do not assume that the tests are running with "Windows" editing behavior.
Unix ports do not make a selection for the misspelled word and they don't
require selection to get spell checking suggestions.
- editing/spelling/spelling-changed-text-expected.txt:
- editing/spelling/spelling-changed-text.html:
- editing/spelling/spelling-double-clicked-word-expected.txt:
- editing/spelling/spelling-double-clicked-word.html:
- editing/spelling/spelling-exactly-selected-word-expected.txt:
- editing/spelling/spelling-exactly-selected-word.html:
Remove verification of correction suggestion.
Instead of that check whether the spelling markers behave correctly.
- editing/spelling/context-menu-suggestions-multiword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection-expected.txt.
- editing/spelling/context-menu-suggestions-multiword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection.html.
- editing/spelling/context-menu-suggestions-subword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-subword-selection-expected.txt.
- editing/spelling/context-menu-suggestions-subword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-subword-selection.html.
Adapt those tests for platforms which populate spell check suggestion
in the context menu.
- platform/efl-wk2/TestExpectations:
Now context-menu-suggestions-multiword-selection.html and
context-menu-suggestions-subword-selection.html are passing for EFL.
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
Update tests path due to rename.
- 11:38 AM Changeset in webkit [156900] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: Crash in OSRExit::convertToForward() using VirtualRegister.offset() as array index
https://bugs.webkit.org/show_bug.cgi?id=122332
Reviewed by Oliver Hunt.
Changed the uses of .offset(), which returns a negative number for locals, to be
toLocal() which returns a local's ordinal number.
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExit::convertToForward):
- 11:34 AM Changeset in webkit [156899] by
-
- 2 edits in trunk/Tools
remove dpranke from webkitpy watchlist
https://bugs.webkit.org/show_bug.cgi?id=122331
Reviewed by Brent Fulgham.
- Scripts/webkitpy/common/config/watchlist:
- 11:30 AM Changeset in webkit [156898] by
-
- 3 edits in trunk/Tools
[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
https://bugs.webkit.org/show_bug.cgi?id=122299
Reviewed by Beth Dakin.
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
- TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
- 11:26 AM Changeset in webkit [156897] by
-
- 2 edits in trunk/Tools
Watchlist is broken after <http://trac.webkit.org/r156880>
- Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
- 11:20 AM Changeset in webkit [156896] by
-
- 11 edits in trunk/Source/JavaScriptCore
Add callOperation to Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=122306
Reviewed by Geoffrey Garen.
Created baseline JIT compatible versions for a few flavors of callOperation().
Migrated cti_op_new_regexp() and its caller to callOperation(operationNewRegexp()).
- dfg/DFGOperations.cpp: Moved operationNewRegexp() to JITOperations
- dfg/DFGOperations.h:
- jit/JIT.h:
(JSC::JIT::appendCall):
- jit/JITInlines.h:
(JSC::JIT::appendCallWithExceptionCheck):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_regexp):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JSInterfaceJIT.h:
- 11:20 AM Changeset in webkit [156895] by
-
- 29 edits3 deletes in trunk/Tools
Remove Qt features from build and test tools
https://bugs.webkit.org/show_bug.cgi?id=122312
Reviewed by Anders Carlsson.
- Scripts/build-dumprendertree:
- Scripts/build-jsc:
- Scripts/build-webkit:
- Scripts/build-webkittestrunner:
- Scripts/old-run-webkit-tests:
(openDumpTool):
(buildPlatformResultHierarchy):
(buildPlatformTestHierarchy):
(readSkippedFiles):
- Scripts/run-launcher:
- Scripts/run-qtwebkit-tests: Removed.
- Scripts/run-webkit-tests:
(useNewRunWebKitTests):
- Scripts/update-webkit:
- Scripts/webkit-build-directory:
- Scripts/webkitdirs.pm:
(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(setupCygwinEnv):
(copyInspectorFrontendFiles):
(setPathForRunningWebKitApp):
- Scripts/webkitpy/common/checkout/baselineoptimizer.py:
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_mac_future):
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_virtual_ports_filtered):
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_reviewer_text):
- Scripts/webkitpy/common/config/watchlist:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
- Scripts/webkitpy/port/base.py:
(Port.init):
(Port._port_flag_for_scripts):
(Port._wk2_port_name):
- Scripts/webkitpy/port/builders.py:
- Scripts/webkitpy/port/factory.py:
(platform_options):
(PortFactory):
(PortFactory._default_port):
- Scripts/webkitpy/port/factory_unittest.py:
(FactoryTest.test_gtk):
- Scripts/webkitpy/port/qt.py: Removed.
- Scripts/webkitpy/port/qt_unittest.py: Removed.
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier):
- Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker):
- Scripts/webkitpy/style/checkers/cpp.py:
(_classify_include):
(check_include_line):
(check_identifier_name_in_declaration):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_classify_include):
(WebKitStyleTest.test_names):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory):
- Scripts/webkitpy/tool/main.py:
(WebKitPatch):
- 10:00 AM Changeset in webkit [156894] by
-
- 2 edits in trunk/Source/WebCore
Add svn:ignore to *.pyc files in inspector/Scripts directory, so that they don't
show up as unversioned all the time.
- inspector/Scripts: Added property svn:ignore.
- 9:15 AM Changeset in webkit [156893] by
-
- 2 edits in trunk/Source/WebCore
[Win][WebGL] Crash on exit
https://bugs.webkit.org/show_bug.cgi?id=120764
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-04
Reviewed by Martin Robinson.
On exit, libGLESv2.dll is detached from the process and relevant memory is released
before the atexit GL context cleanup handler is called, causing a NULL pointer crash.
The GL context cleanup code was originally written to avoid a X server crash on exit,
so it's only needed for PLATFORM(X11).
- platform/graphics/GLContext.cpp: Only clean up active GL contexts on exit for PLATFORM(X11).
(WebCore::GLContext::cleanupSharedX11Display):
(WebCore::GLContext::cleanupActiveContextsAtExit):
(WebCore::GLContext::GLContext):
(WebCore::GLContext::~GLContext):
- 9:14 AM Changeset in webkit [156892] by
-
- 6 edits in trunk
[GTK] Enable text edition UndoOperations support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122305
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-10-04
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
Replaced the notImplemented() function calls for
the corresponding implementation of the edit operations
provided by the DefaultUndoController class.
- GNUmakefile.list.am:
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):
- UIProcess/API/gtk/PageClientImpl.h:
LayoutTests:
- platform/gtk-wk2/TestExpectations: Corrected the expectations
with the new results.
- 9:02 AM Changeset in webkit [156891] by
-
- 6 edits2 adds in trunk
[CSSRegions] Regions as stacking contexts should paint over positioned sibling
https://bugs.webkit.org/show_bug.cgi?id=122321
Reviewed by Alexandru Chiculita.
Source/WebCore:
Test: fast/regions/layers/region-normalflow-stacking-context.html
Since regions are stacking contexts, they should not be in normal flow list of layers.
More clean-up after https://bugs.webkit.org/show_bug.cgi?id=117365 and https://bugs.webkit.org/show_bug.cgi?id=121828
which enabled the layers.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::shouldBeSelfPaintingLayer):
LayoutTests:
Add a new test and modify existing tests to take into account the stacking context behavior
for non-positioned regions.
- fast/regions/autoheight-regions-mark-expected.txt:
- fast/regions/layers/region-normalflow-stacking-context-expected.html: Added.
- fast/regions/layers/region-normalflow-stacking-context.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html:
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html:
- 8:26 AM Changeset in webkit [156890] by
-
- 3 edits1 delete in trunk/Source/WebKit
Remove WebAssertions.h
https://bugs.webkit.org/show_bug.cgi?id=122328
Reviewed by Jessie Berlin.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Misc/WebAssertions.h: Removed.
- 8:22 AM Changeset in webkit [156889] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Remove failure expectations from tests that are passing.
- platform/efl-wk2/TestExpectations: update js/dom/create-lots-of-workers.html path.
- platform/efl/TestExpectations:
- 7:22 AM Changeset in webkit [156888] by
-
- 4 edits in trunk
[EFL] Enable correct behaviour for deleting regional indicator symbols
https://bugs.webkit.org/show_bug.cgi?id=122209
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-10-04
Reviewed by Gyuyoung Kim.
Source/WebCore:
Regional indicator symbols that are combined should behave as a single character when deleting.
Removed unused variable initialState.
- rendering/RenderText.cpp:
(WebCore::RenderText::previousOffsetForBackwardDeletion):
LayoutTests:
Now editing/deleting/regional-indicators.html is passing on EFL port.
- platform/efl/TestExpectations:
- 7:16 AM Changeset in webkit [156887] by
-
- 12 edits in trunk/Source/WebKit2
Remove Qt leftovers from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122317
Patch by Sergio Correia <Sergio Correia> on 2013-10-04
Reviewed by Anders Carlsson.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):
- Shared/API/c/WKBase.h:
- Shared/NativeWebTouchEvent.h:
- UIProcess/API/C/WebKit2_C.h:
- UIProcess/BackingStore.h:
- UIProcess/InspectorServer/WebInspectorServer.cpp:
(WebKit::WebInspectorServer::inspectorUrlForPageID):
- UIProcess/InspectorServer/WebInspectorServer.h:
- UIProcess/InspectorServer/WebSocketServer.cpp:
- UIProcess/InspectorServer/WebSocketServer.h:
- UIProcess/WebPageProxy.cpp:
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::getPluginDisplay):
(WebKit::x11Screen):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::NetscapePlugin::x11HostDisplay):
(WebKit::NetscapePlugin::platformPostInitializeWindowless):
(WebKit::NetscapePlugin::platformPaint):
- 5:23 AM Changeset in webkit [156886] by
-
- 21 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/css/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122276
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/css/.
- css/CSSHostRule.idl:
- css/CSSMediaRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- css/CSSSupportsRule.idl:
- css/CSSValueList.idl:
- css/DOMWindowCSS.idl:
- css/FontLoader.idl:
- css/MediaList.idl:
- css/MediaQueryList.idl:
- css/MediaQueryListListener.idl:
- css/StyleMedia.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSFilterValue.idl:
- css/WebKitCSSKeyframesRule.idl:
- css/WebKitCSSMatrix.idl:
- css/WebKitCSSTransformValue.idl:
- 4:59 AM Changeset in webkit [156885] by
-
- 2 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/loader/appcache/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122274
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/loader/appcache/.
- loader/appcache/DOMApplicationCache.idl:
- 4:55 AM Changeset in webkit [156884] by
-
- 4 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/plugins/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122273
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/plugins/.
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPlugin.idl:
- plugins/DOMPluginArray.idl:
- 4:51 AM Changeset in webkit [156883] by
-
- 3 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/storage/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122272
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/storage/.
- storage/Storage.idl:
- storage/StorageEvent.idl:
- 4:41 AM Changeset in webkit [156882] by
-
- 5 edits in trunk/Source/WebCore
[WebIDL] Annotate IDL interfaces under Source/WebCore/workers/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122270
Reviewed by Darin Adler.
Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.
This patch covers IDL interfaces under Source/WebCore/workers/.
- workers/DedicatedWorkerGlobalScope.idl:
- workers/Worker.idl:
- workers/WorkerGlobalScope.idl:
- workers/WorkerLocation.idl:
- 1:49 AM Changeset in webkit [156881] by
-
- 5 edits2 adds in trunk
[CSS Regions] Infinite loop when computing widows
https://bugs.webkit.org/show_bug.cgi?id=122215
Reviewed by David Hyatt.
Source/WebCore:
The patch ensures it's not possible to relayout a block indefinitely because of widows contraints. You can't
break a block more than once to account for widows. This can happen if, for example, some lines are moved
to the next container and there the content breaks in another container again without respecting the widows property.
This is in line with the idea of not leaving empty fragmentation containers during layout.
Test: fast/regions/regions-widows-stack-overflow.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::setBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::setDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidow):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData): Rename the m_shouldBreakAtLineToAvoidWidow
flag to m_didBreakAtLineToAvoidWidow.
(WebCore::RenderBlockFlow::shouldBreakAtLineToAvoidWidow): Use the line index to determine if it should break or not.
(WebCore::RenderBlockFlow::didBreakAtLineToAvoidWidow): Use to determine if a break already happened because of widows.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
LayoutTests:
Test there is no stack overflow when trying to break for widows that are caused by other widows.
- fast/regions/regions-widows-stack-overflow-expected.html: Added.
- fast/regions/regions-widows-stack-overflow.html: Added.
Oct 3, 2013:
- 11:05 PM Changeset in webkit [156880] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself to some watchlists.
- Scripts/webkitpy/common/config/watchlist:
- 9:42 PM Changeset in webkit [156879] by
-
- 2 edits in trunk/Source/WebCore
Assert that we don't try to index past the end of the m_coreTextIndices array
https://bugs.webkit.org/show_bug.cgi?id=122308
Reviewed by Dan Bernstein.
Because an assertion failure is better than a random crash.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::indexAt):
- 9:38 PM Changeset in webkit [156878] by
-
- 4 edits2 deletes in trunk/Source/WebKit
Remove WebNSNotificationCenterExtras
https://bugs.webkit.org/show_bug.cgi?id=122316
Reviewed by Dan Bernstein.
Source/WebKit:
Update Xcode project.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Use dispatch_async to ensure that notifications are posted on the main thread.
- Misc/WebIconDatabase.mm:
(-[WebIconDatabase _sendNotificationForURL:]):
(-[WebIconDatabase _sendDidRemoveAllIconsNotification]):
- Misc/WebNSNotificationCenterExtras.h: Removed.
- Misc/WebNSNotificationCenterExtras.m: Removed.
- 9:11 PM Changeset in webkit [156877] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r155787): WebKitTestRunner rebuilds from scratch when doing an incremental build
Reviewed by Dan Bernstein.
- WebKit2.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status
indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
over the destination. This avoids updating the modification date of the file when it has not changed.
- 9:04 PM Changeset in webkit [156876] by
-
- 69 edits in trunk/Source/WebCore
Move setting of some layout bits to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122256
Reviewed by Andreas Kling.
These bits never apply to RenderText nodes:
normalChildNeedsLayout
posChildNeedsLayout
needsSimplifiedNormalFlowLayout
normalChildNeedsLayout
positionedMovementLayout
The code for setting them can be moved to RenderElement.
Also separated the code paths for setting and clearing the bits and uninlined
everything that is not massively popular.
- 8:42 PM Changeset in webkit [156875] by
-
- 2 edits in tags/Safari-538.1.2/Source/ThirdParty/ANGLE
Merged r156870. <rdar://problem/15116673>
- 8:21 PM Changeset in webkit [156874] by
-
- 5 edits in tags/Safari-538.1.2/Source
Versioning.
- 8:19 PM Changeset in webkit [156873] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r156811): WebCore rebuilds from scratch when doing an incremental build
The change in r156811 resulted in several public headers in the JavaScriptCore framework having their modification
date touched on every build, even if their contents had not changed. This resulted in a large portion of WebCore
needing to rebuilt after an incremental build of JavaScriptCore.
Reviewed by Dan Bernstein.
- JavaScriptCore.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status
indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
over the destination.
- 8:19 PM Changeset in webkit [156872] by
-
- 1 copy in tags/Safari-538.1.2
New Tag.
- 8:08 PM Changeset in webkit [156871] by
-
- 23 edits in trunk/Source
Remove shouldRubberBandInDirection from the WKBundlePageUIClient
https://bugs.webkit.org/show_bug.cgi?id=122309
Reviewed by Andreas Kling.
../WebCore:
- loader/EmptyClients.h:
- page/ChromeClient.h:
- page/FrameView.cpp:
- page/FrameView.h:
- platform/ScrollableArea.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::shouldRubberBandInDirection):
../WebKit/efl:
- WebCoreSupport/ChromeClientEfl.h:
../WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.h:
../WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
../WebKit/win:
- WebCoreSupport/WebChromeClient.h:
../WebKit/wince:
- WebCoreSupport/ChromeClientWinCE.h:
../WebKit2:
WKBundlePageUIClient's shouldRubberBandInDirection has never worked with
threaded scrolling, so remove it.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 5:43 PM Changeset in webkit [156870] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
<rdar://problem/15116673> [mac] Build failure when the source directory is not named ANGLE
https://bugs.webkit.org/show_bug.cgi?id=122307
Reviewed by Mark Rowe.
- ANGLE.xcodeproj/project.pbxproj: Ensure that the symlink to SRCROOT in
DerivedSources/ANGLE is named ANGLE.
- 4:38 PM Changeset in webkit [156869] by
-
- 11 edits in trunk
Fix the HTMLSelectElement.prototype.remove() method
https://bugs.webkit.org/show_bug.cgi?id=121586
Reviewed by Darin Adler.
Source/WebCore:
Fix the HTMLSelectElement.prototype.remove() method so that it behaves like
Element.remove() if no argument is passed (from ChildNode). This behavior
is consistent with Firefox and Blink.
See https://www.w3.org/Bugs/Public/show_bug.cgi?id=20720 for more
information.
Tests: js/dom/select-options-remove.html
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::remove):
Stop calling JSHTMLSelectElement::remove() blindly as it is dangerous, especially
now that calling it without argument now detaches the element. Instead, have the
bindings call the corresponding methods on the HTMLOptionsCollection implementation
object, as it should.
- bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::JSHTMLSelectElement::remove):
Call Element::remove() if no argument is given.
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::remove):
- html/HTMLOptionsCollection.h:
- html/HTMLSelectElement.cpp:
- html/HTMLSelectElement.h:
Rename remove(int) to removeByIndex(int) to avoid conflict with
Node::remove(ExceptionCode&).
LayoutTests:
Add test to make sure calling HTMLSelectElement.prototype.remove() detaches the
select element from its parent, as Element::remove() would.
- js/dom/select-options-remove-expected.txt:
- js/resources/select-options-remove.js:
- 4:31 PM Changeset in webkit [156868] by
-
- 1 edit1 delete in trunk/LayoutTests
Re-remove Qt TestExpectations re-added in r156841 after r156866.
- platform/qt: Removed.
- platform/qt/TestExpectations: Removed.
- 4:29 PM Changeset in webkit [156867] by
-
- 8 edits2 adds in trunk
Regression: AX: <table><caption> no longer exposed as AXTitle.
https://bugs.webkit.org/show_bug.cgi?id=121977
Patch by Samuel White <Samuel White> on 2013-10-03
Reviewed by Darin Adler.
Source/WebCore:
Some cleanup of accessibilityText. Notably, subclasses were unnecessarily redeclaring this method as both private and
protected. Added OVERRIDE keyword to these subclasses as needed. Moved titleElementText to virtual so we can do subclass
overrides in cases like this bug. That is, AccessibilityTable can leverage the existing machinery for alternativeText,
visibleText, and helpText, but we do some custom work ONLY in titleElementText.
Test: accessibility/table-title.html
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityMediaControls.h:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::titleElementText):
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::titleElementText):
- accessibility/AccessibilityTable.h:
LayoutTests:
Added test to verify that table elements correctly derive their AXTitle from their associated caption element.
- accessibility/table-title-expected.txt: Added.
- accessibility/table-title.html: Added.
- 4:24 PM Changeset in webkit [156866] by
-
- 5 edits in trunk/Tools
Remove Qt builders from the flakiness dashboard.
- TestResultServer/static-dashboards/builders.jsonp:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- TestResultServer/static-dashboards/loader_unittests.js:
- 4:18 PM Changeset in webkit [156865] by
-
- 1 edit3 adds in trunk/LayoutTests
Add a testcase for a bug that I had during the development. This code uses the asm.js style.
https://bugs.webkit.org/show_bug.cgi?id=122286
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-03
Reviewed by Filip Pizlo.
- js/regress/asmjs_bool_bug-expected.txt: Added.
- js/regress/asmjs_bool_bug.html: Added.
- js/regress/script-tests/asmjs_bool_bug.js: Added.
(strlen):
- 4:10 PM Changeset in webkit [156864] by
-
- 4 edits in trunk/Tools
[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
https://bugs.webkit.org/show_bug.cgi?id=122299
Reviewed by Beth Dakin.
- TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
Disable threaded scrolling.
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
- TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
- 4:03 PM Changeset in webkit [156863] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Unreviewed gardening.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Clean up the
paths for various files added outside of Visual Studio. They are all
displayed in the root of the project, rather than the proper sub-folder.
- 3:54 PM Changeset in webkit [156862] by
-
- 6 edits in trunk/Source
../JavaScriptCore: [Win] Update solutions and projects to support 64-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=122225
Reviewed by Anders Carlsson.
Revise ordering of CPU(X86) and CPU(X86_64) tests, because MSVC always defines
both when targeting a 64-bit build.
- JavaScriptCore.vcxproj/JavaScriptCore.submit.sln: Add an x64 target
for 64-bit builds.
../WTF: [Win] Update solutions and projects to support 64-bit build.
https://bugs.webkit.org/show_bug.cgi?id=122225
Reviewed by Anders Carlsson.
- WTF.vcxproj/WTF.submit.sln: Add x64 architecture targets.
- WTF.vcxproj/WTF.vcxproj: Correct path to config.h file.
- WTF.vcxproj/WTF.vcxproj.filters: Correct path to config.h file.
- 3:52 PM Changeset in webkit [156861] by
-
- 10 edits4 copies in trunk/Source/WebKit2
Create CoordinatedDrawingArea / CoordinatedDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=122207
Patch by Sergio Correia <Sergio Correia> on 2013-10-03
Reviewed by Anders Carlsson.
Since Apple are moving away from DrawingAreaImpl, Coordinated Graphics
should have its own drawing area.
- CMakeLists.txt: Use CoordinatedDrawingArea and
CoordinatedDrawingAreaProxy instead of the DrawingAreaImpl /
DrawingAreaProxyImpl.
- Shared/DrawingAreaInfo.h: Add DrawingAreaTypeCoordinated.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
Added, copied from DrawingAreaProxyImpl.cpp.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h: Added,
copied from DrawingAreaProxyImpl.h.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createDrawingAreaProxy): Use CoordinatedDrawingAreaProxy.
- UIProcess/DrawingAreaProxyImpl.cpp: Remove Coordinated Graphics
bits.
- UIProcess/DrawingAreaProxyImpl.h: Ditto.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
Added, copied from DrawingAreaImpl.cpp.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
Added, copied from DrawingAreaImpl.h.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush): Use
CoordinatedDrawingArea.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create): Handle the DrawingAreaTypeCoordinated
in the DrawingArea creation code.
- WebProcess/WebPage/DrawingAreaImpl.cpp: Remove Coordinated Graphics
bits.
- WebProcess/WebPage/DrawingAreaImpl.h: Ditto.
- 3:15 PM Changeset in webkit [156860] by
-
- 30 edits in trunk/Source
Ignore deprecation warnings
https://bugs.webkit.org/show_bug.cgi?id=122302
Reviewed by Mark Rowe.
Source/WebCore:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
- bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _rectOnScreen]):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
- page/mac/FrameSnapshottingMac.mm:
(WebCore::imageFromRect):
- platform/graphics/mac/IconMac.mm:
(WebCore::Icon::Icon):
- platform/mac/DragImageMac.mm:
(WebCore::scaleDragImage):
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::globalPoint):
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformContentsToScreen):
(WebCore::ScrollView::platformScreenToContents):
Source/WebKit/mac:
- Misc/WebIconDatabase.mm:
(-[WebIconDatabase _scaleIcon:toSize:]):
(webGetNSImage):
- Misc/WebNSImageExtras.m:
(-[NSImage _web_scaleToMaxSize:]):
(-[NSImage _web_dissolveToFraction:]):
- Misc/WebNSViewExtras.m:
(-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]):
(-[NSView _web_convertRect:toView:]):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::mouseEvent):
- Plugins/Hosted/WebTextInputWindowController.m:
(-[WebTextInputPanel _interpretKeyEvent:string:]):
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):
- WebInspector/WebNodeHighlight.mm:
(-[WebNodeHighlight _computeHighlightWindowFrame]):
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
- WebView/WebHTMLView.mm:
(+[WebHTMLView _postFlagsChangedEvent:]):
(-[WebHTMLView _updateMouseoverWithFakeEvent]):
(-[WebHTMLView _autoscroll]):
(-[WebHTMLView mouseDown:]):
(-[WebHTMLView mouseDragged:]):
(-[WebHTMLView mouseUp:]):
(-[WebHTMLView accessibilityHitTest:]):
(-[WebHTMLView _executeSavedKeypressCommands]):
(-[WebHTMLView attachRootLayer:]):
(-[WebHTMLView textStorage]):
(-[WebHTMLView _updateSelectionForInputManager]):
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _buildUI]):
(-[WebTextCompletionController _placePopupWindow:]):
Source/WebKit2:
- Shared/mac/WebEventFactory.mm:
(WebKit::globalPoint):
- UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::setFindIndicator):
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::screenToWindow):
(WebKit::PageClientImpl::windowToScreen):
- UIProcess/API/mac/WKTextInputWindowController.mm:
(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
(-[WKTextInputPanel _hasMarkedText]):
- UIProcess/API/mac/WKView.mm:
(-[WKView characterIndexForPoint:]):
(-[WKView firstRectForCharacterRange:actualRange:]):
(-[WKView _postFakeMouseMovedEventForFlagsChangedEvent:]):
(-[WKView _setDragImage:at:linkDrag:]):
(-[WKView performDictionaryLookupAtCurrentMouseLocation]):
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
- 2:46 PM Changeset in webkit [156859] by
-
- 2 edits in trunk/Tools
Use numeric strings in the OS version dictionary
https://bugs.webkit.org/show_bug.cgi?id=122300
Reviewed by Mark Rowe.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._determine_mac_version):
- 2:14 PM Changeset in webkit [156858] by
-
- 2 edits in trunk/Source/JavaScriptCore
Eliminate unused JITStub function declarations
https://bugs.webkit.org/show_bug.cgi?id=122288
Reviewed by Geoffrey Garen.
Removed unused JITStub declarations.
- jit/JITStubs.h:
- 2:07 PM Changeset in webkit [156857] by
-
- 3 edits2 adds in trunk/LayoutTests
[CSS Regions] Layout Test for selecting text in 2 regions
https://bugs.webkit.org/show_bug.cgi?id=121841
Reviewed by Alexandru Chiculita.
Add new reftest for selecting text in 2 regions. It compares the
behavior (highlighted text and selected content) in regions and absolute
positions.
- fast/regions/resources/helper.js: Add new function to set selected
content in an element onmouseup.
(onMouseUpLogSelection.document.onmouseup):
(onMouseUpLogSelection):
- fast/regions/resources/region-style.css: Define some styles that could
be reused in other tests.
- fast/regions/selection/selecting-text-in-2-regions-expected.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions.html: Added.
- 1:49 PM Changeset in webkit [156856] by
-
- 5 edits in tags/Safari-538.1.1/Source
Versioning.
- 1:44 PM Changeset in webkit [156855] by
-
- 1 copy in tags/Safari-538.1.1
New Tag.
- 1:44 PM Changeset in webkit [156854] by
-
- 2 edits in trunk/Tools
Fix LeaksViewer to load leaks results from MountainLion, not Lion.
Rubber-stamped by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer._displayURLPrompt):
- 1:36 PM Changeset in webkit [156853] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: fast/history/history-back-while-pdf-in-pagecache.html
https://bugs.webkit.org/show_bug.cgi?id=121628
- platform/mac/TestExpectations: Marking as such.
- 1:04 PM Changeset in webkit [156852] by
-
- 3 edits4 adds in trunk
[CSS Shapes] Support the shape-image-threshold property
https://bugs.webkit.org/show_bug.cgi?id=122254
Reviewed by Andreas Kling.
Source/WebCore:
Replace the hardwired 0 Shape::createShape() threshold parameter with the style's
shapeImageThreshold() value (which has been clamped to [0,1]).
Tests: fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002.html
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape):
LayoutTests:
Verify that a shape-outside image whose pixels' alpha channels are all above shape-image-threshold causes
layout to skirt the shape, and similarly that an image whose pixels' alpha channels are all below the threshold
has no effect on the layout.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002.html: Added.
- 1:00 PM Changeset in webkit [156851] by
-
- 7 edits1 copy1 delete in trunk/LayoutTests
[CSS Shapes] Revise the CSS property parsing tests
https://bugs.webkit.org/show_bug.cgi?id=122251
Reviewed by Andreas Kling.
Flattened the shapes CSS property parsing tests by inserting the code from
the fast/shapes/parsing/script-tests subdirectory into the test HTML source
files. The subdirectory is now empty and the tests are easier to read.
- fast/shapes/parsing/parsing-shape-image-threshold.html: Inserted parsing-shape-image-threshold.js instead of referring to it with script src.
- fast/shapes/parsing/parsing-shape-inside.html: Likewise
- fast/shapes/parsing/parsing-shape-lengths.html: Likewise
- fast/shapes/parsing/parsing-shape-margin.html: Likewise
- fast/shapes/parsing/parsing-shape-outside.html: Likewise
- fast/shapes/parsing/parsing-shape-padding.html: Likewise
- fast/shapes/parsing/parsing-test-utils.js: Renamed from LayoutTests/fast/shapes/parsing/script-tests/parsing-test-utils.js.
(getCSSText):
(getComputedStyleValue):
(getParentAndChildComputedStyles):
(getParentAndChildComputedStylesString):
(getChildComputedStyle):
(testShapeSpecifiedProperty):
(testShapeComputedProperty):
(testNotInheritedShapeChildProperty):
(property):
- fast/shapes/parsing/script-tests/parsing-shape-image-threshold.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-inside.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-lengths.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-margin.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-outside.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-padding.js: Removed.
- 12:53 PM Changeset in webkit [156850] by
-
- 5 edits in trunk/Source/WebCore
[CSS Regions] Follow-up code style change after bug #121828 All regions have layers
https://bugs.webkit.org/show_bug.cgi?id=122265
Patch by Mihai Maerean <Mihai Maerean> on 2013-10-03
Reviewed by Darin Adler.
Comments moved to the cpp file, as requested in the review of bug #121828 All regions have layers.
No new tests, no behavior change.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::requiresLayer):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::requiresLayer):
- rendering/RenderRegion.h:
- 12:52 PM Changeset in webkit [156849] by
-
- 2 edits in trunk/LayoutTests
video-object-fit tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=121803
I'm not quite sure what's going on, but [ Pass Failure ] expectations didn't cut it.
Trying [ Pass ImageOnlyFailure ], as the failures are always image only anyway.
- platform/mac/TestExpectations:
- 12:48 PM Changeset in webkit [156848] by
-
- 3 edits in trunk/Source/WebCore
[cairo] Initialize the m_compositorTexture in GraphicsContext3DCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=122285
Patch by Alejandro G. Castro <alex@igalia.com> on 2013-10-03
Reviewed by Noam Rosenthal.
Initialize to the default texture to avoid the random texture name
and generate the texture name.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D): Initialize
m_compositorTexture.
(WebCore::GraphicsContext3D::~GraphicsContext3D): Delete the
generated textures names.
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs): Generate the texture
names for m_compositorTexture and m_texture.
- 11:38 AM Changeset in webkit [156847] by
-
- 41 edits in trunk/Source/WebKit2
Remove the last remnants of Qt from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122290
Reviewed by Andreas Kling.
- Platform/PlatformProcessIdentifier.h:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- Shared/Downloads/Download.cpp:
(WebKit::Download::Download):
- Shared/Downloads/Download.h:
- Shared/Downloads/DownloadManager.cpp:
- Shared/Downloads/DownloadManager.h:
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
- Shared/EditorState.h:
(WebKit::EditorState::EditorState):
- Shared/LayerTreeContext.h:
- Shared/NativeWebKeyboardEvent.h:
- Shared/NativeWebMouseEvent.h:
- Shared/NativeWebWheelEvent.h:
- Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
- Shared/PlatformPopupMenuData.h:
- Shared/ShareableBitmap.h:
- Shared/WebPreferencesStore.h:
- UIProcess/Downloads/DownloadProxy.cpp:
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/PageClient.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
- UIProcess/WebFullScreenManagerProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::showPopupMenu):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPopupMenuProxy.h:
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::willSetInputMethodState):
(WebKit::WebEditorClient::supportsGlobalSelection):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldFallBack):
- WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::didChangeSelectedIndex):
- WebProcess/WebCoreSupport/WebPopupMenu.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::editorState):
(WebKit::WebPage::performDragControllerAction):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- config.h:
- 11:24 AM Changeset in webkit [156846] by
-
- 7 edits10 adds in trunk
[CSS Shapes] Support block content with inline content around floats in shape-inside
https://bugs.webkit.org/show_bug.cgi?id=121616
Reviewed by David Hyatt.
In r156022 and r156364, I added support for floats inside shape-inside with inline content. This change extends
the existing implementation to support block content with inline content (paragraphs). I added an extra text for
positioning a float inside shape-inside without text content around it.
Source/WebCore:
Tests: fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html
- rendering/FloatingObjects.h:
(WebCore::FloatingObject::logicalSize): Add new function to return the FloatingObject logical size.
- rendering/LineWidth.cpp:
(WebCore::LineWidth::fitBelowFloats): When the lineBreaker code pushes down the content below the floating object,
we need to update the segments if we are in a shape-inside.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Do the positioning based on the float actual size, and use the
recent shapeInsideInfo. (Calling layoutShapeInsideInfo which deals with the layoutStates also instead of shapeInsideInfo.)
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): If we don't have inline content we still need to positionize
our float content in a shape-inside.
(WebCore::updateSegmentsForShapes): Use the right coordinates for block content with inline content.
LayoutTests:
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html: Added.
- 11:06 AM Changeset in webkit [156845] by
-
- 1 edit247 deletes in trunk/Source/WebKit2
Remove Qt files from WebKit2.
Rubber-stomped by Andreas Kling.
- DerivedSources.pri: Removed.
- PluginProcess.pro: Removed.
- PluginProcess/qt/PluginControllerProxyQt.cpp: Removed.
- PluginProcess/qt/PluginProcessMainQt.cpp: Removed.
- PluginProcess/qt/PluginProcessQt.cpp: Removed.
- SandboxProcess.pro: Removed.
- Shared/API/c/qt/WKImageQt.cpp: Removed.
- Shared/API/c/qt/WKImageQt.h: Removed.
- Shared/Downloads/qt/DownloadQt.cpp: Removed.
- Shared/Downloads/qt/QtFileDownloader.cpp: Removed.
- Shared/Downloads/qt/QtFileDownloader.h: Removed.
- Shared/qt/ArgumentCodersQt.cpp: Removed.
- Shared/qt/ArgumentCodersQt.h: Removed.
- Shared/qt/LayerTreeContextQt.cpp: Removed.
- Shared/qt/NativeWebKeyboardEventQt.cpp: Removed.
- Shared/qt/NativeWebMouseEventQt.cpp: Removed.
- Shared/qt/NativeWebTouchEventQt.cpp: Removed.
- Shared/qt/NativeWebWheelEventQt.cpp: Removed.
- Shared/qt/PlatformCertificateInfo.h: Removed.
- Shared/qt/ProcessExecutablePathQt.cpp: Removed.
- Shared/qt/QtNetworkReplyData.cpp: Removed.
- Shared/qt/QtNetworkReplyData.h: Removed.
- Shared/qt/QtNetworkRequestData.cpp: Removed.
- Shared/qt/QtNetworkRequestData.h: Removed.
- Shared/qt/ShareableBitmapQt.cpp: Removed.
- Shared/qt/WebCoreArgumentCodersQt.cpp: Removed.
- Shared/qt/WebEventFactoryQt.cpp: Removed.
- Shared/qt/WebEventFactoryQt.h: Removed.
- Shared/qt/WebURLRequestQt.cpp: Removed.
- Shared/qt/WebURLResponseQt.cpp: Removed.
- Target.pri: Removed.
- UIProcess/API/C/qt/WKIconDatabaseQt.cpp: Removed.
- UIProcess/API/C/qt/WKIconDatabaseQt.h: Removed.
- UIProcess/API/C/qt/WKNativeEvent.h: Removed.
- UIProcess/API/cpp/qt/WKStringQt.cpp: Removed.
- UIProcess/API/cpp/qt/WKStringQt.h: Removed.
- UIProcess/API/cpp/qt/WKURLQt.cpp: Removed.
- UIProcess/API/cpp/qt/WKURLQt.h: Removed.
- UIProcess/API/qt/qquicknetworkreply.cpp: Removed.
- UIProcess/API/qt/qquicknetworkreply_p.h: Removed.
- UIProcess/API/qt/qquicknetworkrequest.cpp: Removed.
- UIProcess/API/qt/qquicknetworkrequest_p.h: Removed.
- UIProcess/API/qt/qquickurlschemedelegate.cpp: Removed.
- UIProcess/API/qt/qquickurlschemedelegate_p.h: Removed.
- UIProcess/API/qt/qquickwebpage.cpp: Removed.
- UIProcess/API/qt/qquickwebpage_p.h: Removed.
- UIProcess/API/qt/qquickwebpage_p_p.h: Removed.
- UIProcess/API/qt/qquickwebview.cpp: Removed.
- UIProcess/API/qt/qquickwebview_p.h: Removed.
- UIProcess/API/qt/qquickwebview_p_p.h: Removed.
- UIProcess/API/qt/qtwebsecurityorigin.cpp: Removed.
- UIProcess/API/qt/qtwebsecurityorigin_p.h: Removed.
- UIProcess/API/qt/qwebdownloaditem.cpp: Removed.
- UIProcess/API/qt/qwebdownloaditem_p.h: Removed.
- UIProcess/API/qt/qwebdownloaditem_p_p.h: Removed.
- UIProcess/API/qt/qwebiconimageprovider.cpp: Removed.
- UIProcess/API/qt/qwebiconimageprovider_p.h: Removed.
- UIProcess/API/qt/qwebkittest.cpp: Removed.
- UIProcess/API/qt/qwebkittest_p.h: Removed.
- UIProcess/API/qt/qwebloadrequest.cpp: Removed.
- UIProcess/API/qt/qwebloadrequest_p.h: Removed.
- UIProcess/API/qt/qwebnavigationhistory.cpp: Removed.
- UIProcess/API/qt/qwebnavigationhistory_p.h: Removed.
- UIProcess/API/qt/qwebnavigationhistory_p_p.h: Removed.
- UIProcess/API/qt/qwebnavigationrequest.cpp: Removed.
- UIProcess/API/qt/qwebnavigationrequest_p.h: Removed.
- UIProcess/API/qt/qwebpermissionrequest.cpp: Removed.
- UIProcess/API/qt/qwebpermissionrequest_p.h: Removed.
- UIProcess/API/qt/qwebpreferences.cpp: Removed.
- UIProcess/API/qt/qwebpreferences_p.h: Removed.
- UIProcess/API/qt/qwebpreferences_p_p.h: Removed.
- UIProcess/API/qt/raw/qrawwebview.cpp: Removed.
- UIProcess/API/qt/raw/qrawwebview_p.h: Removed.
- UIProcess/API/qt/raw/qrawwebview_p_p.h: Removed.
- UIProcess/API/qt/tests/bytearraytestdata.cpp: Removed.
- UIProcess/API/qt/tests/bytearraytestdata.h: Removed.
- UIProcess/API/qt/tests/html/basic_page.html: Removed.
- UIProcess/API/qt/tests/html/basic_page2.html: Removed.
- UIProcess/API/qt/tests/html/bluesquare.html: Removed.
- UIProcess/API/qt/tests/html/direct-image-compositing.html: Removed.
- UIProcess/API/qt/tests/html/inputmethod.html: Removed.
- UIProcess/API/qt/tests/html/redsquare.html: Removed.
- UIProcess/API/qt/tests/html/resources/qwkview_noBackground1.png: Removed.
- UIProcess/API/qt/tests/html/resources/qwkview_noBackground3.png: Removed.
- UIProcess/API/qt/tests/html/resources/qwkview_paint.png: Removed.
- UIProcess/API/qt/tests/html/resources/simple_image.png: Removed.
- UIProcess/API/qt/tests/html/scroll.html: Removed.
- UIProcess/API/qt/tests/inspectorserver/inspectorserver.pro: Removed.
- UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp: Removed.
- UIProcess/API/qt/tests/publicapi/publicapi.pro: Removed.
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView.pro: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_findText.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_messaging.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_notification.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_resize.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_userScripts.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml: Removed.
- UIProcess/API/qt/tests/qmltests/common/TestWebView.qml: Removed.
- UIProcess/API/qt/tests/qmltests/common/alert.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/append-document-title.js: Removed.
- UIProcess/API/qt/tests/qmltests/common/big-user-script.js: Removed.
- UIProcess/API/qt/tests/qmltests/common/change-document-title.js: Removed.
- UIProcess/API/qt/tests/qmltests/common/colorChooser.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/confirm.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/download.zip: Removed.
- UIProcess/API/qt/tests/qmltests/common/evaluatejavascript.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/favicon.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/favicon.png: Removed.
- UIProcess/API/qt/tests/qmltests/common/favicon2.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/geolocation.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/javascript.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/link.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/localStorage.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/messaging.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/multifileupload.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/notification.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/prompt.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/qrctest.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/redirect.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/select.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/selectwithsize.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/singlefileupload.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/small-favicon.png: Removed.
- UIProcess/API/qt/tests/qmltests/common/test1.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test2.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test3.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test4.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test5.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/titleupdate.js: Removed.
- UIProcess/API/qt/tests/qmltests/qmltests.pro: Removed.
- UIProcess/API/qt/tests/qmltests/resources.qrc: Removed.
- UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp: Removed.
- UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro: Removed.
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: Removed.
- UIProcess/API/qt/tests/qrawwebview/qrawwebview.pro: Removed.
- UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp: Removed.
- UIProcess/API/qt/tests/tests.pri: Removed.
- UIProcess/API/qt/tests/testwindow.h: Removed.
- UIProcess/API/qt/tests/util.cpp: Removed.
- UIProcess/API/qt/tests/util.h: Removed.
- UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Removed.
- UIProcess/InspectorServer/qt/WebSocketServerQt.cpp: Removed.
- UIProcess/InspectorServer/qt/WebSocketServerQt.h: Removed.
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Removed.
- UIProcess/Plugins/qt/PluginProcessProxyQt.cpp: Removed.
- UIProcess/qt/BackingStoreQt.cpp: Removed.
- UIProcess/qt/PageViewportControllerClientQt.cpp: Removed.
- UIProcess/qt/PageViewportControllerClientQt.h: Removed.
- UIProcess/qt/QtDialogRunner.cpp: Removed.
- UIProcess/qt/QtDialogRunner.h: Removed.
- UIProcess/qt/QtDownloadManager.cpp: Removed.
- UIProcess/qt/QtDownloadManager.h: Removed.
- UIProcess/qt/QtGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtGestureRecognizer.h: Removed.
- UIProcess/qt/QtPageClient.cpp: Removed.
- UIProcess/qt/QtPageClient.h: Removed.
- UIProcess/qt/QtPanGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtPanGestureRecognizer.h: Removed.
- UIProcess/qt/QtPinchGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtPinchGestureRecognizer.h: Removed.
- UIProcess/qt/QtTapGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtTapGestureRecognizer.h: Removed.
- UIProcess/qt/QtWebContext.cpp: Removed.
- UIProcess/qt/QtWebContext.h: Removed.
- UIProcess/qt/QtWebError.cpp: Removed.
- UIProcess/qt/QtWebError.h: Removed.
- UIProcess/qt/QtWebIconDatabaseClient.cpp: Removed.
- UIProcess/qt/QtWebIconDatabaseClient.h: Removed.
- UIProcess/qt/QtWebPageEventHandler.cpp: Removed.
- UIProcess/qt/QtWebPageEventHandler.h: Removed.
- UIProcess/qt/QtWebPagePolicyClient.cpp: Removed.
- UIProcess/qt/QtWebPagePolicyClient.h: Removed.
- UIProcess/qt/QtWebPageSGNode.cpp: Removed.
- UIProcess/qt/QtWebPageSGNode.h: Removed.
- UIProcess/qt/QtWebPageUIClient.cpp: Removed.
- UIProcess/qt/QtWebPageUIClient.h: Removed.
- UIProcess/qt/TextCheckerQt.cpp: Removed.
- UIProcess/qt/WebColorPickerQt.cpp: Removed.
- UIProcess/qt/WebColorPickerQt.h: Removed.
- UIProcess/qt/WebContextMenuProxyQt.cpp: Removed.
- UIProcess/qt/WebContextMenuProxyQt.h: Removed.
- UIProcess/qt/WebContextQt.cpp: Removed.
- UIProcess/qt/WebFullScreenManagerProxyQt.cpp: Removed.
- UIProcess/qt/WebGeolocationProviderQt.cpp: Removed.
- UIProcess/qt/WebGeolocationProviderQt.h: Removed.
- UIProcess/qt/WebInspectorProxyQt.cpp: Removed.
- UIProcess/qt/WebPageProxyQt.cpp: Removed.
- UIProcess/qt/WebPopupMenuProxyQt.cpp: Removed.
- UIProcess/qt/WebPopupMenuProxyQt.h: Removed.
- UIProcess/qt/WebPreferencesQt.cpp: Removed.
- UIProcess/qt/WebProcessProxyQt.cpp: Removed.
- WebKit2.pri: Removed.
- WebKit2.pro: Removed.
- WebProcess.pro: Removed.
- WebProcess/Cookies/qt/WebCookieManagerQt.cpp: Removed.
- WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
- WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h: Removed.
- WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp: Removed.
- WebProcess/WebPage/qt/WebInspectorQt.cpp: Removed.
- WebProcess/WebPage/qt/WebPageQt.cpp: Removed.
- WebProcess/qt/QtBuiltinBundle.cpp: Removed.
- WebProcess/qt/QtBuiltinBundle.h: Removed.
- WebProcess/qt/QtBuiltinBundlePage.cpp: Removed.
- WebProcess/qt/QtBuiltinBundlePage.h: Removed.
- WebProcess/qt/QtNetworkAccessManager.cpp: Removed.
- WebProcess/qt/QtNetworkAccessManager.h: Removed.
- WebProcess/qt/QtNetworkReply.cpp: Removed.
- WebProcess/qt/QtNetworkReply.h: Removed.
- WebProcess/qt/SeccompFiltersWebProcessQt.cpp: Removed.
- WebProcess/qt/SeccompFiltersWebProcessQt.h: Removed.
- WebProcess/qt/WebProcessMainQt.cpp: Removed.
- WebProcess/qt/WebProcessQt.cpp: Removed.
- qt/MainQt.cpp: Removed.
- qt/PluginMainQt.cpp: Removed.
- 11:05 AM Changeset in webkit [156844] by
-
- 2 edits in trunk/LayoutTests
Add test expectation for one more test having color space issues after r156793.
(css3/filters/custom/custom-filter-composite-fractional-source-alpha.html)
- platform/mac-wk2/TestExpectations:
- 10:58 AM Changeset in webkit [156843] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/click-volume-bar-not-pausing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122126
- platform/mac/TestExpectations: Marked it as such.
- 10:55 AM Changeset in webkit [156842] by
-
- 10 edits in trunk/Source
Move IDBFactoryBackend creation to DatabaseStrategy.
https://bugs.webkit.org/show_bug.cgi?id=122284
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create):
- platform/DatabaseStrategy.cpp:
(WebCore::DatabaseStrategy::createIDBFactoryBackend): Implement a default.
- platform/DatabaseStrategy.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createIDBFactoryBackend): Fallback to the default for now.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 10:45 AM Changeset in webkit [156841] by
-
- 1 edit2 adds in trunk/LayoutTests
Re-add Qt TestExpectations. Without it, the flakiness dashboard page loads as blank.
- platform/qt: Added.
- platform/qt/TestExpectations: Added.
- 10:29 AM Changeset in webkit [156840] by
-
- 2 edits in trunk/Tools
REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
https://bugs.webkit.org/show_bug.cgi?id=122260
Reviewed by Alexey Proskuryakov.
For the API to work, the tests need to be compiled with a newer version of the LLVM
compiler. Until the bots are updated to that version, disable the tests on 10.8.
- TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
- 10:24 AM Changeset in webkit [156839] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error with VIDEO disabled.
https://bugs.webkit.org/show_bug.cgi?id=122266
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-03
Reviewed by Brent Fulgham.
- dom/Document.cpp:
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Protect with ENABLE(VIDEO) guard.
- 10:20 AM Changeset in webkit [156838] by
-
- 6 edits6 adds in trunk
[CSS Shapes] add shape-margin support for image valued shapes
https://bugs.webkit.org/show_bug.cgi?id=121619
Reviewed by Alexandru Chiculita.
Source/WebCore:
Add support for computing the shape-margin boundary for a shape-outside whose
value is an image.
Tests: fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html
- rendering/shapes/RasterShape.cpp:
(WebCore::MarginIntervalGenerator::MarginIntervalGenerator): Internal utility that generates the margin intervals for the image interval specified with set().
(WebCore::MarginIntervalGenerator::set):
(WebCore::MarginIntervalGenerator::intervalAt):
(WebCore::findInsertionPoint): Find the insertion point index for the the specified X value, within a vector of intervals sorted by X1.
(WebCore::RasterShapeIntervals::uniteMarginInterval): Destructively unite one interval with an existing one, or append it.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals):
(WebCore::RasterShape::marginIntervals): Return the lazily computed value, or create it with computeShapeMarginIntervals().
- rendering/shapes/RasterShape.h:
(WebCore::RasterShapeIntervals::getIntervals):
(WebCore::RasterShape::RasterShape):
(WebCore::RasterShapeIntervals::uniteMarginInterval):
- WTF/wtf/MathExtras.h: Added clampToUnsigned() inline.
LayoutTests:
Verify that the shape-outside margin-boundary is computed correctly for image valued shapes.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html: Added.
- 10:12 AM Changeset in webkit [156837] by
-
- 2 edits in trunk/Source/JavaScriptCore
[EFL] [DEBUG] JavaScriptCore fails to build
https://bugs.webkit.org/show_bug.cgi?id=122267
Patch by Sergio Correia <Sergio Correia> on 2013-10-03
Reviewed by Michael Saboff.
Build fails due to an expression containing comparison between signed
and unsigned integer.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): Add cast to avoid signed vs.
unsigned comparison warning.
- 9:02 AM Changeset in webkit [156836] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] Remove unused RenderLayerModelObject::updateLayerIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=122262
Reviewed by Alexandru Chiculita.
All regions have layers by default therefore there is no need for this function.
No tests needed, just a minor cleanup.
- rendering/RenderLayerModelObject.cpp:
- rendering/RenderLayerModelObject.h:
- 8:21 AM Changeset in webkit [156835] by
-
- 10 edits in trunk
[ATK] Expose aria-invalid as a text attribute (not object attribute)
https://bugs.webkit.org/show_bug.cgi?id=122015
Reviewed by Chris Fleizach.
Source/WebCore:
Expose the aria-invalid attribute correctly through a text
attribute (through the AtkText interface) instead of using an
object, according to what the WAI-ARIA specs says.
http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property
This will be tested by accesibility/aria-invalid.html, which should
keep passing after thanks to the changes done in the DRT and WKTR.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::invalidStatus): Update this method
to only return values recognized by the WAI-ARIA specification.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject): Expose aria-invalid as a
custom text attribute 'invalid', following the lead of Firefox.
Also register that custom attribute as a AtkTextAttribute.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Remove exposure of aria-invalid
as an object attribute from here.
Tools:
Adapted DRT and WKTR to check the exposure of the aria-invalid
attribute as a text attribute, instead of an object attribute.
Also, done some refactoring of the code to try to keep things
simpler and more coherent, by defining new helper functions,
simplifying code, moving static variables and functions into
unnammed namespaces and so on, without altering the logic other
than for checking the text attribute for aria-invalid.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(coreAttributeToAtkAttribute): Consider 'invalid' as the name of
the attribute exposed by the ATK wrapper, not 'aria-invalid'.
Also, never return an empty string if not falling through any of
the cases checked here, and return the original attribute instead.
(atkAttributeValueToCoreAttributeValue): New helper function to
match the attributes values returned by the ATK wrapper with the
values expected by the layout tests. Moved the mappings for the
values of AXSortDirection here as well.
(getAttributeSet): New helper function to retrieve a list of
attributes (an AtkAttributeSet) from an AtkObject using the right
API depending on whether we want the object attributes or the text
attributes (in case the object implements AtkText).
(getAttributeSetValueForId): Simplified by using getAttributeSet
and atkAttributeValueToCoreAttributeValue. Also, added a new
parameter to indicater whether we are interested in object
attributes or text attributes.
(getAtkAttributeSetAsString): Ditto.
(attributesOfElement): Updated to pass the new required parameter
to getAtkAttributeSetAsString, indicating that we want the object
attributes in this case, for backwards compatibility.
(indexRangeInTable): Moved up in the file into the unnammed namespace.
(alterCurrentValue): Ditto.
(AccessibilityUIElement::stringAttributeValue): After moving most
of the code here to the new helper functions, simplified it by
just checking whether the required attribute is provided as an
object attribute or, if that's not the case, as a text attribute.
(AccessibilityUIElement::isAttributeSupported): Ditto.
(AccessibilityUIElement::intValue): Updated to pass the new
required parameter to getAttributeSetValueForId, indicating that
we want the object attributes in this case.
(AccessibilityUIElement::hasPopup): Ditto.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
(WTR::atkAttributeValueToCoreAttributeValue): Ditto.
(WTR::getAttributeSet): Ditto.
(WTR::getAttributeSetValueForId): Ditto.
(WTR::getAtkAttributeSetAsString): Ditto.
(WTR::attributesOfElement): Ditto.
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
(WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::hasPopup): Ditto.
LayoutTests:
Updated the aria-invalid.html layout test to make sure that it
behaves as defined by the WAI-ARIA specification for values other
than 'false', 'true', 'grammar' and 'spelling'.
- accessibility/aria-invalid.html: Updated test.
- accessibility/aria-invalid-expected.txt: Updated expectations.
- 8:05 AM Changeset in webkit [156834] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 8:03 AM Changeset in webkit [156833] by
-
- 1 copy in tags/Safari-537.73.1
New Tag.
- 3:19 AM Changeset in webkit [156832] by
-
- 1 edit2 copies in trunk/LayoutTests
Add back .htaccess files erroneously removed in r156827.
- http/tests/appcache/resources/intercept: Copied from LayoutTests/http/tests/appcache/resources/intercept.
- http/tests/uri/intercept: Copied from LayoutTests/http/tests/uri/intercept.
- 2:30 AM Changeset in webkit [156831] by
-
- 2 edits in trunk/Source/WebCore
Add the NotDeletable, OperationsNotDeletable IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=122217
Reviewed by Darin Adler.
Before adjusting the JSC bindings generator to enforce configurable operations and thus conform to the
WebIDL specification in this regard, two no-op attributes are introduced that will preserve the current
behavior of operations being non-configurable.
All the relevant interfaces will be annotated with the OperationsNotDeletable attribute first. After the
generator is properly modified, this attribute will be removed from the interfaces after checking that
the operations' configurability also matches the configurability of operations in other browser engines
and that the change introduces no regressions in tests.
The NotDeletable attribute will be used as required to annotate operations that should stay
non-configurable for backwards compatibility or cross-browser compatibility.
- bindings/scripts/IDLAttributes.txt:
- 1:43 AM Changeset in webkit [156830] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG: ConstProp the pattern ValueToInt32(Bool(x)) -> Int32(x)
https://bugs.webkit.org/show_bug.cgi?id=122263
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-03
Reviewed by Geoffrey Garen.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- 1:35 AM Changeset in webkit [156829] by
-
- 8 deletes in trunk/LayoutTests/platform
Remove Qt specific expected files and directories.
Reviewed by Csaba Osztrogonác.
- 12:58 AM Changeset in webkit [156828] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed fix of DrawingArea creation on non-Mac platforms after r156793.
std::make_unique<DrawingAreaImpl>() should be used, as before that revision.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
- 12:35 AM Changeset in webkit [156827] by
-
- 138 deletes in trunk
Unreviewed. Remove empty directories.
- 12:33 AM Changeset in webkit [156826] by
-
- 2 edits in trunk/Source/WebCore
Remove preDispatchEventHandler and postDispatchEventHandler,
functions that are supposed to be removed in the previous commit (r156825).
- dom/Node.h:
Oct 2, 2013:
- 11:50 PM Changeset in webkit [156825] by
-
- 16 edits in trunk/Source/WebCore
Get rid of Node::preDispatchEventHandler and Node::postDispatchEventHandler
https://bugs.webkit.org/show_bug.cgi?id=122144
Reviewed by Darin Adler.
Get rid of pre/post event dispatch callbacks preDispatchEventHandler and postDispatchEventHandler since
the former was only called by HTMLMediaElement and HTMLInputElement and the latter was only called by
HTMLInputElement.
Explicitly call HTMLMediaElement's willDispatchFullScreenChangeEvent in fullScreenChangeDelayTimerFired
of Document since this is the only place that fires the fullscreenchange event.
Also add an explicit call to willDispatchEvent and didDispatchClickEvent in EventDispatcher::dispatch.
This also allows us to stack-allocate InputElementClickHandlingState instead of having willDispatchEvent
heap-allocate it and pass it around as void*.
- WebCore.order:
- dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):
- dom/Document.h:
- dom/EventContext.cpp:
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::callWillDispatchEventOnInputElement):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
- html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::willDispatchClick):
- html/CheckboxInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::willDispatchEvent):
(WebCore::HTMLInputElement::didDispatchClickEvent):
- html/HTMLInputElement.h:
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::willDispatchFullScreenChangeEvent): Renamed from preDispatchEventHandler.
- html/HTMLTextFormControlElement.h:
- html/InputType.cpp:
(WebCore::InputType::willDispatchClick):
- html/InputType.h:
- html/RadioInputType.cpp:
(WebCore::RadioInputType::willDispatchClick):
- html/RadioInputType.h:
- 11:41 PM Changeset in webkit [156824] by
-
- 5 edits in trunk/Source/WebCore
Update binding test results after r156808 for r156769.
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeOwner::finalize):
- bindings/scripts/test/JS/JSattribute.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyOwner::finalize):
- bindings/scripts/test/JS/JSreadonly.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- 11:30 PM Changeset in webkit [156823] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
https://bugs.webkit.org/show_bug.cgi?id=122260
Reviewed by Mark Rowe.
For the API to work, the tests need to be compiled with a newer version of the LLVM
compiler. Until the bots are updated to that version, disable the tests on 10.8.
- API/tests/testapi.mm:
- 10:59 PM Changeset in webkit [156822] by
-
- 69 edits in trunk/Source/WebCore
Unreviewed, rolling out r156816.
http://trac.webkit.org/changeset/156816
https://bugs.webkit.org/show_bug.cgi?id=122259
broke 8 tests (Requested by kling on #webkit).
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::willRecalcStyle):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::listAttributeTargetChanged):
- html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::setPositionFromValue):
(WebCore::SliderThumbElement::setPositionFromPoint):
(WebCore::SliderThumbElement::stopDragging):
- page/FrameView.cpp:
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
(WebCore::FrameView::layout):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::setNeedsLayout):
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
- rendering/FlowThreadController.h:
(WebCore::FlowThreadController::setIsRenderNamedFlowThreadOrderDirty):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::relayoutShapeDescendantIfMoved):
(WebCore::RenderBlock::markShapeInsideDescendantsForLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout):
(WebCore::RenderBlock::dirtyForLayoutFromPercentageHeightDescendants):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markPositionedObjectsForLayout):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::removePositionedObjects):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::getClearDelta):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::adjustPositionedBlock):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlock::positionNewFloatOnLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::layout):
(WebCore::RenderBox::positionLineBox):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::insertChildInternal):
- rendering/RenderElement.h:
(WebCore::RenderElement::setAncestorLineBoxDirty):
(WebCore::RenderObject::setNeedsLayout):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::layoutSpecialExcludedChild):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::styleDidChange):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFrames):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::continueResizing):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged):
- rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::layout):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::updateMarqueeStyle):
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::relayoutForPagination):
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::RenderObject::layout):
- rendering/RenderObject.h:
(WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::RenderObject::setNormalChildNeedsLayout):
(WebCore::RenderObject::setPosChildNeedsLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setChildNeedsLayout):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::layout):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layoutSpecialExcludedChild):
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarParts):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::layout):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
- rendering/RenderTable.h:
(WebCore::RenderTable::setNeedsSectionRecalc):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicPadding):
(WebCore::RenderTableCell::setCellLogicalWidth):
(WebCore::RenderTableCell::layout):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::layout):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::recalcCells):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::layoutSpecialExcludedChild):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::setNeedsLayoutOnAncestors):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::styleDidChange):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize):
- rendering/RenderView.cpp:
(WebCore::RenderView::layout):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::layout):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::layout):
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
- rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::layout):
- rendering/svg/RenderSVGHiddenContainer.cpp:
(WebCore::RenderSVGHiddenContainer::layout):
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout):
- rendering/svg/RenderSVGResource.cpp:
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::setFilterRes):
(WebCore::SVGFilterElement::svgAttributeChanged):
(WebCore::SVGFilterElement::childrenChanged):
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::svgAttributeChanged):
(WebCore::SVGGradientElement::childrenChanged):
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::svgAttributeChanged):
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::svgAttributeChanged):
(WebCore::SVGMarkerElement::childrenChanged):
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::svgAttributeChanged):
(WebCore::SVGPatternElement::childrenChanged):
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::svgAttributeChanged):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::updateCurrentTranslate):
- 9:31 PM Changeset in webkit [156821] by
-
- 3 edits in trunk/Websites/webkit.org
2013-10-02 Geoffrey Garen <ggaren@apple.com>
Sync'd sunspider-1.0.2 to PerformanceTests/SunSpider/hosted/sunspider-1.0.2.
- perf/sunspider-1.0.2/sunspider-1.0.2/driver.html:
- perf/sunspider-1.0.2/sunspider-1.0.2/sunspider-test-contents.js:
- 9:25 PM Changeset in webkit [156820] by
-
- 3 edits in trunk/PerformanceTests/SunSpider
Improved painting behavior in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122257
Reviewed by Oliver Hunt.
Individual test names with times was a good painting strategy years
back, when each benchmark took hundreds of milliseconds to run. Now,
the whole suite can finish in a a few hundres milliseconds, and things
look pretty flashy.
Instead, display a countdown that indicates which iteration of the
test we're on.
- resources/TEMPLATE.html: Work around a bug in Firefox by specifying
our style inside the .html file instead of in an external stylesheet.
Under heavy JavaScript load, Firefox neglects to apply external
stylesheets -- probably due to a starved timer.
- resources/driver-TEMPLATE.html: Delay a little between runs to ensure
that our countdown has enough time to paint.
- 8:21 PM Changeset in webkit [156819] by
-
- 5 edits in trunk/Source/WebCore
Keep SVGElementRareData in an SVGElement member instead of a hashmap.
<https://webkit.org/b/122253>
Reviewed by Antti Koivisto.
Free up another Node flag by moving SVGElement's SVG-specific rare data
to a member variable instead of tracking them in a hashmap on the side.
This grows SVGElement by one pointer, but I will make up for this in
subsequent patches.
- 7:44 PM Changeset in webkit [156818] by
-
- 7 edits in trunk/Source/JavaScriptCore
Make LLINT exception stack unwinding consistent with the JIT.
https://bugs.webkit.org/show_bug.cgi?id=122255.
Reviewed by Filip Pizlo.
Previously, the CommonSlowPaths code is expected to behave in an
inconsistent way in terms of whether to unwind the stack when handling
exceptions or not. For the LLINT, the slow path should unwind the stack
before returning. For the JIT, the slow path should not unwind the stack.
This can result in the stack being unwound twice when the exception
being handled is a TerminationException.
This patch fixes the LLINT's expectation so that it expects the same
slow path behavior as the JIT does.
- llint/LLIntExceptions.cpp:
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPathsExceptions.cpp:
(JSC::CommonSlowPaths::interpreterThrowInCaller):
- 7:27 PM Changeset in webkit [156817] by
-
- 9 edits in trunk/Source/JavaScriptCore
The DFG should use always DFG::Graph methods for determining where special registers are
https://bugs.webkit.org/show_bug.cgi?id=122248
Reviewed by Michael Saboff.
This makes it possible to have the DFG use different registers than the other engines
for things like activation and arguments.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setLocalStoreElimination):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::activationRegister):
(JSC::DFG::Graph::uncheckedActivationRegister):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::baselineArgumentsRegisterFor):
- 7:26 PM Changeset in webkit [156816] by
-
- 69 edits in trunk/Source/WebCore
Move setting of some layout bits to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122256
Reviewed by Andreas Kling.
These bits never apply to RenderText nodes:
normalChildNeedsLayout
posChildNeedsLayout
needsSimplifiedNormalFlowLayout
normalChildNeedsLayout
positionedMovementLayout
The code for setting them can be moved to RenderElement.
Also separated the code paths for setting and clearing the bits and uninlined
everything that is not massively popular.
- 6:32 PM Changeset in webkit [156815] by
-
- 3 edits in trunk/Source/WebCore
CTTE: Drag events are only dispatched on Elements.
<https://webkit.org/b/122250>
Reviewed by Antti Koivisto.
We never dispatch drag events on non-Element nodes so tighten up the
code to operate on Elements instead.
- 5:54 PM Changeset in webkit [156814] by
-
- 10 edits3 adds in trunk
[CSS Shapes] Implement the shape-image-threshold property
https://bugs.webkit.org/show_bug.cgi?id=122216
Reviewed by Andreas Kling.
Source/WebCore:
Added support for the CSS shape-image-threshold property. This change
just enables parsing the property, it's not connected to the
Shapes code yet.
The number valued shape-image-threshold property is defined here:
http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property
Its computed value is clamped to the range [0, 1].
Test: fast/shapes/parsing/parsing-shape-image-threshold.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
Check parsing of the non-inherited CSS shape-image-threshold number property.
The property is defined here:
http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property
- fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: Added.
- fast/shapes/parsing/parsing-shape-image-threshold.html: Added.
- fast/shapes/parsing/script-tests/parsing-shape-image-threshold.js: Added.
- 5:10 PM Changeset in webkit [156813] by
-
- 10 edits1 delete in trunk/Source/WebCore
Remove Qt-specific code in WebCore/plugins.
<https://webkit.org/b/122247>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and Qt-specific files.
- 5:04 PM Changeset in webkit [156812] by
-
- 1 edit7 deletes in trunk
Remove Qt related files from the root directories
https://bugs.webkit.org/show_bug.cgi?id=122249
Reviewed by Andreas Kling.
- Source/QtWebKit.pro: Removed.
- Source/api.pri: Removed.
- Source/qtwebkit.qdocconf: Removed.
- Source/sync.profile: Removed.
- Source/tests.pri: Removed.
- Source/widgetsapi.pri: Removed.
- WebKit.pro: Removed.
- 4:47 PM Changeset in webkit [156811] by
-
- 8 edits in trunk/Source/JavaScriptCore
The Objective-C API should be available in 10.8 builds
https://bugs.webkit.org/show_bug.cgi?id=122245
Reviewed by Mark Rowe.
Enabled the Objective-C API when building on OS X 10.8 with the modern Objective-C runtime,
but kept the availability attributes in API headers for 10.9 and later as they were.
- API/JSBase.h: When JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 is defined, made
JSC_OBJC_API_ENABLED true on 10.8 and above.
- API/JSContext.h: When JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 is defined, marked the class
as available on all OS X versions.
- API/JSManagedValue.h: Ditto.
- API/JSValue.h: Ditto.
- API/JSVirtualMachine.h: Ditto.
- Configurations/Base.xcconfig: Added JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 to
GCC_PREPROCESSOR_DEFINITIONS.
- JavaScriptCore.xcodeproj/project.pbxproj: Added a script build phase to unifdef the
above header files with JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 either defined or not based on
the OS X version we are targeting.
- 4:33 PM Changeset in webkit [156810] by
-
- 3 edits in trunk/Source/JavaScriptCore
Make Baseline JIT exception handling work like the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=122244
Reviewed by Filip Pizlo.
Added a jump list (m_exceptionChecks) to JIT as a common place for exception processing within
generated code. Added exceptionCheck() helpers that check for an exception which add a branch
to the list.
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JIT.h:
(JSC::JIT::exceptionCheck):
- 4:33 PM Changeset in webkit [156809] by
-
- 6 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: save and restore source positions in back/forward history
https://bugs.webkit.org/show_bug.cgi?id=122062
Patch by Brian J. Burg <Brian Burg> on 2013-10-02
Reviewed by Timothy Hatcher.
Previously, the back/forward entries comprised of only the content
views, but not their positions if navigated via hyperlink (i.e.,
handling script.js:42). When multiple instances of the same
content view appeared in the back/forward list, the most recent
navigation was displayed rather than the linked position.
We now store context necessary to re-navigate such hyperlinks by
storing view- specific data inside a cookie object, and invoke a
supplied callback to take any position initialization actions,
such as calling TextEditor.revealPosition. This state is
encapsulated into BackForwardEntry instances.
Functions that save and restore scroll positions inside content
views have been changed to store state in BackForwardEntry
instances, so multiple scroll positions can be saved for a content
view appearing in the navigation history more than once.
- UserInterface/BackForwardEntry.js: Added.
(WebInspector.BackForwardEntry):
(WebInspector.BackForwardEntry.prototype.get contentView):
(WebInspector.BackForwardEntry.prototype.get cookie):
(WebInspector.BackForwardEntry.prototype.prepareToShow):
(WebInspector.BackForwardEntry.prototype.prepareToHide):
(WebInspector.BackForwardEntry.prototype._restoreFromCookie):
(WebInspector.BackForwardEntry.prototype._restoreScrollPositions):
(WebInspector.BackForwardEntry.prototype._saveScrollPositions):
- UserInterface/ContentBrowser.js:
(WebInspector.ContentBrowser.prototype.showContentView):
(WebInspector.ContentBrowser.prototype._updateContentViewNavigationItems):
(WebInspector.ContentBrowser.prototype._updateFindBanner):
- UserInterface/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.get currentContentView):
(WebInspector.ContentViewContainer.prototype.get currentBackForwardEntry):
(WebInspector.ContentViewContainer.prototype.showContentView):
(WebInspector.ContentViewContainer.prototype.showBackForwardEntryForIndex):
(WebInspector.ContentViewContainer.prototype.replaceContentView):
(WebInspector.ContentViewContainer.prototype.closeAllContentViewsOfPrototype):
(WebInspector.ContentViewContainer.prototype.closeAllContentViews):
(WebInspector.ContentViewContainer.prototype.goBack):
(WebInspector.ContentViewContainer.prototype.goForward):
(WebInspector.ContentViewContainer.prototype.shown):
(WebInspector.ContentViewContainer.prototype.hidden):
(WebInspector.ContentViewContainer.prototype._showEntry):
(WebInspector.ContentViewContainer.prototype._hideEntry):
- UserInterface/Main.html:
- UserInterface/Main.js:
(WebInspector.openURL):
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.restoreCallback):
(WebInspector.ResourceSidebarPanel.prototype.showSourceCode):
- 4:32 PM Changeset in webkit [156808] by
-
- 14 edits22 adds in trunk/Source/WebCore
IDL parser should remove a leading "_" from identifier names
https://bugs.webkit.org/show_bug.cgi?id=122239
Reviewed by Jer Noble.
No new tests, updated bindings tests and results.
- bindings/scripts/IDLParser.pm:
(identifierRemoveNullablePrefix): Remove leading "_".
(parseInterface): Call identifierRemoveNullablePrefix.
(parseException): Ditto.
(parseEnum): Ditto.
(parseConst): Ditto.
(parseAttributeRest): Ditto.
(parseOperationRest): Ditto.
(parseOptionalOrRequiredArgument): Ditto.
(parseExceptionField): Ditto.
(parseNonAnyType): Ditto.
Update tests and results.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/CPP/WebDOMattribute.cpp: Added.
- bindings/scripts/test/CPP/WebDOMattribute.h: Added.
- bindings/scripts/test/CPP/WebDOMreadonly.cpp: Added.
- bindings/scripts/test/CPP/WebDOMreadonly.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.symbols:
- bindings/scripts/test/GObject/WebKitDOMattribute.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMattribute.h: Added.
- bindings/scripts/test/GObject/WebKitDOMattribute.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMattributePrivate.h: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonly.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonly.h: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonly.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonlyPrivate.h: Added.
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSattribute.cpp: Added.
- bindings/scripts/test/JS/JSattribute.h: Added.
- bindings/scripts/test/JS/JSreadonly.cpp: Added.
- bindings/scripts/test/JS/JSreadonly.h: Added.
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/ObjC/DOMattribute.h: Added.
- bindings/scripts/test/ObjC/DOMattribute.mm: Added.
- bindings/scripts/test/ObjC/DOMattributeInternal.h: Added.
- bindings/scripts/test/ObjC/DOMreadonly.h: Added.
- bindings/scripts/test/ObjC/DOMreadonly.mm: Added.
- bindings/scripts/test/ObjC/DOMreadonlyInternal.h: Added.
- bindings/scripts/test/TestException.idl:
- bindings/scripts/test/TestInterface.idl:
- bindings/scripts/test/TestObj.idl:
- 4:29 PM Changeset in webkit [156807] by
-
- 8 edits in trunk/LayoutTests
[CSS Regions] Helper functions for selection layout tests
https://bugs.webkit.org/show_bug.cgi?id=122128
Reviewed by Alexandru Chiculita.
Create new common JavaScript methods for CSS Regions layout tests
related to selection. Refactored tests in order to use them.
- fast/regions/resources/helper.js: Added new functions.
(selectContentByRange): Select from start to end position.
(selectContentByIds): Select from the beginning of the first element to the end
of the second one.
(selectBaseAndExtent): Select from start to end with given offsets using
Selection.setBaseAndExtent() method.
(mouseClick): Clicks in a given position.
- fast/regions/selection/selecting-text-in-empty-region.html: Refactored
test in order to use the new functions.
- fast/regions/selection/selecting-text-through-different-region-flows-2-expected.html:
Ditto.
- fast/regions/selection/selecting-text-through-different-region-flows-2.html:
Ditto.
- fast/regions/selection/selecting-text-through-different-region-flows.html:
Ditto.
- fast/regions/selection/selection-direction-expected.html: Ditto.
- fast/regions/selection/selection-direction.html: Ditto.
- 4:27 PM Changeset in webkit [156806] by
-
- 3 edits2 adds in trunk
[css-shapes] shape-outside does not properly handle the container and the float having different writing modes
https://bugs.webkit.org/show_bug.cgi?id=122243
Reviewed by Alexandru Chiculita.
Source/WebCore:
The margin box offset needs to be computed based on the writing mode
of the container, not the writihg mode of the float itself. This
patch makes that happen.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
LayoutTests:
Test that the margins and width are properly computed in the case of
different writing modes.
- fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html: Added.
- 4:11 PM Changeset in webkit [156805] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MSVC build
- 3:37 PM Changeset in webkit [156804] by
-
- 10 edits1 delete in trunk/Source/WebCore
Remove Qt-specific code in WebCore/{bindings,bridge,loader,icon,testing}.
<https://webkit.org/b/122242>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and Qt-specific files.
- 3:21 PM Changeset in webkit [156803] by
-
- 2 edits in trunk/Tools
EWS build fix after the Qt EWS removal.
- QueueStatusServer/model/attachment.py:
(Attachment._calculate_queue_positions):
- 3:14 PM Changeset in webkit [156802] by
-
- 2 edits in trunk/Source/JavaScriptCore
Optimized VM access from C++ code
https://bugs.webkit.org/show_bug.cgi?id=122241
Reviewed by Filip Pizlo.
- runtime/JSScope.h:
(JSC::JSScope::vm): Use MarkedBlock instead of Heap, since both have a
pointer to the VM, and Heap is one extra load.
- 2:58 PM Changeset in webkit [156801] by
-
- 11 edits in trunk/LayoutTests
Unreviewed rebaseline, try to add newlines back that keep disappearing on me.
- platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt:
- platform/mac-wk2/compositing/contents-opaque/body-background-skipped-expected.txt:
- platform/mac-wk2/compositing/repaint/fixed-background-scroll-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-absolute-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- platform/mac-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/mac-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/mac-wk2/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/mac-wk2/compositing/tiling/tiled-layer-resize-expected.txt:
- 2:57 PM Changeset in webkit [156800] by
-
- 3 edits2 deletes in trunk/Source/WebCore
Remove Qt-specific code in WebCore/{page,accessibility}.
<https://webkit.org/b/122222>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and FooBarQt.* files.
- 2:45 PM Changeset in webkit [156799] by
-
- 8 edits1 delete in trunk/Source/WebKit2
Remove Qt code from Platform/
https://bugs.webkit.org/show_bug.cgi?id=122240
Reviewed by Andreas Kling.
- Platform/CoreIPC/Connection.h:
- Platform/Logging.cpp:
- Platform/Logging.h:
- Platform/Module.h:
- Platform/PlatformProcessIdentifier.h:
- Platform/SharedMemory.h:
- Platform/WorkQueue.h:
- Platform/qt/LoggingQt.cpp: Removed.
- Platform/qt/ModuleQt.cpp: Removed.
- Platform/qt/WorkQueueQt.cpp: Removed.
- 2:44 PM Changeset in webkit [156798] by
-
- 3 edits in trunk/Source/WebCore
[CSS Shapes] Move ShapeInsideInfo::updateSegmentsForLine implementations into the cpp
https://bugs.webkit.org/show_bug.cgi?id=122236
Reviewed by Oliver Hunt.
There is no reason for updateSegmentsForLine methods to be inline. I moved them to the cpp.
No new tests, no behavior change.
- rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::updateSegmentsForLine):
- rendering/shapes/ShapeInsideInfo.h:
- 2:27 PM Changeset in webkit [156797] by
-
- 10 edits25 deletes in trunk/Tools
Remove Qt code from Tools/
https://bugs.webkit.org/show_bug.cgi?id=122227
Reviewed by Andreas Kling.
- DumpRenderTree/WorkQueue.cpp:
- DumpRenderTree/blackberry/src.pro: Removed.
- DumpRenderTree/qt/DumpRenderTree.pro: Removed.
- DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
- DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
- DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
- DumpRenderTree/qt/EventSenderQt.cpp: Removed.
- DumpRenderTree/qt/EventSenderQt.h: Removed.
- DumpRenderTree/qt/GCControllerQt.cpp: Removed.
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
- DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
- DumpRenderTree/qt/TestRunnerQt.h: Removed.
- DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
- DumpRenderTree/qt/TextInputControllerQt.h: Removed.
- DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
- DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
- DumpRenderTree/qt/fonts/AHEM.TTF: Removed.
- DumpRenderTree/qt/resources/user.css: Removed.
- DumpRenderTree/qt/testplugin.cpp: Removed.
- DumpRenderTree/qt/testplugin.h: Removed.
- ImageDiff/ImageDiff.pro: Removed.
- ImageDiff/qt/ImageDiff.cpp: Removed.
- MiniBrowser/qt/BrowserWindow.cpp: Removed.
- MiniBrowser/qt/BrowserWindow.h: Removed.
- MiniBrowser/qt/MiniBrowser.pro: Removed.
- MiniBrowser/qt/MiniBrowser.qrc: Removed.
- MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
- MiniBrowser/qt/MiniBrowserApplication.h: Removed.
- MiniBrowser/qt/UrlLoader.cpp: Removed.
- MiniBrowser/qt/UrlLoader.h: Removed.
- MiniBrowser/qt/icons/checkbox_checked.png: Removed.
- MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
- MiniBrowser/qt/icons/contents_width.png: Removed.
- MiniBrowser/qt/icons/favicon.png: Removed.
- MiniBrowser/qt/icons/find.png: Removed.
- MiniBrowser/qt/icons/folder.png: Removed.
- MiniBrowser/qt/icons/info.png: Removed.
- MiniBrowser/qt/icons/next.png: Removed.
- MiniBrowser/qt/icons/plus.png: Removed.
- MiniBrowser/qt/icons/previous.png: Removed.
- MiniBrowser/qt/icons/refresh.png: Removed.
- MiniBrowser/qt/icons/stop.png: Removed.
- MiniBrowser/qt/icons/titlebar.png: Removed.
- MiniBrowser/qt/icons/touch.png: Removed.
- MiniBrowser/qt/icons/touchpoint.png: Removed.
- MiniBrowser/qt/icons/up.png: Removed.
- MiniBrowser/qt/js/MultiSelect.js: Removed.
- MiniBrowser/qt/main.cpp: Removed.
- MiniBrowser/qt/qml/AlertDialog.qml: Removed.
- MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
- MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
- MiniBrowser/qt/qml/CheckBox.qml: Removed.
- MiniBrowser/qt/qml/ColorChooser.qml: Removed.
- MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
- MiniBrowser/qt/qml/Dialog.qml: Removed.
- MiniBrowser/qt/qml/DialogButton.qml: Removed.
- MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
- MiniBrowser/qt/qml/FilePicker.qml: Removed.
- MiniBrowser/qt/qml/ItemSelector.qml: Removed.
- MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
- MiniBrowser/qt/qml/PromptDialog.qml: Removed.
- MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
- MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
- MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
- MiniBrowser/qt/raw/DerivedSources.pri: Removed.
- MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
- MiniBrowser/qt/raw/Target.pri: Removed.
- MiniBrowser/qt/raw/View.cpp: Removed.
- MiniBrowser/qt/raw/View.h: Removed.
- MiniBrowser/qt/utils.cpp: Removed.
- MiniBrowser/qt/utils.h: Removed.
- QtTestBrowser/QtTestBrowser.pro: Removed.
- QtTestBrowser/QtTestBrowser.qrc: Removed.
- QtTestBrowser/cookiejar.cpp: Removed.
- QtTestBrowser/cookiejar.h: Removed.
- QtTestBrowser/favicon.png: Removed.
- QtTestBrowser/fpstimer.cpp: Removed.
- QtTestBrowser/fpstimer.h: Removed.
- QtTestBrowser/launcherwindow.cpp: Removed.
- QtTestBrowser/launcherwindow.h: Removed.
- QtTestBrowser/locationedit.cpp: Removed.
- QtTestBrowser/locationedit.h: Removed.
- QtTestBrowser/mainwindow.cpp: Removed.
- QtTestBrowser/mainwindow.h: Removed.
- QtTestBrowser/qttestbrowser.cpp: Removed.
- QtTestBrowser/urlloader.cpp: Removed.
- QtTestBrowser/urlloader.h: Removed.
- QtTestBrowser/useragentlist.txt: Removed.
- QtTestBrowser/utils.cpp: Removed.
- QtTestBrowser/utils.h: Removed.
- QtTestBrowser/webinspector.h: Removed.
- QtTestBrowser/webpage.cpp: Removed.
- QtTestBrowser/webpage.h: Removed.
- QtTestBrowser/webview.cpp: Removed.
- QtTestBrowser/webview.h: Removed.
- TestWebKitAPI/DerivedSources.pri: Removed.
- TestWebKitAPI/InjectedBundle.pri: Removed.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/TestWebKitAPI.pri: Removed.
- TestWebKitAPI/TestWebKitAPI.pro: Removed.
- TestWebKitAPI/Tests.pri: Removed.
- TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
- TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
- TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
- TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
- TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
- TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
- TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
- TestWebKitAPI/qt/main.cpp: Removed.
- Tools.pro: Removed.
- WebKitTestRunner/DerivedSources.pri: Removed.
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
- WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
(WTR::InjectedBundlePage::didClearWindowForFrame):
- WebKitTestRunner/InjectedBundle/Target.pri: Removed.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
- WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
- WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/Target.pri: Removed.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/WebKitTestRunner.pro: Removed.
- WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
- WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
- WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
- WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
- WebKitTestRunner/qt/main.cpp: Removed.
- WebKitTestRunner/qt/resources/user.css: Removed.
- qmake/.qmake.cache: Removed.
- qmake/.qmake.conf: Removed.
- qmake/README: Removed.
- qmake/config.tests/README: Removed.
- qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
- qmake/config.tests/fontconfig/fontconfig.pro: Removed.
- qmake/config.tests/gccdepends/empty.cpp: Removed.
- qmake/config.tests/gccdepends/gccdepends.pro: Removed.
- qmake/config.tests/glx/glx.cpp: Removed.
- qmake/config.tests/glx/glx.pro: Removed.
- qmake/config.tests/gnuld/gnuld.pro: Removed.
- qmake/config.tests/gnuld/main.cpp: Removed.
- qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
- qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
- qmake/config.tests/libXrender/libXrender.cpp: Removed.
- qmake/config.tests/libXrender/libXrender.pro: Removed.
- qmake/config.tests/libwebp/libwebp.cpp: Removed.
- qmake/config.tests/libwebp/libwebp.pro: Removed.
- qmake/config.tests/libxml2/libxml2.cpp: Removed.
- qmake/config.tests/libxml2/libxml2.pro: Removed.
- qmake/config.tests/libxslt/libxslt.cpp: Removed.
- qmake/config.tests/libxslt/libxslt.pro: Removed.
- qmake/config.tests/libzlib/libzlib.cpp: Removed.
- qmake/config.tests/libzlib/libzlib.pro: Removed.
- qmake/dump-features.pl: Removed.
- qmake/mkspecs/features/configure.prf: Removed.
- qmake/mkspecs/features/default_post.prf: Removed.
- qmake/mkspecs/features/default_pre.prf: Removed.
- qmake/mkspecs/features/features.prf: Removed.
- qmake/mkspecs/features/features.pri: Removed.
- qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
- qmake/mkspecs/features/functions.prf: Removed.
- qmake/mkspecs/features/gprof.prf: Removed.
- qmake/mkspecs/features/mac/default_post.prf: Removed.
- qmake/mkspecs/features/mac/default_pre.prf: Removed.
- qmake/mkspecs/features/minimal_qt.prf: Removed.
- qmake/mkspecs/features/production_build.prf: Removed.
- qmake/mkspecs/features/rpath.prf: Removed.
- qmake/mkspecs/features/unix/default_post.prf: Removed.
- qmake/mkspecs/features/unix/default_pre.prf: Removed.
- qmake/mkspecs/features/unix/icc.prf: Removed.
- qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
- qmake/mkspecs/features/valgrind.prf: Removed.
- qmake/mkspecs/features/webkit_modules.prf: Removed.
- qmake/mkspecs/features/win32/default_post.prf: Removed.
- qmake/mkspecs/features/win32/default_pre.prf: Removed.
- qmake/mkspecs/modules/angle.prf: Removed.
- qmake/mkspecs/modules/javascriptcore.prf: Removed.
- qmake/mkspecs/modules/webcore.prf: Removed.
- qmake/mkspecs/modules/webkit1.prf: Removed.
- qmake/mkspecs/modules/webkit2.prf: Removed.
- qmake/mkspecs/modules/wtf.prf: Removed.
- 2:24 PM Changeset in webkit [156796] by
-
- 3 edits8 moves1 add in trunk/LayoutTests
[CSS Regions] Selection layout tests moved to specific folder
https://bugs.webkit.org/show_bug.cgi?id=122099
Reviewed by Alexandru Chiculita.
Moved CSS Regions layout tests related to selection to
"fast/regions/selection/".
- fast/regions/selection/selecting-text-in-empty-region-expected.txt: Renamed from LayoutTests/fast/regions/selecting-text-in-empty-region-expected.txt.
- fast/regions/selection/selecting-text-in-empty-region.html: Renamed from LayoutTests/fast/regions/selecting-text-in-empty-region.html.
- fast/regions/selection/selecting-text-through-different-region-flows-2-expected.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows-2-expected.html.
- fast/regions/selection/selecting-text-through-different-region-flows-2.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows-2.html.
- fast/regions/selection/selecting-text-through-different-region-flows-expected.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows-expected.html.
- fast/regions/selection/selecting-text-through-different-region-flows.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows.html.
- fast/regions/selection/selection-direction-expected.html: Renamed from LayoutTests/fast/regions/selection-direction-expected.html.
- fast/regions/selection/selection-direction.html: Renamed from LayoutTests/fast/regions/selection-direction.html.
- platform/gtk-wk2/TestExpectations: Update path in skipped tests.
- platform/qt-wk2/TestExpectations: Ditto.
- 2:24 PM WebKitGTK/2.2.x edited by
- (diff)
- 2:23 PM Changeset in webkit [156795] by
-
- 79 edits11 deletes in trunk/Source/WebCore
Remove Qt from WebCore/platform.
<https://webkit.org/b/122228>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and FooBarQt.* files.
- 2:22 PM Changeset in webkit [156794] by
-
- 8 edits in trunk
The LLInt should not use JITStackFrame
https://bugs.webkit.org/show_bug.cgi?id=122231
Reviewed by Filip Pizlo.
Replaced uses of JITStackFrame::vm with code to either access the vm via the CodeBlock from
known JavaScript call frames or via the JSScope* for host call frames. This eliminates
all uses of JITStackFrame from the LLInt.
- heap/MarkedBlock.h: Made LLIntOffsetsExtractor a friend to access member offsets.
- heap/WeakSet.h: Made LLIntOffsetsExtractor a friend to access member offsets.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): Added an ASSERT for the newly added MarkedBlockMask
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 2:14 PM Changeset in webkit [156793] by
-
- 22 edits31 adds3 deletes in trunk
[mac] Stop using DrawingAreaImpl on PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=121859
<rdar://problem/15069359>
Reviewed by Anders Carlsson.
The Mac port will now use tiled drawing for all WebKit2 views.
- Shared/DrawingAreaInfo.h:
Don't include DrawingAreaTypeImpl as a valid DrawingAreaType on Mac.
- UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
Remove our implementation of drawRect that paints from DrawingAreaImpl's backing store.
(-[WKView _shouldUseTiledDrawingArea]):
Removed. Always treated as if it were true, now.
(-[WKView _createDrawingAreaProxy]):
Always create a TiledCoreAnimationDrawingAreaProxy now.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView wantsUpdateLayer]):
WKView always wants a layer, etc.
- UIProcess/BackingStore.h:
Remove Mac-specific BackingStore code, only used for DrawingAreaImpl on Mac.
- UIProcess/DrawingAreaProxy.h:
Remove an unneeded include.
- UIProcess/mac/BackingStoreMac.mm: Removed.
- WebKit2.xcodeproj/project.pbxproj:
Remove a bunch of files we don't need to build anymore.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
Never create a DrawingAreaImpl on Mac.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updatePreferences):
(WebKit::DrawingAreaImpl::resumePainting):
- WebProcess/WebPage/DrawingAreaImpl.h:
Remove Mac-specific DrawingAreaImpl code.
- WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
- WebProcess/WebPage/mac/LayerTreeHostMac.h: Removed.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: Removed.
- page/FrameView.cpp:
(WebCore::FrameView::addTrackedRepaintRect):
(WebCore::FrameView::repaintContentRectangle):
- page/FrameView.h:
Factor out the coordinate conversion and appending of new repaint rects on FrameView.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldDumpPropertyForLayer):
Don't dump repaint rects on the root tile cache, they'll be included at the top,
where FrameView's repaints are normally included.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
Push the root tile cache's tracked repaint rects to FrameView instead.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::shouldUseThreadedScrolling):
(WTR::updateThreadedScrollingForCurrentTest):
(WTR::TestInvocation::invoke):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
Rename the tiled drawing switch to threaded scrolling, since that's really
all it switches now that we use tiled drawing everywhere.
Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
and to more closely match the case we're interested in testing.
- platform/mac-wk2/TestExpectations:
- platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt: Added.
- platform/mac-wk2/compositing/contents-opaque/body-background-skipped-expected.txt: Added.
- platform/mac-wk2/compositing/rtl/rtl-absolute-expected.txt: Added.
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
Add WebKit2 results, because we dump non-white background color on the root layer now.
- platform/mac-wk2/compositing/repaint/fixed-background-scroll-expected.txt: Added.
New WebKit2 result; repaint rects are showing up now.
- platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
Slightly adjusted results.
- platform/mac-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
- platform/mac-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
- platform/mac-wk2/compositing/tiling/tile-cache-zoomed-expected.txt: Added.
- platform/mac-wk2/compositing/tiling/tiled-layer-resize-expected.txt: Added.
New WebKit2 results; we show the root tile cache if layerTreeAsText is asked to dump tile caches.
- platform/mac-wk2/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
- platform/mac-wk2/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
- platform/mac-wk2/fast/block/basic/020-expected.txt: Added.
- platform/mac-wk2/fast/dynamic/012-expected.txt: Added.
- platform/mac-wk2/fast/dynamic/layer-hit-test-crash-expected.txt: Added.
- platform/mac-wk2/fast/repaint/layer-hide-when-needs-layout-expected.txt: Added.
- platform/mac-wk2/fast/text/whitespace/028-expected.txt: Added.
- platform/mac-wk2/fast/layers/layer-visibility-expected.txt: Added.
- platform/mac-wk2/fast/layers/layer-visibility-sublayer-expected.txt: Added.
- platform/mac-wk2/fast/repaint/invisible-objects-expected.txt: Added.
New WebKit2 results; additional compositing layers.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
New test to ensure that window-server snapshots work with tiled drawing.
- 1:34 PM Changeset in webkit [156792] by
-
- 2 edits in trunk/Source/WTF
Eliminate a branch in FastBitVector setAndCheck, make it vectorizable.
https://bugs.webkit.org/show_bug.cgi?id=122229
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-02
Reviewed by Geoffrey Garen.
The CPU is unlikely to predict the branch in setAndCheck. I changed the code to use conditional instructions.
- wtf/FastBitVector.h:
(WTF::FastBitVector::setAndCheck):
- 1:34 PM Changeset in webkit [156791] by
-
- 13 edits9 adds in trunk
Implement Array key, value and entries iterators
https://bugs.webkit.org/show_bug.cgi?id=122195
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Add implementation of ES6 Array iterators for keys(), values() and entries()
Fairly self explanatory as we just need a simple implementation so that we can
implement and test other features.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/ArrayIteratorConstructor.cpp: Added.
(JSC::ArrayIteratorConstructor::finishCreation):
- runtime/ArrayIteratorConstructor.h: Added.
(JSC::ArrayIteratorConstructor::create):
(JSC::ArrayIteratorConstructor::createStructure):
(JSC::ArrayIteratorConstructor::ArrayIteratorConstructor):
- runtime/ArrayIteratorPrototype.cpp: Added.
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::createIteratorResult):
(JSC::arrayIteratorPrototypeNext):
- runtime/ArrayIteratorPrototype.h: Added.
(JSC::ArrayIteratorPrototype::create):
(JSC::ArrayIteratorPrototype::createStructure):
(JSC::ArrayIteratorPrototype::ArrayIteratorPrototype):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncValues):
(JSC::arrayProtoFuncEntries):
(JSC::arrayProtoFuncKeys):
- runtime/CommonIdentifiers.h:
- runtime/Identifier.h:
(JSC::Identifier::createEmptyUnique):
- runtime/JSArrayIterator.cpp: Added.
(JSC::JSArrayIterator::finishCreation):
- runtime/JSArrayIterator.h: Added.
(JSC::JSArrayIterator::createStructure):
(JSC::JSArrayIterator::create):
(JSC::JSArrayIterator::iterationKind):
(JSC::JSArrayIterator::iteratedObject):
(JSC::JSArrayIterator::nextIndex):
(JSC::JSArrayIterator::setNextIndex):
(JSC::JSArrayIterator::finish):
(JSC::JSArrayIterator::JSArrayIterator):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::iteratorResultStructure):
LayoutTests:
Add tests
- js/Object-getOwnPropertyNames-expected.txt:
- js/array-iterators-expected.txt: Added.
- js/array-iterators.html: Added.
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/array-iterators.js: Added.
- 1:31 PM Changeset in webkit [156790] by
-
- 1 edit in branches/safari-537.73-branch/LayoutTests/platform/mac-wk2/TestExpectations
Merge 156783.
- 1:16 PM Changeset in webkit [156789] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Unreviewed build fix.
- WebScriptWorld.cpp:
(WebScriptWorld::findOrCreateWorld):
- 12:55 PM Changeset in webkit [156788] by
-
- 6 edits in trunk/Source/WebCore
Clean up more <style scoped> from style resolution
https://bugs.webkit.org/show_bug.cgi?id=122188
Reviewed by Darin Adler.
- css/ElementRuleCollector.cpp:
(WebCore::MatchRequest::MatchRequest):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):
- css/ElementRuleCollector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):
- 12:38 PM Changeset in webkit [156787] by
-
- 2 edits in trunk/Source/JavaScriptCore
get_callee and to_this aren't properly cleared during finalizeUnconditionally
https://bugs.webkit.org/show_bug.cgi?id=122224
Reviewed by Geoffrey Garen.
Even though there is code to clear unmarked inline cache objects in finalizeUnconditionally,
it will never run because get_callee and to_this weren't added to the proper Vector in the
UnlinkedCodeBlock that is iterated during finalizeUnconditionally.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCreateThis):
- 12:16 PM Changeset in webkit [156786] by
-
- 2 edits1 move in trunk/Tools
Move AHEM.TTF from qt/fonts/ to fonts/.
Rubber-stamped by Andreas Kling.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/fonts/AHEM.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM.TTF.
- 12:11 PM Changeset in webkit [156785] by
-
- 19 edits12 adds in trunk
Implement prefixed-destructuring assignment
https://bugs.webkit.org/show_bug.cgi?id=121930
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
Relanding with fix after rollout - it helps to not completely destroy
optimisations for no reason.
LayoutTests:
Relanding with fix after rollout - it helps to not completely destroy
optimisations for no reason.
- 11:52 AM Changeset in webkit [156784] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: Refactor compileArithDiv and compileArithMod into one function.
https://bugs.webkit.org/show_bug.cgi?id=122205
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-02
Reviewed by Filip Pizlo.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAddSub):
(JSC::FTL::LowerDFGToLLVM::compileArithDivMod):
- 11:34 AM WebKitGTK/2.2.x edited by
- (diff)
- 11:29 AM Changeset in webkit [156783] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-wk2/TestExpectations
Update Test Expectations.
- 11:23 AM Changeset in webkit [156782] by
-
- 25 edits in trunk/Source/WebCore
Update bindings test results.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectOwner::finalize):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterOwner::finalize):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorOwner::finalize):
- bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetOwner::finalize):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionOwner::finalize):
- bindings/scripts/test/JS/JSTestException.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceOwner::finalize):
- bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerOwner::finalize):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorOwner::finalize):
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjOwner::finalize):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsOwner::finalize):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsOwner::finalize):
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- 11:20 AM Changeset in webkit [156781] by
-
- 1 edit263 deletes in trunk/Source/WebKit
Remove WebKit/qt.
Rubber-stamped by Andreas Kling.
- qt/Api/qhttpheader.cpp: Removed.
- qt/Api/qhttpheader_p.h: Removed.
- qt/Api/qwebdatabase.cpp: Removed.
- qt/Api/qwebdatabase.h: Removed.
- qt/Api/qwebdatabase_p.h: Removed.
- qt/Api/qwebelement.cpp: Removed.
- qt/Api/qwebelement.h: Removed.
- qt/Api/qwebelement_p.h: Removed.
- qt/Api/qwebhistory.cpp: Removed.
- qt/Api/qwebhistory.h: Removed.
- qt/Api/qwebhistory_p.h: Removed.
- qt/Api/qwebhistoryinterface.cpp: Removed.
- qt/Api/qwebhistoryinterface.h: Removed.
- qt/Api/qwebkitglobal.cpp: Removed.
- qt/Api/qwebkitglobal.h: Removed.
- qt/Api/qwebkitplatformplugin.h: Removed.
- qt/Api/qwebplugindatabase.cpp: Removed.
- qt/Api/qwebplugindatabase_p.h: Removed.
- qt/Api/qwebpluginfactory.cpp: Removed.
- qt/Api/qwebpluginfactory.h: Removed.
- qt/Api/qwebscriptworld.cpp: Removed.
- qt/Api/qwebscriptworld.h: Removed.
- qt/Api/qwebscriptworld_p.h: Removed.
- qt/Api/qwebsecurityorigin.cpp: Removed.
- qt/Api/qwebsecurityorigin.h: Removed.
- qt/Api/qwebsecurityorigin_p.h: Removed.
- qt/Api/qwebsettings.cpp: Removed.
- qt/Api/qwebsettings.h: Removed.
- qt/ChangeLog-2011-02-16: Removed.
- qt/WebCoreSupport/ChromeClientQt.cpp: Removed.
- qt/WebCoreSupport/ChromeClientQt.h: Removed.
- qt/WebCoreSupport/ContextMenuClientQt.cpp: Removed.
- qt/WebCoreSupport/ContextMenuClientQt.h: Removed.
- qt/WebCoreSupport/DragClientQt.cpp: Removed.
- qt/WebCoreSupport/DragClientQt.h: Removed.
- qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp: Removed.
- qt/WebCoreSupport/DumpRenderTreeSupportQt.h: Removed.
- qt/WebCoreSupport/EditorClientQt.cpp: Removed.
- qt/WebCoreSupport/EditorClientQt.h: Removed.
- qt/WebCoreSupport/FrameLoaderClientQt.cpp: Removed.
- qt/WebCoreSupport/FrameLoaderClientQt.h: Removed.
- qt/WebCoreSupport/FrameNetworkingContextQt.cpp: Removed.
- qt/WebCoreSupport/FrameNetworkingContextQt.h: Removed.
- qt/WebCoreSupport/FullScreenVideoQt.cpp: Removed.
- qt/WebCoreSupport/FullScreenVideoQt.h: Removed.
- qt/WebCoreSupport/GeolocationClientQt.cpp: Removed.
- qt/WebCoreSupport/GeolocationClientQt.h: Removed.
- qt/WebCoreSupport/GeolocationPermissionClientQt.cpp: Removed.
- qt/WebCoreSupport/GeolocationPermissionClientQt.h: Removed.
- qt/WebCoreSupport/IconDatabaseClientQt.cpp: Removed.
- qt/WebCoreSupport/IconDatabaseClientQt.h: Removed.
- qt/WebCoreSupport/InitWebCoreQt.cpp: Removed.
- qt/WebCoreSupport/InitWebCoreQt.h: Removed.
- qt/WebCoreSupport/InspectorClientQt.cpp: Removed.
- qt/WebCoreSupport/InspectorClientQt.h: Removed.
- qt/WebCoreSupport/InspectorServerQt.cpp: Removed.
- qt/WebCoreSupport/InspectorServerQt.h: Removed.
- qt/WebCoreSupport/NotificationPresenterClientQt.cpp: Removed.
- qt/WebCoreSupport/NotificationPresenterClientQt.h: Removed.
- qt/WebCoreSupport/PlatformStrategiesQt.cpp: Removed.
- qt/WebCoreSupport/PlatformStrategiesQt.h: Removed.
- qt/WebCoreSupport/PopupMenuQt.cpp: Removed.
- qt/WebCoreSupport/PopupMenuQt.h: Removed.
- qt/WebCoreSupport/QWebFrameAdapter.cpp: Removed.
- qt/WebCoreSupport/QWebFrameAdapter.h: Removed.
- qt/WebCoreSupport/QWebPageAdapter.cpp: Removed.
- qt/WebCoreSupport/QWebPageAdapter.h: Removed.
- qt/WebCoreSupport/QtPlatformPlugin.cpp: Removed.
- qt/WebCoreSupport/QtPlatformPlugin.h: Removed.
- qt/WebCoreSupport/QtPluginWidgetAdapter.cpp: Removed.
- qt/WebCoreSupport/QtPluginWidgetAdapter.h: Removed.
- qt/WebCoreSupport/QtPrintContext.cpp: Removed.
- qt/WebCoreSupport/QtPrintContext.h: Removed.
- qt/WebCoreSupport/SearchPopupMenuQt.cpp: Removed.
- qt/WebCoreSupport/SearchPopupMenuQt.h: Removed.
- qt/WebCoreSupport/TextCheckerClientQt.cpp: Removed.
- qt/WebCoreSupport/TextCheckerClientQt.h: Removed.
- qt/WebCoreSupport/TextureMapperLayerClientQt.cpp: Removed.
- qt/WebCoreSupport/TextureMapperLayerClientQt.h: Removed.
- qt/WebCoreSupport/UndoStepQt.cpp: Removed.
- qt/WebCoreSupport/UndoStepQt.h: Removed.
- qt/WebCoreSupport/WebEventConversion.cpp: Removed.
- qt/WebCoreSupport/WebEventConversion.h: Removed.
- qt/WidgetApi/qgraphicswebview.cpp: Removed.
- qt/WidgetApi/qgraphicswebview.h: Removed.
- qt/WidgetApi/qwebframe.cpp: Removed.
- qt/WidgetApi/qwebframe.h: Removed.
- qt/WidgetApi/qwebframe_p.h: Removed.
- qt/WidgetApi/qwebinspector.cpp: Removed.
- qt/WidgetApi/qwebinspector.h: Removed.
- qt/WidgetApi/qwebinspector_p.h: Removed.
- qt/WidgetApi/qwebpage.cpp: Removed.
- qt/WidgetApi/qwebpage.h: Removed.
- qt/WidgetApi/qwebpage_p.h: Removed.
- qt/WidgetApi/qwebview.cpp: Removed.
- qt/WidgetApi/qwebview.h: Removed.
- qt/WidgetApi/qwebviewaccessible.cpp: Removed.
- qt/WidgetApi/qwebviewaccessible_p.h: Removed.
- qt/WidgetSupport/DefaultFullScreenVideoHandler.cpp: Removed.
- qt/WidgetSupport/DefaultFullScreenVideoHandler.h: Removed.
- qt/WidgetSupport/FullScreenVideoWidget.cpp: Removed.
- qt/WidgetSupport/FullScreenVideoWidget.h: Removed.
- qt/WidgetSupport/InitWebKitQt.cpp: Removed.
- qt/WidgetSupport/InitWebKitQt.h: Removed.
- qt/WidgetSupport/InspectorClientWebPage.cpp: Removed.
- qt/WidgetSupport/InspectorClientWebPage.h: Removed.
- qt/WidgetSupport/PageClientQt.cpp: Removed.
- qt/WidgetSupport/PageClientQt.h: Removed.
- qt/WidgetSupport/QGraphicsWidgetPluginImpl.cpp: Removed.
- qt/WidgetSupport/QGraphicsWidgetPluginImpl.h: Removed.
- qt/WidgetSupport/QStyleFacadeImp.cpp: Removed.
- qt/WidgetSupport/QStyleFacadeImp.h: Removed.
- qt/WidgetSupport/QWebUndoCommand.cpp: Removed.
- qt/WidgetSupport/QWebUndoCommand.h: Removed.
- qt/WidgetSupport/QWidgetPluginImpl.cpp: Removed.
- qt/WidgetSupport/QWidgetPluginImpl.h: Removed.
- qt/WidgetSupport/QtFallbackWebPopup.cpp: Removed.
- qt/WidgetSupport/QtFallbackWebPopup.h: Removed.
- qt/WidgetSupport/QtWebComboBox.cpp: Removed.
- qt/WidgetSupport/QtWebComboBox.h: Removed.
- qt/declarative/declarative.pro: Removed.
- qt/declarative/experimental/experimental.pri: Removed.
- qt/declarative/experimental/plugin.cpp: Removed.
- qt/declarative/experimental/plugin.json: Removed.
- qt/declarative/experimental/qmldir: Removed.
- qt/declarative/plugin.cpp: Removed.
- qt/declarative/plugin.json: Removed.
- qt/declarative/plugins.qmltypes: Removed.
- qt/declarative/public.pri: Removed.
- qt/declarative/qmldir: Removed.
- qt/docs/qtwebkit-bridge.qdoc: Removed.
- qt/docs/qtwebkit-goes-mobile.qdoc: Removed.
- qt/docs/qtwebkit.qdoc: Removed.
- qt/docs/qwebview-diagram.png: Removed.
- qt/docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: Removed.
- qt/docs/webkitsnippets/qtwebkit_build_snippet.qdoc: Removed.
- qt/docs/webkitsnippets/qtwebkit_goes_mobile_snippets.cpp: Removed.
- qt/docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp: Removed.
- qt/docs/webkitsnippets/qtwebkit_qwebview_snippet.cpp: Removed.
- qt/docs/webkitsnippets/simple/main.cpp: Removed.
- qt/docs/webkitsnippets/simple/simple.pro: Removed.
- qt/docs/webkitsnippets/webelement/main.cpp: Removed.
- qt/docs/webkitsnippets/webelement/webelement.pro: Removed.
- qt/docs/webkitsnippets/webpage/main.cpp: Removed.
- qt/docs/webkitsnippets/webpage/webpage.pro: Removed.
- qt/examples/examples.pro: Removed.
- qt/examples/platformplugin/README: Removed.
- qt/examples/platformplugin/WebNotificationPresenter.cpp: Removed.
- qt/examples/platformplugin/WebNotificationPresenter.h: Removed.
- qt/examples/platformplugin/WebPlugin.cpp: Removed.
- qt/examples/platformplugin/WebPlugin.h: Removed.
- qt/examples/platformplugin/platformplugin.pro: Removed.
- qt/examples/platformplugin/qwebkitplatformplugin.h: Removed.
- qt/tests/MIMESniffing/MIMESniffing.pro: Removed.
- qt/tests/MIMESniffing/TestData.h: Removed.
- qt/tests/MIMESniffing/resources.qrc: Removed.
- qt/tests/MIMESniffing/resources/application_atom+xml: Removed.
- qt/tests/MIMESniffing/resources/application_ogg: Removed.
- qt/tests/MIMESniffing/resources/application_pdf: Removed.
- qt/tests/MIMESniffing/resources/application_postscript: Removed.
- qt/tests/MIMESniffing/resources/application_rdf+xml: Removed.
- qt/tests/MIMESniffing/resources/application_rss+xml: Removed.
- qt/tests/MIMESniffing/resources/application_x-gzip: Removed.
- qt/tests/MIMESniffing/resources/application_x-rar-compressed: Removed.
- qt/tests/MIMESniffing/resources/application_zip: Removed.
- qt/tests/MIMESniffing/resources/audio_x-wave: Removed.
- qt/tests/MIMESniffing/resources/image_bmp: Removed.
- qt/tests/MIMESniffing/resources/image_gif: Removed.
- qt/tests/MIMESniffing/resources/image_jpeg: Removed.
- qt/tests/MIMESniffing/resources/image_png: Removed.
- qt/tests/MIMESniffing/resources/image_vnd.microsoft.icon: Removed.
- qt/tests/MIMESniffing/resources/image_webp: Removed.
- qt/tests/MIMESniffing/resources/text_html: Removed.
- qt/tests/MIMESniffing/resources/text_xml: Removed.
- qt/tests/MIMESniffing/resources/video_webm: Removed.
- qt/tests/MIMESniffing/tst_MIMESniffing.cpp: Removed.
- qt/tests/benchmarks/loading/loading.pro: Removed.
- qt/tests/benchmarks/loading/tst_loading.cpp: Removed.
- qt/tests/benchmarks/painting/painting.pro: Removed.
- qt/tests/benchmarks/painting/tst_painting.cpp: Removed.
- qt/tests/benchmarks/webgl/10000_triangles.html: Removed.
- qt/tests/benchmarks/webgl/tst_webgl.cpp: Removed.
- qt/tests/benchmarks/webgl/tst_webgl.qrc: Removed.
- qt/tests/benchmarks/webgl/webgl.pro: Removed.
- qt/tests/cmake/CMakeLists.txt: Removed.
- qt/tests/cmake/cmake.pro: Removed.
- qt/tests/hybridPixmap/hybridPixmap.pro: Removed.
- qt/tests/hybridPixmap/resources.qrc: Removed.
- qt/tests/hybridPixmap/test.html: Removed.
- qt/tests/hybridPixmap/tst_hybridPixmap.cpp: Removed.
- qt/tests/hybridPixmap/widget.cpp: Removed.
- qt/tests/hybridPixmap/widget.h: Removed.
- qt/tests/hybridPixmap/widget.ui: Removed.
- qt/tests/qgraphicswebview/qgraphicswebview.pro: Removed.
- qt/tests/qgraphicswebview/resources/greendiv.html: Removed.
- qt/tests/qgraphicswebview/resources/input_types.html: Removed.
- qt/tests/qgraphicswebview/resources/pointing_right.html: Removed.
- qt/tests/qgraphicswebview/resources/pointing_up.html: Removed.
- qt/tests/qgraphicswebview/resources/scrolltest_page.html: Removed.
- qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp: Removed.
- qt/tests/qgraphicswebview/tst_qgraphicswebview.qrc: Removed.
- qt/tests/qobjectbridge/qobjectbridge.pro: Removed.
- qt/tests/qobjectbridge/tst_qobjectbridge.cpp: Removed.
- qt/tests/qwebelement/qwebelement.pro: Removed.
- qt/tests/qwebelement/resources/image.png: Removed.
- qt/tests/qwebelement/resources/style.css: Removed.
- qt/tests/qwebelement/resources/style2.css: Removed.
- qt/tests/qwebelement/tst_qwebelement.cpp: Removed.
- qt/tests/qwebelement/tst_qwebelement.qrc: Removed.
- qt/tests/qwebframe/qwebframe.pro: Removed.
- qt/tests/qwebframe/resources/image.png: Removed.
- qt/tests/qwebframe/resources/style.css: Removed.
- qt/tests/qwebframe/resources/test1.html: Removed.
- qt/tests/qwebframe/resources/test2.html: Removed.
- qt/tests/qwebframe/resources/testiframe.html: Removed.
- qt/tests/qwebframe/resources/testiframe2.html: Removed.
- qt/tests/qwebframe/tst_qwebframe.cpp: Removed.
- qt/tests/qwebframe/tst_qwebframe.qrc: Removed.
- qt/tests/qwebhistory/qwebhistory.pro: Removed.
- qt/tests/qwebhistory/resources/page1.html: Removed.
- qt/tests/qwebhistory/resources/page2.html: Removed.
- qt/tests/qwebhistory/resources/page3.html: Removed.
- qt/tests/qwebhistory/resources/page4.html: Removed.
- qt/tests/qwebhistory/resources/page5.html: Removed.
- qt/tests/qwebhistory/resources/page6.html: Removed.
- qt/tests/qwebhistory/tst_qwebhistory.cpp: Removed.
- qt/tests/qwebhistory/tst_qwebhistory.qrc: Removed.
- qt/tests/qwebhistoryinterface/qwebhistoryinterface.pro: Removed.
- qt/tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp: Removed.
- qt/tests/qwebinspector/qwebinspector.pro: Removed.
- qt/tests/qwebinspector/tst_qwebinspector.cpp: Removed.
- qt/tests/qwebpage/qwebpage.pro: Removed.
- qt/tests/qwebpage/resources/content.html: Removed.
- qt/tests/qwebpage/resources/frame_a.html: Removed.
- qt/tests/qwebpage/resources/frame_c.html: Removed.
- qt/tests/qwebpage/resources/framedindex.html: Removed.
- qt/tests/qwebpage/resources/iframe.html: Removed.
- qt/tests/qwebpage/resources/iframe2.html: Removed.
- qt/tests/qwebpage/resources/iframe3.html: Removed.
- qt/tests/qwebpage/resources/index.html: Removed.
- qt/tests/qwebpage/resources/script.html: Removed.
- qt/tests/qwebpage/resources/user.css: Removed.
- qt/tests/qwebpage/tst_qwebpage.cpp: Removed.
- qt/tests/qwebpage/tst_qwebpage.qrc: Removed.
- qt/tests/qwebplugindatabase/qwebplugindatabase.pro: Removed.
- qt/tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: Removed.
- qt/tests/qwebsecurityorigin/qwebsecurityorigin.pro: Removed.
- qt/tests/qwebsecurityorigin/resources/test.html: Removed.
- qt/tests/qwebsecurityorigin/tst_qwebsecurityorigin.cpp: Removed.
- qt/tests/qwebsecurityorigin/tst_qwebsecurityorigin.qrc: Removed.
- qt/tests/qwebview/.gitignore: Removed.
- qt/tests/qwebview/qwebview.pro: Removed.
- qt/tests/qwebview/resources/frame_a.html: Removed.
- qt/tests/qwebview/resources/index.html: Removed.
- qt/tests/qwebview/resources/input_types.html: Removed.
- qt/tests/qwebview/resources/scrolltest_page.html: Removed.
- qt/tests/qwebview/tst_qwebview.cpp: Removed.
- qt/tests/qwebview/tst_qwebview.qrc: Removed.
- qt/tests/resources/image2.png: Removed.
- qt/tests/resources/test.swf: Removed.
- qt/tests/tests.pri: Removed.
- qt/tests/util.h: Removed.
- 11:17 AM Changeset in webkit [156780] by
-
- 17 edits9 deletes in trunk/Source/JavaScriptCore
Get rid of Qt code from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=122223
Reviewed by Oliver Hunt.
- API/JSStringRefQt.cpp: Removed.
- API/JSStringRefQt.h: Removed.
- API/OpaqueJSString.h:
- DerivedSources.pri: Removed.
- JavaScriptCore.pri: Removed.
- JavaScriptCore.pro: Removed.
- LLIntOffsetsExtractor.pro: Removed.
- Target.pri: Removed.
- assembler/AbstractMacroAssembler.h:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::urshift32):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::shouldBlindForSpecificArch):
- assembler/MacroAssemblerX86Common.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithSub):
- heap/HeapTimer.cpp:
(JSC::HeapTimer::timerEvent):
- heap/HeapTimer.h:
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::scheduleTimer):
- heap/IncrementalSweeper.h:
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitSub32Constant):
- jsc.cpp:
(main):
- jsc.pro: Removed.
- runtime/DateConstructor.cpp:
- runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::cancelTimer):
- runtime/GCActivityCallback.h:
- testRegExp.cpp:
(main):
- yarr/yarr.pri: Removed.
- 11:08 AM Changeset in webkit [156779] by
-
- 5 edits1 delete in trunk/Source/WebCore
Remove Qt-specific code in WebCore/{rendering,editing,history}.
<https://webkit.org/b/122220>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and FooBarQt.* files.
- 11:07 AM Changeset in webkit [156778] by
-
- 12 edits in trunk/Source/WebCore
Remove Qt-specific code in common WebCore/{html,dom} files.
<https://webkit.org/b/122219>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks.
- 11:06 AM Changeset in webkit [156777] by
-
- 2 edits in trunk/LayoutTests
video-object-fit tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=121803
- platform/mac/TestExpectations: Marking as such.
- 11:06 AM Changeset in webkit [156776] by
-
- 2 edits in trunk/Source/WebKit2
Fix the Mac WebKit2 build following <http://trac.webkit.org/changeset/139241>
(https://bugs.webkit.org/show_bug.cgi?id=104197)
WebContextMac.mm fails to compile when building with network process disabled.
The constants WebKit2HTTPProxyDefaultsKey and WebKit2HTTPSProxyDefaultsKey,
defined in WebContextMac.mm, should only be defined when building with the
network process enabled as these constants are only referenced from
ENABLE(NETWORK_PROCESS)-guard code.
- UIProcess/mac/WebContextMac.mm:
- 11:03 AM Changeset in webkit [156775] by
-
- 11 edits3 deletes in trunk/Source/WTF
Remove Qt code from WTF
https://bugs.webkit.org/show_bug.cgi?id=122221
Reviewed by Antti Koivisto.
I'm keeping the PLATFORM(QT) defines in Platform.h for now so we can assess if there are any
Qt only features that we can remove later.
- WTF.pri: Removed.
- WTF.pro: Removed.
- wtf/Assertions.cpp:
- wtf/CurrentTime.cpp:
- wtf/DisallowCType.h:
- wtf/FastMalloc.cpp:
- wtf/FeatureDefines.h:
- wtf/qt/MainThreadQt.cpp: Removed.
- wtf/qt/StringQt.cpp: Removed.
- wtf/text/AtomicString.h:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
- wtf/text/StringImpl.h:
- wtf/text/WTFString.cpp:
(WTF::String::format):
- wtf/text/WTFString.h:
- 11:02 AM Changeset in webkit [156774] by
-
- 2 edits in trunk/LayoutTests
Quirksmode: CSS1: WebKit fails dynamic :first-letter test
https://bugs.webkit.org/show_bug.cgi?id=15602
- platform/mac/TestExpectations: Correcting Mac expectations too, now that we have results.
- 11:00 AM Changeset in webkit [156773] by
-
- 3 edits2 adds in trunk/LayoutTests
Quirksmode: CSS1: WebKit fails dynamic :first-letter test
https://bugs.webkit.org/show_bug.cgi?id=15602
- platform/mac/fast/css/first-letter-block-change-expected.png: Added.
- platform/mac/fast/css/first-letter-block-change-expected.txt: Added.
Added expected results for Mac.
- platform/efl/TestExpectations: Corrected the expectation. This test is not
failing, it has no results.
- 10:26 AM Changeset in webkit [156772] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/templates/root.html
remove Qt from the main buildbot page.
- 10:16 AM Changeset in webkit [156771] by
-
- 4 edits in trunk/Tools
Remove Qt bots and EWS from trunk.
https://bugs.webkit.org/show_bug.cgi?id=122210.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2013-10-02
Reviewed by Allan Sandfeld Jensen.
Remove Qt buil dbots.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
(RunGtkAPITests.getText2):
(Factory.init):
(TestFactory.init):
(BuildAndTestFactory.init):
(loadBuilderConfig):
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- 10:13 AM Changeset in webkit [156770] by
-
- 3 edits in trunk/Tools
Remove Qt bots and EWS from trunk.
https://bugs.webkit.org/show_bug.cgi?id=122210.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2013-10-02
Reviewed by Allan Sandfeld Jensen.
Remove Qt EWS bots.
- QueueStatusServer/config/queues.py:
- Scripts/webkitpy/common/config/ews.json:
- 10:03 AM Changeset in webkit [156769] by
-
- 94 edits in trunk/Source
CTTE: DOMWrapperWorlds should be passed around by reference
https://bugs.webkit.org/show_bug.cgi?id=122206
Reviewed by Andreas Kling.
../WebCore:
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::clearWrappers):
(WebCore::normalWorld):
(WebCore::mainThreadNormalWorld):
- bindings/js/DOMWrapperWorld.h:
(WebCore::debuggerWorld):
(WebCore::pluginWorld):
(WebCore::currentWorld):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::JSCSSValueOwner::finalize):
- bindings/js/JSDOMBinding.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::getInlineCachedWrapper):
(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper):
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper):
(WebCore::uncacheWrapper):
(WebCore::jsStringWithCache):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
(WebCore::toJSDOMGlobalObject):
- bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::world):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::toJSDOMWindow):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::toJSDOMWindowShell):
- bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::create):
(WebCore::JSDOMWindowShell::world):
- bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::JSErrorHandler):
- bindings/js/JSErrorHandler.h:
(WebCore::JSErrorHandler::create):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create):
(WebCore::JSEventListener::isolatedWorld):
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::getJSListenerFunctions):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
- bindings/js/JSLazyEventListener.h:
- bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::JSMutationCallback):
(WebCore::JSMutationCallback::call):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::finalize):
- bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
(WebCore::ScheduledAction::ScheduledAction):
- bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
- bindings/js/ScriptCachedFrameData.h:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::destroyWindowShell):
(WebCore::ScriptController::createWindowShell):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::getAllWorlds):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::executeScriptInWorld):
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
- bindings/js/ScriptController.h:
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::globalObject):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::isContentScript):
- bindings/js/ScriptState.cpp:
(WebCore::execStateFromNode):
(WebCore::execStateFromPage):
- bindings/js/ScriptState.h:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
- bindings/js/WebCoreJSClientData.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::getAllWorlds):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):
- bindings/js/WebCoreTypedArrayController.cpp:
(WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- dom/Document.cpp:
(WebCore::Document::ensurePlugInsInjectedScript):
- dom/Document.h:
- dom/DocumentStyleSheetCollection.cpp:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::ensureIsolatedWorld):
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
- html/HTMLMediaElement.h:
- html/HTMLPlugInImageElement.cpp:
(WebCore::plugInImageElementIsolatedWorld):
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
- inspector/InspectorAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::didClearWindowObjectInWorld):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
- inspector/InspectorPageAgent.h:
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoader::dispatchGlobalObjectAvailableInAllWorlds):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchGlobalObjectAvailable):
- page/CaptionUserPreferencesMediaAF.cpp:
- page/DOMWindowExtension.cpp:
(WebCore::DOMWindowExtension::DOMWindowExtension):
- page/DOMWindowExtension.h:
(WebCore::DOMWindowExtension::create):
(WebCore::DOMWindowExtension::world):
- page/Frame.cpp:
(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptsForWorld):
- page/Frame.h:
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
- page/PageGroup.h:
../WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientEfl.h:
../WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientGtk.h:
../WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
(WebKit::NetscapePluginInstanceProxy::evaluate):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
(-[WebFrame _globalContextForScriptWorld:]):
(-[WebFrame jsWrapperForNode:inScriptWorld:]):
- WebView/WebScriptWorld.mm:
(+[WebScriptWorld standardWorld]):
(+[WebScriptWorld findOrCreateWorld:]):
- WebView/WebScriptWorldInternal.h:
- WebView/WebView.mm:
(-[WebView _injectOutlookQuirksScript]):
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
../WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebScriptWorld.cpp:
(WebScriptWorld::standardWorld):
(WebScriptWorld::findOrCreateWorld):
- WebScriptWorld.h:
(WebScriptWorld::world):
../WebKit/wince:
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientWinCE.h:
../WebKit2:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
(WebKit::InjectedBundleScriptWorld::getOrCreate):
(WebKit::InjectedBundleScriptWorld::normalWorld):
(WebKit::InjectedBundleScriptWorld::coreWorld):
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 9:43 AM Changeset in webkit [156768] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, removing references to the recently removed Modules/filesystem directory.
- GNUmakefile.am:
- 8:10 AM WebKitGTK/2.2.x edited by
- propose r156003 for 2.2.1 (diff)
- 6:07 AM Changeset in webkit [156767] by
-
- 47 edits5 copies103 deletes in trunk
[CSS Regions] Activate all regions to have layers, as CSS Regions create a new stacking context
https://bugs.webkit.org/show_bug.cgi?id=121828
Patch by Mihai Maerean <Mihai Maerean> on 2013-10-02
Reviewed by Darin Adler.
Source/WebCore:
The CSS Regions specification says "CSS Regions create a new stacking context." (http://dev.w3.org/csswg/css-regions/).
Divs that create stacking contexts are painted after the divs that don't create stacking contexts.
Test: fast/regions/layers/stacking-context-paint-order.html: While the existing region-sibling-paint-order.html
test verifies that regions paint correctly when the next sibling also creates a stacking context, this new test
verifies that regions paint correctly when the next sibling doesn't create a stacking context.
- rendering/RenderBlock.cpp: Remove code that is not needed now that all regions have layers.
- rendering/RenderBlock.h: Remove code that is not needed now that all regions have layers.
- rendering/RenderBox.cpp: Remove code that is not needed now that all regions have layers.
- rendering/RenderBox.h: Remove code that is not needed now that all regions have layers.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Remove code that is not needed now that all regions have layers.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
- rendering/RenderRegion.h:
(WebCore::RenderRegion::requiresLayer): Always. CSS Regions create Stacking Contexts. RenderMultiColumnSet
implements its own behaviour so the behaviour of each class is contained within its own files.
- rendering/RenderMultiColumnSet.h:
(WebCore::RenderMultiColumnSet::requiresLayer): RenderMultiColumnSet derives from RenderRegion, but unlike the
CSS Regions specification, the Multi-Columns CSS specification states that the column boxes do not establish new
Stacking Contexts.
- rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderRegionList): There's no need to output " hasLayer" since all regions now have layers.
LayoutTests:
For the ref tests, the divs in the expected results coresponding to the regions now have a CSS style causing
them to also create Stacking Contexts.
Most of the tests in fast/regions/layers/ have been deleted because they aren't relevant anymore.
The change in most of the *-expected.txt files is that the " hasLayer" part has been removed (since all regions
now have layers).
Platform (efl, efl-wk2, gtk, mac-lion, mac-wk2, qt, qt-wk2) specific expectated results need to be generated again.
- fast/regions/autoheight-regions-mark-expected.txt:
- fast/regions/flow-content-basic-expected.html: Added. The test is now a ref test.
- fast/regions/flow-content-basic-vertical-expected.html: Added. The test is now a ref test.
- fast/regions/flow-content-basic-vertical-rl-expected.html: Added.The test is now a ref test.
- fast/regions/flow-content-basic-vertical-rl.html:
- fast/regions/flow-content-basic-vertical.html:
- fast/regions/flow-content-basic.html:
- fast/regions/flows-dependency-dynamic-remove-expected.txt:
- fast/regions/flows-dependency-same-flow-expected.txt:
- fast/regions/layers/dynamic-layer-added-with-no-layout-expected.png: Removed.
- fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Removed.
- fast/regions/layers/dynamic-layer-added-with-no-layout.html: Removed.
- fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.png: Removed.
- fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Removed.
- fast/regions/layers/dynamic-layer-removed-with-no-layout.html: Removed.
- fast/regions/layers/regions-promoted-to-layers-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt.html: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr.html: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl.html: Removed.
- fast/regions/layers/regions-promoted-to-layers.html: Removed.
- fast/regions/layers/stacking-context-paint-order-expected.html: Added.
- fast/regions/layers/stacking-context-paint-order.html: Added. While the existing region-sibling-paint-order.html
test verifies that regions paint correctly when the next sibling also creates a stacking context, this new test
verifies that regions paint correctly when the next sibling doesn't create a stacking context.
- fast/regions/region-sibling-paint-order-expected.html:
- fast/regions/region-sibling-paint-order.html:
- fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
- fast/repaint/region-painting-composited-element-expected.html:
- fast/repaint/region-painting-in-composited-view-expected.html:
- fast/repaint/region-painting-in-composited-view.html:
- fast/repaint/region-painting-via-layout-expected.txt:
- platform/efl-wk2/TestExpectations:
- platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/efl/TestExpectations:
- platform/efl/fast/regions/autoheight-regions-mark-expected.png: Removed.
- platform/efl/fast/regions/autoheight-regions-mark-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-expected.png: Removed. The test is now a ref test.
- platform/efl/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/region-dynamic-after-before-expected.txt:
- platform/efl/fast/regions/region-generated-content-before-after-expected.txt:
- platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/efl/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/efl/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/efl/fast/repaint/region-painting-via-layout-expected.txt: Removed.
- platform/gtk/TestExpectations:
- platform/gtk/fast/regions/autoheight-regions-mark-expected.png: Removed.
- platform/gtk/fast/regions/autoheight-regions-mark-expected.txt: Removed.
- platform/gtk/fast/regions/flow-content-basic-expected.png: Removed.
- platform/gtk/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
- platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/gtk/fast/regions/region-dynamic-after-before-expected.txt:
- platform/gtk/fast/regions/region-generated-content-before-after-expected.txt:
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
- platform/gtk/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/gtk/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/gtk/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/gtk/fast/repaint/region-painting-via-layout-expected.txt: Removed.
- platform/mac-lion/TestExpectations:
- platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/mac-wk2/TestExpectations:
- platform/mac/fast/regions/flow-content-basic-expected.png: Removed.
- platform/mac/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
- platform/mac/fast/regions/region-dynamic-after-before-expected.txt:
- platform/mac/fast/regions/region-generated-content-before-after-expected.txt:
- platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
- platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/mac/fast/repaint/region-painting-invalidation-expected.txt:
- platform/qt-wk2/TestExpectations:
- platform/qt-wk2/fast/regions/flow-content-basic-expected.png: Removed.
- platform/qt-wk2/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/qt-wk2/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/qt-wk2/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/qt-wk2/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/qt-wk2/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/qt-wk2/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/qt-wk2/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/qt-wk2/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/qt/TestExpectations:
- platform/qt/fast/regions/autoheight-regions-mark-expected.png: Removed.
- platform/qt/fast/regions/autoheight-regions-mark-expected.txt: Removed.
- platform/qt/fast/regions/flow-content-basic-expected.png: Removed.
- platform/qt/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
- platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/qt/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/qt/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/qt/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
- platform/qt/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/qt/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/qt/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/qt/fast/repaint/region-painting-via-layout-expected.txt: Removed.
- platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- 3:14 AM Changeset in webkit [156766] by
-
- 4 edits2 adds in trunk
HTML listbox is not resized horizontally when zooming
https://bugs.webkit.org/show_bug.cgi?id=20445
Reviewed by Darin Adler.
Source/WebCore:
If any style changes happens on a HTMLSelectElement, we need to set the m_optionsChanged property
of its renderer (RenderListBox) otherwise its size won't follow the changed content.
Test: fast/transforms/listbox-zoom.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::didRecalcStyle):
- html/HTMLSelectElement.h:
LayoutTests:
A test with a zoomed listbox is added to check whether the styleChange is catched.
- fast/transforms/listbox-zoom.html: Added.
- fast/transforms/listbox-zoom-expected.txt: Added.
- 2:32 AM Changeset in webkit [156765] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: highlight newly added console messages in the Activity Viewer
https://bugs.webkit.org/show_bug.cgi?id=122093
Reviewed by Joseph Pecoraro.
Fade the appropriate console log button in the Activity Viewer for a short duration
to call attention to it when its count is incremented. The animation may be restarted
in-flight if the count is incremented as we were pulsing the opacity.
- UserInterface/DashboardView.css:
(.toolbar .dashboard > .item.pulsing):
(@-webkit-keyframes console-item-pulse):
New pulse animation for a console item in the Activity Viewer, the new "pulsing" CSS
class is applied in WebInspector.DashboardView.prototype._setConsoleItemValue().
- UserInterface/DashboardView.js:
(WebInspector.DashboardView.prototype.set logs):
(WebInspector.DashboardView.prototype.set issues):
(WebInspector.DashboardView.prototype.set errors):
Refactor setters to use the new WebInspector.DashboardView.prototype._setConsoleItemValue()
method.
(WebInspector.DashboardView.prototype._setConsoleItemValue):
We now set the ivar backing console item values in this new refactored method and additionally
apply an animation to the DOM element for the given item if its value is incremented such that
it pulses, subtly calling out the developer's attention to it.
- UserInterface/Utilities.js:
New Element.prototype.recalculateStyles() method to abstract the hack required to force
a style recalc on a given element.
Oct 1, 2013:
- 10:11 PM Changeset in webkit [156764] by
-
- 4 edits2 adds in trunk
contenteditable justify commands applied to next paragraph as well
https://bugs.webkit.org/show_bug.cgi?id=90611
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-01
Reviewed by Ryosuke Niwa.
Source/WebCore:
When the selection extends from first paragraph to start of next
paragraph then Justify command is applied to both the paragraph,
Instead it should be applied only to first paragraph.
Co-author: Sudarshan C P <sudarshan.cp@samsung.com>
Test: editing/execCommand/contenteditable-justify-next-paragraph.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
Adjusted visibleEnd to previous position.
LayoutTests:
Added a test for selecting one paragraph and the beginning of another
paragraph to ensure that only the first fully-selected paragraph should
be justified when justifying the selection.
- editing/execCommand/align-in-span-expected.txt: Updated.
- editing/execCommand/contenteditable-justify-next-paragraph-expected.txt: Added.
- editing/execCommand/contenteditable-justify-next-paragraph.html: Added.
- 10:01 PM Changeset in webkit [156763] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: media/media-element-play-after-eos.html
https://bugs.webkit.org/show_bug.cgi?id=115048
- platform/mac/TestExpectations: Marking as such.
- 9:25 PM Changeset in webkit [156762] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations
Rollout r156759.
- 9:20 PM Changeset in webkit [156761] by
-
- 15 edits in trunk/Source
Move mouse event dispatch from Node to Element.
<https://webkit.org/b/122203>
Reviewed by Anders Carlsson.
We never dispatch mouse events on text or other non-element nodes,
so move the related logic to using Element.
Node::dispatchMouseEvent() moves to Element. I also changed the
relatedTarget argument to be an Element* since the related target
is never a Node either.
Most of this patch is *Node -> *Element renames in EventHandler.
- 9:17 PM Changeset in webkit [156760] by
-
- 22 edits in trunk/Source/WebCore
Generate toCSSFooValue for CSS child values
https://bugs.webkit.org/show_bug.cgi?id=122157
Reviewed by Darin Adler.
As a step to cleanup static_cast<> for CSSFooValue, this patch adds toCSSFooValue()
for "CSSAspectRatioValue, CSSBorderImageSliceValue, CSSFunctionValue, CSSInheritedValue,
CSSValueList, CSSVariableValue, and CSSFontFaceSrcValue".
To use CSS_VALUE_TYPE_CASTS, isFunctionValue(), isFontFaceSrcValue() are added to
generate toCSSFunctionValue, toCSSFontFaceSrcValue().
No new tests, no behavior changes.
- css/CSSAspectRatioValue.h:
- css/CSSBorderImageSliceValue.h:
- css/CSSFontFaceSrcValue.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSFunctionValue.h:
- css/CSSInheritedValue.h:
- css/CSSParser.cpp:
(WebCore::filterProperties):
(WebCore::CSSParser::addFillValue):
(WebCore::CSSParser::addAnimationValue):
(WebCore::CSSParser::createFontFaceRule):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::wrapValueInCommaSeparatedList):
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapNinePieceImage):
(WebCore::CSSToStyleMap::mapNinePieceImageSlice):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isFunctionValue):
(WebCore::CSSValue::isFontFaceSrcValue):
- css/CSSValueList.h:
(WebCore::CSSValueListInspector::CSSValueListInspector):
- css/CSSVariableValue.h:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- css/MediaQueryEvaluator.cpp:
(WebCore::compareAspectRatioValue):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
- editing/EditingStyle.cpp:
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(WebCore::EditingStyle::mergeStyle):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
- editing/EditorCommand.cpp:
(WebCore::executeToggleStyleInList):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace):
- 8:28 PM Changeset in webkit [156759] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations
Update TestExpectations.
- 7:22 PM Changeset in webkit [156758] by
-
- 5 edits in trunk
FTL should use the new version of LLVM MCJIT memory manager APIs that take a SectionName
https://bugs.webkit.org/show_bug.cgi?id=122193
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Update our usage of the LLVM C API since the API is about to change.
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateCodeSection):
(JSC::FTL::mmAllocateDataSection):
WebKitLibraries:
Reviewed by Geoffrey Garen.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 7:19 PM Changeset in webkit [156757] by
-
- 19 edits12 deletes in trunk
REGRESSION(156464): 50% regression on SunSpider/string-fasta
https://bugs.webkit.org/show_bug.cgi?id=122202
Source/JavaScriptCore:
Unreviewed, roll out r156464.
This is a progression on string-fasta, since it fixes the regression.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::paramString):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitExpressionInfo):
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::FuncExprNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::addVar):
- parser/NodeConstructors.h:
(JSC::CommaNode::CommaNode):
(JSC::ParameterNode::ParameterNode):
(JSC::ForInNode::ForInNode):
- parser/Nodes.cpp:
(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):
- parser/Nodes.h:
(JSC::ExpressionNode::isDotAccessorNode):
(JSC::CommaNode::append):
(JSC::ParameterNode::ident):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::identifiers):
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseFormalParameters):
(JSC::::parseAssignmentExpression):
- parser/Parser.h:
(JSC::Scope::declareParameter):
(JSC::Parser::declareParameter):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::operatorStackPop):
- runtime/JSONObject.cpp:
- runtime/JSONObject.h:
LayoutTests:
Unreviewed, roll out r156464.
- js/destructuring-assignment-expected.txt: Removed.
- js/destructuring-assignment.html: Removed.
- js/mozilla/strict/13.1-expected.txt:
- js/mozilla/strict/regress-532254-expected.txt:
- js/mozilla/strict/script-tests/13.1.js:
- js/regress/destructuring-arguments-expected.txt: Removed.
- js/regress/destructuring-arguments-length-expected.txt: Removed.
- js/regress/destructuring-arguments-length.html: Removed.
- js/regress/destructuring-arguments.html: Removed.
- js/regress/destructuring-swap-expected.txt: Removed.
- js/regress/destructuring-swap.html: Removed.
- js/regress/script-tests/destructuring-arguments-length.js: Removed.
- js/regress/script-tests/destructuring-arguments.js: Removed.
- js/regress/script-tests/destructuring-swap.js: Removed.
- js/script-tests/destructuring-assignment.js: Removed.
- sputnik/Conformance/13_Function_Definition/S13_A5.html:
- 7:01 PM Changeset in webkit [156756] by
-
- 2 edits in trunk/Tools
Fix singular labels for test failures.
https://bugs.webkit.org/show_bug.cgi?id=122200
Reviewed by Joseph Pecoraro.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- 6:09 PM FTLJIT edited by
- (diff)
- 6:05 PM Changeset in webkit [156755] by
-
- 1 edit in branches/safari-537.73-branch/LayoutTests/platform/mac-lion/TestExpectations
Merge TextExpectations.
- 6:04 PM Changeset in webkit [156754] by
-
- 1 edit in branches/safari-537.73-branch/LayoutTests/platform/mac-wk2/TestExpectations
Merge TextExpectations.
- 6:00 PM Changeset in webkit [156753] by
-
- 2 edits in trunk/Tools
Don't keep appending iterations each time the queue updates.
https://bugs.webkit.org/show_bug.cgi?id=122198
Reviewed by Joseph Pecoraro.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.update):
- 5:36 PM Changeset in webkit [156752] by
-
- 3 edits in trunk/Tools
Properly sort iterations in the Dashboard by revision for out-of-order queues.
https://bugs.webkit.org/show_bug.cgi?id=122196
Reviewed by Brent Fulgham.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration):
(BuildbotIteration.prototype.update):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.update):
(BuildbotQueue.prototype.sortIterations):
- 5:03 PM Changeset in webkit [156751] by
-
- 24 edits in trunk/Source/WebCore
Convert PageGroup to using std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=122184
Reviewed by Anders Carlsson.
- page/CaptionUserPreferences.cpp:
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMediaAF.cpp:
- page/CaptionUserPreferencesMediaAF.h:
- page/Frame.cpp:
- page/GroupSettings.h:
- page/Page.cpp:
- page/PageGroup.cpp:
- page/PageGroup.h:
- page/UserScriptTypes.h:
- page/UserStyleSheetTypes.h:
- workers/DedicatedWorkerGlobalScope.h:
- workers/DedicatedWorkerThread.cpp:
- workers/DedicatedWorkerThread.h:
- workers/SharedWorkerGlobalScope.cpp:
- workers/SharedWorkerGlobalScope.h:
- workers/SharedWorkerThread.cpp:
- workers/SharedWorkerThread.h:
- workers/WorkerGlobalScope.cpp:
- workers/WorkerGlobalScope.h:
- workers/WorkerThread.cpp:
- workers/WorkerThread.h:
- 4:45 PM Changeset in webkit [156750] by
-
- 4 edits in trunk/Tools
Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
Also fix some URLs to not have extras slashes and add a page title.
https://bugs.webkit.org/show_bug.cgi?id=122192
Reviewed by Joseph Pecoraro.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.buildLogURLForIteration):
(WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
(WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
- 4:42 PM Changeset in webkit [156749] by
-
- 27 edits in trunk
Tiled drawing GraphicsLayer tree dumps should match non-tiled more closely
https://bugs.webkit.org/show_bug.cgi?id=122172
Reviewed by Anders Carlsson.
No new tests, but will be tested by all of the compositing tests after bug 121859 lands.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
Only dump drawsContent and backgroundColor if the client says we should.
Provide the ability to skip over a layer in the dump, making it appear as if that layer's
children are direct decendents of that layer's parent.
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::shouldSkipLayerInDump): Added.
(WebCore::GraphicsLayerClient::shouldDumpPropertyForLayer): Added.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldSkipLayerInDump):
Added. Always skip the root tile cache's flattening layer, as it is
uninteresting and does not exist in the non-tiled-drawing compositing case.
(WebCore::RenderLayerBacking::shouldDumpPropertyForLayer):
Don't dump drawsContent on the root tile cache.
Don't dump backgroundcolor on the root tile cache, unless it is non-white.
This may require some WebKit2-specific rebaselines, but they will occur later.
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::layerTreeAsText):
If the root tile cache has no composited children, don't dump anything,
to match the traditional case where we drop out of compositing when
we have no reason to be compositing. Except, do dump the root tile cache's
layers if we're specifically being asked to dump tile caches.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
- platform/mac-wk2/tiled-drawing/sticky/sticky-layers-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
- platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
Rebaseline some tests given these changes.
- 4:35 PM Changeset in webkit [156748] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations
Skip Failing tests.
- 4:28 PM Changeset in webkit [156747] by
-
- 13 edits in trunk/Source/JavaScriptCore
Variable event stream (for DFG OSR exit) should be explicit about where on the stack a SetLocal put a value
https://bugs.webkit.org/show_bug.cgi?id=122178
Reviewed by Geoffrey Garen.
Now if the DFG stores the value of a variable into the stack explicitly via a SetLocal,
it will record where on the stack it stored the value in addition to recording where on
the stack the bytecode would have done the SetLocal. Previously it just recorded the
format and the bytecode variable. Recording just the bytecode variable is currently fine
since the DFG always executes SetLocal's to the same stack location that the bytecode
would have used. But that prevents stack compression (webkit.org/b/122024) so this patch
allows the SetLocal to say both the bytecode variable that we're speaking of and the
actual stack location to which the SetLocal stored the value.
This had to touch a lot of code, so I took the opportunity to also resolve
webkit.org/b/108019.
- bytecode/Operands.h:
(JSC::Operands::hasOperand):
- dfg/DFGFlushFormat.h:
(JSC::DFG::dataFormatFor):
- dfg/DFGMinifiedID.h:
(JSC::DFG::MinifiedID::bits):
(JSC::DFG::MinifiedID::invalidID):
(JSC::DFG::MinifiedID::otherInvalidID):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::recordSetLocal):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValueSource.cpp:
(JSC::DFG::ValueSource::dump):
- dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::forFlushFormat):
(JSC::DFG::ValueSource::forDataFormat):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::kind):
(JSC::DFG::ValueSource::valueRecovery):
(JSC::DFG::ValueSource::id):
(JSC::DFG::ValueSource::virtualRegister):
- dfg/DFGVariableEvent.cpp:
(JSC::DFG::VariableEvent::dump):
(JSC::DFG::VariableEvent::dumpSpillInfo):
- dfg/DFGVariableEvent.h:
(JSC::DFG::VariableEvent::fillGPR):
(JSC::DFG::VariableEvent::fillPair):
(JSC::DFG::VariableEvent::fillFPR):
(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::death):
(JSC::DFG::VariableEvent::setLocal):
(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::id):
(JSC::DFG::VariableEvent::gpr):
(JSC::DFG::VariableEvent::tagGPR):
(JSC::DFG::VariableEvent::payloadGPR):
(JSC::DFG::VariableEvent::fpr):
(JSC::DFG::VariableEvent::spillRegister):
(JSC::DFG::VariableEvent::bytecodeRegister):
(JSC::DFG::VariableEvent::machineRegister):
(JSC::DFG::VariableEvent::variableRepresentation):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- 4:18 PM Changeset in webkit [156746] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: split overflow checks into non-overflow arithmetic and an additional call to the overflow intrinsic check.
https://bugs.webkit.org/show_bug.cgi?id=122170
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-01
Reviewed by Filip Pizlo.
Overflow intrinsics are preventing SCEV and other LLVM analysis passes from analyzing loops. This patch changes the FTL-IR gen by splitting arithmetic calculations into two parts:
- Generate the arithmetic calculation (that may overflow)
- Generate the overflow check (that is only used by the OSR-exit logic).
We trust LLVM (SelectionDAG) to merge these calculations into a single opcode.
This JS function:
function foo() {
for (i=0; i < 10000000; i++) { }
}
Is now compiled into this LLVM-IR:
"OSR exit continuation for @24<Int32>": ; preds = %"Block #0", %"OSR exit continuation for @24<Int32>2"
%4 = phi i64 [ %10, %"OSR exit continuation for @24<Int32>2" ], [ -281474976710656, %"Block #0" ]
%5 = trunc i64 %4 to i32
%6 = add i32 %5, 1
%7 = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %5, i32 1)
%8 = extractvalue { i32, i1 } %7, 1
br i1 %8, label %"OSR exit failCase for @24<Int32>1", label %"OSR exit continuation for @24<Int32>2"
And into this assembly:
LBB0_1: ## %OSR exit continuation for @24<Int32>
## =>This Inner Loop Header: Depth=1
movl %ecx, %esi
incl %esi
jo LBB0_4
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileAddSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
- 4:17 PM Changeset in webkit [156745] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations
<rdar://problem/15126654>
- 3:59 PM Changeset in webkit [156744] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-wk2/TestExpectations
Skip failing test.
- 3:52 PM Changeset in webkit [156743] by
-
- 8 edits in trunk/Source/WebKit2
<http://webkit.org/b/122190> WebKit2 APIs returning CF and NS types should explicitly declare whether they return retained objects.
This make the APIs easier to use under ARC and can help out the static analyzer.
Reviewed by Anders Carlsson.
- Shared/API/c/cf/WKErrorCF.h:
- Shared/API/c/cf/WKStringCF.h:
- Shared/API/c/cf/WKURLCF.h:
- Shared/API/c/cg/WKImageCG.h:
- Shared/API/c/mac/WKURLRequestNS.h:
- Shared/API/c/mac/WKURLResponseNS.h:
- UIProcess/API/C/cg/WKIconDatabaseCG.h:
- 3:47 PM Changeset in webkit [156742] by
-
- 5 edits5 adds in trunk
Quirksmode: CSS1: WebKit fails dynamic :first-letter test
https://bugs.webkit.org/show_bug.cgi?id=15602
Reviewed by David Hyatt.
Source/WebCore:
CSS first-letter property does not work properly when the first letter is changed
by DOM scripting.
This patch allows to check if the existing first-letter is no longer the
first-letter. In this case, it deletes the old first-letter object and creates
a new one. For the remaining text, the oldRemainingText object is used
again for containing the full text(first letter + remaining text).
Test: fast/css/first-letter-block-change.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
LayoutTests:
Add a test case that ensures that CSS first-letter property should work
properly when the first letter is changed by DOM scripting.
- fast/css/first-letter-block-change.html: Added.
- platform/efl/TestExpectations:
- platform/gtk-wk1/fast/css/first-letter-block-change-expected.png: Added.
- platform/gtk-wk2/fast/css/first-letter-block-change-expected.png: Added.
- platform/gtk/fast/css/first-letter-block-change-expected.txt: Added.
- platform/mac/TestExpectations:
- 3:45 PM Changeset in webkit [156741] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening.
- platform/win/TestExpectations: Update TestExpectations for two crashes that were not
previously logged, one image-only failure, another broken test due to the media changes.
- 3:45 PM Changeset in webkit [156740] by
-
- 3 edits in trunk/Tools
[Mac] Set NSApplication current event while sending events directly to views
https://bugs.webkit.org/show_bug.cgi?id=122179
Reviewed by Darin Adler.
DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
use the current event.
- DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseDown:withModifiers:]):
(-[EventSendingController mouseUp:withModifiers:]):
(-[EventSendingController mouseMoveToX:Y:]):
(-[EventSendingController mouseScrollByX:andY:continuously:]):
(-[EventSendingController contextClick]):
(-[EventSendingController keyDown:withModifiers:withLocation:]):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::mouseScrollBy):
Update the current event. We were already using the SPI in WebKit.
- 3:34 PM Changeset in webkit [156739] by
-
- 2 edits in trunk/Tools
Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
https://bugs.webkit.org/show_bug.cgi?id=122183
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-01
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.update):
- 3:29 PM Changeset in webkit [156738] by
-
- 32 edits in trunk/Source/WebCore
Make tests for renderer base types non-virtual
https://bugs.webkit.org/show_bug.cgi?id=122185
Reviewed by Dave Hyatt.
Make isRenderFoo() functions for commonly tested base types use bit flags instead of virtual calls.
This is faster and we have space in RenderElement.
These bits are not mutully exclusive. For testing leaf types we can add an enum.
- 3:22 PM Changeset in webkit [156737] by
-
- 2 edits in trunk/LayoutTests
[Windows] Unreviewed gardening. Skip fast/events/drag-and-drop-autoscroll-inner-frame.html.
Drag and drop does not work on Windows DRT.
- platform/win/TestExpectations:
- 3:04 PM Changeset in webkit [156736] by
-
- 7 edits1 add in trunk/Tools
Tweaks to the Buildbot Dashboard
https://bugs.webkit.org/show_bug.cgi?id=122169
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype.revisionLinksForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.buildLogURLForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
- 2:49 PM Changeset in webkit [156735] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed build fix after r156730.
https://bugs.webkit.org/show_bug.cgi?id=122021
- platform/win/TestExpectations: Disable a number of tests broken by the switch to the new
CSS/JS-based media controls.
- 2:26 PM Changeset in webkit [156734] by
-
- 2 edits in trunk/Source/JavaScriptCore
Consolidate multiple OSRExit calls into one.
https://bugs.webkit.org/show_bug.cgi?id=122168
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-01
Reviewed by Filip Pizlo.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):
- 2:12 PM Changeset in webkit [156733] by
-
- 3 edits in trunk/Source/WebCore
Cleanup Document::dispatchFullScreenChangeOrErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=122143
Reviewed by Antti Koivisto.
Reduce the code duplication by extracting dispatchFullScreenChangeOrErrorEvent.
- dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Extracted.
- dom/Document.h:
- 1:45 PM Changeset in webkit [156732] by
-
- 2 edits in trunk/LayoutTests
fast/forms/search-event-delay.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=53990
- TestExpectations: Marking as such.
- 1:38 PM Changeset in webkit [156731] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r156725.
http://trac.webkit.org/changeset/156725
https://bugs.webkit.org/show_bug.cgi?id=122176
broke all the mismatch tests again (Requested by thorton on
#webkit).
Tools:
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
LayoutTests:
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Removed.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Removed.
- 1:33 PM Changeset in webkit [156730] by
-
- 9 edits in trunk
Source/WebCore: [Win] Implement the media controls in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=122166
Reviewed by Jer Noble.
- DerivedSources.make: Uncomment feature flag test.
- WebCore.vcxproj/WebCore.vcxproj: Add new media control implementation files.
Also cleaned up some misplaced files in the project tree.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.vcxproj/WebCoreCommon.props: Add missing include path for the
mediacontrols path.
- WebCore.vcxproj/copyForwardingHeaders.cmd: Add Modules/mediacontrols to copied headers.
- rendering/RenderThemeWin.cpp: Add missing include for UserAgentScripts.
WebKitLibraries: [Win] Implement the media controls in JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=122166
Reviewed by Jer Noble.
- win/tools/vsprops/FeatureDefines.props: Activate the
ENABLE_MEDIA_CONTROLS_SCRIPT flag.
- 1:20 PM Changeset in webkit [156729] by
-
- 8 edits in trunk
Source/WebCore: Added adoptCOM to COMPtr on Windows.
https://bugs.webkit.org/show_bug.cgi?id=122069
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.
- platform/win/COMPtr.h:
(adoptCOM): Added.
Source/WebKit/win: Implemented createWebViewWithRequest in WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122069
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::createWindow):
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchCreatePage):
Pass request url from the NavigationAction to createWebViewWithRequest.
Tools: Implemented createWebViewWithRequest in WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122069
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.
- WinLauncher/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::createWebViewWithRequest): Added.
- WinLauncher/PrintWebUIDelegate.h:
Removed createWebViewWithRequest stub.
- 12:55 PM Changeset in webkit [156728] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: evaluate and show a popover for selected text in JS source when paused
https://bugs.webkit.org/show_bug.cgi?id=122151
Reviewed by Joseph Pecoraro.
Identify if the hovered token is contained within the text selection (if any) and use
the selection as the hovered expression to allow the user to select text and hover it
to see what it evaluates to.
- UserInterface/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightRange):
Check we're trying to highlight a different range before removing the highlight
and applying the new one, this prevents the marked text from flashing if it's
being re-hovered which would easily happen when hovering multiple tokens within
the same selection.
(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
In the case where there is selected text, check whether the hovered token is at least
partially contained within the selection, and if so use the selection text as the
hovered expression to evaluate.
- 12:32 PM Changeset in webkit [156727] by
-
- 2 edits in trunk/Source/WebInspectorUI
Console buttons don’t show after page reload
https://bugs.webkit.org/show_bug.cgi?id=116515
Reviewed by Darin Adler.
The correct display of navigation items in the ContentBrowser is contingent on
the ContentViewContainer's _backForwardList being up-to-date when the navigation
items are retrieved from it. However, when the main resource changes (in this case
the user refreshes the browser), calls are made to ContentViewContainer's
closeAllContentViewsOfPrototype() which may modify the _backForwardList but doesn't
necessarily notify of a change to the currentContentView since we may be still showing
the same view in case it wasn't directly related to the main resource, for instance
the console log.
We now check if the _backForwardList is changed as a result of calling
closeAllContentViewsOfPrototype() and in that case also dispatch the
CurrentContentViewDidChange event which will restore the correct state
for the back/forward buttons and navigation items of the navigation bar.
- UserInterface/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.closeAllContentViewsOfPrototype):
Track changes to the _backForwardList and dispatch the CurrentContentViewDidChange
event in case such changes happened.
- 12:31 PM Changeset in webkit [156726] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed build fix; The addedFunction and removedFunction arguments to determineChangedTracksFromNewTracksAndOldItems
were reversed, exposing an underlying, existing bug in AudioTrackPrivate and VideoTrack private. Give a default (null)
value to AudioTrackPrivate::m_client and VideoTrackPrivate::m_client and fix the ordering of arguments in
determineChangedTracksFromNewTracksAndOldItems.
- platform/graphics/AudioTrackPrivate.h:
(WebCore::AudioTrackPrivate::AudioTrackPrivate):
- platform/graphics/VideoTrackPrivate.h:
(WebCore::VideoTrackPrivate::VideoTrackPrivate):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::determineChangedTracksFromNewTracksAndOldItems):
- 11:50 AM Changeset in webkit [156725] by
-
- 3 edits2 adds in trunk
[wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
https://bugs.webkit.org/show_bug.cgi?id=122006
<rdar://problem/15095197>
Reviewed by Dean Jackson.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
Layer-back the root view in WebKitTestRunner's window, to work around a bug
where the window server snapshot API returns blank snapshots.
Re-landing after r156724, this should not break everything now.
Add a test that ensures that WebKitTestRunner's snapshots are not
completely blank with tiled drawing enabled.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
- 11:46 AM Changeset in webkit [156724] by
-
- 6 edits in trunk/Tools
[mac] 1x emulation on Retina hardware shouldn't use SPI
https://bugs.webkit.org/show_bug.cgi?id=122152
<rdar://problem/15119384>
Reviewed by Anders Carlsson.
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(main):
- DumpRenderTree/mac/DumpRenderTreeWindow.h:
- DumpRenderTree/mac/DumpRenderTreeWindow.mm:
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
- WebKitTestRunner/mac/main.mm:
(main):
Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
- 11:45 AM Changeset in webkit [156723] by
-
- 3 edits in trunk/Source/JavaScriptCore
SpeculativeJIT::m_arguments/m_variables are vestiges of a time long gone
https://bugs.webkit.org/show_bug.cgi?id=122140
Reviewed by Darin Adler.
Just killing code.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::recordSetLocal):
- 11:41 AM WebKitGTK/2.2.x edited by
- (diff)
- 11:40 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:36 AM WebKitGTK/2.2.x edited by
- (diff)
- 11:24 AM Changeset in webkit [156722] by
-
- 7 edits3 copies4 adds in trunk
[Mac] Add support for VideoTrack to MediaPlayerPrivateAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=122122
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/video-track.html
Refactor the methods which query AVAssetTrack and AVPlayerItemTrack into an Impl class, and
use that class to reset the properties of both AudioTrackAVFObjC and the new VideoTrackAVFObjC.
Add new files to project:
- WebCore.xcodeproj/project.pbxproj:
Add the new implementation class, shared by AudioTrackAVFObjC and VideoTrackAVFObjC:
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h: Added.
(WebCore::AVTrackPrivateAVFObjCImpl::create): Simple factory.
(WebCore::AVTrackPrivateAVFObjCImpl::playerItemTrack): Simple getter.
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm: Added.
(WebCore::AVTrackPrivateAVFObjCImpl::AVTrackPrivateAVFObjCImpl): Simple constructor.
(WebCore::AVTrackPrivateAVFObjCImpl::enabled): Pass to AVPlayerItemTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::setEnabled): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::audioKind): Distinguish between Alternative and Main content.
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind): Distinguish between Alternative, Main, Caption,
and Description content.
(WebCore::AVTrackPrivateAVFObjCImpl::id): Pass to AVAssetTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::label): Retrieve the Title metadata in the user's preferred
language.
(WebCore::AVTrackPrivateAVFObjCImpl::language): Pass to languageForAVAssetTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::languageForAVAssetTrack): Moved from AudioTrackPrivateAVFObjC.
- platform/graphics/avfoundation/VideoTrackPrivateAVF.h: Copied from Source/WebCore/platform/graphics/avfoundation/AudioTrackPrivateAVF.h.
(WebCore::VideoTrackPrivateAVF::kind): Simple getter.
(WebCore::VideoTrackPrivateAVF::id): Ditto.
(WebCore::VideoTrackPrivateAVF::label): Ditto.
(WebCore::VideoTrackPrivateAVF::language): Ditto.
(WebCore::VideoTrackPrivateAVF::setKind): Simple setter.
(WebCore::VideoTrackPrivateAVF::setId): Ditto.
(WebCore::VideoTrackPrivateAVF::setLabel): Ditto.
(WebCore::VideoTrackPrivateAVF::setLanguage): Ditto.
(WebCore::VideoTrackPrivateAVF::VideoTrackPrivateAVF): Simple constructor.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
(WebCore::AudioTrackPrivateAVFObjC::setEnabled): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Refactor implementation into
template method determineChangedTracksFromNewTracksAndOldItems().
(WebCore::determineChangedTracksFromNewTracksAndOldItems): Refactored.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks): Pass to determineChangedTracksFromNewTracksAndOldItems.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Changed class hosting
languageForAVAssetTrack.
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp: Added.
(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
(WebCore::VideoTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
(WebCore::VideoTrackPrivateAVFObjC::setSelected): Ditto.
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h: Added.
(WebCore::VideoTrackPrivateAVFObjC::create): Simple factory.
LayoutTests:
- media/track/video-track-expected.txt: Added.
- media/track/video-track.html: Added.
- 10:22 AM Changeset in webkit [156721] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 10:20 AM Changeset in webkit [156720] by
-
- 7 edits in branches/safari-537.73-branch/Source
rollout 156718.
- 10:20 AM Changeset in webkit [156719] by
-
- 23 edits in trunk/Source/WebCore
Leaf EventTarget subclasses should be FINAL.
<https://webkit.org/b/122141>
Reviewed by Darin Adler.
Clear out a slew of FIXMEs now that HasMemoryCostMemberFunction
works on classes marked FINAL (fixed in bug 121747.)
- 10:19 AM Changeset in webkit [156718] by
-
- 7 edits in branches/safari-537.73-branch/Source
Versioning.
- 10:03 AM Changeset in webkit [156717] by
-
- 2 edits in trunk/Source/WebCore
Rename URL type variables in Curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=122158
Patch by Szabolcs Dávid <davidsz@inf.u-szeged.hu> on 2013-10-01
Reviewed by Darin Adler.
I changed the name of the URL objects to match with the new class name.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::getProtectionSpace):
(WebCore::ResourceHandleManager::initializeHandle):
- 9:59 AM Changeset in webkit [156716] by
-
- 4 edits in trunk
Center misspelling dots across width of word
https://bugs.webkit.org/show_bug.cgi?id=122046
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-01
Reviewed by Darin Adler.
Source/WebCore:
Test: editing/spelling/spelling.html
- platform/graphics/GraphicsContext.h:
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
LayoutTests:
This patch only rebaselines a single test. I would have rebaselined
the rest of the tests, but they seem to be affected by
webkit.org/b/122146. I don't want to commit incorrect expected results.
- platform/mac/editing/spelling/spelling-expected.png:
- 9:40 AM Changeset in webkit [156715] by
-
- 5 edits in trunk/Source/WebCore
[iOS] WebCore fails to build with newer versions of clang
https://bugs.webkit.org/show_bug.cgi?id=122161
Reviewed by Darin Adler.
- editing/FrameSelection.cpp: Add ENABLE(TEXT_CARET)-guard around shouldStopBlinkingDueToTypingCommand().
- page/EventHandler.cpp: Add !PLATFORM(IOS)-guard around constants cursorUpdateInterval and maximumCursorSize;
also add touch event/gesture event guard around shouldGesturesTriggerActive().
- platform/network/cf/ResourceResponseCFNet.cpp: Remove unused function filenameHasSaneExtension.
- platform/network/mac/ResourceResponseMac.mm: Only define static variables commonHeaderFields when building
without CFNetwork; also remove variable numCommonHeaderFields, instead use WTF_ARRAY_LENGTH(commonHeaderFields)
to compute the size of the fixed-sized array commonHeaderFields.
- 9:39 AM Changeset in webkit [156714] by
-
- 2 edits in trunk/Source/JavaScriptCore
[iOS] JavaScriptCore fails to build with newer versions of clang
https://bugs.webkit.org/show_bug.cgi?id=122162
Reviewed by Darin Adler.
- runtime/GCActivityCallback.cpp: Add !PLATFORM(IOS)-guard around constant pagingTimeOut
as we don't compile the code that uses it on iOS.
- 9:26 AM Changeset in webkit [156713] by
-
- 24 edits2 copies1 add in trunk
[GStreamer] Support "chapter" text tracks
https://bugs.webkit.org/show_bug.cgi?id=122000
Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-01
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/in-band/track-in-band-mkv-chapters.html
- platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h: New class, needed for cues that aren't associated with GstPads.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Check for table of contents messages.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents): Parse table of contents messages into text tracks.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry): Recursive method for parsing all of the TOC entries.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Add the processTableOfContents functions.
LayoutTests:
- media/content/counting-subtitled-srt.mkv: Added chapters metadata.
- media/track/in-band/track-in-band-mkv-chapters-expected.txt: New test, similar to cues-added-one, but uses "chapters" track.
- media/track/in-band/track-in-band-mkv-chapters.html: Same.
- media/in-band-cues.js: Updated tests to handle the new "chapters" track.
- media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt: Same.
- media/track/in-band/track-in-band-kate-ogg-cues-added-once.html: Same.
- media/track/in-band/track-in-band-kate-ogg-mode-expected.txt: Same.
- media/track/in-band/track-in-band-kate-ogg-mode.html: Same.
- media/track/in-band/track-in-band-kate-ogg-style-expected.txt: Same.
- media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt: Same.
- media/track/in-band/track-in-band-kate-ogg-track-order.html: Same.
- media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-cues-added-once.html: Same.
- media/track/in-band/track-in-band-srt-mkv-kind-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-kind.html: Same.
- media/track/in-band/track-in-band-srt-mkv-language-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-language.html: Same.
- media/track/in-band/track-in-band-srt-mkv-mode-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-mode.html: Same.
- media/track/in-band/track-in-band-srt-mkv-style-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-track-order.html: Same.
- 9:14 AM Changeset in webkit [156712] by
-
- 2 edits in trunk/LayoutTests
Try to get another Windows test to pass.
- platform/win/js/dom/global-constructors-attributes-expected.txt: Removed one
more class (Notification) for a feature turned off for the Windows platform.
- 8:02 AM Changeset in webkit [156711] by
-
- 1 edit1 add in trunk/LayoutTests
Try to get another Windows test to pass.
- platform/win/js/dom/global-constructors-attributes-expected.txt: Added.
Copy of the platform-independent results file, with items deleted for features
that are currently turned off for the Windows platform.
- 7:58 AM Changeset in webkit [156710] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] CSS filter not working on software composited layers
https://bugs.webkit.org/show_bug.cgi?id=122159
Reviewed by Noam Rosenthal.
Tell the rendering layer we do not support CSS filters when we do not. This
will make RenderLayer fall back to using its own software implementation.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setFilters):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
- 5:34 AM Changeset in webkit [156709] by
-
- 2 edits in trunk/Source/WebCore
Try to fix assertion failures seem on bots.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createFilterOperations): Rearrange code so this
won't try ot call toCSSPrimitiveValue on a non-primitive-value in the
DROP_SHADOW case.
- 5:09 AM Changeset in webkit [156708] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix the 'InexedDB' typo in the ChangeLog that I failed to address prior to landing r156701.
- 4:57 AM Changeset in webkit [156707] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Adding failure expectations for currently failing tests.
- platform/gtk/TestExpectations:
- 4:38 AM Changeset in webkit [156706] by
-
- 9 edits in trunk/Source/WebKit2
[Qt][WK2] Fix build after r156688.
https://bugs.webkit.org/show_bug.cgi?id=122153
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-10-01
Reviewed by Allan Sandfeld Jensen.
- Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::createDrawingAreaProxy):
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebViewPrivate::createDrawingAreaProxy):
- UIProcess/API/qt/raw/qrawwebview_p_p.h:
- UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::createDrawingAreaProxy):
- UIProcess/qt/QtPageClient.h:
- WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
(WebKit::convertQPixmapToShareableBitmap):
- 3:50 AM Changeset in webkit [156705] by
-
- 21 edits in trunk/Source/WebCore
Generate toCSSFooValue for CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=122101
Reviewed by Antti Koivisto.
As a step of clean-up static_cast<> in CSSValues, this patch generates
toCSSFooPrimitiveValue() in order to detect bad casts as well as improves
code readability.
No new tests, no behavior changes.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
- css/CSSPrimitiveValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- css/MediaList.cpp:
(WebCore::reportMediaQueryWarningIfNeeded):
- css/MediaQueryEvaluator.cpp:
(WebCore::numberValue):
(WebCore::orientationMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::computeLength):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::createGridTrackSize):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::hasVariableReference):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore::StyleResolver::parseCustomFilterNumberParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::computedFontSize):
- editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::legacyFontSize):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::StyleChange::extractTextStyles):
(WebCore::fontWeightIsBold):
(WebCore::isTransparentColorValue):
- editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):
- 3:36 AM Changeset in webkit [156704] by
-
- 1 edit25 moves2 adds in trunk/LayoutTests
Move platform-specific test results from js to js/dom to match moves in r156066.
I see multiple check-ins with people doing this for some files, but these seem to have been missed.
Maybe some of these are unneeded and can be removed.
My hope is that this might help with some failures seen on the Windows bot.
- platform/blackberry/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/blackberry/js/constructor-length-expected.txt.
- platform/efl/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/efl/js/constructor-length-expected.txt.
- platform/efl/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/efl/js/dom-static-property-for-in-iteration-expected.txt.
- platform/efl/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/efl/js/exception-linenums-in-html-3-expected.png.
- platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/efl/js/global-constructors-attributes-dedicated-worker-expected.txt.
- platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/efl/js/global-constructors-attributes-shared-worker-expected.txt.
- platform/efl/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/efl/js/missing-style-end-tag-js-expected.png.
- platform/efl/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/efl/js/missing-title-end-tag-js-expected.png.
- platform/gtk/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/gtk/js/constructor-length-expected.txt.
- platform/gtk/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/gtk/js/exception-linenums-in-html-3-expected.png.
- platform/gtk/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/gtk/js/missing-style-end-tag-js-expected.png.
- platform/gtk/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/gtk/js/missing-title-end-tag-js-expected.png.
- platform/mac/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/mac/js/exception-linenums-in-html-3-expected.png.
- platform/mac/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/mac/js/missing-style-end-tag-js-expected.png.
- platform/mac/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/mac/js/missing-title-end-tag-js-expected.png.
- platform/qt/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/qt/js/constructor-length-expected.txt.
- platform/qt/js/dom/date-DST-time-cusps-expected.txt: Renamed from LayoutTests/platform/qt/js/date-DST-time-cusps-expected.txt.
- platform/qt/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/qt/js/dom-static-property-for-in-iteration-expected.txt.
- platform/qt/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/qt/js/exception-linenums-in-html-3-expected.png.
- platform/qt/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/qt/js/missing-style-end-tag-js-expected.png.
- platform/qt/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/qt/js/missing-title-end-tag-js-expected.png.
- platform/qt/js/dom/switch-behaviour-expected.txt: Renamed from LayoutTests/platform/qt/js/switch-behaviour-expected.txt.
- platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/win/js/dom-static-property-for-in-iteration-expected.txt.
- platform/win/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/win/js/global-constructors-attributes-dedicated-worker-expected.txt.
- platform/win/js/dom/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/win/js/global-constructors-attributes-shared-worker-expected.txt.
- 2:59 AM Changeset in webkit [156703] by
-
- 2 edits in trunk/Source/WebCore
Try to fix AVFoundation crashes seen on Lion bot.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
Four AVFoundation string constants used in this file were new to 10.8.
For older versions of OS X, use hard-coded string constants instead.
- 2:37 AM Changeset in webkit [156702] by
-
- 6 edits6 adds2 deletes in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r156527, moving baselines specific to GTK WK1
under the platform/gtk-wk1 directory.
- platform/gtk-wk1/js: Added.
- platform/gtk-wk1/js/dom: Added.
- platform/gtk-wk1/js/dom/function-length-expected.txt: Added.
- platform/gtk-wk1/scrollingcoordinator: Added.
- platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
- platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
- platform/gtk/js/dom/function-length-expected.txt: Removed.
- platform/gtk/scrollingcoordinator: Removed.
- platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Removed.
- platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Removed.
- platform/gtk/svg/custom/SVGPoint-matrixTransform-expected.txt:
- platform/gtk/svg/custom/getTransformToElement-expected.txt:
- platform/gtk/svg/custom/text-ctm-expected.txt:
- platform/gtk/svg/custom/text-hit-test-expected.txt:
- platform/gtk/svg/text/append-text-node-to-tspan-expected.txt:
- 1:12 AM Changeset in webkit [156701] by
-
- 5 edits in trunk/Source/WebCore
[InexedDB] Interfaces inheriting from EventTarget should generate JSC (un)wrapping functions
https://bugs.webkit.org/show_bug.cgi?id=122114
Reviewed by Darin Adler.
After r156590, four IndexedDB interfaces are inheriting from the EventTarget interface. Because of that,
they're now required to have interface-specific JSC wrapping and unwrapping functions generated since the
JSC wrapping and unwrapping functions for the EventTarget interface delegate these operations to these
interface-specific functions. If the functions are not generated and accessible, the EventTarget functions
end up recursively calling themselves.
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBOpenDBRequest.idl:
- Modules/indexeddb/IDBRequest.idl:
- Modules/indexeddb/IDBTransaction.idl:
Sep 30, 2013:
- 11:37 PM Changeset in webkit [156700] by
-
- 18 edits in trunk/Source
Build fix for EFL, Qt, Gtk port after r156688
https://bugs.webkit.org/show_bug.cgi?id=122139
Reviewed by Anders Carlsson.
Get rid of more uses of OwnPtr and PassOwnPtr.
Source/WebCore:
- platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::beginPaint):
- platform/graphics/surfaces/GraphicsSurface.h:
- platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
- platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
Source/WebKit2:
- Shared/API/c/cairo/WKImageCairo.cpp:
(WKImageCreateFromCairoSurface):
- Shared/API/c/qt/WKImageQt.cpp:
(WKImageCreateFromQImage):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::createGraphicsContext):
(WebKit::WebCoordinatedSurface::paintToSurface):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
- Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::encodeImage):
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createDrawingAreaProxy):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createDrawingAreaProxy):
- UIProcess/CoordinatedGraphics/WebView.h:
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::convertCairoSurfaceToShareableBitmap):
- 11:12 PM Changeset in webkit [156699] by
-
- 3 edits in trunk/LayoutTests
Layout Test media/click-volume-bar-not-pausing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122126
Reviewed by Darin Adler.
Speculative partial fix.
I'm not sure if it's possible to make this test completely controlled without
DOMFrameContentLoaded support - we need to do work when the <video> element is
already present, but playback hasn't started yet. As media documents use autoplay,
there is a race between load and playing events.
- media/click-volume-bar-not-pausing-expected.txt:
- media/click-volume-bar-not-pausing.html:
- Add video URL after initial content fully loads to avoid races with that.
- Added some state logging for clarity.
- Only listen for "playing" event once. If playback already started, we have a playing event already queued, and would add another one with pause()/play().
- 10:58 PM Changeset in webkit [156698] by
-
- 5 edits2 adds in trunk
AX: Expose ARIA Busy Notifications
https://bugs.webkit.org/show_bug.cgi?id=121451
Patch by Sam White <Samuel White> on 2013-09-30
Reviewed by Chris Fleizach.
Source/WebCore:
Added AXElementBusyChanged notification that posts when aria-busy is toggled. This
enables screen readers to detect busy states without polling the focused element.
Test: platform/mac/accessibility/element-busy-changed.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChanged):
- accessibility/AXObjectCache.h:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
Added test to verify that elements post AXElementBusyChanged notifications when aria-busy is toggled.
- platform/mac/accessibility/element-busy-changed-expected.txt: Added.
- platform/mac/accessibility/element-busy-changed.html: Added.
- 10:16 PM Changeset in webkit [156697] by
-
- 2 edits in trunk/Source/WebKit/efl
Fix the build.
- ewk/ewk_settings.cpp:
- 10:10 PM Changeset in webkit [156696] by
-
- 2 edits in trunk/Source/WebCore
Fixing the build.
- GNUmakefile.list.am:
- 9:59 PM Changeset in webkit [156695] by
-
- 5 edits in trunk/Source/WebCore
More build fixing.
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- inspector/InspectorAllInOne.cpp:
- inspector/InstrumentingAgents.h:
- 9:57 PM Changeset in webkit [156694] by
-
- 3 edits in trunk/Tools
check-webkit-style should not warn about use of C++11 “>>” instead of “> >"
https://bugs.webkit.org/show_bug.cgi?id=116474
Patch by Sam Weinig <sam@webkit.org> on 2013-09-30
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- 9:47 PM Changeset in webkit [156693] by
-
- 4 edits in trunk/Source/WebCore
Fix the Efl and Gtk builds.
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- 9:33 PM Changeset in webkit [156692] by
-
- 75 edits51 deletes in trunk
Remove support for DOMFileSystem
https://bugs.webkit.org/show_bug.cgi?id=122137
Reviewed by Anders Carlsson.
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Files elided *
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::clearWebFileSystem):
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/efl:
- ewk/ewk_settings.cpp:
(ewk_settings_file_system_path_set):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_for_binary_ops):
- qmake/mkspecs/features/features.pri:
LayoutTests:
- fast/dom/MutationObserver/filesystem-callback-delivery-expected.txt: Removed.
- fast/dom/MutationObserver/filesystem-callback-delivery.html: Removed.
- fast/filesystem: Removed.
- fast/filesystem/async-operations-expected.txt: Removed.
- fast/filesystem/async-operations.html: Removed.
- fast/filesystem/cross-filesystem-op-expected.txt: Removed.
- fast/filesystem/cross-filesystem-op.html: Removed.
- fast/filesystem/directory-entry-to-uri-expected.txt: Removed.
- fast/filesystem/directory-entry-to-uri.html: Removed.
- fast/filesystem/entry-points-missing-arguments-expected.txt: Removed.
- fast/filesystem/entry-points-missing-arguments.html: Removed.
- fast/filesystem/file-after-reload-crash-expected.txt: Removed.
- fast/filesystem/file-after-reload-crash.html: Removed.
- fast/filesystem/file-entry-to-uri-expected.txt: Removed.
- fast/filesystem/file-entry-to-uri.html: Removed.
- fast/filesystem/file-from-file-entry-expected.txt: Removed.
- fast/filesystem/file-from-file-entry.html: Removed.
- fast/filesystem/file-metadata-after-write-expected.txt: Removed.
- fast/filesystem/file-metadata-after-write.html: Removed.
- fast/filesystem/file-writer-abort-continue-expected.txt: Removed.
- fast/filesystem/file-writer-abort-continue.html: Removed.
- fast/filesystem/file-writer-abort-depth-expected.txt: Removed.
- fast/filesystem/file-writer-abort-depth.html: Removed.
- fast/filesystem/file-writer-abort-expected.txt: Removed.
- fast/filesystem/file-writer-abort.html: Removed.
- fast/filesystem/file-writer-empty-blob-expected.txt: Removed.
- fast/filesystem/file-writer-empty-blob.html: Removed.
- fast/filesystem/file-writer-events-expected.txt: Removed.
- fast/filesystem/file-writer-events.html: Removed.
- fast/filesystem/file-writer-gc-blob-expected.txt: Removed.
- fast/filesystem/file-writer-gc-blob.html: Removed.
- fast/filesystem/file-writer-truncate-extend-expected.txt: Removed.
- fast/filesystem/file-writer-truncate-extend.html: Removed.
- fast/filesystem/file-writer-write-overlapped-expected.txt: Removed.
- fast/filesystem/file-writer-write-overlapped.html: Removed.
- fast/filesystem/filesystem-missing-arguments-expected.txt: Removed.
- fast/filesystem/filesystem-missing-arguments.html: Removed.
- fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Removed.
- fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Removed.
- fast/filesystem/filesystem-reference-expected.txt: Removed.
- fast/filesystem/filesystem-reference.html: Removed.
- fast/filesystem/filesystem-unserializable-expected.txt: Removed.
- fast/filesystem/filesystem-unserializable.html: Removed.
- fast/filesystem/filesystem-uri-origin-expected.txt: Removed.
- fast/filesystem/filesystem-uri-origin.html: Removed.
- fast/filesystem/flags-passing-expected.txt: Removed.
- fast/filesystem/flags-passing.html: Removed.
- fast/filesystem/input-access-entries-expected.txt: Removed.
- fast/filesystem/input-access-entries.html: Removed.
- fast/filesystem/not-enough-arguments-expected.txt: Removed.
- fast/filesystem/not-enough-arguments.html: Removed.
- fast/filesystem/op-copy-expected.txt: Removed.
- fast/filesystem/op-copy.html: Removed.
- fast/filesystem/op-get-entry-expected.txt: Removed.
- fast/filesystem/op-get-entry.html: Removed.
- fast/filesystem/op-get-metadata-expected.txt: Removed.
- fast/filesystem/op-get-metadata.html: Removed.
- fast/filesystem/op-get-parent-expected.txt: Removed.
- fast/filesystem/op-get-parent.html: Removed.
- fast/filesystem/op-move-expected.txt: Removed.
- fast/filesystem/op-move.html: Removed.
- fast/filesystem/op-read-directory-expected.txt: Removed.
- fast/filesystem/op-read-directory.html: Removed.
- fast/filesystem/op-remove-expected.txt: Removed.
- fast/filesystem/op-remove.html: Removed.
- fast/filesystem/op-restricted-chars-expected.txt: Removed.
- fast/filesystem/op-restricted-chars.html: Removed.
- fast/filesystem/op-restricted-names-expected.txt: Removed.
- fast/filesystem/op-restricted-names.html: Removed.
- fast/filesystem/op-restricted-unicode-expected.txt: Removed.
- fast/filesystem/op-restricted-unicode.html: Removed.
- fast/filesystem/read-directory-expected.txt: Removed.
- fast/filesystem/read-directory.html: Removed.
- fast/filesystem/resources: Removed.
- fast/filesystem/resources/async-operations.js: Removed.
- fast/filesystem/resources/directory-entry-to-uri.js: Removed.
- fast/filesystem/resources/file-entry-to-uri-sync.js: Removed.
- fast/filesystem/resources/file-entry-to-uri.js: Removed.
- fast/filesystem/resources/file-from-file-entry-sync.js: Removed.
- fast/filesystem/resources/file-from-file-entry.js: Removed.
- fast/filesystem/resources/file-writer-abort-continue.js: Removed.
- fast/filesystem/resources/file-writer-abort-depth.js: Removed.
- fast/filesystem/resources/file-writer-abort.js: Removed.
- fast/filesystem/resources/file-writer-empty-blob.js: Removed.
- fast/filesystem/resources/file-writer-events.js: Removed.
- fast/filesystem/resources/file-writer-gc-blob.js: Removed.
- fast/filesystem/resources/file-writer-sync-truncate-extend.js: Removed.
- fast/filesystem/resources/file-writer-sync-write-overlapped.js: Removed.
- fast/filesystem/resources/file-writer-truncate-extend.js: Removed.
- fast/filesystem/resources/file-writer-utils.js: Removed.
- fast/filesystem/resources/file-writer-write-overlapped.js: Removed.
- fast/filesystem/resources/fs-test-util.js: Removed.
- fast/filesystem/resources/fs-worker-common.js: Removed.
- fast/filesystem/resources/op-copy.js: Removed.
- fast/filesystem/resources/op-get-entry.js: Removed.
- fast/filesystem/resources/op-get-metadata.js: Removed.
- fast/filesystem/resources/op-get-parent.js: Removed.
- fast/filesystem/resources/op-move.js: Removed.
- fast/filesystem/resources/op-read-directory.js: Removed.
- fast/filesystem/resources/op-remove.js: Removed.
- fast/filesystem/resources/op-restricted-chars.js: Removed.
- fast/filesystem/resources/op-restricted-names.js: Removed.
- fast/filesystem/resources/op-restricted-unicode.js: Removed.
- fast/filesystem/resources/op-tests-helper.js: Removed.
- fast/filesystem/resources/shared-worker-stub.js: Removed.
- fast/filesystem/resources/simple-persistent-sync.js: Removed.
- fast/filesystem/resources/simple-persistent.js: Removed.
- fast/filesystem/resources/simple-readonly.js: Removed.
- fast/filesystem/resources/simple-required-arguments-getdirectory.js: Removed.
- fast/filesystem/resources/simple-required-arguments-getfile.js: Removed.
- fast/filesystem/resources/simple-required-arguments-getmetadata.js: Removed.
- fast/filesystem/resources/simple-required-arguments-remove.js: Removed.
- fast/filesystem/resources/simple-temporary-sync.js: Removed.
- fast/filesystem/resources/simple-temporary.js: Removed.
- fast/filesystem/resources/sync-operations.js: Removed.
- fast/filesystem/script-tests: Removed.
- fast/filesystem/script-tests/TEMPLATE.html: Removed.
- fast/filesystem/script-tests/filesystem-reference.js: Removed.
- fast/filesystem/script-tests/filesystem-unserializable.js: Removed.
- fast/filesystem/script-tests/flags-passing.js: Removed.
- fast/filesystem/script-tests/read-directory.js: Removed.
- fast/filesystem/simple-persistent-expected.txt: Removed.
- fast/filesystem/simple-persistent.html: Removed.
- fast/filesystem/simple-readonly-expected.txt: Removed.
- fast/filesystem/simple-readonly-file-object-expected.txt: Removed.
- fast/filesystem/simple-readonly-file-object.html: Removed.
- fast/filesystem/simple-readonly.html: Removed.
- fast/filesystem/simple-required-arguments-getdirectory-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-getdirectory.html: Removed.
- fast/filesystem/simple-required-arguments-getfile-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-getfile.html: Removed.
- fast/filesystem/simple-required-arguments-getmetadata-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-getmetadata.html: Removed.
- fast/filesystem/simple-required-arguments-remove-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-remove.html: Removed.
- fast/filesystem/simple-temporary-expected.txt: Removed.
- fast/filesystem/simple-temporary.html: Removed.
- fast/filesystem/workers: Removed.
- fast/filesystem/workers/async-operations-expected.txt: Removed.
- fast/filesystem/workers/async-operations.html: Removed.
- fast/filesystem/workers/detached-frame-crash-expected.txt: Removed.
- fast/filesystem/workers/detached-frame-crash.html: Removed.
- fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Removed.
- fast/filesystem/workers/file-entry-to-uri-sync.html: Removed.
- fast/filesystem/workers/file-from-file-entry-expected.txt: Removed.
- fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Removed.
- fast/filesystem/workers/file-from-file-entry-sync.html: Removed.
- fast/filesystem/workers/file-from-file-entry.html: Removed.
- fast/filesystem/workers/file-writer-empty-blob-expected.txt: Removed.
- fast/filesystem/workers/file-writer-empty-blob.html: Removed.
- fast/filesystem/workers/file-writer-events-expected.txt: Removed.
- fast/filesystem/workers/file-writer-events-shared-worker-expected.txt: Removed.
- fast/filesystem/workers/file-writer-events-shared-worker.html: Removed.
- fast/filesystem/workers/file-writer-events.html: Removed.
- fast/filesystem/workers/file-writer-gc-blob-expected.txt: Removed.
- fast/filesystem/workers/file-writer-gc-blob.html: Removed.
- fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Removed.
- fast/filesystem/workers/file-writer-sync-truncate-extend.html: Removed.
- fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Removed.
- fast/filesystem/workers/file-writer-sync-write-overlapped.html: Removed.
- fast/filesystem/workers/file-writer-truncate-extend-expected.txt: Removed.
- fast/filesystem/workers/file-writer-truncate-extend.html: Removed.
- fast/filesystem/workers/file-writer-write-overlapped-expected.txt: Removed.
- fast/filesystem/workers/file-writer-write-overlapped.html: Removed.
- fast/filesystem/workers/resources: Removed.
- fast/filesystem/workers/resources/detached-frame-crash-frame.html: Removed.
- fast/filesystem/workers/resources/detached-frame-crash-worker.js: Removed.
- fast/filesystem/workers/simple-persistent-expected.txt: Removed.
- fast/filesystem/workers/simple-persistent-sync-expected.txt: Removed.
- fast/filesystem/workers/simple-persistent-sync.html: Removed.
- fast/filesystem/workers/simple-persistent.html: Removed.
- fast/filesystem/workers/simple-temporary-expected.txt: Removed.
- fast/filesystem/workers/simple-temporary-sync-expected.txt: Removed.
- fast/filesystem/workers/simple-temporary-sync.html: Removed.
- fast/filesystem/workers/simple-temporary.html: Removed.
- fast/filesystem/workers/sync-operations-expected.txt: Removed.
- fast/filesystem/workers/sync-operations.html: Removed.
- fast/forms/file/input-file-entries-expected.txt: Removed.
- fast/forms/file/input-file-entries.html: Removed.
- http/tests/filesystem: Removed.
- http/tests/filesystem/no-cache-filesystem-url-expected.txt: Removed.
- http/tests/filesystem/no-cache-filesystem-url.html: Removed.
- http/tests/filesystem/resolve-uri-expected.txt: Removed.
- http/tests/filesystem/resolve-uri.html: Removed.
- http/tests/filesystem/resources: Removed.
- http/tests/filesystem/resources/fs-test-util.js: Removed.
- http/tests/filesystem/resources/fs-worker-common.js: Removed.
- http/tests/filesystem/resources/fs-worker-test-util.js: Removed.
- http/tests/filesystem/script-tests: Removed.
- http/tests/filesystem/script-tests/TEMPLATE.html: Removed.
- http/tests/filesystem/script-tests/resolve-uri.js: Removed.
- http/tests/filesystem/workers: Removed.
- http/tests/filesystem/workers/resolve-url-expected.txt: Removed.
- http/tests/filesystem/workers/resolve-url-sync-expected.txt: Removed.
- http/tests/filesystem/workers/resolve-url-sync.html: Removed.
- http/tests/filesystem/workers/resolve-url.html: Removed.
- http/tests/filesystem/workers/script-tests: Removed.
- http/tests/filesystem/workers/script-tests/TEMPLATE.html: Removed.
- http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Removed.
- http/tests/inspector/filesystem: Removed.
- http/tests/inspector/filesystem/delete-entry-expected.txt: Removed.
- http/tests/inspector/filesystem/delete-entry.html: Removed.
- http/tests/inspector/filesystem/directory-tree-expected.txt: Removed.
- http/tests/inspector/filesystem/directory-tree.html: Removed.
- http/tests/inspector/filesystem/filesystem-test.js: Removed.
- http/tests/inspector/filesystem/request-directory-content-expected.txt: Removed.
- http/tests/inspector/filesystem/request-directory-content.html: Removed.
- http/tests/inspector/filesystem/request-file-content-expected.txt: Removed.
- http/tests/inspector/filesystem/request-file-content.html: Removed.
- http/tests/inspector/filesystem/request-filesystem-root-expected.txt: Removed.
- http/tests/inspector/filesystem/request-filesystem-root.html: Removed.
- http/tests/inspector/filesystem/request-metadata-expected.txt: Removed.
- http/tests/inspector/filesystem/request-metadata.html: Removed.
- http/tests/security/contentSecurityPolicy/filesystem-urls-match-self-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html: Removed.
- http/tests/security/filesystem-iframe-from-remote-expected.txt: Removed.
- http/tests/security/filesystem-iframe-from-remote.html: Removed.
- http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Removed.
- http/tests/security/mixedContent/filesystem-url-in-iframe.html: Removed.
- http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
- http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
- http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
- http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
- http/tests/workers/resources/sync-operations.js:
(onmessage):
- http/tests/workers/terminate-during-sync-operation-expected.txt: Removed.
- http/tests/workers/terminate-during-sync-operation.html: Removed.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 6:47 PM Changeset in webkit [156691] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Build fix afer r156688.
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL): Switch to std::unique_ptr in
method implementation.
- 6:37 PM Changeset in webkit [156690] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- NetworkProcess/mac/RemoteNetworkingContext.mm:
- 6:24 PM Changeset in webkit [156689] by
-
- 3 edits in trunk/Tools
More build fixage for builds with SDKs.
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig:
- 5:59 PM Changeset in webkit [156688] by
-
- 93 edits in trunk/Source
Get rid of more uses of OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122136
Reviewed by Antti Koivisto.
Source/WebCore:
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveBinaryData):
- WebCore.exp.in:
- fileapi/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::slice):
- fileapi/Blob.h:
(WebCore::Blob::create):
- fileapi/File.cpp:
(WebCore::createBlobDataForFileWithType):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::BlobRegistryContext::BlobRegistryContext):
(WebCore::registerBlobURLTask):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
- fileapi/ThreadableBlobRegistry.h:
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::getBlob):
- platform/network/BlobData.cpp:
(WebCore::BlobDataHandle::BlobDataHandle):
- platform/network/BlobData.h:
(WebCore::BlobData::BlobData):
(WebCore::BlobDataHandle::create):
- platform/network/BlobRegistry.h:
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
- platform/network/BlobRegistryImpl.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseBlob):
Source/WebKit2:
- NetworkProcess/AsynchronousNetworkLoaderClient.h:
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURL):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/SynchronousNetworkLoaderClient.h:
- NetworkProcess/mac/RemoteNetworkingContext.mm:
- Platform/CoreIPC/ArgumentDecoder.h:
- Platform/CoreIPC/ArgumentEncoder.h:
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::setImportanceAssertion):
- Platform/CoreIPC/MessageDecoder.h:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::receiveSourceEventHandler):
- Platform/CoreIPC/mac/ImportanceAssertion.h:
(CoreIPC::ImportanceAssertion::ImportanceAssertion):
- Platform/mac/LayerHostingContext.h:
- Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForWindowServer):
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::addPluginControllerProxy):
(WebKit::WebProcessConnection::removePluginControllerProxy):
(WebKit::WebProcessConnection::createPluginInternal):
- PluginProcess/WebProcessConnection.h:
- Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateFromCGImage):
- Shared/BlockingResponseMap.h:
(BlockingResponseMap::waitForResponse):
(BlockingResponseMap::didReceiveResponse):
- Shared/Downloads/Download.cpp:
- Shared/Downloads/Download.h:
- Shared/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertHandleToDownload):
- Shared/FileAPI/BlobRegistrationData.cpp:
(WebKit::BlobRegistrationData::BlobRegistrationData):
(WebKit::BlobRegistrationData::releaseData):
(WebKit::BlobRegistrationData::decode):
- Shared/FileAPI/BlobRegistrationData.h:
- Shared/Plugins/NPObjectMessageReceiver.cpp:
- Shared/Plugins/NPObjectMessageReceiver.h:
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject):
- Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
- Shared/Plugins/Netscape/NetscapePluginModule.h:
- Shared/ShareableBitmap.h:
- Shared/WebURL.h:
(WebKit::WebURL::create):
(WebKit::WebURL::WebURL):
(WebKit::WebURL::parseURLIfNecessary):
- Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImageCopy):
- Shared/mac/SecItemShim.cpp:
(WebKit::sendSecItemRequest):
(WebKit::webSecItemCopyMatching):
(WebKit::webSecItemAdd):
(WebKit::webSecItemUpdate):
(WebKit::webSecItemDelete):
(WebKit::SecItemShim::secItemResponse):
- UIProcess/API/mac/FindIndicatorWindow.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createDrawingAreaProxy):
- UIProcess/API/mac/WKView.mm:
(-[WKView std::WebKit::]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/BackingStore.cpp:
- UIProcess/BackingStore.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURL):
- WebProcess/FileAPI/BlobRegistryProxy.h:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
- WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
(WKBundlePageBannerCreateBannerWithCALayer):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::imageForRect):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::scheduleTimer):
(WebKit::NetscapePlugin::unscheduleTimer):
(WebKit::NetscapePlugin::snapshot):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::snapshot):
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::update):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap):
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::getFindIndicatorBitmapAndRect):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::create):
(WebKit::WebFrame::WebFrame):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaledSnapshotWithOptions):
(WebKit::WebPage::drawRectToImage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
- 5:48 PM Changeset in webkit [156687] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Message sending functions should only accept rvalues
https://bugs.webkit.org/show_bug.cgi?id=122041
Reviewed by Andreas Kling.
In order to safely encode move-only types, make all send variants accept rvalues only, except
for the "send to all processes" ones. For them, copy the message before sending. This ensures that trying
to send a move-only type in a message will fail to compile.
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::sendSync):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):
- UIProcess/WebContext.h:
(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):
(WebKit::WebContext::sendToAllProcesses):
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
(WebKit::WebContext::sendToOneProcess):
- UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
- 4:42 PM Changeset in webkit [156686] by
-
- 1 copy in branches/safari-537.73-branch
New Branch.
- 4:13 PM Changeset in webkit [156685] by
-
- 1 edit36 adds in trunk/Tools
Add initial version of a new Buildbot dashboard view.
https://bugs.webkit.org/show_bug.cgi?id=122131
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
- 3:52 PM Changeset in webkit [156684] by
-
- 2 edits in trunk/Source/JavaScriptCore
<rdar://problem/15114974> Assertion failure under -[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:] if no classes conform to JSExport
https://bugs.webkit.org/show_bug.cgi?id=122124
Reviewed by Darin Adler.
- API/JSWrapperMap.mm: Defined an empty class that conforms to the JSExport protocol, to
ensure that the protocol is always registered with the runtime by the time
getJSExportProtocol() is called.
- 3:43 PM Changeset in webkit [156683] by
-
- 46 edits in trunk
Remove the code guarded by STYLE_SCOPED
https://bugs.webkit.org/show_bug.cgi?id=122123
Reviewed by Anders Carlsson.
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Start cleaning the code related to <style scoped>. This patch
only removes the code with #ifdef guards.
- Configurations/FeatureDefines.xcconfig:
- WebCore.exp.in:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/generic/RuntimeEnabledFeatures.h:
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchScopedAuthorRules):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
- css/StyleResolver.h:
(WebCore::StyleResolver::ensureScopeResolver):
- css/StyleScopeResolver.cpp:
- css/StyleScopeResolver.h:
- dom/Node.cpp:
- dom/Node.h:
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
- dom/ShadowRoot.h:
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):
- html/HTMLStyleElement.h:
- html/HTMLStyleElement.idl:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
- 2:56 PM Changeset in webkit [156682] by
-
- 2 edits in trunk/Source/WebCore
ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=122032
Patch by Drew Yao <ayao@apple.com> on 2013-09-30
Reviewed by Andreas Kling.
Convert assertion to ASSERT_WITH_SECURITY_IMPLICATION to help catch use after free bugs.
No new tests needed.
- rendering/InlineBox.h:
(WebCore::InlineBox::parent):
- 2:54 PM Changeset in webkit [156681] by
-
- 2 edits in trunk/Source/WebCore
Don't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw data.
https://bugs.webkit.org/show_bug.cgi?id=122115
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-09-30
Reviewed by Daniel Bates.
With BitmapImage::create(PassNativeImagePtr, ImageObserver*), a BitmapImage could be created by
passing a native image. If this image is added to memory cache, we shouldn't attempt to destroy
its decoded frames since there is no encoded raw data and we won't be able to reconstruct the image again.
No new tests for now. Currently there isn't a code path to add to the memory cache a BitmapImage
that was created by adopting a native image. We'll add such a code path in a subsequent patch.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
- 2:42 PM Changeset in webkit [156680] by
-
- 4 edits in trunk/Source/JavaScriptCore
Pass VM instead of ExecState to ObjectPrototype constructor.
<https://webkit.org/b/122116>
Reviewed by Geoffrey Garen.
The ObjectPrototype constructor was only using the ExecState to get
to the VM.
- 2:41 PM Changeset in webkit [156679] by
-
- 6 edits in trunk/Source/JavaScriptCore
Pass VM instead of JSGlobalObject to MathObject constructor.
<https://webkit.org/b/122119>
Reviewed by Geoffrey Garen.
The MathObject constructor was only using the global object to get
to the VM. finishCreation() still uses it to set up functions.
- 1:47 PM Changeset in webkit [156678] by
-
- 2 edits in trunk/LayoutTests
Remove timeout from shouldBecome* functions in js-test-pre
https://bugs.webkit.org/show_bug.cgi?id=122121
Reviewed by Ryosuke Niwa.
Removed timeout. A 0.5 sec timeout never makes sense, and if something is stuck,
a test should just time out normally.
- resources/js-test-pre.js:
(_waitForCondition):
(shouldBecomeEqual):
(shouldBecomeEqualToString):
(shouldBecomeDifferent):
- 1:38 PM Changeset in webkit [156677] by
-
- 21 edits1 add in trunk/Source/JavaScriptCore
Get rid of the AlreadyInJSStack recoveries since they are totally redundant with the DisplacedInJSStack recoveries
https://bugs.webkit.org/show_bug.cgi?id=122065
Reviewed by Mark Hahnenberg.
This mostly just kills a bunch of code.
But incidentaly while killing that code, I uncovered a bug in our FTL OSR entrypoint
creation phase. The phase inserts a sequence of SetLocal(ExtractOSREntryLocal) nodes.
If we hoist some type check into the local, then we might inject a conversion node
between the ExtractOSREntryLocal and the SetLocal - for example we might put in a
Int32ToDouble node. But currently the FixupPhase will make all conversion nodes placed
on an edge of a SetLocal use forward exit. This then confuses the OSR exit machinery.
When OSR exit sees a forward exit, it tries to "roll forward" execution from the exiting
node to the first node that has a different CodeOrigin. This only works if the nodes
after the forward exit are MovHints or other tnings that the OSR exit compiler can
forward-execute. But here, it will see a bunch of SetLocal and ExtractOSREntryLocal
nodes for the same bytecode index. Two possible solutions exist. We could teach the
forward-execution logic how to deal with multiple SetLocals and ExtractOSREntryLocals.
This would be a lot of complexity; right now it just needs to deal with exactly one
SetLocal-like operation. The alternative is to make sure that the conversion node that
we inject ends up exiting *backward* rather than forward.
But making the conversion nodes exit backward is somewhat tricky. Before this patch,
conversion nodes always exit forward for SetLocals and backwards otherwise. It turns out
that the solution is to rationalize how we choose the speculation direciton for a
conversion node. The conversion node's speculation direction should be the same as the
speculation direction of the node for which it is doing a conversion. Since SetLocal's
already exit forward by default, this policy preserves our previous behavior. But it
also allows the OSR entrypoint creation phase to make its SetLocals exit backward
instead.
Of course, if the SetLocal(ExtractOSREntryLocal) sequences exit backward, then we need
to make sure that the OSR exit machine knows that the local variables are indeed live.
Consider that if we have:
a: ExtractOSREntryLocal(loc1)
b: SetLocal(@a, loc1)
c: ExtractOSRentryLocal(loc2)
d: SetLocal(@c, loc2)
Without additional magic, the exit at @b will think that loc2 is dead and the OSR exit
compiler will clobber loc2 with Undefined. So we need to make sure that we actually
emit code like:
a: ExtractOSREntryLocal(loc1)
b: ExtractOSREntryLocal(loc2)
c: SetLocal(@a, loc1)
d: SetLocal(@b, loc2)
e: SetLocal(@a, loc1)
f: SetLocal(@b, loc2)
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeOrigin.h:
- bytecode/ValueRecovery.cpp: Added.
(JSC::ValueRecovery::recover):
(JSC::ValueRecovery::dumpInContext):
(JSC::ValueRecovery::dump):
- bytecode/ValueRecovery.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixEdge):
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
- dfg/DFGNode.h:
(JSC::DFG::Node::speculationDirection):
(JSC::DFG::Node::setSpeculationDirection):
- dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::valueRecovery):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateMachineInt):
- interpreter/Register.h:
(JSC::Register::unboxedStrictInt52):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
- runtime/Arguments.h:
- 1:32 PM Changeset in webkit [156676] by
-
- 19 edits1 delete in trunk/Source/WebCore
Remove IDBTracing.h.
https://bugs.webkit.org/show_bug.cgi?id=122118
Reviewed by Alexey Proskuryakov.
Global replace of "IDB_TRACE" with "LOG(StorageAPI)", and remove all notions of this header.
- GNUmakefile.list.am:
- Modules/indexeddb/IDBCursor.cpp:
- Modules/indexeddb/IDBDatabase.cpp:
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
- Modules/indexeddb/IDBFactory.cpp:
- Modules/indexeddb/IDBIndex.cpp:
- Modules/indexeddb/IDBObjectStore.cpp:
- Modules/indexeddb/IDBOpenDBRequest.cpp:
- Modules/indexeddb/IDBRequest.cpp:
- Modules/indexeddb/IDBTracing.h: Removed.
- Modules/indexeddb/IDBTransaction.cpp:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/IDBBindingUtilities.cpp:
- 1:10 PM Changeset in webkit [156675] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: rows in the Layer sidebar panel may have the incorrect background color
https://bugs.webkit.org/show_bug.cgi?id=122108
Reviewed by Darin Adler.
The LayerTreeDataGrid is a custom DataGrid subclass which exposes a .setChildren() method
used to sort chidren without DOM order manipulation, for performance reason. However, since
the way the alternating background color is usually implemented is based on the built-in
CSS pseudo-classes working with DOM order, the background colors of nodes in the LayerTreeDataGrid
can be incorrect depending on the sort order and the number of nodes. To fix this, we now manually
set "even" and "odd" CSS classes on those nodes when they're sorted such that we have a chance
to style them as intended.
- UserInterface/LayerTreeDataGrid.js:
(WebInspector.LayerTreeDataGrid.prototype._updateChildren):
Check if the data grid node index is even or odd and reflect this via an exclusive "even"
or "odd" CSS class name.
- UserInterface/LayerTreeSidebarPanel.css:
(.layer-tree.panel .data-container tbody > tr.even):
(.layer-tree.panel .data-container tbody > tr.odd):
Apply alternating colors based on the exclusive "even" and "odd" CSS class names as applied in
WebInspector.LayerTreeDataGrid.prototype._updateChildren().
- 1:07 PM Changeset in webkit [156674] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix for Win64.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added correct 64-bit BitmapImage::create symbol.
- 1:07 PM Changeset in webkit [156673] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Popover displaying "reasons for compositing" may remain on screen after selected layer is removed
https://bugs.webkit.org/show_bug.cgi?id=117575
Ensure the popover attached to the selected data grid node is updated when the
content or sort order of the Layer sidebar panel is updated.
Reviewed by Darin Adler.
- UserInterface/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
- 1:06 PM Changeset in webkit [156672] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: nodes can be dragged from the console log
https://bugs.webkit.org/show_bug.cgi?id=122105
Reviewed by Darin Adler.
Catch "dragstart" events targeting nodes hosted in a DOMTreeOutline within the console
log view and prevent the default logic to trigger so that these nodes can't be dragged
off the console as it wouldn't make sense to.
- UserInterface/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline):
Create a class property to allow the CSS class name to be used in WebInspector.LogContentView.
- UserInterface/LogContentView.js:
(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._ondragstart):
Track the "dragstart" events in their capture phase such that, if the event target is
a DOM node hosted in a DOMTreeOutline, we can prevent the event from propagating and
cancel its default behavior such that no dragging at all is performed.
- 12:51 PM Changeset in webkit [156671] by
-
- 2 edits in trunk/Source/JavaScriptCore
Win64 compile fix after r1256490.
https://bugs.webkit.org/show_bug.cgi?id=122117
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-09-30
Reviewed by Michael Saboff.
- jit/JITStubsMSVC64.asm:
Implemented getHostCallReturnValue for Windows x86_64 processors.
- 12:44 PM Changeset in webkit [156670] by
-
- 2 edits in trunk/Source/WebKit2
NetworkResourceLoader.messages.in should be ENABLE(NETWORK_PROCESS) guarded
https://bugs.webkit.org/show_bug.cgi?id=122110
Reviewed by Darin Adler.
- NetworkProcess/NetworkResourceLoader.messages.in:
- 12:35 PM Changeset in webkit [156669] by
-
- 4 edits in trunk/Source/WebCore
[Windows] Build fix after r156622. Build RenderLayerModelObject.cpp in a separate compilation unit
from the RenderLayerAllnOne file so that the scalar and vector destructors are visible to other
elements of WebCore during the build.
- WebCore.vcxproj/WebCore.vcxproj: Compile RenderLayerModelObject outside of the all-in-one file.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- rendering/RenderingAllInOne.cpp: Remove RenderLayerModelObject.cpp.
- 11:58 AM Changeset in webkit [156668] by
-
- 11 edits in trunk/Source
Pass VM instead of JSGlobalObject to RegExp constructor.
<https://webkit.org/b/122113>
Reviewed by Darin Adler.
RegExps don't need anything from the global object during their
construction and only use it to get to the VM. Reduce loads by
simply passing the VM around instead.
JSC release binary size -= 120 bytes(!)
- 11:13 AM Changeset in webkit [156667] by
-
- 2 edits in trunk/Source/WebKit
[Win] Compile errors in WebKit (via peavo@outlook.com).
https://bugs.webkit.org/show_bug.cgi?id=122106
Reviewed by Darin Adler.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add link
declarations missed in r156655.
- 11:09 AM Changeset in webkit [156666] by
-
- 9 edits in trunk
Fix the build when building against an SDK.
Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
the compiler command lines. It can't know to do this for the system framework search paths
we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig:
- 10:58 AM Changeset in webkit [156665] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Unreviewed build fix.
- WebCore.vcxproj/WebCore.vcxproj.filters: Correct malformed XML in project files.
- 10:56 AM Changeset in webkit [156664] by
-
- 11 edits in trunk
Unreviewed, roll back in r156546 with rebaselined tests.
https://bugs.webkit.org/show_bug.cgi?id=122111
Source/WebCore:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.updateHasAudio):
LayoutTests:
- platform/mac/TestExpectations:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/mac/fast/layers/video-layer-expected.png:
- platform/mac/fast/layers/video-layer-expected.txt:
- platform/mac/media/media-controls-clone-expected.png:
- platform/mac/media/media-controls-clone-expected.txt:
- platform/mac/media/video-no-audio-expected.txt:
- 10:38 AM Changeset in webkit [156663] by
-
- 3 edits3 deletes in trunk/LayoutTests
editing/execCommand/findString-diacriticals.html expects to fail
https://bugs.webkit.org/show_bug.cgi?id=122100
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
Reviewed by Alexey Proskuryakov.
Since all major platforms pass editing/execCommand/findString-diacriticals.html,
the test now globally expects "PASS" instead of "FAIL" rendering the individual
platform expectation files obsolete.
- editing/execCommand/findString-diacriticals-expected.txt: "PASS" -> "FAIL"
- platform/efl/TestExpectations: EFL passes editing/execCommand/findString-diacriticals.
- platform/gtk/editing/execCommand/findString-diacriticals-expected.txt: Removed.
- platform/mac/editing/execCommand/findString-diacriticals-expected.txt: Removed.
- platform/qt/editing/execCommand/findString-diacriticals-expected.txt: Removed.
- 10:36 AM Changeset in webkit [156662] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
it to be double-freed.
- WinLauncher/WinLauncher.cpp:
(EditProc): Be explicit about type passed to loadURL.
(loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
that reallocating the BSTR is done with the knowledge of the smart pointer.
- 9:59 AM Changeset in webkit [156661] by
-
- 5 edits in trunk
Unreviewed, rolling out r156656.
http://trac.webkit.org/changeset/156656
https://bugs.webkit.org/show_bug.cgi?id=122111
Broke several media tests (Requested by ap on #webkit).
Source/WebCore:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
LayoutTests:
- platform/mac/TestExpectations:
- platform/mac/media/video-no-audio-expected.txt:
- 9:50 AM Changeset in webkit [156660] by
-
- 7 edits in trunk/Source/WebCore
Convert a bunch of OwnPtrs on Page to std::unique_ptrs
https://bugs.webkit.org/show_bug.cgi?id=122086
Reviewed by Darin Adler.
- loader/ProgressTracker.cpp:
- loader/ProgressTracker.h:
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::setGroupName):
(WebCore::Page::initGroup):
- page/Page.h:
- page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
- page/PageGroup.h:
- 9:32 AM Changeset in webkit [156659] by
-
- 3 edits in trunk/LayoutTests
[EFL] Changed expectation for accessibility/file-upload-button-stringvalue.html after r156532
https://bugs.webkit.org/show_bug.cgi?id=122103
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
- platform/efl-wk1/TestExpectations: file-upload-button-stringvalue.html fails on efl-wk1.
Unskipped accessibility/heading-level.html. It passes after r156551.
- platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt:
- 9:30 AM Changeset in webkit [156658] by
-
- 7 edits2 deletes in trunk
[Qt] Fix force_static_libs_as_shared in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121961
Reviewed by Csaba Osztrogonác.
Get rid of the unused WebKit2QML library
.:
- Source/api.pri:
Source/WebKit2:
- Target.pri:
- WebKit2.pro:
- WebKit2QML.pri: Removed.
Tools:
- qmake/mkspecs/features/webkit_modules.prf:
- qmake/mkspecs/modules/webkit2qml.prf: Removed.
- 9:21 AM Changeset in webkit [156657] by
-
- 14 edits1 delete in trunk/Source/WebCore
Remove FontTranscoder
https://bugs.webkit.org/show_bug.cgi?id=122088
Reviewed by Andreas Kling.
This overly generic class just implements mapping of backslash to yen symbol for some legacy Japanese fonts.
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/Font.cpp:
(WebCore::useBackslashAsYenSignForFamily):
Move the family set to Font.cpp.
(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::update):
Keep the cached boolean up to date.
- platform/graphics/Font.h:
(WebCore::Font::useBackslashAsYenSymbol):
Use descriptive name instead of talking about "transcoding".
- platform/text/transcoder: Removed.
- platform/text/transcoder/FontTranscoder.cpp: Removed.
- platform/text/transcoder/FontTranscoder.h: Removed.
- rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::computeUseBackslashAsYenSymbol):
Rename for clarity.
Avoid unnecessary hash lookup, just check the cached bit in Font.
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::setTextInternal):
"Transcoding" here was just a simple character replacement.
(WebCore::RenderText::textWithoutConvertingBackslashToYenSymbol):
Renamed.
- rendering/RenderText.h:
- 9:09 AM Changeset in webkit [156656] by
-
- 5 edits in trunk
REGRESSION(r156546): media/video-no-audio.html broken
https://bugs.webkit.org/show_bug.cgi?id=122049
Reviewed by Eric Carlson.
Source/WebCore:
Now that our video elements have audio tracks, use their presence or
absense to show or hide the volume controls.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners): Listen for audioTrack changes.
(Controller.prototype.removeVideoListeners): Stop listening to same.
(Controller.prototype.handleAudioTrackChange): Call this.updateHasAudio()
(Controller.prototype.handleAudioTrackAdd): Ditto.
(Controller.prototype.handleAudioTrackRemove): Ditto.
(Controller.prototype.updateHasAudio): Hide the volume controls if no
audioTracks are present, and vice versa.
LayoutTests:
- platform/mac/TestExpectations:
- platform/mac/media/video-no-audio-expected.txt:
- 8:43 AM Changeset in webkit [156655] by
-
- 2 edits in trunk/Source/WebKit/win
Try to fix the Windows build.
- WebFrame.cpp:
(WebFrame::pauseAnimation):
(WebFrame::pauseTransition):
- 8:42 AM Changeset in webkit [156654] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix compilation for COMPILER(MSVC) && !CPU(X86) after r156490.
https://bugs.webkit.org/show_bug.cgi?id=122102
Reviewed by Geoffrey Garen.
_AddressOfReturnAddress() is supported for all platforms of
ths Microsoft compiler, so we can use it for !CPU(X86) too.
- jit/JITOperationWrappers.h:
- 8:39 AM Changeset in webkit [156653] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Mac-Lion build fix.
Use metadataItemsFromArray:withLocale: instead of
metadataItemsFromArray:filteredAndSortedAccordingToPreferredLanguages:
on Lion and earlier.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):
- 8:17 AM Changeset in webkit [156652] by
-
- 6 edits5 adds in trunk
[Mac] Add AudioTrack support to MediaPlayerPrivateAVFObC.
https://bugs.webkit.org/show_bug.cgi?id=122043
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/audio-track.html
Add a new class AudioTrackPrivateAVF and subclass AudioTrackPrivateAVFObjC
which are backed by a AVPlayerItemTrack. Create one of these tracks when
we are notified that the list of available tracks has changed.
- WebCore.xcodeproj/project.pbxproj:
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::setEnabled): Pass through to the AudioTrackPrivate
so that the underlying media track can be (dis|en)abled.
- platform/graphics/avfoundation/AudioTrackPrivateAVF.h: Added.
(WebCore::AudioTrackPrivateAVF::kind): Simple getter.
(WebCore::AudioTrackPrivateAVF::id): Ditto.
(WebCore::AudioTrackPrivateAVF::label): Ditto.
(WebCore::AudioTrackPrivateAVF::language): Ditto.
(WebCore::AudioTrackPrivateAVF::setKind): Simple Setter.
(WebCore::AudioTrackPrivateAVF::setId): Ditto.
(WebCore::AudioTrackPrivateAVF::setLabel): Ditto.
(WebCore::AudioTrackPrivateAVF::setLanguage): Ditto.
(WebCore::AudioTrackPrivateAVF::AudioTrackPrivateAVF): Simple constructor.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h: Added.
(WebCore::AudioTrackPrivateAVFObjC::create): Simple factory.
(WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Simple getter.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm: Added.
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Fill out the values from
the associated AVPlayerItemTrack and its AVAssetTrack.
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::setEnabled): (En|Dis)able the AVPlayerItemTrack.
(WebCore::AudioTrackPrivateAVFObjC::languageForAVAssetTrack): Refactored from
MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Determine which tracks
have been added or removed and notify the clients accordingly.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Refactor into
AudioTrackPrivateAVFObjC::languageForAVAssetTrack.
LayoutTests:
- media/track/audio-track-expected.txt: Added.
- media/track/audio-track.html: Added.
- 7:57 AM Changeset in webkit [156651] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Added passing expectation for fast/forms/textarea-metrics.html
https://bugs.webkit.org/show_bug.cgi?id=122107
Unreviewed EFL gardening.
fast/forms/textarea-metrics.html fails in WebKitTestRunner but returns expected
results in MiniBrowser. Since GTK uses platform dependent expectation file to
migitate this identical discrepancy, the same solution has been applied to EFL.
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
- platform/efl/TestExpectations:
- platform/efl/fast/forms/textarea-metrics-expected.txt: Added.
- 7:05 AM Changeset in webkit [156650] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r153927.
- WebView.cpp:
(WebView::WebView):
- 6:58 AM Changeset in webkit [156649] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r155289.
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):
- 6:57 AM Changeset in webkit [156648] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r154178.
- WebView.cpp:
(WebView::wndProc):
- 6:15 AM Changeset in webkit [156647] by
-
- 4 edits in trunk
[EFL] Fix incorrect click counting in EventSenderProxy
https://bugs.webkit.org/show_bug.cgi?id=122098
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-30
Reviewed by Gyuyoung Kim.
Tools:
Previously used two types of recording time, which conflicted with each other.
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::mouseUp):
LayoutTests:
After fixing EventSenderProxy extend-selection-after-double-click.html runs correctly.
- platform/efl/TestExpectations:
- 4:49 AM Changeset in webkit [156646] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening after the resolution of bug 84835
https://bugs.webkit.org/show_bug.cgi?id=122096
Unreviewed EFL gardening.
Removed expected failures for bug 84835.
editing/pasteboard/copy-inside-h1-preserves-h1 and
editing/pasteboard/copy-without-selection are still failing due to bug 86623
and have been marked accordingly.
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 3:56 AM Changeset in webkit [156645] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Two tests are passing in WK2 after r156541.
- platform/gtk-wk2/TestExpectations: Removed passing tests.
- 3:46 AM Changeset in webkit [156644] by
-
- 2 edits in trunk/LayoutTests
[EFL] Accessibility tests pass after r156532 and r156551
https://bugs.webkit.org/show_bug.cgi?id=122090
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
- platform/efl-wk2/TestExpectations:
- 3:44 AM Changeset in webkit [156643] by
-
- 2 edits in trunk/LayoutTests
[EFL] New test accessibility/table-with-hidden-head-section.html failing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=111850
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
Reviewed by Mario Sanchez Prada.
Test passes after r156532.
- platform/efl/TestExpectations:
- 3:39 AM Changeset in webkit [156642] by
-
- 5 edits in trunk/Source/WebCore
Generate toCSSCalcValue instead of using manual cast function
https://bugs.webkit.org/show_bug.cgi?id=122055
Reviewed by Antti Koivisto.
Generated type cast function supports more plenty functions rather than manual functions.
To use CSS_VALUE_TYPE_CAST, isCalculationValue() needs to be changed with isCalcValue().
No new tests, no behavior changes.
- css/CSSCalculationValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isCalcValue):
- css/StyleResolver.cpp:
(WebCore::hasVariableReference):
- 2:33 AM Changeset in webkit [156641] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Build fix for DEBUG_VERBOSE mode after r156511.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- 1:26 AM Changeset in webkit [156640] by
-
- 3 edits in trunk/Tools
[webkitpy] Make the Xvfb screen depth overridable
https://bugs.webkit.org/show_bug.cgi?id=122089
Reviewed by Gyuyoung Kim.
Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
was set. The default value that's used if the variable wasn't set is 24.
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._xvfb_screen_depth):
(XvfbDriver._start):
- Scripts/webkitpy/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_next_free_display):
(XvfbDriverTest.test_start_next_worker):
- 1:21 AM Changeset in webkit [156639] by
-
- 9 edits in trunk/Source/WebCore
Get rid of static map for marking ancestor line boxes dirty
https://bugs.webkit.org/show_bug.cgi?id=122080
Reviewed by Andreas Kling.
This is ugly and shows up in profiles too. Use a bit in RenderElement instead.
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.h:
Move dirtyLinesFromChangedChild down to RenderBlockFlow. It wouldn't do anything on other RenderBlocks.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
- rendering/RenderElement.h:
Add m_ancestorLineBoxDirty bit. We have 32 unused bits here on 64bit systems.
(WebCore::RenderElement::dirtyLinesFromChangedChild):
(WebCore::RenderElement::ancestorLineBoxDirty):
(WebCore::RenderElement::setAncestorLineBoxDirty):
(WebCore::RenderObject::setNeedsLayout):
- rendering/RenderInline.h:
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
Tighten the interface.
- rendering/RenderLineBoxList.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderObject.h:
Remove the static map.
- 1:14 AM Changeset in webkit [156638] by
-
- 9 edits2 adds in trunk
[CSS Grid Layout] Implement the grid-area shorthand
https://bugs.webkit.org/show_bug.cgi?id=103334
Reviewed by Andreas Kling.
Source/WebCore:
Based on Blink r151684 by <jchaffraix@chromium.org>
Test: fast/css-grid-layout/grid-item-area-get-set.html
Added support to specify grid positions using the
'-webkit-grid-area' shorthand. Named grid areas are still not
allowed, to be done in a follow up patch as it likely requires
'-webkit-grid-template' support.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):
- css/CSSPropertyNames.in:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
- css/StylePropertyShorthand.cpp:
(WebCore::webkitGridAreaShorthand):
(WebCore::shorthandForProperty):
- css/StylePropertyShorthand.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
LayoutTests:
From Blink r151684 by <jchaffraix@chromium.org>
- fast/css-grid-layout/grid-item-area-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-item-area-get-set.html: Added.
- 1:10 AM Changeset in webkit [156637] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Speculative build fix on ARMv7 Thumb2 after r156490.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::fmodAsDFGOperation):
- 12:35 AM Changeset in webkit [156636] by
-
- 8 edits in trunk/Source/WebCore
Generate toCSSFooValue for CSSGradientValue, CSSLinearGradientValue and CSSRadialGradient
https://bugs.webkit.org/show_bug.cgi?id=122060
Reviewed by Antti Koivisto.
As a step to generate toCSSFooValue, toCSSGradientValuem toCSSLinearGradientValue and
toCSSRadialGradient are generated. isLinearGradient() and isRadialGradient() are moved
from each class to CSSValue in order to generate toCSSFooValue.
No new tests, no behavior change.
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::gradientWithStylesResolved):
- css/CSSGradientValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseDeprecatedGradient):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isLinearGradient):
(WebCore::CSSValue::isRadialGradient):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
- 12:12 AM Changeset in webkit [156635] by
-
- 3 edits2 adds in trunk
user-select: none cursor turns to I-beam on mouse dragging
https://bugs.webkit.org/show_bug.cgi?id=90159
Patch by Vani Hegde <vani.hegde@samsung.com> on 2013-09-30
Reviewed by Ryosuke Niwa.
Source/WebCore:
When tried to select some text in an area that has style
cursor:default set, cursor type changes to text cursor ignoring
the cursor style that is explicitly set.
When the cursor style is explicitly set as default (or something else),
we should not change it to text cursor no matter what we are over
or what operation we are performing (be it hovering over the text
or selecting the text).
During text selection, changing the cursor type to text only when
there is no explicit cursor type set fixes the issue.
Test: editing/caret/selection-with-caret-type-progress.html
- page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
During selection, set the cursor style to text only if there is no
explicit cursor style set.
LayoutTests:
Test case added to verify that explicitly set cursor style
is retained on performing text selection.
- editing/caret/selection-with-caret-type-progress-expected.txt: Added.
- editing/caret/selection-with-caret-type-progress.html: Added.
Sep 29, 2013:
- 11:32 PM Changeset in webkit [156634] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: refactor compileAdd and compileArithSub into one function.
https://bugs.webkit.org/show_bug.cgi?id=122081
Patch by Nadav Rotem <nrotem@apple.com> on 2013-09-29
Reviewed by Geoffrey Garen.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAddSub):
- 10:40 PM Changeset in webkit [156633] by
-
- 5 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSCanvasValue
https://bugs.webkit.org/show_bug.cgi?id=122058
Reviewed by Antti Koivisto.
Generate toCSSFooValue() for CSSCanvasValue, and use it.
This type cast function will help to detect bad-casts.
isCanvasValue() is added in order to generate toCSSCanvasValue.
No new tests, no behavior change.
- css/CSSCanvasValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isCanvasValue):
- 10:38 PM Changeset in webkit [156632] by
-
- 5 edits in trunk/Source/ThirdParty
Take some Xcode advice about turning on additional warnings in ANGLE and gtest
https://bugs.webkit.org/show_bug.cgi?id=122087
Reviewed by Mark Rowe.
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig: Added some warnings that Xcode 5 suggested.
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig: Add some of the warnings that Xcode 5 suggested.
- src/compiler/preprocessor/Tokenizer.l: Defined YY_NO_INPUT so we don't compile
an unused function and get a warning.
- 10:30 PM Changeset in webkit [156631] by
-
- 9 edits in trunk
Fix the Lion build.
Ensure that C++ and Objective-C++ files build with the right compiler flags.
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig:
- 10:28 PM Changeset in webkit [156630] by
-
- 5 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSLineBoxContainValue
https://bugs.webkit.org/show_bug.cgi?id=122054
Reviewed by Darin Adler.
As a step to use toCSSFooValue, toCSSLineBoxContainValue is generated by using
CSS_VALUE_TYPE_CASTS. To use it, isCSSLineBoxContainValue() is changed to
isLineBoxContatinValue(). Unnecessary local variable is removed by this patch.
No new tests, no behavior changes.
- css/CSSLineBoxContainValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isLineBoxContainValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 10:26 PM Changeset in webkit [156629] by
-
- 4 edits in trunk/Source/WebCore
Generate toCSSCrossfadeValue() instead of using manual function
https://bugs.webkit.org/show_bug.cgi?id=122057
Reviewed by Antti Koivisto.
Generated toCSSFooValue() supports more plenty functions rather than
to use manual cast function.
No new tests, no behavior changes.
- css/CSSCrossfadeValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- 10:22 PM Changeset in webkit [156628] by
-
- 6 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue
https://bugs.webkit.org/show_bug.cgi?id=122056
Reviewed by Antti Koivisto.
Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue, and use it.
This type cast function will help to detect bad-casts.
No new tests, no behavior changes.
- css/CSSFilterImageValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSInitialValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::generatedOrPendingFromValue):
- 9:57 PM Changeset in webkit [156627] by
-
- 2 edits in trunk/Source/WebCore
Fix crashes caused by my recent attempt at a Windows build fix.
- bindings/js/WebCoreTypedArrayController.cpp: (WebCore::WebCoreTypedArrayController::toJS): Added back the prefix for the call to WebCore::toJS, otherwise this function just calls itself infinitely recursively.
- 9:56 PM Changeset in webkit [156626] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):
- 9:36 PM Changeset in webkit [156625] by
-
- 14 edits in trunk/Source/WebCore
Cleanup PageThrottler and PageConsole a bit
https://bugs.webkit.org/show_bug.cgi?id=122085
Reviewed by Anders Carlsson.
- html/HTMLMediaElement.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::completed):
- loader/FrameLoader.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
- loader/SubresourceLoader.h:
Store the PageActivityAssertionToken as a std::unique_ptr.
- page/Page.cpp:
(WebCore::Page::Page):
Use createOwned and pass this by reference for the PageThrottler and PageConsole.
(WebCore::Page::~Page):
Remove unnecessary clearing of an OwnPtr that is about to be destroyed.
- page/Page.h:
Make m_pageThrottler const and return it as a reference.
- page/PageActivityAssertionToken.cpp:
(WebCore::PageActivityAssertionToken::PageActivityAssertionToken):
(WebCore::PageActivityAssertionToken::~PageActivityAssertionToken):
- page/PageActivityAssertionToken.h:
Take the PageThrottler by reference in the constructor. It is never null.
- page/PageConsole.cpp:
(WebCore::PageConsole::PageConsole):
(WebCore::PageConsole::~PageConsole):
(WebCore::PageConsole::addMessage):
- page/PageConsole.h:
Pass and store the Page as a reference and remove an extraneous null check. Remove
the create function.
- page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
(WebCore::PageThrottler::~PageThrottler):
(WebCore::PageThrottler::createActivityToken):
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
(WebCore::PageThrottler::addActivityToken):
(WebCore::PageThrottler::removeActivityToken):
- page/PageThrottler.h:
Pass and store the Page as a reference. Move the creation of PageActivityAssertionToken here
to aid encapsulation.
- 8:45 PM Changeset in webkit [156624] by
-
- 52 edits in trunk/Source
Pass VM instead of JSGlobalObject to function constructors.
<https://webkit.org/b/122082>
Reviewed by Darin Adler.
Functions don't need anything from the global object during their
construction and only use it to get to the VM. Reduce loads by
simply passing the VM around instead.
This patch is mostly mechanical, I just changed the signature of
InternalFunction and worked my way from there until it built.
JSC release binary size -= 4840 bytes.
- 7:54 PM Changeset in webkit [156623] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Windows build.
- bindings/js/WebCoreTypedArrayController.cpp: Windows has a symbol named Handle, so we need to call JSC::Handle out by name. To fix that, I removed "using namespace JSC" entirely. And just for fun, sort of "rewrote" this file. (WebCore::WebCoreTypedArrayController::WebCoreTypedArrayController): Removed unneeded explicit initialization of m_owner. (WebCore::WebCoreTypedArrayController::~WebCoreTypedArrayController): Fixed formatting. (WebCore::WebCoreTypedArrayController::toJS): Added lots of explicit JSC and got rid of local. (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::isReachableFromOpaqueRoots): Cut down on locals, used auto& for type, and called it "wrapper" since that's what JSArrayBuffer is. (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize): More of the same.
- 7:40 PM Changeset in webkit [156622] by
-
- 138 edits in trunk/Source
Use RenderElement instead of RenderObject in many places
https://bugs.webkit.org/show_bug.cgi?id=122078
Reviewed by Andreas Kling.
Source/ThirdParty/ANGLE:
- ANGLE.xcodeproj/project.pbxproj: Let Xcode do its thing to this file.
Source/WebCore:
- WebCore.exp.in: Updated for name changes.
- dom/ContainerNode.h: Moved renderer() here from Element.
- dom/Element.h: Moved renderer() from here to ContainerNode.
- render/RenderElement.h: Moved renderer() from Element to ContainerNode.
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
(WebCore::AccessibilityImageMapLink::detachFromParent):
(WebCore::AccessibilityImageMapLink::elementPath):
(WebCore::AccessibilityImageMapLink::elementRect):
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- bindings/objc/DOM.mm:
(-[DOMElement image]):
(-[DOMElement _font]):
(-[DOMElement _imageTIFFRepresentation]):
- css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):
(WebCore::CSSCanvasValue::canvasDestroyed):
(WebCore::CSSCanvasValue::fixedSize):
(WebCore::CSSCanvasValue::image):
- css/CSSCanvasValue.h:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::computeRenderStyleForProperty):
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):
(WebCore::CSSCrossfadeValue::image):
(WebCore::CSSCrossfadeValue::crossfadeChanged):
- css/CSSCrossfadeValue.h:
- css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::fixedSize):
(WebCore::CSSFilterImageValue::knownToBeOpaque):
(WebCore::CSSFilterImageValue::image):
(WebCore::CSSFilterImageValue::filterImageChanged):
- css/CSSFilterImageValue.h:
- css/CSSFontSelector.cpp:
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::addStops):
(WebCore::CSSGradientValue::knownToBeOpaque):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):
- css/CSSGradientValue.h:
(WebCore::CSSGradientValue::fixedSize):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):
- css/CSSImageGeneratorValue.h:
(WebCore::CSSImageGeneratorValue::clients):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::knownToBeOpaque):
- css/CSSImageValue.h:
- css/DeprecatedStyleBuilder.cpp:
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::removeMarkersFromList):
(WebCore::DocumentMarkerController::repaintMarkers):
- dom/Element.cpp:
(WebCore::localZoomForRenderer):
(WebCore::adjustForLocalZoom):
(WebCore::Element::offsetParent):
(WebCore::Element::updateExistingPseudoElement):
- dom/ElementRareData.h:
(WebCore::ElementRareData::create):
(WebCore::ElementRareData::ElementRareData):
- dom/Node.cpp:
(WebCore::Node::ensureRareData):
- editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
- editing/Editor.cpp:
(WebCore::Editor::hasBidiSelection):
(WebCore::Editor::baseWritingDirectionForSelectionStart):
- editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
- editing/htmlediting.cpp:
(WebCore::directionOfEnclosingBlock):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::fontForSelection):
(WebCore::getImage):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontForSelection):
(WebCore::getImage):
- editing/markup.cpp:
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::computePath):
(WebCore::HTMLAreaElement::computeRect):
(WebCore::HTMLAreaElement::setFocus):
- html/HTMLAreaElement.h:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reset):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setInnerText):
- html/HTMLFormControlElement.cpp:
(WebCore::updateFromElementCallback):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
- html/HTMLFrameOwnerElement.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::x):
(WebCore::HTMLImageElement::y):
(WebCore::HTMLImageElement::willRespondToMouseClickEvents):
- html/HTMLMapElement.cpp:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::defaultEventHandler):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::renderMeter):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::didRecalcStyle):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
(WebCore::HTMLPlugInElement::defaultEventHandler):
(WebCore::HTMLPlugInElement::isKeyboardFocusable):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::defaultEventHandler):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::renderProgress):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::scrollToSelection):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
(WebCore::HTMLSelectElement::selectOption):
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::cellAbove):
- html/HTMLTextFormControlElement.cpp:
(WebCore::hasVisibleTextArea):
(WebCore::HTMLTextFormControlElement::setSelectionRange):
- html/InputType.h:
- html/parser/HTMLResourcePreloader.cpp:
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlElement::setDisplayType):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::startDrag):
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
- html/shadow/MeterShadowElement.cpp:
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore::MeterInnerElement::rendererIsNeeded):
- inspector/InspectorOverlay.cpp:
- inspector/InspectorTimelineAgent.cpp:
- inspector/InspectorTimelineAgent.h:
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::renderImageResource):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::currentFrameKnownToBeOpaque):
- loader/cache/CachedImage.h:
- mathml/MathMLElement.cpp:
- page/ContextMenuController.cpp:
- page/DragController.cpp:
(WebCore::DragController::draggableElement):
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::startPanScrolling):
(WebCore::EventHandler::autoscrollRenderer):
(WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::logicalScrollOverflow):
(WebCore::EventHandler::subframeForTargetNode):
(WebCore::EventHandler::selectCursor):
(WebCore::layerForNode):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::clearGestureScrollNodes):
- page/EventHandler.h:
- page/FocusController.cpp:
- page/Frame.cpp:
(WebCore::Frame::ownerRenderer):
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::nodeImage):
- page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::applyPaginationToViewport):
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::isEnclosedInCompositingLayer):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::repaintSlowRepaintObjects):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::updateOverflowStatus):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
- page/FrameView.h:
- page/PageSerializer.cpp:
(WebCore::PageSerializer::addImageToResources):
- page/PageSerializer.h:
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::AnimationBase):
(WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationBase.h:
(WebCore::AnimationBase::renderer):
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
(WebCore::AnimationControllerPrivate::clear):
(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::getAnimatedStyleForRenderer):
(WebCore::AnimationController::notifyAnimationStarted):
(WebCore::AnimationController::pauseAnimationAtTime):
(WebCore::AnimationController::pauseTransitionAtTime):
(WebCore::AnimationController::isRunningAnimationOnRenderer):
(WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):
- page/animation/AnimationController.h:
- page/animation/AnimationControllerPrivate.h:
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::crossfadeBlend):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
- page/animation/CompositeAnimation.h:
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::ImplicitAnimation::animate):
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):
- page/animation/ImplicitAnimation.h:
(WebCore::ImplicitAnimation::create):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):
- page/animation/KeyframeAnimation.h:
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passSubframeEventToSubframe):
- page/mac/FrameSnapshottingMac.mm:
(WebCore::snapshotDragImage):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::paint):
- rendering/CounterNode.cpp:
(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::create):
- rendering/CounterNode.h:
(WebCore::CounterNode::owner):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::buildReferenceFilter):
(WebCore::FilterEffectRenderer::build):
- rendering/FilterEffectRenderer.h:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::spellingToolTip):
(WebCore::HitTestResult::title):
(WebCore::HitTestResult::innerTextIfTruncated):
(WebCore::HitTestResult::image):
- rendering/LayoutRepainter.cpp:
(WebCore::LayoutRepainter::LayoutRepainter):
- rendering/LayoutRepainter.h:
- rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
- rendering/LineWidth.h:
- rendering/LogicalSelectionOffsetCaches.h:
(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject):
(WebCore::isNonRenderBlockInline):
(WebCore::containingBlockForFixedPosition):
(WebCore::containingBlockForAbsolutePosition):
(WebCore::containingBlockForObjectInFlow):
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
- rendering/PaintInfo.h:
(WebCore::PaintInfo::PaintInfo):
(WebCore::PaintInfo::updateSubtreePaintRootForChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/RenderBoxModelObject.h:
- rendering/RenderCounter.cpp:
(WebCore::nextInPreOrder):
(WebCore::planCounter):
(WebCore::makeCounterNode):
(WebCore::RenderCounter::originalText):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::willBeDestroyed):
(WebCore::RenderElement::rendererForRootBackground):
- rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::initialize):
- rendering/RenderImageResource.h:
- rendering/RenderImageResourceStyleImage.cpp:
(WebCore::RenderImageResourceStyleImage::initialize):
- rendering/RenderImageResourceStyleImage.h:
(WebCore::RenderImageResourceStyleImage::create):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::canBeComposited):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
(WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters):
(WebCore::RenderLayerCompositor::requiresCompositingForBlending):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):
- rendering/RenderLayerCompositor.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
(WebCore::mustRepaintFillLayers):
(WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered):
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::rendererOwningScrollbar):
- rendering/RenderScrollbarPart.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
- rendering/RenderTableCell.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::hasOpaqueImage):
- rendering/style/FillLayer.h:
- rendering/style/KeyframeList.h:
(WebCore::KeyframeList::KeyframeList):
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::imageSize):
(WebCore::StyleCachedImage::computeIntrinsicDimensions):
(WebCore::StyleCachedImage::setContainerSizeForRenderer):
(WebCore::StyleCachedImage::addClient):
(WebCore::StyleCachedImage::removeClient):
(WebCore::StyleCachedImage::image):
(WebCore::StyleCachedImage::knownToBeOpaque):
- rendering/style/StyleCachedImage.h:
- rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::imageSize):
(WebCore::StyleCachedImageSet::computeIntrinsicDimensions):
(WebCore::StyleCachedImageSet::setContainerSizeForRenderer):
(WebCore::StyleCachedImageSet::addClient):
(WebCore::StyleCachedImageSet::removeClient):
(WebCore::StyleCachedImageSet::image):
(WebCore::StyleCachedImageSet::knownToBeOpaque):
- rendering/style/StyleCachedImageSet.h:
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
(WebCore::StyleGeneratedImage::addClient):
(WebCore::StyleGeneratedImage::removeClient):
(WebCore::StyleGeneratedImage::image):
(WebCore::StyleGeneratedImage::knownToBeOpaque):
- rendering/style/StyleGeneratedImage.h:
- rendering/style/StyleImage.h:
(WebCore::StyleImage::imagesEquivalent):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):
(WebCore::StylePendingImage::computeIntrinsicDimensions):
- testing/Internals.cpp:
(WebCore::Internals::boundingBox):
(WebCore::Internals::isSelectPopupVisible):
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured):
Use RenderElement instead of RenderObject where it was easy to do so.
For local variables holding the return value of renderer() functions,
use auto instead, so the most-specific possible type will be used,
without having to figure out what that is in each case. Also use some
more OVERRIDE and FINAL and use nullptr instead of 0. And replace some
cryptic short local variable names with words.
- 5:57 PM Changeset in webkit [156621] by
-
- 4 edits in trunk/Source/JavaScriptCore
Pass VM instead of JSGlobalObject to ArrayPrototype constructor.
<https://webkit.org/b/122079>
Reviewed by Geoffrey Garen.
ArrayPrototype doesn't need the global object for anything during
construction, so reduce the amount of loads by just passing the VM.
- 3:20 PM Changeset in webkit [156620] by
-
- 31 edits in trunk/Source
Pass VM instead of ExecState to simple builtin constructors.
<https://webkit.org/b/122077>
Reviewed by Sam Weinig.
None of the simple builtins need the ExecState for anything during
their construction, so reduce the amount of loads by just passing
the VM around instead.
- 3:16 PM Changeset in webkit [156619] by
-
- 8 edits3 adds in trunk
Repaint borders and outlines on pseudo content changes
https://bugs.webkit.org/show_bug.cgi?id=122070
Reviewed by Andreas Kling.
Source/WebCore:
This patch fixes a regression from wkrev.com/150259 where pseudo content with
borders or outlines would fail to repaint if the color property changed.
The root bug is that border-color and outline-color properties use 'color' if
no explicit border-color or outline-color are given, and changing color should
repaint borders and outlines even if the text content is empty.
Relevant spec sections:
border: http://www.w3.org/TR/CSS1/#border-color
outline: http://www.w3.org/TR/CSS2/ui.html#propdef-outline-color
This patch also renames StyleDifferenceRepaintIfText to
StyleDifferenceRepaintIfTextOrBorderOrOutline and updates the relevant functions.
Test: fast/repaint/hover-pseudo-borders.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::hasImmediateNonWhitespaceTextChildOrBorderOrOutline):
This function has been renamed to reflect that it returns true for borders
or outlines as well.
(WebCore::RenderElement::shouldRepaintForStyleDifference):
- rendering/RenderElement.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):
These have also been renamed to reflect the new borders and outlines check.
LayoutTests:
- fast/repaint/hover-pseudo-borders.html: Added.
- platform/mac/fast/repaint/hover-pseudo-borders-expected.png: Added.
- platform/mac/fast/repaint/hover-pseudo-borders-expected.txt: Added.
- 1:50 PM Changeset in webkit [156618] by
-
- 6 edits in trunk/Source/WebCore
Tighten typing in inline rendering
https://bugs.webkit.org/show_bug.cgi?id=122076
Reviewed by Andreas Kling.
More RenderElement, const, &, etc.
- dom/Position.cpp:
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- rendering/InlineFlowBox.cpp:
(WebCore::isLastChildForRenderer):
(WebCore::isAncestorAndWithinBlock):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineIterator.h:
(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::root):
(WebCore::isEmptyInline):
(WebCore::bidiNextShared):
(WebCore::bidiNextSkippingEmptyInlines):
(WebCore::bidiNextIncludingEmptyInlines):
(WebCore::bidiFirstSkippingEmptyInlines):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
(WebCore::alwaysRequiresLineBox):
(WebCore::requiresLineBox):
(WebCore::canBreakAtThisPosition):
(WebCore::LineBreaker::nextSegmentBreak):
- rendering/shapes/ShapeInsideInfo.h:
(WebCore::LineSegmentIterator::LineSegmentIterator):
- 12:31 PM Changeset in webkit [156617] by
-
- 2 edits in trunk/Source/JavaScriptCore
Refactor code for finding x86 scratch register.
https://bugs.webkit.org/show_bug.cgi?id=122072
Patch by Nadav Rotem <nrotem@apple.com> on 2013-09-29
Reviewed by Geoffrey Garen.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::getUnusedRegister):
(JSC::MacroAssemblerX86Common::store8):
(JSC::MacroAssemblerX86Common::store16):
- 11:04 AM Changeset in webkit [156616] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening. Skip the IndexedDB tests for now as the feature is going
through substantial changes that don't ensure constant proper functionality.
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
Sep 28, 2013:
- 11:02 PM Changeset in webkit [156615] by
-
- 9 edits2 deletes in trunk/Source/WebCore
Merge ScriptControllerBase into ScriptController
https://bugs.webkit.org/show_bug.cgi?id=122071
Reviewed by Antti Koivisto.
There is no need for ScriptControllerBase. Remove it.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/ScriptControllerBase.cpp: Removed.
- bindings/ScriptControllerBase.h: Removed.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::canExecuteScripts):
(WebCore::ScriptController::executeScript):
(WebCore::ScriptController::executeIfJavaScriptURL):
- bindings/js/ScriptController.h:
- 10:42 PM Changeset in webkit [156614] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r156613 for ports enabling CSS3_TEXT.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::requiresIndent): Use the RenderStyle reference.
- 9:34 PM Changeset in webkit [156613] by
-
- 21 edits in trunk/Source/WebCore
Switch inline boxes to use const RenderStyle&
https://bugs.webkit.org/show_bug.cgi?id=122068
Reviewed by Sam Weinig.
- 1:20 PM Changeset in webkit [156612] by
-
- 12 edits in trunk/Source/WebCore
Add first()/last() to ElementIteratorAdapters
https://bugs.webkit.org/show_bug.cgi?id=122067
Reviewed by Darin Adler.
Add a convenient way for getting the first and last element if it exists.
Use it in some places.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- dom/Document.cpp:
(WebCore::Document::childrenChanged):
(WebCore::Document::removeTitle):
- dom/ElementChildIterator.h:
(WebCore::::first):
(WebCore::::last):
- dom/ElementDescendantIterator.h:
(WebCore::::first):
(WebCore::::last):
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::legend):
- html/HTMLLegendElement.cpp:
(WebCore::HTMLLegendElement::associatedControl):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::finishParsingChildren):
(WebCore::HTMLMediaElement::selectMediaResource):
- svg/SVGElement.cpp:
(WebCore::SVGElement::title):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::hasSingleSecurityOrigin):
- 1:01 PM Changeset in webkit [156611] by
-
- 18 edits2 copies in trunk
Fix some failures with newer versions of clang.
Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
Reviewed by Dan Bernstein.
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/DebugRelease.xcconfig:
- Configurations/WebKit.xcconfig:
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
- DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
- DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
- WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
- 12:15 PM Changeset in webkit [156610] by
-
- 17 edits in trunk/Source
Take Xcode's advice and enable some extra warnings.
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
Source/WebCore:
- Configurations/Base.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::removeNamedItemNS): Use the correct constant.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- WebKit2.xcodeproj/project.pbxproj:
Source/WTF:
- Configurations/Base.xcconfig:
- WTF.xcodeproj/project.pbxproj:
- 12:10 PM Changeset in webkit [156609] by
-
- 4 edits in trunk/Source/WebCore
CTTE: VisitedLinkState should hold a Document&
https://bugs.webkit.org/show_bug.cgi?id=122066
Reviewed by Antti Koivisto.
The Document can never be null, so use a reference.
- 11:30 AM Changeset in webkit [156608] by
-
- 23 edits in trunk/Source/WebCore
Clean up code for getting first line style
https://bugs.webkit.org/show_bug.cgi?id=122037
Reviewed by Andreas Kling.
We have confusing RenderObject::style(bool firstLine). Get rid of it in favour of
just using RenderObject::firstLineStyle() where appropriate.
Also switch to RenderStyle references in many places and move first line style caching
code down to RenderElement.
- 10:19 AM Changeset in webkit [156607] by
-
- 44 edits in trunk/Source
Add Frame::mainFrame and Frame::isMainFrame
https://bugs.webkit.org/show_bug.cgi?id=122064
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in: Removed exports of FrameView::isMainFrameView and
Page::frameIsMainFrame. Since the new isMainFrame function is inline, it
does not need to be exported.
- history/PageCache.cpp:
(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore::PageCache::markPagesForDeviceScaleChanged):
These two were the only functions I found that really wanted the equivalent
of Page::frameIsMainFrame, so wrote it out here instead of using a function
call.
- inspector/InspectorAgent.cpp: Removed the unused isMainResourceLoader function.
- inspector/InspectorAgent.h: Removed declarations of a few nonexistent or
unused private member functions. Also removed the InjectedScriptForOriginMap
typedef: It's mor readable to use the type directly
- loader/FrameLoader.h: Removed isLoadingMainFrame. It's not better than
calling frame().isMainFrame() directly.
- page/Frame.cpp:
(WebCore::Frame::Frame): Initialize m_mainFrame and call selfOnlyRef, keeping
the MainFrame alive as long as any of its subframes is alive.
(WebCore::Frame::~Frame): Call selfOnlyDeref.
(WebCore::Frame::createView): Use isMainFrame.
(WebCore::Frame::setPageAndTextZoomFactors): Ditto.
- page/Frame.h: Added Frame::mainFrame, Frame::isMainFrame, and Frame::m_mainFrame.
- page/FrameView.h: Removed the isMainFrameView function. It's not better than
calling frame().isMainFrame() directly.
- page/MainFrame.cpp:
(WebCore::MainFrame::MainFrame): Initialize m_selfOnlyRefCount to 0.
(WebCore::MainFrame::selfOnlyRef): Added.
(WebCore::MainFrame::selfOnlyDeref): Added.
(WebCore::MainFrame::dropChildren): Added. Called when the self-only reference
count reaches 0 to avoid a reference cycle with subframes.
- page/MainFrame.h: Added new data members as mentioned above. Also, the
definition of the Frame::isMainFrame inline function goes here, since it can't
compile without the MainFrame class definition. This means that callers of
isMainFrame need to include MainFrame.h, which seems reasonable and is easy
to do.
- page/Page.cpp:
- page/Page.h: Added assertion to Page::mainFrame since it returns a reference.
Removed Page::frameIsMainFrame since it's not better than calling isMainFrame
on the frame.
- dom/Document.cpp:
(WebCore::Document::setVisualUpdatesAllowed):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::setInPageCache):
(WebCore::Document::ensurePlugInsInjectedScript):
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::shouldShrinkToFit):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::didClearWindowObjectInWorld):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameNavigated):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::prepareForCachedPageRestore):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::didLayout):
(WebCore::FrameLoader::checkLoadComplete):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::loadResourceSynchronously):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidCommitLoad):
(WebCore::FrameLoader::loadProgressingStatusChanged):
- loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
(WebCore::HistoryController::restoreScrollPositionAndViewState):
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::updateForSameDocumentNavigation):
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
(WebCore::HistoryController::pushState):
- loader/icon/IconController.cpp:
(WebCore::IconController::startLoader):
- page/AutoscrollController.cpp:
(WebCore::AutoscrollController::stopAutoscrollTimer):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
- page/DOMWindow.cpp:
(WebCore::allowsBeforeUnloadListeners):
(WebCore::DOMWindow::focus):
(WebCore::DOMWindow::blur):
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::allowedToChangeWindowGeometry):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::keyEvent):
- page/FrameTree.cpp:
(WebCore::FrameTree::find):
(WebCore::FrameTree::traverseNextWithWrap):
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::createScrollbar):
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
(WebCore::FrameView::minimumScrollPosition):
(WebCore::FrameView::maximumScrollPosition):
(WebCore::FrameView::shouldUpdateFixedElementsAfterScrolling):
(WebCore::FrameView::beginDeferredRepaints):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEventIfNeeded):
(WebCore::FrameView::pagination):
(WebCore::FrameView::visibleContentScaleFactor):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::scrollbarStyleChanged):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintScrollbar):
(WebCore::FrameView::paintOverhangAreas):
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
Use the new functions where possible instead of Page::frameIsMainFrame,
Page::mainFrame, FrameLoader::isLoadingMainFrame, and FrameView::isMainFrameView.
Source/WebKit/blackberry:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
Call isMainFrame.
Source/WebKit/efl:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientEfl::updateGlobalHistory):
Call isMainFrame.
Source/WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
Call isMainFrame.
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::canHandleRequest):
(WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebView/WebFrameView.mm:
(-[WebFrameView _install]):
Call isMainFrame.
Source/WebKit2:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrameView):
Call isMainFrame.
- 9:14 AM Changeset in webkit [156606] by
-
- 3 edits8 adds in trunk
filter: drop-shadow doesnot support viewport units
https://bugs.webkit.org/show_bug.cgi?id=122053
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-28
Reviewed by Darin Adler.
Source/WebCore:
drop-shadow properties were not applied incase its values
were given in vh, vw, vmax, vmin units.
Tests: fast/css/drop-shadow-viewport-height.html
fast/css/drop-shadow-viewport-vmax.html
fast/css/drop-shadow-viewport-vmin.html
fast/css/drop-shadow-viewport-width.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createFilterOperations):
Calculating the drop-shadow values which has been specified in viewport
units.The vh/vw units are calcultated as percent of viewport height and
viewport width respectively. 1vmax: 1vw or 1vh, whatever is largest.
1vmin: 1vw or 1vh, whatever is smallest.
LayoutTests:
- fast/css/drop-shadow-viewport-height-expected-mismatch.html: Added.
- fast/css/drop-shadow-viewport-height.html: Added.
- fast/css/drop-shadow-viewport-vmax-expected-mismatch.html: Added.
- fast/css/drop-shadow-viewport-vmax.html: Added.
- fast/css/drop-shadow-viewport-vmin-expected-mismatch.html: Added.
- fast/css/drop-shadow-viewport-vmin.html: Added.
- fast/css/drop-shadow-viewport-width-expected-mismatch.html: Added.
- fast/css/drop-shadow-viewport-width.html: Added.
Added new tests for verifying that drop-shadow properties are applied
when its values are viewport units.
- 9:10 AM Changeset in webkit [156605] by
-
- 5 edits16 adds in trunk
REGRESSION (r154614): Setting the document scroll position isn't symmetric; can successfully set document.body.scrollTop, but can only read from document.documentElement.scrollTop
https://bugs.webkit.org/show_bug.cgi?id=121876
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-28
Reviewed by Darin Adler.
Source/WebCore:
Non-Quirks mode should set/get scrolltop/scrollleft through
document.documentElement.scrollTop/document.documentElement.scrollLeft
Quirks mode should set/get scrolltop/scrollleft through
document.body.scrollTop/document.body.scrollLeft.
Tests: fast/dom/Element/body-scrollLeft-Quirks.html
fast/dom/Element/body-scrollLeft.html
fast/dom/Element/body-scrollTop-Quirks.html
fast/dom/Element/body-scrollTop.html
fast/dom/Element/documentElement-scrollLeft-Quirks.html
fast/dom/Element/documentElement-scrollLeft.html
fast/dom/Element/documentElement-scrollTop-Quirks.html
fast/dom/Element/documentElement-scrollTop.html
- dom/Element.cpp:
(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
Need to set the scrollTop and scrollLeft after checking if document
is in quirks or non-quirks mode. Incase it is body.scrollLeft/
body.scrollTop set only if document is in quirks mode. If document is
non-quirks mode set documentElement.scrollLeft/documentElement.scrollTop.
LayoutTests:
- fast/dom/Element/body-scrollLeft-Quirks-expected.txt: Added.
- fast/dom/Element/body-scrollLeft-Quirks.html: Added.
- fast/dom/Element/body-scrollLeft-expected.txt: Added.
- fast/dom/Element/body-scrollLeft.html: Added.
- fast/dom/Element/body-scrollTop-Quirks-expected.txt: Added.
- fast/dom/Element/body-scrollTop-Quirks.html: Added.
- fast/dom/Element/body-scrollTop-expected.txt: Added.
- fast/dom/Element/body-scrollTop.html: Added.
- fast/dom/Element/documentElement-scrollLeft-Quirks-expected.txt: Added.
- fast/dom/Element/documentElement-scrollLeft-Quirks.html: Added.
- fast/dom/Element/documentElement-scrollLeft-expected.txt: Added.
- fast/dom/Element/documentElement-scrollLeft.html: Added.
- fast/dom/Element/documentElement-scrollTop-Quirks-expected.txt: Added.
- fast/dom/Element/documentElement-scrollTop-Quirks.html: Added.
- fast/dom/Element/documentElement-scrollTop-expected.txt: Added.
- fast/dom/Element/documentElement-scrollTop.html: Added.
Added test cases for verifying that Non-Quirks mode should set
scrolltop/scrollleft through document.documentElement.scrollTop/
document.documentElement.scrollLeft and Quirks mode should set/get
scrolltop/scrollleft through document.body.scrollTop/document.body.scrollLeft.
- fast/multicol/scrolling-overflow.html:
Rebaselining existing tests as per the new behavior. To set
document.body.scrollLeft document to be in Quirks mode.
- 8:05 AM Changeset in webkit [156604] by
-
- 7 edits in trunk/Source/WebKit2
Message sending functions should only accept rvalues
https://bugs.webkit.org/show_bug.cgi?id=122041
Reviewed by Andreas Kling.
In order to safely encode move-only types, make all send variants accept rvalues only, except
for the "send to all processes" ones. For them, copy the message before sending. This ensures that trying
to send a move-only type in a message will fail to compile.
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::sendSync):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):
- UIProcess/WebContext.h:
(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):
(WebKit::WebContext::sendToAllProcesses):
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
(WebKit::WebContext::sendToOneProcess):
- UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
- 8:02 AM Changeset in webkit [156603] by
-
- 5 edits in trunk/Source
Unreviewed GTK build fix after r156560.
Source/WebKit/gtk:
- WebCoreSupport/AcceleratedCompositingContext.h:
Source/WebKit2:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::paintContents):
(WebKit::LayerTreeHostGtk::createPageOverlayLayer):
(WebKit::LayerTreeHostGtk::destroyPageOverlayLayer):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 7:15 AM Changeset in webkit [156602] by
-
- 25 edits in trunk/Source
Pass VM instead of ExecState to JSFunction constructors.
<https://webkit.org/b/122014>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
JSFunction doesn't need the ExecState for anything during its
construction, so reduce the amount of loads by just passing the
VM around instead.
Factored out putDirectNonIndexAccessor() from the existing
putDirectAccessor() to avoid snowballing the patch (and because
it's kinda neat to avoid the extra branch.)
JSC release binary size -= 9680 bytes.
Source/WebCore:
Updated for new JSFunction::create() signature.
- 6:27 AM Changeset in webkit [156601] by
-
- 10 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSImageValue
https://bugs.webkit.org/show_bug.cgi?id=122051
Reviewed by Andreas Kling.
Clean up static_cast<CSSImageValue*> type casts. It will help to
detect bad cast as well as improve code readability.
Removed unnecessary local variables as well.
No new tests, no behavior changes.
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::isSVGCursor):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
- css/CSSImageValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForProperties):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::data):
(WebCore::StylePendingImage::cssImageValue):
- 3:26 AM Changeset in webkit [156600] by
-
- 21 edits in trunk/Source/WebCore
WebCore fails to build with newer versions of clang.
Reviewed by Sam Weinig.
- Modules/indexeddb/IDBIndex.cpp: Remove an unused constant.
- Modules/indexeddb/IDBObjectStore.cpp: Ditto.
- Modules/webaudio/AudioContext.cpp: Ditto.
- Modules/webaudio/ScriptProcessorNode.cpp: Ditto.
- Modules/webdatabase/SQLResultSet.cpp: Ditto.
- Modules/webdatabase/SQLTransactionBackend.cpp: Ditto.
- Modules/websockets/WebSocketHandshake.cpp: Ditto.
- bindings/objc/DOM.mm: Disable a warning about overriding a protocol method in a cateogry around the one
place we do it. I don't understand why this generates a warning, nor can I see a different approach that
would not result in the warning being emitted.
- css/CSSGrammar.y.in: #if a function that's only used inside an #if.
- html/track/TextTrackCue.cpp: Remove an unused constant.
- loader/TextResourceDecoder.cpp: Remove two unused functions.
- page/ContentSecurityPolicy.cpp: Add #if's around constants and functions that are only used when CSP_NEXT is enabled.
(WebCore::CSPDirectiveList::checkSourceAndReportViolation): Reorder the ifs slightly to make the #if'ing easier.
- page/ContentSecurityPolicy.h: Add #if's around functions that are only used when CSP_NEXT is enabled.
- page/DOMSecurityPolicy.cpp: Ditto.
- page/DOMSecurityPolicy.h: Ditto.
- page/animation/CSSPropertyAnimation.cpp: Remove an unused function.
- platform/mac/DisplaySleepDisabler.cpp: Add an #if around a constant that's only used on iOS.
- platform/mac/WebCoreFullScreenWarningView.mm: Remove three unused constants.
- rendering/RenderLayer.cpp: Remove two unused constants.
- rendering/RenderLayerCompositor.cpp:
(WebCore::compositingLogEnabled): Move the #if around the function definition.
- svg/SVGAnimatedAngle.cpp: Remove an unused function.
- svg/SVGUseElement.cpp: #if a function that's only used inside an ASSERT.
- xml/XPathStep.cpp: Ditto.
- 3:25 AM Changeset in webkit [156599] by
-
- 6 edits in trunk/Source/WebKit/mac
WebKit fails to build with newer versions of clang.
Reviewed by Sam Weinig.
- Carbon/HIWebView.mm: Remove an unused function.
- History/BinaryPropertyList.cpp: #if a constant that's only used in 64-bit.
- Misc/WebIconDatabase.mm: Remove two unused constants.
- Plugins/WebBaseNetscapePluginView.mm: Remove an unused constant.
- WebCoreSupport/WebEditorClient.mm: Ditto.
- 3:23 AM Changeset in webkit [156598] by
-
- 7 edits in trunk/Source/WebKit2
WebKit2 fails to build with newer versions of clang.
Reviewed by Anders Carlsson.
- Shared/VisitedLinkTable.cpp: #if a function that's only used inside an ASSERT.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm: Remove an unused constant.
- UIProcess/mac/WKFullScreenWindowController.mm: Ditto.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Ditto.
- WebProcess/WebPage/FindController.cpp: Ditto.
- WebProcess/WebPage/WebBackForwardListProxy.cpp: Remove two unused constants.
- 3:22 AM Changeset in webkit [156597] by
-
- 6 edits in trunk/Source/JavaScriptCore
JavaScriptCore fails to build with newer versions of clang.
Reviewed by Sam Weinig.
- interpreter/Interpreter.cpp: Remove an unused function.
- parser/SourceProvider.cpp: Ditto.
- runtime/GCActivityCallback.cpp: #if a constant that's only used on non-CF platforms.
- runtime/JSCJSValue.cpp: Remove an unused constant.
- runtime/JSString.cpp: Ditto.
- 3:19 AM Changeset in webkit [156596] by
-
- 5 edits in trunk/Source/WTF
<rdar://problem/15079224> WTF fails to build with newer versions of clang.
Reviewed by Sam Weinig.
- wtf/DateMath.cpp: Remove some unused constants.
- wtf/FastMalloc.cpp: #if some constants and functions that are unused in some configurations.
Remove a function that's unused on all platforms.
- wtf/TCSystemAlloc.cpp: Remove some unused constants.
(TCMalloc_SystemRelease): Remove an if whose body is never executed.
- wtf/dtoa.cpp: #if things such that storeInc is only defined when USE_LONG_LONG is undefined.
Remove an unused constant.
Sep 27, 2013:
- 10:35 PM Changeset in webkit [156595] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Restore accidentally removed ChangeLog lines.
- 9:08 PM Changeset in webkit [156594] by
-
- 11 edits in trunk/Source/JavaScriptCore
Get rid of SetMyScope/SetCallee; use normal variables for the scope and callee of inlined call frames of closures
https://bugs.webkit.org/show_bug.cgi?id=122047
Reviewed by Oliver Hunt.
Currently we have the DFG reserve space for inline call frames at exactly the same stack
offsets that you would have gotten if the baseline interpreter/JIT had made the calls.
We need to get rid of that. One of the weirder parts of this is that we have special DFG
operations for accessing these inlined call frame headers. It's really hard for any
analysis of DFG IR to see what the liveness of any of those frame header "variables" is;
the liveness behaves like flushed arguments (it's all live until end of the inlinee) but
we don't have anything like a Flush node for those special variables.
This patch gets rid of the special operations for accessing inline call frame headers.
GetMyScope and GetCallee still remain, and are only for accessing the machine call
frame's scope/callee entries. The inline call frame's scope/callee now behave like
normal variables, and have Flush behavior just like inline arguments.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::getScope):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getCalleeLoadElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 5:32 PM Changeset in webkit [156593] by
-
- 3 edits10 adds in trunk/LayoutTests
[CSS Shapes] New positioning model: Positive margins
https://bugs.webkit.org/show_bug.cgi?id=118089
Reviewed by Alexandru Chiculita.
The remaining tests for shape-outside with positive margins. These
have all been imported from the CSSWG's repo.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 5:11 PM Changeset in webkit [156592] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/media-controller-playback.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122042
- platform/mac/TestExpectations: Marked as such.
- 5:03 PM Changeset in webkit [156591] by
-
- 5 edits in trunk/Source
Versioning.
- 4:45 PM Changeset in webkit [156590] by
-
- 32 edits in trunk/Source/WebCore
IndexedDB IDL Refactoring.
https://bugs.webkit.org/show_bug.cgi?id=121996
Reviewed by Alexey Proskuryakov.
This includes:
1 - Leveraging EventTarget.idl inheritance
2 - Removing comments
3 - Reordering to match the spec's IDLs
4 - Removing nonstandard, WebKit-specific methods
5 - Updating interfaces to match the spec (versions are only uint64_t's now...)
6 - Updating implementation code as needed (versions are only uint64_t's now...)
IDL changes:
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBFactory.idl:
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBKeyRange.idl:
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/indexeddb/IDBRequest.idl:
- Modules/indexeddb/IDBTransaction.idl:
- Modules/indexeddb/IDBVersionChangeEvent.idl:
- Modules/indexeddb/IndexedDB.h: Add new enum to represent version nullness.
Adapt to new IDLs, and also refactor representation of initial, null versioning:
- Modules/indexeddb/IDBCallbacks.h:
(WebCore::IDBCallbacks::onBlocked):
(WebCore::IDBCallbacks::onUpgradeNeeded):
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::version):
(WebCore::IDBDatabase::onVersionChange):
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseCallbacks.h:
- Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:
(WebCore::IDBDatabaseCallbacksImpl::onVersionChange):
- Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/IDBMetadata.h:
(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
- Modules/indexeddb/IDBOpenDBRequest.h:
- Modules/indexeddb/IDBRequest.cpp:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransaction.cpp:
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/IDBVersionChangeEvent.cpp:
(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
- Modules/indexeddb/IDBVersionChangeEvent.h:
(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::oldVersion):
(WebCore::IDBVersionChangeEvent::newVersion):
Keep leveldb building with minimal adaptations to the new IDLs,
but note that the LevelDB implementation is now incompatible with the spec:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
(WebCore::IDBDatabaseBackendLevelDB::openInternal):
(WebCore::IDBDatabaseBackendLevelDB::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendLevelDB::processPendingCalls):
(WebCore::IDBDatabaseBackendLevelDB::openConnection):
(WebCore::IDBDatabaseBackendLevelDB::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendLevelDB::deleteDatabase):
(WebCore::IDBDatabaseBackendLevelDB::deleteDatabaseFinal):
(WebCore::IDBDatabaseBackendLevelDB::VersionChangeAbortOperation::perform):
- Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
- inspector/InspectorIndexedDBAgent.cpp: Update for metadata change.
- 4:40 PM Changeset in webkit [156589] by
-
- 2 edits in trunk/Source/WebKit2
CookieStorageShim should be PLATFORM(MAC) guarded
https://bugs.webkit.org/show_bug.cgi?id=121423
Reviewed by Darin Adler.
Original patch by Kwang Yul Seo <skyul@company100.com>.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 4:29 PM Changeset in webkit [156588] by
-
- 22 edits in trunk/Source
Upstream changes to Pasteboard implementation for iOS.
https://bugs.webkit.org/show_bug.cgi?id=121818
Reviewed by Benjamin Poulain.
Source/WebCore:
- WebCore.exp.in:
- editing/Editor.cpp:
(WebCore::Editor::dispatchCPPEvent):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::WebContentReader::addFragment):
(WebCore::Editor::WebContentReader::readWebArchive):
(WebCore::Editor::WebContentReader::readFilenames):
(WebCore::Editor::WebContentReader::readHTML):
(WebCore::Editor::WebContentReader::readRTFD):
(WebCore::Editor::WebContentReader::readRTF):
(WebCore::uniqueURLWithRelativePart):
(WebCore::Editor::WebContentReader::readImage):
(WebCore::Editor::WebContentReader::readURL):
(WebCore::Editor::WebContentReader::readPlainText):
(WebCore::Editor::webContentFromPasteboard):
(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::createFragmentAndAddResources):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):
- platform/Pasteboard.h:
- platform/PasteboardStrategy.h:
- platform/PlatformPasteboard.h:
- platform/ios/PasteboardIOS.mm:
(WebCore::PasteboardWebContent::PasteboardWebContent):
(WebCore::PasteboardWebContent::~PasteboardWebContent):
(WebCore::PasteboardImage::PasteboardImage):
(WebCore::PasteboardImage::~PasteboardImage):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::writeString):
(WebCore::Pasteboard::types):
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::changeCount):
(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::count):
(WebCore::PlatformPasteboard::readBuffer):
(WebCore::PlatformPasteboard::readString):
(WebCore::PlatformPasteboard::readURL):
- platform/mac/PasteboardMac.mm:
(WebCore::PasteboardWebContent::PasteboardWebContent):
(WebCore::PasteboardWebContent::~PasteboardWebContent):
(WebCore::PasteboardImage::PasteboardImage):
(WebCore::PasteboardImage::~PasteboardImage):
- platform/mac/PlatformPasteboardMac.mm:
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::writeToPasteboard):
(WebPlatformStrategies::getPasteboardItemsCount):
(WebPlatformStrategies::readBufferFromPasteboard):
(WebPlatformStrategies::readURLFromPasteboard):
(WebPlatformStrategies::readStringFromPasteboard):
(WebPlatformStrategies::changeCount):
Source/WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::decodeSharedBuffer):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/WebContext.h:
- UIProcess/WebContext.messages.in:
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::writeWebContentToPasteboard):
(WebKit::WebContext::writeImageToPasteboard):
(WebKit::WebContext::writeStringToPasteboard):
(WebKit::WebContext::readStringFromPasteboard):
(WebKit::WebContext::readURLFromPasteboard):
(WebKit::WebContext::readBufferFromPasteboard):
(WebKit::WebContext::getPasteboardItemsCount):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::writeToPasteboard):
(WebKit::WebPlatformStrategies::getPasteboardItemsCount):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
(WebKit::WebPlatformStrategies::readURLFromPasteboard):
(WebKit::WebPlatformStrategies::readStringFromPasteboard):
(WebKit::WebPlatformStrategies::changeCount):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 4:19 PM Changeset in webkit [156587] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Unreviewed build fix following r156560.
- WebView.h:
- 4:17 PM Changeset in webkit [156586] by
-
- 12 edits4 adds in trunk
Crash on shape-outside when using calc()
https://bugs.webkit.org/show_bug.cgi?id=121020
Reviewed by Dirk Schulze.
Source/WebCore:
This change prevents a crash caused by specifying a CSS Shape geometry
Length attribute with a calc() expression. It adds support for converting
Lengths to CSSPrimitive Values, in large part by migrating Blink changes
made to the calc classes since the split. Doing so required a few supporting
changes in some related classes, notably CSSPrimitiveValue.
Tests: fast/shapes/shape-inside/shape-inside-calc-crash.html
css3/calc/simplification.html
- css/BasicShapeFunctions.cpp:
(WebCore::convertToCSSPrimitiveValue): Effectively use the new CSSPrimtiveValue(length,style) constructor to convert Lengths to CSSValues.
(WebCore::valueForBasicShape): Use the convertToCSSPrimitiveValue() function.
(WebCore::convertToLength): Added the CalculatedConversion convertToLength() flag to enable support for calc() valued Length Shape attributes.
- css/BasicShapeFunctions.h:
- css/CSSCalculationValue.cpp:
(WebCore::hasDoubleValue):
(WebCore::buildCssText):
(WebCore::CSSCalcValue::clampToPermittedRange):
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcExpressionNode::~CSSCalcExpressionNode):
(WebCore::CSSCalcPrimitiveValue::create):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::primitiveType):
(WebCore::CSSCalcPrimitiveValue::CSSCalcPrimitiveValue):
(WebCore::determineCategory):
(WebCore::isIntegerResult):
(WebCore::CSSCalcBinaryOperation::create):
(WebCore::CSSCalcBinaryOperation::createSimplified):
(WebCore::CSSCalcBinaryOperation::doubleValue):
(WebCore::CSSCalcBinaryOperation::buildCssText):
(WebCore::CSSCalcBinaryOperation::primitiveType):
(WebCore::CSSCalcBinaryOperation::CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::getNumberSide):
(WebCore::CSSCalcBinaryOperation::evaluate):
(WebCore::CSSCalcBinaryOperation::evaluateOperator):
(WebCore::CSSCalcExpressionNodeParser::parseValue):
(WebCore::CSSCalcExpressionNodeParser::parseValueTerm):
(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
(WebCore::CSSCalcExpressionNodeParser::parseAdditiveValueExpression):
(WebCore::CSSCalcValue::createExpressionNode):
(WebCore::CSSCalcValue::create):
- css/CSSCalculationValue.h:
(WebCore::CSSCalcExpressionNode::category):
(WebCore::CSSCalcValue::create):
(WebCore::CSSCalcValue::isInt):
(WebCore::CSSCalcValue::permittedValueRange):
(WebCore::CSSCalcValue::expressionNode):
(WebCore::CSSCalcValue::CSSCalcValue):
(WebCore::toCSSCalcValue):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Pass the style along to the new valueForBasicShape() function.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::unitCategory): Made this function public so that CSSCalculationValue could use it.
(WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor): Ditto.
(WebCore::CSSPrimitiveValue::primitiveType): Cleared trailing whitespace.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Construct a CSSPrimitiveValue from a Length and a RenderStyle*.
(WebCore::CSSPrimitiveValue::init): The common part of the two Length CSSPrimitiveValue constructors.
(WebCore::CSSPrimitiveValue::computeLengthDouble): Moved the case labels to the left per check-webkit-style.
(WebCore::CSSPrimitiveValue::getStringValue): Ditto.
(WebCore::CSSPrimitiveValue::getDoubleValue): Removed trailing whitespace.
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::create): Construct a CSSPrimitiveValue from a Length and a RenderStyle*.
(WebCore::toCSSPrimitiveValue): Check the CSSValue*'s validity with ASSERT_WITH_SECURITY_IMPLICATION before casting to CSSPrimitiveValue*.
- css/CSSValuePool.h:
(WebCore::CSSValuePool::createValue): A new overload that delegates to the new CSSPrimitiveValue(length,style) constructor.
- platform/CalculationValue.h:
(WebCore::CalculationValue::operator==):
(WebCore::CalculationValue::isNonNegative):
(WebCore::CalculationValue::expression):
(WebCore::CalcExpressionNumber::value):
(WebCore::toCalcExpressionNumber):
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionLength::length):
(WebCore::toCalcExpressionLength):
(WebCore::CalcExpressionBinaryOperation::leftSide):
(WebCore::CalcExpressionBinaryOperation::rightSide):
(WebCore::CalcExpressionBinaryOperation::getOperator):
(WebCore::toCalcExpressionBinaryOperation):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::from):
(WebCore::CalcExpressionBlendLength::to):
(WebCore::CalcExpressionBlendLength::progress):
(WebCore::toCalcExpressionBlendLength):
LayoutTests:
Specifying a CSS Shape geometry Length attribute with a calc() expression
or looking up the value with getComputedStyle(), caused crashes.
- fast/shapes/shape-inside/shape-inside-calc-crash-expected.txt: Added.
- fast/shapes/shape-inside/shape-inside-calc-crash.html: Added.
- css3/calc/simplification-expected.txt: Added
- css3/calc/simplification.html: Added
- LayoutTests/css3/calc/cssom-expected.txt:
- 4:09 PM Changeset in webkit [156585] by
-
- 2 edits in trunk/LayoutTests
Layout Test animations/combo-transform-translate+scale.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122040
- platform/mac/TestExpectations: Marking as such.
- 4:05 PM Changeset in webkit [156584] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/track/track-cue-overlap-snap-to-lines-not-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122039
- platform/mac/TestExpectations: Marking as such.
- 4:01 PM Changeset in webkit [156583] by
-
- 2 edits in trunk/LayoutTests
animations/transform-non-accelerated.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122038
- platform/mac/TestExpectations: Marking as such.
- 3:34 PM Changeset in webkit [156582] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r154219): 30% more malloc memory used on html5-full-render.
<https://webkit.org/b/122034>
Reviewed by Antti Koivisto.
canExecuteScripts() used to rely on Frame::settings() returning null
when the Frame was disconnected from its Page, and giving Frame its
own handle on the Settings broke this mechanism.
This caused us to hold on for some objects for a bit longer than we
needed to in the run-perf-tests harness, showing up as a massive 30%
regression in malloc memory use.
Fixed it by added an explicit null check of Frame::page().
- 3:24 PM Changeset in webkit [156581] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Fixed linker symbols I broke last time.
- 3:14 PM Changeset in webkit [156580] by
-
- 22 edits in trunk/Source/WebCore
Updating bindings test results after KURL->URL rename.
Includes were now in the wrong order.
- bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp:
- bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp:
- bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
- bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp:
- bindings/scripts/test/CPP/WebDOMTestException.cpp:
- bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/ObjC/DOMTestActiveDOMObject.mm:
- bindings/scripts/test/ObjC/DOMTestCallback.mm:
- bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm:
- bindings/scripts/test/ObjC/DOMTestEventConstructor.mm:
- bindings/scripts/test/ObjC/DOMTestEventTarget.mm:
- bindings/scripts/test/ObjC/DOMTestException.mm:
- bindings/scripts/test/ObjC/DOMTestInterface.mm:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
- 3:05 PM Changeset in webkit [156579] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
Add supporting logic for r156570.
- 3:01 PM Changeset in webkit [156578] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r156569.
http://trac.webkit.org/changeset/156569
https://bugs.webkit.org/show_bug.cgi?id=122035
broke a lot of mismatch tests (Requested by thorton on
#webkit).
Tools:
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
LayoutTests:
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Removed.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Removed.
- 2:54 PM Changeset in webkit [156577] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix for Win64.
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-09-27
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added and fixed 64-bit linker symbols.
- 2:52 PM Changeset in webkit [156576] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/video-duration-known-after-eos.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122033
- platform/mac/TestExpectations: Marked as such.
- 2:29 PM Changeset in webkit [156575] by
-
- 2 edits in trunk/Source/WebCore
Get MediaStreamCenterGStreamer compiling again
https://bugs.webkit.org/show_bug.cgi?id=122029
After MediaStream cleanup commit, it was not building anymore.
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Eric Carlson.
No new tests needed.
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
- 2:18 PM Changeset in webkit [156574] by
-
- 4 edits in trunk/Source/WebCore
Storing a reference to MediaStreamTrack in RTCStatsRequest
https://bugs.webkit.org/show_bug.cgi?id=122030
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Eric Carlson.
The spec[1] says that the stats is related to a MediaStreamTrack object.
It also says: "Evaluate the need for other selectors than MediaStreamTrack".
So a MediaStreamTrack object is more suitable in this case.
[1]http://dev.w3.org/2011/webrtc/editor/webrtc.html#stats-selector
No new tests needed.
- Modules/mediastream/RTCStatsRequestImpl.cpp:
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::hasSelector):
(WebCore::RTCStatsRequestImpl::track):
- Modules/mediastream/RTCStatsRequestImpl.h:
- platform/mediastream/RTCStatsRequest.h:
- 2:15 PM Changeset in webkit [156573] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r156546): 18 media tests broken
https://bugs.webkit.org/show_bug.cgi?id=122021
- platform/mac/TestExpectations: Adding one more test, media/track/track-cue-rendering-vertical.html
- 2:11 PM Changeset in webkit [156572] by
-
- 2 edits in trunk/LayoutTests
[Mac] Intermittent crash on media/video-controls-captions-trackmenu.html
https://bugs.webkit.org/show_bug.cgi?id=110173
This code got rewritten, and the test now just fails. Fixing and re-enabling it
is tracked in a different bug.
- platform/mac/TestExpectations: Removing superfluous entry which was confusing the parser.
- 1:48 PM Changeset in webkit [156571] by
-
- 2 edits in trunk/Tools
Don't retry failures on Apple MountainLion Release WK1 tester
https://bugs.webkit.org/show_bug.cgi?id=122026
Reviewed by Mark Rowe.
- BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
on this bot.
- 1:47 PM Changeset in webkit [156570] by
-
- 3 edits in trunk/Tools
Don't hardcode builder specific configuration in buildbot master.cfg
https://bugs.webkit.org/show_bug.cgi?id=122023
Reviewed by Mark Rowe.
- BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
property to Qt Mountain Lion Release, making it run pixel tests.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.start): Use additionalArguments.
(RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
- 1:47 PM Changeset in webkit [156569] by
-
- 3 edits2 adds in trunk
[wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
https://bugs.webkit.org/show_bug.cgi?id=122006
<rdar://problem/15095197>
Reviewed by Dean Jackson.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
Layer-back the root view in WebKitTestRunner's window, to work around a bug
where the window server snapshot API returns blank snapshots.
Add a test that ensures that WebKitTestRunner's snapshots are not
completely blank with tiled drawing enabled.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
- 1:44 PM Changeset in webkit [156568] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/animation/request-animation-frame-time-unit.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122031
- platform/mac/TestExpectations: Marking as such. Dean is going to look into
related issues soon.
- 1:25 PM Changeset in webkit [156567] by
-
- 12 edits in trunk/Source
[Nix] Updating Nix trunk files
https://bugs.webkit.org/show_bug.cgi?id=121752
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Benjamin Poulain.
Source/WebCore:
No new tests needed.
- page/nix/EventHandlerNix.cpp:
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
- platform/DragImage.h:
- platform/graphics/GraphicsContext3D.h:
- platform/nix/DragImageNix.cpp:
(WebCore::createDragImageFromImage):
- platform/nix/GamepadsNix.cpp:
(WebCore::sampleGamepads):
- platform/nix/LanguageNix.cpp:
(WebCore::platformLanguage):
- platform/nix/LocalizedStringsNix.cpp:
(WebCore::unacceptableTLSCertificate):
- platform/nix/PasteboardNix.cpp:
(WebCore::Pasteboard::types):
- platform/nix/RenderThemeNix.cpp:
(WebCore::toColor):
(WebCore::themeEngine):
(WebCore::webCanvas):
(WebCore::getWebThemeState):
(WebCore::RenderThemeNix::paintButton):
(WebCore::RenderThemeNix::paintTextField):
(WebCore::RenderThemeNix::paintCheckbox):
(WebCore::RenderThemeNix::paintRadio):
(WebCore::RenderThemeNix::paintMenuList):
(WebCore::RenderThemeNix::paintProgressBar):
(WebCore::RenderThemeNix::paintInnerSpinButton):
(WebCore::RenderThemeNix::paintMeter):
Source/WTF:
- wtf/nix/FeatureDefinesNix.h:
- 1:06 PM Changeset in webkit [156566] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][CoordinatedGraphics] fix build after r156560
https://bugs.webkit.org/show_bug.cgi?id=122028
Fixing build.
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-09-27
Reviewed by Anders Carlsson.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 12:22 PM Changeset in webkit [156565] by
-
- 2 edits in trunk/Source/WebKit/win
Attempt to fix Windows build.
- 11:49 AM Changeset in webkit [156564] by
-
- 4 edits in trunk/Source/JavaScriptCore
Deoptimize 32-bit deoptimization
https://bugs.webkit.org/show_bug.cgi?id=122025
Reviewed by Oliver Hunt.
Just simplifying a bunch of code. I don't want the old, super-complicated,
deoptimization code to get in the way of changes I'll be making to DFG stack layout.
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::isInRegisters):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::dumpInContext):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- 11:48 AM Changeset in webkit [156563] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 11:46 AM Changeset in webkit [156562] by
-
- 1 copy in tags/Safari-537.60.3
New Tag.
- 11:41 AM Changeset in webkit [156561] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r156546): 17 media tests broken
https://bugs.webkit.org/show_bug.cgi?id=122021
Unreviewed gardening; add failing tests to TestExpectations while triaging new failures.
- platform/mac/TestExpectations:
- 11:38 AM Changeset in webkit [156560] by
-
- 27 edits in trunk/Source
Use std::unique_ptr for GraphicsLayer creation
https://bugs.webkit.org/show_bug.cgi?id=122020
Reviewed by Antti Koivisto.
Source/WebCore:
- platform/graphics/GraphicsLayer.h:
- platform/graphics/GraphicsLayerFactory.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::create):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::createGraphicsLayer):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::paintIntoLayer):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::hasScrollingLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
- rendering/RenderLayerCompositor.h:
Source/WebKit2:
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::getOrCreateLayer):
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::paintContents):
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::createGraphicsLayer):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
- 11:36 AM Changeset in webkit [156559] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fixed Win64 build after r156184.
https://bugs.webkit.org/show_bug.cgi?id=121994
Reviewed by Oliver Hunt.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupTwoStubArgsGPR):
(JSC::CCallHelpers::setupTwoStubArgsFPR):
Renamed from setupTwoStubArgs.
Visual Studio x64 compiler fails to see that this is an overloaded template function.
(JSC::CCallHelpers::setupStubArguments):
(JSC::CCallHelpers::setupArguments):
(JSC::CCallHelpers::setupArgumentsWithExecState):
Use setupTwoStubArgsGPR or setupTwoStubArgsFPR instead of setupTwoStubArgs.
- 11:34 AM Changeset in webkit [156558] by
-
- 23 edits in trunk/Source
ScrollbarPainterController should adopt the api to lock overlay scrollbar state
https://bugs.webkit.org/show_bug.cgi?id=121928
Reviewed by Sam Weinig.
Source/WebCore:
ScrollbarPainterController should adopt the api to lock overlay scrollbar state.
This will allow the ScrollbarPainterController and ScrollAnimatorMac to have
control over knowing whether or not the scrollbars are currently active, which
will allow us to remove a bunch of functions previously implemented in
ScrollableArea subclasses to answer that question.
ScrollableArea::scrollbarsCanBeActive() is not longer virtual. It used to
implemented on ScrollableArea subclasses, but now ScrollableArea can just get the
information from the ScrollAnimator.
- WebCore.exp.in:
When ScrollableArea subclasses implemented scrollbarsCanBeActive(), they would
check to see if the document was in the page cache. Instead of that model, this
patch adopts a model where ScrollbarPainterController is told directly whether or
not it is active via shouldLockOverlayScrollbarsToHidden(bool).
- dom/Document.cpp:
(WebCore::Document::setInPageCache):
setAnimatorsAreActive() is no longer necessary. The functionality can be bundled
into shouldLockOverlayScrollbarsToHidden(bool).
(WebCore::Document::documentDidResumeFromPageCache):
Remove implementations of scrollbarsCanBeActive(), setAnimatorsAreActive(), and
scrollbarAnimationsAreSuppressed().
- page/FrameView.cpp:
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
- page/FrameView.h:
setShouldSuppressScrollbarAnimations(bool) now calls
setShouldLockOverlayScrollbars(bool).
- page/Page.cpp:
(WebCore::Page::setShouldSuppressScrollbarAnimations):
(WebCore::Page::setShouldLockOverlayScrollbars):
- page/Page.h:
setIsActive() is now implemented in the ScrollAnimator instead of ScrollableArea
subclasses. finishCurrentScrollAnimations() is replaced by
lockOverlayScrollbarStateToHidden(bool).
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollAnimator::scrollbarsCanBeActive):
New enum ScrollbarOverlayState.
- platform/ScrollTypes.h:
Go to the animator for both of these functions.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollableArea::scrollbarsCanBeActive):
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::setVisibleScrollerThumbRect):
Three new pieces of ScrollbarPainterController api.
- platform/mac/NSScrollerImpDetails.h:
Instead of asking the ScrollableArea if scrollbars can be active, just find out if
the ScrollbarPaintController has been locked.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollAnimatorMac::scrollbarsCanBeActive):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
Remove implementations of scrollbarsCanBeActive() and
scrollbarAnimationsAreSuppressed().
- rendering/RenderLayer.cpp:
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp:
- rendering/RenderListBox.h:
Source/WebKit2:
This function no longer needs to be implemented by ScrollablArea subclasses.
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- 11:22 AM Changeset in webkit [156557] by
-
- 9 edits in trunk/Source/WebCore
Move line grid functionality from RenderBlock into RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=121502
Reviewed by Dean Jackson.
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::establishLineGrid):
- rendering/LayoutState.h:
(WebCore::LayoutState::lineGrid):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::layoutLineGridBox):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::lineGridBox):
(WebCore::RenderBlockFlow::setLineGridBox):
- rendering/RenderBlockLineLayout.cpp:
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineSnapAdjustment):
- 10:52 AM Changeset in webkit [156556] by
-
- 2 edits in trunk/Source/WebCore
Re-indent Settings.h
Rubber-stamped by Anders Carlsson.
- 10:42 AM Changeset in webkit [156555] by
-
- 2 edits in trunk/Source/WebKit2
Web Inspector: Make WebKitGTK+ port work with Eclipse chromedevtools plugin
https://bugs.webkit.org/show_bug.cgi?id=121121
Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-27
Reviewed by Gustavo Noronha Silva.
The chromedevtools plugin (http://code.google.com/p/chromedevtools/) requires a specific
json format to connect to the webkit inspector.
The current format is missing some required fields that make the connection with the plugin
fail.
The format expected by the plugin is as follows:
{
"title": "Foo",
"url": "http://foo",
"devtoolsFrontendUrl": "/Main.html?ws=localhost:9222/devtools/page/1",
"webSocketDebuggerUrl": "ws://localhost:9222/devtools/page/1"
}
The current format is missing the entries for "devtoolsFrontendUrl" and
"webSocketDebuggerUrl".
The plugin also sends an HTTP GET request to http://host:port/json instead of
http://host:port/pagelist.json when retrieving the pages list.
This patch fixes the issues by adding support for the missing fields and accepting requests
for "/json" alongside "/pagelist.json".
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath):
Also accept requests for "/json" alongside "pagelist.json".
(WebKit::WebInspectorServer::buildPageList):
Add fields required by chromedevtools plugin.
- 10:40 AM Changeset in webkit [156554] by
-
- 9 edits in trunk
[MediaStream API] update SourceInfo object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121941
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, existing test updated.
- Modules/mediastream/SourceInfo.cpp:
(WebCore::SourceInfo::kind): Get rid of "none".
- Modules/mediastream/SourceInfo.h:
(WebCore::SourceInfo::sourceId): Renamed from "id".
- Modules/mediastream/SourceInfo.idl:
- platform/mediastream/MediaStreamTrackSourcesRequestClient.h:
(WebCore::TrackSourceInfo::create):
(WebCore::TrackSourceInfo::kind):
(WebCore::TrackSourceInfo::TrackSourceInfo):
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::MockMediaStreamCenter::getMediaStreamTrackSources): "facing" isn't a part of sourceInfo.
Return a non-NULL ID because a source must always have one.
LayoutTests:
- fast/mediastream/MediaStreamTrack-getSources-expected.txt:
- fast/mediastream/MediaStreamTrack-getSources.html:
- 10:26 AM Changeset in webkit [156553] by
-
- 9 edits in trunk
Provide 2D Matrix decomposition for animation
https://bugs.webkit.org/show_bug.cgi?id=112824
<rdar://problem/15091882>
Reviewed by Eric Carlson (and Ian Henderson offline).
Source/WebCore:
Implement a new 2d matrix blend, which is triggered
when animating between two affine 3d matrices. This
is intended to be the official algorithm that gets
put into the W3C Transforms specification.
The old code is renamed with a 4 prefix (indicating
it is a blend between 3d matrices using quaternions),
and new methods and structures for 2d blending were added.
I also took the opportunity to clean up a lot of
bad WebKit style.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::maxScaleFromTransform): Use 3d decomposition.
- platform/graphics/transforms/PerspectiveTransformOperation.cpp:
(WebCore::PerspectiveTransformOperation::blend): Ditto.
- platform/graphics/transforms/RotateTransformOperation.cpp:
(WebCore::RotateTransformOperation::blend): Ditto.
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::decompose2): New method to decompose an affine 3d matrix
into X/Y scale + translate, a rotation angle, plus some extracted
a,b,c,d fields from the affine section.
(WebCore::decompose4): New name for the old function.
(WebCore::TransformationMatrix::blend2): Perform linear interpolation
between two 2d decompositions.
(WebCore::TransformationMatrix::blend4): New name for the old function.
(WebCore::TransformationMatrix::blend): Call blend2 or blend4 depending
on the type of matrix.
(WebCore::TransformationMatrix::decompose2): Calls into the decompose2
method above.
(WebCore::TransformationMatrix::decompose4): New name.
(WebCore::TransformationMatrix::recompose2): Recomposes a 3d matrix from
a 2d decomposition.
(WebCore::TransformationMatrix::recompose4): New name.
- platform/graphics/transforms/TransformationMatrix.h: All the changes
for the new methods above.
LayoutTests:
This test was only exercising the fact that our
software decomposition did not match our hardware
decomposition (although that required visual inspection).
Now that our 2d decomposition is correct, update the
test and its expected result.
- animations/transform-non-accelerated-expected.txt:
- animations/transform-non-accelerated.html:
- 10:24 AM Changeset in webkit [156552] by
-
- 1 edit in trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
Attempt to fix windows build.
- 9:59 AM Changeset in webkit [156551] by
-
- 5 edits in trunk
[GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106924
Reviewed by Chris Fleizach.
Tools:
Consider headings levels as values to be returned in intValue()
both in DRT and WKTR, so we can share more tests with other ports.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::intValue): Consider headings too.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::intValue): Ditto.
LayoutTests:
Removed accesibility/heading-level.html from failure expectations.
- platform/gtk/TestExpectations: Removed test now passing.
- 9:39 AM Changeset in webkit [156550] by
-
- 840 edits7 moves in trunk
rename KURL to URL
https://bugs.webkit.org/show_bug.cgi?id=16214
Reviewed by Andreas Kling.
Source/WebCore:
- many files: Renamed, using script.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Let the script to try to rename here.
Source/WebKit/blackberry:
- many files: Renamed, using script.
Source/WebKit/efl:
- many files: Renamed, using script.
Source/WebKit/gtk:
- many files: Renamed, using script.
Source/WebKit/mac:
- many files: Renamed, using script.
Source/WebKit/qt:
- many files: Renamed, using script.
Source/WebKit/win:
- many files: Renamed, using script.
Source/WebKit/wince:
- many files: Renamed, using script.
Source/WebKit2:
- many files: Renamed, using script.
Tools:
- many files: Renamed, using script.
- 9:37 AM Changeset in webkit [156549] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLInt alignment problem on ARM in debug mode
https://bugs.webkit.org/show_bug.cgi?id=122012
Reviewed by Michael Saboff.
Force GCC to put the LLInt code to .text section.
- llint/LowLevelInterpreter.cpp:
- 9:34 AM Changeset in webkit [156548] by
-
- 2 edits in trunk/Tools
Fix Python scripts test failures.
- Scripts/webkitpy/style/checkers/cpp.py: (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests now, not by the checker itself.
- 9:12 AM Changeset in webkit [156547] by
-
- 2 edits in trunk/Source/WebKit2
Remove unused method parameters from TupleCoder.
https://bugs.webkit.org/show_bug.cgi?id=122009
Reviewed by Anders Carlsson.
In case of TupleCoder<0, Elements...> the parameter
names for encoder, decoder and tuple are not used.
By removing the paramter names the unusued paramter
warning will disappear.
- Platform/CoreIPC/Arguments.h:
- 9:05 AM Changeset in webkit [156546] by
-
- 45 edits8 adds2 deletes in trunk
[Mac] Implement the media controls in JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=120895
Reviewed by Dean Jackson.
Source/JavaScriptCore:
Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Re-implement the existing MediaControls constellation of classes in JavaScript
and CSS. This will allow different ports to configure their controls without
dependencies on the layout requirements of any other port's controls.
Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT:
- Configurations/FeatureDefines.xcconfig:
Add new source files to the project:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Add a new class MediaControlsHost which the script controls can use to
communicate with the HTMLMediaElement without exposing private interfaces
to web facing scripts:
- Modules/mediacontrols/MediaControlsHost.cpp: Added.
(WebCore::MediaControlsHost::automaticKeyword): Static method.
(WebCore::MediaControlsHost::forcedOnlyKeyword): Ditto.
(WebCore::MediaControlsHost::alwaysOnKeyword): Ditto.
(WebCore::MediaControlsHost::create): Simple factory.
(WebCore::MediaControlsHost::MediaControlsHost): Simple constructor.
(WebCore::MediaControlsHost::~MediaControlsHost): Simple destructor.
(WebCore::MediaControlsHost::sortedTrackListForMenu): Pass through to CaptionUserPreferences.
(WebCore::MediaControlsHost::displayNameForTrack): Ditto.
(WebCore::MediaControlsHost::captionMenuOffItem): Pass through to TextTrack.
(WebCore::MediaControlsHost::captionMenuAutomaticItem): Ditto.
(WebCore::MediaControlsHost::captionDisplayMode): Pass through to CaptionUserPreferences.
(WebCore::MediaControlsHost::setSelectedTextTrack): Pass through to HTMLMediaElement.
(WebCore::MediaControlsHost::textTrackContainer): Lazily create a MediaControlTextTrackContainerElement.
(WebCore::MediaControlsHost::updateTextTrackContainer): Pass through to MediaControlTextTrackContainerElement.
- Modules/mediacontrols/MediaControlsHost.h: Added.
- Modules/mediacontrols/MediaControlsHost.idl: Added.
- Modules/mediacontrols/mediaControlsApple.css: Added.
Add convenience methods for adding a MediaControlsHost to a VM.
- bindings/js/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
- bindings/js/ScriptObject.h:
Add the new controller .js implementation:
- Modules/mediacontrols/mediaControlsApple.js: Added.
(createControls): Global method to create a new Controller object.
(Controller): Constructor. Create and configure the default set of controls.
(Controller.prototype.addListeners): Adds event listeners to the this.video object.
(Controller.prototype.removeListeners): Removes listeners from same.
(Controller.prototype.handleEvent): Makes Controller an EventHandler, making registration and
deregistration simpler.
(Controller.prototype.createBase): Creates the base controls object and the text track container.
(Controller.prototype.createControls): Creates the controls panel object and controller UI.
(Controller.prototype.setControlsType): Switches between Full Screen and Inline style of controller.
(Controller.prototype.disconnectControls): Disconnects all UI elements from the DOM.
(Controller.prototype.configureInlineControls): Configures existing controls for Inline mode.
(Controller.prototype.configureFullScreenControls): Ditto, for Full Screen Mode.
Add listeners for HTMLMediaElement events:
(Controller.prototype.onloadstart): Update the status display.
(Controller.prototype.onerror): Ditto.
(Controller.prototype.onabort): Ditto.
(Controller.prototype.onsuspend): Ditto.
(Controller.prototype.onprogress): Ditto.
(Controller.prototype.onstalled): Ditto.
(Controller.prototype.onwaiting): Ditto.
(Controller.prototype.onreadystatechange): Ditto.
(Controller.prototype.ontimeupdate): Update the timeline and time displays.
(Controller.prototype.ondurationchange): Ditto.
(Controller.prototype.onplaying): Update the play button.
(Controller.prototype.onplay): Ditto.
(Controller.prototype.onpause): Ditto.
(Controller.prototype.onratechange): Ditto.
(Controller.prototype.onvolumechange): Update the volume and mute UI.
(Controller.prototype.ontexttrackchange): Update the text track container and captions button.
(Controller.prototype.ontexttrackadd): Ditto.
(Controller.prototype.ontexttrackremove): Ditto.
(Controller.prototype.ontexttrackcuechange): Ditto.
(Controller.prototype.onfullscreenchange): Reconfigure the controls.
Add listeners for UI element events:
(Controller.prototype.onwrappermousemove): Show the controls and start the hide timer.
(Controller.prototype.onwrappermouseout): Hide the controls and stop the hide timer.
(Controller.prototype.onrewindbuttonclicked): Rewind.
(Controller.prototype.onplaybuttonclicked): Toggle pause.
(Controller.prototype.ontimelinechange): Update the currentTime.
(Controller.prototype.ontimelinedown):
(Controller.prototype.ontimelineup):
(Controller.prototype.ontimelinemouseover): Show the thumbnail view if available.
(Controller.prototype.ontimelinemouseout): Hide same.
(Controller.prototype.ontimelinemousemove): Move the thumbnail view.
(Controller.prototype.onmutebuttonclicked): Mute audio.
(Controller.prototype.onminbuttonclicked): Increase volume to max.
(Controller.prototype.onmaxbuttonclicked): Decrease volume to min.
(Controller.prototype.onvolumesliderchange): Update the current volume.
(Controller.prototype.oncaptionbuttonclicked): Show or hide the track menu.
(Controller.prototype.onfullscreenbuttonclicked): Enter or exit fullscreen.
(Controller.prototype.oncontrolschange): Show or hide the controls panel.
(Controller.prototype.onseekbackmousedown): Start seeking and enable the seek timer.
(Controller.prototype.onseekbackmouseup): Stop seeking and disable the seek timer.
(Controller.prototype.onseekforwardmousedown): Start seekind and enable the seek timer.
(Controller.prototype.onseekforwardmouseup): Stop seekind and disable the seek timer.
Add action methods (which are mostly self explanatory):
(Controller.prototype.updateDuration):
(Controller.prototype.updatePlaying):
(Controller.prototype.showControls):
(Controller.prototype.hideControls):
(Controller.prototype.removeControls):
(Controller.prototype.addControls):
(Controller.prototype.updateTime):
(Controller.prototype.updateReadyState):
(Controller.prototype.setStatusHidden):
(Controller.prototype.updateThumbnailTrack):
(Controller.prototype.updateCaptionButton):
(Controller.prototype.updateCaptionContainer):
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.captionItemSelected):
(Controller.prototype.destroyCaptionMenu):
(Controller.prototype.updateVolume):
Add utility methods:
(Controller.prototype.isFullScreen):
(Controller.prototype.canPlay):
(Controller.prototype.nextRate):
(Controller.prototype.seekBackFaster):
(Controller.prototype.seekForwardFaster):
(Controller.prototype.formatTime):
(Controller.prototype.trackHasThumbnails):
Add the stylesheet for the javascript controls (which are mostly) copied from
the (deleted) mediaControlsQuickTime.css and fullscreenQuickTime.css files:
- Modules/mediacontrols/mediaControlsApple.css: Added.
- css/fullscreenQuickTime.css: Removed.
- css/mediaControlsQuickTime.css: Removed.
Inject new stylesheets into UA sheets:
- css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
Use the new javascript controls rather than MediaControls:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::childShouldCreateRenderer): Use the javascript controls if available.
(WebCore::HTMLMediaElement::updateTextTrackDisplay): Ditto.
(WebCore::HTMLMediaElement::mediaControls): Ditto.
(WebCore::HTMLMediaElement::hasMediaControls): Ditto.
(WebCore::HTMLMediaElement::createMediaControls): Ditto.
(WebCore::HTMLMediaElement::configureMediaControls): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackDisplay): Ditto.
(WebCore::HTMLMediaElement::ensureIsolatedWorld): Create a new VM for the controls script.
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript): Inject the media controls script into the VM.
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): Inject the MediaControlsHost into the VM and call
the scripts global factory function.
- html/HTMLMediaElement.h:
Remove most of the drawing code from RenderThemeMac and RenderThemeWin and
add accessors for the new .js and .css file data:
- rendering/RenderTheme.h:
(WebCore::RenderTheme::mediaControlsStyleSheet): Empty virtual method.
(WebCore::RenderTheme::mediaControlsScript): Ditto.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::mediaControlsStyleSheet): Add accessor for mediaControlsApple.css.
(WebCore::RenderThemeMac::mediaControlsScript): Add accessor for mediaControlsApple.js.
(WebCore::RenderThemeMac::adjustSliderThumbSize): Remove the call to adjustMediaSliderThumbSize.
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::mediaControlsStyleSheet):
(WebCore::RenderThemeWin::mediaControlsScript):
- rendering/RenderThemeWin.h:
Source/WebKit/mac:
Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.
- wtf/FeatureDefines.h:
LayoutTests:
Rebaseline changed tests and add new (failing) tests to
TestExpectations.
- media/audio-delete-while-slider-thumb-clicked.html:
- platform/mac/TestExpectations:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/mac/fast/layers/video-layer-expected.png:
- platform/mac/fast/layers/video-layer-expected.txt:
- platform/mac/fullscreen/video-controls-override-expected.txt: Added.
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.png:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-strict-expected.png:
- platform/mac/media/controls-strict-expected.txt:
- platform/mac/media/controls-styling-strict-expected.png:
- platform/mac/media/controls-styling-strict-expected.txt:
- platform/mac/media/controls-without-preload-expected.png:
- platform/mac/media/controls-without-preload-expected.txt:
- platform/mac/media/media-controls-clone-expected.png:
- platform/mac/media/media-controls-clone-expected.txt:
- webarchive/loading/video-in-webarchive-expected.txt:
- 8:55 AM Changeset in webkit [156545] by
-
- 7 edits2 adds in trunk
[css-shapes] Shapes are not resolved the same way in shape-inside and clip-path
https://bugs.webkit.org/show_bug.cgi?id=121922
Reviewed by Andreas Kling.
Source/WebCore:
Fix computation of a percentage radius for circle shape-outside to
match the CSS Shapes spec.
Test: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):
LayoutTests:
Add new test for circular shape-outside with percentage radius.
Update the nested container with unresolved height test because with a
circle it isn't really testing just for unresolved height behavior.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html:
- fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:
- 8:34 AM Changeset in webkit [156544] by
-
- 2 edits in trunk/LayoutTests
Unrehued mac-lion rebaseline.
- platform/mac-lion/js/dom/global-constructors-attributes-expected.txt:
- 8:09 AM Changeset in webkit [156543] by
-
- 119 edits2 adds in trunk
Add empty MainFrame class
https://bugs.webkit.org/show_bug.cgi?id=121770
Reviewed by Andreas Kling.
Source/WebCore:
For now, MainFrame simply derives from Frame and adds nothing.
Next, we will make each Frame point back to its MainFrame.
- CMakeLists.txt: Added MainFrame.cpp/h.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.exp.in: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- page/Frame.cpp:
(WebCore::Frame::Frame): Use references instead of pointers for constructor.
(WebCore::Frame::create): Pass references instead of pointers to constructor.
- page/Frame.h: Made constructor protected instead of private, and marked
destructor virtual explicitly. Also marked virtual functions OVERRIDE and FINAL.
- page/MainFrame.cpp: Added.
- page/MainFrame.h: Added.
- page/Page.cpp:
(WebCore::Page::Page): Use MainFrame::create instead of Frame::create.
(WebCore::Page::frameIsMainFrame): Moved here, no longer inline.
(WebCore::Page::renderTreeSize): Use const Frame* instead of Frame*.
(WebCore::Page::checkSubframeCountConsistency): Ditto.
- page/Page.h: Changed mainFrame() to return MainFrame& and m_mainFrame to
be a RefPtr<MainFrame>.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
- bindings/js/PageScriptDebugServer.cpp:
- bindings/js/ScriptProfiler.cpp:
- bindings/js/ScriptState.cpp:
- css/MediaQueryEvaluator.cpp:
- dom/Document.cpp:
- history/CachedFrame.cpp:
- history/CachedPage.cpp:
- history/PageCache.cpp:
- html/HTMLPlugInImageElement.cpp:
- inspector/InspectorAgent.cpp:
- inspector/InspectorCanvasAgent.cpp:
- inspector/InspectorClient.cpp:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorInputAgent.cpp:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorOverlay.cpp:
- inspector/InspectorPageAgent.cpp:
- inspector/PageRuntimeAgent.cpp:
- loader/FrameLoader.cpp:
- loader/HistoryController.cpp:
- loader/archive/mhtml/MHTMLArchive.cpp:
- page/AutoscrollController.cpp:
- page/Chrome.cpp:
- page/ContextMenuController.cpp:
- page/DOMWindow.cpp:
- page/DragController.cpp:
- page/EventHandler.cpp:
- page/FocusController.cpp:
- page/FrameTree.cpp:
- page/FrameView.cpp:
- page/GestureTapHighlighter.cpp:
- page/PageGroup.cpp:
- page/PageGroupLoadDeferrer.cpp:
- page/PageSerializer.cpp:
- page/PageThrottler.cpp:
- page/Settings.cpp:
- page/SpatialNavigation.cpp:
- page/mac/DragControllerMac.mm:
- page/mac/PageMac.cpp:
- page/scrolling/ScrollingCoordinator.cpp:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
- plugins/DOMMimeType.cpp:
- storage/StorageEventDispatcher.cpp:
- svg/graphics/SVGImage.cpp:
- testing/InternalSettings.cpp:
- testing/Internals.cpp:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit/efl:
- WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
- WebCoreSupport/InspectorClientEfl.cpp:
- ewk/ewk_view.cpp:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit/gtk:
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/GtkAdjustmentWatcher.cpp:
- webkit/webkitwebframe.cpp:
- webkit/webkitwebview.cpp:
- webkit/webkitviewportattributes.cpp:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit/mac:
- WebCoreSupport/WebDragClient.mm:
- WebCoreSupport/WebInspectorClient.mm:
- WebCoreSupport/WebPlatformStrategies.mm:
- WebView/WebFrame.mm:
- WebView/WebHTMLView.mm:
- WebView/WebView.mm:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit/qt:
- Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:
- Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:
- Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:
- Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:
- Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit/win:
- win/WebCoreSupport/WebDragClient.cpp:
- win/WebCoreSupport/WebContextMenuClient.cpp:
- win/WebDropSource.cpp:
- win/WebFrame.cpp:
- win/WebView.cpp:
Include MainFrame.h instead of Frame.h as needed.
Source/WebKit2:
- WebProcess/FullScreen/WebFullScreenManager.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/Storage/StorageAreaMap.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
- WebProcess/WebPage/FindController.cpp:
- WebProcess/WebPage/PageOverlay.cpp:
- WebProcess/WebPage/WebInspector.cpp:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
- WebProcess/WebPage/mac/WebPageMac.mm:
Include MainFrame.h instead of Frame.h as needed.
- 7:31 AM Changeset in webkit [156542] by
-
- 10 edits in trunk/Source/WebCore
Add toWebKitCSS*Value functions to cast from CSSValue
https://bugs.webkit.org/show_bug.cgi?id=121776
Reviewed by Andreas Kling.
CSS_VALUE_TYPE_CASTS can't cover WebKitCSS*Value classes. So, this patch adds toWebKitCSS*Value manually.
No new tests, no behavior change.
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/WebKitCSSArrayFunctionValue.h:
(WebCore::toWebKitCSSArrayFunctionValue):
- css/WebKitCSSFilterValue.h:
(WebCore::toWebKitCSSFilterValue):
- css/WebKitCSSMatFunctionValue.h:
(WebCore::toWebKitCSSMatFunctionValue):
- css/WebKitCSSMixFunctionValue.h:
(WebCore::toWebKitCSSMixFunctionValue):
- css/WebKitCSSSVGDocumentValue.h:
(WebCore::toWebKitCSSSVGDocumentValue):
- css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
- css/WebKitCSSTransformValue.h:
(WebCore::toWebKitCSSTransformValue):
- 6:48 AM Changeset in webkit [156541] by
-
- 4 edits in trunk
[GTK][WK2] Logging of accessibility events is not disabled between tests
https://bugs.webkit.org/show_bug.cgi?id=121957
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-27
Reviewed by Mario Sanchez Prada.
Tools:
Fixed an issue in AccessibilityNotificationHandler where the destructor
was not disconnecting accessibility event callbacks if logging was on.
The decision of disconnecting events can solely rely on the existence of
notification handlers because logging uses the global notification
handler.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
disconnection when logging is on.
LayoutTests:
Removed some accessibility tests from the expectations file that were
failing before this fix.
- platform/gtk-wk2/TestExpectations:
- 6:40 AM Changeset in webkit [156540] by
-
- 7 edits in trunk/Source
Pass VM instead of ExecState to JSDateMath functions.
<https://webkit.org/b/121997>
Reviewed by Geoffrey Garen.
The JSC date math functions only need the VM, so pass that from
callers instead of the whole ExecState.
- 6:31 AM Changeset in webkit [156539] by
-
- 3 edits in trunk/LayoutTests
[EFL] editing/selection/fake-doubleclick.html rebaseline after r140111
https://bugs.webkit.org/show_bug.cgi?id=121831
Unreviewed EFL gardening.
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-27
- platform/efl-wk2/TestExpectations:
- platform/efl/editing/selection/fake-doubleclick-expected.txt:
- 6:01 AM Changeset in webkit [156538] by
-
- 2 edits2 adds1 delete in trunk/Tools
Add general CMakeLists.txt for DRT
https://bugs.webkit.org/show_bug.cgi?id=119268
Reviewed by Gyuyoung Kim.
The new file allows better sharing between ports.
- CMakeLists.txt:
- DumpRenderTree/CMakeLists.txt: Added.
- DumpRenderTree/PlatformEfl.cmake: Added.
- DumpRenderTree/efl/CMakeLists.txt: Removed.
- 5:58 AM Changeset in webkit [156537] by
-
- 1 copy in releases/WebKitGTK/webkit-2.2.0
Tagging the WebKitGTK+ 2.2.0 release
- 5:47 AM Changeset in webkit [156536] by
-
- 5 edits2 adds in trunk
Unexpected word wrapping for wrapped content then raw content.
https://bugs.webkit.org/show_bug.cgi?id=121130
Reviewed by Darin Adler.
When deciding whether a line is considered empty, we need to check if the current
object is fully responsible for the currently uncommitted width. It helps differentiating
<span></span><span>abcd</span> from <span>a</span><span>bcd</span>, where in the first
case when we hit the second <span> the line is still considered empty, as opposed to the
second example.
This patch introduces a map to keep track of the uncommitted widths.
Source/WebCore:
Test: fast/css/unexpected-word-wrapping-with-non-empty-spans.html
- rendering/LineWidth.cpp:
(WebCore::LineWidth::uncommittedWidthForObject):
(WebCore::LineWidth::addUncommittedWidth):
- rendering/LineWidth.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Added.
- fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Added.
- 5:16 AM Changeset in webkit [156535] by
-
- 6 edits in trunk
[Qt] Fix force_static_libs_as_shared in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121961
Reviewed by Csaba Osztrogonác.
Source/WebKit/qt:
- WebCoreSupport/QWebFrameAdapter.h:
Source/WebKit2:
Do not add strict ordering for webkit2qml. It is not needed and causes
Target.pri to be built out of order.
- WebKit2.pro:
Tools:
Reenable force_static_libs_as_shared when building WebKit2.
- qmake/mkspecs/features/default_post.prf:
- 4:57 AM Changeset in webkit [156534] by
-
- 3 edits in trunk/Tools
[Qt] Mock implementations of positioning and orientation not used
https://bugs.webkit.org/show_bug.cgi?id=121956
Reviewed by Csaba Osztrogonác.
Move production_build checks to sanitizeFeatures where its value is actually known.
- qmake/mkspecs/features/features.prf:
- qmake/mkspecs/features/features.pri:
- 3:40 AM Changeset in webkit [156533] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2
Unreviewed. Update NEWS and Versions.m4 for 2.2.0 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Add release notes.
- 2:44 AM Changeset in webkit [156532] by
-
- 23 edits2 adds in trunk
[ATK] Protect entry points in the ATK wrapper against outdated render trees
https://bugs.webkit.org/show_bug.cgi?id=121558
Reviewed by Chris Fleizach.
Source/WebCore:
Make sure that we protect every entry point in the ATK wrapper
against outdated render trees, before using the WebCore's
accessibility API, since that might lead to problems (and crashes)
if the render and accessibility trees are not stable.
Thus, call AccessibilityObject::updateBackingStore() in those
entry points and check whether the ATK wrapper is detached or not
after that, to decide whether to continue or not.
Besides providing a new test to check that it WebKit does not
crash in a given scenario (which actually triggered the
investigation here), solving this situation also fixes other tests
that were previously failing (aria-used-on-image-maps.html) or
that were printing wrong results, not detected until now due to
wrong platform specific expectations (file-upload-button-stringvalue
and deleting-iframe-destroys-axcache).
Test: accessibility/heading-crash-after-hidden.html
- accessibility/atk/WebKitAccessibleUtil.h: Added two new macros
to inject the needed code at the beginning of each entry point to
allow gracefully exit those functions when the render tree is
unstable. Inspired by g_return_if_fail and g_return_val_if_fail, we
called them returnIfWebKitAccessibleIsInvalid and returnValIfWebKitAccessibleIsInvalid.
- accessibility/atk/WebKitAccessibleHyperlink.cpp:
(webkitAccessibleHyperlinkActionDoAction): Protect entry point.
(webkitAccessibleHyperlinkActionGetNActions): Ditto.
(webkitAccessibleHyperlinkActionGetDescription): Ditto.
(webkitAccessibleHyperlinkActionGetKeybinding): Ditto.
(webkitAccessibleHyperlinkActionGetName): Ditto.
(webkitAccessibleHyperlinkGetURI): Ditto.
(webkitAccessibleHyperlinkGetObject): Ditto.
(webkitAccessibleHyperlinkGetStartIndex): Ditto.
(webkitAccessibleHyperlinkGetEndIndex): Ditto.
(webkitAccessibleHyperlinkIsValid): Ditto.
(webkitAccessibleHyperlinkGetNAnchors): Ditto.
(webkitAccessibleHyperlinkIsSelectedLink): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceAction.cpp:
(webkitAccessibleActionDoAction): Ditto.
(webkitAccessibleActionGetNActions): Ditto.
(webkitAccessibleActionGetDescription): Ditto.
(webkitAccessibleActionGetKeybinding): Ditto.
(webkitAccessibleActionGetName): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:
(webkitAccessibleComponentRefAccessibleAtPoint): Ditto.
(webkitAccessibleComponentGetExtents): Ditto.
(webkitAccessibleComponentGrabFocus): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:
(webkitAccessibleDocumentGetAttributeValue): Ditto.
(webkitAccessibleDocumentGetAttributes): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp:
(webkitAccessibleEditableTextSetRunAttributes): Ditto.
(webkitAccessibleEditableTextSetTextContents): Ditto.
(webkitAccessibleEditableTextInsertText): Ditto.
(webkitAccessibleEditableTextCopyText): Ditto.
(webkitAccessibleEditableTextCutText): Ditto.
(webkitAccessibleEditableTextDeleteText): Ditto.
(webkitAccessibleEditableTextPasteText): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:
(webkitAccessibleHypertextGetLink): Ditto.
(webkitAccessibleHypertextGetNLinks): Ditto.
(webkitAccessibleHypertextGetLinkIndex): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceImage.cpp:
(webkitAccessibleImageGetImagePosition): Ditto.
(webkitAccessibleImageGetImageDescription): Ditto.
(webkitAccessibleImageGetImageSize): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
(webkitAccessibleSelectionAddSelection): Ditto.
(webkitAccessibleSelectionClearSelection): Ditto.
(webkitAccessibleSelectionRefSelection): Ditto.
(webkitAccessibleSelectionGetSelectionCount): Ditto.
(webkitAccessibleSelectionIsChildSelected): Ditto.
(webkitAccessibleSelectionRemoveSelection): Ditto.
(webkitAccessibleSelectionSelectAllSelection): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableRefAt): Ditto.
(webkitAccessibleTableGetIndexAt): Ditto.
(webkitAccessibleTableGetColumnAtIndex): Ditto.
(webkitAccessibleTableGetRowAtIndex): Ditto.
(webkitAccessibleTableGetNColumns): Ditto.
(webkitAccessibleTableGetNRows): Ditto.
(webkitAccessibleTableGetColumnExtentAt): Ditto.
(webkitAccessibleTableGetRowExtentAt): Ditto.
(webkitAccessibleTableGetColumnHeader): Ditto.
(webkitAccessibleTableGetRowHeader): Ditto.
(webkitAccessibleTableGetCaption): Ditto.
(webkitAccessibleTableGetColumnDescription): Ditto.
(webkitAccessibleTableGetRowDescription): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetText): Ditto.
(webkitAccessibleTextGetTextAfterOffset): Ditto.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.
(webkitAccessibleTextGetCharacterAtOffset): Ditto.
(webkitAccessibleTextGetCaretOffset): Ditto.
(webkitAccessibleTextGetRunAttributes): Ditto.
(webkitAccessibleTextGetDefaultAttributes): Ditto.
(webkitAccessibleTextGetCharacterExtents): Ditto.
(webkitAccessibleTextGetRangeExtents): Ditto.
(webkitAccessibleTextGetCharacterCount): Ditto.
(webkitAccessibleTextGetOffsetAtPoint): Ditto.
(webkitAccessibleTextGetNSelections): Ditto.
(webkitAccessibleTextGetSelection): Ditto.
(webkitAccessibleTextAddSelection): Ditto.
(webkitAccessibleTextSetSelection): Ditto.
(webkitAccessibleTextRemoveSelection): Ditto.
(webkitAccessibleTextSetCaretOffset): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceValue.cpp:
(webkitAccessibleValueGetCurrentValue): Ditto.
(webkitAccessibleValueGetMaximumValue): Ditto.
(webkitAccessibleValueGetMinimumValue): Ditto.
(webkitAccessibleValueSetCurrentValue): Ditto.
(webkitAccessibleValueGetMinimumIncrement): Ditto.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(core): Removed, as it's not actually needed.
(webkitAccessibleGetName): Protect entry point.
(webkitAccessibleGetDescription): Ditto.
(webkitAccessibleGetParent): Ditto.
(webkitAccessibleGetNChildren): Ditto.
(webkitAccessibleRefChild): Ditto.
(webkitAccessibleGetIndexInParent): Ditto.
(webkitAccessibleGetAttributes): Ditto.
(webkitAccessibleGetRole): Ditto.
(webkitAccessibleRefStateSet): Ditto.
(webkitAccessibleRefRelationSet): Ditto.
(webkitAccessibleGetObjectLocale): Ditto.
(webkitAccessibleDetach): Ditto.
(webkitAccessibleIsDetached): New helper function, to be used from
the newly added macros. We need to check whether the wrapper is
detached and not just the wrapper AccessibilityObject since once
the detachment happens we can't trust anything but the AtkObject
from the wrapper (the AccessibilityObject might be invalid).
- accessibility/atk/WebKitAccessibleWrapperAtk.h:
Assert that the render tree is neither being updated nor in need
of being updated before trying to compute the text under a given
element, since that might lead to crashes due to the constructor
of TextIterator calling updateLayoutIgnorePendingStylesheets().
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement): Assert that
the render tree is neither being updated nor needing updating.
LayoutTests:
Added a new test to check that we do not crash in certain
scenarios when hiding objects and retriving accessibility
information about it.
- accessibility/heading-crash-after-hidden-expected.txt: Added.
- accessibility/heading-crash-after-hidden.html: Added.
Rebaselined expectations that were wrong before, since they were
not returning the actual value that they should be returning when
called AccessibilityUIElement::stringValue().
- platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt:
Updated, since the actual text being returned should be the actual
value of the file chooser (e.g. "(None)") and not the text in the
upload botton (e.g. "Choose files").
- platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Ditto.
- platform/gtk-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Ditto..
- platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Ditto.
- platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt:
Updated, since the iframe should be exposed at all after deleting it.
Removed accesibility test now passing after fixing this issue.
- platform/gtk/TestExpectations: Removed accessibility/aria-used-on-image-maps.html.
- 2:07 AM Changeset in webkit [156531] by
-
- 3 edits in trunk/Tools
[ATK] Normalize checks in entry points for DRT and WKTR
https://bugs.webkit.org/show_bug.cgi?id=121959
Reviewed by Chris Fleizach.
Always check if we have a proper instance of AtkObject,
implementing the interfaces that we might need for each case, at
the entry point of every method of AccessibilityUIElement for ATK,
and do those checks in an uniform way across DRT and WKTR, to
avoid confusion and issues when modifying these files in the future.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::getChildren): Use normalized checks.
(AccessibilityUIElement::getChildrenWithRange): Ditto.
(AccessibilityUIElement::rowCount): Ditto.
(AccessibilityUIElement::columnCount): Ditto.
(AccessibilityUIElement::childrenCount): Ditto.
(AccessibilityUIElement::elementAtPoint): Ditto.
(AccessibilityUIElement::getChildAtIndex): Ditto.
(AccessibilityUIElement::allAttributes): Ditto.
(AccessibilityUIElement::titleUIElement): Ditto.
(AccessibilityUIElement::parentElement): Ditto.
(AccessibilityUIElement::attributesOfChildren): Ditto.
(AccessibilityUIElement::role): Ditto.
(AccessibilityUIElement::title): Ditto.
(AccessibilityUIElement::description): Ditto.
(AccessibilityUIElement::stringValue): Ditto.
(AccessibilityUIElement::language): Ditto.
(AccessibilityUIElement::x): Ditto.
(AccessibilityUIElement::y): Ditto.
(AccessibilityUIElement::width): Ditto.
(AccessibilityUIElement::height): Ditto.
(AccessibilityUIElement::orientation): Ditto.
(AccessibilityUIElement::intValue): Ditto.
(AccessibilityUIElement::minValue): Ditto.
(AccessibilityUIElement::maxValue): Ditto.
(indexRangeInTable): Ditto.
(AccessibilityUIElement::cellForColumnAndRow): Ditto.
(AccessibilityUIElement::stringAttributeValue): Ditto.
(alterCurrentValue): Ditto.
(AccessibilityUIElement::press): Ditto.
(AccessibilityUIElement::documentEncoding): Ditto.
(AccessibilityUIElement::documentURI): Ditto.
(AccessibilityUIElement::hasPopup): Ditto.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::indexRangeInTable): Use normalized checks.
(WTR::alterCurrentValue): Ditto.
(WTR::AccessibilityUIElement::getChildren): Ditto.
(WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
(WTR::AccessibilityUIElement::childrenCount): Ditto.
(WTR::AccessibilityUIElement::elementAtPoint): Ditto.
(WTR::AccessibilityUIElement::indexOfChild): Ditto.
(WTR::AccessibilityUIElement::childAtIndex): Ditto.
(WTR::AccessibilityUIElement::titleUIElement): Ditto.
(WTR::AccessibilityUIElement::parentElement): Ditto.
(WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
(WTR::AccessibilityUIElement::allAttributes): Ditto.
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
(WTR::AccessibilityUIElement::role): Ditto.
(WTR::AccessibilityUIElement::title): Ditto.
(WTR::AccessibilityUIElement::description): Ditto.
(WTR::AccessibilityUIElement::orientation): Ditto.
(WTR::AccessibilityUIElement::stringValue): Ditto.
(WTR::AccessibilityUIElement::language): Ditto.
(WTR::AccessibilityUIElement::x): Ditto.
(WTR::AccessibilityUIElement::y): Ditto.
(WTR::AccessibilityUIElement::width): Ditto.
(WTR::AccessibilityUIElement::height): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::minValue): Ditto.
(WTR::AccessibilityUIElement::maxValue): Ditto.
(WTR::AccessibilityUIElement::rowCount): Ditto.
(WTR::AccessibilityUIElement::columnCount): Ditto.
(WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
(WTR::AccessibilityUIElement::press): Ditto.
(WTR::AccessibilityUIElement::documentEncoding): Ditto.
(WTR::AccessibilityUIElement::documentURI): Ditto.
(WTR::AccessibilityUIElement::hasPopup): Ditto.
- 1:58 AM Changeset in webkit [156530] by
-
- 5 edits in trunk
[ATK] accessibility/aria-sort.html is failing after r156409
https://bugs.webkit.org/show_bug.cgi?id=121947
Reviewed by Chris Fleizach.
Source/WebCore:
The WAI-ARIA spec says to translate the value as is from the
attribute, so do just that instead of mapping values from the
AccessibilitySortDirection enumeration into strings.
http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Do the right mapping for aria-sort.
Tools:
Implement AccessibilityUIElement::isSupported for the ATK
platforms, just by checking whether we have an associated object
attribute exposed for the wrapper object matching the required
attribute in the layout test (e.g "AXSortDirection" -> "sort").
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isAttributeSupported): Implemented.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
- 1:47 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:48 AM Changeset in webkit [156529] by
-
- 2 edits in trunk/Source/WTF
[GCC] Fix build with gcc < 4.8.1, which does not have is_trivially_destructible
https://bugs.webkit.org/show_bug.cgi?id=121999
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-09-27
Reviewed by Benjamin Poulain.
- wtf/StdLibExtras.h:
Sep 26, 2013:
- 8:26 PM Changeset in webkit [156528] by
-
- 3 edits in trunk/Source/WebCore
Sync toWebKitCSSShaderValue() behavior with other toCSSFooValue()
https://bugs.webkit.org/show_bug.cgi?id=121886
Reviewed by Darin Adler.
toWebKitCSSShaderValue() behavior is different from other to CSSFooValue().
It shouldn't return null. The type checking should be done before doing type cast.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
- css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
- 7:02 PM Changeset in webkit [156527] by
-
- 32 edits in trunk
Move m_style to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121936
Source/WebCore:
Reviewed by Andreas Kling.
Text renderers always have the same style as their parent. They can get their style via the parent pointer
rather than having a member of their own.
This shrinks RenderText by a pointer.
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::didRecalcStyle):
Text renderers have no independent style. No need to set it.
- editing/ApplyBlockElementCommand.cpp:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):
Avoid getting style from text child before it is added to tree.
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::setText):
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
Don't set text style anymore.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::setStyle):
Notify child text renderers of style change.
(WebCore::RenderElement::setAnimatableStyle):
(WebCore::RenderElement::setPseudoStyle):
Push down to RenderElement, remove text branches.
(WebCore::RenderElement::addChild):
Notify text renderers of style change when added to tree.
(WebCore::RenderElement::propagateStyleToAnonymousChildren):
- rendering/RenderElement.h:
(WebCore::RenderElement::style):
(WebCore::RenderElement::setStyleInternal):
Move m_style from RenderObject.
(WebCore::RenderObject::style):
Inline this in RenderElement.h instead of making it virtual.
- rendering/RenderInline.cpp:
(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::styleDidChange):
Tighten typing to call RenderElement::setStyle.
(WebCore::RenderInline::clippedOverflowRectForRepaint):
Change assert. This can get legitimately called during layout for the first letter renderers.
This was previously avoided by luck.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::styleDidChange):
(WebCore::RenderMenuList::setText):
Don't set text style anymore.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::hasEntirelyFixedBackground):
(WebCore::RenderObject::container):
(WebCore::RenderObject::cachedFirstLineStyle):
Switch to style(), avoid unnecessary repetition.
Move code out.
- rendering/RenderObject.h:
Move functions to RenderElement.
(WebCore::RenderObject::isBeforeContent):
(WebCore::RenderObject::isAfterContent):
Avoid accessing style for text renderers as these are called before the renderer
is added to tree.
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::setObjectStyleInRegion):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::updateCancelButtonVisibility):
- rendering/RenderText.cpp:
- rendering/RenderText.h:
Remove setStyle.
(WebCore::RenderText::style):
Get style from parent.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):
- rendering/style/ContentData.cpp:
(WebCore::TextContentData::createRenderer):
(WebCore::CounterContentData::createRenderer):
(WebCore::QuoteContentData::createRenderer):
Pseudo style for RenderText subclasses comes from parent without any explicit setting.
- style/StyleResolveTree.cpp:
(WebCore::Style::createTextRendererIfNeeded):
(WebCore::Style::resolveLocal):
(WebCore::Style::updateTextStyle):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::resolveTree):
No need to set or update text renderer style separately.
LayoutTests:
Reviewed by Andreas Kling.
Progressions from text style updating correctly in all cases.
- compositing/contents-opaque/hidden-with-visible-text-expected.txt:
- compositing/contents-opaque/visibility-hidden-expected.txt:
Can't figure out why these progress but they do. The new rendering (showing nothing)
is correct and matches Firefox.
- platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt:
- platform/mac/svg/custom/getTransformToElement-expected.txt:
- platform/mac/svg/custom/text-ctm-expected.txt:
- platform/mac/svg/custom/text-hit-test-expected.txt:
- platform/mac/svg/text/append-text-node-to-tspan-expected.txt:
- 6:58 PM Changeset in webkit [156526] by
-
- 2 edits in trunk/Source/WTF
"Build fix".
We can't use std::move. Explicitly destroy the old value and then construct the new in place.
- wtf/HashTable.h:
- 6:56 PM Changeset in webkit [156525] by
-
- 5 edits in trunk
Fixed a version number string in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122004
Reviewed by Gavin Barraclough.
PerformanceTests/SunSpider:
- resources/driver-TEMPLATE.html:
- resources/results-TEMPLATE.html: 1.0.2!
Websites/webkit.org:
- perf/sunspider-1.0.2/sunspider-1.0.2/results.html: 1.0.2!
- 6:51 PM Changeset in webkit [156524] by
-
- 2 edits in trunk/Source/WTF
Use the move assignment operator when reinserting values in the hash map
https://bugs.webkit.org/show_bug.cgi?id=122003
Reviewed by Alexey Proskuryakov.
Using the move assignment operator ensures that the existing values will be destroyed correctly.
- wtf/HashTable.h:
- 6:46 PM Changeset in webkit [156523] by
-
- 4 edits39 adds in trunk
Tentative SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122002
Reviewed by Gavin Barraclough.
PerformanceTests/SunSpider:
Be even more aggressive about asking for zero delay between tests by
setting a timeout at the beginning of a test instead of the end. This is
another step toward reducing noise -- particularly noise caused by
power management -- just like the step down from 10ms to 0ms.
Browsers typically put a 4ms floor on timers. The sooner we set
our timer, the sooner it will fire.
- make-hosted:
- resources/driver-TEMPLATE.html: Changed the driver to set the timeout
earlier.
- tests/sunspider-1.0.2: Added. These tests are unchanged from 1.0.1.
Websites/webkit.org:
See comments in PerformanceTests/SunSpider.
- perf/sunspider-1.0.2: Added.
- 6:08 PM Changeset in webkit [156522] by
-
- 29 edits4 adds in trunk
[MediaStream] make MediaStream testable
https://bugs.webkit.org/show_bug.cgi?id=121967
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, existing tests updated.
- CMakeLists.txt: Add MockMediaStreamCenter.
- GNUmakefile.list.am: Ditto.
- Modules/mediastream/MediaStreamTrack.idl: Add SkipVTableValidation.
- Modules/mediastream/NavigatorUserMediaError.idl: Add JSGenerateToJSObject.
- WebCore.exp.in: Export MockMediaStreamCenter::registerMockMediaStreamCenter.
- WebCore.xcodeproj/project.pbxproj: Add MockMediaStreamCenter.
- dom/DOMError.h: Make the destructor virtual because it has a derived class.
- dom/DOMError.idl:
- platform/mock/MockMediaStreamCenter.cpp: Added.
- platform/mock/MockMediaStreamCenter.h: Added.
- testing/Internals.cpp: Register the mock stream center.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Add WebUserMediaClient.
Source/WebKit/mac:
- WebCoreSupport/WebUserMediaClient.h: Added.
- WebCoreSupport/WebUserMediaClient.mm: Added.
- WebView/WebUIDelegatePrivate.h: Declare decidePolicyForUserMediaRequestFromOrigin:listener:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Register WebUserMediaClient.
(-[WebView _setUserMediaClient:]): New.
(-[WebView _userMediaClient]): New.
- WebView/WebViewData.h:
- WebView/WebViewPrivate.h:
Tools:
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
user media request policy delegate.
LayoutTests:
- fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
- fast/mediastream/MediaStream-add-remove-tracks.html: Make the test results more understandable
to simplify debugging failures.
- fast/mediastream/MediaStream-onended-expected.txt:
- fast/mediastream/MediaStream-onended.html: Ditto. Fix a test error: stopping stream A should
not stop stream B even when it was created from stream A.
- fast/mediastream/MediaStreamConstructor-expected.txt:
- fast/mediastream/MediaStreamConstructor.html: Make the test results more understandable. Fix a
logic errors: webkitMediaStream is an object, not a function. JSC does not support
object.constructor.name, use object.constructor.toString() instead.
- fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
- fast/mediastream/MediaStreamTrackEvent-constructor.html: Update now that getUserMedia() works.
- fast/mediastream/argument-types-expected.txt: Updated with "Failing" results because the correct
behavior is unknown. The spec says "the syntax for getUserMedia() is still under discussion".
- 5:39 PM Changeset in webkit [156521] by
-
- 8 edits in trunk/Source/JavaScriptCore
GetterSetter construction should take a VM instead of ExecState.
<https://webkit.org/b/121993>
Reviewed by Sam Weinig.
Pass VM& instead of ExecState* to GetterSetter. Updated surrounding
code at touched sites to cache VM in a local for fewer loads.
JSC release binary size -= 4120 bytes.
- 5:27 PM Changeset in webkit [156520] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: dissociate old content views that are spliced from back/forward list
https://bugs.webkit.org/show_bug.cgi?id=121987
Patch by Brian J. Burg <Brian Burg> on 2013-09-26
Reviewed by Timothy Hatcher.
There was a bug where old back/forward list entries were not being dissociated when
the newly-shown content view was already in the list. Instead, dissociation should be
skipped if the old list entry is not already in the list.
- UserInterface/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.showContentView):
- 5:27 PM Changeset in webkit [156519] by
-
- 2 edits in trunk/LayoutTests
Layout Test http/tests/inspector/network/network-iframe-load-and-delete.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121998
- platform/mac/TestExpectations: Marking as such.
- 5:23 PM Changeset in webkit [156518] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make GCC happy
- 4:51 PM Changeset in webkit [156517] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed Build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing
symbol export to support tests.
- 4:37 PM Changeset in webkit [156516] by
-
- 2 edits in trunk/Source/WTF
[Windows] Work around missing C++11 features of MSVC by providing an implementation for
std::is_trivially_destructible based on the existing std::has_trivial_destructor.
Rubber-stamped by Anders Carlsson.
- wtf/StdLibExtras.h: Add implementation for is_trivially_destructable for MSVC 2010 and prior.
- 4:36 PM Changeset in webkit [156515] by
-
- 5 edits in trunk/Source/WebCore
Move CSS MatchRequest from StyleResolver to a private definition in ElementRuleCollector
https://bugs.webkit.org/show_bug.cgi?id=121986
Reviewed by Andreas Kling.
MatchRequest is an internal type of ElementRuleCollector now, move the definition
to ElementRuleCollector.
- css/DocumentRuleSets.h:
- css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::MatchRequest::MatchRequest):
- css/StyleResolver.h:
- 4:32 PM Changeset in webkit [156514] by
-
- 19 edits12 adds in trunk
2013-09-25 Oliver Hunt <oliver@apple.com>
Implement prefixed-destructuring assignment
https://bugs.webkit.org/show_bug.cgi?id=121930
Reviewed by Mark Hahnenberg.
Relanding with fix after rollout
- 4:16 PM Changeset in webkit [156513] by
-
- 4 edits in trunk/Source/WebCore
[Windows] Unreviewed build fix after r156487.
Add explicit casting needed by MSVC to compile this code. Much
of this could probably be removed when we move to VS2012 or newer.
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
- 4:00 PM Changeset in webkit [156512] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r156510.
http://trac.webkit.org/changeset/156510
https://bugs.webkit.org/show_bug.cgi?id=121989
Landed in-progress code along with build fix. (Requested by
bfulgham on #webkit).
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApply):
- platform/graphics/win/DIBPixelData.cpp:
(WebCore::DIBPixelData::writeToFile):
- platform/graphics/win/DIBPixelData.h:
- 3:53 PM Changeset in webkit [156511] by
-
- 68 edits in trunk/Source/JavaScriptCore
VirtualRegister should be a class
https://bugs.webkit.org/show_bug.cgi?id=121732
Reviewed by Geoffrey Garen.
This is a refactoring change. Changed VirtualRegister from an enum to a class.
Moved Operands::operandIsArgument(), operandToArgument(), argumentToOperand()
and the similar functions for locals to VirtualRegister class.
This is in preparation for changing the offset for the first local register from
0 to -1. This is needed since most native calling conventions have the architected
frame pointer (e.g. %rbp for X86) point at the slot that stores the previous frame
pointer. Local values start below that address.
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
- bytecode/Instruction.h:
- bytecode/LazyOperandValueProfile.h:
- bytecode/MethodOfGettingAValueProfile.cpp:
- bytecode/Operands.h:
- bytecode/UnlinkedCodeBlock.cpp:
- bytecode/UnlinkedCodeBlock.h:
- bytecode/ValueRecovery.h:
- bytecode/VirtualRegister.h:
- bytecompiler/BytecodeGenerator.cpp:
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/RegisterID.h:
- debugger/DebuggerCallFrame.cpp:
- dfg/DFGAbstractHeap.h:
- dfg/DFGAbstractInterpreterInlines.h:
- dfg/DFGArgumentPosition.h:
- dfg/DFGArgumentsSimplificationPhase.cpp:
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGCFGSimplificationPhase.cpp:
- dfg/DFGCPSRethreadingPhase.cpp:
- dfg/DFGCapabilities.cpp:
- dfg/DFGConstantFoldingPhase.cpp:
- dfg/DFGFlushLivenessAnalysisPhase.cpp:
- dfg/DFGGraph.cpp:
- dfg/DFGGraph.h:
- dfg/DFGJITCode.cpp:
- dfg/DFGNode.h:
- dfg/DFGOSREntry.cpp:
- dfg/DFGOSREntrypointCreationPhase.cpp:
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompiler32_64.cpp:
- dfg/DFGOSRExitCompiler64.cpp:
- dfg/DFGRegisterBank.h:
- dfg/DFGScoreBoard.h:
- dfg/DFGSpeculativeJIT.cpp:
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
- dfg/DFGSpeculativeJIT64.cpp:
- dfg/DFGValidate.cpp:
- dfg/DFGValueRecoveryOverride.h:
- dfg/DFGVariableAccessData.h:
- dfg/DFGVariableEvent.h:
- dfg/DFGVariableEventStream.cpp:
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
- ftl/FTLExitArgumentForOperand.h:
- ftl/FTLLink.cpp:
- ftl/FTLLowerDFGToLLVM.cpp:
- ftl/FTLOSREntry.cpp:
- ftl/FTLOSRExit.cpp:
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompiler.cpp:
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
- jit/AssemblyHelpers.h:
- jit/JIT.h:
- jit/JITCall.cpp:
- jit/JITCall32_64.cpp:
- jit/JITInlines.h:
- jit/JITOpcodes.cpp:
- jit/JITOpcodes32_64.cpp:
- jit/JITPropertyAccess32_64.cpp:
- jit/JITStubs.cpp:
- llint/LLIntSlowPaths.cpp:
- profiler/ProfilerBytecodeSequence.cpp:
- runtime/CommonSlowPaths.cpp:
- runtime/JSActivation.cpp:
- 3:49 PM Changeset in webkit [156510] by
-
- 7 edits in trunk/Source/WebCore
[Windows] Unreviewed build fix after r156487.
Add explicit casting needed by MSVC to compile this code. Much
of this could probably be removed when we move to VS2012 or newer.
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApply):
- platform/graphics/win/DIBPixelData.cpp:
(WebCore::DIBPixelData::DIBPixelData):
(WebCore::DIBPixelData::writeToFile):
- platform/graphics/win/DIBPixelData.h:
- 3:47 PM Changeset in webkit [156509] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: transitions/cancel-transition.html
https://bugs.webkit.org/show_bug.cgi?id=114193
- platform/mac/TestExpectations: Marking as flaky. Dean says that such tests are
currently broken by design.
- 3:45 PM Changeset in webkit [156508] by
-
- 8 edits2 deletes in trunk/Source/WebKit2
Remove Windows code
https://bugs.webkit.org/show_bug.cgi?id=121988
Reviewed by Antti Koivisto.
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/win/ConnectionWin.cpp: Removed.
- Platform/SharedMemory.h:
- Platform/WorkQueue.h:
- Platform/win/SharedMemoryWin.cpp: Removed.
- Platform/win/WorkQueueWin.cpp: Removed.
- Shared/ChildProcess.cpp:
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::didFinishLaunching):
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
- WebProcess/WebProcess.cpp:
- 3:37 PM Changeset in webkit [156507] by
-
- 5 edits in trunk/Source/WTF
Remove needsDestruction from vector and hash traits
https://bugs.webkit.org/show_bug.cgi?id=121983
Reviewed by Sam Weinig.
For Vector, use std::is_trivially_destructible to determine whether to call the destructor.
For HashTable, always call the destructor; if it is trivial then no code will be generated for it and the loops will be folded away.
Removing this does break the ability to store objects with non-trivial destructors in vectors and hash maps
and have their destructors not be called when removed, but we've never used this feature in WebKit so the extra
code complexity is not worth it.
- wtf/HashTable.h:
(WTF::::deallocateTable):
- wtf/HashTraits.h:
- wtf/Vector.h:
(WTF::VectorTypeOperations::destruct):
- wtf/VectorTraits.h:
- 3:29 PM Changeset in webkit [156506] by
-
- 6 edits2 adds in trunk
Expose a setting to disable hardware accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=121978
<rdar://problem/15091284>
Reviewed by Eric Carlson.
Source/WebCore:
Expose acceleratedCompositedAnimationsEnabled
to disable CoreAnimation animations.
Test: LayoutTests/animations/transform-non-accelerated.html
- WebCore.exp.in: Export new method.
- page/Settings.in: Add new setting.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation): Don't go
to GraphicsLayer if the setting is false.
LayoutTests:
- animations/resources/animation-test-helpers.js: Add a callback
for when the tests finish. Minor cleanup.
(endTest):
(.else):
(runAnimationTest):
- animations/transform-non-accelerated.html: New test.
- animations/transform-non-accelerated-expected.txt: Result.
- 3:25 PM Changeset in webkit [156505] by
-
- 4 edits in trunk/Source
Source/JavaScriptCore: Work around another MSVC bug.
- runtime/PrototypeMap.cpp:
(JSC::PrototypeMap::emptyObjectStructureForPrototype):
Source/WTF: Build fixes.
Fix a paste-o.
- wtf/StdLibExtras.h:
(std::make_unique):
- 3:20 PM Changeset in webkit [156504] by
-
- 2 edits in trunk/Source/JavaScriptCore
Attempt to fix the FTL build.
- ftl/FTLAbstractHeap.cpp:
(JSC::FTL::IndexedAbstractHeap::atSlow):
- 3:19 PM Changeset in webkit [156503] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix build after r156487.
https://bugs.webkit.org/show_bug.cgi?id=121984
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-26
Reviewed by Anders Carlsson.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::jsObjectRef):
- 3:15 PM Changeset in webkit [156502] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebKit/win
Merged r156433. <rdar://problem/15092137>
- 3:13 PM Changeset in webkit [156501] by
-
- 5 edits in branches/safari-537.60-branch/Source
Merged r156416. <rdar://problem/15092135>
- 3:01 PM Changeset in webkit [156500] by
-
- 4 edits in trunk/Source/WebCore
Don't mutate style in RenderCombineText
https://bugs.webkit.org/show_bug.cgi?id=121979
Reviewed by Andreas Kling.
Text renderers should always have the same style as the parent.
- rendering/InlineTextBox.cpp:
(WebCore::fontToUse):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
Select the modified font for text-combine.
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
(WebCore::RenderCombineText::combineText):
- rendering/RenderCombineText.h:
Move the text-combine specific font style to a member of its own.
- 2:45 PM Changeset in webkit [156499] by
-
- 26 edits in trunk/Source/WebCore/bindings/scripts/test/JS
Update expected binding test results after r156498.
- 2:43 PM Changeset in webkit [156498] by
-
- 56 edits in trunk/Source/JavaScriptCore
Pass VM instead of ExecState to many finishCreation() functions.
<https://webkit.org/b/121975>
Reviewed by Sam Weinig.
Reduce unnecessary loads by passing the VM to object creation
functions that don't need the ExecState.
There are tons of opportunities in this area, I'm just scratching
the surface.
- 2:27 PM Changeset in webkit [156497] by
-
- 19 edits12 deletes in trunk
Unreviewed, rolling out r156464 and r156480.
http://trac.webkit.org/changeset/156464
http://trac.webkit.org/changeset/156480
https://bugs.webkit.org/show_bug.cgi?id=121981
Leaking too much and killi
ng buildbot. (Requested by xenon on
#webkit).
Source/JavaScriptCore:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::paramString):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitExpressionInfo):
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::FuncExprNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::addVar):
- parser/NodeConstructors.h:
(JSC::CommaNode::CommaNode):
(JSC::ParameterNode::ParameterNode):
(JSC::ForInNode::ForInNode):
- parser/Nodes.cpp:
(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):
- parser/Nodes.h:
(JSC::CommaNode::append):
(JSC::ParameterNode::ident):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::identifiers):
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseFormalParameters):
(JSC::::parseAssignmentExpression):
- parser/Parser.h:
(JSC::Scope::declareParameter):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::operatorStackPop):
- runtime/JSONObject.cpp:
- runtime/JSONObject.h:
LayoutTests:
- js/destructuring-assignment-expected.txt: Removed.
- js/destructuring-assignment.html: Removed.
- js/mozilla/strict/13.1-expected.txt:
- js/mozilla/strict/regress-532254-expected.txt:
- js/mozilla/strict/script-tests/13.1.js:
- js/regress/destructuring-arguments-expected.txt: Removed.
- js/regress/destructuring-arguments-length-expected.txt: Removed.
- js/regress/destructuring-arguments-length.html: Removed.
- js/regress/destructuring-arguments.html: Removed.
- js/regress/destructuring-swap-expected.txt: Removed.
- js/regress/destructuring-swap.html: Removed.
- js/regress/script-tests/destructuring-arguments-length.js: Removed.
- js/regress/script-tests/destructuring-arguments.js: Removed.
- js/regress/script-tests/destructuring-swap.js: Removed.
- js/script-tests/destructuring-assignment.js: Removed.
- sputnik/Conformance/13_Function_Definition/S13_A5.html:
- 2:25 PM Changeset in webkit [156496] by
-
- 2 edits in trunk/Source/WTF
Remove the hash table mover
https://bugs.webkit.org/show_bug.cgi?id=121980
Reviewed by Andreas Kling.
Use std::move instead.
- wtf/HashTable.h:
- 2:07 PM Changeset in webkit [156495] by
-
- 3 edits1 copy1 add in trunk/LayoutTests
Layout Test plugins/access-after-page-destroyed.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121976
Reviewed by Anders Carlsson.
Clean up the test.
- plugins/access-after-page-destroyed-2-expected.txt: Added.
- plugins/access-after-page-destroyed-2.html: Copied from LayoutTests/plugins/access-after-page-destroyed.html.
This was testing two distinct issues, the second one unfittingly piled onto the first.
Split the test in two.
- plugins/access-after-page-destroyed-expected.txt:
- plugins/access-after-page-destroyed.html:
Modernized the test with js-test scripts, added a gc() call for predictability,
changed the test to fail quickly in the flaky case.
- 1:59 PM Changeset in webkit [156494] by
-
- 3 edits in trunk/Source/JavaScriptCore
Try to fix the Windows build.
- jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub):
- jit/JITThunks.h:
- 1:54 PM Changeset in webkit [156493] by
-
- 2 edits in trunk/Tools
build-webkit --inspector-frontend should copy WebInspectorUI files
https://bugs.webkit.org/show_bug.cgi?id=117851
Patch by Brian J. Burg <Brian Burg> on 2013-09-26
Reviewed by Joseph Pecoraro.
Change the --inspector-frontend build option to additionally build/copy
WebInspectorUI by setting it as the only project that needs to be built.
- Scripts/build-webkit:
- 1:44 PM Changeset in webkit [156492] by
-
- 15 edits in trunk/Source
Change a couple of HashMap value types from OwnPtr to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=121973
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- API/JSClassRef.cpp:
(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::contextData):
- API/JSClassRef.h:
- bytecode/SamplingTool.h:
- ftl/FTLAbstractHeap.h:
- parser/Parser.cpp:
(JSC::::parseFunctionInfo):
- parser/SourceProviderCache.cpp:
(JSC::SourceProviderCache::add):
- parser/SourceProviderCache.h:
- parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::create):
- profiler/ProfilerCompilation.cpp:
(JSC::Profiler::Compilation::executionCounterFor):
(JSC::Profiler::Compilation::toJS):
- profiler/ProfilerCompilation.h:
- runtime/JSGlobalObject.h:
Source/WTF:
- wtf/RefPtrHashMap.h:
Add a missing std::forward.
- wtf/StdLibExtras.h:
(std::make_unique):
Add more overloads.
- 1:32 PM Changeset in webkit [156491] by
-
- 4 edits2 copies in tags/Safari-538.1
Merged r156404. <rdar://problem/15081686>
- 1:27 PM Changeset in webkit [156490] by
-
- 29 edits7 copies4 deletes in trunk/Source/JavaScriptCore
Move DFG inline caching logic into jit/.
https://bugs.webkit.org/show_bug.cgi?id=121749.
Reviewed by Geoffrey Garen.
Relanding http://trac.webkit.org/changeset/156235 after rebasing to latest
revision and fixing build breakages on Windows.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlink):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
- bytecode/StructureStubInfo.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExitCompiler.h:
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- dfg/DFGOperations.h:
(JSC::DFG::operationNewTypedArrayWithSizeForType):
(JSC::DFG::operationNewTypedArrayWithOneArgumentForType):
- dfg/DFGRegisterSet.h: Removed.
- dfg/DFGRepatch.cpp: Removed.
- dfg/DFGRepatch.h: Removed.
- dfg/DFGScratchRegisterAllocator.h: Removed.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGThunks.cpp:
- dfg/DFGThunks.h:
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- ftl/FTLOSRExitCompiler.h:
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::writeBarrier):
- jit/JIT.cpp:
(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):
- jit/JITCall.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITOperationWrappers.h: Copied from Source/JavaScriptCore/jit/JITOperationWrappers.h.
- jit/JITOperations.cpp: Copied from Source/JavaScriptCore/jit/JITOperations.cpp.
(JSC::getHostCallReturnValueWithExecState):
- jit/JITOperations.h: Copied from Source/JavaScriptCore/jit/JITOperations.h.
- jit/RegisterSet.h: Copied from Source/JavaScriptCore/jit/RegisterSet.h.
- jit/Repatch.cpp: Copied from Source/JavaScriptCore/jit/Repatch.cpp.
(JSC::tryBuildGetByIDList):
- jit/Repatch.h: Copied from Source/JavaScriptCore/jit/Repatch.h.
- jit/ScratchRegisterAllocator.h: Copied from Source/JavaScriptCore/jit/ScratchRegisterAllocator.h.
- jit/ThunkGenerators.cpp:
(JSC::oldStyleGenerateSlowCaseFor):
(JSC::oldStyleLinkForGenerator):
(JSC::oldStyleLinkCallGenerator):
(JSC::oldStyleLinkConstructGenerator):
(JSC::oldStyleLinkClosureCallGenerator):
(JSC::oldStyleVirtualForGenerator):
(JSC::oldStyleVirtualCallGenerator):
(JSC::oldStyleVirtualConstructGenerator):
(JSC::emitPointerValidation):
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::slowPathFor):
(JSC::linkForThunkGenerator):
(JSC::linkCallThunkGenerator):
(JSC::linkConstructThunkGenerator):
(JSC::linkClosureCallThunkGenerator):
(JSC::virtualForThunkGenerator):
(JSC::virtualCallThunkGenerator):
(JSC::virtualConstructThunkGenerator):
- jit/ThunkGenerators.h:
- 12:48 PM Changeset in webkit [156489] by
-
- 7 edits2 deletes in trunk/Source
Remove PassWeak.h
https://bugs.webkit.org/show_bug.cgi?id=121971
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/PassWeak.h: Removed.
- heap/WeakInlines.h:
Source/WebCore:
- ForwardingHeaders/heap/PassWeak.h: Removed.
- 12:37 PM Changeset in webkit [156488] by
-
- 8 edits6 adds in trunk/Source/WebCore
[MediaStream API] implement VideoStreamTrack and AudioStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=121950
Reviewed by Dean Jackson.
No new tests, blocked by https://bugs.webkit.org/show_bug.cgi?id=121967
- CMakeLists.txt: Add new files.
- DerivedSources.make: Ditto.
- GNUmakefile.list.am: Ditto.
- Modules/mediastream/AudioStreamTrack.cpp: Added.
- Modules/mediastream/AudioStreamTrack.h: Added.
- Modules/mediastream/AudioStreamTrack.idl: Added.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream): Create an AudioStreamTrack or a VideoStreamTrack.
(WebCore::MediaStream::addRemoteSource): Ditto.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create): Removed.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/VideoStreamTrack.cpp: Added.
- Modules/mediastream/VideoStreamTrack.h: Added.
- Modules/mediastream/VideoStreamTrack.idl: Added.
- WebCore.xcodeproj/project.pbxproj: Add new files.
- 12:23 PM Changeset in webkit [156487] by
-
- 19 edits in trunk/Source
Stop using PassWeak
https://bugs.webkit.org/show_bug.cgi?id=121968
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- heap/Weak.h:
Remove all knowledge of PassWeak.
(JSC::Weak::Weak):
These constructors don't need to be explicit.
- heap/WeakInlines.h:
(JSC::weakAdd):
Change Value to be an rvalue reference and use std::forward.
- jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub):
Remove PassWeak.
- runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
Use Weak instead of PassWeak.
- runtime/SimpleTypedArrayController.cpp:
Change add and set to take Weak by value and std::move into place.
- runtime/WeakGCMap.h:
(JSC::WeakGCMap::get):
(JSC::WeakGCMap::set):
(JSC::WeakGCMap::add):
Source/WebCore:
Update for JavaScriptCore changes.
- bindings/js/JSDOMBinding.h:
(WebCore::setInlineCachedWrapper):
(WebCore::cacheWrapper):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::setWrapper):
(WebCore::JSEventListener::jsFunction):
- bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::JSMutationCallback):
- bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
- bindings/js/ScriptWrappableInlines.h:
(WebCore::ScriptWrappable::setWrapper):
- bindings/js/WebCoreTypedArrayController.cpp:
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
- bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::addRuntimeObject):
Source/WebKit2:
Update for JavaScriptCore changes.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::getOrCreateJSObject):
- 12:14 PM Changeset in webkit [156486] by
-
- 2 edits in trunk/LayoutTests
fast/css/font-face-data-uri.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82744
Reviewed by Dan Bernstein.
- fast/css/font-face-data-uri.html: There is no need to keep retrying, we can just
wait for onload - as long as the font load starts early enough.
- 12:09 PM Changeset in webkit [156485] by
-
- 28 edits in trunk/Source
Pass a JSC::VM& to JS bindings object creation functions, rather than a JSC::ExecState*
https://bugs.webkit.org/show_bug.cgi?id=121934
Reviewed by Geoffrey Garen.
../WebCore:
Reduce unnecessary loads by passing the JSC::VM to object creation/access functions
that don't need the ExecState.
- WebCore.exp.in:
- bindings/js/JSDOMBinding.h:
(WebCore::getDOMStructure):
(WebCore::deprecatedGetDOMStructure):
(WebCore::getDOMPrototype):
(WebCore::setInlineCachedWrapper):
(WebCore::createWrapper):
- bindings/js/JSDOMGlobalObject.h:
(WebCore::getDOMConstructor):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::image):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
- bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::finishCreation):
- bindings/js/JSImageConstructor.h:
(WebCore::JSImageConstructor::create):
- bindings/js/ScriptWrappable.h:
- bindings/js/ScriptWrappableInlines.h:
(WebCore::ScriptWrappable::setWrapper):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorHelperMethods):
- bridge/c/CRuntimeObject.cpp:
(JSC::Bindings::CRuntimeObject::CRuntimeObject):
(JSC::Bindings::CRuntimeObject::finishCreation):
- bridge/c/CRuntimeObject.h:
(JSC::Bindings::CRuntimeObject::create):
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::newRuntimeObject):
- bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::newRuntimeObject):
- bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::create):
- bridge/objc/ObjCRuntimeObject.mm:
(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
(JSC::Bindings::ObjCRuntimeObject::finishCreation):
- bridge/objc/objc_instance.mm:
(ObjcInstance::newRuntimeObject):
- bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::createPrototype):
- bridge/runtime_array.h:
(JSC::RuntimeArray::createPrototype):
- bridge/runtime_method.h:
(JSC::RuntimeMethod::createPrototype):
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::finishCreation):
- bridge/runtime_object.h:
(JSC::Bindings::RuntimeObject::create):
(JSC::Bindings::RuntimeObject::createPrototype):
../WebKit/mac:
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::newRuntimeObject):
- Plugins/Hosted/ProxyRuntimeObject.h:
(WebKit::ProxyRuntimeObject::create):
- Plugins/Hosted/ProxyRuntimeObject.mm:
(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
(WebKit::ProxyRuntimeObject::finishCreation):
- 11:59 AM Changeset in webkit [156484] by
-
- 1 copy in tags/Safari-538.1
New Tag.
- 11:40 AM Changeset in webkit [156483] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Activity viewer not properly reset when reloading
https://bugs.webkit.org/show_bug.cgi?id=121958
Reviewed by Darin Adler.
Reset the resources count and accumulated size when we detect the main frame
has changed, which will work with documents where there are no resources besides
frames in which case WebInspector.Frame.Event.AllResourcesRemoved was not fired
and our counts wouldn't be reset correctly.
- UserInterface/DashboardManager.js:
(WebInspector.DashboardManager):
(WebInspector.DashboardManager.prototype._mainResourceDidChange):
- 11:31 AM Changeset in webkit [156482] by
-
- 65 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r156474.
http://trac.webkit.org/changeset/156474
https://bugs.webkit.org/show_bug.cgi?id=121966
Broke the builds. (Requested by xenon on #webkit).
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::registerName):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::createActivation):
(JSC::CodeBlock::nameForRegister):
- bytecode/CodeBlock.h:
(JSC::unmodifiedArgumentsRegister):
(JSC::CodeBlock::isKnownNotImmediate):
(JSC::CodeBlock::setThisRegister):
(JSC::CodeBlock::thisRegister):
(JSC::CodeBlock::setArgumentsRegister):
(JSC::CodeBlock::argumentsRegister):
(JSC::CodeBlock::uncheckedArgumentsRegister):
(JSC::CodeBlock::setActivationRegister):
(JSC::CodeBlock::activationRegister):
(JSC::CodeBlock::uncheckedActivationRegister):
(JSC::CodeBlock::usesArguments):
(JSC::CodeBlock::isCaptured):
- bytecode/Instruction.h:
- bytecode/LazyOperandValueProfile.h:
(JSC::LazyOperandValueProfileKey::LazyOperandValueProfileKey):
(JSC::LazyOperandValueProfileKey::operator!):
(JSC::LazyOperandValueProfileKey::hash):
(JSC::LazyOperandValueProfileKey::operand):
(JSC::LazyOperandValueProfileKey::isHashTableDeletedValue):
(JSC::LazyOperandValueProfile::LazyOperandValueProfile):
- bytecode/MethodOfGettingAValueProfile.cpp:
(JSC::MethodOfGettingAValueProfile::fromLazyOperand):
(JSC::MethodOfGettingAValueProfile::getSpecFailBucket):
- bytecode/Operands.h:
(JSC::localToOperand):
(JSC::operandIsLocal):
(JSC::operandToLocal):
(JSC::operandIsArgument):
(JSC::operandToArgument):
(JSC::argumentToOperand):
(JSC::Operands::operand):
(JSC::Operands::hasOperand):
(JSC::Operands::setOperand):
(JSC::Operands::operandForIndex):
(JSC::Operands::setOperandFirstTime):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::setThisRegister):
(JSC::UnlinkedCodeBlock::setActivationRegister):
(JSC::UnlinkedCodeBlock::setArgumentsRegister):
(JSC::UnlinkedCodeBlock::usesArguments):
(JSC::UnlinkedCodeBlock::argumentsRegister):
(JSC::UnlinkedCodeBlock::usesGlobalObject):
(JSC::UnlinkedCodeBlock::setGlobalObjectRegister):
(JSC::UnlinkedCodeBlock::globalObjectRegister):
(JSC::UnlinkedCodeBlock::thisRegister):
(JSC::UnlinkedCodeBlock::activationRegister):
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dumpInContext):
- bytecode/VirtualRegister.h:
(WTF::printInternal):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::newRegister):
(JSC::BytecodeGenerator::emitLoadGlobalObject):
(JSC::BytecodeGenerator::emitGetArgumentsLength):
(JSC::BytecodeGenerator::emitGetArgumentByVal):
(JSC::BytecodeGenerator::createArgumentsIfNecessary):
(JSC::BytecodeGenerator::emitReturn):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::registerFor):
- bytecompiler/RegisterID.h:
(JSC::RegisterID::RegisterID):
(JSC::RegisterID::setIndex):
(JSC::RegisterID::index):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::thisObject):
- dfg/DFGAbstractHeap.h:
(JSC::DFG::AbstractHeap::Payload::Payload):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
(JSC::DFG::::clobberCapturedVars):
- dfg/DFGArgumentPosition.h:
(JSC::DFG::ArgumentPosition::dump):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::findArgumentPosition):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::getToInt32):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitFunctionChecks):
(JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleTypedArrayConstructor):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCFGSimplificationPhase.cpp:
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetArgument):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::isCapturedAtOrAfter):
- dfg/DFGFlushLivenessAnalysisPhase.cpp:
(JSC::DFG::FlushLivenessAnalysisPhase::setForNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::argumentsRegisterFor):
(JSC::DFG::Graph::uncheckedArgumentsRegisterFor):
(JSC::DFG::Graph::uncheckedActivationRegisterFor):
(JSC::DFG::Graph::valueProfileFor):
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::convertToGetLocalUnlinked):
(JSC::DFG::Node::hasVirtualRegister):
(JSC::DFG::Node::virtualRegister):
(JSC::DFG::Node::setVirtualRegister):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::tryAllocate):
(JSC::DFG::RegisterBank::allocateSpecific):
(JSC::DFG::RegisterBank::retain):
(JSC::DFG::RegisterBank::isInUse):
(JSC::DFG::RegisterBank::dump):
(JSC::DFG::RegisterBank::releaseAtIndex):
(JSC::DFG::RegisterBank::allocateInternal):
(JSC::DFG::RegisterBank::MapEntry::MapEntry):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::allocate):
(JSC::DFG::ScoreBoard::use):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::allocate):
(JSC::DFG::SpeculativeJIT::fprAllocate):
(JSC::DFG::SpeculativeJIT::silentSpillAllRegistersImpl):
(JSC::DFG::SpeculativeJIT::flushRegisters):
(JSC::DFG::SpeculativeJIT::isFlushed):
(JSC::DFG::SpeculativeJIT::argumentSlot):
(JSC::DFG::SpeculativeJIT::argumentTagSlot):
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
(JSC::DFG::SpeculativeJIT::valueSourceForOperand):
(JSC::DFG::SpeculativeJIT::setNodeForOperand):
(JSC::DFG::SpeculativeJIT::valueSourceReferenceForOperand):
(JSC::DFG::SpeculativeJIT::recordSetLocal):
(JSC::DFG::SpeculativeJIT::generationInfoFromVirtualRegister):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::validateCPS):
(JSC::DFG::Validate::checkOperand):
(JSC::DFG::Validate::reportValidationContext):
- dfg/DFGValueRecoveryOverride.h:
(JSC::DFG::ValueRecoveryOverride::ValueRecoveryOverride):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::operand):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::flushFormat):
- dfg/DFGVariableEvent.h:
(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::setLocal):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- ftl/FTLExitArgumentForOperand.h:
(JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::operand):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileGetArgument):
(JSC::FTL::LowerDFGToLLVM::compileExtractOSREntryLocal):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):
(JSC::FTL::LowerDFGToLLVM::addressFor):
(JSC::FTL::LowerDFGToLLVM::payloadFor):
(JSC::FTL::LowerDFGToLLVM::tagFor):
- ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExit::convertToForward):
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::unwindCallFrame):
(JSC::Interpreter::unwind):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::addressFor):
(JSC::AssemblyHelpers::tagFor):
(JSC::AssemblyHelpers::payloadFor):
(JSC::AssemblyHelpers::argumentsRegisterFor):
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITInlines.h:
(JSC::JIT::emitGetVirtualRegister):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_enter):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- profiler/ProfilerBytecodeSequence.cpp:
(JSC::Profiler::BytecodeSequence::BytecodeSequence):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/JSActivation.cpp:
(JSC::JSActivation::argumentsGetter):
- 11:29 AM Changeset in webkit [156481] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Keep DOM tree expanded on page reload
https://bugs.webkit.org/show_bug.cgi?id=121665
Reviewed by Darin Adler.
Allow the node that was selected before reloading the page to be selected
at the page is reloaded. Credit goes to Joseph Pecoraro for the fix.
- UserInterface/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype._rootDOMNodeAvailable.selectNode):
- 11:13 AM Changeset in webkit [156480] by
-
- 3 edits in trunk/Source/JavaScriptCore
Attempt to fix MSVC build
- 11:13 AM Changeset in webkit [156479] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Crash at at com.apple.WebKit2: WebKit::VoidCallback::invalidate + 46
https://bugs.webkit.org/show_bug.cgi?id=121910
Reviewed by Darin Adler.
Store a copy of the VoidCallback passed to WKPage, and invalidate the callback
during dealloc. The VoidCallback class assumes that it will only ever be
invalidated or invoked once, so change the ASSERTs into an early return.
- UIProcess/GenericCallback.h:
(WebKit::VoidCallback::performCallback): Exit early if previously invalidated.
(WebKit::VoidCallback::invalidate): Ditto.
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController dealloc]): Invalidate the repaint callback if present.
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Ditto & create a new callback.
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]): Clear the callback.
- 11:13 AM Changeset in webkit [156478] by
-
- 20 edits1 delete in trunk
Unreviewed, rolling out r156451.
http://trac.webkit.org/changeset/156451
https://bugs.webkit.org/show_bug.cgi?id=121965
Broke two fast/multicol tests. (Requested by kling on
#webkit).
Source/WebCore:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::propagateStyleToAnonymousChildren):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::updateRegionForRenderLayer):
(WebCore::RenderFlowThread::updateLayerToRegionMappings):
- rendering/RenderFlowThread.h:
- rendering/RenderGeometryMap.cpp:
- rendering/RenderGeometryMap.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::canBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
- rendering/RenderLayerCompositor.h:
- rendering/RenderMultiColumnSet.cpp:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRequiresLayerForCompositing):
- rendering/RenderRegion.h:
- rendering/RenderRegionSet.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
LayoutTests:
- fast/regions/layers/accelerated-compositing/crash-transform-inside-region-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/crash-transform-inside-region.html: Removed.
- fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child.html: Removed.
- fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another.html: Removed.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video.html: Removed.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding.html: Removed.
- fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread.html: Removed.
- fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region.html: Removed.
- fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer.html: Removed.
- fast/regions/layers/accelerated-compositing/z-index-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/z-index-update-expected.html: Removed.
- fast/regions/layers/accelerated-compositing/z-index-update.html: Removed.
- fast/regions/layers/accelerated-compositing/z-index.html: Removed.
- 11:09 AM Changeset in webkit [156477] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] JSValue* exception is unused since r70703 in JITStackFrame.
https://bugs.webkit.org/show_bug.cgi?id=121962
This is a cosmetic change, but it could avoid people reading sh4 part to
waste time to understand why there is a JSValue* here.
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-26
Reviewed by Darin Adler.
- jit/JITStubs.h:
- 11:00 AM Changeset in webkit [156476] by
-
- 2 edits in trunk/Source/JavaScriptCore
WeakGCMap should not inherit from HashMap
https://bugs.webkit.org/show_bug.cgi?id=121964
Reviewed by Geoffrey Garen.
Add the HashMap as a member variable instead and implement the missing member functions.
- runtime/WeakGCMap.h:
- 10:57 AM Changeset in webkit [156475] by
-
- 3 edits in trunk/Tools
XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
https://bugs.webkit.org/show_bug.cgi?id=121951
Reviewed by Carlos Garcia Campos.
Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
500 layout tests that trigger accelerated compositing to be used.
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._start):
- Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_next_free_display):
(XvfbDriverTest.test_start_next_worker):
- 10:50 AM Changeset in webkit [156474] by
-
- 65 edits in trunk/Source/JavaScriptCore
VirtualRegister should be a class
https://bugs.webkit.org/show_bug.cgi?id=121732
Reviewed by Geoffrey Garen.
This is a refactoring change. Changed VirtualRegister from an enum to a class.
Moved Operands::operandIsArgument(), operandToArgument(), argumentToOperand()
and the similar functions for locals to VirtualRegister class.
This is in preparation for changing the offset for the first local register from
0 to -1. This is needed since most native calling conventions have the architected
frame pointer (e.g. %rbp for X86) point at the slot that stores the previous frame
pointer. Local values start below that address.
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
- bytecode/Instruction.h:
- bytecode/LazyOperandValueProfile.h:
- bytecode/MethodOfGettingAValueProfile.cpp:
- bytecode/Operands.h:
- bytecode/UnlinkedCodeBlock.cpp:
- bytecode/UnlinkedCodeBlock.h:
- bytecode/ValueRecovery.h:
- bytecode/VirtualRegister.h:
- bytecompiler/BytecodeGenerator.cpp:
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/RegisterID.h:
- debugger/DebuggerCallFrame.cpp:
- dfg/DFGAbstractHeap.h:
- dfg/DFGAbstractInterpreterInlines.h:
- dfg/DFGArgumentPosition.h:
- dfg/DFGArgumentsSimplificationPhase.cpp:
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGCFGSimplificationPhase.cpp:
- dfg/DFGCPSRethreadingPhase.cpp:
- dfg/DFGCapabilities.cpp:
- dfg/DFGConstantFoldingPhase.cpp:
- dfg/DFGFlushLivenessAnalysisPhase.cpp:
- dfg/DFGGraph.cpp:
- dfg/DFGGraph.h:
- dfg/DFGJITCode.cpp:
- dfg/DFGNode.h:
- dfg/DFGOSREntry.cpp:
- dfg/DFGOSREntrypointCreationPhase.cpp:
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompiler32_64.cpp:
- dfg/DFGOSRExitCompiler64.cpp:
- dfg/DFGRegisterBank.h:
- dfg/DFGScoreBoard.h:
- dfg/DFGSpeculativeJIT.cpp:
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT64.cpp:
- dfg/DFGValidate.cpp:
- dfg/DFGValueRecoveryOverride.h:
- dfg/DFGVariableAccessData.h:
- dfg/DFGVariableEvent.h:
- dfg/DFGVariableEventStream.cpp:
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
- ftl/FTLExitArgumentForOperand.h:
- ftl/FTLLink.cpp:
- ftl/FTLLowerDFGToLLVM.cpp:
- ftl/FTLOSREntry.cpp:
- ftl/FTLOSRExit.cpp:
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompiler.cpp:
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
- jit/AssemblyHelpers.h:
- jit/JIT.h:
- jit/JITCall.cpp:
- jit/JITInlines.h:
- jit/JITOpcodes.cpp:
- jit/JITOpcodes32_64.cpp:
- jit/JITStubs.cpp:
- llint/LLIntSlowPaths.cpp:
- profiler/ProfilerBytecodeSequence.cpp:
- runtime/CommonSlowPaths.cpp:
- runtime/JSActivation.cpp:
- 10:43 AM Changeset in webkit [156473] by
-
- 34 edits2 adds3 deletes in trunk/Source/WebCore
[MediaStream] Cleanup platform interface
https://bugs.webkit.org/show_bug.cgi?id=121935
Reviewed by Jer Noble.
No new tests, tests will be updated in the next patch.
- CMakeLists.txt: Remove MediaStreamComponent.cpp.
- GNUmakefile.list.am: Remove MediaStreamComponent.h|cpp and MediaStreamSourcesQueryClient.h.
Add MediaStreamConstraintsValidationClient.h and MediaStreamCreationClient.h.
- Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack): Duplicate MediaStreamSource when necessary to work around bug 121954.
(WebCore::createFromSourceVectors): MediaStreamCenter::instance -> MediaStream::sharedStreamCenter.
(WebCore::MediaStream::MediaStream): *Components -> *Streams.
(WebCore::MediaStream::setEnded): New.
(WebCore::MediaStream::stop): MediaStreamCenter::instance -> MediaStream::sharedStreamCenter.
(WebCore::MediaStream::addTrack): Append the track parameter rather than duplicating it, as per spec.
(WebCore::MediaStream::removeTrack): *Components -> *Streams.
(WebCore::MediaStream::trackDidEnd): Renamed from trackEnded.
(WebCore::MediaStream::streamDidEnd): Renamed from streamEnded.
(WebCore::MediaStream::addRemoteSource): Renamed from addRemoteTrack. *Components -> *Streams.
(WebCore::MediaStream::removeRemoteSource): Renamed from removeRemoteTrack. *Components -> *Streams.
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create): *Component -> *Stream.
(WebCore::MediaStreamTrack::MediaStreamTrack): Don't assume source is valid.
(WebCore::MediaStreamTrack::~MediaStreamTrack): Ditto.
(WebCore::MediaStreamTrack::kind): Ditto. AtomicString -> const AtomicString&.
(WebCore::MediaStreamTrack::setSource): Moved from .h file.
(WebCore::MediaStreamTrack::id): Don't assume source is valid. Create ID when the source doesn't have one.
(WebCore::MediaStreamTrack::label): Don't assume source is valid.
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled): *Component -> *Stream. MediaStreamCenter::instance -> MediaStreamCenter::shared.
(WebCore::MediaStreamTrack::readyState): "muted" is not a readyState, but "new" is.
(WebCore::MediaStreamTrack::getSources): MediaStreamCenter::instance -> MediaStreamCenter::shared.
(WebCore::MediaStreamTrack::ended): *Component -> *Stream.
(WebCore::MediaStreamTrack::sourceChangedState): Dispatch "started" and "unmuted" events.
(WebCore::MediaStreamTrack::trackDidEnd): Renamed from didEndTrack. m_component -> m_source.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/RTCDTMFSender.cpp:
(WebCore::RTCDTMFSender::create): track->component() -> track->source();
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::didRemoveRemoteStream): Ditto.
- Modules/mediastream/RTCStatsRequestImpl.cpp:
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl): Ditto.
(WebCore::RTCStatsRequestImpl::component): Removed, it was unused.
- Modules/mediastream/RTCStatsRequestImpl.h:
- Modules/mediastream/UserMediaClient.h:
- Modules/mediastream/UserMediaController.h:
(WebCore::UserMediaController::requestPermission): Renamed from requestUserMedia, get rid of source
vector parameters.
(WebCore::UserMediaController::cancelRequest): Renamed from cancelUserMediaRequest.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::parseOptions): MediaConstraintsImpl -> MediaConstraints.
(WebCore::UserMediaRequest::create): Ditto.
(WebCore::UserMediaRequest::UserMediaRequest): Ditto.
(WebCore::UserMediaRequest::securityOrigin): New.
(WebCore::UserMediaRequest::start): Request constraint validation.
(WebCore::UserMediaRequest::constraintsValidated): New. Callback from media engine when constraints
can be supported.
(WebCore::UserMediaRequest::requestPermission): New. Ask user media client for permission to access media.
(WebCore::UserMediaRequest::userMediaAccessGranted): New. Access has been granted.
(WebCore::UserMediaRequest::createMediaStream): New. Allowed to access media, ask media engine
to create stream sources.
(WebCore::UserMediaRequest::userMediaAccessDenied): New. User media client has denied access request.
(WebCore::UserMediaRequest::constraintsInvalid): New. Media engine can not support constraints.
(WebCore::UserMediaRequest::didCreateStream): New. Media engine has created stream sources.
(WebCore::UserMediaRequest::callSuccessHandler): New. Create stream from sources and call success handler.
(WebCore::UserMediaRequest::failedToCreateStreamWithConstraintsError): Renamed from constraintFailure.
(WebCore::UserMediaRequest::failedToCreateStreamWithPermissionError): Renamed from permissionFailure.
(WebCore::UserMediaRequest::callErrorHandler):
(WebCore::UserMediaRequest::contextDestroyed): cancelUserMediaRequest -> cancelRequest.
- Modules/mediastream/UserMediaRequest.h:
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource): localAudio->component()->source() -> localAudio->source().
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): MediaStreamSource::TypeAudio ->
MediaStreamSource::Audio, MediaStreamSource::ReadyStateLive -> MediaStreamSource::Live.
MediaStreamCenter::instance -> MediaStreamCenter::shared.
- WebCore.exp.in: Export new symbols.
- WebCore.xcodeproj/project.pbxproj: Add new files and remove deleted files.
- dom/EventNames.h: Define "started" event.
- platform/mediastream/MediaStreamCenter.cpp:
(WebCore::mediaStreamCenterOverride): Make it possible to override the shared stream center. Will
be used for testing in a later patch.
(WebCore::MediaStreamCenter::shared): Renamed from instance. Return current stream center.
(WebCore::MediaStreamCenter::setSharedStreamCenter): Override current stream center.
(WebCore::MediaStreamCenter::endLocalMediaStream): Never call the descriptor client, always call
the descriptor and let it deal with the client.
- platform/mediastream/MediaStreamCenter.h:
- platform/mediastream/MediaStreamComponent.cpp: Removed.
- platform/mediastream/MediaStreamComponent.h: Removed.
- platform/mediastream/MediaStreamConstraintsValidationClient.h: Added.
- platform/mediastream/MediaStreamCreationClient.h: Added.
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::addSource): *Component -> *Source.
(WebCore::MediaStreamDescriptor::removeSource): Ditto.
(WebCore::MediaStreamDescriptor::addRemoteSource): Ditto.
(WebCore::MediaStreamDescriptor::removeRemoteSource): Ditto.
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Ditto.
(WebCore::MediaStreamDescriptor::setEnded): Ditto. Set source readyStates to Ended.
- platform/mediastream/MediaStreamDescriptor.h:
- platform/mediastream/MediaStreamSource.cpp:
(WebCore::MediaStreamSource::MediaStreamSource): Initialize new member variables.
(WebCore::MediaStreamSource::setReadyState): Early return when the state hasn't changed.
(WebCore::MediaStreamSource::setStream): New.
(WebCore::MediaStreamSource::setMuted): New.
- platform/mediastream/MediaStreamSource.h:
- platform/mediastream/MediaStreamSourcesQueryClient.h: Removed.
- platform/mediastream/RTCPeerConnectionHandler.h:
- platform/mediastream/RTCStatsRequest.h:
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp: Update for new MediaStreamCenter API.
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp: Ditto.
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
- platform/mediastream/mac/MediaStreamCenterMac.cpp: Ditto.
- platform/mediastream/mac/MediaStreamCenterMac.h:
- 10:34 AM Changeset in webkit [156472] by
-
- 25 edits in trunk
Tiled drawing should not imply threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=121874
<rdar://problem/15071494>
Reviewed by Sam Weinig.
- Shared/DrawingAreaInfo.h:
We can have DrawingAreaTypeTiledCoreAnimation without threaded scrolling.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetThreadedScrollingEnabled):
(WKPreferencesGetThreadedScrollingEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
Add a preference for threaded scrolling.
- UIProcess/API/mac/WKView.mm:
(-[WKView WebKit::]):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h:
Make it so we can use TiledCoreAnimationDrawingArea without ENABLE(THREADED_SCROLLING).
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUseTiledBackingForFrame):
- WebProcess/WebCoreSupport/WebChromeClient.h:
Override shouldUseTiledBackingForFrame; ask the drawing area if we want a tiled backing for the given frame.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
- WebProcess/WebPage/WebPage.h:
Move attaching and detaching the scrolling tree into WebPage.
Store whether or not this page is going to use threaded scrolling once, as this
cannot change through the life of a page.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
Move attaching and detaching the scrolling tree into WebPage.
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
Only do scrolling coordinator work if we have a scrolling coordinator.
(WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrame):
TiledCoreAnimationDrawingArea always wants a tiled backing for the main frame.
No new tests; a near-future patch is going to put the majority of layout
tests into the tiled-drawing-without-threaded-scrolling mode.
- page/ChromeClient.h:
(WebCore::ChromeClient::shouldUseTiledBackingForFrame):
Add a ChromeClient callback to determine whether a given frame wants a TiledBacking for its contents.
- page/FrameView.h:
- WebCore.exp.in:
Make isMainFrameView public and export it for use in WebKit2.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
Make use of shouldUseTiledBackingForFrame instead of predicating the
main frame using a tile cache on whether we have a scrolling coordinator.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::mainFrameBackingIsTiled): Added.
(WebCore::RenderLayerCompositor::shouldCompositeOverflowControls):
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
All of these checks for existence of a scrollingCoordinator should actually
key off whether we're using tiled drawing at the root; they have nothing
to do with threaded scrolling.
- rendering/RenderLayerCompositor.h:
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
The existing tiled-drawing layout tests require threaded scrolling to be enabled.
- 10:33 AM Changeset in webkit [156471] by
-
- 2 edits in trunk/Source/WebCore
Mark IDBDatabase "FINAL" now that http://webkit.org/b/121747 is fixed.
Rubberstamped by Andreas Kling
- Modules/indexeddb/IDBDatabase.h: Mark this class FINAL.
- 10:24 AM Changeset in webkit [156470] by
-
- 2 edits in trunk/LayoutTests
One more IndexedDB rebaseline.
- js/dom/global-constructors-attributes-expected.txt:
- 10:19 AM Changeset in webkit [156469] by
-
- 5 edits in trunk/Source/JavaScriptCore
Weak should have a move constructor and move assignment operator
https://bugs.webkit.org/show_bug.cgi?id=121963
Reviewed by Oliver Hunt.
This is the first step towards getting rid of PassWeak.
- API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
- heap/Weak.h:
- heap/WeakInlines.h:
(JSC::::Weak):
(JSC::::leakImpl):
- runtime/SimpleTypedArrayController.cpp:
(JSC::SimpleTypedArrayController::toJS):
- 10:16 AM Changeset in webkit [156468] by
-
- 16 edits in trunk
op_to_this shouldn't use value profiling
https://bugs.webkit.org/show_bug.cgi?id=121920
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Currently it's the only opcode that uses m_singletonValue, which is unnecessary. Our current plan is
to remove m_singletonValue so that GenGC can have a simpler story for handling CodeBlocks/FunctionExecutables
during nursery collections.
This patch adds an inline cache for the Structure of to_this so it no longer depends on the ValueProfile's
m_singletonValue. Since nobody uses m_singletonValue now, this patch also removes m_singletonValue from
ValueProfile.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllPredictions):
(JSC::CodeBlock::shouldOptimizeNow):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllPredictions):
- bytecode/LazyOperandValueProfile.cpp:
(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
- bytecode/LazyOperandValueProfile.h:
- bytecode/ValueProfile.h:
(JSC::ValueProfileBase::ValueProfileBase):
(JSC::ValueProfileBase::briefDescription):
(JSC::ValueProfileBase::dump):
(JSC::ValueProfileBase::computeUpdatedPrediction):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emitSlow_op_to_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emitSlow_op_to_this):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
LayoutTests:
Updated a couple tests that waited for two DFG compiles, but with this patch we
don't do two compiles any more, so we don't want to wait forever.
- js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-other.js:
- js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-string.js:
- 10:06 AM Changeset in webkit [156467] by
-
- 3 edits in trunk/LayoutTests
Rebaseline some tests after IndexedDB was enabled.
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- js/dom/global-constructors-attributes-shared-worker-expected.txt:
- 9:57 AM Changeset in webkit [156466] by
-
- 4 edits8 adds in trunk
Inset box-shadows fail to round around corners when border-radius is set in vh/vw units.
https://bugs.webkit.org/show_bug.cgi?id=119187
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-26
Reviewed by Darin Adler.
Source/WebCore:
Border-radius properties were not applied incase its values
were given in vh, vw, vmax, vmin units.
Tests: fast/css/border-radius-inset-box-shadow-viewportlength.html
fast/css/border-radius-viewport-height.html
fast/css/border-radius-viewport-vmax.html
fast/css/border-radius-viewport-vmin.html
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
- css/StyleResolver.h:
Calculating the border-radius values which has been specified
in viewport units.The vh/vw units are calcultated as percent of
viewport height and viewport width respectively. 1vmax: 1vw or 1vh,
whatever is largest.1vmin: 1vw or 1vh, whatever is smallest.
LayoutTests:
- fast/css/border-radius-inset-box-shadow-viewportlength-expected-mismatch.html: Added.
- fast/css/border-radius-inset-box-shadow-viewportlength.html: Added.
- fast/css/border-radius-viewport-height-expected-mismatch.html: Added.
- fast/css/border-radius-viewport-height.html: Added.
- fast/css/border-radius-viewport-vmax-expected-mismatch.html: Added.
- fast/css/border-radius-viewport-vmax.html: Added.
- fast/css/border-radius-viewport-vmin-expected-mismatch.html: Added.
- fast/css/border-radius-viewport-vmin.html: Added.
Added new tests for verifying that box-shadow and border-radius properties
are applied when its values are viewport units.
- 9:53 AM Changeset in webkit [156465] by
-
- 2 edits in trunk/Source/WebCore
Fix ordered comparison warnings in BitmapImage::drawPattern
https://bugs.webkit.org/show_bug.cgi?id=121945
Reviewed by Darin Adler.
No new tests, no behavior change.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern):
- 9:52 AM Changeset in webkit [156464] by
-
- 19 edits12 adds in trunk
Implement prefixed-destructuring assignment
https://bugs.webkit.org/show_bug.cgi?id=121930
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
This is mostly simple - the semantics of deconstruction are already
present in the language, so most of the complexity (if you call it
that) is addition of new AST nodes, and parsing the syntax.
In order to get correct semantics for the parameter lists, FunctionParameters
now needs to store refcounted references to the parameter patterns.
There's also a little work to ensure that variable creation and assignment
occurs in the correct order while the BytecodeGenerator is being constructed.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::paramString):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitExpressionInfo):
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::DeconstructingAssignmentNode::emitBytecode):
(JSC::DeconstructionPatternNode::~DeconstructionPatternNode):
(JSC::ArrayPatternNode::emitBytecode):
(JSC::ArrayPatternNode::emitDirectBinding):
(JSC::ArrayPatternNode::toString):
(JSC::ArrayPatternNode::collectBoundIdentifiers):
(JSC::ObjectPatternNode::toString):
(JSC::ObjectPatternNode::emitBytecode):
(JSC::ObjectPatternNode::collectBoundIdentifiers):
(JSC::BindingNode::emitBytecode):
(JSC::BindingNode::toString):
(JSC::BindingNode::collectBoundIdentifiers):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::addVar):
(JSC::ASTBuilder::createDeconstructingAssignment):
(JSC::ASTBuilder::createArrayPattern):
(JSC::ASTBuilder::appendArrayPatternSkipEntry):
(JSC::ASTBuilder::appendArrayPatternEntry):
(JSC::ASTBuilder::createObjectPattern):
(JSC::ASTBuilder::appendObjectPatternEntry):
(JSC::ASTBuilder::createBindingLocation):
- parser/NodeConstructors.h:
(JSC::CommaNode::CommaNode):
(JSC::ParameterNode::ParameterNode):
(JSC::ForInNode::ForInNode):
(JSC::DeconstructionPatternNode::DeconstructionPatternNode):
(JSC::ArrayPatternNode::ArrayPatternNode):
(JSC::ArrayPatternNode::create):
(JSC::ObjectPatternNode::ObjectPatternNode):
(JSC::ObjectPatternNode::create):
(JSC::BindingNode::create):
(JSC::BindingNode::BindingNode):
(JSC::DeconstructingAssignmentNode::DeconstructingAssignmentNode):
- parser/Nodes.cpp:
(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):
- parser/Nodes.h:
(JSC::ExpressionNode::isDeconstructionNode):
(JSC::ArrayNode::elements):
(JSC::CommaNode::append):
(JSC::ParameterNode::pattern):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::patterns):
(JSC::DeconstructionPatternNode::isBindingNode):
(JSC::DeconstructionPatternNode::emitDirectBinding):
(JSC::ArrayPatternNode::appendIndex):
(JSC::ObjectPatternNode::appendEntry):
(JSC::ObjectPatternNode::Entry::Entry):
(JSC::BindingNode::boundProperty):
(JSC::BindingNode::isBindingNode):
(JSC::DeconstructingAssignmentNode::bindings):
(JSC::DeconstructingAssignmentNode::isLocation):
(JSC::DeconstructingAssignmentNode::isDeconstructionNode):
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::createBindingPattern):
(JSC::::parseDeconstructionPattern):
(JSC::::parseForStatement):
(JSC::::parseFormalParameters):
(JSC::::parseAssignmentExpression):
- parser/Parser.h:
(JSC::Scope::declareBoundParameter):
(JSC::Parser::declareBoundParameter):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::addVar):
(JSC::SyntaxChecker::operatorStackPop):
- runtime/JSONObject.cpp:
(JSC::escapeStringToBuilder):
- runtime/JSONObject.h:
LayoutTests:
Add enw tests, and update old ones.
- js/destructuring-assignment-expected.txt: Added.
- js/destructuring-assignment.html: Added.
- js/mozilla/strict/13.1-expected.txt:
- js/mozilla/strict/regress-532254-expected.txt:
- js/mozilla/strict/script-tests/13.1.js:
- js/regress/destructuring-arguments-expected.txt: Added.
- js/regress/destructuring-arguments-length-expected.txt: Added.
- js/regress/destructuring-arguments-length.html: Added.
- js/regress/destructuring-arguments.html: Added.
- js/regress/destructuring-swap-expected.txt: Added.
- js/regress/destructuring-swap.html: Added.
- js/regress/script-tests/destructuring-arguments-length.js: Added.
(foo):
- js/regress/script-tests/destructuring-arguments.js: Added.
(foo):
- js/regress/script-tests/destructuring-swap.js: Added.
(foo):
- js/script-tests/destructuring-assignment.js: Added.
(testDestructuring):
(testDeconstructArgs):
(testDeconstructArgLength):
- 9:46 AM Changeset in webkit [156463] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Unskip media/context-menu-actions.html which is passing now.
- platform/gtk-wk2/TestExpectations:
- 9:36 AM Changeset in webkit [156462] by
-
- 2 edits in trunk
[GTK] Tons of warnings caused by using FORTIFY_SOURCE in an unoptimized build
https://bugs.webkit.org/show_bug.cgi?id=121836
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-09-26
Reviewed by Martin Robinson.
- Source/autotools/SetupCompilerFlags.m4: only consider enabling FORTIFY_SOURCE if optimizations have
been enabled, since they are required for FORTIFY_SOURCE to work, and enabling FORTIFY_SOURCE unconditionally
generates warnings in newer glibc.
- 9:18 AM Changeset in webkit [156461] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r156457.
http://trac.webkit.org/changeset/156457
https://bugs.webkit.org/show_bug.cgi?id=121960
Broke webkitpy tests. (Requested by kling on #webkit).
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._start):
- 8:16 AM Changeset in webkit [156460] by
-
- 3 edits in trunk/LayoutTests
[GTK][WK2] Logging of accessibility events is not disabled between tests
https://bugs.webkit.org/show_bug.cgi?id=121957
Unreviewed gardening again. Now moving the expected flakiness to
the WebKit2GTK+ port, where it actually belongs to.
- platform/gtk-wk2/TestExpectations: Added expectations.
- platform/gtk/TestExpectations: Removed expectations.
- 8:02 AM Changeset in webkit [156459] by
-
- 2 edits in trunk/LayoutTests
[GTK] Logging of accessibility events is not disabled between tests
https://bugs.webkit.org/show_bug.cgi?id=121957
Unreviewed gardening. Marking accessibility tests as flaky while
an issue with the logging of accessibility events is investigated.
- platform/gtk/TestExpectations: Added flaky expectations.
- 7:24 AM Changeset in webkit [156458] by
-
- 8 edits14 deletes in trunk/Source/WebCore
Remove empty JSFooCustom.cpp files.
<https://webkit.org/b/121955>
Reviewed by Anders Carlsson.
There's no sense in slowing down build times with empty files that
still include a bunch of headers.
- bindings/js/JSAudioBufferCustom.cpp: Removed.
- bindings/js/JSCSSFontFaceRuleCustom.cpp: Removed.
- bindings/js/JSCSSImportRuleCustom.cpp: Removed.
- bindings/js/JSCSSMediaRuleCustom.cpp: Removed.
- bindings/js/JSCSSPageRuleCustom.cpp: Removed.
- bindings/js/JSCSSStyleRuleCustom.cpp: Removed.
- bindings/js/JSDOMImplementationCustom.cpp: Removed.
- bindings/js/JSDOMTokenListCustom.cpp: Removed.
- bindings/js/JSHTMLStyleElementCustom.cpp: Removed.
- bindings/js/JSMediaListCustom.cpp: Removed.
- bindings/js/JSProcessingInstructionCustom.cpp: Removed.
- bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp: Removed.
- bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp: Removed.
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: Removed.
- 6:30 AM Changeset in webkit [156457] by
-
- 2 edits in trunk/Tools
XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
https://bugs.webkit.org/show_bug.cgi?id=121951
Reviewed by Carlos Garcia Campos.
Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
500 layout tests that trigger accelerated compositing to be used.
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._start):
- 4:50 AM Changeset in webkit [156456] by
-
- 2 edits in trunk/Source/WTF
[Qt] Remove PassTraits.h from WTF.pro.
https://bugs.webkit.org/show_bug.cgi?id=121946
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-26
Reviewed by Andreas Kling.
- WTF.pro: Remove PassTraits.h as this file disappeared in r156298.
- 4:18 AM Changeset in webkit [156455] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r144831-r144846):Crashes in accessibility/aria-hidden-with-elements.html, accessibility/table-with-hidden-head-section.html
https://bugs.webkit.org/show_bug.cgi?id=112152
Unreviewed GTK gardening. Removed crash expectations now passing.
- platform/gtk/TestExpectations: Removed crashing expectations
- 4:13 AM Changeset in webkit [156454] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Remove failure expectation for test passing after r156209.
- platform/gtk-wk2/TestExpectations: Removed failure expectation.
- 1:58 AM Changeset in webkit [156453] by
-
- 3 edits in trunk/LayoutTests
[EFL] Remove inappropriate expectations for tests that are now passing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=121897
Unreviewed EFL gardening.
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-26
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 1:41 AM Changeset in webkit [156452] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Add baselines for editing/selection/paragraph-granularity.html
https://bugs.webkit.org/show_bug.cgi?id=121842
Unreviewed EFL gardening.
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-26
- platform/efl/TestExpectations: Removing the corresponding entry.
- platform/efl/editing/selection/paragraph-granularity-expected.txt: Added.
- 1:20 AM Changeset in webkit [156451] by
-
- 20 edits21 adds in trunk
[CSS Regions] The layers from the flow thread should be collected under the regions' layers.
https://bugs.webkit.org/show_bug.cgi?id=120457
Patch by Mihai Maerean <Mihai Maerean> on 2013-09-26
Reviewed by David Hyatt.
Source/WebCore:
This patch is based on the work of Alexandru Chiculita at https://bugs.webkit.org/attachment.cgi?id=203872&action=review
The composited layers inside the named flow threads are collected as part of the regions.
When a region displays a layer that needs accelerated compositing we activate the accelerated compositing for
that region too (inside RenderFlowThread::updateAllLayerToRegionMappings).
Tests: fast/regions/layers/accelerated-compositing/crash-transform-inside-region.html
fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child.html
fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another.html
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding.html
fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video.html
fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread.html
fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region.html
fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer.html
fast/regions/layers/accelerated-compositing/z-index.html: Added.
fast/regions/layers/accelerated-compositing/z-index-update.html: Added.
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout): When the layout of the flow thread is over (including the 2 phase layout),
we update all the mappings between the layers inside the flow thread and the regions where those layers will be
painted.
(WebCore::RenderFlowThread::hasCompositingRegionDescendant): Whether any of the regions has a compositing descendant.
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Triggers an update of the layers if a layer has moved
from a region to another since the last update.
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings):
- rendering/RenderFlowThread.h:
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::pushRenderFlowThread):
- rendering/RenderGeometryMap.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds): The RenderNamedFlowThread is ignored when we calculate the bounds
of the RenderView.
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds): Not if it's inside an out of flow Flow Thread.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Now adjusts the ancestorCompositingBounds for the FlowThread.
(WebCore::enclosingFlowThreadAncestor):
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Make sure that the region propagates
its borders, paddings, outlines or box-shadows to layers inside it.
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Now calls computeRegionCompositingRequirements.
(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Do not iterate the RenderFlowThread directly. We
are going to collect composited layers as part of regions.
(WebCore::RenderLayerCompositor::rebuildRegionCompositingLayerTree):
(WebCore::RenderLayerCompositor::canBeComposited): CSS Regions flow threads do not need to be composited as we
use composited RenderRegions to render the background of the RenderFlowThread.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): If it's a region.
- rendering/RenderLayerCompositor.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderElement.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren): Not for RenderFlowThreads, as they are updated
through the RenderView::styleDidChange function.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRequiresLayerForCompositing):
(WebCore::RenderRegion::adjustRegionBoundsFromFlowThreadPortionRect):
- rendering/RenderRegion.h:
(WebCore::toRenderRegion):
- rendering/RenderRegionSet.h:
(WebCore::RenderRegionSet::requiresLayer): Never.
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
LayoutTests:
- fast/regions/layers/accelerated-compositing/crash-transform-inside-region.html: Added.
- fast/regions/layers/accelerated-compositing/crash-transform-inside-region-expected.html: Added.
- fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child.html: Added.
- fast/regions/layers/accelerated-compositing/floated-region-with-transformed-child-expected.html: Added.
- fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another.html: Added.
- fast/regions/layers/accelerated-compositing/move-layer-from-one-region-to-another-expected.html: Added.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding.html: Added.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-expected.html: Added.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video.html: Added.
- fast/regions/layers/accelerated-compositing/propagate-region-box-shadow-border-padding-for-video-expected.html: Added.
- fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread.html: Added.
- fast/regions/layers/accelerated-compositing/region-as-layer-in-another-flowthread-expected.html: Added.
- fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer.html: Added.
- fast/regions/layers/accelerated-compositing/transformed-layer-inside-transformed-layer-expected.html: Added.
- fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region.html: Added.
- fast/regions/layers/accelerated-compositing/transform-transparent-positioned-video-inside-region-expected.html: Added.
- fast/regions/layers/accelerated-compositing/z-index.html: Added.
- fast/regions/layers/accelerated-compositing/z-index-expected.html: Added.
- fast/regions/layers/accelerated-compositing/z-index-update-expected.html: Added.
- fast/regions/layers/accelerated-compositing/z-index-update.html: Added.
- 12:58 AM Changeset in webkit [156450] by
-
- 3 edits4 adds in trunk
[CSSRegions] Unable to collect html element in a named flow
https://bugs.webkit.org/show_bug.cgi?id=121878
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: fast/regions/collect-html-in-named-flow.html
fast/regions/iframe-html-collected.html
It should be possible to collect the html element in a named flow.
However, before we check whether adding a child is not restricted
by its original parent, we have to make sure that the original parent
is an element to safely perform the check.
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::isChildAllowed):
LayoutTests:
Use an iframe with a html element collected in a named flow
to test that is does not crash or assert.
- fast/regions/collect-html-in-named-flow-expected.txt: Added.
- fast/regions/collect-html-in-named-flow.html: Added.
- fast/regions/iframe-html-collected-expected.txt: Added.
- fast/regions/iframe-html-collected.html: Added.
Sep 25, 2013:
- 11:33 PM Changeset in webkit [156449] by
-
- 2 edits in trunk/Source/WebKit2
8 bytes memory leaks in WebProcessMainQt.cpp when proxy is initialized
https://bugs.webkit.org/show_bug.cgi?id=118515
Patch by Minju Kim <pmuarteo@gmail.com> on 2013-09-25
Reviewed by Christophe Dumez.
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::initializeProxy): Handled EnvHttpProxyFactory by using OwnPtr
to avoid memory leak when it isn't handled by NetworkProxyFactory
- 9:50 PM Changeset in webkit [156448] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, blind attempt at a build fix.
- inspector/InspectorIndexedDBAgent.cpp: Don’t include the keyPathFromIDBKeyPath method for PLATFORM(MAC) as it is unused.
- 9:15 PM Changeset in webkit [156447] by
-
- 11 edits in trunk/Source
Enable the IndexedDB build on Mac, but leave the feature non-functional
https://bugs.webkit.org/show_bug.cgi?id=121918
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
(WebCore::IDBFactory::create): If the IDBFactoryBackend is null (which it is for on-levelDB platforms),
don't create an IDBFactory. This hides the feature from javascript even though upport code is in the build.
- inspector/InspectorIndexedDBAgent.cpp: Empty out DatabaseLoader::execute on Mac until the inspector build gurus can figure out a 32bit-vs-64bit issue that there is no obvious solution for.
- WebCore.xcodeproj/project.pbxproj: Remove the Modules/indexedDB/leveldb directory now that Mac has no further use for it.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 8:54 PM Changeset in webkit [156446] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed build fix for EFL port.
IDBCursorBackendImpl and IDBDatabaseBackendImpl are renamed after r156406.
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::create):
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
(WebCore::IDBTransactionBackendLevelDB::registerOpenCursor):
(WebCore::IDBTransactionBackendLevelDB::unregisterOpenCursor):
(WebCore::IDBTransactionBackendLevelDB::closeOpenCursors):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
(WebCore::IDBTransactionBackendLevelDB::database):
- 8:51 PM Changeset in webkit [156445] by
-
- 3 edits in trunk/LayoutTests
fast/css/font-face-data-uri.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82744
Reviewed by Darin Adler.
This test used to wait for one font to load, but not for another, which made no sense.
- fast/css/font-face-data-uri.html: Wait for both fonts. Increased the number of tries,
it's not that long. Use an async test idiom that doesn't conflict with js-test-post.js.
- fast/css/font-face-data-uri-expected.txt: Updated the results for proper async
test usage.
- 7:30 PM Changeset in webkit [156444] by
-
- 5 edits in trunk/Source/WebCore
Do not reenter Document from its destructor
https://bugs.webkit.org/show_bug.cgi?id=121933
Reviewed by Darin Adler.
Following r156422, there are cases where we would reenter Document
during its destruction.
The flow was the following:
-Document's destructor is executed.
-DocumentStyleSheetCollection being part of Document, its destructor
is executed.
-DocumentStyleSheetCollection's destructor detach the owner node of all
its stylesheets avoid keeping stale references to a dead Document.
-CSSStyleSheet::clearOwnerNode() would fetch the dying document
and invoke Document::styleResolverChanged().
This would not fail because the document is detached and Document::styleResolverChanged()
would fail early. This is complicated and error prone so this patch attempt to clear
the process a bit.
With the patch, Document detach all the stylesheets early in the destruction.
Clearing the stylesheet is also changed to avoid re-entering the document.
- css/CSSStyleSheet.h:
- dom/Document.cpp:
(WebCore::Document::~Document):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::detachFromDocument):
- dom/DocumentStyleSheetCollection.h:
- 7:03 PM Changeset in webkit [156443] by
-
- 3 edits in trunk/Source/WTF
Fix compilation with new MSVC compiler for Windows CE
https://bugs.webkit.org/show_bug.cgi?id=121914
Reviewed by Darin Adler.
Remove code to support older Windows CE versions, since those old
versions do not support C+11, which is required in the meantime.
- wtf/Atomics.h:
- wtf/Platform.h:
- 7:01 PM Changeset in webkit [156442] by
-
- 2 edits in trunk/Source/WebCore
htmlediting.cpp: unnecessary local variable cleanup
https://bugs.webkit.org/show_bug.cgi?id=121903
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-25
Reviewed by Darin Adler.
Code cleanup.
- editing/htmlediting.cpp:
(WebCore::lowestEditableAncestor):
- 6:49 PM Changeset in webkit [156441] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed Build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 6:05 PM Changeset in webkit [156440] by
-
- 5 edits1 add in trunk/Tools
Removed check for Apple Application Support directory in WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=121869
Patch by Alex Christensen <achristensen@webkit.org> on 2013-09-25
Reviewed by Brent Fulgham.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
Use DLLLauncherWinCairo.props for WinCairo ports.
- win/DLLLauncher/DLLLauncherMain.cpp:
(wWinMain):
Don't call modifyPath to check for AAS in the WinCairo port.
- win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
- 6:03 PM Changeset in webkit [156439] by
-
- 10 edits in trunk/Source
Unreviewed, rolling out r156432.
http://trac.webkit.org/changeset/156432
https://bugs.webkit.org/show_bug.cgi?id=121932
some integer conversion things that need brady to fix
(Requested by thorton on #webkit).
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- Modules/indexeddb/IDBFactory.h:
(WebCore::IDBFactory::create):
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 5:53 PM Changeset in webkit [156438] by
-
- 4 edits in trunk/Source
Move KeyValuePairTraits inside HashMap
https://bugs.webkit.org/show_bug.cgi?id=121931
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- tools/ProfileTreeNode.h:
Source/WTF:
Also rename the ValueType typedef to KeyValuePairType since it's always a key value pair.
- wtf/HashMap.h:
(WTF::HashMap::KeyValuePairTraits::isEmptyValue):
(WTF::HashMap::find):
(WTF::HashMap::contains):
- 5:48 PM Changeset in webkit [156437] by
-
- 7 edits in trunk
Enabled AssembleBuildLogs on WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=121923
Patch by Alex Christensen <achristensen@webkit.org> on 2013-09-25
Reviewed by Brent Fulgham.
Source/WebKit:
- WebKit.vcxproj/WebKit.sln:
Build AssembleBuildLogs in WinCairo port.
Tools:
- win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
Fixed reference to README, added WinCairo configurations.
- win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
Fixed reference to README.
- win/AssembleBuildLogs/AssembleLogs.cmd:
Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
- win/AssembleBuildLogs/README: Fixed spelling.
- 5:41 PM Changeset in webkit [156436] by
-
- 2 edits in trunk/Source/WebCore
Win64 compile fix after r155226.
https://bugs.webkit.org/show_bug.cgi?id=120969
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj:
Disable building StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm on Win64.
- 4:51 PM Changeset in webkit [156435] by
-
- 4 edits in trunk/Source/WebCore
Flaky Test: platform/mac/fonts/han-disunification.html
https://bugs.webkit.org/show_bug.cgi?id=114207
Reviewed by Anders Carlsson.
This test was affected by preceding tests changing font settings.
Save original font if it's changed, and restore it in Backup::restoreTo().
- WebCore.exp.in:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setStandardFontFamily):
(WebCore::InternalSettings::setSerifFontFamily):
(WebCore::InternalSettings::setSansSerifFontFamily):
(WebCore::InternalSettings::setFixedFontFamily):
(WebCore::InternalSettings::setCursiveFontFamily):
(WebCore::InternalSettings::setFantasyFontFamily):
(WebCore::InternalSettings::setPictographFontFamily):
- testing/InternalSettings.h:
- 4:26 PM Changeset in webkit [156434] by
-
- 2 edits in trunk/Source/WTF
Un-indent HashMap.h.
Rubber-stamped by Andreas Kling.
- wtf/HashMap.h:
- 4:24 PM Changeset in webkit [156433] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Attempting to scroll from a non-scrollable layer results the main document getting scrolled.
https://bugs.webkit.org/show_bug.cgi?id=121889.
<rdar://problem/15072441>
- WebView.cpp:
(WebView::gesture):
Call scrollByRecursively on the current RenderLayer's enclosingScrollableLayer to make sure that the method
doesn't bail early and end up just scrolling the main document instead of the next scrollable layer in the RenderLayer tree.
- 4:21 PM Changeset in webkit [156432] by
-
- 10 edits in trunk/Source
Enable the IndexedDB build on Mac, but leave the feature non-functional
https://bugs.webkit.org/show_bug.cgi?id=121918
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig: Enable the feature.
- Modules/indexeddb/IDBFactory.h:
(WebCore::IDBFactory::create): If the IDBFactoryBackend is null (which it is for on-levelDB platforms),
don't create an IDBFactory. This hides the feature from javascript even though upport code is in the build.
- WebCore.xcodeproj/project.pbxproj: Remove the Modules/indexedDB/leveldb directory now that Mac has no further use for it.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 4:18 PM Changeset in webkit [156431] by
-
- 3 edits in trunk/LayoutTests
Flaky Test: fast/history/history-subframe-with-name.html
https://bugs.webkit.org/show_bug.cgi?id=51039
Reviewed by Brady Eidson.
- fast/history/history-subframe-with-name.html: In state 3, there was a race between
history.forward() and navigating to a new URL. Not sure how this resulted in an
extra load, but let's get rid of that. Also, extended failure logging.
- fast/history/resources/history-subframe-with-name-2.html: No longer do the
navigation unconditionally. We need it in state 1, but not in state 3.
- 4:18 PM Changeset in webkit [156430] by
-
- 3 edits in trunk/Source/WebKit/win
[WIN] Replace CF time functions with Windows API functions in WebHistory
https://bugs.webkit.org/show_bug.cgi?id=121599
Reviewed by Brent Fulgham.
This reduces the dependencies on the CoreFoundation library.
- WebHistory.cpp:
(addDayToSystemTime):
(getDayBoundaries):
(beginningOfDay):
(dateKey):
(WebHistory::orderedLastVisitedDays):
- WebHistory.h:
- 3:54 PM Changeset in webkit [156429] by
-
- 2 edits in trunk/Source/WTF
Un-indent HashTraits.h.
Rubber-stamped by Andreas Kling.
- wtf/HashTraits.h:
- 3:51 PM Changeset in webkit [156428] by
-
- 1 edit in trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
Fix the build.
- 3:42 PM Changeset in webkit [156427] by
-
- 2 edits in trunk/Source/WebCore
Make EventTarget::hasEventListeners() a const method.
This class needs a lot of love in the const correctness department
but for now let's limit ourselves to fixing the IndexedDB build.
- dom/EventTarget.h:
(WebCore::EventTarget::hasEventListeners):
- 3:35 PM Changeset in webkit [156426] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Disable more CSS_SHAPES tests on AppleWin port.
- platform/win/TestExpectations:
- 3:18 PM Changeset in webkit [156425] by
-
- 3 edits99 adds in trunk/PerformanceTests
DoYouEvenBench: Add a test case for FlightJS
https://bugs.webkit.org/show_bug.cgi?id=121926
Reviewed by Antti Koivisto.
Add a FlightJS test case.
- DoYouEvenBench/benchmark.html:
- DoYouEvenBench/benchmark.js:
- DoYouEvenBench/flightjs-example-app: Added.
- DoYouEvenBench/flightjs-example-app/LICENSE.md: Added.
- DoYouEvenBench/flightjs-example-app/README.md: Added.
- DoYouEvenBench/flightjs-example-app/app: Added.
- DoYouEvenBench/flightjs-example-app/app/boot: Added.
- DoYouEvenBench/flightjs-example-app/app/boot/page.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_data: Added.
- DoYouEvenBench/flightjs-example-app/app/component_data/compose_box.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_data/mail_items.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_data/move_to.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/compose_box.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/folders.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/mail_controls.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/mail_items.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/move_to_selector.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/with_select.js: Added.
- DoYouEvenBench/flightjs-example-app/app/css: Added.
- DoYouEvenBench/flightjs-example-app/app/css/custom.css: Added.
- DoYouEvenBench/flightjs-example-app/app/data.js: Added.
- DoYouEvenBench/flightjs-example-app/app/templates.js: Added.
- DoYouEvenBench/flightjs-example-app/components: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.css: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.min.css: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.css: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.min.css: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/img: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings-white.png: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings.png: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/js: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.js: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.min.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/.gitignore: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/CHANGES: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/CONTRIBUTORS.md: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/LICENSE: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/README.md: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/component.json: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.min.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.min.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/package.json: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-kill.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-matchers.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/index.html: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine-html.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.css: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine_favicon.png: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/json2.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-array.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-date.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-function.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-object.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-string.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/.travis.yml: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/advice.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/component.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/compose.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/index.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/logger.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/registry.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/utils.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/tools: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/tools/debug: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/tools/debug/debug.js: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/LICENSE.md: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/README.md: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/bower.json: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib/jasmine-flight.js: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-jquery: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib/jasmine-jquery.js: Added.
- DoYouEvenBench/flightjs-example-app/components/jquery: Added.
- DoYouEvenBench/flightjs-example-app/components/jquery/component.json: Added.
- DoYouEvenBench/flightjs-example-app/components/jquery/composer.json: Added.
- DoYouEvenBench/flightjs-example-app/components/jquery/jquery.js: Added.
- DoYouEvenBench/flightjs-example-app/components/jquery/jquery.min.js: Added.
- DoYouEvenBench/flightjs-example-app/components/mustache: Added.
- DoYouEvenBench/flightjs-example-app/components/mustache/mustache.js: Added.
- DoYouEvenBench/flightjs-example-app/components/requirejs: Added.
- DoYouEvenBench/flightjs-example-app/components/requirejs/require.js: Added.
- DoYouEvenBench/flightjs-example-app/index.html: Added.
- DoYouEvenBench/flightjs-example-app/karma.conf.js: Added.
- DoYouEvenBench/flightjs-example-app/package.json: Added.
- DoYouEvenBench/flightjs-example-app/requireMain.js: Added.
- 3:18 PM Changeset in webkit [156424] by
-
- 47 edits in trunk/Source
../WebCore: [Windows] Refactor RuntimeEnabledFeatures as a Singleton
https://bugs.webkit.org/show_bug.cgi?id=121883
Windows is experiencing crashes when client programs (such as
DumpRenderTree) attemp to change settings on the RuntimeEnabledFeatures
object. The inlined static accessor methods are not accessing
memory safely (when compiled by Visual Studio) resulting in
crashes.
Reviewed by Jer Noble.
- WebCore.exp.in: Remove static accessors for RuntimeEnabledFeatures.
- bindings/generic/RuntimeEnabledFeatures.cpp: Switch methods to
conform to a singleton pattern.
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::sharedRuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::fileSystemEnabled):
(WebCore::RuntimeEnabledFeatures::javaScriptI18NAPIEnabled):
(WebCore::RuntimeEnabledFeatures::audioEnabled):
(WebCore::RuntimeEnabledFeatures::htmlMediaElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlAudioElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlVideoElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
(WebCore::RuntimeEnabledFeatures::mediaControllerEnabled):
(WebCore::RuntimeEnabledFeatures::mediaErrorEnabled):
(WebCore::RuntimeEnabledFeatures::timeRangesEnabled):
(WebCore::RuntimeEnabledFeatures::sharedWorkerEnabled):
(WebCore::RuntimeEnabledFeatures::webSocketEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):
- bindings/generic/RuntimeEnabledFeatures.h: Ditto.
(WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled):
(WebCore::RuntimeEnabledFeatures::localStorageEnabled):
(WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled):
(WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitNotificationsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitNotificationsEnabled):
(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
(WebCore::RuntimeEnabledFeatures::setGeolocationEnabled):
(WebCore::RuntimeEnabledFeatures::geolocationEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::indexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::canvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSShapesEnabled):
(WebCore::RuntimeEnabledFeatures::cssShapesEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSRegionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssRegionsEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSCompositingEnabled):
(WebCore::RuntimeEnabledFeatures::cssCompositingEnabled):
(WebCore::RuntimeEnabledFeatures::setFontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenEnabledEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitExitFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::touchEnabled):
(WebCore::RuntimeEnabledFeatures::setTouchEnabled):
(WebCore::RuntimeEnabledFeatures::setDeviceMotionEnabled):
(WebCore::RuntimeEnabledFeatures::deviceMotionEnabled):
(WebCore::RuntimeEnabledFeatures::deviceMotionEventEnabled):
(WebCore::RuntimeEnabledFeatures::ondevicemotionEnabled):
(WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled):
(WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled):
(WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled):
(WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled):
(WebCore::RuntimeEnabledFeatures::setSpeechInputEnabled):
(WebCore::RuntimeEnabledFeatures::speechInputEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::setScriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::scriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarListEnabled):
(WebCore::RuntimeEnabledFeatures::setFileSystemEnabled):
(WebCore::RuntimeEnabledFeatures::setJavaScriptI18NAPIEnabled):
(WebCore::RuntimeEnabledFeatures::mediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetUserMediaEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRTCPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::quotaEnabled):
(WebCore::RuntimeEnabledFeatures::setQuotaEnabled):
(WebCore::RuntimeEnabledFeatures::mediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::encryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::setEncryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::shadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::setShadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::authorShadowDOMForAnyElementEnabled):
(WebCore::RuntimeEnabledFeatures::setAuthorShadowDOMForAnyElementEnabled):
(WebCore::RuntimeEnabledFeatures::customDOMElementsEnabled):
(WebCore::RuntimeEnabledFeatures::setCustomDOMElements):
(WebCore::RuntimeEnabledFeatures::styleScopedEnabled):
(WebCore::RuntimeEnabledFeatures::setStyleScopedEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeLocalEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeLocalEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeMonthEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeMonthEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeTimeEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeTimeEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeWeekEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeWeekEnabled):
(WebCore::RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled):
(WebCore::RuntimeEnabledFeatures::setExperimentalContentSecurityPolicyFeaturesEnabled):
(WebCore::RuntimeEnabledFeatures::seamlessIFramesEnabled):
(WebCore::RuntimeEnabledFeatures::setSeamlessIFramesEnabled):
(WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getCSSPropertyNamePrefix): Use singleton accessors.
(WebCore::cssPropertyIDForJSCSSPropertyName): Ditto.
- bindings/scripts/CodeGeneratorJS.pm:
(GetRuntimeEnableFunctionName): Generate singleton version of
accessors.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoaded): Use singleton accessors.
(WebCore::CSSFontFace::getFontData): Ditto.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Ditto.
- css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID): Ditto.
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::rewriteSpecifiers):
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::fontLoaded): Ditto.
- css/StyleResolver.h:
(WebCore::StyleResolver::ensureScopeResolver): Ditto.
- dom/Document.cpp:
(WebCore::Document::cssRegionsEnabled): Ditto.
(WebCore::Document::cssCompositingEnabled):
(WebCore::Document::shouldDisplaySeamlesslyWithParent):
(WebCore::Document::getCachedLocale):
- dom/Element.cpp:
(WebCore::Element::createShadowRoot): Ditto.
- dom/Position.cpp:
(WebCore::Position::Position): Ditto.
(WebCore::Position::findParent):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection): Ditto.
- dom/make_names.pl:
(printConstructorInterior): Generate singleton version of accessors.
(printWrapperFunctions): Ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isSpeechEnabled): Use singleton accessors.
(WebCore::HTMLInputElement::setupDateTimeChooserParameters): Ditto.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::finishParsingChildren): Ditto.
(WebCore::HTMLMediaElement::scheduleDelayedAction):
(WebCore::HTMLMediaElement::loadTimerFired):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadInternal):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack):
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack):
(WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack):
(WebCore::HTMLMediaElement::addAudioTrack):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::addVideoTrack):
(WebCore::HTMLMediaElement::removeAudioTrack):
(WebCore::HTMLMediaElement::removeTextTrack):
(WebCore::HTMLMediaElement::removeVideoTrack):
(WebCore::HTMLMediaElement::audioTracks):
(WebCore::HTMLMediaElement::textTracks):
(WebCore::HTMLMediaElement::videoTracks):
(WebCore::HTMLMediaElement::didAddTextTrack):
(WebCore::HTMLMediaElement::didRemoveTextTrack):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseAttribute): Ditto.
(WebCore::HTMLStyleElement::scopedAttributeChanged):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
(WebCore::HTMLStyleElement::scoped):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute): Ditto.
(WebCore::HTMLTrackElement::scheduleLoad):
(WebCore::HTMLTrackElement::canLoadUrl):
- html/InputType.cpp:
(WebCore::createInputTypeFactoryMap): Ditto.
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::experimentalFeaturesEnabled): Ditto.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener): Ditto.
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks): Ditto.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Ditto.
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShadowDOMEnabled):
(WebCore::InternalSettings::setAuthorShadowDOMForAnyElementEnabled):
(WebCore::InternalSettings::setStyleScopedEnabled):
(WebCore::InternalSettings::setCSSExclusionsEnabled):
(WebCore::InternalSettings::setCSSShapesEnabled):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
../WebKit: [Windows] Refactor RuntimeEnabledFeatures as a Singleton
https://bugs.webkit.org/show_bug.cgi?id=121883
Reviewed by Jer Noble.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Expose singleton accessor for DLL clients.
../WebKit/blackberry: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setStyleScopedEnabled): use
singleton accessor.
../WebKit/efl: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSRegionsEnabled): Use singleton.
(DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled): Ditto.
- ewk/ewk_settings.cpp:
(ewk_settings_shadow_dom_enable_get): Ditto.
(ewk_settings_shadow_dom_enable_set):
- ewk/ewk_view.cpp:
(_ewk_view_priv_new): Ditto.
../WebKit/gtk: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSRegionsEnabled): Use singleton.
(DumpRenderTreeSupportGtk::setExperimentalContentSecurityPolicyFeaturesEnabled):
(DumpRenderTreeSupportGtk::setSeamlessIFramesEnabled):
(DumpRenderTreeSupportGtk::setShadowDOMEnabled):
(DumpRenderTreeSupportGtk::setStyleScopedEnabled):
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings): Ditto.
../WebKit/mac: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Use singleton accessor.
(-[WebView _setDashboardBehavior:to:]): Ditto.
../WebKit/qt: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply): Use singleton accessor.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setSeamlessIFramesEnabled): Ditto.
../WebKit/win: [Windows] Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883
Reviewed by Jer Noble.
- WebView.cpp:
(WebView::notifyPreferencesChanged): Use singleton accessor
../WebKit2: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Use
Singleton accessor.
(WebKit::InjectedBundle::setShadowDOMEnabled):
(WebKit::InjectedBundle::setCSSRegionsEnabled):
(WebKit::InjectedBundle::setCSSCompositingEnabled):
(WebKit::InjectedBundle::setSeamlessIFramesEnabled):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Ditto.
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Ditto.
- 3:08 PM Changeset in webkit [156423] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for IDBDatabase.
Turns out there was a much cleaner way to express this.
- 2:13 PM Changeset in webkit [156422] by
-
- 34 edits in trunk/Source/WebCore
Tie the life of DocumentStyleSheetCollection and Document together
https://bugs.webkit.org/show_bug.cgi?id=121892
Reviewed by Andreas Kling.
DocumentStyleSheetCollection had an odd destruction pattern for no apparent reason.
The two objects strictly depend on eachother, this patch make that explicit by making
DocumentStyleSheetCollection a plain object in Document's memory space.
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::didMutateRules):
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::initUserStyle):
- css/DocumentRuleSets.h:
- css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
- css/InspectorCSSOMWrappers.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
- css/StyleSheetList.cpp:
(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::detachFromDocument):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleResolver):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::scheduleOptimizedStyleSheetUpdate):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::haveStylesheetsLoaded):
- dom/Document.h:
(WebCore::Document::styleSheetCollection):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::pageUserSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
(WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::addAuthorSheet):
(WebCore::DocumentStyleSheetCollection::addUserSheet):
(WebCore::DocumentStyleSheetCollection::removePendingSheet):
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
- dom/DocumentStyleSheetCollection.h:
- dom/Element.cpp:
(WebCore::Element::createPseudoElementIfNeeded):
- dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::insertedIntoDocument):
(WebCore::InlineStyleSheetOwner::removedFromDocument):
(WebCore::InlineStyleSheetOwner::clearDocumentData):
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):
- html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::insertedInto):
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willMatchRule):
- mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedInto):
- page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
- page/PageGroup.cpp:
(WebCore::PageGroup::invalidateInjectedStyleSheetCacheInAllFrames):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::lineHeight):
- rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::lineHeight):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::uncachedFirstLineStyle):
(WebCore::RenderObject::cachedFirstLineStyle):
- rendering/RenderObject.h:
(WebCore::RenderObject::firstLineStyle):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):
- style/StyleResolveTree.cpp:
(WebCore::Style::resolveLocal):
- testing/Internals.cpp:
(WebCore::Internals::insertAuthorCSS):
(WebCore::Internals::insertUserCSS):
- 1:58 PM Changeset in webkit [156421] by
-
- 8 edits in trunk/Source
FeatureDefine.xcconfig cleanup (They should all be identical).
https://bugs.webkit.org/show_bug.cgi?id=121921
Reviewed by Mark Rowe.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 1:57 PM Changeset in webkit [156420] by
-
- 7 edits in trunk/Source/WebKit2
Use tuples for encoding IPC messages
https://bugs.webkit.org/show_bug.cgi?id=121924
Reviewed by Andreas Kling.
Yet another step towards getting rid of the Arguments hierarchy.
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
(CoreIPC::handleMessageVariadic):
(CoreIPC::handleMessageDelayed):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
- Scripts/webkit2/messages.py:
(arguments_type_old):
(arguments_type):
(reply_type):
(decode_type):
(delayed_reply_type):
(message_to_struct_declaration):
- Scripts/webkit2/messages_unittest.py:
(LoadURL):
(std):
(TouchEvent):
(DidReceivePolicyDecision):
(Close):
(PreferencesDidChange):
(SendDoubleAndFloat):
(SendInts):
(CreatePlugin):
(RunJavaScriptAlert):
(GetPlugins):
(GetPluginProcessConnection):
(TestMultipleAttributes):
(TestParameterAttributes):
(TemplateTest):
(DidCreateWebProcessConnection):
(InterpretKeyEvent):
(DeprecatedOperation):
(ExperimentalOperation):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
- 1:01 PM Changeset in webkit [156419] by
-
- 45 edits in trunk/Source/WebCore
JS wrappers should have strongly typed impl() functions.
<https://webkit.org/b/121919>
Reviewed by Geoffrey Garen.
Generate strongly typed JSFoo::impl() functions for all wrappers,
not just those marked with JSGenerateToNativeObject.
Removed 8.8 million static_casts that are no longer needed.
- 12:22 PM Changeset in webkit [156418] by
-
- 3 edits in trunk/Tools
[WIN] Fix MSVC C4146 compiler warning
https://bugs.webkit.org/show_bug.cgi?id=121838
Reviewed by Brent Fulgham.
Fix some variables from unsinged to int to fix the compiler warning
"unary minus operator applied to unsigned type, result still unsigned".
- DumpRenderTree/WorkQueueItem.h:
(BackItem::BackItem):
(ForwardItem::ForwardItem):
- DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):
- 12:13 PM Changeset in webkit [156417] by
-
- 2 edits in trunk/Tools
[GTK] Switch the 64-bit Release builder to testing layout tests under WK2
https://bugs.webkit.org/show_bug.cgi?id=121256
Reviewed by Martin Robinson.
Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 12:04 PM Changeset in webkit [156416] by
-
- 5 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=121885.
<rdar://problem/15072332>.
Reviewed by Brent Fulgham.
No new functionality added.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
- rendering/RenderLayer.h:
- WebView.cpp:
(WebView::gestureNotify):
(WebView::gesture):
- 12:02 PM Changeset in webkit [156415] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening. Moving WK1-specific failure expectations into the WK1-specific TestExpectations.
Also adding expectations for the currently failing tests on WK2.
- platform/gtk-wk1/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 11:56 AM Changeset in webkit [156414] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix: Add new syntax of function declaration to
Windows export definition file.
- 11:52 AM Changeset in webkit [156413] by
-
- 69 edits in trunk/Source/WebCore
Reduce repetitive EventTarget subclassing.
<https://webkit.org/b/121915>
Reviewed by Antti Koivisto.
Add a EventTargetWithInlineData helper class to EventTarget.h.
It's a simple subclass with an EventTargetData member and FINAL
eventTargetData()/ensureEventTargetData() overrides.
Turns out that this fits almost every use case except Node and
SVGElementInstance.
Inlined most of the FINAL EventTarget overrides since they will
be called on tight pointers by generated bindings code and this
removes the need for virtual dispatch.
Spammed OVERRIDE FINAL as appropriate, we can't make the whole
classes FINAL until bug 121747 is fixed, so added FIXMEs.
- 11:51 AM Changeset in webkit [156412] by
-
- 1 edit42 adds12 deletes in trunk/LayoutTests
Unreviewed GTK gardening. Moving around and updating the GTK baselines that are
either specific to WK1 or WK2 or can be shared by both.
- platform/gtk-wk1/http: Added.
- platform/gtk-wk1/http/tests: Added.
- platform/gtk-wk1/http/tests/cache: Added.
- platform/gtk-wk1/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Added.
- platform/gtk-wk1/http/tests/security: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.
- platform/gtk-wk2/http: Added.
- platform/gtk-wk2/http/tests: Added.
- platform/gtk-wk2/http/tests/loading: Added.
- platform/gtk-wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
- platform/gtk-wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
- platform/gtk-wk2/http/tests/misc: Added.
- platform/gtk-wk2/http/tests/misc/401-alternative-content-expected.txt: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-1: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-2: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-4: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Added.
- platform/gtk-wk2/http/tests/security: Added.
- platform/gtk-wk2/http/tests/security/401-logout: Added.
- platform/gtk-wk2/http/tests/security/401-logout/401-logout-expected.txt: Added.
- platform/gtk-wk2/http/tests/xmlhttprequest: Added.
- platform/gtk-wk2/http/tests/xmlhttprequest/failed-auth-expected.txt: Added.
- platform/gtk-wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Added.
- platform/gtk-wk2/js: Added.
- platform/gtk-wk2/js/dom: Added.
- platform/gtk-wk2/js/dom/constructor-length-expected.txt: Added.
- platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt: Added.
- platform/gtk/http/tests/cache: Removed.
- platform/gtk/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Removed.
- platform/gtk/userscripts: Added.
- platform/gtk/userscripts/script-run-at-end-expected.txt: Added.
- 11:43 AM Changeset in webkit [156411] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix after r156408.
- 11:29 AM Changeset in webkit [156410] by
-
- 2 edits in trunk/LayoutTests
loader/go-back-to-different-window-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=96642
- platform/mac/TestExpectations: Marking it as flaky on Mac. I think that it's
a general issue with the tools that window resizing doesn't work well.
- 11:21 AM Changeset in webkit [156409] by
-
- 6 edits in trunk
AX: WebKit doesn't map aria-sort=other on OS X
https://bugs.webkit.org/show_bug.cgi?id=118511
Patch by Sam White <Samuel White> on 2013-09-25
Reviewed by Chris Fleizach.
Source/WebCore:
No new tests, updated existing aria-sort test to validate addition of "other"
sort order per http://www.w3.org/TR/wai-aria/complete#aria-sort.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::sortDirection):
- accessibility/AccessibilityObject.h:
LayoutTests:
Updated test to check "other" aria-sort order. Also added additional checks to
determine which elements expose aria-sort so our "none" case is more clear.
- accessibility/aria-sort-expected.txt:
- accessibility/aria-sort.html:
- 11:09 AM Changeset in webkit [156408] by
-
- 65 edits in trunk/Source/WebCore
CTTE: More Document references please
https://bugs.webkit.org/show_bug.cgi?id=121893
Reviewed by Anders Carlsson.
- Thread even more Document&s around. *
- 11:07 AM Changeset in webkit [156407] by
-
- 2 edits in trunk/Source/WebCore
HasMemoryCostMemberFunction should work for final classes
https://bugs.webkit.org/show_bug.cgi?id=121747
Reviewed by Sam Weinig.
Use decltype to check for the memoryCost() member function. This doesn't check that the return type is size_t, but
the build will fail anyway if that's the case (or if the return type is not convertible to size_t).
- bindings/js/JSDOMBinding.h:
- 11:02 AM Changeset in webkit [156406] by
-
- 11 edits13 moves1 delete in trunk/Source/WebCore
More refactoring to make the LevelDB dependencies of IDB more obvious.
https://bugs.webkit.org/show_bug.cgi?id=121880
Reviewed by Alexey Proskuryakov.
This patch does three things:
1 - Moves some files to the indexeddb/leveldb subdirectory, renaming them in the process.
2 - Renames some classes.
3 - Adds "USE(LEVELDB)" guards in addition to the ENABLE(INDEXED_DATABASE) guard for those files.
Project file updates:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.xcodeproj/project.pbxproj:
- WebCore.vcxproj/WebCore.vcxproj:
File renames, class renames, and USE(LEVELDB) guards:
- Modules/indexeddb/IDBBackingStore.cpp: Removed.
- Modules/indexeddb/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create): Add a null return if USE(LEVELDB) is disabled as a stop gap measure until
there is a non-LevelDB impl.
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBBackingStore.h.
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp.
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h.
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp.
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h.
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.cpp.
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.h.
- Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:
- Modules/indexeddb/leveldb/IDBLevelDBCoding.h:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp.
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h.
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp.
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h.
- Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.cpp.
- Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.h.
- 11:00 AM Changeset in webkit [156405] by
-
- 3 edits in trunk/Tools
Add style checker for CMake lists
https://bugs.webkit.org/show_bug.cgi?id=121764
Reviewed by Ryosuke Niwa.
Add an additional check to make sure that list of files are sorted.
Exclude lists of include directories for now, since the order
can be importent for compilation of some files.
- Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker.check):
(CMakeChecker._check_indent):
(CMakeChecker):
(CMakeChecker._check_list_order):
(CMakeChecker._list_item_path):
- Scripts/webkitpy/style/checkers/cmake_unittest.py:
(CMakeCheckerTest.test_check):
- 10:45 AM Changeset in webkit [156404] by
-
- 4 edits2 adds in trunk
REGRESSION (r156355) Links / interactive elements inside nested tables are unclickable
https://bugs.webkit.org/show_bug.cgi?id=121904
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/table/hittest-self-painting.html
Original reduction by Philippe Wittenbergh.
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
Tighten a bit.
(WebCore::RenderTableRow::nodeAtPoint):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
These flipped accidentally in r156355.
LayoutTests:
- fast/table/hittest-self-painting-expected.txt: Added.
- fast/table/hittest-self-painting.html: Added.
- 10:40 AM Changeset in webkit [156403] by
-
- 5 edits in trunk/Tools
CMakeChecker takes unusually long time to run
https://bugs.webkit.org/show_bug.cgi?id=105662
Reviewed by Ryosuke Niwa.
Move the caching mechanism for regular expression of the C++ checker into
a common file and use it for the CMake and ChangeLog checkers too.
- Scripts/webkitpy/style/checkers/changelog.py:
(ChangeLogChecker.check_entry):
- Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker._process_line):
(CMakeChecker._check_no_space_cmds):
(CMakeChecker._check_one_space_cmds):
(CMakeChecker._check_non_lowercase_cmd):
- Scripts/webkitpy/style/checkers/common.py:
(match):
(search):
(searchIgnorecase):
(sub):
(subn):
- Scripts/webkitpy/style/checkers/cpp.py:
- 9:33 AM Changeset in webkit [156402] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix for WinCE after r155098.
Windows CE does not support getenv().
- jsc.cpp:
(main):
- 9:32 AM Changeset in webkit [156401] by
-
- 2 edits in trunk/Source/WTF
Fix template deduction for CollatorDefault
- wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault): Use nullptr instead of 0.
- 9:08 AM Changeset in webkit [156400] by
-
- 2 edits in trunk/Source/WebCore
Fix warning in makeprop.pl
https://bugs.webkit.org/show_bug.cgi?id=121900
Reviewed by Ryosuke Niwa.
%nameIsInherited and %nameToId were incorrectly initialized using
references instead of lists.
Anyway there's no need to initialize those variables explicitly,
they're already empty by default.
- css/makeprop.pl:
- 9:02 AM Changeset in webkit [156399] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r156393): Build with !ENABLE(SVG_FONTS) broken
Unreviewed build-fix.
Protect SVG font code with #ifdef ENABLE(SVG_FONTS).
- platform/graphics/WidthIterator.cpp:
(WebCore::applyFontTransforms):
- 8:41 AM Changeset in webkit [156398] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r156272.
http://trac.webkit.org/changeset/156272
https://bugs.webkit.org/show_bug.cgi?id=121909
Has no real effect (Requested by carewolf on #webkit).
- platform/graphics/qt/TileQt.cpp:
(WebCore::TileQt::updateBackBuffer):
- 8:40 AM Changeset in webkit [156397] by
-
- 16 edits in trunk/Source/WebCore
Move wheel event dispatch from Node to Element.
<https://webkit.org/b/121908>
Reviewed by Anders Carlsson.
Wheel events are only ever dispatched on Elements, so move the logic out of Node.
Had to make RenderBox::scroll() and friends return a stopElement instead of a
stopNode (out argument) to make this work, though it was only ever returning
Elements there anyway.
- 8:06 AM Changeset in webkit [156396] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening. Unskip passing fast/text/font-kerning.html
https://bugs.webkit.org/show_bug.cgi?id=121907
Unreviewed EFL gardening. Passes after r152411.
Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2013-09-25
- platform/efl/TestExpectations:
- 7:57 AM Changeset in webkit [156395] by
-
- 13 edits in trunk
[Qt] Fix build with Qt 5.2 QtPosition module
https://bugs.webkit.org/show_bug.cgi?id=121089
Reviewed by Simon Hausmann.
.:
QtLocation -> QtPositioning
- Source/sync.profile:
Source/WebKit:
QtLocation -> QtPositioning
- WebKit1.pri:
Source/WebKit/qt:
QtLocation -> QtPositioning
- WebCoreSupport/GeolocationClientQt.cpp:
Source/WebKit2:
QtLocation -> QtPositioning
- Target.pri:
- UIProcess/qt/WebGeolocationProviderQt.cpp:
- WebKit2.pri:
Tools:
QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
that might depend on them.
- qmake/mkspecs/features/default_pre.prf:
- qmake/mkspecs/features/features.prf:
- 7:50 AM Changeset in webkit [156394] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix build with !ENABLE(BLOB) after r156330
Unreviewed build-fix.
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
- 7:19 AM Changeset in webkit [156393] by
-
- 13 edits3 adds in trunk
Support kerning with SVG web fonts
https://bugs.webkit.org/show_bug.cgi?id=117540
Source/WebCore:
Reviewed by Stephen Chenney.
Adds the glue to WidthIterator to take advantage of kerning in SVG web fonts.
To supply SVG font kerning with its required text input, the signature of
applyFontTransforms has been extended.
Since SVG font kerning was extremely slow, it has been sped up by replacing
the iteration over all possible kerning definitions with a hash-map based
lookup of the leading symbol to be kerned. The new algorithm provides a
roughly 100x speed-up in SVG font kerning.
Test: fast/text/svg-font-face-with-kerning.html
- platform/graphics/TextRun.h:
(WebCore::TextRun::string):
- platform/graphics/WidthIterator.cpp:
(WebCore::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::applySVGKerning):
- rendering/svg/SVGTextRunRenderingContext.h:
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::invalidateGlyphCache):
(WebCore::SVGFontElement::ensureGlyphCache):
(WebCore::SVGKerningMap::clear):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):
(WebCore::stringMatchesGlyphName):
(WebCore::stringMatchesUnicodeName):
(WebCore::matches):
(WebCore::kerningForPairOfStringsAndGlyphs):
(WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs):
(WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs):
- svg/SVGFontElement.h:
(WebCore::SVGKerning::SVGKerning):
(WebCore::SVGKerningMap::isEmpty):
- svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::buildHorizontalKerningPair):
- svg/SVGHKernElement.h:
- svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::buildVerticalKerningPair):
- svg/SVGVKernElement.h:
LayoutTests:
Added test of SVG web font kerning.
Reviewed by Stephen Chenney.
- fast/text/svg-font-face-with-kerning-expected.png: Added.
- fast/text/svg-font-face-with-kerning-expected.txt: Added.
- fast/text/svg-font-face-with-kerning.html: Added.
- 7:16 AM Changeset in webkit [156392] by
-
- 2 edits in trunk/LayoutTests
[GTK] Update test expectations. Mark fast/images/exif-orientation.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=121906
Unreviewed GTK gardening.
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-09-25
- platform/gtk/TestExpectations: Mark fast/images/exif-orientation.html as failing,
as reported in webkit.org/b/121905.
- 6:53 AM Changeset in webkit [156391] by
-
- 10 edits9 adds in trunk
<https://webkit.org/b/120476> [CSS Masking] Implement luminance masking
Source/WebCore:
Added implementation for luminance masking. A luminance mask is applied by transforming its RGB values into
an alpha value, using luminance-to-alpha coefficients. Because this conversion is already implemented in
the ImageBuffer class, we used it in our implementation.
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-25
Reviewed by Dirk Schulze.
Tests: css3/masking/mask-luminance-gradient.html
css3/masking/mask-luminance-png.html
css3/masking/mask-luminance-svg.html
- platform/graphics/BitmapImage.cpp: Add a drawPattern method, in which an ImageBuffer is created and converted from alpha to luminance, if there is a luminance mask.
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::drawPattern):
- platform/graphics/BitmapImage.h:
- platform/graphics/GeneratorGeneratedImage.cpp: Convert the ImageBuffer to luminance, if necessary.
(WebCore::GeneratorGeneratedImage::drawPattern):
- platform/graphics/GraphicsContext.cpp: Add methods which set and check if a luminance mask is drawn.
(WebCore::GraphicsContext::setDrawLuminanceMask):
(WebCore::GraphicsContext::drawLuminanceMask):
- platform/graphics/GraphicsContext.h: Add property to ContextState for luminance drawing.
(WebCore::GraphicsContextState::GraphicsContextState):
- rendering/RenderBoxModelObject.cpp: Set the luminance property of the mask, if the layer has a mask source type of luminance.
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- svg/graphics/SVGImage.cpp: Convert the ImageBuffer to luminance, if necessary.
(WebCore::SVGImage::drawPatternForContainer):
- svg/graphics/SVGImageForContainer.cpp: Pass the luminance property to the SVG image.
(WebCore::SVGImageForContainer::drawPattern):
LayoutTests:
Added tests to verify the implementation of luminance masking.
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-25
Reviewed by Dirk Schulze.
- css3/masking/mask-luminance-gradient-expected.html: Added.
- css3/masking/mask-luminance-gradient.html: Added.
- css3/masking/mask-luminance-png.html: Added.
- css3/masking/mask-luminance-svg-expected.html: Added.
- css3/masking/mask-luminance-svg.html: Added.
- css3/masking/resources/circle-alpha.svg: Added.
- css3/masking/resources/circle2.svg: Added.
- css3/masking/resources/dice.png: Added.
- platform/mac/css3/masking/mask-luminance-png-expected.txt: Added.
- 6:02 AM Changeset in webkit [156390] by
-
- 10 edits2 deletes in trunk/Source/WebCore
Remove EventPathWalker.
<https://webkit.org/b/121890>
Reviewed by Antti Koivisto.
Purge some more leftover Shadow DOM code.
- dom/EventPathWalker.cpp:
- dom/EventPathWalker.h:
Removed.
- dom/EventRetargeter.cpp:
(WebCore::nodeOrHostIfPseudoElement):
(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::buildRelatedNodeMap):
If starting at a pseudo element, e.g for events originating from
a transition on :before/:after, retarget to the pseudo element's
host as appropriate. This was the only real "feature" we were
using in EventPathWalker.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleTouchEvent):
Replace use of EventPathWalker with parentOrShadowHostElement()
parent chain climbing.
- 5:50 AM Changeset in webkit [156389] by
-
- 3 edits in trunk/LayoutTests
[EFL] Updated accessibility expectations after r154781 and r155599
https://bugs.webkit.org/show_bug.cgi?id=121901
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-25
- platform/efl/accessibility/menu-list-sends-change-notification-expected.txt:
- platform/efl/accessibility/notification-listeners-expected.txt:
- 5:33 AM Changeset in webkit [156388] by
-
- 3 edits in trunk/Tools
[ATK] Fix style issues in AccessibilityUIElementAtk
https://bugs.webkit.org/show_bug.cgi?id=121898
Reviewed by Chris Fleizach.
Avoid the '.f' suffix for float literals and use G_VALUE_INIT
instead of { 0, { { 0 } } } to initialize a GValue.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::clickPointX): Remove suffix.
(AccessibilityUIElement::clickPointY): Ditto.
(AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
(AccessibilityUIElement::minValue): Ditto.
(AccessibilityUIElement::maxValue): Ditto.
(AccessibilityUIElement::numberAttributeValue): Remove suffix.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
(WTR::AccessibilityUIElement::x): Ditto.
(WTR::AccessibilityUIElement::y): Ditto.
(WTR::AccessibilityUIElement::width): Ditto.
(WTR::AccessibilityUIElement::height): Ditto.
(WTR::AccessibilityUIElement::clickPointX): Ditto.
(WTR::AccessibilityUIElement::clickPointY): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::minValue): Ditto.
(WTR::AccessibilityUIElement::maxValue): Ditto.
- 5:21 AM Changeset in webkit [156387] by
-
- 4 edits2 adds in trunk
:read-write pseudo-class should not be applied on <input type="text" disabled>
https://bugs.webkit.org/show_bug.cgi?id=118236
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-25
Reviewed by Darin Adler.
Source/WebCore:
The :read-write pseudo-class must match any element falling into one
of the following categories i.e
input elements to which the readonly attribute applies, and that are mutable
(i.e. that do not have the readonly attribute specified and that are not disabled)
textarea elements that do not have a readonly attribute, and that are not disabled
elements that are editing hosts or editable and are neither input elements nor
textarea elements.
Test: fast/css/readwrite-pseudoclass-input.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::matchesReadWritePseudoClass):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass):
Checking for both readonly and disabled attribute on input ane textarea element.
LayoutTests:
- fast/css/readwrite-pseudoclass-input-expected.txt: Added.
- fast/css/readwrite-pseudoclass-input.html: Added.
Added test case to verify that :read-write pseudo-class properties are
are not applied to disabled input and textarea elements.
- 4:02 AM Changeset in webkit [156386] by
-
- 9 edits in trunk
[EFL] accessibility/loading-iframe-sends-notification.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112003
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-25
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Enabled AXLayoutComplete on EFL platform.
- dom/Document.cpp:
(WebCore::Document::implicitClose):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
Tools:
Enabled addNotificationListener and removeNotificationListener for EFL port.
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::removeNotificationListener):
LayoutTests:
- platform/efl-wk1/TestExpectations: Removed loading-iframe-sends-notification.html.
- platform/efl-wk2/TestExpectations: Removed loading-iframe-sends-notification.html.
Sep 24, 2013:
- 10:38 PM Changeset in webkit [156385] by
-
- 2 edits in trunk/Source/WebKit2
Remove erroneous reference to libWTF.a in the WebKit2 Xcode project file.
Rubber-stamped by Alexey Proskuryakov.
- WebKit2.xcodeproj/project.pbxproj:
- 10:37 PM Changeset in webkit [156384] by
-
- 2 edits in trunk/Source/WebKit2
Remove the Windows-specific rules from WebKit2's DerivedSources.make, Windows is not supported anymore
https://bugs.webkit.org/show_bug.cgi?id=121895
Reviewed by Alexey Proskuryakov.
- DerivedSources.make:
Remove Windows-specific rules, and, now that only the Mac is using this file, remove the
Mac checks.
- 10:22 PM Changeset in webkit [156383] by
-
- 11 edits in trunk/Source/WebCore
Unreviewed, rolling out r156379.
http://trac.webkit.org/changeset/156379
https://bugs.webkit.org/show_bug.cgi?id=121894
Caused many assertion failures (Requested by ap on #webkit).
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/WebKitCSSArrayFunctionValue.h:
- css/WebKitCSSFilterValue.h:
- css/WebKitCSSMatFunctionValue.h:
- css/WebKitCSSMixFunctionValue.h:
- css/WebKitCSSSVGDocumentValue.h:
- css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
- css/WebKitCSSTransformValue.h:
- 8:34 PM Changeset in webkit [156382] by
-
- 3 edits2 adds in trunk
Crash in Document::setFocusedElement
https://bugs.webkit.org/show_bug.cgi?id=121888
Reviewed by Andreas Kling.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/4a594a3de7d9761462b55fb27a6850d767419af2
The crash was caused by attempting to call Chrome:focusedNodeChanged() after m_page had already
been cleared. This could happen when blur's event handler removes the iframe from which
the focus had been moved. Fixed the bug by adding a null pointer check.
Test: fast/events/blur-remove-parent-crash.html
- dom/Document.cpp:
(WebCore::Document::setFocusedElement):
LayoutTests:
- fast/events/blur-remove-parent-crash-expected.txt: Added.
- fast/events/blur-remove-parent-crash.html: Added.
- 8:09 PM Changeset in webkit [156381] by
-
- 19 edits3 deletes in trunk/Source/WebCore
Remove HTMLContentElement
https://bugs.webkit.org/show_bug.cgi?id=121891
Reviewed by Andreas Kling.
Remove an unsused Shadow DOM type.
- DerivedSources.make:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLDetailsElement.cpp:
- html/HTMLSummaryElement.cpp:
- html/HTMLTagNames.in:
- html/shadow/ContentDistributor.cpp:
- html/shadow/HTMLContentElement.cpp: Removed.
- html/shadow/HTMLContentElement.h: Removed.
- html/shadow/HTMLContentElement.idl: Removed.
- html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::matchTypeFor):
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
- 6:18 PM Changeset in webkit [156380] by
-
- 2 edits in trunk/Source/WebCore
Remove a contradiction from SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121881
Reviewed by Andreas Kling.
The matching code for PseudoHover and PseudoActive is done on the current
selector pseudo type. The current selector match type must be CSSSelector::PseudoClass
in order to reach this code. Consequently, selector->m_match == CSSSelector::Tag can
never be true.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- 6:17 PM Changeset in webkit [156379] by
-
- 11 edits in trunk/Source/WebCore
Add toWebKitCSS*Value functions to cast from CSSValue
https://bugs.webkit.org/show_bug.cgi?id=121776
Reviewed by Darin Adler.
CSS_VALUE_TYPE_CASTS can't cover WebKitCSS*Value classes. So, this patch adds toWebKitCSS*Value manually.
No new tests, no behavior change.
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/WebKitCSSArrayFunctionValue.h:
(WebCore::toWebKitCSSArrayFunctionValue):
- css/WebKitCSSFilterValue.h:
(WebCore::toWebKitCSSFilterValue):
- css/WebKitCSSMatFunctionValue.h:
(WebCore::toWebKitCSSMatFunctionValue):
- css/WebKitCSSMixFunctionValue.h:
(WebCore::toWebKitCSSMixFunctionValue):
- css/WebKitCSSSVGDocumentValue.h:
(WebCore::toWebKitCSSSVGDocumentValue):
- css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
- css/WebKitCSSTransformValue.h:
(WebCore::toWebKitCSSTransformValue):
- 6:03 PM Changeset in webkit [156378] by
-
- 4 edits in trunk/Source/WebKit2
Only allow rvalues to be passed as synchronous message replies
https://bugs.webkit.org/show_bug.cgi?id=121870
Reviewed by Andreas Kling.
This lets us get rid of a nasty const cast and is more logical.
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendSync):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::sendSync):
- 6:01 PM Changeset in webkit [156377] by
-
- 12 edits in trunk/Source/WebCore
Clean up some uses of first/lastChildSlow
https://bugs.webkit.org/show_bug.cgi?id=121882
Reviewed by Andreas Kling.
Tighten typing and use first/lastChild instead.
- dom/Position.cpp:
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
(WebCore::Position::isCandidate):
(WebCore::Position::getInlineBoxAndOffset):
- dom/Position.h:
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
- rendering/RenderBlock.cpp:
(WebCore::canMergeAnonymousBlock):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::firstLineBlock):
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
- rendering/RenderRegion.h:
- rendering/RenderRuby.cpp:
(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):
(WebCore::lastRubyRun):
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::writeCounterValuesFromChildren):
- rendering/svg/RenderSVGText.cpp:
(WebCore::findPreviousAndNextAttributes):
- style/StyleResolveTree.cpp:
(WebCore::Style::textRendererIsNeeded):
- 5:37 PM Changeset in webkit [156376] by
-
- 13 edits6 adds in trunk
op_get_callee shouldn't use value profiling
https://bugs.webkit.org/show_bug.cgi?id=121821
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Currently it's one of the two opcodes that uses m_singletonValue, which is unnecessary.
Our current plan is to remove m_singletonValue so that GenGC can have a simpler story
for handling CodeBlocks/FunctionExecutables during nursery collections.
Instead of using a ValueProfile op_get_callee now has a simple inline cache of the most
recent JSFunction that we saw.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCreateThis):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emitSlow_op_get_callee):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emitSlow_op_get_callee):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
LayoutTests:
Added two tests to make sure we didn't regress the performance of op_get_callee.
- js/regress/get_callee_monomorphic-expected.txt: Added.
- js/regress/get_callee_monomorphic.html: Added.
- js/regress/get_callee_polymorphic-expected.txt: Added.
- js/regress/get_callee_polymorphic.html: Added.
- js/regress/script-tests/get_callee_monomorphic.js: Added.
- js/regress/script-tests/get_callee_polymorphic.js: Added.
- 5:14 PM Changeset in webkit [156375] by
-
- 5 edits in trunk
initial commit
- 4:52 PM Changeset in webkit [156374] by
-
- 25 edits in trunk/Source
Change JSC debug hooks to pass a CallFrame* instead of a DebuggerCallFrame.
https://bugs.webkit.org/show_bug.cgi?id=121867.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- Removed the need for passing the line and column info to the debug hook callbacks. We now get the line and column info from the CallFrame.
- Simplify BytecodeGenerator::emitDebugHook() to only take 1 line number argument. The caller can determine whether to pass in the first or last line number of the block of source code as appropriate. Note: we still need to pass in the line and column info to emitDebugHook() because it uses this info to emit expression info which is later used by the StackVisitor to determine the line and column info for its "pc".
- Pass the exceptionValue explicitly to the exception() debug hook callback. It should not be embedded in the CallFrame / DebuggerCallFrame.
- Change the op_debug opcode size to 2 (from 5) since we've removing 3 arg values. Update the LLINT and JIT code to handle this.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
- debugger/Debugger.h:
- debugger/DebuggerCallFrame.cpp:
(JSC::LineAndColumnFunctor::operator()):
(JSC::LineAndColumnFunctor::line):
(JSC::LineAndColumnFunctor::column):
(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::clear):
- debugger/DebuggerCallFrame.h:
(JSC::DebuggerCallFrame::line):
(JSC::DebuggerCallFrame::column):
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::UnwindFunctor::UnwindFunctor):
(JSC::UnwindFunctor::operator()):
(JSC::Interpreter::unwind):
(JSC::Interpreter::debug):
- interpreter/Interpreter.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_debug):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
Source/WebCore:
No new tests.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::createCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):
- bindings/js/ScriptDebugServer.h:
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::willExecuteProgram):
- bindings/js/WorkerScriptDebugServer.h:
Source/WebKit/mac:
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame _initWithGlobalObject:debuggerCallFrame:exceptionValue:JSC::]):
(-[WebScriptCallFrame exception]):
- WebView/WebScriptDebugger.h:
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::exception):
- 4:47 PM Changeset in webkit [156373] by
-
- 3 edits in trunk/LayoutTests
webgl/conformance/extensions/oes-element-index-uint.html failing after r156351 or 156352
https://bugs.webkit.org/show_bug.cgi?id=121863
<rdar://problem/15069481>
Reviewed by Beth Dakin.
This test was not querying the vertex attribute locations
before binding data to them. When we enabled symbol mangling
we started seeing attributes appear in a different order
than the order defined in the shader source. Update this test
to ask getAttribLocation first.
Note that there are two important issues.
Firstly, this is updating our local copy of the Khronos test.
I've opened pull request #377 to get it addressed in the source.
https://github.com/KhronosGroup/WebGL/pull/377
Secondly, this indicates that we might have a lot of problems
with existing content that does not expect the order of
attributes to change.
- webgl/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html:
- TestExpectations: Unskip test.
- 4:39 PM Changeset in webkit [156372] by
-
- 9 edits in trunk/Source/WebCore
Move keyboard event dispatch from Node to Element.
<https://webkit.org/b/121873>
Reviewed by Antti Koivisto.
We only dispatch keyboard events on Elements so that logic shouldn't be in Node.
- dom/Document.cpp:
(WebCore::eventTargetElementForDocument):
Reworked to return Element instead of Node.
- dom/Document.h:
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::dispatchKeyEvent):
Moved from Node to Element.
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::insertDictatedText):
- page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):
Adjusted for above changes.
- 4:27 PM Changeset in webkit [156371] by
-
- 7 edits6 adds in trunk
Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
https://bugs.webkit.org/show_bug.cgi?id=121844
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Fix some int52 bugs that caused this.
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext): There's no such thing as int53.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::spill): Actually spill int52's, instead of hitting an assert and crashing.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal): Use the right format (from before when we clobber it).
Tools:
Reviewed by Mark Hahnenberg.
- Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
LayoutTests:
Reviewed by Mark Hahnenberg.
- js/dfg-int52-spill-expected.txt: Added.
- js/dfg-int52-spill-trickier-expected.txt: Added.
- js/dfg-int52-spill-trickier.html: Added.
- js/dfg-int52-spill.html: Added.
- js/script-tests/dfg-int52-spill-trickier.js: Added.
(foo):
- js/script-tests/dfg-int52-spill.js: Added.
(foo):
- 4:18 PM Changeset in webkit [156370] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: compositing/reflections/load-video-in-reflection.html
https://bugs.webkit.org/show_bug.cgi?id=117427
- platform/mac/TestExpectations: Marking the test accordingly.
- 4:00 PM Changeset in webkit [156369] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed buildfix.
- UIProcess/WebNetworkInfoManagerProxy.h:
- 3:57 PM Changeset in webkit [156368] by
-
- 2 edits in trunk/Source/WebKit2
Fix Mac build now.
- UIProcess/WebContext.messages.in:
- 3:45 PM Changeset in webkit [156367] by
-
- 2 edits in trunk/LayoutTests
SVG Animations are flaky
https://bugs.webkit.org/show_bug.cgi?id=107018
- platform/mac-wk2/TestExpectations: Marked some frequently failing tests
- 3:40 PM Changeset in webkit [156366] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed buildfix after r156350.
- UIProcess/WebContext.messages.in:
- 3:35 PM Changeset in webkit [156365] by
-
- 2 edits in trunk/Tools
[Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
https://bugs.webkit.org/show_bug.cgi?id=121854
Reviewed by Anders Carlsson.
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize): Post a notification to update cached
settings in underlying frameworks.
- 3:24 PM Changeset in webkit [156364] by
-
- 5 edits2 adds in trunk
[CSS Shapes] Modify updateSegmentsForShapes function to use logical coordinates
https://bugs.webkit.org/show_bug.cgi?id=121864
Reviewed by David Hyatt.
When I landed updateSegmentsForShapes in r156022, I didn't use logical coordinates. This change modifies the
code to use coordinates for positioning the float and the content around the float in a shape-inside. Now I
added only one writing mode tests, but I will add more later in bug #121866.
Source/WebCore:
Test: fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html
- rendering/FloatingObjects.h:
(WebCore::FloatingObject::logicalHeight):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::updateSegmentsForShapes):
LayoutTests:
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html: Added.
- 3:18 PM Changeset in webkit [156363] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed buildfix after r156354 and r156360.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):
- 3:09 PM Changeset in webkit [156362] by
-
- 3 edits in trunk/LayoutTests
Flaky Test: fast/history/history-subframe-with-name.html
https://bugs.webkit.org/show_bug.cgi?id=51039
Reviewed by Anders Carlsson.
Speculative fix, I could not reproduce locally.
- fast/history/resources/history-subframe-with-name-container.html: Added a check
that onunload trick worked.
- fast/history/resources/history-subframe-with-name-2.html: Starting the navigation
used to race with loading another iframe in the parent. Wait until the parent loads.
- 2:51 PM Changeset in webkit [156361] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed buildfix after r156349.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):
- 2:46 PM Changeset in webkit [156360] by
-
- 5 edits in trunk/Source/WebKit2
Use std::unique_ptr for decoders as well
https://bugs.webkit.org/show_bug.cgi?id=121868
Reviewed by Andreas Kling.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::waitForSyncReply):
(CoreIPC::Connection::processIncomingSyncReply):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::enqueueIncomingMessage):
(CoreIPC::Connection::dispatchMessage):
(CoreIPC::Connection::dispatchOneMessage):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::sendSync):
(CoreIPC::Connection::waitForAndDispatchImmediately):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::createMessageDecoder):
(CoreIPC::Connection::receiveSourceEventHandler):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postSynchronousMessage):
- 2:25 PM Changeset in webkit [156359] by
-
- 2 edits in trunk/Source/WebCore
Remove IDBTransactionCallbacks.h from the .xcodeproj, as it's gone from the repository.
Rubberstamped by Anders Carlsson and Alexey Proskuryakov.
- WebCore.xcodeproj/project.pbxproj:
- 2:23 PM Changeset in webkit [156358] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Using Breakpoint Actions Breaks iOS inspection
https://bugs.webkit.org/show_bug.cgi?id=121862
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-24
Reviewed by Timothy Hatcher.
Only use DebuggerAgent.BreakpointActionType if it is available.
Otherwise leave options undefined for breakpoints since the backend
does not support it.
- UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype._setBreakpoint):
- 2:19 PM Changeset in webkit [156357] by
-
- 1 edit3 adds in trunk/Source/WebInspectorUI
Web Inspector: Include iOS 7 Inspector.json Version
https://bugs.webkit.org/show_bug.cgi?id=121852
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-24
Reviewed by Timothy Hatcher.
- UserInterface/Legacy/7.0/InspectorBackendCommands.js: Added.
- Versions/Inspector-iOS-7.0.json: Added.
- 1:50 PM Changeset in webkit [156356] by
-
- 2 edits in trunk/LayoutTests
webgl/conformance/extensions/oes-element-index-uint.html failing after r156351 or 156352
https://bugs.webkit.org/show_bug.cgi?id=121863
<rdar://problem/15069481>
Temporarily skipped while investigating.
- 1:47 PM Changeset in webkit [156355] by
-
- 9 edits in trunk/Source/WebCore
Tighten table rendering code
https://bugs.webkit.org/show_bug.cgi?id=121860
Reviewed by Andreas Kling.
Hide firstChild/lastChild/nextSibling/previousSibling in table renderers,
expose correctly typed firstRow/nextCell etc instead.
- 1:41 PM Changeset in webkit [156354] by
-
- 48 edits in trunk/Source/WebKit2
Move MessageEncoder and ArgumentEncoder to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=121861
Reviewed by Andreas Kling.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkProcess.h:
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendSyncReply):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::sendOutgoingMessages):
(CoreIPC::Connection::dispatchSyncMessage):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessageDelayed):
- Platform/CoreIPC/MessageReceiver.h:
(CoreIPC::MessageReceiver::didReceiveSyncMessage):
- Platform/CoreIPC/MessageReceiverMap.cpp:
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):
- Platform/CoreIPC/MessageReceiverMap.h:
- Platform/CoreIPC/MessageSender.cpp:
(CoreIPC::MessageSender::sendMessage):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- PluginProcess/WebProcessConnection.h:
- Scripts/webkit2/messages.py:
(message_to_struct_declaration):
(generate_message_handler):
- Scripts/webkit2/messages_unittest.py:
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::dispatchSyncMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
- Shared/Plugins/NPObjectMessageReceiver.h:
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
- Shared/Plugins/NPRemoteObjectMap.h:
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveSyncMessage):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Storage/StorageManager.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::dispatchSyncMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
- UIProcess/WebFullScreenManagerProxy.h:
- UIProcess/WebIconDatabase.h:
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
- WebProcess/Plugins/PluginProcessConnection.h:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveSyncMessage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
- WebProcess/WebProcess.h:
- 12:59 PM Changeset in webkit [156353] by
-
- 17 edits in trunk/Source
Remove encoder create functions
https://bugs.webkit.org/show_bug.cgi?id=121853
Reviewed by Sam Weinig.
Source/WebKit2:
- Platform/CoreIPC/ArgumentEncoder.cpp:
- Platform/CoreIPC/ArgumentEncoder.h:
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::dispatchSyncMessage):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
- Platform/CoreIPC/MessageEncoder.cpp:
(CoreIPC::MessageEncoder::setIsSyncMessage):
- Platform/CoreIPC/MessageEncoder.h:
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::postMessageToInjectedBundle):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
- WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::EncoderAdapter):
(WebKit::EncoderAdapter::dataReference):
(WebKit::EncoderAdapter::encodeBytes):
(WebKit::EncoderAdapter::encodeBool):
(WebKit::EncoderAdapter::encodeUInt16):
(WebKit::EncoderAdapter::encodeUInt32):
(WebKit::EncoderAdapter::encodeUInt64):
(WebKit::EncoderAdapter::encodeInt32):
(WebKit::EncoderAdapter::encodeInt64):
(WebKit::EncoderAdapter::encodeFloat):
(WebKit::EncoderAdapter::encodeDouble):
(WebKit::EncoderAdapter::encodeString):
- WebProcess/WebPage/EncoderAdapter.h:
Source/WTF:
Add a variadic version of createOwned.
- wtf/OwnPtr.h:
(WTF::createOwned):
- 12:43 PM Changeset in webkit [156352] by
-
- 3 edits in trunk/Source/WebCore
Implement symbol name hashing for WebGL shaders
https://bugs.webkit.org/show_bug.cgi?id=121849
Reviewed by Anders Carlsson.
Turn on ANGLE's symbol name mapping for shader programs.
This avoids compilation failures (or worse, crashers)
on some hardware that doesn't like it when shaders redefine
symbols like "sin", even though that is valid.
The way ANGLE exposes this is via setting a pointer
to a char* -> uint64_t hash function. Since we only have
a 32-bit hash in WebKit, I combine the 32-bit value with
a counter value that exists over the lifetime of a GC3D context.
Before calling ANGLE, I point the global hash map to the local
hash map, and then clean up after we're done. This introduces
a memory hit, in that the symbol table will build up until
the context is released.
Covered by Khronos WebGL tests, including
conformance/glsl/misc/shader-with-non-reserved-words.html
- platform/graphics/GraphicsContext3D.h: Define a ShaderNameHash type,
and add an OwnPtr to one as a member variable.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::nameHashForShader): Global function used for ANGLE hashing.
(WebCore::GraphicsContext3D::compileShader): Set up the ANGLE properties,
point to the local hash map, and call compile/translate.
- 12:43 PM Changeset in webkit [156351] by
-
- 4 edits2 adds in trunk
Use mapped name in attribute location binding
https://bugs.webkit.org/show_bug.cgi?id=121847
<rdar://problem/15067526>
Reviewed by Eric Carlson.
Source/WebCore:
The shader that we send down to OpenGL to compile
may have been translated by ANGLE, so we keep a
table around that maps input symbols to output symbols.
We used the table when binding to and looking up
uniforms, and when looking up attributes, but not
when actually binding to attribute locations.
Test: fast/canvas/webgl/gl-bind-attrib-mapped-names.html
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::getSymbolInfo): Add logging of symbol mapping.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::bindAttribLocation): Used the mapped name.
(WebCore::GraphicsContext3D::getAttribLocation): Remove comment since
we do the lookup everywhere.
(WebCore::GraphicsContext3D::getUniformLocation): Ditto.
LayoutTests:
New test that has an attribute name long enough
to trigger symbol mapping in all cases.
- fast/canvas/webgl/gl-bind-attrib-mapped-names-expected.txt: Added.
- fast/canvas/webgl/gl-bind-attrib-mapped-names.html: Added.
- 12:35 PM Changeset in webkit [156350] by
-
- 20 edits1 add in trunk/Source
Upstream changes to Pasteboard implementation for iOS.
https://bugs.webkit.org/show_bug.cgi?id=121818
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp:
(WebCore::Editor::cut):
(WebCore::Editor::copyImage):
- editing/ios/EditorIOS.mm:
(WebCore::attributedStringForRange):
(WebCore::dataInRTFDFormat):
(WebCore::dataInRTFFormat):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
(WebCore::Editor::selectionInWebArchiveFormat):
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::getImage):
(WebCore::Editor::writeImageToPasteboard):
- platform/Pasteboard.h:
- platform/PasteboardStrategy.h:
- platform/PlatformPasteboard.h:
- platform/ios/PasteboardIOS.mm:
- platform/ios/PlatformPasteboardIOS.mm: Added.
(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::getTypes):
(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::getPathnamesForType):
(WebCore::PlatformPasteboard::stringForType):
(WebCore::PlatformPasteboard::color):
(WebCore::PlatformPasteboard::url):
(WebCore::PlatformPasteboard::copy):
(WebCore::PlatformPasteboard::addTypes):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setBufferForType):
(WebCore::PlatformPasteboard::setPathnamesForType):
(WebCore::PlatformPasteboard::setStringForType):
(WebCore::PlatformPasteboard::changeCount):
(WebCore::PlatformPasteboard::uniqueName):
(WebCore::PlatformPasteboard::write):
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::writeToPasteboard):
Source/WebKit2:
- Scripts/webkit2/messages.py:
(struct_or_class):
(headers_for_type):
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::encodeSharedBuffer):
(CoreIPC::decodeSharedBuffer):
(CoreIPC::::encode):
(CoreIPC::::decode):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/WebContext.h:
- UIProcess/WebContext.messages.in:
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::writeWebContentToPasteboard):
(WebKit::WebContext::writeImageToPasteboard):
(WebKit::WebContext::writeStringToPasteboard):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::writeToPasteboard):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 12:23 PM Changeset in webkit [156349] by
-
- 9 edits in trunk/Source/WebKit2
Remove create functions from MessageDecoder and ArgumentDecoder
https://bugs.webkit.org/show_bug.cgi?id=121850
Reviewed by Antti Koivisto.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::ArgumentDecoder):
- Platform/CoreIPC/ArgumentDecoder.h:
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::MessageDecoder):
- Platform/CoreIPC/MessageDecoder.h:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::createMessageDecoder):
- WebProcess/WebPage/DecoderAdapter.cpp:
(WebKit::DecoderAdapter::DecoderAdapter):
(WebKit::DecoderAdapter::decodeBytes):
(WebKit::DecoderAdapter::decodeBool):
(WebKit::DecoderAdapter::decodeUInt16):
(WebKit::DecoderAdapter::decodeUInt32):
(WebKit::DecoderAdapter::decodeUInt64):
(WebKit::DecoderAdapter::decodeInt32):
(WebKit::DecoderAdapter::decodeInt64):
(WebKit::DecoderAdapter::decodeFloat):
(WebKit::DecoderAdapter::decodeDouble):
(WebKit::DecoderAdapter::decodeString):
- WebProcess/WebPage/DecoderAdapter.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::postInjectedBundleMessage):
- 12:18 PM Changeset in webkit [156348] by
-
- 20 edits in trunk
<rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- WebKitLauncher/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- 12:14 PM Changeset in webkit [156347] by
-
- 10 edits in trunk/Source/WebCore
[iOS] Upstream -webkit-touch-callout
https://bugs.webkit.org/show_bug.cgi?id=121507
Reviewed by Antti Koivisto.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in: Added -webkit-touch-callout.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::willRespondToMouseClickEvents): Added.
- html/HTMLImageElement.h:
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
- 12:02 PM Changeset in webkit [156346] by
-
- 8 edits5 adds in trunk
Properly handle bottom margin on float with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=121808
Reviewed by David Hyatt.
Source/WebCore:
When a float has a shape-outside, inline content must conform to the
shape, not to the margin box. Thus, if a float with shape-outside has
a bottom margin and the shape does not intrude into that margin, then
the inline content should ignore the margin. Before this patch, inline
content would drop below the margin box instead of obeying the shape.
Note that content that should clear the float still clears the margin
box, not the shape's contour.
Tests: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html
- rendering/LineWidth.cpp:
(WebCore::LineWidth::fitBelowFloats): Compute the logical bottom based
on the shape.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nextFloatLogicalBottomBelow): Add option to
compute the logical bottom based on the shape instead of on the margin
box.
- rendering/RenderBlock.h:
LayoutTests:
Import new tests for floats wish shape-outside and bottom margins.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/rounded-rectangle.js: Remove whitespace at ends of lines.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 11:58 AM Changeset in webkit [156345] by
-
- 9 edits in trunk/Source
[GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE
https://bugs.webkit.org/show_bug.cgi?id=121782
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-09-24
Reviewed by Martin Robinson.
Disabled drag functions.
Source/WebCore:
- page/gtk/EventHandlerGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
Source/WebKit/gtk:
- WebCoreSupport/DragClientGtk.cpp:
- WebCoreSupport/DragClientGtk.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_class_init):
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
- 11:42 AM Changeset in webkit [156344] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Unreviewed crash fix after r156321.
Fix a few mistakes in the use of Vectors and counting that introduced test crashes.
- WebHistory.cpp:
(WebHistory::removeAllItems): Loop termination tried to test an unsigned for negative size.
(WebHistory::removeItemFromDateCaches): Vector was being created with empty entries.
(WebHistory::addItemToDateCaches): Ditto.
- 11:38 AM Changeset in webkit [156343] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merged r156315. <rdar://problem/15063134>
- 11:20 AM Changeset in webkit [156342] by
-
- 1 edit in branches/safari-537.60-branch/Source/WebCore/rendering/RenderLayer.cpp
build fix.
- 11:16 AM Changeset in webkit [156341] by
-
- 3 edits in trunk/Source/WebKit2
Begin adopting std::tuple for IPC decoding
https://bugs.webkit.org/show_bug.cgi?id=121848
Reviewed by Sam Weinig.
This is the first step towards getting rid of the horrible Arguments class hierarchy.
- Platform/CoreIPC/Arguments.h:
(CoreIPC::TupleCoder::encode):
(CoreIPC::TupleCoder::decode):
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessage):
(CoreIPC::handleMessageVariadic):
(CoreIPC::handleMessageDelayed):
- 11:11 AM Changeset in webkit [156340] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Breakpoint Actions input should disable spellchecking
https://bugs.webkit.org/show_bug.cgi?id=121846
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-24
Reviewed by Timothy Hatcher.
- UserInterface/BreakpointActionView.js:
- 10:57 AM Changeset in webkit [156339] by
-
- 15 edits in trunk/Source/WebCore
AX: Replace AXObjectCache postNotification method boolean arguments with enum values.
https://bugs.webkit.org/show_bug.cgi?id=121504
Patch by Samuel White <Samuel White> on 2013-09-24
Reviewed by Chris Fleizach.
No new tests, no functional changes. Changed argument type from bool
to enum per "Names" rule #10 in the WebKit coding style guidelines.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::textChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::postNotification):
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::didUpdateActiveOption):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::childrenChanged):
(WebCore::AccessibilityNodeObject::changeValueByStep):
(WebCore::AccessibilityNodeObject::changeValueByPercent):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::textChanged):
- dom/Document.cpp:
(WebCore::Document::implicitClose):
- editing/Editor.cpp:
(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):
- editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
- html/InputType.cpp:
(WebCore::InputType::applyStep):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
- page/FocusController.cpp:
(WebCore::FocusController::setInitialFocus):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- 10:51 AM Changeset in webkit [156338] by
-
- 8 edits in trunk/Source/WebCore
Make hoverAncestor() a RenderElement concept.
<https://webkit.org/b/121845>
Reviewed by Antti Koivisto.
The hover ancestor renderer is always a RenderElement, we only ever
ask RenderElements for their hover ancestors.
Updated Document::updateHoverActiveState() to take advantage of the
tighter typing, removing a few isElementNode() checks.
- 10:12 AM Changeset in webkit [156337] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Initialize settings mediaPlayback{AllowsInline, RequiresUserGesture} and
shouldRespectImageOrientation as appropriate
https://bugs.webkit.org/show_bug.cgi?id=121792
Reviewed by Darin Adler.
On iOS we explicitly want to disable mediaPlaybackAllowsInline, and enable
mediaPlaybackRequiresUserGesture and shouldRespectImageOrientation by default.
This differs from other platforms. We need to extract the initialization logic
for these settings into constants whose definition is conditioned on the platform.
- page/Settings.cpp:
- page/Settings.in:
- 9:45 AM Changeset in webkit [156336] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=121839
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-24
Reviewed by Brent Fulgham.
- platform/graphics/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate): Added missing guard.
- 9:22 AM Changeset in webkit [156335] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merge patch for <rdar://problem/15056974>. Build fix after r156221.
- 9:20 AM Changeset in webkit [156334] by
-
- 4 edits in trunk/Source/WebCore
Cache continuation() in a local to avoid repeat hash lookups.
<https://webkit.org/b/121840>
Reviewed by Geoffrey Garen.
RenderBoxModelObject::continuation() does a hash lookup every time.
Cache the result in a local instead of calling it repeatedly.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::isAnonymousBlockContinuation):
Reorder to check bitfield before hash map.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateDragState):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::updateDragState):
(WebCore::RenderInline::addFocusRingRects):
Cache continuation() in locals where it's used more than once.
- 7:25 AM Changeset in webkit [156333] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Build failed at ProcessLauncherEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=121826
Reviewed by Gyuyoung Kim.
Fixed a build failure with adding socket.h.
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
- 7:24 AM Changeset in webkit [156332] by
-
- 5 edits in trunk
[ATK] Missing WTR AccessibilityController::addNotificationListener implementation
https://bugs.webkit.org/show_bug.cgi?id=121674
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-24
Reviewed by Mario Sanchez Prada.
Tools:
Implemented the global notification listener for
AccessibilityController. The signal is generated by
AXObjectCache::postPlatformNotification() and received by
axObjectEventListener(). axObjectEventListener will then invoke
JSObjectCallAsFunction() with the respective callback function.
There is no additional test for this patch since its implementation will
be tested by an accessibility layout test that is currently failing
(accessibility/loading-iframe-sends-notification.html).
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
stub implementations of addNotificationListener and
removeNotificationListener for the GTK port.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::addNotificationListener): Creates the
notification handler and sets the notification function callback.
(WTR::AccessibilityController::removeNotificationListener): Removes the
global handler.
LayoutTests:
Updated the expectation of loading-iframe-sends-notification.html test,
which was failing before this fix.
- platform/gtk-wk2/TestExpectations: Removed
loading-iframe-sends-notification.html because it now passes with this
fix.
- 7:18 AM Changeset in webkit [156331] by
-
- 4 edits in trunk
[GTK] fast/images/exif-orientation-composited.html is failing
https://bugs.webkit.org/show_bug.cgi?id=119731
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-09-24
Reviewed by Carlos Garcia Campos.
Tools:
Add handling respect image orientation property in DRT.
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::overridePreference):
LayoutTests:
Unskip fast/images/exif-orientation-composited.html for GTK WK1 and WK2.
- platform/gtk/TestExpectations:
- 7:16 AM Changeset in webkit [156330] by
-
- 6 edits in trunk
[Qt] Crash when trying to download blob url
https://bugs.webkit.org/show_bug.cgi?id=121681
Reviewed by Simon Hausmann.
Source/WebCore:
Resolve any blob URLs before creating a QUrl.
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::appendBlobResolved):
(WebCore::resolveBlobUrl):
(WebCore::ResourceRequest::toNetworkRequest):
Source/WebKit/qt:
Do not crash if a download was triggered on a resource WebCore handles internally.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::convertMainResourceLoadToDownload):
LayoutTests:
Unskip two tests that downloads blob URLs. Note the two tests do not use the download attribute feature.
- platform/qt/TestExpectations:
- 7:10 AM Changeset in webkit [156329] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] RepaintRequested signal sometimes not emitted
https://bugs.webkit.org/show_bug.cgi?id=121790
Reviewed by Simon Hausmann.
We should also emit repaintRequested after calling PageClient::update().
- WidgetSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::repaintViewport):
(WebCore::PageClientQGraphicsWidget::repaintViewport):
- 6:14 AM Changeset in webkit [156328] by
-
- 4 edits in trunk
[GTK] Enable the Wayland target if GTK+ dependency is found
https://bugs.webkit.org/show_bug.cgi?id=121704
Reviewed by Gustavo Noronha Silva.
The Wayland target should be enabled by default if the GTK+ dependency is of version 3.9.14 or later.
- Source/autotools/FindDependencies.m4: If the Wayland target was not strictly disabled, the GTK+ dependency
is tested if it can provide the Wayland GDK backend, and that the version of that backend matches the version
of the master GTK+ dependency for which we already tested. If found, the target is enabled, otherwise we either
warn or error out, depending on whether the build target was set to auto or completely disabled through configuration.
- Source/autotools/ReadCommandLineArguments.m4: Switch the default Wayland target status to 'auto', meaning
it will be disabled if the GTK+ dependency is not found.
- Source/autotools/Versions.m4: Require GTK+ 3.9.14 for the Wayland target only.
- 6:09 AM Changeset in webkit [156327] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Fix accelerated compositing disabling under Wayland displays
https://bugs.webkit.org/show_bug.cgi?id=121788
Reviewed by Gustavo Noronha Silva.
- webkit/webkitwebview.cpp:
(updateAcceleratedCompositingSetting): Fix a ridiculous early return in the case of disabling the accelerated
compositing setting. There's no need to re-disable the setting if it was already disabled, but it should
definitely be disabled if the setting was previously enabled.
- 6:08 AM Changeset in webkit [156326] by
-
- 2 edits in trunk/Tools
[GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=121787
Reviewed by Gustavo Noronha Silva.
- gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
with the Wayland target enabled to version 3.10.0.
- 5:22 AM Changeset in webkit [156325] by
-
- 7 edits in trunk/Source/WebCore
Move more style change code from RenderObject to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121822
Reviewed by Darin Adler.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::~RenderElement):
RenderTexts are no longer registered as image clients. They don't need be unregistered either.
(WebCore::RenderElement::adjustStyleDifference):
(WebCore::RenderElement::hasImmediateNonWhitespaceTextChild):
(WebCore::RenderElement::shouldRepaintForStyleDifference):
(WebCore::RenderElement::updateFillImages):
(WebCore::RenderElement::updateImage):
(WebCore::RenderElement::updateShapeImage):
(WebCore::RenderElement::setStyle):
Move from RenderObject and remove the text specific bits.
- rendering/RenderElement.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::arenaDelete):
- rendering/RenderObject.h:
Remove styleWill/DidChange which move to subclasses.
- rendering/RenderText.cpp:
(WebCore::RenderText::setStyle):
Add simple text specific setStyle.
- rendering/RenderText.h:
- 3:41 AM WebKitGTK/2.2.x edited by
- Strike out a merged proposal. (diff)
- 3:36 AM Changeset in webkit [156324] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk
Merge r156261 - Unreviewed, GTK build fix when building with GTK+ 2.0.
Patch provided by Dominique Leuenberger <dimstar@opensuse.org>.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp: Include GtkVersioning.h to set up
the mock GDK_IS_X11_DISPLAY macro if it's not provided by the GTK+ headers.
- 3:25 AM Changeset in webkit [156323] by
-
- 1 edit in releases/WebKitGTK/webkit-2.2/Source/autotools/Versions.m4
Bump the GTK+ Wayland dependency to 3.10.0 for the forthcoming 2.2 release.
- 12:47 AM Changeset in webkit [156322] by
-
- 15 edits in trunk
[CSS Background] repeat: round should round the number of tiles to the nearest natural number
https://bugs.webkit.org/show_bug.cgi?id=120668
Source/WebCore:
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-24
Reviewed by Darin Adler.
Tests already available in css3/masking and css3/background
- rendering/RenderBoxModelObject.cpp: Rounded the number of tiles to the nearest natural number.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
LayoutTests:
Changed the sizes of the images/masks in the tests to be compliant with the new behaviour.
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-24
Reviewed by Darin Adler.
- css3/background/background-repeat-round-auto1-expected.html:
- css3/background/background-repeat-round-auto2-expected.html:
- css3/background/background-repeat-round-border-expected.html:
- css3/background/background-repeat-round-content-expected.html:
- css3/background/background-repeat-round-padding-expected.html:
- css3/background/background-repeat-round-padding.html:
- css3/masking/mask-repeat-round-auto1-expected.html:
- css3/masking/mask-repeat-round-auto2-expected.html:
- css3/masking/mask-repeat-round-border-expected.html:
- css3/masking/mask-repeat-round-content-expected.html:
- css3/masking/mask-repeat-round-padding-expected.html:
- css3/masking/mask-repeat-round-padding.html:
- 12:33 AM Changeset in webkit [156321] by
-
- 3 edits in trunk/Source/WebKit/win
Make WebHistory more type safe
https://bugs.webkit.org/show_bug.cgi?id=121801
Reviewed by Brent Fulgham.
Use a WTF::Vector instead of a CFMutableArray to avoid
casting from void* all the time when accessing the entries.
This reduces the dependencies on CoreFoundation too.
- WebHistory.cpp:
(getDayBoundaries):
(beginningOfDay):
(dateKey):
(WebHistory::orderedItemsLastVisitedOnDay):
(WebHistory::removeItemFromDateCaches):
(WebHistory::addItemToDateCaches):
- WebHistory.h:
- 12:30 AM Changeset in webkit [156320] by
-
- 4 edits1 delete in trunk/Source/WebCore
Remove ScrollView::platformInit() and ScrollView::platformDestroy()
https://bugs.webkit.org/show_bug.cgi?id=121824
Reviewed by Darin Adler.
ScrollView::platformInit() and ScrollView::platformDestroy() are just
empty functions for all ports after removed WX port at r149186.
- PlatformEfl.cmake: Removed ScrollViewEfl.cpp from source list.
- platform/ScrollView.cpp: Removed platformInit and PlatformDestroy.
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::~ScrollView):
- platform/ScrollView.h: Ditto.
- platform/efl/ScrollViewEfl.cpp: Removed.
Sep 23, 2013:
- 10:53 PM Changeset in webkit [156319] by
-
- 8 edits in trunk/Source/WebCore
Use unique_ptr instead of deleteAllValues in FloatingObject code
https://bugs.webkit.org/show_bug.cgi?id=121823
Reviewed by Sam Weinig.
- rendering/FloatingObjects.cpp:
(WebCore::FloatingObject::create): Return a unique_ptr instead of PassOwnPtr.
Use auto and a word for the local variable instead of an abbreviation. Also
changed to take a reference instead of a pointer.
(WebCore::FloatingObject::copyToNewContainer): Ditto.
(WebCore::FloatingObject::unsafeClone): Ditto.
(WebCore::FloatingObjects::~FloatingObjects): Removed call to deleteAllValues.
(WebCore::FloatingObjects::clearLineBoxTreePointers): Use auto to make this
read clearly.
(WebCore::FloatingObjects::clear): Removed call to deleteAllValues.
(WebCore::FloatingObjects::moveAllToFloatInfoMap): Use std::move to move values
out of the set, into the map. Removed code to clear the set, since it was a
trick to prevent the values from being deleted when they were not moved.
(WebCore::FloatingObjects::add): Changed to take a unique_ptr and to move the
pointer into the set instead of using leakPtr.
(WebCore::FloatingObjects::remove): Rearranged code so that the remove is at
the end of the function rather than the beginning. Also had to use a hash
translator and a find/remove combo since we don't have hash translator version
of the remove function.
(WebCore::FloatingObjects::computePlacedFloatsTree): Updated for changes to
the types.
(WebCore::FloatingObjects::placedFloatsTree): Moved this function here instead
of having it in the header, since it's only used within the file.
- rendering/FloatingObjects.h: Changed functions to take references instead
of pointers and return unique_ptr instead of PassOwnPtr. Also made
constructors public so we can use them with make_unique. Changed types to
use unique_ptr instead of raw pointers, and made the FloatingObjectHashTranslator
work for both RenderBox& and FloatingObject&.
- rendering/LineWidth.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
Updated for changes to types.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::containsFloat):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::updateLocalFloatingObjectsForPaintingContainer):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
Updated for changes to types.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::clearFloats): Updated to use take instead of
a combination of remove and delete.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):
Updated for changes to types.
- 9:00 PM Changeset in webkit [156318] by
-
- 7 edits10 adds in trunk
CSS Unit vh, vw, vmin and vmax in box-shadow are not applied.
https://bugs.webkit.org/show_bug.cgi?id=121422
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-23
Reviewed by Darin Adler.
Source/WebCore:
Box-shadow properties were not applied incase its values
were given in vh, vw, vmax, vmin unit.
Tests: fast/css/box-shadow-negative-viewportlength.html
fast/css/box-shadow-viewport-height.html
fast/css/box-shadow-viewport-vmax.html
fast/css/box-shadow-viewport-vmin.html
fast/css/box-shadow-viewport-width.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseShadow):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::MatchedProperties::~MatchedProperties):
(WebCore::StyleResolver::viewportPercentageHeight):
(WebCore::StyleResolver::viewportPercentageWidth):
(WebCore::StyleResolver::viewportPercentageMax):
(WebCore::StyleResolver::viewportPercentageMin):
- css/StyleResolver.h:
Parsing and calculating the shadow values which has been specified
in viewport units.The vh/vw units are calcultated as percent of
viewport height and viewport width respectively. 1vmax: 1vw or 1vh,
whatever is largest.1vmin: 1vw or 1vh, whatever is smallest.
LayoutTests:
- fast/css/box-shadow-negative-viewportlength-expected-mismatch.html: Added.
- fast/css/box-shadow-negative-viewportlength.html: Added.
- fast/css/box-shadow-viewport-height-expected-mismatch.html: Added.
- fast/css/box-shadow-viewport-height.html: Added.
- fast/css/box-shadow-viewport-vmax-expected-mismatch.html: Added.
- fast/css/box-shadow-viewport-vmax.html: Added.
- fast/css/box-shadow-viewport-vmin-expected-mismatch.html: Added.
- fast/css/box-shadow-viewport-vmin.html: Added.
- fast/css/box-shadow-viewport-width-expected-mismatch.html: Added.
- fast/css/box-shadow-viewport-width.html: Added.
Added new tests for verifying that box-shadow properties are
applied when its values are viewport units.
- fast/css/shadow-viewport-units-expected.txt:
- fast/css/shadow-viewport-units.html:
Rebaselining existing tests as per the new behavior. Support for shadow
properties with viewport units is added so modified the test case.
- 7:48 PM Changeset in webkit [156317] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for CMake ports with INDEXED_DATABASE after r156296
- CMakeLists.txt: Removed IDBBackingStore.cpp from source list.
- 7:09 PM Changeset in webkit [156316] by
-
- 7 edits in trunk/Source
Remove WTF_USE_SCROLLBAR_PAINTER #define
https://bugs.webkit.org/show_bug.cgi?id=121819
Reviewed by Sam Weinig.
Source/WebCore:
Remove unnecessary if checks and dead code.
- platform/mac/NSScrollerImpDetails.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::finishCurrentScrollAnimations):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::shouldScrollbarParticipateInHitTesting):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
- platform/mac/ScrollViewMac.mm:
(WebCore::toNSScrollerKnobStyle):
(WebCore::ScrollView::platformSetScrollbarOverlayStyle):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbarsChanged):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::ScrollbarThemeMac::paint):
Source/WTF:
All our supported systems use the scrollbar painter now, so get rid of the #ifdef.
- wtf/Platform.h:
- 6:56 PM Changeset in webkit [156315] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Moving back in history from a page with <video>, then moving forward causes crash.
https://bugs.webkit.org/show_bug.cgi?id=120475
Reviewed by Anders Carlsson.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::AVFWrapper): Add assertion that creation is on main thread.
(WebCore::AVFWrapper::~AVFWrapper): Add assertion that destruction is on main thread.
(WebCore::destroyAVFWrapper): Helper function to dispatch on main queue.
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Spawn AVFoundationCF destruction to
main queue.
- 6:44 PM Changeset in webkit [156314] by
-
- 3 edits in trunk/Source/WebCore
RenderTextControlSingleLine::updateFromElement() override not needed.
<https://webkit.org/b/121815>
Reviewed by Anders Carlsson.
- rendering/RenderTextControlSingleLine.cpp:
- rendering/RenderTextControlSingleLine.h:
- 5:57 PM Changeset in webkit [156313] by
-
- 8 edits in trunk/Source/WebCore
Introduce CSS_VALUE_TYPE_CASTS macro in order to cast CSSValue type
https://bugs.webkit.org/show_bug.cgi?id=121462
Reviewed by Darin Adler.
As r155429 introduced ELEMENT_TYPE_CASTS, CSS_VALUE_TYPE_CASTS can be used
by css value type casting as well. This type cast macros will help to detect
bad-cast bugs as well as improve a code readibility.
This patch adds the following methods,
- CSSFooValue* toCSSFooValue(CSSValue*)
- const CSSFooValue* toCSSFooValue(const CSSValue*)
This patch support CSSImageSetValue and CSSReflectValue first. Other CSS*Values
will use this macro step by step.
Besides this patch will remove unnecessary local variables.
No new tests, no behavior change.
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
- css/CSSImageSetValue.h:
- css/CSSReflectValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
- css/StyleResolver.cpp:
(WebCore::hasVariableReference):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssImageSetValue):
- 5:55 PM Changeset in webkit [156312] by
-
- 10 edits in trunk/Source/WebCore
Move style change analysis code to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121812
Reviewed by Andreas Kling.
Text renderers don't need this. There is no text renderer specific invalidation and text
style never changes independent from the containing RenderElement.
- 5:51 PM Changeset in webkit [156311] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r156307.
http://trac.webkit.org/changeset/156307
https://bugs.webkit.org/show_bug.cgi?id=121817
Broke the build, and crashes the compiler (Requested by ap on
#webkit).
Source/WebCore:
- css/MediaQuery.cpp:
(WebCore::expressionCompare):
(WebCore::MediaQuery::MediaQuery):
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::ObserverLessThan::operator()):
(WebCore::MutationObserver::deliverAllMutations):
- page/CaptionUserPreferences.cpp:
(WebCore::textTrackCompare):
(WebCore::CaptionUserPreferences::sortedTrackListForMenu):
Source/WTF:
- wtf/ListDump.h:
(WTF::lessThan):
(WTF::sortedListDump):
- 5:34 PM Changeset in webkit [156310] by
-
- 8 edits in trunk/Source/WebCore
Move rendererForRootBackground() to RenderElement.
<http://webkit.org/b/121813>
Reviewed by Antti Koivisto.
Move this to RenderElement (and make it return one, too) since the
document element renderer will always be a RenderElement.
- 5:14 PM Changeset in webkit [156309] by
-
- 7 edits1 add in trunk/Source/WebCore
Make the Mac build work with IndexedDB enabled.
https://bugs.webkit.org/show_bug.cgi?id=121814
Reviewed by Alexey Proskuryakov.
This patch makes the Mac build work if one were to enable the IndexedDB feature flag.
This patch does not actually enable the flag for everyone.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBBackingStore.cpp: Added.
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::openInMemory):
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::IDBBackingStore::Cursor::advance):
(WebCore::IDBBackingStore::Cursor::continueFunction):
(WebCore::IDBBackingStore::Transaction::Transaction):
(WebCore::IDBBackingStore::Transaction::begin):
(WebCore::IDBBackingStore::Transaction::commit):
(WebCore::IDBBackingStore::Transaction::rollback):
- Modules/indexeddb/IDBBackingStore.h:
(WebCore::LevelDBFactory::~LevelDBFactory):
(WebCore::IDBBackingStore::Transaction::reset):
(WebCore::IDBBackingStore::Transaction::levelDBTransactionFrom):
- Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBIsValidKeyPath):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
- bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS):
- 4:55 PM Changeset in webkit [156308] by
-
- 10 edits in trunk/Source/WebCore
CTTE: RenderObject::container() should return a RenderElement*.
<https://webkit.org/b/121811>
Reviewed by Antti Koivisto.
The containing renderer is always a RenderElement.
- 4:53 PM Changeset in webkit [156307] by
-
- 6 edits in trunk/Source
Test the waters and begin using lambdas
https://bugs.webkit.org/show_bug.cgi?id=121809
Reviewed by Andreas Kling.
Source/WebCore:
Use lambdas instead of static functions and function objects.
- css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery):
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::deliverAllMutations):
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::sortedTrackListForMenu):
Source/WTF:
- wtf/ListDump.h:
(WTF::sortedListDump):
Use std::less instead of a custom lessThan function.
- 4:26 PM Changeset in webkit [156306] by
-
- 2 edits in trunk/Source/WebCore
[WIN] Add implementation for WebCore::readFromFile()
https://bugs.webkit.org/show_bug.cgi?id=119210
Reviewed by Brent Fulgham.
- platform/win/FileSystemWin.cpp:
(WebCore::readFromFile):
- 3:41 PM Changeset in webkit [156305] by
-
- 2 edits in trunk/Source/WTF
ListHashSet::removeLast should only remove one element.
- wtf/ListHashSet.h:
(WTF::ListHashSet::removeLast):
- 3:39 PM Changeset in webkit [156304] by
-
- 5 edits in trunk/Source/WTF
Add hash traits for std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=121807
Reviewed by Antti Koivisto.
Also, convert the thread map over to using std::unique_ptr instead of OwnPtr.
- wtf/HashMap.h:
Remove unnecessary typedefs and add missing calls to std::forward.
- wtf/HashTraits.h:
Add hash trait for std::unique_ptr.
- wtf/RefPtrHashMap.h:
Use std::add_lvalue_reference.
- wtf/ThreadingPthreads.cpp:
(WTF::establishIdentifierForPthreadHandle):
Change ThreadMap to be a hash map from ThreadIdentifier to std::unique_ptr<PthreadState>.
- 3:35 PM Changeset in webkit [156303] by
-
- 5 edits in trunk/Source
[WIN] Implement WebMutableURLRequest::setHTTPBody()
https://bugs.webkit.org/show_bug.cgi?id=91920
Reviewed by Brent Fulgham.
Source/WebCore:
Add a method to FormData for growing the internal buffer with a given size.
- platform/network/FormData.cpp:
(WebCore::FormData::appendData):
(WebCore::FormData::expandDataStore):
- platform/network/FormData.h:
Source/WebKit/win:
- WebMutableURLRequest.cpp:
(WebMutableURLRequest::setHTTPBody):
(WebMutableURLRequest::setHTTPBodyStream):
- 3:25 PM Changeset in webkit [156302] by
-
- 20 edits in trunk
use NOMINMAX instead of #define min min
https://bugs.webkit.org/show_bug.cgi?id=73563
Reviewed by Brent Fulgham.
Use NOMINMAX instead of #define min/max as a cleaner
way of ensuring that Windows system header files don't
define min/max as macro in the first place.
Source/JavaScriptCore:
- config.h:
Source/WebCore:
- WebCorePrefix.h:
- config.h:
Source/WebKit/win:
- WebKitPrefix.h:
Source/WebKit2:
- config.h:
Source/WTF:
- config.h:
Tools:
- DumpRenderTree/DumpRenderTreePrefix.h:
- DumpRenderTree/cg/ImageDiffCG.cpp:
- DumpRenderTree/config.h:
- DumpRenderTree/win/ImageDiffCairo.cpp:
- WebKitTestRunner/WebKitTestRunnerPrefix.h:
- WebKitTestRunner/config.h:
WebKitLibraries:
- win/tools/vsprops/common.props:
- 3:16 PM Changeset in webkit [156301] by
-
- 8 edits in trunk
REGRESSION (r155998): when zooming in, tiles are too small
https://bugs.webkit.org/show_bug.cgi?id=121765
Source/WebCore:
Reviewed by Dean Jackson.
In r155998 I made GraphicsLayerCA take root-relative transforms
into account when computing contentsScale, and landed a bunch of
new results which should actually have told me that I broke page
scaling.
We don't want to take page scale into account when computing contentsScale,
because we already do so, so ignore the transform on the layer that
applies page scale (the only transform it should ever has is the page scale).
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateRootRelativeScale):
LayoutTests:
Reviewed by Dean Jackson.
Fix results of tests that showed that we had incorrect tiling
behavior on zooming.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
- platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
- 3:09 PM Changeset in webkit [156300] by
-
- 28 edits2 adds in trunk/Source/JavaScriptCore
Never use ReturnPC for exception handling and quit using exception check indices as a lame replica of the CodeOrigin index
https://bugs.webkit.org/show_bug.cgi?id=121734
Reviewed by Mark Hahnenberg.
Exception handling can deduce where the exception was thrown from by looking at the
code origin that was stored into the call frame header. There is no need to pass any
additional meta-data into the exception throwing logic. But the DFG was still doing it
anyway.
This removes all of the logic to pass extra meta-data into lookupExceptionHandler()
and friends. It simplifies a lot of code.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::codeOrigins):
(JSC::CodeBlock::hasCodeOrigins):
(JSC::CodeBlock::canGetCodeOrigin):
(JSC::CodeBlock::codeOrigin):
- bytecode/CodeOrigin.h:
(JSC::InlineCallFrame::InlineCallFrame):
- bytecode/InlineCallFrameSet.cpp: Added.
(JSC::InlineCallFrameSet::InlineCallFrameSet):
(JSC::InlineCallFrameSet::~InlineCallFrameSet):
(JSC::InlineCallFrameSet::add):
(JSC::InlineCallFrameSet::shrinkToFit):
- bytecode/InlineCallFrameSet.h: Added.
(JSC::InlineCallFrameSet::isEmpty):
(JSC::InlineCallFrameSet::size):
(JSC::InlineCallFrameSet::at):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::addCodeOrigin):
(JSC::DFG::CommonData::shrinkToFit):
- dfg/DFGCommonData.h:
- dfg/DFGDesiredWriteBarriers.cpp:
(JSC::DFG::DesiredWriteBarrier::DesiredWriteBarrier):
(JSC::DFG::DesiredWriteBarrier::trigger):
- dfg/DFGDesiredWriteBarriers.h:
(JSC::DFG::DesiredWriteBarriers::add):
(JSC::DFG::initializeLazyWriteBarrierForInlineCallFrameExecutable):
(JSC::DFG::initializeLazyWriteBarrierForInlineCallFrameCallee):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::emitStoreCodeOrigin):
(JSC::DFG::JITCompiler::exceptionCheck):
(JSC::DFG::JITCompiler::fastExceptionCheck):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
(JSC::DFG::SpeculativeJIT::appendCall):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::callPreflight):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitExceptionCheck):
- 3:07 PM Changeset in webkit [156299] by
-
- 5 edits in trunk/Tools
Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
Patch by Benjamin Poulain <benjamin@webkit.org> on 2013-09-23
Reviewed by Alexey Proskuryakov.
Previously, initalizing a WebPreference would change the cache model
to WebCacheModelDocumentBrowser. That behavior was due to a stale
preference file on disk.
This patch fixes the tests by resetting the default, and using the proper
default values after initializing WebPreference.
- TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
(TestWebKitAPI::TEST): Use the proper initial value, unrelated
to the previous runs.
- TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
(TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
cache model to the one required.
- TestWebKitAPI/ios/mainIOS.mm:
(main): Reset the preferences before testing.
- TestWebKitAPI/mac/mainMac.mm:
(main): Ditto.
- 2:53 PM Changeset in webkit [156298] by
-
- 6 edits1 delete in trunk/Source/WTF
Remove PassTraits.h
https://bugs.webkit.org/show_bug.cgi?id=121805
Reviewed by Andreas Kling.
We no longer need PassTraits.h, get rid of it.
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/PassTraits.h: Removed.
- 2:50 PM Changeset in webkit [156297] by
-
- 3 edits3 adds in trunk
iframe and scrollbar with "overflow:auto" should support autoscroll with mousedrag
https://bugs.webkit.org/show_bug.cgi?id=40981
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com> on 2013-09-23
Reviewed by Darin Adler.
Source/WebCore:
RenderBox::calculateAutoscrollDirection does not properly translate
inner frames' coordinates in order to determine its auto-scrollability.
By coincidence, if the inner frame box it placed near to page's 0, 0 position
(upper left corner), it might work.
Patch fixes it by changing ::calculateAutoscrollDirection algorithm to operate
with window coordinates, taking inner frames offset and scroll position into account.
The behavior of auto-scrollable non-frame overflow boxes, including divs, still works
as it is used to.
Test: fast/events/drag-and-drop-autoscroll-inner-frame.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calculateAutoscrollDirection):
LayoutTests:
Test ensures that dragging an element close to the boundary of
scrollable Frames, scroll its content in that direction.
- fast/events/drag-and-drop-autoscroll-inner-frame-expected.txt: Added.
- fast/events/drag-and-drop-autoscroll-inner-frame.html: Added.
- 2:45 PM Changeset in webkit [156296] by
-
- 4 edits3 moves1 add in trunk/Source/WebCore
Move LevelDB specific IDB files into their own subdirectory.
https://bugs.webkit.org/show_bug.cgi?id=121804
Rubberstamped by Alexey Proskuryakov.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp.
(WebCore::recordInternalError):
(WebCore::putBool):
(WebCore::getInt):
(WebCore::putInt):
(WebCore::getVarInt):
(WebCore::putVarInt):
(WebCore::getString):
(WebCore::putString):
(WebCore::putIDBKeyPath):
(WebCore::compareKeys):
(WebCore::compareIndexKeys):
(WebCore::Comparator::compare):
(WebCore::Comparator::name):
(WebCore::isSchemaKnown):
(WebCore::setUpMetadata):
(WebCore::getMaxObjectStoreId):
(WebCore::DefaultLevelDBFactory::openLevelDB):
(WebCore::DefaultLevelDBFactory::destroyLevelDB):
(WebCore::IDBBackingStore::IDBBackingStore):
(WebCore::IDBBackingStore::~IDBBackingStore):
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::openInMemory):
(WebCore::IDBBackingStore::create):
(WebCore::IDBBackingStore::getDatabaseNames):
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::getNewDatabaseId):
(WebCore::IDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::deleteRange):
(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::checkObjectStoreAndMetaDataType):
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::setMaxObjectStoreId):
(WebCore::IDBBackingStore::createObjectStore):
(WebCore::IDBBackingStore::deleteObjectStore):
(WebCore::IDBBackingStore::getRecord):
(WebCore::getNewVersionNumber):
(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::clearObjectStore):
(WebCore::IDBBackingStore::deleteRecord):
(WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::checkIndexAndMetaDataKey):
(WebCore::IDBBackingStore::getIndexes):
(WebCore::setMaxIndexId):
(WebCore::IDBBackingStore::createIndex):
(WebCore::IDBBackingStore::deleteIndex):
(WebCore::IDBBackingStore::putIndexDataForRecord):
(WebCore::findGreatestKeyLessThanOrEqual):
(WebCore::versionExists):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
(WebCore::IDBBackingStore::Cursor::Cursor):
(WebCore::IDBBackingStore::Cursor::firstSeek):
(WebCore::IDBBackingStore::Cursor::advance):
(WebCore::IDBBackingStore::Cursor::continueFunction):
(WebCore::IDBBackingStore::Cursor::haveEnteredRange):
(WebCore::IDBBackingStore::Cursor::isPastBounds):
(WebCore::ObjectStoreKeyCursorImpl::create):
(WebCore::ObjectStoreKeyCursorImpl::clone):
(WebCore::ObjectStoreKeyCursorImpl::value):
(WebCore::ObjectStoreKeyCursorImpl::encodeKey):
(WebCore::ObjectStoreKeyCursorImpl::ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::create):
(WebCore::ObjectStoreCursorImpl::clone):
(WebCore::ObjectStoreCursorImpl::value):
(WebCore::ObjectStoreCursorImpl::encodeKey):
(WebCore::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::create):
(WebCore::IndexKeyCursorImpl::clone):
(WebCore::IndexKeyCursorImpl::value):
(WebCore::IndexKeyCursorImpl::primaryKey):
(WebCore::IndexKeyCursorImpl::recordIdentifier):
(WebCore::IndexKeyCursorImpl::encodeKey):
(WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::loadCurrentRow):
(WebCore::IndexCursorImpl::create):
(WebCore::IndexCursorImpl::clone):
(WebCore::IndexCursorImpl::value):
(WebCore::IndexCursorImpl::primaryKey):
(WebCore::IndexCursorImpl::recordIdentifier):
(WebCore::IndexCursorImpl::encodeKey):
(WebCore::IndexCursorImpl::IndexCursorImpl):
(WebCore::IndexCursorImpl::loadCurrentRow):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStore::openObjectStoreCursor):
(WebCore::IDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBBackingStore::openIndexKeyCursor):
(WebCore::IDBBackingStore::openIndexCursor):
(WebCore::IDBBackingStore::Transaction::Transaction):
(WebCore::IDBBackingStore::Transaction::begin):
(WebCore::IDBBackingStore::Transaction::commit):
(WebCore::IDBBackingStore::Transaction::rollback):
- Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp.
(WebCore::IDBLevelDBCoding::encodeByte):
(WebCore::IDBLevelDBCoding::decodeByte):
(WebCore::IDBLevelDBCoding::maxIDBKey):
(WebCore::IDBLevelDBCoding::minIDBKey):
(WebCore::IDBLevelDBCoding::encodeBool):
(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::decodeInt):
(WebCore::IDBLevelDBCoding::compareInts):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::decodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):
(WebCore::IDBLevelDBCoding::encodeStringWithLength):
(WebCore::IDBLevelDBCoding::decodeStringWithLength):
(WebCore::IDBLevelDBCoding::compareEncodedStringsWithLength):
(WebCore::IDBLevelDBCoding::encodeDouble):
(WebCore::IDBLevelDBCoding::decodeDouble):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::keyTypeByteToKeyType):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::decodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
(WebCore::IDBLevelDBCoding::KeyPrefix::createWithSpecialIndex):
(WebCore::IDBLevelDBCoding::KeyPrefix::isValidDatabaseId):
(WebCore::IDBLevelDBCoding::KeyPrefix::isValidObjectStoreId):
(WebCore::IDBLevelDBCoding::KeyPrefix::isValidIndexId):
(WebCore::IDBLevelDBCoding::KeyPrefix::decode):
(WebCore::IDBLevelDBCoding::KeyPrefix::encodeEmpty):
(WebCore::IDBLevelDBCoding::KeyPrefix::encode):
(WebCore::IDBLevelDBCoding::KeyPrefix::encodeInternal):
(WebCore::IDBLevelDBCoding::KeyPrefix::compare):
(WebCore::IDBLevelDBCoding::KeyPrefix::type):
(WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
(WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
(WebCore::IDBLevelDBCoding::DataVersionKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeMinKeyForOrigin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeStopKeyForOrigin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
(WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
(WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
(WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encodeMinKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
(WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
(WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
(WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::primaryKey):
- Modules/indexeddb/leveldb/IDBLevelDBCoding.h: Renamed from Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.h.
(WebCore::IDBLevelDBCoding::encodeIntSafely):
(WebCore::IDBLevelDBCoding::KeyPrefix::validIds):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
(WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
- 2:39 PM Changeset in webkit [156295] by
-
- 3 edits in trunk/Source/WebCore
Try to fix GTK build.
Not reviewed.
- accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer):
- 2:39 PM Changeset in webkit [156294] by
-
- 4 edits in trunk
ListHashSet should work with move-only types
https://bugs.webkit.org/show_bug.cgi?id=121802
Reviewed by Andreas Kling.
Source/WTF:
Add rvalue reference overloads and calls to std::forward and std::move where appropriate.
- wtf/ListHashSet.h:
(WTF::::removeFirst):
Implement this in terms of takeFirst.
(WTF::::takeFirst):
Look up the iterator before we move out the value so we won't break the hash invariant.
(WTF::::removeLast):
Implement this in terms of takeLast.
(WTF::::takeLast):
Look up the iterator before we move out the value so we won't break the hash invariant.
Tools:
- TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
(TestWebKitAPI::TEST):
Add a test for move-only types.
- 2:20 PM Changeset in webkit [156293] by
-
- 4 edits in trunk/LayoutTests
video-object-fit tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=121803
Rubber-stamped by Simon Fraser.
Removing an ad hoc 1.5 second timeout that these tests had. Loading video can take
longer.
- compositing/video/video-object-fit.html:
- media/video-object-fit-change.html:
- media/video-object-fit.html:
- 1:45 PM Changeset in webkit [156292] by
-
- 8 edits in trunk
Web Inspector: [CSS Regions] Display CSS Regions flow name in the inspector overlay
https://bugs.webkit.org/show_bug.cgi?id=121794
Reviewed by Joseph Pecoraro.
Source/WebCore:
No new tests, the previous test for CSS Regions highlighting covers the flow name.
This patch adds the "Flow" property in the inspector overlay. The region
chain is already displayed with numbers, so it makes sense to have the flow
name around when a CSS region is highlighted.
I've consolidated the flow information into "elementInfo.flowInfo".
Flow info has two properties: "name" and "regions".
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForCSSRegionsHighlight):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
- inspector/InspectorOverlayPage.css:
(.css-property): Added the CSS property font color that the Inspector uses.
- inspector/InspectorOverlayPage.html: Added a new element to be used to display the flow-from property.
- inspector/InspectorOverlayPage.js:
(_drawElementTitle):
(drawNodeHighlight):
LayoutTests:
Updated the expected results after moving the regions to the elementInfo.flowInfo property.
Also, the test is now logging the name of the flow container in the output.
- http/tests/inspector/elements-test.js:
- inspector/elements/highlight-node-regions-expected.txt:
- 1:43 PM Changeset in webkit [156291] by
-
- 10 edits in trunk/Source/WebCore
Rapidly loading pages can result in !needsLayout() assertions in FrameView::paintContents() and RenderView::paint()
https://bugs.webkit.org/show_bug.cgi?id=121725
<rdar://problem/13982161> ASSERT(!needsLayout()) in WebCore::RenderView::paint (121196)
Reviewed by Dean Jackson.
Layout has to be up-to-date before we paint, and when composited we rely on a
CFRunLoopObserver owned by LayerFlushScheduler to enforce this. The contract is
that changes to GraphicsLayers accumulate in those layers, and are all pushed to
CALayers only inside of flushCompositingState(). CALayers must not be touched
directly outside of flushCompositingState(), since this may trigger a CA commit
and resultant painting without us having updated layout.
In addition, we rely on the CA commits only happening after our runloop observer
has fired in order for LayerFlushScheduler's suspend/resume to work (these are used
for freezing the layer tree during page transitions).
However, TileController was violating this contract. It called revalidateTiles()
at random times, and on a timer. This would result in CA commits happening when
layer flushing was suspended at the LayerFlushScheduler level, and thus before
we'd had a chance to do layout.
Fix by only ever revalidatingTiles inside of flushCompositingState(). Calls
that used to result in revalidateTiles() at other times now just set a bit
on GraphicsLayerCA to indicate that revalidation is required, and this triggers
a later flush like any other GraphicsLayerCA change.
There is one exception to the revalidate-inside-flush rule: when purging
files for background tabs on a timer, we are only dealing with an unparented
layer tree, so CALayer manipulation is safe at any time.
Very timing dependent, so hard to test.
- platform/graphics/TiledBacking.h: Expose revalidateTiles()
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Remove
platformCALayerDidCreateTiles() override.
- platform/graphics/ca/GraphicsLayerCA.h: Keep track of m_isCommittingChanges
so we can assert. Add TilingAreaChanged flag.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::recursiveCommitChanges): noteSublayersChanged() is
used inside of a commit in some cases to trigger a parent layer to update
children after the children have been processed. To avoid trying to pointlessly
schedule the flusher inside a flush, and for strong assertions, use a new flag
that indicates that flushing is not required in this situation.
Set the m_isCommittingChanges flag around committing state.
(WebCore::GraphicsLayerCA::platformCALayerSetNeedsToRevalidateTiles): We used
to use platformCALayerDidCreateTiles() to ensure that we would flush after adding
new tiles to avoid garbage flashes. Now that we only ever create tiles inside
a flush, this is no longer necessary.
The new platformCALayerSetNeedsToRevalidateTiles() function just sets the
TilingAreaChanged flag and triggers a flush.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): After updating
visible rect, we look for the TilingAreaChanged flag to tell us whether to
revalidate TiledBacking tiles.
(WebCore::GraphicsLayerCA::ensureStructuralLayer): Use DontScheduleFlush when
telling a parent layer that it needs to reconsider sublayers.
(WebCore::GraphicsLayerCA::updateTiles): The caller of revalidateTiles().
(WebCore::GraphicsLayerCA::updateContentsRects): DontScheduleFlush again.
(WebCore::GraphicsLayerCA::noteSublayersChanged): Pass scheduleFlush along.
(WebCore::GraphicsLayerCA::noteLayerPropertyChanged): Handle scheduleFlush.
- platform/graphics/ca/PlatformCALayerClient.h:
(WebCore::PlatformCALayerClient::platformCALayerSetNeedsToRevalidateTiles): Added
so that TileController can call back out to GraphicsLayerCA.
(WebCore::PlatformCALayerClient::isCommittingChanges):
- platform/graphics/ca/mac/TileController.h: Need to keep track of secondary
coverage rects in m_secondaryTileCoverageRects.
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::tileCacheLayerBoundsChanged): Just trigger a tile revalidate,
which will happen later in this same commit.
(WebCore::TileController::setScale): This is called inside the commit. Does an extra
revalidate, which is needed to prune tiles. This could be optimized in future.
(WebCore::TileController::setVisibleRect): Assert that we're inside a commit,
and trigger a revalidate.
(WebCore::TileController::setExposedRect): Trigger a revalidate.
(WebCore::TileController::setClipsToExposedRect): Ditto.
(WebCore::TileController::prepopulateRect): Save the rect and trigger a revalidate.
(WebCore::TileController::setIsInWindow): If we're in the window, trigger a revalidate
otherwise schedule the timer.
(WebCore::TileController::revalidateTiles): Wrapper for the real revalidateTiles().
(WebCore::TileController::tileRevalidationTimerFired): If we're in the window,
schedule a revalidate. Otherwise our layer tree is disconnected, and it's OK to call revalidateTiles().
(WebCore::TileController::setNeedsRevalidateTiles): Call through the client to GraphicsLayerCA
which will schedule a layer tree flush.
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::ensureTilesForRect): Move code from prepopulateRect
into here; ensureTilesForRect() for each secondary rect, then clear the rects.
No need to call platformCALayerDidCreateTiles() at the end.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: Remove
platformCALayerDidCreateTiles() override.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scheduleLayerFlush): This should only be
called when we're not inside a flush, otherwise it will fail to schedule
another one.
- 1:38 PM Changeset in webkit [156290] by
-
- 2 edits in trunk/Tools
Added --64-bit option for Windows build.
https://bugs.webkit.org/show_bug.cgi?id=121799
Reviewed by Brent Fulgham.
- Scripts/webkitdirs.pm:
(determinePassedConfiguration): Add "|x64" for 64-bit configuration.
(isWin64): Added.
(determineIsWin64): Added.
- 1:24 PM Changeset in webkit [156289] by
-
- 21 edits in trunk/Source/WebCore
CTTE: htmlediting.h Element creation function should take a Document&
https://bugs.webkit.org/show_bug.cgi?id=121800
Reviewed by Antti Koivisto.
Thread the Document&!
- 1:23 PM Changeset in webkit [156288] by
-
- 5 edits in trunk/Source
[BlackBerry] Poor rendering opening a Google map short link
https://bugs.webkit.org/show_bug.cgi?id=121687
Source/WebCore:
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-09-23.
Reviewed by Yong Li.
Internally reviewed by Liam Quinn and Joe Mason.
Fix a regression. It turns out that LayerCompositingThread already has
an API named isVisible() which by default returns false. So rename the
one in the LayerData to isLayerVisible().
- platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::isLayerVisible):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayersRecursive):
Source/WebKit/blackberry:
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-09-23.
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.
Clean up m_isAcceleratedCompositingActive as it has been deprecated.
- Api/WebPage_p.h:
- 1:09 PM Changeset in webkit [156287] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
https://bugs.webkit.org/show_bug.cgi?id=121600
Reviewed by Gustavo Noronha Silva.
Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
an instance of NetscapePlugin. So the created GtkWidget remains visible.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformDestroy):
- 12:46 PM Changeset in webkit [156286] by
-
- 3 edits in trunk/Source/JavaScriptCore
CodeLoad performance regression
Reviewed by Filip Pizlo.
Temporarily remove the ExpressionInfo compression until we can
work out how to make it not clobber performance.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::addExpressionInfo):
- bytecode/UnlinkedCodeBlock.h:
- 12:32 PM Changeset in webkit [156285] by
-
- 38 edits in trunk/Source
Rename RenderObject::first/lastChild to RenderObject::first/lastChildSlow
https://bugs.webkit.org/show_bug.cgi?id=121784
Reviewed by Andreas Kling.
This will make it obvious in code where typing should be tightened.
Handled some simple cases by tightening the code instead of renaming.
- 12:27 PM Changeset in webkit [156284] by
-
- 5 edits in trunk/Source/WebInspectorUI
Hook up the initiator info and show it in the Resource details sidebar.
https://bugs.webkit.org/show_bug.cgi?id=121741
Reviewed by Joseph Pecoraro.
- UserInterface/FrameResourceManager.js:
(WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
(WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
(WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
(WebInspector.FrameResourceManager.prototype._initiatorSourceCodeLocationFromPayload):
- UserInterface/NetworkObserver.js:
(WebInspector.NetworkObserver.prototype.requestWillBeSent):
(WebInspector.NetworkObserver.prototype.requestServedFromMemoryCache):
- UserInterface/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.get initiatorSourceCodeLocation):
- UserInterface/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshURL):
- 12:27 PM Changeset in webkit [156283] by
-
- 2 edits in trunk/Source/WTF
Clean up ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=121797
Reviewed by Antti Koivisto.
- wtf/ListHashSet.h:
- 12:02 PM Changeset in webkit [156282] by
-
- 5 edits2 adds in trunk
[Texmap] Reloading a webgl page doesn't work
https://bugs.webkit.org/show_bug.cgi?id=120593
Reviewed by Noam Rosenthal.
Source/WebCore:
Let GraphicsLayerTextureMapper know it needs to detach the platform layer when a GraphicsContext3D is destroyed.
Test: fast/canvas/webgl/webgl-reload-crash.html
- platform/graphics/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/TextureMapperPlatformLayer.h:
LayoutTests:
Add a new test case to check if a crash occurs while reloading a page which contains webgl.
- fast/canvas/webgl/webgl-reload-crash-expected.txt: Added.
- fast/canvas/webgl/webgl-reload-crash.html: Added.
- 11:21 AM Changeset in webkit [156281] by
-
- 4 edits in trunk
ListHashSet should use std::reverse_iterator for reverse iterators
https://bugs.webkit.org/show_bug.cgi?id=121795
Reviewed by Antti Koivisto.
Source/WTF:
Get rid of the custom reverse iterators and just use std::reverse_iterator instead.
- wtf/ListHashSet.h:
Tools:
Add test for reverse iterators.
- TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
(TestWebKitAPI::TEST):
- 10:54 AM Changeset in webkit [156280] by
-
- 2 edits in trunk/LayoutTests
Audio object garbage collection is incorrect (media/audio-garbage-collect.html test is flaky)
https://bugs.webkit.org/show_bug.cgi?id=72698
Skipping the test. It frequently times out, and when it doesn't, that's only
because if fails to detect incorrect behavior.
- 10:50 AM Changeset in webkit [156279] by
-
- 3 edits in trunk/Source/WebKit2
Add back the SharedWorkerStrategy to prevent crashing.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createSharedWorkerStrategy):
(WebKit::WebPlatformStrategies::isAvailable):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 10:43 AM Changeset in webkit [156278] by
-
- 40 edits2 deletes in trunk/Source/WebCore
Remove RenderObjectChildList
https://bugs.webkit.org/show_bug.cgi?id=121771
Reviewed by Darin Adler.
Most RenderElement subclasses have m_children member (>90% of instances on typical page). It is not worth optimising
for memory for the few cases that don't (RenderImage, RenderLineBreak mostly) in expense of performance.
This patch moves child handling to RenderElement. This gets rid of virtual children() calls and simplifies the code.
- 10:39 AM Changeset in webkit [156277] by
-
- 15 edits11 deletes in trunk/Source/WebKit2
SharedWorkerProcess code is dead
https://bugs.webkit.org/show_bug.cgi?id=121563
Reviewed by Alexey Proskuryakov.
Remove SharedWorkerProcess code.
- 10:33 AM Changeset in webkit [156276] by
-
- 2 edits in trunk/Source/WTF
De-indent ListHashSet in preparation of more changes.
Rubber-stamped by Sam Weinig.
- wtf/ListHashSet.h:
- 10:15 AM Changeset in webkit [156275] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merged r156223. <rdar://problem/15048898>
- 9:32 AM Changeset in webkit [156274] by
-
- 2 edits in trunk/Source/WebCore
Document::destroyRenderTree() shouldn't do anything but.
<https://webkit.org/b/121786>
Reviewed by Anders Carlsson.
Move everything in destroyRenderTree() that doesn't actually destroy
render trees to prepareForDestruction() instead.
Destroying the render tree is now a reparable operation.
- 8:47 AM Changeset in webkit [156273] by
-
- 6 edits in trunk
[EFL] accessibility/aria-invalid is failing
https://bugs.webkit.org/show_bug.cgi?id=111986
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-23
Reviewed by Mario Sanchez Prada.
Tools:
Adds possibility to retrieve JS context.
This is part of the implementation of AccessibilityUIElement::addNotificationListener
from 119883 and 120421.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
(axObjectEventListener):
(addAccessibilityNotificationHandler):
(removeAccessibilityNotificationHandler):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
LayoutTests:
Test passes on both efk-wk2 and efl-wk1, because of the patches from bugs: 119883 and 120421.
- platform/efl-wk1/TestExpectations: Removed accessibility/aria-invalid.html
- platform/efl-wk2/TestExpectations: Removed accessibility/aria-invalid.html
- 8:40 AM Changeset in webkit [156272] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Tiled backing-store causes wrong translation
https://bugs.webkit.org/show_bug.cgi?id=121789
Reviewed by Noam Rosenthal.
Move the translation inside save/restore of the GraphicsContext.
- platform/graphics/qt/TileQt.cpp:
(WebCore::TileQt::updateBackBuffer):
- 8:09 AM Changeset in webkit [156271] by
-
- 8 edits1 add in trunk
[Autotools] Rework the build target selection
https://bugs.webkit.org/show_bug.cgi?id=121703
Reviewed by Gustavo Noronha Silva.
Replace the --with-target configuration flag with target-specific --enable-*-target flags:
- --enable-x11-target
- --enable-wayland-target
- --enable-win32-target
- --enable-quartz-target
- --enable-directfb-target
By default, the X11 target is enabled. This default is preserved only if no --enable-*-target flag
is passed on the command line. When that occurs, the newly-constructed list of build targets is
used to determine what build targets should actually be built. So for instance, executing just
./configurewould only enable the X11 target as that's the default, and executing
./configure --enable-wayland-targetwould only enable the Wayland target, as the defaults are
completely ignored.
- Source/autotools/CheckSystemAndBasicDependencies.m4: Abort if grep was not found, just in case.
- Source/autotools/CustomMacros.m4: The new file that contains helpful custom macros.
- Source/autotools/FindDependencies.m4: Use the appropriate 'enable_*_target' references instead of 'with_*target'.
- Source/autotools/PrintBuildConfiguration.m4: Use the new AM_APPEND_TO_DESCRIPTION macro to construct a pretty-looking
description string of what targets will be built.
- Source/autotools/ReadCommandLineArguments.m4: Replace the --with-target configuration flag and the related
hacks with the set of --enable-*-target flags. The new AM_DETERMINE_BUILD_TARGET_STATUS macro is used to determine
whether to enable specific build targets, based indirectly on the passed-in --enable-*-target flags.
- Source/autotools/SetupAutoconfHeader.m4: Use the appropriate 'enable_*_target' references instead of 'with_*target'.
- Source/autotools/SetupAutomake.m4: Use the appropriate 'enable_*_target' references instead of 'with_*target'.
- configure.ac: Include the new CustomMacros.m4 file.
- 6:04 AM Changeset in webkit [156270] by
-
- 4 edits in trunk/Source/WebCore
Unify code paths leading to render tree teardown.
<https://webkit.org/b/121785>
Reviewed by Antti Koivisto.
Make Document::prepareForDestruction() fit all the call sites that were
doing destroyRenderTree() + disconnectFromFrame().
- disconnectDescendantFrames() is already a no-op if there are no frames.
- willDetachDocumentFromFrame() will only run if there is a frame.
This is another step towards making tree rebuild possible.
Removed some age-old FIXMEs about why we aren't calling willRemove(),
a long-gone function.
- 5:23 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:03 AM Changeset in webkit [156269] by
-
- 2 edits in trunk
[GTK] Bump version
Reviewed by Carlos Garcia Campos.
- Source/autotools/Versions.m4: Bump to 2.3.0
- 4:04 AM QtWebKitBuildBots edited by
- Updating EWS info to Qt 5.1.1 (diff)
- 2:51 AM Changeset in webkit [156268] by
-
- 2 edits in trunk/LayoutTests
[EFL] accessibility/selection-states.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112007
Unreviewed EFL gardening. Passes after r156149.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-23
- platform/efl-wk2/TestExpectations:
- 1:26 AM Changeset in webkit [156267] by
-
- 7 edits in trunk/Source/WebCore
Cleanup CMake files in WebCore
https://bugs.webkit.org/show_bug.cgi?id=119262
Reviewed by Gyuyoung Kim.
Sort files and unify style.
- CMakeLists.txt:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- PlatformWin.cmake:
- PlatformWinCE.cmake:
- 1:09 AM Changeset in webkit [156266] by
-
- 4 edits in trunk/Source/WebKit
Cleanup CMake files in WebKit
https://bugs.webkit.org/show_bug.cgi?id=121763
Reviewed by Gyuyoung Kim.
Sort files and unify style.
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
- 1:07 AM Changeset in webkit [156265] by
-
- 4 edits in trunk/Source/WebKit2
Cleanup CMake files in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121767
Reviewed by Gyuyoung Kim.
Sort files and unify style.
- CMakeLists.txt:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- 1:03 AM Changeset in webkit [156264] by
-
- 4 edits in trunk/Source/WTF
Cleanup CMake files in WTF
https://bugs.webkit.org/show_bug.cgi?id=121761
Reviewed by Gyuyoung Kim.
Sort files and unify the style.
- wtf/CMakeLists.txt:
- wtf/PlatformEfl.cmake:
- wtf/PlatformGTK.cmake:
- 1:02 AM Changeset in webkit [156263] by
-
- 5 edits in trunk/Source/JavaScriptCore
Cleanup CMake files in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=121762
Reviewed by Gyuyoung Kim.
Sort files and unify style.
- CMakeLists.txt:
- shell/CMakeLists.txt:
- shell/PlatformBlackBerry.cmake:
- shell/PlatformEfl.cmake:
Sep 22, 2013:
- 11:41 PM WebKitGTK/2.2.x edited by
- (diff)
- 11:35 PM Changeset in webkit [156262] by
-
- 40 edits1 copy1 add in trunk/Source/WebCore
Unreviewed, rolling out r156254.
http://trac.webkit.org/changeset/156254
https://bugs.webkit.org/show_bug.cgi?id=121779
Caused assertions in fast/regions tests (Requested by ap on
#webkit).
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::splitFlow):
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::RenderBlock::collapseAnonymousBoxChild):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::updateFirstLetterStyle):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::firstChild):
(WebCore::RenderBlock::lastChild):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::splitAnonymousBoxesAroundChild):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildTo):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::addChild):
(WebCore::RenderElement::removeChild):
- rendering/RenderElement.h:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout):
- rendering/RenderEmbeddedObject.h:
- rendering/RenderFrameSet.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::splitFlow):
(WebCore::RenderInline::childBecameNonInline):
- rendering/RenderInline.h:
(WebCore::RenderInline::firstChild):
(WebCore::RenderInline::lastChild):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::willBeDestroyed):
- rendering/RenderLineBreak.h:
- rendering/RenderListMarker.h:
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
- rendering/RenderMedia.h:
(WebCore::RenderMedia::firstChild):
(WebCore::RenderMedia::lastChild):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::handleDynamicFloatPositionChange):
(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive):
- rendering/RenderObject.h:
(WebCore::RenderObject::firstChild):
(WebCore::RenderObject::lastChild):
(WebCore::RenderObject::children):
(WebCore::RenderObject::canHaveChildren):
- rendering/RenderObjectChildList.cpp: Added.
(WebCore::RenderObjectChildList::destroyLeftoverChildren):
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
- rendering/RenderObjectChildList.h: Copied from Source/WebCore/rendering/RenderMedia.h.
(WebCore::RenderObjectChildList::RenderObjectChildList):
(WebCore::RenderObjectChildList::firstChild):
(WebCore::RenderObjectChildList::lastChild):
(WebCore::RenderObjectChildList::setFirstChild):
(WebCore::RenderObjectChildList::setLastChild):
(WebCore::RenderObjectChildList::appendChildNode):
- rendering/RenderReplaced.h:
(WebCore::RenderReplaced::canHaveChildren):
- rendering/RenderReplica.h:
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.h:
- rendering/RenderText.h:
- rendering/RenderingAllInOne.cpp:
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):
- rendering/svg/RenderSVGContainer.h:
(WebCore::RenderSVGContainer::firstChild):
(WebCore::RenderSVGContainer::lastChild):
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::willBeDestroyed):
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGShape.h:
- 11:34 PM Changeset in webkit [156261] by
-
- 2 edits in trunk/Source/WebKit/gtk
Unreviewed, GTK build fix when building with GTK+ 2.0.
Patch provided by Dominique Leuenberger <dimstar@opensuse.org>.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp: Include GtkVersioning.h to set up
the mock GDK_IS_X11_DISPLAY macro if it's not provided by the GTK+ headers.
- 11:33 PM Changeset in webkit [156260] by
-
- 45 edits in trunk/Source/WebCore
Unreviewed, rolling out r156253.
http://trac.webkit.org/changeset/156253
https://bugs.webkit.org/show_bug.cgi?id=121778
Caused >20 tests to crash with assertion failures (Requested
by ap on #webkit).
- css/CSSAspectRatioValue.h:
- css/CSSBorderImageSliceValue.h:
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcExpressionNodeParser::parseValue):
- css/CSSCalculationValue.h:
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
- css/CSSCrossfadeValue.h:
(WebCore::toCSSCrossfadeValue):
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
(WebCore::CSSCursorImageValue::isSVGCursor):
- css/CSSCursorImageValue.h:
- css/CSSFilterImageValue.h:
(WebCore::toCSSFilterImageValue):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSGradientValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):
- css/CSSImageGeneratorValue.h:
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
- css/CSSImageSetValue.h:
- css/CSSImageValue.h:
- css/CSSInheritedValue.h:
- css/CSSInitialValue.h:
- css/CSSLineBoxContainValue.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
- css/CSSPrimitiveValue.h:
- css/CSSReflectValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageSlice):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isCSSLineBoxContainValue):
(WebCore::CSSValue::isCalculationValue):
- css/CSSValueList.h:
- css/CSSVariableValue.h:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- css/FontFeatureValue.h:
- css/FontValue.h:
- css/MediaList.cpp:
(WebCore::reportMediaQueryWarningIfNeeded):
- css/MediaQueryEvaluator.cpp:
(WebCore::compareAspectRatioValue):
(WebCore::numberValue):
(WebCore::orientationMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::computeLength):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/ShadowValue.h:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::createGridTrackSize):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::hasVariableReference):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore::StyleResolver::parseCustomFilterNumberParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::computedFontSize):
- editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::legacyFontSize):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::StyleChange::extractTextStyles):
(WebCore::fontWeightIsBold):
(WebCore::isTransparentColorValue):
- editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForProperties):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::data):
(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):
- 11:31 PM Changeset in webkit [156259] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r156257.
http://trac.webkit.org/changeset/156257
https://bugs.webkit.org/show_bug.cgi?id=121777
The test from this patch fails (Requested by ap on #webkit).
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calculateAutoscrollDirection):
LayoutTests:
- fast/events/drag-and-drop-autoscroll-inner-frame-expected.txt: Removed.
- fast/events/drag-and-drop-autoscroll-inner-frame.html: Removed.
- 9:32 PM Changeset in webkit [156258] by
-
- 10 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r156040.
- platform/efl/fast/forms/HTMLOptionElement_label06-expected.txt:
- platform/efl/fast/forms/HTMLOptionElement_label07-expected.txt:
- platform/efl/fast/forms/form-element-geometry-expected.txt:
- platform/efl/fast/forms/menulist-separator-painting-expected.txt:
- platform/efl/fast/forms/select-baseline-expected.txt:
- platform/efl/fast/forms/select-empty-option-height-expected.txt:
- platform/efl/fast/forms/selectlist-minsize-expected.txt:
- platform/efl/fast/html/keygen-expected.txt:
- platform/efl/fast/replaced/three-selects-break-expected.txt:
- 9:03 PM Changeset in webkit [156257] by
-
- 3 edits2 adds in trunk
iframe and scrollbar with "overflow:auto" should support autoscroll with mousedrag
https://bugs.webkit.org/show_bug.cgi?id=40981
Reviewed by Darin Adler.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
Source/WebCore:
RenderBox::calculateAutoscrollDirection does not properly translate
inner frames' coordinates in order to determine its auto-scrollability.
By coincidence, if the inner frame box it placed near to page's 0, 0 position
(upper left corner), it might work.
Patch fixes it by changing ::calculateAutoscrollDirection algorithm to operate
with window coordinates, taking inner frames offset and scroll position into account.
The behavior of auto-scrollable non-frame overflow boxes, including divs, still works
as it is used to.
Test: fast/events/drag-and-drop-autoscroll-inner-frame.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calculateAutoscrollDirection):
LayoutTests:
Test ensures that dragging an element close to the boundary of
scrollable Frames, scroll its content in that direction.
- fast/events/drag-and-drop-autoscroll-inner-frame-expected.txt: Added.
- fast/events/drag-and-drop-autoscroll-inner-frame.html: Added.
- 8:40 PM Changeset in webkit [156256] by
-
- 40 edits in trunk/Source
CTTE: Use references more in ContainerNode, ContainerNodeAlgorithms and related classes
https://bugs.webkit.org/show_bug.cgi?id=121772
Reviewed by Andreas Kling.
../WebCore:
Use references for never null Nodes in ContainerNode and related classes.
../WebKit/qt:
- Api/qwebelement.cpp:
(QWebElementCollection::append):
Update to work with the new StaticNodeList adopt function.
- 7:59 PM Changeset in webkit [156255] by
-
- 5 edits in trunk/Source/WebCore
Fix functions calling to RenderObject superclass to call RenderElement instead
https://bugs.webkit.org/show_bug.cgi?id=121773
Reviewed by Andreas Kling.
The class hierarchy has a new class. Superclass calls should be pointed there instead to
avoid future bugs.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::setSelectionState):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleWillChange):
(WebCore::RenderLayerModelObject::styleDidChange):
- rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::styleDidChange):
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::styleWillChange):
(WebCore::RenderSVGModelObject::styleDidChange):
- 7:35 PM Changeset in webkit [156254] by
-
- 40 edits2 deletes in trunk/Source/WebCore
Remove RenderObjectChildList
https://bugs.webkit.org/show_bug.cgi?id=121771
Reviewed by Darin Adler.
Most RenderElement subclasses have m_children member (>90% of instances on typical page). It is not worth optimising
for memory for the few cases that don't (RenderImage, RenderLineBreak mostly) in expense of performance.
This patch moves child handling to RenderElement. This gets rid of virtual children() calls and simplifies the code.
- 6:20 PM Changeset in webkit [156253] by
-
- 45 edits in trunk/Source/WebCore
Introduce CSS_VALUE_TYPE_CASTS macro in order to cast CSSValue type
https://bugs.webkit.org/show_bug.cgi?id=121462
Reviewed by Andreas Kling.
As r155429 introduced ELEMENT_TYPE_CASTS, CSS_VALUE_TYPE_CASTS can be used
by css value type casting as well. This type cast macros will help to detect
bad-cast bugs as well as improve a code readibility.
This patch adds the following methods,
- CSSFooValue* toCSSFooValue(CSSValue*)
- const CSSFooValue* toCSSFooValue(const CSSValue*)
To be consistent with other is*Value() naming style, isCSSLineBoxContainValue() and isCalculationValue()
are changed with isLineBoxContainValue() and isCalcValue().
FontValue, FontFeatureValue, ShadowValue have a manual type case function because of different
class naming style. So, toFontValue(), toFontFeatureValue() and toShadowValue() are added manually.
This patch removes unnecessary local variables.
No new tests, no behavior change.
- css/CSSAspectRatioValue.h:
- css/CSSBorderImageSliceValue.h:
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcExpressionNodeParser::parseValue):
- css/CSSCalculationValue.h:
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
- css/CSSCrossfadeValue.h:
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
(WebCore::CSSCursorImageValue::isSVGCursor):
- css/CSSCursorImageValue.h:
- css/CSSFilterImageValue.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSGradientValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):
- css/CSSImageGeneratorValue.h:
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
- css/CSSImageSetValue.h:
- css/CSSImageValue.h:
- css/CSSInheritedValue.h:
- css/CSSInitialValue.h:
- css/CSSLineBoxContainValue.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
- css/CSSPrimitiveValue.h:
- css/CSSReflectValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageSlice):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isLineBoxContainValue):
(WebCore::CSSValue::isCalcValue):
- css/CSSValueList.h:
- css/CSSVariableValue.h:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- css/FontFeatureValue.h:
(WebCore::toFontFeatureValue):
- css/FontValue.h:
(WebCore::toFontValue):
- css/MediaList.cpp:
(WebCore::reportMediaQueryWarningIfNeeded):
- css/MediaQueryEvaluator.cpp:
(WebCore::compareAspectRatioValue):
(WebCore::numberValue):
(WebCore::orientationMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::computeLength):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/ShadowValue.h:
(WebCore::toShadowValue):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::createGridTrackSize):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::hasVariableReference):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore::StyleResolver::parseCustomFilterNumberParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::computedFontSize):
- editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::legacyFontSize):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::StyleChange::extractTextStyles):
(WebCore::fontWeightIsBold):
(WebCore::isTransparentColorValue):
- editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForProperties):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::data):
(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):
- 4:19 PM Changeset in webkit [156252] by
-
- 4 edits2 adds in trunk
Hiding a focused element should unfocus it and fire a blur event
https://bugs.webkit.org/show_bug.cgi?id=29241
Patch by Arunprasad Rajkumar <ararunprasad@gmail.com> on 2013-09-22
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/dom/HTMLDocument/active-element-gets-unfocusable.html
We check whether the current focus element is really focusable after
the style recalculation and layout change. If it is not focusable then schedule a
timer to reset it asynchronously.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle): Check isFocusable() on the focus element after
style recalculation.
(WebCore::Document::updateLayout): Check isFocusable() on the focus element after
layout.
(WebCore::Document::resetHiddenFocusElementSoon):
(WebCore::Document::resetHiddenFocusElementTimer):
- dom/Document.h:
LayoutTests:
- fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Added.
- fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Added.
LayoutTest reused from https://chromium.googlesource.com/chromium/blink/+/c58f636fd18fc27944c42e27d6a92a36867c57e1
with little modification.
- 3:11 PM Changeset in webkit [156251] by
-
- 15 edits in trunk/Source/WebCore
CTTE: StaticNodeLists often contain only Elements, we shouldn't store them as Vector<RefPtr<Node>> in those cases
https://bugs.webkit.org/show_bug.cgi?id=121769
Reviewed by Andreas Kling.
Introduces StaticElementList and uses it.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
- bindings/js/JSHTMLCollectionCustom.cpp:
- bindings/js/JSHTMLFormControlsCollectionCustom.cpp:
(WebCore::getNamedItems):
- bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
- dom/SelectorQuery.cpp:
(WebCore::AllElementExtractorSelectorQueryTrait::appendOutputForElement):
(WebCore::SelectorDataList::queryAll):
- dom/StaticNodeList.cpp:
(WebCore::StaticElementList::length):
(WebCore::StaticElementList::item):
(WebCore::StaticElementList::namedItem):
- dom/StaticNodeList.h:
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContent):
(WebCore::WebKitNamedFlow::getRegions):
(WebCore::WebKitNamedFlow::getContent):
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
(WebCore::WebKitNamedFlow::dispatchRegionOversetChangeEvent):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::namedItems):
- html/HTMLCollection.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getNamedElements):
- html/HTMLFormElement.h:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):
- 2:23 PM Changeset in webkit [156250] by
-
- 12 edits in trunk/Source/WebCore
CTTE: RenderNamedFlowThread and FlowThreadController should operate on Elements, not Nodes
https://bugs.webkit.org/show_bug.cgi?id=121768
Reviewed by Andreas Kling.
- dom/Element.cpp:
(WebCore::Element::unregisterNamedFlowContentElement):
(WebCore::Element::shouldMoveToFlowThread):
(WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):
- dom/Element.h:
Update to new names and to pass this as a reference to the FlowThreadController.
- dom/Node.cpp:
- dom/Node.h:
Move isRegisteredWithNamedFlow() to Element.
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContent):
(WebCore::WebKitNamedFlow::getRegions):
(WebCore::WebKitNamedFlow::getContent):
Update for contentNodes() -> contentElements() name change. Modernize the code a bit
as well.
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::registerNamedFlowContentElement):
(WebCore::FlowThreadController::unregisterNamedFlowContentElement):
(WebCore::FlowThreadController::isContentElementRegisteredWithAnyNamedFlow):
- rendering/FlowThreadController.h:
Change the Node* -> RenderNamedFlowThread* map to a Element* -> RenderNamedFlowThread*. Update
functions taking Node*s to take Element&s.
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::clearContentElements):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::hasContentElement):
(WebCore::isContainedInElements):
(WebCore::nextNodeInsideContentElement):
(WebCore::RenderNamedFlowThread::getRanges):
- rendering/RenderNamedFlowThread.h:
Change the NamedFlowContent set to store Elements rather than Nodes. Like with FlowThreadController,
update registration functions to take Element&s instead of Node*s, removing asserts.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
Update for new names.
- style/StyleResolveTree.cpp:
(WebCore::Style::moveToFlowThreadIfNeeded):
Pass the Element and RenderNamedFlowThread as references.
- 2:23 PM Changeset in webkit [156249] by
-
- 2 edits in trunk/Source/WebKit/win
Try to fix the windows build (take 2).
- DOMEventsClasses.cpp:
(DOMEvent::createInstance):
- 2:17 PM Changeset in webkit [156248] by
-
- 2 edits in trunk/Source/WebKit/win
Try to fix the windows build.
- DOMEventsClasses.cpp:
(DOMEvent::createInstance):
- 10:03 AM Changeset in webkit [156247] by
-
- 5 edits in trunk/Source/JavaScriptCore
Get rid of CodeBlock::RareData::callReturnIndexVector and most of the evil that it introduced
https://bugs.webkit.org/show_bug.cgi?id=121766
Reviewed by Andreas Kling.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::link):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- 5:49 AM Changeset in webkit [156246] by
-
- 6 edits in trunk/Source
Give purity hints to compiler to avoid penalizing repeated calls to some functions.
<https://webkit.org/b/121744>
Reviewed by Darin Adler.
Source/WebCore:
Mark the following functions pure:
- gcController()
- cssValuePool()
- threadGlobalData()
I had this idea when I saw Darin's patch to cache cssValuePool() in a local.
We know that this function will always return the same value, so we should just
share this knowledge with the compiler and let it do the cleverness instead.
Source/WTF:
Added a PURE_FUNCTION macro. This is supported on GCC and Clang for now.
Marking a function pure means that the compiler's CSE pass is free to coalesce
multiple calls to this function because it has no globally observable side
effects beyond the first call.
- 12:34 AM Changeset in webkit [156245] by
-
- 7 edits in trunk/Source/WebKit/mac
Remove unused code in WebKit/mac's WebScriptDebugDelegate.
https://bugs.webkit.org/show_bug.cgi?id=121706.
Reviewed by Timothy Hatcher.
WebScriptDebugDelegate's didEnterCallFrame, willExecuteStatement,
and willLeaveCallFrame are not in use. Removed them and all methods
and fields used for supporting them.
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebScriptDebugDelegate.h:
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFramePrivate dealloc]):
(-[WebScriptCallFrame _initWithGlobalObject:debuggerCallFrame:]):
- WebView/WebScriptDebugger.h:
(WebScriptDebugger::globalObject):
(WebScriptDebugger::callEvent):
(WebScriptDebugger::atStatement):
(WebScriptDebugger::returnEvent):
(WebScriptDebugger::willExecuteProgram):
(WebScriptDebugger::didExecuteProgram):
(WebScriptDebugger::didReachBreakpoint):
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::WebScriptDebugger):
(WebScriptDebugger::exception):
- WebView/WebView.mm:
(-[WebView _cacheScriptDebugDelegateImplementations]):
- 12:15 AM Changeset in webkit [156244] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix accessibility-node-memory-management.html to use normal style for
GC-related tests, making it more robust
https://bugs.webkit.org/show_bug.cgi?id=121760
Rubber-stamped by Alexey Proskuryakov.
Change was accidentally landed in previous commit, this is the change log
that goes with it.
- accessibility/accessibility-node-memory-management.html:
Use jsTestIsAsync and setTimeout to do the garbage collection without the
rest of the script state on the stack. Also removed a lot of unneeded
"window." since the test works fine without them and tweaked comments.
- 12:11 AM Changeset in webkit [156243] by
-
- 3 edits in trunk
Fix too-strict type error exceptions introduced in WebGL bindings
https://bugs.webkit.org/show_bug.cgi?id=121759
Reviewed by Alexey Proskuryakov.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::getAttachedShaders): Allow undefined
or null without throwing type error.
(WebCore::JSWebGLRenderingContext::getProgramParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getUniform): Ditto.
(WebCore::dataFunctionf): Ditto.
(WebCore::dataFunctioni): Ditto.
(WebCore::dataFunctionMatrix): Ditto.
Sep 21, 2013:
- 10:00 PM Changeset in webkit [156242] by
-
- 15 edits in trunk/Source/JavaScriptCore
Interpreter::unwind() has no need for the bytecodeOffset
https://bugs.webkit.org/show_bug.cgi?id=121755
Reviewed by Oliver Hunt.
It was only using the bytecodeOffset for some debugger stuff, but the debugger could
just get the bytecodeOffset the same way the rest of the machinery does: by using the
CallFrame's location.
It turns out that a lot of really ugly code was in place just to supply this
bytecodeOffset. This patch kills most of that code, and allows us to kill even more
code in a future patch - though most likely that killage will involve further
refactorings as well, see https://bugs.webkit.org/show_bug.cgi?id=121734.
- dfg/DFGOperations.cpp:
- interpreter/CallFrame.cpp:
(JSC::CallFrame::bytecodeOffset):
(JSC::CallFrame::codeOrigin):
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
- interpreter/Interpreter.h:
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- jit/JITExceptions.h:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::cti_vm_handle_exception):
- llint/LLIntExceptions.cpp:
(JSC::LLInt::doThrow):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntExceptions.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPathsExceptions.cpp:
(JSC::CommonSlowPaths::interpreterThrowInCaller):
- runtime/CommonSlowPathsExceptions.h:
- 9:15 PM Changeset in webkit [156241] by
-
- 202 edits in trunk/Source/WebCore
Event and EventTarget interfaces don't need to be store as AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=121751
Reviewed by Andreas Kling.
Convert the Event and EventTarget interface identifiers from AtomicStrings to enums. They
are not extensible and not exposed as Strings anywhere.
- Files elided *
- 9:02 PM Changeset in webkit [156240] by
-
- 46 edits in trunk/Source
Add ExecState::uncheckedArgument and use where possible to shrink a bit
https://bugs.webkit.org/show_bug.cgi?id=121750
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- interpreter/CallFrame.h:
(JSC::ExecState::uncheckedArgument): Added. Like argument, but with an
assertion rather than a runtime check.
- API/APICallbackFunction.h:
(JSC::APICallbackFunction::call): Use uncheckedArgument because we are
already in a loop over arguments, so don't need a range check.
- API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback): Ditto.
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::construct): Ditto.
(JSC::JSCallbackObject::call): Ditto.
- jsc.cpp:
(functionPrint): Ditto.
(functionRun): Ditto.
(functionSetSamplingFlags): Ditto.
(functionClearSamplingFlags): Ditto.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat): Ditto.
(JSC::arrayProtoFuncPush): Use uncheckedArgument because there is already
code that explicitly checks argumentCount.
(JSC::arrayProtoFuncSplice): Ditto.
(JSC::arrayProtoFuncUnShift): Ditto.
(JSC::arrayProtoFuncReduce): Ditto.
(JSC::arrayProtoFuncReduceRight): Ditto.
(JSC::arrayProtoFuncLastIndexOf): Ditto.
- runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingTimeArgs): Ditto.
(JSC::fillStructuresUsingDateArgs): Ditto.
- runtime/JSArrayBufferConstructor.cpp:
(JSC::constructArrayBuffer): Ditto.
- runtime/JSArrayBufferPrototype.cpp:
(JSC::arrayBufferProtoFuncSlice): Ditto.
- runtime/JSBoundFunction.cpp:
(JSC::boundFunctionCall): Ditto.
(JSC::boundFunctionConstruct): Ditto.
- runtime/JSDataViewPrototype.cpp:
(JSC::getData): Ditto.
(JSC::setData): Ditto.
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayView): Ditto.
- runtime/JSGenericTypedArrayViewPrototypeInlines.h:
(JSC::genericTypedArrayViewProtoFuncSet): Ditto.
(JSC::genericTypedArrayViewProtoFuncSubarray): Ditto.
- runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse): Ditto.
(JSC::JSONProtoFuncStringify): Ditto.
- runtime/JSPromiseConstructor.cpp:
(JSC::constructPromise): Ditto.
(JSC::JSPromiseConstructorFuncFulfill): Ditto.
(JSC::JSPromiseConstructorFuncResolve): Ditto.
(JSC::JSPromiseConstructorFuncReject): Ditto.
- runtime/MathObject.cpp:
(JSC::mathProtoFuncMax): Ditto.
(JSC::mathProtoFuncMin): Ditto.
- runtime/NameConstructor.cpp:
(JSC::constructPrivateName): Removed unneeded check of argumentCout
that simply repeats what argument already does.
- runtime/NativeErrorConstructor.cpp:
(JSC::Interpreter::constructWithNativeErrorConstructor): Ditto.
(JSC::Interpreter::callNativeErrorConstructor): Ditto.
- runtime/NumberConstructor.cpp:
(JSC::constructWithNumberConstructor): Use uncheckedArgument since
there is already code that explicitly checks argument count.
(JSC::callNumberConstructor): Ditto.
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorCreate): Small refactoring to not call argument(0)
three times.
- runtime/SetConstructor.cpp:
(JSC::constructSet): Use uncheckedArgument since we are already in a loop
over arguments.
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCodeSlowCase): In a loop.
(JSC::stringFromCharCode): Already checked count.
(JSC::constructWithStringConstructor): Ditto.
(JSC::callStringConstructor): Ditto.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncConcat): Already checked count.
- runtime/TestRunnerUtils.cpp:
(JSC::numberOfDFGCompiles): Ditto.
(JSC::setNeverInline): Ditto.
Source/WebCore:
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::probablySupportsContext): Already checked count.
(WebCore::JSHTMLCanvasElement::toDataURL): Ditto.
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::documentWrite): In a loop.
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::inspectedObject): Already checked count.
(WebCore::JSInjectedScriptHost::internalConstructorName): Ditto.
(WebCore::JSInjectedScriptHost::isHTMLAllCollection): Ditto.
(WebCore::JSInjectedScriptHost::type): Ditto.
(WebCore::JSInjectedScriptHost::functionDetails): Ditto.
(WebCore::JSInjectedScriptHost::getEventListeners): Ditto.
(WebCore::JSInjectedScriptHost::inspect): Ditto.
(WebCore::JSInjectedScriptHost::databaseId): Ditto.
(WebCore::JSInjectedScriptHost::storageId): Ditto.
- bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql): Ditto.
- bindings/js/JSSVGLengthCustom.cpp:
(WebCore::JSSVGLength::convertToSpecifiedUnits): Ditto.
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Ditto.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter): Already checked count.
(WebCore::JSWebGLRenderingContext::getAttachedShaders): Removed tortured code
to triply do the checking that the toWebGLProgram function already does, including
spurious exception checking in code that can't create an exception. Also count is
already checked.
(WebCore::JSWebGLRenderingContext::getExtension): More of the same.
(WebCore::JSWebGLRenderingContext::getFramebufferAttachmentParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getProgramParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getShaderParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getUniform): Ditto.
(WebCore::dataFunctionf): Ditto.
(WebCore::dataFunctioni): Ditto.
(WebCore::dataFunctionMatrix): Ditto.
- bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::importScripts): In a loop.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open): Already checked. Also removed some unneeded
argument count checks.
(WebCore::JSXMLHttpRequest::send): Removed unneeded special case for 0 argument
count that does the same thing as the undefined case, since asking for an
argument past the count yields undefined.
- bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessor::setParameter): Already checked.
(WebCore::JSXSLTProcessor::getParameter): Already checked.
(WebCore::JSXSLTProcessor::removeParameter): Already checked.
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction): In a loop.
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptArguments): Ditto.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck): Removed some excess argumentCount checks.
Used uncheckedArgument in a few places. More needs to be done, especially for
overloaded functions.
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::invokeMethod): In a loop.
(JSC::Bindings::CInstance::invokeDefaultMethod): Ditto.
- bridge/objc/objc_instance.mm:
(ObjcInstance::invokeObjcMethod): Ditto.
(ObjcInstance::invokeDefaultMethod): Ditto.
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
Updated.
Source/WebKit2:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::callMethod): In a loop.
(WebKit::JSNPObject::callObject): Ditto.
(WebKit::JSNPObject::callConstructor): Ditto.
- 8:48 PM Changeset in webkit [156239] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove the notion that a CallFrame can have a pointer to an InlineCallFrame, since that doesn't happen anymore
https://bugs.webkit.org/show_bug.cgi?id=121753
Reviewed by Darin Adler.
- interpreter/CallFrame.cpp:
(JSC::CallFrame::bytecodeOffsetFromCodeOriginIndex):
- interpreter/CallFrame.h:
- interpreter/Register.h:
- 5:31 PM Changeset in webkit [156238] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix the revert.
- dfg/DFGRepatch.cpp:
- 5:24 PM Changeset in webkit [156237] by
-
- 29 edits4 adds7 deletes in trunk/Source/JavaScriptCore
Unreviewed, revert http://trac.webkit.org/changeset/156235. It won't work on Windows.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlink):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
- bytecode/StructureStubInfo.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExitCompiler.h:
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- dfg/DFGOperations.h:
(JSC::DFG::operationNewTypedArrayWithSizeForType):
(JSC::DFG::operationNewTypedArrayWithOneArgumentForType):
- dfg/DFGRegisterSet.h: Added.
(JSC::DFG::RegisterSet::RegisterSet):
(JSC::DFG::RegisterSet::asPOD):
(JSC::DFG::RegisterSet::copyInfo):
(JSC::DFG::RegisterSet::set):
(JSC::DFG::RegisterSet::setGPRByIndex):
(JSC::DFG::RegisterSet::clear):
(JSC::DFG::RegisterSet::get):
(JSC::DFG::RegisterSet::getGPRByIndex):
(JSC::DFG::RegisterSet::getFreeGPR):
(JSC::DFG::RegisterSet::setFPRByIndex):
(JSC::DFG::RegisterSet::getFPRByIndex):
(JSC::DFG::RegisterSet::setByIndex):
(JSC::DFG::RegisterSet::getByIndex):
(JSC::DFG::RegisterSet::numberOfSetGPRs):
(JSC::DFG::RegisterSet::numberOfSetFPRs):
(JSC::DFG::RegisterSet::numberOfSetRegisters):
(JSC::DFG::RegisterSet::setBit):
(JSC::DFG::RegisterSet::clearBit):
(JSC::DFG::RegisterSet::getBit):
- dfg/DFGRepatch.cpp: Added.
(JSC::DFG::repatchCall):
(JSC::DFG::repatchByIdSelfAccess):
(JSC::DFG::addStructureTransitionCheck):
(JSC::DFG::replaceWithJump):
(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::repatchGetByID):
(JSC::DFG::getPolymorphicStructureList):
(JSC::DFG::patchJumpToGetByIdStub):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::buildGetByIDList):
(JSC::DFG::appropriateGenericPutByIdFunction):
(JSC::DFG::appropriateListBuildingPutByIdFunction):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::repatchPutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::buildPutByIdList):
(JSC::DFG::tryRepatchIn):
(JSC::DFG::repatchIn):
(JSC::DFG::linkSlowFor):
(JSC::DFG::linkFor):
(JSC::DFG::linkClosureCall):
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):
- dfg/DFGRepatch.h: Added.
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):
- dfg/DFGScratchRegisterAllocator.h: Added.
(JSC::DFG::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::lock):
(JSC::DFG::ScratchRegisterAllocator::allocateScratch):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::DFG::ScratchRegisterAllocator::didReuseRegisters):
(JSC::DFG::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::DFG::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::DFG::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGThunks.cpp:
(JSC::DFG::emitPointerValidation):
(JSC::DFG::throwExceptionFromCallSlowPathGenerator):
(JSC::DFG::slowPathFor):
(JSC::DFG::linkForThunkGenerator):
(JSC::DFG::linkCallThunkGenerator):
(JSC::DFG::linkConstructThunkGenerator):
(JSC::DFG::linkClosureCallThunkGenerator):
(JSC::DFG::virtualForThunkGenerator):
(JSC::DFG::virtualCallThunkGenerator):
(JSC::DFG::virtualConstructThunkGenerator):
- dfg/DFGThunks.h:
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- ftl/FTLOSRExitCompiler.h:
- jit/AssemblyHelpers.h:
- jit/JIT.cpp:
(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):
- jit/JITCall.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITOperationWrappers.h: Removed.
- jit/JITOperations.cpp: Removed.
- jit/JITOperations.h: Removed.
- jit/RegisterSet.h: Removed.
- jit/Repatch.cpp: Removed.
- jit/Repatch.h: Removed.
- jit/ScratchRegisterAllocator.h: Removed.
- jit/ThunkGenerators.cpp:
(JSC::generateSlowCaseFor):
(JSC::linkForGenerator):
(JSC::linkCallGenerator):
(JSC::linkConstructGenerator):
(JSC::linkClosureCallGenerator):
(JSC::virtualForGenerator):
(JSC::virtualCallGenerator):
(JSC::virtualConstructGenerator):
- jit/ThunkGenerators.h:
- 5:11 PM Changeset in webkit [156236] by
-
- 2 edits in trunk/Source/WebCore
Fix Obj-C bindings test expectations.
Unreviewed.
Bindings tests failed with r156232, from https://bugs.webkit.org/show_bug.cgi?id=121745.
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj reflectedStringAttr]): Update test expectations.
- 4:10 PM Changeset in webkit [156235] by
-
- 29 edits7 adds4 deletes in trunk/Source/JavaScriptCore
Move DFG inline caching logic into jit/
https://bugs.webkit.org/show_bug.cgi?id=121749
Rubber stamped by Sam Weinig.
We want to get rid of the baseline JIT's inline caching machinery and have it use the
DFG's instead. But before we do that we need to move the DFG's inline caching machine
out from behind its ENABLE(DFG_JIT) guards and make it available to the whole system.
This patch does that:
- dfg/DFGRepatch becomes jit/Repatch.
- The thunks used by the DFG IC go into jit/ThunkGenerators, instead of dfg/DFGThunks.
- The operations used by the DFG IC go into jit/JITOperations, instead of dfg/DFGOperations.
- The old JIT's thunk generators for calls are renamed to reduce confusion. Previously it was easy to know which generators belong to which JIT because the old JIT used JSC::virtualCallBlah and the DFG used JSC::DFG::virtualCallBlah, but that's not the case anymore. Note that the old JIT's thunk generators will die in a future patch.
No functional changes beyond those moves.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlink):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
- bytecode/StructureStubInfo.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExitCompiler.h:
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- dfg/DFGOperations.h:
(JSC::DFG::operationNewTypedArrayWithSizeForType):
(JSC::DFG::operationNewTypedArrayWithOneArgumentForType):
- dfg/DFGRegisterSet.h: Removed.
- dfg/DFGRepatch.cpp: Removed.
- dfg/DFGRepatch.h: Removed.
- dfg/DFGScratchRegisterAllocator.h: Removed.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGThunks.cpp:
- dfg/DFGThunks.h:
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::writeBarrier):
- jit/JIT.cpp:
(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):
- jit/JITCall.cpp:
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITOperationWrappers.h: Added.
- jit/JITOperations.cpp: Added.
- jit/JITOperations.h: Added.
- jit/RegisterSet.h: Added.
(JSC::RegisterSet::RegisterSet):
(JSC::RegisterSet::asPOD):
(JSC::RegisterSet::copyInfo):
(JSC::RegisterSet::set):
(JSC::RegisterSet::setGPRByIndex):
(JSC::RegisterSet::clear):
(JSC::RegisterSet::get):
(JSC::RegisterSet::getGPRByIndex):
(JSC::RegisterSet::getFreeGPR):
(JSC::RegisterSet::setFPRByIndex):
(JSC::RegisterSet::getFPRByIndex):
(JSC::RegisterSet::setByIndex):
(JSC::RegisterSet::getByIndex):
(JSC::RegisterSet::numberOfSetGPRs):
(JSC::RegisterSet::numberOfSetFPRs):
(JSC::RegisterSet::numberOfSetRegisters):
(JSC::RegisterSet::setBit):
(JSC::RegisterSet::clearBit):
(JSC::RegisterSet::getBit):
- jit/Repatch.cpp: Added.
(JSC::repatchCall):
(JSC::repatchByIdSelfAccess):
(JSC::addStructureTransitionCheck):
(JSC::replaceWithJump):
(JSC::emitRestoreScratch):
(JSC::linkRestoreScratch):
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::repatchGetByID):
(JSC::getPolymorphicStructureList):
(JSC::patchJumpToGetByIdStub):
(JSC::tryBuildGetByIDList):
(JSC::buildGetByIDList):
(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateListBuildingPutByIdFunction):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryCachePutByID):
(JSC::repatchPutByID):
(JSC::tryBuildPutByIdList):
(JSC::buildPutByIdList):
(JSC::tryRepatchIn):
(JSC::repatchIn):
(JSC::linkSlowFor):
(JSC::linkFor):
(JSC::linkClosureCall):
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):
- jit/Repatch.h: Added.
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):
- jit/ScratchRegisterAllocator.h: Added.
(JSC::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::ScratchRegisterAllocator::lock):
(JSC::ScratchRegisterAllocator::allocateScratch):
(JSC::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::ScratchRegisterAllocator::didReuseRegisters):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):
- jit/ThunkGenerators.cpp:
(JSC::oldStyleGenerateSlowCaseFor):
(JSC::oldStyleLinkForGenerator):
(JSC::oldStyleLinkCallGenerator):
(JSC::oldStyleLinkConstructGenerator):
(JSC::oldStyleLinkClosureCallGenerator):
(JSC::oldStyleVirtualForGenerator):
(JSC::oldStyleVirtualCallGenerator):
(JSC::oldStyleVirtualConstructGenerator):
(JSC::emitPointerValidation):
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::slowPathFor):
(JSC::linkForThunkGenerator):
(JSC::linkCallThunkGenerator):
(JSC::linkConstructThunkGenerator):
(JSC::linkClosureCallThunkGenerator):
(JSC::virtualForThunkGenerator):
(JSC::virtualCallThunkGenerator):
(JSC::virtualConstructThunkGenerator):
- jit/ThunkGenerators.h:
- 1:02 PM Changeset in webkit [156234] by
-
- 5 edits in trunk/Source/WebCore
Node: FINAL-ize EventTarget overrides.
<https://webkit.org/b/121748>
Reviewed by Darin Adler.
Mark the following Node functions FINAL:
- scriptExecutionContext()
- eventTargetData()
- ensureEventTargetData()
This devirtualizes a myriad of generated calls in the JSC bindings.
- 12:05 PM Changeset in webkit [156233] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix the non-DFG build.
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::r):
- 11:46 AM Changeset in webkit [156232] by
-
- 2 edits in trunk/Source/WebCore
Don't bloat Obj-C bindings with inlined attribute retrieval.
<https://webkit.org/b/121745>
Reviewed by Anders Carlsson.
Hack bindings generator to always use getAttribute() for Objective-C.
Reduces WebCore binary size by 25120 bytes.
- 11:25 AM Changeset in webkit [156231] by
-
- 38 edits2 deletes in trunk/Source/WebCore
Shink attribute event listener code
https://bugs.webkit.org/show_bug.cgi?id=121735
Reviewed by Antti Koivisto.
- GNUmakefile.list.am: Eliminate ScriptEventListener source files.
- Target.pri: Ditto.
- UseJSC.cmake: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/JSDOMGlobalObject.h: Removed unneeded forward declarations
of JSEventListener and JSLazyEventListener.
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener): Changed type to
ContainerNode because the node pointer is only ever used for elements
and documents.
(WebCore::eventParameterName): Moved this function here from
ScriptEventListener.cpp, but also rewrote to use NeverDestroyed.
(WebCore::JSLazyEventListener::createForNode): Moved this function
here from ScriptEventListener.cpp, cleaned up a bit.
(WebCore::JSLazyEventListener::createForDOMWindow): Ditto.
- bindings/js/JSLazyEventListener.h: Replaced the old create function
with two new create functions we can use directly. Also used some
OVERRIDE, some FINAL, and a bit of WTF_DELETED_FUNCTION so we don't
accidentally call create and create a non-lazy listener.
- bindings/js/ScriptEventListener.cpp: Removed.
- bindings/js/ScriptEventListener.h: Removed.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::setAttributeEventListener): Added.
Calls JSLazyEventListener::createForNode and then calls the other
overload of setAttributeEventListener, to obviate having more code
at the call site.
- dom/ContainerNode.h: Added overload of setAttributeEventListener
for convenient use in Document and Element implementations.
- dom/Document.cpp:
(WebCore::Document::prepareForDestruction): Use m_domWindow instead
of the domWindow() function.
(WebCore::Document::removeAllEventListeners): Ditto.
(WebCore::Document::errorEventTarget): Ditto.
(WebCore::Document::takeDOMWindowFrom): Ditto.
(WebCore::Document::setWindowAttributeEventListener): Ditto. Also
added an overload that calls JSLazyEventListener::createForDOMWindow.
(WebCore::Document::getWindowAttributeEventListener): Use m_domWindow.
(WebCore::Document::dispatchWindowEvent): Ditto.
(WebCore::Document::dispatchWindowLoadEvent): Ditto.
(WebCore::Document::enqueueWindowEvent): Ditto.
(WebCore::Document::enqueuePopstateEvent): Ditto.
- dom/Document.h: Added overload of setWindowAttributeEventListener.
- html/HTMLBodyElement.cpp: Removed unnneded include.
(WebCore::HTMLBodyElement::parseAttribute): Removed all the calls to
createAttributeEventListener, and use the setAttributeEventListener
overloads instead.
- html/HTMLButtonElement.cpp: Ditto.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute): Ditto.
- html/HTMLFormControlElement.cpp: Ditto.
- html/HTMLFormElement.cpp: Ditto.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute): Ditto.
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseAttribute): Ditto.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute): Ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute): Ditto.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute): Ditto.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseAttribute): Ditto.
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseAttribute): Ditto.
- html/HTMLSelectElement.cpp: Ditto.
- html/HTMLStyleElement.cpp: Ditto.
- html/HTMLTextFormControlElement.cpp: Ditto.
- html/HTMLTrackElement.cpp: Ditto.
- html/track/LoadableTextTrack.cpp: Ditto.
- svg/SVGElement.cpp:
(WebCore::SVGElement::parseAttribute): Ditto.
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseAttribute): Ditto.
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::parseAttribute): Ditto.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
Moved the code here to dig inside a JSEventListener for things like
the source location. This used to be spread across multiple function
calls in ScriptEventListener.h, which were doing and redoing the same
things, so better to just get it all at once.
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init): Fixed "minium" typo.
- 10:47 AM Changeset in webkit [156230] by
-
- 3 edits in trunk/Source/WebCore
Don't store the "processing-instruction" string for PI tokens in the XPath parser
https://bugs.webkit.org/show_bug.cgi?id=121746
Reviewed by Antti Koivisto.
For PI tokens, the string is always going to be "processing-instruction", and it's never used so we don't need to save it.
- xml/XPathGrammar.y:
- xml/XPathParser.cpp:
(Parser::nextTokenInternal):
(Parser::lex):
- 10:40 AM Changeset in webkit [156229] by
-
- 8 edits3 adds in trunk
Get rid of IsInlinedCodeTag and its associated methods since it's unused
https://bugs.webkit.org/show_bug.cgi?id=121737
Source/JavaScriptCore:
Reviewed by Sam Weinig.
This was meant to be easy, but I kept wondering if it was safe to remove the
inline call frame check in Arguments::tearOff(). The check was clearly dead
since the bit wasn't being set anywhere.
It turns out that the unwindCallFrame() function was relying on tearOff()
doing the right thing for inlined code, but it wasn't even passing it an
inline call frame. I fixed this by having unwindCallFrame() inlining check,
while also making sure that the code uses the right operand index for the
arguments register.
- interpreter/CallFrame.h:
- interpreter/CallFrameInlines.h:
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::r):
- interpreter/StackVisitor.h:
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
LayoutTests:
Reviewed by Sam Weinig.
- js/dfg-inline-arguments-capture-throw-exception-expected.txt: Added.
- js/dfg-inline-arguments-capture-throw-exception.html: Added.
- js/script-tests/dfg-inline-arguments-capture-throw-exception.js: Added.
(foo):
(bar):
(makeF):
(recurse):
- 6:45 AM Changeset in webkit [156228] by
-
- 2 edits in trunk/Source/WebCore
Handle windows lineendings in makeprop.pl after r155511
https://bugs.webkit.org/show_bug.cgi?id=121740
Reviewed by Ryosuke Niwa.
Check for an optinal \r at the end of a line in regular expressions
to make it work again on native windows machines which use CRLF.
- css/makeprop.pl:
- 6:05 AM Changeset in webkit [156227] by
-
- 3 edits in trunk/Source/WebCore
Re-inline some hot ElementData functions.
<https://webkit.org/b/121743>
Reviewed by Antti Koivisto.
Make the following functions inline again:
- deref()
- addAttribute()
- removeAttribute()
- attributeAt()
They were out-of-lined in r154249 and perf.webkit.org reports a 1.4%
regression on the html5 spec for that revision. This'll hopefully steer
the graph back in the right direction.
- 3:52 AM Changeset in webkit [156226] by
-
- 13 edits2 moves in trunk/Source/WebCore
GeneratorGeneratedImage should be called GradientImage
https://bugs.webkit.org/show_bug.cgi?id=121085
Reviewed by Simon Fraser.
No new tests, just a refactor.
r150053 removed the concept of a Generator, making GeneratorGeneratedImage
take a Gradient. This leaves GeneratorGeneratedImage's name not making a
whole lot of sense, so let's rename it to GradientImage.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
- platform/graphics/BitmapImage.h:
- platform/graphics/GradientImage.cpp: Renamed from Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp.
(WebCore::GradientImage::draw):
(WebCore::GradientImage::drawPattern):
- platform/graphics/GradientImage.h: Renamed from Source/WebCore/platform/graphics/GeneratorGeneratedImage.h.
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.h:
Rename.
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::cachedImageForSize):
(WebCore::CSSImageGeneratorValue::saveCachedImageForSize):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):
- css/CSSImageGeneratorValue.h:
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::image):
Drive-by, the CSSImageGeneratorValue generated image cache should be
in terms of GeneratedImage, not a random subclass, regardless
of the fact that it's only used for GradientImage as of yet.
- 1:03 AM Changeset in webkit [156225] by
-
- 2 edits in trunk/Source/WebCore
Shrink valueForBasicShape by removing repeated calls to cssValuePool()
https://bugs.webkit.org/show_bug.cgi?id=121736
Reviewed by Sam Weinig.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape): Put the pool into a local variable and use that.
Sep 20, 2013:
- 10:35 PM Changeset in webkit [156224] by
-
- 2 edits in trunk/Source/WebCore
Another CSS parser leak fix
https://bugs.webkit.org/show_bug.cgi?id=121730
Reviewed by Alexey Proskuryakov.
- css/CSSGrammar.y.in: Added a missing adoptPtr.
- 10:35 PM Changeset in webkit [156223] by
-
- 2 edits in trunk/Source/WebCore
Handle panning gestures messages properly on Windows
https://bugs.webkit.org/show_bug.cgi?id=121711
Follow-up fix: five regression tests started to crash on Mac.
Reviewed by Anders Carlsson.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively):
Added null checks, not all callers are interested in scrolled view pointer.
- 9:13 PM Changeset in webkit [156222] by
-
- 3 edits2 adds in trunk
Bad cast from CSSInitialValue to CSSValueList
https://bugs.webkit.org/show_bug.cgi?id=121729
Source/WebCore:
Reviewed by Beth Dakin.
Merge https://chromium.googlesource.com/chromium/blink/+/fcfaa51f9207b32cffe751c1a1380a921e464cbb
The issue was that we would cast to CSSValueList without checking
the type of the CSSValue. After this change, we use the ASSERT'ing
cast and explicitly check the type of the CSSValue before the cast.
Test: fast/css/crash-inherit-value-font-family.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceValue):
LayoutTests:
Reviewed by Beth Dakin.
Add a regression test. This is not a merge since the test in the Blink change involves
superfluous execCommand calls.
- fast/css/crash-inherit-value-font-family-expected.txt: Added.
- fast/css/crash-inherit-value-font-family.html: Added.
- 9:11 PM Changeset in webkit [156221] by
-
- 5 edits in branches/safari-537.60-branch/Source
Merged r156219. <rdar://problem/12712495>
- 8:36 PM Changeset in webkit [156220] by
-
- 3 edits in trunk/Source/WebCore
Remove includes from LineWidth.h
https://bugs.webkit.org/show_bug.cgi?id=121716
Reviewed by Darin Adler.
In r156197 I removed logicalLineHeight from LineWidth.h, so we don't need to include RenderBlock.h
and RenderRubyRun.h anymore in LineWidth.h.
No new tests, no behavior change.
- rendering/LineWidth.cpp:
- rendering/LineWidth.h:
- 8:23 PM Changeset in webkit [156219] by
-
- 5 edits in trunk/Source
Handle panning gestures messages properly on Windows.
https://bugs.webkit.org/show_bug.cgi?id=121711.
Reviewed by Brent Fulgham.
This fixes a number of issues with panning gestures on Windows.
- Two finger panning in one direction can sometimes cause some unexpected scrolling
in the other direction when the gesture first begins (directions meaning horizontal and vertical)
- Single finger horizontal panning should only be disabled when attempting to select text.
- Scrolling via panning should be clamped, other wise we can scroll contents completely out of the scrollview.
- Horizontal overpan should work.
- Overpan should occur whenever we scroll to the extents of whichever scroll view we're currently scrolling.
- WebView.cpp:
(WebView::gestureNotify):
(WebView::gesture):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
- rendering/RenderLayer.h:
Added an argument to keep track of which scrollview was actually scrolled
This is needed by the Windows port to keep track to determine whether or not
we need to overpan.
- 6:25 PM Changeset in webkit [156218] by
-
- 3 edits in trunk/WebKitLibraries
Fix link errors for external users when building WebKit with Xcode 5.
Reviewed by Oliver Hunt.
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 5:57 PM Changeset in webkit [156217] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix after r156216.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: I accidentally exposed the symbol of the calling function, not the missing symbol!
- 5:51 PM Changeset in webkit [156216] by
-
- 2 edits in trunk/Source/WebKit
[WINDOWS] Unreviewed build fix after r156215.
- WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing symbols needed by DumpRenderTree.dll.
- 5:35 PM Changeset in webkit [156215] by
-
- 12 edits2 adds in trunk
Web Inspector: [CSS Regions] Display CSS Regions chain when highlighting a CSS Region node
https://bugs.webkit.org/show_bug.cgi?id=121719
Reviewed by Joseph Pecoraro.
Source/WebCore:
Test: inspector/elements/highlight-node-regions.html
When a CSS Region node is highlighted through the WebInspector, it will also lookup all the regions
that are part of the same flow and inject enough information into InspectorOverlayPage.js to get the other
CSS Regions highlighted as well. A chain will also link the regions and a number will display the ordering
of the content.
- WebCore.exp.in:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::buildObjectForHighlightedNode):
- inspector/InspectorController.h:
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForRegionHighlight):
(WebCore::buildObjectForCSSRegionsHighlight):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawNodeHighlight): Separated the InspectorObject building part out of this function,
so that we can call buildObjectForHighlightedNode from the Internals APIs for testing.
- inspector/InspectorOverlay.h:
- inspector/InspectorOverlayPage.js:
(_drawRegionNumber):
(_quadMidPoint):
(_drawRegionLink):
(_fixQuadScrollPosition):
(_drawRegionsHighlight):
(drawNodeHighlight):
- testing/Internals.cpp: Exposed the generated InspectorObject to the layout test.
(WebCore::Internals::inspectorHighlightObject):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Added test to check the position of the CSS Regions part of the same flow thread with
the highlighted CSS Region node.
- http/tests/inspector/elements-test.js:
- inspector/elements/highlight-node-regions-expected.txt: Added.
- inspector/elements/highlight-node-regions.html: Added.
- 5:24 PM Changeset in webkit [156214] by
-
- 3 edits3 adds in trunk
(un)shiftCountWithAnyIndexingType will start over in the middle of copying if it sees a hole
https://bugs.webkit.org/show_bug.cgi?id=121717
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This bug caused the array to become corrupted. We now check for holes before we start moving things,
and start moving things only once we've determined that there are none.
- runtime/JSArray.cpp:
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithAnyIndexingType):
LayoutTests:
Added test to make sure that splicing an array with holes works correctly.
- js/array-splice-with-holes-expected.txt: Added.
- js/array-splice-with-holes.html: Added.
- js/script-tests/array-splice-with-holes.js: Added.
- 5:07 PM Changeset in webkit [156213] by
-
- 2 edits in trunk/LayoutTests
Fix test after <http://trac.webkit.org/changeset/156203>
- platform/mac/accessibility/aria-help.html: Correct paths to JS tests.
- 5:07 PM Changeset in webkit [156212] by
-
- 3 edits3 adds in trunk
REGRESSION(r156047): WebCore hangs inside JSC::toInt32(double)
https://bugs.webkit.org/show_bug.cgi?id=121648
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
The Int52<->StrictInt52 conversion did the opposite fill() than what it was
supposed to. For example when converting a Int52 to a StrictInt52 it would fill
as Int52, and vice-versa.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
LayoutTests:
Reviewed by Mark Hahnenberg.
- js/dfg-int52-change-format-expected.txt: Added.
- js/dfg-int52-change-format.html: Added.
- js/script-tests/dfg-int52-change-format.js: Added.
(foo):
- 5:00 PM Changeset in webkit [156211] by
-
- 3 edits3 adds in trunk
REGRESSION(r153215): New iCloud site crashes
https://bugs.webkit.org/show_bug.cgi?id=121710
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Don't claim to be able to rely on the arguments structure, use the Arguments
speculation type
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
LayoutTests:
New test case
- js/dfg-arguments-mutated-structure-expected.txt: Added.
- js/dfg-arguments-mutated-structure.html: Added.
- js/script-tests/dfg-arguments-mutated-structure.js: Added.
(foo):
- 4:59 PM Changeset in webkit [156210] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r156185.
http://trac.webkit.org/changeset/156185
https://bugs.webkit.org/show_bug.cgi?id=121727
Caused a lot of crashes in tests (Requested by ap on #webkit).
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateLayout):
- dom/Document.h:
LayoutTests:
- fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Removed.
- fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Removed.
- 4:45 PM Changeset in webkit [156209] by
-
- 9 edits in trunk/Source/WebInspectorUI
Parse MIME-types and strip them down to the base type when needed.
The use of charset in a MIME-type interferes with our type maps,
preventing the right syntax highlighting mode and pretty printing.
https://bugs.webkit.org/show_bug.cgi?id=121723
Reviewed by Joseph Pecoraro.
- UserInterface/ConsolePrompt.js:
(WebInspector.ConsolePrompt):
- UserInterface/FontResourceContentView.js:
- UserInterface/Resource.js:
(WebInspector.Resource.Type.fromMIMEType):
(WebInspector.Resource.prototype.get mimeTypeComponents):
(WebInspector.Resource.prototype.get syntheticMIMEType):
(WebInspector.Resource.prototype.get contentURL):
(WebInspector.Resource.prototype.updateForResponse):
- UserInterface/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):
- UserInterface/SourceMapResource.js:
(WebInspector.SourceMapResource.prototype.requestContentFromBackend):
- UserInterface/SyntaxHighlightingSupport.js:
(WebInspector.syntaxHighlightStringAsDocumentFragment):
- UserInterface/TextEditor.js:
(WebInspector.TextEditor.prototype.set mimeType):
- UserInterface/Utilities.js:
(parseMIMEType): Added.
- 4:01 PM Changeset in webkit [156208] by
-
- 5 edits in trunk
<https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
Tools:
Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
Reviewed by David Kilzer.
- Scripts/webkitdirs.pm:
(checkRequiredSystemConfig):
Websites/webkit.org:
Update references on webkit.org to mention Xcode 4.6 as the minimum version.
Reviewed by David Kilzer.
- building/debug-mac-uiprocess.html:
- building/tools.html:
- 3:52 PM Changeset in webkit [156207] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 3:48 PM Changeset in webkit [156206] by
-
- 1 copy in tags/Safari-537.60.2
New Tag.
- 3:17 PM Changeset in webkit [156205] by
-
- 3 edits in trunk/Source/WebCore
Shaders that fail to compile should be marked as such
https://bugs.webkit.org/show_bug.cgi?id=121721
Reviewed by Simon Fraser.
- Add a new logging channel for WebGL.
- If a translated shader fails to compile (technically
this should never happen), mark it as invalid.
- platform/Logging.h: New WebGL channel.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::compileShader): Log the raw and translated
input to glCompileShader, but mark the entry as invalid.
- 2:58 PM Changeset in webkit [156204] by
-
- 2 edits in trunk/Source/WTF
Add an implementation of std::index_sequence from C++14
https://bugs.webkit.org/show_bug.cgi?id=121718
Reviewed by Ryosuke Niwa.
This will make it easier to do things like pack expansion of tuple elements.
- wtf/StdLibExtras.h:
- 2:56 PM Changeset in webkit [156203] by
-
- 18 edits2 moves2 deletes in trunk
[ATK] Do not expose aria-help in ATK based platforms
https://bugs.webkit.org/show_bug.cgi?id=121675
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-20
Reviewed by Chris Fleizach.
Source/WebCore:
Stop exposing the value for the 'aria-help' attribute as an
AtkObject attribute, based in AccessibilityObject::helpText().
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Remove the mapping.
Source/WebKit/efl:
Removed accessibilityHelpText() helper method from
DumpRenderSupportEfl's API, since it's not longer needed.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp: Removed method.
- WebCoreSupport/DumpRenderTreeSupportEfl.h: Ditto.
Source/WebKit/gtk:
Removed accessibilityHelpText() helper method from
DumpRenderSupportGtk's API, since it's not longer needed.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Removed method.
- WebCoreSupport/DumpRenderTreeSupportGtk.h: Ditto.
Tools:
Remove the implementations for AccessibilityUIElement::helpText()
from DRT and WKTR for GTK and EFL, since they are based on the
AccessibilityObject::helpText() method and the 'aria-help'
attributes, which is wrong since they should not depend on that
but in ATK specific API (see also http://webkit.org/b/121684).
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::helpText): Added a new and empty
implementation, now that we are no longer using this in ATK.
- DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
as the only function provided here was helpText().
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
- DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
removed from the list of sources to compile.
- GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::helpText): Replaced old implementation
based in DumpRenderTreeSupportGtk with an empty one.
LayoutTests:
Moved test based in helpText() into the Mac directory, and update
expectations for platforms as needed.
- platform/mac/accessibility/aria-help-expected.txt: Renamed from LayoutTests/accessibility/aria-help-expected.txt.
- platform/mac/accessibility/aria-help.html: Renamed from LayoutTests/accessibility/aria-help.html.
- platform/gtk-wk2/TestExpectations: Removed failure expectation
for aria-help, now moved to Mac, and for aria-describedby-on-input,
which is now moved to the generic TestExpectations file for GTK.
- platform/gtk/TestExpectations: Added aria-describedby-on-input,
linking it to the newly filed bug 121684.
- platform/gtk-wk2/TestExpectations: Removed failure expectation.
- platform/win/TestExpectations: Removed failure expectation.
- platform/wincairo/TestExpectations: Ditto.
- 2:54 PM Changeset in webkit [156202] by
-
- 3 edits in branches/safari-537.60-branch/Source/WebCore
Correct build by activating Microsoft Assembler support in
project file. I have no idea why this would be missing in
the branch.
Patch by Brent Fulgham <Brent Fulgham> on 2013-09-20
- WebCore.vcxproj/WebCore.vcxproj: Activate MASM support.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- 2:47 PM Changeset in webkit [156201] by
-
- 7 edits in trunk/Source/WebCore
Scrollbars don't appear on long pages after r155660
https://bugs.webkit.org/show_bug.cgi?id=121714
<rdar://problem/15042478>
Reviewed by Beth Dakin.
After r155660, we don't do any additional layouts when scrollbars are
added or removed. That caused us to not enter the code that creates or
destroys composting layers for scrollbars in RenderLayerCompositor, resulting
in missing scrollbars.
Fix by having ScrollView::updateScrollbars() call addedOrRemovedScrollbar()
when a scrollbar was added or removed, which is overridden in FrameView
to call through to RenderLayerCompositor::frameViewDidAddOrRemoveScrollbars().
Not testable since scrollbar layers aren't contained in layer tree dumps
(to reduce diffs between platforms).
- page/FrameView.cpp:
(WebCore::FrameView::addedOrRemovedScrollbar): New function to tell the compositor
that scrollbars changed.
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Change the meaning of the return
value to say if the scrollbar was added or removed. Add an out param that indicates
whether the scrollbar change affects content size (not true for overlay scrollbars).
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): Keep track of whether scrollbars were
added or removed, and call addedOrRemovedScrollbar() if true.
- platform/ScrollView.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidAddOrRemoveScrollbars): Call updateOverflowControlsLayers().
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
- rendering/RenderLayerCompositor.h:
- 2:47 PM Changeset in webkit [156200] by
-
- 2 edits in trunk/Source/WebCore
Ensure that TileController tile coverage is updated on scrolling even when we don't have scrollbars
https://bugs.webkit.org/show_bug.cgi?id=121700
<rdar://problem/15030589>
Reviewed by Dean Jackson.
r155660 introduced a bug where we wouldn't make scrollbars on long pages. However,
that revealed a fundamental flaw in the TiledBacking update logic; it relied on the
GraphicsLayer flushes triggered by scrollbars updates in order to update the main
TileController's tile coverage. No scrollbars meant no tile coverage updates.
Fix by explicitly triggering a flush when the FrameView is scrolled (we get
notified about this on the main thread after the scrolling thread has moved
layers around).
No test since this will only be exposed for a short time while scrollbars are
broken.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
- 2:17 PM Changeset in webkit [156199] by
-
- 3 edits in trunk/Source/WebCore
Refactoring LineBreaker and RenderTextInfo out of RenderBlock.h
https://bugs.webkit.org/show_bug.cgi?id=121707
Reviewed by David Hyatt.
LineBreaker and RenderTextInfo are defined in RenderBlock.h, but only used in RenderBlockLineLayout.cpp.
Moving them there (LineBreaker needs to be a friend class of RenderBlock) in the first step in the process
of refactoring LineBreaker::NextSegmentBreak into more manageable chunks.
This change was reviewed and landed in Blink:
https://src.chromium.org/viewvc/blink?revision=157402&view=revision
No new tests.
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineBreaker::LineBreaker):
(WebCore::LineBreaker::lineWasHyphenated):
(WebCore::LineBreaker::positionedObjects):
(WebCore::LineBreaker::clear):
(WebCore::RenderTextInfo::RenderTextInfo):
(WebCore::RenderTextInfo::~RenderTextInfo):
(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):
(WebCore::LineBreaker::reset):
(WebCore::LineBreaker::nextLineBreak):
(WebCore::LineBreaker::nextSegmentBreak):
- 2:17 PM Changeset in webkit [156198] by
-
- 10 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix keyboard shortcuts for other platforms
https://bugs.webkit.org/show_bug.cgi?id=120657
Patch by Marcelo Morais <m.morais@samsung.com> on 2013-09-20
Reviewed by Timothy Hatcher.
Handling keyboard shortcuts according to the current platform.
- UserInterface/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
(.WebInspector.InspectorFrontendHostStub.prototype.platform): Added. Return the
current platform.
- UserInterface/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut.Modifier.get CommandOrControl): Added. Created keyboard
modifier to return Control or Command key according to current platform.
- UserInterface/ContentBrowser.js:
(WebInspector.ContentBrowser): Returning Control or Command key for keyboard
shortcuts according to current platform.
- UserInterface/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel): Ditto.
- UserInterface/FindBanner.js:
(WebInspector.FindBanner): Ditto.
- UserInterface/JavaScriptLogViewController.js:
(WebInspector.JavaScriptLogViewController): Ditto.
- UserInterface/LogContentView.js:
(WebInspector.LogContentView): Ditto.
- UserInterface/Main.js:
(WebInspector.contentLoaded): Ditto.
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel): Ditto.
- 1:53 PM Changeset in webkit [156197] by
-
- 6 edits in trunk/Source/WebCore
Move logicalHeightForLine out of LineWidth.h
https://bugs.webkit.org/show_bug.cgi?id=121575
Reviewed by David Hyatt.
In bug #121107 (r155565), I moved logicalHeightForLine into LineWidth.h as part of LineWidth
refactoring. LogicalHeightForLine without passing the second parameter uses RenderBlock::lineHeight
anyway, except it doesn't take -line-box-contain CSS property into account. For Shapes we don't
have implementation for variable-height lines (https://bugs.webkit.org/show_bug.cgi?id=95361) yet, so
so I modified the affected functions to call lineHeight directly. I renamed logicalHeightForLine
to minLineHeightForReplacedRenderer, and I made the second parameter a mandatory for that function.
No new tests, no behavior change.
- rendering/LineWidth.cpp:
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
- rendering/LineWidth.h:
- rendering/RenderBlock.cpp: Move the definition here.
(WebCore::RenderBlock::minLineHeightForReplacedRenderer):
- rendering/RenderBlock.h: Move the function here and rename it.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutShapeInsideInfo):
(WebCore::updateLogicalInlinePositions):
(WebCore::updateSegmentsForShapes):
- 1:40 PM Changeset in webkit [156196] by
-
- 2 edits in trunk/Source/WebCore
-[WebHTMLConveter _getFloat:forNode:property:] leaks
https://bugs.webkit.org/show_bug.cgi?id=121709
Reviewed by Enrica Casucci.
- platform/mac/HTMLConverter.mm:
(-[WebHTMLConverter _getFloat:forNode:property:]): Don't leak.
- 1:35 PM Changeset in webkit [156195] by
-
- 4 edits in trunk/Source/WebCore
Add an argument to ImageSource::createFrameAtIndex to hint a decoder that we expect a scaled image.
https://bugs.webkit.org/show_bug.cgi?id=121696
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-09-20
Reviewed by Antti Koivisto.
Add an argument to ImageSource::createFrameAtIndex. A platform image decoder can decide the optimal
scale based on the hint and pass the real scale it used for decoding.
No new tests, no behavior change.
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::createFrameAtIndex):
- platform/graphics/ImageSource.h:
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::createFrameAtIndex):
- 1:27 PM Changeset in webkit [156194] by
-
- 1 edit57 copies8 adds1 delete in trunk/LayoutTests
Move tests to new import location
https://bugs.webkit.org/show_bug.cgi?id=121701
Reviewed by Dirk Schulze.
The import script was previously importing the tests into an incorrect
path. This change uses the latest import script to import all of the
shapes tests to the right location.
There are also some small changes in the tests since they had some
more metadata added upstream, but there are no functional changes in
the tests with this change.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/rounded-rectangle.js: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/resources/rounded-rectangle.js.
(ellipseXIntercept):
(scanConvertRoundedRectangleOutside):
(genLeftRightRoundedRectFloatShapeOutsideRefTest):
(genLeftRoundedRectFloatShapeOutsideRefTest):
(genRightRoundedRectFloatShapeOutsideRefTest):
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/subpixel-utils.js: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/resources/subpixel-utils.js.
(SubPixelLayout):
(SubPixelLayout.):
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Copied from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log: Added.
- csswg/submitted/shapes/shape-outside/w3c-import.log: Removed.
- 1:26 PM Changeset in webkit [156193] by
-
- 2 edits in trunk/Source/WebCore
Make JSMainThreadNullState noncopyable.
Blindly rubber-stamped by Antti Koivisto.
- bindings/js/JSMainThreadExecState.h:
- 1:23 PM Changeset in webkit [156192] by
-
- 2 edits in trunk/Source/JavaScriptCore
Clobberize phase forgets to indicate that it writes GCState for several node types
https://bugs.webkit.org/show_bug.cgi?id=121702
Reviewed by Oliver Hunt.
Added read and write for GCState to the nodes that could end up allocating (and thereby
cause a garbage collection).
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- 1:13 PM Changeset in webkit [156191] by
-
- 5 edits1 copy in trunk
Make extract-localizable-strings available to WebCore clients
https://bugs.webkit.org/show_bug.cgi?id=121699
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Added a Scripts group with a reference to
extract-localizable-strings.pl. Added a Copy Scripts build phase to the WebCore target that
copies the script into PrivateHeaders/Scripts in the framework.
- extract-localizable-strings.pl: Copied from Tools/Scripts/extract-localizable-strings.
Tools:
- Scripts/extract-localizable-strings: Copied to
Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
executes the script from its new location. This is a temporary measure until certain code
that is external to WebKit is adapted to the new location.
- Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
from its new location.
- 12:56 PM Changeset in webkit [156190] by
-
- 6 edits in trunk/Source/WebCore
Move layer hierarchy functions from RenderObject to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121692
Reviewed by Andreas Kling.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::addLayers):
(WebCore::RenderElement::removeLayers):
(WebCore::RenderElement::moveLayers):
(WebCore::RenderElement::findNextLayer):
(WebCore::RenderElement::layerCreationAllowedForSubtree):
Move these from RenderObject.
(WebCore::RenderElement::insertedIntoTree):
(WebCore::RenderElement::willBeRemovedFromTree):
Factor the layer related portion of these virtuals here.
- 12:29 PM Changeset in webkit [156189] by
-
- 6 edits in trunk/Source/WebCore
Start cleaning the API of SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121654
Reviewed by Antti Koivisto.
Make the matching mode internal.
Remove unused accessors.
Make isFrameFocused() internal.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
(WebCore::isFrameFocused):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::match):
- css/StyleResolver.h:
(WebCore::checkRegionSelector):
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):
- 12:28 PM Changeset in webkit [156188] by
-
- 3 edits in trunk/Source/WebCore
Remove SelectorChecker's CrossesBoundary boundary mode
https://bugs.webkit.org/show_bug.cgi?id=121653
Reviewed by Antti Koivisto.
This mode is an ancient vestige of shadow dom.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::checkOne):
- css/SelectorChecker.h:
- 12:27 PM Changeset in webkit [156187] by
-
- 3 edits in trunk/Source/WebCore
Move the SharingRules mode outside of SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121652
Reviewed by Antti Koivisto.
The SharingRules handling inside SelectorChecker is a weird hack
to hit a specific branch of ElementRuleCollector.
This patch moves the exception to ElementRuleCollector, where it is easier
to understand what it is for.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
- 12:09 PM Changeset in webkit [156186] by
-
- 3 edits3 adds in trunk
Fixed img src URLS with multiple spaces
https://bugs.webkit.org/show_bug.cgi?id=121592
Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-20
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/loader/image-src-multiple-space.html
I've removed the simplifyWhiteSpace step from HTMLImageElement's src attribute during the srcset selection algorithm.
That step prevented URLs with multiple spaces from being loaded as images, minimizing the multiple spaces into a single one.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::bestFitSourceForImageAttributes):
LayoutTests:
This test verifies that URLs with multiple spaces can be loaded as an image resource.
- fast/loader/image-src-multiple-space-expected.txt: Added.
- fast/loader/image-src-multiple-space.html: Added.
- 12:06 PM Changeset in webkit [156185] by
-
- 4 edits2 adds in trunk
Hiding a focused element should unfocus it and fire a blur event
https://bugs.webkit.org/show_bug.cgi?id=29241
Patch by Arunprasad Rajkumar <ararunprasad@gmail.com> on 2013-09-20
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/dom/HTMLDocument/active-element-gets-unfocusable.html
We check whether the current focus element is really focusable after
the style recalculation and layout change. If it is not focusable then schedule a
timer to reset it asynchronously.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle): Check isFocusable() on the focus element after
style recalculation.
(WebCore::Document::updateLayout): Check isFocusable() on the focus element after
layout.
(WebCore::Document::resetHiddenFocusElementSoon):
(WebCore::Document::resetHiddenFocusElementTimer):
- dom/Document.h:
LayoutTests:
- fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Added.
- fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Added.
LayoutTest reused from https://chromium.googlesource.com/chromium/blink/+/c58f636fd18fc27944c42e27d6a92a36867c57e1
with little modification.
- 11:42 AM Changeset in webkit [156184] by
-
- 39 edits5 adds5 deletes in trunk/Source/JavaScriptCore
Move CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
https://bugs.webkit.org/show_bug.cgi?id=121637
Rubber stamped by Michael Saboff.
Also moved GPRInfo/FPRInfo into jit/. Rolling back in after fixing JIT-only build
and tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext):
- dfg/DFGAssemblyHelpers.cpp: Removed.
- dfg/DFGAssemblyHelpers.h: Removed.
- dfg/DFGBinarySwitch.h:
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGCCallHelpers.h: Removed.
- dfg/DFGDisassembler.cpp:
- dfg/DFGFPRInfo.h: Removed.
- dfg/DFGGPRInfo.h: Removed.
- dfg/DFGGraph.cpp:
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExit.cpp:
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompiler.h:
- dfg/DFGOSRExitCompilerCommon.h:
- dfg/DFGRegisterBank.h:
- dfg/DFGRegisterSet.h:
- dfg/DFGRepatch.cpp:
- dfg/DFGSilentRegisterSavePlan.h:
- dfg/DFGThunks.cpp:
- dfg/DFGVariableEvent.cpp:
- ftl/FTLCArgumentGetter.h:
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
- ftl/FTLCompile.cpp:
- ftl/FTLExitThunkGenerator.h:
- ftl/FTLLink.cpp:
- ftl/FTLThunks.cpp:
- jit/AssemblyHelpers.cpp: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.cpp.
- jit/AssemblyHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h.
(JSC::AssemblyHelpers::AssemblyHelpers):
(JSC::AssemblyHelpers::debugCall):
- jit/CCallHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGCCallHelpers.h.
- jit/FPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGFPRInfo.h.
(WTF::printInternal):
- jit/GPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGGPRInfo.h.
(WTF::printInternal):
- jit/JIT.cpp:
(JSC::JIT::JIT):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
- jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::JSInterfaceJIT):
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):
- jit/ThunkGenerators.cpp:
(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
- llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
- runtime/JSCJSValue.h:
- 11:31 AM Changeset in webkit [156183] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r156140): Srcset tests are frequently crashing
https://bugs.webkit.org/show_bug.cgi?id=121695
Reviewed by Dean Jackson.
Returning a string created without copying bytes is not safe. It used to be OK
because a new string was immediately created by decodeURLEscapeSequences().
But even that was not great, because decodeURLEscapeSequences() could potentially
return the same string, not a deep copy, if we decided to optimize it like that.
Also made a number of drive-by style fixes.
- It's URL, not Url.
- It's srcset, not srcSet.
- We don't add ".0" in floating point value initializers. It's particularly misleading
to initialize a float with 1.0, which is a double value.
- Renamed srcSetLength to srcsetAttributeLength to match srcsetAttribute variable
whose length it caches.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseImagesWithScaleFromSrcsetAttribute):
(WebCore::bestFitSourceForImageAttributes):
- 11:12 AM Changeset in webkit [156182] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Clean up the Skip* functions in the GObject DOM bindings code generator
https://bugs.webkit.org/show_bug.cgi?id=121633
Reviewed by Gustavo Noronha Silva.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute): Fold in some skipping checks that are used by all callers.
(SkipFunction): Ditto.
(GenerateProperties): Rely on SkipAttribute more thoroughly.
(GenerateFunction): Rely on SkipFunction more thoroughly.
(GenerateFunctions): Rely on SkipAttribute more thoroughly.
- 10:44 AM Changeset in webkit [156181] by
-
- 2 edits in trunk/Source/WebCore
Fix the build after r156144
- html/canvas/CanvasRenderingContext2D.cpp: Added missing include.
- 10:32 AM Changeset in webkit [156180] by
-
- 3 edits in trunk/Source/WebCore
renderStyleOfEnclosingTextNode should update style before using a renderer
https://bugs.webkit.org/show_bug.cgi?id=121690
Reviewed by Enrica Casucci.
Merge https://chromium.googlesource.com/chromium/blink/+/65f089545e8c18cb268dfcbe56cba1cd8045527a
When accessing a renderer editing should always make sure that the style has been updated for the node.
Editing calls splitTextNode in a number of places and then accesses the renderer later. This patch is
the first of many to make sure editing always updates the style before attempting to access the renderer
(or style) of a node after calling a mutation method.
- editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::renderStyleOfEnclosingTextNode):
- editing/ApplyBlockElementCommand.h:
- 10:28 AM Changeset in webkit [156179] by
-
- 1 edit1 move in trunk/LayoutTests
Remove URL decoding in srcset handling
https://bugs.webkit.org/show_bug.cgi?id=121609
Followup to <http://trac.webkit.org/changeset/156161> - that change renamed expected
results, but the new test wasn't landed.
- fast/loader/image-src-encoded.html: Copied from LayoutTests/fast/loader/image-src-question-mark.html.
- fast/loader/image-src-question-mark.html: Removed.
- 10:18 AM Changeset in webkit [156178] by
-
- 3 edits in trunk/Source/WebCore
Fix a couple more CSS leaks
https://bugs.webkit.org/show_bug.cgi?id=121683
Reviewed by Alexey Proskuryakov.
- css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::viewSourceStyle): Put the result of the
parseUASheet into a global variable so it doesn't show up as a storage leak.
- css/CSSGrammar.y.in: Added a missing adoptRef. This was leaking any rule
we parsed individually.
- 10:16 AM Changeset in webkit [156177] by
-
- 1 edit4 deletes in trunk/Tools
Nuke remaining VS2005 tools from the tree.
https://bugs.webkit.org/show_bug.cgi?id=121691
Reviewed by Brent Fulgham.
- CLWrapper/CLWrapper.cpp: Removed.
- CLWrapper/CLWrapper.sln: Removed.
- CLWrapper/CLWrapper.vcproj: Removed.
- MIDLWrapper/MIDLWrapper.cpp: Removed.
- MIDLWrapper/MIDLWrapper.sln: Removed.
- MIDLWrapper/MIDLWrapper.vcproj: Removed.
- Scripts/parallelcl: Removed.
- vcbin/cl.exe: Removed.
- vcbin/midl.exe: Removed.
- 10:16 AM Changeset in webkit [156176] by
-
- 8 edits in trunk/Source/WebCore
Simplify the ShapeOutsideInfo and ShapeInfo interfaces
https://bugs.webkit.org/show_bug.cgi?id=121685
Reviewed by Darin Adler.
With the creation ShapeInfo::computeSegmentsForLine, it became possible to
simplify the ShapeInfo classes. ShapeOutsideInfo has no need to save the
segments, and now that segment creation is in its own method, it doesn't have
to save the segments anymore. This also simplifies the public interface of
ShapeOutsideInfo, as it only has one method to do the computation.
Also, the methods in ShapeOutsideInfo have been renamed to reflect the fact
that ShapeOutsideInfo isn't really interested in segments.
No new tests, no new behavior.
- rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
- rendering/LineWidth.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
- rendering/shapes/ShapeInfo.cpp:
- rendering/shapes/ShapeInfo.h:
- rendering/shapes/ShapeInsideInfo.h:
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
- rendering/shapes/ShapeOutsideInfo.h:
- 10:10 AM Changeset in webkit [156175] by
-
- 2 edits in trunk/Source/WebCore
Making tests added in r156157 JS-only, given that other
code generators are still broken.
Original bug 121305 (StrictTypeChecking extended attribute fails for methods with sequence<T>).
https://bugs.webkit.org/show_bug.cgi?id=121305
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com> on 2013-09-20
Rubber stamped by Alexey Proskuryakov.
- bindings/scripts/test/TestObj.idl:
- 10:07 AM Changeset in webkit [156174] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Poor rendering opening a Google map short link
https://bugs.webkit.org/show_bug.cgi?id=121687
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-09-20
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.
JIRA 495023
Route lines on google map were shown even they were on a hidden canvas.
Include visibility on LayerWebKitThread if it's a canvas layer and respect
the visibility when compositing layers in LayerRenderer.
- platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::isCanvasLayer):
(WebCore::LayerData::isVisible):
(WebCore::LayerData::includeVisibility):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayersRecursive):
- 9:57 AM Changeset in webkit [156173] by
-
- 2 edits in trunk/Source/WebInspectorUI
[Windows] Unreviewed gardening. Teach WebInspectorUI.vcxproj folder to
ignore Visual Studio's local user settings file.
- WebInspectorUI.vcxproj: Added property svn:ignore.
- 9:48 AM Changeset in webkit [156172] by
-
- 2 edits in trunk
[CMAKE] FindHarfBuzz: Handle harfbuzz / harfbuzz-icu split
https://bugs.webkit.org/show_bug.cgi?id=121688
Patch by Sergio Correia <Sergio Correia> on 2013-09-20
Reviewed by Martin Robinson.
HarfBuzz 0.9.18 split ICU support into a separate harfbuzz-icu library.
To be able to build with earlier and newer versions of HarfBuzz, we should
check for harfbuzz-icu as well, if version >= 0.9.18.
- Source/cmake/FindHarfBuzz.cmake: Check for harfbuzz-icu, if version
0.9.18.
- 9:45 AM Changeset in webkit [156171] by
-
- 2 edits in trunk/Source/WebKit/win
Fix MIDL files for Visual Studio 2012
https://bugs.webkit.org/show_bug.cgi?id=121552
Reviewed by Brent Fulgham.
The MIDL compiler shipped with Visual Studio 2012 does not accept forward declarations
with typedefs. Use the struct keyword in the function signature to fix this problem.
- Interfaces/DOMPrivate.idl:
- 9:45 AM Changeset in webkit [156170] by
-
- 2 edits in trunk/Source/WTF
Atomics.h does not build on MinGW
https://bugs.webkit.org/show_bug.cgi?id=121663
Reviewed by Darin Adler.
MinGW does not have _ReadWriteBarrier() intrinsic, but does have GCC
inline assembler, so use the GCC definitions instead of MSVC ones.
- wtf/Atomics.h:
(WTF::compilerFence):
- 9:40 AM WebInspector edited by
- (diff)
- 9:39 AM WebInspector edited by
- (diff)
- 9:35 AM Changeset in webkit [156169] by
-
- 2 edits in trunk/Source/JavaScriptCore
Inline method exported
https://bugs.webkit.org/show_bug.cgi?id=121664
Reviewed by Darin Adler.
WatchDog::didFire() is marked as an exported symbol eventhough it is
defined inline. This breaks the build on MinGW since it results in dllimport
being declared on a definition.
- runtime/Watchdog.h:
(JSC::Watchdog::didFire):
- 9:18 AM Changeset in webkit [156168] by
-
- 4 edits in trunk
AX: WebArea claims to have a subrole, but always returns nil.
https://bugs.webkit.org/show_bug.cgi?id=121658
Patch by Sam White <Samuel White> on 2013-09-20
Reviewed by Chris Fleizach.
Source/WebCore:
No new tests, updated existing AXWebArea related test to reflect unused attribute removal.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
Updated test output to reflect removal of unused NSAccessibilitySubroleAttribute in AXWebArea.
- platform/mac/accessibility/document-attributes-expected.txt:
- 8:47 AM Changeset in webkit [156167] by
-
- 2 edits1 add in trunk/Tools
[GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
https://bugs.webkit.org/show_bug.cgi?id=121294
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-20
Reviewed by Martin Robinson.
Provide a new patch to deal with the issue in the GTK+ module from
the internal jhbuild environment. This issue has been reported
upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
- gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
- gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
- 8:34 AM Changeset in webkit [156166] by
-
- 14 edits in trunk/Source/WebCore
Add valueForLength/minimumValueForLength wrappers to RenderElement.
<https://webkit.org/b/121676>
Reviewed by Antti Koivisto.
Add two inline wrappers for these functions so we don't have to pass
the RenderView everywhere.
- 8:20 AM Changeset in webkit [156165] by
-
- 4 edits in trunk
[ATK][WTR] accessibility/aria-invalid.html times out
https://bugs.webkit.org/show_bug.cgi?id=121668
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.
Tools:
Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
false in case of aria-invalid event with empty value.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
case of aria-invalid event with empty value.
LayoutTests:
Updated the expectation of aria-invalid.html test, which was timing out
before bug 120421 and this fix.
- platform/gtk-wk2/TestExpectations: Removed aria-invalid.html because
it now passes with this fix and the patch from bug 120421.
- 8:15 AM Changeset in webkit [156164] by
-
- 9 edits2 adds in trunk/Tools
[ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
https://bugs.webkit.org/show_bug.cgi?id=120421
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.
Implemented the notification listener for AccessibilityUIElement for
WebKitTestRunner. The signal is generated by
AXObjectCache::postPlatformNotification() and received by
axObjectEventListener(). axObjectEventListener() will then invoke
JSObjectCallAsFunction() with the respective callback function. The
notification handlers are stored in HashMap in
AccessibilityNotificationHandlerAtk.cpp.
Moved ATK signal handling (printAccessibilityEvent and
axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
- WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
include path.
- WebKitTestRunner/GNUmakefile.am:
Added AccessibilityNotificationHandlerAtk.cpp/h.
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
listener IDs to AccessibilityNotificationHandlerAtk.cpp.
- WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
listener IDs to AccessibilityNotificationHandlerAtk.cpp.
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
notification handler for GTK+ and EFL.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
Moved printAccessibilityEvent and axObjectEventListener to
AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::logAccessibilityEvents): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::resetToConsistentState): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
(WTR::printAccessibilityEvent): Prints accessibility events. This
function was moved from AccessibilityControllerAtk.cpp.
(WTR::axObjectEventListener): Callback for signals. This function was
moved from AccessibilityControllerAtk.cpp.
(WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
Initialize element and function callback.
(WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
Removes handler from HashMap and disconnects callbacks if necessary.
(WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
logging mode and connects callbacks.
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
Sets the notification callback and connects callback to signals.
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
Removes the notification callback from HashMap.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connects axObjectEventListener to ATK signals.
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Disconnects callback.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
(WTR::AccessibilityNotificationHandler::create): Creates a new instance
of AccessibilityNotificationHandler.
(WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
element.
(WTR::AccessibilityNotificationHandler::platformElement): Gets the
element.
(WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
Gets the notification callback.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::addNotificationListener): Creates
notification handler, set the platform element and the notification
callback.
(WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
notification handler.
- WebKitTestRunner/PlatformEfl.cmake:
Added AccessibilityNotificationHandlerAtk.cpp.
- 8:04 AM Changeset in webkit [156163] by
-
- 44 edits in trunk/Source/WebCore
[GTK] Fix some small style issues in the bindings
https://bugs.webkit.org/show_bug.cgi?id=121613
Reviewed by Carlos Garcia Campos.
- bindings/scripts/CodeGeneratorGObject.pm: When printing the license
header use the more common comment style within the WebKit project.
(GenerateProperty): Indent property definitions according to WebKit style, improve
the nick and blurb properties, and improve the various parameter spec argument layout.
(GenerateFunction): Remove the newline from function signatures to match WebKit style.
- bindings/scripts/test/GObject: Update bindings test results.
- 7:58 AM Changeset in webkit [156162] by
-
- 4 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase after Qt 5.1.1 and skip failing tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20
- platform/qt-wk1/TestExpectations:
- platform/qt-wk2/TestExpectations:
- platform/qt-wk2/fast/forms/submit-to-blank-multiple-times-expected.txt: Added.
- platform/qt/TestExpectations:
- 7:43 AM Changeset in webkit [156161] by
-
- 1 edit5 moves in trunk/LayoutTests
Modified img src and srcset encoded URL tests
https://bugs.webkit.org/show_bug.cgi?id=121677
Previous tests have broken the Windows builds, since '?' is not a valid char.
Moved to using '@'
Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-20
Reviewed by Anders Carlsson.
- fast/hidpi/image-srcset-encoded-expected.txt: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark-expected.txt.
- fast/hidpi/image-srcset-encoded.html: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark.html.
- fast/hidpi/resources/image@test.png: Renamed from LayoutTests/fast/hidpi/resources/image?test.png.
- fast/loader/image-src-encoded-expected.txt: Renamed from LayoutTests/fast/loader/image-src-question-mark-expected.txt.
- fast/loader/resources/image@test.png: Renamed from LayoutTests/fast/loader/resources/image?test.png.
- 7:12 AM Changeset in webkit [156160] by
-
- 1 edit16 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Update tests after r156066 and r156083.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20
- platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.png: Added r156083.
- platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.txt: Added r156083.
- platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.png: Added r156083.
- platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.txt: Added r156083.
- platform/qt-wk1/fast/forms/form-element-geometry-expected.png: Added r156083.
- platform/qt-wk1/fast/forms/form-element-geometry-expected.txt: Added r156083.
- platform/qt-wk1/fast/forms/menulist-separator-painting-expected.txt: Added r156083.
- platform/qt-wk1/fast/forms/select-baseline-expected.png: Added r156083.
- platform/qt-wk1/fast/forms/select-baseline-expected.txt: Added r156083.
- platform/qt-wk1/fast/forms/selectlist-minsize-expected.txt: Added r156083.
- platform/qt-wk1/fast/replaced/three-selects-break-expected.txt: Added r156083.
- platform/qt-wk1/js/dom/switch-behaviour-expected.txt: Added r156066.
- 6:23 AM Changeset in webkit [156159] by
-
- 8 edits in trunk/Source
[CMake] Use COMPILE_DEFINITIONS target property for setting BUILDING_* defines
https://bugs.webkit.org/show_bug.cgi?id=121672
Reviewed by Gyuyoung Kim.
Since the scope of add_definitions() is always a whole file, we need to use
target properties instead to set definitions only for specific targets.
Source/JavaScriptCore:
- CMakeLists.txt:
Source/WebCore:
- CMakeLists.txt:
Source/WebKit:
- CMakeLists.txt:
Source/WTF:
- wtf/CMakeLists.txt:
- 6:17 AM Changeset in webkit [156158] by
-
- 9 edits in trunk
Source/WebCore: Make "autoscroll for drag'n drop" a setting
https://bugs.webkit.org/show_bug.cgi?id=121559
Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
Currently, there is a ChromeClient hook to make the
feature opt'ed-in or out. That makes it harder to test the
feature on ports that do not enable it, e.g. Mac/WebKit2 port.
However, Mac/WebKit2 is the port that has the best drag'n drop
WTR implementation.
Patch changes the toggle on/off mechanism to be a setting,
and exposes it through InternalSetting interface for testing.
- page/AutoscrollController.cpp:
(WebCore::AutoscrollController::updateDragAndDrop):
- page/ChromeClient.h:
- page/Settings.in:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setAutoscrollForDragAndDropEnabled):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
LayoutTests: Make "autoscroll" for drag'n drop a setting
https://bugs.webkit.org/show_bug.cgi?id=121559
- fast/events/drag-and-drop-autoscroll.html:
Adapts the test so that is toggles the feature on
via InternalSettings interface.
- 6:16 AM Changeset in webkit [156157] by
-
- 6 edits in trunk/Source/WebCore
StrictTypeChecking extended attribute fails for methods with sequence<T> https://bugs.webkit.org/show_bug.cgi?id=121305
Reviewed by Darin Adler.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
The extended attribute StrictTypeChecking can not be set to methods if
one of the parameters is a "sequence".
Basically, since "sequence" is not considered a native type
(see function IsNativeType) the Perl code generator tries to
include its supposedly associated header, in this case "JSsequence.h"
Compilation then fails.
It is a problem for bindings including WebGL, where all methods
are supposed to be set as StrictTypeChecking (see bug 44202 [1]). Due to this restriction,
it relaxed, but I would like to bring it back.
Patch fixes the issue by hardening the way includes are auto-added
for methods where StrictTypeChecking extended attribute is present.
Now, only wrapper types (see IsWrapperType) trigger header inclusion,
excluding arrays, sequences, basic types, etc.
[1] https://bugs.webkit.org/show_bug.cgi?id=44202
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/TestObj.idl:
- 5:28 AM Changeset in webkit [156156] by
-
- 17 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Update tests after change to Qt 5.1.1
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20
- platform/qt/css1/text_properties/letter_spacing-expected.png:
- platform/qt/css1/text_properties/letter_spacing-expected.txt:
- platform/qt/fast/css/first-line-text-decoration-expected.png:
- platform/qt/fast/css/first-line-text-decoration-expected.txt:
- platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.png:
- platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
- platform/qt/fast/css/word-space-extra-expected.png:
- platform/qt/fast/css/word-space-extra-expected.txt:
- platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
- platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
- platform/qt/fast/text/basic/003-expected.png:
- platform/qt/fast/text/basic/003-expected.txt:
- platform/qt/fast/text/basic/013-expected.png:
- platform/qt/fast/text/basic/013-expected.txt:
- platform/qt/fast/text/text-letter-spacing-expected.png:
- platform/qt/fast/text/text-letter-spacing-expected.txt:
- 5:16 AM Changeset in webkit [156155] by
-
- 38 edits in trunk/Source/WebCore
Optimize fetching the Node for never-anonymous renderers.
<https://webkit.org/b/121627>
Reviewed by Antti Koivisto.
Add a RenderObject::nodeForNonAnonymous() that can be used instead
of node() when a renderer is guaranteed non-anonymous.
Use this to implement reference element getters for the various
renderers that are known at compile-time to correspond to a DOM node.
Also renamed existingElement() => element() since using an alternate
name for a reference overload isn't actually necessary.
- 4:56 AM Changeset in webkit [156154] by
-
- 7 edits in trunk/Source
Remove duplicated secondsPerDay variables
https://bugs.webkit.org/show_bug.cgi?id=121601
Reviewed by Andreas Kling.
Source/WebCore:
Use secondsPerDay from DateMath.h instead of defining it again.
- history/HistoryItem.cpp:
(WebCore::timeToDay):
Source/WebKit/win:
Use secondsPerDay from DateMath.h instead of defining it again.
- MarshallingHelpers.cpp:
Source/WTF:
Move secondsPerDay from the source into the header file
to make it accessible by other code too.
- wtf/DateMath.cpp:
- wtf/DateMath.h:
- 4:54 AM Changeset in webkit [156153] by
-
- 2 edits in trunk/Source/WebCore
Fix duplicated loop variable names after r155743
https://bugs.webkit.org/show_bug.cgi?id=121667
Reviewed by Andreas Kling.
Do not use the same name for variables in nested loops to fix a compiler warning.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- 4:51 AM Changeset in webkit [156152] by
-
- 2 edits in trunk/Tools
Update features.pri
https://bugs.webkit.org/show_bug.cgi?id=121670
Reviewed by Jocelyn Turcotte.
Remove feature flags that no longer exists and new ones added to FeatureList.pm
- qmake/mkspecs/features/features.pri:
- 4:44 AM Changeset in webkit [156151] by
-
- 27 edits in trunk/Source/WebCore
Make RenderObject::parent() return RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121671
Reviewed by Andreas Kling.
Make RenderObject::parent() return RenderElement and adopt everywhere.
Moved addChild/removeChild from RenderObject to RenderElement.
Uninlined a few big RenderObject functions.
Renamed RenderObject::remove() -> RenderObject::removeFromParent()
- 4:32 AM Changeset in webkit [156150] by
-
- 3 edits in trunk/Source/WebCore
Buildfix after r156133 for !ENABLE(WORKERS) platforms
https://bugs.webkit.org/show_bug.cgi?id=121669
Reviewed by Antti Koivisto.
- platform/ThreadGlobalData.cpp:
- platform/ThreadGlobalData.h:
- 4:18 AM Changeset in webkit [156149] by
-
- 4 edits in trunk
[GTK][WK2] accessibility/selection-states.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116972
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.
Tools:
isSelectable() was not exposed in Accessibility.
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
LayoutTests:
Unskipping accessibility/selection-states.html test.
- platform/gtk-wk2/TestExpectations:
- 3:58 AM Changeset in webkit [156148] by
-
- 2 edits in trunk/Source/WebKit/win
Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638
Unreviewed buildfix after r156144.
- DOMCoreClasses.cpp:
(DOMElement::boundingBox):
(DOMElement::font):
- 2:59 AM Changeset in webkit [156147] by
-
- 135 edits in trunk/Source/WebCore
Make createRenderer() return RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121666
Rubber-stamped by Andreas Kling.
Tighter typing.
- 2:52 AM Changeset in webkit [156146] by
-
- 2 edits in trunk/Source/WebCore
Buildfix for ENABLE(CSS_FILTERS) && !ENABLE(ACCELERATED_COMPOSITING) after r155131.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::enclosingFilterRepaintLayer):
- 2:51 AM Changeset in webkit [156145] by
-
- 2 edits in trunk/Source/WebCore
[WIN] Fix build without precompiled header after r154146.
- platform/win/WebCoreBundleWin.cpp:
- 2:48 AM BadContent edited by
- Block a spamming account. (diff)
- 1:59 AM Changeset in webkit [156144] by
-
- 22 edits in trunk/Source/WebCore
Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638
Reviewed by Andreas Kling.
Also add isRenderElement() test and casting functions.
- 12:34 AM Changeset in webkit [156143] by
-
- 5 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20
- platform/qt-wk2/fast/css/word-space-extra-expected.png: Added r155957.
- platform/qt/fast/css/pseudo-first-line-border-width-expected.png: Rebase after r155957.
- platform/qt/fast/css/pseudo-first-line-border-width-expected.txt: Rebase after r155957.
- platform/qt/fast/css/word-space-extra-expected.txt: Rebase after r155957.
- platform/qt/fast/forms/select-empty-option-height-expected.txt: Rebase after rr156040.
Sep 19, 2013:
- 11:08 PM Changeset in webkit [156142] by
-
- 2 edits in trunk/Source/WebCore
Handle null font families.
Reviewed by Darin Adler.
- platform/graphics/Font.cpp:
(WebCore::computeFontGlyphsCacheHash):
Don't crash when trying to hash null strings.
- 10:57 PM Changeset in webkit [156141] by
-
- 2 edits in trunk/Source/WebCore
Fix a couple mistakes in my recent CSS grammar leak patch
https://bugs.webkit.org/show_bug.cgi?id=121659
Reviewed by Alexey Proskuryakov.
- css/CSSGrammar.y.in: Added initialization to nullptr for some error cases
that were otherwise leaving a bad value for the result of the production.
Also fixed a reversed logical expression.
- 10:02 PM Changeset in webkit [156140] by
-
- 3 edits6 adds in trunk
Remove URL decoding in srcset handling
https://bugs.webkit.org/show_bug.cgi?id=121609
Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-19
Reviewed by Benjamin Poulain.
Source/WebCore:
Tests: fast/hidpi/image-srcset-question-mark.html
fast/loader/image-src-question-mark.html
Removed URL decoding from src and srcset's handling algorithm, since they break encoded URLS.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseImagesWithScaleFromSrcSetAttribute):
(WebCore::bestFitSourceForImageAttributes):
LayoutTests:
These tests make sure that encoded URLs are properly handled, and especially URLs
with a question mark in them.
- fast/hidpi/image-srcset-question-mark-expected.txt: Added.
- fast/hidpi/image-srcset-question-mark.html: Added.
- fast/hidpi/resources/image?test.png: Added.
- fast/loader/image-src-question-mark-expected.txt: Added.
- fast/loader/image-src-question-mark.html: Added.
- fast/loader/resources/image?test.png: Added.
- 9:46 PM Changeset in webkit [156139] by
-
- 2 edits in trunk/Source/WebCore
Avoid calling AtomicString::lower() in makeFontGlyphsCacheKey
https://bugs.webkit.org/show_bug.cgi?id=121656
Reviewed by Darin Adler.
Instead of lower casing AtomicStrings, store the strings as is and use the case folding
hash and case insensitive compare to determine equality.
- platform/graphics/Font.cpp:
(WebCore::operator==):
(WebCore::makeFontGlyphsCacheKey):
(WebCore::computeFontGlyphsCacheHash):
- 9:29 PM Changeset in webkit [156138] by
-
- 2 edits in trunk/Source/WebCore
Fix leaks in CSS parser caused by overwriting owned raw pointers with 0
https://bugs.webkit.org/show_bug.cgi?id=121655
Reviewed by Anders Carlsson.
- css/CSSGrammar.y.in: Use nullptr instead of 0. Use unique_ptr instead
of a raw pointer in cases where we might or might not actually keep
the allocated memory. This can still be cleaned up further, but this
should fix the memory leaks we have been seeing.
- 9:07 PM Changeset in webkit [156137] by
-
- 18 edits in trunk/LayoutTests
Use shouldBecomeEqual in asynchronous spellchecking tests.
https://bugs.webkit.org/show_bug.cgi?id=121483
Reviewed by Darin Adler.
Every asynchronous spellchecking layout test waits for spelling or grammar
markers using setTimeout. It duplicates the code, moreover the implementation
differs in every test.
Use shouldBecomeEqual helper (introduced in r143860) to test spellchecking
asynchronously.
- editing/spelling/grammar-markers-expected.txt:
- editing/spelling/grammar-markers-hidpi-expected.txt:
- editing/spelling/grammar-markers-hidpi.html:
- editing/spelling/grammar-markers.html:
- editing/spelling/grammar-paste-expected.txt:
- editing/spelling/grammar-paste.html:
Dump text of destination element instead of source one to show what is
really tested. It stops outputting that the input and textarea elements
can store html tags, for example,
PASS INPUT has a marker on 'I have a<b>n ki</b>wi'.
- editing/spelling/script-tests/spellcheck-paste.js:
(verifyMarker):
(pasteAndVerify):
- editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
- editing/spelling/spellcheck-paste-continuous-disabled.html:
- editing/spelling/spellcheck-paste-disabled-expected.txt:
- editing/spelling/spellcheck-paste-disabled.html:
At the beginning, those tests check whether spelling marker appears
synchronously. Then, spell checking is disabled to check whether
the markers have disappeared properly.
There is no need to check spelling asynchronously in the second part
of the tests. Use synchronous spellchecking path instead.
- editing/spelling/spellcheck-paste-expected.txt:
- editing/spelling/spelling-marker-description-expected.txt:
- editing/spelling/spelling-marker-description.html:
- platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
- platform/mac/editing/spelling/grammar-markers-expected.png:
- platform/mac/editing/spelling/grammar-markers-hidpi-expected.png:
- 7:05 PM Changeset in webkit [156136] by
-
- 37 edits5 adds5 deletes in trunk/Source/JavaScriptCore
Unreviewed, rolling out r156120.
http://trac.webkit.org/changeset/156120
https://bugs.webkit.org/show_bug.cgi?id=121651
Broke windows runtime and all tests (Requested by bfulgham on
#webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2013-09-19
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext):
- dfg/DFGAssemblyHelpers.cpp: Renamed from Source/JavaScriptCore/jit/AssemblyHelpers.cpp.
(JSC::DFG::AssemblyHelpers::executableFor):
(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
(JSC::DFG::AssemblyHelpers::setSamplingFlag):
(JSC::DFG::AssemblyHelpers::clearSamplingFlag):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
- dfg/DFGAssemblyHelpers.h: Renamed from Source/JavaScriptCore/jit/AssemblyHelpers.h.
(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::codeBlock):
(JSC::DFG::AssemblyHelpers::vm):
(JSC::DFG::AssemblyHelpers::assembler):
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::emitGetFromCallFrameHeaderPtr):
(JSC::DFG::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::branchIfNotCell):
(JSC::DFG::AssemblyHelpers::addressFor):
(JSC::DFG::AssemblyHelpers::tagFor):
(JSC::DFG::AssemblyHelpers::payloadFor):
(JSC::DFG::AssemblyHelpers::branchIfNotObject):
(JSC::DFG::AssemblyHelpers::selectScratchGPR):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
(JSC::DFG::AssemblyHelpers::boxInt52):
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):
(JSC::DFG::AssemblyHelpers::emitCount):
(JSC::DFG::AssemblyHelpers::globalObjectFor):
(JSC::DFG::AssemblyHelpers::strictModeFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):
(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(JSC::DFG::AssemblyHelpers::symbolTableFor):
(JSC::DFG::AssemblyHelpers::offsetOfLocals):
(JSC::DFG::AssemblyHelpers::offsetOfArgumentsIncludingThis):
- dfg/DFGBinarySwitch.h:
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGCCallHelpers.h: Renamed from Source/JavaScriptCore/jit/CCallHelpers.h.
(JSC::DFG::CCallHelpers::CCallHelpers):
(JSC::DFG::CCallHelpers::resetCallArguments):
(JSC::DFG::CCallHelpers::addCallArgument):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsExecState):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(JSC::DFG::CCallHelpers::setupTwoStubArgs):
(JSC::DFG::CCallHelpers::setupStubArguments):
(JSC::DFG::CCallHelpers::setupResults):
- dfg/DFGDisassembler.cpp:
- dfg/DFGFPRInfo.h: Renamed from Source/JavaScriptCore/jit/FPRInfo.h.
(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::toArgumentRegister):
(JSC::DFG::FPRInfo::debugName):
- dfg/DFGGPRInfo.h: Renamed from Source/JavaScriptCore/jit/GPRInfo.h.
(JSC::DFG::JSValueRegs::JSValueRegs):
(JSC::DFG::JSValueRegs::payloadOnly):
(JSC::DFG::JSValueRegs::operator!):
(JSC::DFG::JSValueRegs::gpr):
(JSC::DFG::JSValueRegs::payloadGPR):
(JSC::DFG::JSValueSource::JSValueSource):
(JSC::DFG::JSValueSource::unboxedCell):
(JSC::DFG::JSValueSource::operator!):
(JSC::DFG::JSValueSource::isAddress):
(JSC::DFG::JSValueSource::offset):
(JSC::DFG::JSValueSource::base):
(JSC::DFG::JSValueSource::gpr):
(JSC::DFG::JSValueSource::asAddress):
(JSC::DFG::JSValueSource::notAddress):
(JSC::DFG::JSValueRegs::tagGPR):
(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::JSValueSource::payloadGPR):
(JSC::DFG::JSValueSource::hasKnownTag):
(JSC::DFG::JSValueSource::tag):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
(JSC::DFG::GPRInfo::toArgumentRegister):
- dfg/DFGGraph.cpp:
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExit.cpp:
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompiler.h:
- dfg/DFGOSRExitCompilerCommon.h:
- dfg/DFGRegisterBank.h:
- dfg/DFGRegisterSet.h:
- dfg/DFGRepatch.cpp:
- dfg/DFGSilentRegisterSavePlan.h:
- dfg/DFGThunks.cpp:
- dfg/DFGVariableEvent.cpp:
- ftl/FTLCArgumentGetter.h:
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
- ftl/FTLCompile.cpp:
- ftl/FTLExitThunkGenerator.h:
- ftl/FTLLink.cpp:
- ftl/FTLThunks.cpp:
- jit/JIT.cpp:
(JSC::JIT::JIT):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
- jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::preserveReturnAddressAfterCall):
(JSC::JSInterfaceJIT::restoreReturnAddressBeforeReturn):
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):
- jit/ThunkGenerators.cpp:
(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
- llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
- runtime/JSCJSValue.h:
- 6:51 PM Changeset in webkit [156135] by
-
- 8 edits2 adds in trunk
MediaStream API: update MediaStreamTrackEvent object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121624
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/mediastream/MediaStreamTrackEvent-constructor.html
- Modules/mediastream/MediaStreamTrack.idl: Remove NoInterfaceObject.
- Modules/mediastream/MediaStreamTrackEvent.cpp:
(WebCore::MediaStreamTrackEventInit::MediaStreamTrackEventInit): New.
(WebCore::MediaStreamTrackEvent::create): New form that takes an initialize.
(WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent): Ditto.
- Modules/mediastream/MediaStreamTrackEvent.h:
- Modules/mediastream/MediaStreamTrackEvent.idl:
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): New.
- bindings/js/JSDictionary.h:
LayoutTests:
- fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt: Added.
- fast/mediastream/MediaStreamTrackEvent-constructor.html: Added.
- 6:41 PM Changeset in webkit [156134] by
-
- 2 edits in trunk/Source/WTF
ASSERTs in isMainThread after USE(WEB_THREAD) MainThread changes
https://bugs.webkit.org/show_bug.cgi?id=121650
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-19
Reviewed by Benjamin Poulain.
- wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
- 6:10 PM Changeset in webkit [156133] by
-
- 4 edits in trunk/Source/WebCore
Remove #if !ENABLE(WORKERS) code in ThreadGlobalData
https://bugs.webkit.org/show_bug.cgi?id=121649
Reviewed by Sam Weinig.
This lets us remove a FIXME. Also, move threadGlobalData out of line; there's no need for it to be inline.
- WebCore.exp.in:
- platform/ThreadGlobalData.cpp:
(WebCore::threadGlobalData):
- platform/ThreadGlobalData.h:
- 6:00 PM Changeset in webkit [156132] by
-
- 19 edits in trunk/Source/WebCore
Modernize Length setters/getters
https://bugs.webkit.org/show_bug.cgi?id=121647
Reviewed by Andreas Kling.
Add a move constructor and move assignment operator to Length and fixup some of the getters and setters.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::createHandler):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(WebCore::ApplyPropertyLineHeight::createHandler):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::LengthPropertyWrapper::LengthPropertyWrapper):
(WebCore::LengthPropertyWrapper::blend):
(WebCore::FillLayerPropertyWrapper::FillLayerPropertyWrapper):
(WebCore::FillLayerPropertyWrapper::blend):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- platform/CalculationValue.h:
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
- platform/Length.cpp:
(WebCore::CalculationValueHandleMap::remove):
(WebCore::CalculationValueHandleMap::find):
(WebCore::Length::decrementCalculatedRef):
- platform/Length.h:
(WebCore::Length::Length):
(WebCore::Length::operator=):
(WebCore::Length::moveFromLength):
- platform/LengthBox.cpp:
(WebCore::LengthBox::logicalLeft):
(WebCore::LengthBox::logicalRight):
(WebCore::LengthBox::before):
(WebCore::LengthBox::after):
(WebCore::LengthBox::start):
(WebCore::LengthBox::end):
- platform/LengthBox.h:
(WebCore::LengthBox::LengthBox):
(WebCore::LengthBox::left):
(WebCore::LengthBox::right):
(WebCore::LengthBox::top):
(WebCore::LengthBox::bottom):
- platform/LengthSize.h:
(WebCore::LengthSize::LengthSize):
(WebCore::LengthSize::setWidth):
(WebCore::LengthSize::width):
(WebCore::LengthSize::setHeight):
(WebCore::LengthSize::height):
- platform/graphics/filters/FilterOperation.h:
(WebCore::FilterOperation::BlurFilterOperation::create):
(WebCore::FilterOperation::BlurFilterOperation::stdDeviation):
(WebCore::FilterOperation::BlurFilterOperation::BlurFilterOperation):
- rendering/style/BasicShapes.h:
(WebCore::BasicShapeRectangle::x):
(WebCore::BasicShapeRectangle::y):
(WebCore::BasicShapeRectangle::width):
(WebCore::BasicShapeRectangle::height):
(WebCore::BasicShapeRectangle::cornerRadiusX):
(WebCore::BasicShapeRectangle::cornerRadiusY):
(WebCore::BasicShapeRectangle::setX):
(WebCore::BasicShapeRectangle::setY):
(WebCore::BasicShapeRectangle::setWidth):
(WebCore::BasicShapeRectangle::setHeight):
(WebCore::BasicShapeRectangle::setCornerRadiusX):
(WebCore::BasicShapeRectangle::setCornerRadiusY):
(WebCore::BasicShapeCircle::centerX):
(WebCore::BasicShapeCircle::centerY):
(WebCore::BasicShapeCircle::radius):
(WebCore::BasicShapeCircle::setCenterX):
(WebCore::BasicShapeCircle::setCenterY):
(WebCore::BasicShapeCircle::setRadius):
(WebCore::BasicShapeEllipse::centerX):
(WebCore::BasicShapeEllipse::centerY):
(WebCore::BasicShapeEllipse::radiusX):
(WebCore::BasicShapeEllipse::radiusY):
(WebCore::BasicShapeEllipse::setCenterX):
(WebCore::BasicShapeEllipse::setCenterY):
(WebCore::BasicShapeEllipse::setRadiusX):
(WebCore::BasicShapeEllipse::setRadiusY):
(WebCore::BasicShapePolygon::getXAt):
(WebCore::BasicShapePolygon::getYAt):
(WebCore::BasicShapePolygon::appendPoint):
(WebCore::BasicShapeInsetRectangle::top):
(WebCore::BasicShapeInsetRectangle::right):
(WebCore::BasicShapeInsetRectangle::bottom):
(WebCore::BasicShapeInsetRectangle::left):
(WebCore::BasicShapeInsetRectangle::cornerRadiusX):
(WebCore::BasicShapeInsetRectangle::cornerRadiusY):
(WebCore::BasicShapeInsetRectangle::setTop):
(WebCore::BasicShapeInsetRectangle::setRight):
(WebCore::BasicShapeInsetRectangle::setBottom):
(WebCore::BasicShapeInsetRectangle::setLeft):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusY):
- rendering/style/FillLayer.h:
(WebCore::FillSize::FillSize):
(WebCore::FillLayer::xPosition):
(WebCore::FillLayer::yPosition):
(WebCore::FillLayer::sizeLength):
(WebCore::FillLayer::setXPosition):
(WebCore::FillLayer::setYPosition):
- rendering/style/NinePieceImage.cpp:
(WebCore::NinePieceImage::NinePieceImage):
- rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::computeOutset):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::specifiedLineHeight):
- rendering/style/RenderStyle.h:
- rendering/style/StyleBoxData.h:
(WebCore::StyleBoxData::width):
(WebCore::StyleBoxData::height):
(WebCore::StyleBoxData::minWidth):
(WebCore::StyleBoxData::minHeight):
(WebCore::StyleBoxData::maxWidth):
(WebCore::StyleBoxData::maxHeight):
(WebCore::StyleBoxData::verticalAlign):
- rendering/style/StyleReflection.h:
(WebCore::StyleReflection::offset):
(WebCore::StyleReflection::setOffset):
- 5:22 PM Changeset in webkit [156131] by
-
- 3 edits in trunk/Source/WebCore
Out-of-line InspectorValues create() methods.
<https://webkit.org/b/121639>
Reviewed by Joseph Pecoraro.
These functions are hardly performance-critical and are taking up
quite a lot of space.
Shrinks the WebCore binary by 70500 bytes.
- 4:19 PM Changeset in webkit [156130] by
-
- 23 edits in trunk
Layout Test http/tests/security/canvas-remote-read-remote-image-redirect.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121458
Reviewed by Sam Weinig.
Source/WebCore:
The code to automagically produce line numbers is quite fragile. Added some FIXMEs,
and added an issue that was making reporting flaky for code is JS event handlers
executed while parsing was paused.
- page/PageConsole.cpp: (WebCore::PageConsole::addMessage): Use actual "script is
running" check instead of "parsing a script element" one.
LayoutTests:
- fast/frames/sandboxed-iframe-attribute-parsing-06-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-07-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-08-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-09-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-10-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-11-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-12-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-13-expected.txt:
- fast/frames/sandboxed-iframe-attribute-parsing-14-expected.txt:
- fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
- fast/frames/sandboxed-iframe-scripting-04-expected.txt:
- http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
- http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
- http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
- http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
- http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
- http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
- media/video-controls-no-scripting-expected.txt:
We now get a line number for blocked inline scripts, which is a progression.
It is the line number for the closing </script>, which is not ideal, but better
than nothing.
- http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
- http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
Also a progression - we now get a line number for offending <script>.
- 4:15 PM Changeset in webkit [156129] by
-
- 2 edits in trunk/Source/WTF
[iOS] Define mainThreadEstablishedAsPthreadMain to be true in WTF::initializeMainThreadPlatform()
Reviewed by Joseph Pecoraro.
This change was inadvertently left out of <http://trac.webkit.org/changeset/155926>.
- wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
- 4:03 PM Changeset in webkit [156128] by
-
- 12 edits1 delete in trunk/Source/WTF
Remove OwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=121612
Reviewed by Anders Carlsson.
- GNUmakefile.list.am:
- WTF.pro:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/Assertions.cpp:
- wtf/CMakeLists.txt:
- wtf/DateMath.h:
- wtf/FastBitVector.h:
- wtf/Forward.h:
- wtf/OwnArrayPtr.h: Removed.
- wtf/VectorTraits.h:
- 4:02 PM Changeset in webkit [156127] by
-
- 2 edits in trunk/Source/WTF
Substitute return type void for bool in function declaration for WTF::initializeWebThread()
Reviewed by Joseph Pecoraro.
Make the declaration of WTF::initializeWebThread() match the function prototype
of its definition.
- wtf/MainThread.h:
- 3:42 PM Changeset in webkit [156126] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix Windows build part 2. m_jitCodeMap should always be there.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::jitCodeMap):
- 3:38 PM Changeset in webkit [156125] by
-
- 8 edits in trunk/Source/WebCore
Remove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction::type() in more places
https://bugs.webkit.org/show_bug.cgi?id=121589
Reviewed by Dean Jackson.
Replaced CSSLinearTimingFunctionValue by the identifier "linear" and used switch statements on
TimingFunction::type() in more places where we were branching on every type.
Merge https://chromium.googlesource.com/chromium/blink/+/5454f20c71090c35bdd1053e5cc572d5c0bdede7
Merge https://chromium.googlesource.com/chromium/blink/+/104ad42c523d32b67d108c6e59f4f27488fe38a5
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::createTimingFunctionValue):
- css/CSSTimingFunctionValue.cpp:
- css/CSSTimingFunctionValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isCubicBezierTimingFunctionValue):
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::progress):
- 3:27 PM Changeset in webkit [156124] by
-
- 5 edits in trunk/Source/JavaScriptCore
Remove some of the tautologies in DFGRepatch function naming.
Rubber stamped by Mark Hahnenberg.
For example change DFG::dfgLinkFor() to be DFG::linkFor().
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
- dfg/DFGOperations.cpp:
- dfg/DFGRepatch.cpp:
(JSC::DFG::repatchCall):
(JSC::DFG::repatchByIdSelfAccess):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::repatchGetByID):
(JSC::DFG::buildGetByIDList):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::repatchPutByID):
(JSC::DFG::buildPutByIdList):
(JSC::DFG::repatchIn):
(JSC::DFG::linkFor):
(JSC::DFG::linkSlowFor):
(JSC::DFG::linkClosureCall):
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):
- dfg/DFGRepatch.h:
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):
- 3:23 PM Changeset in webkit [156123] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix Windows build. ScratchBuffer should always be available regardless of
ENABLE_DFG_JIT.
- runtime/VM.h:
- 3:16 PM Changeset in webkit [156122] by
-
- 5 edits in trunk/Source/JavaScriptCore
[iOS] Add more iOS logic to the JavaScriptCore build configuration files
https://bugs.webkit.org/show_bug.cgi?id=121635
Reviewed by Geoffrey Garen.
Towards building JavaScriptCore for both OS X and iOS using the same
set of configuration files, add more iOS logic.
- Configurations/Base.xcconfig:
- Configurations/JSC.xcconfig:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/ToolExecutable.xcconfig:
- 3:12 PM Changeset in webkit [156121] by
-
- 17 edits in trunk/Source/WebCore
Unreviewed, rolling out r156119.
http://trac.webkit.org/changeset/156119
https://bugs.webkit.org/show_bug.cgi?id=121640
broke builds in various ways (Requested by anttik on #webkit).
- accessibility/AccessibilitySpinButton.cpp:
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
- css/SelectorChecker.cpp:
- dom/ContainerNode.h:
- dom/Element.h:
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::didAttachRenderers):
- editing/SplitTextNodeContainingElementCommand.cpp:
(WebCore::SplitTextNodeContainingElementCommand::doApply):
- editing/TypingCommand.cpp:
- html/ImageDocument.cpp:
- page/PageSerializer.cpp:
- rendering/RenderElement.h:
- rendering/RenderObject.h:
- svg/SVGAnimatedColor.cpp:
(WebCore::adjustForCurrentColor):
- svg/SVGLocatable.cpp:
- svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::referencedRenderer):
- svg/graphics/filters/SVGFEImage.h:
- 3:10 PM Changeset in webkit [156120] by
-
- 37 edits5 moves in trunk/Source/JavaScriptCore
Move CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
https://bugs.webkit.org/show_bug.cgi?id=121637
Rubber stamped by Michael Saboff.
Also moved GPRInfo/FPRInfo into jit/.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext):
- dfg/DFGAssemblyHelpers.cpp: Removed.
- dfg/DFGAssemblyHelpers.h: Removed.
- dfg/DFGBinarySwitch.h:
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGCCallHelpers.h: Removed.
- dfg/DFGDisassembler.cpp:
- dfg/DFGFPRInfo.h: Removed.
- dfg/DFGGPRInfo.h: Removed.
- dfg/DFGGraph.cpp:
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExit.cpp:
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompiler.h:
- dfg/DFGOSRExitCompilerCommon.h:
- dfg/DFGRegisterBank.h:
- dfg/DFGRegisterSet.h:
- dfg/DFGRepatch.cpp:
- dfg/DFGSilentRegisterSavePlan.h:
- dfg/DFGThunks.cpp:
- dfg/DFGVariableEvent.cpp:
- ftl/FTLCArgumentGetter.h:
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
- ftl/FTLCompile.cpp:
- ftl/FTLExitThunkGenerator.h:
- ftl/FTLLink.cpp:
- ftl/FTLThunks.cpp:
- jit/AssemblyHelpers.cpp: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.cpp.
- jit/AssemblyHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h.
(JSC::AssemblyHelpers::AssemblyHelpers):
(JSC::AssemblyHelpers::debugCall):
- jit/CCallHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGCCallHelpers.h.
- jit/FPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGFPRInfo.h.
(WTF::printInternal):
- jit/GPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGGPRInfo.h.
(WTF::printInternal):
- jit/JIT.cpp:
(JSC::JIT::JIT):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
- jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::JSInterfaceJIT):
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):
- jit/ThunkGenerators.cpp:
(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):
- llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
- runtime/JSCJSValue.h:
- 3:03 PM Changeset in webkit [156119] by
-
- 17 edits in trunk/Source/WebCore
Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638
Reviewed by Andreas Kling.
Also add isRenderElement() test and casting functions.
- 2:42 PM Changeset in webkit [156118] by
-
- 2 edits in trunk/Source/WebCore
Streamline JSMainThreadNullState.
<https://webkit.org/b/121636>
Reviewed by Anders Carlsson.
JSMainThreadNullState is only used by non-JavaScript bindings and
thus won't ever call didLeaveScriptContext() on destruction.
Specialize the class for its use-case instead of sharing code
with JSMainThreadExecState.
Shrinks the WebCore binary by 82848 bytes.
- 2:40 PM Changeset in webkit [156117] by
-
- 2 edits in trunk/Source/WTF
Assume allocator success in Vector unless using try* functions.
<https://webkit.org/b/121629>
Reviewed by Anders Carlsson.
Turn some Vector::begin() null checking into assertions instead.
We have try* style functions for when an allocation request is so
large that it might actually fail. fastMalloc() will never return
null (it will just CRASH() instead.)
- 2:27 PM Changeset in webkit [156116] by
-
- 12 edits in trunk
CSS_SHAPES not supported on AppleWin port
https://bugs.webkit.org/show_bug.cgi?id=118810
Enabling CSS Shapes on Windows port
Reviewed by Brent Fulgham.
- LayoutTests/Changelog
- LayoutTEsts/platform/win/TestExpectations
- Source/WebCore/ChangeLog
- Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
- Source/WebCore/WebCore.vcxproj/WebCoreCommon.props
- Source/WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd
- Source/WebCore/css/CSSPropertyNames.in
- Source/WebKit/ChangeLog
- Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
- WebKitLibraries/ChangeLog
- WebKitLibraries/win/tools/vsprops/FeatureDefines.props
- WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props
- 2:06 PM Changeset in webkit [156115] by
-
- 2 edits in trunk/Tools
Attempted build fix after r156114.
- Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
- 1:46 PM Changeset in webkit [156114] by
-
- 1 edit2 deletes in trunk/WebKitLibraries
Removed WebCoreSQLite3. It has been unused for years.
Rubber-stamped by Mark Rowe.
- WebCoreSQLite3: Removed.
- WebCoreSQLite3/sqlite3.h: Removed.
- WebCoreSQLite3/sqlite3ext.h: Removed.
- libWebCoreSQLite3.a: Removed.
- 1:29 PM Changeset in webkit [156113] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()
Rubber-stamped by Joseph Pecoraro.
Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
noreturn warning in Clang while simultaneously asserting unreachable code.
- jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_mod):
- 1:27 PM Changeset in webkit [156112] by
-
- 2 edits in trunk/Source/JavaScriptCore
[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()
Rubber-stamped by Joseph Pecoraro.
Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
noreturn warning in Clang while simultaneously asserting unreachable code.
- jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_mod):
- 1:07 PM Changeset in webkit [156111] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSC: X86 disassembler shows 16, 32 and 64 bit displacements as unsigned
https://bugs.webkit.org/show_bug.cgi?id=121625
Rubber-stamped by Filip Pizlo.
Chenged 16, 32 and 64 bit offsets to be signed. Kept the original tab indented
spacing to match the rest of the file.
- disassembler/udis86/udis86_syn-att.c:
(gen_operand):
- 12:54 PM Changeset in webkit [156110] by
-
- 8 edits1 add in trunk/Source/WebCore
Add SVGPropertyInfo.cpp
<https://webkit.org/b/121622>
Reviewed by Anders Carlsson.
Add a cpp file for this class to make it more hackable.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- svg/properties/SVGPropertyInfo.cpp: Added.
(WebCore::SVGPropertyInfo::SVGPropertyInfo):
- svg/properties/SVGPropertyInfo.h:
- 12:22 PM Changeset in webkit [156109] by
-
- 2 edits in trunk/Tools
REGRESSION (r129451): run-safari --no-saved-state is broken
https://bugs.webkit.org/show_bug.cgi?id=121566
Undo a last minute change that doesn't actually work.
- Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
via command line, <rdar://problem/15032886>.
- 12:06 PM Changeset in webkit [156108] by
-
- 13 edits1 add in trunk
MediaStream API: update NavigatorUserMediaError object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121584
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, updated getusermedia.html.
- CMakeLists.txt: Add NavigatorUserMediaError.cpp.
- GNUmakefile.list.am: Ditto.
- Modules/mediastream/NavigatorUserMediaError.cpp: Added.
- Modules/mediastream/NavigatorUserMediaError.h: Derive from DOMError, get rid of "message" attribute.
- Modules/mediastream/NavigatorUserMediaError.idl: Ditto.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::create): ASCIILiteral -> AtomicString. Rename constraint parameters.
(WebCore::UserMediaRequest::UserMediaRequest): Rename constraint parameters.
(WebCore::UserMediaRequest::audioConstraints): Return PassRefPtr<> instead of raw ptr.
(WebCore::UserMediaRequest::videoConstraints): Ditto.
(WebCore::UserMediaRequest::ownerDocument): Clean up style.
(WebCore::UserMediaRequest::succeed):
(WebCore::UserMediaRequest::permissionFailure): Renamed from fail.
(WebCore::UserMediaRequest::constraintFailure): Renamed from failConstraint.
(WebCore::UserMediaRequest::callSuccessHandler): New.
(WebCore::UserMediaRequest::callErrorHandler): New.
- Modules/mediastream/UserMediaRequest.h:
- WebCore.xcodeproj/project.pbxproj: Add NavigatorUserMediaError.cpp
- dom/DOMError.h: Make constructor protected.
- platform/mediastream/MediaStreamSourcesQueryClient.h: Make constraints available.
LayoutTests:
- fast/mediastream/getusermedia-expected.txt:
- fast/mediastream/getusermedia.html:
- 11:49 AM Changeset in webkit [156107] by
-
- 8 edits in trunk/LayoutTests
[CSS Shapes] Fix starting html tag and doctype for shape-inside floats tests
https://bugs.webkit.org/show_bug.cgi?id=121621
Reviewed by Andreas Kling.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html:
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html:
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html:
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html:
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html:
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html:
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html:
- 11:18 AM Changeset in webkit [156106] by
-
- 8 edits4 adds in trunk
Fix handling of top margin on float with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=121614
Reviewed by Alexandru Chiculita.
Source/WebCore:
When a float has shape outside, the top margin should be treated as if
there is no shape there, so inline content should be allowed to flow
into that space. This patch fixes two issues:
1) If the top margin is the same as the line height, a line should be
able to fit into the margin. Before this patch, that line was being
treated as if it intersected with the shape.
2) The shape should be positioned (x, y) relative to the box sizing
box of the float. While the x coordinate was being treated properly,
the y coordinate was relative to the top of the margin box. This patch
fixes this behavior.
This patch also includes a simple test for right and left margins, as
I wrote that test and then discovered the problems listed above.
This patch also removes an unused override of the
lineOverlapsShapeBounds method.
Tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html
- rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
- rendering/LineWidth.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
- rendering/shapes/ShapeInfo.h:
- rendering/shapes/ShapeInsideInfo.h:
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::computeSegmentsForContainingBlockLine):
- rendering/shapes/ShapeOutsideInfo.h:
LayoutTests:
- csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Added.
Test for a positive left/right margin.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Added.
Test for a positive top margin.
- 11:13 AM Changeset in webkit [156105] by
-
- 5 edits in trunk
Add a style guideline regarding spacing in range-based for loops
https://bugs.webkit.org/show_bug.cgi?id=121620
Reviewed by Anders Carlsson.
Tools:
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing): Added checking that there are spaces around the colon in a range-based for
loop.
(CppChecker): Added whitespace/colon to the categories set.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_spacing): Added two tests for the new check.
Websites/webkit.org:
- coding/coding-style.html: Added the guideline that spaces should be placed
around the colon in a range-based for loop.
- 10:57 AM Changeset in webkit [156104] by
-
- 3 edits in trunk/PerformanceTests
DoYouEvenBench: Indentations in benchmark.js and benchmark.html are all messed up
https://bugs.webkit.org/show_bug.cgi?id=121597
Reviewed by Anders Carlsson.
Fixed indentations.
- DoYouEvenBench/benchmark.html:
- DoYouEvenBench/benchmark.js:
(SimplePromise.prototype.resolve.else):
(SimplePromise.prototype.resolve):
(BenchmarkRunner.waitForElement.resolveIfReady):
(BenchmarkRunner.waitForElement):
(BenchmarkRunner._waitAndWarmUp.Fibonacci):
(BenchmarkRunner._finalize):
- 10:57 AM Changeset in webkit [156103] by
-
- 1 edit2 adds in trunk/LayoutTests
Add XHR tests checking readyState transition when abort() is invoked in various states
https://bugs.webkit.org/show_bug.cgi?id=121585
Reviewed by Alexey Proskuryakov.
Merge https://chromium.googlesource.com/chromium/blink/+/2d854757576db590745cfb78e11ca428a1aac342
- http/tests/xmlhttprequest/readystatechange-and-abort-expected.txt: Added.
- http/tests/xmlhttprequest/readystatechange-and-abort.html: Added.
- 10:52 AM Changeset in webkit [156102] by
-
- 26 edits2 adds in trunk/Source/WebCore
Add RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121608
Reviewed by Dave Hyatt.
Add a common base class for all Element renderers. The class hierarchy will now look like this
RenderObject
RenderText
RenderElement
RenderLayerModelObject
...
RenderSVGModelObject
...
RenderSVGGradientStop
This will allow tighter typing in both render and DOM trees.
The patch also moves renderer factory function to RenderElement::createFor().
- 10:36 AM Changeset in webkit [156101] by
-
- 2 edits in trunk/Source/WebKit/qt
Keep chasing the definition of QAccessibleWidget
https://bugs.webkit.org/show_bug.cgi?id=121611
Reviewed by Jocelyn Turcotte.
- WidgetApi/qwebviewaccessible_p.h:
- 9:06 AM Changeset in webkit [156100] by
-
- 12 edits in trunk/Tools
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
https://bugs.webkit.org/show_bug.cgi?id=121588
Reviewed by Anders Carlsson.
- DumpRenderTree/TestRunner.cpp:
- ImageDiff/efl/ImageDiff.cpp:
- TestWebKitAPI/JavaScriptTest.cpp:
- TestWebKitAPI/PlatformUtilities.cpp:
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/StringFunctions.h:
- WebKitTestRunner/TestInvocation.cpp:
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
- 9:00 AM Changeset in webkit [156099] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r149928): CanvasStyle::operator= leaks everything
https://bugs.webkit.org/show_bug.cgi?id=121591
Reviewed by Andreas Kling.
- html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::operator=): Don't leak.
- 8:11 AM Changeset in webkit [156098] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Fix typo in layout test description introduced in r155974.
- fast/regions/selection-direction-expected.html:
- fast/regions/selection-direction.html:
- 7:41 AM Changeset in webkit [156097] by
-
- 4 edits2 copies in trunk
[CSS Masking/Background] Position property should be ignored when using repeat: space
https://bugs.webkit.org/show_bug.cgi?id=120623
Source/WebCore:
The background/mask-position should be ignored when using repeat: space,
unless there is not enough space for two copies of the image. In that case,
only one image is placed and background/mask-position determines its position.
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.
Test: css3/masking/mask-repeat-one-copy.html
- rendering/RenderBoxModelObject.cpp: Ignored position property if space value is positive, set no-repeat otherwise.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
LayoutTests:
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.
- css3/masking/mask-repeat-one-copy-expected.html:
- css3/masking/mask-repeat-one-copy.html: Only one copy of the mask should be drawn, and background position should determine its position.
- css3/masking/mask-repeat-space-padding.html: Added a mask-position which should be ignored.
- 7:39 AM Changeset in webkit [156096] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip tests added to platform/efl/Skipped, which now are passing.
- platform/efl/TestExpectations:
- 6:51 AM Changeset in webkit [156095] by
-
- 4 edits in trunk/Source/WebCore
CTTE: EllipsisBox::renderer() should return RenderBlock&.
<https://webkit.org/b/121604>
Reviewed by Antti Koivisto.
I missed adding a renderer() overload when fixing up EllipsisBox.
Flushed out one unnecessary type check.
- 6:48 AM Changeset in webkit [156094] by
-
- 13 edits in trunk/Source/WebCore
CTTE: Tighten renderer types for InlineTextBox and SVGInlineTextBox.
<https://webkit.org/b/121605>
Reviewed by Antti Koivisto.
Codify the following:
- InlineTextBox always has a RenderText.
- SVGInlineTextBox always has a RenderSVGInlineText.
Removed InlineTextBox::textRenderer() and make renderer() simply
return a RenderText&/RenderSVGInlineText& instead.
This turns some node() accessors into textNode() and removes a host
of casts and assertions.
- 6:36 AM Changeset in webkit [156093] by
-
- 5 edits in trunk/Source/WebCore
[CTTE] Hide nonPseudoNode and generatingNode, replace with Element versions
https://bugs.webkit.org/show_bug.cgi?id=121606
Reviewed by Andreas Kling.
- 5:33 AM Changeset in webkit [156092] by
-
- 5 edits in trunk/Source/WebCore
CTTE: Tighten renderer types for InlineFlowBox and SVGInlineFlowBox.
<https://webkit.org/b/121603>
Reviewed by Antti Koivisto.
Codify the following:
- InlineFlowBox always has a RenderBoxModelObject.
- SVGInlineFlowBox always has a RenderSVGInline.
This turns some node() accessors into element(). Neato!
- 4:03 AM Changeset in webkit [156091] by
-
- 5 edits4 adds in trunk
CSS Unit vmax and vmin in border-width not handled.
https://bugs.webkit.org/show_bug.cgi?id=121421
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-19
Reviewed by Darin Adler.
Source/WebCore:
Border properties were not applied incase its values
were given in vmax/vmin units.
Tests: fast/css/viewport-vmax-border.html
fast/css/viewport-vmin-border.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportPercentageMax):
(WebCore::CSSPrimitiveValue::isViewportPercentageMin):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):
Calculating the border values which has been specified in
vmax/vmin units. 1vmax: 1vw or 1vh, whatever is largest.
1vmin: 1vw or 1vh, whatever is smallest. The vh/vw units are
calcultated as percent of viewport height and viewport width respectively.
LayoutTests:
- fast/css/viewport-vmax-border-expected.txt: Added.
- fast/css/viewport-vmax-border.html: Added.
- fast/css/viewport-vmin-border-expected.txt: Added.
- fast/css/viewport-vmin-border.html: Added.
Added new tests for verifying that border properties are
applied when its values are given in vmax/vmin units.
- 3:37 AM Changeset in webkit [156090] by
-
- 22 edits in trunk
[CTTE] RenderText is always anonymous or associated with Text node
https://bugs.webkit.org/show_bug.cgi?id=121596
Source/WebCore:
Reviewed by Andreas Kling.
Tighten the node type of RenderText and its subclasses to Text.
Switch to createAnonymous pattern.
Switch a bunch of unnecessary StringImpl* use to Strings.
LayoutTests:
Reviewed by Andreas Kling.
Update some MathML render tree dumps. RenderTexts for these are now anonymous.
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/row-expected.txt:
- 1:42 AM Changeset in webkit [156089] by
-
- 4 edits10 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase after r155957 and 155998.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-19
- platform/qt-wk1/compositing/contents-scale/animating-expected.txt: Added r155998.
- platform/qt-wk1/compositing/contents-scale/scaled-ancestor-expected.txt: Added r155998.
- platform/qt-wk1/compositing/contents-scale/simple-scale-expected.txt: Added r155998.
- platform/qt-wk1/compositing/contents-scale/z-translate-expected.txt: Added r155998.
- platform/qt-wk2/compositing/contents-scale/animating-expected.txt: Added r155998.
- platform/qt-wk2/compositing/contents-scale/scaled-ancestor-expected.txt: Added r155998.
- platform/qt-wk2/compositing/contents-scale/simple-scale-expected.txt: Added r155998.
- platform/qt-wk2/compositing/contents-scale/z-translate-expected.txt: Added r155998.
- platform/qt/css3/selectors3/html/css3-modsel-179a-expected.txt: Rebase after r155957.
- platform/qt/css3/selectors3/xhtml/css3-modsel-179a-expected.txt: Rebase after r155957.
- platform/qt/css3/selectors3/xml/css3-modsel-179a-expected.txt: Rebase after r155957.
- 1:07 AM Changeset in webkit [156088] by
-
- 2 edits31 adds in trunk/PerformanceTests
Add an AngularJS test to DoYouEvenBench
https://bugs.webkit.org/show_bug.cgi?id=121595
Reviewed by Antti Koivisto.
- DoYouEvenBench/benchmark.html:
- DoYouEvenBench/todomvc/architecture-examples/angularjs: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower.json: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/index.html: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/app.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services/todoStorage.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/readme.md: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/package.json: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/readme.md: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Added.
- 12:54 AM Changeset in webkit [156087] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for failing HiDPI and a11y tests.
- 12:07 AM Changeset in webkit [156086] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after 156082. Guard SVG code with defines.
- 12:07 AM Changeset in webkit [156085] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove names of unused arguments from the x86/x86-64 function prototype
for JIT::emitSlow_op_mod()
Rubber-stamped by Ryosuke Niwa.
- jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_mod):
Sep 18, 2013:
- 11:42 PM Changeset in webkit [156084] by
-
- 7 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r155957.
- platform/gtk/css3/selectors3/html/css3-modsel-179a-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-179a-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-179a-expected.txt:
- platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt:
- platform/gtk/fast/css/word-space-extra-expected.txt:
- platform/gtk/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
- 11:32 PM Changeset in webkit [156083] by
-
- 10 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r156040.
- platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
- platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
- platform/gtk/fast/forms/form-element-geometry-expected.txt:
- platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
- platform/gtk/fast/forms/select-baseline-expected.txt:
- platform/gtk/fast/forms/select-empty-option-height-expected.txt:
- platform/gtk/fast/forms/selectlist-minsize-expected.txt:
- platform/gtk/fast/html/keygen-expected.txt:
- platform/gtk/fast/replaced/three-selects-break-expected.txt:
- 11:22 PM Changeset in webkit [156082] by
-
- 3 edits2 adds in trunk
[CSSRegions] Failed to retrieve named flow ranges for content with inline svg
https://bugs.webkit.org/show_bug.cgi?id=121489
Reviewed by David Hyatt.
Source/WebCore:
The inline SVG element behaves like a replaced element in HTML context. When computing the ranges
that are displayed inside a region for a named flow that contains an inline SVG element, we have
to treat the SVG as a replaced and run the checks only for the SVG root element, skipping the
other SVG elements inside.
Test: fast/regions/get-region-flow-ranges-inline-svg.html
- rendering/RenderNamedFlowThread.cpp:
(WebCore::nextNodeInsideContentNode): Add function to retrieve the next node in traversal
under the contentNode subtree that should be used for getRanges inspection.
(WebCore::RenderNamedFlowThread::getRanges): Replace NodeTravesal::next with nextNodeInsideContentNode.
LayoutTests:
- fast/regions/get-region-flow-ranges-inline-svg-expected.txt: Added.
- fast/regions/get-region-flow-ranges-inline-svg.html: Added.
- 11:18 PM Changeset in webkit [156081] by
-
- 1 edit5 moves1 add in trunk/LayoutTests
Unreviewed GTK gardening. Moving GTK-specific baselines for some js/dom/* tests into the proper directory.
- platform/gtk/js/dom: Added.
- platform/gtk/js/dom-static-property-for-in-iteration-expected.txt: Removed.
- platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt: Copied from LayoutTests/platform/gtk/js/dom-static-property-for-in-iteration-expected.txt.
- platform/gtk/js/dom/function-length-expected.txt: Copied from LayoutTests/platform/gtk/js/function-length-expected.txt.
- platform/gtk/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-dedicated-worker-expected.txt.
- platform/gtk/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-expected.txt.
- platform/gtk/js/dom/global-constructors-attributes-shared-worker-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-shared-worker-expected.txt.
- platform/gtk/js/function-length-expected.txt: Removed.
- platform/gtk/js/global-constructors-attributes-dedicated-worker-expected.txt: Removed.
- platform/gtk/js/global-constructors-attributes-expected.txt: Removed.
- platform/gtk/js/global-constructors-attributes-shared-worker-expected.txt: Removed.
- 9:03 PM Changeset in webkit [156080] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
Redo r156078.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
- platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Removed.
- platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Removed.
- 8:12 PM Changeset in webkit [156079] by
-
- 16 edits in trunk/Source/JavaScriptCore
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=121583
Reviewed by Anders Carlsson.
- API/JSStringRefCF.cpp:
(JSStringCreateWithCFString):
- API/JSStringRefQt.cpp:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::dumpDisassembly):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
- runtime/Arguments.h:
(JSC::Arguments::isTornOff):
(JSC::Arguments::allocateSlowArguments):
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
- runtime/JSPropertyNameIterator.h:
- runtime/JSSegmentedVariableObject.h:
- runtime/JSVariableObject.h:
- runtime/PropertyNameArray.h:
- runtime/RegExp.cpp:
- runtime/StructureChain.h:
(JSC::StructureChain::finishCreation):
- runtime/SymbolTable.h:
(JSC::SharedSymbolTable::setSlowArguments):
- 8:03 PM Changeset in webkit [156078] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
Lion rebaseline after r155253.
- platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
- platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
- platform/qt-wk2/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Removed.
- platform/qt-wk2/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Removed.
- 7:17 PM Changeset in webkit [156077] by
-
- 3 edits in trunk/LayoutTests
Add test expectations for bugs 121581 and 121582.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 7:04 PM Changeset in webkit [156076] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Fix the expected result again after r156070.
- platform/mac-lion/js/dom: Added.
- platform/mac-lion/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt.
- platform/mac/js/dom/global-constructors-attributes-expected.txt: Removed.
- 6:31 PM Changeset in webkit [156075] by
-
- 3 edits2 adds in trunk
REGRESSION (r155854 - r155967) block with margin-left adjacent to floated block causes text of subsequent blocks to overlap the floated block.
https://bugs.webkit.org/show_bug.cgi?id=121532
Reviewed by Andreas Kling.
Source/WebCore:
When refactoring the code, I ended up adding the margin in instead of
subtracting it in the case of an intruding float. This patch fixes
that so that the margin is properly handled.
Test: fast/block/float/intruding-float-sibling-with-margin.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addIntrudingFloats):
LayoutTests:
- fast/block/float/intruding-float-sibling-with-margin-expected.html: Added.
- fast/block/float/intruding-float-sibling-with-margin.html: Added.
- 5:55 PM Changeset in webkit [156074] by
-
- 4 edits in trunk/Tools
W3C Test Import script reformats test HTML
https://bugs.webkit.org/show_bug.cgi?id=119159
Reviewed by Dirk Pranke.
Completely rewrite the test conversion process to minimize
reformatting when adding prefixes, etc. This isn't 100% perfect, there
are still places where it will end up changing the formatting, but it
is much better than before. Most notably, the public interface to the
test converter has changed: now one calls a method instead of creating
an instance of the test converter class. This is because the test
converter class now has state, so one really needs a new instance for
each test.
Note that this also lays some simple groundwork for being able to use
a MockHost in the tests.
- Scripts/webkitpy/w3c/test_converter.py:
(convert_for_webkit):
(_W3CTestConverter):
(_W3CTestConverter.init):
(_W3CTestConverter.output):
(_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
(_W3CTestConverter.convert_style_data):
(_W3CTestConverter.convert_attributes_if_needed):
(_W3CTestConverter.handle_starttag):
(_W3CTestConverter.handle_endtag):
(_W3CTestConverter.handle_startendtag):
(_W3CTestConverter.handle_data):
(_W3CTestConverter.handle_entityref):
(_W3CTestConverter.handle_charref):
(_W3CTestConverter.handle_comment):
(_W3CTestConverter.handle_decl):
(_W3CTestConverter.handle_pi):
- Scripts/webkitpy/w3c/test_converter_unittest.py:
(W3CTestConverterTest):
(W3CTestConverterTest.fake_dir_path):
(W3CTestConverterTest.test_read_prefixed_property_list):
(verify_no_conversion_happened):
- Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.import_tests):
- 5:15 PM Changeset in webkit [156073] by
-
- 2 edits100 adds in trunk/PerformanceTests
Add a not completely unrealistic DOM Benchmark
https://bugs.webkit.org/show_bug.cgi?id=121361
Reviewed by Filip Pizlo.
Add a DOM benchmark based on TodoMVC for vanilla JS, Ember.js, Backbone.js, and jQuery.
We'll add more frameworks and demo apps as we go.
- DoYouEvenBench: Added.
- DoYouEvenBench/benchmark.html: Added.
- DoYouEvenBench/benchmark.js: Added.
(SimplePromise):
(SimplePromise.prototype.then):
(SimplePromise.prototype.resolve.else):
(SimplePromise.prototype.resolve):
(BenchmarkRunner.suite):
(BenchmarkRunner.waitForElement.resolveIfReady):
(BenchmarkRunner.waitForElement):
(BenchmarkRunner._removeFrame):
(BenchmarkRunner._appendFrame):
(BenchmarkRunner._waitAndWarmUp.Fibonacci):
(BenchmarkRunner._testName):
(BenchmarkRunner._testItemId):
(BenchmarkRunner.listSuites.button.onclick):
(BenchmarkRunner.listSuites.callNextStep):
(BenchmarkRunner.listSuites):
(BenchmarkState):
(BenchmarkState.prototype.currentSuite):
(BenchmarkState.prototype.currentTest):
(BenchmarkState.prototype.next):
(BenchmarkState.prototype.isFirstTest):
(BenchmarkState.prototype.prepareCurrentSuite.frame.onload):
(BenchmarkRunner.step):
(BenchmarkRunner._runTestAndRecordResults):
(BenchmarkRunner._finalize):
- DoYouEvenBench/todomvc: Added.
- DoYouEvenBench/todomvc/architecture-examples: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower.json: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage/backbone.localStorage.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone/backbone.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery/jquery.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/bg.png: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore/underscore.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/index.html: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/app.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections/todos.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/models: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/models/todo.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers/router.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/views: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/app-view.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/todo-view.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/backbone/readme.md: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower.json: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter/localstorage_adapter.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery/jquery.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/bg.png: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/index.html: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/app.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todo_controller.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todos_controller.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs/ember-data.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/store.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/todo.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views/edit_todo_view.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/readme.md: Added.
- DoYouEvenBench/todomvc/architecture-examples/emberjs/test.html: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower.json: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars/handlebars.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery/jquery.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/bg.png: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/css: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/css/app.css: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/index.html: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/js: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/js/app.js: Added.
- DoYouEvenBench/todomvc/architecture-examples/jquery/readme.md: Added.
- DoYouEvenBench/todomvc/license.md: Added.
- DoYouEvenBench/todomvc/readme.md: Added.
- DoYouEvenBench/todomvc/vanilla-examples: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower.json: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.js: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/bg.png: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/index.html: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/app.js: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/controller.js: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/helpers.js: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/model.js: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/store.js: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/view.js: Added.
- DoYouEvenBench/todomvc/vanilla-examples/vanillajs/readme.md: Added.
- Skipped:
- 4:58 PM Changeset in webkit [156072] by
-
- 6 edits in trunk
Merge HTMLBodyElement::didNotifySubtreeInsertions into HTMLBodyElement::insertedInto
https://bugs.webkit.org/show_bug.cgi?id=121576
Reviewed by Andreas Kling.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/2a9cac908f4eceadfcf9d21bdf5b3e598075aa1f
The logic in didNotifySubtreeInsertions to set the marginwidth and marginheight attributes
on the <body> of elements inside <iframe> and <frame> doesn't need to run after inserting
all the children of the frame. In fact this means that when you have those attributes
and then the script in the iframe touches offsetLeft or any layout dependent property
we'll layout with the wrong values and then have to do another layout after these margin
attributes are set.
I also remove the scheduleRelayout() call that was inside didNotifySubtreeInsertions. This
call doesn't make any sense, inserting a <body> will always trigger a style recalc and
a subsequent layout. The code is 9 years old: https://trac.webkit.org/changeset/8122
and all tests run fine without it.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
- html/HTMLBodyElement.h:
- html/HTMLFrameElementBase.h:
(WebCore::isHTMLFrameElementBase):
(WebCore::toHTMLFrameElementBase):
LayoutTests:
Rebaseline a test now that we don't do an extra layout.
- inspector/timeline/timeline-script-tag-1-expected.txt:
- 4:51 PM Changeset in webkit [156071] by
-
- 2 edits in trunk/LayoutTests
Unreviewed check in a proper baseline.
- js/dom/global-constructors-attributes-expected.txt:
- 4:40 PM Changeset in webkit [156070] by
-
- 1 edit3 moves2 adds in trunk/LayoutTests
Move expected results after r156066.
- platform/efl/js/dom: Added.
- platform/efl/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/efl/js/global-constructors-attributes-expected.txt.
- platform/efl/js/global-constructors-attributes-expected.txt: Removed.
- platform/mac-lion/js/global-constructors-attributes-expected.txt: Removed.
- platform/mac/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac-lion/js/global-constructors-attributes-expected.txt.
- platform/qt/js/dom: Added.
- platform/qt/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/qt/js/global-constructors-attributes-expected.txt.
- platform/qt/js/global-constructors-attributes-expected.txt: Removed.
- 3:45 PM Changeset in webkit [156069] by
-
- 62 edits in trunk/Source/WebKit2
Remove the ENABLE_PLUGIN_PROCESS #define
https://bugs.webkit.org/show_bug.cgi?id=121569
Reviewed by Andreas Kling.
Fold the ENABLE_PLUGIN_PROCESS #define into the NETSCAPE_PLUGIN_API #define since
building plug-ins without the plug-in process is not supported.
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
- PluginProcess/PluginControllerProxy.cpp:
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginControllerProxy.messages.in:
- PluginProcess/PluginCreationParameters.cpp:
- PluginProcess/PluginCreationParameters.h:
- PluginProcess/PluginProcess.cpp:
- PluginProcess/PluginProcess.h:
- PluginProcess/PluginProcess.messages.in:
- PluginProcess/WebProcessConnection.cpp:
- PluginProcess/WebProcessConnection.h:
- PluginProcess/WebProcessConnection.messages.in:
- PluginProcess/mac/PluginControllerProxyMac.mm:
- PluginProcess/mac/PluginProcessMac.mm:
- Shared/Plugins/NPIdentifierData.cpp:
- Shared/Plugins/NPIdentifierData.h:
- Shared/Plugins/NPObjectMessageReceiver.cpp:
- Shared/Plugins/NPObjectMessageReceiver.h:
- Shared/Plugins/NPObjectMessageReceiver.messages.in:
- Shared/Plugins/NPObjectProxy.cpp:
- Shared/Plugins/NPObjectProxy.h:
- Shared/Plugins/NPRemoteObjectMap.cpp:
- Shared/Plugins/NPRemoteObjectMap.h:
- Shared/Plugins/NPVariantData.cpp:
- Shared/Plugins/NPVariantData.h:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getMIMETypesFromPluginBundle):
- Shared/Plugins/PluginProcessCreationParameters.cpp:
- Shared/Plugins/PluginProcessCreationParameters.h:
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::processTypeAsString):
(WebKit::ProcessLauncher::getProcessTypeFromString):
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
(WebKit::serviceName):
(WebKit::createProcess):
- UIProcess/Plugins/PluginProcessManager.cpp:
- UIProcess/Plugins/PluginProcessManager.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.messages.in:
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::~WebPluginSiteDataManager):
(WebKit::WebPluginSiteDataManager::invalidate):
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
- UIProcess/Plugins/WebPluginSiteDataManager.h:
- UIProcess/Plugins/mac/PluginProcessManagerMac.mm:
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setProcessModel):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginProcessConnection):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- UIProcess/mac/WebContextMac.mm:
(WebKit::updateProcessSuppressionStateOfGlobalChildProcesses):
- WebKit2Prefix.h:
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
- WebProcess/Plugins/PluginProcessConnection.cpp:
- WebProcess/Plugins/PluginProcessConnection.h:
- WebProcess/Plugins/PluginProcessConnection.messages.in:
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
- WebProcess/Plugins/PluginProcessConnectionManager.h:
- WebProcess/Plugins/PluginProcessConnectionManager.messages.in:
- WebProcess/Plugins/PluginProxy.cpp:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginProxy.messages.in:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 3:37 PM Changeset in webkit [156068] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Build fix after r156063.
- WebHistory.h: std::unique is an algorithm; std::unique_ptr is what we want here!
- 3:36 PM Changeset in webkit [156067] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed build fix after r156064.
- jsc.cpp:
(jscmain): Need a temporary to perform '&' in VS2010.
- 3:26 PM Changeset in webkit [156066] by
-
- 7 edits3 moves785 adds781 deletes in trunk
Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
https://bugs.webkit.org/show_bug.cgi?id=121578
Rubber stamped by Geoffrey Garen.
Tools:
- Scripts/run-layout-jsc:
LayoutTests:
- fast/regex/cross-frame-callable-expected.txt: Removed.
- fast/regex/cross-frame-callable.html: Removed.
- fast/regex/dom: Added.
- fast/regex/dom/cross-frame-callable-expected.txt: Added.
- fast/regex/dom/cross-frame-callable.html: Added.
- fast/regex/dom/lastIndex-expected.txt: Added.
- fast/regex/dom/lastIndex.html: Added.
- fast/regex/dom/non-pattern-characters-expected.txt: Added.
- fast/regex/dom/non-pattern-characters.html: Added.
- fast/regex/dom/script-tests: Added.
- fast/regex/dom/script-tests/cross-frame-callable.js: Added.
(doTest):
- fast/regex/dom/script-tests/lastIndex.js: Added.
- fast/regex/dom/script-tests/non-pattern-characters.js: Added.
- fast/regex/dom/script-tests/unicodeCaseInsensitive.js: Added.
(shouldBeTrue.ucs2CodePoint):
- fast/regex/dom/syntax-errors-expected.txt: Added.
- fast/regex/dom/syntax-errors.html: Added.
- fast/regex/dom/unicodeCaseInsensitive-expected.txt: Added.
- fast/regex/dom/unicodeCaseInsensitive.html: Added.
- fast/regex/lastIndex-expected.txt: Removed.
- fast/regex/lastIndex.html: Removed.
- fast/regex/non-pattern-characters-expected.txt: Removed.
- fast/regex/non-pattern-characters.html: Removed.
- fast/regex/script-tests/cross-frame-callable.js: Removed.
- fast/regex/script-tests/lastIndex.js: Removed.
- fast/regex/script-tests/non-pattern-characters.js: Removed.
- fast/regex/script-tests/unicodeCaseInsensitive.js: Removed.
- fast/regex/syntax-errors-expected.txt: Removed.
- fast/regex/syntax-errors.html: Removed.
- fast/regex/unicodeCaseInsensitive-expected.txt: Removed.
- fast/regex/unicodeCaseInsensitive.html: Removed.
- js/JSON-parse-expected.txt: Removed.
- js/JSON-parse.html: Removed.
- js/JSON-stringify-expected.txt: Removed.
- js/JSON-stringify.html: Removed.
- js/Object-defineProperty-expected.txt: Removed.
- js/Object-defineProperty.html: Removed.
- js/Promise-already-fulfilled-expected.txt: Removed.
- js/Promise-already-fulfilled.html: Removed.
- js/Promise-already-rejected-expected.txt: Removed.
- js/Promise-already-rejected.html: Removed.
- js/Promise-already-resolved-expected.txt: Removed.
- js/Promise-already-resolved.html: Removed.
- js/Promise-catch-expected.txt: Removed.
- js/Promise-catch-in-workers-expected.txt: Removed.
- js/Promise-catch-in-workers.html: Removed.
- js/Promise-catch.html: Removed.
- js/Promise-chain-expected.txt: Removed.
- js/Promise-chain.html: Removed.
- js/Promise-exception-expected.txt: Removed.
- js/Promise-exception.html: Removed.
- js/Promise-expected.txt: Removed.
- js/Promise-fulfill-expected.txt: Removed.
- js/Promise-fulfill-in-workers-expected.txt: Removed.
- js/Promise-fulfill-in-workers.html: Removed.
- js/Promise-fulfill.html: Removed.
- js/Promise-init-expected.txt: Removed.
- js/Promise-init-in-workers-expected.txt: Removed.
- js/Promise-init-in-workers.html: Removed.
- js/Promise-init.html: Removed.
- js/Promise-reject-expected.txt: Removed.
- js/Promise-reject-in-workers-expected.txt: Removed.
- js/Promise-reject-in-workers.html: Removed.
- js/Promise-reject.html: Removed.
- js/Promise-resolve-chain-expected.txt: Removed.
- js/Promise-resolve-chain.html: Removed.
- js/Promise-resolve-expected.txt: Removed.
- js/Promise-resolve-in-workers-expected.txt: Removed.
- js/Promise-resolve-in-workers.html: Removed.
- js/Promise-resolve-with-then-exception-expected.txt: Removed.
- js/Promise-resolve-with-then-exception.html: Removed.
- js/Promise-resolve-with-then-fulfill-expected.txt: Removed.
- js/Promise-resolve-with-then-fulfill.html: Removed.
- js/Promise-resolve-with-then-reject-expected.txt: Removed.
- js/Promise-resolve-with-then-reject.html: Removed.
- js/Promise-resolve.html: Removed.
- js/Promise-simple-expected.txt: Removed.
- js/Promise-simple-fulfill-expected.txt: Removed.
- js/Promise-simple-fulfill-inside-callback-expected.txt: Removed.
- js/Promise-simple-fulfill-inside-callback.html: Removed.
- js/Promise-simple-fulfill.html: Removed.
- js/Promise-simple-in-workers-expected.txt: Removed.
- js/Promise-simple-in-workers.html: Removed.
- js/Promise-simple.html: Removed.
- js/Promise-static-fulfill-expected.txt: Removed.
- js/Promise-static-fulfill.html: Removed.
- js/Promise-static-reject-expected.txt: Removed.
- js/Promise-static-reject.html: Removed.
- js/Promise-static-resolve-expected.txt: Removed.
- js/Promise-static-resolve.html: Removed.
- js/Promise-then-expected.txt: Removed.
- js/Promise-then-in-workers-expected.txt: Removed.
- js/Promise-then-in-workers.html: Removed.
- js/Promise-then-without-callbacks-expected.txt: Removed.
- js/Promise-then-without-callbacks-in-workers-expected.txt: Removed.
- js/Promise-then-without-callbacks-in-workers.html: Removed.
- js/Promise-then-without-callbacks.html: Removed.
- js/Promise-then.html: Removed.
- js/Promise-types-expected.txt: Removed.
- js/Promise-types.html: Removed.
- js/Promise.html: Removed.
- js/activation-object-function-lifetime-expected.txt: Removed.
- js/activation-object-function-lifetime.html: Removed.
- js/activation-proto-expected.txt: Removed.
- js/activation-proto.html: Removed.
- js/add-to-primitive-expected.txt: Removed.
- js/add-to-primitive.html: Removed.
- js/array-float-delete-expected.txt: Removed.
- js/array-float-delete.html: Removed.
- js/array-foreach-expected.txt: Removed.
- js/array-foreach.html: Removed.
- js/array-indexof-expected.txt: Removed.
- js/array-indexof.html: Removed.
- js/array-join-bug-11524-expected.txt: Removed.
- js/array-join-bug-11524.html: Removed.
- js/array-map-expected.txt: Removed.
- js/array-map.html: Removed.
- js/array-prototype-properties-expected.txt: Removed.
- js/array-prototype-properties.html: Removed.
- js/array-some-expected.txt: Removed.
- js/array-some.html: Removed.
- js/array-sort-exception-expected.txt: Removed.
- js/array-sort-exception.html: Removed.
- js/array-tostring-ignore-separator-expected.txt: Removed.
- js/array-tostring-ignore-separator.html: Removed.
- js/array-with-double-assign-expected.txt: Removed.
- js/array-with-double-assign.html: Removed.
- js/array-with-double-push-expected.txt: Removed.
- js/array-with-double-push.html: Removed.
- js/assign-expected.txt: Removed.
- js/assign.html: Removed.
- js/basic-map-expected.txt: Removed.
- js/basic-map.html: Removed.
- js/basic-set-expected.txt: Removed.
- js/basic-set.html: Removed.
- js/basic-weakmap-expected.txt: Removed.
- js/basic-weakmap.html: Removed.
- js/bitwise-and-on-undefined-expected.txt: Removed.
- js/bitwise-and-on-undefined.html: Removed.
- js/bom-in-file-retains-correct-offset-expected.txt: Removed.
- js/bom-in-file-retains-correct-offset.html: Removed.
- js/branch-fold-correctness-expected.txt: Removed.
- js/branch-fold-correctness.html: Removed.
- js/cached-eval-gc-expected.txt: Removed.
- js/cached-eval-gc.html: Removed.
- js/call-base-resolution-expected.txt: Removed.
- js/call-base-resolution.html: Removed.
- js/callback-function-with-handle-event-expected.txt: Removed.
- js/callback-function-with-handle-event.html: Removed.
- js/codegen-temporaries-multiple-global-blocks-expected.txt: Removed.
- js/codegen-temporaries-multiple-global-blocks.html: Removed.
- js/concat-large-strings-crash-expected.txt: Removed.
- js/concat-large-strings-crash.html: Removed.
- js/concat-large-strings-crash2-expected.txt: Removed.
- js/concat-large-strings-crash2.html: Removed.
- js/console-non-string-values-expected.txt: Removed.
- js/console-non-string-values.html: Removed.
- js/const-expected.txt: Removed.
- js/const.html: Removed.
- js/construct-global-object-expected.txt: Removed.
- js/construct-global-object.html: Removed.
- js/constructor-attributes-expected.txt: Removed.
- js/constructor-attributes.html: Removed.
- js/constructor-expected.txt: Removed.
- js/constructor-length.html: Removed.
- js/constructor.html: Removed.
- js/create-lots-of-workers-expected.txt: Removed.
- js/create-lots-of-workers.html: Removed.
- js/cross-frame-bad-time-expected.txt: Removed.
- js/cross-frame-bad-time.html: Removed.
- js/cross-frame-prototype-expected.txt: Removed.
- js/cross-frame-prototype.html: Removed.
- js/cross-frame-really-bad-time-expected.txt: Removed.
- js/cross-frame-really-bad-time-with-proto-expected.txt: Removed.
- js/cross-frame-really-bad-time-with-proto.html: Removed.
- js/cross-frame-really-bad-time.html: Removed.
- js/cross-global-object-inline-global-var-expected.txt: Removed.
- js/cross-global-object-inline-global-var.html: Removed.
- js/custom-constructors-expected.txt: Removed.
- js/custom-constructors.html: Removed.
- js/cyclic-proto-expected.txt: Removed.
- js/cyclic-proto.html: Removed.
- js/cyclic-ref-toString-expected.txt: Removed.
- js/cyclic-ref-toString.html: Removed.
- js/date-DST-time-cusps-expected.txt: Removed.
- js/date-DST-time-cusps.html: Removed.
- js/date-big-constructor-expected.txt: Removed.
- js/date-big-constructor.html: Removed.
- js/date-big-setdate-expected.txt: Removed.
- js/date-big-setdate.html: Removed.
- js/date-big-setmonth-expected.txt: Removed.
- js/date-big-setmonth.html: Removed.
- js/date-negative-setmonth-expected.txt: Removed.
- js/date-negative-setmonth.html: Removed.
- js/date-preserve-milliseconds-expected.txt: Removed.
- js/date-preserve-milliseconds.html: Removed.
- js/deep-recursion-test-expected.txt: Removed.
- js/deep-recursion-test.html: Removed.
- js/delete-function-parameter-expected.txt: Removed.
- js/delete-function-parameter.html: Removed.
- js/delete-multiple-global-blocks-expected.txt: Removed.
- js/delete-multiple-global-blocks.html: Removed.
- js/delete-syntax-expected.txt: Removed.
- js/delete-syntax.html: Removed.
- js/dfg-arguments-alias-activation-expected.txt: Removed.
- js/dfg-arguments-alias-activation.html: Removed.
- js/dfg-byte-array-put-expected.txt: Removed.
- js/dfg-byte-array-put.html: Removed.
- js/dfg-byteOffset-neuter-expected.txt: Removed.
- js/dfg-byteOffset-neuter.html: Removed.
- js/dfg-compare-final-object-to-final-object-or-other-expected.txt: Removed.
- js/dfg-compare-final-object-to-final-object-or-other.html: Removed.
- js/dfg-cross-global-object-inline-new-array-expected.txt: Removed.
- js/dfg-cross-global-object-inline-new-array-literal-expected.txt: Removed.
- js/dfg-cross-global-object-inline-new-array-literal-with-variables-expected.txt: Removed.
- js/dfg-cross-global-object-inline-new-array-literal-with-variables.html: Removed.
- js/dfg-cross-global-object-inline-new-array-literal.html: Removed.
- js/dfg-cross-global-object-inline-new-array-with-elements-expected.txt: Removed.
- js/dfg-cross-global-object-inline-new-array-with-elements.html: Removed.
- js/dfg-cross-global-object-inline-new-array-with-size-expected.txt: Removed.
- js/dfg-cross-global-object-inline-new-array-with-size.html: Removed.
- js/dfg-cross-global-object-inline-new-array.html: Removed.
- js/dfg-cross-global-object-new-array-expected.txt: Removed.
- js/dfg-cross-global-object-new-array.html: Removed.
- js/dfg-custom-getter-expected.txt: Removed.
- js/dfg-custom-getter-throw-expected.txt: Removed.
- js/dfg-custom-getter-throw-inlined-expected.txt: Removed.
- js/dfg-custom-getter-throw-inlined.html: Removed.
- js/dfg-custom-getter-throw.html: Removed.
- js/dfg-custom-getter.html: Removed.
- js/dfg-ensure-array-storage-on-window-expected.txt: Removed.
- js/dfg-ensure-array-storage-on-window.html: Removed.
- js/dfg-ensure-non-array-array-storage-on-window-expected.txt: Removed.
- js/dfg-ensure-non-array-array-storage-on-window.html: Removed.
- js/dfg-inline-resolve-expected.txt: Removed.
- js/dfg-inline-resolve.html: Removed.
- js/dfg-inline-switch-imm-expected.txt: Removed.
- js/dfg-inline-switch-imm.html: Removed.
- js/dfg-int32-to-double-on-set-local-and-exit-expected.txt: Removed.
- js/dfg-int32-to-double-on-set-local-and-exit.html: Removed.
- js/dfg-int32-to-double-on-set-local-and-sometimes-exit-expected.txt: Removed.
- js/dfg-int32-to-double-on-set-local-and-sometimes-exit.html: Removed.
- js/dfg-logical-not-final-object-or-other-expected.txt: Removed.
- js/dfg-logical-not-final-object-or-other.html: Removed.
- js/dfg-make-rope-side-effects-expected.txt: Removed.
- js/dfg-make-rope-side-effects.html: Removed.
- js/dfg-negative-array-size-expected.txt: Removed.
- js/dfg-negative-array-size.html: Removed.
- js/dfg-patchable-get-by-id-after-watchpoint-expected.txt: Removed.
- js/dfg-patchable-get-by-id-after-watchpoint.html: Removed.
- js/dfg-peephole-compare-final-object-to-final-object-or-other-expected.txt: Removed.
- js/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object-expected.txt: Removed.
- js/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.html: Removed.
- js/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object-expected.txt: Removed.
- js/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object.html: Removed.
- js/dfg-peephole-compare-final-object-to-final-object-or-other.html: Removed.
- js/dfg-proto-stub-watchpoint-fire-expected.txt: Removed.
- js/dfg-proto-stub-watchpoint-fire.html: Removed.
- js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Removed.
- js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Removed.
- js/dfg-put-by-id-allocate-storage-expected.txt: Removed.
- js/dfg-put-by-id-allocate-storage-polymorphic-expected.txt: Removed.
- js/dfg-put-by-id-allocate-storage-polymorphic.html: Removed.
- js/dfg-put-by-id-allocate-storage.html: Removed.
- js/dfg-put-by-id-reallocate-storage-expected.txt: Removed.
- js/dfg-put-by-id-reallocate-storage-polymorphic-expected.txt: Removed.
- js/dfg-put-by-id-reallocate-storage-polymorphic.html: Removed.
- js/dfg-put-by-id-reallocate-storage.html: Removed.
- js/dfg-put-by-val-setter-then-get-by-val-expected.txt: Removed.
- js/dfg-put-by-val-setter-then-get-by-val.html: Removed.
- js/dfg-put-to-readonly-property-expected.txt: Removed.
- js/dfg-put-to-readonly-property.html: Removed.
- js/dfg-rshift-by-zero-eliminate-valuetoint32-expected.txt: Removed.
- js/dfg-rshift-by-zero-eliminate-valuetoint32.html: Removed.
- js/dfg-store-unexpected-value-into-argument-and-osr-exit-expected.txt: Removed.
- js/dfg-store-unexpected-value-into-argument-and-osr-exit.html: Removed.
- js/dfg-strcat-over-objects-then-exit-on-it-expected.txt: Removed.
- js/dfg-strcat-over-objects-then-exit-on-it.html: Removed.
- js/dfg-strict-mode-arguments-get-beyond-length-expected.txt: Removed.
- js/dfg-strict-mode-arguments-get-beyond-length.html: Removed.
- js/dfg-typed-array-neuter-expected.txt: Removed.
- js/dfg-typed-array-neuter.html: Removed.
- js/direct-entry-to-function-code-expected.txt: Removed.
- js/direct-entry-to-function-code.html: Removed.
- js/do-while-expression-value-expected.txt: Removed.
- js/do-while-expression-value.html: Removed.
- js/do-while-without-semicolon-expected.txt: Removed.
- js/do-while-without-semicolon.html: Removed.
- js/document-all-between-frames-expected.txt: Removed.
- js/document-all-between-frames.html: Removed.
- js/document-all-triggers-masquerades-watchpoint-expected.txt: Removed.
- js/document-all-triggers-masquerades-watchpoint.html: Removed.
- js/dom: Added.
- js/dom-static-property-for-in-iteration-expected.txt: Removed.
- js/dom-static-property-for-in-iteration.html: Removed.
- js/dom/JSON-parse-expected.txt: Added.
- js/dom/JSON-parse.html: Added.
- js/dom/JSON-stringify-expected.txt: Added.
- js/dom/JSON-stringify.html: Added.
- js/dom/Object-defineProperty-expected.txt: Added.
- js/dom/Object-defineProperty.html: Added.
- js/dom/Promise-already-fulfilled-expected.txt: Added.
- js/dom/Promise-already-fulfilled.html: Added.
- js/dom/Promise-already-rejected-expected.txt: Added.
- js/dom/Promise-already-rejected.html: Added.
- js/dom/Promise-already-resolved-expected.txt: Added.
- js/dom/Promise-already-resolved.html: Added.
- js/dom/Promise-catch-expected.txt: Added.
- js/dom/Promise-catch-in-workers-expected.txt: Added.
- js/dom/Promise-catch-in-workers.html: Added.
- js/dom/Promise-catch.html: Added.
- js/dom/Promise-chain-expected.txt: Added.
- js/dom/Promise-chain.html: Added.
- js/dom/Promise-exception-expected.txt: Added.
- js/dom/Promise-exception.html: Added.
- js/dom/Promise-expected.txt: Added.
- js/dom/Promise-fulfill-expected.txt: Added.
- js/dom/Promise-fulfill-in-workers-expected.txt: Added.
- js/dom/Promise-fulfill-in-workers.html: Added.
- js/dom/Promise-fulfill.html: Added.
- js/dom/Promise-init-expected.txt: Added.
- js/dom/Promise-init-in-workers-expected.txt: Added.
- js/dom/Promise-init-in-workers.html: Added.
- js/dom/Promise-init.html: Added.
- js/dom/Promise-reject-expected.txt: Added.
- js/dom/Promise-reject-in-workers-expected.txt: Added.
- js/dom/Promise-reject-in-workers.html: Added.
- js/dom/Promise-reject.html: Added.
- js/dom/Promise-resolve-chain-expected.txt: Added.
- js/dom/Promise-resolve-chain.html: Added.
- js/dom/Promise-resolve-expected.txt: Added.
- js/dom/Promise-resolve-in-workers-expected.txt: Added.
- js/dom/Promise-resolve-in-workers.html: Added.
- js/dom/Promise-resolve-with-then-exception-expected.txt: Added.
- js/dom/Promise-resolve-with-then-exception.html: Added.
- js/dom/Promise-resolve-with-then-fulfill-expected.txt: Added.
- js/dom/Promise-resolve-with-then-fulfill.html: Added.
- js/dom/Promise-resolve-with-then-reject-expected.txt: Added.
- js/dom/Promise-resolve-with-then-reject.html: Added.
- js/dom/Promise-resolve.html: Added.
- js/dom/Promise-simple-expected.txt: Added.
- js/dom/Promise-simple-fulfill-expected.txt: Added.
- js/dom/Promise-simple-fulfill-inside-callback-expected.txt: Added.
- js/dom/Promise-simple-fulfill-inside-callback.html: Added.
- js/dom/Promise-simple-fulfill.html: Added.
- js/dom/Promise-simple-in-workers-expected.txt: Added.
- js/dom/Promise-simple-in-workers.html: Added.
- js/dom/Promise-simple.html: Added.
- js/dom/Promise-static-fulfill-expected.txt: Added.
- js/dom/Promise-static-fulfill.html: Added.
- js/dom/Promise-static-reject-expected.txt: Added.
- js/dom/Promise-static-reject.html: Added.
- js/dom/Promise-static-resolve-expected.txt: Added.
- js/dom/Promise-static-resolve.html: Added.
- js/dom/Promise-then-expected.txt: Added.
- js/dom/Promise-then-in-workers-expected.txt: Added.
- js/dom/Promise-then-in-workers.html: Added.
- js/dom/Promise-then-without-callbacks-expected.txt: Added.
- js/dom/Promise-then-without-callbacks-in-workers-expected.txt: Added.
- js/dom/Promise-then-without-callbacks-in-workers.html: Added.
- js/dom/Promise-then-without-callbacks.html: Added.
- js/dom/Promise-then.html: Added.
- js/dom/Promise-types-expected.txt: Added.
- js/dom/Promise-types.html: Added.
- js/dom/Promise.html: Added.
- js/dom/activation-object-function-lifetime-expected.txt: Added.
- js/dom/activation-object-function-lifetime.html: Added.
- js/dom/activation-proto-expected.txt: Added.
- js/dom/activation-proto.html: Added.
- js/dom/add-to-primitive-expected.txt: Added.
- js/dom/add-to-primitive.html: Added.
- js/dom/array-float-delete-expected.txt: Added.
- js/dom/array-float-delete.html: Added.
- js/dom/array-foreach-expected.txt: Added.
- js/dom/array-foreach.html: Added.
- js/dom/array-indexof-expected.txt: Added.
- js/dom/array-indexof.html: Added.
- js/dom/array-join-bug-11524-expected.txt: Added.
- js/dom/array-join-bug-11524.html: Added.
- js/dom/array-map-expected.txt: Added.
- js/dom/array-map.html: Added.
- js/dom/array-prototype-properties-expected.txt: Added.
- js/dom/array-prototype-properties.html: Added.
- js/dom/array-some-expected.txt: Added.
- js/dom/array-some.html: Added.
- js/dom/array-sort-exception-expected.txt: Added.
- js/dom/array-sort-exception.html: Added.
- js/dom/array-tostring-ignore-separator-expected.txt: Added.
- js/dom/array-tostring-ignore-separator.html: Added.
- js/dom/array-with-double-assign-expected.txt: Added.
- js/dom/array-with-double-assign.html: Added.
- js/dom/array-with-double-push-expected.txt: Added.
- js/dom/array-with-double-push.html: Added.
- js/dom/assign-expected.txt: Added.
- js/dom/assign.html: Added.
- js/dom/basic-map-expected.txt: Added.
- js/dom/basic-map.html: Added.
- js/dom/basic-set-expected.txt: Added.
- js/dom/basic-set.html: Added.
- js/dom/basic-weakmap-expected.txt: Added.
- js/dom/basic-weakmap.html: Added.
- js/dom/bitwise-and-on-undefined-expected.txt: Added.
- js/dom/bitwise-and-on-undefined.html: Added.
- js/dom/bom-in-file-retains-correct-offset-expected.txt: Added.
- js/dom/bom-in-file-retains-correct-offset.html: Added.
- js/dom/branch-fold-correctness-expected.txt: Added.
- js/dom/branch-fold-correctness.html: Added.
- js/dom/cached-eval-gc-expected.txt: Added.
- js/dom/cached-eval-gc.html: Added.
- js/dom/call-base-resolution-expected.txt: Added.
- js/dom/call-base-resolution.html: Added.
- js/dom/callback-function-with-handle-event-expected.txt: Added.
- js/dom/callback-function-with-handle-event.html: Added.
- js/dom/codegen-temporaries-multiple-global-blocks-expected.txt: Added.
- js/dom/codegen-temporaries-multiple-global-blocks.html: Added.
- js/dom/concat-large-strings-crash-expected.txt: Added.
- js/dom/concat-large-strings-crash.html: Added.
- js/dom/concat-large-strings-crash2-expected.txt: Added.
- js/dom/concat-large-strings-crash2.html: Added.
- js/dom/console-non-string-values-expected.txt: Added.
- js/dom/console-non-string-values.html: Added.
- js/dom/const-expected.txt: Added.
- js/dom/const.html: Added.
- js/dom/construct-global-object-expected.txt: Added.
- js/dom/construct-global-object.html: Added.
- js/dom/constructor-attributes-expected.txt: Added.
- js/dom/constructor-attributes.html: Added.
- js/dom/constructor-expected.txt: Added.
- js/dom/constructor-length.html: Added.
- js/dom/constructor.html: Added.
- js/dom/create-lots-of-workers-expected.txt: Added.
- js/dom/create-lots-of-workers.html: Added.
- js/dom/cross-frame-bad-time-expected.txt: Added.
- js/dom/cross-frame-bad-time.html: Added.
- js/dom/cross-frame-prototype-expected.txt: Added.
- js/dom/cross-frame-prototype.html: Added.
- js/dom/cross-frame-really-bad-time-expected.txt: Added.
- js/dom/cross-frame-really-bad-time-with-proto-expected.txt: Added.
- js/dom/cross-frame-really-bad-time-with-proto.html: Added.
- js/dom/cross-frame-really-bad-time.html: Added.
- js/dom/cross-global-object-inline-global-var-expected.txt: Added.
- js/dom/cross-global-object-inline-global-var.html: Added.
- js/dom/custom-constructors-expected.txt: Added.
- js/dom/custom-constructors.html: Added.
- js/dom/cyclic-proto-expected.txt: Added.
- js/dom/cyclic-proto.html: Added.
- js/dom/cyclic-ref-toString-expected.txt: Added.
- js/dom/cyclic-ref-toString.html: Added.
- js/dom/date-DST-time-cusps-expected.txt: Added.
- js/dom/date-DST-time-cusps.html: Added.
- js/dom/date-big-constructor-expected.txt: Added.
- js/dom/date-big-constructor.html: Added.
- js/dom/date-big-setdate-expected.txt: Added.
- js/dom/date-big-setdate.html: Added.
- js/dom/date-big-setmonth-expected.txt: Added.
- js/dom/date-big-setmonth.html: Added.
- js/dom/date-negative-setmonth-expected.txt: Added.
- js/dom/date-negative-setmonth.html: Added.
- js/dom/date-preserve-milliseconds-expected.txt: Added.
- js/dom/date-preserve-milliseconds.html: Added.
- js/dom/deep-recursion-test-expected.txt: Added.
- js/dom/deep-recursion-test.html: Added.
- js/dom/delete-function-parameter-expected.txt: Added.
- js/dom/delete-function-parameter.html: Added.
- js/dom/delete-multiple-global-blocks-expected.txt: Added.
- js/dom/delete-multiple-global-blocks.html: Added.
- js/dom/delete-syntax-expected.txt: Added.
- js/dom/delete-syntax.html: Added.
- js/dom/dfg-arguments-alias-activation-expected.txt: Added.
- js/dom/dfg-arguments-alias-activation.html: Added.
- js/dom/dfg-byte-array-put-expected.txt: Added.
- js/dom/dfg-byte-array-put.html: Added.
- js/dom/dfg-byteOffset-neuter-expected.txt: Added.
- js/dom/dfg-byteOffset-neuter.html: Added.
- js/dom/dfg-compare-final-object-to-final-object-or-other-expected.txt: Added.
- js/dom/dfg-compare-final-object-to-final-object-or-other.html: Added.
- js/dom/dfg-cross-global-object-inline-new-array-expected.txt: Added.
- js/dom/dfg-cross-global-object-inline-new-array-literal-expected.txt: Added.
- js/dom/dfg-cross-global-object-inline-new-array-literal-with-variables-expected.txt: Added.
- js/dom/dfg-cross-global-object-inline-new-array-literal-with-variables.html: Added.
- js/dom/dfg-cross-global-object-inline-new-array-literal.html: Added.
- js/dom/dfg-cross-global-object-inline-new-array-with-elements-expected.txt: Added.
- js/dom/dfg-cross-global-object-inline-new-array-with-elements.html: Added.
- js/dom/dfg-cross-global-object-inline-new-array-with-size-expected.txt: Added.
- js/dom/dfg-cross-global-object-inline-new-array-with-size.html: Added.
- js/dom/dfg-cross-global-object-inline-new-array.html: Added.
- js/dom/dfg-cross-global-object-new-array-expected.txt: Added.
- js/dom/dfg-cross-global-object-new-array.html: Added.
- js/dom/dfg-custom-getter-expected.txt: Added.
- js/dom/dfg-custom-getter-throw-expected.txt: Added.
- js/dom/dfg-custom-getter-throw-inlined-expected.txt: Added.
- js/dom/dfg-custom-getter-throw-inlined.html: Added.
- js/dom/dfg-custom-getter-throw.html: Added.
- js/dom/dfg-custom-getter.html: Added.
- js/dom/dfg-ensure-array-storage-on-window-expected.txt: Added.
- js/dom/dfg-ensure-array-storage-on-window.html: Added.
- js/dom/dfg-ensure-non-array-array-storage-on-window-expected.txt: Added.
- js/dom/dfg-ensure-non-array-array-storage-on-window.html: Added.
- js/dom/dfg-inline-resolve-expected.txt: Added.
- js/dom/dfg-inline-resolve.html: Added.
- js/dom/dfg-inline-switch-imm-expected.txt: Added.
- js/dom/dfg-inline-switch-imm.html: Added.
- js/dom/dfg-int32-to-double-on-set-local-and-exit-expected.txt: Added.
- js/dom/dfg-int32-to-double-on-set-local-and-exit.html: Added.
- js/dom/dfg-int32-to-double-on-set-local-and-sometimes-exit-expected.txt: Added.
- js/dom/dfg-int32-to-double-on-set-local-and-sometimes-exit.html: Added.
- js/dom/dfg-logical-not-final-object-or-other-expected.txt: Added.
- js/dom/dfg-logical-not-final-object-or-other.html: Added.
- js/dom/dfg-make-rope-side-effects-expected.txt: Added.
- js/dom/dfg-make-rope-side-effects.html: Added.
- js/dom/dfg-negative-array-size-expected.txt: Added.
- js/dom/dfg-negative-array-size.html: Added.
- js/dom/dfg-patchable-get-by-id-after-watchpoint-expected.txt: Added.
- js/dom/dfg-patchable-get-by-id-after-watchpoint.html: Added.
- js/dom/dfg-peephole-compare-final-object-to-final-object-or-other-expected.txt: Added.
- js/dom/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object-expected.txt: Added.
- js/dom/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.html: Added.
- js/dom/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object-expected.txt: Added.
- js/dom/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object.html: Added.
- js/dom/dfg-peephole-compare-final-object-to-final-object-or-other.html: Added.
- js/dom/dfg-proto-stub-watchpoint-fire-expected.txt: Added.
- js/dom/dfg-proto-stub-watchpoint-fire.html: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Added.
- js/dom/dfg-put-by-id-allocate-storage-expected.txt: Added.
- js/dom/dfg-put-by-id-allocate-storage-polymorphic-expected.txt: Added.
- js/dom/dfg-put-by-id-allocate-storage-polymorphic.html: Added.
- js/dom/dfg-put-by-id-allocate-storage.html: Added.
- js/dom/dfg-put-by-id-reallocate-storage-expected.txt: Added.
- js/dom/dfg-put-by-id-reallocate-storage-polymorphic-expected.txt: Added.
- js/dom/dfg-put-by-id-reallocate-storage-polymorphic.html: Added.
- js/dom/dfg-put-by-id-reallocate-storage.html: Added.
- js/dom/dfg-put-by-val-setter-then-get-by-val-expected.txt: Added.
- js/dom/dfg-put-by-val-setter-then-get-by-val.html: Added.
- js/dom/dfg-put-to-readonly-property-expected.txt: Added.
- js/dom/dfg-put-to-readonly-property.html: Added.
- js/dom/dfg-rshift-by-zero-eliminate-valuetoint32-expected.txt: Added.
- js/dom/dfg-rshift-by-zero-eliminate-valuetoint32.html: Added.
- js/dom/dfg-store-unexpected-value-into-argument-and-osr-exit-expected.txt: Added.
- js/dom/dfg-store-unexpected-value-into-argument-and-osr-exit.html: Added.
- js/dom/dfg-strcat-over-objects-then-exit-on-it-expected.txt: Added.
- js/dom/dfg-strcat-over-objects-then-exit-on-it.html: Added.
- js/dom/dfg-strict-mode-arguments-get-beyond-length-expected.txt: Added.
- js/dom/dfg-strict-mode-arguments-get-beyond-length.html: Added.
- js/dom/dfg-typed-array-neuter-expected.txt: Added.
- js/dom/dfg-typed-array-neuter.html: Added.
- js/dom/direct-entry-to-function-code-expected.txt: Added.
- js/dom/direct-entry-to-function-code.html: Added.
- js/dom/do-while-expression-value-expected.txt: Added.
- js/dom/do-while-expression-value.html: Added.
- js/dom/do-while-without-semicolon-expected.txt: Added.
- js/dom/do-while-without-semicolon.html: Added.
- js/dom/document-all-between-frames-expected.txt: Added.
- js/dom/document-all-between-frames.html: Added.
- js/dom/document-all-triggers-masquerades-watchpoint-expected.txt: Added.
- js/dom/document-all-triggers-masquerades-watchpoint.html: Added.
- js/dom/dom-static-property-for-in-iteration-expected.txt: Added.
- js/dom/dom-static-property-for-in-iteration.html: Added.
- js/dom/dot-node-base-exception-expected.txt: Added.
- js/dom/dot-node-base-exception.html: Added.
- js/dom/encode-URI-test-expected.txt: Added.
- js/dom/encode-URI-test.html: Added.
- js/dom/end-in-string-escape-expected.txt: Added.
- js/dom/end-in-string-escape.html: Added.
- js/dom/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt: Added.
- js/dom/enter-dictionary-indexing-mode-with-blank-indexing-type.html: Added.
- js/dom/error-object-write-and-detele-for-stack-property-expected.txt: Added.
- js/dom/error-object-write-and-detele-for-stack-property.html: Added.
- js/dom/eval-cache-scoped-lookup-expected.txt: Added.
- js/dom/eval-cache-scoped-lookup.html: Added.
- js/dom/eval-contained-syntax-error-expected.txt: Added.
- js/dom/eval-contained-syntax-error.html: Added.
- js/dom/eval-cross-window-expected.txt: Added.
- js/dom/eval-cross-window.html: Added.
- js/dom/eval-keyword-vs-function-expected.txt: Added.
- js/dom/eval-keyword-vs-function.html: Added.
- js/dom/eval-overriding-expected.txt: Added.
- js/dom/eval-overriding.html: Added.
- js/dom/exception-codegen-crash-expected.txt: Added.
- js/dom/exception-codegen-crash.html: Added.
- js/dom/exception-line-number-expected.txt: Added.
- js/dom/exception-line-number.html: Added.
- js/dom/exception-linenums-in-html-1-expected.txt: Added.
- js/dom/exception-linenums-in-html-1.html: Added.
- js/dom/exception-linenums-in-html-2-expected.txt: Added.
- js/dom/exception-linenums-in-html-2.html: Added.
- js/dom/exception-linenums-in-html-3-expected.txt: Added.
- js/dom/exception-linenums-in-html-3.html: Added.
- js/dom/exception-registerfile-shrink-expected.txt: Added.
- js/dom/exception-registerfile-shrink.html: Added.
- js/dom/exception-sequencing-binops-expected.txt: Added.
- js/dom/exception-sequencing-binops.html: Added.
- js/dom/exception-sequencing-binops2-expected.txt: Added.
- js/dom/exception-sequencing-binops2.html: Added.
- js/dom/exception-sequencing-expected.txt: Added.
- js/dom/exception-sequencing.html: Added.
- js/dom/exception-thrown-from-equal-expected.txt: Added.
- js/dom/exception-thrown-from-equal.html: Added.
- js/dom/exception-thrown-from-eval-inside-closure-expected.txt: Added.
- js/dom/exception-thrown-from-eval-inside-closure.html: Added.
- js/dom/exception-thrown-from-function-with-lazy-activation-expected.txt: Added.
- js/dom/exception-thrown-from-function-with-lazy-activation.html: Added.
- js/dom/exception-thrown-from-new-expected.txt: Added.
- js/dom/exception-thrown-from-new.html: Added.
- js/dom/exceptions-thrown-in-callbacks-expected.txt: Added.
- js/dom/exceptions-thrown-in-callbacks.html: Added.
- js/dom/exec-state-marking-expected.txt: Added.
- js/dom/exec-state-marking.html: Added.
- js/dom/find-ignoring-case-regress-99753-expected.txt: Added.
- js/dom/find-ignoring-case-regress-99753.html: Added.
- js/dom/floating-point-truncate-rshift-expected.txt: Added.
- js/dom/floating-point-truncate-rshift.html: Added.
- js/dom/function-argument-evaluation-before-exception-expected.txt: Added.
- js/dom/function-argument-evaluation-before-exception.html: Added.
- js/dom/function-argument-evaluation-expected.txt: Added.
- js/dom/function-argument-evaluation.html: Added.
- js/dom/function-bind-expected.txt: Added.
- js/dom/function-bind.html: Added.
- js/dom/function-constructor-this-value-expected.txt: Added.
- js/dom/function-constructor-this-value.html: Added.
- js/dom/function-declarations-expected.txt: Added.
- js/dom/function-declarations.html: Added.
- js/dom/function-decompilation-operators-expected.txt: Added.
- js/dom/function-decompilation-operators.html: Added.
- js/dom/function-dot-arguments-and-caller-expected.txt: Added.
- js/dom/function-dot-arguments-and-caller.html: Added.
- js/dom/function-dot-arguments-identity-expected.txt: Added.
- js/dom/function-dot-arguments-identity.html: Added.
- js/dom/function-dot-arguments2-expected.txt: Added.
- js/dom/function-dot-arguments2.html: Added.
- js/dom/function-length-expected.txt: Added.
- js/dom/function-length.html: Added.
- js/dom/function-name-expected.txt: Added.
- js/dom/function-name-is-in-scope-expected.txt: Added.
- js/dom/function-name-is-in-scope.html: Added.
- js/dom/function-name.html: Added.
- js/dom/function-names-expected.txt: Added.
- js/dom/function-names.html: Added.
- js/dom/function-prototype-expected.txt: Added.
- js/dom/function-prototype.html: Added.
- js/dom/function-redefinition-expected.txt: Added.
- js/dom/function-redefinition.html: Added.
- js/dom/garbage-collect-after-string-appends-expected.txt: Added.
- js/dom/get-by-pname-only-prototype-properties-expected.txt: Added.
- js/dom/get-by-pname-only-prototype-properties.html: Added.
- js/dom/getOwnPropertyDescriptor-expected.txt: Added.
- js/dom/getOwnPropertyDescriptor.html: Added.
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Added.
- js/dom/global-constructors-attributes-dedicated-worker.html: Added.
- js/dom/global-constructors-attributes-expected.txt: Added.
- js/dom/global-constructors-attributes-shared-worker-expected.txt: Added.
- js/dom/global-constructors-attributes-shared-worker.html: Added.
- js/dom/global-constructors-attributes.html: Added.
- js/dom/global-constructors-deletable-expected.txt: Added.
- js/dom/global-constructors-deletable.html: Added.
- js/dom/global-function-resolve-expected.txt: Added.
- js/dom/global-function-resolve.html: Added.
- js/dom/global-recursion-on-full-stack-expected.txt: Added.
- js/dom/global-recursion-on-full-stack.html: Added.
- js/dom/global-var-limit-expected.txt: Added.
- js/dom/global-var-limit.html: Added.
- js/dom/immediate-constant-instead-of-cell-expected.txt: Added.
- js/dom/immediate-constant-instead-of-cell.html: Added.
- js/dom/implicit-call-with-global-reentry-expected.txt: Added.
- js/dom/implicit-call-with-global-reentry.html: Added.
- js/dom/implicit-global-to-global-reentry-expected.txt: Added.
- js/dom/implicit-global-to-global-reentry.html: Added.
- js/dom/imul-expected.txt: Added.
- js/dom/imul.html: Added.
- js/dom/inc-bracket-assign-subscript-expected.txt: Added.
- js/dom/inc-bracket-assign-subscript.html: Added.
- js/dom/inc-const-valueOf-expected.txt: Added.
- js/dom/inc-const-valueOf.html: Added.
- js/dom/indexed-setter-on-global-object-expected.txt: Added.
- js/dom/indexed-setter-on-global-object.html: Added.
- js/dom/inline-arguments-tear-off-expected.txt: Added.
- js/dom/inline-arguments-tear-off.html: Added.
- js/dom/instanceof-XMLHttpRequest-expected.txt: Added.
- js/dom/instanceof-XMLHttpRequest.html: Added.
- js/dom/invalid-syntax-for-function-expected.txt: Added.
- js/dom/invalid-syntax-for-function.html: Added.
- js/dom/jit-set-profiling-access-type-only-for-get-by-id-self-expected.txt: Added.
- js/dom/jit-set-profiling-access-type-only-for-get-by-id-self.html: Added.
- js/dom/js-constructors-use-correct-global-expected.txt: Added.
- js/dom/js-constructors-use-correct-global.html: Added.
- js/dom/js-correct-exception-handler-expected.txt: Added.
- js/dom/js-correct-exception-handler.html: Added.
- js/dom/lastModified-expected.txt: Added.
- js/dom/lastModified.html: Added.
- js/dom/lazy-create-arguments-from-get-by-val-expected.txt: Added.
- js/dom/lazy-create-arguments-from-get-by-val.html: Added.
- js/dom/lexical-lookup-in-function-constructor-expected.txt: Added.
- js/dom/lexical-lookup-in-function-constructor.html: Added.
- js/dom/line-column-numbers-expected.txt: Added.
- js/dom/line-column-numbers.html: Added.
- js/dom/method-check-expected.txt: Added.
- js/dom/method-check.html: Added.
- js/dom/missing-style-end-tag-js-expected.txt: Added.
- js/dom/missing-style-end-tag-js.html: Added.
- js/dom/missing-title-end-tag-js-expected.txt: Added.
- js/dom/missing-title-end-tag-js.html: Added.
- js/dom/native-error-prototype-expected.txt: Added.
- js/dom/native-error-prototype.html: Added.
- js/dom/navigator-language-expected.txt: Added.
- js/dom/navigator-language.html: Added.
- js/dom/navigator-plugins-crash-expected.txt: Added.
- js/dom/navigator-plugins-crash.html: Added.
- js/dom/negate-overflow-expected.txt: Added.
- js/dom/negate-overflow.html: Added.
- js/dom/neq-null-crash-expected.txt: Added.
- js/dom/neq-null-crash.html: Added.
- js/dom/nested-function-scope-expected.txt: Added.
- js/dom/nested-function-scope.html: Added.
- js/dom/nested-object-gc-expected.txt: Added.
- js/dom/nested-object-gc.html: Added.
- js/dom/non-object-proto-expected.txt: Added.
- js/dom/non-object-proto.html: Added.
- js/dom/normal-character-escapes-in-string-literals-expected.txt: Added.
- js/dom/normal-character-escapes-in-string-literals.html: Added.
- js/dom/not-a-constructor-to-string-expected.txt: Added.
- js/dom/not-a-constructor-to-string.html: Added.
- js/dom/not-a-function-to-string-expected.txt: Added.
- js/dom/not-a-function-to-string.html: Added.
- js/dom/null-char-in-string-expected.txt: Added.
- js/dom/null-char-in-string.html: Added.
- js/dom/number-tofixed-expected.txt: Added.
- js/dom/number-tofixed.html: Added.
- js/dom/number-toprecision-expected.txt: Added.
- js/dom/number-toprecision.html: Added.
- js/dom/object-extra-comma-expected.txt: Added.
- js/dom/object-extra-comma.html: Added.
- js/dom/object-prototype-constructor-expected.txt: Added.
- js/dom/object-prototype-constructor.html: Added.
- js/dom/object-prototype-properties-expected.txt: Added.
- js/dom/object-prototype-properties.html: Added.
- js/dom/object-prototype-toLocaleString-expected.txt: Added.
- js/dom/object-prototype-toLocaleString.html: Added.
- js/dom/parse-error-external-script-in-eval-expected.txt: Added.
- js/dom/parse-error-external-script-in-eval.html: Added.
- js/dom/parse-error-external-script-in-new-Function-expected.txt: Added.
- js/dom/parse-error-external-script-in-new-Function.html: Added.
- js/dom/post-inc-assign-overwrites-expected.txt: Added.
- js/dom/post-inc-assign-overwrites.html: Added.
- js/dom/post-message-numeric-property-expected.txt: Added.
- js/dom/post-message-numeric-property.html: Added.
- js/dom/postfix-syntax-expected.txt: Added.
- js/dom/postfix-syntax.html: Added.
- js/dom/prefix-syntax-expected.txt: Added.
- js/dom/prefix-syntax.html: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Added.
- js/dom/put-direct-index-beyond-vector-length-resize-expected.txt: Added.
- js/dom/put-direct-index-beyond-vector-length-resize.html: Added.
- js/dom/put-to-base-global-checked-expected.txt: Added.
- js/dom/put-to-base-global-checked.html: Added.
- js/dom/random-array-gc-stress-expected.txt: Added.
- js/dom/random-array-gc-stress.html: Added.
- js/dom/recursion-limit-equal-expected.txt: Added.
- js/dom/recursion-limit-equal.html: Added.
- js/dom/regexp-bol-expected.txt: Added.
- js/dom/regexp-bol-with-multiline-expected.txt: Added.
- js/dom/regexp-bol-with-multiline.html: Added.
- js/dom/regexp-bol.html: Added.
- js/dom/regexp-caching-expected.txt: Added.
- js/dom/regexp-caching.html: Added.
- js/dom/regexp-charclass-crash-expected.txt: Added.
- js/dom/regexp-charclass-crash.html: Added.
- js/dom/regexp-extended-characters-crash-expected.txt: Added.
- js/dom/regexp-extended-characters-crash.html: Added.
- js/dom/regexp-lastindex-expected.txt: Added.
- js/dom/regexp-lastindex.html: Added.
- js/dom/regexp-look-ahead-empty-expected.txt: Added.
- js/dom/regexp-look-ahead-empty.html: Added.
- js/dom/regexp-look-ahead-expected.txt: Added.
- js/dom/regexp-look-ahead.html: Added.
- js/dom/regexp-match-reify-before-putbyval-expected.txt: Added.
- js/dom/regexp-match-reify-before-putbyval.html: Added.
- js/dom/regexp-non-capturing-groups-expected.txt: Added.
- js/dom/regexp-non-capturing-groups.html: Added.
- js/dom/regexp-non-greedy-parentheses-expected.txt: Added.
- js/dom/regexp-non-greedy-parentheses.html: Added.
- js/dom/regexp-overflow-expected.txt: Added.
- js/dom/regexp-overflow.html: Added.
- js/dom/regexp-range-out-of-order-expected.txt: Added.
- js/dom/regexp-range-out-of-order.html: Added.
- js/dom/regexp-ranges-and-escaped-hyphens-expected.txt: Added.
- js/dom/regexp-ranges-and-escaped-hyphens.html: Added.
- js/dom/regexp-stack-overflow-expected.txt: Added.
- js/dom/regexp-stack-overflow.html: Added.
- js/dom/regexp-test-null-string-expected.txt: Added.
- js/dom/regexp-test-null-string.html: Added.
- js/dom/regexp-unicode-handling-expected.txt: Added.
- js/dom/regexp-unicode-handling.html: Added.
- js/dom/regexp-unicode-overflow-expected.txt: Added.
- js/dom/regexp-unicode-overflow.html: Added.
- js/dom/removing-Cf-characters-expected.txt: Added.
- js/dom/removing-Cf-characters.html: Added.
- js/dom/reserved-words-as-property-expected.txt: Added.
- js/dom/reserved-words-as-property.html: Added.
- js/dom/same-origin-subframe-about-blank-expected.txt: Added.
- js/dom/same-origin-subframe-about-blank.html: Added.
- js/dom/script-line-number-expected.txt: Added.
- js/dom/script-line-number.html: Added.
- js/dom/script-tests: Added.
- js/dom/script-tests/Object-defineProperty.js: Added.
(createUnconfigurableProperty):
(getter):
(getter1):
(setter):
(setter1):
(get shouldBeTrue):
(testObject.):
(testObject.set get anObj):
(testObject):
- js/dom/script-tests/activation-proto.js: Added.
- js/dom/script-tests/array-float-delete.js: Added.
- js/dom/script-tests/array-join-bug-11524.js: Added.
(customObject.valueOf):
- js/dom/script-tests/array-prototype-properties.js: Added.
- js/dom/script-tests/array-sort-exception.js: Copied from LayoutTests/js/script-tests/array-sort-exception.js.
- js/dom/script-tests/array-tostring-ignore-separator.js: Added.
- js/dom/script-tests/array-with-double-assign.js: Added.
(foo):
- js/dom/script-tests/array-with-double-push.js: Added.
(foo):
- js/dom/script-tests/assign.js: Added.
- js/dom/script-tests/basic-map.js: Added.
(set shouldBe):
(set var):
- js/dom/script-tests/basic-set.js: Added.
(set new):
(otherString.string_appeared_here.set add):
(try.set forEach):
(set forEach):
(set gc):
- js/dom/script-tests/basic-weakmap.js: Added.
- js/dom/script-tests/cached-eval-gc.js: Added.
(gc):
(doTest):
- js/dom/script-tests/constructor-attributes.js: Added.
(canEnum):
(checkConstructor):
(declaredFunction):
- js/dom/script-tests/constructor.js: Added.
- js/dom/script-tests/cross-frame-bad-time.js: Added.
(foo):
- js/dom/script-tests/cross-frame-really-bad-time-with-proto.js: Added.
(foo):
(evil):
(bar):
(done):
- js/dom/script-tests/cross-frame-really-bad-time.js: Added.
(Cons):
(foo):
(evil):
(bar):
(done):
- js/dom/script-tests/cross-global-object-inline-global-var.js: Added.
(foo):
(done):
(doit):
- js/dom/script-tests/custom-constructors.js: Added.
- js/dom/script-tests/cyclic-proto.js: Added.
- js/dom/script-tests/cyclic-ref-toString.js: Added.
- js/dom/script-tests/date-DST-time-cusps.js: Added.
- js/dom/script-tests/date-big-constructor.js: Added.
- js/dom/script-tests/date-big-setdate.js: Added.
- js/dom/script-tests/date-big-setmonth.js: Added.
- js/dom/script-tests/date-negative-setmonth.js: Added.
- js/dom/script-tests/date-preserve-milliseconds.js: Added.
- js/dom/script-tests/delete-syntax.js: Added.
- js/dom/script-tests/dfg-byte-array-put.js: Added.
(doPut):
(doGet):
- js/dom/script-tests/dfg-byteOffset-neuter.js: Added.
(foo):
- js/dom/script-tests/dfg-compare-final-object-to-final-object-or-other.js: Added.
(foo):
- js/dom/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js: Added.
(foo):
(done):
(doit):
- js/dom/script-tests/dfg-cross-global-object-inline-new-array-literal.js: Added.
(foo):
(done):
(doit):
- js/dom/script-tests/dfg-cross-global-object-inline-new-array-with-elements.js: Added.
(foo):
(done):
(doit):
- js/dom/script-tests/dfg-cross-global-object-inline-new-array-with-size.js: Added.
(foo):
(done):
(doit):
- js/dom/script-tests/dfg-cross-global-object-inline-new-array.js: Added.
(foo):
(done):
(doit):
- js/dom/script-tests/dfg-cross-global-object-new-array.js: Added.
(foo):
(runTest):
(doit):
- js/dom/script-tests/dfg-custom-getter-throw-inlined.js: Added.
(foo):
(baz):
(bar):
- js/dom/script-tests/dfg-custom-getter-throw.js: Added.
(foo):
(bar):
- js/dom/script-tests/dfg-custom-getter.js: Added.
(foo):
- js/dom/script-tests/dfg-ensure-array-storage-on-window.js: Added.
(foo):
(while):
- js/dom/script-tests/dfg-ensure-non-array-array-storage-on-window.js: Added.
(foo):
(bar):
(.shouldBe):
- js/dom/script-tests/dfg-inline-switch-imm.js: Added.
(foo):
(bar):
- js/dom/script-tests/dfg-int32-to-double-on-set-local-and-exit.js: Added.
(checkpoint):
(func1):
(func2):
(func3):
(test):
- js/dom/script-tests/dfg-int32-to-double-on-set-local-and-sometimes-exit.js: Added.
(checkpoint):
(func1):
(func2):
(func3):
(test):
- js/dom/script-tests/dfg-logical-not-final-object-or-other.js: Added.
(foo):
- js/dom/script-tests/dfg-make-rope-side-effects.js: Added.
(f):
(k.valueOf):
(k.toString):
- js/dom/script-tests/dfg-negative-array-size.js: Added.
(foo):
- js/dom/script-tests/dfg-patchable-get-by-id-after-watchpoint.js: Added.
(foo):
(O):
(O.prototype.f):
(P1):
(P2):
- js/dom/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.js: Added.
(foo):
- js/dom/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object.js: Added.
(foo):
- js/dom/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other.js: Added.
(foo):
- js/dom/script-tests/dfg-proto-stub-watchpoint-fire.js: Added.
(A):
(B):
(foo):
- js/dom/script-tests/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Added.
(f):
- js/dom/script-tests/dfg-put-by-id-allocate-storage-polymorphic.js: Added.
(foo):
- js/dom/script-tests/dfg-put-by-id-allocate-storage.js: Added.
(foo):
- js/dom/script-tests/dfg-put-by-id-reallocate-storage-polymorphic.js: Added.
(foo):
- js/dom/script-tests/dfg-put-by-id-reallocate-storage.js: Added.
(foo):
- js/dom/script-tests/dfg-put-by-val-setter-then-get-by-val.js: Added.
(foo):
(for):
- js/dom/script-tests/dfg-put-to-readonly-property.js: Added.
(foo):
(bar):
- js/dom/script-tests/dfg-rshift-by-zero-eliminate-valuetoint32.js: Added.
(f):
- js/dom/script-tests/dfg-store-unexpected-value-into-argument-and-osr-exit.js: Added.
(foo):
- js/dom/script-tests/dfg-strcat-over-objects-then-exit-on-it.js: Added.
(foo):
(bar):
(x):
- js/dom/script-tests/dfg-strict-mode-arguments-get-beyond-length.js: Added.
(foo):
(bar):
- js/dom/script-tests/dfg-typed-array-neuter.js: Added.
(foo):
(bar):
- js/dom/script-tests/document-all-triggers-masquerades-watchpoint.js: Added.
(f):
- js/dom/script-tests/dot-node-base-exception.js: Added.
- js/dom/script-tests/end-in-string-escape.js: Added.
- js/dom/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js: Added.
- js/dom/script-tests/eval-cache-scoped-lookup.js: Added.
(first):
(a.string_appeared_here.second):
(third):
(fifth):
(sixth):
(seventh):
(eighth):
(nineth):
(tenth):
(eleventh):
- js/dom/script-tests/eval-contained-syntax-error.js: Added.
- js/dom/script-tests/exception-line-number.js: Added.
(foo):
(window.onerror):
- js/dom/script-tests/exception-registerfile-shrink.js: Added.
- js/dom/script-tests/exception-sequencing-binops.js: Copied from LayoutTests/js/exception-sequencing-binops.js.
- js/dom/script-tests/function-bind.js: Added.
(F):
- js/dom/script-tests/function-name.js: Added.
- js/dom/script-tests/function-names.js: Added.
(checkConstructorName):
- js/dom/script-tests/get-by-pname-only-prototype-properties.js: Added.
(foo):
- js/dom/script-tests/global-constructors-attributes.js: Added.
(.self.postMessage):
(.self.onconnect.self.postMessage):
(.self.onconnect):
(classNameForObject):
(constructorPropertiesOnGlobalObject):
- js/dom/script-tests/global-constructors-deletable.js: Added.
- js/dom/script-tests/global-function-resolve.js: Added.
- js/dom/script-tests/immediate-constant-instead-of-cell.js: Added.
- js/dom/script-tests/implicit-call-with-global-reentry.js: Added.
(testGlobalCode):
(testObject.get getterTest):
(testObject.set setterTest):
(testObject.toString):
(testObject.valueOf):
(testObject.toStringTest):
(testObject.valueOfTest):
- js/dom/script-tests/imul.js: Added.
(testIMul):
- js/dom/script-tests/inc-bracket-assign-subscript.js: Added.
(testPreIncBracketAccessWithAssignSubscript):
(testPostIncBracketAccessWithAssignSubscript):
- js/dom/script-tests/inc-const-valueOf.js: Added.
(testPostIncConstVarWithIgnoredResult.const.a.valueOf):
(testPostIncConstVarWithIgnoredResult):
(testPreIncConstVarWithIgnoredResult.const.a.valueOf):
(testPreIncConstVarWithIgnoredResult):
(testPreIncConstVarWithAssign.const.a.valueOf):
(testPreIncConstVarWithAssign):
- js/dom/script-tests/indexed-setter-on-global-object.js: Added.
- js/dom/script-tests/inline-arguments-tear-off.js: Added.
(g):
(f):
(doStuff):
- js/dom/script-tests/instanceof-XMLHttpRequest.js: Added.
- js/dom/script-tests/jit-set-profiling-access-type-only-for-get-by-id-self.js: Added.
(L_):
(Q2):
(f):
- js/dom/script-tests/js-correct-exception-handler.js: Added.
(throwEventually):
(f.g):
(f):
(test):
- js/dom/script-tests/lastModified.js: Added.
- js/dom/script-tests/lazy-create-arguments-from-get-by-val.js: Added.
(foo):
- js/dom/script-tests/line-column-numbers.js: Added.
(try.doThrow4b):
(doThrow5b.try.innerFunc):
(doThrow5b):
(doThrow6b.try.innerFunc):
(doThrow6b):
(catch):
(try.doThrow11b):
(try.doThrow14b):
(try.testObj19b.toString):
(try.testObj19b.run):
(try.test20b.f):
(try.test20b):
(try.toFuzz21b):
(try.toFuzz22b):
- js/dom/script-tests/method-check.js: Added.
(func2):
(func.String.prototype.a):
(func.String.prototype.b):
(func):
(addOne):
(addOneHundred):
(totalizer.makeCall):
- js/dom/script-tests/native-error-prototype.js: Added.
- js/dom/script-tests/neq-null-crash.js: Added.
(crush):
- js/dom/script-tests/nested-object-gc.js: Added.
- js/dom/script-tests/non-object-proto.js: Added.
- js/dom/script-tests/normal-character-escapes-in-string-literals.js: Added.
(test):
(testOther):
- js/dom/script-tests/null-char-in-string.js: Added.
- js/dom/script-tests/number-tofixed.js: Added.
- js/dom/script-tests/number-toprecision.js: Added.
- js/dom/script-tests/object-extra-comma.js: Added.
- js/dom/script-tests/object-prototype-constructor.js: Added.
(Foo.Bar):
(F):
- js/dom/script-tests/object-prototype-properties.js: Added.
- js/dom/script-tests/object-prototype-toLocaleString.js: Added.
(o.toLocaleString):
(String.prototype.toString):
- js/dom/script-tests/post-inc-assign-overwrites.js: Added.
(postIncDotAssignToBase):
(postIncBracketAssignToBase):
(postIncBracketAssignToSubscript):
- js/dom/script-tests/post-message-numeric-property.js: Added.
(window.onmessage):
- js/dom/script-tests/postfix-syntax.js: Added.
- js/dom/script-tests/prefix-syntax.js: Added.
- js/dom/script-tests/prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Added.
(f):
- js/dom/script-tests/put-direct-index-beyond-vector-length-resize.js: Added.
- js/dom/script-tests/put-to-base-global-checked.js: Added.
(globalF):
(warmup):
(foo):
- js/dom/script-tests/random-array-gc-stress.js: Added.
(getRandomIndex):
(test):
- js/dom/script-tests/recursion-limit-equal.js: Added.
(test):
- js/dom/script-tests/regexp-bol-with-multiline.js: Added.
- js/dom/script-tests/regexp-bol.js: Added.
- js/dom/script-tests/regexp-extended-characters-crash.js: Added.
- js/dom/script-tests/regexp-lastindex.js: Added.
- js/dom/script-tests/regexp-look-ahead-empty.js: Added.
- js/dom/script-tests/regexp-look-ahead.js: Added.
- js/dom/script-tests/regexp-match-reify-before-putbyval.js: Added.
- js/dom/script-tests/regexp-non-capturing-groups.js: Added.
- js/dom/script-tests/regexp-non-greedy-parentheses.js: Added.
- js/dom/script-tests/regexp-overflow.js: Added.
- js/dom/script-tests/regexp-range-out-of-order.js: Added.
- js/dom/script-tests/regexp-ranges-and-escaped-hyphens.js: Added.
- js/dom/script-tests/regexp-stack-overflow.js: Added.
- js/dom/script-tests/regexp-unicode-handling.js: Added.
(Gn):
- js/dom/script-tests/regexp-unicode-overflow.js: Added.
(createRegExs):
- js/dom/script-tests/removing-Cf-characters.js: Added.
- js/dom/script-tests/reserved-words-as-property.js: Added.
(testWordEvalAndFunction):
(testWord):
(testWordStrictAndNonStrict):
- js/dom/script-tests/select-options-add.js: Added.
- js/dom/script-tests/stack-at-creation-for-error-objects.js: Added.
(checkStack):
- js/dom/script-tests/stack-trace.js: Added.
(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
(selfRecursive1):
(selfRecursive2):
(selfRecursive3):
(throwError):
(object.get getter1.o.valueOf):
(object.get getter1):
(object.get getter2):
(object.get getter3.o2.valueOf):
(object.get getter3):
(object.nonInlineable.callCount):
(object.nonInlineable):
(object.inlineable):
(yetAnotherInlinedCall):
(makeInlinableCall):
(.try.g):
(h):
(mapTest):
(mapTestDriver):
(dfgFunction):
(try.f):
(callNonCallable):
(dfgTest):
(inlineableThrow):
(dfgThing.get willThrow):
(dfgThing.get willThrowEventually):
(dfgThing.willThrowFunc):
(dfgThing.willThrowEventuallyFunc):
(dfg1):
(dfg2):
(dfg3):
(dfg4):
(dfg5):
(dfg6):
(dfg7):
(dfg8):
(dfg9):
(dfga):
(dfgb):
(dfgc):
- js/dom/script-tests/strict-readonly-statics.js: Added.
(testWindowUndefined):
(testNumberMAX_VALUE):
- js/dom/script-tests/string-match.js: Added.
(testMatch):
- js/dom/script-tests/string-prototype-properties.js: Added.
(Number.prototype.toString):
- js/dom/script-tests/string-replace-2.js: Added.
(testReplace):
(replacer):
- js/dom/script-tests/string-replace-3.js: Added.
- js/dom/script-tests/string-replacement-outofmemory.js: Added.
(createStringWithRepeatedChar):
- js/dom/script-tests/string-split-conformance.js: Added.
- js/dom/script-tests/string-split-double-empty.js: Added.
- js/dom/script-tests/string-split-ignore-case.js: Added.
- js/dom/script-tests/switch-behaviour.js: Added.
(characterSwitch):
(sparseCharacterSwitch):
- js/dom/script-tests/throw-exception-in-global-setter.js: Added.
(callSetter):
- js/dom/script-tests/toInt32UInt32.js: Added.
- js/dom/script-tests/toString-exception.js: Added.
- js/dom/script-tests/toString-overrides.js: Added.
(Number.prototype.toString):
(Number.prototype.toLocaleString):
(RegExp.prototype.toString):
(RegExp.prototype.toLocaleString):
- js/dom/script-tests/toString-stack-overflow.js: Added.
- js/dom/script-tests/transition-cache-dictionary-crash.js: Added.
(f):
- js/dom/script-tests/typed-array-access.js: Added.
(bitsToString):
(bitsToValue):
(valueToBits):
(roundTrip):
- js/dom/script-tests/typed-array-set-different-types.js: Added.
(MyRandom):
(.reference):
(.usingConstruct):
- js/dom/script-tests/typeof-syntax.js: Added.
- js/dom/script-tests/unshift-multi.js: Added.
(unshift1):
(unshift2):
(unshift5):
- js/dom/script-tests/vardecl-preserve-arguments.js: Added.
(argumentsLength):
(argumentsLengthInnerBlock):
(argumentsLengthInnerBlock2):
(argumentsLengthTryCatch):
(argumentsLengthWith):
(argumentsLengthOverride):
(argumentsLengthOverrideInnerBlock):
(argumentsLengthOverrideInnerBlock2):
(argumentsLengthOverrideInnerBlock3):
(argumentsTearOff1):
(argumentsTearOff2):
(argumentsTearOff3):
- js/dom/script-tests/webcore-string-comparison.js: Added.
- js/dom/script-tests/with-scope-gc.js: Added.
(gc):
- js/dom/select-options-add-expected.txt: Added.
- js/dom/select-options-add.html: Added.
- js/dom/select-options-remove-expected.txt: Added.
- js/dom/select-options-remove-gc-expected.txt: Added.
- js/dom/select-options-remove-gc.html: Added.
- js/dom/select-options-remove.html: Added.
- js/dom/stack-at-creation-for-error-objects-expected.txt: Added.
- js/dom/stack-at-creation-for-error-objects.html: Added.
- js/dom/stack-trace-expected.txt: Added.
- js/dom/stack-trace.html: Added.
- js/dom/strict-readonly-statics-expected.txt: Added.
- js/dom/strict-readonly-statics.html: Added.
- js/dom/string-anchor-expected.txt: Added.
- js/dom/string-anchor.html: Added.
- js/dom/string-concatenate-outofmemory-expected.txt: Added.
- js/dom/string-fontcolor-expected.txt: Added.
- js/dom/string-fontcolor.html: Added.
- js/dom/string-fontsize-expected.txt: Added.
- js/dom/string-fontsize.html: Added.
- js/dom/string-link-expected.txt: Added.
- js/dom/string-link.html: Added.
- js/dom/string-match-expected.txt: Added.
- js/dom/string-match.html: Added.
- js/dom/string-prototype-properties-expected.txt: Added.
- js/dom/string-prototype-properties.html: Added.
- js/dom/string-replace-2-expected.txt: Added.
- js/dom/string-replace-2.html: Added.
- js/dom/string-replace-3-expected.txt: Added.
- js/dom/string-replace-3.html: Added.
- js/dom/string-replace-exception-crash-expected.txt: Added.
- js/dom/string-replace-exception-crash.html: Added.
- js/dom/string-replacement-outofmemory-expected.txt: Added.
- js/dom/string-replacement-outofmemory.html: Added.
- js/dom/string-split-conformance-expected.txt: Added.
- js/dom/string-split-conformance.html: Added.
- js/dom/string-split-double-empty-expected.txt: Added.
- js/dom/string-split-double-empty.html: Added.
- js/dom/string-split-ignore-case-expected.txt: Added.
- js/dom/string-split-ignore-case.html: Added.
- js/dom/switch-behaviour-expected.txt: Added.
- js/dom/switch-behaviour.html: Added.
- js/dom/text-field-resize-expected.txt: Added.
- js/dom/text-field-resize.html: Added.
- js/dom/throw-exception-in-global-setter-expected.txt: Added.
- js/dom/throw-exception-in-global-setter.html: Added.
- js/dom/throw-from-array-sort-expected.txt: Added.
- js/dom/throw-from-array-sort.html: Added.
- js/dom/toInt32UInt32-expected.txt: Added.
- js/dom/toInt32UInt32.html: Added.
- js/dom/toString-and-valueOf-override-expected.txt: Added.
- js/dom/toString-and-valueOf-override.html: Added.
- js/dom/toString-dontEnum-expected.txt: Added.
- js/dom/toString-dontEnum.html: Added.
- js/dom/toString-exception-expected.txt: Added.
- js/dom/toString-exception.html: Added.
- js/dom/toString-number-expected.txt: Added.
- js/dom/toString-number.html: Added.
- js/dom/toString-overrides-expected.txt: Added.
- js/dom/toString-overrides.html: Added.
- js/dom/toString-stack-overflow-expected.txt: Added.
- js/dom/toString-stack-overflow.html: Added.
- js/dom/toString-try-else-expected.txt: Added.
- js/dom/toString-try-else.html: Added.
- js/dom/transition-cache-dictionary-crash-expected.txt: Added.
- js/dom/transition-cache-dictionary-crash.html: Added.
- js/dom/trivial-functions-expected.txt: Added.
- js/dom/trivial-functions.html: Added.
- js/dom/try-catch-crash-expected.txt: Added.
- js/dom/try-catch-crash.html: Added.
- js/dom/typed-array-access-expected.txt: Added.
- js/dom/typed-array-access.html: Added.
- js/dom/typed-array-set-different-types-expected.txt: Added.
- js/dom/typed-array-set-different-types.html: Added.
- js/dom/typeof-syntax-expected.txt: Added.
- js/dom/typeof-syntax.html: Added.
- js/dom/uncaught-exception-line-number-expected.txt: Added.
- js/dom/uncaught-exception-line-number.html: Added.
- js/dom/unshift-multi-expected.txt: Added.
- js/dom/unshift-multi.html: Added.
- js/dom/var-declarations-expected.txt: Added.
- js/dom/var-declarations-shadowing-expected.txt: Added.
- js/dom/var-declarations-shadowing.html: Added.
- js/dom/var-declarations.html: Added.
- js/dom/vardecl-preserve-arguments-expected.txt: Added.
- js/dom/vardecl-preserve-arguments.html: Added.
- js/dom/vardecl-preserve-parameters-expected.txt: Added.
- js/dom/vardecl-preserve-parameters.html: Added.
- js/dom/vardecl-preserve-vardecl-expected.txt: Added.
- js/dom/vardecl-preserve-vardecl.html: Added.
- js/dom/webcore-string-comparison-expected.txt: Added.
- js/dom/webcore-string-comparison.html: Added.
- js/dom/webidl-type-mapping-expected.txt: Added.
- js/dom/webidl-type-mapping.html: Added.
- js/dom/while-expression-value-expected.txt: Added.
- js/dom/while-expression-value.html: Added.
- js/dom/window-location-href-file-urls-expected.txt: Added.
- js/dom/window-location-href-file-urls.html: Added.
- js/dom/with-scope-gc-expected.txt: Added.
- js/dom/with-scope-gc.html: Added.
- js/dot-node-base-exception-expected.txt: Removed.
- js/dot-node-base-exception.html: Removed.
- js/encode-URI-test-expected.txt: Removed.
- js/encode-URI-test.html: Removed.
- js/end-in-string-escape-expected.txt: Removed.
- js/end-in-string-escape.html: Removed.
- js/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt: Removed.
- js/enter-dictionary-indexing-mode-with-blank-indexing-type.html: Removed.
- js/error-object-write-and-detele-for-stack-property-expected.txt: Removed.
- js/error-object-write-and-detele-for-stack-property.html: Removed.
- js/eval-cache-scoped-lookup-expected.txt: Removed.
- js/eval-cache-scoped-lookup.html: Removed.
- js/eval-contained-syntax-error-expected.txt: Removed.
- js/eval-contained-syntax-error.html: Removed.
- js/eval-cross-window-expected.txt: Removed.
- js/eval-cross-window.html: Removed.
- js/eval-keyword-vs-function-expected.txt: Removed.
- js/eval-keyword-vs-function.html: Removed.
- js/eval-overriding-expected.txt: Removed.
- js/eval-overriding.html: Removed.
- js/exception-codegen-crash-expected.txt: Removed.
- js/exception-codegen-crash.html: Removed.
- js/exception-line-number-expected.txt: Removed.
- js/exception-line-number.html: Removed.
- js/exception-linenums-in-html-1-expected.txt: Removed.
- js/exception-linenums-in-html-1.html: Removed.
- js/exception-linenums-in-html-2-expected.txt: Removed.
- js/exception-linenums-in-html-2.html: Removed.
- js/exception-linenums-in-html-3-expected.txt: Removed.
- js/exception-linenums-in-html-3.html: Removed.
- js/exception-registerfile-shrink-expected.txt: Removed.
- js/exception-registerfile-shrink.html: Removed.
- js/exception-sequencing-binops-expected.txt: Removed.
- js/exception-sequencing-binops.html: Removed.
- js/exception-sequencing-binops.js: Removed.
- js/exception-sequencing-binops2-expected.txt: Removed.
- js/exception-sequencing-binops2.html: Removed.
- js/exception-sequencing-expected.txt: Removed.
- js/exception-sequencing.html: Removed.
- js/exception-thrown-from-equal-expected.txt: Removed.
- js/exception-thrown-from-equal.html: Removed.
- js/exception-thrown-from-eval-inside-closure-expected.txt: Removed.
- js/exception-thrown-from-eval-inside-closure.html: Removed.
- js/exception-thrown-from-function-with-lazy-activation-expected.txt: Removed.
- js/exception-thrown-from-function-with-lazy-activation.html: Removed.
- js/exception-thrown-from-new-expected.txt: Removed.
- js/exception-thrown-from-new.html: Removed.
- js/exceptions-thrown-in-callbacks-expected.txt: Removed.
- js/exceptions-thrown-in-callbacks.html: Removed.
- js/exec-state-marking-expected.txt: Removed.
- js/exec-state-marking.html: Removed.
- js/find-ignoring-case-regress-99753-expected.txt: Removed.
- js/find-ignoring-case-regress-99753.html: Removed.
- js/floating-point-truncate-rshift-expected.txt: Removed.
- js/floating-point-truncate-rshift.html: Removed.
- js/function-argument-evaluation-before-exception-expected.txt: Removed.
- js/function-argument-evaluation-before-exception.html: Removed.
- js/function-argument-evaluation-expected.txt: Removed.
- js/function-argument-evaluation.html: Removed.
- js/function-bind-expected.txt: Removed.
- js/function-bind.html: Removed.
- js/function-constructor-this-value-expected.txt: Removed.
- js/function-constructor-this-value.html: Removed.
- js/function-declarations-expected.txt: Removed.
- js/function-declarations.html: Removed.
- js/function-decompilation-operators-expected.txt: Removed.
- js/function-decompilation-operators.html: Removed.
- js/function-dot-arguments-and-caller-expected.txt: Removed.
- js/function-dot-arguments-and-caller.html: Removed.
- js/function-dot-arguments-identity-expected.txt: Removed.
- js/function-dot-arguments-identity.html: Removed.
- js/function-dot-arguments2-expected.txt: Removed.
- js/function-dot-arguments2.html: Removed.
- js/function-length-expected.txt: Removed.
- js/function-length.html: Removed.
- js/function-name-expected.txt: Removed.
- js/function-name-is-in-scope-expected.txt: Removed.
- js/function-name-is-in-scope.html: Removed.
- js/function-name.html: Removed.
- js/function-names-expected.txt: Removed.
- js/function-names.html: Removed.
- js/function-prototype-expected.txt: Removed.
- js/function-prototype.html: Removed.
- js/function-redefinition-expected.txt: Removed.
- js/function-redefinition.html: Removed.
- js/garbage-collect-after-string-appends-expected.txt: Removed.
- js/get-by-pname-only-prototype-properties-expected.txt: Removed.
- js/get-by-pname-only-prototype-properties.html: Removed.
- js/getOwnPropertyDescriptor-expected.txt: Removed.
- js/getOwnPropertyDescriptor.html: Removed.
- js/global-constructors-attributes-dedicated-worker-expected.txt: Removed.
- js/global-constructors-attributes-dedicated-worker.html: Removed.
- js/global-constructors-attributes-expected.txt: Removed.
- js/global-constructors-attributes-shared-worker-expected.txt: Removed.
- js/global-constructors-attributes-shared-worker.html: Removed.
- js/global-constructors-attributes.html: Removed.
- js/global-constructors-deletable-expected.txt: Removed.
- js/global-constructors-deletable.html: Removed.
- js/global-function-resolve-expected.txt: Removed.
- js/global-function-resolve.html: Removed.
- js/global-recursion-on-full-stack-expected.txt: Removed.
- js/global-recursion-on-full-stack.html: Removed.
- js/global-var-limit-expected.txt: Removed.
- js/global-var-limit.html: Removed.
- js/immediate-constant-instead-of-cell-expected.txt: Removed.
- js/immediate-constant-instead-of-cell.html: Removed.
- js/implicit-call-with-global-reentry-expected.txt: Removed.
- js/implicit-call-with-global-reentry.html: Removed.
- js/implicit-global-to-global-reentry-expected.txt: Removed.
- js/implicit-global-to-global-reentry.html: Removed.
- js/imul-expected.txt: Removed.
- js/imul.html: Removed.
- js/inc-bracket-assign-subscript-expected.txt: Removed.
- js/inc-bracket-assign-subscript.html: Removed.
- js/inc-const-valueOf-expected.txt: Removed.
- js/inc-const-valueOf.html: Removed.
- js/indexed-setter-on-global-object-expected.txt: Removed.
- js/indexed-setter-on-global-object.html: Removed.
- js/inline-arguments-tear-off-expected.txt: Removed.
- js/inline-arguments-tear-off.html: Removed.
- js/instanceof-XMLHttpRequest-expected.txt: Removed.
- js/instanceof-XMLHttpRequest.html: Removed.
- js/invalid-syntax-for-function-expected.txt: Removed.
- js/invalid-syntax-for-function.html: Removed.
- js/jit-set-profiling-access-type-only-for-get-by-id-self-expected.txt: Removed.
- js/jit-set-profiling-access-type-only-for-get-by-id-self.html: Removed.
- js/js-constructors-use-correct-global-expected.txt: Removed.
- js/js-constructors-use-correct-global.html: Removed.
- js/js-correct-exception-handler-expected.txt: Removed.
- js/js-correct-exception-handler.html: Removed.
- js/jsc-test-list: Removed.
- js/lastModified-expected.txt: Removed.
- js/lastModified.html: Removed.
- js/lazy-create-arguments-from-get-by-val-expected.txt: Removed.
- js/lazy-create-arguments-from-get-by-val.html: Removed.
- js/lexical-lookup-in-function-constructor-expected.txt: Removed.
- js/lexical-lookup-in-function-constructor.html: Removed.
- js/line-column-numbers-expected.txt: Removed.
- js/line-column-numbers.html: Removed.
- js/method-check-expected.txt: Removed.
- js/method-check.html: Removed.
- js/missing-style-end-tag-js-expected.txt: Removed.
- js/missing-style-end-tag-js.html: Removed.
- js/missing-title-end-tag-js-expected.txt: Removed.
- js/missing-title-end-tag-js.html: Removed.
- js/native-error-prototype-expected.txt: Removed.
- js/native-error-prototype.html: Removed.
- js/navigator-language-expected.txt: Removed.
- js/navigator-language.html: Removed.
- js/navigator-plugins-crash-expected.txt: Removed.
- js/navigator-plugins-crash.html: Removed.
- js/negate-overflow-expected.txt: Removed.
- js/negate-overflow.html: Removed.
- js/neq-null-crash-expected.txt: Removed.
- js/neq-null-crash.html: Removed.
- js/nested-function-scope-expected.txt: Removed.
- js/nested-function-scope.html: Removed.
- js/nested-object-gc-expected.txt: Removed.
- js/nested-object-gc.html: Removed.
- js/non-object-proto-expected.txt: Removed.
- js/non-object-proto.html: Removed.
- js/normal-character-escapes-in-string-literals-expected.txt: Removed.
- js/normal-character-escapes-in-string-literals.html: Removed.
- js/not-a-constructor-to-string-expected.txt: Removed.
- js/not-a-constructor-to-string.html: Removed.
- js/not-a-function-to-string-expected.txt: Removed.
- js/not-a-function-to-string.html: Removed.
- js/null-char-in-string-expected.txt: Removed.
- js/null-char-in-string.html: Removed.
- js/number-tofixed-expected.txt: Removed.
- js/number-tofixed.html: Removed.
- js/number-toprecision-expected.txt: Removed.
- js/number-toprecision.html: Removed.
- js/object-extra-comma-expected.txt: Removed.
- js/object-extra-comma.html: Removed.
- js/object-prototype-constructor-expected.txt: Removed.
- js/object-prototype-constructor.html: Removed.
- js/object-prototype-properties-expected.txt: Removed.
- js/object-prototype-properties.html: Removed.
- js/object-prototype-toLocaleString-expected.txt: Removed.
- js/object-prototype-toLocaleString.html: Removed.
- js/parse-error-external-script-in-eval-expected.txt: Removed.
- js/parse-error-external-script-in-eval.html: Removed.
- js/parse-error-external-script-in-new-Function-expected.txt: Removed.
- js/parse-error-external-script-in-new-Function.html: Removed.
- js/post-inc-assign-overwrites-expected.txt: Removed.
- js/post-inc-assign-overwrites.html: Removed.
- js/post-message-numeric-property-expected.txt: Removed.
- js/post-message-numeric-property.html: Removed.
- js/postfix-syntax-expected.txt: Removed.
- js/postfix-syntax.html: Removed.
- js/prefix-syntax-expected.txt: Removed.
- js/prefix-syntax.html: Removed.
- js/prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Removed.
- js/prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Removed.
- js/put-direct-index-beyond-vector-length-resize-expected.txt: Removed.
- js/put-direct-index-beyond-vector-length-resize.html: Removed.
- js/put-to-base-global-checked-expected.txt: Removed.
- js/put-to-base-global-checked.html: Removed.
- js/random-array-gc-stress-expected.txt: Removed.
- js/random-array-gc-stress.html: Removed.
- js/recursion-limit-equal-expected.txt: Removed.
- js/recursion-limit-equal.html: Removed.
- js/regexp-bol-expected.txt: Removed.
- js/regexp-bol-with-multiline-expected.txt: Removed.
- js/regexp-bol-with-multiline.html: Removed.
- js/regexp-bol.html: Removed.
- js/regexp-caching-expected.txt: Removed.
- js/regexp-caching.html: Removed.
- js/regexp-charclass-crash-expected.txt: Removed.
- js/regexp-charclass-crash.html: Removed.
- js/regexp-extended-characters-crash-expected.txt: Removed.
- js/regexp-extended-characters-crash.html: Removed.
- js/regexp-lastindex-expected.txt: Removed.
- js/regexp-lastindex.html: Removed.
- js/regexp-look-ahead-empty-expected.txt: Removed.
- js/regexp-look-ahead-empty.html: Removed.
- js/regexp-look-ahead-expected.txt: Removed.
- js/regexp-look-ahead.html: Removed.
- js/regexp-match-reify-before-putbyval-expected.txt: Removed.
- js/regexp-match-reify-before-putbyval.html: Removed.
- js/regexp-non-capturing-groups-expected.txt: Removed.
- js/regexp-non-capturing-groups.html: Removed.
- js/regexp-non-greedy-parentheses-expected.txt: Removed.
- js/regexp-non-greedy-parentheses.html: Removed.
- js/regexp-overflow-expected.txt: Removed.
- js/regexp-overflow.html: Removed.
- js/regexp-range-out-of-order-expected.txt: Removed.
- js/regexp-range-out-of-order.html: Removed.
- js/regexp-ranges-and-escaped-hyphens-expected.txt: Removed.
- js/regexp-ranges-and-escaped-hyphens.html: Removed.
- js/regexp-stack-overflow-expected.txt: Removed.
- js/regexp-stack-overflow.html: Removed.
- js/regexp-test-null-string-expected.txt: Removed.
- js/regexp-test-null-string.html: Removed.
- js/regexp-unicode-handling-expected.txt: Removed.
- js/regexp-unicode-handling.html: Removed.
- js/regexp-unicode-overflow-expected.txt: Removed.
- js/regexp-unicode-overflow.html: Removed.
- js/removing-Cf-characters-expected.txt: Removed.
- js/removing-Cf-characters.html: Removed.
- js/reserved-words-as-property-expected.txt: Removed.
- js/reserved-words-as-property.html: Removed.
- js/same-origin-subframe-about-blank-expected.txt: Removed.
- js/same-origin-subframe-about-blank.html: Removed.
- js/script-line-number-expected.txt: Removed.
- js/script-line-number.html: Removed.
- js/script-tests/Object-defineProperty.js: Removed.
- js/script-tests/activation-proto.js: Removed.
- js/script-tests/array-float-delete.js: Removed.
- js/script-tests/array-join-bug-11524.js: Removed.
- js/script-tests/array-prototype-properties.js: Removed.
- js/script-tests/array-sort-exception.js: Removed.
- js/script-tests/array-tostring-ignore-separator.js: Removed.
- js/script-tests/array-with-double-assign.js: Removed.
- js/script-tests/array-with-double-push.js: Removed.
- js/script-tests/assign.js: Removed.
- js/script-tests/basic-map.js: Removed.
- js/script-tests/basic-set.js: Removed.
- js/script-tests/basic-weakmap.js: Removed.
- js/script-tests/cached-eval-gc.js: Removed.
- js/script-tests/constructor-attributes.js: Removed.
- js/script-tests/constructor.js: Removed.
- js/script-tests/cross-frame-bad-time.js: Removed.
- js/script-tests/cross-frame-really-bad-time-with-proto.js: Removed.
- js/script-tests/cross-frame-really-bad-time.js: Removed.
- js/script-tests/cross-global-object-inline-global-var.js: Removed.
- js/script-tests/custom-constructors.js: Removed.
- js/script-tests/cyclic-proto.js: Removed.
- js/script-tests/cyclic-ref-toString.js: Removed.
- js/script-tests/date-DST-time-cusps.js: Removed.
- js/script-tests/date-big-constructor.js: Removed.
- js/script-tests/date-big-setdate.js: Removed.
- js/script-tests/date-big-setmonth.js: Removed.
- js/script-tests/date-negative-setmonth.js: Removed.
- js/script-tests/date-preserve-milliseconds.js: Removed.
- js/script-tests/delete-syntax.js: Removed.
- js/script-tests/dfg-byte-array-put.js: Removed.
- js/script-tests/dfg-byteOffset-neuter.js: Removed.
- js/script-tests/dfg-compare-final-object-to-final-object-or-other.js: Removed.
- js/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js: Removed.
- js/script-tests/dfg-cross-global-object-inline-new-array-literal.js: Removed.
- js/script-tests/dfg-cross-global-object-inline-new-array-with-elements.js: Removed.
- js/script-tests/dfg-cross-global-object-inline-new-array-with-size.js: Removed.
- js/script-tests/dfg-cross-global-object-inline-new-array.js: Removed.
- js/script-tests/dfg-cross-global-object-new-array.js: Removed.
- js/script-tests/dfg-custom-getter-throw-inlined.js: Removed.
- js/script-tests/dfg-custom-getter-throw.js: Removed.
- js/script-tests/dfg-custom-getter.js: Removed.
- js/script-tests/dfg-ensure-array-storage-on-window.js: Removed.
- js/script-tests/dfg-ensure-non-array-array-storage-on-window.js: Removed.
- js/script-tests/dfg-inline-switch-imm.js: Removed.
- js/script-tests/dfg-int32-to-double-on-set-local-and-exit.js: Removed.
- js/script-tests/dfg-int32-to-double-on-set-local-and-sometimes-exit.js: Removed.
- js/script-tests/dfg-logical-not-final-object-or-other.js: Removed.
- js/script-tests/dfg-make-rope-side-effects.js: Removed.
- js/script-tests/dfg-negative-array-size.js: Removed.
- js/script-tests/dfg-patchable-get-by-id-after-watchpoint.js: Removed.
- js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.js: Removed.
- js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object.js: Removed.
- js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other.js: Removed.
- js/script-tests/dfg-proto-stub-watchpoint-fire.js: Removed.
- js/script-tests/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Removed.
- js/script-tests/dfg-put-by-id-allocate-storage-polymorphic.js: Removed.
- js/script-tests/dfg-put-by-id-allocate-storage.js: Removed.
- js/script-tests/dfg-put-by-id-reallocate-storage-polymorphic.js: Removed.
- js/script-tests/dfg-put-by-id-reallocate-storage.js: Removed.
- js/script-tests/dfg-put-by-val-setter-then-get-by-val.js: Removed.
- js/script-tests/dfg-put-to-readonly-property.js: Removed.
- js/script-tests/dfg-rshift-by-zero-eliminate-valuetoint32.js: Removed.
- js/script-tests/dfg-store-unexpected-value-into-argument-and-osr-exit.js: Removed.
- js/script-tests/dfg-strcat-over-objects-then-exit-on-it.js: Removed.
- js/script-tests/dfg-strict-mode-arguments-get-beyond-length.js: Removed.
- js/script-tests/dfg-typed-array-neuter.js: Removed.
- js/script-tests/document-all-triggers-masquerades-watchpoint.js: Removed.
- js/script-tests/dot-node-base-exception.js: Removed.
- js/script-tests/end-in-string-escape.js: Removed.
- js/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js: Removed.
- js/script-tests/eval-cache-scoped-lookup.js: Removed.
- js/script-tests/eval-contained-syntax-error.js: Removed.
- js/script-tests/exception-line-number.js: Removed.
- js/script-tests/exception-registerfile-shrink.js: Removed.
- js/script-tests/function-bind.js: Removed.
- js/script-tests/function-name.js: Removed.
- js/script-tests/function-names.js: Removed.
- js/script-tests/get-by-pname-only-prototype-properties.js: Removed.
- js/script-tests/global-constructors-attributes.js: Removed.
- js/script-tests/global-constructors-deletable.js: Removed.
- js/script-tests/global-function-resolve.js: Removed.
- js/script-tests/immediate-constant-instead-of-cell.js: Removed.
- js/script-tests/implicit-call-with-global-reentry.js: Removed.
- js/script-tests/imul.js: Removed.
- js/script-tests/inc-bracket-assign-subscript.js: Removed.
- js/script-tests/inc-const-valueOf.js: Removed.
- js/script-tests/indexed-setter-on-global-object.js: Removed.
- js/script-tests/inline-arguments-tear-off.js: Removed.
- js/script-tests/instanceof-XMLHttpRequest.js: Removed.
- js/script-tests/jit-set-profiling-access-type-only-for-get-by-id-self.js: Removed.
- js/script-tests/js-correct-exception-handler.js: Removed.
- js/script-tests/lastModified.js: Removed.
- js/script-tests/lazy-create-arguments-from-get-by-val.js: Removed.
- js/script-tests/line-column-numbers.js: Removed.
- js/script-tests/method-check.js: Removed.
- js/script-tests/native-error-prototype.js: Removed.
- js/script-tests/neq-null-crash.js: Removed.
- js/script-tests/nested-object-gc.js: Removed.
- js/script-tests/non-object-proto.js: Removed.
- js/script-tests/normal-character-escapes-in-string-literals.js: Removed.
- js/script-tests/null-char-in-string.js: Removed.
- js/script-tests/number-tofixed.js: Removed.
- js/script-tests/number-toprecision.js: Removed.
- js/script-tests/object-extra-comma.js: Removed.
- js/script-tests/object-prototype-constructor.js: Removed.
- js/script-tests/object-prototype-properties.js: Removed.
- js/script-tests/object-prototype-toLocaleString.js: Removed.
- js/script-tests/post-inc-assign-overwrites.js: Removed.
- js/script-tests/post-message-numeric-property.js: Removed.
- js/script-tests/postfix-syntax.js: Removed.
- js/script-tests/prefix-syntax.js: Removed.
- js/script-tests/prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Removed.
- js/script-tests/put-direct-index-beyond-vector-length-resize.js: Removed.
- js/script-tests/put-to-base-global-checked.js: Removed.
- js/script-tests/random-array-gc-stress.js: Removed.
- js/script-tests/recursion-limit-equal.js: Removed.
- js/script-tests/regexp-bol-with-multiline.js: Removed.
- js/script-tests/regexp-bol.js: Removed.
- js/script-tests/regexp-extended-characters-crash.js: Removed.
- js/script-tests/regexp-lastindex.js: Removed.
- js/script-tests/regexp-look-ahead-empty.js: Removed.
- js/script-tests/regexp-look-ahead.js: Removed.
- js/script-tests/regexp-match-reify-before-putbyval.js: Removed.
- js/script-tests/regexp-non-capturing-groups.js: Removed.
- js/script-tests/regexp-non-greedy-parentheses.js: Removed.
- js/script-tests/regexp-overflow.js: Removed.
- js/script-tests/regexp-range-out-of-order.js: Removed.
- js/script-tests/regexp-ranges-and-escaped-hyphens.js: Removed.
- js/script-tests/regexp-stack-overflow.js: Removed.
- js/script-tests/regexp-unicode-handling.js: Removed.
- js/script-tests/regexp-unicode-overflow.js: Removed.
- js/script-tests/removing-Cf-characters.js: Removed.
- js/script-tests/reserved-words-as-property.js: Removed.
- js/script-tests/select-options-add.js: Removed.
- js/script-tests/stack-at-creation-for-error-objects.js: Removed.
- js/script-tests/stack-trace.js: Removed.
- js/script-tests/strict-readonly-statics.js: Removed.
- js/script-tests/string-match.js: Removed.
- js/script-tests/string-prototype-properties.js: Removed.
- js/script-tests/string-replace-2.js: Removed.
- js/script-tests/string-replace-3.js: Removed.
- js/script-tests/string-replacement-outofmemory.js: Removed.
- js/script-tests/string-split-conformance.js: Removed.
- js/script-tests/string-split-double-empty.js: Removed.
- js/script-tests/string-split-ignore-case.js: Removed.
- js/script-tests/switch-behaviour.js: Removed.
- js/script-tests/throw-exception-in-global-setter.js: Removed.
- js/script-tests/toInt32UInt32.js: Removed.
- js/script-tests/toString-exception.js: Removed.
- js/script-tests/toString-overrides.js: Removed.
- js/script-tests/toString-stack-overflow.js: Removed.
- js/script-tests/transition-cache-dictionary-crash.js: Removed.
- js/script-tests/typed-array-access.js: Removed.
- js/script-tests/typed-array-set-different-types.js: Removed.
- js/script-tests/typeof-syntax.js: Removed.
- js/script-tests/unshift-multi.js: Removed.
- js/script-tests/vardecl-preserve-arguments.js: Removed.
- js/script-tests/webcore-string-comparison.js: Removed.
- js/script-tests/with-scope-gc.js: Removed.
- js/select-options-add-expected.txt: Removed.
- js/select-options-add.html: Removed.
- js/select-options-remove-expected.txt: Removed.
- js/select-options-remove-gc-expected.txt: Removed.
- js/select-options-remove-gc.html: Removed.
- js/select-options-remove.html: Removed.
- js/stack-at-creation-for-error-objects-expected.txt: Removed.
- js/stack-at-creation-for-error-objects.html: Removed.
- js/stack-trace-expected.txt: Removed.
- js/stack-trace.html: Removed.
- js/strict-readonly-statics-expected.txt: Removed.
- js/strict-readonly-statics.html: Removed.
- js/string-anchor-expected.txt: Removed.
- js/string-anchor.html: Removed.
- js/string-concatenate-outofmemory-expected.txt: Removed.
- js/string-fontcolor-expected.txt: Removed.
- js/string-fontcolor.html: Removed.
- js/string-fontsize-expected.txt: Removed.
- js/string-fontsize.html: Removed.
- js/string-link-expected.txt: Removed.
- js/string-link.html: Removed.
- js/string-match-expected.txt: Removed.
- js/string-match.html: Removed.
- js/string-prototype-properties-expected.txt: Removed.
- js/string-prototype-properties.html: Removed.
- js/string-replace-2-expected.txt: Removed.
- js/string-replace-2.html: Removed.
- js/string-replace-3-expected.txt: Removed.
- js/string-replace-3.html: Removed.
- js/string-replace-exception-crash-expected.txt: Removed.
- js/string-replace-exception-crash.html: Removed.
- js/string-replacement-outofmemory-expected.txt: Removed.
- js/string-replacement-outofmemory.html: Removed.
- js/string-split-conformance-expected.txt: Removed.
- js/string-split-conformance.html: Removed.
- js/string-split-double-empty-expected.txt: Removed.
- js/string-split-double-empty.html: Removed.
- js/string-split-ignore-case-expected.txt: Removed.
- js/string-split-ignore-case.html: Removed.
- js/switch-behaviour-expected.txt: Removed.
- js/switch-behaviour.html: Removed.
- js/text-field-resize-expected.txt: Removed.
- js/text-field-resize.html: Removed.
- js/throw-exception-in-global-setter-expected.txt: Removed.
- js/throw-exception-in-global-setter.html: Removed.
- js/throw-from-array-sort-expected.txt: Removed.
- js/throw-from-array-sort.html: Removed.
- js/toInt32UInt32-expected.txt: Removed.
- js/toInt32UInt32.html: Removed.
- js/toString-and-valueOf-override-expected.txt: Removed.
- js/toString-and-valueOf-override.html: Removed.
- js/toString-dontEnum-expected.txt: Removed.
- js/toString-dontEnum.html: Removed.
- js/toString-exception-expected.txt: Removed.
- js/toString-exception.html: Removed.
- js/toString-number-expected.txt: Removed.
- js/toString-number.html: Removed.
- js/toString-overrides-expected.txt: Removed.
- js/toString-overrides.html: Removed.
- js/toString-stack-overflow-expected.txt: Removed.
- js/toString-stack-overflow.html: Removed.
- js/toString-try-else-expected.txt: Removed.
- js/toString-try-else.html: Removed.
- js/transition-cache-dictionary-crash-expected.txt: Removed.
- js/transition-cache-dictionary-crash.html: Removed.
- js/trivial-functions-expected.txt: Removed.
- js/trivial-functions.html: Removed.
- js/try-catch-crash-expected.txt: Removed.
- js/try-catch-crash.html: Removed.
- js/typed-array-access-expected.txt: Removed.
- js/typed-array-access.html: Removed.
- js/typed-array-set-different-types-expected.txt: Removed.
- js/typed-array-set-different-types.html: Removed.
- js/typeof-syntax-expected.txt: Removed.
- js/typeof-syntax.html: Removed.
- js/uncaught-exception-line-number-expected.txt: Removed.
- js/uncaught-exception-line-number.html: Removed.
- js/unshift-multi-expected.txt: Removed.
- js/unshift-multi.html: Removed.
- js/var-declarations-expected.txt: Removed.
- js/var-declarations-shadowing-expected.txt: Removed.
- js/var-declarations-shadowing.html: Removed.
- js/var-declarations.html: Removed.
- js/vardecl-preserve-arguments-expected.txt: Removed.
- js/vardecl-preserve-arguments.html: Removed.
- js/vardecl-preserve-parameters-expected.txt: Removed.
- js/vardecl-preserve-parameters.html: Removed.
- js/vardecl-preserve-vardecl-expected.txt: Removed.
- js/vardecl-preserve-vardecl.html: Removed.
- js/webcore-string-comparison-expected.txt: Removed.
- js/webcore-string-comparison.html: Removed.
- js/webidl-type-mapping-expected.txt: Removed.
- js/webidl-type-mapping.html: Removed.
- js/while-expression-value-expected.txt: Removed.
- js/while-expression-value.html: Removed.
- js/window-location-href-file-urls-expected.txt: Removed.
- js/window-location-href-file-urls.html: Removed.
- js/with-scope-gc-expected.txt: Removed.
- js/with-scope-gc.html: Removed.
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/mac/js/constructor-length-expected.txt: Removed.
- platform/mac/js/dom: Added.
- platform/mac/js/dom/constructor-length-expected.txt: Copied from LayoutTests/platform/mac/js/constructor-length-expected.txt.
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 3:17 PM Changeset in webkit [156065] by
-
- 2 edits in trunk/Tools
Unreviewed, fix for Ruby 1.8.
- Scripts/run-jsc-stress-tests:
- 3:09 PM Changeset in webkit [156064] by
-
- 3 edits in trunk/Source/JavaScriptCore
Give 'jsc' commandline an option to disable deleting the VM.
Reviewed by Mark Hahnenberg.
- jsc.cpp:
(jscmain):
- runtime/Options.h:
- 2:45 PM Changeset in webkit [156063] by
-
- 12 edits in trunk/Source
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121568
Reviewed by Andreas Kling.
../WebKit/win:
- WebHistory.cpp:
(WebHistory::removeAllItems):
(WebHistory::orderedLastVisitedDays):
(WebHistory::addItemToDateCaches):
(WebHistory::removeItemFromDateCaches):
- WebHistory.h:
- WebPreferences.cpp:
(WebPreferences::copyWebKitPreferencesToCFPreferences):
../WebKit2:
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):
(CoreIPC::readBytesFromSocket):
(CoreIPC::Connection::sendOutgoingMessage):
- UIProcess/API/efl/EwkView.cpp:
(EwkView::feedTouchEvent):
(EwkView::feedTouchEvents):
- UIProcess/API/efl/SnapshotImageGL.h:
- UIProcess/API/efl/ewk_file_chooser_request.cpp:
(ewk_file_chooser_request_files_choose):
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::createArgsArray):
(WebKit::ProcessLauncher::launchProcess):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyContextMenuItems):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- 2:38 PM Changeset in webkit [156062] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests should make it easier to look at error spew from tests
https://bugs.webkit.org/show_bug.cgi?id=121531
Reviewed by Mark Hahnenberg.
This makes two changes:
- The out/err spew from each test is now saved to a .out file in jsc-stress-results.
- The same spew also goes to the console but is prefixed by the test's name.
This required some tee and awk hacks, and then some sh hacks to work around the fact
that if you do "(foo | bar) baz", and foo fails, then baz won't run - the operator will only see a failure of bar failed. So to pass output to tee and awk, I
needed to do weird things.
- Scripts/run-jsc-stress-tests:
- 2:12 PM Changeset in webkit [156061] by
-
- 7 edits in trunk/LayoutTests
Fix svg/masking/* tests
https://bugs.webkit.org/show_bug.cgi?id=121570
Reviewed by Rob Buis.
Merge https://chromium.googlesource.com/chromium/blink/+/975b3219677968706cbddb9295ceada05c092dd6
"rx" is not a valid <circle> attribute - these tests were not drawing anything.
Also switching to rects to avoid reftest antialiasing issues.
For non-alpha variants, using a 50% luminance to capture the effect on the output color.
- svg/masking/mask-type-alpha-expected.svg:
- svg/masking/mask-type-alpha.svg:
- svg/masking/mask-type-luminance-expected.svg:
- svg/masking/mask-type-luminance.svg:
- svg/masking/mask-type-not-set-expected.svg:
- svg/masking/mask-type-not-set.svg:
- 2:08 PM Changeset in webkit [156060] by
-
- 2 edits in trunk/WebKitLibraries
[Windows] Unreviewed build fix: Expose PlatformArchitecture macro to build system.
- win/tools/vsprops/common.props:
- 1:45 PM Changeset in webkit [156059] by
-
- 3 edits in trunk/Source/WTF
[Windows] Unreviewed build correction.
- WTF.vcxproj/WTFGeneratedCommon.props: Export PLATFORMARCHITECTURE macro for use in
Makefiles and shell scripts.
- WTF.vcxproj/build-generated-files.sh: Output header search path to identify when the build
is confused about build architecture.
- 1:33 PM Changeset in webkit [156058] by
-
- 5 edits in trunk
[MSE] Throw exception when setting timestampOffset while 'updating' state is set.
https://bugs.webkit.org/show_bug.cgi?id=121561
Reviewed by Eric Carlson.
Source/WebCore:
Tests: Updated http/tests/media/media-source/mediasource-append-buffer.html.
Merge https://chromium.googlesource.com/chromium/blink/+/25285998be3d0edcd951d12d445a7375e50e512c
by Changbin Shao.
The Media Source Extensions spec requires that an exception be thrown if the 'updating' attribute
equals true while setting the timestampOffset of a SourceBuffer.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::setTimestampOffset):
LayoutTests:
- http/tests/media/media-source/mediasource-append-buffer-expected.txt:
- http/tests/media/media-source/mediasource-append-buffer.html:
- 1:31 PM Changeset in webkit [156057] by
-
- 2 edits in trunk/Tools
REGRESSION (r129451): run-safari --no-saved-state is broken
https://bugs.webkit.org/show_bug.cgi?id=121566
Reviewed by Mark Rowe.
- Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
Check arguments, not the newly created empty array. Pass a value that silences warnings.
While at it, removed a check for Snow Leopard.
- 12:51 PM Changeset in webkit [156056] by
-
- 12 edits in trunk/Source
RefPtrHashMap should work with move only types
https://bugs.webkit.org/show_bug.cgi?id=121564
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- runtime/VM.cpp:
(JSC::VM::addSourceProviderCache):
Source/WebCore:
- bridge/IdentifierRep.cpp:
(WebCore::IdentifierRep::get):
- page/PageGroup.cpp:
(WebCore::PageGroup::transientLocalStorage):
Source/WebKit/mac:
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::methodNamed):
(WebKit::ProxyInstance::fieldNamed):
Source/WebKit2:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::LocalStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
Source/WTF:
Add the same rvalue references and std::forward calls that already exist in HashMap.
- wtf/RefPtrHashMap.h:
- 12:13 PM Changeset in webkit [156055] by
-
- 3 edits in trunk/Source/WebCore
Upstream changes to WebHTMLConverter to support HTML
to NSAttributedString conversion on both iOS and OS X.
Reviewed by Benjamin Poulain.
This is a new submission of r156001 with the fix for the
failing TestWebKitAPI test. The additional change has been
reviewed by Tim Horton.
- platform/mac/HTMLConverter.h:
- platform/mac/HTMLConverter.mm:
(WebDefaultFont):
(_fontForNameAndSize):
(+[WebHTMLConverter defaultParagraphStyle]):
(-[WebHTMLConverter _computedStyleForElement:]):
(-[WebHTMLConverter _specifiedStyleForElement:]):
(-[WebHTMLConverter _computedStringForNode:property:]):
(-[WebHTMLConverter _stringForNode:property:]):
(-[WebHTMLConverter _getComputedFloat:forNode:property:]):
(-[WebHTMLConverter _getFloat:forNode:property:]):
(_NSFirstPathForDirectoriesInDomains):
(_NSSystemLibraryPath):
(-[WebHTMLConverter _webKitBundle]):
(_colorForRGBColor):
(_shadowForShadowStyle):
(-[WebHTMLConverter _elementIsBlockLevel:]):
(-[WebHTMLConverter _elementHasOwnBackgroundColor:]):
(-[WebHTMLConverter _computedColorForNode:property:]):
(-[WebHTMLConverter _colorForNode:property:]):
(-[WebHTMLConverter _computedAttributesForElement:]):
(-[WebHTMLConverter _attributesForElement:]):
(-[WebHTMLConverter _newParagraphForElement:tag:allowEmpty:suppressTrailingSpace:]):
(-[WebHTMLConverter _newLineForElement:]):
(-[WebHTMLConverter _newTabForElement:]):
(-[WebHTMLConverter _WebMessageDocumentClass]):
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(-[WebHTMLConverter _addQuoteForElement:opening:level:]):
(-[WebHTMLConverter _addValue:forElement:]):
(-[WebHTMLConverter _fillInBlock:forElement:backgroundColor:extraMargin:extraPadding:isTable:]):
(_dateForString):
(_colCompare):
(-[WebHTMLConverter _processMetaElementWithName:content:]):
(-[WebHTMLConverter _processHeadElement:]):
(-[WebHTMLConverter _enterElement:tag:display:embedded:]):
(-[WebHTMLConverter _addTableForElement:]):
(-[WebHTMLConverter _addTableCellForElement:]):
(-[WebHTMLConverter _processElement:tag:display:depth:]):
(-[WebHTMLConverter _addMarkersToList:range:]):
(-[WebHTMLConverter _exitElement:tag:display:depth:startIndex:]):
(-[WebHTMLConverter _processText:]):
(-[WebHTMLConverter _traverseNode:depth:embedded:]):
(-[WebHTMLConverter _traverseFooterNode:depth:]):
(-[WebHTMLConverter _loadFromDOMRange]):
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
(-[WebHTMLConverter initWithDOMRange:]):
(-[WebHTMLConverter attributedString]):
(+[WebHTMLConverter editingAttributedStringFromRange:]):
- 11:04 AM Changeset in webkit [156054] by
-
- 18 edits2 moves in trunk/Source/WebCore
Rename RenderBR to RenderLineBreak
https://bugs.webkit.org/show_bug.cgi?id=121560
Reviewed by Sam Weinig.
It now represents both hard (br) and soft (wbr) line breaks.
- 10:58 AM Changeset in webkit [156053] by
-
- 3 edits2 adds in trunk
Quirksmode: Break Tag Extra Space Bug
https://bugs.webkit.org/show_bug.cgi?id=11943
Reviewed by David Hyatt.
Source/WebCore:
Collapse away all space between text and a hard line-break when in a right-aligned
container so that the trailing space doesn't push the text away from the container edge.
Test: fast/text/whitespace/trailing-space-before-br-in-right-aligned-text.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/text/whitespace/trailing-space-before-br-in-right-aligned-text-expected.html: Added.
- fast/text/whitespace/trailing-space-before-br-in-right-aligned-text.html: Added.
- 10:45 AM Changeset in webkit [156052] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for Qt (and other) ports after 156049.
Wrap implementation of PublicURLManager in ENABLE(BLOB) check.
- html/PublicURLManager.cpp:
- 10:32 AM Changeset in webkit [156051] by
-
- 3 edits in trunk/Source/WebKit/win
Make WebHistory more type safe
https://bugs.webkit.org/show_bug.cgi?id=119389
Reviewed by Brent Fulgham.
Use a WTF::HashMap instead of a CFMutableDictionary to avoid
casting from void* all the time when accessing the entries.
This reduces the dependencies on CoreFoundation too.
- WebHistory.cpp:
(WebHistory::WebHistory):
(WebHistory::removeAllItems):
(WebHistory::allItems):
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):
(WebHistory::itemForURL):
(WebHistory::removeItemForURLString):
(WebHistory::itemForURLString):
(WebHistory::addVisitedLinksToPageGroup):
- WebHistory.h:
- 10:27 AM Changeset in webkit [156050] by
-
- 11 edits1 add in trunk/Source/JavaScriptCore
Rename OperationInProgress to HeapOperation and move it out of Heap.h into its own header
https://bugs.webkit.org/show_bug.cgi?id=121534
Reviewed by Geoffrey Garen.
OperationInProgress is a silly name.
Many parts of the Heap would like to know what HeapOperation is currently underway, but
since they are included in Heap.h they can't directly reference HeapOperation if it also
lives in Heap.h. The simplest thing to do is to give HeapOperation its own header. While
a bit overkill, it simplifies including it wherever its needed.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllPredictions):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllPredictions):
- bytecode/LazyOperandValueProfile.cpp:
(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
- bytecode/LazyOperandValueProfile.h:
- bytecode/ValueProfile.h:
(JSC::ValueProfileBase::computeUpdatedPrediction):
- heap/Heap.h:
- heap/HeapOperation.h: Added.
- 10:25 AM Changeset in webkit [156049] by
-
- 43 edits20 copies69 adds in trunk
Merge blink MediaSource changes since fork.
https://bugs.webkit.org/show_bug.cgi?id=118752
Rubber-stamped by Eric Carlson.
Source/WebCore:
Tests: http/tests/media/media-source/mediasource-addsourcebuffer.html
http/tests/media/media-source/mediasource-append-buffer.html
http/tests/media/media-source/mediasource-buffered.html
http/tests/media/media-source/mediasource-closed.html
http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate.html
http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate.html
http/tests/media/media-source/mediasource-config-change-mp4-av-framesize.html
http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate.html
http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate.html
http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html
http/tests/media/media-source/mediasource-config-change-mp4-v-framesize.html
http/tests/media/media-source/mediasource-config-change-webm-a-bitrate.html
http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate.html
http/tests/media/media-source/mediasource-config-change-webm-av-framesize.html
http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate.html
http/tests/media/media-source/mediasource-config-change-webm-v-bitrate.html
http/tests/media/media-source/mediasource-config-change-webm-v-framerate.html
http/tests/media/media-source/mediasource-config-change-webm-v-framesize.html
http/tests/media/media-source/mediasource-is-type-supported.html
http/tests/media/media-source/mediasource-multiple-attach.html
http/tests/media/media-source/mediasource-play.html
http/tests/media/media-source/mediasource-sourcebufferlist.html
Add files to project. Fix compile errors exposed by enabling.
- WebCore.xcodeproj/project.pbxproj:
- Modules/mediasource/MediaSourceRegistry.cpp:
(WebCore::MediaSourceRegistry::lookupMediaSource):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::load):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(WebCore::MediaPlayerPrivateQTKit::load):
- platform/mac/MIMETypeRegistryMac.mm:
(WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType):
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
Merge
https://chromium.googlesource.com/chromium/blink/+/c38e2955db98a300a535b692869fea0e41501497
https://chromium.googlesource.com/chromium/blink/+/8568015e9bee1de7fccee28163f9e4a4b51f9baf
https://chromium.googlesource.com/chromium/blink/+/14417e8fa6294f4e7dbc1e0fac549398522b2f97
https://chromium.googlesource.com/chromium/blink/+/f43a5496f233102f8861a067a9cf8053c010d401
https://chromium.googlesource.com/chromium/blink/+/57771439806f7c6e6a272efb1ea72900f5f6a015
https://chromium.googlesource.com/chromium/blink/+/8c77a790a9d225194db0a8832399d0f9e1fa54ec
https://chromium.googlesource.com/chromium/blink/+/d33ae3fa7a8592e946503ed17f862a27c6d9dde1
https://chromium.googlesource.com/chromium/blink/+/1caaa9c51f06e1b9341d58c994f77fd59fcd236d
https://chromium.googlesource.com/chromium/blink/+/e95720393b0ebe67f19de39bb77cdf2926165512
https://chromium.googlesource.com/chromium/blink/+/bad2c1b4b70faec731b2ad3cc8a4ccf28de6cc38
https://chromium.googlesource.com/chromium/blink/+/a7873430c3d5c9373336c6f3993db3cb4228e9cd
https://chromium.googlesource.com/chromium/blink/+/508966d5e32360b3cec058f9fbae0014542fbc52
https://chromium.googlesource.com/chromium/blink/+/371dfe72f61ce6f73e6c242324da73c415d38be3
LayoutTests:
- http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt: Added.
- http/tests/media/media-source/mediasource-addsourcebuffer.html: Added.
- http/tests/media/media-source/mediasource-append-buffer-expected.txt: Added.
- http/tests/media/media-source/mediasource-append-buffer.html: Added.
- http/tests/media/media-source/mediasource-buffered-expected.txt: Added.
- http/tests/media/media-source/mediasource-buffered.html: Added.
- http/tests/media/media-source/mediasource-closed-expected.txt: Added.
- http/tests/media/media-source/mediasource-closed.html: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate.html: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate.html: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-av-framesize-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-av-framesize.html: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate.html: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate.html: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-v-framerate-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-v-framesize-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-mp4-v-framesize.html: Added.
- http/tests/media/media-source/mediasource-config-change-webm-a-bitrate-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-webm-a-bitrate.html: Added.
- http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate.html: Added.
- http/tests/media/media-source/mediasource-config-change-webm-av-framesize-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-webm-av-framesize.html: Added.
- http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate.html: Added.
- http/tests/media/media-source/mediasource-config-change-webm-v-bitrate-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-webm-v-bitrate.html: Added.
- http/tests/media/media-source/mediasource-config-change-webm-v-framerate-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-webm-v-framerate.html: Added.
- http/tests/media/media-source/mediasource-config-change-webm-v-framesize-expected.txt: Added.
- http/tests/media/media-source/mediasource-config-change-webm-v-framesize.html: Added.
- http/tests/media/media-source/mediasource-config-changes.js: Added.
- http/tests/media/media-source/mediasource-is-type-supported-expected.txt: Added.
- http/tests/media/media-source/mediasource-is-type-supported.html: Added.
- http/tests/media/media-source/mediasource-multiple-attach-expected.txt: Added.
- http/tests/media/media-source/mediasource-multiple-attach.html: Added.
- http/tests/media/media-source/mediasource-play-expected.txt: Added.
- http/tests/media/media-source/mediasource-play.html: Added.
- http/tests/media/media-source/mediasource-sourcebufferlist-expected.txt: Added.
- http/tests/media/media-source/mediasource-sourcebufferlist.html: Added.
- http/tests/media/media-source/mediasource-util.js: Added.
- http/tests/media/media-source/video-media-source-objects-expected.txt:
- http/tests/media/resources/media-source/generate-config-change-tests.py: Added.
- http/tests/media/resources/media-source/mp4/test-a-128k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/resources/media-source/mp4/test-a-192k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/resources/media-source/mp4/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/mp4/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/mp4/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/mp4/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/mp4/test-v-128k-320x240-24fps-8kfr-manifest.json: Added.
- http/tests/media/resources/media-source/mp4/test-v-128k-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/mp4/test-v-128k-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/mp4/test-v-256k-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/webm/test-a-128k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/resources/media-source/webm/test-a-192k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/resources/media-source/webm/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/webm/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/webm/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/webm/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/webm/test-v-128k-320x240-24fps-8kfr-manifest.json: Added.
- http/tests/media/resources/media-source/webm/test-v-128k-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/webm/test-v-128k-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/resources/media-source/webm/test-v-256k-320x240-30fps-10kfr-manifest.json: Added.
- 10:21 AM Changeset in webkit [156048] by
-
- 2 edits in trunk/Tools
Improved WinLauncher's URL handling.
https://bugs.webkit.org/show_bug.cgi?id=121535
Patch by Alex Christensen <achristensen@webkit.org> on 2013-09-18
Reviewed by Brent Fulgham.
- WinLauncher/WinLauncher.cpp:
(EditProc):
Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
(loadURL):
Prepend "http://" to URLs with no scheme.
- 10:14 AM Changeset in webkit [156047] by
-
- 75 edits12 adds in trunk
DFG should support Int52 for local variables
https://bugs.webkit.org/show_bug.cgi?id=121064
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This adds Int52 support for local variables to the DFG and FTL. It's a speed-up on
programs that have local int32 overflows but where a larger int representation can
prevent us from having to convert all the way up to double.
It's a small speed-up for now. But we're just supporting Int52 for a handful of
operations (add, sub, mul, neg, compare, bitops, typed array access) and this lays
the groundwork for adding Int52 to JSValue, which will probably be a bigger
speed-up.
The basic approach is:
- We have a notion of Int52 in our typesystem. Int52 doesn't belong to BytecodeTop or HeapTop - i.e. it doesn't arise from JSValues.
- DFG treats Int52 as being part of its FullTop and will treat it as being a subtype of double unless instructed otherwise.
- Prediction propagator creates Int52s whenever we have a node going doubly but due to large values rather than fractional values, and that node is known to be able to produce Int52 natively in the DFG backend.
- Fixup phase converts edges to MachineIntUses in nodes that are known to be able to deal with Int52, and where we have a subtype of Int32|Int52 as the predicted input.
- The DFG backend and FTL LLVM IR lowering have two notions of Int52s - ones that are left-shifted by 16 (great for overflow checks) and ones that are sign-extended. Both backends know how to convert between Int52s and the other representations.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::rshift64):
(JSC::MacroAssemblerX86_64::mul64):
(JSC::MacroAssemblerX86_64::branchMul64):
(JSC::MacroAssemblerX86_64::branchNeg64):
(JSC::MacroAssemblerX86_64::convertInt64ToDouble):
- assembler/X86Assembler.h:
(JSC::X86Assembler::imulq_rr):
(JSC::X86Assembler::cvtsi2sdq_rr):
- bytecode/DataFormat.h:
(JSC::dataFormatToString):
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
- bytecode/ExitKind.h:
- bytecode/OperandsInlines.h:
(JSC::::dumpInContext):
- bytecode/SpeculatedType.cpp:
(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromValue):
- bytecode/SpeculatedType.h:
(JSC::isInt32SpeculationForArithmetic):
(JSC::isInt52Speculation):
(JSC::isMachineIntSpeculationForArithmetic):
(JSC::isInt52AsDoubleSpeculation):
(JSC::isBytecodeRealNumberSpeculation):
(JSC::isFullRealNumberSpeculation):
(JSC::isBytecodeNumberSpeculation):
(JSC::isFullNumberSpeculation):
(JSC::isBytecodeNumberSpeculationExpectingDefined):
(JSC::isFullNumberSpeculationExpectingDefined):
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedInt52):
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::isAlreadyInJSStack):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dumpInContext):
- dfg/DFGAbstractInterpreter.h:
(JSC::DFG::AbstractInterpreter::needsTypeCheck):
(JSC::DFG::AbstractInterpreter::filterByType):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::checkConsistency):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::couldBeType):
(JSC::DFG::AbstractValue::isType):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::validateType):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::boxInt52):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGCommon.h:
(JSC::DFG::enableInt52):
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::fixupBlock):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixupUntypedSetLocalsInBlock):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):
- dfg/DFGFlushFormat.cpp:
(WTF::printInternal):
- dfg/DFGFlushFormat.h:
(JSC::DFG::resultFor):
(JSC::DFG::useKindFor):
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::initInt52):
(JSC::DFG::GenerationInfo::initStrictInt52):
(JSC::DFG::GenerationInfo::isFormat):
(JSC::DFG::GenerationInfo::isInt52):
(JSC::DFG::GenerationInfo::isStrictInt52):
(JSC::DFG::GenerationInfo::fillInt52):
(JSC::DFG::GenerationInfo::fillStrictInt52):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::addShouldSpeculateMachineInt):
(JSC::DFG::Graph::mulShouldSpeculateMachineInt):
(JSC::DFG::Graph::negateShouldSpeculateMachineInt):
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
- dfg/DFGMinifiedNode.h:
(JSC::DFG::belongsInMinifiedGraph):
(JSC::DFG::MinifiedNode::hasChild):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldSpeculateNumberExpectingDefined):
(JSC::DFG::Node::canSpeculateInt52):
- dfg/DFGNodeFlags.h:
(JSC::DFG::nodeCanSpeculateInt52):
- dfg/DFGNodeType.h:
(JSC::DFG::permitsOSRBackwardRewiring):
(JSC::DFG::forwardRewiringSelectionScore):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSREntry.h:
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPrediction):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):
- dfg/DFGSilentRegisterSavePlan.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateMachineInt):
(JSC::DFG::SpeculativeJIT::speculateNumber):
(JSC::DFG::SpeculativeJIT::speculateRealNumber):
(JSC::DFG::SpeculativeJIT::speculate):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::int52Result):
(JSC::DFG::SpeculativeJIT::strictInt52Result):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::betterUseStrictInt52):
(JSC::DFG::SpeculativeJIT::generationInfo):
(JSC::DFG::SpeculateInt52Operand::SpeculateInt52Operand):
(JSC::DFG::SpeculateInt52Operand::~SpeculateInt52Operand):
(JSC::DFG::SpeculateInt52Operand::edge):
(JSC::DFG::SpeculateInt52Operand::node):
(JSC::DFG::SpeculateInt52Operand::gpr):
(JSC::DFG::SpeculateInt52Operand::use):
(JSC::DFG::SpeculateStrictInt52Operand::SpeculateStrictInt52Operand):
(JSC::DFG::SpeculateStrictInt52Operand::~SpeculateStrictInt52Operand):
(JSC::DFG::SpeculateStrictInt52Operand::edge):
(JSC::DFG::SpeculateStrictInt52Operand::node):
(JSC::DFG::SpeculateStrictInt52Operand::gpr):
(JSC::DFG::SpeculateStrictInt52Operand::use):
(JSC::DFG::SpeculateWhicheverInt52Operand::SpeculateWhicheverInt52Operand):
(JSC::DFG::SpeculateWhicheverInt52Operand::~SpeculateWhicheverInt52Operand):
(JSC::DFG::SpeculateWhicheverInt52Operand::edge):
(JSC::DFG::SpeculateWhicheverInt52Operand::node):
(JSC::DFG::SpeculateWhicheverInt52Operand::gpr):
(JSC::DFG::SpeculateWhicheverInt52Operand::use):
(JSC::DFG::SpeculateWhicheverInt52Operand::format):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::boxInt52):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileInt52Compare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleInt52Branch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGUseKind.cpp:
(WTF::printInternal):
- dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):
- dfg/DFGValueSource.cpp:
(JSC::DFG::ValueSource::dump):
- dfg/DFGValueSource.h:
(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::ValueSource::forFlushFormat):
(JSC::DFG::ValueSource::valueRecovery):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::flushFormat):
- ftl/FTLCArgumentGetter.cpp:
(JSC::FTL::CArgumentGetter::loadNextAndBox):
- ftl/FTLCArgumentGetter.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLExitValue.cpp:
(JSC::FTL::ExitValue::dumpInContext):
- ftl/FTLExitValue.h:
(JSC::FTL::ExitValue::inJSStackAsInt52):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowInt52):
(JSC::FTL::LowerDFGToLLVM::lowStrictInt52):
(JSC::FTL::LowerDFGToLLVM::betterUseStrictInt52):
(JSC::FTL::LowerDFGToLLVM::bestInt52Kind):
(JSC::FTL::LowerDFGToLLVM::opposite):
(JSC::FTL::LowerDFGToLLVM::lowWhicheverInt52):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToInt32):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToDouble):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToJSValue):
(JSC::FTL::LowerDFGToLLVM::setInt52WithStrictValue):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToInt52):
(JSC::FTL::LowerDFGToLLVM::int52ToStrictInt52):
(JSC::FTL::LowerDFGToLLVM::speculateRealNumber):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::setInt52):
(JSC::FTL::LowerDFGToLLVM::setStrictInt52):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLOutput.h:
(JSC::FTL::Output::addWithOverflow64):
(JSC::FTL::Output::subWithOverflow64):
(JSC::FTL::Output::mulWithOverflow64):
- ftl/FTLValueFormat.cpp:
(WTF::printInternal):
- ftl/FTLValueFormat.h:
- ftl/FTLValueSource.cpp:
(JSC::FTL::ValueSource::dump):
- ftl/FTLValueSource.h:
- interpreter/Register.h:
(JSC::Register::unboxedInt52):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOffForInlineCallFrame):
- runtime/IndexingType.cpp:
(JSC::leastUpperBoundOfIndexingTypeAndType):
- runtime/JSCJSValue.h:
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::isMachineInt):
(JSC::JSValue::asMachineInt):
Source/WTF:
Reviewed by Oliver Hunt.
- wtf/PrintStream.h:
(WTF::ValueIgnoringContext::ValueIgnoringContext):
(WTF::ValueIgnoringContext::dump):
(WTF::ignoringContext):
Tools:
Reviewed by Oliver Hunt.
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Oliver Hunt.
- js/dfg-int-overflow-large-constants-in-a-line-expected.txt:
- js/regress/large-int-captured-expected.txt: Added.
- js/regress/large-int-captured.html: Added.
- js/regress/large-int-expected.txt: Added.
- js/regress/large-int-neg-expected.txt: Added.
- js/regress/large-int-neg.html: Added.
- js/regress/large-int.html: Added.
- js/regress/marsaglia-larger-ints-expected.txt: Added.
- js/regress/marsaglia-larger-ints.html: Added.
- js/regress/script-tests/large-int-captured.js: Added.
(.bar):
(foo):
- js/regress/script-tests/large-int-neg.js: Added.
(foo):
- js/regress/script-tests/large-int.js: Added.
(foo):
- js/regress/script-tests/marsaglia-larger-ints.js: Added.
(uint):
(marsaglia):
- js/script-tests/dfg-int-overflow-large-constants-in-a-line.js:
- 9:51 AM Changeset in webkit [156046] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r155771): js/stack-overflow-arrity-catch.html is crashing on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=121376
Reviewed by Oliver Hunt.
Fix stack grow() call for stack growing down. This should catch running out of stack space before
we try to move the frame down due to arity mismatch.
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
- 9:33 AM Changeset in webkit [156045] by
-
- 4 edits in trunk
[Win] TestWebKitAPI does not compile.
https://bugs.webkit.org/show_bug.cgi?id=121485
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-18
Reviewed by Brent Fulgham.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export needed symbols.
Tools:
It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
to return null, which is the case we want to test.
- TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
(TestWebKitAPI::TEST):
- 9:27 AM Changeset in webkit [156044] by
-
- 2 edits in trunk/LayoutTests
Missed one rebaseline for the RenderMenuList change.
- platform/mac/fast/forms/select-empty-option-height-expected.txt:
- 8:55 AM Changeset in webkit [156043] by
-
- 4 edits in trunk/Source/JavaScriptCore
YARR: Put UCS2 canonicalization tables in read-only memory.
<https://webkit.org/b/121547>
Reviewed by Sam Weinig.
These tables never mutate so mark them const.
- 8:54 AM Changeset in webkit [156042] by
-
- 2 edits in trunk/Source/WTF
Put constant CachedPower table in read-only memory.
<https://webkit.org/b/121546>
Reviewed by Anders Carlsson.
- wtf/dtoa/cached-powers.cc:
- 8:48 AM Changeset in webkit [156041] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderBR always has an HTMLElement.
<https://webkit.org/b/121557>
Reviewed by Antti Koivisto.
This renderer is never anonymous and always has a corresponding HTMLElement.
Tighten this up by making the constructor take a HTMLElement& and remove
RenderBR::createAnonymous().
- 8:35 AM Changeset in webkit [156040] by
-
- 12 edits in trunk
Avoid using RenderBR internally in RenderMenuList.
<https://webkit.org/b/121550>
Reviewed by Antti Koivisto.
Source/WebCore:
RenderMenuLists with an empty caption text were previously using a
RenderBR as placeholder.
Switch to using a \n RenderText instead so we can tighten RenderBR.
This will change DRT dumps but actual metrics should not change.
LayoutTests:
Update expected results for RenderMenuLists with empty text.
They now have a RenderText inside them instead of a RenderBR.
- 7:41 AM Changeset in webkit [156039] by
-
- 2 edits in trunk/Source/WebCore
Change one accidental "object->isText() object->isLineBreak()" from previous patch back to "object->isTextOrLineBreak()"
Not reviewed.
- rendering/InlineIterator.h:
(WebCore::isIteratorTarget):
- 7:33 AM Changeset in webkit [156038] by
-
- 28 edits2 deletes in trunk/Source/WebCore
Remove RenderWordBreak
https://bugs.webkit.org/show_bug.cgi?id=121549
Reviewed by Andreas Kling.
Remove RenderWordBreak and make it a bit in RenderBR instead.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
- dom/Position.cpp:
(WebCore::hasInlineBoxWrapper):
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- editing/Editor.cpp:
(WebCore::findFirstMarkable):
- editing/TextIterator.cpp:
(WebCore::ignoresContainerClip):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::createRenderer):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
(WebCore::InlineBox::deleteLine):
(WebCore::InlineBox::extractLine):
(WebCore::InlineBox::attachLine):
(WebCore::InlineBox::nodeAtPoint):
- rendering/InlineBox.h:
(WebCore::InlineBox::isLineBreak):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::computeOverflow):
- rendering/InlineIterator.h:
(WebCore::InlineIterator::atTextParagraphSeparator):
(WebCore::isIteratorTarget):
- rendering/RenderBR.cpp:
(WebCore::RenderBR::RenderBR):
- rendering/RenderBR.h:
(WebCore::toRenderBR):
RenderBR now represents both hard and soft line breaks. It will be renamed to RenderLineBreak later.
- rendering/RenderBlock.cpp:
(WebCore::InlineMinMaxIterator::next):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::createInlineBoxForRenderer):
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::textBeginsWithBreakablePosition):
(WebCore::canBreakAtThisPosition):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
(WebCore::RenderInline::dirtyLineBoxes):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- rendering/RenderObject.h:
(WebCore::RenderObject::isLineBreak):
This bit covers both BR and WBR.
(WebCore::RenderObject::isBR):
(WebCore::RenderObject::isLineBreakOpportunity):
Rename isWordBreak to isLineBreakOpportunity. This matches HTML5 spec terminology.
(WebCore::RenderObject::isTextOrLineBreak):
Since WBR used to be Text we want this check to still cover it too. Renamed from isTextOrBR.
(WebCore::RenderObject::setIsLineBreak):
(WebCore::RenderObject::isWBR):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
- rendering/RenderText.cpp:
- rendering/RenderText.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
- rendering/RenderWordBreak.cpp: Removed.
- rendering/RenderWordBreak.h: Removed.
- rendering/RenderingAllInOne.cpp:
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):
(WebCore::RootInlineBox::includeLeadingForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::includeMarginForBox):
- 6:48 AM Changeset in webkit [156037] by
-
- 3 edits5 adds in trunk
ASSERT_NOT_REACHED is touched in WebCore::CSSPrimitiveValue::computeLengthDouble
https://bugs.webkit.org/show_bug.cgi?id=120469
Source/WebCore:
Tests: fast/css/outline-offset-parsing-assert.html
fast/css/outline-offset-parsing.html
Reviewed by Dirk Schulze.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Fixed a typo after r66615, outline-offset can't be percentage.
LayoutTests:
Reviewed by Dirk Schulze.
- fast/css/outline-offset-parsing-assert-expected.txt: Added.
- fast/css/outline-offset-parsing-assert.html: Added.
- fast/css/outline-offset-parsing-expected.txt: Added.
- fast/css/outline-offset-parsing.html: Added.
- fast/css/script-tests/outline-offset-parsing.js: Added.
(test):
- 5:39 AM Changeset in webkit [156036] by
-
- 4 edits12 adds in trunk
[MathML] Implement the subscriptshift and superscriptshift attributes
https://bugs.webkit.org/show_bug.cgi?id=120069
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-18
Reviewed by Darin Adler.
Source/WebCore:
Added support for subscriptshift and superscriptshift attributes. The
subscriptshift attribute is for msup element and superscriptshift for
msup. msubsup can have both subscriptshift and superscriptshift. The
subscriptshift attribute specifies the minimum amount to shift the
baseline of subscript down. The superscriptshift attribute specifies
the minimum amount to shift the baseline of superscript up.
Tests: mathml/presentation/msub-subscriptshift.html
mathml/presentation/msubsup-subscriptshift.html
mathml/presentation/msubsup-superscriptshift.html
mathml/presentation/msup-superscriptshift.html
mathml/presentation/multiscript-subscriptshift.html
mathml/presentation/multiscript-superscriptshift.html
- mathml/mathattrs.in:
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::layout):
For aligning the subscript and superscript padding is added to the base.
So subscriptshift and superscriptshift attributes is set as padding bottom
and padding top of base respectively.
LayoutTests:
- mathml/presentation/msub-subscriptshift-expected.txt: Added.
- mathml/presentation/msub-subscriptshift.html: Added.
- mathml/presentation/msubsup-subscriptshift-expected.txt: Added.
- mathml/presentation/msubsup-subscriptshift.html: Added.
- mathml/presentation/msubsup-superscriptshift-expected.txt: Added.
- mathml/presentation/msubsup-superscriptshift.html: Added.
- mathml/presentation/msup-superscriptshift-expected.txt: Added.
- mathml/presentation/msup-superscriptshift.html: Added.
- mathml/presentation/multiscript-subscriptshift-expected.txt: Added.
- mathml/presentation/multiscript-subscriptshift.html: Added.
- mathml/presentation/multiscript-superscriptshift-expected.txt: Added.
- mathml/presentation/multiscript-superscriptshift.html: Added.
Added new tests for verifying that subscriptshift and superscriptshift are
being applied properly to the script base.
- 5:07 AM QtWebKitBuildBots edited by
- (diff)
- 3:12 AM Changeset in webkit [156035] by
-
- 1 copy in releases/WebKitGTK/webkit-2.1.92
Tagging the WebKitGTK+ 2.1.91 release
- 2:34 AM Changeset in webkit [156034] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2
Unreviewed. Update NEWS and Versions.m4 for 2.1.92 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Add release notes.
- 1:28 AM Changeset in webkit [156033] by
-
- 29 edits in trunk
[ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
https://bugs.webkit.org/show_bug.cgi?id=121495
Reviewed by Chris Fleizach.
Source/WebCore:
Removed the 'aria-' prefix from the exposed ATK object attributes
for WAI-ARIA attributes 'aria-haspopup' and 'aria-sort'.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Removed the prefix.
Tools:
Adapted DRT and WKTR to deal with the new names for the ATK object
attributes being exposed for 'aria-haspopup' and 'aria-sort'.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
(AccessibilityUIElement::stringAttributeValue): Ditto.
(AccessibilityUIElement::hasPopup): Ditto.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
(WTR::AccessibilityUIElement::hasPopup): Ditto.
LayoutTests:
Rebaseline test expectations that were displaying the 'aria-sort'
attributes incorrectly, when they shouldn't due to that ARIA
attribute not being explicitly used in the HTML.
- platform/efl-wk1/accessibility/lists-expected.txt: Removed output for 'aria-sort'.
- platform/efl-wk1/accessibility/plugin-expected.txt: Ditto.
- platform/efl-wk1/accessibility/table-with-aria-role-expected.txt: Ditto.
- platform/efl-wk1/accessibility/transformed-element-expected.txt: Ditto.
- platform/efl-wk2/accessibility/image-link-expected.txt: Ditto.
- platform/efl-wk2/accessibility/image-map2-expected.txt: Ditto.
- platform/efl-wk2/accessibility/lists-expected.txt: Ditto.
- platform/efl-wk2/accessibility/plugin-expected.txt: Ditto.
- platform/efl-wk2/accessibility/table-cell-spans-expected.txt: Ditto.
- platform/efl-wk2/accessibility/table-cells-expected.txt: Ditto.
- platform/efl-wk2/accessibility/table-with-aria-role-expected.txt: Ditto.
- platform/efl-wk2/accessibility/transformed-element-expected.txt: Ditto.
- platform/gtk/accessibility/image-link-expected.txt: Ditto.
- platform/gtk/accessibility/image-map2-expected.txt: Ditto.
- platform/gtk/accessibility/lists-expected.txt: Ditto.
- platform/gtk/accessibility/plugin-expected.txt: Ditto.
- platform/gtk/accessibility/table-cell-spans-expected.txt: Ditto.
- platform/gtk/accessibility/table-cells-expected.txt: Ditto.
- platform/gtk/accessibility/table-detection-expected.txt: Ditto.
- platform/gtk/accessibility/table-one-cell-expected.txt: Ditto.
- platform/gtk/accessibility/table-with-aria-role-expected.txt: Ditto.
- platform/gtk/accessibility/table-with-rules-expected.txt: Ditto.
- platform/gtk/accessibility/transformed-element-expected.txt: Ditto.
- 12:55 AM Changeset in webkit [156032] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r156028 - [GTK] WebKitScriptWorld not in API documentation
https://bugs.webkit.org/show_bug.cgi?id=121539
Reviewed by Philippe Normand.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add WebKitScriptWorld.
- 12:52 AM Changeset in webkit [156031] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebInspectorUI
Merge r156027 - [GTK] Cannot find WebInspectorUI/UserInterface/Main.html referenced in GResourceBundle.xml
https://bugs.webkit.org/show_bug.cgi?id=121405
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-09-17
Reviewed by Carlos Garcia Campos.
- GNUmakefile.am: if srcdir == builddir the WebInspectorUI variable that is used both to list
the dependencies of the GResourceBundle and to normalize the paths added to the XML through sed
replacement will end up starting with ./, which would be fine if automake did not remove that
from the paths in the target's dependency. We deal with that by normalizing the path we use to
take that quirk into account.
- 12:38 AM Changeset in webkit [156030] by
-
- 30 edits1 add in releases/WebKitGTK/webkit-2.2
Merge r155714 - [GTK] Move to the new web inspector
https://bugs.webkit.org/show_bug.cgi?id=120647
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-09-13
Reviewed by Carlos Garcia Campos.
.:
- GNUmakefile.am: include the new WebInspectorUI GNUmakefile.am.
Source/WebCore:
No tests for the new inspector UI as of yet.
- GNUmakefile.am: no longer install the deprecated inspector UI files.
- WebCore.exp.in: add SchemeRegistry symbol that is now used.
Source/WebInspectorUI:
- GNUmakefile.am: Added. Generate the GResource source and link it into libWebCore.
Source/WebKit/gtk:
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::openInspectorFrontend): update paths to the internal resource ones.
(WebKit::InspectorClient::inspectorFilesPath): ditto.
- tests/testwebinspector.c:
(consoleMessageCallback): the new inspector currently emits an error when loading, so add it to
the list of messages which are not considered failures.
- webkit/webkitglobals.cpp:
(webkitInit): register resource as a local scheme; currently used by the inspector.
Source/WebKit2:
- GNUmakefile.am: bundle the remote inspector page list HTML into libwebkit2gtk as a GResource.
- UIProcess/API/gtk/tests/GNUmakefile.am: no need to set WEBKIT_INSPECTOR_PATH anymore.
- UIProcess/API/gtk/tests/InspectorTestServer.cpp:
(main): ditto.
- UIProcess/API/gtk/tests/TestInspector.cpp:
(beforeAll): ditto.
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(testInspectorServerPageList): update paths to the internal resource ones.
- UIProcess/InspectorServer/WebInspectorServer.h:
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath): ditto.
(WebKit::WebInspectorServer::buildPageList): ditto.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::isMainInspectorPage): factor out checking for the inspector main resource, to make
the code more readable.
(WebKit::decidePolicyForNavigationAction): use SchemeRegistry to figure out whether the
request is for a local resource instead of KURL::isLocalFile() to allow using schemes
other than file:// for the inspector resources.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::inspectorPageURL): use the new internal resource URL; since it's now
static we no longer need to generate and store the string.
(WebKit::WebInspectorProxy::inspectorBaseURL): ditto.
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::localizedStringsURL): use the new internal resource URL.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess): register resource as a local scheme.
Tools:
- GtkLauncher/main.c:
(main): no longer set WEBKIT_INSPECTOR_PATH.
- MiniBrowser/gtk/main.c:
(main): ditto.
- Scripts/old-run-webkit-tests:
(openDumpTool): ditto.
- Scripts/run-gtk-tests: ditto.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server): ditto.
LayoutTests:
- platform/gtk/TestExpectations: the new inspector UI does not support the current
inspector testing harness so keep it skipped, a new one will eventually be landed.
- 12:37 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:25 AM Changeset in webkit [156029] by
-
- 69 edits12 deletes in trunk
Unreviewed, rolling out r156019 and r156020.
http://trac.webkit.org/changeset/156019
http://trac.webkit.org/changeset/156020
https://bugs.webkit.org/show_bug.cgi?id=121540
Broke tests (Requested by ap on #webkit).
Source/JavaScriptCore:
- assembler/MacroAssemblerX86_64.h:
- assembler/X86Assembler.h:
- bytecode/DataFormat.h:
(JSC::dataFormatToString):
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
- bytecode/ExitKind.h:
- bytecode/OperandsInlines.h:
(JSC::::dumpInContext):
- bytecode/SpeculatedType.cpp:
(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromValue):
- bytecode/SpeculatedType.h:
(JSC::isInt32SpeculationForArithmetic):
(JSC::isInt48Speculation):
(JSC::isMachineIntSpeculationForArithmetic):
(JSC::isInt48AsDoubleSpeculation):
(JSC::isRealNumberSpeculation):
(JSC::isNumberSpeculation):
(JSC::isNumberSpeculationExpectingDefined):
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::isAlreadyInJSStack):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dumpInContext):
- dfg/DFGAbstractInterpreter.h:
(JSC::DFG::AbstractInterpreter::needsTypeCheck):
(JSC::DFG::AbstractInterpreter::filterByType):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::checkConsistency):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::validateType):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::unboxDouble):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGCommon.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):
- dfg/DFGFlushFormat.cpp:
(WTF::printInternal):
- dfg/DFGFlushFormat.h:
(JSC::DFG::resultFor):
(JSC::DFG::useKindFor):
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::initInt32):
(JSC::DFG::GenerationInfo::fillInt32):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::addShouldSpeculateMachineInt):
(JSC::DFG::Graph::mulShouldSpeculateMachineInt):
(JSC::DFG::Graph::negateShouldSpeculateMachineInt):
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
- dfg/DFGMinifiedNode.h:
(JSC::DFG::belongsInMinifiedGraph):
(JSC::DFG::MinifiedNode::hasChild):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldSpeculateNumberExpectingDefined):
(JSC::DFG::Node::canSpeculateInt48):
- dfg/DFGNodeFlags.h:
(JSC::DFG::nodeCanSpeculateInt48):
- dfg/DFGNodeType.h:
(JSC::DFG::forwardRewiringSelectionScore):
- dfg/DFGOSRExitCompiler.cpp:
(JSC::DFG::shortOperandsDump):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPrediction):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):
- dfg/DFGSilentRegisterSavePlan.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateNumber):
(JSC::DFG::SpeculativeJIT::speculateRealNumber):
(JSC::DFG::SpeculativeJIT::speculate):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::boxDouble):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::int32Result):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::generationInfoFromVirtualRegister):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGUseKind.cpp:
(WTF::printInternal):
- dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):
- dfg/DFGValueSource.cpp:
(JSC::DFG::ValueSource::dump):
- dfg/DFGValueSource.h:
(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::ValueSource::forFlushFormat):
(JSC::DFG::ValueSource::valueRecovery):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::flushFormat):
- ftl/FTLCArgumentGetter.cpp:
(JSC::FTL::CArgumentGetter::loadNextAndBox):
- ftl/FTLCArgumentGetter.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLExitValue.cpp:
(JSC::FTL::ExitValue::dumpInContext):
- ftl/FTLExitValue.h:
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::speculateRealNumber):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::setInt32):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLOutput.h:
(JSC::FTL::Output::mulWithOverflow32):
- ftl/FTLValueFormat.cpp:
(WTF::printInternal):
- ftl/FTLValueFormat.h:
- ftl/FTLValueSource.cpp:
(JSC::FTL::ValueSource::dump):
- ftl/FTLValueSource.h:
- interpreter/Register.h:
- runtime/Arguments.cpp:
(JSC::Arguments::tearOffForInlineCallFrame):
- runtime/IndexingType.cpp:
(JSC::leastUpperBoundOfIndexingTypeAndType):
- runtime/JSCJSValue.h:
- runtime/JSCJSValueInlines.h:
Source/WTF:
- wtf/PrintStream.h:
Tools:
- Scripts/run-jsc-stress-tests:
LayoutTests:
- js/regress/large-int-captured-expected.txt: Removed.
- js/regress/large-int-captured.html: Removed.
- js/regress/large-int-expected.txt: Removed.
- js/regress/large-int-neg-expected.txt: Removed.
- js/regress/large-int-neg.html: Removed.
- js/regress/large-int.html: Removed.
- js/regress/marsaglia-larger-ints-expected.txt: Removed.
- js/regress/marsaglia-larger-ints.html: Removed.
- js/regress/script-tests/large-int-captured.js: Removed.
- js/regress/script-tests/large-int-neg.js: Removed.
- js/regress/script-tests/large-int.js: Removed.
- js/regress/script-tests/marsaglia-larger-ints.js: Removed.
- 12:07 AM Changeset in webkit [156028] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] WebKitScriptWorld not in API documentation
https://bugs.webkit.org/show_bug.cgi?id=121539
Reviewed by Philippe Normand.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add WebKitScriptWorld.
Sep 17, 2013:
- 11:51 PM Changeset in webkit [156027] by
-
- 2 edits in trunk/Source/WebInspectorUI
[GTK] Cannot find WebInspectorUI/UserInterface/Main.html referenced in GResourceBundle.xml
https://bugs.webkit.org/show_bug.cgi?id=121405
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-09-17
Reviewed by Carlos Garcia Campos.
- GNUmakefile.am: if srcdir == builddir the WebInspectorUI variable that is used both to list
the dependencies of the GResourceBundle and to normalize the paths added to the XML through sed
replacement will end up starting with ./, which would be fine if automake did not remove that
from the paths in the target's dependency. We deal with that by normalizing the path we use to
take that quirk into account.
- 11:39 PM Changeset in webkit [156026] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- 11:30 PM Changeset in webkit [156025] by
-
- 9 edits in trunk/Source/WebCore
Rename InlineBox::isText()
<https://webkit.org/b/121525>
Reviewed by Andreas Kling.
The flag sounds like RenderObject::isText() yet it can be set for some inline boxes generated
for non-text renderers too (br, list markers). This is pretty confusing.
Rename to InlineBox::behavesLikeText().
- rendering/InlineBox.cpp:
(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
- rendering/InlineBox.h:
(WebCore::InlineBox::behavesLikeText):
(WebCore::InlineBox::setBehavesLikeText):
(WebCore::InlineBox::InlineBoxBitfields::InlineBoxBitfields):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::createInlineBoxForRenderer):
(WebCore::setLogicalWidthForTextRun):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::createInlineBox):
- rendering/RenderText.cpp:
(WebCore::RenderText::createInlineTextBox):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::includeLeadingForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::includeMarginForBox):
Switch tests from isText() to isTextOrBR(). This matches the behavior before r155957.
I don't know if there is a case where this actually makes any difference in behavior.
- 11:05 PM Changeset in webkit [156024] by
-
- 3 edits in trunk/Source/WebCore
Shrink SVGPathStringBuilder
https://bugs.webkit.org/show_bug.cgi?id=121536
Reviewed by Anders Carlsson.
- Use StringBuilder everywhere to avoid unnecessary temporary String objects and code size bloat.
- Also did a drive by FINAL / OVERRIDE pass.
As an example of the win, the function SVGPathStringBuilder::arcTo
went from being 6120 bytes down to just 378 bytes.
- svg/SVGPathStringBuilder.cpp:
(WebCore::SVGPathStringBuilder::SVGPathStringBuilder):
(WebCore::SVGPathStringBuilder::~SVGPathStringBuilder):
(WebCore::SVGPathStringBuilder::cleanup):
(WebCore::SVGPathStringBuilder::incrementPathSegmentCount):
(WebCore::SVGPathStringBuilder::continueConsuming):
It wasn't helpful for these to be inlined, so move them to
the implementation file.
(WebCore::appendFlag):
(WebCore::appendNumber):
(WebCore::appendPoint):
Added helpers.
(WebCore::SVGPathStringBuilder::moveTo):
(WebCore::SVGPathStringBuilder::lineTo):
(WebCore::SVGPathStringBuilder::lineToHorizontal):
(WebCore::SVGPathStringBuilder::lineToVertical):
(WebCore::SVGPathStringBuilder::curveToCubic):
(WebCore::SVGPathStringBuilder::curveToCubicSmooth):
(WebCore::SVGPathStringBuilder::curveToQuadratic):
(WebCore::SVGPathStringBuilder::curveToQuadraticSmooth):
(WebCore::SVGPathStringBuilder::arcTo):
(WebCore::SVGPathStringBuilder::closePath):
- svg/SVGPathStringBuilder.h:
Stopped using operator+ and removed duplicate string building logic in each build
type (e.g. both sides of the PathCoordinateMode condition were doing almost identical
work).
- 10:00 PM Changeset in webkit [156023] by
-
- 14 edits in trunk/Source/WebCore
CTTE: Convert some straggling Element subclasses constructors to take a Document&
https://bugs.webkit.org/show_bug.cgi?id=121533
Reviewed by Anders Carlsson.
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::didAddUserAgentShadowRoot):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::didAddUserAgentShadowRoot):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::didAddUserAgentShadowRoot):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::createShadowSubtree):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
- html/shadow/MeterShadowElement.cpp:
(WebCore::MeterShadowElement::MeterShadowElement):
(WebCore::MeterInnerElement::MeterInnerElement):
- html/shadow/MeterShadowElement.h:
(WebCore::MeterInnerElement::create):
(WebCore::MeterBarElement::create):
(WebCore::MeterValueElement::create):
- html/shadow/ProgressShadowElement.cpp:
(WebCore::ProgressShadowElement::ProgressShadowElement):
(WebCore::ProgressInnerElement::ProgressInnerElement):
(WebCore::ProgressBarElement::ProgressBarElement):
(WebCore::ProgressValueElement::ProgressValueElement):
- html/shadow/ProgressShadowElement.h:
(WebCore::ProgressInnerElement::create):
(WebCore::ProgressBarElement::create):
(WebCore::ProgressValueElement::create):
- html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::create):
- html/shadow/SpinButtonElement.h:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerContainer::TextControlInnerContainer):
(WebCore::TextControlInnerContainer::create):
(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerElement::create):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::TextControlInnerTextElement::create):
(WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
(WebCore::SearchFieldResultsButtonElement::create):
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
(WebCore::SearchFieldCancelButtonElement::create):
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
(WebCore::InputFieldSpeechButtonElement::create):
- html/shadow/TextControlInnerElements.h:
- 8:27 PM Changeset in webkit [156022] by
-
- 12 edits8 adds in trunk
[CSS Shapes] Use the float height to determine position in shape-inside
https://bugs.webkit.org/show_bug.cgi?id=102846
Reviewed by Darin Adler.
Float positioning inside shape-inside has been working only for simple cases when the float boundaries didn't overlap with the shape.
This patch fixes the behavior for left floats and shapes with inline content. I want to add this work step by step, therefore the next
step would be to add support for block content with inline content (e.g. paragraphs) then cover cases with right floats.
Source/WebCore:
Tests: fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html
- rendering/LineWidth.cpp:
(WebCore::LineWidth::LineWidth): Use the new updateCurrentShapeSegment member function.
(WebCore::LineWidth::updateCurrentShapeSegment): We need a function to update the current line segment's reference, since we use it multiple places.
- rendering/LineWidth.h: Add new member function.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Fix positioning of a floating element.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Use updateSegmentsForLine instead of computeSegmentsForLine.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread): Use updateSegmentsForLine instead of computeSegmentsForLine.
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded):
(WebCore::updateSegmentsForShapes): After our float is positioned, we need to adjust the current lineTop and update the logical height to be able to wrap around the float.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): If we have a float in our line we might need to adjust our lineTop and logicalHeight.
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::computeSegmentsForLine): Add new const function to compute the segments. I'd like make this function static later if possible.
(WebCore::::updateSegmentsForLine): Old computeSegmentsForLine, change name to indicate that it is actually changing things.
- rendering/shapes/ShapeInfo.h: Update function names, add declaration.
(WebCore::ShapeInfo::clearSegments):
(WebCore::ShapeInfo::logicalLineBottom):
(WebCore::ShapeInfo::lineOverlapsShapeBounds):
- rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::computeFirstFitPositionForFloat): Compute the first fit position below the current line position inside shapes. I called this function
this way, because currently we use it only for shapes.
- rendering/shapes/ShapeInsideInfo.h: Update function names.
- rendering/shapes/ShapeOutsideInfo.cpp: Update function names.
(WebCore::ShapeOutsideInfo::computeSegmentsForContainingBlockLine):
(WebCore::ShapeOutsideInfo::updateSegmentsForLine):
- rendering/shapes/ShapeOutsideInfo.h: Update function names.
LayoutTests:
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html: Added.
- 6:59 PM Changeset in webkit [156021] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 6:48 PM Changeset in webkit [156020] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix 32-bit build.
- runtime/JSCJSValue.h:
- 6:31 PM Changeset in webkit [156019] by
-
- 69 edits12 adds in trunk
DFG should support Int52 for local variables
https://bugs.webkit.org/show_bug.cgi?id=121064
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This adds Int52 support for local variables to the DFG and FTL. It's a speed-up on
programs that have local int32 overflows but where a larger int representation can
prevent us from having to convert all the way up to double.
It's a small speed-up for now. But we're just supporting Int52 for a handful of
operations (add, sub, mul, neg, compare, bitops, typed array access) and this lays
the groundwork for adding Int52 to JSValue, which will probably be a bigger
speed-up.
The basic approach is:
- We have a notion of Int52 in our typesystem. Int52 doesn't belong to BytecodeTop or HeapTop - i.e. it doesn't arise from JSValues.
- DFG treats Int52 as being part of its FullTop and will treat it as being a subtype of double unless instructed otherwise.
- Prediction propagator creates Int52s whenever we have a node going doubly but due to large values rather than fractional values, and that node is known to be able to produce Int52 natively in the DFG backend.
- Fixup phase converts edges to MachineIntUses in nodes that are known to be able to deal with Int52, and where we have a subtype of Int32|Int52 as the predicted input.
- The DFG backend and FTL LLVM IR lowering have two notions of Int52s - ones that are left-shifted by 16 (great for overflow checks) and ones that are sign-extended. Both backends know how to convert between Int52s and the other representations.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::rshift64):
(JSC::MacroAssemblerX86_64::mul64):
(JSC::MacroAssemblerX86_64::branchMul64):
(JSC::MacroAssemblerX86_64::branchNeg64):
(JSC::MacroAssemblerX86_64::convertInt64ToDouble):
- assembler/X86Assembler.h:
(JSC::X86Assembler::imulq_rr):
(JSC::X86Assembler::cvtsi2sdq_rr):
- bytecode/DataFormat.h:
(JSC::dataFormatToString):
- bytecode/OperandsInlines.h:
(JSC::::dumpInContext):
- bytecode/SpeculatedType.cpp:
(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromValue):
- bytecode/SpeculatedType.h:
(JSC::isInt32SpeculationForArithmetic):
(JSC::isMachineIntSpeculationForArithmetic):
(JSC::isBytecodeRealNumberSpeculation):
(JSC::isFullRealNumberSpeculation):
(JSC::isBytecodeNumberSpeculation):
(JSC::isFullNumberSpeculation):
(JSC::isBytecodeNumberSpeculationExpectingDefined):
(JSC::isFullNumberSpeculationExpectingDefined):
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::alreadyInJSStackAsUnboxedInt52):
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::isAlreadyInJSStack):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dumpInContext):
- dfg/DFGAbstractInterpreter.h:
(JSC::DFG::AbstractInterpreter::needsTypeCheck):
(JSC::DFG::AbstractInterpreter::filterByType):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::checkConsistency):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::couldBeType):
(JSC::DFG::AbstractValue::isType):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::validateType):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::boxInt52):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGCommon.h:
(JSC::DFG::enableInt52):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixupUntypedSetLocalsInBlock):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):
- dfg/DFGFlushFormat.cpp:
(WTF::printInternal):
- dfg/DFGFlushFormat.h:
(JSC::DFG::resultFor):
(JSC::DFG::useKindFor):
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::initInt52):
(JSC::DFG::GenerationInfo::initStrictInt52):
(JSC::DFG::GenerationInfo::isFormat):
(JSC::DFG::GenerationInfo::isInt52):
(JSC::DFG::GenerationInfo::isStrictInt52):
(JSC::DFG::GenerationInfo::fillInt52):
(JSC::DFG::GenerationInfo::fillStrictInt52):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::addShouldSpeculateMachineInt):
(JSC::DFG::Graph::mulShouldSpeculateMachineInt):
(JSC::DFG::Graph::negateShouldSpeculateMachineInt):
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
- dfg/DFGMinifiedNode.h:
(JSC::DFG::belongsInMinifiedGraph):
(JSC::DFG::MinifiedNode::hasChild):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldSpeculateNumberExpectingDefined):
- dfg/DFGNodeFlags.h:
- dfg/DFGNodeType.h:
(JSC::DFG::forwardRewiringSelectionScore):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPrediction):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):
- dfg/DFGSilentRegisterSavePlan.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateMachineInt):
(JSC::DFG::SpeculativeJIT::speculateNumber):
(JSC::DFG::SpeculativeJIT::speculateRealNumber):
(JSC::DFG::SpeculativeJIT::speculate):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::int52Result):
(JSC::DFG::SpeculativeJIT::strictInt52Result):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::betterUseStrictInt52):
(JSC::DFG::SpeculativeJIT::generationInfo):
(JSC::DFG::SpeculateInt52Operand::SpeculateInt52Operand):
(JSC::DFG::SpeculateInt52Operand::~SpeculateInt52Operand):
(JSC::DFG::SpeculateInt52Operand::edge):
(JSC::DFG::SpeculateInt52Operand::node):
(JSC::DFG::SpeculateInt52Operand::gpr):
(JSC::DFG::SpeculateInt52Operand::use):
(JSC::DFG::SpeculateStrictInt52Operand::SpeculateStrictInt52Operand):
(JSC::DFG::SpeculateStrictInt52Operand::~SpeculateStrictInt52Operand):
(JSC::DFG::SpeculateStrictInt52Operand::edge):
(JSC::DFG::SpeculateStrictInt52Operand::node):
(JSC::DFG::SpeculateStrictInt52Operand::gpr):
(JSC::DFG::SpeculateStrictInt52Operand::use):
(JSC::DFG::SpeculateWhicheverInt52Operand::SpeculateWhicheverInt52Operand):
(JSC::DFG::SpeculateWhicheverInt52Operand::~SpeculateWhicheverInt52Operand):
(JSC::DFG::SpeculateWhicheverInt52Operand::edge):
(JSC::DFG::SpeculateWhicheverInt52Operand::node):
(JSC::DFG::SpeculateWhicheverInt52Operand::gpr):
(JSC::DFG::SpeculateWhicheverInt52Operand::use):
(JSC::DFG::SpeculateWhicheverInt52Operand::format):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::boxInt52):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileInt52Compare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleInt52Branch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGUseKind.cpp:
(WTF::printInternal):
- dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):
- dfg/DFGValueSource.cpp:
(JSC::DFG::ValueSource::dump):
- dfg/DFGValueSource.h:
(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::ValueSource::forFlushFormat):
(JSC::DFG::ValueSource::valueRecovery):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::flushFormat):
- ftl/FTLCArgumentGetter.cpp:
(JSC::FTL::CArgumentGetter::loadNextAndBox):
- ftl/FTLCArgumentGetter.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLExitValue.cpp:
(JSC::FTL::ExitValue::dumpInContext):
- ftl/FTLExitValue.h:
(JSC::FTL::ExitValue::inJSStackAsInt52):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowInt52):
(JSC::FTL::LowerDFGToLLVM::lowStrictInt52):
(JSC::FTL::LowerDFGToLLVM::betterUseStrictInt52):
(JSC::FTL::LowerDFGToLLVM::bestInt52Kind):
(JSC::FTL::LowerDFGToLLVM::opposite):
(JSC::FTL::LowerDFGToLLVM::Int52s::operator[]):
(JSC::FTL::LowerDFGToLLVM::lowWhicheverInt52):
(JSC::FTL::LowerDFGToLLVM::lowWhicheverInt52s):
(JSC::FTL::LowerDFGToLLVM::lowOpposingInt52s):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToInt32):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToDouble):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToJSValue):
(JSC::FTL::LowerDFGToLLVM::setInt52WithStrictValue):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToInt52):
(JSC::FTL::LowerDFGToLLVM::int52ToStrictInt52):
(JSC::FTL::LowerDFGToLLVM::speculateRealNumber):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::setInt52):
(JSC::FTL::LowerDFGToLLVM::setStrictInt52):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLOutput.h:
(JSC::FTL::Output::addWithOverflow64):
(JSC::FTL::Output::subWithOverflow64):
(JSC::FTL::Output::mulWithOverflow64):
- ftl/FTLValueFormat.cpp:
(WTF::printInternal):
- ftl/FTLValueFormat.h:
- ftl/FTLValueSource.cpp:
(JSC::FTL::ValueSource::dump):
- ftl/FTLValueSource.h:
- interpreter/Register.h:
(JSC::Register::unboxedInt52):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOffForInlineCallFrame):
- runtime/IndexingType.cpp:
(JSC::leastUpperBoundOfIndexingTypeAndType):
- runtime/JSCJSValue.h:
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::isMachineInt):
(JSC::JSValue::asMachineInt):
Source/WTF:
Reviewed by Oliver Hunt.
- wtf/PrintStream.h:
(WTF::ValueIgnoringContext::ValueIgnoringContext):
(WTF::ValueIgnoringContext::dump):
(WTF::ignoringContext):
Tools:
Reviewed by Oliver Hunt.
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Oliver Hunt.
- js/regress/large-int-captured-expected.txt: Added.
- js/regress/large-int-captured.html: Added.
- js/regress/large-int-expected.txt: Added.
- js/regress/large-int-neg-expected.txt: Added.
- js/regress/large-int-neg.html: Added.
- js/regress/large-int.html: Added.
- js/regress/marsaglia-larger-ints-expected.txt: Added.
- js/regress/marsaglia-larger-ints.html: Added.
- js/regress/script-tests/large-int-captured.js: Added.
(.bar):
(foo):
- js/regress/script-tests/large-int-neg.js: Added.
(foo):
- js/regress/script-tests/large-int.js: Added.
(foo):
- js/regress/script-tests/marsaglia-larger-ints.js: Added.
(uint):
(marsaglia):
- 6:10 PM Changeset in webkit [156018] by
-
- 2 edits in trunk/Tools
Added back and forward buttons to WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=121212
Reviewed by Brent Fulgham.
- WinLauncher/WinLauncher.cpp:
(resizeSubViews):
Move new back and forward buttons to correct positions before URL bar.
(dllLauncherEntryPoint):
Store the default button window procedure and replace with my button procedures.
(EditProc): Updated style and renamed from MyEditProc.
(BackButtonProc): Added.
(ForwardButtonProc): Added.
- 6:06 PM Changeset in webkit [156017] by
-
- 5 edits in trunk/Source/JavaScriptCore
Use CheckStructure for checking the types of typed arrays whenever possible
https://bugs.webkit.org/show_bug.cgi?id=121514
Reviewed by Oliver Hunt.
- bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::refine):
(JSC::DFG::ArrayMode::originalArrayStructure):
(JSC::DFG::arrayClassToString):
- dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::ArrayMode):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShape):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::isOriginalTypedArrayStructure):
- 6:04 PM Changeset in webkit [156016] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG should use the (x & 0x7fffffff) trick for doing overflow and neg-zero checks on negation in one go
https://bugs.webkit.org/show_bug.cgi?id=121520
Reviewed by Oliver Hunt.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithNegate):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
- 5:15 PM Changeset in webkit [156015] by
-
- 40 edits in trunk/Source/WebCore
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebCore
https://bugs.webkit.org/show_bug.cgi?id=121527
Reviewed by Anders Carlsson.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::setBuffer):
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/OscillatorNode.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::currentCharacter16):
- css/CSSParser.h:
- html/HTMLAreaElement.h:
- html/HTMLFrameSetElement.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::simulateVertexAttrib0):
(WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache):
- html/canvas/WebGLRenderingContext.h:
- platform/ScrollAnimatorNone.cpp:
- platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::setNumberOfChannels):
- platform/audio/DynamicsCompressor.h:
- platform/audio/FFTFrame.h:
- platform/audio/gstreamer/FFTFrameGStreamer.cpp:
(WebCore::FFTFrame::FFTFrame):
- platform/efl/ScrollbarEfl.cpp:
(ScrollbarEfl::updateThumbPositionAndProportion):
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::compileShaderSource):
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::texImage2DResourceSafe):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- platform/graphics/blackberry/LayerTexture.cpp:
- platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::getDirtyRects):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/graphics/cg/ImageBufferCG.cpp:
- platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::updateSubRect):
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setNormalizedBuffer):
- platform/graphics/harfbuzz/HarfBuzzShaper.h:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderInfoLog):
- platform/graphics/opentype/OpenTypeSanitizer.cpp:
- platform/graphics/texmap/TextureMapperGL.cpp:
- platform/graphics/wince/SharedBitmap.cpp:
(WebCore::SharedBitmap::SharedBitmap):
(WebCore::SharedBitmap::to16bit):
- platform/graphics/wince/SharedBitmap.h:
- platform/image-decoders/blackberry/JPEGImageDecoder.cpp:
(WebCore::ImageReader::decode):
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::createRowBuffer):
- platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::getContextMenuItems):
- platform/win/LoggingWin.cpp:
(WebCore::logLevelString):
- plugins/PluginPackage.cpp:
- plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::handleTouchEvent):
- plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::fetchInfo):
- 5:10 PM Changeset in webkit [156014] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r156001.
http://trac.webkit.org/changeset/156001
https://bugs.webkit.org/show_bug.cgi?id=121529
Broke API tests (Requested by ap on #webkit).
- platform/mac/HTMLConverter.h:
- platform/mac/HTMLConverter.mm:
(WebDefaultFont):
(_fontForNameAndSize):
(+[WebHTMLConverter defaultParagraphStyle]):
(-[WebHTMLConverter _computedStyleForElement:]):
(-[WebHTMLConverter _specifiedStyleForElement:]):
(-[WebHTMLConverter _computedStringForNode:property:]):
(-[WebHTMLConverter _stringForNode:property:]):
(-[WebHTMLConverter _getComputedFloat:forNode:property:]):
(-[WebHTMLConverter _getFloat:forNode:property:]):
(_colorForRGBColor):
(_shadowForShadowStyle):
(-[WebHTMLConverter _elementIsBlockLevel:]):
(-[WebHTMLConverter _elementHasOwnBackgroundColor:]):
(-[WebHTMLConverter _computedColorForNode:property:]):
(-[WebHTMLConverter _colorForNode:property:]):
(-[WebHTMLConverter _computedAttributesForElement:]):
(-[WebHTMLConverter _attributesForElement:]):
(-[WebHTMLConverter _newParagraphForElement:tag:allowEmpty:suppressTrailingSpace:]):
(-[WebHTMLConverter _newLineForElement:]):
(-[WebHTMLConverter _newTabForElement:]):
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(-[WebHTMLConverter _addQuoteForElement:opening:level:]):
(-[WebHTMLConverter _addValue:forElement:]):
(-[WebHTMLConverter _fillInBlock:forElement:backgroundColor:extraMargin:extraPadding:isTable:]):
(_dateForString):
(_colCompare):
(-[WebHTMLConverter _enterElement:tag:display:]):
(-[WebHTMLConverter _addTableForElement:]):
(-[WebHTMLConverter _addTableCellForElement:]):
(-[WebHTMLConverter _processElement:tag:display:depth:]):
(-[WebHTMLConverter _addMarkersToList:range:]):
(-[WebHTMLConverter _exitElement:tag:display:depth:startIndex:]):
(-[WebHTMLConverter _processText:]):
(-[WebHTMLConverter _traverseNode:depth:embedded:]):
(-[WebHTMLConverter _traverseFooterNode:depth:]):
(-[WebHTMLConverter _loadFromDOMRange]):
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
(-[WebHTMLConverter initWithDOMRange:]):
(-[WebHTMLConverter attributedString]):
(+[WebHTMLConverter editingAttributedStringFromRange:]):
(fileWrapperForElement):
- 4:24 PM Changeset in webkit [156013] by
-
- 1 edit4 deletes in trunk/LayoutTests
Removed some Lion specific results - these tests are failing on Lion bots despite these,
and it looks like Lion now matches cross-platform results.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Removed.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Removed.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Removed.
- platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Removed.
- 4:12 PM Changeset in webkit [156012] by
-
- 2 edits in trunk/LayoutTests
compositing/images/positioned-image-content-rect.html is failing on some bots
https://bugs.webkit.org/show_bug.cgi?id=121526
- platform/mac/TestExpectations: Marked as failing or passing for now, should
be fixed with upcoming color management improvements.
- 4:08 PM Changeset in webkit [156011] by
-
- 24 edits in trunk
AX: Mac AXARIABusy should be AXElementBusy (not ARIA specific)
https://bugs.webkit.org/show_bug.cgi?id=121442
Patch by Samuel White <Samuel White> on 2013-09-17
Reviewed by Chris Fleizach.
Source/WebCore:
No new tests, changed AXARIABusy attribute to AXElementBusy to uncouple the concept of busy with
the aria-busy attribute. This will allow us to expand on the definition of busy moving forward.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
Mac platform attribute name change only (AXARIABusy => AXElementBusy). Updated existing tests using this attribute.
- accessibility/transformed-element-expected.txt:
- platform/mac/accessibility/aria-columnrowheaders-expected.txt:
- platform/mac/accessibility/aria-liveregions-attributes-expected.txt:
- platform/mac/accessibility/aria-liveregions-attributes.html:
- platform/mac/accessibility/bounds-for-range-expected.txt:
- platform/mac/accessibility/document-attributes-expected.txt:
- platform/mac/accessibility/document-links-expected.txt:
- platform/mac/accessibility/image-link-expected.txt:
- platform/mac/accessibility/image-map2-expected.txt:
- platform/mac/accessibility/internal-link-anchors-expected.txt:
- platform/mac/accessibility/internal-link-anchors2-expected.txt:
- platform/mac/accessibility/lists-expected.txt:
- platform/mac/accessibility/plugin-expected.txt:
- platform/mac/accessibility/table-attributes-expected.txt:
- platform/mac/accessibility/table-cell-spans-expected.txt:
- platform/mac/accessibility/table-cells-expected.txt:
- platform/mac/accessibility/table-detection-expected.txt:
- platform/mac/accessibility/table-one-cell-expected.txt:
- platform/mac/accessibility/table-sections-expected.txt:
- platform/mac/accessibility/table-with-aria-role-expected.txt:
- platform/mac/accessibility/table-with-rules-expected.txt:
- 3:48 PM Changeset in webkit [156010] by
-
- 2 edits in trunk/Tools
Unreviewed typo fix after r155999
Changed en_US.UTB-8 to en_US.UTF-8
- Scripts/run-javascriptcore-tests:
- 3:32 PM Changeset in webkit [156009] by
-
- 18 edits in trunk/Source
Pack create_hash_table tables better.
<https://webkit.org/b/121517>
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Reduces JavaScriptCore binary size by 4648 bytes.
- create_hash_table:
- runtime/Lookup.h:
Reorder HashTableValue members to avoid unnecessary padding.
Source/WebCore:
Reduces WebCore binary size by 72744 bytes.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable):
Updated for new HashTableValue member order.
- bindings/scripts/test/JS/*:
Rebaselined bindings tests.
- 3:27 PM Changeset in webkit [156008] by
-
- 2 edits1 copy in trunk/LayoutTests
Rebaseline a test.
- platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt: Copied from LayoutTests/platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt.
- platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
- 3:27 PM Changeset in webkit [156007] by
-
- 2 edits in trunk/LayoutTests
[Windows] Adjust test list further to make the bots green.
- platform/win/TestExpectations:
- 3:07 PM Changeset in webkit [156006] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Add FlowThreadController.h to Target.pri
https://bugs.webkit.org/show_bug.cgi?id=121516
Reviewed by Dirk Schulze.
No new tests, no behavior change.
- Target.pri:
- 3:03 PM Changeset in webkit [156005] by
-
- 2 edits in trunk/LayoutTests
ScriptProcessorNode is garbage collected while still active if unreachable (breaks
webaudio/javascriptaudionode.html test)
https://bugs.webkit.org/show_bug.cgi?id=112521
- TestExpectations: Marking test as failing/asserting.
- 2:58 PM Changeset in webkit [156004] by
-
- 115 edits in trunk/Source
Stop explicitly using PassOwnPtr in WebCore/html
https://bugs.webkit.org/show_bug.cgi?id=121511
Reviewed by Andreas Kling.
Source/WebCore:
- dom/ElementRareData.h:
(WebCore::ElementRareData::setClassList):
- html/ButtonInputType.cpp:
(WebCore::ButtonInputType::create):
- html/ButtonInputType.h:
- html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::create):
(WebCore::CheckboxInputType::willDispatchClick):
- html/CheckboxInputType.h:
- html/ClassList.cpp:
(WebCore::ClassList::create):
- html/ClassList.h:
- html/ColorInputType.cpp:
(WebCore::ColorInputType::create):
- html/ColorInputType.h:
- html/DateInputType.cpp:
(WebCore::DateInputType::create):
- html/DateInputType.h:
- html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::create):
- html/DateTimeInputType.h:
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::create):
- html/DateTimeLocalInputType.h:
- html/EmailInputType.cpp:
(WebCore::EmailInputType::create):
- html/EmailInputType.h:
- html/FileInputType.cpp:
(WebCore::FileInputType::create):
- html/FileInputType.h:
- html/FormAssociatedElement.cpp:
(WebCore::FormAttributeTargetObserver::create):
- html/FormController.cpp:
(WebCore::SavedFormState::create):
(WebCore::SavedFormState::deserialize):
(WebCore::FormKeyGenerator::create):
(WebCore::FormController::createSavedFormStateMap):
- html/FormController.h:
(WebCore::FormController::create):
- html/HTMLInputElement.cpp:
(WebCore::ListAttributeTargetObserver::create):
- html/HiddenInputType.cpp:
(WebCore::HiddenInputType::create):
- html/HiddenInputType.h:
- html/ImageInputType.cpp:
(WebCore::ImageInputType::create):
- html/ImageInputType.h:
- html/InputType.cpp:
(WebCore::InputType::create):
(WebCore::InputType::createText):
(WebCore::InputType::willDispatchClick):
- html/InputType.h:
- html/MonthInputType.cpp:
(WebCore::MonthInputType::create):
- html/MonthInputType.h:
- html/NumberInputType.cpp:
(WebCore::NumberInputType::create):
- html/NumberInputType.h:
- html/PasswordInputType.cpp:
(WebCore::PasswordInputType::create):
- html/PasswordInputType.h:
- html/PublicURLManager.h:
(WebCore::PublicURLManager::create):
- html/RadioInputType.cpp:
(WebCore::RadioInputType::create):
(WebCore::RadioInputType::willDispatchClick):
- html/RadioInputType.h:
- html/RangeInputType.cpp:
(WebCore::RangeInputType::create):
- html/RangeInputType.h:
- html/ResetInputType.cpp:
(WebCore::ResetInputType::create):
- html/ResetInputType.h:
- html/SearchInputType.cpp:
(WebCore::SearchInputType::create):
- html/SearchInputType.h:
- html/SubmitInputType.cpp:
(WebCore::SubmitInputType::create):
- html/SubmitInputType.h:
- html/TelephoneInputType.cpp:
(WebCore::TelephoneInputType::create):
- html/TelephoneInputType.h:
- html/TextInputType.cpp:
(WebCore::TextInputType::create):
- html/TextInputType.h:
- html/TimeInputType.cpp:
(WebCore::TimeInputType::create):
- html/TimeInputType.h:
- html/URLInputType.cpp:
(WebCore::URLInputType::create):
- html/URLInputType.h:
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::create):
- html/ValidationMessage.h:
- html/ValidityState.h:
(WebCore::ValidityState::create):
- html/WeekInputType.cpp:
(WebCore::WeekInputType::create):
- html/WeekInputType.h:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
- html/canvas/CanvasRenderingContext2D.h:
(WebCore::CanvasRenderingContext2D::create):
- html/canvas/EXTDrawBuffers.cpp:
(WebCore::EXTDrawBuffers::create):
- html/canvas/EXTDrawBuffers.h:
- html/canvas/EXTTextureFilterAnisotropic.cpp:
(WebCore::EXTTextureFilterAnisotropic::create):
- html/canvas/EXTTextureFilterAnisotropic.h:
- html/canvas/OESElementIndexUint.cpp:
(WebCore::OESElementIndexUint::create):
- html/canvas/OESElementIndexUint.h:
- html/canvas/OESStandardDerivatives.cpp:
(WebCore::OESStandardDerivatives::create):
- html/canvas/OESStandardDerivatives.h:
- html/canvas/OESTextureFloat.cpp:
(WebCore::OESTextureFloat::create):
- html/canvas/OESTextureFloat.h:
- html/canvas/OESTextureHalfFloat.cpp:
(WebCore::OESTextureHalfFloat::create):
- html/canvas/OESTextureHalfFloat.h:
- html/canvas/OESVertexArrayObject.cpp:
(WebCore::OESVertexArrayObject::create):
- html/canvas/OESVertexArrayObject.h:
- html/canvas/WebGLCompressedTextureATC.cpp:
(WebCore::WebGLCompressedTextureATC::create):
- html/canvas/WebGLCompressedTextureATC.h:
- html/canvas/WebGLCompressedTexturePVRTC.cpp:
(WebCore::WebGLCompressedTexturePVRTC::create):
- html/canvas/WebGLCompressedTexturePVRTC.h:
- html/canvas/WebGLCompressedTextureS3TC.cpp:
(WebCore::WebGLCompressedTextureS3TC::create):
- html/canvas/WebGLCompressedTextureS3TC.h:
- html/canvas/WebGLDebugRendererInfo.cpp:
(WebCore::WebGLDebugRendererInfo::create):
- html/canvas/WebGLDebugRendererInfo.h:
- html/canvas/WebGLDebugShaders.cpp:
(WebCore::WebGLDebugShaders::create):
- html/canvas/WebGLDebugShaders.h:
- html/canvas/WebGLDepthTexture.cpp:
(WebCore::WebGLDepthTexture::create):
- html/canvas/WebGLDepthTexture.h:
- html/canvas/WebGLLoseContext.cpp:
(WebCore::WebGLLoseContext::create):
- html/canvas/WebGLLoseContext.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create):
- html/canvas/WebGLRenderingContext.h:
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::resumeFrom):
- html/parser/BackgroundHTMLParser.h:
(WebCore::BackgroundHTMLParser::create):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::discardSpeculationsAndResumeFrom):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
- html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::ElementRecord::releaseNext):
(WebCore::HTMLElementStack::ElementRecord::setNext):
- html/parser/HTMLMetaCharsetParser.h:
(WebCore::HTMLMetaCharsetParser::create):
- html/parser/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::create):
- html/parser/HTMLParserThread.h:
(WebCore::HTMLParserThread::create):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
- html/parser/HTMLResourcePreloader.cpp:
(WebCore::HTMLResourcePreloader::preload):
- html/parser/HTMLResourcePreloader.h:
(WebCore::PreloadRequest::create):
- html/parser/HTMLScriptRunner.h:
(WebCore::HTMLScriptRunner::create):
- html/parser/HTMLToken.h:
(WebCore::HTMLToken::releaseDoctypeData):
- html/parser/HTMLTokenizer.h:
(WebCore::HTMLTokenizer::create):
- html/parser/HTMLTreeBuilder.h:
(WebCore::HTMLTreeBuilder::create):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h:
- html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
- html/track/WebVTTParser.h:
(WebCore::WebVTTParser::create):
- html/track/WebVTTTokenizer.h:
(WebCore::WebVTTTokenizer::create):
Source/WTF:
Make operator= work work for different types of OwnPtrs.
- wtf/OwnPtr.h:
- 2:57 PM Changeset in webkit [156003] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG doesn't properly keep scope alive for op_put_to_scope
https://bugs.webkit.org/show_bug.cgi?id=121519
Reviewed by Michael Saboff.
This was a latent bug that can't actually occur in ToT. It was uncovered by causing slow
path calls in the baseline JIT for op_put_to_scope in places where we couldn't before (but
which were necessary for gen GC).
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- 2:48 PM Changeset in webkit [156002] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: inspector/storage-panel-dom-storage-update.html is flakey on the bots
https://bugs.webkit.org/show_bug.cgi?id=120544
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
Marking as such again.
- 2:48 PM Changeset in webkit [156001] by
-
- 3 edits in trunk/Source/WebCore
Upstream changes to WebHTMLConverter to support HTML
to NSAttributedString conversion on both iOS and OS X.
Reviewed by Benjamin Poulain.
- platform/mac/HTMLConverter.h:
- platform/mac/HTMLConverter.mm:
(WebDefaultFont):
(_fontForNameAndSize):
(+[WebHTMLConverter defaultParagraphStyle]):
(-[WebHTMLConverter _computedStyleForElement:]):
(-[WebHTMLConverter _specifiedStyleForElement:]):
(-[WebHTMLConverter _computedStringForNode:property:]):
(-[WebHTMLConverter _stringForNode:property:]):
(-[WebHTMLConverter _getComputedFloat:forNode:property:]):
(-[WebHTMLConverter _getFloat:forNode:property:]):
(_NSFirstPathForDirectoriesInDomains):
(_NSSystemLibraryPath):
(-[WebHTMLConverter _webKitBundle]):
(_colorForRGBColor):
(_shadowForShadowStyle):
(-[WebHTMLConverter _elementIsBlockLevel:]):
(-[WebHTMLConverter _elementHasOwnBackgroundColor:]):
(-[WebHTMLConverter _computedColorForNode:property:]):
(-[WebHTMLConverter _colorForNode:property:]):
(-[WebHTMLConverter _computedAttributesForElement:]):
(-[WebHTMLConverter _attributesForElement:]):
(-[WebHTMLConverter _newParagraphForElement:tag:allowEmpty:suppressTrailingSpace:]):
(-[WebHTMLConverter _newLineForElement:]):
(-[WebHTMLConverter _newTabForElement:]):
(-[WebHTMLConverter _WebMessageDocumentClass]):
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(-[WebHTMLConverter _addQuoteForElement:opening:level:]):
(-[WebHTMLConverter _addValue:forElement:]):
(-[WebHTMLConverter _fillInBlock:forElement:backgroundColor:extraMargin:extraPadding:isTable:]):
(_dateForString):
(_colCompare):
(-[WebHTMLConverter _processMetaElementWithName:content:]):
(-[WebHTMLConverter _processHeadElement:]):
(-[WebHTMLConverter _enterElement:tag:display:embedded:]):
(-[WebHTMLConverter _addTableForElement:]):
(-[WebHTMLConverter _addTableCellForElement:]):
(-[WebHTMLConverter _processElement:tag:display:depth:]):
(-[WebHTMLConverter _addMarkersToList:range:]):
(-[WebHTMLConverter _exitElement:tag:display:depth:startIndex:]):
(-[WebHTMLConverter _processText:]):
(-[WebHTMLConverter _traverseNode:depth:embedded:]):
(-[WebHTMLConverter _traverseFooterNode:depth:]):
(-[WebHTMLConverter _loadFromDOMRange]):
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
(-[WebHTMLConverter initWithDOMRange:]):
(-[WebHTMLConverter attributedString]):
(+[WebHTMLConverter editingAttributedStringFromRange:]):
- 2:46 PM Changeset in webkit [156000] by
-
- 7 edits in trunk/Source
Add make_unique and start using it
https://bugs.webkit.org/show_bug.cgi?id=121523
Reviewed by Anders Carlsson.
../WebCore:
- html/HTMLAreaElement.h:
- html/HTMLFrameSetElement.h:
- platform/Length.cpp:
(WebCore::newCoordsArray):
(WebCore::newLengthArray):
- platform/Length.h:
Switch off OwnArrayPtr to std::unique_ptr<T[]> and make use of make_unique.
../WTF:
- wtf/StdLibExtras.h:
(std::make_unique):
Add temporary implementation of std::make_unique that we can use until our standard
libraries have support for it.
- 2:44 PM Changeset in webkit [155999] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests fails with ruby version 2
https://bugs.webkit.org/show_bug.cgi?id=121521
Reviewed by Jessie Berlin.
Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
- Scripts/run-javascriptcore-tests:
- 2:33 PM Changeset in webkit [155998] by
-
- 33 edits13 copies9 adds1 delete in trunk
Hardware accelerated CSS transitions appear pixelated when scaled up using transform
https://bugs.webkit.org/show_bug.cgi?id=27684
<rdar://problem/6134606>
Source/WebCore:
Reviewed by Dean Jackson.
Take transforms and animations into account when computing the contentsScale
for a layer, so that scaled-up layers remain sharp most of the time.
In its recursiveCommitChanges() tree walk, GraphicsLayerCA now tracks
a root-relative transform, and extracts from that transform the X and Y
scales which it uses to scale the backing store.
If the layer has transform animations on it, we keep around
a transformation matrix for the animation endpoints (or keyframes),
pick up the state that has the larger impact on the root-relative scale,
and use that as the layer's transform, and the transform when recursing
over descendants.
Tests: compositing/contents-scale/animating.html
compositing/contents-scale/scaled-ancestor.html
compositing/contents-scale/simple-scale.html
compositing/contents-scale/z-translate.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::maxScaleFromTransform): Decompose the transform if necesssary
to extract the X and Y scale components.
(WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_rootRelativeScaleFactor.
(WebCore::GraphicsLayerCA::flushCompositingState): Supply a TransformationMatrix
for the root of the recursion.
(WebCore::GraphicsLayerCA::layerTransform): This code was factored out of
computeVisibleRect(), and optionally takes a custom transform.
(WebCore::GraphicsLayerCA::computeVisibleRect): Use the layerTransform() function.
(WebCore::GraphicsLayerCA::updateRootRelativeScale): Given a transform from the root,
find the max scale factor by multiplying the various animation endpoint matrices and picking
the one with the biggest impact on scale. Use this to set m_rootRelativeScaleFactor, and
set the flag to say that we need to update contentsScale.
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): After updating
animations, call updateRootRelativeScale() to update m_rootRelativeScaleFactor.
(WebCore::GraphicsLayerCA::updateAnimations): We have a side table of animation name to
TransformationMatrix, so figure out which entries can be removed from that side table,
and remove them.
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations): Store the matrices for
animation endpoints/keyframes in the m_animationTransforms side table. We don't store
them directly in LayerPropertyAnimation because we just want the final matrix for
a transform list, and using a side table makes ownership easier to manage.
(WebCore::GraphicsLayerCA::getTransformFromAnimationsWithMaxScaleImpact):
goes through the matrices for the running animation endpoints/keyframes, and
multiplies each with the transform up to this layer to find the matrix with the
larger impact on scale.
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints): Returns a vector
of TransformationMatrix for the from and to states.
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes): Returns a vector
of TransformationMatrix for the keyframes.
(WebCore::GraphicsLayerCA::updateContentsScale): Include m_rootRelativeScaleFactor in the
scale factor computation.
(WebCore::GraphicsLayerCA::dumpAdditionalProperties): If we're dumping visible rects,
also dump the contentsScale. Convenient at these are useful to look at together, and I didn't
want to pollute Internals with yet more flags.
- platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation): Formatting.
LayoutTests:
Reviewed by Dean Jackson.
New tests that dump contentsScale under various scaling scenarios:
- compositing/contents-scale/animating-expected.txt: Added.
- compositing/contents-scale/animating.html: Added.
- compositing/contents-scale/scaled-ancestor-expected.txt: Added.
- compositing/contents-scale/scaled-ancestor.html: Added.
- compositing/contents-scale/simple-scale-expected.txt: Added.
- compositing/contents-scale/simple-scale.html: Added.
- compositing/contents-scale/z-translate-expected.txt: Added.
- compositing/contents-scale/z-translate.html: Added.
These tests had Mac-specific results (which include visible rects and now
contents scale) in the cross-platform directory, so cleaned up the cross-platform
results and moved the Mac results to platform-mac.
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
- compositing/visible-rect/2d-transformed-expected.txt:
- compositing/visible-rect/3d-transform-style-expected.txt:
- compositing/visible-rect/3d-transformed-expected.txt:
- compositing/visible-rect/animated-expected.txt:
- compositing/visible-rect/animated-from-none-expected.txt:
- compositing/visible-rect/clipped-by-viewport-expected.txt:
- compositing/visible-rect/clipped-visible-rect-expected.txt:
- compositing/visible-rect/flipped-preserve-3d-expected.txt:
- compositing/visible-rect/iframe-and-layers-expected.txt:
- compositing/visible-rect/nested-transform-expected.txt:
- compositing/visible-rect/scrolled-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/mac/compositing/visible-rect/2d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/2d-transformed-expected.txt.
- platform/mac/compositing/visible-rect/3d-transform-style-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transform-style-expected.txt.
- platform/mac/compositing/visible-rect/3d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transformed-expected.txt.
- platform/mac/compositing/visible-rect/animated-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-expected.txt.
- platform/mac/compositing/visible-rect/animated-from-none-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-from-none-expected.txt.
- platform/mac/compositing/visible-rect/clipped-by-viewport-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-by-viewport-expected.txt.
- platform/mac/compositing/visible-rect/clipped-visible-rect-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-visible-rect-expected.txt.
- platform/mac/compositing/visible-rect/flipped-preserve-3d-expected.txt: Copied from LayoutTests/compositing/visible-rect/flipped-preserve-3d-expected.txt.
- platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt: Copied from LayoutTests/compositing/visible-rect/iframe-and-layers-expected.txt.
- platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/mac/compositing/visible-rect/nested-transform-expected.txt: Copied from LayoutTests/compositing/visible-rect/nested-transform-expected.txt.
- platform/mac/compositing/visible-rect/scrolled-expected.txt: Copied from LayoutTests/compositing/visible-rect/scrolled-expected.txt.
- 2:07 PM Changeset in webkit [155997] by
-
- 5 edits in branches/safari-537.60-branch/Source/WebCore
Merge 154391.
- 2:02 PM Changeset in webkit [155996] by
-
- 3 edits in branches/safari-537.60-branch/WebKitLibraries
Merge 154390.
- 1:56 PM Changeset in webkit [155995] by
-
- 3 edits in trunk/Source/JavaScriptCore
Don't GC while OSR compiling
https://bugs.webkit.org/show_bug.cgi?id=121513
Reviewed by Mark Hahnenberg.
Fixes some rare crashes that I see in ConservativeRoots, while in a GC from OSR exit
compilation.
- dfg/DFGOSRExitCompiler.cpp:
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileFTLOSRExit):
- 1:54 PM Changeset in webkit [155994] by
-
- 21 edits14 deletes in trunk
Unreviewed, rolling out r155977.
http://trac.webkit.org/changeset/155977
https://bugs.webkit.org/show_bug.cgi?id=121515
Broke over a dozen tests on Mac WK2 (Requested by ap on
#webkit).
Source/WebCore:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::computeVisibleRect):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateAnimations):
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::updateContentsScale):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):
- platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation):
LayoutTests:
- compositing/contents-scale/animating-expected.txt: Removed.
- compositing/contents-scale/animating.html: Removed.
- compositing/contents-scale/scaled-ancestor-expected.txt: Removed.
- compositing/contents-scale/scaled-ancestor.html: Removed.
- compositing/contents-scale/simple-scale-expected.txt: Removed.
- compositing/contents-scale/simple-scale.html: Removed.
- compositing/contents-scale/z-translate-expected.txt: Removed.
- compositing/contents-scale/z-translate.html: Removed.
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
- compositing/visible-rect/2d-transformed-expected.txt:
- compositing/visible-rect/3d-transform-style-expected.txt:
- compositing/visible-rect/3d-transformed-expected.txt:
- compositing/visible-rect/animated-expected.txt:
- compositing/visible-rect/animated-from-none-expected.txt:
- compositing/visible-rect/clipped-by-viewport-expected.txt:
- compositing/visible-rect/clipped-visible-rect-expected.txt:
- compositing/visible-rect/flipped-preserve-3d-expected.txt:
- compositing/visible-rect/iframe-and-layers-expected.txt:
- compositing/visible-rect/nested-transform-expected.txt:
- compositing/visible-rect/scrolled-expected.txt:
- platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Removed.
- platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Removed.
- platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/mac/compositing/visible-rect/2d-transformed-expected.txt: Removed.
- platform/mac/compositing/visible-rect/3d-transform-style-expected.txt: Removed.
- platform/mac/compositing/visible-rect/3d-transformed-expected.txt: Removed.
- platform/mac/compositing/visible-rect/animated-expected.txt: Removed.
- platform/mac/compositing/visible-rect/animated-from-none-expected.txt: Removed.
- platform/mac/compositing/visible-rect/clipped-by-viewport-expected.txt: Removed.
- platform/mac/compositing/visible-rect/clipped-visible-rect-expected.txt: Removed.
- platform/mac/compositing/visible-rect/flipped-preserve-3d-expected.txt: Removed.
- platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt: Removed.
- platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/mac/compositing/visible-rect/nested-transform-expected.txt: Removed.
- platform/mac/compositing/visible-rect/scrolled-expected.txt: Removed.
- 1:53 PM Changeset in webkit [155993] by
-
- 3 edits in branches/safari-537-branch/WebKitLibraries
Rollout r155990
- 1:36 PM Changeset in webkit [155992] by
-
- 17 edits10 adds in trunk
MediaStream API: Changing the device enumeration to be async
https://bugs.webkit.org/show_bug.cgi?id=120883
Reviewed by Darin Adler.
Source/WebCore:
Parts merged from https://chromium.googlesource.com/chromium/blink/+/40a96080a1531e50de4eb84571c7dc9fb321ece5
and https://chromium.googlesource.com/chromium/blink/+/ff783a23bb1add588971a8187048a305cf485121
by Tommy Widenflycht.
Test: fast/mediastream/MediaStreamTrack-getSources.html
- CMakeLists.txt: Added new files.
- DerivedSources.make: Ditto.
- GNUmakefile.list.am: Ditto.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::kind): ASCIILiteral -> NeverDestroyed<AtomicString>.
(WebCore::MediaStreamTrack::readyState): Ditto.
(WebCore::MediaStreamTrack::getSources): New.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/MediaStreamTrackSourcesCallback.h: Added.
- Modules/mediastream/MediaStreamTrackSourcesCallback.idl: Added.
- Modules/mediastream/MediaStreamTrackSourcesRequest.cpp: Added.
- Modules/mediastream/MediaStreamTrackSourcesRequest.h: Added.
- Modules/mediastream/SourceInfo.cpp: Added.
- Modules/mediastream/SourceInfo.h: Added.
- Modules/mediastream/SourceInfo.idl: Added.
- WebCore.xcodeproj/project.pbxproj: Add new files.
- bindings/js/JSDOMBinding.h: Add toJS templates for Vector<T> and Vector<RefPtr<T>>.
- platform/mediastream/MediaStreamCenter.h: Add prototype for getMediaStreamTrackSources.
- platform/mediastream/MediaStreamTrackSourcesRequestClient.h: Added.
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
(WebCore::MediaStreamCenterMac::getMediaStreamTrackSources): Added.
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
(WebCore::MediaStreamCenterMac::getMediaStreamTrackSources): Added
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
- platform/mediastream/mac/MediaStreamCenterMac.cpp:
(WebCore::MediaStreamCenterMac::getMediaStreamTrackSources): Added.
- platform/mediastream/mac/MediaStreamCenterMac.h:
LayoutTests:
- fast/mediastream/MediaStreamTrack-getSources-expected.txt: Added.
- fast/mediastream/MediaStreamTrack-getSources.html: Added.
- 1:30 PM Changeset in webkit [155991] by
-
- 2 edits in trunk/LayoutTests
lUnreviewed, rolling out r155976.
http://trac.webkit.org/changeset/155976
https://bugs.webkit.org/show_bug.cgi?id=121512
Broke a test, needs cleanup (Requested by ap_ on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2013-09-17
- platform/mac/accessibility/element-busy-changed-expected.txt: Removed.
- platform/mac/accessibility/element-busy-changed.html: Removed.
- 1:23 PM Changeset in webkit [155990] by
-
- 3 edits in branches/safari-537-branch/WebKitLibraries
Windows build fix after r154914.
- 1:10 PM Changeset in webkit [155989] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r155976.
http://trac.webkit.org/changeset/155976
https://bugs.webkit.org/show_bug.cgi?id=121512
Broke a test, needs cleanup (Requested by ap_ on #webkit).
Source/WebCore:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChanged):
- accessibility/AXObjectCache.h:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
- platform/mac/accessibility/element-busy-changed-expected.txt: Removed.
- platform/mac/accessibility/element-busy-changed.html: Removed.
- 1:06 PM Changeset in webkit [155988] by
-
- 8 edits15 adds1 delete in trunk
Improve srcset parser
https://bugs.webkit.org/show_bug.cgi?id=119423
Patch by Romain Perier <Romain Perier> on 2013-09-17
Reviewed by Benjamin Poulain.
Source/WebCore:
Added new tests and covered by existing ones.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::isHTMLSpaceOrComma): Add a new predicate function used by String::find()
to get the first space or comma character from the input string.
(WebCore::parseImagesWithScaleFromSrcSetAttribute): Add a new static function to parse
and extract images with scale from the srcset attribute. All valid candidates are
returned to the caller through a list. This parsing function also adds support
for data URI schemes as described by the specification.
(WebCore::bestFitSourceForImageAttributes): Remove intermediate arrays of string
when parsing. That is more efficient and avoids trashing the data cache
(varying between 20 and 65% faster depending of the amount of data)
The parser now walks along the attribute value and extracts the candidates directly.
LayoutTests:
- fast/hidpi/image-srcset-data-srcset-invalid-inputs.html: Ensures that a various invalid form of data uri schemes are supported by the srcset attribute.
- fast/hidpi/image-srcset-data-srcset-valid-inputs.html: Ensures that a various valid form of data uri schemes are supported by the srcset attribute.
- fast/hidpi/image-srcset-data-srcset.html: Use comma instead of %.
- fast/hidpi/image-srcset-fraction-1.5x.html: Added.
- fast/hidpi/image-srcset-invalid-inputs-except-one.html: Missing srcset-helper.js. Adding more invalid cases.
- fast/hidpi/image-srcset-invalid-inputs.html: Adding more invalid cases.
- fast/hidpi/image-srcset-nomodifier.html: Updated output as behaviour changed for this case.
- fast/hidpi/image-srcset-space-suffix-nomodifier.html: Ensures that a single candidate with no scale modifier is supported by the srcset attribute, even if a space is left at the end.
- fast/hidpi/image-srcset-space-prefix-nomodifier.html: Ensures that a single candidate with no scale modifier is supported by the srcset attribute, even if a space is left at the beginning.
- fast/hidpi/image-srcset-space-surrounded-nomodifier.html: Ensures that a single candidate with no scale modifier is supported by the srcset attribute, even if it is surrounded by spaces.
- fast/hidpi/image-srcset-data-escaped-srcset.html: Ensures that data uri schemes with escaped characters are supported by the srcset attribute.
- 1:00 PM Changeset in webkit [155987] by
-
- 7 edits in trunk/Source/WebKit2
Buildfix for !ENABLE(CUSTOM_PROTOCOLS) platforms
https://bugs.webkit.org/show_bug.cgi?id=121417
Reviewed by Alexey Proskuryakov.
Original patch by Balazs Kelemen <kbalazs@webkit.org>.
- CMakeLists.txt: Add CustomProtocolManagerProxy.messages.in.
- DerivedSources.pri: Add CustomProtocolManagerProxy.messages.in.
- GNUmakefile.am: Add CustomProtocolManagerProxy.messages.in.
- GNUmakefile.list.am: Add CustomProtocolManagerProxyMessages.h and CustomProtocolManagerProxyMessageReceiver.cpp.
- NetworkProcess/NetworkProcess.cpp: Add the missing ENABLE(CUSTOM_PROTOCOLS) guard.
(WebKit::NetworkProcess::NetworkProcess):
- UIProcess/WebProcessProxy.cpp: Remove the unnecessary conditional include.
- 12:41 PM Changeset in webkit [155986] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge 155985 - [GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session times out after r155714
https://bugs.webkit.org/show_bug.cgi?id=121383
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(openRemoteDebuggingSession): use the page contents' to check the remote debugging of the page
has been successfuly opened, as the title is no longer the same after the switch to the new
frontend.
- 12:27 PM Changeset in webkit [155985] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session times out after r155714
https://bugs.webkit.org/show_bug.cgi?id=121383
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(openRemoteDebuggingSession): use the page contents' to check the remote debugging of the page
has been successfuly opened, as the title is no longer the same after the switch to the new
frontend.
- 12:16 PM Changeset in webkit [155984] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after 155963.
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::getStyleContext): use nullptr instead of 0.
- 12:06 PM Changeset in webkit [155983] by
-
- 2 edits in trunk/LayoutTests
[Windows] Disable a number of crashing tests to help the EWS system run more rapidly.
https://bugs.webkit.org/show_bug.cgi?id=121509
- platform/win/TestExpectations:
- 12:05 PM Changeset in webkit [155982] by
-
- 2 edits in trunk/Source/WebCore
Make SVGTransform::valueAsString use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=121498
Unreviewed typo fix, should address a regression on svg/dom/SVGViewSpec.html.
- svg/SVGTransform.cpp: (WebCore::SVGTransform::valueAsString): "e" is totally
not the same as "f".
- 11:57 AM Changeset in webkit [155981] by
-
- 2 edits in trunk/LayoutTests
[Windows] Disable a number of failing tests to help the EWS system run more rapidly.
- platform/win/TestExpectations:
- 11:39 AM Changeset in webkit [155980] by
-
- 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebInspectorUI
Merge 155966 - Clean up the Inspector's WebSocket code and prevent it from dropping messages.
https://bugs.webkit.org/show_bug.cgi?id=121391
Reviewed by Joseph Pecoraro.
- UserInterface/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.initializeWebSocket): Added. Create the socket
and call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend): Store messages as pending
if the socket isn't ready yet. Call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype._sendPendingMessagesToBackendIfNeeded): Added.
- UserInterface/Main.js:
(WebInspector._initializeWebSocketIfNeeded): Move socket creation to initializeWebSocket.
- 11:22 AM Changeset in webkit [155979] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed build fix after r155963.
- DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
- 11:15 AM Changeset in webkit [155978] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Speculative build fix after r155963
- WebKitCOMAPI.cpp:
(classFactory): Use nullptr rather than 0 for HashMap.
- 11:12 AM Changeset in webkit [155977] by
-
- 21 edits13 copies9 adds in trunk
Hardware accelerated CSS transitions appear pixelated when scaled up using transform
https://bugs.webkit.org/show_bug.cgi?id=27684
<rdar://problem/6134606>
Source/WebCore:
Reviewed by Dean Jackson.
Take transforms and animations into account when computing the contentsScale
for a layer, so that scaled-up layers remain sharp most of the time.
In its recursiveCommitChanges() tree walk, GraphicsLayerCA now tracks
a root-relative transform, and extracts from that transform the X and Y
scales which it uses to scale the backing store.
If the layer has transform animations on it, we keep around
a transformation matrix for the animation endpoints (or keyframes),
pick up the state that has the larger impact on the root-relative scale,
and use that as the layer's transform, and the transform when recursing
over descendants.
Tests: compositing/contents-scale/animating.html
compositing/contents-scale/scaled-ancestor.html
compositing/contents-scale/simple-scale.html
compositing/contents-scale/z-translate.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::maxScaleFromTransform): Decompose the transform if necesssary
to extract the X and Y scale components.
(WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_rootRelativeScaleFactor.
(WebCore::GraphicsLayerCA::flushCompositingState): Supply a TransformationMatrix
for the root of the recursion.
(WebCore::GraphicsLayerCA::layerTransform): This code was factored out of
computeVisibleRect(), and optionally takes a custom transform.
(WebCore::GraphicsLayerCA::computeVisibleRect): Use the layerTransform() function.
(WebCore::GraphicsLayerCA::updateRootRelativeScale): Given a transform from the root,
find the max scale factor by multiplying the various animation endpoint matrices and picking
the one with the biggest impact on scale. Use this to set m_rootRelativeScaleFactor, and
set the flag to say that we need to update contentsScale.
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): After updating
animations, call updateRootRelativeScale() to update m_rootRelativeScaleFactor.
(WebCore::GraphicsLayerCA::updateAnimations): We have a side table of animation name to
TransformationMatrix, so figure out which entries can be removed from that side table,
and remove them.
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations): Store the matrices for
animation endpoints/keyframes in the m_animationTransforms side table. We don't store
them directly in LayerPropertyAnimation because we just want the final matrix for
a transform list, and using a side table makes ownership easier to manage.
(WebCore::GraphicsLayerCA::getTransformFromAnimationsWithMaxScaleImpact):
goes through the matrices for the running animation endpoints/keyframes, and
multiplies each with the transform up to this layer to find the matrix with the
larger impact on scale.
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints): Returns a vector
of TransformationMatrix for the from and to states.
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes): Returns a vector
of TransformationMatrix for the keyframes.
(WebCore::GraphicsLayerCA::updateContentsScale): Include m_rootRelativeScaleFactor in the
scale factor computation.
(WebCore::GraphicsLayerCA::dumpAdditionalProperties): If we're dumping visible rects,
also dump the contentsScale. Convenient at these are useful to look at together, and I didn't
want to pollute Internals with yet more flags.
- platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation): Formatting.
LayoutTests:
Reviewed by Dean Jackson.
New tests that dump contentsScale under various scaling scenarios:
- compositing/contents-scale/animating-expected.txt: Added.
- compositing/contents-scale/animating.html: Added.
- compositing/contents-scale/scaled-ancestor-expected.txt: Added.
- compositing/contents-scale/scaled-ancestor.html: Added.
- compositing/contents-scale/simple-scale-expected.txt: Added.
- compositing/contents-scale/simple-scale.html: Added.
- compositing/contents-scale/z-translate-expected.txt: Added.
- compositing/contents-scale/z-translate.html: Added.
These tests had Mac-specific results (which include visible rects and now
contents scale) in the cross-platform directory, so cleaned up the cross-platform
results and moved the Mac results to platform-mac.
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
- compositing/visible-rect/2d-transformed-expected.txt:
- compositing/visible-rect/3d-transform-style-expected.txt:
- compositing/visible-rect/3d-transformed-expected.txt:
- compositing/visible-rect/animated-expected.txt:
- compositing/visible-rect/animated-from-none-expected.txt:
- compositing/visible-rect/clipped-by-viewport-expected.txt:
- compositing/visible-rect/clipped-visible-rect-expected.txt:
- compositing/visible-rect/flipped-preserve-3d-expected.txt:
- compositing/visible-rect/iframe-and-layers-expected.txt:
- compositing/visible-rect/nested-transform-expected.txt:
- compositing/visible-rect/scrolled-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/mac/compositing/visible-rect/2d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/2d-transformed-expected.txt.
- platform/mac/compositing/visible-rect/3d-transform-style-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transform-style-expected.txt.
- platform/mac/compositing/visible-rect/3d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transformed-expected.txt.
- platform/mac/compositing/visible-rect/animated-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-expected.txt.
- platform/mac/compositing/visible-rect/animated-from-none-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-from-none-expected.txt.
- platform/mac/compositing/visible-rect/clipped-by-viewport-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-by-viewport-expected.txt.
- platform/mac/compositing/visible-rect/clipped-visible-rect-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-visible-rect-expected.txt.
- platform/mac/compositing/visible-rect/flipped-preserve-3d-expected.txt: Copied from LayoutTests/compositing/visible-rect/flipped-preserve-3d-expected.txt.
- platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt: Copied from LayoutTests/compositing/visible-rect/iframe-and-layers-expected.txt.
- platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/mac/compositing/visible-rect/nested-transform-expected.txt: Copied from LayoutTests/compositing/visible-rect/nested-transform-expected.txt.
- platform/mac/compositing/visible-rect/scrolled-expected.txt: Copied from LayoutTests/compositing/visible-rect/scrolled-expected.txt.
- 11:10 AM Changeset in webkit [155976] by
-
- 5 edits2 adds in trunk
AX: Expose ARIA Busy Notifications
https://bugs.webkit.org/show_bug.cgi?id=121451
Patch by Samuel White <Samuel White> on 2013-09-17
Reviewed by Darin Adler.
Source/WebCore:
Added AXElementBusyChanged notification that posts when aria-busy is toggled. This
enables screen readers to detect busy states without polling the focused element.
Test: platform/mac/accessibility/element-busy-changed.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChanged):
- accessibility/AXObjectCache.h:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
Added test to verify that elements post AXElementBusyChanged notifications when aria-busy is toggled.
- platform/mac/accessibility/element-busy-changed-expected.txt: Added.
- platform/mac/accessibility/element-busy-changed.html: Added.
- 11:10 AM Changeset in webkit [155975] by
-
- 12 edits in trunk/Source/WebCore
Add isTextOrBR() and use it
https://bugs.webkit.org/show_bug.cgi?id=121506
Reviewed by Darin Adler.
It is a popular test.
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
- editing/Editor.cpp:
(WebCore::findFirstMarkable):
- editing/TextIterator.cpp:
(WebCore::ignoresContainerClip):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::logicalHeight):
- rendering/InlineIterator.h:
(WebCore::isIteratorTarget):
- rendering/RenderBlock.cpp:
(WebCore::InlineMinMaxIterator::next):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
- rendering/RenderCounter.cpp:
(WebCore::planCounter):
- rendering/RenderObject.h:
(WebCore::RenderObject::isTextOrBR):
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):
- 11:04 AM Changeset in webkit [155974] by
-
- 1 edit2 adds in trunk/LayoutTests
[CSS Regions] Layout Test for selection direction
https://bugs.webkit.org/show_bug.cgi?id=121501
Reviewed by Darin Adler.
Selection follows DOM tree, so the highlighted text in this test case is
the opposite to what the user is actually selecting. This was not
working properly from r139197 to r155058, so adding a Layout Test to
prevent future breaks. It is a reftest comparing regions and absolute
positions behavior.
- fast/regions/selection-direction-expected.html: Added.
- fast/regions/selection-direction.html: Added.
- 10:56 AM Changeset in webkit [155973] by
-
- 2 edits in trunk/Tools
Fix a typo.
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
- 10:40 AM Changeset in webkit [155972] by
-
- 2 edits in trunk/Source/WebCore
RenderBR should not be RenderText
https://bugs.webkit.org/show_bug.cgi?id=121221
Rubber-stamped by Andreas Kling.
Fix assertion in these tests:
fast/repaint/selection-rl.html
fast/writing-mode/horizontal-bt-replaced-selection.html
fast/writing-mode/vertical-rl-replaced-selection.html
- rendering/InlineBox.cpp:
(WebCore::InlineBox::nodeAtPoint):
- 10:20 AM Changeset in webkit [155971] by
-
- 31 edits in trunk/Source
Remove unused function didSetSelectionTypesForPasteboard from EditorClient.
https://bugs.webkit.org/show_bug.cgi?id=121464
Reviewed by Darin Adler.
Source/WebCore:
This method was only implemented in WebEditorClient.mm for Mac where it was
calling a private delegate that is no longer in use.
This patch removes it for all the platforms.
I've also removed setTypes and writeAfterSettingTypes from the implementation
of the Pasteboard class for Mac.
- editing/mac/EditorMac.mm:
(WebCore::Editor::writeSelectionToPasteboard): Now calls write instead of
setTypes and writeAfterSettingTypes.
- loader/EmptyClients.h: Removed didSetSelectionTypesForPasteboard.
- page/EditorClient.h: Ditto.
- platform/Pasteboard.h: Removed setTypes and writeAfterSettingTypes.
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::writeSelection): Removed call to didSetSelectionTypesForPasteboard.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::write): Added to replace setTypes and writeAfterSettingTypes.
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.cpp:
- WebCoreSupport/EditorClientEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp:
- WebCoreSupport/EditorClientGtk.h:
Source/WebKit/mac:
This method was only implemented in WebEditorClient.mm for Mac where it was
calling a private delegate that is no longer in use.
- DefaultDelegates/WebDefaultEditingDelegate.m:
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
- WebView/WebEditingDelegatePrivate.h:
Source/WebKit/qt:
- WebCoreSupport/EditorClientQt.cpp:
- WebCoreSupport/EditorClientQt.h:
Source/WebKit/win:
- WebCoreSupport/WebEditorClient.cpp:
- WebCoreSupport/WebEditorClient.h:
Source/WebKit/wince:
- WebCoreSupport/EditorClientWinCE.cpp:
- WebCoreSupport/EditorClientWinCE.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.h:
- 10:17 AM Changeset in webkit [155970] by
-
- 6 edits in trunk/Source/WebCore
Further shrink table-populating code by making the tables read-only data and preventing inlining
https://bugs.webkit.org/show_bug.cgi?id=121468
Reviewed by Sam Weinig.
- bindings/scripts/StaticString.pm:
(GenerateStrings): Eliminated the xxxImpl globals. We definitely did not need
globals for these, much less read-write data. Instead, write the expression at
each site where we need them.
(GenerateStringAsserts): This is one such site (see above).
- css/CSSSelector.cpp:
(WebCore::populatePseudoTypeByNameMap): Mark this function NEVER_INLINE and
add static to make sure the table ends up in read-only data.
- dom/make_names.pl:
(printDefinitions): Write the xxxImpl expression (see above).
(printFactoryCppFile): Ditto. Also mark the populate function NEVER_INLINE and
add static to make sure the table ends up in read-only data.
(printWrapperFactoryCppFile): Ditto.
- html/HTMLElement.cpp:
(WebCore::populateEventNameForAttributeLocalNameMap): Mark this function
NEVER_INLINE and add static to makes sure the table ends up in read-only data.
- platform/text/UnicodeRange.cpp: Added a const to make this read-only data.
- 10:13 AM Changeset in webkit [155969] by
-
- 2 edits in trunk/Source/WebCore
Shrink SVGElement::cssPropertyIdForSVGAttributeName and cssPropertyToTypeMap
https://bugs.webkit.org/show_bug.cgi?id=121499
Reviewed by Andreas Kling.
- svg/SVGElement.cpp:
(WebCore::populateAttributeNameToCSSPropertyIDMap): Added. Code that used to
be in SVGElement::cssPropertyIdForSVGAttributeName to build a map that maps
attribute names to CSS property IDs, but without the multiple unrolled calls
to HashMap functions.
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap): Added. Code that
used to be in cssPropertyToTypeMap, but without the multiple unrolled calls
to HashMap functions.
(WebCore::attributeNameToAnimatedPropertyTypeMap): Renamed from
cssPropertyToTypeMap, a confusingly inaccurate and imprecise name, and
reimplemented using the populate function.
(WebCore::SVGElement::animatedPropertyTypeForAttribute): Updated to call
attributeNameToAnimatedPropertyTypeMap, and also removed the double hashing
that was done by calling contains followed by get.
(WebCore::SVGElement::cssPropertyIdForSVGAttributeName): Rewrote to use
populateAttributeNameToCSSPropertyIDMap.
(WebCore::SVGElement::isAnimatableCSSProperty): Updated to call the new
attributeNameToAnimatedPropertyTypeMap.
- 10:09 AM Changeset in webkit [155968] by
-
- 5 edits in trunk/Source
Make SVGTransform::valueAsString use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=121498
Reviewed by Andreas Kling.
Source/WebCore:
- svg/SVGTransform.cpp:
(WebCore::SVGTransform::valueAsString): Use StringBuilder constently to
avoid creating temporary String objects that cause additional, slow
memory allocation.
Source/WTF:
- wtf/text/StringBuilder.cpp: Added appendNumber functions corresponding to all remaining
String::number functions. If we find we don't need all of these we can delete them later,
but I don't want to give clients a reason to prefer less-efficient API to StringBuilder.
- wtf/text/StringBuilder.h: Ditto.
- 10:07 AM Changeset in webkit [155967] by
-
- 3 edits in trunk/Source/WebCore
Get rid of a couple unneeded NeverDestroyed::get() calls
https://bugs.webkit.org/show_bug.cgi?id=121500
Reviewed by Andreas Kling.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::parsePseudoType): No need to call get() here.
- dom/make_names.pl:
(printFactoryCppFile): Ditto.
(printWrapperFactoryCppFile): Ditto.
- 10:04 AM Changeset in webkit [155966] by
-
- 3 edits in trunk/Source/WebInspectorUI
Clean up the Inspector's WebSocket code and prevent it from dropping messages.
https://bugs.webkit.org/show_bug.cgi?id=121391
Reviewed by Joseph Pecoraro.
- UserInterface/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.initializeWebSocket): Added. Create the socket
and call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend): Store messages as pending
if the socket isn't ready yet. Call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype._sendPendingMessagesToBackendIfNeeded): Added.
- UserInterface/Main.js:
(WebInspector._initializeWebSocketIfNeeded): Move socket creation to initializeWebSocket.
- 9:46 AM Changeset in webkit [155965] by
-
- 3 edits2 adds in trunk
Bad ASSERT() in RasterShapeIntervals::firstIncludedIntervalY()
https://bugs.webkit.org/show_bug.cgi?id=121455
Reviewed by Darin Adler.
Source/WebCore:
Corrected a bad ASSERT() introduced in https://bugs.webkit.org/show_bug.cgi?id=120211.
Test: fast/shapes/shape-inside/shape-inside-first-fit-crash.html
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShapeIntervals::firstIncludedIntervalY):
LayoutTests:
Simple regression test, it crashes in the bad ASSERT().
- fast/shapes/shape-inside/shape-inside-first-fit-crash-expected.txt: Added.
- fast/shapes/shape-inside/shape-inside-first-fit-crash.html: Added.
- 9:41 AM Changeset in webkit [155964] by
-
- 7 edits in trunk/Source/WebCore
Move the line widow functions out of RenderBlock and into RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=121456
Reviewed by Dean Jackson.
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::calculateMinimumPageHeight):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::setBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::relayoutToAvoidWidows):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::shouldBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::lineBreakToAvoidWidow):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
- rendering/RenderObject.h:
- 9:26 AM Changeset in webkit [155963] by
-
- 14 edits in trunk
HashMap should work with move-only keys
https://bugs.webkit.org/show_bug.cgi?id=121310
Reviewed by Darin Adler.
Source/WebCore:
Update the call sites now that HashMap::take doesn't return a PassOwnPtr.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::takeRenderBoxRegionInfo):
- rendering/RenderRegion.h:
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::removePendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForRemoval):
- svg/SVGDocumentExtensions.h:
Source/WTF:
Add extra overloads for add and set where the key is an rvalue reference, but not a
template parameter rvalue reference. This way we'll coerce the key parameter to have the expected
type instead of the passed in type, causing map.add(StringImpl::create("Hello"), 123) work when the
type of map is HashMap<String, unsigned>.
Also, sprinkle && and std::forward where appropriate.
- wtf/HashMap.h:
- wtf/HashTable.h:
Tools:
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
Add test.
- 9:00 AM Changeset in webkit [155962] by
-
- 4 edits in trunk/Source/WebCore
Add RenderObject bit for isBR().
https://bugs.webkit.org/show_bug.cgi?id=121494
Reviewed by Andreas Kling.
It is no longer piggybacking on isText() flag and is now hot in inline layout.
- rendering/RenderBR.cpp:
(WebCore::RenderBR::RenderBR):
- rendering/RenderBR.h:
- rendering/RenderObject.h:
(WebCore::RenderObject::isBR):
(WebCore::RenderObject::setIsBR):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
- 8:54 AM Changeset in webkit [155961] by
-
- 2 edits in trunk/Source/WebCore
Export some missing symbols for Internals after RenderArena& change.
- WebCore.exp.in:
- 8:38 AM Changeset in webkit [155960] by
-
- 3 edits4 adds1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip and rebase tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-17
- platform/qt-wk2/TestExpectations:
- platform/qt-wk2/compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt: Added r155546.
- platform/qt-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added r155607.
- platform/qt-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added r155607.
- platform/qt-wk2/fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt: Added r155546.
- platform/qt-wk2/fast/replaced/border-radius-clip-expected.txt: Removed.
- platform/qt/TestExpectations:
- 8:25 AM Changeset in webkit [155959] by
-
- 12 edits3 adds in trunk
Set MessageEvent.source to the newly created port for shared workers' connect events
https://bugs.webkit.org/show_bug.cgi?id=121390
Reviewed by Darin Adler.
Source/WebCore:
Set MessageEvent.source to the newly created port for shared workers' connect events
instead of previously null, as per the latest specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html#dom-messageevent-source
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#dom-sharedworker
This behavior is consisent with Blink.
Test: fast/workers/shared-worker-messageevent-source.html
- dom/EventTarget.cpp:
(WebCore::EventTarget::isMessagePort):
- dom/EventTarget.h:
- dom/MessageEvent.cpp:
(WebCore::isValidSource):
(WebCore::MessageEvent::MessageEvent):
- dom/MessageEvent.h:
Use null String instead of an empty String as default value for origin and lastEventId.
This is more efficient and has no impact on the behavior on the JavaScript since a
null String is exposed as an empty one on JS side.
This change is covered by fast/events/constructors/message-event-constructor.html
- dom/MessageEvent.idl:
- dom/MessagePort.h:
- page/DOMWindow.cpp:
(WebCore::PostMessageTimer::event):
- workers/SharedWorkerGlobalScope.cpp:
(WebCore::createConnectEvent):
LayoutTests:
Add layout test to check that MessageEvent.source is set to the newly created port
for shared workers' connect events.
- fast/events/constructors/message-event-constructor-expected.txt:
- fast/events/constructors/message-event-constructor.html:
- fast/workers/resources/messageevent-source.js: Added.
(onconnect):
- fast/workers/shared-worker-messageevent-source-expected.txt: Added.
- fast/workers/shared-worker-messageevent-source.html: Added.
- 8:18 AM Changeset in webkit [155958] by
-
- 2 edits in trunk/Source/WTF
Fix Windows CE build on ARM.
https://bugs.webkit.org/show_bug.cgi?id=121490
Patch by Sergio Martins <sergio.martins@kdab.com> on 2013-09-17
Reviewed by Darin Adler.
- wtf/dtoa/utils.h:
- 8:13 AM Changeset in webkit [155957] by
-
- 36 edits in trunk
RenderBR should not be RenderText
https://bugs.webkit.org/show_bug.cgi?id=121221
Reviewed by Darin Adler.
Source/WebCore:
Stop inheriting RenderBR from RenderText and make it be a RenderBoxModelObject instead. RenderBR was one
of the few cases where Element renderer was a RenderText. This will enable future cleanups.
RenderBR used little of RenderText mechanisms and was already heavily specialized everywhere. Layout code
didn't care about its text content at all. The new RenderText is also significatly more lightweight
than the old. As a line box it uses plain InlineBox instead of InlineTextBox.
The patch tries to avoid changing test results though there are a few changed render tree dumps without
visual effect. There are also two rendering progressions.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getUpperLeftCorner):
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
- dom/Position.cpp:
(WebCore::hasInlineBoxWrapper):
(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
(WebCore::Position::getInlineBoxAndOffset):
- dom/Range.cpp:
(WebCore::Range::textRects):
(WebCore::Range::textQuads):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
- editing/Editor.cpp:
(WebCore::findFirstMarkable):
- editing/TextIterator.cpp:
(WebCore::ignoresContainerClip):
- editing/VisibleUnits.cpp:
(WebCore::CachedLogicallyOrderedLeafBoxes::previousTextOrLineBreakBox):
(WebCore::CachedLogicallyOrderedLeafBoxes::nextTextOrLineBreakBox):
(WebCore::logicallyPreviousBox):
(WebCore::logicallyNextBox):
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
(WebCore::InlineBox::deleteLine):
(WebCore::InlineBox::extractLine):
(WebCore::InlineBox::attachLine):
(WebCore::InlineBox::paint):
- rendering/InlineBox.h:
(WebCore::InlineBox::isLineBreak):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeOverflow):
- rendering/InlineIterator.h:
(WebCore::isIteratorTarget):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::lineHeight):
(WebCore::InlineTextBox::isLineBreak):
- rendering/RenderBR.cpp:
(WebCore::RenderBR::RenderBR):
(WebCore::RenderBR::~RenderBR):
(WebCore::RenderBR::createAnonymous):
(WebCore::RenderBR::lineHeight):
(WebCore::RenderBR::baselinePosition):
(WebCore::RenderBR::createInlineBox):
(WebCore::RenderBR::setInlineBoxWrapper):
(WebCore::RenderBR::replaceInlineBoxWrapper):
(WebCore::RenderBR::deleteInlineBoxWrapper):
(WebCore::RenderBR::dirtyLineBoxes):
(WebCore::RenderBR::caretMinOffset):
(WebCore::RenderBR::caretMaxOffset):
(WebCore::RenderBR::canBeSelectionLeaf):
(WebCore::RenderBR::setSelectionState):
(WebCore::RenderBR::localCaretRect):
(WebCore::RenderBR::linesBoundingBox):
(WebCore::RenderBR::absoluteRects):
(WebCore::RenderBR::absoluteQuads):
(WebCore::RenderBR::updateFromStyle):
(WebCore::RenderBR::borderBoundingBox):
- rendering/RenderBR.h:
(WebCore::toRenderBR):
- rendering/RenderBlock.cpp:
(WebCore::InlineMinMaxIterator::next):
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::createInlineBoxForRenderer):
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::reachedEndOfTextRenderer):
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::requiresLineBox):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::canBreakAtThisPosition):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
(WebCore::RenderInline::dirtyLineBoxes):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::styleDidChange):
(WebCore::RenderMenuList::setText):
(WebCore::RenderMenuList::text):
- rendering/RenderMenuList.h:
- rendering/RenderObject.h:
(WebCore::RenderObject::isBeforeContent):
(WebCore::RenderObject::isAfterContent):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
- rendering/RenderText.cpp:
(WebCore::RenderText::removeAndDestroyTextBoxes):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::setTextInternal):
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):
LayoutTests:
- editing/selection/move-by-word-visually-mac-expected.txt:
This is a progression. A previously failing subtest passes.
- platform/mac/css3/selectors3/html/css3-modsel-179a-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-179a-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-179a-expected.txt:
Changes in render tree dump that don't affect rendering.
- platform/mac/fast/css/pseudo-first-line-border-width-expected.txt:
This is a progression. The new rendering matches Firefox.
- platform/mac/fast/css/word-space-extra-expected.txt:
- platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
Changes in render tree dump that don't affect rendering.
- 8:10 AM Changeset in webkit [155956] by
-
- 2 edits in trunk/Source/WebKit2
Buildfix for !(ENABLE(WEB_ARCHIVE) ENABLE(MHTML)) platforms https://bugs.webkit.org/show_bug.cgi?id=121491
Reviewed by Darin Adler.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
- 7:57 AM Changeset in webkit [155955] by
-
- 12 edits in trunk/Source/WebCore
Dodge more work during render tree teardown.
<https://webkit.org/b/121487>
Reviewed by Antti Koivisto.
Add a Document::hasLivingRenderTree() method that returns true if
there's a render tree attached to the document and it's not in the
process of being torn down.
Deploy this check in a number of places that were only checking
for the presence of a RenderView.
- 7:52 AM Changeset in webkit [155954] by
-
- 9 edits in trunk
MediaStream API: Adding an async RTCPeerConnection::addIceCandidate
https://bugs.webkit.org/show_bug.cgi?id=121403
Source/WebCore:
Merged from https://chromium.googlesource.com/chromium/blink/+/5bd81fda88d48dd2780832246e7d1ab973ee7a1d
Reviewed by Darin Adler.
No new tests, updated RTCPeerConnection-ice.html.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addIceCandidate): Add success and error callbacks.
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/RTCPeerConnection.idl:
- platform/mediastream/RTCPeerConnectionHandler.h: Changed addIceCandidate signature.
- platform/mediastream/RTCVoidRequest.h: Removed ExtraData, it is unnecessary.
LayoutTests:
Reviewed by Darin Adler.
- fast/mediastream/RTCPeerConnection-ice-expected.txt:
- fast/mediastream/RTCPeerConnection-ice.html:
- 6:44 AM Changeset in webkit [155953] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Unreviewed make distcheck fix.
- GNUmakefile.am: include WebProcess/Network/*.in in the tarball,
it's needed for generating WebResourceLoaderMessage*.{cpp,h}.
- 6:38 AM Changeset in webkit [155952] by
-
- 8 edits in trunk/Source/WebCore
[GTK] Do not include Returns tag in api doc for methods returning void
https://bugs.webkit.org/show_bug.cgi?id=121488
Reviewed by Philippe Normand.
- bindings/gobject/WebKitDOMCustom.h:
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction): Only add Returns tag for methods not returning
void.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
- 6:24 AM Changeset in webkit [155951] by
-
- 2 edits in trunk/Source/WebCore
Correct range used for Emoji checks.
https://bugs.webkit.org/show_bug.cgi?id=121486
Reviewed by Allan Sandfeld Jensen.
Found and reported by David Binderman via Qt bug tracker.
The check if a character was in the Emoji range always evaluated to
false due to the upper range limit being lower than the lower limit.
Changed the upper limit to the highest assigned character from the
"Transport and Map Symbols" (0x1F6C5) as that seems to have been the
intended upper range limit of this check.
- platform/graphics/Font.cpp:
(WebCore::Font::isCJKIdeographOrSymbol):
- 5:40 AM Changeset in webkit [155950] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r155910): WebKit nightly builds don't load any page
https://bugs.webkit.org/show_bug.cgi?id=121482
Reviewed by Andreas Kling.
Replaced C++ style comments with C style comments.
- wtf/Platform.h:
- 5:33 AM Changeset in webkit [155949] by
-
- 4 edits in trunk/Source/WebCore
Move text caret rect computation to root inline box
https://bugs.webkit.org/show_bug.cgi?id=121479
Reviewed by Andreas Kling.
For future code sharing.
- rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::computeCaretRect):
- rendering/RootInlineBox.h:
- 5:17 AM Changeset in webkit [155948] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Don't make the GObject DOM bindings API break test fatal
https://bugs.webkit.org/show_bug.cgi?id=121484
Reviewed by Carlos Garcia Campos.
The API varies depending on the compilation options, so this can
easily produce false positives.
Until we figure out a way to handle this situation we shouldn't
make this test fatal.
- bindings/scripts/gobject-run-api-break-test:
(check_api):
- 5:05 AM Changeset in webkit [155947] by
-
- 1 edit2 adds in trunk/LayoutTests
[CSSRegions] Flowed fixed element without its transformed parent positioned relative to viewport
https://bugs.webkit.org/show_bug.cgi?id=121478
Reviewed by Antti Koivisto.
A fixed positioned element collected into a named flow without its transformed parent should be positioned relative to the viewport instead of the transformed parent. Add a test for this behavior.
- fast/regions/flow-fixed-element-transformed-parent-expected.txt: Added.
- fast/regions/flow-fixed-element-transformed-parent.html: Added.
- 5:02 AM Changeset in webkit [155946] by
-
- 2 edits in trunk/Source/WebCore
[CSSRegions] Replace generatingNode() with generatingElement() for RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=121469
Reviewed by Antti Koivisto.
The fix for https://bugs.webkit.org/show_bug.cgi?id=120397 replaced node() with generatingElement() for regions, but i forgot about replacing generatingNode() with generatingElement() in RenderNamedFlowThread::compareRenderRegions. This is needed in preparation for regions as anonymous blocks refactoring in https://bugs.webkit.org/show_bug.cgi?id=119135.
No new functionality introduced, therefore no new tests.
- rendering/RenderNamedFlowThread.cpp:
(WebCore::compareRenderRegions):
- 4:58 AM Changeset in webkit [155945] by
-
- 2 edits in trunk/Tools
BrowserMarshal.h build fail
https://bugs.webkit.org/show_bug.cgi?id=102938
Patch by YuTeh Shen <shenyute@hotmail.com> on 2013-09-17
Reviewed by Carlos Garcia Campos.
Fix variable name.
- MiniBrowser/gtk/GNUmakefile.am:
- 4:05 AM Changeset in webkit [155944] by
-
- 35 edits in trunk/Source/WebCore
CTTE: Pass RenderArena around by reference.
<https://webkit.org/b/121470>
Reviewed by Antti Koivisto.
Pass the RenderArena around by reference in all render tree code.
This code will never be running without an arena.
- 3:24 AM Changeset in webkit [155943] by
-
- 3 edits in trunk/Source/WebCore
[GTK] GObject DOM symbols file is not generated for video related classes
https://bugs.webkit.org/show_bug.cgi?id=121476
Reviewed by Philippe Normand.
The problem is that we are using a different path for video
related header files in the Makefile, it's the same path in
practice, because we are just prepending ./ to the path, but the
rules that parse those paths don't expect the ./ at the beginning.
- bindings/gobject/GNUmakefile.am: Use the same path for video
related header files as the other paths in
webkitgtk_gdom_built_h_api.
- bindings/gobject/webkitdom.symbols: Updated to include the
symbols of the video related clases.
- 2:47 AM Changeset in webkit [155942] by
-
- 3 edits in trunk/Source/WebKit2
[GTK][EFL] Add ResourceError::internalError() after r138387
https://bugs.webkit.org/show_bug.cgi?id=121433
Reviewed by Christophe Dumez.
Original patch by Balazs Kelemen <kbalazs@webkit.org>
and Kwang Yul Seo <skyul@company100.net>
- WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
(WebKit::internalError):
- WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:
(WebKit::internalError):
- 2:44 AM Changeset in webkit [155941] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed make distcheck fix.
- GNUmakefile.list.am:
- 2:38 AM Changeset in webkit [155940] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests.
- platform/qt-wk1/TestExpectations:
- 2:32 AM Changeset in webkit [155939] by
-
- 2 edits in trunk/Source/WebKit
Some build juice for Windows.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 2:27 AM Changeset in webkit [155938] by
-
- 16 edits2 deletes in trunk/Source/WebCore
Remove ContextFeatures.
<https://webkit.org/b/121473>
Reviewed by Antti Koivisto.
This was only used by the chromium port, nobody implements ContextFeaturesClient.
- 1:53 AM Changeset in webkit [155937] by
-
- 2 edits in trunk/Source/WebCore
Un-dork the build. :|
- 1:44 AM Changeset in webkit [155936] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix clang warning when building without ENABLE(STYLE_SCOPED).
- 1:39 AM Changeset in webkit [155935] by
-
- 7 edits in trunk/Source/WebKit2
Fix Qt WK2 build after r155888
https://bugs.webkit.org/show_bug.cgi?id=121471
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-17
Reviewed by Csaba Osztrogonác.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::createDrawingAreaProxy):
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebViewPrivate::createDrawingAreaProxy):
- UIProcess/API/qt/raw/qrawwebview_p_p.h:
- UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::createDrawingAreaProxy):
- UIProcess/qt/QtPageClient.h:
- 1:22 AM Changeset in webkit [155934] by
-
- 6 edits in trunk/Source/WebKit2
[GTK][EFL] Add NetworkProcess support for ProcessLauncher
https://bugs.webkit.org/show_bug.cgi?id=121434
Reviewed by Sam Weinig.
Original patch by Balazs Kelemen <kbalazs@webkit.org>
and Kwang Yul Seo <skyul@company100.net>
- Shared/ProcessExecutablePath.h:
- Shared/efl/ProcessExecutablePathEfl.cpp:
(WebKit::executablePathOfNetworkProcess):
- Shared/gtk/ProcessExecutablePathGtk.cpp:
(WebKit::executablePathOfNetworkProcess):
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
- 1:20 AM Changeset in webkit [155933] by
-
- 5 edits in trunk/Source/WebKit2
Buildfix for !USE(PROTECTION_SPACE_AUTH_CALLBACK) platforms
https://bugs.webkit.org/show_bug.cgi?id=121431
Reviewed by Alexey Proskuryakov.
Mising guards added.
Original patch by Balazs Kelemen <kbalazs@webkit.org>
and Kwang Yul Seo <skyul@company100.net>
- NetworkProcess/NetworkResourceLoader.messages.in:
- WebProcess/Network/WebResourceLoader.cpp:
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- 1:18 AM Changeset in webkit [155932] by
-
- 6 edits in trunk/Source/WebKit2
WebResourceLoader.messages.in should be ENABLE(NETWORK_PROCESS) guarded
https://bugs.webkit.org/show_bug.cgi?id=121424
Reviewed by Alexey Proskuryakov.
Original patch by Balazs Kelemen <kbalazs@webkit.org>.
- CMakeLists.txt:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebProcess/Network/WebResourceLoader.messages.in: ENABLE(NETWORK_PROCESS) guard added.
- 1:13 AM Changeset in webkit [155931] by
-
- 9 edits in trunk/Source/WebCore
Move <style scoped> code behind ENABLE(STYLE_SCOPED)
<https://webkit.org/b/121018>
Reviewed by Darin Adler.
Move all the code for <style scoped> behind ENABLE(STYLE_SCOPED) guards.
It's not nice to clutter common codepaths with code that always executes
even though the feature is disabled at compile-time.
- 12:01 AM Changeset in webkit [155930] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, fixing the GTK WK2 debug build after r155911.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp: Add missing using
namespace WebCore.
