Timeline
Oct 28, 2013:
- 10:18 PM Changeset in webkit [158181] by
-
- 5 edits in trunk/Source/WebCore
applyTextTransform() should take a const RenderStyle&.
<https://webkit.org/b/123434>
This function is always called with an existing RenderStyle object.
Reviewed by Anders Carlsson.
- 10:14 PM Changeset in webkit [158180] by
-
- 19 edits in trunk/Source/WebCore
RenderSVGResource::applyResource() should take a const RenderStyle&.
<https://webkit.org/b/123433>
These functions are always called with an existing RenderStyle object
so let them take a const reference instead of a raw pointer.
Also sprinkled some missing OVERRIDEs.
Reviewed by Anders Carlsson.
- 10:13 PM Changeset in webkit [158179] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix bug URL in ChangeLog.
- 10:09 PM Changeset in webkit [158178] by
-
- 6 edits in trunk/Source/WebCore
Remove unused RenderTextControl::textBaseStyle().
<https://webkit.org/b/123423>
Reviewed by Anders Carlsson.
- 9:42 PM Changeset in webkit [158177] by
-
- 2 edits in trunk/LayoutTests
Fix path for xss-DENIED-xsl-document-redirect test, and mark
editing/selection/5057506-2.html as image-only failure.
- platform/mac-wk2/TestExpectations:
- 9:38 PM Changeset in webkit [158176] by
-
- 2 edits in trunk/Tools
Floating left the header broke other pages, and this CSS has no way to customize
per-page.
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
- 9:34 PM Changeset in webkit [158175] by
-
- 2 edits in trunk/Tools
Remove underlines on the bot names in the header.
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(td.LastBuild a):
- 9:33 PM Changeset in webkit [158174] by
-
- 3 edits1 add in trunk/Tools
Add EFL release bots to the buildbot dashboard
https://bugs.webkit.org/show_bug.cgi?id=123430
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): add 64 bits release wk2 and wk1 testers and 32 bits release builder.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.linux-efl img.logo): use the EFL logo in its dashboard line.
- 9:32 PM Changeset in webkit [158173] by
-
- 2 edits in trunk/Tools
More waterfall tweaking.
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(body > .header):
(td.LastBuild):
(td.LastBuild a):
(td.LastBuild,td.Activity a,td.Change a,td.Builder a):
- 9:27 PM Changeset in webkit [158172] by
-
- 2 edits in trunk/Tools
More waterfall tweaking.
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(body.interface):
(body > hr):
(div.content h1):
(body > .header):
(td.Activity a,td.Change a,td.Builder a):
(td.Builder):
- 9:20 PM Changeset in webkit [158171] by
-
- 51 edits in trunk/Source/WebCore
HTML input type objects should be managed through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=123160
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-10-28
Reviewed by Darin Adler.
Make the constructors of the InputType subclasses public. This makes it possible to use std::make_unique on these classes
and makes the T::create() helpers redundant. New instances of these classes are now managed through std::unique_ptr.
InputType::create() now uses a NeverDestroyed InputTypeFactoryMap that maps type names to InputTypeFactoryFunctions and
gets populated when the method is first called and the map is still empty. Certain types are not added to the factory map
if they're disabled at runtime.
The factory is used to create the new InputType object if the requested type was found in the map, and TextInputType is used otherwise.
- html/ButtonInputType.cpp:
- html/ButtonInputType.h:
(WebCore::ButtonInputType::ButtonInputType):
- html/CheckboxInputType.cpp:
- html/CheckboxInputType.h:
(WebCore::CheckboxInputType::CheckboxInputType):
- html/ColorInputType.cpp:
- html/ColorInputType.h:
(WebCore::ColorInputType::ColorInputType):
- html/DateInputType.cpp:
- html/DateInputType.h:
- html/DateTimeInputType.cpp:
- html/DateTimeInputType.h:
(WebCore::DateTimeInputType::DateTimeInputType):
- html/DateTimeLocalInputType.cpp:
- html/DateTimeLocalInputType.h:
(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
- html/EmailInputType.cpp:
- html/EmailInputType.h:
(WebCore::EmailInputType::EmailInputType):
- html/FileInputType.cpp:
- html/FileInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
- html/HTMLInputElement.h:
- html/HiddenInputType.cpp:
- html/HiddenInputType.h:
(WebCore::HiddenInputType::HiddenInputType):
- html/ImageInputType.cpp:
(WebCore::ImageInputType::ImageInputType):
- html/ImageInputType.h:
- html/InputType.cpp:
(WebCore::createInputType): A templated helper that constructs a new InputType subclass object through std::make_unique.
(WebCore::populateInputTypeFactoryMap): Populates the passed-in map with type-createInputType<T> pairs.
(WebCore::InputType::create): Get the InputTypeFactoryFunction for the specified type, or fall back to TextInputType.
(WebCore::InputType::createText):
- html/InputType.h:
- html/MonthInputType.cpp:
- html/MonthInputType.h:
(WebCore::MonthInputType::MonthInputType):
- html/NumberInputType.cpp:
- html/NumberInputType.h:
(WebCore::NumberInputType::NumberInputType):
- html/PasswordInputType.cpp:
- html/PasswordInputType.h:
(WebCore::PasswordInputType::PasswordInputType):
- html/RadioInputType.cpp:
- html/RadioInputType.h:
(WebCore::RadioInputType::RadioInputType):
- html/RangeInputType.cpp:
- html/RangeInputType.h:
- html/ResetInputType.cpp:
- html/ResetInputType.h:
(WebCore::ResetInputType::ResetInputType):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::SearchInputType):
- html/SearchInputType.h:
- html/SubmitInputType.cpp:
- html/SubmitInputType.h:
(WebCore::SubmitInputType::SubmitInputType):
- html/TelephoneInputType.cpp:
- html/TelephoneInputType.h:
(WebCore::TelephoneInputType::TelephoneInputType):
- html/TextInputType.cpp:
- html/TextInputType.h:
(WebCore::TextInputType::TextInputType):
- html/TimeInputType.cpp:
- html/TimeInputType.h:
- html/URLInputType.cpp:
- html/URLInputType.h:
(WebCore::URLInputType::URLInputType):
- html/WeekInputType.cpp:
- html/WeekInputType.h:
(WebCore::WeekInputType::WeekInputType):
- 9:19 PM Changeset in webkit [158170] by
-
- 24 edits in trunk/Source
Refactor IDB factory creation.
https://bugs.webkit.org/show_bug.cgi?id=123347
Reviewed by Andreas Kling.
- Rework how database directory location is passed around.
- Make (some) SecurityOrigin arguments be references instead of pointers.
- Add two SecurityOrigin arguments to opening databases for future use.
Source/WebCore:
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal):
- Modules/indexeddb/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create):
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/PageGroupIndexedDatabase.cpp:
(WebCore::PageGroupIndexedDatabase::PageGroupIndexedDatabase):
(WebCore::PageGroupIndexedDatabase::from):
(WebCore::PageGroupIndexedDatabase::factoryBackend):
- Modules/indexeddb/PageGroupIndexedDatabase.h:
- Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp:
(WebCore::WorkerGlobalScopeIndexedDatabase::WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::from):
(WebCore::WorkerGlobalScopeIndexedDatabase::indexedDB):
- Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::open):
(WebCore::IDBBackingStoreLevelDB::openInMemory):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::computeFileIdentifier):
(WebCore::computeUniqueIdentifier):
(WebCore::IDBFactoryBackendLevelDB::IDBFactoryBackendLevelDB):
(WebCore::IDBFactoryBackendLevelDB::getDatabaseNames):
(WebCore::IDBFactoryBackendLevelDB::deleteDatabase):
(WebCore::IDBFactoryBackendLevelDB::openBackingStore):
(WebCore::IDBFactoryBackendLevelDB::open):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
(WebCore::IDBFactoryBackendLevelDB::create):
- WebCore.exp.in:
- platform/DatabaseStrategy.cpp:
(WebCore::DatabaseStrategy::createIDBFactoryBackend):
- platform/DatabaseStrategy.h:
Source/WebKit2:
- Shared/Databases/IndexedDB/IDBUtilities.cpp:
(WebKit::uniqueDatabaseIdentifier):
- Shared/Databases/IndexedDB/IDBUtilities.h:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::open):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
(WebKit::WebIDBFactoryBackend::create):
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:
(WebKit::WebProcessIDBDatabaseBackend::WebProcessIDBDatabaseBackend):
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createIDBFactoryBackend):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 9:16 PM Changeset in webkit [158169] by
-
- 3 edits in trunk/Tools
Apply changes to default.css, revert buildbot.css which seems to be unused.
- BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
(body):
(body, td):
(a:link,a:visited,a:active):
(td.Time):
(td.Activity):
(.exception, td.offline):
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(body.interface):
(.auth):
(td.LastBuild):
(td.Time):
(td.Activity):
(.offline,td.offline,.retry):
- 9:03 PM Changeset in webkit [158168] by
-
- 2 edits in trunk/Tools
Prettify the waterfall page, and make it a little more space-efficient.
- BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
(body, td):
(body.interface):
(.auth):
(.header):
(div.content h1):
(a):
(a:link,a:active):
(a:link,a:visited,a:active):
(td.LastBuild):
(td.Time):
(td.Activity):
(.exception, td.offline, .retry):
- 8:29 PM Changeset in webkit [158167] by
-
- 2 edits in trunk/Tools
Fix Lion readableName (spotted by Dan Bernstein).
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
- 8:18 PM Changeset in webkit [158166] by
-
- 5 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r157561. <rdar://problem/15292382>
- 8:10 PM Changeset in webkit [158165] by
-
- 4 edits2 copies in branches/safari-537.73-branch
Merged r157298. <rdar://problem/15292359>
- 8:05 PM Changeset in webkit [158164] by
-
- 4 edits4 copies in branches/safari-537.73-branch
Merged r155554. <rdar://problem/15292361>
- 7:58 PM Changeset in webkit [158163] by
-
- 260 edits in trunk/Source
RenderElement::style() should return a reference.
<https://webkit.org/b/123414>
Now that renderers always have style, go ahead and make style()
return a RenderStyle&.
There are countless opportunities for further cleanup enabled by
this change. I'm simply passing &style() in many cases where we
can really do something nicer instead.
Reviewed by Anders Carlsson.
- 7:52 PM Changeset in webkit [158162] by
-
- 7 edits2 copies in branches/safari-537.73-branch
Merged r155665. <rdar://problem/15109475>
- 7:45 PM Changeset in webkit [158161] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r155664. <rdar://problem/15168243>
- 7:45 PM Changeset in webkit [158160] by
-
- 10 edits in trunk/Source
Make TileController create the appropriate PlatformCALayer subclasses
https://bugs.webkit.org/show_bug.cgi?id=123418
Reviewed by Simon Fraser.
Add PlatformCALayer::createCompatibleLayer, which is overridden in
each of the subclasses to create a PlatformCALayer instance of the same
subclass. This is used in TileController to make bare PlatformCALayers
of the correct type (Mac, Win, or Remote).
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::createCompatibleLayer):
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::createCompatibleLayer):
- platform/graphics/ca/win/PlatformCALayerWin.h:
Add createCompatibleLayer and implement it in the subclasses.
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
(WebCore::TileController::tiledScrollingIndicatorLayer):
(WebCore::TileController::createTileLayer):
Make use of createCompatibleLayer when creating PlatformCALayers.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::createCompatibleLayer):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Add createCompatibleLayer and implement it in the subclasses.
- 7:38 PM Changeset in webkit [158159] by
-
- 13 edits2 adds in trunk
Web Inspector: CSS Regions: Add protocol API to expose content nodes addition/removal
https://bugs.webkit.org/show_bug.cgi?id=123424
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: inspector-protocol/model/content-flow-content-nodes.html
Adding two new inspector-protocol APIs to handle the cases when new elements are
added or removed from a named flow. These APIs will trigger even though there
is no region associated with the named flow.
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didRegisterNamedFlowContentElement):
(WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElementImpl):
(WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElementImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElement):
(WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElement):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
Source/WebInspectorUI:
Exposed the new CSS Agent events to the ContentFlow class that will now maintain
a list of nodes in the "contentNodes" property.
- UserInterface/CSSObserver.js:
(WebInspector.CSSObserver.prototype.regionOversetChanged):
(WebInspector.CSSObserver.prototype.registeredNamedFlowContentElement):
(WebInspector.CSSObserver.prototype.unregisteredNamedFlowContentElement):
- UserInterface/ContentFlow.js:
(WebInspector.ContentFlow):
(WebInspector.ContentFlow.prototype.set overset):
(WebInspector.ContentFlow.prototype.get contentNodes):
(WebInspector.ContentFlow.prototype.insertContentNodeBefore):
(WebInspector.ContentFlow.prototype.appendContentNode):
(WebInspector.ContentFlow.prototype.removeContentNode):
- UserInterface/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype.regionOversetChanged):
(WebInspector.DOMTreeManager.prototype.registeredNamedFlowContentElement):
(WebInspector.DOMTreeManager.prototype.unregisteredNamedFlowContentElement):
- UserInterface/InspectorBackendCommands.js:
LayoutTests:
Added test to check that the two new events are triggered correctly and can be used to maintain
the flow content nodes list on the inspector side.
- inspector-protocol/model/content-flow-content-nodes-expected.txt: Added.
- inspector-protocol/model/content-flow-content-nodes.html: Added.
- 7:37 PM Changeset in webkit [158158] by
-
- 7 edits2 deletes in branches/safari-537.73-branch
rollout r158067.
- 7:13 PM Changeset in webkit [158157] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r156099. <rdar://problem/15168245>
- 7:10 PM Changeset in webkit [158156] by
-
- 4 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r156479. <rdar://problem/15168235>
- 7:07 PM Changeset in webkit [158155] by
-
- 3 edits2 copies in branches/safari-537.73-branch
Merged r156222. <rdar://problem/15168254>
- 7:05 PM Changeset in webkit [158154] by
-
- 3 edits2 copies in branches/safari-537.73-branch
Merged r157231. <rdar://problem/15333294>
- 6:53 PM Changeset in webkit [158153] by
-
- 2 edits in branches/safari-537.73-branch/WebKitLibraries
Merged r157608. <rdar://problem/15323809>
- 6:50 PM Changeset in webkit [158152] by
-
- 2 edits in branches/safari-537.73-branch/Source/WTF
Merged r155717. <rdar://problem/15292366>
- 6:38 PM Changeset in webkit [158151] by
-
- 3 edits in trunk/Tools
Add tooltips to the platform icons in Dashboard
https://bugs.webkit.org/show_bug.cgi?id=123429
Reviewed by Alexey Proskuryakov.
Add a human readable name to Buildbot.Platform entries, and use it to
show a tooltip on the ring image.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady):
- 6:38 PM Changeset in webkit [158150] by
-
- 2 edits in trunk/LayoutTests
Last few Mavericks WK2 failures.
- platform/mac-wk2/TestExpectations:
- 6:34 PM Changeset in webkit [158149] by
-
- 6 edits in branches/safari-537.73-branch
Merged r157830. <rdar://problem/15303898>
- 6:15 PM Changeset in webkit [158148] by
-
- 2 edits in branches/safari-537.73-branch/Source/JavaScriptCore
Debug build correction after r158124.
- runtime/JSObject.h:
(JSC::JSObject::setStructure): Use external hasIndexingHeader function since
the member function did not exist at the time of this branch.
- 5:56 PM Changeset in webkit [158147] by
-
- 1 edit1 delete in trunk/Source/WebCore
Web Inspector: Remove unused inspector/inline-javascript-imports.py
https://bugs.webkit.org/show_bug.cgi?id=123425
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-28
Reviewed by Timothy Hatcher.
- inspector/inline-javascript-imports.py: Removed.
- 5:52 PM Changeset in webkit [158146] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Web Inspector: Remove unused "externs" files and generators
https://bugs.webkit.org/show_bug.cgi?id=123427
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-28
Reviewed by Timothy Hatcher.
- inspector/InjectedScriptExterns.js: Removed.
- inspector/generate_protocol_externs.py: Removed.
- 4:52 PM Changeset in webkit [158145] by
-
- 2 edits in trunk/LayoutTests
Mark some more Mavericks/WK2 tests as failing.
We have no way currently to land new results for just
WK2 on Mavericks.
- platform/mac-wk2/TestExpectations:
- 4:14 PM Changeset in webkit [158144] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 4:13 PM Changeset in webkit [158143] by
-
- 1 copy in tags/Safari-537.60.4
New Tag.
- 3:44 PM Changeset in webkit [158142] by
-
- 2 edits in branches/safari-537.60-branch/WebKitLibraries
Merged r157608. <rdar://problem/15323836>
- 3:32 PM Changeset in webkit [158141] by
-
- 13 edits in trunk/Source/JavaScriptCore
OSRExit::m_watchpointIndex should be in OSRExitCompilationInfo
https://bugs.webkit.org/show_bug.cgi?id=123423
Reviewed by Mark Hahnenberg.
Also enable ExitKind to tell you if it's a watchpoint.
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
- bytecode/ExitKind.h:
(JSC::isWatchpoint):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::appendExitInfo):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompilationInfo.h:
(JSC::DFG::OSRExitCompilationInfo::OSRExitCompilationInfo):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 3:22 PM Changeset in webkit [158140] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebKit/win
Merged r156433. <rdar://problem/15109489>
- 3:20 PM Changeset in webkit [158139] by
-
- 5 edits in branches/safari-537.73-branch/Source
Merged r156416. <rdar://problem/15109488>
- 3:13 PM Changeset in webkit [158138] by
-
- 5 edits in branches/safari-537.73-branch/Source
Merged r156219. <rdar://problem/15109342>
- 3:08 PM Changeset in webkit [158137] by
-
- 19 edits2 adds in trunk/Source
Upstream remaining PLATFORM(IOS) and ENABLE(REMOTE_INSPECTOR) pieces
https://bugs.webkit.org/show_bug.cgi?id=123411
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-28
Reviewed by Timothy Hatcher.
Source/WebCore:
Include an InspectorClient hook for when node searching is enabled / disabled.
- inspector/InspectorClient.h:
(WebCore::InspectorClient::didSetSearchingForNode):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setSearchingForNode):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::didSetSearchingForNode):
- inspector/InspectorOverlay.h:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Upstream iOS node highlighting and view indication.
- WebCoreSupport/WebInspectorClient.h:
- WebInspector/WebInspector.h:
- WebInspector/WebInspector.mm:
- WebInspector/WebNodeHighlight.h:
- WebInspector/WebNodeHighlight.mm:
(-[WebHighlightLayer initWithHighlightView:webView:]):
(-[WebHighlightLayer layoutSublayers]):
(-[WebHighlightLayer actionForKey:]):
(-[WebNodeHighlight initWithTargetView:inspectorController:]):
(-[WebNodeHighlight dealloc]):
(-[WebNodeHighlight attach]):
- WebInspector/WebNodeHighlightView.h:
- WebInspector/WebNodeHighlightView.mm:
(-[WebNodeHighlightView initWithWebNodeHighlight:]):
(-[WebNodeHighlightView dealloc]):
(-[WebNodeHighlightView _attach:numLayers:]):
(findIntersectionOnLineBetweenPoints):
(quadIntersection):
(layerPathWithHole):
(layerPath):
(-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):
(-[WebNodeHighlightView _layoutForRectsHighlight:parent:]):
(-[WebNodeHighlightView layoutSublayers:]):
- WebInspector/WebNodeHighlighter.mm:
(-[WebNodeHighlighter highlight]):
- WebView/WebIndicateLayer.h: Added.
- WebView/WebIndicateLayer.mm: Added.
(-[WebIndicateLayer layoutSublayers]):
(-[WebIndicateLayer actionForKey:]):
- WebView/WebView.mm:
(-[WebView setIndicatingForRemoteInspector:]):
(-[WebView setHostApplicationBundleId:name:]):
(-[WebView hostApplicationBundleId]):
(-[WebView hostApplicationName]):
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]):
- 3:01 PM Changeset in webkit [158136] by
-
- 4 edits in trunk/Tools
Allow explicit sort order for Dashboard platforms
https://bugs.webkit.org/show_bug.cgi?id=123419
Reviewed by Tim Hatcher.
Assign a specific sort order to Dashboard platforms, rather than
just using object property order.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady):
- 3:00 PM Changeset in webkit [158135] by
-
- 2 edits in trunk/LayoutTests
Add skipped or failing expectations for Mavericks WK2.
- platform/mac-wk2/TestExpectations:
- 2:55 PM Changeset in webkit [158134] by
-
- 20 edits in branches/safari-537.73-branch
Merged r156302.
- 2:43 PM Changeset in webkit [158133] by
-
- 20 edits in branches/safari-537.60-branch
Merged r156302.
- 2:32 PM Changeset in webkit [158132] by
-
- 1 edit2 adds in branches/safari-537.73-branch/LayoutTests
Merge r155471.
https://bugs.webkit.org/show_bug.cgi?id=123409.
Missing files from previous merge commit for r155471.
- inspector-protocol/debugger/resources: Added.
- inspector-protocol/debugger/resources/exception.js: Added.
(exceptionBasic):
(exceptionDOM):
(throwString):
(throwParam):
(exceptionInHostFunction):
(catchNested):
(noException):
- 2:27 PM Changeset in webkit [158131] by
-
- 2 edits in trunk/LayoutTests
WebGL flake.
- platform/mac/TestExpectations:
- 2:24 PM Changeset in webkit [158130] by
-
- 2 edits in trunk/Tools
Tidy up main http://build.webkit.org page
https://bugs.webkit.org/show_bug.cgi?id=123413
Reviewed by Alexey Proskuryakov.
Break the list of links into sections. Add some font style.
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 2:19 PM Changeset in webkit [158129] by
-
- 9 edits in trunk/Source
Rename applyPageScaleFactorInCompositor to delegatesPageScaling
https://bugs.webkit.org/show_bug.cgi?id=123417
Reviewed by Simon Fraser.
Source/WebCore:
- page/Frame.cpp:
(WebCore::Frame::frameScaleFactor):
- page/FrameView.cpp:
(WebCore::FrameView::visibleContentScaleFactor):
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
- page/Settings.in:
- platform/ScrollView.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
- 2:09 PM Changeset in webkit [158128] by
-
- 2 edits in branches/safari-537.73-branch/Source/WTF
Merged r156933. <rdar://problem/15323812>
- 2:05 PM Changeset in webkit [158127] by
-
- 22 edits3 adds in trunk
Parsing support for -webkit-text-decoration-skip: ink
https://bugs.webkit.org/show_bug.cgi?id=123358
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-28
Reviewed by Dean Jackson.
Source/JavaScriptCore:
Adding ENABLE(CSS3_TEXT_DECORATION)
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Adds initial parsing support for parsing -webkit-text-decoration-skip with
values of "none" and "ink". This work is behind the new
ENABLE(CSS3_TEXT_DECORATION) compile-time flag.
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html
- Configurations/FeatureDefines.xcconfig: Adding ENABLE(CSS3_TEXT_DECORATION)
- css/CSSComputedStyleDeclaration.cpp: Mapping internal representation of text-decoration-skip
to a CSSValue
(WebCore::renderTextDecorationSkipFlagsToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp: Actually parsing tokens
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextDecorationSkip):
- css/CSSParser.h:
- css/CSSPropertyNames.in: adding -webkit-text-decoration-skip
- css/CSSValueKeywords.in: adding ink
- css/DeprecatedStyleBuilder.cpp: Mapping from CSSValue to internal representation
(WebCore::ApplyPropertyTextDecorationSkip::valueToDecorationSkip):
(WebCore::ApplyPropertyTextDecorationSkip::applyValue):
(WebCore::ApplyPropertyTextDecorationSkip::createHandler):
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/StyleResolver.cpp: decoration-skip uses DeprecatedStyleBuilder
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h: Adding functions for modifying and accessing decoration-skip properties
- rendering/style/RenderStyleConstants.h: Definition of internal representation
- rendering/style/StyleRareInheritedData.cpp: Setting up constructors and comparators
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h: Holds actual value of internal representation
Source/WebKit/mac:
Adding ENABLE(CSS3_TEXT_DECORATION)
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Adding ENABLE(CSS3_TEXT_DECORATION)
- Configurations/FeatureDefines.xcconfig:
Tools:
Adding ENABLE(CSS3_TEXT_DECORATION)
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Adds a test which makes sure that we can parse the
-webkit-text-decoration-skip CSS property, as well
as values for "ink" and "none". We can use the CSSOM
to test the roundtrip of these values
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html: Added.
- 1:59 PM Changeset in webkit [158126] by
-
- 2 edits in branches/safari-537.60-branch/Source/WTF
Merged r156933.
- 1:56 PM Changeset in webkit [158125] by
-
- 8 edits in branches/safari-537.73-branch/Source/WebKit/win
Merged r154508. <rdar://problem/15109410>
- 1:30 PM Changeset in webkit [158124] by
-
- 5 edits in branches/safari-537.73-branch/Source/JavaScriptCore
Merged r154366. <rdar://problem/15109352>
- 1:10 PM Changeset in webkit [158123] by
-
- 6 edits in trunk/Source
RunLoop::dispatch should take an std::function
https://bugs.webkit.org/show_bug.cgi?id=123407
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
- platform/RunLoop.cpp:
(WebCore::RunLoop::performWork):
(WebCore::RunLoop::dispatch):
- platform/RunLoop.h:
Source/WTF:
- wtf/FunctionDispatcher.h:
- 1:01 PM Changeset in webkit [158122] by
-
- 32 edits2 deletes in trunk/Source
Make TileController manipulate PlatformCALayers instead of CALayers
https://bugs.webkit.org/show_bug.cgi?id=123279
Reviewed by Simon Fraser.
In the interest of making TileController more platform-independent
(so that it can be used with the remote layer tree, and maybe Windows),
move TileController onto our PlatformCALayer abstraction instead of
direct manipulation of CALayers.
Some fallout from this includes getting rid of special Mac-specific
TileController-specific CALayer subclasses, and reworking tile
painting to work in a more generic way.
This is a first step, and doesn't get us all the way to a platform independent
TileController, but more patches are forthcoming.
No new tests, just a (largeish) refactor.
- WebCore.exp.in:
The signature of some methods has changed.
- WebCore.xcodeproj/project.pbxproj:
Remove WebTileLayer.*
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::logExposedUnfilledArea):
Use the "isTile" key on the CALayer dictionary instead of the layer's
class to determine if it's a tile. TileController will set this on a tile
when it is created, for now.
- platform/graphics/TiledBacking.h:
tiledScrollingIndicatorLayer() should return a PlatformCALayer.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
- platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::platformCALayerIncrementRepaintCount):
- platform/graphics/ca/PlatformCALayerClient.h:
The PlatformCALayerClient paintContents and incrementRepaintCount callbacks
should include the platformCALayer that caused the callback.
- platform/graphics/ca/PlatformCALayer.h:
Add LayerTypeSimpleLayer, which is similar to LayerTypeWebLayer
except it just calls back its client to paint, instead of doing
complicated things with repaint rects. This is so that TileController
doesn't re-enter drawLayerContents when asking its GraphicsLayer
to paint for each PlatformCALayer (it will be entering drawLayerContents
for the first time for each layer). It also happens to be useful
for things like the tile controller overlay, which don't need
all that complication.
Add LayerTypeTiledBackingTileLayer, which is used simply to distinguish
TileController Tile layers from other LayerTypeSimpleLayers.
- platform/graphics/ca/mac/LayerPool.h:
- platform/graphics/ca/mac/LayerPool.mm:
(WebCore::LayerPool::addLayer):
(WebCore::LayerPool::takeLayerWithSize):
LayerPool should operate on PlatformCALayers now.
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::PlatformCALayerMac):
Set the "isTile" key on the CALayer to true for TiledBackingTileLayers,
so that the scrolling performance logging can tell a tile apart from
any other layer, on the scrolling thread, without touching PlatformCALayers
or the TileController or any other main-thread data structures.
(PlatformCALayerMac::setEdgeAntialiasingMask): Added.
- platform/graphics/ca/mac/TileController.h:
Remove references to Objective-C classes; instead use PlatformCALayer everywhere.
TileController is now a PlatformCALayerClient, and the layers it owns are
all PlatformCALayers (and it is constructed with a PlatformCALayer, etc.).
Hand in the tile debug border color as a WebCore color, instead of a CGColorRef.
blankPixelCountForTiles() now operates on a list of PlatformLayers instead of
WebTileLayers specifically, since WebTileLayer is gone.
Make drawTileMapContents private because WebTileCacheMapLayer no longer exists.
(WebCore::TileController::platformCALayerDrawsContent):
All of the layers who have TileController as their client paint their contents.
(WebCore::TileController::platformCALayerContentsOpaque):
This will only be called for layers which paint via drawLayerContents,
so it's OK that we don't special-case the debugging overlay here.
(WebCore::TileController::owningGraphicsLayer):
Return the GraphicsLayer that owns the TileController's main
layer, via its conformance to PlatformCALayerClient. This is
a bit strange (because it's not strictly a GraphicsLayer, despite
always being so at the moment), but is done for clarity inside
TileController itself.
- platform/graphics/ca/mac/TileController.mm:
Remove CALayer (WebCALayerDetails), WebTiledScrollingIndicatorLayer,
and a bunch of includes that we don't need anymore.
(WebCore::TileController::create):
(WebCore::TileController::TileController):
TileController is passed a PlatformCALayer for the tile cache root layer,
instead of a WebTiledBackingLayer. It also creates a PlatformCALayer with
LayerTypeLayer instead of a bare CALayer for the container layer.
It's OK to remove the transaction because it was only used to stop
the implicit animation, which PlatformCALayer will do for us.
(WebCore::TileController::~TileController):
Clear the owner of the PlatformCALayers which the TileController previously owned,
so they don't try to call back a destroyed TileController.
(WebCore::TileController::tileCacheLayerBoundsChanged):
(WebCore::TileController::setNeedsDisplay):
Straightforward adjustments towards use of PlatformCALayer.
(WebCore::TileController::setTileNeedsDisplayInRect):
Adjustments towards use of PlatformCALayer; we need FloatRects so we can
pass pointers to PlatformCALayer::setNeedsDisplay.
(WebCore::TileController::platformCALayerPaintContents):
Replace drawLayer with platformCALayerPaintContents, which will be called
back from our various WebSimpleLayers. If the PlatformCALayer is our
tiled scrolling debug indicator, paint that. Otherwise, it's a tile.
Make use of drawLayerContents() to paint the tile contents.
Make use of drawRepaintIndicator() to paint the repaint indicator if needed.
Move scrolling performance logging code that used to be in WebTileLayer here.
(WebCore::TileController::platformCALayerDeviceScaleFactor):
(WebCore::TileController::platformCALayerShowDebugBorders):
(WebCore::TileController::platformCALayerShowRepaintCounter):
Forward these to the owning GraphicsLayerCA, because it will have the right answers.
(WebCore::TileController::setScale):
Adjustments towards use of PlatformCALayer; remove some code that Simon
caused to be unused in 156291 but did not remove.
(WebCore::TileController::setAcceleratesDrawing):
(WebCore::TileController::setTilesOpaque):
(WebCore::TileController::setVisibleRect):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::setTileDebugBorderWidth):
(WebCore::TileController::setTileDebugBorderColor):
(WebCore::TileController::bounds):
(WebCore::TileController::blankPixelCount):
(WebCore::TileController::blankPixelCountForTiles):
(WebCore::queueTileForRemoval):
(WebCore::TileController::setNeedsRevalidateTiles):
(WebCore::TileController::ensureTilesForRect):
(WebCore::TileController::retainedTileBackingStoreMemory):
Straightforward adjustments towards use of PlatformCALayer.
(WebCore::TileController::updateTileCoverageMap):
Adjustments towards use of PlatformCALayer; rename backgroundColor
to visibleRectIndicatorColor, since it's actually a border, not a background.
(WebCore::TileController::tiledScrollingIndicatorLayer):
Create a LayerTypeSimpleLayer PlatformCALayer for the tiled scrolling indicator.
It will be asked to paint straightforwardly, like a CALayer would.
Create a LayerTypeLayer PlatformCALayer for the visible rect indicator.
It doesn't need to paint anything, so it doesn't get an owner.
(WebCore::TileController::createTileLayer):
When creating a new tile layer, adopt it by setting its owner.
Otherwise, straightforward adjustments towards use of PlatformCALayer.
(WebCore::TileController::platformCALayerIncrementRepaintCount):
Manage repaint counts for tiles in TileController now.
(WebCore::TileController::drawTileMapContents):
Adjustments towards use of PlatformCALayer.
- platform/graphics/ca/mac/WebTileLayer.h: Removed.
- platform/graphics/ca/mac/WebTileLayer.mm: Removed.
We don't need WebTileLayer anymore, tiles are now just WebSimpleLayers
owned by TileController. Its behavior has been moved into TileController.
- platform/graphics/ca/mac/WebTiledBackingLayer.h:
- platform/graphics/ca/mac/WebTiledBackingLayer.mm:
(-[WebTiledBackingLayer createTileController:]):
Add createTileController: so that the WebTiledBackingLayer's owner can
hand the TileController the PlatformCALayer for the WebTiledBackingLayer
without propagating additional usage of PlatformCALayer::platformCALayer(),
which we need to remove in light of the remote layer tree work.
(-[WebTiledBackingLayer setBorderColor:]):
- platform/graphics/ca/win/PlatformCALayerWin.h:
Add an empty implementation of setEdgeAntialiasingMask.
We'll probably want to implement it before adopting TileController on Windows.
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerPaintContents):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerIncrementRepaintCount):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::LayerClient::platformCALayerPaintContents):
(WebCore::LayerClient::platformCALayerIncrementRepaintCount):
Adjust for new parameters on PlatformCALayerClient callbacks.
- platform/graphics/mac/WebLayer.h:
Add WebSimpleLayer, which inherits directly from CALayer, and make
our standard WebLayer (which is used for compositing layers in web content)
inherit from that.
- platform/graphics/mac/WebLayer.mm:
Move most of the behavior of WebLayer onto WebSimpleLayer, except for its
complex painting code. That stays as an override on WebLayer.
(WebCore::drawLayerContents):
Use the PlatformCALayer's PlatformLayer - if it exists - to extract
fine-grained repaint rects. If it doesn't, we'll just use the CGContext's
clip rect as our single repaint rect.
Rename platformLayer to platformCALayer for accuracy.
Remove special code for CATiledLayer since we ought not use it on Mac anymore.
(WebCore::drawRepaintIndicator):
Factor repaint indicator code out into its own function so that TileController
can use it. It can't be called from drawLayerContents for TileController, since
the PlatformCALayer that TileController passes in to drawLayerContents is actually
that of the tile cache's root layer, not the tile itself.
Also, add a custom background color parameter so TileController can override
the default green color with its own standard purple.
(-[WebLayer drawInContext:]):
(-[WebSimpleLayer drawInContext:]):
- platform/graphics/mac/WebTiledLayer.mm:
(-[WebTiledLayer drawInContext:]):
Removed a param from drawLayerContents because it's trivially acquirable
from the PlatformCALayer.
- FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerPaintContents):
(FullscreenVideoController::LayerClient::platformCALayerIncrementRepaintCount):
Adjust for new parameters on PlatformCALayerClient callbacks.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::dump):
Support the new LayerTypes.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::setEdgeAntialiasingMask):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Add an empty implementation of setEdgeAntialiasingMask.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::display):
Removed a parameter from drawLayerContents.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateDebugInfoLayer):
TiledCoreAnimationDrawingArea still operates in terms of CALayers, so
grab the PlatformLayer out from TileController's indicator.
- 12:22 PM Changeset in webkit [158121] by
-
- 7 edits in trunk/Source/WebCore
Move RenderBlock functions only used by RenderBlockFlow to RenderBlockFlow
https://bugs.webkit.org/show_bug.cgi?id=123318
Reviewed by David Hyatt.
- rendering/LineLayoutState.h:
Move FloatWithRect from RenderBlock.
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
Move pagination and float functions.
- 11:48 AM Changeset in webkit [158120] by
-
- 2 edits in trunk/LayoutTests
Expunge Lion and SnowLeopard from TestExpectations.
- platform/mac/TestExpectations:
- 11:46 AM Changeset in webkit [158119] by
-
- 2 edits in trunk/LayoutTests
Some test expectations for Mavericks.
- platform/mac/TestExpectations:
- 11:42 AM Changeset in webkit [158118] by
-
- 2 edits in trunk/Tools
Add additional Apple Mavericks test bots.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 11:31 AM Changeset in webkit [158117] by
-
- 5 edits6 copies in branches/safari-537.73-branch
Merge r155471.
https://bugs.webkit.org/show_bug.cgi?id=123409.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Re-implemented fix based on the frame iteration mechanhism before the
StackVisitor was available.
2013-09-10 Joseph Pecoraro <Joseph Pecoraro>
Web Inspector: [JSC] Caught exception is treated as uncaught
https://bugs.webkit.org/show_bug.cgi?id=93607
Reviewed by Geoff Garen.
Check up the entire call stack to see if there is an exception handler.
- interpreter/Interpreter.cpp: (JSC::GetExceptionHandlerFunctor::GetExceptionHandlerFunctor): (JSC::GetExceptionHandlerFunctor::handler): (JSC::GetExceptionHandlerFunctor::operator()):
LayoutTests:
Re-based test results from merge.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.checkForError): This is needed for the merged tests.
2013-09-10 Joseph Pecoraro <Joseph Pecoraro>
Web Inspector: [JSC] Caught exception is treated as uncaught
https://bugs.webkit.org/show_bug.cgi?id=93607
Reviewed by Geoff Garen.
Add tests for different inspector pause on exceptions states.
- inspector-protocol/debugger/resources/exception.js: Added.
- inspector-protocol/debugger/setPauseOnExceptions-all-expected.txt: Added.
- inspector-protocol/debugger/setPauseOnExceptions-all.html: Added.
- inspector-protocol/debugger/setPauseOnExceptions-none-expected.txt: Added.
- inspector-protocol/debugger/setPauseOnExceptions-none.html: Added.
- inspector-protocol/debugger/setPauseOnExceptions-uncaught-expected.txt: Added.
- inspector-protocol/debugger/setPauseOnExceptions-uncaught.html: Added.
- 11:03 AM Changeset in webkit [158116] by
-
- 16 edits in trunk/Source/JavaScriptCore
Get rid of InlineStart so that I don't have to implement it in FTL
https://bugs.webkit.org/show_bug.cgi?id=123302
Reviewed by Geoffrey Garen.
InlineStart was a special instruction that we would insert at the top of inlined code,
so that the backend could capture the OSR state of arguments to an inlined call. It used
to be that only the backend had this information, so this instruction was sort of an ugly
callback from the backend for filling in some data structures.
But in the time since when that code was written (two years ago?), we rationalized how
variables work. It's now the case that variables that the runtime must know about are
treated specially in IR (they are "flushed") and we know how we will represent them even
before we get to the backend. The last place that makes changes to their representation
is the StackLayoutPhase.
So, this patch gets rid of InlineStart, but keeps around the special meta-data that the
instruction had. Instead of handling the bookkeeping in the backend, we handle it in
StackLayoutPhase. This means that the DFG and FTL can share code for handling this
bookkeeping. This also means that now the FTL can compile code blocks that had inlining.
Of course, giving the FTL the ability to handle code blocks that had inlining means that
we're going to have new bugs. Sure enough, the FTL's linker didn't handle inline call
frames. This patch also fixes that.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
- dfg/DFGNode.h:
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- 10:35 AM Changeset in webkit [158115] by
-
- 10 edits6 adds in trunk
[CSS Grid Layout] Add support for order inside grid items
https://bugs.webkit.org/show_bug.cgi?id=123208
Reviewed by Antti Koivisto.
Source/WebCore:
Based on Blink r153457 and r153536 by <jchaffraix@chromium.org>
Added support for sorting grid items by using -webkit-order
property. Used OrderIterator to implement it so it had to be moved
out of RenderFlexibleBox to be shared with RenderGrid.
Tests: fast/css-grid-layout/grid-item-order-auto-flow-resolution.html
fast/css-grid-layout/grid-item-order-paint-order.html
- CMakeLists.txt: Added new file.
- GNUmakefile.list.am: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/OrderIterator.cpp: Added. Ripped out of RenderFlexibleBox.
(WebCore::OrderIterator::OrderIterator):
(WebCore::OrderIterator::setOrderValues): Use std::move semantics.
(WebCore::OrderIterator::first): Use an integer as iterator.
(WebCore::OrderIterator::next): Ditto.
(WebCore::OrderIterator::reset): Ditto.
- rendering/OrderIterator.h: Added.
(WebCore::OrderIterator::currentChild):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderFlexibleBox.h:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::RenderGrid):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::paintChildren):
- rendering/RenderGrid.h:
LayoutTests:
From Blink r153536 by <jchaffraix@chromium.org>
Added a couple of tests to verify that we respect the specified
order of grid items both in the auto-placement algorithm and in
the final painting.
- fast/css-grid-layout/grid-item-order-auto-flow-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-item-order-auto-flow-resolution.html: Added.
- fast/css-grid-layout/grid-item-order-paint-order-expected.html: Added.
- fast/css-grid-layout/grid-item-order-paint-order.html: Added.
- 10:20 AM Changeset in webkit [158114] by
-
- 2 edits in trunk/Source/JavaScriptCore
The GetById->GetByOffset AI-based optimization should actually do things
https://bugs.webkit.org/show_bug.cgi?id=123299
Reviewed by Oliver Hunt.
20% speed-up on Octane/gbemu.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor): Actually finish filling in the Status by setting the state. Previously it would remain set to NoInformation, meaning that this whole method was a no-op.
- 9:15 AM Changeset in webkit [158113] by
-
- 337 edits in trunk
Methods on window.internals shouldn't pass a document.
https://bugs.webkit.org/show_bug.cgi?id=107301
Patch by Afonso R. Costa Jr. <afonso.costa@samsung.com> on 2013-10-28
Reviewed by Alexey Proskuryakov.
Each 'Internals' instance is associated with a 'Document'. So, it
is not necessary to pass a document as argument. Only nodesFromRect and
layerTreeAsText methods were kept because, in some Layout Tests, the
'Document' object is not the same used by Internals::contextDocument.
Source/WebCore:
- testing/Internals.cpp: Removed 'document' parameter.
(WebCore::Internals::animationsAreSuspended):
(WebCore::Internals::suspendAnimations):
(WebCore::Internals::resumeAnimations):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
(WebCore::Internals::setScrollViewPosition):
(WebCore::Internals::setPagination):
(WebCore::Internals::configurationForViewport):
(WebCore::Internals::paintControlTints):
(WebCore::Internals::setDelegatesScrolling):
(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::touchNodeAdjustedToBestClickableNode):
(WebCore::Internals::touchPositionAdjustedToBestContextMenuNode):
(WebCore::Internals::touchNodeAdjustedToBestContextMenuNode):
(WebCore::Internals::bestZoomableAreaForTouchPoint):
(WebCore::Internals::lastSpellCheckRequestSequence):
(WebCore::Internals::lastSpellCheckProcessedSequence):
(WebCore::Internals::wheelEventHandlerCount):
(WebCore::Internals::touchEventHandlerCount):
(WebCore::Internals::setBatteryStatus):
(WebCore::Internals::setNetworkInformation):
(WebCore::Internals::setDeviceProximity):
(WebCore::Internals::hasSpellingMarker):
(WebCore::Internals::hasAutocorrectedMarker):
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore::Internals::toggleOverwriteModeEnabled):
(WebCore::Internals::consoleMessageArgumentCounts):
(WebCore::Internals::hasGrammarMarker):
(WebCore::Internals::numberOfScrollableAreas):
(WebCore::Internals::isPageBoxVisible):
(WebCore::Internals::repaintRectsAsText):
(WebCore::Internals::scrollingStateTreeAsText):
(WebCore::Internals::mainThreadScrollingReasons):
(WebCore::Internals::nonFastScrollableRects):
(WebCore::Internals::garbageCollectDocumentResources):
(WebCore::Internals::insertAuthorCSS):
(WebCore::Internals::insertUserCSS):
(WebCore::Internals::shortcutIconURLs):
(WebCore::Internals::allIconURLs):
(WebCore::Internals::setHeaderHeight):
(WebCore::Internals::setFooterHeight):
(WebCore::Internals::webkitWillEnterFullScreenForElement):
(WebCore::Internals::webkitDidEnterFullScreenForElement):
(WebCore::Internals::webkitWillExitFullScreenForElement):
(WebCore::Internals::webkitDidExitFullScreenForElement):
(WebCore::Internals::startTrackingRepaints):
(WebCore::Internals::stopTrackingRepaints):
(WebCore::Internals::getCurrentCursorInfo):
- testing/Internals.h:
(WebCore::Internals::setPagination):
- testing/Internals.idl:
LayoutTests:
- animations/added-while-suspended.html: Removed 'document' parameter.
- animations/play-state-suspend.html:
- animations/stop-animation-on-suspend.html:
- animations/suspend-resume-animation-events.html:
- animations/suspend-resume-animation.html:
- animations/suspend-transform-animation.html:
- batterystatus/resources/event-after-navigation-new.html:
- batterystatus/script-tests/add-listener-from-callback.js:
(firstListener):
- batterystatus/script-tests/basic-all-types-of-events.js:
- batterystatus/script-tests/basic-operation.js:
- batterystatus/script-tests/multiple-frames.js:
- batterystatus/script-tests/updates.js:
(setBatteryStatus):
- compositing/columns/ancestor-clipped-in-paginated.html:
- compositing/columns/clipped-in-paginated.html:
- compositing/columns/composited-columns-vertical-rl.html:
- compositing/columns/composited-in-paginated-rl.html:
- compositing/columns/composited-in-paginated-writing-mode-rl.html:
- compositing/columns/composited-in-paginated.html:
- compositing/columns/composited-lr-paginated-repaint.html:
- compositing/columns/composited-rl-paginated-repaint.html:
- compositing/columns/geometry-map-paginated-assert.html:
- compositing/columns/hittest-composited-in-paginated.html:
- compositing/columns/rotated-in-paginated.html:
- compositing/columns/untransformed-composited-in-paginated.html:
- compositing/iframes/iframe-composited-scrolling.html:
- compositing/layer-creation/fixed-position-in-view-dynamic.html:
- compositing/layer-creation/fixed-position-no-content-scroll-reason.html:
- compositing/layer-creation/fixed-position-out-of-view-dynamic.html:
- compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html:
- compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html:
- compositing/overflow/dynamic-composited-scrolling-status.html:
- compositing/overflow/scrolling-without-painting.html:
- compositing/overflow/updating-scrolling-content.html:
- compositing/repaint/absolute-painted-into-composited-ancestor.html:
- compositing/repaint/fixed-background-scroll.html:
- compositing/repaint/invalidations-on-composited-layers.html:
- compositing/repaint/positioned-movement.html:
- compositing/repaint/repaint-on-layer-grouping-change.html:
- compositing/repaint/resize-repaint.html:
- compositing/repaint/scroll-fixed-layer-no-content.html:
- compositing/repaint/scroll-fixed-layer-out-of-view.html:
- editing/caret/selection-with-caret-type-progress.html:
- editing/execCommand/overtype.html:
- editing/selection/block-cursor-overtype-mode.html:
- editing/spelling/design-mode-spellcheck-off.html:
- editing/spelling/grammar-edit-word-expected.txt:
- editing/spelling/grammar-edit-word.html:
- editing/spelling/grammar-markers-hidpi.html:
- editing/spelling/grammar-markers.html:
- editing/spelling/grammar.html:
- editing/spelling/script-tests/spellcheck-paste.js:
(verifyMarker):
- editing/spelling/script-tests/spelling-attribute-at-child.js:
(childHasSpellingMarker):
- editing/spelling/script-tests/spelling-attribute-change.js:
(testSpellCheckingEnabled):
- editing/spelling/script-tests/spelling-backspace-between-lines.js:
(testWithDelete):
(testWithForwardDelete):
- editing/spelling/script-tests/spelling-hasspellingmarker.js:
(hasMarked):
- editing/spelling/spellcheck-async-mutation.html:
- editing/spelling/spellcheck-attribute-expected.txt:
- editing/spelling/spellcheck-attribute.html:
- editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
- editing/spelling/spellcheck-paste-continuous-disabled.html:
- editing/spelling/spellcheck-paste-disabled-expected.txt:
- editing/spelling/spellcheck-paste-disabled.html:
- editing/spelling/spellcheck-sequencenum.html:
- editing/spelling/spelling-attribute-change-expected.txt:
- editing/spelling/spelling-backspace-between-lines-expected.txt:
- editing/spelling/spelling-linebreak.html:
- fast/box-shadow/shadow-repaint.html:
- fast/css/webkit-mask-crash-fieldset-legend.html:
- fast/css/webkit-mask-crash-figure.html:
- fast/css/webkit-mask-crash-table.html:
- fast/css/webkit-mask-crash-td-2.html:
- fast/css/webkit-mask-crash-td.html:
- fast/dom/icon-url-change.html:
- fast/dom/icon-url-list-apple-touch.html:
- fast/dom/icon-url-list.html:
- fast/dom/icon-url-property.html:
- fast/events/mouse-cursor-change.html:
- fast/events/mouse-cursor-image-set.html:
- fast/events/mouse-cursor-multiframecur.html:
- fast/events/mouse-cursor-no-mousemove.html:
- fast/events/mouse-cursor.html:
- fast/events/touch/touch-handler-count-expected.txt:
- fast/events/touch/touch-handler-count.html:
- fast/events/touch/touch-input-element-change-documents-expected.txt:
- fast/events/touch/touch-input-element-change-documents.html:
- fast/multicol/hit-test-gap-between-pages-flipped.html:
- fast/multicol/hit-test-gap-between-pages.html:
- fast/multicol/pagination-h-horizontal-bt.html:
- fast/multicol/pagination-h-horizontal-tb.html:
- fast/multicol/pagination-h-vertical-lr.html:
- fast/multicol/pagination-h-vertical-rl.html:
- fast/multicol/pagination-v-horizontal-bt.html:
- fast/multicol/pagination-v-horizontal-tb.html:
- fast/multicol/pagination-v-vertical-lr.html:
- fast/multicol/pagination-v-vertical-rl.html:
- fast/multicol/pagination/BottomToTop-bt.html:
- fast/multicol/pagination/BottomToTop-lr.html:
- fast/multicol/pagination/BottomToTop-rl.html:
- fast/multicol/pagination/BottomToTop-tb.html:
- fast/multicol/pagination/LeftToRight-bt.html:
- fast/multicol/pagination/LeftToRight-lr.html:
- fast/multicol/pagination/LeftToRight-rl.html:
- fast/multicol/pagination/LeftToRight-tb.html:
- fast/multicol/pagination/RightToLeft-bt.html:
- fast/multicol/pagination/RightToLeft-lr.html:
- fast/multicol/pagination/RightToLeft-rl.html:
- fast/multicol/pagination/RightToLeft-tb.html:
- fast/multicol/pagination/TopToBottom-bt.html:
- fast/multicol/pagination/TopToBottom-lr.html:
- fast/multicol/pagination/TopToBottom-rl.html:
- fast/multicol/pagination/TopToBottom-tb.html:
- fast/multicol/shrink-to-column-height-for-pagination.html:
- fast/repaint/background-shorthand-with-gradient-and-height-changes.html:
- fast/repaint/obscured-background-no-repaint.html:
- fast/repaint/resources/text-based-repaint.js:
(runRepaintTest):
- fast/scrolling/resources/scrollable-area.js:
(end):
- fast/viewport/scroll-delegates-switch-on-page-with-no-composition-mode-asserts.html:
- fast/viewport/viewport-1.html:
- fast/viewport/viewport-10.html:
- fast/viewport/viewport-100.html:
- fast/viewport/viewport-101.html:
- fast/viewport/viewport-102.html:
- fast/viewport/viewport-103.html:
- fast/viewport/viewport-104.html:
- fast/viewport/viewport-105.html:
- fast/viewport/viewport-106.html:
- fast/viewport/viewport-107.html:
- fast/viewport/viewport-108.html:
- fast/viewport/viewport-109.html:
- fast/viewport/viewport-11.html:
- fast/viewport/viewport-110.html:
- fast/viewport/viewport-111.html:
- fast/viewport/viewport-112.html:
- fast/viewport/viewport-113.html:
- fast/viewport/viewport-114.html:
- fast/viewport/viewport-115.html:
- fast/viewport/viewport-116.html:
- fast/viewport/viewport-117.html:
- fast/viewport/viewport-118.html:
- fast/viewport/viewport-119.html:
- fast/viewport/viewport-12.html:
- fast/viewport/viewport-120.html:
- fast/viewport/viewport-121.html:
- fast/viewport/viewport-122.html:
- fast/viewport/viewport-123.html:
- fast/viewport/viewport-124.html:
- fast/viewport/viewport-125.html:
- fast/viewport/viewport-126.html:
- fast/viewport/viewport-127.html:
- fast/viewport/viewport-128.html:
- fast/viewport/viewport-129.html:
- fast/viewport/viewport-13.html:
- fast/viewport/viewport-130.html:
- fast/viewport/viewport-131.html:
- fast/viewport/viewport-132.html:
- fast/viewport/viewport-133.html:
- fast/viewport/viewport-134.html:
- fast/viewport/viewport-14.html:
- fast/viewport/viewport-15.html:
- fast/viewport/viewport-16.html:
- fast/viewport/viewport-17.html:
- fast/viewport/viewport-18.html:
- fast/viewport/viewport-19.html:
- fast/viewport/viewport-2.html:
- fast/viewport/viewport-20.html:
- fast/viewport/viewport-21.html:
- fast/viewport/viewport-22.html:
- fast/viewport/viewport-23.html:
- fast/viewport/viewport-24.html:
- fast/viewport/viewport-25.html:
- fast/viewport/viewport-26.html:
- fast/viewport/viewport-27.html:
- fast/viewport/viewport-28.html:
- fast/viewport/viewport-29.html:
- fast/viewport/viewport-3.html:
- fast/viewport/viewport-30.html:
- fast/viewport/viewport-31.html:
- fast/viewport/viewport-32.html:
- fast/viewport/viewport-33.html:
- fast/viewport/viewport-34.html:
- fast/viewport/viewport-35.html:
- fast/viewport/viewport-36.html:
- fast/viewport/viewport-37.html:
- fast/viewport/viewport-38.html:
- fast/viewport/viewport-39.html:
- fast/viewport/viewport-4.html:
- fast/viewport/viewport-40.html:
- fast/viewport/viewport-41.html:
- fast/viewport/viewport-42.html:
- fast/viewport/viewport-43.html:
- fast/viewport/viewport-44.html:
- fast/viewport/viewport-45.html:
- fast/viewport/viewport-46.html:
- fast/viewport/viewport-47.html:
- fast/viewport/viewport-48.html:
- fast/viewport/viewport-49.html:
- fast/viewport/viewport-5.html:
- fast/viewport/viewport-50.html:
- fast/viewport/viewport-51.html:
- fast/viewport/viewport-52.html:
- fast/viewport/viewport-53.html:
- fast/viewport/viewport-54.html:
- fast/viewport/viewport-55.html:
- fast/viewport/viewport-56.html:
- fast/viewport/viewport-57.html:
- fast/viewport/viewport-58.html:
- fast/viewport/viewport-59.html:
- fast/viewport/viewport-6.html:
- fast/viewport/viewport-60.html:
- fast/viewport/viewport-61.html:
- fast/viewport/viewport-62.html:
- fast/viewport/viewport-63.html:
- fast/viewport/viewport-64.html:
- fast/viewport/viewport-65.html:
- fast/viewport/viewport-66.html:
- fast/viewport/viewport-67.html:
- fast/viewport/viewport-68.html:
- fast/viewport/viewport-69.html:
- fast/viewport/viewport-7.html:
- fast/viewport/viewport-70.html:
- fast/viewport/viewport-71.html:
- fast/viewport/viewport-72.html:
- fast/viewport/viewport-73.html:
- fast/viewport/viewport-74.html:
- fast/viewport/viewport-75.html:
- fast/viewport/viewport-76.html:
- fast/viewport/viewport-77.html:
- fast/viewport/viewport-78.html:
- fast/viewport/viewport-79.html:
- fast/viewport/viewport-8.html:
- fast/viewport/viewport-80.html:
- fast/viewport/viewport-81.html:
- fast/viewport/viewport-82.html:
- fast/viewport/viewport-83.html:
- fast/viewport/viewport-84.html:
- fast/viewport/viewport-85.html:
- fast/viewport/viewport-86.html:
- fast/viewport/viewport-87.html:
- fast/viewport/viewport-88.html:
- fast/viewport/viewport-9.html:
- fast/viewport/viewport-90.html:
- fast/viewport/viewport-91.html:
- fast/viewport/viewport-legacy-handheldfriendly.html:
- fast/viewport/viewport-legacy-mobileoptimized-2.html:
- fast/viewport/viewport-legacy-mobileoptimized-3.html:
- fast/viewport/viewport-legacy-mobileoptimized.html:
- fast/viewport/viewport-legacy-ordering-1.html:
- fast/viewport/viewport-legacy-ordering-2.html:
- fast/viewport/viewport-legacy-ordering-3.html:
- fast/viewport/viewport-legacy-ordering-4.html:
- fast/viewport/viewport-legacy-ordering-5.html:
- fast/viewport/viewport-legacy-ordering-6.html:
- fast/viewport/viewport-legacy-ordering-7.html:
- fast/viewport/viewport-legacy-ordering-8.html:
- fast/viewport/viewport-legacy-ordering-9.html:
- fast/viewport/viewport-legacy-xhtmlmp-misplaced-doctype.html:
- fast/viewport/viewport-legacy-xhtmlmp-ordering.html:
- fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html:
- fast/viewport/viewport-legacy-xhtmlmp.html:
- fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html:
- fast/viewport/viewport-limits-adjusted-for-no-user-scale.html:
- fast/viewport/viewport-warnings-1.html:
- fast/viewport/viewport-warnings-2.html:
- fast/viewport/viewport-warnings-3.html:
- fast/viewport/viewport-warnings-4.html:
- fast/viewport/viewport-warnings-5.html:
- fast/viewport/viewport-warnings-6.html:
- fullscreen/video-cursor-auto-hide-expected.txt:
- fullscreen/video-cursor-auto-hide.html:
- http/tests/inspector-enabled/resources/console-clear-arguments-test.js:
(dumpConsoleMessageArgumentCounts):
- http/tests/inspector/elements-test.js:
- networkinformation/resources/event-after-navigation-new.html:
- networkinformation/script-tests/add-listener-from-callback.js:
(firstListener):
- networkinformation/script-tests/basic-all-types-of-events.js:
- networkinformation/script-tests/basic-operation.js:
- networkinformation/script-tests/multiple-frames.js:
- networkinformation/script-tests/updates.js:
(setNetworkInformation):
- platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
- platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html:
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html:
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html:
- platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow.html:
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html:
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view.html:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed.html:
- platform/mac-wk2/tiled-drawing/fixed/four-bars.html:
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view.html:
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset.html:
- platform/mac-wk2/tiled-drawing/fixed/nested-fixed.html:
- platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed.html:
- platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-in-frame.html:
- platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-with-page-scale.html:
- platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing.html:
- platform/mac-wk2/tiled-drawing/scrolling-tree-after-scroll.html:
- platform/mac-wk2/tiled-drawing/scrolling-tree-slow-scrolling.html:
- platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html:
- platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html:
- platform/mac-wk2/tiled-drawing/slow-scrolling.html:
- platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset.html:
- platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal.html:
- platform/mac-wk2/tiled-drawing/sticky/sticky-vertical.html:
- platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
- platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
- platform/mac/editing/spelling/delete-into-misspelled-word.html:
- platform/mac/editing/spelling/editing-multiple-words-with-markers.html:
- platform/mac/editing/spelling/editing-word-with-marker-1.html:
- platform/mac/editing/spelling/editing-word-with-marker-2.html:
- platform/mac/editing/spelling/move-cursor-around-misspelled-word.html:
- platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt:
- printing/page-format-data-expected.txt:
- printing/page-format-data.html:
- proximity/add-listener-from-callback.html:
- proximity/basic-operation.html:
- proximity/multiple-frames.html:
- proximity/resources/event-after-navigation-new.html:
- proximity/updates.html:
- scrollingcoordinator/resources/non-fast-scrollable-region-testing.js:
(runNonFastScrollableRegionTest):
- touchadjustment/big-div.html:
- touchadjustment/event-triggered-widgets.html:
- touchadjustment/iframe.html:
- touchadjustment/nested-shadow-node.html:
- touchadjustment/resources/touchadjustment.js:
(testTouchPoint):
(testTouchPointContextMenu):
(adjustTouchPoint):
(adjustTouchPointContextMenu):
- touchadjustment/scroll-delegation/iframe-with-mainframe-scroll-offset.html:
- touchadjustment/scroll-offset.html:
- touchadjustment/search-cancel.html:
- touchadjustment/zoom-basic.html:
- touchadjustment/zoom-fatfinger.html:
- transitions/created-while-suspended.html:
- transitions/started-while-suspended.html:
- transitions/suspend-transform-transition.html:
- userscripts/insert-stylesheets.html:
- 9:11 AM Changeset in webkit [158112] by
-
- 10 edits2 deletes in trunk
Remove HTMLMediaElement.startTime
https://bugs.webkit.org/show_bug.cgi?id=123264
Reviewed by Eric Carlson.
Source/WebCore:
Patch based on one by: philipj@opera.com
Blink review URL: https://codereview.chromium.org/32583003
startTime has been removed from the HTMLMediaElement and its use
in the rest of components.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleRewindButtonClicked):
(Controller.prototype.handleTimelineMouseMove):
(Controller.prototype.updateDuration):
(Controller.prototype.updateTime): Removed used of startTime().
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_media_element_get_start_time):
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols: Added phony function.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::isBlockedOnMediaController): Removed
use of startTime()
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl: Removed startTime()
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::paintSliderThumb): Removed use of
startTime()
LayoutTests:
Removed test about startTime.
Blink review URL: https://codereview.chromium.org/32583003
- media/media-startTime-expected.txt: Removed.
- media/media-startTime.html: Removed.
- 8:48 AM Changeset in webkit [158111] by
-
- 5 edits in trunk/Source
RenderElement::m_style should be a Ref.
<https://webkit.org/b/123401>
Source/WebCore:
Made RenderElement::m_style a Ref. This codifies the fact that it
can never be null after construction.
Removed a couple of unnecessary null checks that were exposed as
compilation failures.
Reviewed by Antti Koivisto.
Source/WTF:
Added a Ref::replace() so we can Indiana Jones the new style in
RenderElement::setStyle() while keeping a handle on the old style
for a while longer.
Reviewed by Antti Koivisto.
- 8:22 AM Changeset in webkit [158110] by
-
- 16 edits in trunk
Name all the GLib timeout sources
https://bugs.webkit.org/show_bug.cgi?id=123229
Patch by Bastien Nocera <hadess@hadess.net> on 2013-10-28
Reviewed by Anders Carlsson.
Source/WebCore:
Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.
No new tests, no change in functionality.
Source/WebKit/gtk:
Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.
Source/WebKit2:
Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.
Tools:
Give a name to GLib timeout sources, this is helpful when
profiling WebKitGTK applications.
- 8:16 AM Changeset in webkit [158109] by
-
- 2 edits in trunk/Source/WebCore
MediaStreamTrackPrivate's m_client uninitialized
https://bugs.webkit.org/show_bug.cgi?id=123403
Reviewed by Eric Carlson.
No new tests, no change in functionality.
- platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
Initialize the m_client member variable.
- 6:44 AM Changeset in webkit [158108] by
-
- 9 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.list.am: Add missing files to compilation.
Source/WebCore:
- GNUmakefile.am: Add crypto idl files to EXTRA_DIST and remove
css/fullscreenQuickTime.css that was removed.
Source/WebKit2:
- GNUmakefile.am: Add messages.in files in
UIProcess/Network/CustomProtocols/ to EXTRA_DIST.
- GNUmakefile.list.am: Remove
WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp from
compilation because it depends on code generated only when
database process is enabled.
Source/WTF:
- GNUmakefile.list.am: Remove unexistent file from compilation.
- 6:39 AM Changeset in webkit [158107] by
-
- 13 edits in trunk/Source/WebCore
Prepare simple line layout to support multiple runs per line
https://bugs.webkit.org/show_bug.cgi?id=123400
Reviewed by Andreas Kling.
Bunch of renaming and some refactoring for future support for text runs.
SimpleLineLayout::Lines -> SimpleLineLayout::Layout and becomes a class instead of a typedef.
SimpleLineLayout::Resolver::Line -> SimpleLineLayout::Resolver::Run
SimpleLineLayout::createLines() -> SimpleLineLayout::create()
RenderBlockFlow::simpleLines() -> RenderBlockFlow::simpleLineLayout()
RenderText::simpleLines() -> RenderText::simpleLineLayout()
Added resolver construction functions:
SimpleLineLayout::runResolver()
SimpleLineLayout::lineResolver()
- 5:32 AM Changeset in webkit [158106] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, EFL gardening.
fast/canvas/webgl/drawingbuffer-test.html is passing on efl-wk2.
Move it to efl-wk1 TestExpectations file.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 3:36 AM Changeset in webkit [158105] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] [GTK] Allow running the web process with an arbitrary prefix command
https://bugs.webkit.org/show_bug.cgi?id=123201
Reviewed by Carlos Garcia Campos.
Launch the web process using WEB_PROCESS_CMD_PREFIX as a
prefix. Useful for debugging the web process with gdb, valgrind,
etc.
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/gtk/WebProcessProxyGtk.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
- 2:57 AM Changeset in webkit [158104] by
-
- 5 edits1 move1 delete in trunk
[GTK] Expose title and alternative text for links in image maps
https://bugs.webkit.org/show_bug.cgi?id=84045
Reviewed by Chris Fleizach.
Source/WebCore:
Change the way we decide when the title attribute should be
used for the accessible description, by not relying in the
titleTagShouldBeUsedInDescriptionField() helper function but
in whether we have found a visible text for it or not.
This actually mimics what the Mac port does and so makes possible
to share both the layout test and its expected results.
- accessibility/atk/WebKitAccessibleUtil.cpp:
(accessibilityDescription): Update the method to determine
whether the title attribute should be used for the description.
LayoutTests:
Share test expectations among Mac, GTK and EFL ports and
remove expected failures for GTK and EFL.
- accessibility/image-map1-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/image-map1-expected.txt.
- platform/gtk/accessibility/image-map1-expected.txt: Removed.
- platform/efl/TestExpectations: Removed failure expectations.
- platform/gtk/TestExpectations: Ditto.
- 2:29 AM Changeset in webkit [158103] by
-
- 12 edits in trunk
Replace 0 timeouts g_timeout_add() by g_idle_add()
https://bugs.webkit.org/show_bug.cgi?id=123260
Patch by Bastien Nocera <hadess@hadess.net> on 2013-10-28
Reviewed by Carlos Garcia Campos.
A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
without the nagging feeling that the wrong API was used.
Source/WebCore:
No new tests, no change in functionality.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Use g_idle_add() instead
of 0-timer.
(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: Ditto.
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
- platform/gtk/GtkDragAndDropHelper.cpp: Ditto.
(WebCore::GtkDragAndDropHelper::handleDragLeave):
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp: Use g_idle_add() instead
of 0-timer.
(WebKit::ChromeClient::closeWindowSoon):
(WebKit::ChromeClient::widgetSizeChanged):
- WebCoreSupport/GtkAdjustmentWatcher.cpp: Ditto.
(WebKit::GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater):
- webkit/webkitwebview.cpp: Ditto.
(webkit_web_view_get_subresources):
Source/WTF:
- wtf/gtk/MainThreadGtk.cpp: Use g_idle_add() instead
of 0-timer.
(WTF::scheduleDispatchFunctionsOnMainThread):
Tools:
- DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead
of 0-timer.
(topLoadingFrameLoadFinished):
- DumpRenderTree/gtk/EventSender.cpp: Ditto.
(scheduleAsynchronousClickCallback):
(scheduleAsynchronousKeyDownCallback):
- 12:29 AM Changeset in webkit [158102] by
-
- 4 edits in trunk/Source
Re-enable simple line layout for GTK
https://bugs.webkit.org/show_bug.cgi?id=123388
Reviewed by Andreas Kling.
Source/WebCore:
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor): 8-bit TextRun support is now enabled for the GTK port, so the port
can use the simple line layout.
Source/WTF:
- wtf/FeatureDefines.h: Enable the 8-bit TextRun support for the GTK port.
Oct 27, 2013:
- 10:42 PM Changeset in webkit [158101] by
-
- 5 edits in trunk/Source/WebKit2
WebIconDatabase can miss private browsing state changes.
<rdar://problem/15322318> and https://bugs.webkit.org/show_bug.cgi?id=123375
Reviewed by Alexey Proskuryakov.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::willStartUsingPrivateBrowsing): Call setAnyPageGroupMightHavePrivateBrowsingEnabled(true) on each context.
(WebKit::WebContext::willStopUsingPrivateBrowsing): Call setAnyPageGroupMightHavePrivateBrowsingEnabled(false) on each context.
(WebKit::WebContext::setPrivateBrowsingEnabled): In addition to notifying other processes about private browsing
sessions, notify the context’s WebIconDatabase about the change in value.
- UIProcess/WebContext.h:
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::setDatabasePath): Prime the IconDatabase with an initial private browsing value.
(WebKit::WebIconDatabase::setAnyPageGroupMightHavePrivateBrowsingEnabled):
- UIProcess/WebIconDatabase.h:
- 6:59 PM Changeset in webkit [158100] by
-
- 2 edits in trunk/Source/WebCore
Fix 4 asserting SVG tests after r158097.
RenderElement::setStyle() is, quite surprisingly, a virtual function
with a single override in RenderSVGBlock.
To match the old behavior, we have to rewrite the display type from
any inline type to block instead.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::initializeStyle):
- 5:17 PM Changeset in webkit [158099] by
-
- 2 edits in trunk/Source/WebCore
Tone down overzealous assertion from r158097.
RenderElement::initializeStyle() really only cares that there are no
text renderers that we should be calling styleDidChange() on.
Tweak the code to only check that there are no text children.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::initializeStyle):
- 4:06 PM Changeset in webkit [158098] by
-
- 4 edits in trunk/Source/WebCore
Enable center and right text alignment for simple lines
https://bugs.webkit.org/show_bug.cgi?id=123398
Reviewed by Andreas Kling.
Support text-align:center and text-align:right on simple line layout path.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
text-align:justify is still not supported.
(WebCore::SimpleLineLayout::computeLineLeft):
(WebCore::SimpleLineLayout::createLines):
Do a rounding dance that matches the line boxes.
- rendering/SimpleLineLayout.h:
Add left position to lines.
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::Resolver::Line::rect):
We now do rounding during layout.
(WebCore::SimpleLineLayout::Resolver::Line::baseline):
- 3:54 PM Changeset in webkit [158097] by
-
- 346 edits in trunk/Source/WebCore
Renderers should receive their style at construction.
<https://webkit.org/b/123396>
Pass the RenderStyle to all non-text renderer constructors.
After construction, initializeStyle() must be called (as a stopgap
measure) until we are able to do style-derived initialization
without virtual function calls.
With this change, RenderElement::m_style is never null. Subsequent
patches will add enforcement for this and also make style() return
a RenderStyle&.
I'm adding three FIXME's in this patch:
- createRendererIfNeeded() calls AnimationController to set up the initial style manually instead of asking RenderElement's setAnimatedStyle() to do it. This can probably be done in a nicer way, but it's not clear yet how.
- ImageContentData::createRenderer() does a bit of unnecessary work. This should be easy to clean up but got too distracting to be part of this patch.
- Document::createRenderTree() creates the RenderView with an initial dummy RenderStyle. I've done this because resolving the document style assumes we already have a RenderView.
For styleWillChange() implementations to detect that they are
reacting to the initial style, I've added a hasInitializedStyle()
function on RenderElement. This will return false until you've
called initializeStyle() on the renderer. This should go away
along with initializeStyle() eventually.
Reviewed by Antti Koivisto.
Oct 26, 2013:
- 7:36 PM Changeset in webkit [158096] by
-
- 8 edits in trunk/Source
[mac] Remove WebTiledLayer
https://bugs.webkit.org/show_bug.cgi?id=123395
Reviewed by Anders Carlsson.
Source/WebCore:
Mac doesn't use CATiledLayer at all anymore. We have to keep
LayerTypeTiledLayer around for Windows, for now, but we can
get rid of WebTiledLayer and some related Mac-specific code.
No new tests, just removing dead code.
- WebCore.xcodeproj/project.pbxproj:
Remove WebTiledLayer.*
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::PlatformCALayerMac):
Remove synchronouslyDisplayTilesInRect, which was only used for WebTiledLayer on Mac.
Remove WebTiledLayer instantiation and setup code.
- platform/graphics/mac/WebTiledLayer.h: Removed.
- platform/graphics/mac/WebTiledLayer.mm: Removed.
Source/WebKit2:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Remove synchronouslyDisplayTilesInRect.
- 5:48 PM Changeset in webkit [158095] by
-
- 4 edits in trunk/Websites/test-results
Make new bug link in flakiness dashboard configurable
https://bugs.webkit.org/show_bug.cgi?id=123386
Reviewed by Alexey Proskuryakov.
- config.json: Added Bugzilla as the default destination for new bugs.
- public/api/manifest.php: Include newBugLinks in the manifest.
- public/index.html:
(TestResultsView): Initialize _newBugLinks.
(TestResultsView.setNewBugLinks): Added.
(TestResultsView._populateTestPane):
(TestResultsView._createTestResultRow): Replaced the hard-coded Bugzilla URL by the code
to generate hyper-links based on _newBugLinks. Also added a nullity check while formatting
revision checks so that we don't blow up when some build doesn't contain all revision info.
(TestResultsView._populateBuilderPane):
- 5:48 PM Changeset in webkit [158094] by
-
- 3 edits in trunk/Websites/test-results
New flakiness dashboard should support substring matching
https://bugs.webkit.org/show_bug.cgi?id=123393
Reviewed by Alexey Proskuryakov.
Addressed the use cases by
- Always showing the candidate even when there is exactly one test matching the current value.
- Adding all tests that match the current value upon the user pressing enter key.
- public/index.html:
(fetchManifest): Add all tests that match the current value. Confirm whether the user really
want to add all the tests when there are more than 15 tests to add.
- public/js/autocompleter.js:
(Autocompleter.prototype.filterCandidates): Extracted from _updateCandidates.
(Autocompleter.prototype._updateCandidates): Show the candidate window even when there is
exactly one test that matches the criteria so that the user can select this test.
- 5:47 PM Changeset in webkit [158093] by
-
- 2 edits in trunk/Websites/test-results
New flakiness dashboard shouldn't treat tests with right expectations as failing
https://bugs.webkit.org/show_bug.cgi?id=123385
Reviewed by Alexey Proskuryakov.
We define failing tests to be tests with wrong expectations whose actual results are not PASS
since tests with TEXT, IMAGE, etc... failures do not turn the bots red as long as the expectation
of the same type is specified in TestExpectation files.
- public/include/test-results.php:
(FailingResultsJSONWriter): Inherit from WrongExpectationsResultsJSONWriter.
- 1:42 PM Changeset in webkit [158092] by
-
- 2 edits in trunk/LayoutTests
Crashy WebGL test is crashy.
- platform/mac/TestExpectations:
- 1:23 PM Changeset in webkit [158091] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] -[WKBackForwardList forwardItem] returns the back item
https://bugs.webkit.org/show_bug.cgi?id=123391
Reviewed by Mark Rowe.
- UIProcess/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList forwardItem]): Changed back to forward.
- 11:59 AM Changeset in webkit [158090] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderImageResourceStyleImage always has a StyleImage.
<https://webkit.org/b/123390>
Codify the fact that RenderImageResourceStyleImage always wraps an
existing StyleImage object.
Reviewed by Antti Koivisto.
- 11:45 AM Changeset in webkit [158089] by
-
- 2 edits in trunk/LayoutTests
Skip two WebGL tests that either crash or fail.
- platform/mac/TestExpectations:
- 11:39 AM Changeset in webkit [158088] by
-
- 4 edits in trunk/Source/WebCore
Revert some accidental changes.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontSelector.cpp:
- css/CSSFontSelector.h:
- 10:09 AM Changeset in webkit [158087] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed, rolling out r158075.
http://trac.webkit.org/changeset/158075
https://bugs.webkit.org/show_bug.cgi?id=123389
Broke WebKit2.PrivateBrowsingPushStateNoHistoryCallback API
test (Requested by ap on #webkit).
- UIProcess/WebContext.cpp:
(WebKit::WebContext::willStartUsingPrivateBrowsing):
(WebKit::WebContext::willStopUsingPrivateBrowsing):
- UIProcess/WebContext.h:
- UIProcess/WebIconDatabase.cpp:
- UIProcess/WebIconDatabase.h:
- 9:11 AM Changeset in webkit [158086] by
-
- 2 edits in trunk/Source/WebCore
Gardening: fixed broken build.
https://bugs.webkit.org/show_bug.cgi?id=123354.
- css/CSSFontSelector.h:
- 8:44 AM Changeset in webkit [158085] by
-
- 7 edits in trunk
Source/WebCore: fast/frames/seamless/seamless-nested-crash.html asserts on wk2 only
https://bugs.webkit.org/show_bug.cgi?id=123354
Reviewed by Andreas Kling.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
Don't enable simple line layout if the primary font is loading. The code expects
to use the primary font metrics for all lines but those won't match the fallbacks
when font is not loaded.
LayoutTests: fast/frames/seamless/seamless-nested-crash.html asserts on wk2 only
https://bugs.webkit.org/show_bug.cgi?id=123354
Reviewed by Andreas Kling.
- TestExpectations: Remove failure expectation
- 8:17 AM Changeset in webkit [158084] by
-
- 2 edits in trunk/Source/WebKit2
Remove Coordinated Graphics bits from DrawingAreaProxyImpl
https://bugs.webkit.org/show_bug.cgi?id=123382
Reviewed by Anders Carlsson.
As of r156861, Coordinated Graphics does not use DrawingAreaProxyImpl.
So, Coordinated Graphics bits should be removed from DrawingAreaProxyImpl.
- UIProcess/DrawingAreaProxyImpl.h:
- 4:02 AM Changeset in webkit [158083] by
-
- 14 edits in trunk/Source/WebCore
[GTK] Deprecate public dispatch_event method in objects implementing EventTarget interface
https://bugs.webkit.org/show_bug.cgi?id=123261
Reviewed by Gustavo Noronha Silva.
The interface function should be used instead.
- bindings/scripts/CodeGeneratorGObject.pm:
(GetFunctionDeprecationInformation): Helper function to return the
version when the function was deprecated and the function
replacing the deprecated one.
(GenerateFunction): Check if the function is deprecated to mark it
as such in the header and API docs.
- bindings/scripts/gobject-generate-headers.pl: Replace the unused
WEBKIT_OBSOLETE_API macro with new macros to mark function as
deprecated, using the glib macros so that we don't need checks for
the platform.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
- bindings/scripts/test/GObject/WebKitDOMTestException.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
- bindings/scripts/test/GObject/WebKitDOMattribute.h:
- 12:16 AM Changeset in webkit [158082] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] clang static analyzer warns about object being autoreleased too many times in +[WKNSArray web_arrayWithImmutableArray:]
https://bugs.webkit.org/show_bug.cgi?id=123384
Reviewed by Mark Rowe.
- Shared/Cocoa/WKNSArray.h: Annotated -web_initWithImmutableArray: as an init method.
Oct 25, 2013:
- 11:37 PM Changeset in webkit [158081] by
-
- 3 edits in trunk/Source/WebKit2
Fix the ENABLE(CSS_FILTERS) && USE(COORDINATED_GRAPHICS) build after r157803
https://bugs.webkit.org/show_bug.cgi?id=123330
Reviewed by Darin Adler.
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
- 11:13 PM Changeset in webkit [158080] by
-
- 2 edits in trunk/Websites/test-results
Build fix. The query results weren't sorted by the latest commit time,
yielding wrong set of tests to be listed in the builder pane.
- public/include/test-results.php:
- 10:50 PM Changeset in webkit [158079] by
-
- 2 edits in trunk/Websites/test-results
Links in new flakiness dashboard could benefit from tooltips
https://bugs.webkit.org/show_bug.cgi?id=123381
Reviewed by Alexey Proskuryakov.
Add title content attribute on each hyperlink in the builder pane.
- public/index.html:
(TestResultsView._populateBuilderPane):
- 10:41 PM Changeset in webkit [158078] by
-
- 2 edits1 move1 add1 delete in trunk/LayoutTests
REGRESSION (r158069): platform/mac/fast/loader/file-url-mimetypes.html
is failing on all Mountain Lion bots.
- platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt: Removed.
- platform/mac-mountainlion/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Copied from LayoutTests/platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt.
Mountain Lion results for platform/mac tests need to be in this crazy place apparently.
- platform/mac/fast/loader/file-url-mimetypes-expected.txt:
- platform/mac/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Removed.
Mavericks results should be in platform/mac, not platform/mac/platform/mac.
Yes, the latter works and takes precedence, but it's wrong.
- 6:23 PM Changeset in webkit [158077] by
-
- 2 edits in trunk/Websites/test-results
Commit the right change.
- public/index.html:
- 6:19 PM Changeset in webkit [158076] by
-
- 2 edits in trunk/Websites/test-results
The new flakiness dashboard should sort builder and test names
https://bugs.webkit.org/show_bug.cgi?id=123363
Reviewed by Simon Fraser.
Sort the forgotten builders in the menu.
- public/index.html:
- 5:29 PM Changeset in webkit [158075] by
-
- 5 edits in trunk/Source/WebKit2
WebIconDatabase can miss private browsing state changes.
<rdar://problem/15322318> and https://bugs.webkit.org/show_bug.cgi?id=123375
Reviewed by Beth Dakin.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::willStartUsingPrivateBrowsing): Call setPrivateBrowsingEnabled(true) on each context.
(WebKit::WebContext::willStopUsingPrivateBrowsing): Call setPrivateBrowsingEnabled(false) on each context.
(WebKit::WebContext::setPrivateBrowsingEnabled): In addition to notifying other processes, notify WebIconDatabase.
- UIProcess/WebContext.h:
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::setPrivateBrowsingEnabled):
- UIProcess/WebIconDatabase.h:
- 5:25 PM Changeset in webkit [158074] by
-
- 3 edits in trunk/Source/JavaScriptCore
Refactor parser rollback logic
https://bugs.webkit.org/show_bug.cgi?id=123372
Reviewed by Brady Eidson.
Add a sane abstraction for rollbacks in the parser.
- parser/Parser.cpp:
(JSC::::parseSourceElements):
(JSC::::parseObjectLiteral):
- parser/Parser.h:
(JSC::Parser::createSavePoint):
(JSC::Parser::restoreSavePoint):
- 5:02 PM Changeset in webkit [158073] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r156315. <rdar://problem/15109335>
- 4:53 PM Changeset in webkit [158072] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: PrettyPrinting tool should have save button
https://bugs.webkit.org/show_bug.cgi?id=123371
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-25
Reviewed by Timothy Hatcher.
Add buttons to save as a URL to share or to save/clear to
localStorage for easier reloads testing local changes.
- Tools/PrettyPrinting/index.html:
- 4:46 PM Changeset in webkit [158071] by
-
- 2 edits in trunk/LayoutTests
Tweak some test expectations.
- platform/mac/TestExpectations:
- 4:35 PM Changeset in webkit [158070] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Mark skipped webgl conformance tests as either flakey or failures.
Also reorganize expectations for WebGL a bit.
- platform/mac/TestExpectations:
- 4:33 PM Changeset in webkit [158069] by
-
- 2 edits1 copy8 adds in trunk/LayoutTests
Add Mavericks-specific results for some tests.
- platform/mac-mountainlion/fast/loader/file-url-mimetypes-expected.txt: Added.
- platform/mac-mountainlion/http/tests/xmlhttprequest/head-redirection-expected.txt: Copied from LayoutTests/platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt.
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt: Added.
- platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt: Added.
- platform/mac/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
- 4:29 PM Changeset in webkit [158068] by
-
- 3 edits3 copies2 adds in branches/safari-537.73-branch
Merged r156214. <rdar://problem/15109485>
- 4:22 PM Changeset in webkit [158067] by
-
- 7 edits2 copies in branches/safari-537.73-branch
Merged r155665. <rdar://problem/15109475>
- 4:16 PM Changeset in webkit [158066] by
-
- 2 edits in trunk/LayoutTests
Mark some CSS filters and SVG ref tests as failing, and two WebGL tests are flakey.
- platform/mac/TestExpectations:
- 4:03 PM Changeset in webkit [158065] by
-
- 4 edits2 copies in branches/safari-537.73-branch
Merged r155608. <rdar://problem/15109361>
- 3:52 PM Changeset in webkit [158064] by
-
- 2 edits1 copy8 adds in trunk/LayoutTests
Mavericks results with MountainLion variants.
- platform/mac-mountainlion/fast/repaint/search-field-cancel-expected.txt: Added.
- platform/mac-mountainlion/fast/text/backslash-to-yen-sign-euc-expected.txt: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt.
- platform/mac-mountainlion/fast/text/international/cjk-segmentation-expected.txt: Added.
- platform/mac/fast/repaint/search-field-cancel-expected.txt: Added.
- platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
- platform/mac/fast/text/international/cjk-segmentation-expected.txt: Added.
- platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
- platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.
- 3:45 PM Changeset in webkit [158063] by
-
- 3 edits4 copies in branches/safari-537.73-branch
Merged r155546. <rdar://problem/15109351>
- 3:24 PM Changeset in webkit [158062] by
-
- 2 edits2 adds in trunk/LayoutTests
Web Inspector: CSS Regions: Add layout tests for the new events in the DOMTreeManager
https://bugs.webkit.org/show_bug.cgi?id=123361
Reviewed by Timothy Hatcher.
Created a test to check that WebInspector.DOMTree.Event.ContentFlowWasAdded and
WebInspector.DOMTree.Event.ContentFlowWasRemoved are dispatched when a flow is added
and removed.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.assert): Similar to InspectorTest.log, but also takes a boolean and prefixes the message
with "FAIL" or "PASS" depending on the value.
(InspectorTest.importInspectorScripts): Added the required CSS Agent scripts to enable the flow thread events.
- inspector-protocol/model/content-flow-list-expected.txt: Added.
- inspector-protocol/model/content-flow-list.html: Added.
- 3:23 PM Changeset in webkit [158061] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Command+Click on url(…) should go to image not source line
https://bugs.webkit.org/show_bug.cgi?id=123362
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-25
Reviewed by Timothy Hatcher.
CodeMirror changed "url" from being type "variable-2" to "string-2".
- UserInterface/CodeMirrorAdditions.js:
- 3:10 PM Changeset in webkit [158060] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r155468.
- 3:08 PM Changeset in webkit [158059] by
-
- 8 edits4 copies in branches/safari-537.73-branch
Merged r155461. <rdar://problem/15109345>
- 3:03 PM Changeset in webkit [158058] by
-
- 3 edits in trunk/Source/WebCore
DatabaseManager's ProposedDatabases need to be thread-safe.
https://bugs.webkit.org/show_bug.cgi?id=123313.
Reviewed by Geoffrey Garen.
No new tests.
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::DatabaseManager):
(WebCore::DatabaseManager::existingDatabaseContextFor):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::didConstructDatabaseContext):
(WebCore::DatabaseManager::didDestructDatabaseContext):
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::addProposedDatabase):
(WebCore::DatabaseManager::removeProposedDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):
- Modules/webdatabase/DatabaseManager.h:
- 3:01 PM Changeset in webkit [158057] by
-
- 4 edits in trunk/Source/JavaScriptCore
[Win] Javascript crash with DFG JIT enabled.
https://bugs.webkit.org/show_bug.cgi?id=121001
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-25
Reviewed by Geoffrey Garen.
On windows, using register GPRInfo::regT0 as parameter to e.g. JIT::storeDouble(..., GPRInfo::regT0)),
results in a call to JIT::storeDouble(FPRegisterID src, const void* address),
where the address parameter gets the value of GPRInfo::regT0, which is 0 (eax on Windows).
This causes the register to be written to address 0, hence the crash.
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::storeDouble): Assert if we try to generate code which writes to a null pointer.
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit): Use address in regT0 as parameter.
- dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator): Ditto.
- 3:01 PM Changeset in webkit [158056] by
-
- 2 edits in trunk/Websites/test-results
The new flakiness dashboard should sort builder and test names
https://bugs.webkit.org/show_bug.cgi?id=123363
Reviewed by Simon Fraser.
Sort builders and tests by their name in each pane.
- public/index.html:
(TestResultsView._populateTestPane): Lexicologically sort builders by their name.
(TestResultsView._sortObjectsByName): Added.
(TestResultsView._populateBuilderPane): Lexicologically sort builders by their name.
- 2:57 PM Changeset in webkit [158055] by
-
- 4 edits in trunk/Websites/test-results
Merge revision columns in flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123360
Reviewed by Simon Fraser.
Merge revision numbers into one cell separated by /, and clearly label them as "latest revisions".
Also add colors for missing & audio failures so that they won't be an empty cell.
- public/index.html:
(TestResultsView._createTestResultHeader): Create a single th for the list of repository names.
(TestResultsView._createTestResultRow): Use single td for all revision numbers.
- public/js/build.js:
(.this.formattedRevision): Don't prefix revision numbers with '@' when we're not in the tooltip.
- public/main.css:
(.resultsTable .AUDIO a): Added.
(.resultsTable .MISSING a): Added.
- 2:54 PM Changeset in webkit [158054] by
-
- 3 edits in branches/safari-537.73-branch/Source/WebKit/win
Merged r155212. <rdar://problem/15109471>
- 2:51 PM Changeset in webkit [158053] by
-
- 4 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r155153. <rdar://problem/15109457>
- 2:32 PM Changeset in webkit [158052] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r155127. <rdar://problem/15109454>
- 2:31 PM Changeset in webkit [158051] by
-
- 7 edits in trunk
Fix a number of problems with destructuring of arguments
https://bugs.webkit.org/show_bug.cgi?id=123357
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This renames the destructuring node's emitBytecode to bindValue
in order to remove the existing confusion over what was happening.
We then fix an incorrect fall through in the destructuring arguments
logic, and fix the then exposed bug where we placed the index rather
than value into the bound property.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::DeconstructingAssignmentNode::emitBytecode):
(JSC::ArrayPatternNode::bindValue):
(JSC::ArrayPatternNode::emitDirectBinding):
(JSC::ObjectPatternNode::bindValue):
(JSC::BindingNode::bindValue):
- parser/Nodes.h:
LayoutTests:
Add additional testing
- js/destructuring-assignment-expected.txt:
- js/script-tests/destructuring-assignment.js:
- 1:59 PM Changeset in webkit [158050] by
-
- 25 edits16 adds in trunk/Source
Upstream ENABLE(REMOTE_INSPECTOR) and enable on iOS and Mac
https://bugs.webkit.org/show_bug.cgi?id=123111
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- WebCore.exp.in:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/cf:
- WebCoreSupport/WebInspectorClientCF.cpp:
Source/WebKit/ios:
iOS does not have a local inspector, only remote. So give it a custom
implementation separate from the WebKit/mac WebInspectorClient
implementation which handles an attaching/detaching local inspector.
- WebKit.xcodeproj/project.pbxproj:
- ios/WebCoreSupport/WebInspectorClientIOS.mm: Added.
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::bringFrontendToFront):
(WebInspectorClient::closeInspectorFrontend):
(WebInspectorClient::didResizeMainFrame):
(WebInspectorClient::highlight):
(WebInspectorClient::hideHighlight):
(WebInspectorClient::didSetSearchingForNode):
(WebInspectorClient::sendMessageToFrontend):
(WebInspectorClient::sendMessageToBackend):
(WebInspectorClient::setupRemoteConnection):
(WebInspectorClient::teardownRemoteConnection):
(WebInspectorClient::hasLocalSession):
(WebInspectorClient::canBeRemotelyInspected):
(WebInspectorClient::inspectedWebView):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebInspectorFrontendClient::attachAvailabilityChanged):
(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::localizedStringsURL):
(WebInspectorFrontendClient::bringToFront):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::disconnectFromBackend):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::setAttachedWindowHeight):
(WebInspectorFrontendClient::setAttachedWindowWidth):
(WebInspectorFrontendClient::setToolbarHeight):
(WebInspectorFrontendClient::inspectedURLChanged):
(WebInspectorFrontendClient::updateWindowTitle):
(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):
Source/WebKit/mac:
The actual implementation at the WebCoreSupport/WebInspectorClient level
is the same as INSPECTOR_SERVER. Give debuggable pages a pageIdentifer.
- Configurations/FeatureDefines.xcconfig:
- Misc/WebKitLogging.h:
Misc.
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient::pageId):
(WebInspectorClient::setPageId):
Give WebInspectorClient's a page identifier.
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::sendMessageToFrontend):
(WebInspectorClient::sendMessageToBackend):
(WebInspectorClient::setupRemoteConnection):
(WebInspectorClient::teardownRemoteConnection):
(WebInspectorClient::hasLocalSession):
(WebInspectorClient::canBeRemotelyInspected):
(WebInspectorClient::inspectedWebView):
A WebInspectorClient can be either local or remote. Add handling
for remote connections.
- WebInspector/remote/WebInspectorClientRegistry.h: Added.
- WebInspector/remote/WebInspectorClientRegistry.mm: Added.
(+[WebInspectorClientRegistry sharedRegistry]):
(-[WebInspectorClientRegistry init]):
(-[WebInspectorClientRegistry _getNextAvailablePageId]):
(-[WebInspectorClientRegistry registerClient:]):
(-[WebInspectorClientRegistry unregisterClient:]):
(-[WebInspectorClientRegistry clientForPageId:]):
(-[WebInspectorClientRegistry inspectableWebViews]):
Registry for all potentially debuggable pages. All WebInspectorClient instances.
- WebInspector/remote/WebInspectorRelayDefinitions.h: Added.
Constants (message keys) shared between WebKit and the XPC process.
- WebInspector/remote/WebInspectorServer.h: Added.
- WebInspector/remote/WebInspectorServer.mm: Added.
(-[WebInspectorServer init]):
(-[WebInspectorServer dealloc]):
(-[WebInspectorServer start]):
(-[WebInspectorServer stop]):
(-[WebInspectorServer isEnabled]):
(-[WebInspectorServer xpcConnection]):
(-[WebInspectorServer setupXPCConnectionIfNeeded]):
(-[WebInspectorServer pushListing]):
(-[WebInspectorServer hasActiveDebugSession]):
(-[WebInspectorServer setHasActiveDebugSession:]):
(-[WebInspectorServer xpcConnection:receivedMessage:userInfo:]):
(-[WebInspectorServer xpcConnectionFailed:]):
(-[WebInspectorServer didRegisterClient:]):
(-[WebInspectorServer didUnregisterClient:]):
Singleton to start/stop remote inspection. Handles the connection to the XPC
and hands off connections to the connection controller.
- WebInspector/remote/WebInspectorServerWebViewConnection.h: Added.
- WebInspector/remote/WebInspectorServerWebViewConnection.mm: Added.
(-[WebInspectorServerWebViewConnection initWithController:connectionIdentifier:destination:identifier:]):
(-[WebInspectorServerWebViewConnection setupChannel]):
(-[WebInspectorServerWebViewConnection dealloc]):
(-[WebInspectorServerWebViewConnection connectionIdentifier]):
(-[WebInspectorServerWebViewConnection identifier]):
(-[WebInspectorServerWebViewConnection clearChannel]):
(-[WebInspectorServerWebViewConnection sendMessageToFrontend:]):
(-[WebInspectorServerWebViewConnection sendMessageToBackend:]):
(-[WebInspectorServerWebViewConnection receivedData:]):
(-[WebInspectorServerWebViewConnection receivedDidClose:]):
An individual remote debug session connection.
- WebInspector/remote/WebInspectorServerWebViewConnectionController.h: Added.
- WebInspector/remote/WebInspectorServerWebViewConnectionController.mm: Added.
(-[WebInspectorServerWebViewConnectionController initWithServer:]):
(-[WebInspectorServerWebViewConnectionController dealloc]):
(-[WebInspectorServerWebViewConnectionController closeAllConnections]):
(-[WebInspectorServerWebViewConnectionController _listingForWebView:pageId:registry:]):
(-[WebInspectorServerWebViewConnectionController _pushListing:]):
(-[WebInspectorServerWebViewConnectionController pushListing:]):
(-[WebInspectorServerWebViewConnectionController pushListing]):
(-[WebInspectorServerWebViewConnectionController _receivedSetup:]):
(-[WebInspectorServerWebViewConnectionController _receivedData:]):
(-[WebInspectorServerWebViewConnectionController _receivedDidClose:]):
(-[WebInspectorServerWebViewConnectionController _receivedGetListing:]):
(-[WebInspectorServerWebViewConnectionController _receivedIndicate:]):
(-[WebInspectorServerWebViewConnectionController _receivedConnectionDied:]):
(-[WebInspectorServerWebViewConnectionController receivedMessage:userInfo:]):
(-[WebInspectorServerWebViewConnectionController connectionClosing:]):
(-[WebInspectorServerWebViewConnectionController sendMessageToFrontend:userInfo:]):
ConnectionController:
- Holds all the current ongoing remote debug connections.
- Simplifies multi-threaded work on iOS.
- Dispatches incoming messages from the remote connection.
- WebInspector/remote/WebInspectorRemoteChannel.h: Added.
- WebInspector/remote/WebInspectorRemoteChannel.mm: Added.
(+[WebInspectorRemoteChannel createChannelForPageId:connection:]):
(-[WebInspectorRemoteChannel initWithRemote:local:]):
(-[WebInspectorRemoteChannel closeFromLocalSide]):
(-[WebInspectorRemoteChannel closeFromRemoteSide]):
(-[WebInspectorRemoteChannel sendMessageToFrontend:]):
(-[WebInspectorRemoteChannel sendMessageToBackend:]):
Thin interface between the remote connection and web inspector client.
This simplifies breaking the connection from either side, e.g. the
page closing, or the remote connection disconnecting.
- WebInspector/remote/WebInspectorXPCWrapper.h: Added.
- WebInspector/remote/WebInspectorXPCWrapper.m: Added.
(-[WebInspectorXPCWrapper initWithConnection:]):
(-[WebInspectorXPCWrapper close]):
(-[WebInspectorXPCWrapper dealloc]):
(-[WebInspectorXPCWrapper _deserializeMessage:]):
(-[WebInspectorXPCWrapper _handleEvent:]):
(-[WebInspectorXPCWrapper sendMessage:userInfo:]):
(-[WebInspectorXPCWrapper available]):
- WebKit.exp:
XPC Connection wrapper handling a simple message format.
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
(-[WebViewPrivate init]):
(-[WebViewPrivate dealloc]):
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(+[WebView sharedWebInspectorServer]):
(+[WebView _enableRemoteInspector]):
(+[WebView _disableRemoteInspector]):
(+[WebView _disableAutoStartRemoteInspector]):
(+[WebView _isRemoteInspectorEnabled]):
(+[WebView _hasRemoteInspectorSession]):
(-[WebView canBeRemotelyInspected]):
(-[WebView allowsRemoteInspection]):
(-[WebView setAllowsRemoteInspection:]):
(-[WebView setIndicatingForRemoteInspector:]):
(-[WebView setRemoteInspectorUserInfo:]):
(-[WebView remoteInspectorUserInfo]):
Remote inspector private API.
- Enable / disable globally
- Allow / disallow per webview
- Optionally attach a userInfo dictionary on the WebView that is published with listing.
- Indicate a WebView (implementation to land later)
(-[WebView _didCommitLoadForFrame:]):
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidReceiveTitle):
Pages changed, pushed page listing.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
- 1:41 PM Changeset in webkit [158049] by
-
- 2 edits in branches/safari-537-branch/Tools
Merged r157995.
- 1:40 PM Changeset in webkit [158048] by
-
- 3 edits in branches/safari-537-branch/Tools
Merged r157815.
- 1:39 PM Changeset in webkit [158047] by
-
- 3 edits in branches/safari-537-branch/Tools
Merged r157687.
- 1:38 PM Changeset in webkit [158046] by
-
- 3 edits in branches/safari-537-branch/Tools
Merged r157553.
- 1:37 PM Changeset in webkit [158045] by
-
- 5 edits in branches/safari-537-branch/Tools
Merged r154450.
- 1:36 PM Changeset in webkit [158044] by
-
- 12 edits3 adds2 deletes in trunk
[CSS Shapes] CORS-enabled fetch for shape image values
https://bugs.webkit.org/show_bug.cgi?id=123114
Reviewed by Andreas Kling.
Source/WebCore:
Access to shape images is now controlled by CORS CSS shape per
http://dev.w3.org/csswg/css-shapes/#shape-outside-property.
Previously shape images had to be same-origin.
Shape image URL access is defined by the same logic that defines
canvas tainting: same-origin and data URLs are allowed and images
with a "Access-Control-Allow-Origin:" header that's either "*" or
that matches the document's origin.
A PotentiallyCrossOriginEnabled RequestOriginPolicy was added to
ResourceLoaderOptions, to indicate that a "potentially CORS-enabled fetch"
was to be undertaken. The CSSImageValue::cachedImage() method handles this
option by effectively setting the "Origin:" request header (see
updateRequestForAccessControl() in CrossOriginAccessControl.cpp).
StyleResolver::loadPendingShapeImage() uses the new ResourceLoaderOption.
The static ShapeInsideInfo and ShapeOutsideInfo isEnabledFor() method
now performs the CORS check for image valued shapes. The private
isOriginClean() method from CanvasRenderingContext2D has been moved to
the CachedImage class so that it can be shared by the Canvas and Shape
implementations. It checks the response headers per the CORS spec.
Test: http/tests/security/shape-image-cors.html
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage): Handle the new ResourceLoaderOption.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingShapeImage): Set the new ResourceLoaderOption.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createPattern): Use the CachedImage::isOriginClean().
- loader/ResourceLoaderOptions.h: Added PotentiallyCrossOriginEnabled to RequestOriginPolicy.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::isOriginClean): Migrated from CanvasRenderingContext2D.
- loader/cache/CachedImage.h:
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::checkImageOrigin): Do the CORS check and log an error message if neccessary.
- rendering/shapes/ShapeInfo.h:
- rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::isEnabledFor): Call checkImageOrigin() for images.
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::isEnabledFor): Ditto.
LayoutTests:
Verify that images not allowed by CORS don't affect the layout
and that same-origin images, data URLs, and images with a
"Access-Control-Allow-Origin: *" header do define the layout.
Added a simple PHP script that optionally adds the allow origin header.
Replaced and renamed the original shape same-origin-only test.
- http/tests/security/resources/image-access-control.php: Added.
- http/tests/security/shape-image-cors-expected.html: Added.
- http/tests/security/shape-image-cors.html: Added.
- http/tests/security/shape-inside-image-origin-expected.txt: Removed.
- http/tests/security/shape-inside-image-origin.html: Removed.
- 1:36 PM Changeset in webkit [158043] by
-
- 2 edits in branches/safari-537.73-branch/Tools
Merged r157995.
- 1:35 PM Changeset in webkit [158042] by
-
- 3 edits in branches/safari-537.73-branch/Tools
Merged r157815.
- 1:35 PM Changeset in webkit [158041] by
-
- 7 edits6 copies8 adds in trunk/LayoutTests
Mavericks results with MountainLion variants.
- platform/mac-mountainlion/canvas/philip/tests/2d.line.join.parallel-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt.
- platform/mac-mountainlion/fast/css/line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/css/line-height-expected.txt.
- platform/mac-mountainlion/fast/text/drawBidiText-expected.txt: Copied from LayoutTests/platform/mac/fast/text/drawBidiText-expected.txt.
- platform/mac-mountainlion/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
- platform/mac-mountainlion/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
- platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt.
- platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.
- platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt:
- platform/mac/fast/css/line-height-expected.txt:
- platform/mac/fast/text/drawBidiText-expected.txt:
- platform/mac/fast/text/hyphenate-locale-expected.txt:
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
- 1:35 PM Changeset in webkit [158040] by
-
- 6 edits in trunk/Source/WebCore
[MSE] Fix runtime errors caused by mediasource IDL attributes.
https://bugs.webkit.org/show_bug.cgi?id=123352
Reviewed by Eric Carlson.
Due to http://webkit.org/b/123178, MediaSource classes must add a GenerateIsReachable
(and also a JSGenerateToJSObject) attribute to avoid runtime asserts and crashes.
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediasource/WebKitMediaSource.idl:
- Modules/mediasource/WebKitSourceBufferList.idl:
- 1:34 PM Changeset in webkit [158039] by
-
- 3 edits in branches/safari-537.73-branch/Tools
Merged r157687.
- 1:33 PM Changeset in webkit [158038] by
-
- 3 edits in branches/safari-537.73-branch/Tools
Merged r157553.
- 1:32 PM Changeset in webkit [158037] by
-
- 5 edits in branches/safari-537.73-branch/Tools
Merged r154450.
- 1:16 PM Changeset in webkit [158036] by
-
- 3 edits in trunk/Source/WebKit/mac
Fix or disable some deprecation warnings.
Reviewed by Darin Adler.
- Panels/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel cancel:]): On newer OS versions, use the modern API.
(-[WebAuthenticationPanel logIn:]): Ditto.
(-[WebAuthenticationPanel runAsSheetOnWindow:withChallenge:]): Ditto. Translate the
response code in to the form that -sheetDidEnd:responseCode:contextInfo: expects.
- WebView/WebClipView.mm:
(-[WebClipView initWithFrame:]): Disable deprecation warnings since it's not obvious
how to avoid calling -releaseGState here.
- 12:55 PM Changeset in webkit [158035] by
-
- 1 edit3 moves2 adds in trunk/LayoutTests
Apparently we need results in platform/mac-mountainlion/platform/mac/ for MountionLion.
- platform/mac-mountainlion/accessibility/aria-readonly-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/accessibility/form-control-value-settable-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/form-control-value-settable-expected.txt.
- platform/mac-mountainlion/platform/mac/accessibility/press-action-is-first-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/press-action-is-first-expected.txt.
- platform/mac-mountainlion/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Renamed from LayoutTests/platform/mac-mountainlion/accessibility/role-subrole-roledescription-expected.txt.
- 12:44 PM Changeset in webkit [158034] by
-
- 4 edits in trunk/Source/WebKit2
Merge viewInWindowStateDidChange into viewStateDidChange
https://bugs.webkit.org/show_bug.cgi?id=123351
Reviewed by Tim Horton.
- UIProcess/API/mac/WKView.mm:
(-[WKView endDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChangesSync]):
- viewInWindowStateDidChange -> viewStateDidChange
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
- removed viewInWindowStateDidChange, renamed parameter to viewStateDidChange
- UIProcess/WebPageProxy.h:
- removed viewInWindowStateDidChange, named parameter to viewStateDidChange
- 12:15 PM Changeset in webkit [158033] by
-
- 2 edits in trunk/Source/WebKit2
One more URTBF for GTK after r158028.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseMap):
(webkitWebViewBaseUnmap):
- 12:07 PM Changeset in webkit [158032] by
-
- 4 edits in trunk/Source/WebKit2
URTBF from non-Mac platforms after r158028.
- GNUmakefile.list.am:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(toplevelWindowFocusInEvent):
(toplevelWindowFocusOutEvent):
(toplevelWindowVisibilityEvent):
(webkitWebViewBaseSetToplevelOnScreenWindow):
(webkitWebViewBaseSetFocus):
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::setActive):
(WebKit::WebView::setFocused):
(WebKit::WebView::setVisible):
- 12:06 PM Changeset in webkit [158031] by
-
- 2 edits in trunk/LayoutTests
fast/frames/seamless/seamless-nested-crash.html asserts on wk2 only
https://bugs.webkit.org/show_bug.cgi?id=123354
- TestExpectations: Skip for now.
- 11:42 AM Changeset in webkit [158030] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Browser crashed at PlatformGraphicsContext::addDrawLineForText() when trying to upload a video to youtube
https://bugs.webkit.org/show_bug.cgi?id=123349
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-10-25.
Reviewed by George Staikos.
Internally reviewed by George Staikos, Konrad Piascik, Eli Fidler and Arvid Nilsson.
Browser crashed when dereferencing null PlatformGraphicsContext*.
In FrameView::paintControlTints(), we intentionally constructed GraphicsContext
with null PlatformGraphicsContext* and disabled painting by doing
context.setUpdatingControlTints(true). So we should not go further in
GraphicsContext::drawLineForText() if painting is disabled.
Check paintingDisabled() for the other functions in PathBlackBerry.cpp
as well; otherwise, it is likely we will crash at those places.
- platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
- 11:38 AM Changeset in webkit [158029] by
-
- 45 edits44 copies35 adds in trunk/LayoutTests
Mavericks results with MountainLion variants.
- platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/103-expected.txt.
- platform/mac-mountainlion/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
- platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt: Copied from LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt.
- platform/mac-mountainlion/fast/css/input-search-padding-expected.txt: Copied from LayoutTests/platform/mac/fast/css/input-search-padding-expected.txt.
- platform/mac-mountainlion/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
- platform/mac-mountainlion/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
- platform/mac-mountainlion/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt.
- platform/mac-mountainlion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt.
- platform/mac-mountainlion/fast/dom/isindex-001-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-001-expected.txt.
- platform/mac-mountainlion/fast/dom/isindex-002-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-002-expected.txt.
- platform/mac-mountainlion/fast/dynamic/008-expected.txt: Copied from LayoutTests/platform/mac/fast/dynamic/008-expected.txt.
- platform/mac-mountainlion/fast/events/context-no-deselect-expected.txt: Copied from LayoutTests/platform/mac/fast/events/context-no-deselect-expected.txt.
- platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/take-focus-from-iframe-expected.txt.
- platform/mac-mountainlion/fast/lists/dynamic-marker-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/lists/dynamic-marker-crash-expected.txt.
- platform/mac-mountainlion/fast/overflow/overflow-x-y-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.txt.
- platform/mac-mountainlion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt.
- platform/mac-mountainlion/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
- platform/mac-mountainlion/fast/parser/entity-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/entity-comment-in-textarea-expected.txt.
- platform/mac-mountainlion/fast/parser/open-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.txt.
- platform/mac-mountainlion/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt.
- platform/mac-mountainlion/fast/repaint/subtree-root-skipped-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.txt.
- platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt.
- platform/mac-mountainlion/fast/replaced/replaced-breaking-mixture-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt.
- platform/mac-mountainlion/fast/selectors/064-expected.txt: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.txt.
- platform/mac-mountainlion/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt.
- platform/mac-mountainlion/fast/table/003-expected.txt: Copied from LayoutTests/platform/mac/fast/table/003-expected.txt.
- platform/mac-mountainlion/fast/table/colspanMinWidth-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-expected.txt.
- platform/mac-mountainlion/fast/table/colspanMinWidth-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.txt.
- platform/mac-mountainlion/fast/table/spanOverlapRepaint-expected.txt: Copied from LayoutTests/platform/mac/fast/table/spanOverlapRepaint-expected.txt.
- platform/mac-mountainlion/fast/table/text-field-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/table/text-field-baseline-expected.txt.
- platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.txt: Copied from LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.txt.
- platform/mac-mountainlion/fast/text/updateNewFont-expected.txt: Copied from LayoutTests/platform/mac/fast/text/updateNewFont-expected.txt.
- platform/mac-mountainlion/fast/transforms/transformed-focused-text-input-expected.txt: Copied from LayoutTests/platform/mac/fast/transforms/transformed-focused-text-input-expected.txt.
- platform/mac-mountainlion/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt.
- platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt: Copied from LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt.
- platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.txt.
- platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt.
- platform/mac-mountainlion/plugins/mouse-click-plugin-clears-selection-expected.txt: Copied from LayoutTests/platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt.
- platform/mac-mountainlion/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt.
- platform/mac-mountainlion/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt.
- platform/mac-mountainlion/svg/custom/use-on-symbol-inside-pattern-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt.
- platform/mac-mountainlion/svg/hixie/mixed/003-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/mixed/003-expected.txt.
- platform/mac-mountainlion/transforms/2d/zoom-menulist-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/zoom-menulist-expected.txt.
- platform/mac-mountainlion/transforms/3d/general/perspective-non-layer-expected.txt: Copied from LayoutTests/platform/mac/transforms/3d/general/perspective-non-layer-expected.txt.
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/css/continuationCrash-expected.txt:
- platform/mac/fast/css/css2-system-fonts-expected.txt:
- platform/mac/fast/css/input-search-padding-expected.txt:
- platform/mac/fast/css/text-overflow-input-expected.txt:
- platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/mac/fast/dom/isindex-001-expected.txt:
- platform/mac/fast/dom/isindex-002-expected.txt:
- platform/mac/fast/dynamic/008-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
- platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
- platform/mac/fast/overflow/overflow-x-y-expected.txt:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/mac/fast/parser/document-write-option-expected.txt:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
- platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/mac/fast/selectors/064-expected.txt:
- platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
- platform/mac/fast/table/003-expected.txt:
- platform/mac/fast/table/colspanMinWidth-expected.txt:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/mac/fast/table/spanOverlapRepaint-expected.txt:
- platform/mac/fast/table/text-field-baseline-expected.txt:
- platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
- platform/mac/fast/text/updateNewFont-expected.txt:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/platform/mac/fast/text/systemFont-expected.txt:
- platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
- platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/mac/svg/hixie/mixed/003-expected.txt:
- platform/mac/transforms/2d/zoom-menulist-expected.txt:
- platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
- 11:26 AM Changeset in webkit [158028] by
-
- 5 edits1 add in trunk/Source/WebKit2
Move ViewStateFlags out of WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=123323
Reviewed by Sam Weinig.
WebPageProxy contains an enum and typedef that provide a bitfield
of flags describing the visibility of the view containing the page.
We're going to want to use this bitfield in a message to the
WebProcess, so moving out from the UIProcess to shared code.
Creating struct 'ViewState' to scope the enum and typedef.
Renamed ViewStateFlags to ViewState::Flags, and removed redundant
'View' from enum entries.
- Shared/ViewState.h: Added.
- UIProcess/API/mac/WKView.mm:
(-[WKView becomeFirstResponder]):
(-[WKView resignFirstResponder]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
(-[WKView _windowDidResignKey:]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
- UIProcess/WebPageProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- 11:24 AM Changeset in webkit [158027] by
-
- 5 edits1 delete in trunk/Source/WebKit2
Move ViewStateFlags out of WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=123323
Unreviewed
Rolling out 158026 - landed extra chnages!
- Shared/ViewState.h: Removed.
- UIProcess/API/mac/WKView.mm:
(-[WKView becomeFirstResponder]):
(-[WKView resignFirstResponder]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
(-[WKView _windowDidResignKey:]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):
(-[WKView endDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChangesSync]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewInWindowStateDidChange):
(WebKit::WebPageProxy::viewStateDidChange):
- UIProcess/WebPageProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- 11:20 AM Changeset in webkit [158026] by
-
- 5 edits1 add in trunk/Source/WebKit2
Move ViewStateFlags out of WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=123323
Reviewed by Sam Weinig.
WebPageProxy contains an enum and typedef that provide a bitfield
of flags describing the visibility of the view containing the page.
We're going to want to use this bitfield in a message to the
WebProcess, so moving out from the UIProcess to shared code.
Creating struct 'ViewState' to scope the enum and typedef.
Renamed ViewStateFlags to ViewState::Flags, and removed redundant
'View' from enum entries.
- Shared/ViewState.h: Added.
- UIProcess/API/mac/WKView.mm:
(-[WKView becomeFirstResponder]):
(-[WKView resignFirstResponder]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
(-[WKView _windowDidResignKey:]):
(-[WKView _windowDidMiniaturize:]):
(-[WKView _windowDidDeminiaturize:]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView viewDidHide]):
(-[WKView viewDidUnhide]):
(-[WKView _activeSpaceDidChange:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
- UIProcess/WebPageProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- 11:06 AM Changeset in webkit [158025] by
-
- 2 edits1 copy9 adds in trunk/LayoutTests
New results for some accessibility tests.
- platform/mac-mountainlion/accessibility/form-control-value-settable-expected.txt: Added.
- platform/mac-mountainlion/accessibility/lists-expected.txt: Copied from LayoutTests/platform/mac/accessibility/lists-expected.txt.
- platform/mac-mountainlion/accessibility/press-action-is-first-expected.txt: Added.
- platform/mac-mountainlion/accessibility/role-subrole-roledescription-expected.txt: Added.
- platform/mac/accessibility/aria-readonly-expected.txt: Added.
- platform/mac/accessibility/lists-expected.txt:
- platform/mac/platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
- platform/mac/platform/mac/accessibility/press-action-is-first-expected.txt: Added.
- platform/mac/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.
- 11:04 AM Changeset in webkit [158024] by
-
- 4 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154915. <rdar://problem/15109453>
- 11:02 AM Changeset in webkit [158023] by
-
- 9 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154914. <rdar://problem/15109453>
- 11:01 AM Changeset in webkit [158022] by
-
- 2 edits in trunk/Source/WebInspectorUI
Ran update-localizable-strings after changes made in r157947.
Rubber-stamped by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
- 10:59 AM Changeset in webkit [158021] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MSVC again
- 10:47 AM Changeset in webkit [158020] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154890. <rdar://problem/15109453>
- 10:44 AM Changeset in webkit [158019] by
-
- 3 edits2 copies in branches/safari-537.73-branch
Merged r154856. <rdar://problem/15109399>
- 10:35 AM Changeset in webkit [158018] by
-
- 11 edits2 adds in trunk/Source/WebCore
Adding platform implementation of MediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=123301
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-25
Reviewed by Eric Carlson.
No new tests needed.
- CMakeLists.txt:
- Modules/mediastream/AudioStreamTrack.cpp:
(WebCore::AudioStreamTrack::create): Create method now receives a MediaStreamTrackPrivate as parameter.
(WebCore::AudioStreamTrack::AudioStreamTrack):
- Modules/mediastream/AudioStreamTrack.h:
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream): Constructor now iterates through a set of MediaStreamTrackPrivate
instances to create each MediaStreamTrack of MediaStream.
(WebCore::MediaStream::addRemoteSource): Calling AudioStreamTrack and VideoStreamTrack with
MediaStreamTrackPrivate as parameter.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack): Constructor now receives a MediaStreamTrackPrivate, instead of a
MediaStreamSource.
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind): Calling method from MediaStreamTrackPrivate.
(WebCore::MediaStreamTrack::setSource): Ditto.
(WebCore::MediaStreamTrack::id): Ditto.
(WebCore::MediaStreamTrack::label): Ditto.
(WebCore::MediaStreamTrack::enabled): Ditto.
(WebCore::MediaStreamTrack::setEnabled): Ditto.
(WebCore::MediaStreamTrack::muted): Ditto.
(WebCore::MediaStreamTrack::readonly): Ditto.
(WebCore::MediaStreamTrack::remote): Ditto.
(WebCore::MediaStreamTrack::readyState): Ditto.
(WebCore::MediaStreamTrack::states):
(WebCore::MediaStreamTrack::capabilities):
(WebCore::MediaStreamTrack::clone):
(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::ended): Ditto.
(WebCore::MediaStreamTrack::sourceStateChanged): Ditto.
(WebCore::MediaStreamTrack::sourceMutedChanged): Ditto.
(WebCore::MediaStreamTrack::sourceEnabledChanged): Ditto.
(WebCore::MediaStreamTrack::configureTrackRendering):
(WebCore::MediaStreamTrack::stopped): Ditto.
(WebCore::MediaStreamTrack::trackDidEnd): Setting Ended ready state in MediaStreamTrackPrivate.
(WebCore::MediaStreamTrack::trackReadyStateChanged): Dispatches Live or Ended event.
(WebCore::MediaStreamTrack::trackMutedChanged): Dispatches Muted event.
- Modules/mediastream/MediaStreamTrack.h: Now inheriting from MediaStreamTrackPrivateClient.
(WebCore::MediaStreamTrack::source): Calling method from MediaStreamTrackPrivate.
(WebCore::MediaStreamTrack::privateTrack):
- Modules/mediastream/VideoStreamTrack.cpp:
(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack): Create method now receives a MediaStreamTrackPrivate as parameter.
- Modules/mediastream/VideoStreamTrack.h:
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Stores the private tracks in a Vector (property of
MediaStreamDescriptor class).
(WebCore::MediaStreamDescriptor::addTrack): Adds a private track to the tracks' Vector
(WebCore::MediaStreamDescriptor::removeTrack): Removes a private track from the tracks' Vector
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::numberOfAudioSources): Renamed from numberOfAudioStreams.
(WebCore::MediaStreamDescriptor::audioSources): Renamed from audioStreams.
(WebCore::MediaStreamDescriptor::numberOfVideoSources): Renamed from numberOfVideoStreams.
(WebCore::MediaStreamDescriptor::videoSources): Renamed from videoStreams.
(WebCore::MediaStreamDescriptor::numberOfAudioTracks): Returns the number of audio tracks this MediaStreamDescriptor
has.
(WebCore::MediaStreamDescriptor::audioTracks): Returns a audio track, given an index
(WebCore::MediaStreamDescriptor::numberOfVideoTracks): Returns the number of video tracks this MediaStreamDescriptor
has.
(WebCore::MediaStreamDescriptor::videoTracks): Returns a video track, given an index
- platform/mediastream/MediaStreamTrackPrivate.cpp: Added.
- platform/mediastream/MediaStreamTrackPrivate.h: Added.
- 10:30 AM Changeset in webkit [158017] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MSVC
- 10:27 AM Changeset in webkit [158016] by
-
- 2 edits in trunk/Source/WebCore
[CSS Regions][CSS Shapes] Update updateShapeAndSegmentsForCurrentLineInFlowThread to deal better with multiple regions
<https://webkit.org/b/123210>
Reviewed by David Hyatt.
I simplified the determination of the next region part of updateShapeAndSegmentsForCurrentLineInFlowThread's implementation
in order to make the code more straightforward. I also tried to avoid using regionAtBlockOffset(...) function where it's possible,
since it's not always that reliable, what I'll will report in a separate bug.
No new tests, covered by existing tests.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):
- 10:26 AM Changeset in webkit [158015] by
-
- 2 edits in trunk/Source/WebCore
[CSS Regions][CSS Shapes] Update updateShapeAndSegmentsForCurrentLineInFlowThread to deal better with the first lines
<https://bugs.webkit.org/show_bug.cgi?id=123275>
Reviewed by David Hyatt.
We have a complex condition in updateShapeAndSegmentsForCurrentLineInFlowThread, which is
adjusting the first line to the shape's top. This patch adds two boolean to make that clear.
No new tests, no behavior change.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):
- 10:13 AM Changeset in webkit [158014] by
-
- 207 edits in trunk
Improve JSC Parser error messages
https://bugs.webkit.org/show_bug.cgi?id=123341
Reviewed by Andreas Kling.
Source/JavaScriptCore:
This patch moves away from the current cludgy mechanisms used to produce
error messages and moves to something closer to case by case errors.
This results in a large change size as previously we may just have
'failIfFalse(foo)', but now the logic becomes either
'failIfFalseWithMessage(foo, "Cannot do blah with ", foo->thing())'
Or alternatively
if (!foo)
check for 'interesting' errors, before falling back to generic error
This means that this patch is large, but produces no semantic changes, and
only hits slow (e.g. error) paths.
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseDoWhileStatement):
(JSC::::parseWhileStatement):
(JSC::::parseVarDeclarationList):
(JSC::::createBindingPattern):
(JSC::::parseDeconstructionPattern):
(JSC::::parseConstDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseBreakStatement):
(JSC::::parseContinueStatement):
(JSC::::parseReturnStatement):
(JSC::::parseThrowStatement):
(JSC::::parseWithStatement):
(JSC::::parseSwitchStatement):
(JSC::::parseSwitchClauses):
(JSC::::parseSwitchDefaultClause):
(JSC::::parseTryStatement):
(JSC::::parseDebuggerStatement):
(JSC::::parseBlockStatement):
(JSC::::parseStatement):
(JSC::::parseFormalParameters):
(JSC::::parseFunctionBody):
(JSC::stringForFunctionMode):
(JSC::::parseFunctionInfo):
(JSC::::parseFunctionDeclaration):
(JSC::::parseExpressionOrLabelStatement):
(JSC::::parseExpressionStatement):
(JSC::::parseIfStatement):
(JSC::::parseExpression):
(JSC::::parseAssignmentExpression):
(JSC::::parseConditionalExpression):
(JSC::::parseBinaryExpression):
(JSC::::parseProperty):
(JSC::::parseObjectLiteral):
(JSC::::parseStrictObjectLiteral):
(JSC::::parseArrayLiteral):
(JSC::::parsePrimaryExpression):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
(JSC::operatorString):
(JSC::::parseUnaryExpression):
(JSC::::printUnexpectedTokenText):
- parser/Parser.h:
(JSC::Scope::hasDeclaredVariable):
(JSC::Scope::hasDeclaredParameter):
(JSC::Parser::hasDeclaredVariable):
(JSC::Parser::hasDeclaredParameter):
(JSC::Parser::setErrorMessage):
LayoutTests:
Update a vast array of layout test results
- fast/events/window-onerror5-expected.txt:
- js/basic-strict-mode-expected.txt:
- js/break-ASI-expected.txt:
- js/dom/assign-expected.txt:
- js/dom/object-extra-comma-expected.txt:
- js/dom/parse-error-external-script-in-eval-expected.txt:
- js/dom/parse-error-external-script-in-new-Function-expected.txt:
- js/dom/reserved-words-as-property-expected.txt:
- js/function-constructor-error-expected.txt:
- js/function-declaration-expected.txt:
- js/function-toString-object-literals-expected.txt:
- js/function-toString-parentheses-expected.txt:
- js/js-continue-break-restrictions-expected.txt:
- js/kde/garbage-n-expected.txt:
- js/kde/parse-expected.txt:
- js/no-semi-insertion-at-end-of-script-expected.txt:
- js/object-literal-syntax-expected.txt:
- js/parser-xml-close-comment-expected.txt:
- js/regexp-compile-crash-expected.txt:
- js/script-tests/function-constructor-error.js:
- js/script-tests/reserved-words-strict.js:
(isReserved):
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.1_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.2_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.3_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A3.4_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A4_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.10-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.12-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.13-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.14-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.16-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.17-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.20-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.22-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.24-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.25-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.2_Keywords/S7.5.2_A1.9-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.10-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.11-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.16-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.27-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.7-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.9-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.2_T2-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.3_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.5_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.2_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.3_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.5_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T7-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T9-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T3-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples/S7.9.2_A1_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A10_T8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A11_T8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.2_T9-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T4-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T5-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.3_T7-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A6.4_T1-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T7-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/S7.9_A9_T8-expected.txt:
- sputnik/Conformance/08_Types/8.2_The_Null_Type/S8.2_A2-expected.txt:
- sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T3-expected.txt:
- sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T3-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T1-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T2-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T3-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.1_Postfix_Increment_Operator/S11.3.1_A1.1_T4-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T1-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T2-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T3-expected.txt:
- sputnik/Conformance/11_Expressions/11.3_PostfixExpressions/11.3.2_Postfix_Decrement_Operator/S11.3.2_A1.1_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A2_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.11_The_switch_Statement/S12.11_A3_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T10-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T11-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T12-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T14-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T15-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T6-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T7-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T8-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T9-expected.txt:
- sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.1_Block/S12.1_A4_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T6-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T7-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T8-expected.txt:
- sputnik/Conformance/12_Statement/12.4_Expression_Statement/S12.4_A1-expected.txt:
- sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A11-expected.txt:
- sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A6_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.5_The_if_Statement/S12.5_A9_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A12-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A13_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A15-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.1_The_do_while_Statement/S12.6.1_A6_T6-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A13_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A15-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.2_The_while_statement/S12.6.2_A6_T6-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11.1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A11_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12.1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A12_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4.1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A4_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7.1_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A7_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8.1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.3_The_for_Statement/S12.6.3_A8_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A13_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.6_Iteration_Statements/12.6.4_The_for_in_Statement/S12.6.4_A15-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A1_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A5_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A6-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.7_The_continue_Statement/S12.7_A8_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A1_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A5_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A6-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.8_The_break_Statement/S12.8_A8_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T10-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T6-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T7-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T8-expected.txt:
- sputnik/Conformance/12_Statement/12.9_The_return_Statement/S12.9_A1_T9-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.2/15.1.2.1_eval/S15.1.2.1_A2_T2-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.2_Function.prototype.toString/S15.3.4.2_A1_T1-expected.txt:
- 9:37 AM Changeset in webkit [158013] by
-
- 9 edits in trunk/Source/WebKit2
[GTK][WK2] Build break after r157967 and r157972
https://bugs.webkit.org/show_bug.cgi?id=123325
Reviewed by Carlos Garcia Campos.
DrawingArea::visibilityDidChange was removed in favour of a new
message called SetIsVisible which is sent to the WebPage. This
means that {suspend|resume}Paiting are now implemented in a
cross-platform way in WebPage and do not require specific code
from the DrawingArea implementations.
This means that we have to track the toplevel window visibility
and notify the WebPage appropriately about its changes.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::isWindowVisible):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(toplevelWindowVisibilityEvent):
(webkitWebViewBaseSetToplevelOnScreenWindow):
(webkitWebViewBaseIsWindowVisible):
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::suspendPainting):
(WebKit::DrawingAreaImpl::resumePainting):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndWebPageAreFocused):
- 8:58 AM Changeset in webkit [158012] by
-
- 5 edits in trunk/Source/WebCore
Faster way for simple line layout to check if text has fallback fonts
https://bugs.webkit.org/show_bug.cgi?id=123342
Reviewed by Andreas Kling.
Don't use RenderText::knownToHaveNoOverflowAndNoFallbackFonts as it is slow.
Simple text code path test already guarantees there is no overflow. Test for fallback
fonts explicitly.
- platform/graphics/SimpleFontData.h:
Make FINAL.
- rendering/RenderText.cpp:
- rendering/RenderText.h:
Remove knownToHaveNoOverflowAndNoFallbackFonts() as it has no clients.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
Check if all characters can be found from the primary font.
- 7:42 AM Changeset in webkit [158011] by
-
- 7 edits in trunk/Source/WebCore
SVGResourcesCache::clientDestroyed() should take a RenderElement&.
<https://webkit.org/b/123339>
This function is always called with an object, and that object
is guaranteed to never be a text renderer.
Reviewed by Antti Koivisto.
- 6:52 AM Changeset in webkit [158010] by
-
- 8 edits in trunk/Source/WebCore
SVGResourcesCache::clientLayoutChanged() should take a RenderElement&.
<https://webkit.org/b/123336>
This function is always called with an object, and that object
is guaranteed to never be a text renderer.
Reviewed by Antti Koivisto.
- 6:49 AM Changeset in webkit [158009] by
-
- 9 edits in trunk/Source/WebCore
SVGResourcesCache::clientStyleChanged() should take a RenderElement&.
<https://webkit.org/b/123335>
This function is always called with an object, and that object
is guaranteed to never be a text renderer.
Reviewed by Antti Koivisto.
- 6:48 AM Changeset in webkit [158008] by
-
- 14 edits in trunk/Source/WebCore
SVG: postApplyResource() should take a RenderElement&.
<https://webkit.org/b/123334>
This function is always called with an object, and that object
is guaranteed to never be a text renderer.
Reviewed by Antti Koivisto.
- 6:46 AM Changeset in webkit [158007] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r157950): It made many tests assert on Windows, EFL, GTK
https://bugs.webkit.org/show_bug.cgi?id=123309
Reviewed by Andreas Kling.
Disable simple line layout on non-Mac plaforms for now.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- 6:20 AM Changeset in webkit [158006] by
-
- 2 edits in trunk/Websites/test-results
One more build fix. Put each latest revision information in an actual td.
- public/index.html:
- 5:43 AM Changeset in webkit [158005] by
-
- 3 edits in trunk/Websites/test-results
Yet another set of build fixes.
- Manually strip / from revisions JSON if there is any.
- Suppress warnings from ob_end_flush.
- Allow "+" in actual and expected results as used in "TEXT+IMAGE".
- public/api/report.php:
- public/include/test-results.php:
- 5:28 AM Changeset in webkit [158004] by
-
- 20 edits in trunk/Source/WebCore
SVG: applyResource() should take a RenderElement&.
<https://webkit.org/b/123286>
This function is always called with an object, and that object
is guaranteed to never be a text renderer.
Reviewed by Antti Koivisto.
- 5:00 AM Changeset in webkit [158003] by
-
- 15 edits in trunk/Source/WebCore
RenderElement::styleWillChange() should pass newStyle as reference.
<https://webkit.org/b/123332>
When styleWillChange() is called, there is always a new style getting
set so there's no need to handle the null style case.
This flushed out a couple of unnecessary checks.
Reviewed by Antti Koivisto.
- 4:57 AM Changeset in webkit [158002] by
-
- 4 edits in trunk
[GTK] [WebKit2] CanHandleRequest API test fails
https://bugs.webkit.org/show_bug.cgi?id=88453
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-10-25
Reviewed by Martin Robinson.
Source/WebKit2:
Make WebPage::platformCanHandleRequest return false by default
for unknown schemes.
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformCanHandleRequest):
Tools:
- Scripts/run-gtk-tests:
(TestRunner):
- 4:49 AM Changeset in webkit [158001] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile fixes.
https://bugs.webkit.org/show_bug.cgi?id=123269
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-25
Reviewed by Csaba Osztrogonác.
- platform/graphics/win/ImageCairoWin.cpp: Added new parameter to BitmapImage::draw() calls.
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- 4:19 AM Changeset in webkit [158000] by
-
- 1 edit1 move in trunk/Websites/test-results
Another build fix. Move .htaccess to public.
- .htaccess: Removed.
- public/.htaccess: Copied from .htaccess.
- 3:31 AM Changeset in webkit [157999] by
-
- 4 edits1 add in trunk
Use a Vector instead of HashSet to computed the orderValues in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=118620
Reviewed by Antti Koivisto.
PerformanceTests:
From Blink r152960 by <ojan@chromium.org>
New performance test for layouts in flexboxes.
- Layout/flexbox-lots-of-data.html: Added.
Source/WebCore:
Turns out that order is extremelly uncommon so using a Vector is
much less expensive. This also special-cases the much common case
of only having order of value 0 by using Vectors with just one
preallocated member.
Also added the performance test that shows a ~1% win when using a
vector instead of the HashSet.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::OrderIterator::setOrderValues):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
- rendering/RenderFlexibleBox.h:
- 2:52 AM Changeset in webkit [157998] by
-
- 2 edits in trunk/Source/WebCore
Non-SVG build broken after r157950
https://bugs.webkit.org/show_bug.cgi?id=123328
Reviewed by Xan Lopez.
The isSVGInlineTest() check should be done only if SVG is enabled.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- 2:50 AM Changeset in webkit [157997] by
-
- 11 edits in trunk/LayoutTests
[CSS Regions] Rename CSS classes and JS methods in vertical layout tests about selection
https://bugs.webkit.org/show_bug.cgi?id=123327
Reviewed by Mihnea Ovidenie.
For consistency with Blink we use Vertical instead of Vert in CSS
classes and JS methods related to the selection layout tests for CSS
Regions.
- fast/regions/resources/helper.js:
(selectContentByIdsVertical):
- fast/regions/resources/region-style.css:
- fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html:
- fast/regions/selection/selecting-text-ignoring-region-vert-lr.html:
- fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html:
- fast/regions/selection/selecting-text-ignoring-region-vert-rl.html:
- fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html:
- fast/regions/selection/selecting-text-in-2-regions-vert-lr.html:
- fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html:
- fast/regions/selection/selecting-text-in-2-regions-vert-rl.html:
- 1:44 AM Changeset in webkit [157996] by
-
- 8 edits in trunk/Source/WebKit2
[EFL][WK2] Build break after r157967 and r157972
https://bugs.webkit.org/show_bug.cgi?id=123324
Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2013-10-25
Reviewed by Tim Horton.
Since r157967 and r157972, visibilityDidChange was removed from DrawingAreaProxy.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
(WebKit::CoordinatedDrawingAreaProxy::visibilityDidChange):
Removed common logic which r157967 moved to WebProcess.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:
Make visibilityDidChange to public method.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::setVisible):
(WebKit::WebView::isWindowVisible): Added.
- UIProcess/CoordinatedGraphics/WebView.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setWindowIsVisible):
- WebProcess/WebPage/WebPage.h:
Moved m_windowIsVisible to use at all WK2 based port.
(WebKit::WebPage::windowIsVisible):
- WebProcess/WebPage/WebPage.messages.in:
Moved SetWindowIsVisible message to use at all WK2 based port.
- 1:32 AM Changeset in webkit [157995] by
-
- 2 edits in trunk/Tools
Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
- Scripts/webkitpy/port/base.py:
(Port.repository_paths):
- 1:31 AM Changeset in webkit [157994] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Several fast/regions/selection tests are failing in WK2.
Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-10-25
- platform/gtk-wk2/TestExpectations:
- 12:47 AM Changeset in webkit [157993] by
-
- 2 edits in trunk/Websites/test-results
It turns out that the current instruction only works on Mountain Lion.
Also fixed some typos.
- Install.md:
- 12:13 AM Changeset in webkit [157992] by
-
- 5 edits in trunk
[WTF] Add a multiplication operator (and a few others) to MediaTime
https://bugs.webkit.org/show_bug.cgi?id=123137
Reviewed by Eric Carlson.
Source/WTF:
Add a multiplication operator and an inequality operator to the
MediaTime class for use by MSE.
- wtf/MediaTime.cpp:
(WTF::signum): Moved to top of file.
(WTF::MediaTime::operator*): Added.
(WTF::MediaTime::operator!=): Added.
- wtf/MediaTime.h:
(WTF::operator*): Added non-class version of operator*.
Tools:
Add tests for new MediaTime operators.
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):
- 12:07 AM Changeset in webkit [157991] by
-
- 7 edits2 copies in trunk/Source
[Mac] Add helper methods to convert CMTime <--> MediaTime
https://bugs.webkit.org/show_bug.cgi?id=123285
Reviewed by Eric Carlson.
Source/WebCore:
Add utility methods to convert between CMTime (a rational time class) and MediaTime.
Once there, PlatformClockCM can now vend and accept MediaTimes for currentTime.
- platform/mac/MediaTimeMac.h:
- platform/mac/MediaTimeMac.cpp:
(WebCore::toMediaTime): Added conversion utility method.
(WebCore::toCMTime): Ditto.
- platform/mac/PlatformClockCM.h:
- platform/mac/PlatformClockCM.mm:
(PlatformClockCM::setCurrentMediaTime): Added.
(PlatformClockCM::currentMediaTime): Added.
- WebCore.xcodeproj/project.pbxproj: Add new files to project.
Source/WTF:
Add a #ifdef header_h protector.
- wtf/MediaTime.h:
Oct 24, 2013:
- 10:17 PM Changeset in webkit [157990] by
-
- 2 edits1 move1 add in trunk/Websites/test-results
Add an instruction on how to setup test-results app
https://bugs.webkit.org/show_bug.cgi?id=123321
Rubber-stamped by Stephanie Lewis.
Added Install.md and updated config.json accordingly.
Also moved init-database.sql out of public/include since it doesn't need to be accessible via httpd.
- Install.md: Added.
- config.json:
- init-database.sql: Moved from public/include/init-database.sql.
- 9:43 PM Changeset in webkit [157989] by
-
- 2 edits1 copy7 moves1 add1 delete in trunk/Websites/test-results
Move everything except ChangeLog and config.json into public directory.
https://bugs.webkit.org/show_bug.cgi?id=123319
Rubber-stamped by Stephanie Lewis.
- admin: Removed.
- admin/admin.css: Removed.
- admin/builders.php: Removed.
- admin/index.php: Removed.
- admin/repositories.php: Removed.
- api: Removed.
- api/failing-tests.php: Removed.
- api/manifest.php: Removed.
- api/report.php: Removed.
- api/results.php: Removed.
- common.css: Removed.
- config.json: Copied from include/config.json.
- include: Removed.
- include/admin-footer.php: Removed.
- include/admin-header.php: Removed.
- include/config.json: Removed.
- include/db.php: Removed.
- include/init-database.sql: Removed.
- include/json-shared.php: Removed.
- include/test-results.php: Removed.
- index.html: Removed.
- js: Removed.
- js/autocompleter.js: Removed.
- js/build.js: Removed.
- js/dom.js: Removed.
- main.css: Removed.
- public: Added.
- public/admin: Copied from admin.
- public/api: Copied from api.
- public/common.css: Copied from common.css.
- public/include: Copied from include.
- public/include/config.json: Removed.
- public/include/db.php:
- public/index.html: Copied from index.html.
- public/js: Copied from js.
- public/main.css: Copied from main.css.
- 9:22 PM Changeset in webkit [157988] by
-
- 9 edits in trunk/Websites/test-results
Showing lists of flaky tests for a builder takes too long
https://bugs.webkit.org/show_bug.cgi?id=123311
Reviewed by Sam Weinig.
Generate JSONs for tests failing, flaky, or with wrong expectation at the time a builder reports results
instead when the frontend requests to those those results since it takes multiple seconds or minutes to
generate those JSON files.
- api/failing-tests.php: Moved and renamed to manually generate all JSON files for a given builder.
(main):
- api/report.php: Manually flush and end the request (to avoid blocking run-webkit-tests on the other side
for minutes), then generate JSONs for tests that are failing, are flaky, and have wrong expectations.
- api/results.php: Merge format_result_rows here since it's not used anywhere else.
- include/config.json: Added the path to the data directory into which JSON files are generated.
- include/db.php:
(configPath): Takes a relative path value from config.json, and resolves it.
- include/json-shared.php:
(echo_success): Extracted from exit_with_success.
(exit_with_success):
- include/test-results.php:
(add_builder): Extracted from add_build.
(add_build):
(ResultsJSONWriter): Extracted from api/failing-tests.php.
(ResultsJSONWriter.construct):
(ResultsJSONWriter.start):
(ResultsJSONWriter.end):
(ResultsJSONWriter.add_results_for_test_if_matches):
(ResultsJSONWriter.pass_for_failure_type):
(FailingResultsJSONWriter): Extracted from index.html's TestResultsView._matchesFailureType.
(FailingResultsJSONWriter.construct):
(FailingResultsJSONWriter.pass_for_failure_type):
(FlakyResultsJSONWriter): Ditto.
(FlakyResultsJSONWriter.construct):
(FlakyResultsJSONWriter.pass_for_failure_type):
(WrongExpectationsResultsJSONWriter): Ditto.
(WrongExpectationsResultsJSONWriter.construct):
(WrongExpectationsResultsJSONWriter.pass_for_failure_type):
(ResultsJSONGenerator): Ditto.
(ResultsJSONGenerator.construct):
(ResultsJSONGenerator.generate):
(ResultsJSONGenerator.open_json_for_failure_type):
(ResultsJSONGenerator.write_jsons):
- index.html:
(TestResultsView):
(TestResultsView.setBuilders):
(TestResultsView._createResultCell): Add a hyperlink to results.html in the tooltip.
(TestResultsView.fetchFailingTestsForBuilder): Fetch the generated JSON files.
- 9:04 PM Changeset in webkit [157987] by
-
- 44 edits in trunk
Remove references to OS X 10.7 from Xcode configuration settings.
Now that we're not building for OS X 10.7 they're no longer needed.
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/BaseXPCService.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebContentProcess.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/DebugRelease.xcconfig:
- WebKitLauncher/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- 8:59 PM Changeset in webkit [157986] by
-
- 20 edits19 copies6 adds in trunk/LayoutTests
New Mavericks results for editing and fast/html, with MountainLion fallbacks.
- platform/mac-mountainlion/editing/input/caret-at-the-edge-of-input-expected.txt: Copied from LayoutTests/platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt.
- platform/mac-mountainlion/editing/inserting/before-after-input-element-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/before-after-input-element-expected.txt.
- platform/mac-mountainlion/editing/pasteboard/4806874-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/4806874-expected.txt.
- platform/mac-mountainlion/editing/pasteboard/drop-text-without-selection-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt.
- platform/mac-mountainlion/editing/pasteboard/input-field-1-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/input-field-1-expected.txt.
- platform/mac-mountainlion/editing/selection/3690703-2-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-2-expected.txt.
- platform/mac-mountainlion/editing/selection/3690703-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-expected.txt.
- platform/mac-mountainlion/editing/selection/3690719-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690719-expected.txt.
- platform/mac-mountainlion/editing/selection/4895428-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4895428-3-expected.txt.
- platform/mac-mountainlion/editing/selection/4975120-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4975120-expected.txt.
- platform/mac-mountainlion/editing/selection/drag-select-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/drag-select-1-expected.txt.
- platform/mac-mountainlion/editing/selection/replaced-boundaries-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/replaced-boundaries-3-expected.txt.
- platform/mac-mountainlion/editing/selection/select-from-textfield-outwards-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/select-from-textfield-outwards-expected.txt.
- platform/mac-mountainlion/fast/html/details-no-summary4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-no-summary4-expected.txt.
- platform/mac-mountainlion/fast/html/details-open-javascript-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open-javascript-expected.txt.
- platform/mac-mountainlion/fast/html/details-open2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open2-expected.txt.
- platform/mac-mountainlion/fast/html/details-open4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open4-expected.txt.
- platform/mac-mountainlion/fast/html/details-replace-summary-child-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.txt.
- platform/mac-mountainlion/fast/html/details-replace-text-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-text-expected.txt.
- platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/mac/editing/inserting/before-after-input-element-expected.txt:
- platform/mac/editing/pasteboard/4806874-expected.txt:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/mac/editing/pasteboard/input-field-1-expected.txt:
- platform/mac/editing/selection/3690703-2-expected.txt:
- platform/mac/editing/selection/3690703-expected.txt:
- platform/mac/editing/selection/3690719-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/drag-select-1-expected.txt:
- platform/mac/editing/selection/replaced-boundaries-3-expected.txt:
- platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/mac/fast/html/details-no-summary4-expected.txt:
- platform/mac/fast/html/details-open-javascript-expected.txt:
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-open4-expected.txt:
- platform/mac/fast/html/details-replace-summary-child-expected.txt:
- platform/mac/fast/html/details-replace-text-expected.txt:
- 7:33 PM Changeset in webkit [157985] by
-
- 5 edits in trunk/Source/WebCore
Cache line layout path
https://bugs.webkit.org/show_bug.cgi?id=123298
Reviewed by Sam Weinig.
Determining the path can be non-trivial. Avoid computing it repeatedly on relayouts.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::invalidateLineLayoutPath):
(WebCore::RenderBlock::removeChild):
Invalidate the path when children change.
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlockFlow::styleDidChange):
Invalidate the path when style changes.
(WebCore::RenderBlockFlow::deleteLineBoxesBeforeSimpleLineLayout):
(WebCore::RenderBlockFlow::ensureLineBoxes):
- rendering/RenderText.cpp:
(WebCore::RenderText::setText):
Invalidate the path when text changes.
- 6:48 PM Changeset in webkit [157984] by
-
- 3 edits in trunk/Source/WebKit2
Coalesce calls to viewStateDidChange
https://bugs.webkit.org/show_bug.cgi?id=123307
Reviewed by Tim Horton.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidOrderOffScreen:]):
(-[WKView _windowDidOrderOnScreen:]):
- coalesce calls to viewStateDidChange
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
- handle changes to view visibility & active state in correct order.
- 6:46 PM Changeset in webkit [157983] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154694. <rdar://problem/15109413>
- 6:44 PM Changeset in webkit [157982] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154693. <rdar://problem/15109413>
- 6:42 PM Changeset in webkit [157981] by
-
- 44 edits in trunk
<rdar://problem/15312643> Prepare for the mysterious future.
Reviewed by David Kilzer.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/Version.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/BaseXPCService.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/FeatureDefines.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/WebContentProcess.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/DebugRelease.xcconfig:
- WebKitLauncher/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- 6:41 PM Changeset in webkit [157980] by
-
- 3 edits1 copy in branches/safari-537.73-branch
Merged r154681. <rdar://problem/15109418>
- 6:35 PM Changeset in webkit [157979] by
-
- 5 edits in trunk/Source/WebCore
DocumentLoader::cachedResourceLoader() should return a reference.
<https://webkit.org/b/123303>
..and while we're at it, make DocumentLoader::m_cachedResourceLoader
a Ref, and have CachedResourceLoader::create return a PassRef.
Reviewed by Sam Weinig.
- 6:34 PM Changeset in webkit [157978] by
-
- 2 edits in branches/safari-537.73-branch/Source/WTF
Merged r154655. <rdar://problem/15109412>
- 6:32 PM Changeset in webkit [157977] by
-
- 35 edits1 delete in branches/safari-537.73-branch
Merged r154647. <rdar://problem/15109412>
- 6:27 PM Changeset in webkit [157976] by
-
- 3 edits in branches/safari-537.73-branch/Source/WebKit
Merged r154642. <rdar://problem/15109339>
- 6:25 PM Changeset in webkit [157975] by
-
- 1 edit3 copies in branches/safari-537.73-branch/Source/WebKit/win
Merged r154634. <rdar://problem/15109339>
- 6:23 PM Changeset in webkit [157974] by
-
- 10 edits2 copies in branches/safari-537.73-branch/Source/WebKit
Merged r154627. <rdar://problem/15109339>
- 6:21 PM Changeset in webkit [157973] by
-
- 24 edits in branches/safari-537.73-branch
Merged r154527. <rdar://problem/15109367>
- 6:17 PM Changeset in webkit [157972] by
-
- 8 edits in trunk/Source/WebKit2
Stop bringing in the std namespace
https://bugs.webkit.org/show_bug.cgi?id=123273
Patch by Anders Carlsson <andersca@apple.com> on 2013-10-24
Reviewed by Andreas Kling.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformSetCacheModel):
- 6:15 PM Changeset in webkit [157971] by
-
- 143 edits in trunk/Source
Stop bringing in the std namespace
https://bugs.webkit.org/show_bug.cgi?id=123273
Reviewed by Andreas Kling.
Source/WebCore:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::startGrain):
(WebCore::AudioBufferSourceNode::totalPitchRate):
- Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::numberOfChannels):
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
(WebCore::AudioScheduledSourceNode::stop):
- Modules/webaudio/AudioSummingJunction.cpp:
- Modules/webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::process):
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::offlineRender):
- Modules/webaudio/OscillatorNode.cpp:
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::dopplerRate):
- Modules/webaudio/WaveShaperDSPKernel.cpp:
(WebCore::WaveShaperDSPKernel::processCurve):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::hasAdequateQuotaForOrigin):
- Modules/websockets/WebSocket.cpp:
(WebCore::saturateAdd):
- Modules/websockets/WebSocketChannel.cpp:
- Modules/websockets/WebSocketFrame.cpp:
(WebCore::WebSocketFrame::parseFrame):
- accessibility/AccessibilityARIAGrid.cpp:
- accessibility/AccessibilityARIAGridCell.cpp:
- accessibility/AccessibilityARIAGridRow.cpp:
- accessibility/AccessibilityList.cpp:
- accessibility/AccessibilityListBox.cpp:
- accessibility/AccessibilityListBoxOption.cpp:
- accessibility/AccessibilityNodeObject.cpp:
- accessibility/AccessibilityObject.cpp:
- accessibility/AccessibilityRenderObject.cpp:
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
- accessibility/AccessibilityTableCell.cpp:
- accessibility/AccessibilityTableColumn.cpp:
- accessibility/AccessibilityTableHeaderContainer.cpp:
- accessibility/AccessibilityTableRow.cpp:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getOwnPropertyNames):
- bindings/js/JSGeolocationCustom.cpp:
(WebCore::setTimeout):
(WebCore::setMaximumAge):
- bindings/js/ScriptController.cpp:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::writeLittleEndian):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::readString):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::getFontFace):
- css/CSSGradientValue.cpp:
(WebCore::CSSRadialGradientValue::createGradient):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColorParameters):
(WebCore::CSSParser::parseHSLParameters):
- css/CSSReflectValue.cpp:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyFontSize::applyValue):
- css/PropertySetCSSStyleDeclaration.cpp:
- css/SVGCSSParser.cpp:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::viewportPercentageValue):
- dom/CharacterData.cpp:
(WebCore::CharacterData::parserAppendData):
- dom/ContainerNode.cpp:
- dom/Document.cpp:
(WebCore::Document::minimumLayoutDelay):
- dom/Node.cpp:
(WebCore::Node::compareDocumentPosition):
- dom/Range.cpp:
(WebCore::Range::toString):
(WebCore::Range::textRects):
(WebCore::Range::textQuads):
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::scheduleAnimation):
- dom/StyledElement.cpp:
(WebCore::StyledElement::makePresentationAttributeCacheKey):
- dom/Text.cpp:
- dom/ViewportArguments.cpp:
(WebCore::clampLengthValue):
(WebCore::clampScaleValue):
(WebCore::ViewportArguments::resolve):
(WebCore::computeMinimumScaleFactorForContentContained):
(WebCore::restrictMinimumScaleFactorToViewportSize):
- editing/AlternativeTextController.cpp:
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::deleteInsignificantText):
- editing/Editor.cpp:
(WebCore::Editor::setComposition):
(WebCore::Editor::compositionRange):
- editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode):
(WebCore::TextIterator::handleTextBox):
(WebCore::CharacterIterator::string):
(WebCore::SearchBuffer::SearchBuffer):
(WebCore::SearchBuffer::append):
(WebCore::SearchBuffer::prependContext):
(WebCore::SearchBuffer::search):
- editing/VisibleUnits.cpp:
(WebCore::startOfParagraph):
- editing/htmlediting.cpp:
- editing/markup.cpp:
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::didReceiveResponse):
(WebCore::FileReaderLoader::didReceiveData):
- history/BackForwardList.cpp:
(WebCore::BackForwardList::backListWithLimit):
(WebCore::BackForwardList::forwardListWithLimit):
- history/PageCache.cpp:
(WebCore::PageCache::setCapacity):
- html/BaseDateAndTimeInputType.cpp:
- html/FTPDirectoryDocument.cpp:
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getRegion):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
(WebCore::parseColorStringWithCrazyLegacyRules):
- html/HTMLFormControlElement.cpp:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getTextFieldValues):
- html/HTMLImageElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLMapElement.cpp:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::textTrackAddCue):
(WebCore::HTMLMediaElement::textTrackRemoveCue):
(WebCore::HTMLMediaElement::rewind):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::duration):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute):
(WebCore::HTMLSelectElement::updateListBoxSelection):
- html/HTMLSourceElement.cpp:
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::colSpan):
(WebCore::HTMLTableCellElement::rowSpan):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::parseAttribute):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionStart):
(WebCore::HTMLTextFormControlElement::setSelectionEnd):
(WebCore::HTMLTextFormControlElement::select):
(WebCore::HTMLTextFormControlElement::setSelectionRange):
- html/HTMLTrackElement.cpp:
- html/ImageDocument.cpp:
(WebCore::ImageDocument::scale):
- html/InputType.cpp:
(WebCore::InputType::valueAsDouble):
- html/MediaController.cpp:
(MediaController::duration):
(MediaController::currentTime):
(MediaController::setCurrentTime):
(MediaController::updateReadyState):
- html/NumberInputType.cpp:
(WebCore::NumberInputType::setValueAsDouble):
(WebCore::NumberInputType::setValueAsDecimal):
(WebCore::NumberInputType::createStepRange):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::startSearchEventTimer):
- html/StepRange.cpp:
(WebCore::StepRange::clampValue):
(WebCore::StepRange::parseStep):
- html/TimeRanges.cpp:
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
(WebCore::adjustBubblePosition):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::normalizeRect):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlRewindButtonElement::defaultEventHandler):
- html/shadow/MediaControlsApple.cpp:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint):
- inspector/ContentSearchUtils.cpp:
- inspector/DOMEditor.cpp:
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::diff):
- inspector/InjectedScriptHost.cpp:
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::incrementProgress):
- loader/cache/CachedImage.cpp:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):
- page/EventHandler.cpp:
(WebCore::MaximumDurationTracker::~MaximumDurationTracker):
- page/FrameTree.cpp:
- page/FrameView.cpp:
(WebCore::FrameView::adjustedDeferredRepaintDelay):
(WebCore::FrameView::autoSizeIfEnabled):
- page/PrintContext.cpp:
(WebCore::PrintContext::computeAutomaticScaleFactor):
- page/SpatialNavigation.cpp:
(WebCore::entryAndExitPointsForDirection):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFilterOperations):
(WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):
- platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::FloatRect):
(WebCore::FloatRect::intersect):
(WebCore::FloatRect::uniteEvenIfEmpty):
(WebCore::FloatRect::extend):
(WebCore::FloatRect::fitToPoints):
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
(WebCore::GlyphPageTreeNode::getChild):
- platform/graphics/IntRect.cpp:
(WebCore::IntRect::intersect):
(WebCore::IntRect::unite):
(WebCore::IntRect::uniteIfNonZero):
- platform/graphics/LayoutRect.cpp:
(WebCore::LayoutRect::intersect):
(WebCore::LayoutRect::unite):
(WebCore::LayoutRect::uniteIfNonZero):
- platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApplyGeneric):
(WebCore::FEMorphology::platformApplySoftware):
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
- platform/text/TextCodecICU.cpp:
- rendering/LineWidth.cpp:
(WebCore::LineWidth::fitBelowFloats):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::availableLogicalWidthForContent):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::computePreferredLogicalWidths):
(WebCore::RenderFieldset::layoutSpecialExcludedChild):
(WebCore::RenderFieldset::paintBoxDecorations):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::updateLogicalWidth):
(WebCore::RenderFlowThread::addForcedRegionBreak):
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layOutAxis):
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computePreferredLogicalWidths):
- rendering/RenderTableCell.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::selectionHeight):
(WebCore::RootInlineBox::selectionHeightAdjustedForPrecedingBlock):
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::layout):
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::layout):
- rendering/style/RenderStyle.h:
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::imageSize):
- style/StyleFontSizeFunctions.cpp:
(WebCore::Style::fontSizeForKeyword):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setCurrentTime):
Source/WebKit/mac:
- WebView/WebFrameView.mm:
(-[WebFrameView _verticalPageScrollDistance]):
(-[WebFrameView _horizontalPageScrollDistance]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _scaleFactorForPrintOperation:]):
- WebView/WebView.mm:
(+[WebView _setCacheModel:]):
(+[WebView _maxCacheModelInAnyInstance]):
(+[WebView _cacheModelChangedNotification:]):
(+[WebView _preferencesRemovedNotification:]):
Source/WebKit2:
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformSetCacheModel):
- 6:12 PM Changeset in webkit [157970] by
-
- 2 edits1 delete in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=123304
The focus-option-control-on-page.html test has behavior that depends on the system
"Full Keyboard Access" prefs, so mark it as passing or failing, and remove a bogus
result that I added.
- platform/mac-mountainlion/platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Removed.
- platform/mac/TestExpectations:
- 5:48 PM Changeset in webkit [157969] by
-
- 57 edits56 copies41 adds in trunk/LayoutTests
More new test results for Mavericks, and MountainLion results where necessary.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-161-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-161-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1188-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1188-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug120107-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12384-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug12384-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1271-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12908-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12910-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug131020-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug13169-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-1-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-3-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug138725-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug138725-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug157890-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1818-3-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1818-6-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug18359-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug18359-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug196870-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug222336-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug222467-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug24200-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug24200-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug26178-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug269566-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug277062-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug28928-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug28928-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug28933-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug29314-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug29326-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug29326-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2954-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug30692-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug4382-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4382-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug46368-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug46368-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug50695-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug51037-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51037-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug51727-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51727-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug52505-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug52505-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug55545-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug55545-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug56201-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug59354-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug59354-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug68912-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug68912-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug7342-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug7342-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug8032-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug92647-2-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/bugs/bug96334-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug96334-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug99948-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug99948-expected.txt.
- platform/mac-mountainlion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt.
- platform/mac-mountainlion/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Added.
- platform/mac-mountainlion/tables/mozilla/core/margins-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/core/margins-expected.txt.
- platform/mac-mountainlion/tables/mozilla/dom/tableDom-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/dom/tableDom-expected.txt.
- platform/mac-mountainlion/tables/mozilla/other/move_row-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/other/move_row-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt.
- platform/mac/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
- platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
- platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
- platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
- platform/mac/tables/mozilla/bugs/bug29326-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
- platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
- platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
- platform/mac/tables/mozilla/bugs/bug68912-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
- platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/mac/tables/mozilla/core/margins-expected.txt:
- platform/mac/tables/mozilla/dom/tableDom-expected.txt:
- platform/mac/tables/mozilla/other/move_row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- 5:43 PM Changeset in webkit [157968] by
-
- 4 edits in trunk/Source/WebKit2
Simplify window occlusion detection code
https://bugs.webkit.org/show_bug.cgi?id=123300
Reviewed by Tim Horton.
Currently the WKView tries to maintain a copy of the window's occluded state,
but forced to NO when occlusion detection is disabled (and capable of handling
dectection being dynamically toggled). Simpler to just rely on the actual value
from the window, && the enabled setting. Cleaning this up revealed that we're
not sending a viewStateDidChange to the WebPageProxy when the occlusion state
changes, which we probably should be.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewVisible):
- check the real value of occlusion state from the window.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
- don't update cached value.
(-[WKView _windowDidChangeOcclusionState:]):
- don't update cached value, but do send viewStateDidChange to the WebPageProxy.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
- removed _isWindowOccluded.
(-[WKView windowOcclusionDetectionEnabled]):
(-[WKView setWindowOcclusionDetectionEnabled:]):
- Just toggle the flag - no cached state to update any more.
- UIProcess/API/mac/WKViewInternal.h:
- removed _isWindowOccluded.
- 5:42 PM Changeset in webkit [157967] by
-
- 12 edits in trunk/Source/WebKit2
SetIsVisible message should be sent to WebPage
https://bugs.webkit.org/show_bug.cgi?id=123296
Reviewed by Tim Horton.
- UIProcess/DrawingAreaProxy.h:
- remove visibilityDidChange - WebPageProxy now mesages WebPage.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
- Send view visibility updates to the WebPage, not the drawing area.
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
- remove visibilityDidChange - WebPageProxy now mesages WebPage.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::suspendPainting):
(WebKit::DrawingArea::resumePainting):
- WebProcess/WebPage/DrawingArea.messages.in:
- Instead of suspendPainting/resumePainting being private in the WebProcess but avaialble to the UIProcess, make them private to the WebProcess but accessible from WebPage.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setViewIsVisible):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- Added SetViewIsVisible message.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- Instead of suspendPainting/resumePainting being private in the WebProcess but avaialble to the UIProcess, make them private to the WebProcess but accessible from WebPage.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::suspendPainting):
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):
- Moved animation suspend code out to WebPage.
- 5:15 PM Changeset in webkit [157966] by
-
- 2 edits in trunk/Source/WebInspectorUI
Allow editing CSS resources after they have been pretty printed.
https://bugs.webkit.org/show_bug.cgi?id=123297
Reviewed by Joseph Pecoraro.
- UserInterface/TextEditor.js:
(WebInspector.TextEditor): Remove the need for _readOnly.
(WebInspector.TextEditor.prototype.set readOnly): Set CodeMirror readOnly directly.
(WebInspector.TextEditor.prototype.set formatted): Don't call _updateCodeMirrorReadOnly.
(WebInspector.TextEditor.prototype._updateCodeMirrorReadOnly): Removed.
(WebInspector.TextEditor.prototype._contentChanged): Clear _formatted and _formatterSourceMap
on edit and notify the delegate and fire the FormattingDidChange event.
- 5:14 PM Changeset in webkit [157965] by
-
- 3 edits3 copies in branches/safari-537.73-branch
Merged r154346. <rdar://problem/15109376>
- 5:06 PM Changeset in webkit [157964] by
-
- 2 edits in branches/safari-537.73-branch/Source/JavaScriptCore/dfg
Merge fix for <rdar://problem/15109401>
- 5:02 PM Changeset in webkit [157963] by
-
- 4 edits8 deletes in branches/safari-537.73-branch
Rollout r157962.
- 4:59 PM Changeset in webkit [157962] by
-
- 4 edits8 copies in branches/safari-537.73-branch
Merged r154344. <rdar://problem/15109401>
- 4:45 PM Changeset in webkit [157961] by
-
- 99 edits97 copies26 adds in trunk/LayoutTests
Update fast/forms tests for Mavericks, adding results for MountainLion when necessary.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label01-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label02-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label03-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label03-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label04-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label05-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-inputs-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-selects-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-selects-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt.
- platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.txt.
- platform/mac-mountainlion/fast/forms/button-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-align-expected.txt.
- platform/mac-mountainlion/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
- platform/mac-mountainlion/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
- platform/mac-mountainlion/fast/forms/button-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-style-color-expected.txt.
- platform/mac-mountainlion/fast/forms/button-table-styles-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-table-styles-expected.txt.
- platform/mac-mountainlion/fast/forms/button-text-transform-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-text-transform-expected.txt.
- platform/mac-mountainlion/fast/forms/button-white-space-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-white-space-expected.txt.
- platform/mac-mountainlion/fast/forms/control-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-expected.txt.
- platform/mac-mountainlion/fast/forms/control-clip-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.txt.
- platform/mac-mountainlion/fast/forms/control-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt.
- platform/mac-mountainlion/fast/forms/encoding-test-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/encoding-test-expected.txt.
- platform/mac-mountainlion/fast/forms/fieldset-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/fieldset-align-expected.txt.
- platform/mac-mountainlion/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file/input-file-re-render-expected.txt.
- platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt.
- platform/mac-mountainlion/fast/forms/hidden-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/hidden-listbox-expected.txt.
- platform/mac-mountainlion/fast/forms/input-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-align-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-bkcolor-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-default-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-disabled-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-focus-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-focus-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-height-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-preventDefault-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-readonly-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-selection-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-visibility-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-visibility-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-width-expected.txt.
- platform/mac-mountainlion/fast/forms/input-baseline-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
- platform/mac-mountainlion/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
- platform/mac-mountainlion/fast/forms/input-double-click-selection-gap-bug-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt.
- platform/mac-mountainlion/fast/forms/input-field-text-truncated-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-field-text-truncated-expected.txt.
- platform/mac-mountainlion/fast/forms/input-placeholder-visibility-1-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt.
- platform/mac-mountainlion/fast/forms/input-placeholder-visibility-3-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt.
- platform/mac-mountainlion/fast/forms/input-readonly-autoscroll-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-autoscroll-expected.txt.
- platform/mac-mountainlion/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
- platform/mac-mountainlion/fast/forms/input-readonly-empty-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-empty-expected.txt.
- platform/mac-mountainlion/fast/forms/input-set-composition-scroll-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/input-spaces-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-spaces-expected.txt.
- platform/mac-mountainlion/fast/forms/input-table-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-table-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-click-inside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-inside-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-click-outside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-outside-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-double-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-double-click-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-drag-down-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-drag-down-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-option-delete-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-option-delete-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-scroll-left-on-blur-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-self-emptying-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-self-emptying-click-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
- platform/mac-mountainlion/fast/forms/input-type-text-min-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-type-text-min-width-expected.txt.
- platform/mac-mountainlion/fast/forms/input-value-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-value-expected.txt.
- platform/mac-mountainlion/fast/forms/input-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-width-expected.txt.
- platform/mac-mountainlion/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
- platform/mac-mountainlion/fast/forms/listbox-hit-test-zoomed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt.
- platform/mac-mountainlion/fast/forms/listbox-width-change-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-width-change-expected.txt.
- platform/mac-mountainlion/fast/forms/menulist-no-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-no-overflow-expected.txt.
- platform/mac-mountainlion/fast/forms/menulist-option-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-option-wrap-expected.txt.
- platform/mac-mountainlion/fast/forms/menulist-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-restrict-line-height-expected.txt.
- platform/mac-mountainlion/fast/forms/minWidthPercent-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/minWidthPercent-expected.txt.
- platform/mac-mountainlion/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-rtl-expected.txt.
- platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt.
- platform/mac-mountainlion/fast/forms/placeholder-position-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt.
- platform/mac-mountainlion/fast/forms/plaintext-mode-2-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.txt.
- platform/mac-mountainlion/fast/forms/search-cancel-button-style-sharing-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt.
- platform/mac-mountainlion/fast/forms/search-display-none-cancel-button-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-display-none-cancel-button-expected.txt.
- platform/mac-mountainlion/fast/forms/search-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-rtl-expected.txt.
- platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-vertical-alignment-expected.txt.
- platform/mac-mountainlion/fast/forms/search/search-size-with-decorations-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/searchfield-heights-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/searchfield-heights-expected.txt.
- platform/mac-mountainlion/fast/forms/select-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-align-expected.txt.
- platform/mac-mountainlion/fast/forms/select-change-listbox-to-popup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt.
- platform/mac-mountainlion/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
- platform/mac-mountainlion/fast/forms/select-disabled-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-disabled-appearance-expected.txt.
- platform/mac-mountainlion/fast/forms/select-empty-option-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-empty-option-height-expected.txt.
- platform/mac-mountainlion/fast/forms/select-initial-position-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-initial-position-expected.txt.
- platform/mac-mountainlion/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt.
- platform/mac-mountainlion/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
- platform/mac-mountainlion/fast/forms/select/popup-closes-on-blur-expected.txt: Added.
- platform/mac-mountainlion/fast/forms/stuff-on-my-optgroup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/stuff-on-my-optgroup-expected.txt.
- platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/tabbing-input-iframe-expected.txt.
- platform/mac-mountainlion/fast/forms/text-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/text-style-color-expected.txt.
- platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-align-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-scrolled-type-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-setinnerhtml-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-setinnerhtml-expected.txt.
- platform/mac-mountainlion/fast/forms/textfield-focus-ring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-focus-ring-expected.txt.
- platform/mac-mountainlion/fast/forms/textfield-outline-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-outline-expected.txt.
- platform/mac-mountainlion/fast/forms/textfield-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-overflow-expected.txt.
- platform/mac-mountainlion/fast/forms/validation-message-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/validation-message-appearance-expected.txt.
- platform/mac-mountainlion/fast/forms/visual-hebrew-text-field-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/visual-hebrew-text-field-expected.txt.
- platform/mac-mountainlion/platform/mac/fast/forms/attributed-strings-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/fast/forms/indeterminate-progress-inline-height-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/fast/forms/input-appearance-spinbutton-size-expected.txt: Added.
- platform/mac-mountainlion/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt.
- platform/mac-mountainlion/platform/mac/fast/forms/input-number-click-expected.txt: Added.
- platform/mac/TestExpectations:
- platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label03-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt:
- platform/mac/fast/forms/basic-inputs-expected.txt:
- platform/mac/fast/forms/basic-selects-expected.txt:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/button-align-expected.txt:
- platform/mac/fast/forms/button-positioned-expected.txt:
- platform/mac/fast/forms/button-sizes-expected.txt:
- platform/mac/fast/forms/button-style-color-expected.txt:
- platform/mac/fast/forms/button-table-styles-expected.txt:
- platform/mac/fast/forms/button-text-transform-expected.txt:
- platform/mac/fast/forms/button-white-space-expected.txt:
- platform/mac/fast/forms/control-clip-expected.txt:
- platform/mac/fast/forms/control-clip-overflow-expected.txt:
- platform/mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac/fast/forms/encoding-test-expected.txt:
- platform/mac/fast/forms/fieldset-align-expected.txt:
- platform/mac/fast/forms/file/input-file-re-render-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/hidden-listbox-expected.txt:
- platform/mac/fast/forms/input-align-expected.txt:
- platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-disabled-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/forms/input-appearance-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-appearance-visibility-expected.txt:
- platform/mac/fast/forms/input-appearance-width-expected.txt:
- platform/mac/fast/forms/input-baseline-expected.txt: Added.
- platform/mac/fast/forms/input-button-sizes-expected.txt:
- platform/mac/fast/forms/input-disabled-color-expected.txt:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/mac/fast/forms/input-field-text-truncated-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
- platform/mac/fast/forms/input-readonly-empty-expected.txt:
- platform/mac/fast/forms/input-spaces-expected.txt:
- platform/mac/fast/forms/input-table-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-click-outside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/input-text-word-wrap-expected.txt:
- platform/mac/fast/forms/input-type-text-min-width-expected.txt:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/forms/input-width-expected.txt:
- platform/mac/fast/forms/listbox-bidi-align-expected.txt:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt:
- platform/mac/fast/forms/listbox-width-change-expected.txt:
- platform/mac/fast/forms/menulist-no-overflow-expected.txt:
- platform/mac/fast/forms/menulist-option-wrap-expected.txt:
- platform/mac/fast/forms/menulist-restrict-line-height-expected.txt:
- platform/mac/fast/forms/minWidthPercent-expected.txt:
- platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
- platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
- platform/mac/fast/forms/placeholder-position-expected.txt: Added.
- platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/mac/fast/forms/plaintext-mode-2-expected.txt:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-vertical-alignment-expected.txt:
- platform/mac/fast/forms/search/search-size-with-decorations-expected.txt: Added.
- platform/mac/fast/forms/searchfield-heights-expected.txt:
- platform/mac/fast/forms/select-align-expected.txt:
- platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:
- platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
- platform/mac/fast/forms/select-disabled-appearance-expected.txt:
- platform/mac/fast/forms/select-empty-option-height-expected.txt:
- platform/mac/fast/forms/select-initial-position-expected.txt:
- platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
- platform/mac/fast/forms/select-selected-expected.txt:
- platform/mac/fast/forms/stuff-on-my-optgroup-expected.txt:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/text-style-color-expected.txt:
- platform/mac/fast/forms/textAreaLineHeight-expected.txt:
- platform/mac/fast/forms/textarea-align-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
- platform/mac/fast/forms/textfield-focus-ring-expected.txt:
- platform/mac/fast/forms/textfield-outline-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- 4:35 PM Changeset in webkit [157960] by
-
- 11 edits in trunk/Source/WebCore
Uncomplicate some of SVGTextRunRenderingContext.
<https://webkit.org/b/123294>
This class was weird about a few things, so I've taken these steps
to clear things up:
- FINAL and OVERRIDE all the things.
- Constructor now takes a RenderObject&.
- renderer() now returns a RenderObject&.
- drawSVGGlyphs() no longer takes a TextRun.
- glyphDataForCharacter() no longer takes a TextRun.
To expand on the last two, there was also some awkward hoop-jumping
where we'd go through the TextRun passed by argument to find its
rendering context, which was really just |this| all along.
Reviewed by Antti Koivisto.
- 4:14 PM Changeset in webkit [157959] by
-
- 4 edits in trunk
Add texture level dependent size checks to textureImage2D calls.
https://bugs.webkit.org/show_bug.cgi?id=123290
<rdar://problem/15201382>
Reviewed by Dean Jackson.
Test covered by WebGL Conformance suite 1.0.2 test, textures/texture-size-limit.html.
There are different size limits when calling textureImage2D on different texture levels.
We should be throwing an error if our texture size exceeds these limits.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
- platform/mac/TestExpectations: Unskip now passing test texture-size-limit.html.
- 3:22 PM Changeset in webkit [157958] by
-
- 9 edits in trunk/Source/WebCore
[MediaStream API] allow a stream source to be shared
https://bugs.webkit.org/show_bug.cgi?id=121954
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-24
Reviewed by Eric Carlson.
Now, the MediaStreamSource don't know about the MediaStream that owns it,
since there can be more than one MediaStream that has it as source for some track.
MediaStreamTrack classes now have observers registered, in case there are more than
one MediaStream owning that track
No new tests, no change in functionality.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream): Adding the MediaStream as an observer for each track it owns.
(WebCore::MediaStream::addTrack): Now adding the MediaStream as an observer the new added track
and adding the source to the MediaStreamDescriptor.
(WebCore::MediaStream::removeTrack): Instead of removing the source right away, we first check if
there isn't any other track using that source, if not we remove the source.
(WebCore::MediaStream::haveTrackWithSource):
(WebCore::MediaStream::addRemoteSource): MediaStreamSource has no information about the MediaStream
that uses it, so now we don't set the stream in the source anymore.
(WebCore::MediaStream::removeRemoteSource): There can be more than on track using the source. So we
get each track that is using the source and then remove it and fire the ended event.
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::addObserver):
(WebCore::MediaStreamTrack::removeObserver):
(WebCore::MediaStreamTrack::trackDidEnd): Does not get the client from the MediaStreamDescriptor, it now
notify each of its observers that the track ended.
- Modules/mediastream/MediaStreamTrack.h: Adding Observer class.
- platform/mediastream/MediaStreamDescriptor.cpp: Destructor now does nothing. Previously it was setting
each MediaStreamSource's descriptor to null.
(WebCore::MediaStreamDescriptor::removeSource): Not setting the stream in source anymore.
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Ditto.
(WebCore::MediaStreamDescriptor::setEnded): Not setting the state of the source to Ended
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::~MediaStreamDescriptor):
- platform/mediastream/MediaStreamSource.cpp: Removing references to MediaStream object
(WebCore::MediaStreamSource::MediaStreamSource):
(WebCore::MediaStreamSource::reset):
- platform/mediastream/MediaStreamSource.h:
- 2:40 PM Changeset in webkit [157957] by
-
- 4 edits2 adds in trunk
Crash in WebCore::NavigationScheduler::startTimer()
https://bugs.webkit.org/show_bug.cgi?id=123288
<rdar://problem/14055644>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Currently NavigationScheduler::startTimer() synchronously notifies the client
before the Web Inspector of a scheduled redirect. If a client cancels this
redirect then NavigationScheduler::m_redirect will become null and we'll
subsequently crash when informing the Web Inspector of this formerly scheduled
redirect. Instead, NavigationScheduler::startTimer() should notify the Web
Inspector before it notifies the client of a scheduled redirect.
As a side benefit of this change, the Web Inspector is notified of a scheduled
redirect before being notified of it being canceled when a client chooses to cancel
a scheduled redirect.
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::startTimer):
Tools:
Add API test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
- TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.
- 2:31 PM Changeset in webkit [157956] by
-
- 3 edits2 copies in branches/safari-537.73-branch
Merged r154308. <rdar://problem/15109394>
- 2:28 PM Changeset in webkit [157955] by
-
- 2 edits in branches/safari-537.73-branch/Source/JavaScriptCore
Merged r154303. <rdar://problem/15109405>
- 2:23 PM Changeset in webkit [157954] by
-
- 11 edits3 adds in branches/safari-537.73-branch
Merge fix for <rdar://problem/15109389>
- 1:55 PM Changeset in webkit [157953] by
-
- 2 edits in trunk/Source/WebKit2
Tried to fix the Mountain Lion build.
- Shared/API/Cocoa/WKFoundation.h:
- 1:46 PM Changeset in webkit [157952] by
-
- 2 edits in trunk/Source/WebCore
Try to fix build without CSS_SHAPES.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- 1:39 PM Changeset in webkit [157951] by
-
- 8 edits in trunk/Source/WebKit2
[Cocoa] Add -[WKBrowsingContextController goToBackForwardItem:]
https://bugs.webkit.org/show_bug.cgi?id=123289
Reviewed by Sam Weinig.
- Shared/API/Cocoa/WKFoundation.h: Defined WK_API_CLASS.
- UIProcess/API/mac/WKBrowsingContextController.h: Declared -goToBackForwardListItem:.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController goToBackForwardListItem:]): Added.
- UIProcess/Cocoa/WKBackForwardList.h: Deployed WK_API_CLASS to make the class exported.
- UIProcess/Cocoa/WKBackForwardListItem.h: Ditto.
- UIProcess/Cocoa/WKBackForwardListItem.mm:
(-[WKBackForwardListItem _item]): Added. Returns the underlying WebBackForwardListItem.
- UIProcess/Cocoa/WKBackForwardListItemInternal.h: Declared _item.
- 1:31 PM Changeset in webkit [157950] by
-
- 15 edits5 adds in trunk/Source/WebCore
Simple line layout
https://bugs.webkit.org/show_bug.cgi?id=122458
Reviewed by Darin Adler.
Line box based inline layout is powerful but also rather slow and memory intensive. Simple line layout
is a compact alternative data structure and fast code path to cover common cases without requiring line
boxes.
This patch handles a case single left-aligned text renderer inside flow with no floats. Even this very basic
case is sufficiently common to handle up to 25% of all text lines on some popular new sites. The decision
which path to use is made per block flow (paragraph).
Simple line layout aims to produce pixel-exact rendering result when compared to the line box layout.
The goal is to handle everything that requires line level access in cases that allow use of simple lines.
This is not quite the case yet. For example selections and outline painting are not supported. In these
cases we seamlessly switch to the line boxes.
The simple line data structure currently uses 12 bytes per line. Lineboxes take ~160 bytes minimum per line.
Laying out the lines is also several times faster as is iterating over them.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Position.cpp:
(WebCore::Position::upstream):
(WebCore::Position::downstream):
(WebCore::Position::getInlineBoxAndOffset):
Creating positions within a simple line flow causes switch to line boxes.
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextNode):
TextIterator traverses line boxes if available. In case simple line case we need to replicate the
same results (for compatibility but especially to avoid changing test results). This is done here
by just traversing the string without actually using the layout.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::layoutShapeInsideInfo):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
Select the layout path to use.
(WebCore::RenderBlockFlow::deleteLines):
(WebCore::RenderBlockFlow::hitTestInlineChildren):
(WebCore::RenderBlockFlow::adjustForBorderFit):
(WebCore::RenderBlockFlow::firstLineBaseline):
(WebCore::RenderBlockFlow::inlineBlockBaseline):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::clearTruncation):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlockFlow::paintInlineChildren):
(WebCore::RenderBlockFlow::hasLines):
(WebCore::RenderBlockFlow::layoutSimpleLines):
Do simple layout.
(WebCore::RenderBlockFlow::deleteLineBoxesBeforeSimpleLineLayout):
(WebCore::RenderBlockFlow::ensureLineBoxes):
This function switches from simple lines to line boxes. The switching can be done outside normal layout.
This is used to cover some cases that are not yet supported by simple lines (like selections).
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::simpleLines):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutLineBoxes):
Rename the line box layout function.
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
- rendering/RenderText.cpp:
(WebCore::RenderText::deleteLineBoxesBeforeSimpleLineLayout):
(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsClippedToEllipsis):
(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::knownToHaveNoOverflowAndNoFallbackFonts):
(WebCore::RenderText::setSelectionState):
(WebCore::RenderText::setTextWithOffset):
(WebCore::RenderText::ensureLineBoxes):
(WebCore::RenderText::simpleLines):
(WebCore::RenderText::linesBoundingBox):
(WebCore::RenderText::linesVisualOverflowBoundingBox):
(WebCore::RenderText::selectionRectForRepaint):
(WebCore::RenderText::caretMinOffset):
(WebCore::RenderText::caretMaxOffset):
(WebCore::RenderText::countRenderedCharacterOffsetsUntil):
(WebCore::RenderText::containsRenderedCharacterOffset):
(WebCore::RenderText::containsCaretOffset):
(WebCore::RenderText::hasRenderedText):
- rendering/RenderText.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeSimpleLine):
(WebCore::write):
- rendering/SimpleLineLayout.cpp: Added.
(WebCore::SimpleLineLayout::canUseFor):
This check for the cases supported by the simple line layout path.
(WebCore::SimpleLineLayout::isWhitespace):
(WebCore::SimpleLineLayout::skipWhitespaces):
(WebCore::SimpleLineLayout::textWidth):
(WebCore::SimpleLineLayout::createLines):
The main layout functions that breaks text to lines. It only handles the cases allowed by
SimpleLineLayout::canUseFor. What it handles it aims to break exactly as line box layout does.
- rendering/SimpleLineLayout.h: Added.
- rendering/SimpleLineLayoutFunctions.cpp: Added.
(WebCore::SimpleLineLayout::paintFlow):
(WebCore::SimpleLineLayout::hitTestFlow):
(WebCore::SimpleLineLayout::collectFlowOverflow):
(WebCore::SimpleLineLayout::computeTextBoundingBox):
- rendering/SimpleLineLayoutFunctions.h: Added.
(WebCore::SimpleLineLayout::computeFlowHeight):
(WebCore::SimpleLineLayout::computeFlowFirstLineBaseline):
(WebCore::SimpleLineLayout::computeFlowLastLineBaseline):
(WebCore::SimpleLineLayout::findTextCaretMinimumOffset):
(WebCore::SimpleLineLayout::findTextCaretMaximumOffset):
(WebCore::SimpleLineLayout::containsTextCaretOffset):
(WebCore::SimpleLineLayout::isTextRendered):
(WebCore::SimpleLineLayout::lineHeightFromFlow):
Support functions called from RenderBlockFlow and RenderText. They are equivalent to
similar line box functions.
(WebCore::SimpleLineLayout::baselineFromFlow):
- rendering/SimpleLineLayoutResolver.h: Added.
(WebCore::SimpleLineLayout::Resolver::Line::Line):
(WebCore::SimpleLineLayout::Resolver::Line::rect):
(WebCore::SimpleLineLayout::Resolver::Line::baseline):
(WebCore::SimpleLineLayout::Resolver::Line::text):
(WebCore::SimpleLineLayout::Resolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator++):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator--):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator==):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator!=):
(WebCore::SimpleLineLayout::Resolver::Iterator::operator*):
Lazy iterator for deriving line metrics. This keeps the line data structure small as
we don't need to keep easily derived values around.
(WebCore::SimpleLineLayout::Resolver::Resolver):
(WebCore::SimpleLineLayout::Resolver::size):
(WebCore::SimpleLineLayout::Resolver::begin):
(WebCore::SimpleLineLayout::Resolver::end):
(WebCore::SimpleLineLayout::Resolver::last):
(WebCore::SimpleLineLayout::Resolver::operator[]):
- 12:59 PM Changeset in webkit [157949] by
-
- 7 edits in trunk/LayoutTests
dumpAsText() is unnecessarily called in spellchecking tests
https://bugs.webkit.org/show_bug.cgi?id=123266
Reviewed by Darin Adler.
dumpAsText is already called either by notifyDone (js-test-post.js) or
by finishJSTest() when asynchrononous spell checking is used.
- editing/spelling/spellcheck-async-mutation.html:
- editing/spelling/spellcheck-async.html:
- editing/spelling/spellcheck-attribute-expected.txt:
- editing/spelling/spellcheck-attribute.html:
- editing/spelling/spelling-insert-html.html:
- editing/spelling/spelling-unified-emulation.html:
- 12:53 PM Changeset in webkit [157948] by
-
- 4 edits2 adds in trunk
Gaps between underlines in adjacent underlined text runs
https://bugs.webkit.org/show_bug.cgi?id=123236
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-24
Reviewed by Simon Fraser and Darin Adler.
Source/WebCore:
There are two pieces to this change. The first piece is in
InlineTextBox::paint(). We were putting floating-point
extents into a LayoutSize, which simply uses ints (for now),
and then immediately converting this back to a FloatSize.
Instead, we should be using floats throughout all of
this code.
In addition, inside GraphicsContext::drawLineForText(), we are
rounding the underline to pixel boundaries so that it appears
very crisp on the screen. However, we should round once after
performing computations, rather than rounding twice and then
performing computations on the rounded numbers.
Test: fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes.html
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLineForText): Change rounding mode
to perform computations before rounding
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Don't convert to a LayoutSize
just to convert to a FloatSize
LayoutTests:
Added a test that checks that we have accurate precision in our
floating-point computations. We should perform calculations before
rounding, instead of rouding twice and performing calculations on
the rounded values.
- fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes.html: Added.
- platform/mac/fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes-expected.png: Added.
- platform/mac/fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes-expected.txt: Added.
- 12:39 PM Changeset in webkit [157947] by
-
- 2 edits in trunk/Source/WebInspectorUI
Adjust the precision of byte strings in Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=123281
Reviewed by Joseph Pecoraro.
- UserInterface/Utilities.js:
(Number.bytesToString): More precision for MB and less precision for 10..1023 KB.
- 12:38 PM Changeset in webkit [157946] by
-
- 2 edits in trunk/LayoutTests
Fix unnecessary alerted value leaking into another test.
Rubber-stamped by Alexey Proskuryakov.
- inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html:
- 12:36 PM Changeset in webkit [157945] by
-
- 10 edits in trunk/Source/WebCore
SVGRenderingContext should wrap a RenderElement.
<https://webkit.org/b/123283>
The SVG rendering context class is never used with text renderers
so we can have it wrap a RenderElement for tighter code.
Also renamed SVGRenderingContext::m_object to m_renderer.
Reviewed by Antti Koivisto.
- 12:18 PM Changeset in webkit [157944] by
-
- 3 edits2 adds in trunk
[contenteditable] Content after non-editable element disappears when merging lines using backspace
https://bugs.webkit.org/show_bug.cgi?id=122748
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-24
Reviewed by Ryosuke Niwa.
Source/WebCore:
In case of paragraph merging after deletion if second paragraph
contains non-editable element, then content after the non-editable
element(including non-editable element) will be removed while the
content before the element will be merged with the first paragraph.
This happens becasue endOfParagraphToMove calculation in merging function
stop at editing boundary so endOfParagraphToMove becomes position just
before non-editable content.
With this patch now endOfParagraphToMove is calculated by skipping
over the non-editable element.
Test: editing/deleting/merge-paragraph-contatining-noneditable.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs): use CanSkipOverEditingBoundary
condition while calculating endOfParagraphToMove.
LayoutTests:
Adding test to verify that on merging the paragraph containing
non-editable element does not cause loss of non-editable content after
merging.
- editing/deleting/merge-paragraph-contatining-noneditable-expected.txt: Added.
- editing/deleting/merge-paragraph-contatining-noneditable.html: Added.
- 12:12 PM Changeset in webkit [157943] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r157931.
http://trac.webkit.org/changeset/157931
https://bugs.webkit.org/show_bug.cgi?id=123284
Seems to have caused a lot of assertions on debug bots
(Requested by ap on #webkit).
- wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty):
- 12:10 PM Changeset in webkit [157942] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Inspector doesn't show webkitTransitionEnd events in the timeline
https://bugs.webkit.org/show_bug.cgi?id=123263
Reviewed by Timothy Hatcher.
A legacy event type is only set on an event in EventTarget::fireEventListeners(Event*)
which is called after we used to call InspectorInstrumentation::willDispatchEvent(), the method
that would ultimately yield the creation of a TimelineRecord for the event in the Web Inspector
frontend, and as a result we would try to dispatch an event with an unprefixed event type to
the frontend, which wouldn't even happen because most likely it wouldn't have listeners for this
unprefixed type.
We now move the call to InspectorInstrumentation::willDispatchEvent() in
EventTarget::fireEventListeners(Event*, EventTargetData*, EventListenerVector&) such that the
correct event type and list of listeners is used to determine what event to dispatch to the frontend.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
Remove calls to InspectorInstrumentation::willDispatchEvent() and InspectorInstrumentation::didDispatchEvent().
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
Add call to InspectorInstrumentation::willDispatchEvent() before we go through each listener and
call InspectorInstrumentation::willHandleEvent(). Additionally, we refactor some code since we're
getting references to the ScriptExecutionContext and Document upfront now.
- 11:58 AM Changeset in webkit [157941] by
-
- 2 edits in trunk/LayoutTests
Layout Test compositing/regions/propagate-region-box-shadow-border-padding-for-video.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123282
- platform/mac/TestExpectations: Marking as such.
- 11:41 AM Changeset in webkit [157940] by
-
- 20 edits in trunk/Source/WebCore
SVG: RenderElement-ize intersectRepaintRectWithResources().
<https://webkit.org/b/123278>
SVGRenderSupport::intersectRepaintRectWithResources() is only ever
called with non-text renderers so make it take RenderElement&.
Had to tweak RenderSVGResource::resourceBoundingBox() to take the
renderer by reference.
Reviewed by Antti Koivisto.
- 11:22 AM Changeset in webkit [157939] by
-
- 5 edits2 adds in trunk
Web Inspector: Breakpoints in sourceURL named scripts do not work
https://bugs.webkit.org/show_bug.cgi?id=123231
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-24
Reviewed by Timothy Hatcher.
Source/WebCore:
Remember a Script's sourceURL and sourceMappingURL. When setting a
breakpoint by URL, check it against the sourceURL or original URL.
If a script had a sourceURL that would have been the only URL sent
to the frontend, so that receives priority.
Test: inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::didParseSource):
- inspector/InspectorDebuggerAgent.h:
- inspector/ScriptDebugListener.h:
LayoutTests:
- inspector-protocol/debugger/setBreakpointByUrl-sourceURL-expected.txt: Added.
- inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html: Added.
- 10:08 AM Changeset in webkit [157938] by
-
- 6 edits5 adds in trunk
Web Inspector: Add a way to test the Manager and model classes
https://bugs.webkit.org/show_bug.cgi?id=123223
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
Moved some global functions out of Main.js, so that they can be used in the
layout tests without including Main.js.
- UserInterface/Main.html: Referenced the new JS files.
- UserInterface/Main.js:
- UserInterface/MessageDispatcher.js: Added.
(WebInspector.dispatchNextQueuedMessageFromBackend):
(WebInspector.dispatchMessageFromBackend):
- UserInterface/URLUtilities.js: Added.
(removeURLFragment):
(relativePath):
(parseURL):
(absoluteURL):
(parseLocationQueryParameters):
(parseQueryString):
(WebInspector.displayNameForURL):
(WebInspector.displayNameForHost):
- UserInterface/Utilities.js:
LayoutTests:
Added the first new WebInspector layout test file. The test is using InspectorTest.importInspectorScripts
to bootstrap some of the managers/observers/models from the new WebInspector.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.importScript):
(InspectorTest.importInspectorScripts):
- inspector-protocol/model/main-frame-resource-expected.txt: Added.
- inspector-protocol/model/main-frame-resource.html: Added.
- 10:05 AM Changeset in webkit [157937] by
-
- 6 edits in trunk/Source/JavaScriptCore
Better way to fix part of broken C Loop LLINT build.
https://bugs.webkit.org/show_bug.cgi?id=123271.
Reviewed by Geoffrey Garen.
Undoing offline asm hackery.
- llint/LowLevelInterpreter.cpp:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/cloop.rb:
- offlineasm/instructions.rb:
- 10:05 AM Changeset in webkit [157936] by
-
- 5 edits8 adds in trunk/Source/WebCore
Add CryptoKey base class and bindings
https://bugs.webkit.org/show_bug.cgi?id=123216
Reviewed by Sam Weinig.
- crypto/CryptoKey.idl: Added.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
Process the IDL.
- WebCore.xcodeproj/project.pbxproj: Added files.
- bindings/js/JSCryptoKeyCustom.cpp: Added.
(WebCore::JSCryptoKey::algorithm): Use a visitor to build algorithm dictionary
for the key.
- crypto/CryptoAlgorithmDescriptionBuilder.cpp: Added.
- crypto/CryptoAlgorithmDescriptionBuilder.h: Added.
An interface for a visitor we'll use to expose CrytoKey.algorithm in bindings,
and possibly also for storage serialization. Not complete yet, we'll need support
for a few more simple types, and less trivially, for nested algorithms.
- bindings/js/JSCryptoAlgorithmBuilder.cpp: Added.
- bindings/js/JSCryptoAlgorithmBuilder.h: Added.
An implementation that builds an algorithm description dictionary for JS bindings.
- crypto/CryptoKey.cpp: Added.
(WebCore::CryptoKey::~CryptoKey):
(WebCore::CryptoKey::buildAlgorithmDescription):
- crypto/CryptoKey.h: Added.
Added an almost empty implementation. Some of the functions that are currently
marked as pure virtual will likely be implemented in this base class.
- 9:38 AM Changeset in webkit [157935] by
-
- 2 edits in trunk/LayoutTests
Freshly landed webgl-1.0.1 tests are failing.
- platform/mac/TestExpectations: Correcting a late-night typo in TetExpectations.
It's [Failure], not [Fail].
- 9:35 AM Changeset in webkit [157934] by
-
- 4 edits1 delete in trunk
Unreviewed, rolling out r157916.
http://trac.webkit.org/changeset/157916
https://bugs.webkit.org/show_bug.cgi?id=123274
Broke Layout/flexbox-lots-of-data.html on perfbot (Requested
by ap on #webkit).
PerformanceTests:
- Layout/flexbox-lots-of-data.html: Removed.
Source/WebCore:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::OrderHashTraits::emptyValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::constructDeletedValue):
(WebCore::RenderFlexibleBox::OrderHashTraits::isDeletedValue):
(WebCore::RenderFlexibleBox::OrderIterator::setOrderValues):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
- rendering/RenderFlexibleBox.h:
- 9:22 AM Changeset in webkit [157933] by
-
- 2 edits in trunk/Source/WebCore
Comment in ScopedEventQueue::dispatchEvent is unnecessarily verbose
https://bugs.webkit.org/show_bug.cgi?id=123252
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-10-24
Reviewed by Darin Adler.
Shorten the comment about the crash avoidance in ScopedEventQueue::dispatchEvent due to
the calling convention in C++ is left unspecified. The problem was already fixed in r157219
and later adjusted in r157401, but the comment could have been shorter and simpler in both cases.
- dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::dispatchEvent):
- 9:10 AM Changeset in webkit [157932] by
-
- 11 edits in trunk/Source/JavaScriptCore
Fix broken C Loop LLINT build.
https://bugs.webkit.org/show_bug.cgi?id=123271.
Reviewed by Michael Saboff.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdCacheStatus): Added an UNUSED_PARAM().
(JSC::CodeBlock::dumpBytecode): Added #if ENABLE(JIT) to JIT only code.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor): Added an UNUSED_PARAM().
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor): Added an UNUSED_PARAM().
- bytecode/StructureStubInfo.h:
- Added a stub StubInfoMap for non-JIT builds. StubInfoMap is still used in function prototypes even when !ENABLE(JIT). Rather that adding #if's in many places, we just provide a stub/placeholder implementation that is unused but keeps the compiler happy.
- jit/JITOperations.h: Added #if ENABLE(JIT).
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- The putByVal() macro reifies a slow path which is never taken in one case. This translates into a label that is never used in the C Loop LLINT. The C++ compiler doesn't like unused labels. So, we fix this by adding a cloopUnusedLabel offline asm instruction that synthesizes the following:
if (false) goto unusedLabel;
This keeps the C++ compiler happy without changing code behavior.
- offlineasm/cloop.rb: Implementing cloopUnusedLabel.
- offlineasm/instructions.rb: Declaring cloopUnusedLabel.
- runtime/Executable.cpp:
(JSC::setupJIT): Added UNUSED_PARAM()s.
(JSC::ScriptExecutable::prepareForExecutionImpl):
- run-javascriptcore-tests have phases that forces the LLINT to be off which in turn asserts that the JIT is enabled. With the C Loop LLINT, this combination is illegal. So, we override the setup code here to always use the LLINT if !ENABLE(JIT) regardless of what options are passed in.
- 9:09 AM Changeset in webkit [157931] by
-
- 2 edits in trunk/Source/WTF
Remove PCRE workaround.
https://bugs.webkit.org/show_bug.cgi?id=123265
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Darin Adler.
- wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty):
- 9:06 AM Changeset in webkit [157930] by
-
- 2 edits in trunk/Source/JavaScriptCore
Uninitialized member causes crash when DFG JIT is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=123270
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-24
Reviewed by Brent Fulgham.
The data member sizeOfLastScratchBuffer in the VM class is only initialized if DFG JIT is enabled, even though it's defined regardless.
This causes an early crash on Windows, which doesn't have DFG JIT enabled.
- runtime/VM.cpp:
(JSC::VM::VM): Initialize sizeOfLastScratchBuffer member regardless of whether DFG JIT is enabled.
- 9:00 AM Changeset in webkit [157929] by
-
- 2 edits in trunk/Tools
[GTK] Disable css-image-orientation
https://bugs.webkit.org/show_bug.cgi?id=123257
Reviewed by Martin Robinson.
CSS image orientation isn't stable yet. So, test regression happen since r157909.
This feature should be enabled again after it is stable.
- Scripts/webkitperl/FeatureList.pm:
- 7:32 AM Changeset in webkit [157928] by
-
- 3 edits3 deletes in trunk/Source/WebCore
Removed unused ThreadSafeCoordinatedSurface and CertificateInfoCurl files.
https://bugs.webkit.org/show_bug.cgi?id=123246
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-24
Reviewed by Noam Rosenthal.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
Removed references to ThreadSafeCoordinatedSurface and CertificateInfoCurl.
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp: Removed.
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h: Removed.
- platform/network/curl/CertificateInfoCurl.cpp: Removed.
- 7:27 AM Changeset in webkit [157927] by
-
- 2 edits in trunk/Source/WTF
Remove Clang workaround.
https://bugs.webkit.org/show_bug.cgi?id=123262
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Anders Carlsson.
- wtf/CheckedArithmetic.h:
(WTF::Checked::Checked):
- 6:30 AM Changeset in webkit [157926] by
-
- 2 edits in trunk/Source/WebCore
Removed Qt workaround.
https://bugs.webkit.org/show_bug.cgi?id=123258
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Csaba Osztrogonác.
No change of functionality, no new tests needed.
!$defines case can be removed, because Qt and Android aren't in WebKit trunk,
all ports (Mac,EFL,GTK,Windows) call this script with --defines option now
- css/make-css-file-arrays.pl:
- 6:28 AM Changeset in webkit [157925] by
-
- 2 edits in trunk/Source/WebCore
Remove a stray space.
Not reviewed.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addImageMapChildren):
- 6:26 AM Changeset in webkit [157924] by
-
- 49 edits in trunk/Source/WebCore
Element iterator functions should take reference
https://bugs.webkit.org/show_bug.cgi?id=123267
Reviewed by Andreas Kling.
The argument has to be non-null.
- 5:26 AM Changeset in webkit [157923] by
-
- 3 edits in trunk/Tools
Fix argument passing for jhbuild.
https://bugs.webkit.org/show_bug.cgi?id=123253
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-24
Reviewed by Gustavo Noronha Silva.
The update-webkit-libs-jhbuild previously didn't allowed
extra arguments to be passed to jhbuild.
- Scripts/update-webkit-libs-jhbuild:
(runJhbuild):
- Scripts/update-webkitefl-libs:
- 4:41 AM Changeset in webkit [157922] by
-
- 2 edits in trunk/Tools
[EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
https://bugs.webkit.org/show_bug.cgi?id=123251
Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2013-10-24
Reviewed by Csaba Osztrogonác.
Replace %llu by PRIu64 macro to print an uint64_t value and silent a
compilation warning on 64-Bit.
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededDatabaseQuota):
- 3:26 AM Changeset in webkit [157921] by
-
- 2 edits3 adds in trunk/LayoutTests
[GTK] Removing flags for tests fixed in bug 121828
https://bugs.webkit.org/show_bug.cgi?id=122967
Unreviewed GTK gardening. Rebaselining after r156767.
Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-10-24
- platform/gtk/TestExpectations:
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
- 3:01 AM Changeset in webkit [157920] by
-
- 21 edits in trunk
[EFL] Build break with latest EFL 1.8 libraries.
https://bugs.webkit.org/show_bug.cgi?id=123245
Reviewed by Gyuyoung Kim.
After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
Eo typedef and splitted header files which contain version macro.
.:
- Source/cmake/EFLHelpers.cmake: Checked whether include path exist.
- Source/cmake/FindEcore.cmake: Added 1.8 Header which have version macro.
- Source/cmake/FindEdje.cmake: Ditto.
- Source/cmake/FindEina.cmake: Ditto.
- Source/cmake/FindEo.cmake: Ditto.
- Source/cmake/FindEvas.cmake: Ditto.
Source/JavaScriptCore:
- PlatformEfl.cmake: Added EO path to include directories.
- heap/HeapTimer.h: Changed Ecore_Timer typedef when EO exist.
Source/WebCore:
- platform/Widget.h: Changed Eo typedef.
- platform/efl/EflScreenUtilities.h: Ditto.
- platform/graphics/Image.h: Ditto.
Source/WTF:
- wtf/OwnPtrCommon.h: Changed Eo typedef.
- wtf/efl/RefPtrEfl.h: Ditto.
Tools:
- TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
- WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
- WebKitTestRunner/PlatformWebView.h: Ditto.
- 2:59 AM Changeset in webkit [157919] by
-
- 6 edits in trunk/Source/WebCore
RenderSVGResource: Pass RenderElement to fill/strokePaintingResource.
<https://webkit.org/b/123242>
We never pass text renderers to these functions, so make them take
RenderElement instead.
Reviewed by Anders Carlsson.
- 2:08 AM Changeset in webkit [157918] by
-
- 14 edits in trunk
[GObject bindings] Make EventTarget interface introspectable
https://bugs.webkit.org/show_bug.cgi?id=77835
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Add webkit_dom_event_target_add_event_listener_with_closure and
webkit_dom_event_target_remove_event_listener_with_closure to be
used by GObject instrospection bindings. Instead of receving a
GCallback, which makes the function not introspectable, they
receive a GClosure.
- bindings/gobject/GObjectEventListener.cpp:
(WebCore::GObjectEventListener::GObjectEventListener):
(WebCore::GObjectEventListener::~GObjectEventListener):
(WebCore::GObjectEventListener::gobjectDestroyed):
(WebCore::GObjectEventListener::handleEvent):
(WebCore::GObjectEventListener::operator==):
- bindings/gobject/GObjectEventListener.h:
(WebCore::GObjectEventListener::addEventListener):
(WebCore::GObjectEventListener::removeEventListener):
- bindings/gobject/WebKitDOMEventTarget.cpp:
(webkit_dom_event_target_dispatch_event):
(webkit_dom_event_target_add_event_listener):
(webkit_dom_event_target_remove_event_listener):
(webkit_dom_event_target_add_event_listener_with_closure):
(webkit_dom_event_target_remove_event_listener_with_closure):
- bindings/gobject/WebKitDOMEventTarget.h:
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateEventTargetIface):
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(webkit_dom_test_event_target_dispatch_event):
(webkit_dom_test_event_target_add_event_listener):
(webkit_dom_test_event_target_remove_event_listener):
- bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(webkit_dom_test_node_dispatch_event):
(webkit_dom_test_node_add_event_listener):
(webkit_dom_test_node_remove_event_listener):
Source/WTF:
Add support for use GRefPtr with GClosure.
- wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr):
(WTF::derefGPtr):
- wtf/gobject/GRefPtr.h:
- wtf/gobject/GTypedefs.h:
Tools:
- Scripts/webkitpy/style/checker.py: Add exceptions for custom
GObject DOM bindings headers.
- 12:10 AM Changeset in webkit [157917] by
-
- 357 edits25 deletes in trunk/LayoutTests
Revert <http://trac.webkit.org/changeset/157893>
(Mavericks test results mega-patch).
It didn't fix Mavericks, which still has dozens of failures, and it broke Mountain
Lion bots, which need to remain green for tools like EWS to work.
At a glance, there are multiple systemic issues with this change:
- some results went to broken locations like platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.png;
- WK2 expectations also went to platform/mac/platform/mac-wk2/TestExpectations.
- some tests like js/dom/global-constructors-attributes.html used to match cross-platform
baseline, but copying Mavericks results over to platform/mac made it so that those results
are now ignored on Mountain Lion.
I think that starting over will be easier that fixing these issues incrementally.
Oct 23, 2013:
- 11:53 PM Changeset in webkit [157916] by
-
- 4 edits1 add in trunk
Use a Vector instead of HashSet to computed the orderValues in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=118620
Reviewed by Antti Koivisto.
PerformanceTests:
From Blink r152960 by <ojan@chromium.org>
New performance test for layouts in flexboxes.
- Layout/flexbox-lots-of-data.html: Added.
Source/WebCore:
Turns out that order is extremelly uncommon so using a Vector is
much less expensive. This also special-cases the much common case
of only having order of value 0 by using Vectors with just one
preallocated member.
Also added the performance test that shows a ~1% win when using a
vector instead of the HashSet.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::OrderIterator::setOrderValues):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
- rendering/RenderFlexibleBox.h:
- 11:43 PM Changeset in webkit [157915] by
-
- 6 edits in trunk/Source
Unreviewed build fix since r157823.
FilterOperation::getOperationType() is renamed FilterOperation::type().
Source/WebCore:
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawUsingCustomFilter):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::applyFilters):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::injectCachedCustomFilterPrograms):
Source/WebKit2:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
- 11:31 PM Changeset in webkit [157914] by
-
- 2 edits in trunk/LayoutTests
Freshly landed webgl-1.0.1 tests are failing.
- platform/mac/TestExpectations: Mark them as such.
- 11:25 PM Changeset in webkit [157913] by
-
- 2 edits in trunk/LayoutTests
Layout Test plugins/destroy-during-npp-new-object-with-fallback-content.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123250
This is a recent regression.
- platform/mac/TestExpectations: Marking as such.
- 11:16 PM Changeset in webkit [157912] by
-
- 2 edits in trunk/LayoutTests
Layout Test webaudio/javascriptaudionode-downmix8-2channel-input.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=120148
- TestExpectations: Marking as such.
- 9:16 PM Changeset in webkit [157911] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix on CMake based ports when CMAKE_BUILD_TYPE is not given.
When CMAKE_BUILD_TYPE is empty, FIND command will be failed.
- CMakeLists.txt:
- 9:09 PM Changeset in webkit [157910] by
-
- 3 edits in trunk/LayoutTests
[EFL] Skip tests which are already passed in WebKit1.
https://bugs.webkit.org/show_bug.cgi?id=123200
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-10-23
Reviewed by Gyuyoung Kim.
These tests are passed in wk1 because DRT is supporting setViewModeMediaFeature().
So these are only failed in wk2, but skipped in all cases now.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 8:40 PM Changeset in webkit [157909] by
-
- 35 edits in trunk
Integrate css3-images image-orientation with existing EXIF support
https://bugs.webkit.org/show_bug.cgi?id=91566
Reviewed by Beth Dakin.
Source/WebCore:
Original patch by David Barr(davidbarr@chromium.org).
This patch passes an information of image orientation into existing EXIF support functions
(draw() functions of image classes mainly). We need to let the functions to know the information
in order to meet the image-orientation requirement.
Spec: http://dev.w3.org/csswg/css-images-3/#the-image-orientation
The css3-images module specification is at last call.
Test: fast/css/image-orientation/image-orientation.html
Image orientation test is to check if incorrect rotation value can be fixed with correct orientation.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
- page/DragController.cpp:
(WebCore::DragController::doImageDrag):
- page/Frame.cpp:
(WebCore::Frame::nodeImage):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::updateSize):
(WebCore::BitmapImage::sizeRespectingOrientation):
(WebCore::BitmapImage::drawPattern):
- platform/graphics/BitmapImage.h:
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::draw):
- platform/graphics/CrossfadeGeneratedImage.h:
- platform/graphics/GeneratedImage.h:
- platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::draw):
- platform/graphics/GradientImage.h:
- platform/graphics/Image.cpp:
(WebCore::Image::draw):
(WebCore::Image::drawTiled):
- platform/graphics/Image.h:
- platform/graphics/blackberry/ImageBlackBerry.cpp:
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::draw):
- platform/graphics/cg/BitmapImageCG.cpp:
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::draw):
- platform/graphics/cg/PDFDocumentImage.h:
- platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::BufferedImage::draw):
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::BitmapImage::draw):
- platform/mac/DragImageMac.mm:
(WebCore::createDragImageFromImage):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintSnapshotImage):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::styleDidChange):
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paintSnapshot):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawForContainer):
(WebCore::SVGImage::nativeImageForCurrentFrame):
(WebCore::SVGImage::draw):
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::draw):
- svg/graphics/SVGImageForContainer.h:
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Update export symbols for draw functions.
LayoutTests:
- fast/css/image-orientation/image-orientation-expected.txt: Fixed wrong description.
- fast/css/image-orientation/image-orientation.html: Remove a space.
- 6:41 PM Changeset in webkit [157908] by
-
- 3 edits in trunk/Source/WebCore
Tighten typing in SVGInlineTextBox a bit.
<https://webkit.org/b/123238>
Use RenderBoxModelObject& instead of generic RenderObject* in some
places where it happens as a natural consequence of keeping the
original return type from InlineBox::parent()->renderer().
Reviewed by Anders Carlsson.
- 6:30 PM Changeset in webkit [157907] by
-
- 66 edits in trunk/Source/WebCore
Introduce RENDER_OBJECT_TYPE_CASTS to replace manual toFoo() in child render object
https://bugs.webkit.org/show_bug.cgi?id=123150
Reviewed by Andreas Kling.
As a step to let toFoo use TYPE_CASTS_BASE, toRenderFoo() can use it for child render object.
So, this patch introduces RENDER_OBJECT_TYPE_CASTS based on the TYPE_CASTS_BASE. This will
generate plenty more helper functions for render object type cast.
Some unnecessary type casts are fixed by this change.
No new tests, no behavior changes.
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.h:
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.h:
- rendering/RenderButton.h:
- rendering/RenderCounter.h:
- rendering/RenderElement.h:
(WebCore::RenderElement::generatingElement):
- rendering/RenderEmbeddedObject.h:
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.h:
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlowThread.h:
- rendering/RenderFrame.h:
- rendering/RenderFrameSet.h:
- rendering/RenderFullScreen.h:
- rendering/RenderHTMLCanvas.h:
- rendering/RenderIFrame.h:
- rendering/RenderImage.h:
- rendering/RenderInline.h:
- rendering/RenderLayerModelObject.h:
- rendering/RenderLineBreak.h:
- rendering/RenderListBox.h:
- rendering/RenderListItem.h:
- rendering/RenderMedia.h:
- rendering/RenderMenuList.h:
- rendering/RenderMeter.h:
- rendering/RenderMultiColumnBlock.h:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderNamedFlowThread.h:
- rendering/RenderObject.h:
- rendering/RenderProgress.h:
- rendering/RenderQuote.h:
- rendering/RenderRegion.h:
- rendering/RenderReplaced.h:
- rendering/RenderRubyRun.h:
- rendering/RenderScrollbarPart.h:
- rendering/RenderSearchField.h:
- rendering/RenderSlider.h:
- rendering/RenderSnapshottedPlugIn.h:
- rendering/RenderTable.h:
- rendering/RenderTableCaption.h:
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.h:
- rendering/RenderText.h:
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.h:
- rendering/RenderWidget.h:
- rendering/mathml/RenderMathMLBlock.h:
- rendering/svg/RenderSVGContainer.h:
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGInlineText.h:
- rendering/svg/RenderSVGPath.h:
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGShape.h:
- rendering/svg/RenderSVGText.h:
- rendering/svg/RenderSVGTextPath.h:
- rendering/svg/RenderSVGViewportContainer.h:
- rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paint):
- 6:23 PM Changeset in webkit [157906] by
-
- 5 edits in trunk/Source
Versioning.
- 6:21 PM Changeset in webkit [157905] by
-
- 1 copy in tags/Safari-538.3
New Tag.
- 6:04 PM Changeset in webkit [157904] by
-
- 2 edits1255 adds in trunk/LayoutTests
Forgot to add 1.0.1 conformance tests in r157888.
- webgl/1.0.1
- 5:14 PM Changeset in webkit [157903] by
-
- 1 edit in trunk/Source/WTF/ChangeLog
Tweak ChangeLog.
- 5:12 PM Changeset in webkit [157902] by
-
- 2 edits1 add in trunk/LayoutTests
fast/forms/input-type-text-min-width.html fails on Mavericks.
https://bugs.webkit.org/show_bug.cgi?id=123235
- platform/mac-mountainlion/TestExpectations: Added.
- platform/mac/TestExpectations:
- 5:06 PM Changeset in webkit [157901] by
-
- 2 edits in trunk/Source/WebKit2
Web Inspector: Make WebKitEFL port work with chromedevtools
https://bugs.webkit.org/show_bug.cgi?id=123017
Patch by Tibor Meszaros <tmeszaros@inf.u-szeged.hu> on 2013-10-23
Reviewed by Gustavo Noronha Silva.
Added /json path and extended the returned JSON format
with the required extra informations
- UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::buildPageList):
- 4:50 PM Changeset in webkit [157900] by
-
- 3 edits6 adds in trunk
Include misspelling dot gap width when centering misspelling dots
https://bugs.webkit.org/show_bug.cgi?id=122365
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-23
Reviewed by Simon Fraser.
Source/WebCore:
When calculating where to place the misspelling dots, we find the
maximum number of full dots that can fit under the misspelled word,
and then center a run of that many dots. However, when we're
centering the run, we are only considering the size of the extra
fractional dot that we cut off. However, the dot image has a "gap"
of transparent pixels (which visually provide tracking for the dots)
which visually appears to be empty space. We should take this gap
space into consideration when centering the run of dots. We also
should make sure that our dots start on integral pixel boundaries
because otherwise we can't set the phase of the dot run properly.
Test: editing/spelling/centering-misspelling-dots.html
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
LayoutTests:
Created a pixel new test where taking this gap width into account when
performing the centering calculation actually changes the location of
where the dots end up. In addition, created a pixel test that misspells
two words next to each other to make sure that the misspelling dots don't
appear under the space between the words.
- editing/spelling/centering-misspelling-dots-expected.txt: Added.
- editing/spelling/centering-misspelling-dots.html: Added.
- platform/mac/editing/spelling/centering-misspelling-dots-expected.png: Added.
- editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.txt: Added.
- editing/spelling/misspelling-dots-dont-extend-beyond-words.html: Added.
- platform/mac/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.png: Added.
- 4:23 PM Changeset in webkit [157899] by
-
- 6 edits in trunk/Source/WebCore
SVGFilterBuilder should not be ref-counted.
<https://webkit.org/b/123222>
These objects are singly-owned and do not need ref counting.
Reviewed by Anders Carlsson.
- 4:01 PM Changeset in webkit [157898] by
-
- 3 edits in trunk/Source/WebCore
Remove unused IDBBackingStoreLevelDB default constructor.
Rubberstamped by Anders Carlsson.
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- 4:01 PM Changeset in webkit [157897] by
-
- 3 edits in trunk/Source/WTF
Remove USE(LOCKFREE_THREADSAFEREFCOUNTED)
https://bugs.webkit.org/show_bug.cgi?id=123228
Reviewed by Geoffrey Garen.
All ports supports USE(LOCKFREE_THREADSAFEREFCOUNTED) now and taking a lock on every ref/deref seems bad.
- wtf/Atomics.h:
- wtf/ThreadSafeRefCounted.h:
(WTF::ThreadSafeRefCountedBase::ref):
(WTF::ThreadSafeRefCountedBase::refCount):
(WTF::ThreadSafeRefCountedBase::derefBase):
- 3:58 PM Changeset in webkit [157896] by
-
- 2 edits in trunk/LayoutTests
ASSERT d->m_defersLoading != defers on detik.com and drive.google.com
https://bugs.webkit.org/show_bug.cgi?id=111902
- platform/mac/TestExpectations: Remove stale test expectations associated with this
bug, it's been fixed for a long time. Flakiness dashboard concurs.
- 3:57 PM Changeset in webkit [157895] by
-
- 4 edits in trunk/Source/WebCore
Added Texture Mapper and Coordinated Graphics to Windows build for WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=123215
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
Added source files for Texture Mapper to Windows build.
- WebCore.vcxproj/WebCoreCairo.props:
Added Texture Mapper include directories for WinCairo.
- 3:50 PM Changeset in webkit [157894] by
-
- 19 edits in trunk/Source
Remove HAVE_XPC
https://bugs.webkit.org/show_bug.cgi?id=123226
Reviewed by Dan Bernstein.
HAVE_XPC has been true on Mac since Lion, so remove it.
Source/WebKit2:
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm:
(DatabaseServiceInitializer):
- NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:
(NetworkServiceInitializer):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::Identifier::Identifier):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::platformInitialize):
- Platform/WorkQueue.h:
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(PluginServiceInitializer):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
- UIProcess/Databases/mac/DatabaseProcessProxyMac.mm:
(WebKit::shouldUseXPC):
(WebKit::DatabaseProcessProxy::platformGetLaunchOptions):
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::didFinishLaunchingProcess):
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::setUpTerminationNotificationHandler):
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Network/mac/NetworkProcessProxyMac.mm:
(WebKit::shouldUseXPC):
(WebKit::NetworkProcessProxy::platformGetLaunchOptions):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::shouldUseXPC):
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::shouldUseXPC):
(WebKit::WebProcessProxy::platformGetLaunchOptions):
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
Source/WTF:
- wtf/Platform.h:
- 3:31 PM Changeset in webkit [157893] by
-
- 356 edits355 copies121 adds in trunk/LayoutTests
Migrate existing platform/mac layout test results to mac-mountainlion, and add new platform/mac results for Mavericks.
- platform/mac-mountainlion/accessibility/lists-expected.txt: Copied from LayoutTests/platform/mac/accessibility/lists-expected.txt.
- platform/mac-mountainlion/canvas/philip/tests/2d.line.join.parallel-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-161-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-161-expected.png.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-161-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-19b-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.png.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-23-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.png.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-24-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.png.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-64-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.png.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-68-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.png.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-69-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.png.
- platform/mac-mountainlion/css3/selectors3/html/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-161-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-161-expected.png.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.png.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-23-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.png.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-24-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.png.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-64-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.png.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-68-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.png.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-69-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.png.
- platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-161-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-161-expected.png.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-161-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-19b-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.png.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-23-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-23-expected.png.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-24-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-24-expected.png.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-64-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-64-expected.png.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-68-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-68-expected.png.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-69-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-69-expected.png.
- platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt.
- platform/mac-mountainlion/editing/input/caret-at-the-edge-of-input-expected.txt: Copied from LayoutTests/platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt.
- platform/mac-mountainlion/editing/inserting/before-after-input-element-expected.png: Copied from LayoutTests/platform/mac/editing/inserting/before-after-input-element-expected.png.
- platform/mac-mountainlion/editing/inserting/before-after-input-element-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/before-after-input-element-expected.txt.
- platform/mac-mountainlion/editing/pasteboard/drop-text-without-selection-expected.png: Copied from LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.png.
- platform/mac-mountainlion/editing/pasteboard/drop-text-without-selection-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt.
- platform/mac-mountainlion/editing/pasteboard/input-field-1-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/input-field-1-expected.txt.
- platform/mac-mountainlion/editing/selection/3690703-2-expected.png: Copied from LayoutTests/platform/mac/editing/selection/3690703-2-expected.png.
- platform/mac-mountainlion/editing/selection/3690703-2-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-2-expected.txt.
- platform/mac-mountainlion/editing/selection/3690703-expected.png: Copied from LayoutTests/platform/mac/editing/selection/3690703-expected.png.
- platform/mac-mountainlion/editing/selection/3690703-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-expected.txt.
- platform/mac-mountainlion/editing/selection/3690719-expected.png: Copied from LayoutTests/platform/mac/editing/selection/3690719-expected.png.
- platform/mac-mountainlion/editing/selection/3690719-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690719-expected.txt.
- platform/mac-mountainlion/editing/selection/4895428-3-expected.png: Copied from LayoutTests/platform/mac/editing/selection/4895428-3-expected.png.
- platform/mac-mountainlion/editing/selection/4895428-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4895428-3-expected.txt.
- platform/mac-mountainlion/editing/selection/4975120-expected.png: Copied from LayoutTests/platform/mac/editing/selection/4975120-expected.png.
- platform/mac-mountainlion/editing/selection/4975120-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4975120-expected.txt.
- platform/mac-mountainlion/editing/selection/drag-select-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/drag-select-1-expected.txt.
- platform/mac-mountainlion/editing/selection/replaced-boundaries-3-expected.png: Copied from LayoutTests/platform/mac/editing/selection/replaced-boundaries-3-expected.png.
- platform/mac-mountainlion/editing/selection/replaced-boundaries-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/replaced-boundaries-3-expected.txt.
- platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/103-expected.txt.
- platform/mac-mountainlion/fast/css/continuationCrash-expected.png: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.png.
- platform/mac-mountainlion/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
- platform/mac-mountainlion/fast/css/css2-system-fonts-expected.png: Copied from LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.png.
- platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt: Copied from LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt.
- platform/mac-mountainlion/fast/css/input-search-padding-expected.png: Copied from LayoutTests/platform/mac/fast/css/input-search-padding-expected.png.
- platform/mac-mountainlion/fast/css/input-search-padding-expected.txt: Copied from LayoutTests/platform/mac/fast/css/input-search-padding-expected.txt.
- platform/mac-mountainlion/fast/css/line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/css/line-height-expected.txt.
- platform/mac-mountainlion/fast/css/text-overflow-input-expected.png: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.png.
- platform/mac-mountainlion/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
- platform/mac-mountainlion/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
- platform/mac-mountainlion/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png.
- platform/mac-mountainlion/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt.
- platform/mac-mountainlion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Copied from LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png.
- platform/mac-mountainlion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt.
- platform/mac-mountainlion/fast/dom/isindex-001-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-001-expected.txt.
- platform/mac-mountainlion/fast/dom/isindex-002-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-002-expected.txt.
- platform/mac-mountainlion/fast/dynamic/008-expected.png: Copied from LayoutTests/platform/mac/fast/dynamic/008-expected.png.
- platform/mac-mountainlion/fast/dynamic/008-expected.txt: Copied from LayoutTests/platform/mac/fast/dynamic/008-expected.txt.
- platform/mac-mountainlion/fast/events/context-no-deselect-expected.txt: Copied from LayoutTests/platform/mac/fast/events/context-no-deselect-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label01-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label02-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label02-expected.png.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label02-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label03-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label03-expected.png.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label03-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label03-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label04-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label04-expected.png.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label04-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label05-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label05-expected.png.
- platform/mac-mountainlion/fast/forms/HTMLOptionElement_label05-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-inputs-expected.png: Copied from LayoutTests/platform/mac/fast/forms/basic-inputs-expected.png.
- platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-inputs-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-selects-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-selects-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-textareas-expected.png: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-expected.png.
- platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt.
- platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.png: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.png.
- platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt.
- platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.txt.
- platform/mac-mountainlion/fast/forms/button-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-align-expected.png.
- platform/mac-mountainlion/fast/forms/button-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-align-expected.txt.
- platform/mac-mountainlion/fast/forms/button-positioned-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.png.
- platform/mac-mountainlion/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
- platform/mac-mountainlion/fast/forms/button-sizes-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.png.
- platform/mac-mountainlion/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
- platform/mac-mountainlion/fast/forms/button-style-color-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-style-color-expected.png.
- platform/mac-mountainlion/fast/forms/button-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-style-color-expected.txt.
- platform/mac-mountainlion/fast/forms/button-table-styles-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-table-styles-expected.png.
- platform/mac-mountainlion/fast/forms/button-table-styles-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-table-styles-expected.txt.
- platform/mac-mountainlion/fast/forms/button-text-transform-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-text-transform-expected.png.
- platform/mac-mountainlion/fast/forms/button-text-transform-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-text-transform-expected.txt.
- platform/mac-mountainlion/fast/forms/button-white-space-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-white-space-expected.png.
- platform/mac-mountainlion/fast/forms/button-white-space-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-white-space-expected.txt.
- platform/mac-mountainlion/fast/forms/control-clip-expected.png: Copied from LayoutTests/platform/mac/fast/forms/control-clip-expected.png.
- platform/mac-mountainlion/fast/forms/control-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-expected.txt.
- platform/mac-mountainlion/fast/forms/control-clip-overflow-expected.png: Copied from LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.png.
- platform/mac-mountainlion/fast/forms/control-clip-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.txt.
- platform/mac-mountainlion/fast/forms/control-restrict-line-height-expected.png: Copied from LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.png.
- platform/mac-mountainlion/fast/forms/control-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt.
- platform/mac-mountainlion/fast/forms/encoding-test-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/encoding-test-expected.txt.
- platform/mac-mountainlion/fast/forms/fieldset-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/fieldset-align-expected.png.
- platform/mac-mountainlion/fast/forms/fieldset-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/fieldset-align-expected.txt.
- platform/mac-mountainlion/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file/input-file-re-render-expected.txt.
- platform/mac-mountainlion/fast/forms/form-element-geometry-expected.png: Copied from LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.png.
- platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt.
- platform/mac-mountainlion/fast/forms/hidden-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/hidden-listbox-expected.txt.
- platform/mac-mountainlion/fast/forms/input-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-align-expected.png.
- platform/mac-mountainlion/fast/forms/input-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-align-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-bkcolor-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-bkcolor-expected.png.
- platform/mac-mountainlion/fast/forms/input-appearance-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-bkcolor-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-default-bkcolor-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png.
- platform/mac-mountainlion/fast/forms/input-appearance-default-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-disabled-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-focus-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-focus-expected.png.
- platform/mac-mountainlion/fast/forms/input-appearance-focus-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-focus-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-height-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-preventDefault-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.png.
- platform/mac-mountainlion/fast/forms/input-appearance-preventDefault-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-readonly-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-selection-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-selection-expected.png.
- platform/mac-mountainlion/fast/forms/input-appearance-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-selection-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-visibility-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-visibility-expected.txt.
- platform/mac-mountainlion/fast/forms/input-appearance-width-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-width-expected.png.
- platform/mac-mountainlion/fast/forms/input-appearance-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-width-expected.txt.
- platform/mac-mountainlion/fast/forms/input-baseline-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-baseline-expected.png.
- platform/mac-mountainlion/fast/forms/input-button-sizes-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.png.
- platform/mac-mountainlion/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
- platform/mac-mountainlion/fast/forms/input-disabled-color-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.png.
- platform/mac-mountainlion/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
- platform/mac-mountainlion/fast/forms/input-double-click-selection-gap-bug-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png.
- platform/mac-mountainlion/fast/forms/input-double-click-selection-gap-bug-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt.
- platform/mac-mountainlion/fast/forms/input-field-text-truncated-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-field-text-truncated-expected.png.
- platform/mac-mountainlion/fast/forms/input-field-text-truncated-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-field-text-truncated-expected.txt.
- platform/mac-mountainlion/fast/forms/input-placeholder-visibility-1-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt.
- platform/mac-mountainlion/fast/forms/input-placeholder-visibility-3-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt.
- platform/mac-mountainlion/fast/forms/input-readonly-autoscroll-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-autoscroll-expected.png.
- platform/mac-mountainlion/fast/forms/input-readonly-autoscroll-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-autoscroll-expected.txt.
- platform/mac-mountainlion/fast/forms/input-readonly-dimmed-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.png.
- platform/mac-mountainlion/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
- platform/mac-mountainlion/fast/forms/input-readonly-empty-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-empty-expected.txt.
- platform/mac-mountainlion/fast/forms/input-spaces-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-spaces-expected.txt.
- platform/mac-mountainlion/fast/forms/input-table-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-table-expected.png.
- platform/mac-mountainlion/fast/forms/input-table-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-table-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-click-inside-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-inside-expected.png.
- platform/mac-mountainlion/fast/forms/input-text-click-inside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-inside-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-click-outside-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-outside-expected.png.
- platform/mac-mountainlion/fast/forms/input-text-click-outside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-outside-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-double-click-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-double-click-expected.png.
- platform/mac-mountainlion/fast/forms/input-text-double-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-double-click-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-drag-down-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-drag-down-expected.png.
- platform/mac-mountainlion/fast/forms/input-text-drag-down-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-drag-down-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-option-delete-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-option-delete-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-scroll-left-on-blur-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png.
- platform/mac-mountainlion/fast/forms/input-text-scroll-left-on-blur-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-self-emptying-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-self-emptying-click-expected.txt.
- platform/mac-mountainlion/fast/forms/input-text-word-wrap-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.png.
- platform/mac-mountainlion/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
- platform/mac-mountainlion/fast/forms/input-value-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-value-expected.txt.
- platform/mac-mountainlion/fast/forms/input-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-width-expected.txt.
- platform/mac-mountainlion/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
- platform/mac-mountainlion/fast/forms/listbox-hit-test-zoomed-expected.png: Copied from LayoutTests/platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png.
- platform/mac-mountainlion/fast/forms/listbox-hit-test-zoomed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt.
- platform/mac-mountainlion/fast/forms/listbox-width-change-expected.png: Copied from LayoutTests/platform/mac/fast/forms/listbox-width-change-expected.png.
- platform/mac-mountainlion/fast/forms/listbox-width-change-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-width-change-expected.txt.
- platform/mac-mountainlion/fast/forms/menulist-no-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-no-overflow-expected.txt.
- platform/mac-mountainlion/fast/forms/menulist-option-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-option-wrap-expected.txt.
- platform/mac-mountainlion/fast/forms/menulist-restrict-line-height-expected.png: Copied from LayoutTests/platform/mac/fast/forms/menulist-restrict-line-height-expected.png.
- platform/mac-mountainlion/fast/forms/menulist-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-restrict-line-height-expected.txt.
- platform/mac-mountainlion/fast/forms/minWidthPercent-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/minWidthPercent-expected.txt.
- platform/mac-mountainlion/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-rtl-expected.png.
- platform/mac-mountainlion/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-rtl-expected.txt.
- platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png.
- platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt.
- platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt.
- platform/mac-mountainlion/fast/forms/placeholder-position-expected.png: Copied from LayoutTests/platform/mac/fast/forms/placeholder-position-expected.png.
- platform/mac-mountainlion/fast/forms/placeholder-pseudo-style-expected.png: Copied from LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.png.
- platform/mac-mountainlion/fast/forms/placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt.
- platform/mac-mountainlion/fast/forms/plaintext-mode-2-expected.png: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.png.
- platform/mac-mountainlion/fast/forms/plaintext-mode-2-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.txt.
- platform/mac-mountainlion/fast/forms/search-cancel-button-style-sharing-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt.
- platform/mac-mountainlion/fast/forms/search-display-none-cancel-button-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-display-none-cancel-button-expected.txt.
- platform/mac-mountainlion/fast/forms/search-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search-rtl-expected.png.
- platform/mac-mountainlion/fast/forms/search-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-rtl-expected.txt.
- platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search-vertical-alignment-expected.png.
- platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-vertical-alignment-expected.txt.
- platform/mac-mountainlion/fast/forms/search/search-size-with-decorations-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search/search-size-with-decorations-expected.png.
- platform/mac-mountainlion/fast/forms/searchfield-heights-expected.png: Copied from LayoutTests/platform/mac/fast/forms/searchfield-heights-expected.png.
- platform/mac-mountainlion/fast/forms/searchfield-heights-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/searchfield-heights-expected.txt.
- platform/mac-mountainlion/fast/forms/select-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-align-expected.png.
- platform/mac-mountainlion/fast/forms/select-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-align-expected.txt.
- platform/mac-mountainlion/fast/forms/select-change-listbox-to-popup-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-to-popup-expected.png.
- platform/mac-mountainlion/fast/forms/select-change-listbox-to-popup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt.
- platform/mac-mountainlion/fast/forms/select-change-popup-to-listbox-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.png.
- platform/mac-mountainlion/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
- platform/mac-mountainlion/fast/forms/select-disabled-appearance-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-disabled-appearance-expected.png.
- platform/mac-mountainlion/fast/forms/select-disabled-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-disabled-appearance-expected.txt.
- platform/mac-mountainlion/fast/forms/select-empty-option-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-empty-option-height-expected.txt.
- platform/mac-mountainlion/fast/forms/select-initial-position-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-initial-position-expected.png.
- platform/mac-mountainlion/fast/forms/select-initial-position-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-initial-position-expected.txt.
- platform/mac-mountainlion/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt.
- platform/mac-mountainlion/fast/forms/select-selected-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.png.
- platform/mac-mountainlion/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
- platform/mac-mountainlion/fast/forms/stuff-on-my-optgroup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/stuff-on-my-optgroup-expected.txt.
- platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.png: Copied from LayoutTests/platform/mac/fast/forms/tabbing-input-iframe-expected.png.
- platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/tabbing-input-iframe-expected.txt.
- platform/mac-mountainlion/fast/forms/text-style-color-expected.png: Copied from LayoutTests/platform/mac/fast/forms/text-style-color-expected.png.
- platform/mac-mountainlion/fast/forms/text-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/text-style-color-expected.txt.
- platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.png.
- platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-align-expected.png.
- platform/mac-mountainlion/fast/forms/textarea-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-align-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-scrolled-type-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.png.
- platform/mac-mountainlion/fast/forms/textarea-scrolled-type-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.txt.
- platform/mac-mountainlion/fast/forms/textarea-setinnerhtml-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-setinnerhtml-expected.txt.
- platform/mac-mountainlion/fast/forms/textfield-focus-ring-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textfield-focus-ring-expected.png.
- platform/mac-mountainlion/fast/forms/textfield-focus-ring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-focus-ring-expected.txt.
- platform/mac-mountainlion/fast/forms/textfield-outline-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textfield-outline-expected.png.
- platform/mac-mountainlion/fast/forms/textfield-outline-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-outline-expected.txt.
- platform/mac-mountainlion/fast/forms/textfield-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-overflow-expected.txt.
- platform/mac-mountainlion/fast/forms/validation-message-appearance-expected.png: Copied from LayoutTests/platform/mac/fast/forms/validation-message-appearance-expected.png.
- platform/mac-mountainlion/fast/forms/validation-message-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/validation-message-appearance-expected.txt.
- platform/mac-mountainlion/fast/forms/visual-hebrew-text-field-expected.png: Copied from LayoutTests/platform/mac/fast/forms/visual-hebrew-text-field-expected.png.
- platform/mac-mountainlion/fast/forms/visual-hebrew-text-field-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/visual-hebrew-text-field-expected.txt.
- platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/take-focus-from-iframe-expected.txt.
- platform/mac-mountainlion/fast/html/details-no-summary4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-no-summary4-expected.txt.
- platform/mac-mountainlion/fast/html/details-open-javascript-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open-javascript-expected.txt.
- platform/mac-mountainlion/fast/html/details-open2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open2-expected.txt.
- platform/mac-mountainlion/fast/html/details-open4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open4-expected.txt.
- platform/mac-mountainlion/fast/html/details-replace-summary-child-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.txt.
- platform/mac-mountainlion/fast/html/details-replace-text-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-text-expected.txt.
- platform/mac-mountainlion/fast/lists/dynamic-marker-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/lists/dynamic-marker-crash-expected.txt.
- platform/mac-mountainlion/fast/overflow/overflow-x-y-expected.png: Copied from LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.png.
- platform/mac-mountainlion/fast/overflow/overflow-x-y-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.txt.
- platform/mac-mountainlion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt.
- platform/mac-mountainlion/fast/parser/document-write-option-expected.png: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.png.
- platform/mac-mountainlion/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
- platform/mac-mountainlion/fast/parser/entity-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/entity-comment-in-textarea-expected.txt.
- platform/mac-mountainlion/fast/parser/open-comment-in-textarea-expected.png: Copied from LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.png.
- platform/mac-mountainlion/fast/parser/open-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.txt.
- platform/mac-mountainlion/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt.
- platform/mac-mountainlion/fast/repaint/subtree-root-skipped-expected.png: Copied from LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.png.
- platform/mac-mountainlion/fast/repaint/subtree-root-skipped-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.txt.
- platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.png: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.png.
- platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt.
- platform/mac-mountainlion/fast/replaced/replaced-breaking-mixture-expected.png: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-mixture-expected.png.
- platform/mac-mountainlion/fast/replaced/replaced-breaking-mixture-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt.
- platform/mac-mountainlion/fast/selectors/064-expected.png: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.png.
- platform/mac-mountainlion/fast/selectors/064-expected.txt: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.txt.
- platform/mac-mountainlion/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt.
- platform/mac-mountainlion/fast/table/colspanMinWidth-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-expected.txt.
- platform/mac-mountainlion/fast/table/colspanMinWidth-vertical-expected.png: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.png.
- platform/mac-mountainlion/fast/table/colspanMinWidth-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.txt.
- platform/mac-mountainlion/fast/table/text-field-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/table/text-field-baseline-expected.txt.
- platform/mac-mountainlion/fast/text/backslash-to-yen-sign-euc-expected.png: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png.
- platform/mac-mountainlion/fast/text/backslash-to-yen-sign-euc-expected.txt: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt.
- platform/mac-mountainlion/fast/text/drawBidiText-expected.png: Copied from LayoutTests/platform/mac/fast/text/drawBidiText-expected.png.
- platform/mac-mountainlion/fast/text/drawBidiText-expected.txt: Copied from LayoutTests/platform/mac/fast/text/drawBidiText-expected.txt.
- platform/mac-mountainlion/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
- platform/mac-mountainlion/fast/text/international/bold-bengali-expected.txt: Added.
- platform/mac-mountainlion/fast/text/international/hindi-spacing-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.txt.
- platform/mac-mountainlion/fast/text/international/khmer-selection-expected.txt: Added.
- platform/mac-mountainlion/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png.
- platform/mac-mountainlion/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
- platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png.
- platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt.
- platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.png: Copied from LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.png.
- platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.txt: Copied from LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.txt.
- platform/mac-mountainlion/fast/text/updateNewFont-expected.txt: Copied from LayoutTests/platform/mac/fast/text/updateNewFont-expected.txt.
- platform/mac-mountainlion/fast/transforms/transformed-focused-text-input-expected.txt: Copied from LayoutTests/platform/mac/fast/transforms/transformed-focused-text-input-expected.txt.
- platform/mac-mountainlion/fast/writing-mode/text-orientation-basic-expected.txt: Added.
- platform/mac-mountainlion/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt.
- platform/mac-mountainlion/fonts/cursive-expected.txt: Added.
- platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.png: Copied from LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.png.
- platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt: Copied from LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt.
- platform/mac-mountainlion/http/tests/xmlhttprequest/head-redirection-expected.txt: Copied from LayoutTests/platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt.
- platform/mac-mountainlion/media/video-controls-captions-trackmenu-localized-expected.txt: Added.
- platform/mac-mountainlion/media/video-controls-captions-trackmenu-sorted-expected.txt: Copied from LayoutTests/platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt.
- platform/mac-mountainlion/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt.
- platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.png: Copied from LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.png.
- platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.txt.
- platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.png: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.png.
- platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt.
- platform/mac-mountainlion/plugins/mouse-click-plugin-clears-selection-expected.txt: Copied from LayoutTests/platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt.
- platform/mac-mountainlion/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt.
- platform/mac-mountainlion/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt.
- platform/mac-mountainlion/svg/custom/use-on-symbol-inside-pattern-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt.
- platform/mac-mountainlion/svg/hixie/mixed/003-expected.png: Copied from LayoutTests/platform/mac/svg/hixie/mixed/003-expected.png.
- platform/mac-mountainlion/svg/hixie/mixed/003-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/mixed/003-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1188-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1188-expected.png.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1188-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1188-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12384-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug12384-expected.png.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12384-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug12384-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug138725-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug138725-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug18359-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug18359-expected.png.
- platform/mac-mountainlion/tables/mozilla/bugs/bug18359-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug18359-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug24200-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug24200-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-2-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.png.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-3-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.png.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2479-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug26178-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug28928-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug28928-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug29326-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug29326-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug30692-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug4382-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4382-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug46368-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug46368-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug51037-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51037-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug51727-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51727-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug52505-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug52505-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug55545-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug55545-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug59354-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug59354-expected.png.
- platform/mac-mountainlion/tables/mozilla/bugs/bug59354-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug59354-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug68912-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug68912-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug7342-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug7342-expected.png.
- platform/mac-mountainlion/tables/mozilla/bugs/bug7342-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug7342-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug96334-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug96334-expected.png.
- platform/mac-mountainlion/tables/mozilla/bugs/bug96334-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug96334-expected.txt.
- platform/mac-mountainlion/tables/mozilla/bugs/bug99948-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug99948-expected.png.
- platform/mac-mountainlion/tables/mozilla/bugs/bug99948-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug99948-expected.txt.
- platform/mac-mountainlion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt.
- platform/mac-mountainlion/tables/mozilla/core/margins-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/core/margins-expected.txt.
- platform/mac-mountainlion/tables/mozilla/dom/tableDom-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/dom/tableDom-expected.png.
- platform/mac-mountainlion/tables/mozilla/dom/tableDom-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/dom/tableDom-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png.
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png.
- platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png.
- platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt.
- platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png.
- platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt.
- platform/mac-mountainlion/transforms/2d/zoom-menulist-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/zoom-menulist-expected.txt.
- platform/mac-mountainlion/transforms/3d/general/perspective-non-layer-expected.txt: Copied from LayoutTests/platform/mac/transforms/3d/general/perspective-non-layer-expected.txt.
- platform/mac-mountainlion/transitions/default-timing-function-expected.txt: Added.
- platform/mac/accessibility/aria-readonly-expected.txt: Added.
- platform/mac/accessibility/lists-expected.txt:
- platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-161-expected.png:
- platform/mac/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-19b-expected.png:
- platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-23-expected.png:
- platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-24-expected.png:
- platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-64-expected.png:
- platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-68-expected.png:
- platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-69-expected.png:
- platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.png:
- platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
- platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
- platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
- platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.png:
- platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
- platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
- platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-161-expected.png:
- platform/mac/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.png:
- platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-23-expected.png:
- platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-24-expected.png:
- platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-64-expected.png:
- platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-68-expected.png:
- platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-69-expected.png:
- platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
- platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/mac/editing/inserting/before-after-input-element-expected.png:
- platform/mac/editing/inserting/before-after-input-element-expected.txt:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
- platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/mac/editing/pasteboard/input-field-1-expected.txt:
- platform/mac/editing/selection/3690703-2-expected.png:
- platform/mac/editing/selection/3690703-2-expected.txt:
- platform/mac/editing/selection/3690703-expected.png:
- platform/mac/editing/selection/3690703-expected.txt:
- platform/mac/editing/selection/3690719-expected.png:
- platform/mac/editing/selection/3690719-expected.txt:
- platform/mac/editing/selection/4895428-3-expected.png:
- platform/mac/editing/selection/4895428-3-expected.txt:
- platform/mac/editing/selection/4975120-expected.png:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/drag-select-1-expected.txt:
- platform/mac/editing/selection/replaced-boundaries-3-expected.png:
- platform/mac/editing/selection/replaced-boundaries-3-expected.txt:
- platform/mac/fast/block/margin-collapse/103-expected.txt:
- platform/mac/fast/css/continuationCrash-expected.png:
- platform/mac/fast/css/continuationCrash-expected.txt:
- platform/mac/fast/css/css2-system-fonts-expected.png:
- platform/mac/fast/css/css2-system-fonts-expected.txt:
- platform/mac/fast/css/input-search-padding-expected.png:
- platform/mac/fast/css/input-search-padding-expected.txt:
- platform/mac/fast/css/line-height-expected.txt:
- platform/mac/fast/css/text-overflow-input-expected.png:
- platform/mac/fast/css/text-overflow-input-expected.txt:
- platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/mac/fast/dom/isindex-001-expected.txt:
- platform/mac/fast/dom/isindex-002-expected.txt:
- platform/mac/fast/dynamic/008-expected.png:
- platform/mac/fast/dynamic/008-expected.txt:
- platform/mac/fast/events/context-no-deselect-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label02-expected.png:
- platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label03-expected.png:
- platform/mac/fast/forms/HTMLOptionElement_label03-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label04-expected.png:
- platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt:
- platform/mac/fast/forms/HTMLOptionElement_label05-expected.png:
- platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt:
- platform/mac/fast/forms/basic-inputs-expected.png:
- platform/mac/fast/forms/basic-inputs-expected.txt:
- platform/mac/fast/forms/basic-selects-expected.txt:
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- platform/mac/fast/forms/basic-textareas-quirks-expected.png:
- platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
- platform/mac/fast/forms/box-shadow-override-expected.txt:
- platform/mac/fast/forms/button-align-expected.png:
- platform/mac/fast/forms/button-align-expected.txt:
- platform/mac/fast/forms/button-positioned-expected.png:
- platform/mac/fast/forms/button-positioned-expected.txt:
- platform/mac/fast/forms/button-sizes-expected.png:
- platform/mac/fast/forms/button-sizes-expected.txt:
- platform/mac/fast/forms/button-style-color-expected.png:
- platform/mac/fast/forms/button-style-color-expected.txt:
- platform/mac/fast/forms/button-table-styles-expected.png:
- platform/mac/fast/forms/button-table-styles-expected.txt:
- platform/mac/fast/forms/button-text-transform-expected.png:
- platform/mac/fast/forms/button-text-transform-expected.txt:
- platform/mac/fast/forms/button-white-space-expected.png:
- platform/mac/fast/forms/button-white-space-expected.txt:
- platform/mac/fast/forms/control-clip-expected.png:
- platform/mac/fast/forms/control-clip-expected.txt:
- platform/mac/fast/forms/control-clip-overflow-expected.png:
- platform/mac/fast/forms/control-clip-overflow-expected.txt:
- platform/mac/fast/forms/control-restrict-line-height-expected.png:
- platform/mac/fast/forms/control-restrict-line-height-expected.txt:
- platform/mac/fast/forms/encoding-test-expected.txt:
- platform/mac/fast/forms/fieldset-align-expected.png:
- platform/mac/fast/forms/fieldset-align-expected.txt:
- platform/mac/fast/forms/file/input-file-re-render-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.png:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/hidden-listbox-expected.txt:
- platform/mac/fast/forms/input-align-expected.png:
- platform/mac/fast/forms/input-align-expected.txt:
- platform/mac/fast/forms/input-appearance-bkcolor-expected.png:
- platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
- platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
- platform/mac/fast/forms/input-appearance-disabled-expected.txt:
- platform/mac/fast/forms/input-appearance-focus-expected.png:
- platform/mac/fast/forms/input-appearance-focus-expected.txt:
- platform/mac/fast/forms/input-appearance-height-expected.txt:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
- platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
- platform/mac/fast/forms/input-appearance-readonly-expected.txt:
- platform/mac/fast/forms/input-appearance-selection-expected.png:
- platform/mac/fast/forms/input-appearance-selection-expected.txt:
- platform/mac/fast/forms/input-appearance-visibility-expected.txt:
- platform/mac/fast/forms/input-appearance-width-expected.png:
- platform/mac/fast/forms/input-appearance-width-expected.txt:
- platform/mac/fast/forms/input-baseline-expected.png:
- platform/mac/fast/forms/input-baseline-expected.txt: Added.
- platform/mac/fast/forms/input-button-sizes-expected.png:
- platform/mac/fast/forms/input-button-sizes-expected.txt:
- platform/mac/fast/forms/input-disabled-color-expected.png:
- platform/mac/fast/forms/input-disabled-color-expected.txt:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/mac/fast/forms/input-field-text-truncated-expected.png:
- platform/mac/fast/forms/input-field-text-truncated-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
- platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/mac/fast/forms/input-readonly-dimmed-expected.png:
- platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
- platform/mac/fast/forms/input-readonly-empty-expected.txt:
- platform/mac/fast/forms/input-spaces-expected.txt:
- platform/mac/fast/forms/input-table-expected.png:
- platform/mac/fast/forms/input-table-expected.txt:
- platform/mac/fast/forms/input-text-click-inside-expected.png:
- platform/mac/fast/forms/input-text-click-inside-expected.txt:
- platform/mac/fast/forms/input-text-click-outside-expected.png:
- platform/mac/fast/forms/input-text-click-outside-expected.txt:
- platform/mac/fast/forms/input-text-double-click-expected.png:
- platform/mac/fast/forms/input-text-double-click-expected.txt:
- platform/mac/fast/forms/input-text-drag-down-expected.png:
- platform/mac/fast/forms/input-text-drag-down-expected.txt:
- platform/mac/fast/forms/input-text-option-delete-expected.txt:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
- platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/mac/fast/forms/input-text-word-wrap-expected.png:
- platform/mac/fast/forms/input-text-word-wrap-expected.txt:
- platform/mac/fast/forms/input-type-text-min-width-actual.png: Added.
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/forms/input-width-expected.txt:
- platform/mac/fast/forms/listbox-bidi-align-expected.png: Added.
- platform/mac/fast/forms/listbox-bidi-align-expected.txt:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt:
- platform/mac/fast/forms/listbox-width-change-expected.png:
- platform/mac/fast/forms/listbox-width-change-expected.txt:
- platform/mac/fast/forms/menulist-no-overflow-expected.txt:
- platform/mac/fast/forms/menulist-option-wrap-expected.txt:
- platform/mac/fast/forms/menulist-restrict-line-height-expected.png:
- platform/mac/fast/forms/menulist-restrict-line-height-expected.txt:
- platform/mac/fast/forms/minWidthPercent-expected.txt:
- platform/mac/fast/forms/number/number-appearance-rtl-expected.png:
- platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
- platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
- platform/mac/fast/forms/placeholder-position-expected.png:
- platform/mac/fast/forms/placeholder-position-expected.txt: Added.
- platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
- platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/mac/fast/forms/plaintext-mode-2-expected.png:
- platform/mac/fast/forms/plaintext-mode-2-expected.txt:
- platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.png:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/search-vertical-alignment-expected.png:
- platform/mac/fast/forms/search-vertical-alignment-expected.txt:
- platform/mac/fast/forms/search/search-size-with-decorations-expected.png:
- platform/mac/fast/forms/search/search-size-with-decorations-expected.txt: Added.
- platform/mac/fast/forms/searchfield-heights-expected.png:
- platform/mac/fast/forms/searchfield-heights-expected.txt:
- platform/mac/fast/forms/select-align-expected.png:
- platform/mac/fast/forms/select-align-expected.txt:
- platform/mac/fast/forms/select-change-listbox-to-popup-expected.png:
- platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:
- platform/mac/fast/forms/select-change-popup-to-listbox-expected.png:
- platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
- platform/mac/fast/forms/select-disabled-appearance-expected.png:
- platform/mac/fast/forms/select-disabled-appearance-expected.txt:
- platform/mac/fast/forms/select-empty-option-height-expected.txt:
- platform/mac/fast/forms/select-initial-position-expected.png:
- platform/mac/fast/forms/select-initial-position-expected.txt:
- platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
- platform/mac/fast/forms/select-selected-expected.png:
- platform/mac/fast/forms/select-selected-expected.txt:
- platform/mac/fast/forms/stuff-on-my-optgroup-expected.txt:
- platform/mac/fast/forms/tabbing-input-iframe-expected.png:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/text-style-color-expected.png:
- platform/mac/fast/forms/text-style-color-expected.txt:
- platform/mac/fast/forms/textAreaLineHeight-expected.png:
- platform/mac/fast/forms/textAreaLineHeight-expected.txt:
- platform/mac/fast/forms/textarea-align-expected.png:
- platform/mac/fast/forms/textarea-align-expected.txt:
- platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/mac/fast/forms/textarea-scrolled-type-expected.png:
- platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
- platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
- platform/mac/fast/forms/textfield-focus-ring-expected.png:
- platform/mac/fast/forms/textfield-focus-ring-expected.txt:
- platform/mac/fast/forms/textfield-outline-expected.png:
- platform/mac/fast/forms/textfield-outline-expected.txt:
- platform/mac/fast/forms/textfield-overflow-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.png:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
- platform/mac/fast/html/details-no-summary4-expected.txt:
- platform/mac/fast/html/details-open-javascript-expected.txt:
- platform/mac/fast/html/details-open2-expected.txt:
- platform/mac/fast/html/details-open4-expected.txt:
- platform/mac/fast/html/details-replace-summary-child-expected.txt:
- platform/mac/fast/html/details-replace-text-expected.txt:
- platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
- platform/mac/fast/overflow/overflow-x-y-expected.png:
- platform/mac/fast/overflow/overflow-x-y-expected.txt:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/mac/fast/parser/document-write-option-expected.png:
- platform/mac/fast/parser/document-write-option-expected.txt:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
- platform/mac/fast/parser/open-comment-in-textarea-expected.png:
- platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
- platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/mac/fast/repaint/search-field-cancel-expected.txt: Added.
- platform/mac/fast/repaint/subtree-root-skipped-expected.png:
- platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.png:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-mixture-expected.png:
- platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
- platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
- platform/mac/fast/selectors/064-expected.png:
- platform/mac/fast/selectors/064-expected.txt:
- platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
- platform/mac/fast/table/colspanMinWidth-expected.txt:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/mac/fast/table/text-field-baseline-expected.txt:
- platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
- platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
- platform/mac/fast/text/drawBidiText-expected.png:
- platform/mac/fast/text/drawBidiText-expected.txt:
- platform/mac/fast/text/hyphenate-locale-expected.txt:
- platform/mac/fast/text/international/cjk-segmentation-expected.txt: Added.
- platform/mac/fast/text/international/hindi-spacing-expected.txt:
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
- platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
- platform/mac/fast/text/textIteratorNilRenderer-expected.png:
- platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
- platform/mac/fast/text/updateNewFont-expected.txt:
- platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
- platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
- platform/mac/http/tests/cache/partitioned-cache-iframe-expected.txt: Added.
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
- platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt: Added.
- platform/mac/media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt: Added.
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
- platform/mac/platform/mac-wk2/TestExpectations: Added.
- platform/mac/platform/mac-wk2/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
- platform/mac/platform/mac-wk2/js/dom/constructor-length-expected.txt: Added.
- platform/mac/platform/mac-wk2/js/dom/global-constructors-attributes-expected.txt: Added.
- platform/mac/platform/mac-wk2/webaudio/oscillator-sawtooth-expected.wav: Added.
- platform/mac/platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
- platform/mac/platform/mac/accessibility/press-action-is-first-expected.txt: Added.
- platform/mac/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.
- platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.png: Added.
- platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
- platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.png: Added.
- platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.
- platform/mac/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt: Added.
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Added.
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
- platform/mac/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
- platform/mac/platform/mac/fast/text/systemFont-expected.png:
- platform/mac/platform/mac/fast/text/systemFont-expected.txt:
- platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.png:
- platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
- platform/mac/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
- platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
- platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
- platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
- platform/mac/svg/hixie/mixed/003-expected.png:
- platform/mac/svg/hixie/mixed/003-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12384-expected.png:
- platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
- platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18359-expected.png:
- platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
- platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
- platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
- platform/mac/tables/mozilla/bugs/bug29326-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
- platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
- platform/mac/tables/mozilla/bugs/bug59354-expected.png:
- platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
- platform/mac/tables/mozilla/bugs/bug68912-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7342-expected.png:
- platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.png:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- platform/mac/tables/mozilla/bugs/bug99948-expected.png:
- platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
- platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/mac/tables/mozilla/core/margins-expected.txt:
- platform/mac/tables/mozilla/dom/tableDom-expected.png:
- platform/mac/tables/mozilla/dom/tableDom-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- platform/mac/transforms/2d/zoom-menulist-expected.txt:
- platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
- platform/mac/webaudio/codec-tests/wav/24bit-22khz-resample-expected.png: Added.
- 3:26 PM Changeset in webkit [157892] by
-
- 9 edits2 copies in trunk
Adding mock class to test RTCDataChannelHandler
https://bugs.webkit.org/show_bug.cgi?id=123205
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-23
Reviewed by Eric Carlson.
Source/WebCore:
Now RTCPeerConnectionHandler-datachannel LayouTest can run properly.
Also updated the expected file, removing the reliable property check (which was removed in the spec)
Existing tests updated.
- CMakeLists.txt:
- platform/mediastream/RTCDataChannelHandlerClient.h:
- platform/mock/RTCDataChannelHandlerMock.cpp: Added.
- platform/mock/RTCDataChannelHandlerMock.h: Added.
- platform/mock/RTCNotifiersMock.cpp:
(WebCore::RemoteDataChannelNotifier::RemoteDataChannelNotifier):
(WebCore::RemoteDataChannelNotifier::fire):
(WebCore::DataChannelStateNotifier::DataChannelStateNotifier):
(WebCore::DataChannelStateNotifier::fire):
- platform/mock/RTCNotifiersMock.h:
- platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::createDataChannel):
LayoutTests:
The reliable property was removed in the spec
- fast/mediastream/RTCPeerConnection-datachannel-expected.txt:
- fast/mediastream/RTCPeerConnection-datachannel.html:
- 3:18 PM Changeset in webkit [157891] by
-
- 2 edits in trunk/Tools
Add two more mac bots to the Mavericks Test Queue.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:12 PM Changeset in webkit [157890] by
-
- 7 edits in trunk/Source/WebCore
Clock should not be ref-counted.
<https://webkit.org/b/123217>
The Clock object is only ever owned by the MediaController,
so remove the ref counting and store it in a std::unique_ptr.
Also slapped the Clock subclasses with FINAL and OVERRIDE.
Reviewed by Anders Carlsson.
- 2:48 PM Changeset in webkit [157889] by
-
- 3 edits20 adds in trunk/LayoutTests
[CSS Shapes] New positioning model: Padding
https://bugs.webkit.org/show_bug.cgi?id=118823
Reviewed by Dirk Schulze.
Tests for floats with shape-outside and padding.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 2:41 PM Changeset in webkit [157888] by
-
- 2 edits3759 adds in trunk/LayoutTests
Add 1.0.1 and 1.0.2 WebGL conformance suites to layout tests.
https://bugs.webkit.org/show_bug.cgi?id=123188
Rubberstamped by Dean Jackson.
Skip known 1.0.2 failures and any other unexpected failures for now.
- 2:15 PM Changeset in webkit [157887] by
-
- 4 edits in trunk
Have a way of dealing with slow tests in run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=123221
Tools:
Reviewed by Mark Hahnenberg.
If you add the slow! command to @ then all subsequent plans are prepended to the run list
rather than appended to it. This means that slow tests get queued up first and are less likely
to block completion.
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Mark Hahnenberg.
- js/regress/script-tests/stepanov_container.js: This test is slow!
- 2:08 PM BuildingOnMac edited by
- (diff)
- 2:08 PM Changeset in webkit [157886] by
-
- 2 edits in trunk/LayoutTests
Layout Test compositing/regions/floated-region-with-transformed-child.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123220
- platform/mac/TestExpectations: Marking as such.
- 2:07 PM BuildingOnMac edited by
- (diff)
- 2:05 PM Changeset in webkit [157885] by
-
- 2 edits in trunk/Source/WebCore
Fix assertion in DatabaseManager::detailsForNameAndOrigin() to be iOS friendly.
https://bugs.webkit.org/show_bug.cgi?id=123218.
Reviewed by Joseph Pecoraro.
No new tests.
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::detailsForNameAndOrigin):
- 2:05 PM BuildingOnMac created by
- 2:01 PM WikiStart edited by
- (diff)
- 1:59 PM Changeset in webkit [157884] by
-
- 9 edits in trunk/Source
Separated USE(CA) from USE(ACCELERATED_COMPOSITING) to prepare WinCairo for accelerated compositing.
https://bugs.webkit.org/show_bug.cgi?id=123214
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-23
Reviewed by Brent Fulgham.
Source/WebCore:
- platform/graphics/PlatformLayer.h:
Added TextureMapperPlatformLayer PlatformLayer declaration for WinCairo.
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow):
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc):
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
Added USE(CA) where necessary to compile WinCairo with accelerated compositing.
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient::delegatedScrollRequested): Added empty function.
- WebPreferences.cpp:
(WebPreferences::acceleratedCompositingEnabled):
Return true for non-CA ports using accelerated compositing.
- WebView.cpp:
(WebView::~WebView):
(WebView::sizeChanged):
(WebView::paint):
(WebView::setShouldInvertColors):
(WebView::flushPendingGraphicsLayerChangesSoon):
(WebView::setAcceleratedCompositing):
- WebView.h:
Added USE(CA) where necessary to compile WinCairo with accelerated compositing.
- 1:58 PM Changeset in webkit [157883] by
-
- 5 edits in trunk/Source/JavaScriptCore
Put all uses of LLVM intrinsics behind a single Option
https://bugs.webkit.org/show_bug.cgi?id=123219
Reviewed by Mark Hahnenberg.
- ftl/FTLExitThunkGenerator.cpp:
(JSC::FTL::ExitThunkGenerator::emitThunk):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::generateExitThunks):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileFTLOSRExit):
- runtime/Options.h:
- 1:55 PM Changeset in webkit [157882] by
-
- 8 edits in trunk/Tools
Explicitly build Win32 or x64 configuration on Windows.
https://bugs.webkit.org/show_bug.cgi?id=123206
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-23
Reviewed by Brent Fulgham.
- Scripts/webkitdirs.pm:
(jscPath):
(determineConfigurationForVisualStudio):
(determinePassedConfiguration):
Add |Win32 to the end of 32-bit Visual Studio build configurations.
(safariPath):
- Scripts/build-webkit:
- Scripts/old-run-webkit-tests:
- Scripts/run-api-tests:
(testToolPath):
- Scripts/run-javascriptcore-tests:
(testapiPath):
- Scripts/run-regexp-tests:
(testapiPath):
- Scripts/sunspider-compare-results:
(pathToBuiltJSC):
Use configuration instead of configurationForVisualStudio, which are now always different.
- 1:51 PM Changeset in webkit [157881] by
-
- 2 edits in trunk/Websites/test-results
Reverted erroneously committed changes from the previous commit.
- index.html:
- 1:48 PM Changeset in webkit [157880] by
-
- 3 edits in trunk/Websites/test-results
Clicking on a test name on the new flakiness dashboard should add a new test pane
https://bugs.webkit.org/show_bug.cgi?id=123194
Reviewed by Simon Fraser.
Added a new click handler on each test name inside the builder test view add a new test pane.
Moved the old trac link to a right-arrow inline SVG icon.
Also tweaked the style so that the builder test view looks different from other test panes.
- index.html:
(TestResultsView._urlFromTest): Extracted from TestResultsView._linkifiedTestName.
(TestResultsView._populateBuilderPane): Fetch the test when its name is clicked.
Added a circled right arrow for the old trac link.
- main.css: Tweaked the style to move the rounded border around the builder test view to be
around the form controls to clearly differentiate it from a regular test pane.
- 1:21 PM Changeset in webkit [157879] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix JavaScriptCore build targets following <http://trac.webkit.org/changeset/157864>
(https://bugs.webkit.org/show_bug.cgi?id=123169)
Tell Xcode that the supported platforms for all JavaScriptCore targets are iOS and OS X.
- Configurations/Base.xcconfig:
- 1:14 PM Changeset in webkit [157878] by
-
- 6 edits in trunk
Antialias underlines if they're not axis-aligned
https://bugs.webkit.org/show_bug.cgi?id=123004
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-23
Reviewed by Simon Fraser.
Source/WebCore:
In order to make underlines crisp, GraphicsContext:drawLineForText
modifies the bounds of the underline rect in order to make the rect
device-pixel-aligned, and then turns off antialiasing when drawing
the line. This makes sense when the underline is axis-aligned, but
doesn't when the rect is rotated or skewed. Therefore, we should
only opt-in to this behavior if the underline we're about to draw
is axis-aligned. This requires figuring out whether or not the
current transformation is axis-aligned every time
GraphicsContext::drawLineForText is called, which will incur a small
performance hit. However, this is justified by underlines looking
much better (antialiased) when the context is rotated or skewed.
Tests: svg/custom/foreign-object-skew.html
svg/zoom/page/zoom-foreignObject.html
svg/zoom/text/zoom-foreignObject.html:
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLineForText):
LayoutTests:
Updating tests that draw underlines in a non-axis-aligned
GraphicsContext. The expected .png's should show an antialiased
underline. However, underlines which are axis-aligned should still
be unchanged.
- platform/mac/svg/custom/foreign-object-skew-expected.png:
- platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
- platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
- 12:13 PM Changeset in webkit [157877] by
-
- 7 edits in trunk/Source
Make more StringImpl construction functions return PassRef.
<https://webkit.org/b/123203>
Knock out a couple more of the StringImpl construction helpers that
always return a non-null StringImpl.
Reviewed by Antti Koivisto.
- 11:45 AM Changeset in webkit [157876] by
-
- 4 edits in trunk/Source/WebKit2
Remove the ifdef to exclude remote layer tree transaction logging
on Lion and before.
Rubber-stamped by Anders Carlsson.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
- 11:42 AM Changeset in webkit [157875] by
-
- 3 edits in trunk/Source/JavaScriptCore
LLInt arity check exception processing should start unwinding from caller
https://bugs.webkit.org/show_bug.cgi?id=123209
Reviewed by Oliver Hunt.
Use the caller frame returned from slow_path_call_arityCheck to process exceptions.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 11:33 AM Changeset in webkit [157874] by
-
- 14 edits2 adds in trunk
Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
https://bugs.webkit.org/show_bug.cgi?id=123131.
Reviewed by Geoffrey Garen.
Source/WebCore:
Test: storage/websql/open-database-expand-quota.html
If a webpage tries to create a database that exceeds the database size
quota for that security origin, the WebKit1 quota request mechanism
uses detailsForNameAndOrigin() to get the requested size of the database
(that the webpage is attempting to open) in order to determine whether
to increase the quota or not.
Previously, detailsForNameAndOrigin() relies on the ProposedDatabase
mechanism to provide this size information. This change re-instates the
ProposedDatabase mechanism so that WebKit1 client code that relies on
this behavior will continue to work.
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::ProposedDatabase::ProposedDatabase):
(WebCore::DatabaseManager::ProposedDatabase::~ProposedDatabase):
(WebCore::DatabaseManager::DatabaseManager):
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):
- Modules/webdatabase/DatabaseManager.h:
(WebCore::DatabaseManager::ProposedDatabase::origin):
(WebCore::DatabaseManager::ProposedDatabase::details):
Tools:
Updated these files to allow database quotas to grow within a limit for
testing purposes.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededDatabaseQuota):
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
- DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::exceededDatabaseQuota):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didExceedDatabaseQuota):
- WebKitTestRunner/TestController.cpp:
(WTR::exceededDatabaseQuota):
LayoutTests:
Added a test to exercise growing the database quota within limit.
- platform/gtk/TestExpectations:
- storage/websql/open-database-expand-quota-expected.txt: Added.
- storage/websql/open-database-expand-quota.html: Added.
- storage/websql/open-database-over-quota-expected.txt:
- storage/websql/open-database-over-quota.html:
- 11:27 AM Changeset in webkit [157873] by
-
- 2 edits in trunk/Tools
It's valid to have a build ID of 0.
Reviewed by Tim Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration):
- 11:22 AM Changeset in webkit [157872] by
-
- 32 edits7 adds in trunk/Source
FTL should be able to do some simple inline caches using LLVM patchpoints
https://bugs.webkit.org/show_bug.cgi?id=123164
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
This implements GetById inline caches in the FTL using llvm.webkit.patchpoint.
The idea is that we ask LLVM for a nop slide the size of a GetById inline
cache and then fill in the code after LLVM compilation is complete. For now, we
just use the system calling convention for the arguments and return. We also
still make some assumptions about registers that aren't correct. But, most of
the scaffolding is there and this will successfully patch an inline cache.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithoutDisassembly):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::allocate):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::link):
- ftl/FTLAbbreviations.h:
(JSC::FTL::constNull):
(JSC::FTL::buildCall):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLInlineCacheDescriptor.h: Added.
(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
(JSC::FTL::GetByIdDescriptor::GetByIdDescriptor):
(JSC::FTL::GetByIdDescriptor::stackmapID):
(JSC::FTL::GetByIdDescriptor::codeOrigin):
(JSC::FTL::GetByIdDescriptor::uid):
- ftl/FTLInlineCacheSize.cpp: Added.
(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):
- ftl/FTLInlineCacheSize.h: Added.
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h:
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::directGPR):
- ftl/FTLLocation.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetById):
- ftl/FTLOutput.h:
(JSC::FTL::Output::call):
- ftl/FTLSlowPathCall.cpp: Added.
(JSC::FTL::callOperation):
- ftl/FTLSlowPathCall.h: Added.
(JSC::FTL::SlowPathCall::SlowPathCall):
(JSC::FTL::SlowPathCall::call):
(JSC::FTL::SlowPathCall::key):
- ftl/FTLSlowPathCallKey.cpp: Added.
(JSC::FTL::SlowPathCallKey::dump):
- ftl/FTLSlowPathCallKey.h: Added.
(JSC::FTL::SlowPathCallKey::SlowPathCallKey):
(JSC::FTL::SlowPathCallKey::usedRegisters):
(JSC::FTL::SlowPathCallKey::callTarget):
(JSC::FTL::SlowPathCallKey::offset):
(JSC::FTL::SlowPathCallKey::isEmptyValue):
(JSC::FTL::SlowPathCallKey::isDeletedValue):
(JSC::FTL::SlowPathCallKey::operator==):
(JSC::FTL::SlowPathCallKey::hash):
(JSC::FTL::SlowPathCallKeyHash::hash):
(JSC::FTL::SlowPathCallKeyHash::equal):
- ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::Location::directGPR):
- ftl/FTLStackMaps.h:
- ftl/FTLState.h:
- ftl/FTLThunks.cpp:
(JSC::FTL::slowPathCallThunkGenerator):
- ftl/FTLThunks.h:
(JSC::FTL::Thunks::getSlowPathCallThunk):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArguments):
- jit/GPRInfo.h:
- jit/JITInlineCacheGenerator.cpp:
(JSC::garbageStubInfo):
(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
(JSC::JITByIdGenerator::finalize):
- jit/JITInlineCacheGenerator.h:
(JSC::JITByIdGenerator::slowPathBegin):
- jit/RegisterSet.cpp:
(JSC::RegisterSet::stackRegisters):
(JSC::RegisterSet::specialRegisters):
(JSC::RegisterSet::calleeSaveRegisters):
(JSC::RegisterSet::allGPRs):
(JSC::RegisterSet::allFPRs):
(JSC::RegisterSet::allRegisters):
(JSC::RegisterSet::dump):
- jit/RegisterSet.h:
(JSC::RegisterSet::exclude):
(JSC::RegisterSet::numberOfSetRegisters):
(JSC::RegisterSet::RegisterSet):
(JSC::RegisterSet::isEmptyValue):
(JSC::RegisterSet::isDeletedValue):
(JSC::RegisterSet::operator==):
(JSC::RegisterSet::hash):
(JSC::RegisterSetHash::hash):
(JSC::RegisterSetHash::equal):
- runtime/Options.h:
Source/WTF:
Reviewed by Mark Hahnenberg.
This needed some better bitvector support, like merging (|=), excluding (&=~),
hashing, and bit counting.
- wtf/BitVector.cpp:
(WTF::BitVector::setSlow):
(WTF::BitVector::excludeSlow):
(WTF::BitVector::bitCountSlow):
(WTF::BitVector::equalsSlowCase):
(WTF::BitVector::hashSlowCase):
(WTF::BitVector::dump):
- wtf/BitVector.h:
(WTF::BitVector::merge):
(WTF::BitVector::exclude):
(WTF::BitVector::bitCount):
(WTF::BitVector::BitVector):
(WTF::BitVector::isEmptyValue):
(WTF::BitVector::isDeletedValue):
(WTF::BitVector::isEmptyOrDeletedValue):
(WTF::BitVector::operator==):
(WTF::BitVector::hash):
(WTF::BitVectorHash::hash):
(WTF::BitVectorHash::equal):
- wtf/HashTraits.h:
(WTF::CustomHashTraits::constructDeletedValue):
(WTF::CustomHashTraits::isDeletedValue):
(WTF::CustomHashTraits::emptyValue):
(WTF::CustomHashTraits::isEmptyValue):
- wtf/StdLibExtras.h:
(WTF::bitCount):
- 11:21 AM Changeset in webkit [157871] by
-
- 2 edits in trunk/Tools
Remove Lion bots from the Dashboard.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- 11:14 AM Changeset in webkit [157870] by
-
- 2 edits in trunk/Source/WebCore
[cg] Fix the capitalization of kCGImageSourceSkipMetaData (-> Metadata)
https://bugs.webkit.org/show_bug.cgi?id=122918
Reviewed by Anders Carlsson.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::imageSourceOptions):
The capitalization of kCGImageSourceSkipMetaData changed to
kCGImageSourceSkipMetadata in Mountain Lion.
- 11:13 AM Changeset in webkit [157869] by
-
- 21 edits2 moves in trunk/Source
Make IDBDatabaseBackendLevelDB.cpp be cross platform
https://bugs.webkit.org/show_bug.cgi?id=123027
Attentively reviewed by Dean Jackson.
Source/WebCore:
Move it out of the indexeddb/leveldb directory, and rename it to IDBDatabaseBackendImpl.
Project files:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp.
- Modules/indexeddb/IDBDatabaseBackendImpl.h: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h.
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
(WebCore::IDBDatabaseBackendInterface::isIDBDatabaseBackendImpl): Add to support a required cast in LevelDB code.
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::deleteDatabase):
(WebCore::IDBFactoryBackendLevelDB::open):
(WebCore::IDBFactoryBackendLevelDB::maybeCreateTransactionBackend):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:
- Modules/indexeddb/leveldb/IDBLevelDBCoding.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::create):
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
(WebCore::IDBTransactionBackendLevelDB::scheduleVersionChangeOperation):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::maybeCreateTransactionBackend):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- 10:55 AM Changeset in webkit [157868] by
-
- 2 edits in trunk/Source/JavaScriptCore
jitCompileAndSetHeuristics should DeferGCForAWhile
https://bugs.webkit.org/show_bug.cgi?id=123196
Reviewed by Mark Hahnenberg.
This fixes random crashes in V8v7/raytrace. I only see those crashes on exactly one of
my machines. I don't think this is testable; we just need to steadily converge towards
getting our uses of DeferGC to be right and then be careful not to regress. We're not
there yet, obviously.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
- 10:50 AM Changeset in webkit [157867] by
-
- 3 edits in trunk/Source/WebKit2
Fixed a typo.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(didChangeBackForwardList):
- UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:
- 10:47 AM Changeset in webkit [157866] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py
wkbuild.py fix after r157827.
- 10:42 AM Changeset in webkit [157865] by
-
- 2 edits in trunk/Source/WTF
Clean-up in Atomics.h
https://bugs.webkit.org/show_bug.cgi?id=123207
Reviewed by Anders Carlsson.
Atomics.h has two confusing and bit-rotted ifdefs with comments.
The first about CPU(SPARC64) was rendered obsolete when we switched
from exchange_and_add to sync_add_and_fetch.
The second was caused by a wrong definition that apparently only
caused trouble on GCC.
- wtf/Atomics.h:
- 10:02 AM Changeset in webkit [157864] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
[iOS] Upstream more JavaScriptCore build configuration changes
https://bugs.webkit.org/show_bug.cgi?id=123169
Reviewed by David Kilzer.
- Configurations/Base.xcconfig:
- Configurations/Version.xcconfig:
- Configurations/iOS.xcconfig: Added.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 9:58 AM Changeset in webkit [157863] by
-
- 2 edits in trunk/Source/JavaScriptCore
[iOS] Export DefaultGCActivityCallback member functions
https://bugs.webkit.org/show_bug.cgi?id=123175
Reviewed by David Kilzer.
- runtime/GCActivityCallback.h:
- 9:56 AM Changeset in webkit [157862] by
-
- 4 edits in trunk/Source
[iOS] Upstream more ARMv7s bits
https://bugs.webkit.org/show_bug.cgi?id=123052
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- Configurations/JavaScriptCore.xcconfig:
Source/WebCore:
Define exported symbol file for armv7s and arm64.
- Configurations/WebCore.xcconfig:
- 9:49 AM Changeset in webkit [157861] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Enable respect image orientation by default
https://bugs.webkit.org/show_bug.cgi?id=122120
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-10-23
Reviewed by Gustavo Noronha Silva.
Add enable respect image orientation by default in GTK port.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsConstructed):
- 9:38 AM Changeset in webkit [157860] by
-
- 4 edits in trunk/LayoutTests
[CSS Regions] compositing/regions/region-as-layer-in-another-flowthread.html has image failure
https://bugs.webkit.org/show_bug.cgi?id=123193
Patch by Mihai Maerean <Mihai Maerean> on 2013-10-23
Reviewed by Simon Fraser.
Removed overlapping of box-shadows which resulted in flaky results.
- compositing/regions/region-as-layer-in-another-flowthread-expected.html:
- compositing/regions/region-as-layer-in-another-flowthread.html:
- platform/mac/TestExpectations:
- 9:23 AM Changeset in webkit [157859] by
-
- 10 edits in trunk
[GTK] Expose image links properly
https://bugs.webkit.org/show_bug.cgi?id=84044
Reviewed by Chris Fleizach.
Tools:
Expose the accessible URL if present, as yet another attribute
for the AccessibilityUIElement wrapper. For coherence with what
the Mac port does (and what you would expect as the output of
the layout test), we strip the absolute URL path for relative
references, if it's the case, leaving the base of the URL path
out of the exposed string.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(attributesOfElement): Print the AXURL, if available.
(AccessibilityUIElement::url): Expose the URL if present. That
is, if the wrapped AtkObject implements AtkHyperlinkImpl.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(attributesOfElement): Print the AXURL, if available.
(WTR::AccessibilityUIElement::url): Expose the URL if present.
That is, if the wrapped AtkObject implements AtkHyperlinkImpl.
LayoutTests:
Rebaseline some tests that would now be printing the new
AXURL string for implementations of AtkHyperlinkImpl.
- platform/efl-wk1/accessibility/image-link-expected.txt: Updated.
- platform/efl-wk1/accessibility/image-map2-expected.txt: Ditto.
- platform/efl-wk2/accessibility/image-link-expected.txt: Ditto.
- platform/efl-wk2/accessibility/image-map2-expected.txt: Ditto.
- platform/gtk/accessibility/image-link-expected.txt: Ditto.
- platform/gtk/accessibility/image-map2-expected.txt: Ditto.
- 9:16 AM Changeset in webkit [157858] by
-
- 2 edits in trunk/Tools
Remove Lion bots.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 5:13 AM Changeset in webkit [157857] by
-
- 5 edits in trunk
[GTK] accessibility/self-referencing-aria-labelledby.html is failing
https://bugs.webkit.org/show_bug.cgi?id=121594
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-10-23
Reviewed by Mario Sanchez Prada.
Source/WebCore:
According to http://www.w3.org/TR/REC-html40/struct/objects.html#edef-IMG
description of image element should be determined by alt attribute, then
if it is empty by title attributte.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetDescription):
LayoutTests:
- platform/efl/TestExpectations:
accessibility/self-referencing-aria-labelledby.html is now passing
- platform/gtk/TestExpectations:
accessibility/self-referencing-aria-labelledby.html is now passing
- 3:55 AM Changeset in webkit [157856] by
-
- 6 edits in trunk/Source/WebCore
Tighten animation-driven restyle to operate on Element only.
<https://webkit.org/b/122820>
Text nodes are never directly animated, so we can tighten this code
to work on Element only. This happens naturally since the code was
already working with RenderElement everywhere.
Reviewed by Antti Koivisto.
- 3:48 AM Changeset in webkit [157855] by
-
- 5 edits in trunk/Source
StringImpl::lower() should return a PassRef.
<https://webkit.org/b/123190>
Test the waters and hack enough of StringImpl to be able to return
a PassRef<StringImpl> from lower().
Also gave String a constructor that takes a PassRef<StringImpl>.
Reviewed by Antti Koivisto.
- 3:42 AM Changeset in webkit [157854] by
-
- 14 edits in trunk/Source/WebCore
Even more PassRef<RenderStyle>!
<https://webkit.org/b/123147>
Convert more of the WebCore code to use PassRef for RenderStyle
in places where they are known to be non-null.
Re-landing this without region styling since that caused some
assertions last time.
Reviewed by Antti Koivisto.
- 2:17 AM Changeset in webkit [157853] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add WebKit2 API for TLS errors
https://bugs.webkit.org/show_bug.cgi?id=120160
Patch by Brian Holt <brian.holt@samsung.com> on 2013-10-23
Reviewed by Mario Sanchez Prada.
Revert back to using PlatformCertificateInfo following the rollout
of https://bugs.webkit.org/show_bug.cgi?id=118520.
- Shared/soup/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
- Shared/soup/PlatformCertificateInfo.h:
- UIProcess/API/gtk/WebKitCertificateInfo.cpp:
(webkitCertificateInfoGetCertificateInfo):
- UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
- 1:24 AM Changeset in webkit [157852] by
-
- 3 edits in trunk/Source/WebKit2
Remote Layer Tree: Implement superlayer, removeFromSuperlayer, replaceSublayer, and adoptSublayers
https://bugs.webkit.org/show_bug.cgi?id=123130
Reviewed by Anders Carlsson.
Implement the remaining layer-hierarchy-manipulation methods.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::PlatformCALayerRemote):
(PlatformCALayerRemote::~PlatformCALayerRemote):
Null out the superlayer back-pointer on our sublayers.
(PlatformCALayerRemote::recursiveBuildTransaction):
Ensure that our children all have us as their superlayer.
(PlatformCALayerRemote::superlayer):
Return the stored superlayer pointer.
(PlatformCALayerRemote::removeFromSuperlayer):
Call removeSublayer on our superlayer, if we have one.
(PlatformCALayerRemote::removeSublayer):
Remove the given layer if it's in our list of sublayers, clear its
reference to us, and note that we'll need to commit hierarchy changes.
(PlatformCALayerRemote::setSublayers):
removeAllSublayers() before setting the new list, to clear superlayer
back-pointers. Children will be protected by the PlatformCALayerList.
Update the new layers' superlayers.
(PlatformCALayerRemote::removeAllSublayers):
Remove each sublayer from its superlayer, then clear our list of children.
(PlatformCALayerRemote::appendSublayer):
(PlatformCALayerRemote::insertSublayer):
Protect the layer from deletion, so that we can remove it from its prior
superlayer before appending or inserting it.
(PlatformCALayerRemote::replaceSublayer):
Find the reference sublayer, if it exists, and replace it with the new one.
(PlatformCALayerRemote::adoptSublayers):
adoptSublayers is really just "set sublayers to this other layer's sublayers".
Since setSublayers already removes layers from the existing superlayer,
we can just go ahead and call it.
(PlatformCALayerRemote::addAnimationForKey):
(PlatformCALayerRemote::removeAnimationForKey):
(PlatformCALayerRemote::animationForKey):
Add some ASSERT_NOT_REACHEDs in animation code.
We ought not get here because we've disabled hardware animations
in GraphicsLayerCARemote.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Add m_superlayer and removeSublayer().
Oct 22, 2013:
- 11:50 PM Changeset in webkit [157851] by
-
- 6 edits in trunk
Refactor LineBreaker::nextSegmentBreak, add BreakingContext that holds all its state
https://bugs.webkit.org/show_bug.cgi?id=123038
Reviewed by David Hyatt.
Source/WebCore:
I followed Levi's logic on Blink's nextSegmentBreak refactoring (https://chromiumcodereview.appspot.com/25054004).
I mostly did the same changes, but the code is too diverged at this point to just apply that patch on our trunk. The patch
introduces BreakingContext as a separate class. I added new methods for each condition, which were originally located in
nextSegmentBreak. I also removed the goto-s from the code. All the new methods are inline in order to avoid introducing any
performance regression. The change makes the code so much cleaner and understandable.
This change would be the first step of the nextSegmentBreak refactoring, I wanted to keep things in place in RenderBlockLineLayout.cpp
for now, but I'm planning to separate BreakingContext into a new file and do additional changes to make things nicer. I'm tracking
the entire progress under http://webkit.org/b/121261 meta bug.
No new tests, covered by existing tests.
- I updated 1 expected result, because there was a 1 pixel difference on the result, which I believe comes from a rounding situation.
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::currentObject):
(WebCore::BreakingContext::lineBreak):
(WebCore::BreakingContext::lineBreakRef):
(WebCore::BreakingContext::lineWidth):
(WebCore::BreakingContext::atEnd):
(WebCore::BreakingContext::clearLineBreakIfFitsOnLine):
(WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
(WebCore::BreakingContext::initializeForCurrentObject):
(WebCore::BreakingContext::increment):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleEmptyInline):
(WebCore::BreakingContext::handleReplaced):
(WebCore::nextCharacter):
(WebCore::BreakingContext::handleText):
(WebCore::textBeginsWithBreakablePosition):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
(WebCore::BreakingContext::handleEndOfLine):
(WebCore::LineBreaker::nextSegmentBreak):
LayoutTests:
- platform/mac/editing/selection/after-line-wrap-expected.png:
- platform/mac/editing/selection/after-line-wrap-expected.txt: I updated the test, there was 1 pixel difference on the
output I think I run into a rounding error.
- 11:03 PM Changeset in webkit [157850] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed build fix attempt on Soup based port after r157842.
WebCore::CertificateInfo was reverted to WebKit::PlatformCertificateInfo.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost):
- 9:42 PM Changeset in webkit [157849] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix attempt on EFL port after r157842.
- Shared/soup/PlatformCertificateInfo.h: Removed message of merge confliction.
- 9:16 PM Changeset in webkit [157848] by
-
- 15 edits in trunk/Source/WebCore
Unreviewed, rolling out r157826.
http://trac.webkit.org/changeset/157826
https://bugs.webkit.org/show_bug.cgi?id=123197
Caused some regions tests to assert (Requested by smfr on
#webkit).
- dom/Document.cpp:
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::styleForRenderer):
- dom/Element.h:
- dom/ElementRareData.h:
(WebCore::ElementRareData::setComputedStyle):
(WebCore::ElementRareData::resetComputedStyle):
- html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::textWithDirection):
- page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::animate):
- page/animation/CompositeAnimation.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
- rendering/RenderElement.h:
(WebCore::RenderElement::setStyleInternal):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
(WebCore::RenderRegion::setObjectStyleInRegion):
- rendering/RenderRegion.h:
- style/StyleResolveTree.cpp:
(WebCore::Style::resolveLocal):
- 9:09 PM Changeset in webkit [157847] by
-
- 4 edits in trunk
[EFL] Remove HAVE_GLX macro
https://bugs.webkit.org/show_bug.cgi?id=123191
Reviewed by Gyuyoung Kim.
.:
- Source/cmake/OptionsEfl.cmake: Removed unnecessary HAVE_GLX macro
Source/WebCore:
Since r138313, HAVE(GLX) was replaced to USE(GLX) except in GraphicsSurfaceToken.h.
- platform/graphics/surfaces/GraphicsSurfaceToken.h:
Replace HAVE(GLX) to USE(GLX)
- 9:04 PM Changeset in webkit [157846] by
-
- 2 edits in trunk/Source/WebKit2
Fix build failures after r157842.
- WebProcess/WebProcess.h: Don't try to #include a file that was deleted.
It won't work.
- 8:39 PM Changeset in webkit [157845] by
-
- 3 edits in trunk/Source/WebCore
Gardening: fix broken build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=123174.
Not reviewed.
No new tests.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 8:23 PM Changeset in webkit [157844] by
-
- 18 edits2 adds2 deletes in trunk/Source
Get rid of IDBObjectStoreBackendLevelDB
https://bugs.webkit.org/show_bug.cgi?id=123174
Reviewed by Tim Horton.
Source/WebCore:
This file was kind of a dumping ground.
Its contents can be merged into IDBBackingStoreInterface and a new IDBIndexWriter class.
Also took the opportunity to do a little bit of RefPtr<> and pointer-vs-reference cleanup.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp: Removed.
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h: Removed.
- Modules/indexeddb/IDBIndexWriter.cpp: Added.
(WebCore::IDBIndexWriter::IDBIndexWriter):
(WebCore::IDBIndexWriter::writeIndexKeys):
(WebCore::IDBIndexWriter::verifyIndexKeys):
(WebCore::IDBIndexWriter::addingKeyAllowed):
- Modules/indexeddb/IDBIndexWriter.h: Added.
(WebCore::IDBIndexWriter::create):
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
- Modules/indexeddb/IDBMetadata.h:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::makeIndexWriters):
(WebCore::IDBBackingStoreLevelDB::generateKey):
(WebCore::IDBBackingStoreLevelDB::updateKeyGenerator):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
(WebCore::IDBDatabaseBackendLevelDB::setIndexesReady):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::schedulePutOperation):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
(WebCore::PutOperation::perform):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
- 6:52 PM Changeset in webkit [157843] by
-
- 19 edits in trunk/Source
[WebGL] Implement a software rendering option on Mac
https://bugs.webkit.org/show_bug.cgi?id=123177
Reviewed by Tim Horton.
Implement a way to force software OpenGL rendering
for WebGL, via a Setting/Preference.
Source/WebCore:
No new tests. We intentionally hide the capabilities of
the renderer from the content, so you can't test for
this setting. However, manual inspection is pretty
obvious. Just go to a page with a complex shader
such as https://www.shadertoy.com/view/lss3WS.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::create): If we're forcing software
rendering, mark the context attributes as such.
- page/Settings.in: New setting key.
- platform/graphics/GraphicsContext3D.h: New flag in Attributes.
(WebCore::GraphicsContext3D::Attributes::Attributes):
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D): Slight update to the
algorithm that sets a pixel format. If we're forcing software rendering,
obviously we never want to create an accelerated pixel format.
- platform/graphics/filters/CustomFilterGlobalContext.cpp:
(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded): Set the attribute
here before trying to create the context.
- platform/graphics/filters/CustomFilterGlobalContext.h: Add a forceSoftwareRendering
flag to prepareContextIfNeeded.
- rendering/FilterEffectRenderer.cpp:
(WebCore::createCustomFilterEffect): Check the Setting before creating a custom
filter context.
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h: New WebKitForceSoftwareWebGLRendering key.
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences forceSoftwareWebGLRendering]):
(-[WebPreferences setForceSoftwareWebGLRendering:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
- Shared/WebPreferencesStore.h: New ForceSoftwareWebGLRendering entry.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetForceSoftwareWebGLRendering):
(WKPreferencesGetForceSoftwareWebGLRendering):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- mac/WebKit2.order:
- 6:15 PM Changeset in webkit [157842] by
-
- 50 edits3 moves1 add1 delete in trunk/Source
Revert r157445 since it broke certificates on Mac.
<rdar://problem/15246926&15254017&15269117>
Source/WebCore:
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/ResourceErrorBase.h:
- platform/network/ResourceResponseBase.h:
- platform/network/cf/CertificateInfoCFNet.cpp: Removed.
- platform/network/cf/ResourceResponse.h:
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::setCertificateChain):
(WebCore::ResourceResponse::certificateChain):
- platform/network/soup/ResourceError.h:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::tlsErrors):
(WebCore::ResourceError::setTLSErrors):
(WebCore::ResourceError::certificate):
(WebCore::ResourceError::setCertificate):
- platform/network/soup/ResourceErrorSoup.cpp:
(WebCore::ResourceError::tlsError):
(WebCore::ResourceError::platformCopy):
(WebCore::ResourceError::platformCompare):
- platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::soupMessageCertificate):
(WebCore::ResourceResponse::setSoupMessageCertificate):
(WebCore::ResourceResponse::soupMessageTLSErrors):
(WebCore::ResourceResponse::setSoupMessageTLSErrors):
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::toSoupMessage):
(WebCore::ResourceResponse::updateFromSoupMessage):
Source/WebKit2:
- GNUmakefile.list.am:
- NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithCertficateChain):
(WKCertificateInfoGetCertificateChain):
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
- Shared/Authentication/AuthenticationManager.h:
- Shared/Authentication/AuthenticationManager.messages.in:
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebCertificateInfo.h:
(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
- Shared/mac/PlatformCertificateInfo.h: Renamed from Source/WebCore/platform/network/soup/CertificateInfoSoup.cpp.
(WebKit::PlatformCertificateInfo::certificateChain):
- Shared/mac/PlatformCertificateInfo.mm: Renamed from Source/WebCore/platform/network/mac/CertificateInfoMac.mm.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::PlatformCertificateInfo::dump):
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- Shared/soup/PlatformCertificateInfo.cpp: Added.
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::~PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
- Shared/soup/PlatformCertificateInfo.h: Renamed from Source/WebCore/platform/network/CertificateInfo.h.
(WebKit::PlatformCertificateInfo::certificate):
(WebKit::PlatformCertificateInfo::tlsErrors):
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_tls_info):
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::useCredential):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
- 6:03 PM Changeset in webkit [157841] by
-
- 2 edits in trunk/LayoutTests
Mark compositing/regions/region-as-layer-in-another-flowthread.html as an image failure.
- platform/mac/TestExpectations:
- 5:55 PM Changeset in webkit [157840] by
-
- 2 edits in trunk/Tools
Dashboard repaints constantly
https://bugs.webkit.org/show_bug.cgi?id=122133
Reviewed by Tim Horton.
Pulsing shadows are really bad for battery life.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line.bad .bubble):
(.status-line.bad .message):
- 5:48 PM Changeset in webkit [157839] by
-
- 5 edits in trunk
Unreviewed, rolling out r157835.
http://trac.webkit.org/changeset/157835
https://bugs.webkit.org/show_bug.cgi?id=123192
broke 32-bit builds (Requested by smfr on #webkit).
Source/WTF:
- wtf/MediaTime.cpp:
(WTF::signum):
- wtf/MediaTime.h:
Tools:
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):
- 5:44 PM Changeset in webkit [157838] by
-
- 3 edits in trunk/Websites/test-results
New flakiness dashboard's test pane should show the latest WebKit revision for each builder
https://bugs.webkit.org/show_bug.cgi?id=123189
Reviewed by Simon Fraser.
- index.html:
(TestResultsView._populateTestPane): Call _createTestResultHeader and _createTestResultRow with
a list of repository information.
(TestResultsView._createTestResultHeader): Optionally creates headers for a list of repositories.
(TestResultsView._createTestResultRow): Add a hyperlinked revision information for each builder.
Also add a hyperlink to file a Bugzilla bug when there is no bug associated with the test already.
- js/build.js:
(Build.formattedRevision): Extracted from Build.formattedRevisions.
(Build.formattedRevisions):
- 5:39 PM Changeset in webkit [157837] by
-
- 4 edits in trunk/Source/WebKit2
Remote Layer Tree: Disable threaded scrolling for RemoteLayerTreeDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=123187
Reviewed by Dean Jackson.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::supportsThreadedScrolling):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Threaded scrolling doesn't work with remote layer trees yet.
Let the DrawingArea subclass tell WebPage if it supports threaded
scrolling, and make TiledCoreAnimationDrawingArea say that it does.
- 5:26 PM Changeset in webkit [157836] by
-
- 6 edits in trunk/Source/JavaScriptCore
Minor VM* -> VM& cleanups in HashTable and Keywords.
<https://webkit.org/b/123183>
Turn some VM* variables that will never be null into VM&.
Reviewed by Geoffrey Garen.
- 5:18 PM Changeset in webkit [157835] by
-
- 5 edits in trunk
[WTF] Add a multiplication operator (and a few others) to MediaTime
https://bugs.webkit.org/show_bug.cgi?id=123137
Reviewed by Eric Carlson.
Source/WTF:
Add a multiplication operator and an inequality operator to the
MediaTime class for use by MSE.
- wtf/MediaTime.cpp:
(WTF::signum): Moved to top of file.
(WTF::MediaTime::operator*): Added.
(WTF::MediaTime::operator!=): Added.
- wtf/MediaTime.h:
(WTF::operator*): Added non-class version of operator*.
Tools:
Add tests for new MediaTime operators.
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):
- 5:14 PM Changeset in webkit [157834] by
-
- 16 edits in trunk/Source/WebCore
[Media] Refactor supportsType() factory method to take a parameters object.
https://bugs.webkit.org/show_bug.cgi?id=122489
Reviewed by Eric Carlson.
In order to support adding new conditional properties with which to decide
what MediaPlayerPrivate subclass to create, replace the two versions of the
supportsType() factory method with a single one taking a parameters object.
At the same time, add a 'isMediaSource' parameter to that object, allowing
MediaPlayerPrivate subclasses which support the same type and codecs but
which do not both support MediaSource to be distinguised.
- platform/graphics/MediaPlayer.cpp:
(WebCore::bestMediaEngineForSupportParameters): Renamed from
bestMediaEngineForTypeAndCodecs.
(WebCore::MediaPlayer::nextBestMediaEngine): Added convenience function.
(WebCore::MediaPlayer::loadWithNextMediaEngine): Call nextBestMediaEngine()
(WebCore::MediaPlayer::supportsType): Pass parameter object.
(WebCore::MediaPlayer::networkStateChanged): Call nextBestMediaEngine().
- platform/graphics/MediaPlayer.h:
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::supportsType): Handle parameter object.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine): Remove extraneous
extendedSupportsType method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType): Handle parameter object.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::supportsType): Ditto.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Remove extraneous
extendedSupportsType method.
(WebCore::MediaPlayerPrivateQTKit::supportsType): Handle parameter object.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::supportsType): Ditto.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
- platform/graphics/wince/MediaPlayerPrivateWinCE.h:
- 5:12 PM Changeset in webkit [157833] by
-
- 3 edits in trunk/Source/WebCore
Merge SVGRenderBlock::styleWillChange() into styleDidChange().
<https://webkit.org/b/123181>
I meant to do this one in r157787, but better late than never.
Reviewed by Geoffrey Garen.
- 5:08 PM Changeset in webkit [157832] by
-
- 3 edits in trunk/Websites/test-results
Make tables on the new flakiness dashboard sortable
https://bugs.webkit.org/show_bug.cgi?id=123141
Reviewed by Simon Fraser.
Use jquery.tablesorter.js to make test and builder tables sortable. The jquery plugin is already used by run-perf-tests.
- index.html:
(TestResultsView._populateTestPane): Add tablesorter to the class name and wrap tr's inside a tbody so that tablesorter
could sort them.
(TestResultsView._populateBuilderPane): Ditto.
- main.css:
(.resultsTable thead): Use cursor: pointer to signify the fact it's clickable.
(.resultsTable th): Don't repeat arrows.
(.resultsTable th.headerSortUp): Inline SVG up arrow.
(.resultsTable th.headerSortDown): Inline SVG down arrow.
- 5:05 PM Changeset in webkit [157831] by
-
- 8 edits in trunk/Tools
Educate webkitpy about Mavericks.
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._determine_mac_version):
- Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_os_version):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
- Scripts/webkitpy/port/builders.py:
- Scripts/webkitpy/port/mac.py:
(MacPort):
- Scripts/webkitpy/port/mac_unittest.py:
(test_versions):
(test_baseline_search_path):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory):
(TestRebaselineExpectations.test_rebaseline_expectations):
- 5:00 PM Changeset in webkit [157830] by
-
- 6 edits in trunk
REGRESSION:
if (false === (true && undefined)) console.log("wrong!");logs "wrong!", shouldn't!
https://bugs.webkit.org/show_bug.cgi?id=123179
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- parser/NodeConstructors.h:
(JSC::LogicalOpNode::LogicalOpNode):
- parser/ResultType.h:
(JSC::ResultType::forLogicalOp): Don't assume that && produces a boolean.
This is JavaScript (aka Sparta).
LayoutTests:
- js/dom/branch-fold-correctness.html: Added a test for this case.
- 4:59 PM Changeset in webkit [157829] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix on EFL port after r157823
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode): renamed getOperationType() to type().
- 4:59 PM Changeset in webkit [157828] by
-
- 19 edits in trunk/Source/WebCore
CTTE: Modernize RenderBlock a bit
https://bugs.webkit.org/show_bug.cgi?id=123162
Reviewed by Andreas Kling.
Start threading references through RenderBlock. While we
are here, do some selective modernization as well.
- 4:55 PM Changeset in webkit [157827] by
-
- 2 edits in trunk/Tools
Update the build trigger list for Mavericks.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):
- 4:32 PM Changeset in webkit [157826] by
-
- 15 edits in trunk/Source/WebCore
Even more PassRef<RenderStyle>!
<https://webkit.org/b/123147>
Convert the remaining WebCore code to use PassRef for RenderStyle
wherever they are known to be non-null.
Reviewed by Antti Koivisto.
- 3:58 PM Changeset in webkit [157825] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r157819.
http://trac.webkit.org/changeset/157819
https://bugs.webkit.org/show_bug.cgi?id=123180
Broke 32-bit builds (Requested by smfr on #webkit).
Source/JavaScriptCore:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/ToolExecutable.xcconfig:
Source/WebCore:
- Configurations/WebCore.xcconfig:
- 3:37 PM Changeset in webkit [157824] by
-
- 10 edits in trunk/Source/WebCore
Rename deleteLineBoxTree to deleteLines
https://bugs.webkit.org/show_bug.cgi?id=123176
Reviewed by Andreas Kling.
RenderBlock::deleteLineBoxTree -> RenderBlock::deleteLines
RenderInline::deleteLineBoxTree -> RenderInline::deleteLines
- 3:33 PM Changeset in webkit [157823] by
-
- 28 edits in trunk/Source
{ClipPathOperation, FilterOperation}::getOperationType() should not include 'get'
https://bugs.webkit.org/show_bug.cgi?id=123172
Reviewed by Simon Fraser.
No new tests, just a rename.
"get" in WebCore tends to mean that the function has out arguments; these have no arguments.
Rename FilterOperation::getOperationType() to FilterOperation::type().
I noticed that ClipPathOperation had the same mistake, so I fixed it there too.
Removed long and useless list of WebCore files.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::encodeFilterOperation):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::operator<<):
Adopt the new name.
- 3:32 PM Changeset in webkit [157822] by
-
- 2 edits in trunk/Tools
Add Mavericks bots to the dashboard.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- 3:30 PM Changeset in webkit [157821] by
-
- 17 edits2 adds in trunk
AX: Add paramAttrs to fetch start and end text markers in a given rect.
https://bugs.webkit.org/show_bug.cgi?id=122164
Patch by Samuel White <Samuel White> on 2013-10-22
Reviewed by Chris Fleizach.
Source/WebCore:
Added ability to fetch end and start text markers inside a given bounds. This gives ScreenReaders
like VoiceOver a way to retrieve the text markers for a specified column of page text.
Test: platform/mac/accessibility/text-marker-for-bounds.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::mainFrame):
(WebCore::AccessibilityObject::topDocument):
(WebCore::AccessibilityObject::visiblePositionForBounds):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper screenToContents:]):
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
Tools:
Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
- DumpRenderTree/AccessibilityUIElement.cpp:
(endTextMarkerForBoundsCallback):
(startTextMarkerForBoundsCallback):
(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
LayoutTests:
Added test to ensure end/start text marker for bounds works as
expected. Updated bounds for range test to include new API.
- platform/mac/accessibility/bounds-for-range-expected.txt:
- platform/mac/accessibility/text-marker-for-bounds-expected.txt: Added.
- platform/mac/accessibility/text-marker-for-bounds.html: Added.
- 3:07 PM Changeset in webkit [157820] by
-
- 2 edits in trunk/Source/WebCore
[CSS Shapes] Match adjustLogicalLineTopAndLogicalHeightIfNeeded's implementation with Blink's
https://bugs.webkit.org/show_bug.cgi?id=123033
Reviewed by David Hyatt.
In Blink I made this function in a bit different way. This change modifies it
to be identical, which helps a lot in the future cross-merging patches.
No new tests, covered by existing texts.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::adjustLogicalLineTopAndLogicalHeightIfNeeded):
- 3:02 PM Changeset in webkit [157819] by
-
- 5 edits in trunk/Source
[iOS] Upstream more ARMv7s bits
https://bugs.webkit.org/show_bug.cgi?id=123052
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/ToolExecutable.xcconfig: Enable CLANG_ENABLE_OBJC_ARC for i386 as I'm
modifying a file in JavaScriptCore/Configurations.
Source/WebCore:
- Configurations/WebCore.xcconfig:
- 2:49 PM Changeset in webkit [157818] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Mavericks build; use <> for framework include.
- page/CaptionUserPreferencesMediaAF.cpp:
- 2:45 PM Changeset in webkit [157817] by
-
- 4 edits in trunk/Source/WebKit2
URTBF after r157803 for !ENABLE(CSS_FILTERS) platforms.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
- Shared/WebCoreArgumentCoders.cpp:
- 2:40 PM Changeset in webkit [157816] by
-
- 3 edits in trunk/Source/WebCore
GammaFilterOperation seems to be dead code
https://bugs.webkit.org/show_bug.cgi?id=123173
Reviewed by Simon Fraser.
- platform/graphics/filters/FilterOperation.cpp:
- platform/graphics/filters/FilterOperation.h:
Remove dead code.
- 2:24 PM Changeset in webkit [157815] by
-
- 3 edits in trunk/Tools
There should be a way to specify additional repository paths in NRWT
https://bugs.webkit.org/show_bug.cgi?id=123135
Reviewed by Alexey Proskuryakov.
Added --additional-repository-name and --additional-repository-path options to NRWT.
These options allow us to submit addtional repository information, such as of Safari's
to the new flakiness dashboard.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- Scripts/webkitpy/port/base.py:
(Port.repository_paths):
- 2:23 PM Changeset in webkit [157814] by
-
- 3 edits in tags/Safari-538.2.1/Source/WebKit/mac
Merged r157753.
- 2:20 PM Changeset in webkit [157813] by
-
- 5 edits in tags/Safari-538.2.1/Source
Versioning.
- 2:18 PM Changeset in webkit [157812] by
-
- 1 copy in tags/Safari-538.2.1
New Tag.
- 2:08 PM Changeset in webkit [157811] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py
add mac-mavericks to wkbuild_unittest.py.
- 2:03 PM Changeset in webkit [157810] by
-
- 31 edits in trunk/Source/WebCore
Rename some line box functions to be just about lines
https://bugs.webkit.org/show_bug.cgi?id=123168
Reviewed by Dave Hyatt.
firstLineBoxBaseline -> firstLineBaseline
hasInlineBoxChildren -> hasLines
Also use hasLines in a bunch of places where firstLineBox() was used.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
Also use hasRenderedText() instead of firstTextBox()
- rendering/RenderFullScreen.cpp:
Fix namespace.
- 1:40 PM Changeset in webkit [157809] by
-
- 3 edits in trunk/Source/JavaScriptCore
[iOS] Upstream JSLock changes
https://bugs.webkit.org/show_bug.cgi?id=123107
Reviewed by Geoffrey Garen.
- runtime/JSLock.cpp:
(JSC::JSLock::unlock):
(JSC::JSLock::dropAllLocks): Modified to take a SpinLock, used only on iOS.
(JSC::JSLock::dropAllLocksUnconditionally): Modified to take a SpinLock, used only on iOS. Also
use pre-increment instead of post-increment when we're not using the return value of the instruction.
(JSC::JSLock::grabAllLocks): Modified to take a SpinLock, used only on iOS. Also change
places where we were using post-increment/post-decrement to use pre-increment/pre-decrement,
since we don't use the return value of such instructions.
(JSC::JSLock::DropAllLocks::DropAllLocks): Modified to support releasing all locks unconditionally.
Take a spin lock before releasing all locks on iOS. Also, use nullptr instead of 0.
(JSC::JSLock::DropAllLocks::~DropAllLocks): Take a spin lock before acquiring all locks on iOS.
- runtime/JSLock.h: Remove extraneous argument name "exec" from DropAllLocks as the data type of
the argument is sufficiently descriptive of its purpose.
- 1:18 PM Changeset in webkit [157808] by
-
- 7 edits1 copy4 adds in trunk/Source/WebCore
Adding Mock class to test RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=122848
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-22
Reviewed by Eric Carlson.
The following tests can be run:
RTCPeerConnection-createAnswer.html
RTCPeerConnection-createOffer.html
RTCPeerConnection-ice.html
RTCPeerConnection-localDescription.html
RTCPeerConnection-remoteDescription.html
RTCPeerConnection-state.html
Tests that require a MediaStream object, by invoking getUserMedia,
are not ready to run yet.
No new tests needed.
- CMakeLists.txt:
- platform/mediastream/RTCPeerConnectionHandler.cpp:
(WebCore::createHandler):
- platform/mediastream/RTCPeerConnectionHandler.h:
- platform/mediastream/RTCPeerConnectionHandlerClient.h:
- platform/mock/RTCNotifiersMock.cpp: Added.
- platform/mock/RTCNotifiersMock.h: Added.
- platform/mock/RTCPeerConnectionHandlerMock.cpp: Added.
- platform/mock/RTCPeerConnectionHandlerMock.h: Copied from Source/WebCore/platform/mediastream/RTCPeerConnectionHandler.h.
- platform/mock/TimerEventBasedMock.h: Added.
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::enableMockRTCPeerConnectionHandler):
- testing/Internals.h:
- 1:16 PM Changeset in webkit [157807] by
-
- 2 edits in trunk/Source/WebCore
WebCore::fillWithEmptyClients adopts new empty clients before leaking their pointers
https://bugs.webkit.org/show_bug.cgi?id=122945
Reviewed by Anders Carlsson.
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients): Store the static empty clients as NeverDestroyed, rather than
adopting the pointer of each heap-allocated object and then immediately leaking that pointer.
- 1:10 PM Changeset in webkit [157806] by
-
- 3 edits in trunk/Source/WebCore
Simplify HRTFDatabaseLoader's load map
https://bugs.webkit.org/show_bug.cgi?id=122944
Reviewed by Eric Carlson.
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::loaderMap): Return a reference to a NeverDestroyed HashMap that maps sample rates to loaders.
(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
- platform/audio/HRTFDatabaseLoader.h: Remove the LoaderMap type definition, the private singleton of that type
and the singleton's unused getter.
- 12:46 PM Changeset in webkit [157805] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py
add mac-mavericks to the target_platform list.
- 12:28 PM Changeset in webkit [157804] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r157774.
http://trac.webkit.org/changeset/157774
https://bugs.webkit.org/show_bug.cgi?id=123167
causes python test to fail (Requested by smfr on #webkit).
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.init):
(TestExpectations._add_expectations):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(_set_up_derived_options):
- 12:25 PM Changeset in webkit [157803] by
-
- 14 edits in trunk/Source
Remote Layer Tree: Support hardware accelerated filters
https://bugs.webkit.org/show_bug.cgi?id=123139
Reviewed by Anders Carlsson.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::ArgumentCoder<Length>::encode):
(CoreIPC::ArgumentCoder<Length>::decode):
Add simple coders for Length.
(CoreIPC::encodeFilterOperation):
(CoreIPC::decodeFilterOperation):
Serialize and deserialize FilterOperations, except for CUSTOM and VALIDATED_CUSTOM.
(CoreIPC::ArgumentCoder<Length>::encode):
(CoreIPC::ArgumentCoder<Length>::decode):
Add coders for FilterOperations that delegate to {en,de}codeFilterOperation
for each operation in the list.
- Shared/WebCoreArgumentCoders.h:
Drive-by fix indentation.
Expose the Length and FilterOperations coders.
- Shared/mac/RemoteLayerTreeTransaction.h:
Add FiltersChanged and LayerProperties::filters.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Encode and decode our FilterOperations.
(WebKit::dumpChangedLayers):
Dump information about the layers' filters.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
Use PlatformCAFilters code to apply a FilterOperations object to our CALayer.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::setFilters):
Replace existing filters with our new set, and note that they've changed.
(PlatformCALayerRemote::copyFiltersFrom):
Not yet implemented. Not critical for this feature, either.
(PlatformCALayerRemote::filtersCanBeComposited):
For now, this is the same as the Mac version.
- WebCore.exp.in:
Export a variety of filter-related things.
- platform/graphics/ca/PlatformCAFilters.h:
- platform/graphics/ca/mac/PlatformCAFiltersMac.mm:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::setFilters):
- platform/graphics/ca/win/PlatformCAFiltersWin.cpp:
(PlatformCAFilters::setFiltersOnLayer):
setFiltersOnLayer should take a PlatformLayer instead of a PlatformCALayer
as its argument, because it doesn't need a PlatformCALayer, and this way
we can share code with the RemoteLayerTreeHost, which only has PlatformLayers
and not PlatformCALayers.
- 12:16 PM Changeset in webkit [157802] by
-
- 2 edits in trunk/Tools
Prepare WebKit Buildbot master for Mavericks.
This adds the following bot configurations:
Mavericks Release/Debug builders
Mavericks Release/Debug WK1 Testers
Mavericks Release/Debug WK2 Testers
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 11:46 AM Changeset in webkit [157801] by
-
- 5 edits3 adds in trunk
cue.text fails for some track element cues
https://bugs.webkit.org/show_bug.cgi?id=81123
Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-22
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-long-captions-file.html
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::parseBytes): Use buffer when we don't have full lines.
(WebCore::WebVTTParser::fileFinished): Force file to finish parsing.
(WebCore::WebVTTParser::hasRequiredFileIdentifier): Simplify due to using String.
(WebCore::WebVTTParser::collectCueText): Don't automatically create cues when we run out of data.
(WebCore::WebVTTParser::collectNextLine): Use buffer.
- html/track/WebVTTParser.h: Add m_buffer and Finished state.
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::notifyFinished): Call m_parser->fileFinished() when done.
LayoutTests:
- media/track/captions-webvtt/captions-long.vtt: Added.
- media/track/track-long-captions-file-expected.txt: Added.
- media/track/track-long-captions-file.html: Added.
- 10:33 AM Changeset in webkit [157800] by
-
- 2 edits in trunk/Source/JavaScriptCore
[arm] Add missing setupArgumentsWithExecState() prototypes to fix build.
https://bugs.webkit.org/show_bug.cgi?id=123166
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- 10:13 AM Changeset in webkit [157799] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=123161
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-22
Reviewed by Brent Fulgham.
- rendering/RenderFlowThread.h: Move USE(ACCELERATED_COMPOSITING) guard to expose needed type.
- 10:08 AM Changeset in webkit [157798] by
-
- 10 edits1 add in trunk/Source/WebCore
Add a cross-platform IDBRecordIdentifier
https://bugs.webkit.org/show_bug.cgi?id=123138
Reviewed by Andreas Kling.
Add the cross-platform header:
- Modules/indexeddb/IDBRecordIdentifier.h: Added.
(WebCore::IDBRecordIdentifier::create):
(WebCore::IDBRecordIdentifier::encodedPrimaryKey):
(WebCore::IDBRecordIdentifier::version):
(WebCore::IDBRecordIdentifier::reset):
(WebCore::IDBRecordIdentifier::IDBRecordIdentifier):
- WebCore.xcodeproj/project.pbxproj:
- GNUmakefile.list.am:
Remove the old abstract and LevelDB classes:
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
Use the cross-platform one everywhere:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::writeIndexKeys):
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
(WebCore::PutOperation::perform):
- 10:04 AM Changeset in webkit [157797] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4][mips][arm] Fix crashes in JSC (32-bit only).
https://bugs.webkit.org/show_bug.cgi?id=123165
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.
- jit/JITInlines.h:
(JSC::JIT::callOperationNoExceptionCheck): Add missing EABI_32BIT_DUMMY_ARG.
(JSC::JIT::callOperation): The last TrustedImm32(arg3) is a bit overkill for SH4 :)
(JSC::JIT::callOperation): Add missing EABI_32BIT_DUMMY_ARG.
(JSC::JIT::callOperation): Fix tag and payload order for V_JITOperation_EJJJ prototype.
- 8:51 AM Changeset in webkit [157796] by
-
- 5 edits in trunk/Source/JavaScriptCore
REGRESSION(r157690, r157699) Fix architectures using AssemblerBufferWithConstantPool.
https://bugs.webkit.org/show_bug.cgi?id=123092
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.
Impacted architectures are SH4 and ARM_TRADITIONAL.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::buffer):
- assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::flushConstantPool):
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::linkCode):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::buffer):
- 8:46 AM Changeset in webkit [157795] by
-
- 9 edits in trunk/Source/JavaScriptCore
Remove unused stuff in JIT stubs.
https://bugs.webkit.org/show_bug.cgi?id=123155
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.
- jit/JITStubs.h:
- jit/JITStubsARM.h:
(JSC::ctiTrampoline):
- jit/JITStubsARM64.h:
- jit/JITStubsARMv7.h:
- jit/JITStubsMIPS.h:
- jit/JITStubsSH4.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86_64.h:
- 8:45 AM Changeset in webkit [157794] by
-
- 2 edits in trunk/Source/JavaScriptCore
[iOS] Upstream OS-version-specific install paths for JavaScriptCore.framework
https://bugs.webkit.org/show_bug.cgi?id=123115
<rdar://problem/13696872>
Reviewed by Andy Estes.
Based on a patch by Mark Hahnenberg.
Add support for running JavaScriptCore-based apps, built against the iOS 7 SDK, on older versions of iOS.
- API/JSBase.cpp:
- 7:50 AM Changeset in webkit [157793] by
-
- 18 edits in trunk/Source/WebCore
[CSS Regions] Possible performance regression after r157567
https://bugs.webkit.org/show_bug.cgi?id=123016
Reviewed by Andreas Kling.
The revision 157567 http://trac.webkit.org/changeset/157567 may have regressed
Parser/html5-full-render by ~1.1% and Parser/html-parser by ~2%. These changes
try to optimize the initial patch, based on Andreas Kling's review.
The patch also adds a couple of refactorings that should make the code easier to read:
- the CSS Shapes functions are now wrapped in a single #if clause
- the CSS Shapes and CSS Regions pre-layout preparations are wrapped in a helper function
The RenderFlowThread::logicalWidthChangedInRegionsForBlock function is optimized by passing
it information about the state of the relayout children flag. If the flag is true already,
some of the steps are skipped.
Tests: no new tests.
- dom/Element.cpp:
(WebCore::Element::webkitGetRegionFlowRanges):
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForElementInfo):
- rendering/RenderBlock.cpp:
(WebCore::shapeInfoRequiresRelayout):
(WebCore::RenderBlock::updateShapesBeforeBlockLayout):
(WebCore::RenderBlock::computeShapeSize):
(WebCore::RenderBlock::prepareShapesAndPaginationBeforeBlockLayout):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):
(WebCore::RenderBlockFlow::setRenderNamedFlowFragment):
(WebCore::RenderBlockFlow::ensureRareData):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderElement::isRenderNamedFlowFragmentContainer):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderElement.h:
(WebCore::RenderElement::generatingElement):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
- rendering/RenderFlowThread.h:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
- style/StyleResolveTree.cpp:
(WebCore::Style::elementInsideRegionNeedsRenderer):
- 7:43 AM Changeset in webkit [157792] by
-
- 5 edits in trunk/Source/WebCore
CSSStyleSheet constructor functions should return PassRef.
<https://webkit.org/b/123156>
Make CSSStyleSheet::create*() return PassRef and tighten some call
sites that were using them. Most callers didn't need any tweaks to
take advantage of PassRef.
Reviewed by Antti Koivisto.
- 7:43 AM Changeset in webkit [157791] by
-
- 3 edits in trunk/Source/WebCore
CTTE: RenderMathMLFraction always has a MathMLInlineContainerElement.
<https://webkit.org/b/123154>
This renderer is never anonymous and always has a corresponding
MathMLInlineContainerElement. Overload element() with a tighter
return type.
Also marked the class FINAL and made most member functions private.
Reviewed by Antti Koivisto.
- 7:42 AM Changeset in webkit [157790] by
-
- 3 edits in trunk/Source/WebCore
FontGlyphs constructor functions should return PassRef.
<https://webkit.org/b/123159>
Made the two FontGlyphs creator functions return PassRef and tweaked
the FontGlyphsCache in Font.cpp to make more efficient use of it.
Reviewed by Antti Koivisto.
- 6:45 AM Changeset in webkit [157789] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Add missing lastRegister(), firstFPRegister() and lastFPRegister().
https://bugs.webkit.org/show_bug.cgi?id=123157
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Andreas Kling.
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::lastRegister):
(JSC::SH4Assembler::firstFPRegister):
(JSC::SH4Assembler::lastFPRegister):
- 6:12 AM Changeset in webkit [157788] by
-
- 2 edits in trunk/Source/WebCore
Fix some more code to use RenderElement instead of RenderObject.
<https://webkit.org/b/123149>
Using RenderElement where possible lets us skip the isRenderElement()
branch in RenderObject::style() and generates much tighter code.
Reviewed by Antti Koivisto.
- 6:04 AM Changeset in webkit [157787] by
-
- 7 edits in trunk/Source/WebCore
Merge SVG renderers' styleWillChange() into styleDidChange().
<https://webkit.org/b/123108>
This work can just as well be done after setting the style.
Three more styleWillChange() overloads gone.
Reviewed by Antti Koivisto.
- 6:04 AM Changeset in webkit [157786] by
-
- 4 edits in trunk/Source/WebCore
CSSValueList constructor functions should return PassRef.
<https://webkit.org/b/123151>
These functions always return objects, and thus can return PassRef.
Also made CSSValueList::createFromParserValueList() take a reference
since that function is only ever called with a non-null value.
Reviewed by Antti Koivisto.
- 6:03 AM Changeset in webkit [157785] by
-
- 2 edits in trunk/Source/WebCore
Avoid parent style ref churn in createTextRendererIfNeeded().
<https://webkit.org/b/123148>
There's no need to take a temporary ref on the parent's RenderStyle
while creating a text renderer. It's not going away, and the text
renderer is not going to participate in ownership afterwards.
Reviewed by Antti Koivisto.
- 4:57 AM Changeset in webkit [157784] by
-
- 3 edits in trunk/Source/JavaScriptCore
Build break on ARMv7 after r157209
https://bugs.webkit.org/show_bug.cgi?id=122890
Patch by Brian Holt <brian.holt@samsung.com> on 2013-10-22
Reviewed by Csaba Osztrogonác.
Add framePointerRegister and first/last register helpers for ARM_TRADITIONAL.
- assembler/ARMAssembler.h:
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::firstRegister):
(JSC::MacroAssemblerARM::lastRegister):
(JSC::MacroAssemblerARM::firstFPRegister):
(JSC::MacroAssemblerARM::lastFPRegister):
- 3:58 AM Changeset in webkit [157783] by
-
- 2 edits in trunk/Source/WebCore
Remove some unnecessary null checks in RenderElement::setStyle().
<https://webkit.org/b/123146>
After assigning the new style to RenderElement::m_style, we know that
it'll be non-null, so remove all the checking for this.
Reviewed by Antti Koivisto.
- 3:10 AM Changeset in webkit [157782] by
-
- 11 edits in trunk/Source/WebCore
Introduce ACCESSIBILITY_OBJECT_TYPE_CASTS to replace manual toFoo() in accessibility child class
https://bugs.webkit.org/show_bug.cgi?id=123140
Reviewed by Andreas Kling.
As a step to let toFoo use TYPE_CASTS_BASE, DEFINE_TYPE_CASTS can be used for toFoo() in accessibility
child class. The DEFINE_TYPE_CASTS will generate plenty more helper functions for accessibility type cast.
No new tests, no behavior changes.
- accessibility/AccessibilityList.h:
- accessibility/AccessibilityMenuList.h:
- accessibility/AccessibilityMockObject.h:
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilitySVGRoot.h:
- accessibility/AccessibilityScrollView.h:
- accessibility/AccessibilitySpinButton.h:
- accessibility/AccessibilityTable.h:
- 2:09 AM Changeset in webkit [157781] by
-
- 21 edits3 adds in trunk/Source
[GTK] Add WebKit2 API for TLS errors
https://bugs.webkit.org/show_bug.cgi?id=120160
Patch by Brian Holt <brian.holt@samsung.com> on 2013-10-22
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Added a new constructor for CertificateInfo under Soup.
- platform/network/CertificateInfo.h:
- platform/network/soup/CertificateInfoSoup.cpp:
(WebCore::CertificateInfo::CertificateInfo): New constructor using
GTlsCertificateFlags and GTlsCertificate.
Source/WebKit2:
Add a new signal load-failed-with-tls-errors that is emitted with
a WebKitCertificateInfo boxed type to allow users to deal with TLS
errors. A new API is exposed in WebKitWebContext to allow
exceptions for TLS errors on a given host.
- GNUmakefile.list.am:
- PlatformGTK.cmake:
- UIProcess/API/gtk/WebKitCertificateInfo.cpp: Added.
(webkitCertificateInfoGetCertificateInfo):
(webkit_certificate_info_copy):
(webkit_certificate_info_free):
(webkit_certificate_info_get_tls_certificate):
(webkit_certificate_info_get_tls_errors):
- UIProcess/API/gtk/WebKitCertificateInfo.h: Added.
- UIProcess/API/gtk/WebKitCertificateInfoPrivate.h: Added.
(_WebKitCertificateInfo::_WebKitCertificateInfo):
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_allow_tls_certificate_for_host): Support TLS
exceptions for a given host.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init): Added new signal.
(webkitWebViewLoadFailedWithTLSErrors): Emit new signal with
WebKitCertificateInfo and host.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/docs/webkit2gtk.types:
- UIProcess/API/gtk/tests/TestSSL.cpp:
(testLoadFailedWithTLSErrors):
(httpsServerCallback):
(beforeAll): Added new test.
- UIProcess/API/gtk/webkit2.h:
- UIProcess/API/gtk/webkit2marshal.list:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::allowSpecificHTTPSCertificateForHost): Send
message to WebProcess to allow a certificate and host pair.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: New message to tell
WebProcess to allow a specific TLS certificate for a given host.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost): Allow
certificate and host pair.
- 1:39 AM Changeset in webkit [157780] by
-
- 5 edits1 move2 deletes in trunk/LayoutTests
[EFL] accessibility/plugin.html passes incorrectly
https://bugs.webkit.org/show_bug.cgi?id=122889
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-10-22
Reviewed by Chris Fleizach.
Sharing test.swf by all existing layout tests accessing it.
- accessibility/plugin.html:
- fast/loader/sandboxed-plugin-crash.html:
- fast/replaced/border-radius-clip.html:
- fast/replaced/embed-display-none.html:
- fast/replaced/resources/test.swf: Removed.
- platform/mac/accessibility/resources/test.swf: Removed.
- resources/test.swf: Renamed from LayoutTests/fast/loader/resources/test.swf.
- 1:28 AM Changeset in webkit [157779] by
-
- 8 edits in trunk/Source/WebCore
[CSSRegions] Use RenderStyle::hasFlowFrom when needed
https://bugs.webkit.org/show_bug.cgi?id=122543
Reviewed by David Hyatt.
Rename RenderStyle::hasStyleRegion -> RenderStyle::hasFlowFrom.
Use RenderStyle::hasFlowFrom() helper function instead of directly
checking the value of RenderStyle::regionThread().
No change of functionality, covered by existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::contentToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::didAttachRenderers):
- dom/PseudoElement.h:
(WebCore::pseudoElementRendererIsNeeded):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
- rendering/style/RenderStyle.h:
- 12:32 AM Changeset in webkit [157778] by
-
- 2 edits in trunk/Source/WebKit2
Try to make the 32-bit Mac build happy.
- UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:
Oct 21, 2013:
- 10:19 PM Changeset in webkit [157777] by
-
- 2 edits in trunk/Source/WebKit2
Try to make the 32-bit Mac build happy.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(setUpPageLoaderClient):
- 10:16 PM Changeset in webkit [157776] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Add load delegate method for didChangeBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=123136
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(didChangeBackForwardList): Added. Calls new delegate method.
(setUpPageLoaderClient): Hook up new client function.
- UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Declare new delegate method.
- 9:42 PM Changeset in webkit [157775] by
-
- 8 edits5 adds in trunk/Websites/test-results
New flakiness dashboard should hyperlink test names, WebKit revisions, and bubbles
https://bugs.webkit.org/show_bug.cgi?id=123134
Reviewed by Stephanie Lewis.
Copied admin.css, admin-header.php, admin-footer.php, builders.php, repositories.php from WebKit Perf Monitor.
(Unfortunately WebKit Perf Monitor hasn't been committed into WebKit repository just yet.)
Updated various parts of index.html to linkify test names, build numbers, and bubbles (to results page).
- admin/admin.css: Added.
- admin/builders.php: Added.
- admin/index.php: Removed the duplicated code now that it uses admin-header.php.
- admin/repositories.php: Added.
- api/manifest.php: Use camelCase for blame_url and build_url to be consistent with other JSON properties.
Also exported testCategories from config so that we can linkify test names in the dashboard.
- include/admin-footer.php: Added.
- include/admin-header.php: Added.
- include/config.json: Added test categories. This avoids hard-coding the URL to trac in php/js.
- include/init-database.sql: Added name and build_url to builders table and category to tests.
- include/test-results.php: Assume the test category to be LayoutTest for now.
- index.html:
(TestResultsView): Initialize _builders, _slaves, _repositories, _testCategories as dictionaries as intended.
(TestResultsView.setTestCategories): Added.
(TestResultsView._createResultCell): Dynamically resolve URLs of results page and and build page.
(TestResultsView._populateTestPane): Linkify the test name. Unfortunately we don't have a test object anywhere.
We need to figure out a way to find the test object here eventually. For now, hard-coding "LayoutTest" works.
(TestResultsView._linkifiedTestName): Added.
(TestResultsView._createBuildsAndComputeSlownessOfResults): Takes builderId to set "builder" property on each
result object as it's used by Build class.
(TestResultsView._populateBuilderPane):
(fetchManigest):
- js/build.js:
(Build.buildUrl): Support $builderName so that we don't have to keep repeating builder names in the database.
(Build.revision): Don't access [0] if revisions[repositoryId] was undefined.
- 7:17 PM Changeset in webkit [157774] by
-
- 4 edits in trunk/Tools
Run tests as if they are expected to pass when --force is given.
https://bugs.webkit.org/show_bug.cgi?id=112890
Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-10-21
Reviewed by Ryosuke Niwa.
The --force switch of new-run-webkit-tests is now forces all tests to
be run with 'PASS' as expected result.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.init):
(TestExpectations._add_expectations):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(_set_up_derived_options):
- 7:05 PM Changeset in webkit [157773] by
-
- 6 edits in trunk/Source/WebCore
[WIN] Properly support reverse animations without needing software fallback.
https://bugs.webkit.org/show_bug.cgi?id=85121
Reviewed by Dean Jackson.
Testing is provided by existing animation tests.
- platform/animation/TimingFunction.h:
(WebCore::CubicBezierTimingFunction::createReversed): Added.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::addAnimation): The early return when performing a reverse or
autoreverse animation is no longer needed.
- platform/graphics/ca/PlatformCAAnimation.h:
- platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(toCAMediaTimingFunction): Use new reversed function.
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFTimingFunction): Ditto.
(PlatformCAAnimation::setTimingFunction): Pass 'reverse' flag.
(PlatformCAAnimation::setTimingFunctions): Ditto.
- 6:51 PM Changeset in webkit [157772] by
-
- 5 edits in trunk/Websites/test-results
New flakiness dashboard should align results by revision numbers
https://bugs.webkit.org/show_bug.cgi?id=123129
Reviewed by Tim Horton.
- include/config.json: Specify the default cache time to be 10 minutes.
- include/json-shared.php: Added Expires and Cache-Control headers. It's configurable via config.json.
- index.html:
(TestResultsView._createResultCell): Don't put '-' in a result cell without time.
(TestResultsView._populateTestPane): Create an array of build times ordered from the newest to the oldest.
Not that build.time() is the newest commit time among all repository for each result. e.g. if we had
both WebKit and Safari repository information in a given result, the newer of the two will be used.
(TestResultsView._createTestResultHeader): Added.
(TestResultsView._createBuildsAndComputeSlownessOfResults): Extracted from _createTestResultRow so
that _populateTestPane could use Build object before calling _createTestResultRow.
(TestResultsView._createTestResultRow): Takes buildTimes. Insert an empty cell for a build time if
the current row doesn't contain that a result for that build time.
(TestResultsView._populateBuilderPane):
- main.css: Tweaked the style so that bubbles are aligned vertically without '-'.
(.resultsTable):
(.resultsTable thead th):
(.resultsTable .resultCell):
(.resultsTable a):
(.resultsTable span a):
- 6:31 PM Changeset in webkit [157771] by
-
- 1 edit in trunk/WebKitLibraries/libWebKitSystemInterfaceMavericks.a
Set svn:mime-type on libWebKitSystemInterfaceMavericks.a so that future changes don't generate giant commit emails.
- 6:27 PM Changeset in webkit [157770] by
-
- 9 edits1 add in trunk
Add a version of WebKitSystemInterface for Mavericks.
Reviewed by Ryosuke Niwa.
Source/WebKit/mac:
- Configurations/DebugRelease.xcconfig:
Source/WebKit2:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- Scripts/copy-webkitlibraries-to-product-directory:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
WebKitLibraries:
- libWebKitSystemInterfaceMavericks.a: Added.
- 6:25 PM Changeset in webkit [157769] by
-
- 33 edits in trunk/Source/WebCore
Use TYPE_CASTS_BASE for CSS_VALUE_TYPE_CASTS
https://bugs.webkit.org/show_bug.cgi?id=123126
Reviewed by Andreas Kling.
TYPE_CASTS_BASE was moved to common place to be used by all toFoo().
CSS_VALUE_TYPE_CASTS starts to use it for CSS child value. This change
generates plenty more helper functions for toCSSFooValue().
Additionally, this use support that toWebKitCSSFooValue, which couldn't
use CSS_VALUE_TYPE_CASTS macro.
No new tests, no behavior change.
- css/CSSAspectRatioValue.h:
- css/CSSBorderImageSliceValue.h:
- css/CSSCalculationValue.h:
- css/CSSCanvasValue.h:
- css/CSSCrossfadeValue.h:
- css/CSSCursorImageValue.h:
- css/CSSFilterImageValue.h:
- css/CSSFontFaceSrcValue.h:
- css/CSSFontFeatureValue.h:
- css/CSSFontValue.h:
- css/CSSFunctionValue.h:
- css/CSSGradientValue.h:
- css/CSSGridTemplateValue.h:
- css/CSSImageSetValue.h:
- css/CSSImageValue.h:
- css/CSSInheritedValue.h:
- css/CSSInitialValue.h:
- css/CSSLineBoxContainValue.h:
- css/CSSPrimitiveValue.h:
- css/CSSReflectValue.h:
- css/CSSShadowValue.h:
- css/CSSTimingFunctionValue.h:
- css/CSSUnicodeRangeValue.h:
- css/CSSValue.h:
- css/CSSValueList.h:
- css/CSSVariableValue.h:
- css/WebKitCSSArrayFunctionValue.h:
- css/WebKitCSSFilterValue.h:
- css/WebKitCSSMatFunctionValue.h:
- css/WebKitCSSMixFunctionValue.h:
- css/WebKitCSSSVGDocumentValue.h:
- css/WebKitCSSShaderValue.h:
- 5:29 PM Changeset in webkit [157768] by
-
- 2 edits in trunk/Source/WebCore
Bad cast with toRenderBoxModelObject in RenderBlock::updateFirstLetter()
https://bugs.webkit.org/show_bug.cgi?id=123013
Reviewed by Andreas Kling.
No new tests because this was reported by Google ClusterFuzz.
https://codereview.chromium.org/25713009/
There is a case that toRenderBoxModelObject causes a crash in RenderBlock::updateFirstLetter()
due to bad cast, so we need to check whether the RenderObject is a RenderBoxModelObject
by running isBoxModelObject() before calling toRenderBoxModelObject.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
- 5:18 PM Changeset in webkit [157767] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154289. <rdar://problem/15109381>
- 5:18 PM Changeset in webkit [157766] by
-
- 10 edits2 moves in trunk/Source/WebCore
Make IDBTransactionCoordinatorLevelDB cross platform
https://bugs.webkit.org/show_bug.cgi?id=123124
Enthusiastically reviewed by Tim Horton.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
Make more methods pure virtual in the interface:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
Update the name of the class, and use IDBTransactionBackendInterface instead of IDBTransactionBackendLeveDB:
- Modules/indexeddb/IDBTransactionCoordinator.cpp: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.cpp.
(WebCore::IDBTransactionCoordinator::create):
(WebCore::IDBTransactionCoordinator::IDBTransactionCoordinator):
(WebCore::IDBTransactionCoordinator::~IDBTransactionCoordinator):
(WebCore::IDBTransactionCoordinator::didCreateTransaction):
(WebCore::IDBTransactionCoordinator::didStartTransaction):
(WebCore::IDBTransactionCoordinator::didFinishTransaction):
(WebCore::IDBTransactionCoordinator::isActive):
(WebCore::IDBTransactionCoordinator::processStartedTransactions):
(WebCore::doScopesOverlap):
(WebCore::IDBTransactionCoordinator::canRunTransaction):
- Modules/indexeddb/IDBTransactionCoordinator.h: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.h.
Update the name of the class elsewhere:
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
(WebCore::IDBDatabaseBackendLevelDB::transactionCoordinator):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
- 4:55 PM Changeset in webkit [157765] by
-
- 4 edits3 copies in branches/safari-537.73-branch
Merged r154217. <rdar://problem/15109395>
- 4:54 PM Changeset in webkit [157764] by
-
- 11 edits in trunk/Source
[iOS] Upstream JSGlobalObject::shouldInterruptScriptBeforeTimeout()
https://bugs.webkit.org/show_bug.cgi?id=123045
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- jsc.cpp: Add function pointer for shouldInterruptScriptBeforeTimeout
to global method table.
- runtime/JSGlobalObject.cpp: Ditto.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::shouldInterruptScriptBeforeTimeout): Added.
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::shouldInterruptScriptToPreventInfiniteRecursionWhenClosingPage): Added.
(WebCore::JSDOMWindowBase::shouldInterruptScript): Extracted comment and assertion
about null Page object into WebCore::shouldInterruptScriptToPreventInfiniteRecursionWhenClosingPage()
so that it can be shared by both this function and JSDOMWindowBase::shouldInterruptScriptBeforeTimeout().
(WebCore::JSDOMWindowBase::shouldInterruptScriptBeforeTimeout):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::shouldInterruptScriptBeforeTimeout): Added.
- bindings/js/JSWorkerGlobalScopeBase.h:
- loader/EmptyClients.h: Added isStopping(). We'll land the iOS chrome client implementation
in a subsequent patch.
- page/ChromeClient.h: Added isStopping().
- 4:35 PM Changeset in webkit [157763] by
-
- 16 edits5 copies4 deletes in branches/safari-537.73-branch/Source
Merged r154183. <rdar://problem/15109466>
- 4:35 PM Changeset in webkit [157762] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: [CSS Regions] Flows are not loading if you refresh the page several times
https://bugs.webkit.org/show_bug.cgi?id=123123
Reviewed by Joseph Pecoraro.
There was a typo in the code where an exception was thrown because "flowKey" was undefined.
- UserInterface/DOMTree.js:
(WebInspector.DOMTree.prototype._contentFlowListWasUpdated):
- 4:28 PM Changeset in webkit [157761] by
-
- 3 edits in trunk/Source/JavaScriptCore
[iOS] Upstream JSC Objective-C API compiler warning fixes
https://bugs.webkit.org/show_bug.cgi?id=123125
Reviewed by Mark Hahnenberg.
Based on a patch by Mark Hahnenberg.
- API/JSValue.mm:
(-[JSValue toPoint]): Cast to CGFloat to fix some compiler warnings about double narrowing to float.
(-[JSValue toSize]): Ditto.
- API/tests/testapi.mm: Changed a test that was failing due to overflow of 32-bit NSUInteger on armv7.
- 4:15 PM Changeset in webkit [157760] by
-
- 10 edits in branches/safari-537.73-branch/Source/WebKit/mac
Merged r154078. <rdar://problem/15109379>
- 4:11 PM Changeset in webkit [157759] by
-
- 3 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r154085. <rdar://problem/15109354>
- 4:09 PM Changeset in webkit [157758] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r154077. <rdar://problem/15109354>
- 4:06 PM Changeset in webkit [157757] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r153848. <rdar://problem/15109354>
- 3:55 PM Changeset in webkit [157756] by
-
- 4 edits2 adds in trunk
Navigation policy callback not called when performing the same fragment navigation twice
https://bugs.webkit.org/show_bug.cgi?id=123121
<rdar://problem/15230466>
Reviewed by Beth Dakin.
Source/WebCore:
There's code in PolicyChecker::checkNavigationPolicy that will call the decision function right away
if the requests are equal, without consulting any policy client. Because of this, make sure to empty out
the last checked request of the document loader when doing a fragment navigation.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
Tools:
Add a test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
- TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
(+[WebKit1FragmentNavigationTestDelegate shared]):
(-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
(-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
(-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
(-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
(TestWebKitAPI::TEST):
- 3:49 PM Changeset in webkit [157755] by
-
- 5 edits in trunk/Source/JavaScriptCore
[iOS] Mark classes JS{Context, ManagedValue, Value, VirtualMachine} as
available since iOS 7.0
https://bugs.webkit.org/show_bug.cgi?id=123122
Reviewed by Dan Bernstein.
- API/JSContext.h:
- API/JSManagedValue.h:
- API/JSValue.h:
- API/JSVirtualMachine.h:
- 3:48 PM Changeset in webkit [157754] by
-
- 3 edits in trunk/Source/WebKit2
Try to fix the Mac 32-bit build.
- UIProcess/API/mac/WKBrowsingContextController.h:
- UIProcess/API/mac/WKBrowsingContextController.mm:
- 3:46 PM Changeset in webkit [157753] by
-
- 3 edits in trunk/Source/WebKit/mac
Remove platform #ifdefs from WebDataSourcePrivate.h
https://bugs.webkit.org/show_bug.cgi?id=123120
<rdar://problem/15275533>
Reviewed by Anders Carlsson.
- WebView/WebDataSource.mm:
(-[WebDataSource _setAllowToBeMemoryMapped]): Define empty implementation when building without
disk image cache enabled.
(-[WebDataSource setDataSourceDelegate:]): Ditto.
(-[WebDataSource dataSourceDelegate]): Return nullptr when building without disk image cache
enabled on iOS.
- WebView/WebDataSourcePrivate.h: Removed platform #ifdefs added in
<http://trac.webkit.org/changeset/156918> (https://bugs.webkit.org/show_bug.cgi?id=121985)
- 3:40 PM Changeset in webkit [157752] by
-
- 4 edits in trunk/Source/WebKit2
Give up on building RemoteLayerTreeTransaction::dump on Lion, it just won't work.
This definitely ought to fix the build.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
- 3:25 PM Changeset in webkit [157751] by
-
- 8 edits in trunk/Websites/test-results
New flakiness dashboard show test time, modifiers, and flaky tests
https://bugs.webkit.org/show_bug.cgi?id=123119
Reviewed by Tim Horton.
- api/failing-tests.php: Manually serialize each row in the results to avoid hitting the memory limit.
- include/db.php:
(Database::query): Added.
(Database::fetch_next_row): Added.
- include/init-database.sql: Added modifiers and time columns to results table.
- include/test-results.php:
(store_test_results): Update start_time and end_time to the union of the new interval and the existing interval.
(recursively_add_test_results): Handle empty $full_name to eliminate the loop over tests in store_test_results.
Also verify that each test name, expected and actual results conform to the specific format to prevent XSS.
Also use insert_row instead of select_or_insert_row to avoid issuing an unnecessary SQL query.
(format_result): Extracted from format_result_rows. Used in failing-tests.php.
- index.html:
(TestResultsView): Added _currentBuilderFailureType and _currentBuilderDays.
(TestResultsView._createResultCell): Show the test time and the expected result.
(TestResultsView._createTestResultRow): Compute the slowest run and also round time to tenth of second for time
less than 10s or second if it's more than 10s so that the test time will always be shown in two digits.
Also show the bug number and the latest expected result on the left columns after linkifying the bug numbers.
(TestResultsView._matchesFailureType): Added. Determines whether results is of a particular failure type.
(TestResultsView._populateBuilderPane):
(TestResultsView.fetchFailingTestsForBuilder): Store the failure type such as flaky, wrongtestexpectations.
(TestResultsView.updateLocationHash):
(TestResultsView.loadTestsFromLocationHash):
(fetchManifest):
- js/dom.js:
(element): appendChild if an item is a Node. Otherwise, e.g. integer, create a text node out of toString() call.
- main.css: Updated styles.
- 3:21 PM Changeset in webkit [157750] by
-
- 2 edits in trunk/Source/WebKit2
Maybe a Lion build fix after r157731, part 2.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::operator<<):
- 3:11 PM Changeset in webkit [157749] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; unprotect the declaration of updateSleepDisabling();
- html/HTMLMediaElement.h:
- 3:09 PM Changeset in webkit [157748] by
-
- 9 edits4 moves12 adds in trunk/Source/WebKit2
[Cocoa] Back/forward list UI process API
https://bugs.webkit.org/show_bug.cgi?id=123109
Reviewed by Darin Adler.
- CMakeLists.txt: Updated for renames.
- GNUmakefile.list.am: Ditto.
- Shared/Cocoa: Added.
- Shared/Cocoa/WKNSArray.h: Added. WKNSArray is an internal NSArray subclass backed by
a WebKit::ImmutableArray.
- Shared/Cocoa/WKNSArray.mm: Added.
(+[WKNSArray web_arrayWithImmutableArray:]): Added.
(-[WKNSArray web_initWithImmutableArray:]): Added.
(-[WKNSArray count]): Added.
(-[WKNSArray objectAtIndex:]): Added.
(-[WKNSArray copyWithZone:]): Added.
- Shared/Cocoa/WKNSObjectExtras.h: Added. Declares a category on NSObject that allows us to
vend WebKit API objects as Objective-C objects.
- Shared/Cocoa/WKNSObjectExtras.mm: Added.
(-[WKObject initWithAPIObject:]): WKObject is the generic Cocoa wrapper for API objects.
(-[WKObject isEqual:]): Check for equality of the underlying object.
(-[WKObject hash]): Return a pointer to the underlying object.
(-[WKObject description]): Added.
(+[NSObject _web_objectWithAPIObject:]): Added. Returns an appropriate Objective-C object
for the given API object. Currently returns a WKBackForwardListItem for a back/forward list
item and a generic WKObject for all other types.
- UIProcess/API/C/WKBackForwardList.cpp: Renamed.
- UIProcess/API/C/WKBackForwardList.h: Renamed.
- UIProcess/API/C/WKBackForwardListItem.cpp: Renamed.
- UIProcess/API/C/WKBackForwardListItem.h: Renamed.
- UIProcess/API/C/WKBackForwardListItemRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardListItem.cpp.
- UIProcess/API/C/WKBackForwardListItemRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardListItem.h.
- UIProcess/API/C/WKBackForwardListRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardList.cpp.
- UIProcess/API/C/WKBackForwardListRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardList.h.
- UIProcess/API/C/WebKit2_C.h: Updated for header renames.
- UIProcess/API/efl/ewk_back_forward_list.cpp: Updated for rename.
- UIProcess/API/efl/ewk_back_forward_list_item.cpp: Ditto.
- UIProcess/API/mac/WKBrowsingContextController.h: Declared backForwardList property.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController backForwardList]): Added this accessor.
- UIProcess/Cocoa: Added.
- UIProcess/Cocoa/WKBackForwardList.h: Added.
- UIProcess/Cocoa/WKBackForwardList.mm: Added.
(toWKBackForwardListItem): Added this helper.
(-[WKBackForwardList currentItem]): Added.
(-[WKBackForwardList backItem]): Added.
(-[WKBackForwardList forwardItem]): Added.
(-[WKBackForwardList itemAtIndex:]): Added.
(-[WKBackForwardList backListCount]): Added.
(-[WKBackForwardList forwardListCount]): Added.
(-[WKBackForwardList backListWithLimit:]): Added.
(-[WKBackForwardList forwardListWithLimit:]): Added.
(-[WKBackForwardList _initWithList:]): Added.
- UIProcess/Cocoa/WKBackForwardListInternal.h: Added.
- UIProcess/Cocoa/WKBackForwardListItem.h: Added.
- UIProcess/Cocoa/WKBackForwardListItem.mm: Added.
(-[WKBackForwardListItem URL]): Added.
(-[WKBackForwardListItem title]): Added.
(-[WKBackForwardListItem originalURL]): Added.
(-[WKBackForwardListItem isEqual:]): Check for equality of the underlying object.
(-[WKBackForwardListItem hash]): Return a pointer to the underlying object
(-[WKBackForwardListItem _initWithItem:]): Added.
- UIProcess/Cocoa/WKBackForwardListItemInternal.h: Added.
- WebKit2.xcodeproj/project.pbxproj: Updated for renames and additions.
- 3:06 PM Changeset in webkit [157747] by
-
- 3 edits in trunk/Tools
Style checker should allow a space after the @property keyword
https://bugs.webkit.org/show_bug.cgi?id=123117
Reviewed by Anders Carlsson.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing_for_function_call): Allow a space between @property and the following (
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_for_fncall): Added a test case.
- 3:00 PM Changeset in webkit [157746] by
-
- 14 edits in trunk/Source
Avoid JSC debugger overhead unless needed.
https://bugs.webkit.org/show_bug.cgi?id=123084.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- If no breakpoints are set, we now avoid calling the debug hook callbacks.
- If no break on exception is set, we also avoid exception event debug callbacks.
- When we return from the ScriptDebugServer to the JSC::Debugger, we may no longer call the debug hook callbacks if not needed. Hence, the m_currentCallFrame pointer in the ScriptDebugServer may become stale. To avoid this issue, before returning, the ScriptDebugServer will clear its m_currentCallFrame if needsOpDebugCallbacks() is false.
- debugger/Debugger.cpp:
(JSC::Debugger::Debugger):
(JSC::Debugger::setNeedsExceptionCallbacks):
(JSC::Debugger::setShouldPause):
(JSC::Debugger::updateNumberOfBreakpoints):
(JSC::Debugger::updateNeedForOpDebugCallbacks):
- debugger/Debugger.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
(JSC::Interpreter::debug):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_debug):
- llint/LLIntOffsetsExtractor.cpp:
- llint/LowLevelInterpreter.asm:
Source/WebCore:
No new tests.
- If no breakpoints are set, we now avoid calling the debug hook callbacks.
- If no break on exception is set, we also avoid exception event debug callbacks.
- When we return from the ScriptDebugServer to the JSC::Debugger, we may no longer call the debug hook callbacks if not needed. Hence, the m_currentCallFrame pointer in the ScriptDebugServer may become stale. To avoid this issue, before returning, the ScriptDebugServer will clear its m_currentCallFrame if needsOpDebugCallbacks() is false.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnNextStatement):
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::dispatchDidContinue):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::didReachBreakpoint):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::reset):
Source/WebKit/mac:
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::WebScriptDebugger):
- 2:48 PM Changeset in webkit [157745] by
-
- 6 edits in branches/safari-537.73-branch/Source
Merged r154067. <rdar://problem/15109373>
- 2:43 PM Changeset in webkit [157744] by
-
- 1 edit2 copies in branches/safari-537.73-branch/LayoutTests
Merged r153982. <rdar://problem/15109382>
- 2:42 PM Changeset in webkit [157743] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r153975. <rdar://problem/15109382>
- 2:39 PM Changeset in webkit [157742] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r153920. <rdar://problem/15109364>
- 2:36 PM Changeset in webkit [157741] by
-
- 8 edits2 copies in branches/safari-537.73-branch
Merged r153913. <rdar://problem/15109360>
- 2:33 PM Changeset in webkit [157740] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r153909. <rdar://problem/15109368>
- 2:31 PM Changeset in webkit [157739] by
-
- 11 edits in trunk
Grammar markers are not updated when switching between 1x and 2x
https://bugs.webkit.org/show_bug.cgi?id=122146
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-21
Reviewed by Dean Jackson.
Source/WebCore:
When running editing/spelling/grammar-markers-hidpi.html, the 2x
grammar/spelling dot resources are cached. If you then run
editing/spelling/grammar-markers.html without tearing down WebKit,
it re-uses the 2x dots. The difference between the two tests is a call
to testRunner.setBackingScaleFactor().
We create a NSColor from an NSImage, and remember it in a static
variable. However, NSColor inspects the current graphics context to
determine which resolution to use, and then remembers that decision.
Therefore, we want to recreate the NSColor whenever the device pixel
ratio changes. This patch adds a new static function to GraphicsContext
which recreates this NSColor every time the ratio changes.
Tests: editing/spelling/grammar-markers.html
editing/spelling/inline_spelling_markers.html
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::makePattern):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
LayoutTests:
- platform/mac/editing/spelling/grammar-markers-expected.png:
- platform/mac/editing/spelling/inline_spelling_markers-expected.png:
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::makePattern):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
- 2:26 PM Changeset in webkit [157738] by
-
- 11 edits2 copies in branches/safari-537.73-branch
Merged r153877. <rdar://problem/15109353>
- 2:26 PM Changeset in webkit [157737] by
-
- 3 edits in trunk/Source/JavaScriptCore
[WIN] Unreviewed build correction.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Handle new JIT files as C++ implementation sources, not header files.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
- 2:22 PM Changeset in webkit [157736] by
-
- 2 edits in trunk/Source/WebCore
Use pink layer borders for compositing layers with a contents layer
https://bugs.webkit.org/show_bug.cgi?id=123118
Reviewed by Dean Jackson.
With the existing layer border colors, it's not possible to distinguish an empty
layer from one with solid color, image or video contents. So use a pink color
for those. This makes it easier to diagnose bugs like 122784.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::getDebugBorderInfo):
- 2:20 PM Changeset in webkit [157735] by
-
- 7 edits in trunk/Source/WebCore
Limit use of display sleep assertion when <video> element is off-screen.
https://bugs.webkit.org/show_bug.cgi?id=123041
Reviewed by Darin Adler.
Use page visibility changes to suspend and resume the use of sleep assertions in
HTMLMediaElement.
Page will propogate the page visibility change notifications to its Documents, which
will further propogate those notifications to registered elements. Upon receiving
these notifications, HTMLMediaElement will release or take a DisplaySleepDisabler
token if necessary.
Also, rename HTMLMediaElement's updateDisableSleep() to updateSleepDisabling() and wrap
the implementation in a PLATFORM(MAC) guard rather than at each call site.
- dom/Document.cpp:
(WebCore::Document::registerForVisibilityStateCallbacks): Added registration method.
(WebCore::Document::unregisterForVisibilityStateCallbacks): Added unregistration method.
(WebCore::Document::visibilityStateChanged): Call all registered clients.
- dom/Document.h:
- dom/Element.h:
(WebCore::Element::visibilityStateChanged): Added default virtual method to be overridden
by subclasses.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Register for the notification, and check the
current status of Document::hidden().
(WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for the notification.
(WebCore::HTMLMediaElement::visibilityStateChanged): Set m_displaySleepDisablingSuspended
and call updateSleepDisabling().
(WebCore::HTMLMediaElement::shouldDisableSleep): Add a check for m_displaySleepDisablingSuspended.
- html/HTMLMediaElement.h:
- page/Page.cpp:
(WebCore::Page::setVisibilityState): Pass to every child document.
Rename updateDisableSleep() -> updateSleepDisabling():
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::mediaPlayerRateChanged):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::stop):
- 2:20 PM Changeset in webkit [157734] by
-
- 2 edits in trunk/Source/WebKit2
Maybe a Lion build fix after r157731.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::operator<<):
- 2:14 PM Changeset in webkit [157733] by
-
- 3 edits in trunk/Source/WebCore
MediaStreamTrack now tracks its own state
https://bugs.webkit.org/show_bug.cgi?id=123025
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-21
Reviewed by Jer Noble.
The spec says that a MediaStreamSource can be shared by different tracks,
so a track must have its own state tracking, synchronizing with its MediaStreamSource when
the underlying MediaStreamSource changes the readyState.
In the old implementation if a user invoked the stop method, its readyState method was still
returning the MediaStreamSource state, which was wrong.
This also adds a setEnabled method, which can be used to set the state of a track when a
remote peer ends it, for instance.
No new tests needed.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::setState):
(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::ended):
(WebCore::MediaStreamTrack::sourceStateChanged):
(WebCore::MediaStreamTrack::trackDidEnd):
- Modules/mediastream/MediaStreamTrack.h:
- 1:59 PM Changeset in webkit [157732] by
-
- 2 edits in branches/safari-537.73-branch/Source/WTF
Merged r153767. <rdar://problem/15109338>
- 1:42 PM Changeset in webkit [157731] by
-
- 4 edits in trunk/Source
Remote Layer Tree: Clean up transaction logging
https://bugs.webkit.org/show_bug.cgi?id=123116
Reviewed by Anders Carlsson.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::RemoteLayerTreeTextStream):
(WebKit::RemoteLayerTreeTextStream::increaseIndent):
(WebKit::RemoteLayerTreeTextStream::decreaseIndent):
(WebKit::RemoteLayerTreeTextStream::writeIndent):
(WebKit::RemoteLayerTreeTextStream::operator<<):
Add some stream operator overrides for various types we need to dump.
Add a notion of current indent to our TextStream subclass to make it
easy to keep track of where we are.
(WebKit::dumpProperty):
Added, hand any arbitrary type to RemoteLayerTreeTransaction.
(WebKit::dumpChangedLayers):
(WebKit::RemoteLayerTreeTransaction::dump):
Make use of TextStream.
- WebCore.exp.in:
Export some TextStream functions.
- 1:31 PM Changeset in webkit [157730] by
-
- 22 edits in trunk/Source
Transition most use of IDBBackingStoreLevelDB to IDBBackingStoreInterface
https://bugs.webkit.org/show_bug.cgi?id=123105
Reviewed by Anders Carlsson.
Source/WebCore:
Export more required headers:
- WebCore.xcodeproj/project.pbxproj:
Flesh out many of the pure virtual methods on IDBBackingStoreInterface, as well as
the RecordIdentifier and Cursor classes:
- Modules/indexeddb/IDBBackingStoreInterface.h:
(WebCore::IDBBackingStoreInterface::RecordIdentifier::~RecordIdentifier):
(WebCore::IDBBackingStoreInterface::Cursor::~Cursor):
Use IDBBackingStoreInterface, IDBBackingStoreInterface::RecordIdentifier, and
IDBBackingStoreInterface::Cursor wherever possible:
- Modules/indexeddb/IDBFactoryBackendInterface.cpp:
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::ObjectStoreKeyCursorImpl::clone):
(WebCore::ObjectStoreCursorImpl::clone):
(WebCore::IndexKeyCursorImpl::clone):
(WebCore::IndexCursorImpl::clone):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
(WebCore::IDBBackingStoreLevelDB::Transaction::Transaction):
(WebCore::IDBBackingStoreLevelDB::Transaction::begin):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
(WebCore::IDBBackingStoreLevelDB::RecordIdentifier::RecordIdentifier):
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
(WebCore::IDBCursorBackendLevelDB::IDBCursorBackendLevelDB):
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
(WebCore::IDBCursorBackendLevelDB::create):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
(WebCore::IDBDatabaseBackendLevelDB::create):
(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
(WebCore::IDBDatabaseBackendLevelDB::backingStore):
(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
(WebCore::IDBDatabaseBackendLevelDB::createTransaction):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::createTransactionBackend):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::verifyIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::writeIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::addingKeyAllowed):
(WebCore::IDBObjectStoreBackendLevelDB::makeIndexWriters):
(WebCore::IDBObjectStoreBackendLevelDB::generateKey):
(WebCore::IDBObjectStoreBackendLevelDB::updateKeyGenerator):
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::create):
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
(WebCore::GetOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:
(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(WebCore::CountOperation::create):
(WebCore::CountOperation::CountOperation):
(WebCore::DeleteRangeOperation::create):
(WebCore::DeleteRangeOperation::DeleteRangeOperation):
(WebCore::ClearOperation::create):
(WebCore::ClearOperation::ClearOperation):
Source/WebKit2:
Stub out a new pure virtual method:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::createTransactionBackend):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- 1:18 PM Changeset in webkit [157729] by
-
- 4 edits2 adds in trunk
[CSS Shapes][CSS Regions] Don't apply shape-inside when we have multiple auto-height regions and the height is not resolved
https://bugs.webkit.org/show_bug.cgi?id=123103
Reviewed by David Hyatt.
When we have multiple regions with auto-height, the region's height is not resolved from other elements we can't apply the
the shape on the region. This patch prevents to apply the shape and fixes the behavior for these cases.
Source/WebCore:
Test: fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutShapeInsideInfo):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):
LayoutTests:
- fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions.html: Added.
- 1:16 PM Changeset in webkit [157728] by
-
- 6 edits in trunk/Source
Remote Layer Tree: Backing store should take contentsScale into account
https://bugs.webkit.org/show_bug.cgi?id=123106
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::ensureBackingStore):
(PlatformCALayerRemote::setNeedsDisplay):
(PlatformCALayerRemote::setContentsScale):
Inform the backing store of the contentsScale, and when it changes.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.h:
(WebKit::RemoteLayerBackingStore::scale): Added.
(WebKit::RemoteLayerBackingStore::mapToContentCoordinates): Added.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
(RemoteLayerBackingStore::mapToContentCoordinates):
Factor out flipping so we can use it for repaints in multiple places.
(RemoteLayerBackingStore::setNeedsDisplay):
(RemoteLayerBackingStore::display):
Create a buffer scaled up by contentsScale, take the scale into account
when copying clean bits from the front buffer, and apply the scale before
painting into the back buffer.
- WebCore.exp.in:
Export FloatRect::scale.
- 1:15 PM Changeset in webkit [157727] by
-
- 1 edit3 adds in trunk/Source/WebInspectorUI
Restore accidentally removed files.
- 1:10 PM Changeset in webkit [157726] by
-
- 3 edits in trunk/Source/WebCore
RenderScrollbarPart doesn't need styleWillChange().
<https://webkit.org/b/123113>
We will call setInline(false) in styleDidChange(), there's no need
to override styleWillChange() just to do it twice.
Reviewed by Darin Adler.
- 12:38 PM Changeset in webkit [157725] by
-
- 29 edits20 adds in trunk
[CSS Regions] The layers from the flow thread should be collected under the regions' layers.
https://bugs.webkit.org/show_bug.cgi?id=120457
Patch by Mihai Maerean <Mihai Maerean> on 2013-10-21
Reviewed by David Hyatt.
Source/WebCore:
This patch is based on the work of Alexandru Chiculita at https://bugs.webkit.org/attachment.cgi?id=203872&action=review
The composited layers inside the named flow threads are collected as part of the regions (as children of the
GraphicsLayer of the layer that corresponds to the region (which is attached to the parent renderer of
RenderNameFlowFragment)).
When a region displays a layer that needs accelerated compositing we activate the accelerated compositing for
that region too (inside RenderLayerCompositor::computeRegionCompositingRequirements).
This patch has landed before (as http://trac.webkit.org/changeset/156451), but was reverted because
fast/multicol/mixed-positioning-stacking-order.html failed. The fix is inside RenderLayerCompositor::canBeComposited
that only enables compositing for layers inside flow threads that collect the graphics layers under the regions.
Another change from changeset #156451 is that now the region renderers are created as anonymous renderers under
the element that has the flow-from property. When a composited layer is needed for the region, it sits in it's
parent renderer, not in the region renderer (RenderNamedFlowFragment).
Tests: compositing/regions/crash-transform-inside-region.html
compositing/regions/floated-region-with-transformed-child.html
compositing/regions/move-layer-from-one-region-to-another.html
compositing/regions/propagate-region-box-shadow-border-padding-for-video.html
compositing/regions/propagate-region-box-shadow-border-padding.html
compositing/regions/region-as-layer-in-another-flowthread.html
compositing/regions/transform-transparent-positioned-video-inside-region.html
compositing/regions/transformed-layer-inside-transformed-layer.html
compositing/regions/z-index-update.html
compositing/regions/z-index.html
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::propagateStyleToAnonymousChildren): Not for RenderFlowThreads, as they are updated
through the RenderView::styleDidChange function.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout): When the layout of the flow thread is over (including the 2 phase layout),
we update all the mappings between the layers inside the flow thread and the regions where those layers will be
painted.
(WebCore::RenderFlowThread::hasCompositingRegionDescendant): Whether any of the regions has a compositing descendant.
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):
(WebCore::RenderFlowThread::collectsGraphicsLayersUnderRegions):
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Triggers an update of the layers if a layer has moved
from a region to another since the last update.
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings):
- rendering/RenderFlowThread.h:
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::pushRenderFlowThread):
- rendering/RenderGeometryMap.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::enclosingFlowThreadAncestor):
(WebCore::RenderLayer::isFlowThreadCollectingGraphicsLayersUnderRegions):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateLayerBounds): When we calculate the bounds of the RenderView, we ignore those
flow threads that collect the graphics layers under the regions.
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds): Not if it's a flow thread that collects the graphics
layers under the regions
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Now adjusts the ancestorCompositingBounds for the FlowThread.
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Make sure that the region propagates
its borders, paddings, outlines or box-shadows to layers inside it.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Now calls computeRegionCompositingRequirements.
(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Do not iterate the RenderFlowThread directly if
we are going to collect the composited layers as part of regions.
(WebCore::RenderLayerCompositor::rebuildRegionCompositingLayerTree):
(WebCore::RenderLayerCompositor::canBeComposited): CSS Regions flow threads do not need to be composited as we
use composited RenderRegions to render the background of the RenderFlowThread.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): If it's a container of a css region.
- rendering/RenderLayerCompositor.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowFragment.h:
(WebCore::RenderNamedFlowFragment::layerOwner): When the content inside the region requires the region to have a
layer, the layer will be created on the region's parent renderer instead. This method returns that renderer
holding the layer. The return value may be null.
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::addFlowChild):
(WebCore::RenderNamedFlowThread::removeFlowChild):
(WebCore::RenderNamedFlowThread::collectsGraphicsLayersUnderRegions):
- rendering/RenderNamedFlowThread.h: m_flowThreadChildList is now allocated through an OwnPtr to keep the render
arena under the size limit.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::adjustRegionBoundsFromFlowThreadPortionRect):
- rendering/RenderRegion.h:
(WebCore::toRenderRegion):
- rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
- WebCore.exp.in: WebCore::RenderLayer::isFlowThreadCollectingGraphicsLayersUnderRegions
LayoutTests:
- compositing/regions/crash-transform-inside-region-expected.html: Added.
- compositing/regions/crash-transform-inside-region.html: Added.
- compositing/regions/floated-region-with-transformed-child-expected.html: Added.
- compositing/regions/floated-region-with-transformed-child.html: Added.
- compositing/regions/move-layer-from-one-region-to-another-expected.html: Added.
- compositing/regions/move-layer-from-one-region-to-another.html: Added.
- compositing/regions/propagate-region-box-shadow-border-padding-expected.html: Added.
- compositing/regions/propagate-region-box-shadow-border-padding-for-video-expected.html: Added.
- compositing/regions/propagate-region-box-shadow-border-padding-for-video.html: Added.
- compositing/regions/propagate-region-box-shadow-border-padding.html: Added.
- compositing/regions/region-as-layer-in-another-flowthread-expected.html: Added.
- compositing/regions/region-as-layer-in-another-flowthread.html: Added.
- compositing/regions/transform-transparent-positioned-video-inside-region-expected.html: Added.
- compositing/regions/transform-transparent-positioned-video-inside-region.html: Added.
- compositing/regions/transformed-layer-inside-transformed-layer-expected.html: Added.
- compositing/regions/transformed-layer-inside-transformed-layer.html: Added.
- compositing/regions/webkit-flow-renderer-layer-compositing-expected.html:
- compositing/regions/webkit-flow-renderer-layer-compositing.html:
- compositing/regions/z-index-expected.html: Added.
- compositing/regions/z-index-update-expected.html: Added.
- compositing/regions/z-index-update.html: Added.
- compositing/regions/z-index.html: Added.
- fast/multicol/mixed-positioning-stacking-order-expected.html:
- fast/multicol/mixed-positioning-stacking-order.html:
- fast/repaint/region-painting-composited-element-expected.html:
- fast/repaint/region-painting-composited-element.html:
- platform/mac-wk2/TestExpectations:
- 12:23 PM Changeset in webkit [157724] by
-
- 10 edits3 adds in trunk
Source/JavaScriptCore: Support computed property names in object literals
https://bugs.webkit.org/show_bug.cgi?id=123112
Reviewed by Michael Saboff.
Add support for computed property names to the parser.
- bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::getName):
- parser/NodeConstructors.h:
(JSC::PropertyNode::PropertyNode):
- parser/Nodes.h:
(JSC::PropertyNode::expressionName):
(JSC::PropertyNode::name):
- parser/Parser.cpp:
(JSC::::parseProperty):
(JSC::::parseStrictObjectLiteral):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::Property::Property):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::operatorStackPop):
LayoutTests: Support expression property names in object literals
https://bugs.webkit.org/show_bug.cgi?id=123112
Reviewed by Michael Saboff.
Add tests
- js/basic-computed-property-name-expected.txt: Added.
- js/basic-computed-property-name.html: Added.
- js/parser-syntax-check-expected.txt:
- js/script-tests/basic-computed-property-name.js: Added.
(a.string_appeared_here.runTest):
- js/script-tests/parser-syntax-check.js:
- 12:02 PM Changeset in webkit [157723] by
-
- 2 edits in trunk/Source/WebCore
Fixing mediastream debug build
https://bugs.webkit.org/show_bug.cgi?id=123104
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-21
Reviewed by Andreas Kling.
No new tests needed.
- Modules/mediastream/RTCDTMFToneChangeEvent.cpp:
(WebCore::RTCDTMFToneChangeEvent::create):
- 11:29 AM Changeset in webkit [157722] by
-
- 3 edits in trunk/Source/WebCore
Merge RenderListMarker::styleWillChange() into styleDidChange().
<https://webkit.org/b/123098>
If the marker's list-style-type or list-style-position changed, we
need to dirty the layout. Move this logic to styleDidChange() so we
can get rid of one styleWillChange() overload.
Reviewed by Antti Koivisto.
- 10:04 AM Changeset in webkit [157721] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/media-controller-time-clamp.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123099
- platform/mac/TestExpectations: Marking as such.
- 9:53 AM Changeset in webkit [157720] by
-
- 5 edits4 adds in trunk
[CSS Regions] Fix WHITESPACE issues in the CSS grammar.
https://bugs.webkit.org/show_bug.cgi?id=123082
Patch by Mihai Maerean <Mihai Maerean> on 2013-10-21
Reviewed by Andreas Kling.
This is a port of Rune Lillesveen's patch from https://codereview.chromium.org/25607005
Source/WebCore:
Fix WHITESPACE issues in the CSS grammar.
A single WHITESPACE token consumes consecutive spaces, but does not consume
spaces separated by comments. That means S* and S+ in CSS grammars need to
accept multiple WHITESPACE tokens. Additionally, white spaces are not
mandatory to separate an @-symbol and the rest of the prelude.
Use space non-terminal instead of WHITESPACE for S+ in calc expressions.
Use maybe_space non-terminal instead of WHITESPACE for S* after @-webkit-filter
and @-webkit-region.
Tests: fast/css/calc-comments-allowed.html
fast/regions/webkit-region-syntax-space.html
- css/CSSGrammar.y.in:
LayoutTests:
- css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid-expected.txt:
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-valid.js:
- fast/css/calc-comments-allowed-expected.html: Added.
- fast/css/calc-comments-allowed.html: Added.
- fast/regions/webkit-region-syntax-space-expected.txt: Added.
- fast/regions/webkit-region-syntax-space.html: Added.
- 8:41 AM Changeset in webkit [157719] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add option so that JSC will crash if it can't allocate executable memory for the JITs
https://bugs.webkit.org/show_bug.cgi?id=123048
<rdar://problem/12856193>
Patch by Michael Saboff <msaboff@apple.com> on 2013-10-21
Reviewed by Geoffrey Garen.
Added new option, called crashIfCantAllocateJITMemory. If this option is true then we crash
when checking the validity of the executable allocator. The default value for this option is
false, but jsc sets it to true when built for iOS to make it straightforward to identify whether
the app can obtain executable memory.
- jsc.cpp: Explicitly enable crashIfCantAllocateJITMemory on iOS.
(main):
- runtime/Options.h: Added option crashIfCantAllocateJITMemory.
- runtime/VM.cpp:
(JSC::enableAssembler): Modified to crash if option crashIfCantAllocateJITMemory
is enabled.
- 7:02 AM Changeset in webkit [157718] by
-
- 4 edits in trunk/Source/WebCore
[ATK] Use atk_object_notify_state_change instead of manually emitting signals
https://bugs.webkit.org/show_bug.cgi?id=122968
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-10-21
Reviewed by Mario Sanchez Prada.
Refactor emitting "state-change" event to use atk_object_notify_state_change
instead of using g_signal_emit_by_name.
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleDetach):
- editing/atk/FrameSelectionAtk.cpp:
(WebCore::maybeEmitTextFocusChange):
- 2:53 AM Changeset in webkit [157717] by
-
- 5 edits in trunk/Source
Make TYPE_CASTS_BASE more flexible
https://bugs.webkit.org/show_bug.cgi?id=122951
Reviewed by Andreas Kling.
TYPE_CASTS_BASE is being used by node|element type casts. However, it is difficult
to be used by other type casts. For instance, CSSValue, Accessibility and so on.
This patch modifies TYPE_CASTS_BASE which can support other type casts.
Besides TYPE_CASTS_BASE body is moved from node.h to Assertions.h.
Source/WebCore:
No new tests, no behavior changes.
- dom/Document.h:
- dom/Node.h:
Source/WTF:
- wtf/Assertions.h:
- 2:44 AM Changeset in webkit [157716] by
-
- 2 edits in trunk/Tools
[WinCairo] Build does not start.
https://bugs.webkit.org/show_bug.cgi?id=123059
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-21
Reviewed by Csaba Osztrogonác.
The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
- Scripts/build-webkit:
- 2:43 AM Changeset in webkit [157715] by
-
- 1 edit1 delete in trunk
Remove .qmake.conf files
https://bugs.webkit.org/show_bug.cgi?id=123091
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-10-21
Reviewed by Csaba Osztrogonác.
- .qmake.conf: Removed.
- 2:32 AM Changeset in webkit [157714] by
-
- 1 edit1 delete in trunk/Source/JavaScriptCore
Remove AllInOneFile.cpp
https://bugs.webkit.org/show_bug.cgi?id=123055
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-21
Reviewed by Csaba Osztrogonác.
- AllInOneFile.cpp: Removed.
- 2:31 AM Changeset in webkit [157713] by
-
- 2 edits in trunk/Source/WebKit2
Remove qt from generate-forwarding-headers.pl
https://bugs.webkit.org/show_bug.cgi?id=123090
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-10-21
Reviewed by Andreas Kling.
- Scripts/generate-forwarding-headers.pl:
- 2:00 AM Changeset in webkit [157712] by
-
- 2 edits in trunk/Tools
[Jhbuild] Bump the required Jhbuild revision
https://bugs.webkit.org/show_bug.cgi?id=123089
Reviewed by Carlos Garcia Campos.
- jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
in the Jhbuild source so a more recent revision of it should be used.
- 1:57 AM Changeset in webkit [157711] by
-
- 4 edits in trunk/Source
[GTK] g-ir-scanner should use the configured C compiler
https://bugs.webkit.org/show_bug.cgi?id=123088
Reviewed by Carlos Garcia Campos.
Source/WebKit/gtk:
- GNUmakefile.am: Pass the C compiler that was detected at configuration to the g-ir-scanner command
via the CC environment variable. This solves the issue of the scanner running the GCC compiler with
the Clang-specific CFLAGS.
Source/WebKit2:
- GNUmakefile.am: Pass the C compiler that was detected at configuration to the g-ir-scanner command
via the CC environment variable. This solves the issue of the scanner running the GCC compiler with
the Clang-specific CFLAGS.
- 12:11 AM Changeset in webkit [157710] by
-
- 4 edits2 adds in trunk
ASSERTION FAILED: !style->propertyIsImportant(propertyID) in WebCore::setTextDecorationProperty
https://bugs.webkit.org/show_bug.cgi?id=122097
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-21
Reviewed by Ryosuke Niwa.
Source/WebCore:
When remove format command is called we pushdown the ancestor style
down to its children. Currently applying inline style to iframe
while pushing down style which causes iframe to be reinserted in tree and
triggres again subframe loading which repeats everytime and finally
crash happens. So we should avoid applying inline style to iframe
element as it doesnot reflect in its content while pushing down style
on it.
And ASSERT call has been removed from setTextDecoration property as
the scenario is perfectly valid case.
Test: editing/execCommand/remove-format-textdecoration-in-iframe.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Return if
element is iframe.
- editing/EditingStyle.cpp:
(WebCore::StyleChange::setTextDecorationProperty): Remove ASSERT.
LayoutTests:
Added Test cases to verify that crash does not happen in scenario when
remove format command is executed on selection containing the iframe
element and when textdecoration style is defined as !important and
need to pushDown to iframe.
- editing/execCommand/remove-format-textdecoration-in-iframe-expected.txt: Added.
- editing/execCommand/remove-format-textdecoration-in-iframe.html: Added.
Oct 20, 2013:
- 11:08 PM Changeset in webkit [157709] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Update EFL test expectations.
- platform/efl/TestExpectations: Skip authentication tests that are failing.
- 10:14 PM Changeset in webkit [157708] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, cleanup a FIXME comment.
- jit/Repatch.cpp:
- 9:48 PM Changeset in webkit [157707] by
-
- 19 edits3 adds in trunk/Source
StructureStubInfo's usedRegisters set should be able to track all registers, not just the ones that our JIT's view as temporaries
https://bugs.webkit.org/show_bug.cgi?id=123076
Source/JavaScriptCore:
Reviewed by Sam Weinig.
Start preparing for a world in which we are patching code generated by LLVM, which may have
very different register usage conventions than our JITs. This requires us being more explicit
about the registers we are using. For example, the repatching code shouldn't take for granted
that tagMaskRegister holds the TagMask or that the register is even in use.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::numberOfRegisters):
(JSC::MacroAssembler::registerIndex):
(JSC::MacroAssembler::numberOfFPRegisters):
(JSC::MacroAssembler::fpRegisterIndex):
(JSC::MacroAssembler::totalNumberOfRegisters):
- bytecode/StructureStubInfo.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::usedRegisters):
- dfg/DFGSpeculativeJIT.h:
- ftl/FTLSaveRestore.cpp:
(JSC::FTL::bytesForGPRs):
(JSC::FTL::bytesForFPRs):
(JSC::FTL::offsetOfGPR):
(JSC::FTL::offsetOfFPR):
- jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
- jit/JITInlineCacheGenerator.h:
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
- jit/RegisterSet.cpp: Added.
(JSC::RegisterSet::specialRegisters):
- jit/RegisterSet.h: Added.
(JSC::RegisterSet::RegisterSet):
(JSC::RegisterSet::set):
(JSC::RegisterSet::clear):
(JSC::RegisterSet::get):
(JSC::RegisterSet::merge):
- jit/Repatch.cpp:
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
(JSC::emitPutReplaceStub):
(JSC::tryRepatchIn):
(JSC::linkClosureCall):
- jit/TempRegisterSet.cpp: Added.
(JSC::TempRegisterSet::TempRegisterSet):
- jit/TempRegisterSet.h:
Source/WTF:
Reviewed by Sam Weinig.
Teach BitVector how to efficiently merge (i.e. bitvector |=).
- wtf/BitVector.cpp:
(WTF::BitVector::mergeSlow):
- wtf/BitVector.h:
(WTF::BitVector::merge):
(WTF::BitVector::cleanseInlineBits):
- 6:02 PM Changeset in webkit [157706] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Update EFL test expectations.
- platform/efl/TestExpectations: Mark fast/workers/worker-call.html as failure.
- 3:57 PM Changeset in webkit [157705] by
-
- 9 edits in trunk/Source/WebCore
Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 5)
https://bugs.webkit.org/show_bug.cgi?id=122969
Reviewed by Antti Koivisto.
- Move m_lineBoxes to RenderBlockFlow.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::innerTextIfTruncated):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::removeFromDelayedUpdateScrollInfoSet):
(WebCore::RenderBlock::paintContents):
(WebCore::blockDirectionOffset):
(WebCore::inlineDirectionOffset):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::hitTestContents):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::inlineBlockBaseline):
(WebCore::RenderBlock::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlock::addFocusRingRects):
(WebCore::RenderBlock::showLineTreeAndMark):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::hasInlineBoxChildren):
(WebCore::RenderBlock::paintInlineChildren):
(WebCore::RenderBlock::hitTestInlineChildren):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::RenderBlockFlow):
(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::deleteLineBoxTree):
(WebCore::RenderBlockFlow::hitTestInlineChildren):
(WebCore::RenderBlockFlow::adjustForBorderFit):
(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded):
(WebCore::RenderBlockFlow::markLinesDirtyInBlockRange):
(WebCore::RenderBlockFlow::firstLineBoxBaseline):
(WebCore::RenderBlockFlow::inlineBlockBaseline):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::positionForBox):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlockFlow::paintInlineChildren):
(WebCore::RenderBlockFlow::relayoutForPagination):
(WebCore::RenderBlockFlow::showLineTreeAndMark):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::lineBoxes):
(WebCore::RenderBlockFlow::firstLineBox):
(WebCore::RenderBlockFlow::lastLineBox):
(WebCore::RenderBlockFlow::firstRootBox):
(WebCore::RenderBlockFlow::lastRootBox):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):
- 11:33 AM Changeset in webkit [157704] by
-
- 2 edits in trunk/Source/WebCore
Avoid unnecessary vector copy in AnimationController event dispatch.
<https://webkit.org/b/122994>
Use Vector's move constructor instead of making a copy of the pending
events queue and then clearing it.
Reviewed by Simon Fraser.
- 9:36 AM Changeset in webkit [157703] by
-
- 11 edits1 add in trunk/Source/WebCore
Add abstract IDBBackingStoreInterface, use it to get IDBDatabaseBackendLevelDB closer to going cross-platform
https://bugs.webkit.org/show_bug.cgi?id=123074
Reviewed by Andreas Kling.
- Modules/indexeddb/IDBBackingStoreInterface.h: Added.
(WebCore::IDBBackingStoreInterface::~IDBBackingStoreInterface):
(WebCore::IDBBackingStoreInterface::Transaction::~Transaction):
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseIntVersion):
(WebCore::IDBBackingStoreLevelDB::createObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteObjectStore):
(WebCore::IDBBackingStoreLevelDB::getRecord):
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::clearObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::createIndex):
(WebCore::IDBBackingStoreLevelDB::deleteIndex):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::IDBBackingStoreLevelDB::findKeyInIndex):
(WebCore::IDBBackingStoreLevelDB::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStoreLevelDB::keyExistsInIndex):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
(WebCore::IDBBackingStoreLevelDB::Transaction::reset):
(WebCore::IDBBackingStoreLevelDB::Transaction::levelDBTransactionFrom):
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
(WebCore::IDBCursorBackendLevelDB::deleteFunction):
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::verifyIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::writeIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::addingKeyAllowed):
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
(WebCore::IDBTransactionBackendLevelDB::backingStoreTransaction):
- WebCore.xcodeproj/project.pbxproj:
- GNUmakefile.list.am:
- 9:12 AM Changeset in webkit [157702] by
-
- 17 edits in trunk/Source
Use PassRef for StyleSheetContents.
<https://webkit.org/b/123083>
Let functions that return newly-constructed StyleSheetContents
objects vend PassRef<StyleSheetContents> instead of PassRefPtr.
Updated functions that take StyleSheetContents in arguments
accordingly. And CSSStyleSheet now has a Ref internally. Woo!
Reviewed by Antti Koivisto.
- 8:43 AM Changeset in webkit [157701] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Loading progress API
https://bugs.webkit.org/show_bug.cgi?id=123069
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKBrowsingContextController.h: Declared estimatedProgress property.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController estimatedProgress]): Added.
(didStartProgress): Added. Calls new delegate method
-browsingContextControllerDidStartProgress:.
(didChangeProgress): Added. Calls new delegate method
-browsingContextController:estimatedProgressChangedTo:.
(didFinishProgress): Added. Calls new delegate method
-browsingContextControllerDidFinishProgress:.
(setUpPageLoaderClient): Hook up new client functions.
- UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Declared new delegate methods.
- 7:14 AM Changeset in webkit [157700] by
-
- 15 edits in trunk/Source
Removing "unused parameter" compiling warnings from WebKit2 and WebCore
https://bugs.webkit.org/show_bug.cgi?id=123075
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-20
Reviewed by Andreas Kling.
Source/WebCore:
No new tests needed.
- Modules/mediastream/RTCDTMFToneChangeEvent.cpp:
(WebCore::RTCDTMFToneChangeEvent::create):
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(lineAtPositionForAtkBoundary):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):
Source/WebKit2:
- NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::loadResourceSynchronously):
- UIProcess/API/C/WKContext.cpp:
(WKContextGetPluginSiteDataManager):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetInspectorUsesWebKitUserInterface):
(WKPreferencesGetInspectorUsesWebKitUserInterface):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPlugins):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetFullScreenClient):
(WKBundlePageWillEnterFullScreen):
(WKBundlePageDidEnterFullScreen):
(WKBundlePageWillExitFullScreen):
(WKBundlePageDidExitFullScreen):
- WebProcess/MediaCache/WebMediaCacheManager.cpp:
(WebKit::WebMediaCacheManager::clearCacheForHostname):
- WebProcess/OriginData/WebOriginDataManager.cpp:
(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteAllEntries):
(WebKit::WebOriginDataManager::startObservingChanges):
(WebKit::WebOriginDataManager::stopObservingChanges):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
(WebKit::WebFrameLoaderClient::recreatePlugin):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::canPluginHandleResponse):
- 4:06 AM Changeset in webkit [157699] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] Fix build (broken since r157690).
https://bugs.webkit.org/show_bug.cgi?id=123081
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-20
Reviewed by Andreas Kling.
- assembler/AssemblerBufferWithConstantPool.h:
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::buffer):
(JSC::SH4Assembler::readCallTarget):
- 3:49 AM Changeset in webkit [157698] by
-
- 7 edits in trunk/Source/WebCore
Use PassRef for constructing StyleRules.
<https://webkit.org/b/123072>
Let functions that return newly-constructed StyleRuleFoo objects
vend PassRef<StyleRuleFoo> instead of PassRefPtr.
Since StyleRuleBase::copy() has to return something, we can't rely
on ASSERT_NOT_REACHED() + return nullptr anymore, so I've replaced
those with CRASH(). No call sites actually handled null anyway.
Reviewed by Sam Weinig.
Oct 19, 2013:
- 10:42 PM Changeset in webkit [157697] by
-
- 9 edits1 delete in trunk
Unreviewed roll out of r157695; broke Mac builds.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
LayoutTests:
- platform/mac/js/dom/global-constructors-attributes-expected.txt: Removed.
- 10:40 PM Changeset in webkit [157696] by
-
- 2 edits in trunk/Source/JavaScriptCore
Simplify TempRegisterSet - it no longer needs to be convertible to a POD since it's no longer going to be a member of a union
https://bugs.webkit.org/show_bug.cgi?id=123079
Reviewed by Geoffrey Garen.
- jit/TempRegisterSet.h:
- 9:58 PM Changeset in webkit [157695] by
-
- 9 edits1 add in trunk
[MSE] [Mac] Enable MediaSource on the Mac
https://bugs.webkit.org/show_bug.cgi?id=122484
Reviewed by Darin Adler.
Source/WebCore:
Enable ENABLE_MEDIA_SOURCE.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
Enable ENABLE_MEDIA_SOURCE.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Enable ENABLE_MEDIA_SOURCE.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Enable ENABLE_MEDIA_SOURCE.
- wtf/FeatureDefines.h:
LayoutTests:
- platform/mac/js/dom/global-constructors-attributes-expected.txt: Added.
- 9:55 PM Changeset in webkit [157694] by
-
- 19 edits in trunk/Source/WebCore
CTTE: Tighten up type usage around InputType::innerTextElement()
https://bugs.webkit.org/show_bug.cgi?id=123078
Reviewed by Anders Carlsson.
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleReplacedElement):
- html/HTMLElement.h:
(WebCore::HTMLElement::isTextControlInnerTextElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::innerTextElement):
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::innerTextElement):
- html/HTMLTextAreaElement.h:
- html/HTMLTextFormControlElement.cpp:
(WebCore::hasVisibleTextArea):
(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::innerTextValue):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):
- html/HTMLTextFormControlElement.h:
- html/InputType.h:
(WebCore::InputType::innerTextElement):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::innerTextElement):
- html/TextFieldInputType.h:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerTextElement::renderer):
- html/shadow/TextControlInnerElements.h:
(WebCore::isTextControlInnerTextElement):
- rendering/RenderObject.h:
(WebCore::RenderObject::isTextControlInnerBlock):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::innerTextElement):
(WebCore::RenderTextControl::styleDidChange):
(WebCore::RenderTextControl::textBlockLogicalWidth):
(WebCore::RenderTextControl::updateFromElement):
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::hitInnerTextElement):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):
- rendering/RenderTextControlSingleLine.h:
(WebCore::toRenderTextControlInnerBlock):
- 9:12 PM Changeset in webkit [157693] by
-
- 11 edits1 move in trunk/Source/JavaScriptCore
Rename RegisterSet to TempRegisterSet
https://bugs.webkit.org/show_bug.cgi?id=123077
Reviewed by Dan Bernstein.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/StructureStubInfo.h:
- dfg/DFGJITCompiler.h:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::usedRegisters):
- jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
- jit/JITInlineCacheGenerator.h:
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
- jit/RegisterSet.h: Removed.
- jit/ScratchRegisterAllocator.h:
(JSC::ScratchRegisterAllocator::ScratchRegisterAllocator):
- jit/TempRegisterSet.h: Copied from Source/JavaScriptCore/jit/RegisterSet.h.
(JSC::TempRegisterSet::TempRegisterSet):
(JSC::TempRegisterSet::asPOD):
(JSC::TempRegisterSet::copyInfo):
- 8:51 PM Changeset in webkit [157692] by
-
- 2 edits in trunk/Tools
Mac build fix.
- DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
- 8:15 PM Changeset in webkit [157691] by
-
- 11 edits3 copies in trunk
Enable webaudio/ tests on DRT/Mac
https://bugs.webkit.org/show_bug.cgi?id=86914
Reviewed by Darin Adler.
Tools:
- DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
- DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
- DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
- DumpRenderTree/TestRunner.cpp:
(setAudioResultCallback):
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner::audioResult):
(TestRunner::setAudioResult):
The function has a different name and argument type now, updated accordingly.
Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
- DumpRenderTree/mac/DumpRenderTree.mm:
(dumpAudio): Updated for the new name of audioResult accessor.
(dump): Print the result in the format webkitpy currently expects.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
chunks made no sense.
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
- DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
so that "SourceProvider.h" can be found.
LayoutTests:
- TestExpectations: Moved webaudio/javascriptaudionode here, as garbage collection
issues with it are cross-platform.
- platform/mac-wk2/TestExpectations: Moved out everything, as there is nothing
WK2 specific about WebAudio.
- platform/mac/TestExpectations: WebAudio expectations here were just ignored. Replaced
with slightly updated expectations from WK2.
- 7:07 PM Changeset in webkit [157690] by
-
- 6 edits in trunk/Source/JavaScriptCore
Restructure LinkBuffer to allow for alternate allocation strategies
https://bugs.webkit.org/show_bug.cgi?id=123071
Reviewed by Oliver Hunt.
The idea is to eventually allow a LinkBuffer to place the code into an already
allocated region of memory. That region of memory could be the nop-slide left behind
by a llvm.webkit.patchpoint.
- assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::buffer):
- assembler/AssemblerBuffer.h:
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::allocate):
(JSC::LinkBuffer::shrink):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::didFailToAllocate):
- assembler/X86Assembler.h:
(JSC::X86Assembler::buffer):
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
- 5:24 PM Changeset in webkit [157689] by
-
- 1 edit2 adds in trunk/LayoutTests
Adding test case for text-decoration property state change on applying different command
https://bugs.webkit.org/show_bug.cgi?id=123073
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-19
Reviewed by Ryosuke Niwa.
This test case verify text-decoration property state on element after
applying editing commands related to text-decoration.
- editing/style/text-decoration-state-change-expected.txt: Added.
- editing/style/text-decoration-state-change.html: Added.
- 5:01 PM Changeset in webkit [157688] by
-
- 8 edits in trunk/Source/JavaScriptCore
Some includes in JSC seem to use an incorrect style
https://bugs.webkit.org/show_bug.cgi?id=123057
Reviewed by Geoffrey Garen.
Changed pseudo-system includes to user ones.
- API/JSContextRef.cpp:
- API/JSStringRefCF.cpp:
- API/JSValueRef.cpp:
- API/OpaqueJSString.cpp:
- jit/JIT.h:
- parser/SyntaxChecker.h:
- runtime/WeakGCMap.h:
- 4:38 PM Changeset in webkit [157687] by
-
- 3 edits in trunk/Tools
run-webkit-tests should submit time and modifiers to the new flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123070
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
in the test expectations when this argument is set to true.
- 4:18 PM Changeset in webkit [157686] by
-
- 3 edits in trunk/Tools
Mac DumpRenderTree builds without NDEBUG even in release mode
https://bugs.webkit.org/show_bug.cgi?id=123066
Reviewed by Dan Bernstein.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
Use the same pattern as WebCore and WebKitTestRunner.
- 4:13 PM Changeset in webkit [157685] by
-
- 18 edits4 adds in trunk/Source/JavaScriptCore
Baseline JIT and DFG IC code generation should be unified and rationalized
https://bugs.webkit.org/show_bug.cgi?id=122939
Reviewed by Geoffrey Garen.
Introduce the JITInlineCacheGenerator, which takes a CodeBlock and a CodeOrigin plus
some register info and creates JIT inline caches for you. Used this to even furhter
unify the baseline and DFG ICs. In the future we can use this for FTL ICs. And my hope
is that we'll be able to use it for cascading ICs: an IC for some instruction may realize
that it needs to do the equivalent of get_by_id, so with this generator it will be able
to create an IC even though it wasn't associated with a get_by_id bytecode instruction.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::DataLabelCompact::label):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::ecmaMode):
- dfg/DFGInlineCacheWrapper.h: Added.
(JSC::DFG::InlineCacheWrapper::InlineCacheWrapper):
- dfg/DFGInlineCacheWrapperInlines.h: Added.
(JSC::DFG::::finalize):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addGetById):
(JSC::DFG::JITCompiler::addPutById):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::isStrictModeFor):
(JSC::AssemblyHelpers::strictModeFor):
- jit/GPRInfo.h:
(JSC::JSValueRegs::tagGPR):
- jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITInlineCacheGenerator.cpp: Added.
(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITByIdGenerator::finalize):
(JSC::JITByIdGenerator::generateFastPathChecks):
(JSC::JITGetByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::slowPathFunction):
- jit/JITInlineCacheGenerator.h: Added.
(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
(JSC::JITInlineCacheGenerator::stubInfo):
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITByIdGenerator::reportSlowPathCall):
(JSC::JITByIdGenerator::slowPathJump):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
- jit/RegisterSet.h:
(JSC::RegisterSet::set):
- 2:56 PM Changeset in webkit [157684] by
-
- 2 edits in trunk/Source/JavaScriptCore
APICast.h uses functions from JSCJSValueInlines.h, but doesn't include it
https://bugs.webkit.org/show_bug.cgi?id=123067
Reviewed by Geoffrey Garen.
- API/APICast.h: Include it.
- 2:43 PM Changeset in webkit [157683] by
-
- 20 edits in trunk/Source/WebCore
Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 4)
https://bugs.webkit.org/show_bug.cgi?id=122969
Reviewed by Andreas Kling.
- Fix classes derived from RenderBlockFlow that were still calling up to RenderBlock rather than RenderBlockFlow.
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::paint):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::computePreferredLogicalWidths):
(WebCore::RenderFieldset::paintBoxDecorations):
(WebCore::RenderFieldset::paintMask):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::styleDidChange):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::nodeAtPoint):
- rendering/RenderFullScreen.cpp:
(RenderFullScreenPlaceholder::willBeDestroyed):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::styleDidChange):
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::styleDidChange):
(WebCore::RenderMultiColumnBlock::updateLogicalWidthAndColumnWidth):
(WebCore::RenderMultiColumnBlock::addChild):
- rendering/RenderProgress.cpp:
(WebCore::RenderProgress::updateFromElement):
- rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsBlock::styleDidChange):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::rubyBaseSafe):
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
(WebCore::RenderRubyRun::layout):
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::textAlignmentForLine):
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds):
- rendering/RenderTableCaption.cpp:
(WebCore::RenderTableCaption::willBeRemovedFromTree):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::willBeRemovedFromTree):
(WebCore::RenderTableCell::computePreferredLogicalWidths):
(WebCore::RenderTableCell::offsetFromContainer):
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
(WebCore::RenderTableCell::styleDidChange):
(WebCore::RenderTableCell::borderLeft):
(WebCore::RenderTableCell::borderRight):
(WebCore::RenderTableCell::borderTop):
(WebCore::RenderTableCell::borderBottom):
(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):
(WebCore::RenderTableCell::paint):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::styleDidChange):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::layout):
- rendering/RenderView.cpp:
(WebCore::RenderView::layoutContent):
(WebCore::RenderView::addChild):
(WebCore::RenderView::visualOverflowRect):
(WebCore::RenderView::styleDidChange):
- rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::setStyle):
(WebCore::RenderSVGBlock::updateFromStyle):
(WebCore::RenderSVGBlock::willBeDestroyed):
(WebCore::RenderSVGBlock::styleWillChange):
(WebCore::RenderSVGBlock::styleDidChange):
- rendering/svg/SVGTextQuery.cpp:
(WebCore::flowBoxForRenderer):
- 2:25 PM Changeset in webkit [157682] by
-
- 24 edits3 adds in trunk/Tools
REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
https://bugs.webkit.org/show_bug.cgi?id=123064
Reviewed by Ryosuke Niwa.
Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
- Scripts/webkitpy/common/config/ports.py: Added.
(DeprecatedPort):
(DeprecatedPort.name):
(DeprecatedPort.flag):
(DeprecatedPort.script_path):
(DeprecatedPort.script_shell_command):
(DeprecatedPort.port):
(DeprecatedPort.makeArgs):
(DeprecatedPort.update_webkit_command):
(DeprecatedPort.check_webkit_style_command):
(DeprecatedPort.prepare_changelog_command):
(DeprecatedPort.build_webkit_command):
(DeprecatedPort.run_javascriptcore_tests_command):
(DeprecatedPort.run_webkit_unit_tests_command):
(DeprecatedPort.run_webkit_tests_command):
(DeprecatedPort.run_python_unittests_command):
(DeprecatedPort.run_perl_unittests_command):
(DeprecatedPort.run_bindings_tests_command):
(MacPort):
(MacWK2Port):
(MacWK2Port.run_webkit_tests_command):
(WinPort):
(WinPort.run_bindings_tests_command):
(GtkPort):
(GtkPort.build_webkit_command):
(GtkPort.run_webkit_tests_command):
(GtkWK2Port):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port.run_webkit_tests_command):
(QtPort):
(QtPort.build_webkit_command):
(QtPort.run_webkit_tests_command):
(QtWK2Port):
(QtWK2Port.build_webkit_command):
(QtWK2Port.run_webkit_tests_command):
(EflPort):
(EflPort.build_webkit_command):
(EflWK2Port):
(EflWK2Port.build_webkit_command):
- Scripts/webkitpy/common/config/ports_mock.py: Added.
(MockPort):
(MockPort.name):
(MockPort.check_webkit_style_command):
(MockPort.update_webkit_command):
(MockPort.build_webkit_command):
(MockPort.prepare_changelog_command):
(MockPort.run_python_unittests_command):
(MockPort.run_perl_unittests_command):
(MockPort.run_javascriptcore_tests_command):
(MockPort.run_webkit_unit_tests_command):
(MockPort.run_webkit_tests_command):
(MockPort.run_bindings_tests_command):
- Scripts/webkitpy/common/config/ports_unittest.py: Added.
(DeprecatedPortTest):
(DeprecatedPortTest.test_mac_port):
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_gtk_wk2_port):
(DeprecatedPortTest.test_efl_port):
(DeprecatedPortTest.test_qt_port):
(DeprecatedPortTest.test_qt_wk2_port):
- Scripts/webkitpy/port/base.py:
(Port._port_flag_for_scripts):
(Port._wk2_port_name):
- Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_build_path):
- Scripts/webkitpy/port/efl_unittest.py:
(EflPortTest.test_show_results_html_file):
- Scripts/webkitpy/port/gtk_unittest.py:
(GtkPortTest.test_get_crash_log):
- Scripts/webkitpy/port/mac_unittest.py:
(test_64bit):
- Scripts/webkitpy/port/test.py:
(TestPort.virtual_test_suites):
- Scripts/webkitpy/tool/bot/flakytestreporter.py:
(FlakyTestReporter.init):
- Scripts/webkitpy/tool/bot/irc_command.py:
(Rollout._update_working_copy):
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.run_command):
- Scripts/webkitpy/tool/commands/queues.py:
(PatchProcessingQueue.begin_work_queue):
(CommitQueue.run_command):
- Scripts/webkitpy/tool/main.py:
(WebKitPatch.init):
(WebKitPatch.deprecated_port):
(WebKitPatch.handle_global_options):
- Scripts/webkitpy/tool/mocktool.py:
(MockTool.init):
(MockTool.deprecated_port):
- Scripts/webkitpy/tool/steps/build.py:
(Build.build):
- Scripts/webkitpy/tool/steps/checkstyle.py:
(CheckStyle.run):
- Scripts/webkitpy/tool/steps/commit.py:
(Commit._check_test_expectations):
- Scripts/webkitpy/tool/steps/preparechangelog.py:
(PrepareChangeLog.run):
- Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
(PrepareChangeLogForRevert.run):
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):
- Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest.test_runtests_args):
- Scripts/webkitpy/tool/steps/update.py:
(Update._update_command):
- Scripts/webkitpy/tool/steps/update_unittest.py:
(UpdateTest.test_update_command_non_interactive):
(UpdateTest.test_update_command_interactive):
- 2:09 PM Changeset in webkit [157681] by
-
- 20 edits in trunk/Source/WebKit2
Fix the Mac 32-bit build by reverting r157676, r157678, and r157679.
- 2:03 PM Changeset in webkit [157680] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL::Location should treat the offset as an addend in the case of a Register location
https://bugs.webkit.org/show_bug.cgi?id=123062
Reviewed by Sam Weinig.
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::forStackmaps):
(JSC::FTL::Location::dump):
(JSC::FTL::Location::restoreInto):
- ftl/FTLLocation.h:
(JSC::FTL::Location::forRegister):
(JSC::FTL::Location::hasAddend):
(JSC::FTL::Location::addend):
- 1:56 PM Changeset in webkit [157679] by
-
- 3 edits in trunk/Source/WebKit2
Try to fix the Mac 32-bit build.
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
- 1:47 PM Changeset in webkit [157678] by
-
- 5 edits in trunk/Source/WebKit2
Try to fix the Mac 32-bit build.
- UIProcess/API/mac/WKView.h:
- UIProcess/API/mac/WKView.mm:
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/API/mac/WKViewPrivate.h:
- 1:26 PM Changeset in webkit [157677] by
-
- 6 edits in trunk/Source/WebCore
Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=122969
Reviewed by Andreas Kling.
- Move containsNonZeroBidiLevel to RenderBlockFlow.
- editing/Editor.cpp:
(WebCore::Editor::hasBidiSelection):
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::containsNonZeroBidiLevel):
- rendering/RenderBlockFlow.h:
- 1:18 PM Changeset in webkit [157676] by
-
- 14 edits in trunk/Source/WebKit2
[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime
https://bugs.webkit.org/show_bug.cgi?id=123065
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKBrowsingContextController.h: Added WK_API_ENABLED guard. Removed _data
ivar and WKBrowsingContextControllerData class declaration.
- UIProcess/API/mac/WKBrowsingContextController.mm: Added WK_API_ENABLED guard. Removed
WKBrowsingContextControllerData class and moved _pageRef ivar directly into
WKBrowsingContextController, declaring it in the @implementation. Removed ivar and accessors
for the loadDelegate property, letting the compiler synthesize them.
(-[WKBrowsingContextController dealloc]): Removed indirection via _data.
(-[WKBrowsingContextController _pageRef]): Ditto.
(-[WKBrowsingContextController loadRequest:userData:]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]): Ditto.
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
Ditto.
(-[WKBrowsingContextController stopLoading]): Ditto.
(-[WKBrowsingContextController reload]): Ditto.
(-[WKBrowsingContextController reloadFromOrigin]): Ditto.
(-[WKBrowsingContextController goForward]): Ditto.
(-[WKBrowsingContextController canGoForward]): Ditto.
(-[WKBrowsingContextController goBack]): Ditto.
(-[WKBrowsingContextController canGoBack]): Ditto.
(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController title]): Ditto.
(-[WKBrowsingContextController textZoom]): Ditto.
(-[WKBrowsingContextController setTextZoom:]): Ditto.
(-[WKBrowsingContextController pageZoom]): Ditto.
(-[WKBrowsingContextController setPageZoom:]): Ditto.
(-[WKBrowsingContextController setPaginationMode:]): Ditto.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Ditto.
(-[WKBrowsingContextController paginationBehavesLikeColumns]): Ditto.
(-[WKBrowsingContextController setPageLength:]): Ditto.
(-[WKBrowsingContextController pageLength]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.
(-[WKBrowsingContextController _initWithPageRef:]): Removed indirection via _data.
- UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Added WK_API_ENABLED guard.
- UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Ditto.
- UIProcess/API/mac/WKBrowsingContextGroup.h: Added WK_API_ENABLED guard. Removed _data ivar
and WKBrowsingContextGroupData class declaration.
- UIProcess/API/mac/WKBrowsingContextGroup.mm: Added WK_API_ENABLED guard. Removed
WKBrowsingContextGroupData class and moved _pageGroupRef ivar directly info
WKBrowsingContextGroup, declaring it in the @implementation.
(-[WKBrowsingContextGroup initWithIdentifier:]): Removed indirection via _data.
(-[WKBrowsingContextGroup _pageGroupRef]): Ditto.
- UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Added WK_API_ENABLED guard.
- UIProcess/API/mac/WKConnection.h: Added WK_API_ENABLED guard. Removed _data ivar and
WKConnectionData class declaration.
- UIProcess/API/mac/WKConnection.mm: Added WK_API_ENABLED guard. Removed WKConnectionData
class and moved _connectionRef ivar directly into WKConnection, declaring it in the
@implementation. Removed ivar and accessors for the delegate property, letting the compiler
synthesize them.
(-[WKConnection dealloc]): Removed indirection via _data.
(-[WKConnection sendMessageWithName:body:]): Ditto.
(-[WKConnection _initWithConnectionRef:]): Ditto.
- UIProcess/API/mac/WKConnectionInternal.h: Added WK_API_ENABLED guard.
- UIProcess/API/mac/WKProcessGroup.h: Added WK_API_ENABLED guard. Replaced forward
declaration of WKConnection with an import. Removed _data ivar and WKProcessGroupData class
declaration.
- UIProcess/API/mac/WKProcessGroup.mm: Added WK_API_ENABLED guard. Removed
WKProcessGroupData class and moved _contextRef ivar directly into WKProcessGroup, declaring
it in the @implementation. Removed ivar and accessors for the delegate property, letting the
compiler synthesize them.
(-[WKProcessGroup initWithInjectedBundleURL:]): Removed indirection via _data.
(-[WKProcessGroup dealloc]): Ditto.
(-[WKProcessGroup _contextRef]): Ditto.
- UIProcess/API/mac/WKProcessGroupPrivate.h: Added WK_API_ENABLED guard.
- 1:11 PM Changeset in webkit [157675] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG dominators: document and rename stuff.
https://bugs.webkit.org/show_bug.cgi?id=123056
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-19
Reviewed by Filip Pizlo.
Documented the code and renamed some variables.
- dfg/DFGDominators.cpp:
(JSC::DFG::Dominators::compute):
(JSC::DFG::Dominators::pruneDominators):
- dfg/DFGDominators.h:
- 12:55 PM Changeset in webkit [157674] by
-
- 9 edits in trunk/Source/WebCore
Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=122969
Reviewed by Antti Koivisto.
- Move truncation (e.g. line clamp and ellipse) support to RenderBlockFlow.
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::EllipsisBox):
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::markupBox):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):
- rendering/EllipsisBox.h:
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::shouldCheckLines):
(WebCore::RenderBlockFlow::lineAtIndex):
(WebCore::RenderBlockFlow::lineCount):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlockFlow::heightForLineCount):
(WebCore::RenderBlockFlow::clearTruncation):
- rendering/RenderBlockFlow.h:
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::placeEllipsis):
- 12:55 PM Changeset in webkit [157673] by
-
- 4 edits in trunk
RefPtr::releaseNonNull() incorrectly increments the refcount.
<https://webkit.org/b/123063>
Source/WTF:
Make releaseNonNull() use adoptRef(T&), mirroring release().
Reviewed by Anders Carlsson.
Tools:
Add an API test to verify that no extra refs are added when calling
RefPtr::releaseNonNull().
Reviewed by Anders Carlsson.
- 9:48 AM Changeset in webkit [157672] by
-
- 4 edits in trunk/Source/WebCore
StyleResolver should deal in PassRef<RenderStyle> where possible.
<https://webkit.org/b/123061>
Make StyleResolver functions that returned or took RenderStyles
by PassRefPtr use PassRef instead where possible.
Reviewed by Anders Carlsson.
- 9:41 AM Changeset in webkit [157671] by
-
- 16 edits in trunk/Source/WebCore
Global rename of the class "IDBBackingStore" to "IDBBackingStoreLevelDB"
Rubberstamped by Anders Carlsson (And Andreas Kling wanted to, but he wasn’t around)
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:
- 9:41 AM Changeset in webkit [157670] by
-
- 1 edit2 copies1 add1 delete in trunk/LayoutTests
WebAudio Mac expected results were misplaced - they apply equally to WK1 and WK2.
We didn't notice before because all these tests are disabled on WK1.
- platform/mac-wk2/webaudio: Removed.
- platform/mac/webaudio: Added.
- platform/mac/webaudio/audiobuffersource-playbackrate-expected.wav: Copied from LayoutTests/platform/mac-wk2/webaudio/audiobuffersource-playbackrate-expected.wav.
- platform/mac/webaudio/codec-tests: Copied from LayoutTests/platform/mac-wk2/webaudio/codec-tests.
- platform/mac-wk2/webaudio/audiobuffersource-loop-points-expected.wav: Removed.
This test is skipped, because it times out.
- 7:42 AM Changeset in webkit [157669] by
-
- 3 edits1 add in trunk/Source/WebCore
[WinCairo] Link fails.
https://bugs.webkit.org/show_bug.cgi?id=123019
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-19
Reviewed by Darin Adler.
Added empty CertificateInfo implementation for Curl.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- platform/network/curl/CertificateInfoCurl.cpp: Added.
(WebCore::CertificateInfo::CertificateInfo):
(WebCore::CertificateInfo::~CertificateInfo):
- 7:34 AM Changeset in webkit [157668] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix build failure for architectures with 4 argument registers.
https://bugs.webkit.org/show_bug.cgi?id=123060
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-19
Reviewed by Michael Saboff.
Add missing setupArgumentsWithExecState() prototypes for architecture with 4 argument registers.
Remove SH4 specific code no longer needed since callOperation prototype change in r157660.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- 7:33 AM Changeset in webkit [157667] by
-
- 3 edits in trunk/Source/WebCore
libWebCoreTestSupport should have explicit exports
https://bugs.webkit.org/show_bug.cgi?id=123053
Reviewed by Oliver Hunt.
No new tests because there is no change in behavior.
- Configurations/WebCoreTestSupport.xcconfig:
- testing/js/WebCoreTestSupport.h:
- 7:26 AM Changeset in webkit [157666] by
-
- 4 edits in trunk/Source
Attempt to get Lion building.
Source/WebKit/mac:
- WebView/WebDataSource.mm:
Source/WebKit2:
- UIProcess/mac/WebColorPickerMac.h:
- 6:58 AM Changeset in webkit [157665] by
-
- 48 edits in trunk/Source
Start passing RenderStyle around with PassRef.
<https://webkit.org/b/123051>
Source/WebCore:
Made the RenderStyle::create methods return PassRef<RenderStyle>
and RenderElement::setStyle take a PassRef<RenderStyle>.
Reviewed by Darin Adler.
Source/WTF:
Added some new PassRef tricks to make this patch possible.
Reviewed by Darin Adler.
- wtf/PassRef.h:
(WTF::PassRef::get):
Added a get() helper to facilitate writing functions that
construct a new object and call some functions on it before
returning it.
(WTF::PassRef::dropRef):
This will deref() the referenced object and mark the PassRef
as "passed." This is used in code paths where the PassRef is
going to go out of scope with nobody to take it over.
(WTF::PassRef::leakRef):
Renamed takeReference() to leakRef() and made it public so
we don't have to awkwardly sink the PassRef into a Ref for
e.g static locals.
- wtf/RefPtr.h:
(WTF::RefPtr::releaseNonNull):
Added RefPtr::releaseNonNull() for a convenient way of creating
a PassRef<T> from a RefPtr<T>. This function may only be called
if the RefPtr is known to be non-null.
Oct 18, 2013:
- 11:47 PM Changeset in webkit [157664] by
-
- 3 edits5 deletes in trunk/LayoutTests
Unreviewed EFL gardening.
Remove EFL-specific test expectations that were identical to generic expectations
and rebaseline test cases.
- platform/efl-wk2/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
- platform/efl-wk2/compositing/overflow/content-loses-scrollbars-expected.txt: Removed.
- platform/efl/compositing/backing/no-backing-for-clip-overhang-expected.txt: Removed.
- platform/efl/compositing/contents-opaque/hidden-with-visible-child-expected.txt: Removed.
- platform/efl/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Rebaselined after r154896.
- platform/efl/svg/batik/paints/gradientLimit-expected.txt: Updating baselines after enabling the subpixel layout.
- 9:28 PM Changeset in webkit [157663] by
-
- 2 edits in trunk/LayoutTests
Update EFL test expectations.
- platform/efl/TestExpectations:
- 8:14 PM Changeset in webkit [157662] by
-
- 17 edits in trunk/Source/WebCore
Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=122969
Reviewed by Dan Bernstein.
- Make the RootInlineBox constructor take a RenderBlockFlow.
- Move createRootInlineBox, and createAndAppendRootInlineBox to RenderBlockFlow.
- editing/VisibleUnits.cpp:
(WebCore::absoluteLineDirectionPointToLocalPointInBlock):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::locationIncludingFlipping):
(WebCore::InlineBox::flipForWritingMode):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::createRootInlineBox):
(WebCore::RenderBlockFlow::createAndAppendRootInlineBox):
(WebCore::createInlineBoxForRenderer):
(WebCore::RenderBlockFlow::createLineBoxes):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::positionLineBox):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::localSelectionRect):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::localSelectionRect):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::rendererLineBoxes):
(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::setContainingRegion):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
(WebCore::RootInlineBox::lineSnapAdjustment):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::computeCaretRect):
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):
(WebCore::RootInlineBox::selectionBottom):
(WebCore::RootInlineBox::blockDirectionPointInLine):
(WebCore::RootInlineBox::blockFlow):
(WebCore::RootInlineBox::closestLeafChildForPoint):
(WebCore::RootInlineBox::removeLineBoxFromRenderObject):
(WebCore::RootInlineBox::extractLineBoxFromRenderObject):
(WebCore::RootInlineBox::attachLineBoxToRenderObject):
- rendering/RootInlineBox.h:
- rendering/TrailingFloatsRootInlineBox.h:
- rendering/svg/RenderSVGText.h:
(WebCore::toRenderSVGText):
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::renderSVGText):
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutRootBox):
- rendering/svg/SVGRootInlineBox.h:
- 7:37 PM Changeset in webkit [157661] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, fix FTL build.
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetById):
- 7:20 PM Changeset in webkit [157660] by
-
- 30 edits1 add in trunk/Source
A CodeBlock's StructureStubInfos shouldn't be in a Vector that we search using code origins and machine code PCs
https://bugs.webkit.org/show_bug.cgi?id=122940
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This accomplishes a number of simplifications. StructureStubInfo is now non-moving,
whereas previously it was in a Vector, so it moved. This allows you to use pointers to
StructureStubInfo. This also eliminates the use of return PC as a way of finding the
StructureStubInfo's. It removes some of the need for the compile-time property access
records; for example the DFG no longer has to save information about registers in a
property access record only to later save it to the stub info.
The main thing is accomplishes is that it makes it easier to add StructureStubInfo's
at any stage of compilation.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::addStubInfo):
(JSC::CodeBlock::getStubInfoMap):
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::begin):
(JSC::CodeBlock::end):
(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):
- bytecode/CodeOrigin.h:
(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isHashTableDeletedValue):
(JSC::CodeOrigin::hash):
(JSC::CodeOriginHash::hash):
(JSC::CodeOriginHash::equal):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdStatus.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h:
- bytecode/StructureStubInfo.h:
(JSC::getStructureStubInfoCodeOrigin):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(JSC::DFG::InRecord::InRecord):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIn):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::PropertyStubCompilationInfo::slowCaseInfo):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
- jit/Repatch.cpp:
(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateListBuildingPutByIdFunction):
(JSC::resetPutByID):
Source/WTF:
Reviewed by Oliver Hunt.
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/BagToHashMap.h: Added.
(WTF::toHashMap):
- wtf/CMakeLists.txt:
- 6:47 PM Changeset in webkit [157659] by
-
- 4 edits4 adds in trunk/Websites/test-results
New flakiness dashboard should support showing the failing tests per builder
https://bugs.webkit.org/show_bug.cgi?id=123011
Reviewed by Timothy Hatcher.
Added the feature. Also did some refactoring to add this feature.
- ChangeLog: Added.
- api/failing-tests.php: Added.
- api/manifest.php: Removed the code to make maps by id. The work is now done in index.html.
- api/results.php:
- common.css: Added. Extracted from index.html.
- include/test-results.php: Extracted parse_revisions_array and format_result_rows from results.php.
- index.html:
- main.css: Added.
(TestResultsView.setAvailableTests): Added.
(TestResultsView.showTooltip): Fixed the code to compute x and y coordinates of the tooltip to take
scrolled positions into account.
(TestResultsView._createTestResultRow): Extracted from _populateTestPane.
(TestResultsView.fetchTest): Added the code to show "Loading..." in the pane while loading the JSON.
(TestResultsView.fetchTests): Respect the doNotUpdateHash flag.
(TestResultsView._populateBuilderPane): Added.
(TestResultsView.fetchFailingTestsForBuilder): Added.
(TestResultsView.updateLocationHash): Serialize builder & builderDays.
(TestResultsView.locationHashChanged): Don't delete existing test panes since that's now done in
loadTestsFromLocationHash.
(TestResultsView.loadTestsFromLocationHash): Take care of both 'tests' and 'builder' components.
(fetchManifest): Setup the UI to select a builder.
- 5:51 PM Changeset in webkit [157658] by
-
- 9 edits in trunk/Source
Remote Layer Tree: Double-buffering and minimization of repaints
https://bugs.webkit.org/show_bug.cgi?id=123043
Reviewed by Simon Fraser.
No new tests, not yet testable.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::ensureBackingStore):
Don't worry about isOpaque with RemoteLayerBackingStore; this is a
optimization that is causing trouble; we can re-add it later.
(PlatformCALayerRemote::setBounds):
Make sure that we will repaint if our bounds change.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.h:
(WebKit::RemoteLayerBackingStore::bitmap):
Keep a front and back buffer; return the front buffer when being asked for the bitmap.
Keep a Region of repaint areas.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
Serialize only the front buffer, since the UI process only needs that.
(RemoteLayerBackingStore::setNeedsDisplay):
Store repaint rects instead of always setting the whole layer to be dirty.
(RemoteLayerBackingStore::display):
Paint into the back buffer (copying valid parts over from the front buffer),
then swap it to the front buffer. Use drawLayerContents so we get repaint counters, etc.
- WebCore.exp.in:
Export one version of drawLayerContents and Region::contains.
- WebCore.xcodeproj/project.pbxproj:
Expose WebLayer.h as a private header.
- platform/graphics/mac/WebLayer.h:
Clean up this header, and add a new drawLayerContents that can operate without a CALayer.
- platform/graphics/mac/WebLayer.mm:
(WebCore::drawLayerContents):
Split drawLayerContents into one method that acquires properties CALayer,
and one that just does the painting.
- 5:46 PM Changeset in webkit [157657] by
-
- 4 edits in trunk/Source
Try to fix the Lion build.
Source/WebCore:
- bindings/objc/ObjCNodeFilterCondition.h:
Source/WebKit2:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
- 5:09 PM Changeset in webkit [157656] by
-
- 36 edits in trunk
Spread operator should be performing direct "puts" and not triggering setters
https://bugs.webkit.org/show_bug.cgi?id=123047
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Add a new opcode -- op_put_by_val_directue -- and make use of it in the spread
to array construct. This required a new PutByValDirect node to be introduced to
the DFG. The current implementation simply changes the slow path function that
is called, but in future this could be made faster as it does not need to check
the prototype chain.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDirectPutByVal):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::clobbersWorld):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasArrayMode):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
(JSC::DFG::putByVal):
(JSC::DFG::operationPutByValInternal):
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
(JSC::JIT::compileDirectPutByVal):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::privateCompilePutByVal):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_put_by_val):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
LayoutTests:
Add a new testcase for the setter case. run-javascriptcore-tests hits this with
the llint, baseline, and dfg.
- js/basic-spread-expected.txt:
- js/script-tests/basic-spread.js:
(Array):
- 5:05 PM Changeset in webkit [157655] by
-
- 2 edits in trunk/Source/JavaScriptCore
[iOS] Export symbol for VM::sharedInstanceExists()
https://bugs.webkit.org/show_bug.cgi?id=123046
Reviewed by Mark Hahnenberg.
- runtime/VM.h:
- 4:57 PM Changeset in webkit [157654] by
-
- 8 edits2 adds in trunk/Source
[iOS] Upstream WebSafe{GCActivityCallback, IncrementalSweeper}IOS
https://bugs.webkit.org/show_bug.cgi?id=123049
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- heap/Heap.cpp:
(JSC::Heap::setIncrementalSweeper):
- heap/Heap.h:
- heap/HeapTimer.h:
- heap/IncrementalSweeper.h: Make protected and export CF-variant of constructor.
Removed unused include of header RetainPtr.h. Also forward declare class MarkedBlock
(we include its header in the .cpp file) and remove include for header wtf/HashSet.h
(duplicates the include in the .cpp).
- heap/MachineStackMarker.h: Export function makeUsableFromMultipleThreads(). We aren't
making use of this now, but we'll make use of it in a subsequent patch.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- platform/ios/WebSafeGCActivityCallbackIOS.h: Added.
- platform/ios/WebSafeIncrementalSweeperIOS.h: Added.
- 4:41 PM Changeset in webkit [157653] by
-
- 573 edits in trunk/Source
Remove spaces between template angle brackets
https://bugs.webkit.org/show_bug.cgi?id=123040
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- API/JSCallbackObject.cpp:
(JSC::::create):
- API/JSObjectRef.cpp:
- bytecode/CodeBlock.h:
(JSC::CodeBlock::constants):
(JSC::CodeBlock::setConstantRegisters):
- bytecode/DFGExitProfile.h:
- bytecode/EvalCodeCache.h:
- bytecode/Operands.h:
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::constantRegisters):
- bytecode/Watchpoint.h:
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/StaticPropertyAnalysis.h:
- bytecompiler/StaticPropertyAnalyzer.h:
- dfg/DFGArgumentsSimplificationPhase.cpp:
- dfg/DFGBlockInsertionSet.h:
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::performCSE):
(JSC::DFG::performStoreElimination):
- dfg/DFGCommonData.h:
- dfg/DFGDesiredStructureChains.h:
- dfg/DFGDesiredWatchpoints.h:
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGWorklist.h:
- heap/BlockAllocator.h:
(JSC::CopiedBlock):
(JSC::MarkedBlock):
(JSC::WeakBlock):
(JSC::MarkStackSegment):
(JSC::CopyWorkListSegment):
(JSC::HandleBlock):
- heap/Heap.h:
- heap/Local.h:
- heap/MarkedBlock.h:
- heap/Strong.h:
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::decodedCodeMapFor):
- jit/AssemblyHelpers.h:
- jit/SpecializedThunkJIT.h:
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::::parseIfStatement):
- parser/Parser.h:
(JSC::Scope::copyCapturedVariablesToVector):
(JSC::parse):
- parser/ParserArena.h:
- parser/SourceProviderCacheItem.h:
- profiler/LegacyProfiler.cpp:
(JSC::dispatchFunctionToProfiles):
- profiler/LegacyProfiler.h:
(JSC::LegacyProfiler::currentProfiles):
- profiler/ProfileNode.h:
(JSC::ProfileNode::children):
- profiler/ProfilerDatabase.h:
- runtime/Butterfly.h:
(JSC::Butterfly::contiguousInt32):
(JSC::Butterfly::contiguous):
- runtime/GenericTypedArrayViewInlines.h:
(JSC::::create):
- runtime/Identifier.h:
(JSC::Identifier::add):
- runtime/JSPromise.h:
- runtime/PropertyMapHashTable.h:
- runtime/PropertyNameArray.h:
- runtime/RegExpCache.h:
- runtime/SparseArrayValueMap.h:
- runtime/SymbolTable.h:
- runtime/VM.h:
- tools/CodeProfile.cpp:
(JSC::truncateTrace):
- tools/CodeProfile.h:
- yarr/YarrInterpreter.cpp:
- yarr/YarrInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileBody):
- yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):
- yarr/YarrPattern.h:
Source/WebCore:
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/encryptedmedia/MediaKeys.h:
- Modules/geolocation/Geolocation.h:
- Modules/geolocation/GeolocationController.cpp:
(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):
- Modules/geolocation/GeolocationController.h:
- Modules/indexeddb/IDBCallbacks.h:
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
- Modules/indexeddb/IDBEventDispatcher.cpp:
(WebCore::IDBEventDispatcher::dispatch):
- Modules/indexeddb/IDBEventDispatcher.h:
- Modules/indexeddb/IDBKey.h:
- Modules/indexeddb/IDBObjectStore.h:
- Modules/indexeddb/IDBPendingTransactionMonitor.cpp:
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
- Modules/indexeddb/IDBRequest.h:
(WebCore::IDBRequest::onSuccessWithPrefetch):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::dispatchEvent):
- Modules/indexeddb/IDBTransaction.h:
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::sortedTrackListForMenu):
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::activeRanges):
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/MediaSourceBase.cpp:
(WebCore::MediaSourceBase::buffered):
- Modules/mediasource/MediaSourceBase.h:
- Modules/mediasource/MediaSourceRegistry.cpp:
(WebCore::MediaSourceRegistry::unregisterURL):
- Modules/mediasource/MediaSourceRegistry.h:
- Modules/mediasource/SourceBufferList.h:
- Modules/mediasource/WebKitMediaSource.cpp:
(WebCore::WebKitMediaSource::activeRanges):
- Modules/mediasource/WebKitMediaSource.h:
- Modules/mediasource/WebKitSourceBufferList.h:
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::scheduledEventTimerFired):
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamRegistry.h:
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/RTCDTMFSender.cpp:
(WebCore::RTCDTMFSender::scheduledEventTimerFired):
- Modules/mediastream/RTCDTMFSender.h:
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::scheduledEventTimerFired):
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/RTCStatsResponse.h:
(WebCore::RTCStatsResponse::result):
- Modules/notifications/Notification.h:
- Modules/notifications/NotificationCenter.h:
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::getVoices):
- Modules/speech/SpeechSynthesis.h:
- Modules/webaudio/AudioBuffer.h:
- Modules/webaudio/AudioNode.h:
- Modules/webaudio/AudioNodeOutput.h:
- Modules/webaudio/MediaStreamAudioSource.cpp:
(WebCore::MediaStreamAudioSource::setAudioFormat):
(WebCore::MediaStreamAudioSource::consumeAudio):
- Modules/webaudio/PeriodicWave.h:
- Modules/webaudio/ScriptProcessorNode.h:
- Modules/webdatabase/AbstractDatabaseServer.h:
- Modules/webdatabase/DatabaseBackend.h:
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::origins):
- Modules/webdatabase/DatabaseManager.h:
- Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::origins):
- Modules/webdatabase/DatabaseServer.h:
- Modules/webdatabase/DatabaseThread.h:
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteAllDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):
- Modules/webdatabase/DatabaseTracker.h:
- Modules/webdatabase/SQLStatementBackend.cpp:
- Modules/webdatabase/SQLTransactionBackend.cpp:
- Modules/webdatabase/SQLTransactionBackend.h:
- Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::SQLTransactionCoordinator::shutdown):
- Modules/webdatabase/SQLTransactionCoordinator.h:
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveBinaryData):
- Modules/websockets/WebSocket.h:
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processFrame):
- Modules/websockets/WebSocketChannel.h:
- Modules/websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::didReceiveBinaryData):
- Modules/websockets/WebSocketExtensionDispatcher.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::workerGlobalScopeDidReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::~AXObjectCache):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::ariaLabeledByText):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityText::AccessibilityText):
- bindings/js/DOMWrapperWorld.h:
- bindings/js/JSDOMBinding.h:
(WebCore::toRefPtrNativeArray):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::call):
- bindings/js/JSMutationCallback.h:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
- bindings/js/PageScriptDebugServer.h:
- bindings/js/ScheduledAction.h:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::collectIsolatedContexts):
- bindings/js/ScriptController.h:
- bindings/js/ScriptDebugServer.h:
- bindings/js/ScriptProfile.cpp:
(WebCore::buildInspectorObjectFor):
- bindings/objc/ObjCNodeFilterCondition.h:
- bridge/objc/objc_class.h:
- bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::invalidate):
- bridge/runtime_root.h:
- css/BasicShapeFunctions.cpp:
(WebCore::basicShapeForValue):
- css/CSSBasicShapes.h:
(WebCore::CSSBasicShapePolygon::values):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForFilter):
- css/CSSFontFace.h:
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontFace):
(WebCore::CSSFontSelector::beginLoadTimerFired):
- css/CSSFontSelector.h:
- css/CSSGroupingRule.h:
- css/CSSImageGeneratorValue.h:
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::adoptSelectorVector):
- css/CSSParserValues.h:
- css/CSSPropertySourceData.h:
- css/CSSRuleList.h:
(WebCore::StaticCSSRuleList::rules):
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::fontLoaded):
- css/CSSSegmentedFontFace.h:
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::adoptSelectorVector):
- css/CSSSelectorList.h:
- css/CSSStyleSheet.h:
- css/CSSValue.h:
(WebCore::compareCSSValueVector):
- css/CSSValuePool.h:
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::collectRulesFromUserStyleSheets):
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):
- css/DocumentRuleSets.h:
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchedRuleList):
- css/ElementRuleCollector.h:
- css/FontLoader.h:
- css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):
- css/InspectorCSSOMWrappers.h:
- css/MediaList.cpp:
(WebCore::MediaQuerySet::parse):
(WebCore::MediaList::item):
(WebCore::reportMediaQueryWarningIfNeeded):
- css/MediaList.h:
(WebCore::MediaQuerySet::queryVector):
- css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
- css/MediaQueryMatcher.h:
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):
- css/PropertySetCSSStyleDeclaration.h:
- css/RuleSet.cpp:
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addChildRules):
(WebCore::RuleSet::addRulesFromSheet):
- css/RuleSet.h:
- css/SelectorFilter.h:
- css/StyleInvalidationAnalysis.cpp:
(WebCore::StyleInvalidationAnalysis::analyzeStyleSheet):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::styleRulesForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::loadPendingShaders):
- css/StyleResolver.h:
- css/StyleRule.cpp:
(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):
(WebCore::StyleRuleGroup::StyleRuleGroup):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleSupports::StyleRuleSupports):
(WebCore::StyleRuleRegion::StyleRuleRegion):
- css/StyleRule.h:
(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRuleGroup::childRules):
(WebCore::StyleRuleMedia::create):
(WebCore::StyleRuleSupports::create):
(WebCore::StyleRuleRegion::create):
(WebCore::StyleRuleHost::create):
(WebCore::StyleRuleHost::StyleRuleHost):
- css/StyleScopeResolver.h:
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::childRulesHaveFailedOrCanceledSubresources):
- css/StyleSheetContents.h:
(WebCore::StyleSheetContents::childRules):
(WebCore::StyleSheetContents::importRules):
- css/StyleSheetList.cpp:
(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::item):
- css/StyleSheetList.h:
- css/WebKitCSSKeyframesRule.h:
(WebCore::StyleRuleKeyframes::keyframes):
- dom/CheckedRadioButtons.h:
- dom/ClientRectList.h:
- dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::nextNode):
(WebCore::ChildNodesLazySnapshot::takeSnapshot):
- dom/CrossThreadTask.h:
- dom/Document.cpp:
(WebCore::Document::webkitCancelFullScreen):
(WebCore::Document::webkitExitFullscreen):
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::didAssociateFormControlsTimerFired):
- dom/Document.h:
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::removeMarkers):
- dom/DocumentMarkerController.h:
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::injectedUserStyleSheets):
(WebCore::DocumentStyleSheetCollection::injectedAuthorStyleSheets):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::styleSheetsUseRemUnits):
(WebCore::filterEnabledNonemptyCSSStyleSheets):
(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
- dom/DocumentStyleSheetCollection.h:
- dom/Element.cpp:
(WebCore::Element::attrNodeList):
(WebCore::Element::webkitGetRegionFlowRanges):
- dom/Element.h:
- dom/EventListenerMap.h:
- dom/EventSender.h:
(WebCore::EventSender::timerFired):
- dom/IdTargetObserverRegistry.h:
- dom/MutationCallback.h:
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::takeRecords):
(WebCore::MutationObserver::deliver):
(WebCore::MutationObserver::deliverAllMutations):
- dom/MutationObserver.h:
- dom/MutationObserverRegistration.h:
- dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::namedFlows):
- dom/NamedFlowCollection.h:
- dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):
- dom/Node.h:
- dom/NodeRareData.h:
- dom/Range.cpp:
(WebCore::Range::processContents):
(WebCore::Range::processNodes):
(WebCore::Range::processAncestorsAndTheirSiblings):
- dom/Range.h:
- dom/ScopedEventQueue.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::reportException):
- dom/ScriptExecutionContext.h:
- dom/ScriptedAnimationController.h:
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
- editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::removeChildrenInRange):
(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
- editing/CompositeEditCommand.h:
- editing/EditingStyle.cpp:
(WebCore::htmlElementEquivalents):
(WebCore::EditingStyle::conflictsWithImplicitStyleOfElement):
(WebCore::htmlAttributeEquivalents):
(WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes):
(WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes):
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
(WebCore::styleFromMatchedRulesForElement):
- editing/Editor.cpp:
(WebCore::Editor::countMatchesForText):
- editing/Editor.h:
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::getAncestorsInsideBlock):
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
(WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/InsertParagraphSeparatorCommand.h:
- editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doApply):
(WebCore::MergeIdenticalElementsCommand::doUnapply):
- editing/RemoveNodePreservingChildrenCommand.cpp:
(WebCore::RemoveNodePreservingChildrenCommand::doApply):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeUnrenderedNodes):
- editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove):
- editing/SimplifyMarkupCommand.h:
- editing/SpellChecker.h:
- editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::executeApply):
(WebCore::SplitElementCommand::doUnapply):
- editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::executeApply):
(WebCore::WrapContentsInDummySpanCommand::doUnapply):
- editing/mac/AlternativeTextUIController.h:
- fileapi/FileList.h:
- history/BackForwardList.h:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::setRedirectURLs):
- history/HistoryItem.h:
- history/mac/HistoryItemMac.mm:
(WebCore::HistoryItem::setTransientProperty):
- html/FormController.h:
- html/HTMLAnchorElement.cpp:
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::append):
- html/HTMLCollection.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::checkValidity):
- html/HTMLFormControlElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::checkValidity):
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
- html/HTMLFormElement.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::platformTextTracks):
(WebCore::HTMLMediaElement::configureTextTrackGroup):
- html/HTMLMediaElement.h:
- html/HTMLPlugInImageElement.cpp:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setLength):
- html/MediaController.cpp:
(MediaController::asyncEventTimerFired):
- html/MediaController.h:
- html/MediaFragmentURIParser.h:
- html/ValidationMessage.h:
- html/canvas/WebGLFramebuffer.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getAttachedShaders):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLTexture.h:
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
- html/parser/BackgroundHTMLParser.h:
(WebCore::BackgroundHTMLParser::create):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::startBackgroundParser):
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLMetaCharsetParser.h:
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::scan):
(WebCore::TokenPreloadScanner::scanCommon):
- html/parser/HTMLResourcePreloader.h:
- html/parser/XSSAuditor.h:
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::ensureInsertionPointList):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
- html/shadow/ContentDistributor.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
- html/shadow/MediaControlElements.h:
- html/track/InbandGenericTextTrack.h:
- html/track/InbandWebVTTTextTrack.cpp:
(WebCore::InbandWebVTTTextTrack::newCuesParsed):
- html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::newCuesAvailable):
(WebCore::LoadableTextTrack::newRegionsAvailable):
- html/track/TextTrackCueList.h:
- html/track/TextTrackList.cpp:
(TextTrackList::invalidateTrackIndexesAfterTrack):
(TextTrackList::remove):
(TextTrackList::contains):
- html/track/TextTrackList.h:
- html/track/TrackListBase.cpp:
(TrackListBase::asyncEventTimerFired):
- html/track/TrackListBase.h:
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::getNewCues):
(WebCore::WebVTTParser::getNewRegions):
- html/track/WebVTTParser.h:
- inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::lineEndings):
(WebCore::ContentSearchUtils::searchInTextByLines):
- inspector/ContentSearchUtils.h:
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
- inspector/DOMPatchSupport.h:
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::getInternalProperties):
(WebCore::InjectedScript::wrapCallFrames):
- inspector/InjectedScript.h:
- inspector/InjectedScriptHost.h:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::enable):
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorBaseAgent.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::SelectorProfile::toInspectorObject):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
(WebCore::InspectorCSSAgent::buildArrayForRegions):
(WebCore::InspectorCSSAgent::buildObjectForNamedFlow):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::RevalidateStyleAttributeTask::onTimer):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::currentCallFrames):
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorHistory.h:
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderLayerHierarchy):
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getProfileHeaders):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::getProperties):
- inspector/InspectorRuntimeAgent.h:
- inspector/InspectorState.h:
- inspector/InspectorStyleSheet.cpp:
(WebCore::asCSSRuleList):
(WebCore::InspectorStyle::buildArrayForComputedStyle):
(WebCore::InspectorStyle::styleWithProperties):
(WebCore::selectorsFromSource):
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::lineEndings):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheetForInlineStyle::lineEndings):
- inspector/InspectorStyleSheet.h:
- inspector/InspectorValues.cpp:
(WebCore::InspectorArrayBase::writeJSON):
- inspector/InspectorValues.h:
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::reportExecutionContextCreation):
- inspector/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::buildInspectorArray):
- inspector/ScriptCallStack.h:
- loader/CrossOriginPreflightResultCache.h:
- loader/DocumentLoader.cpp:
(WebCore::cancelAll):
(WebCore::setAllDefersLoading):
(WebCore::DocumentLoader::getSubresources):
- loader/DocumentLoader.h:
- loader/FormState.h:
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- loader/ProgressTracker.h:
- loader/ResourceLoadScheduler.h:
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::getNewCues):
(WebCore::TextTrackLoader::getNewRegions):
- loader/TextTrackLoader.h:
- loader/WorkerThreadableLoader.cpp:
(WebCore::workerGlobalScopeDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::removeResource):
(WebCore::ApplicationCache::dump):
- loader/appcache/ApplicationCache.h:
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
- loader/archive/Archive.cpp:
(WebCore::Archive::clearAllSubframeArchives):
(WebCore::Archive::clearAllSubframeArchivesImpl):
- loader/archive/Archive.h:
(WebCore::Archive::subresources):
(WebCore::Archive::subframeArchives):
- loader/archive/ArchiveResourceCollection.cpp:
(WebCore::ArchiveResourceCollection::addAllResources):
- loader/archive/ArchiveResourceCollection.h:
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):
- loader/archive/cf/LegacyWebArchive.h:
- loader/archive/mhtml/MHTMLParser.h:
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.h:
- loader/cache/MemoryCache.h:
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::notifyPendingLoadDecisions):
- loader/icon/IconDatabase.h:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu):
- page/CaptionUserPreferencesMediaAF.h:
- page/ChromeClient.h:
(WebCore::ChromeClient::didAssociateFormControls):
- page/Console.h:
- page/ContentSecurityPolicy.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::getMatchedCSSRules):
- page/DeviceController.cpp:
(WebCore::DeviceController::dispatchDeviceEvent):
(WebCore::DeviceController::fireDeviceEvent):
- page/DeviceController.h:
- page/EditorClient.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::handleTouchEvent):
- page/EventHandler.h:
- page/FrameView.cpp:
(WebCore::FrameView::serviceScriptedAnimations):
- page/Page.cpp:
(WebCore::Page::findStringMatchingRanges):
- page/Page.h:
- page/PageGroup.h:
- page/Performance.cpp:
(WebCore::Performance::webkitGetEntriesByType):
(WebCore::Performance::webkitGetEntriesByName):
- page/Performance.h:
- page/PerformanceEntryList.cpp:
(WebCore::PerformanceEntryList::appendAll):
- page/PerformanceEntryList.h:
- page/SecurityOriginHash.h:
- page/SecurityPolicy.cpp:
- page/SpeechInputResult.h:
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
- page/animation/AnimationControllerPrivate.h:
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- page/animation/CompositeAnimation.h:
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::appendChild):
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::children):
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):
- page/scrolling/ScrollingThread.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::appendChild):
- page/scrolling/ScrollingTreeNode.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::syncChildPositions):
- platform/CrossThreadCopier.cpp:
- platform/CrossThreadCopier.h:
- platform/DragData.h:
- platform/MainThreadTask.h:
- platform/PODFreeListArena.h:
(WebCore::PODFreeListArena::freeObject):
(WebCore::PODFreeListArena::allocate):
- platform/PODIntervalTree.h:
- platform/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::PODRedBlackTree):
- platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::voiceList):
- platform/PlatformSpeechSynthesizer.h:
- platform/RunLoop.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::frameRectsChanged):
(WebCore::ScrollView::clipRectChanged):
(WebCore::ScrollView::setParentVisible):
(WebCore::ScrollView::show):
(WebCore::ScrollView::hide):
- platform/ScrollView.h:
- platform/SharedBuffer.h:
- platform/Supplementable.h:
(WebCore::Supplement::provideTo):
(WebCore::Supplementable::provideSupplement):
- platform/URL.cpp:
(WebCore::findHostnamesInMailToURL):
(WebCore::encodeHostnames):
- platform/audio/AudioBus.h:
- platform/audio/AudioDSPKernelProcessor.h:
- platform/audio/AudioResampler.h:
- platform/audio/DynamicsCompressor.h:
- platform/audio/DynamicsCompressorKernel.h:
- platform/audio/HRTFDatabase.h:
- platform/audio/HRTFKernel.h:
- platform/audio/MultiChannelResampler.h:
- platform/audio/Reverb.h:
- platform/audio/ReverbConvolver.h:
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::copyBufferAndClear):
(WebCore::SharedBuffer::copySomeDataFromDataArray):
- platform/graphics/FloatPolygon.cpp:
(WebCore::FloatPolygon::FloatPolygon):
- platform/graphics/FloatPolygon.h:
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::purgeInactiveFontData):
- platform/graphics/GlyphMetricsMap.h:
(WebCore::::locatePageSlowCase):
- platform/graphics/GlyphPageTreeNode.h:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/GraphicsLayer.cpp:
- platform/graphics/GraphicsLayer.h:
- platform/graphics/PlatformTextTrackMenu.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/WidthCache.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::processNewAndRemovedTextTracks):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):
(WebCore::GraphicsLayerCA::fetchCloneLayers):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCAAnimation.h:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/LayerPool.h:
- platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(PlatformCAAnimation::setValues):
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/cg/SubimageCacheWithTimer.h:
- platform/graphics/filters/CustomFilterParameterList.h:
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/FilterOperations.h:
(WebCore::FilterOperations::operations):
- platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::Texture):
(WebCore::Texture::create):
- platform/graphics/gpu/Texture.h:
- platform/graphics/mac/ComplexTextController.h:
- platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::SimpleFontData::getCFStringAttributes):
- platform/graphics/transforms/TransformOperations.h:
(WebCore::TransformOperations::operations):
- platform/ios/PasteboardIOS.mm:
(WebCore::documentFragmentWithRTF):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
- platform/mediastream/MediaStreamDescriptor.h:
- platform/mediastream/MediaStreamSource.h:
- platform/mediastream/RTCConfiguration.h:
- platform/network/BlobRegistryImpl.h:
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::parseCacheHeader):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::clientCerts):
(WebCore::ResourceHandle::createCFURLConnection):
- platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForNullKey):
(WebCore::::createValueForKey):
(WebCore::cfLocaleCache):
- plugins/PluginMainThreadScheduler.h:
- rendering/HitTestResult.h:
- rendering/InlineFlowBox.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::removeFromTrackedRendererMaps):
- rendering/RenderBlock.h:
- rendering/RenderButton.h:
- rendering/RenderCounter.cpp:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::GridIterator):
- rendering/RenderGrid.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrder):
(WebCore::RenderLayer::rebuildZOrderLists):
(WebCore::RenderLayer::collectLayers):
- rendering/RenderLayer.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::getRanges):
- rendering/RenderNamedFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::getRanges):
- rendering/RenderRegion.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::setSelection):
- rendering/RootInlineBox.h:
- rendering/shapes/PolygonShape.cpp:
(WebCore::computeShapePaddingBounds):
(WebCore::computeShapeMarginBounds):
- rendering/shapes/PolygonShape.h:
(WebCore::PolygonShape::PolygonShape):
- rendering/shapes/Shape.cpp:
(WebCore::createPolygonShape):
(WebCore::Shape::createShape):
- rendering/shapes/ShapeInfo.h:
- rendering/shapes/ShapeInterval.h:
- rendering/style/QuotesData.cpp:
(WebCore::QuotesData::create):
(WebCore::QuotesData::QuotesData):
- rendering/style/QuotesData.h:
- rendering/style/RenderStyle.cpp:
(WebCore::requireTransformOrigin):
(WebCore::RenderStyle::applyTransform):
- rendering/style/StyleGridData.h:
- rendering/svg/RenderSVGResourceGradient.h:
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/SVGResourcesCache.h:
- storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):
(WebCore::StorageEventDispatcher::dispatchSessionStorageEventsToFrames):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEventsToFrames):
- storage/StorageEventDispatcher.h:
- storage/StorageNamespaceImpl.h:
- storage/StorageThread.h:
- storage/StorageTracker.cpp:
(WebCore::StorageTracker::origins):
- storage/StorageTracker.h:
- svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
- svg/SVGAnimatedTypeAnimator.cpp:
(WebCore::SVGElementAnimatedProperties::SVGElementAnimatedProperties):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
- svg/SVGAnimatedTypeAnimator.h:
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::startAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget):
(WebCore::SVGDocumentExtensions::addElementReferencingTarget):
(WebCore::SVGDocumentExtensions::rebuildAllElementReferencesForTarget):
- svg/SVGDocumentExtensions.h:
- svg/SVGFontElement.h:
- svg/SVGGlyphMap.h:
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::orientTypeAnimated):
- svg/SVGMarkerElement.h:
- svg/SVGPathSegList.h:
- svg/animation/SMILTimeContainer.h:
- svg/graphics/SVGImageCache.h:
- svg/graphics/filters/SVGFilterBuilder.h:
(WebCore::SVGFilterBuilder::addBuiltinEffects):
- svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):
- svg/properties/SVGAnimatedListPropertyTearOff.h:
(WebCore::SVGAnimatedListPropertyTearOff::create):
- svg/properties/SVGAnimatedPropertyTearOff.h:
(WebCore::SVGAnimatedPropertyTearOff::create):
- svg/properties/SVGAnimatedStaticPropertyTearOff.h:
(WebCore::SVGAnimatedStaticPropertyTearOff::create):
- svg/properties/SVGAttributeToPropertyMap.cpp:
(WebCore::SVGAttributeToPropertyMap::animatedPropertiesForAttribute):
- svg/properties/SVGAttributeToPropertyMap.h:
- svg/properties/SVGStaticListPropertyTearOff.h:
(WebCore::SVGStaticListPropertyTearOff::create):
- svg/properties/SVGTransformListPropertyTearOff.h:
(WebCore::SVGTransformListPropertyTearOff::create):
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
(WebCore::SVGTransformListPropertyTearOff::consolidate):
- workers/DefaultSharedWorkerRepository.h:
- workers/WorkerMessagingProxy.h:
- xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):
- xml/XMLHttpRequestProgressEventThrottle.h:
- xml/XPathNodeSet.cpp:
(WebCore::XPath::NodeSet::sort):
(WebCore::XPath::NodeSet::traversalSort):
- xml/XSLStyleSheet.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
Source/WebKit/mac:
- History/WebHistory.mm:
(-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
- History/WebHistoryItem.mm:
(-[WebHistoryItem initFromDictionaryRepresentation:]):
- Plugins/Hosted/NetscapePluginHostProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
(WebKit::NetscapePluginInstanceProxy::stopAllStreams):
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView destroyPlugin]):
- Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager origins]):
- Storage/WebStorageManager.mm:
(-[WebStorageManager origins]):
- WebCoreSupport/WebApplicationCache.mm:
(+[WebApplicationCache originsWithCache]):
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::getClientPasteboardDataForRange):
(WebEditorClient::documentFragmentFromAttributedString):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebNotificationClient.h:
- WebCoreSupport/WebNotificationClient.mm:
(WebNotificationClient::show):
(WebNotificationClient::clearNotifications):
- WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):
- WebView/WebDataSource.mm:
(-[WebDataSource subresources]):
- WebView/WebViewData.h:
Source/WebKit2:
- UIProcess/mac/WebColorPickerMac.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setProcessSuppressionEnabled):
Source/WTF:
- wtf/AVLTree.h:
- wtf/CheckedArithmetic.h:
- wtf/Compression.h:
- wtf/Functional.h:
(WTF::R):
- wtf/HashFunctions.h:
- wtf/HashIterators.h:
- wtf/HashSet.h:
(WTF::::contains):
- wtf/ListHashSet.h:
(WTF::::contains):
- wtf/RefCountedLeakCounter.cpp:
- wtf/RetainPtr.h:
- wtf/SentinelLinkedList.h:
(WTF::::remove):
- wtf/SizeLimits.cpp:
- wtf/StreamBuffer.h:
- wtf/Vector.h:
- wtf/VectorTraits.h:
- wtf/WeakPtr.h:
(WTF::WeakReference::create):
(WTF::WeakReference::createUnbound):
(WTF::WeakPtr::WeakPtr):
(WTF::WeakPtrFactory::WeakPtrFactory):
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::add):
(WTF::findString):
- wtf/text/StringConcatenate.h:
- wtf/text/StringImpl.h:
- wtf/text/StringOperators.h:
(WTF::operator+):
- 4:35 PM Changeset in webkit [157652] by
-
- 2 edits in trunk/Source/WebCore
Cleaning warning messages from StyleResolveTree
https://bugs.webkit.org/show_bug.cgi?id=123030
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-18
Reviewed by Andreas Kling.
No new tests needed.
- style/StyleResolveTree.cpp:
(WebCore::Style::elementInsideRegionNeedsRenderer):
(WebCore::Style::createRendererIfNeeded):
- 4:23 PM Changeset in webkit [157651] by
-
- 13 edits in trunk/Source
Get rid of IDBFactoryBackendLevelDB and IDBTransactionBackendLevelDB in IDBDatabaseBackendLevelDB.
https://bugs.webkit.org/show_bug.cgi?id=123039
Reviewed by Anders Carlsson.
Source/WebCore:
Add a few concepts to the interfaces to make this work:
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
(WebCore::IDBTransactionBackendInterface::id):
(WebCore::IDBTransactionBackendInterface::IDBTransactionBackendInterface):
Adapt to using Interface ptr’s instead of LevelDB ptr’s:
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
(WebCore::IDBDatabaseBackendLevelDB::create):
(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
(WebCore::IDBDatabaseBackendLevelDB::createObjectStore):
(WebCore::IDBDatabaseBackendLevelDB::deleteObjectStore):
(WebCore::IDBDatabaseBackendLevelDB::createIndex):
(WebCore::IDBDatabaseBackendLevelDB::deleteIndex):
(WebCore::IDBDatabaseBackendLevelDB::get):
(WebCore::IDBDatabaseBackendLevelDB::put):
(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
(WebCore::IDBDatabaseBackendLevelDB::setIndexesReady):
(WebCore::IDBDatabaseBackendLevelDB::openCursor):
(WebCore::IDBDatabaseBackendLevelDB::count):
(WebCore::IDBDatabaseBackendLevelDB::deleteRange):
(WebCore::IDBDatabaseBackendLevelDB::clear):
(WebCore::IDBDatabaseBackendLevelDB::transactionStarted):
(WebCore::IDBDatabaseBackendLevelDB::transactionFinished):
(WebCore::IDBDatabaseBackendLevelDB::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendLevelDB::transactionFinishedAndCompleteFired):
(WebCore::IDBDatabaseBackendLevelDB::runIntVersionChangeTransaction):
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
(WebCore::IDBObjectStoreBackendLevelDB::makeIndexWriters):
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
(WebCore::IDBTransactionBackendLevelDB::abort):
(WebCore::IDBTransactionBackendLevelDB::commit):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::removeIDBDatabaseBackend): Stub out this new interface method.
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- 3:57 PM Changeset in webkit [157650] by
-
- 4 edits in trunk/Source/JavaScriptCore
Remove excess reserved space in ctiTrampoline frames for X86 and X86_64.
https://bugs.webkit.org/show_bug.cgi?id=123037.
Reviewed by Geoffrey Garen.
- jit/JITStubsMSVC64.asm:
- jit/JITStubsX86.h:
- jit/JITStubsX86_64.h:
- 2:41 PM Changeset in webkit [157649] by
-
- 9 edits4 adds in trunk/Source/WebInspectorUI
Web Inspector: CSS Regions: Add the list of flows in the FrameTreeElement
https://bugs.webkit.org/show_bug.cgi?id=122924
Reviewed by Timothy Hatcher.
Added code to collect the flows from the backend into the DOMTree object
on the frontend. Added ContentFlow to represent the flows on the frontend
side and created ContentFlowTreeElement to display the flows in the FrameTreeElement.
- Localizations/en.lproj/localizedStrings.js:
- Scripts/copy-user-interface-resources.sh:
- UserInterface/CSSObserver.js:
(WebInspector.CSSObserver.prototype.namedFlowCreated):
(WebInspector.CSSObserver.prototype.namedFlowRemoved):
(WebInspector.CSSObserver.prototype.regionLayoutUpdated):
(WebInspector.CSSObserver.prototype.regionOversetChanged):
- UserInterface/ContentFlow.js: Added.
(WebInspector.ContentFlow):
(WebInspector.ContentFlow.prototype.get id):
(WebInspector.ContentFlow.prototype.get documentNodeIdentifier):
(WebInspector.ContentFlow.prototype.get name):
(WebInspector.ContentFlow.prototype.get overset):
(WebInspector.ContentFlow.prototype.set overset):
- UserInterface/ContentFlowIcon.css: Added.
(.content-flow-icon .icon):
- UserInterface/ContentFlowTreeElement.js: Added.
(WebInspector.ContentFlowTreeElement):
- UserInterface/DOMTree.js:
(WebInspector.DOMTree):
(WebInspector.DOMTree.prototype.get flowMap):
(WebInspector.DOMTree.prototype.get flowsCount):
(WebInspector.DOMTree.prototype._framePageExecutionContextChanged):
(WebInspector.DOMTree.prototype.requestContentFlowList):
(WebInspector.DOMTree.prototype._isContentFlowInCurrentDocument):
(WebInspector.DOMTree.prototype._contentFlowListWasUpdated):
(WebInspector.DOMTree.prototype._contentFlowWasAdded):
(WebInspector.DOMTree.prototype._contentFlowWasRemoved):
- UserInterface/DOMTreeManager.js:
(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager._flowPayloadHashKey):
(WebInspector.DOMTreeManager.prototype._buildHighlightConfig):
(WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype.getNamedFlowCollection):
(WebInspector.DOMTreeManager.prototype.namedFlowCreated):
(WebInspector.DOMTreeManager.prototype.namedFlowRemoved):
(WebInspector.DOMTreeManager.prototype._sendNamedFlowUpdateEvents):
(WebInspector.DOMTreeManager.prototype.regionLayoutUpdated):
(WebInspector.DOMTreeManager.prototype.regionOversetChanged):
- UserInterface/FrameTreeElement.js:
(WebInspector.FrameTreeElement):
(WebInspector.FrameTreeElement.prototype.onpopulate):
(WebInspector.FrameTreeElement.prototype.onexpand):
(WebInspector.FrameTreeElement.prototype._childContentFlowWasAdded):
(WebInspector.FrameTreeElement.prototype._childContentFlowWasRemoved):
(WebInspector.FrameTreeElement.prototype._rootDOMNodeInvalidated):
(WebInspector.FrameTreeElement.prototype._addChildForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._removeChildForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._addTreeElementForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._compareResourceTreeElements):
(WebInspector.FrameTreeElement.prototype._insertResourceTreeElement):
(WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):
- UserInterface/Images/ContentFlow.svg: Added.
- UserInterface/Main.html:
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
- 2:09 PM Changeset in webkit [157648] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] WKBrowsingController accessors crash instead of returning nil
https://bugs.webkit.org/show_bug.cgi?id=123036
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(autoreleased): Return nil if the object is NULL.
- 1:53 PM Changeset in webkit [157647] by
-
- 4 edits4 adds in trunk
Unable to upload <img src="foo.svg"> as WebGL texture
https://bugs.webkit.org/show_bug.cgi?id=123035
Reviewed by Tim Horton.
Source/WebCore:
If the HTMLImageElement passed to texture2D is an SVG
image, paint it first into a bitmap buffer and upload that.
Note that the SVG image still needs to have an intrinsic
or explicit size - see how the test case must set width and
height.
I also renamed the cache of ImageBuffers since it is
no longer only being used for video frames.
Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContext): Rename m_videoCache to m_generatedImageCache.
(WebCore::WebGLRenderingContext::drawImageIntoBuffer): New method that creates an ImageBuffer
of the appropriate size and renders into that.
(WebCore::WebGLRenderingContext::texImage2D): If we see an SVG image, render it first.
(WebCore::WebGLRenderingContext::videoFrameToImage): Renamed m_generatedImageCache.
(WebCore::WebGLRenderingContext::texSubImage2D): If we see an SVG image, render it first.
- html/canvas/WebGLRenderingContext.h: Renaming.
LayoutTests:
Test that creates an HTMLImageElement, sets its source
to an SVG file, and then uploads as a WebGLTexture. Based
on the existing WebGL conformance tests.
- fast/canvas/webgl/resources/red-green.svg: Added.
- fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-svg-image.js: Added.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image-expected.txt: Added.
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image.html: Added.
- 1:28 PM Changeset in webkit [157646] by
-
- 2 edits in trunk/Tools
Add Rik Cabanier to list of committers
https://bugs.webkit.org/show_bug.cgi?id=123031
reviewed by Dirk Schulze.
- Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
- 1:21 PM Changeset in webkit [157645] by
-
- 2 edits in trunk/Source/JavaScriptCore
Frequent RELEASE_ASSERT crashes in Structure::checkOffsetConsistency on WebGL swizzler tests
https://bugs.webkit.org/show_bug.cgi?id=121661
Reviewed by Mark Hahnenberg.
This method shouldn't have been called from the concurrent JIT thread. That's hard to prevent
so I added a return-early check using isCompilationThread().
Here's why this makes sense. Structure has two ways to tell you about the layout of the objects
it is describing: m_offset and the property table. Most structures only have m_offset and report
null for the property table. If the property table is there, it will tell you additional
information and that information subsumes m_offset - but the m_offset is still there. So, when
we have a property table, we have to keep it in sync with the m_offset. There is a bunch of
machinery to do this.
Changing the property table only happens on the main thread.
Because the machinery to change the property table is so complex, especially with respect to
keeping it in sync with m_offset, we have the checkOffsetConsistency method. It's meant to be
called at key points before and after changes to the property table or the offset.
Most clients of Structure who care about object layout, including the concurrent thread, will
want to know m_offset and not the property table. If they want the property table, they will
already be super careful. The concurrent thread has special methods for this, like
Structure::getConcurrently(), which uses fine-grained locking to ensure that it sees a coherent
view of the property table.
Adding locking to checkOffsetConsistency() is probably a bad idea since that method may be
called when the relevant lock is already held. So, we'd have awkward recursive locking issues.
But right now, the concurrent JIT thread may call a method, like Structure::outOfLineCapacity(),
which has a call to checkOffsetConsistency(). The call to checkOffsetConsistency() is there
because we have found that it helps quickly identify situations where the property table and
m_offset get out of sync - mainly because code that changes either of those things will usually
also want to know the outOfLineCapacity(). But Structure::outOfLineCapacity() doesn't *actually*
need the property table; it uses the m_offset. The concurrent JIT is correct to call
outOfLineCapacity(), and is right to do so without holding any locks (since in all cases where
it calls outOfLineCapacity() it has already proven that m_offset is immutable). But because
outOfLineCapacity() calls checkOffsetConsistency(), and checkOffsetConsistency() doesn't grab
locks, and that same structure is having its property table modified by the main thread, we end
up with these spurious assertion failures. FWIW, the structure isn't *actually* having *its*
property table modified - instead what happens is that some downstream structure steals the
property table and then starts adding things to it. The concurrent thread loads the property
table before it's stolen, and hence the badness.
I suspect there are other code paths that lead to the concurrent JIT calling some Structure
method that it is fine and safe to call, but then that method calls checkOffsetConsistency(),
and then you have a possible crash.
The most sensible solution to this appears to be to make sure that checkOffsetConsistency() is
aware of its uselessness to the concurrent JIT thread. This change makes it return early if
it's in the concurrent JIT.
- runtime/StructureInlines.h:
(JSC::Structure::checkOffsetConsistency):
- 1:19 PM Changeset in webkit [157644] by
-
- 10 edits3 adds in trunk/Source/WebCore
[GTK] Generate API documentation for GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=121538
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-10-18
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am: Initialize gdom_symbol_files variable.
- 12:17 PM Changeset in webkit [157643] by
-
- 6 edits in trunk/Source/WebKit2
Remove some Windows specific code from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=123034
Reviewed by Beth Dakin.
- Platform/PlatformProcessIdentifier.h:
- Shared/API/c/WKDeclarationSpecifiers.h:
- UIProcess/API/C/WKNativeEvent.h:
- UIProcess/API/C/WKPreferencesPrivate.h:
- config.h:
- 12:11 PM Changeset in webkit [157642] by
-
- 4 edits in trunk/Source/WebCore
Rubber-banding is often not smooth on infinitely scrolling websites
https://bugs.webkit.org/show_bug.cgi?id=122985
Reviewed by Simon Fraser.
totalContentsSize is an important part of the calculation for
maximumScrollPosition(). This function is called repeatedly throughout the curve
of a rubber-band to determine the stretch amount. To keep the rubber-band
animation smooth, it should be allowed to finish its animation using the old
totalContentsSize. This patch does that by adding a new variable,
m_totalContentsSizeForRubberBand. This value should almost always be equivalent to
m_totalContentsSize. It will only vary if m_totalContentsSize has changed in the
middle of a rubber-band, and in that case, it will stay equivalent to the old
totalContentSize value until the rubber band animation finishes.
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
- page/scrolling/ScrollingTreeScrollingNode.h:
(WebCore::ScrollingTreeScrollingNode::totalContentsSizeForRubberBand):
(WebCore::ScrollingTreeScrollingNode::setTotalContentsSizeForRubberBand):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::stopSnapRubberbandTimer):
(WebCore::ScrollingTreeScrollingNodeMac::maximumScrollPosition):
- 10:22 AM Changeset in webkit [157641] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add SPI to disable the garbage collector timer
https://bugs.webkit.org/show_bug.cgi?id=122921
Add null check to Heap::setGarbageCollectionTimerEnabled() that I inadvertently
omitted.
- heap/Heap.cpp:
(JSC::Heap::setGarbageCollectionTimerEnabled):
- 10:11 AM Changeset in webkit [157640] by
-
- 2 edits in trunk/Websites/webkit.org
Mixed content error when accessing webkit.org/team.html over https
https://bugs.webkit.org/show_bug.cgi?id=123020
Patch by Tibor Meszaros <tmeszaros@inf.u-szeged.hu> on 2013-10-18
Reviewed by Alexey Proskuryakov.
When the webkit.org/team.html page is accessed over https most browsers report
Mixed Content error, which is caused by the fact that the contributos.json file
is accessed over a plain http connection and not https.
- team.html:
- 10:03 AM Changeset in webkit [157639] by
-
- 2 edits in trunk/Source/JavaScriptCore
Group 64-bit specific and 32-bit specific callOperation implementations.
https://bugs.webkit.org/show_bug.cgi?id=123024
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-18
Reviewed by Michael Saboff.
This is not a big deal, but could be less confusing when reading the code.
- jit/JITInlines.h:
(JSC::JIT::callOperation):
(JSC::JIT::callOperationWithCallFrameRollbackOnException):
(JSC::JIT::callOperationNoExceptionCheck):
- 10:03 AM Changeset in webkit [157638] by
-
- 2 edits in trunk/Websites/webkit.org
Cleanup webkit.org/team.html
https://bugs.webkit.org/show_bug.cgi?id=123022
Patch by Tibor Meszaros <tmeszaros@inf.u-szeged.hu> on 2013-10-18
Reviewed by Alexey Proskuryakov.
Removed the annoteWithWikiData function, because data it tries to fetch does not exists.
- team.html:
- 9:55 AM Changeset in webkit [157637] by
-
- 3 edits3 adds in trunk
Fix a FlushLiveness problem.
https://bugs.webkit.org/show_bug.cgi?id=122984
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-18
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
- dfg/DFGFlushLivenessAnalysisPhase.cpp:
(JSC::DFG::FlushLivenessAnalysisPhase::process):
LayoutTests:
- js/regress/script-tests/stepanov_container.js: Added.
- js/regress/stepanov_container-expected.txt: Added.
- js/regress/stepanov_container.html: Added.
- 9:25 AM Changeset in webkit [157636] by
-
- 26 edits in trunk/Source/JavaScriptCore
Change native function call stubs to use JIT operations instead of ctiVMHandleException
https://bugs.webkit.org/show_bug.cgi?id=122982
Reviewed by Geoffrey Garen.
Change ctiVMHandleException to operationVMHandleException. Change all exception operations to
return the catch callFrame and entryPC via vm.callFrameForThrow and vm.targetMachinePCForThrow.
This removed calling convention headaches, fixing https://bugs.webkit.org/show_bug.cgi?id=122980
in the process.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::jumpToExceptionHandler):
- jit/JIT.cpp:
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JIT.h:
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- jit/JITExceptions.h:
- jit/JITInlines.h:
(JSC::JIT::callOperationNoExceptionCheck):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_throw):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_throw):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JITStubsARM.h:
- jit/JITStubsARM64.h:
- jit/JITStubsARMv7.h:
- jit/JITStubsMIPS.h:
- jit/JITStubsMSVC64.asm:
- jit/JITStubsSH4.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86_64.h:
- jit/Repatch.cpp:
(JSC::tryBuildGetByIDList):
- jit/SlowPathCall.h:
(JSC::JITSlowPathCall::call):
- jit/ThunkGenerators.cpp:
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::nativeForGenerator):
- runtime/VM.h:
(JSC::VM::callFrameForThrowOffset):
(JSC::VM::targetMachinePCForThrowOffset):
- 9:06 AM Changeset in webkit [157635] by
-
- 2 edits in trunk/Source/WebKit2
Removed the MAC_OS_X_VERSION_MIN_REQUIRED condition from the definition of WK_API_ENABLED.
Rubber-stamped by Anders Carlsson.
- Shared/API/Cocoa/WKFoundation.h:
- 9:05 AM Changeset in webkit [157634] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for --no-svg option.
m_svgStyle of RenderStyle is guarded with the ENABLE_SVG flag.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
- 8:23 AM Changeset in webkit [157633] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix J_JITOperation_EAapJ call for MIPS and ARM EABI.
https://bugs.webkit.org/show_bug.cgi?id=123023
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-18
Reviewed by Michael Saboff.
- jit/JITInlines.h:
(JSC::JIT::callOperation): EncodedJSValue parameter do not need alignment
using EABI_32BIT_DUMMY_ARG here.
- 7:52 AM Changeset in webkit [157632] by
-
- 2 edits in trunk/Source/WebCore
Cleanup the Modules group in the WebCore.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=123009
Rubberstamped by Antti Koivisto.
- WebCore.xcodeproj/project.pbxproj:
- 6:07 AM QtWebKitBuildBots edited by
- (diff)
- 5:01 AM QtWebKitGardening edited by
- (diff)
- 4:40 AM WebKitGTK/2.2.x edited by
- (diff)
- 4:26 AM Changeset in webkit [157631] by
-
- 5 edits in trunk
[ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
https://bugs.webkit.org/show_bug.cgi?id=122970
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-10-18
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Removed an invalid signal to set objects to an unknown state
layout-complete. This signal was originally generated to notify DRT
and WKTR in case of page load complete.
It was replaced by ATK:AtkDocument:load-complete, which is already sent
by AXObjectCache::frameLoadingEventPlatformNotification().
There is no new test since the changes are covered by existing ones
(e.g. accessibility/loading-iframe-sends-notification.html).
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Removed an invalid
signal to set objects to an unknown state layout-complete.
Tools:
Removed an invalid signal to set an object state to layout-complete
that does not exist. It was replaced by ATK:AtkDocument:load-complete.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
(axObjectEventListener): Replaced layout-complete with load-complete.
(connectAccessibilityCallbacks): Connect callback to new listener for
ATK:AtkDocument:load-complete.
(disconnectAccessibilityCallbacks): Disconnect callback to new listener
for ATK:AtkDocument:load-complete.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(axObjectEventListener): Replaced layout-complete with load-complete.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connect callback to new listener for ATK:AtkDocument:load-complete.
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Disconnect callback to new listener for ATK:AtkDocument:load-complete.
- 3:33 AM Changeset in webkit [157630] by
-
- 7 edits1 add in trunk
[GTK] Generate API documentation for GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=121538
Reviewed by Gustavo Noronha Silva.
.:
- GNUmakefile.am: Initialize gdom_symbol_files variable.
Source/WebCore:
- bindings/gobject/GNUmakefile.am: Add a explicit rule for all
.symbols file making them depend on the corresponding header file,
since the .symbols file is generated by the bindings generator.
Tools:
The .symbols file that is now generated for checking GObject DOM
bindings API compatibility while building can also be used to
generate the files needed to produce the gtk-doc
documentation. The new script generate-webkitdom-doc-files can
generate the docs.sgml and sections.txt files from the given list
of .symbols files.
- gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
and webkitdomgtk-sections.txt as well as rules to install the
generated WebKitDOMGTK documentation.
- gtk/generate-gtkdoc:
(webkitdom_docs_html_path): New helper function that returns the
path where the DOM API documentation has been generated.
(get_webkit2_options): Include DOM API docs to the list of xref
dependencies.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Return the gtk-doc options to generate
the DOM API docs.
(get_webkitdom_options.derived_sources_path):
(get_webkitdom_options.src_path):
- gtk/generate-webkitdom-doc-files: Added.
(WebKitDOMDocGenerator):
(WebKitDOMDocGenerator.write_header):
(WebKitDOMDocGenerator.write_section):
(WebKitDOMDocGenerator.write_footer):
(WebKitDOMDocGeneratorDocs):
(WebKitDOMDocGeneratorDocs.write_header):
(write_section):
(write_footer):
(WebKitDOMDocGeneratorSections):
(WebKitDOMDocGeneratorSections.init):
(WebKitDOMDocGeneratorSections._dom_class):
(WebKitDOMDocGeneratorSections._dom_class_decamelize):
(WebKitDOMDocGeneratorSections._symbol_list):
(WebKitDOMDocGeneratorSections.write_section):
- 3:21 AM Changeset in webkit [157629] by
-
- 8 edits1 add in trunk/LayoutTests
Unreviewed EFL gardening.
- platform/efl-wk2/TestExpectations: Remove passing testcase.
- platform/efl/TestExpectations: fast/backgrounds/background-opaque-images-over-color.html is failing.
- platform/efl/fast/dom/Range/getClientRects-expected.txt: Rebaseline after r152872.
- platform/efl/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Rebaseline after r152793.
- platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
- platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Rebaseline after r152911.
- platform/efl/tables/mozilla/marvin/backgr_index-expected.png: Rebaseline after r152793.
- platform/efl/tables/mozilla/marvin/backgr_index-expected.txt: Rebaseline after r152793.
- 3:15 AM Changeset in webkit [157628] by
-
- 3 edits in trunk/Source/WebCore
[ATK] Simplify implementation of atk_text_get_text
https://bugs.webkit.org/show_bug.cgi?id=122644
Reviewed by Chris Fleizach.
Simplified code so we only call textUnderElement() directly once
and only when needed. Also, moved the specific code for ColorWell
objects up to the beginning of that function, so we don't do any
additional efforts like computing text ranges in those cases.
No new tests are needed, just to make sure that the current layout
and unit tests are still passing, which they are.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(textForObject): Fixed a issue that got detected while working on
this patch, which was causing a '\n' to be artificially appended
at the end of text controls all the time.
(webkitAccessibleTextGetText): Simplified function.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::doAXStringForRange): Removed
the check that prevents from pass ranges exceeding the limits of
the element's text, since those will be checked anyway when
calling String::substring().
- 2:17 AM Changeset in webkit [157627] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r153852.
- platform/efl-wk2/loader/go-back-cached-main-resource-expected.txt:
- platform/efl/security/block-test-no-port-expected.txt:
- 12:37 AM Changeset in webkit [157626] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/W3C/audio/networkState/networkState_during_loadstart.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123010
- platform/mac/TestExpectations: Marked as such.
- 12:29 AM Changeset in webkit [157625] by
-
- 2 edits in trunk/LayoutTests
css3/filters/composited-during-animation-layertree.html sometimes produces empty results
https://bugs.webkit.org/show_bug.cgi?id=95622
- platform/mac/TestExpectations: Marking as flaky.
- 12:17 AM Changeset in webkit [157624] by
-
- 9 edits in trunk/Source
[GStreamer][GTK] Add GRefPtr::outPtr()
https://bugs.webkit.org/show_bug.cgi?id=122996
Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-18
Reviewed by Philippe Normand.
Source/WebCore:
No new tests because this is just simplifying existing code.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Add GRefPtr specialization for GstToc.
- platform/graphics/gstreamer/GRefPtrGStreamer.h: Same.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: Use GRefPtr::outPtr() to simplify code.
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
(WebCore::GStreamerGWorld::removePlatformVideoSink):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Same.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
(WebCore::MediaPlayerPrivateGStreamer::newTextSample):
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: Same.
(WebCore::MediaPlayerPrivateGStreamerBase::currentVideoSinkCaps):
- platform/network/soup/ResourceHandleSoup.cpp: Same.
(WebCore::HostTLSCertificateSet::computeCertificateHash):
Source/WTF:
- wtf/gobject/GRefPtr.h:
(WTF::GRefPtr::outPtr): Added.
Oct 17, 2013:
- 10:23 PM Changeset in webkit [157623] by
-
- 7 edits2 adds in trunk/Source/WebKit2
Remote Layer Tree: Proxy layer contents to the UI process
http://bugs.webkit.org/show_bug.cgi?id=123003
Reviewed by Anders Carlsson.
Proxy layer contents to the UI process. Contents are painted into ShareableBitmaps
for now, and are fully repainted on any invalidation. Also, contents do not respect
any kind of scale or use of contentsRect/etc.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):
Store/encode/decode/dump the new RemoteLayerBackingStore.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
Fix a mistake where contentsRect was getting reset when contentsScale changed.
Set the layer contents when the backing store changes.
- WebKit2.xcodeproj/project.pbxproj:
Add RemoteLayerBackingStore.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::recursiveBuildTransaction):
Paint while building our transaction, and mark the backing store as changed
if we did any painting.
(PlatformCALayerRemote::ensureBackingStore):
Keep the backing store's properties up-to-date with our layer.
(PlatformCALayerRemote::setNeedsDisplay):
Inform the backing store that it needs to paint.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/RemoteLayerBackingStore.h: Added.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.mm: Added.
(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
Encode/decode our ShareableBitmap (via its handle) and size.
(RemoteLayerBackingStore::setNeedsDisplay):
For now, repaint the world.
(RemoteLayerBackingStore::display):
Create a new bitmap if needed, and paint into it.
- 9:41 PM Changeset in webkit [157622] by
-
- 2 edits in trunk/Source/WebKit2
Fixed a typo in the definition of WK_API_ENABLED.
- Shared/API/Cocoa/WKFoundation.h: It’s 101000, not 10100.
- 9:32 PM Changeset in webkit [157621] by
-
- 5 edits in trunk/Source/JavaScriptCore
Unreviewed, another ARM64 build fix.
Get rid of andPtr(TrustedImmPtr, blah), since it would take Effort to get it to work
on ARM64 and none of its uses are legit - they should all be using
andPtr(TrustedImm32, blah) anyway.
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerARM64.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
- jit/JIT.cpp:
(JSC::JIT::privateCompileExceptionHandlers):
- 8:59 PM Changeset in webkit [157620] by
-
- 31 edits2 adds in trunk/Source/WebKit2
Add and deploy WK_API_ENABLED guards
https://bugs.webkit.org/show_bug.cgi?id=123008
Reviewed by Darin Adler.
- Shared/API/Cocoa: Added.
- Shared/API/Cocoa/WKFoundation.h: Added. Defined WK_API_ENABLED based on whether the
Objective-C API should be enabled in the current configuration.
- Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::typeFromObject): Changed to use WK_API_ENABLED.
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode): Ditto.
(WebKit::WebContextObjCObjectGraphDecoderImpl::decode): Ditto.
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode): Ditto.
(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode): Ditto.
- UIProcess/API/mac/WKTypeRefWrapper.h: Ditto.
- UIProcess/API/mac/WKTypeRefWrapper.mm: Ditto.
- UIProcess/API/mac/WebKit2.h: Imported WKFoundation.h.
- WebKit2.xcodeproj/project.pbxproj: Added new Cocoa group in Shared/API. Added
WKFoundation.h as a public header.
- WebProcess/InjectedBundle/API/mac/WKDOMDocument.h:
- WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
- WebProcess/InjectedBundle/API/mac/WKDOMElement.h:
- WebProcess/InjectedBundle/API/mac/WKDOMElement.mm:
- WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:
- WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
- WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
- WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
- WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h:
- WebProcess/InjectedBundle/API/mac/WKDOMRange.h:
- WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:
- WebProcess/InjectedBundle/API/mac/WKDOMRangePrivate.h:
- WebProcess/InjectedBundle/API/mac/WKDOMText.h:
- WebProcess/InjectedBundle/API/mac/WKDOMText.mm:
- WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:
- WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h:
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::load):
- 8:47 PM Changeset in webkit [157619] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, speculative ARM64 build fix.
move(ImmPtr, blah) is only available in MacroAssembler since that's where blinding is
implemented. So, you have to use TrustedImmPtr in the superclasses.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::store8):
(JSC::MacroAssemblerARM64::branchTest8):
- 7:43 PM Changeset in webkit [157618] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, speculative ARM build fix.
https://bugs.webkit.org/show_bug.cgi?id=122890
<rdar://problem/15258624>
- assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::firstRegister):
(JSC::ARM64Assembler::lastRegister):
(JSC::ARM64Assembler::firstFPRegister):
(JSC::ARM64Assembler::lastFPRegister):
- assembler/MacroAssemblerARM64.h:
- assembler/MacroAssemblerARMv7.h:
- 6:55 PM Changeset in webkit [157617] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip tests which are already passed.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 6:04 PM Changeset in webkit [157616] by
-
- 3 edits4 adds in trunk/LayoutTests
Unreviewed EFL gardening.
- platform/efl-wk2/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Added.
- platform/efl-wk2/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
- platform/efl/fast/forms/control-restrict-line-height-expected.png: Rebaseline after r155408.
- platform/efl/fast/forms/control-restrict-line-height-expected.txt: Rebaseline after r155408.
- 5:52 PM Changeset in webkit [157615] by
-
- 2 edits in trunk/Source/WebCore
Don't add an include for return type of a [Custom] function in generated bindings code
https://bugs.webkit.org/show_bug.cgi?id=122972
Reviewed by Sam Weinig.
- bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Don't.
- 4:35 PM Changeset in webkit [157614] by
-
- 4 edits in trunk/Source/JavaScriptCore
Pass VM instead of JSGlobalObject to JSONObject constructor.
<https://webkit.org/b/122999>
JSONObject was only use the JSGlobalObject to grab at the VM.
Dodge a few loads by passing the VM directly instead.
Reviewed by Geoffrey Garen.
- runtime/JSONObject.cpp:
(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):
- runtime/JSONObject.h:
(JSC::JSONObject::create):
- 4:33 PM Changeset in webkit [157613] by
-
- 3 edits in trunk/Source/WebCore
CTTE: RenderMathMLSpace always has a MathMLTextElement.
<https://webkit.org/b/122992>
The renderer is never anonymous and always has a corresponding
MathMLTextElement. Overload element() with a tighter return type.
Also marked the class FINAL and made most methods private.
Reviewed by Antti Koivisto.
- rendering/mathml/RenderMathMLSpace.cpp:
(WebCore::RenderMathMLSpace::RenderMathMLSpace):
(WebCore::RenderMathMLSpace::updateFromElement):
- rendering/mathml/RenderMathMLSpace.h:
- 4:29 PM Changeset in webkit [157612] by
-
- 2 edits in trunk/Source/JavaScriptCore
Removed the JITStackFrame struct
https://bugs.webkit.org/show_bug.cgi?id=123001
Reviewed by Anders Carlsson.
- jit/JITStubs.h: JITStackFrame and JITStubArg are unused now, since all
our helper functions obey the C function call ABI.
- 4:20 PM Changeset in webkit [157611] by
-
- 2 edits in trunk/Source/WebCore
PlatformCALayer constructor should take layer type as an argument
https://bugs.webkit.org/show_bug.cgi?id=122915
Reviewed by Anders Carlsson.
No new tests, just restoring old code.
Un-do part of the patch for bug 122915; we can't early-return
in the constructor, there's still more work to do.
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::PlatformCALayerMac):
- 4:08 PM Changeset in webkit [157610] by
-
- 2 edits in trunk/Source/JavaScriptCore
Removed an unused #define
https://bugs.webkit.org/show_bug.cgi?id=123000
Reviewed by Anders Carlsson.
- jit/JITStubs.h: Removed the concept of JITSTACKFRAME_ARGS_INDEX,
since it is unused now. This is a step toward using the C stack.
- 4:00 PM Changeset in webkit [157609] by
-
- 2 edits in trunk/Source/JavaScriptCore
Eliminate uses of JITSTACKFRAME_ARGS_INDEX as scratch area for thunks
https://bugs.webkit.org/show_bug.cgi?id=122973
Reviewed by Michael Saboff.
- jit/ThunkGenerators.cpp:
(JSC::throwExceptionFromCallSlowPathGenerator): This was all dead code,
so I removed it.
The code acted as if it needed to pass an argument to
lookupExceptionHandler, and as if it passed that argument to itself
through JITStackFrame. However, lookupExceptionHandler does not take
an argument (other than the default ExecState argument), and the code
did not initialize the thing that it thought it passed to itself!
- 3:47 PM Changeset in webkit [157608] by
-
- 2 edits in trunk/WebKitLibraries
Crash fix for Windows XP.
https://bugs.webkit.org/show_bug.cgi?id=122790
Patch by Anthony Johnson <anthony.johnson@flexsim.com> on 2013-10-17
Reviewed by Geoffrey Garen.
- win/tools/vsprops/common.props:
Replaced stack and heap sizes of zero with blank stack and heap sizes.
- 3:28 PM Changeset in webkit [157607] by
-
- 6 edits1 add in trunk
Run JavaScriptCore tests again on Windows.
https://bugs.webkit.org/show_bug.cgi?id=122787
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-17
Reviewed by Tim Horton.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.sln: Added.
- jit/JITStubsMSVC64.asm: Removed reference to cti_vm_throw unused since r157581.
Tools:
- Scripts/build-jsc:
(buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
- Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
- Scripts/webkitdirs.pm:
(determineConfigurationForVisualStudio):
(determineConfigurationProductDir):
Build directory should end with bin64 and configuration should end with |x64 on Win64.
(isAppleWinWebKit):
(copyInspectorFrontendFiles):
(setPathForRunningWebKitApp):
Separated WinCairo directories and options from AppleWin.
- 3:10 PM Changeset in webkit [157606] by
-
- 2 edits in trunk/Source/WTF
Tidied up the Vector<T> move constructor
https://bugs.webkit.org/show_bug.cgi?id=122998
Reviewed by Anders Carlsson.
- wtf/Vector.h:
(WTF::::Vector): Don't call swap() "weird". It's the way most std types
implement move constructors.
Do inline this function, so the compiler can optimize away a logical
move into a physical no-op.
- 3:08 PM Changeset in webkit [157605] by
-
- 3 edits2 adds in trunk
Web Inspector: [CSS Regions] Crash when highlighting a node of a flow with no regions
https://bugs.webkit.org/show_bug.cgi?id=122993
Reviewed by Joseph Pecoraro.
Source/WebCore:
Test: inspector-protocol/dom/highlight-flow-with-no-region.html
Even if a named flow has no regions the content of the flow will still have renderer objects created.
Removed the assumption that all renderers inside a RenderFlowThread will always have an enclosing RenderRegion.
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForRendererFragments):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
LayoutTests:
Added test to check that DOM.highlightNode is not crashing WebCore when the node is inside
a flow with no associated regions.
- inspector-protocol/dom/highlight-flow-with-no-region-expected.txt: Added.
- inspector-protocol/dom/highlight-flow-with-no-region.html: Added.
- 2:45 PM Changeset in webkit [157604] by
-
- 2 edits in trunk/Source/JavaScriptCore
Removed restoreArgumentReference (another use of JITStackFrame)
https://bugs.webkit.org/show_bug.cgi?id=122997
Reviewed by Oliver Hunt.
- jit/JSInterfaceJIT.h: Removed an unused function. This is a step
toward using the C stack.
- 2:39 PM Changeset in webkit [157603] by
-
- 14 edits4 deletes in trunk/Source
Remove JITStubCall.h
https://bugs.webkit.org/show_bug.cgi?id=122991
Reviewed by Geoff Garen.
Happily this is no longer used
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JIT.cpp:
- jit/JITArithmetic.cpp:
- jit/JITArithmetic32_64.cpp:
- jit/JITCall.cpp:
- jit/JITCall32_64.cpp:
- jit/JITOpcodes.cpp:
- jit/JITOpcodes32_64.cpp:
- jit/JITPropertyAccess.cpp:
- jit/JITPropertyAccess32_64.cpp:
- jit/JITStubCall.h: Removed.
- 2:38 PM Changeset in webkit [157602] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Improve the viewport of some websites like mobilesyrup.com/2013/08/25/moto-x-review/
https://bugs.webkit.org/show_bug.cgi?id=122995
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-10-17.
Reviewed by George Staikos.
Internally reviewed by George Staikos and Eli Fidler.
JIRA 523949
Force to respect the viewport when there is viewport meta tag but width
is not specified even though the viewport is broken. By doing that, We
want to improve the user experience of some websites that use a reasonable
initial-scale, but have some overly-wide contents
The contents of those websites like mobilesyrup.com/2013/08/25/moto-x-review
should be improved by the contents provider eventually.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- 2:38 PM Changeset in webkit [157601] by
-
- 5 edits3 adds in trunk/Source/WebInspectorUI
Web Inspector: Go to line keyboard command and dialog
https://bugs.webkit.org/show_bug.cgi?id=122893
Reviewed by Timothy Hatcher.
Add a text input over source code text editors, centered within the width of the editor
and towards the top of the editor, upon pressing Command+L or Control+G to match the
behavior in Chrome.
- Localizations/en.lproj/localizedStrings.js:
New localized string "Line Number".
- UserInterface/GoToLineDialog.css: Added.
Styling for the go-to-line dialog.
- UserInterface/GoToLineDialog.js: Added.
(WebInspector.GoToLineDialog):
Generate the DOM structure for the dialog.
(WebInspector.GoToLineDialog.prototype.present):
Present the dialog as a child of a parent element. The dialog's text field automatically
gets focus and resets to be empty.
(WebInspector.GoToLineDialog.prototype.dismiss):
Dismiss the dialog if visible, this triggers the goToLineDialogWasDismissed delegate method.
(WebInspector.GoToLineDialog.prototype.handleEvent):
Route the various events registered in the dialog's DOM tree: input, keydown, blur, mousedown
and click.
(WebInspector.GoToLineDialog.prototype._handleInputEvent):
Update the "non-empty" class on the dialog's element depending on the content of the dialog's
text field. If there is content in the text field, this will make the clear icon visible.
(WebInspector.GoToLineDialog.prototype._handleKeydownEvent):
If the Esc. key is pressed when there is text in the dialog's input field, clear the input field.
If no text is in the input field, dismiss the input field. When the Enter key is pressed, we call
the isGoToLineDialogValueValid() method on the delegate to figure out if the text field value is
valid. If it's not, we select the text field value so that it may be easily replaced and play
en error sound. If it's valid, we call the goToLineDialogValueWasValidated() delegate method
and dismiss the dialog.
(WebInspector.GoToLineDialog.prototype._handleBlurEvent):
Dismiss the dialog when its text field loses focus. This ensures that clicking anywhere outside
of the dialog removes it from display.
(WebInspector.GoToLineDialog.prototype._handleMousedownEvent):
Upon pressing the mouse down on the clear icon, select the entire text field content (matches
the behavior of Xcode) and prevent the default event action that would blur the text field
which would dismiss the dialog.
(WebInspector.GoToLineDialog.prototype._handleClickEvent):
Clear the content of the dialog's text field upon clicking on its clear button.
(WebInspector.GoToLineDialog.prototype._clear):
Reset the dialog's text field's value to an empty string and remove the "non-empty" CSS class name
controlling the display of the clear button.
- UserInterface/Images/CloseWhite.svg: Added.
Variation of the Close.svg icon with a white cross.
- UserInterface/Main.html:
Link to the newly added resources for GoToLineDialog.
- UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor):
Register the Command+L and Control+G keyboard shortcuts to bring up the go-to-line dialog.
(WebInspector.SourceCodeTextEditor.prototype.showGoToLineDialog):
Method called upon pressing the Command+L and Control+G keyboard shorcuts creating an instance
of a GoToDialog if necessary, becoming its delegate and presenting it in the context of the
editor's root element.
(WebInspector.SourceCodeTextEditor.prototype.isGoToLineDialogValueValid):
Delegate method called to validate the line number presently set in the go-to-dialog's text field,
checking it's a number between 1 and the number of lines in the source code.
(WebInspector.SourceCodeTextEditor.prototype.goToLineDialogValueWasValidated):
Delegate method called when the line number set in the go-to-dialog's text field has been validated.
We reveal and select the line at the number provided.
(WebInspector.SourceCodeTextEditor.prototype.goToLineDialogWasDismissed):
Ensure the source code editor regains focus upon dismissing the go-to-dialog.
- UserInterface/TextEditor.js:
(WebInspector.TextEditor.prototype.revealPosition):
Add a new opt-in option to not highlight the revealed position. The code in goToLineDialogValueWasValidated()
sets that new flag to true to avoid an unnecessary highlight on top of the selection.
(WebInspector.TextEditor.prototype.get lineCount):
Expose the lineCount() method on the private CodeMirror instance.
(WebInspector.TextEditor.prototype.focus):
Expose the focus() method on the private CodeMirror instance.
- 2:29 PM Changeset in webkit [157600] by
-
- 5 edits2 deletes in trunk/Source/WebInspectorUI
Web Inspector: logged objects are highlighted in blue
https://bugs.webkit.org/show_bug.cgi?id=122897
Reviewed by Joseph Pecoraro.
Switch to using the system highlight color for the background selected messages.
Also removing SVG assets no longer needed since we won't be showing white prompt
and result icons anymore as well as a few generated canvas states.
- UserInterface/Images/UserInputPromptPreviousSelected.svg: Removed.
- UserInterface/Images/UserInputResultSelected.svg: Removed.
- UserInterface/LogContentView.css:
(.console-messages:focus .console-item.selected):
- UserInterface/Main.js:
(WebInspector._generateDisclosureTriangleImages):
- 2:21 PM Changeset in webkit [157599] by
-
- 3 edits in trunk/Source/WebCore
CTTE: RenderMathMLOperator always has a MathMLElement.
<https://webkit.org/b/122988>
Reviewed by Antti Koivisto.
The renderer is never anonymous and always has a corresponding
MathMLElement. Overload element() with a tighter return type.
Also marked the class FINAL and made most methods private.
- 2:14 PM Changeset in webkit [157598] by
-
- 5 edits in trunk
Fix three bugs in the equals() implementations for css gradients.
https://bugs.webkit.org/show_bug.cgi?id=122987
Reviewed by Andreas Kling.
- Linear gradients were considered equal if the first gradient has no x and y position and the second has no x but does have y.
- Same as 1, for radial gradients. (This doesn't happen in practice as CSSParser::parseRadialGradient rejects such input, so no test for this case.)
- Radial gradients without x and y position weren't considered equal even if they were.
Source/WebCore:
- css/CSSGradientValue.cpp:
(WebCore::CSSLinearGradientValue::equals):
(WebCore::CSSRadialGradientValue::equals):
LayoutTests:
Merges https://codereview.chromium.org/26147006/
- cssom/cssvalue-comparison-expected.txt:
- cssom/cssvalue-comparison.html:
- 2:07 PM Changeset in webkit [157597] by
-
- 6 edits in trunk/Source
Web Inspector: allow front-end to trigger the system beep sound to signal an error
https://bugs.webkit.org/show_bug.cgi?id=122955
Reviewed by Timothy Hatcher.
Source/WebCore:
New beep() method exposed on InspectorFrontendHost calling into WebCore's systemBeep().
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::beep):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
Source/WebInspectorUI:
Provide a stub method for the new InspectorFrontendHost.beep() method.
- UserInterface/InspectorFrontendHostStub.js:
(WebInspector.InspectorFrontendHostStub.prototype.beep):
- 2:03 PM Changeset in webkit [157596] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Speculative buildfixes for GTK and EFL after r157582.
- CMakeLists.txt:
- GNUmakefile.am:
- 1:51 PM Changeset in webkit [157595] by
-
- 11 edits11 adds in trunk/Source/WebKit2
Refactor stored website data APIs
https://bugs.webkit.org/show_bug.cgi?id=122781
Patch by Martin Hock <mhock@apple.com> on 2013-10-17
Reviewed by Brady Eidson.
Add WebOriginDataManager along with corresponding class
WebOriginDataManagerProxy and API WKOriginDataManager.
Currently, the new files are unused.
WKOriginDataManager should subsume the functionality of:
WKApplicationCacheManager, WKCookieManager, WKDatabaseManager,
WKKeyValueStorageManager, WKMediaCacheManager,
WKPluginSiteDataManager, and WKResourceCacheManager.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextGetOriginDataManager):
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKOriginDataManager.cpp: Added.
(WKOriginDataManagerGetTypeID):
(WKOriginDataManagerGetOrigins):
(WKOriginDataManagerDeleteEntriesForOrigin):
(WKOriginDataManagerDeleteAllEntries):
(WKOriginDataManagerStartObservingChanges):
(WKOriginDataManagerStopObservingChanges):
(WKOriginDataManagerSetChangeClient):
- UIProcess/API/C/WKOriginDataManager.h: Added.
- UIProcess/WebOriginDataManagerProxy.cpp: Added.
(WebKit::WebOriginDataManagerProxy::supplementName):
(WebKit::WebOriginDataManagerProxy::create):
(WebKit::WebOriginDataManagerProxy::WebOriginDataManagerProxy):
(WebKit::WebOriginDataManagerProxy::~WebOriginDataManagerProxy):
(WebKit::WebOriginDataManagerProxy::contextDestroyed):
(WebKit::WebOriginDataManagerProxy::processDidClose):
(WebKit::WebOriginDataManagerProxy::shouldTerminate):
(WebKit::WebOriginDataManagerProxy::refWebContextSupplement):
(WebKit::WebOriginDataManagerProxy::derefWebContextSupplement):
(WebKit::WebOriginDataManagerProxy::getOrigins):
(WebKit::WebOriginDataManagerProxy::didGetOrigins):
(WebKit::WebOriginDataManagerProxy::deleteEntriesForOrigin):
(WebKit::WebOriginDataManagerProxy::deleteAllEntries):
(WebKit::WebOriginDataManagerProxy::startObservingChanges):
(WebKit::WebOriginDataManagerProxy::stopObservingChanges):
(WebKit::WebOriginDataManagerProxy::setChangeClient):
(WebKit::WebOriginDataManagerProxy::didChange):
- UIProcess/WebOriginDataManagerProxy.h: Added.
- UIProcess/WebOriginDataManagerProxy.messages.in: Added.
- UIProcess/WebOriginDataManagerProxyChangeClient.cpp: Added.
(WebKit::WebOriginDataManagerProxyChangeClient::didChange):
- UIProcess/WebOriginDataManagerProxyChangeClient.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/OriginData/WebOriginDataManager.cpp: Added.
(WebKit::WebOriginDataManager::supplementName):
(WebKit::WebOriginDataManager::WebOriginDataManager):
(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteAllEntries):
(WebKit::WebOriginDataManager::startObservingChanges):
(WebKit::WebOriginDataManager::stopObservingChanges):
- WebProcess/OriginData/WebOriginDataManager.h: Added.
- WebProcess/OriginData/WebOriginDataManager.messages.in: Added.
- 1:36 PM Changeset in webkit [157594] by
-
- 5 edits in trunk/Source/WebCore
Remove PlatformCAAnimation::supportsValueFunction()
https://bugs.webkit.org/show_bug.cgi?id=122990
Reviewed by Tim Horton.
PlatformCAAnimation::supportsValueFunction always returns true now, so there's no need for it to exist anymore.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
- platform/graphics/ca/PlatformCAAnimation.h:
- platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
- 1:08 PM Changeset in webkit [157593] by
-
- 3 edits in trunk/Source/WebCore
CTTE: RenderMathMLFenced always has a MathMLInlineContainerElement.
<https://webkit.org/b/122986>
This renderer is never anonymous and always has a corresponding
MathMLInlineContainerElement. Overload element() with a tighter
return type.
Also marked the class FINAL and made most methods private.
Reviewed by Anders Carlsson.
- 1:04 PM Changeset in webkit [157592] by
-
- 2 edits in trunk/Source/JavaScriptCore
Removed a use of JITSTACKFRAME_ARGS_INDEX
https://bugs.webkit.org/show_bug.cgi?id=122989
Reviewed by Oliver Hunt.
- jit/JITStubCall.h: Removed an unused function. This is one step closer
to using the C stack.
- 12:53 PM Changeset in webkit [157591] by
-
- 3 edits in trunk/Source/JavaScriptCore
Change emit_op_catch to use another method to materialize VM
https://bugs.webkit.org/show_bug.cgi?id=122977
Reviewed by Oliver Hunt.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_catch): Use a constant. It removes our dependency
on JITStackFrame. It is also faster and simpler.
- 12:42 PM Changeset in webkit [157590] by
-
- 3 edits in trunk/Source/JavaScriptCore
Eliminate emitGetJITStubArg() - dead code
https://bugs.webkit.org/show_bug.cgi?id=122975
Reviewed by Anders Carlsson.
- jit/JIT.h:
- jit/JITInlines.h: Removed unused, deprecated function.
- 12:22 PM Changeset in webkit [157589] by
-
- 2 edits in trunk/Source/WebCore
Comment AffineTransform::xScale() and yScale() to make their meanings clearer
https://bugs.webkit.org/show_bug.cgi?id=122981
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-17
Reviewed by Simon Fraser.
- platform/graphics/transforms/AffineTransform.h:
- 12:22 PM Changeset in webkit [157588] by
-
- 11 edits in trunk/Source/JavaScriptCore
Eliminate all ASSERT references to OBJECT_OFFSETOF(struct JITStackFrame,...) in JITStubsXXX.h.
https://bugs.webkit.org/show_bug.cgi?id=122979.
Reviewed by Michael Saboff.
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JITStubsARM.h:
- jit/JITStubsARM64.h:
- jit/JITStubsARMv7.h:
- jit/JITStubsMIPS.h:
- jit/JITStubsSH4.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86_64.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- 12:15 PM Changeset in webkit [157587] by
-
- 3 edits in trunk/Source/WebCore
Remove unnecessary check for RenderLayer and rename ensureLayer to createLayer in RenderLayerModelObject.
https://bugs.webkit.org/show_bug.cgi?id=122928
Reviewed by Darin Adler.
No new tests due to code refactoring.
RenderLayerModelObject::styleDidChange invokes the ensureLayer() only in case of !layer().
Again checking for layer existence would be deemed redundant in ensureLayer.
Replacing it with an ASSERT(!m_layer) and also renaming it to createLayer.
Blink review URL: https://codereview.chromium.org/27246003/
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::createLayer):
(WebCore::RenderLayerModelObject::styleDidChange):
- rendering/RenderLayerModelObject.h:
- 11:57 AM Changeset in webkit [157586] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove saving callFrameRegister to JITStackFrame in JITCompiler::compileFunction()
https://bugs.webkit.org/show_bug.cgi?id=122974
Reviewed by Geoffrey Garen.
Eliminated unneeded storing to JITStackFrame.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- 11:52 AM Changeset in webkit [157585] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening of Apple Windows port.
- platform/win/TestExpectations:
- 11:51 AM Changeset in webkit [157584] by
-
- 2 edits in trunk/Source/WebCore
Remove PlatformCALayerMac workaround for <rdar://problem/7390716>
https://bugs.webkit.org/show_bug.cgi?id=122983
Reviewed by Simon Fraser.
Remove a workaround for a bug fixed in Lion.
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::setSublayers):
(PlatformCALayerMac::removeAllSublayers):
(PlatformCALayerMac::adoptSublayers):
- 11:33 AM Changeset in webkit [157583] by
-
- 2 edits in trunk/Source/WebKit2
Blind attempt at gtk-wk2 build fix.
- GNUmakefile.am:
- 11:30 AM Changeset in webkit [157582] by
-
- 9 edits3 copies8 adds in trunk/Source/WebKit2
Add scaffolding for IDBDatabaseBackends in Web and Database processes
https://bugs.webkit.org/show_bug.cgi?id=122971
Reviewed by Tim Horton.
This patch:
- Adds a WebProcessIDBDatabaseBackend
- Adds a DatabaseProcessIDBDatabaseBackend
- Establishes the basic messaging between them
- Actually creates those backends as the result of an indexedDB.open() call from javascript
- DerivedSources.make:
- WebKit2.xcodeproj/project.pbxproj:
- Platform/Logging.h:
Hook up messaging so (Web/Database)ProcessIDBDatabaseBackends can message each other:
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::didReceiveMessage):
(WebKit::DatabaseToWebProcessConnection::establishIDBDatabaseBackend):
- DatabaseProcess/DatabaseToWebProcessConnection.h:
(WebKit::DatabaseToWebProcessConnection::connection):
- DatabaseProcess/DatabaseToWebProcessConnection.messages.in: Added.
DatabaseProcess side of an IDBDatabaseBackend:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.cpp:
(WebKit::DatabaseProcessIDBDatabaseBackend::DatabaseProcessIDBDatabaseBackend):
(WebKit::DatabaseProcessIDBDatabaseBackend::~DatabaseProcessIDBDatabaseBackend):
(WebKit::DatabaseProcessIDBDatabaseBackend::openConnection):
(WebKit::DatabaseProcessIDBDatabaseBackend::messageSenderConnection):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.h: Added.
(WebKit::DatabaseProcessIDBDatabaseBackend::create):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.messages.in: Added.
WebProcess side of an IDBDatabaseBackend:
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp: Added.
(WebKit::generateBackendIdentifier):
(WebKit::WebProcessIDBDatabaseBackend::WebProcessIDBDatabaseBackend):
(WebKit::WebProcessIDBDatabaseBackend::~WebProcessIDBDatabaseBackend):
(WebKit::WebProcessIDBDatabaseBackend::openConnection):
(WebKit::WebProcessIDBDatabaseBackend::createObjectStore):
(WebKit::WebProcessIDBDatabaseBackend::deleteObjectStore):
(WebKit::WebProcessIDBDatabaseBackend::createTransaction):
(WebKit::WebProcessIDBDatabaseBackend::close):
(WebKit::WebProcessIDBDatabaseBackend::commit):
(WebKit::WebProcessIDBDatabaseBackend::abort):
(WebKit::WebProcessIDBDatabaseBackend::createIndex):
(WebKit::WebProcessIDBDatabaseBackend::deleteIndex):
(WebKit::WebProcessIDBDatabaseBackend::get):
(WebKit::WebProcessIDBDatabaseBackend::put):
(WebKit::WebProcessIDBDatabaseBackend::setIndexKeys):
(WebKit::WebProcessIDBDatabaseBackend::setIndexesReady):
(WebKit::WebProcessIDBDatabaseBackend::openCursor):
(WebKit::WebProcessIDBDatabaseBackend::count):
(WebKit::WebProcessIDBDatabaseBackend::deleteRange):
(WebKit::WebProcessIDBDatabaseBackend::clear):
(WebKit::WebProcessIDBDatabaseBackend::messageSenderConnection):
(WebKit::WebProcessIDBDatabaseBackend::establishDatabaseProcessBackend):
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h: Added.
(WebKit::WebProcessIDBDatabaseBackend::create):
Basic shared utilities that multiple processes will need going forward:
- Shared/Databases/IndexedDB/IDBUtilities.cpp:
(WebKit::uniqueDatabaseIdentifier):
- Shared/Databases/IndexedDB/IDBUtilities.h:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::sharedDatabaseBackendMap):
(WebKit::WebIDBFactoryBackend::open): Actually establish an IDBDatabaseBackend in the DatabaseProcess
when indexedDB.open() is called, even if it does nothing for now.
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
- WebProcess/Databases/WebToDatabaseProcessConnection.h:
- 11:12 AM Changeset in webkit [157581] by
-
- 18 edits in trunk/Source/JavaScriptCore
Transition cti_op_throw and cti_vm_throw to a JIT operation
https://bugs.webkit.org/show_bug.cgi?id=122931
Reviewed by Filip Pizlo.
Moved cti_op_throw to operationThrow. Made the caller responsible for jumping to the
catch handler. Eliminated cti_op_throw_static_error, cti_vm_throw, ctiVMThrowTrampoline()
and their callers as it is now dead code. There is some work needed on the Microsoft X86
callOperation to handle the need to provide space for structure return value.
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_throw):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_catch):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JITStubsARM.h:
- jit/JITStubsARM64.h:
- jit/JITStubsARMv7.h:
- jit/JITStubsMIPS.h:
- jit/JITStubsMSVC64.asm:
- jit/JITStubsSH4.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86_64.h:
- jit/JSInterfaceJIT.h:
- 11:00 AM Changeset in webkit [157580] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] REGRESSION(r156472): scrolling coordinator is always enabled incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=122958
Patch by Attila Dusnoki <Attila Dusnoki> on 2013-10-17
Reviewed by Tim Horton.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Missing ENABLE(THREADED_SCROLLING) guard added.
- 10:44 AM Changeset in webkit [157579] by
-
- 4 edits10 adds in trunk
"border-collapse: collapse;" for table removes part of its border (was: Border disappears when close to some elements)
https://bugs.webkit.org/show_bug.cgi?id=8914
Reviewed by David Hyatt.
Source/WebCore:
The table section's side of a collapsed border won't get painted if there are no cells there to paint it. So instead
of relying solely on cells to paint the collapsed border paint the appropriate section of the border if there's no
cell to take care of it.
Tests: fast/table/paint-section-borders-without-cells-rtl.html
fast/table/paint-section-borders-without-cells-vertical-lr-rtl.html
fast/table/paint-section-borders-without-cells-vertical-lr.html
fast/table/paint-section-borders-without-cells-vertical-rl.html
fast/table/paint-section-borders-without-cells.html
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintRowGroupBorder):
(WebCore::RenderTableSection::offsetLeftForRowGroupBorder):
(WebCore::RenderTableSection::offsetTopForRowGroupBorder):
(WebCore::RenderTableSection::verticalRowGroupBorderHeight):
(WebCore::RenderTableSection::horizontalRowGroupBorderWidth):
(WebCore::RenderTableSection::paintRowGroupBorderIfRequired):
(WebCore::physicalBorderForDirection):
(WebCore::RenderTableSection::paintObject):
- rendering/RenderTableSection.h:
LayoutTests:
- fast/table/paint-section-borders-without-cells-expected.html: Added.
- fast/table/paint-section-borders-without-cells-rtl-expected.html: Added.
- fast/table/paint-section-borders-without-cells-rtl.html: Added.
- fast/table/paint-section-borders-without-cells-vertical-lr-expected.html: Added.
- fast/table/paint-section-borders-without-cells-vertical-lr-rtl-expected.html: Added.
- fast/table/paint-section-borders-without-cells-vertical-lr-rtl.html: Added.
- fast/table/paint-section-borders-without-cells-vertical-lr.html: Added.
- fast/table/paint-section-borders-without-cells-vertical-rl-expected.html: Added.
- fast/table/paint-section-borders-without-cells-vertical-rl.html: Added.
- fast/table/paint-section-borders-without-cells.html: Added.
- 9:57 AM Changeset in webkit [157578] by
-
- 5 edits in tags/Safari-538.2/Source/WebKit2
Merged r157561. <rdar://problem/15183901>
- 9:19 AM Changeset in webkit [157577] by
-
- 2 edits in trunk/LayoutTests
certain http media tests doesn't receive the expected "Content-Length" header
https://bugs.webkit.org/show_bug.cgi?id=122965
Patch by Andres Gomez <Andres Gomez> on 2013-10-17
Reviewed by Eric Carlson.
Fixed PHP syntax so "Content-Length" HTTP Header is included in
the response.
- http/tests/media/resources/serve-video.php:
- 8:47 AM Changeset in webkit [157576] by
-
- 12 edits1 add in trunk/Source
Source/JavaScriptCore: Remove JITStackFrame references in the C Loop LLINT.
https://bugs.webkit.org/show_bug.cgi?id=122950.
Patch by Mark Lam <mark.lam@apple.com> on 2013-10-17
Reviewed by Michael Saboff.
- jit/JITStubs.h:
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- offlineasm/cloop.rb:
Source/WTF: Introduce WTF::Bag and start using it for InlineCallFrameSet
https://bugs.webkit.org/show_bug.cgi?id=122941
Reviewed by Geoffrey Garen.
Introduce WTF::Bag, which is basically an allocation pool. No POD restrictions. Does one
malloc per entry. No need to shrink afterwards.
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/Bag.h: Added.
(WTF::Bag::Bag):
(WTF::Bag::~Bag):
(WTF::Bag::add):
(WTF::Bag::iterator::iterator):
(WTF::Bag::iterator::operator!):
(WTF::Bag::iterator::operator*):
(WTF::Bag::iterator::operator++):
(WTF::Bag::iterator::operator==):
(WTF::Bag::begin):
(WTF::Bag::end):
(WTF::Bag::isEmpty):
- wtf/CMakeLists.txt:
- 8:17 AM Changeset in webkit [157575] by
-
- 14 edits in trunk/Source/WebCore
StyleRuleFoo::mutableProperties() should return a reference.
<https://webkit.org/b/122962>
The mutableProperties() functions always return objects, so make
them return MutableStylePropertySet&.
Also tweaked the StyleRuleCSSStyleDeclaration constructor to take
references to both the properties and the owner rule since both
are required.
Reviewed by Antti Koivisto.
- 7:45 AM Changeset in webkit [157574] by
-
- 4 edits in trunk/Source/WebCore
[CSS Shapes] Improve the performance of image valued shapes with large shape-margins
https://bugs.webkit.org/show_bug.cgi?id=122613
Reviewed by Andreas Kling.
The cost of computing the shape-margin boundary of an image-valued shape-outside
is now proportional to (2 * shape-margin + image.height) rather than
(2 * shape-margin * image.height). The performance improvement comes from skipping
sequences of rounded-rectangle intervals that will not contribute to the final
result. Each non-empty row in the original image contributes one rounded-rectangle
whose corner radius is shape-margin, height is 2 * shape-margin, and width is
2 * shape-margin plus the width of the limits of the intervals on the row.
Renamed private method RasterShape::getIntervals() to intervalsAt() to be a little
more consistent with WebKit naming conventions.
There are no new tests since is just an internal refactoring.
- rendering/shapes/RasterShape.cpp:
(WebCore::MarginIntervalGenerator::set): Changed the x1,x2 parameters to an IntShapeInterval.
(WebCore::RasterShapeIntervals::contains): Refactor for the getIntervals() => intervalsAt() rename.
(WebCore::RasterShapeIntervals::getIntervalX1Values): Ditto.
(WebCore::RasterShapeIntervals::getIncludedIntervals): Ditto.
(WebCore::RasterShapeIntervals::getExcludedIntervals): Ditto.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals): Performance tuning.
- rendering/shapes/RasterShape.h:
(WebCore::RasterShapeIntervals::intervalsAt): Renamed getIntervals().
(WebCore::RasterShapeIntervals::limitIntervalAt): Return the min/max limits of the intervals at Y.
- rendering/shapes/ShapeInterval.h:
(WebCore::ShapeInterval::isEmpty): Added.
- 7:02 AM Changeset in webkit [157573] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Add URLMediaStream in the build
https://bugs.webkit.org/show_bug.cgi?id=122833
Reviewed by Carlos Garcia Campos.
- GNUmakefile.am: Add mediastream/gstreamer in include directories list.
- GNUmakefile.list.am: Add DOMURLMediaStream files in the build.
- 6:47 AM Changeset in webkit [157572] by
-
- 4 edits in trunk/Source/JavaScriptCore
Remove JITStackFrame references in the C Loop LLINT.
https://bugs.webkit.org/show_bug.cgi?id=122950.
Reviewed by Michael Saboff.
- jit/JITStubs.h:
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- offlineasm/cloop.rb:
- 6:43 AM Changeset in webkit [157571] by
-
- 12 edits in trunk/Source/JavaScriptCore
Remove JITStackFrame references in JIT probes.
https://bugs.webkit.org/show_bug.cgi?id=122947.
Reviewed by Michael Saboff.
- assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::ProbeContext::dump):
- assembler/MacroAssemblerARM.h:
- assembler/MacroAssemblerARMv7.cpp:
(JSC::MacroAssemblerARMv7::ProbeContext::dump):
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerX86Common.cpp:
(JSC::MacroAssemblerX86Common::ProbeContext::dump):
- assembler/MacroAssemblerX86Common.h:
- jit/JITStubsARM.h:
- jit/JITStubsARMv7.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86Common.h:
- jit/JITStubsX86_64.h:
- 5:58 AM Changeset in webkit [157570] by
-
- 2 edits in trunk/Source/WebKit/gtk
Massage the Gtk build.
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldApplyStyle):
- 5:38 AM Changeset in webkit [157569] by
-
- 24 edits in trunk/Source
Use PassRef for constructing StylePropertySets.
<https://webkit.org/b/122948>
Make functions that construct StylePropertySets return PassRef
instead of PassRefPtr. Since they never return null, this gets rid
of the extra branch in ~PassRefPtr everywhere.
Also StyleRule* classes now hold a Ref<StylePropertySet>, codifying
the fact that they always have a property set.
Reviewed by Antti Koivisto.
- 5:15 AM Changeset in webkit [157568] by
-
- 26 edits in trunk/Source/WebCore
DataRef<T> should use Ref<T> internally.
<https://webkit.org/b/122953>
DataRef is used to hold RenderStyle substructures, and due to the
way style inheritance is implemented, DataRef will always point to
a live object.
Codify this by making DataRef::m_data a Ref, and making all methods
that create substructure objects return PassRef.
Reviewed by Antti Koivisto.
- 2:02 AM Changeset in webkit [157567] by
-
- 28 edits6 adds in trunk
[CSS Regions] Anonymous nested regions
https://bugs.webkit.org/show_bug.cgi?id=119135
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/regions/table-caption-as-region.html
fast/regions/table-cell-as-region.html
This patch allows any non-replaced block to behave like a region. When an element is styled with the
-webkit-flow-from property, instead of making the renderer a RenderRegion, we let the original
renderer be created the same way and we add a region as an anonymous child for the renderer.
The anonymous block child, modeled by the new RenderNamedFlowFragment class, will be responsible
for the fragmentation of the named flow thread content.
A RenderBlockFlow object will keep a reference to a RenderNamedFlowFragment(RenderRegion) inside its
rare data structures.
Contains code contributed by Catalin Badea.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp: Changed to take the anonymous region into account.
(WebCore::Element::renderRegion):
(WebCore::Element::webkitGetRegionFlowRanges):
- dom/WebKitNamedFlow.cpp: Ditto.
(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore::WebKitNamedFlow::getRegionsByContent):
(WebCore::WebKitNamedFlow::getRegions):
- inspector/InspectorOverlay.cpp: Take into account the new model for regions, with an anonymous region inside a block.
(WebCore::buildObjectForRegionHighlight):
(WebCore::buildObjectForElementInfo):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeShapeSize): For a render named flow fragment, there is no need to recompute the shape inside
we can take it from the parent.
(WebCore::RenderBlock::renderName): Make the block that contains a render named flow fragment (region) report RenderRegion.
A future patch that will change this will need to rebase a lot of tests.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::insertedIntoTree): Create the anonymous region if needed (change of -webkit-flow-from determines Node reattach).
(WebCore::RenderBlockFlow::willBeDestroyed): Clean-up the anonymous region if necessary.
(WebCore::RenderBlockFlow::clearFloats): Small style change to make sure that check-webkit-style reports 0 failures on RenderBlockFlow.cpp.
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::styleDidChange): Update the style of the anonymous region too.
(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded): Helper function to create the anonymous region
and to add it as a child to the block.
(WebCore::RenderBlockFlow::canHaveChildren):
(WebCore::RenderBlockFlow::canHaveGeneratedChildren):
(WebCore::RenderBlockFlow::namedFlowFragmentNeedsUpdate): Force a layout of the anonymous region if the
parent block has percentage height (similar to RenderBlock::updateBlockChildDirtyBitsBeforeLayout)
(WebCore::RenderBlockFlow::updateLogicalHeight): Update the logical height of anonymous region when the height of parent is updated.
(WebCore::RenderBlockFlow::setRenderNamedFlowFragment):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::renderNamedFlowFragment):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor): Remove the direct creation of RenderRegion objects since they will be
created as anonymous children of block flow objects.
- rendering/RenderElement.h:
(WebCore::RenderElement::generatingElement): Account for anonymous region if necessary.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent): Take anonymous region into account
and use the anonymous region parent offset/border.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly): Check for style instead of isRenderRegion since
the parent of the anonymous region will get the layer.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::insertedIntoTree): Call RenderBlockFlow method instead.
- rendering/RenderNamedFlowFragment.cpp: Added. Model the behaviour of the anonymous region.
Has RenderRegion as a base class.
(WebCore::RenderNamedFlowFragment::RenderNamedFlowFragment):
(WebCore::RenderNamedFlowFragment::~RenderNamedFlowFragment):
(WebCore::RenderNamedFlowFragment::setStyleForNamedFlowFragment):
(WebCore::RenderNamedFlowFragment::styleDidChange):
(WebCore::RenderNamedFlowFragment::shouldHaveAutoLogicalHeight):
(WebCore::RenderNamedFlowFragment::maxPageLogicalHeight):
- rendering/RenderNamedFlowFragment.h: Added.
(WebCore::RenderNamedFlowFragment::isPseudoElementRegion):
(WebCore::RenderNamedFlowFragment::renderName):
(WebCore::toRenderNamedFlowFragment):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::isRenderNamedFlowFragmentContainer):
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderNamedFlowFragment):
- rendering/RenderRegion.h:
- rendering/RenderTableCaption.cpp: Call RenderBlockFlow method instead.
(WebCore::RenderTableCaption::insertedIntoTree):
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::writeRenderRegionList):
- rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::shapeSize):
- style/StyleResolveTree.cpp:
(WebCore::Style::elementInsideRegionNeedsRenderer):
LayoutTests:
Add new tests for making a table-cell and a table-caption a region.
Change expected results for repaint tests of fixed elements since the parent of the region gets layer.
- fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
- fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
- fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
- fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
- fast/regions/table-caption-as-region-expected.html: Added.
- fast/regions/table-caption-as-region.html: Added.
- fast/regions/table-cell-as-region-expected.html: Added.
- fast/regions/table-cell-as-region.html: Added.
- 1:53 AM Changeset in webkit [157566] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build when NUMBER_OF_ARGUMENT_REGISTERS == 4.
https://bugs.webkit.org/show_bug.cgi?id=122949
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-17
Reviewed by Andreas Kling.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- 1:48 AM Changeset in webkit [157565] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a reviewer.
- 1:06 AM Changeset in webkit [157564] by
-
- 6 edits6 adds in trunk
[EFL] Properly expose tables in accessibility
https://bugs.webkit.org/show_bug.cgi?id=122894
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-17
Reviewed by Chris Fleizach.
Source/WebCore:
All tables should exposed as tables.
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::addChildren):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):
LayoutTests:
Added new accessibility expectations after r153432.
- platform/efl-wk2/TestExpectations:
- platform/efl-wk2/accessibility/table-detection-expected.txt: Added.
- platform/efl-wk2/accessibility/table-one-cell-expected.txt: Added.
- platform/efl-wk2/accessibility/table-with-rules-expected.txt: Added.
- platform/efl/accessibility/table-detection-expected.txt: Added.
- platform/efl/accessibility/table-one-cell-expected.txt: Added.
- platform/efl/accessibility/table-with-rules-expected.txt: Added.
- 12:55 AM Changeset in webkit [157563] by
-
- 4 edits in trunk
Make it possible to assign a PassRef to a RefPtr.
<https://webkit.org/b/122943>
Source/WTF:
We have to use std::move when constructing a RefPtr from a PassRef
since there is no copy constructor for the latter.
Reviewed by Antti Koivisto.
Tools:
Added a small API test for RefPtr=(PassRef) so we know this code
will compile (and work.)
Reviewed by Antti Koivisto.
- 12:46 AM Changeset in webkit [157562] by
-
- 3 edits in trunk
[CMAKE] Update code to take advantage of CMake version 2.8.3+.
https://bugs.webkit.org/show_bug.cgi?id=97516
Patch by Afonso R. Costa Jr. <afonso.costa@samsung.com> on 2013-10-17
Reviewed by Gyuyoung Kim.
CMake's version was changed to 2.8.3. So, these files below
can be simplified to take advantage of CMake's new version.
- Source/cmake/FindCairo.cmake: Simplified according to CMake 2.8.3+.
- Source/cmake/FindGStreamer.cmake: Ditto.
- 12:28 AM Changeset in webkit [157561] by
-
- 5 edits in trunk/Source/WebKit2
<rdar://problem/15183901> WebKit2 XPC services load the wrong frameworks when running
from the staged frameworks location.
Build the XPC services with DYLD_VERSIONED_FRAMEWORK_PATH when USE_STAGING_INSTALL_PATH
is set to YES. This is necessary because there's no way to specify environment variables
to be used when an XPC service is launched.
Reviewed by Anders Carlsson.
- Configurations/BaseTarget.xcconfig: Set OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH to contain the
DYLD_VERSIONED_FRAMEWORK_PATH value when USE_STAGING_INSTALL_PATH is YES.
- Configurations/BaseXPCService.xcconfig: Include OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH in the
value of OTHER_LDFLAGS.
- Configurations/PluginService.32.xcconfig: Ditto.
- Configurations/PluginService.64.xcconfig: Ditto.
- 12:22 AM Changeset in webkit [157560] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Too many arguments for format in WebKitWebAudioSourceGStreamer.cpp
https://bugs.webkit.org/show_bug.cgi?id=122932
Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-17
Reviewed by Philippe Normand.
No new tests because this just fixes a build warning.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop): Add another %s for the second part of the pad name.
- 12:20 AM Changeset in webkit [157559] by
-
- 14 edits in trunk/Source/JavaScriptCore
Transition remaining op_get* JITStubs to JIT operations.
https://bugs.webkit.org/show_bug.cgi?id=122925.
Reviewed by Geoffrey Garen.
Transitioning:
cti_op_get_by_id_generic
cti_op_get_by_val
cti_op_get_by_val_generic
cti_op_get_by_val_string
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_get_arguments_length):
(JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_get_arguments_length):
(JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_pname):
(JSC::JIT::privateCompileGetByVal):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_pname):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- runtime/Executable.cpp:
(JSC::setupLLInt): Added some UNUSED_PARAMs to fix the no LLINT build.
- runtime/Options.cpp:
(JSC::Options::initialize):
Oct 16, 2013:
- 8:47 PM Changeset in webkit [157558] by
-
- 6 edits in trunk
libllvmForJSC shouldn't call exit(1) on report_fatal_error()
https://bugs.webkit.org/show_bug.cgi?id=122905
<rdar://problem/15237856>
Source/JavaScriptCore:
Reviewed by Michael Saboff.
Expose the new LLVMInstallFatalErrorHandler() API through the soft linking magic and
then always call it to install something that calls CRASH().
- llvm/InitializeLLVM.cpp:
(JSC::llvmCrash):
(JSC::initializeLLVMOnce):
(JSC::initializeLLVM):
- llvm/LLVMAPIFunctions.h:
WebKitLibraries:
Reviewed by Michael Saboff.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 8:36 PM Changeset in webkit [157557] by
-
- 2 edits in trunk/Tools
We need test coverage for just the Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=122929
Reviewed by Sam Weinig.
Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
variant.
- Scripts/run-jsc-stress-tests:
- 8:29 PM Changeset in webkit [157556] by
-
- 2 edits in trunk/Source/JavaScriptCore
Prototype chain repatching in the polymorphic case fails to check if the receiver is a dictionary
https://bugs.webkit.org/show_bug.cgi?id=122938
Reviewed by Sam Weinig.
This fixes jsc-layout-tests.yaml/js/script-tests/dictionary-prototype-caching.js.layout-no-llint.
- jit/Repatch.cpp:
(JSC::tryBuildGetByIDList):
- 8:10 PM Changeset in webkit [157555] by
-
- 1 edit19 adds in trunk
Add a new flakiness dashboard clone
https://bugs.webkit.org/show_bug.cgi?id=122936
Reviewed by Anders Carlsson.
Added the initial prototype.
- Websites/test-results: Added.
- Websites/test-results/.htaccess: Added.
- Websites/test-results/admin: Added.
- Websites/test-results/admin/index.php: Added.
- Websites/test-results/api: Added.
- Websites/test-results/api/manifest.php: Added.
- Websites/test-results/api/report.php: Added.
- Websites/test-results/api/results.php: Added.
- Websites/test-results/include: Added.
- Websites/test-results/include/config.json: Added.
- Websites/test-results/include/db.php: Added.
- Websites/test-results/include/init-database.sql: Added.
- Websites/test-results/include/json-shared.php: Added.
- Websites/test-results/include/test-results.php: Added.
- Websites/test-results/index.html: Added.
- Websites/test-results/js: Added.
- Websites/test-results/js/autocompleter.js: Added.
- Websites/test-results/js/build.js: Added.
- Websites/test-results/js/dom.js: Added.
- 8:01 PM Changeset in webkit [157554] by
-
- 2 edits in trunk/Source/JavaScriptCore
JIT::appendCall() needs to killLastResultRegister() or equivalent since there's some really bad code that expects it
https://bugs.webkit.org/show_bug.cgi?id=122937
Reviewed by Geoffrey Garen.
JITStubCall used to do it.
This makes mozilla-tests.yaml/ecma/Statements/12.10-1.js.mozilla-baseline pass.
- jit/JIT.h:
(JSC::JIT::appendCall):
- 7:36 PM Changeset in webkit [157553] by
-
- 3 edits in trunk/Tools
Support multiple repositories in submitting results to --results-server-host
https://bugs.webkit.org/show_bug.cgi?id=122935
Reviewed by Anders Carlsson.
Remoevd --got-revision and added the logic to extract revision information
from multiple repositories as done in run-perf-tests.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.upload_results):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 7:12 PM Changeset in webkit [157552] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155607.
- platform/efl-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added.
- platform/efl-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added.
- 7:04 PM Changeset in webkit [157551] by
-
- 2 edits in trunk/Source/WebKit/win
Attempt to fix the Windows build after http://trac.webkit.org/changeset/157547.
Apparently some *more* Windows code uses setFrame and I missed it.
- FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerLayoutSublayersOfLayer):
- 6:58 PM Changeset in webkit [157550] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Windows build after http://trac.webkit.org/changeset/157547.
The relevant conversion doesn't happen implicitly.
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc):
- 6:54 PM Changeset in webkit [157549] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r156527.
- platform/efl/compositing/contents-opaque/hidden-with-visible-text-expected.txt:
- platform/efl/svg/text/append-text-node-to-tspan-expected.txt:
- 6:53 PM Changeset in webkit [157548] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Windows build after http://trac.webkit.org/changeset/157547.
Apparently some Windows code uses setFrame and I missed it.
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc):
- 6:46 PM Changeset in webkit [157547] by
-
- 13 edits in trunk/Source
Remote Layer Tree: Complete support for simple layer properties
https://bugs.webkit.org/show_bug.cgi?id=122933
Reviewed by Anders Carlsson.
Add remote layer tree support for maskLayer, contentsRect, contentsScale,
minificationFilter, magnificationFilter, speed, and timeOffset.
No new tests, not yet testable.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpProperty):
(WebKit::dumpChangedLayers):
Add the new properties.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::toCAFilterType):
(WebKit::RemoteLayerTreeHost::commit):
Apply the new properties.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::setSublayers):
(PlatformCALayerRemote::appendSublayer):
(PlatformCALayerRemote::insertSublayer):
Ensure that passed-in sublayers are always also PlatformCALayerRemote instances.
These are ASSERT_WITH_SECURITY_IMPLICATION as we will later unconditionally static_cast
them to PlatformCALayerRemote.
(PlatformCALayerRemote::setMask):
(PlatformCALayerRemote::setContentsRect):
(PlatformCALayerRemote::setMinificationFilter):
(PlatformCALayerRemote::setMagnificationFilter):
(PlatformCALayerRemote::setSpeed):
(PlatformCALayerRemote::setTimeOffset):
(PlatformCALayerRemote::contentsScale):
(PlatformCALayerRemote::setContentsScale):
Remove setFrame, store the new properties.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Remove setFrame, add isRemote, fix pointer side on playerLayer.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setName):
Don't dump the CALayer pointer if we own a PlatformCALayerRemote.
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
Fix the visible tile wash (my fault!), and make it use setPosition and
setBounds instead of setFrame; while more convenient, it is the only
caller of setFrame, so we'll remove it.
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::isRemote): Added.
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(nullActionsDictionary):
(toCAFilterType):
(PlatformCALayerMac::synchronouslyDisplayTilesInRect):
(PlatformCALayerMac::playerLayer):
Remove setFrame, fix some pointer sides.
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
- platform/graphics/ca/win/PlatformCALayerWin.h:
Remove setFrame.
- 6:23 PM Changeset in webkit [157546] by
-
- 11 edits in trunk/Source/JavaScriptCore
transition void cti_op_put_by_val* stubs to JIT operations
https://bugs.webkit.org/show_bug.cgi?id=122903
Reviewed by Geoffrey Garen.
Transitioned cti_op_put_by_val and cti_op_put_by_val_generic to operationPutByVal and
operationPutByValGeneric.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::privateCompilePutByVal):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_put_by_val):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JSInterfaceJIT.h:
- 6:02 PM Changeset in webkit [157545] by
-
- 16 edits3 adds in trunk
Source/JavaScriptCore: Implement ES6 spread operator
https://bugs.webkit.org/show_bug.cgi?id=122911
Reviewed by Michael Saboff.
Implement the ES6 spread operator
This has a little bit of refactoring to move the enumeration logic out ForOfNode
and into BytecodeGenerator, and then adds the logic to make it nicely callback
driven.
The rest of the logic is just the addition of the SpreadExpressionNode, the parsing,
and actually handling the spread.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitEnumeration):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::SpreadExpressionNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createSpreadExpression):
- parser/Lexer.cpp:
(JSC::::lex):
- parser/NodeConstructors.h:
(JSC::SpreadExpressionNode::SpreadExpressionNode):
- parser/Nodes.h:
(JSC::ExpressionNode::isSpreadExpression):
(JSC::SpreadExpressionNode::expression):
- parser/Parser.cpp:
(JSC::::parseArrayLiteral):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
- parser/Parser.h:
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
- parser/ParserTokens.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createSpreadExpression):
LayoutTests: Implement spread
https://bugs.webkit.org/show_bug.cgi?id=122911
Reviewed by Michael Saboff.
Add testcases
- js/basic-spread-expected.txt: Added.
- js/basic-spread.html: Added.
- js/parser-syntax-check-expected.txt:
- js/script-tests/basic-spread.js: Added.
(f):
(o.f.o.f.o.f.o.f.h.eval.o.h.o.h.o.h.o.h.g):
- js/script-tests/parser-syntax-check.js:
- 5:25 PM Changeset in webkit [157544] by
-
- 5 edits in trunk/Source
Unreviewed build fix attempt on EFL port after r157520 and r157523
Source/WebKit2:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
Removed ArgumentCoder<TransformationMatrix> which caused redefinition build error
in EFL port.
Source/WTF:
- wtf/PassRef.h: includes <utility>
- 5:15 PM Changeset in webkit [157543] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add a useLLInt option to jsc
https://bugs.webkit.org/show_bug.cgi?id=122930
Reviewed by Geoffrey Garen.
- runtime/Executable.cpp:
(JSC::setupLLInt):
(JSC::setupJIT):
(JSC::ScriptExecutable::prepareForExecutionImpl):
- runtime/Options.h:
- 4:57 PM Changeset in webkit [157542] by
-
- 1 edit1 add in trunk/Source/JavaScriptCore
Build fix.
Forgot to svn add DeferGC.cpp
- heap/DeferGC.cpp: Added.
- 4:49 PM Changeset in webkit [157541] by
-
- 2 edits in trunk/Source/JavaScriptCore
r157411 fails run-javascriptcore-tests when run with Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=122902
Reviewed by Mark Hahnenberg.
It turns out that this was a long-standing bug in the DFG PutById repatching logic. It's
not legal to patch if the typeInfo tells you that you can't patch. The old JIT's patching
logic did this right, and the DFG's GetById patching logic did it right; but DFG PutById
didn't. Turns out that there's even a helpful method,
Structure::propertyAccessesAreCacheable(), that will even do all of the checks for you!
- jit/Repatch.cpp:
(JSC::tryCachePutByID):
- 4:48 PM Changeset in webkit [157540] by
-
- 3 edits in trunk/Websites/webkit.org
Publish SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122923
Reviewed by Darin Adler.
- perf/sunspider/sunspider.html:
- perf/sunspider/versions.html:
- 4:47 PM Changeset in webkit [157539] by
-
- 17 edits in trunk/Source/JavaScriptCore
llint_slow_path_put_by_id can deadlock on a ConcurrentJITLock
https://bugs.webkit.org/show_bug.cgi?id=122667
Reviewed by Geoffrey Garen.
The issue this patch is attempting to fix is that there are places in our codebase
where we acquire the ConcurrentJITLock for a particular CodeBlock, then we do some
operations that can initiate a garbage collection. Garbage collection then calls
some methods of CodeBlock that also take the ConcurrentJITLock (because they don't
always necessarily run during garbage collection). This causes a deadlock.
To fix this issue, this patch adds a new RAII-style object (DisallowGC) that stores
into a thread-local field that indicates that it is unsafe to perform any operation
that could trigger garbage collection on the current thread. In debug builds,
ConcurrentJITLocker contains one of these DisallowGC objects so that we can eagerly
detect deadlocks.
This patch also adds a new type of ConcurrentJITLocker, GCSafeConcurrentJITLocker,
which uses the DeferGC mechanism to prevent collections from occurring while the
lock is held.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/DeferGC.h:
(JSC::DisallowGC::DisallowGC):
(JSC::DisallowGC::~DisallowGC):
(JSC::DisallowGC::isGCDisallowedOnCurrentThread):
(JSC::DisallowGC::initialize):
- jit/Repatch.cpp:
(JSC::repatchPutByID):
(JSC::buildPutByIdList):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/ConcurrentJITLock.h:
(JSC::ConcurrentJITLockerBase::ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::~ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::unlockEarly):
(JSC::GCSafeConcurrentJITLocker::GCSafeConcurrentJITLocker):
(JSC::GCSafeConcurrentJITLocker::~GCSafeConcurrentJITLocker):
(JSC::GCSafeConcurrentJITLocker::NoDefer::NoDefer):
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSCellInlines.h:
(JSC::allocateCell):
- runtime/JSSymbolTableObject.h:
(JSC::symbolTablePut):
- runtime/Structure.cpp: materializePropertyMapIfNecessary* now has a problem in that it
can start a garbage collection when the GCSafeConcurrentJITLocker goes out of scope, but
before the caller has a chance to use the newly created PropertyTable. The garbage collection
clears the PropertyTable, and then the caller uses it assuming it's valid. To avoid this,
we must DeferGC until the caller is done getting the newly materialized PropertyTable from
the Structure.
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::takePropertyTableOrCloneIfPinned):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
- runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
- runtime/StructureInlines.h:
(JSC::Structure::get):
- runtime/SymbolTable.h:
(JSC::SymbolTable::find):
(JSC::SymbolTable::end):
- 4:42 PM Changeset in webkit [157538] by
-
- 1 edit1 delete in trunk/Source/WebKit2
Remove Qt sandbox process code
https://bugs.webkit.org/show_bug.cgi?id=122920
Reviewed by Geoffrey Garen.
This code was only used by the Qt port, and the other Linux-based ports are using the seccomp based sandbox.
- Shared/linux/SandboxProcess/SandboxEnvironmentLinux.cpp: Removed.
- Shared/linux/SandboxProcess/SandboxEnvironmentLinux.h: Removed.
- 4:36 PM Changeset in webkit [157537] by
-
- 9 edits in trunk/Source/JavaScriptCore
Add SPI to disable the garbage collector timer
https://bugs.webkit.org/show_bug.cgi?id=122921
Reviewed by Geoffrey Garen.
Based on a patch by Mark Hahnenberg.
- API/JSBase.cpp:
(JSDisableGCTimer): Added; SPI function.
- API/JSBasePrivate.h:
- heap/BlockAllocator.cpp:
(JSC::createBlockFreeingThread): Added.
(JSC::BlockAllocator::BlockAllocator): Modified to use JSC::createBlockFreeingThread()
to conditionally create the "block freeing" thread depending on the value of
GCActivityCallback::s_shouldCreateGCTimer.
(JSC::BlockAllocator::~BlockAllocator):
- heap/BlockAllocator.h:
(JSC::BlockAllocator::deallocate):
- heap/Heap.cpp:
(JSC::Heap::didAbandon):
(JSC::Heap::collect):
(JSC::Heap::didAllocate):
- heap/HeapTimer.cpp:
(JSC::HeapTimer::timerDidFire):
- runtime/GCActivityCallback.cpp:
- runtime/GCActivityCallback.h:
(JSC::DefaultGCActivityCallback::create): Only instantiate a DefaultGCActivityCallback object
when GCActivityCallback::s_shouldCreateGCTimer is true so as to prevent allocating a HeapTimer
object (since DefaultGCActivityCallback ultimately extends HeapTimer).
- 3:33 PM Changeset in webkit [157536] by
-
- 15 edits3 deletes in trunk
Unreviewed, rolling out r157529.
http://trac.webkit.org/changeset/157529
https://bugs.webkit.org/show_bug.cgi?id=122919
Caused score test failures and some build failures. (Requested
by rfong on #webkit).
Source/JavaScriptCore:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
(JSC::CallArguments::CallArguments):
(JSC::ForOfNode::emitBytecode):
(JSC::BindingNode::collectBoundIdentifiers):
- parser/ASTBuilder.h:
- parser/Lexer.cpp:
(JSC::::lex):
- parser/NodeConstructors.h:
(JSC::DotAccessorNode::DotAccessorNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::::parseArrayLiteral):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
- parser/Parser.h:
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
- parser/ParserTokens.h:
- parser/SyntaxChecker.h:
LayoutTests:
- js/basic-spread-expected.txt: Removed.
- js/basic-spread.html: Removed.
- js/parser-syntax-check-expected.txt:
- js/script-tests/basic-spread.js: Removed.
- js/script-tests/parser-syntax-check.js:
- 3:28 PM Changeset in webkit [157535] by
-
- 167 edits in trunk/Source/WebCore
Take RenderObjects out of the arena.
<https://webkit.org/b/122895>
Reviewed by Antti Koivisto.
Stop arena-allocating renderers so we can move forward on improving
render tree memory management. This will also allow rendering code
to take advantage of malloc optimizations.
Line boxes and BiDi runs remain in the arena for now.
- 3:20 PM Changeset in webkit [157534] by
-
- 13 edits2 adds in trunk
A page should exit fullscreen mode if it opens a new popup
https://bugs.webkit.org/show_bug.cgi?id=122865
Reviewed by Jer Noble.
Source/WebKit/blackberry:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
Source/WebKit/efl:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::createWindow):
Source/WebKit/gtk:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::createWindow):
Source/WebKit/mac:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createWindow):
Source/WebKit/win:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::createWindow):
Source/WebKit2:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
LayoutTests:
- fullscreen/full-screen-exit-when-popup-expected.txt: Added.
- fullscreen/full-screen-exit-when-popup.html: Added.
- 3:17 PM Changeset in webkit [157533] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Speculative fix for test, media/video-canvas-drawing-output.html.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::createImageForTimeInRect):
- 3:10 PM Changeset in webkit [157532] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove useless architecture specific implementation in DFG.
https://bugs.webkit.org/show_bug.cgi?id=122917.
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-16
Reviewed by Michael Saboff.
With CPU(ARM) && CPU(ARM_HARDFP) architecture, the fallback implementation is fine
as FPRInfo::argumentFPR0 == FPRInfo::returnValueFPR in this case.
- dfg/DFGSpeculativeJIT.h:
- 3:02 PM Changeset in webkit [157531] by
-
- 2 edits in trunk/Source/WebKit2
Blind attempt to fix non-DATABASE_PROCESS builds.
- WebProcess/WebProcess.cpp:
- 2:37 PM Changeset in webkit [157530] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove unused JIT::restoreArgumentReferenceForTrampoline function.
https://bugs.webkit.org/show_bug.cgi?id=122916.
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-16
Reviewed by Michael Saboff.
This architecture specific function is not used anymore, so get rid of it.
- jit/JIT.h:
- jit/JITInlines.h:
- 2:27 PM Changeset in webkit [157529] by
-
- 15 edits3 adds in trunk
Source/JavaScriptCore: Implement ES6 spread operator
https://bugs.webkit.org/show_bug.cgi?id=122911
Reviewed by Michael Saboff.
Implement the ES6 spread operator
This has a little bit of refactoring to move the enumeration logic out ForOfNode
and into BytecodeGenerator, and then adds the logic to make it nicely callback
driven.
The rest of the logic is just the addition of the SpreadExpressionNode, the parsing,
and actually handling the spread.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitEnumeration):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::SpreadExpressionNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createSpreadExpression):
- parser/Lexer.cpp:
(JSC::::lex):
- parser/NodeConstructors.h:
(JSC::SpreadExpressionNode::SpreadExpressionNode):
- parser/Nodes.h:
(JSC::ExpressionNode::isSpreadExpression):
(JSC::SpreadExpressionNode::expression):
- parser/Parser.cpp:
(JSC::::parseArrayLiteral):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
- parser/Parser.h:
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
- parser/ParserTokens.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createSpreadExpression):
LayoutTests: Implement spread
https://bugs.webkit.org/show_bug.cgi?id=122911
Reviewed by Michael Saboff.
Add testcases
- js/basic-spread-expected.txt: Added.
- js/basic-spread.html: Added.
- js/parser-syntax-check-expected.txt:
- js/script-tests/basic-spread.js: Added.
(f):
(o.f.o.f.o.f.o.f.h.eval.o.h.o.h.o.h.o.h.g):
- js/script-tests/parser-syntax-check.js:
- 2:20 PM Changeset in webkit [157528] by
-
- 6 edits in trunk/Source
PlatformCALayer constructor should take layer type as an argument
https://bugs.webkit.org/show_bug.cgi?id=122915
Reviewed by Simon Fraser.
No new tests, just a minor refactoring.
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::PlatformCALayer):
Add a LayerType argument.
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::PlatformCALayerMac):
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::PlatformCALayerWin):
Use the new LayerType argument, and early-return in the case where we
are wrapping a custom PlatformLayer.
Drive-by un-indent the switch in the Mac version.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::PlatformCALayerRemote):
Use the new LayerType argument.
- 2:19 PM Changeset in webkit [157527] by
-
- 2 edits in trunk/Source/WebKit2
Remote Layer Tree: Use a default instead of an environment variable
https://bugs.webkit.org/show_bug.cgi?id=122913
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView std::WebKit::]):
Use the default 'WebKit2UseRemoteLayerTreeDrawingArea' instead of
the environment variable 'WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA'
to indicate that WKViews should make RemoteLayerTreeDrawingAreas.
- 1:47 PM Changeset in webkit [157526] by
-
- 5 edits in trunk/Source
Versioning.
- 1:01 PM Changeset in webkit [157525] by
-
- 1 copy in tags/Safari-538.2
New Tag.
- 12:27 PM Changeset in webkit [157524] by
-
- 19 edits4 copies2 adds in trunk/Source
Flesh out the DatabaseProcess (and launch it!)
https://bugs.webkit.org/show_bug.cgi?id=122884
Reviewed by Tim Horton.
Source/WebCore:
- English.lproj/Localizable.strings: Add a localizable string.
- WebCore.xcodeproj/project.pbxproj: Export some more headers.
Source/WebKit2:
This patch adds actual process launching and basic messaging infrastructure for the DatabaseProcess.
It still does very little except exist.
Project file stuff:
- WebKit2.xcodeproj/project.pbxproj:
- DerivedSources.make:
WebContext owns the DatabaseProcess (much like the NetworkProcess):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureDatabaseProcess):
(WebKit::WebContext::getDatabaseProcessConnection):
- UIProcess/WebContext.h:
Add a basic DatabaseProcess that - for now - can only return a new Connection for a WebProcess:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::createDatabaseToWebProcessConnection):
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/DatabaseProcess.messages.in: Added.
Add an object to represent a single connection to a single WebProcess:
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::create):
(WebKit::DatabaseToWebProcessConnection::DatabaseToWebProcessConnection):
(WebKit::DatabaseToWebProcessConnection::~DatabaseToWebProcessConnection):
(WebKit::DatabaseToWebProcessConnection::didReceiveMessage):
(WebKit::DatabaseToWebProcessConnection::didClose):
(WebKit::DatabaseToWebProcessConnection::didReceiveInvalidMessage):
- DatabaseProcess/DatabaseToWebProcessConnection.h:
Basic DatabaseProcessProxy with the ability to ask the DatabaseProcess for a connection to hand back to a WebProcess:
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::DatabaseProcessProxy):
(WebKit::DatabaseProcessProxy::getDatabaseProcessConnection):
(WebKit::DatabaseProcessProxy::didCreateDatabaseToWebProcessConnection):
(WebKit::DatabaseProcessProxy::didFinishLaunching):
- UIProcess/Databases/DatabaseProcessProxy.h:
- UIProcess/Databases/DatabaseProcessProxy.messages.in: Added.
Add an object to represent a WebProcess’s connection to a DatabaseProcess:
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
(WebKit::WebToDatabaseProcessConnection::WebToDatabaseProcessConnection):
(WebKit::WebToDatabaseProcessConnection::~WebToDatabaseProcessConnection):
(WebKit::WebToDatabaseProcessConnection::didReceiveMessage):
(WebKit::WebToDatabaseProcessConnection::didClose):
(WebKit::WebToDatabaseProcessConnection::didReceiveInvalidMessage):
- WebProcess/Databases/WebToDatabaseProcessConnection.h:
(WebKit::WebToDatabaseProcessConnection::create):
(WebKit::WebToDatabaseProcessConnection::connection):
Give WebProcess(Proxy) an accessor for a Web -> Database process connection:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webToDatabaseProcessConnectionClosed):
(WebKit::WebProcess::webToDatabaseProcessConnection):
(WebKit::WebProcess::ensureWebToDatabaseProcessConnection):
- WebProcess/WebProcess.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getDatabaseProcessConnection):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::open): Access the database process connection to test that it works.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createIDBFactoryBackend): Keep non-DATABASE_PROCESS builds working.
- 12:04 PM Changeset in webkit [157523] by
-
- 13 edits in trunk/Source
RemoteLayerTree: Add support for more layer properties and transform layers
https://bugs.webkit.org/show_bug.cgi?id=122906
Reviewed by Anders Carlsson.
Add support for name, border width, border color, opacity, transform, sublayer transform,
hidden, geometry flipped, double sided, masks to bounds, and opaque layer properties.
Factor layer creation out from layer changes, so that we can create layers of the correct
type. Use this mechanism to create CATransformLayers when handed a LayerTypeTransformLayer.
No new tests, this code is not yet testable.
- WebCore.exp.in:
Export some TextStream and TransformationMatrix stuff.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- Shared/WebCoreArgumentCoders.h:
Add coders for TransformationMatrix.
- Shared/mac/RemoteLayerTreeTransaction.h:
Add the new LayerChange values.
(WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged):
LayerProperties::layerChanges should be a LayerChange.
(WebKit::RemoteLayerTreeTransaction::createdLayers):
Expose the list of newly created layers (for RemoteLayerTreeHost's consumption).
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
Add (and support coding) a new LayerCreationProperties struct, which is currently
just a pair of LayerID and PlatformCALayer::LayerType. Additional properties may follow.
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Encode and decode all of the new layer properties.
Encode changedProperties as an enum, not an unsigned.
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
Encode and decode the list of newly created layers.
(WebKit::RemoteLayerTreeTransaction::setCreatedLayers):
Setter for the list of newly created layers, which comes from the
RemoteLayerTreeContext at commit time.
(WebKit::dumpProperty):
Helper function to dump TransformationMatrix instances.
(WebKit::dumpChangedLayers):
Dump all of the new layer properties.
(WebKit::RemoteLayerTreeTransaction::dump):
Dump the list of newly created layers.
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::cgColorFromColor):
Factor out the code to make a CGColor from a WebCore::Color, as we need it
for both border and background color.
(WebKit::RemoteLayerTreeHost::commit):
Create layers before applying changes, using the new list of newly created layers.
When applying changes, ensure that the layer we're interested in was already created.
Rename "sublayer" to "layer", and use dot notation everywhere.
Apply all the new layer properties to the layers.
(WebKit::RemoteLayerTreeHost::getLayer):
(WebKit::RemoteLayerTreeHost::createLayer):
Separate creating a new layer from retrieving it by ID.
Ensure that a layer doesn't already exist when creating it.
Support creating CATransformLayers.
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
Disable accelerated animations, as we don't support proxying animations yet.
This makes GraphicsLayer fall back to software animations, which already work wonderfully remotely.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::PlatformCALayerRemote):
Inform the RemoteLayerTreeContext of the creation of every PlatformCALayerRemote.
(PlatformCALayerRemote::removeFromSuperlayer):
(PlatformCALayerRemote::replaceSublayer):
(PlatformCALayerRemote::adoptSublayers):
Assert when we hit a few critical unimplemented methods that would
leave the layer tree in a broken state.
(PlatformCALayerRemote::isOpaque):
(PlatformCALayerRemote::setOpaque):
(PlatformCALayerRemote::transform):
(PlatformCALayerRemote::setTransform):
(PlatformCALayerRemote::sublayerTransform):
(PlatformCALayerRemote::setSublayerTransform):
(PlatformCALayerRemote::setHidden):
(PlatformCALayerRemote::setGeometryFlipped):
(PlatformCALayerRemote::isDoubleSided):
(PlatformCALayerRemote::setDoubleSided):
(PlatformCALayerRemote::masksToBounds):
(PlatformCALayerRemote::setMasksToBounds):
(PlatformCALayerRemote::setBorderWidth):
(PlatformCALayerRemote::setBorderColor):
(PlatformCALayerRemote::opacity):
(PlatformCALayerRemote::setOpacity):
(PlatformCALayerRemote::setName):
Proxy all of these properties via RemoteLayerTreeTransaction.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
Add storage for the list of newly created layers.
Use LayerID for the list of destroyed layers.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerWasCreated):
Store the ID and type of the newly created layer to be pushed to the UI process later.
(WebKit::RemoteLayerTreeContext::flushLayers):
Push the created and destroyed layers to the transaction *after* flushing
GraphicsLayers, so that any changes to e.g. structural layers will not be missed.
- 10:35 AM Changeset in webkit [157522] by
-
- 3 edits2 adds in trunk
During editing, merge inline style with overriding other author styles
https://bugs.webkit.org/show_bug.cgi?id=122874
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-10-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
Inline styles need to override other author styles even on DoNotOverrideValues mode.
So, merge and override inline styles to other author styles before merging them to m_mutableStyle.
Test: editing/deleting/merge-div-with-inline-style.html
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
LayoutTests:
Add a test for merging inline styles of parents.
- editing/deleting/merge-div-with-inline-style.html: Added.
- editing/deleting/merge-div-with-inline-style-expected.txt: Added.
- 10:26 AM Changeset in webkit [157521] by
-
- 4 edits in trunk/Source/JavaScriptCore
Transition void cti_op_tear_off* methods to JIT operations for 32 bit.
https://bugs.webkit.org/show_bug.cgi?id=122899.
Reviewed by Michael Saboff.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 10:18 AM Changeset in webkit [157520] by
-
- 13 edits1 add in trunk
Add PassRef and createRefCounted so we can improve creation of RefCounted objects
https://bugs.webkit.org/show_bug.cgi?id=122904
Reviewed by Anders Carlsson.
Source/WTF:
- GNUmakefile.list.am: Added PassRef.h.
- WTF.vcxproj/WTF.vcxproj: Ditto.
- WTF.vcxproj/WTF.vcxproj.filters: Ditto.
- WTF.xcodeproj/project.pbxproj: Ditto.
- wtf/CMakeLists.txt: Ditto.
- wtf/Forward.h: Added PassRef. Also re-sorted and un-indented to match what
the style-checking script expects.
- wtf/PassRef.h: Added. Includes the createRefCounted function template, which
is analogous to make_unique, but is for reference counted objects, and also
assumes that new will never return null. Also includes an overload of adoptRef
that takes a reference rather than a pointer.
- wtf/PassRefPtr.h: Include "PassRef.h" so we can share the adopted function.
Got rid of declarations that duplicate ones in there.
(WTF::refIfNotNull): Use nullptr.
(WTF::derefIfNotNull): Use nullptr.
(WTF::PassRefPtr::PassRefPtr): Use nullptr. Added an overload that takes a PassRef.
(WTF::PassRefPtr::operator UnspecifiedBoolType): Use nullptr.
(WTF::PassRefPtr::operator=): Made this deleted instead of compile time assertion.
(WTF::PassRefPtr::PassRefPtr): Made adopting constructor use an adopt tag instead
of an unused boolean.
(WTF::PassRefPtr::leakRef): Use nullptr.
(WTF::adoptRef): Use the adopt tag.
- wtf/Ref.h: Use Noncopyable instead of rolling our own.
(WTF::Ref::Ref): Add an overload that takes a PassRef.
(WTF::Ref::operator=): Ditto.
- wtf/RefPtr.h: Removed unneeded forward declaration of PassRefPtr.
(WTF::RefPtr::RefPtr): Use nullptr. Added overload that takes a PassRef.
(WTF::RefPtr::release): Use nullptr.
(WTF::RefPtr::operator UnspecifiedBoolType): Use nullptr.
(WTF::RefPtr::operator=): Added overload that takes a PassRef.
(WTF::RefPtr::clear): Use nullptr.
- wtf/StdLibExtras.h: Added inline keyword to isPointerTypeAlignmentOkay,
reinterpret_cast_ptr, and make_unique. Seems like a simple oversight that these
were missing before.
Tools:
- TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
- 10:11 AM Changeset in webkit [157519] by
-
- 2 edits in trunk/Tools
Need tests for RefPtr self-assignment and self-move-assignment.
- TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
- 9:57 AM Changeset in webkit [157518] by
-
- 4 edits2 adds in trunk
Emphasis marks has wrong color.
https://bugs.webkit.org/show_bug.cgi?id=122829
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-16
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: fast/text/text-emphasis.html.
fast/text/text-emphasis-expected.html.
Emphasis color should be set as fill color, not stroke color.
- rendering/TextPaintStyle.cpp:
(WebCore::updateGraphicsContext):
- rendering/TextPaintStyle.h:
LayoutTests:
- fast/text/text-emphasis-expected.html: Added.
- fast/text/text-emphasis.html: Added.
- 7:33 AM Changeset in webkit [157517] by
-
- 7 edits in trunk/Source/WebCore
Move code for finding rendered character offset to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122892
Reviewed by Andreas Kling.
- rendering/RenderText.cpp:
(WebCore::RenderText::countRenderedCharacterOffsets):
(WebCore::RenderText::containsRenderedCharacterOffset):
Renamed for consistency.
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::countCharacterOffsets):
This used to be Position::renderedPosition.
- 6:03 AM Changeset in webkit [157516] by
-
- 1 copy in releases/WebKitGTK/webkit-2.2.1
Tagging the WebKitGTK+ 2.2.1 release
- 5:40 AM Changeset in webkit [157515] by
-
- 28 edits in trunk/Source/WebCore
RenderElement::removeChild() should take child as a reference.
<https://webkit.org/b/122888>
We can't remove a child without a child to remove.
Reviewed by Antti Koivisto.
- 5:24 AM Changeset in webkit [157514] by
-
- 10 edits in trunk/Source/WebCore
Move test for contained caret offset to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122887
Reviewed by Andreas Kling.
- dom/Position.cpp:
(WebCore::Position::renderedOffset):
(WebCore::Position::isCandidate):
Remove isRenderedText, call RenderText::containsCaretOffset instead.
(WebCore::Position::isRenderedCharacter):
(WebCore::Position::rendersInDifferentPosition):
- dom/Position.h:
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
- rendering/InlineTextBox.cpp:
- rendering/InlineTextBox.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::containsCharacterOffset):
(WebCore::RenderText::containsCaretOffset):
- rendering/RenderText.h:
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::containsOffset):
Combined implementations of Position::isRenderedCharacter and Position::isRenderedText.
- rendering/RenderTextLineBoxes.h:
Remove containsCaretOffset(), functionality is now in RenderTextLineBoxes::containsOffset.
- 4:07 AM Changeset in webkit [157513] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155998.
- platform/efl-wk2/compositing/contents-scale/animating-expected.txt: Added.
- platform/efl-wk2/compositing/contents-scale/scaled-ancestor-expected.txt: Added.
- platform/efl-wk2/compositing/contents-scale/simple-scale-expected.txt: Added.
- platform/efl-wk2/compositing/contents-scale/z-translate-expected.txt: Added.
- 3:34 AM Changeset in webkit [157512] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip the IndexedDB tests for now as the feature is going through substantial
changes that don't ensure constant proper functionality.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 3:29 AM Changeset in webkit [157511] by
-
- 1 edit51 adds in trunk/LayoutTests
Revert Windows-specific expectations shuffling from r157497.
This wasn't wrong either. Shame on me. :|
- 2:52 AM Changeset in webkit [157510] by
-
- 7 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155957.
- platform/efl/css3/selectors3/html/css3-modsel-179a-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-179a-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-179a-expected.txt:
- platform/efl/fast/css/pseudo-first-line-border-width-expected.txt:
- platform/efl/fast/css/word-space-extra-expected.txt:
- platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
- 2:34 AM Changeset in webkit [157509] by
-
- 26 edits in trunk/Source/WebCore
RenderElement::isChildAllowed() should take const references.
<https://webkit.org/b/122870>
Reviewed by Anders Carlsson.
The isChildAllowed() functions expect non-null values to be passed,
so enforce this at compile-time.
Reordered some checks to do bit tests before virtual calls.
- 2:24 AM Changeset in webkit [157508] by
-
- 1 edit22 adds in trunk/LayoutTests
Revert Mac-specific expecations shuffling from r157498.
Everything was already in order.
- 2:23 AM Changeset in webkit [157507] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2
Unreviewed. Update NEWS and Versions.m4 for 2.2.1 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Add release notes.
- 2:18 AM Changeset in webkit [157506] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] video info unset if upstream doesn't query allocation
https://bugs.webkit.org/show_bug.cgi?id=122834
Reviewed by Gustavo Noronha Silva.
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender): If the sink didn't process any allocation
query then use the configured source pad caps and don't rely on
invalid video info.
- 2:15 AM Changeset in webkit [157505] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] move Logging.h include to GStreamerUtilities.h
https://bugs.webkit.org/show_bug.cgi?id=122886
Reviewed by Gustavo Noronha Silva.
Include Logging.h from GStreamerUtilities.h so the modules using
the LOG_MEDIA macros don't need to bother, especially for Debug builds.
- platform/graphics/gstreamer/GStreamerUtilities.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
- 2:07 AM Changeset in webkit [157504] by
-
- 6 edits in trunk
[WK2][Efl][CMake] Add support for ENABLE_NETWORK_PROCESS to the build system
https://bugs.webkit.org/show_bug.cgi?id=110139
Reviewed by Laszlo Gombos.
Original patch by Balazs Kelemen <kbalazs@webkit.org>
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebKit2:
- CMakeLists.txt:
- PlatformEfl.cmake:
- 1:51 AM Changeset in webkit [157503] by
-
- 1 edit347 deletes in trunk/LayoutTests
Remove EFL-specific test expectations that were identical to generic expectations.
<https://webkit.org/b/121551>
Reviewed by Antti Koivisto.
- platform/efl-wk2/webaudio/javascriptaudionode-expected.txt: Removed.
- platform/efl/compositing/culling/filter-occlusion-blur-expected.txt: Removed.
- platform/efl/compositing/culling/filter-occlusion-blur-large-expected.txt: Removed.
- platform/efl/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Removed.
- platform/efl/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Removed.
- platform/efl/compositing/iframes/composited-iframe-scroll-expected.txt: Removed.
- platform/efl/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
- platform/efl/compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Removed.
- platform/efl/compositing/images/content-image-change-expected.txt: Removed.
- platform/efl/css1/units/rounding-expected.txt: Removed.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-circle-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-circle-filter-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-circle-overflow-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-ellipse-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-polygon-evenodd-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-polygon-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-polygon-nonzero-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-rectangle-expected.txt: Removed.
- platform/efl/editing/deleting/transpose-empty-expected.txt: Removed.
- platform/efl/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
- platform/efl/editing/selection/drag-start-event-client-x-y-expected.txt: Removed.
- platform/efl/fast/backgrounds/bgCompositeCopy-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize01-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize02-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize03-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize04-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize05-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize06-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize07-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize08-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize09-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize10-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize11-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize12-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize13-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize14-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
- platform/efl/fast/block/basic/fieldset-stretch-to-legend-expected.txt: Removed.
- platform/efl/fast/block/basic/quirk-percent-height-grandchild-expected.txt: Removed.
- platform/efl/fast/block/float/008-expected.txt: Removed.
- platform/efl/fast/block/float/009-expected.txt: Removed.
- platform/efl/fast/block/float/019-expected.txt: Removed.
- platform/efl/fast/block/float/034-expected.txt: Removed.
- platform/efl/fast/block/float/035-expected.txt: Removed.
- platform/efl/fast/block/float/4145535Crash-expected.txt: Removed.
- platform/efl/fast/block/float/br-with-clear-2-expected.txt: Removed.
- platform/efl/fast/block/float/float-forced-below-other-floats-expected.txt: Removed.
- platform/efl/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Removed.
- platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Removed.
- platform/efl/fast/block/float/float-on-zero-height-line-expected.txt: Removed.
- platform/efl/fast/block/float/float-overhangs-root-expected.txt: Removed.
- platform/efl/fast/block/float/narrow-after-wide-expected.txt: Removed.
- platform/efl/fast/block/float/negative-margin-clear-expected.txt: Removed.
- platform/efl/fast/block/float/nested-clearance-expected.txt: Removed.
- platform/efl/fast/block/float/nowrap-clear-min-width-expected.txt: Removed.
- platform/efl/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Removed.
- platform/efl/fast/block/float/relative-painted-twice-expected.txt: Removed.
- platform/efl/fast/block/positioning/003-expected.txt: Removed.
- platform/efl/fast/block/positioning/004-expected.txt: Removed.
- platform/efl/fast/block/positioning/005-expected.txt: Removed.
- platform/efl/fast/block/positioning/006-expected.txt: Removed.
- platform/efl/fast/block/positioning/007-expected.txt: Removed.
- platform/efl/fast/block/positioning/008-expected.txt: Removed.
- platform/efl/fast/block/positioning/009-expected.txt: Removed.
- platform/efl/fast/block/positioning/010-expected.txt: Removed.
- platform/efl/fast/block/positioning/011-expected.txt: Removed.
- platform/efl/fast/block/positioning/012-expected.txt: Removed.
- platform/efl/fast/block/positioning/013-expected.txt: Removed.
- platform/efl/fast/block/positioning/014-expected.txt: Removed.
- platform/efl/fast/block/positioning/015-expected.txt: Removed.
- platform/efl/fast/block/positioning/017-expected.txt: Removed.
- platform/efl/fast/block/positioning/018-expected.txt: Removed.
- platform/efl/fast/block/positioning/019-expected.txt: Removed.
- platform/efl/fast/block/positioning/020-expected.txt: Removed.
- platform/efl/fast/block/positioning/021-expected.txt: Removed.
- platform/efl/fast/block/positioning/022-expected.txt: Removed.
- platform/efl/fast/block/positioning/023-expected.txt: Removed.
- platform/efl/fast/block/positioning/024-expected.txt: Removed.
- platform/efl/fast/block/positioning/026-expected.txt: Removed.
- platform/efl/fast/block/positioning/027-expected.txt: Removed.
- platform/efl/fast/block/positioning/029-expected.txt: Removed.
- platform/efl/fast/block/positioning/030-expected.txt: Removed.
- platform/efl/fast/block/positioning/032-expected.txt: Removed.
- platform/efl/fast/block/positioning/033-expected.txt: Removed.
- platform/efl/fast/block/positioning/034-expected.txt: Removed.
- platform/efl/fast/block/positioning/035-expected.txt: Removed.
- platform/efl/fast/block/positioning/036-expected.txt: Removed.
- platform/efl/fast/block/positioning/037-expected.txt: Removed.
- platform/efl/fast/block/positioning/038-expected.txt: Removed.
- platform/efl/fast/block/positioning/039-expected.txt: Removed.
- platform/efl/fast/block/positioning/040-expected.txt: Removed.
- platform/efl/fast/block/positioning/041-expected.txt: Removed.
- platform/efl/fast/block/positioning/042-expected.txt: Removed.
- platform/efl/fast/block/positioning/043-expected.txt: Removed.
- platform/efl/fast/block/positioning/044-expected.txt: Removed.
- platform/efl/fast/block/positioning/045-expected.txt: Removed.
- platform/efl/fast/block/positioning/046-expected.txt: Removed.
- platform/efl/fast/block/positioning/048-expected.txt: Removed.
- platform/efl/fast/block/positioning/049-expected.txt: Removed.
- platform/efl/fast/block/positioning/050-expected.txt: Removed.
- platform/efl/fast/block/positioning/062-expected.txt: Removed.
- platform/efl/fast/block/positioning/complex-positioned-movement-expected.txt: Removed.
- platform/efl/fast/block/positioning/move-with-auto-width-expected.txt: Removed.
- platform/efl/fast/block/positioning/negative-rel-position-expected.txt: Removed.
- platform/efl/fast/block/positioning/relative-overconstrained-expected.txt: Removed.
- platform/efl/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
- platform/efl/fast/block/positioning/static-inline-position-dynamic-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-lr/003-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-lr/004-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-lr/005-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-lr/006-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-rl/003-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-rl/004-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-rl/005-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-rl/006-expected.txt: Removed.
- platform/efl/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
- platform/efl/fast/borders/outline-offset-min-assert-expected.txt: Removed.
- platform/efl/fast/borders/webkit-border-radius-expected.txt: Removed.
- platform/efl/fast/box-shadow/shadow-tiling-artifact-expected.txt: Removed.
- platform/efl/fast/box-shadow/single-pixel-shadow-expected.txt: Removed.
- platform/efl/fast/canvas/canvas-as-image-expected.txt: Removed.
- platform/efl/fast/canvas/canvas-bg-expected.txt: Removed.
- platform/efl/fast/canvas/canvas-render-layer-expected.txt: Removed.
- platform/efl/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
- platform/efl/fast/css/006-expected.txt: Removed.
- platform/efl/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
- platform/efl/fast/css/bogus-color-span-expected.txt: Removed.
- platform/efl/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Removed.
- platform/efl/fast/css/content-dynamic-expected.txt: Removed.
- platform/efl/fast/css/contentDiv-expected.txt: Removed.
- platform/efl/fast/css/contentDivWithChildren-expected.txt: Removed.
- platform/efl/fast/css/contentImage-expected.txt: Removed.
- platform/efl/fast/css/empty-inline-003-quirksmode-expected.txt: Removed.
- platform/efl/fast/css/empty-inline-line-height-first-line-expected.txt: Removed.
- platform/efl/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Removed.
- platform/efl/fast/css/font-face-multiple-remote-sources-expected.txt: Removed.
- platform/efl/fast/css/font-face-remote-expected.txt: Removed.
- platform/efl/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Removed.
- platform/efl/fast/css/last-child-style-sharing-expected.txt: Removed.
- platform/efl/fast/css/nested-rounded-corners-expected.txt: Removed.
- platform/efl/fast/css/outline-auto-empty-rects-expected.txt: Removed.
- platform/efl/fast/css/transition-color-unspecified-expected.txt: Removed.
- platform/efl/fast/dom/Element/getBoundingClientRect-expected.txt: Removed.
- platform/efl/fast/dom/HTMLStyleElement/insert-parser-generated-expected.txt: Removed.
- platform/efl/fast/dom/Range/getBoundingClientRect-expected.txt: Removed.
- platform/efl/fast/dom/Window/window-properties-performance-expected.txt: Removed.
- platform/efl/fast/dom/attr_dead_doc-expected.txt: Removed.
- platform/efl/fast/dom/css-cached-import-rule-expected.txt: Removed.
- platform/efl/fast/dom/css-insert-import-rule-expected.txt: Removed.
- platform/efl/fast/dom/delete-contents-expected.txt: Removed.
- platform/efl/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
- platform/efl/fast/dom/shadow/shadow-contents-event-expected.txt: Removed.
- platform/efl/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
- platform/efl/fast/dynamic/001-expected.txt: Removed.
- platform/efl/fast/dynamic/005-expected.txt: Removed.
- platform/efl/fast/dynamic/anonymous-block-layer-lost-expected.txt: Removed.
- platform/efl/fast/dynamic/float-no-longer-overhanging-expected.txt: Removed.
- platform/efl/fast/dynamic/float-withdrawal-2-expected.txt: Removed.
- platform/efl/fast/dynamic/floating-to-positioned-2-expected.txt: Removed.
- platform/efl/fast/dynamic/floating-to-positioned-expected.txt: Removed.
- platform/efl/fast/dynamic/insertAdjacentElement-expected.txt: Removed.
- platform/efl/fast/dynamic/staticY-expected.txt: Removed.
- platform/efl/fast/dynamic/subtree-parent-static-y-expected.txt: Removed.
- platform/efl/fast/events/document-elementFromPoint-expected.txt: Removed.
- platform/efl/fast/events/overflow-viewport-renderer-deleted-expected.txt: Removed.
- platform/efl/fast/flexbox/flex-hang-expected.txt: Removed.
- platform/efl/fast/flexbox/overhanging-floats-removed-expected.txt: Removed.
- platform/efl/fast/forms/002-expected.txt: Removed.
- platform/efl/fast/forms/005-expected.txt: Removed.
- platform/efl/fast/forms/color/input-color-onchange-event-expected.txt: Removed.
- platform/efl/fast/forms/input-placeholder-paint-order-expected.txt: Removed.
- platform/efl/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Removed.
- platform/efl/fast/frames/002-expected.txt: Removed.
- platform/efl/fast/frames/calculate-fixed-expected.txt: Removed.
- platform/efl/fast/frames/calculate-order-expected.txt: Removed.
- platform/efl/fast/frames/calculate-percentage-expected.txt: Removed.
- platform/efl/fast/frames/calculate-relative-expected.txt: Removed.
- platform/efl/fast/frames/calculate-round-expected.txt: Removed.
- platform/efl/fast/frames/content-opacity-1-expected.txt: Removed.
- platform/efl/fast/frames/content-opacity-2-expected.txt: Removed.
- platform/efl/fast/frames/empty-cols-attribute-expected.txt: Removed.
- platform/efl/fast/frames/empty-frame-src-expected.txt: Removed.
- platform/efl/fast/frames/frame-set-whitespace-attributes-expected.txt: Removed.
- platform/efl/fast/frames/iframe-scaling-with-scroll-expected.txt: Removed.
- platform/efl/fast/frames/iframe-text-contents-expected.txt: Removed.
- platform/efl/fast/frames/invalid-expected.txt: Removed.
- platform/efl/fast/frames/no-frame-borders-expected.txt: Removed.
- platform/efl/fast/frames/seamless/seamless-inherited-origin-expected.txt: Removed.
- platform/efl/fast/gradients/background-clipped-expected.txt: Removed.
- platform/efl/fast/images/gif-large-checkerboard-expected.txt: Removed.
- platform/efl/fast/images/gray-scale-png-with-color-profile-expected.txt: Removed.
- platform/efl/fast/images/png-suite/test-expected.txt: Removed.
- platform/efl/fast/images/repaint-subrect-grid-expected.txt: Removed.
- platform/efl/fast/images/zoomed-img-size-expected.txt: Removed.
- platform/efl/fast/inline-block/004-expected.txt: Removed.
- platform/efl/fast/inline-block/005-expected.txt: Removed.
- platform/efl/fast/invalid/015-expected.txt: Removed.
- platform/efl/fast/invalid/table-residual-style-crash-expected.txt: Removed.
- platform/efl/fast/layers/opacity-stacking-expected.txt: Removed.
- platform/efl/fast/layers/positioned-inside-root-with-margins-expected.txt: Removed.
- platform/efl/fast/layers/zindex-ridonkulous-expected.txt: Removed.
- platform/efl/fast/lists/list-marker-before-content-table-expected.txt: Removed.
- platform/efl/fast/multicol/break-properties-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-h-horizontal-bt-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-h-horizontal-tb-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-h-vertical-lr-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-h-vertical-rl-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-v-horizontal-bt-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-v-horizontal-tb-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-v-vertical-lr-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-v-vertical-rl-expected.txt: Removed.
- platform/efl/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Removed.
- platform/efl/fast/multicol/vertical-lr/break-properties-expected.txt: Removed.
- platform/efl/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Removed.
- platform/efl/fast/multicol/vertical-rl/break-properties-expected.txt: Removed.
- platform/efl/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Removed.
- platform/efl/fast/overflow/overflow-update-transform-expected.txt: Removed.
- platform/efl/fast/overflow/position-relative-expected.txt: Removed.
- platform/efl/fast/overflow/trailing-float-linebox-expected.txt: Removed.
- platform/efl/fast/overflow/unreachable-content-test-expected.txt: Removed.
- platform/efl/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Removed.
- platform/efl/fast/parser/style-script-head-test-expected.txt: Removed.
- platform/efl/fast/profiler/apply-expected.txt: Removed.
- platform/efl/fast/reflections/reflection-with-zoom-expected.txt: Removed.
- platform/efl/fast/reflections/table-cell-expected.txt: Removed.
- platform/efl/fast/repaint/background-generated-expected.txt: Removed.
- platform/efl/fast/repaint/content-into-overflow-expected.txt: Removed.
- platform/efl/fast/repaint/erase-overflow-expected.txt: Removed.
- platform/efl/fast/repaint/fixed-tranformed-expected.txt: Removed.
- platform/efl/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Removed.
- platform/efl/fast/repaint/float-new-in-block-expected.txt: Removed.
- platform/efl/fast/repaint/focus-ring-expected.txt: Removed.
- platform/efl/fast/repaint/iframe-scroll-repaint-expected.txt: Removed.
- platform/efl/fast/repaint/inline-block-resize-expected.txt: Removed.
- platform/efl/fast/repaint/intermediate-layout-position-clip-expected.txt: Removed.
- platform/efl/fast/repaint/intermediate-layout-position-expected.txt: Removed.
- platform/efl/fast/repaint/invisible-objects-expected.txt: Removed.
- platform/efl/fast/repaint/layer-hide-when-needs-layout-expected.txt: Removed.
- platform/efl/fast/repaint/layer-visibility-expected.txt: Removed.
- platform/efl/fast/repaint/layout-state-only-positioned-expected.txt: Removed.
- platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Removed.
- platform/efl/fast/repaint/overflow-into-content-expected.txt: Removed.
- platform/efl/fast/repaint/repaint-during-scroll-expected.txt: Removed.
- platform/efl/fast/repaint/table-col-background-expected.txt: Removed.
- platform/efl/fast/repaint/table-outer-border-expected.txt: Removed.
- platform/efl/fast/repaint/table-row-expected.txt: Removed.
- platform/efl/fast/repaint/table-section-overflow-expected.txt: Removed.
- platform/efl/fast/repaint/table-two-pass-layout-overpaint-expected.txt: Removed.
- platform/efl/fast/repaint/text-emphasis-v-expected.txt: Removed.
- platform/efl/fast/repaint/transform-disable-layoutstate-expected.txt: Removed.
- platform/efl/fast/repaint/transform-replaced-shadows-expected.txt: Removed.
- platform/efl/fast/repaint/transform-rotate-and-remove-expected.txt: Removed.
- platform/efl/fast/repaint/view-background-from-body-1-expected.txt: Removed.
- platform/efl/fast/repaint/view-background-from-body-2-expected.txt: Removed.
- platform/efl/fast/replaced/008-expected.txt: Removed.
- platform/efl/fast/replaced/percent-height-in-anonymous-block-expected.txt: Removed.
- platform/efl/fast/replaced/selection-rect-expected.txt: Removed.
- platform/efl/fast/ruby/position-after-expected.txt: Removed.
- platform/efl/fast/ruby/ruby-block-style-not-updated-expected.txt: Removed.
- platform/efl/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Removed.
- platform/efl/fast/ruby/ruby-inline-style-not-updated-expected.txt: Removed.
- platform/efl/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Removed.
- platform/efl/fast/runin/runin-generated-before-content-expected.txt: Removed.
- platform/efl/fast/sub-pixel/inline-block-with-padding-expected.txt: Removed.
- platform/efl/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Removed.
- platform/efl/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Removed.
- platform/efl/fast/table/024-expected.txt: Removed.
- platform/efl/fast/table/031-expected.txt: Removed.
- platform/efl/fast/table/032-expected.txt: Removed.
- platform/efl/fast/table/auto-100-percent-width-expected.txt: Removed.
- platform/efl/fast/table/caption-relayout-expected.txt: Removed.
- platform/efl/fast/table/div-as-col-span-expected.txt: Removed.
- platform/efl/fast/table/fixed-granular-cols-expected.txt: Removed.
- platform/efl/fast/table/fixed-with-auto-with-colspan-expected.txt: Removed.
- platform/efl/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Removed.
- platform/efl/fast/table/growCellForImageQuirk-expected.txt: Removed.
- platform/efl/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
- platform/efl/fast/table/height-percent-test-vertical-expected.txt: Removed.
- platform/efl/fast/table/percent-widths-stretch-expected.txt: Removed.
- platform/efl/fast/table/percent-widths-stretch-vertical-expected.txt: Removed.
- platform/efl/fast/table/table-before-child-style-update-expected.txt: Removed.
- platform/efl/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Removed.
- platform/efl/fast/table/table-cell-before-after-content-around-table-expected.txt: Removed.
- platform/efl/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Removed.
- platform/efl/fast/table/table-row-before-after-content-around-block-expected.txt: Removed.
- platform/efl/fast/table/table-row-before-after-content-around-table-expected.txt: Removed.
- platform/efl/fast/table/table-row-before-child-style-update-expected.txt: Removed.
- platform/efl/fast/table/table-row-outline-paint-expected.txt: Removed.
- platform/efl/fast/table/table-row-style-not-updated-expected.txt: Removed.
- platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Removed.
- platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Removed.
- platform/efl/fast/table/table-style-not-updated-expected.txt: Removed.
- platform/efl/fast/table/vertical-align-baseline-readjust-expected.txt: Removed.
- platform/efl/fast/table/wide-colspan-expected.txt: Removed.
- platform/efl/fast/table/wide-column-expected.txt: Removed.
- platform/efl/fast/text/align-center-rtl-spill-expected.txt: Removed.
- platform/efl/fast/text/emphasis-avoid-ruby-expected.txt: Removed.
- platform/efl/fast/text/soft-hyphen-4-expected.txt: Removed.
- platform/efl/fast/text/stripNullFromText-expected.txt: Removed.
- platform/efl/fast/text/wbr-pre-expected.txt: Removed.
- platform/efl/fast/text/whitespace/019-expected.txt: Removed.
- platform/efl/fast/text/whitespace/023-expected.txt: Removed.
- platform/efl/fast/tokenizer/missing-style-end-tag-1-expected.txt: Removed.
- platform/efl/fast/tokenizer/missing-style-end-tag-2-expected.txt: Removed.
- platform/efl/fast/tokenizer/script-after-frameset-expected.txt: Removed.
- platform/efl/fast/transforms/matrix-01-expected.txt: Removed.
- platform/efl/fast/transforms/matrix-02-expected.txt: Removed.
- platform/efl/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Removed.
- platform/efl/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Removed.
- platform/efl/fast/writing-mode/body-direction-propagation-blocked-expected.txt: Removed.
- platform/efl/fast/writing-mode/body-direction-propagation-expected.txt: Removed.
- platform/efl/fast/writing-mode/body-writing-mode-propagation-blocked-expected.txt: Removed.
- platform/efl/fast/writing-mode/body-writing-mode-propagation-expected.txt: Removed.
- platform/efl/fast/writing-mode/floats-in-block-layout-expected.txt: Removed.
- platform/efl/fast/writing-mode/inline-direction-positioning-expected.txt: Removed.
- platform/efl/fast/writing-mode/margin-collapse-expected.txt: Removed.
- platform/efl/fast/writing-mode/root-lr-basic-expected.txt: Removed.
- platform/efl/fast/writing-mode/self-collapsing-block-expected.txt: Removed.
- platform/efl/fullscreen/full-screen-render-inline-expected.txt: Removed.
- platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt: Removed.
- platform/efl/plugins/iframe-plugin-bgcolor-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug131020-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug13169-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug157890-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug1818-3-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug1818-6-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug222336-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug222467-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug269566-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug277062-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug28933-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug2954-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug8032-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug83786-expected.txt: Removed.
- platform/efl/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Removed.
- platform/efl/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
- platform/efl/transforms/3d/general/matrix-with-zoom-3d-expected.txt: Removed.
- platform/efl/transforms/3d/general/transform-origin-z-change-expected.txt: Removed.
- platform/efl/transitions/transition-end-event-rendering-expected.txt: Removed.
- 1:48 AM Changeset in webkit [157502] by
-
- 6 edits in trunk
[EFL] Minibrowser can't load child window's location
https://bugs.webkit.org/show_bug.cgi?id=122485
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-16
Reviewed by Gyuyoung Kim.
Source/WebKit2:
EwkView::createNewPage(), which is only called during handling of
Messages::WebPageProxy::CreateNewPage message from WebProcess, no longer passes
the URL to window_create(). As a result, no Messages::WebPage::LoadURL message
is sent back, that would load the same URL twice and effectively cancel any
other scheduled navigation inside WebProcess.
Additionally, since the url parameter in MiniBrowser's implementation of
window_create() is only used internally and is prone to bugs as demonstrated
in r139303 (d7f10c8), it has been removed in favour of explicit calls to
ewk_view_url_set().
- UIProcess/API/efl/EwkView.cpp:
(EwkView::createNewPage): No longer passes the URL to window_create() impl.
- UIProcess/API/efl/ewk_view.h: window_create() no longer has the url parameter.
- UIProcess/API/efl/tests/test_ewk2_window_features.cpp: Test methods updated to
comply with the API change.
(EWK2WindowFeaturesTest::createDefaultWindow): Ditto.
(EWK2WindowFeaturesTest::createWindow): Ditto.
Tools:
- MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
followed by an explicit call to ewk_view_url_set() where appropriate.
(on_key_down):
(on_window_create):
(window_create):
(elm_main):
- 1:42 AM Changeset in webkit [157501] by
-
- 1 edit299 deletes in trunk/LayoutTests
Remove Gtk-specific test expectations that were identical to generic expectations.
<https://webkit.org/b/121551>
Reviewed by Antti Koivisto.
- platform/gtk/css1/units/rounding-expected.txt: Removed.
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-circle-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-circle-filter-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-circle-overflow-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-ellipse-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-polygon-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-rectangle-expected.txt: Removed.
- platform/gtk/editing/deleting/transpose-empty-expected.txt: Removed.
- platform/gtk/editing/pasteboard/5761530-1-expected.txt: Removed.
- platform/gtk/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
- platform/gtk/editing/selection/doubleclick-crash-expected.txt: Removed.
- platform/gtk/editing/selection/select-missing-image-expected.txt: Removed.
- platform/gtk/fast/backgrounds/bgCompositeCopy-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize01-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize02-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize03-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize04-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize05-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize06-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize07-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize08-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize09-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize10-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize11-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize12-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize13-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize14-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
- platform/gtk/fast/block/basic/fieldset-stretch-to-legend-expected.txt: Removed.
- platform/gtk/fast/block/basic/quirk-percent-height-grandchild-expected.txt: Removed.
- platform/gtk/fast/block/float/008-expected.txt: Removed.
- platform/gtk/fast/block/float/009-expected.txt: Removed.
- platform/gtk/fast/block/float/019-expected.txt: Removed.
- platform/gtk/fast/block/float/034-expected.txt: Removed.
- platform/gtk/fast/block/float/035-expected.txt: Removed.
- platform/gtk/fast/block/float/4145535Crash-expected.txt: Removed.
- platform/gtk/fast/block/float/br-with-clear-2-expected.txt: Removed.
- platform/gtk/fast/block/float/float-forced-below-other-floats-expected.txt: Removed.
- platform/gtk/fast/block/float/float-on-zero-height-line-expected.txt: Removed.
- platform/gtk/fast/block/float/float-overhangs-root-expected.txt: Removed.
- platform/gtk/fast/block/float/narrow-after-wide-expected.txt: Removed.
- platform/gtk/fast/block/float/negative-margin-clear-expected.txt: Removed.
- platform/gtk/fast/block/float/nowrap-clear-min-width-expected.txt: Removed.
- platform/gtk/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Removed.
- platform/gtk/fast/block/float/relative-painted-twice-expected.txt: Removed.
- platform/gtk/fast/block/positioning/003-expected.txt: Removed.
- platform/gtk/fast/block/positioning/004-expected.txt: Removed.
- platform/gtk/fast/block/positioning/005-expected.txt: Removed.
- platform/gtk/fast/block/positioning/006-expected.txt: Removed.
- platform/gtk/fast/block/positioning/007-expected.txt: Removed.
- platform/gtk/fast/block/positioning/008-expected.txt: Removed.
- platform/gtk/fast/block/positioning/009-expected.txt: Removed.
- platform/gtk/fast/block/positioning/010-expected.txt: Removed.
- platform/gtk/fast/block/positioning/011-expected.txt: Removed.
- platform/gtk/fast/block/positioning/012-expected.txt: Removed.
- platform/gtk/fast/block/positioning/013-expected.txt: Removed.
- platform/gtk/fast/block/positioning/014-expected.txt: Removed.
- platform/gtk/fast/block/positioning/015-expected.txt: Removed.
- platform/gtk/fast/block/positioning/017-expected.txt: Removed.
- platform/gtk/fast/block/positioning/018-expected.txt: Removed.
- platform/gtk/fast/block/positioning/019-expected.txt: Removed.
- platform/gtk/fast/block/positioning/020-expected.txt: Removed.
- platform/gtk/fast/block/positioning/021-expected.txt: Removed.
- platform/gtk/fast/block/positioning/022-expected.txt: Removed.
- platform/gtk/fast/block/positioning/023-expected.txt: Removed.
- platform/gtk/fast/block/positioning/024-expected.txt: Removed.
- platform/gtk/fast/block/positioning/026-expected.txt: Removed.
- platform/gtk/fast/block/positioning/027-expected.txt: Removed.
- platform/gtk/fast/block/positioning/029-expected.txt: Removed.
- platform/gtk/fast/block/positioning/030-expected.txt: Removed.
- platform/gtk/fast/block/positioning/032-expected.txt: Removed.
- platform/gtk/fast/block/positioning/033-expected.txt: Removed.
- platform/gtk/fast/block/positioning/034-expected.txt: Removed.
- platform/gtk/fast/block/positioning/035-expected.txt: Removed.
- platform/gtk/fast/block/positioning/036-expected.txt: Removed.
- platform/gtk/fast/block/positioning/037-expected.txt: Removed.
- platform/gtk/fast/block/positioning/038-expected.txt: Removed.
- platform/gtk/fast/block/positioning/039-expected.txt: Removed.
- platform/gtk/fast/block/positioning/040-expected.txt: Removed.
- platform/gtk/fast/block/positioning/041-expected.txt: Removed.
- platform/gtk/fast/block/positioning/042-expected.txt: Removed.
- platform/gtk/fast/block/positioning/043-expected.txt: Removed.
- platform/gtk/fast/block/positioning/044-expected.txt: Removed.
- platform/gtk/fast/block/positioning/045-expected.txt: Removed.
- platform/gtk/fast/block/positioning/046-expected.txt: Removed.
- platform/gtk/fast/block/positioning/048-expected.txt: Removed.
- platform/gtk/fast/block/positioning/049-expected.txt: Removed.
- platform/gtk/fast/block/positioning/050-expected.txt: Removed.
- platform/gtk/fast/block/positioning/062-expected.txt: Removed.
- platform/gtk/fast/block/positioning/complex-positioned-movement-expected.txt: Removed.
- platform/gtk/fast/block/positioning/move-with-auto-width-expected.txt: Removed.
- platform/gtk/fast/block/positioning/negative-rel-position-expected.txt: Removed.
- platform/gtk/fast/block/positioning/relative-overconstrained-expected.txt: Removed.
- platform/gtk/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
- platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-lr/003-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-lr/004-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-lr/005-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-lr/006-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-rl/003-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-rl/004-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-rl/005-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-rl/006-expected.txt: Removed.
- platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
- platform/gtk/fast/borders/outline-offset-min-assert-expected.txt: Removed.
- platform/gtk/fast/borders/webkit-border-radius-expected.txt: Removed.
- platform/gtk/fast/box-shadow/shadow-tiling-artifact-expected.txt: Removed.
- platform/gtk/fast/box-shadow/single-pixel-shadow-expected.txt: Removed.
- platform/gtk/fast/canvas/canvas-as-image-expected.txt: Removed.
- platform/gtk/fast/canvas/canvas-bg-expected.txt: Removed.
- platform/gtk/fast/canvas/canvas-render-layer-expected.txt: Removed.
- platform/gtk/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
- platform/gtk/fast/css/006-expected.txt: Removed.
- platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
- platform/gtk/fast/css/bogus-color-span-expected.txt: Removed.
- platform/gtk/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Removed.
- platform/gtk/fast/css/content-dynamic-expected.txt: Removed.
- platform/gtk/fast/css/contentDiv-expected.txt: Removed.
- platform/gtk/fast/css/contentDivWithChildren-expected.txt: Removed.
- platform/gtk/fast/css/contentImage-expected.txt: Removed.
- platform/gtk/fast/css/font-face-multiple-remote-sources-expected.txt: Removed.
- platform/gtk/fast/css/font-face-remote-expected.txt: Removed.
- platform/gtk/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Removed.
- platform/gtk/fast/css/last-child-style-sharing-expected.txt: Removed.
- platform/gtk/fast/css/nested-rounded-corners-expected.txt: Removed.
- platform/gtk/fast/css/outline-auto-empty-rects-expected.txt: Removed.
- platform/gtk/fast/css/transition-color-unspecified-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLStyleElement/insert-parser-generated-expected.txt: Removed.
- platform/gtk/fast/dom/attr_dead_doc-expected.txt: Removed.
- platform/gtk/fast/dom/css-cached-import-rule-expected.txt: Removed.
- platform/gtk/fast/dom/css-insert-import-rule-expected.txt: Removed.
- platform/gtk/fast/dom/delete-contents-expected.txt: Removed.
- platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
- platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
- platform/gtk/fast/dynamic/001-expected.txt: Removed.
- platform/gtk/fast/dynamic/005-expected.txt: Removed.
- platform/gtk/fast/dynamic/anonymous-block-layer-lost-expected.txt: Removed.
- platform/gtk/fast/dynamic/float-no-longer-overhanging-expected.txt: Removed.
- platform/gtk/fast/dynamic/float-withdrawal-2-expected.txt: Removed.
- platform/gtk/fast/dynamic/floating-to-positioned-2-expected.txt: Removed.
- platform/gtk/fast/dynamic/floating-to-positioned-expected.txt: Removed.
- platform/gtk/fast/dynamic/insertAdjacentElement-expected.txt: Removed.
- platform/gtk/fast/dynamic/staticY-expected.txt: Removed.
- platform/gtk/fast/dynamic/subtree-parent-static-y-expected.txt: Removed.
- platform/gtk/fast/events/document-elementFromPoint-expected.txt: Removed.
- platform/gtk/fast/events/event-attribute-expected.txt: Removed.
- platform/gtk/fast/files/workers/worker-read-blob-async-expected.txt: Removed.
- platform/gtk/fast/files/workers/worker-read-blob-sync-expected.txt: Removed.
- platform/gtk/fast/flexbox/flex-hang-expected.txt: Removed.
- platform/gtk/fast/forms/002-expected.txt: Removed.
- platform/gtk/fast/forms/005-expected.txt: Removed.
- platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt: Removed.
- platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Removed.
- platform/gtk/fast/frames/002-expected.txt: Removed.
- platform/gtk/fast/frames/calculate-fixed-expected.txt: Removed.
- platform/gtk/fast/frames/calculate-order-expected.txt: Removed.
- platform/gtk/fast/frames/calculate-percentage-expected.txt: Removed.
- platform/gtk/fast/frames/calculate-relative-expected.txt: Removed.
- platform/gtk/fast/frames/calculate-round-expected.txt: Removed.
- platform/gtk/fast/frames/content-opacity-1-expected.txt: Removed.
- platform/gtk/fast/frames/content-opacity-2-expected.txt: Removed.
- platform/gtk/fast/frames/empty-cols-attribute-expected.txt: Removed.
- platform/gtk/fast/frames/empty-frame-src-expected.txt: Removed.
- platform/gtk/fast/frames/frame-set-whitespace-attributes-expected.txt: Removed.
- platform/gtk/fast/frames/iframe-scaling-with-scroll-expected.txt: Removed.
- platform/gtk/fast/frames/iframe-text-contents-expected.txt: Removed.
- platform/gtk/fast/frames/invalid-expected.txt: Removed.
- platform/gtk/fast/frames/no-frame-borders-expected.txt: Removed.
- platform/gtk/fast/gradients/background-clipped-expected.txt: Removed.
- platform/gtk/fast/images/gif-large-checkerboard-expected.txt: Removed.
- platform/gtk/fast/images/gray-scale-png-with-color-profile-expected.txt: Removed.
- platform/gtk/fast/images/png-suite/test-expected.txt: Removed.
- platform/gtk/fast/images/zoomed-img-size-expected.txt: Removed.
- platform/gtk/fast/inline-block/004-expected.txt: Removed.
- platform/gtk/fast/inline-block/005-expected.txt: Removed.
- platform/gtk/fast/invalid/015-expected.txt: Removed.
- platform/gtk/fast/invalid/table-residual-style-crash-expected.txt: Removed.
- platform/gtk/fast/layers/opacity-stacking-expected.txt: Removed.
- platform/gtk/fast/layers/positioned-inside-root-with-margins-expected.txt: Removed.
- platform/gtk/fast/layers/zindex-ridonkulous-expected.txt: Removed.
- platform/gtk/fast/multicol/break-properties-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-h-horizontal-bt-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-h-horizontal-tb-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-h-vertical-lr-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-h-vertical-rl-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-v-horizontal-bt-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-v-horizontal-tb-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-v-vertical-lr-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-v-vertical-rl-expected.txt: Removed.
- platform/gtk/fast/multicol/vertical-lr/break-properties-expected.txt: Removed.
- platform/gtk/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Removed.
- platform/gtk/fast/multicol/vertical-rl/break-properties-expected.txt: Removed.
- platform/gtk/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Removed.
- platform/gtk/fast/overflow/overflow-update-transform-expected.txt: Removed.
- platform/gtk/fast/overflow/position-relative-expected.txt: Removed.
- platform/gtk/fast/overflow/trailing-float-linebox-expected.txt: Removed.
- platform/gtk/fast/overflow/unreachable-content-test-expected.txt: Removed.
- platform/gtk/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Removed.
- platform/gtk/fast/parser/style-script-head-test-expected.txt: Removed.
- platform/gtk/fast/reflections/reflection-with-zoom-expected.txt: Removed.
- platform/gtk/fast/reflections/table-cell-expected.txt: Removed.
- platform/gtk/fast/repaint/background-generated-expected.txt: Removed.
- platform/gtk/fast/repaint/content-into-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/erase-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/fixed-tranformed-expected.txt: Removed.
- platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Removed.
- platform/gtk/fast/repaint/float-new-in-block-expected.txt: Removed.
- platform/gtk/fast/repaint/focus-ring-expected.txt: Removed.
- platform/gtk/fast/repaint/inline-block-resize-expected.txt: Removed.
- platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.txt: Removed.
- platform/gtk/fast/repaint/intermediate-layout-position-expected.txt: Removed.
- platform/gtk/fast/repaint/invisible-objects-expected.txt: Removed.
- platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.txt: Removed.
- platform/gtk/fast/repaint/layer-visibility-expected.txt: Removed.
- platform/gtk/fast/repaint/layout-state-only-positioned-expected.txt: Removed.
- platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Removed.
- platform/gtk/fast/repaint/overflow-into-content-expected.txt: Removed.
- platform/gtk/fast/repaint/repaint-during-scroll-expected.txt: Removed.
- platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- platform/gtk/fast/repaint/table-col-background-expected.txt: Removed.
- platform/gtk/fast/repaint/table-outer-border-expected.txt: Removed.
- platform/gtk/fast/repaint/table-row-expected.txt: Removed.
- platform/gtk/fast/repaint/table-section-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/table-two-pass-layout-overpaint-expected.txt: Removed.
- platform/gtk/fast/repaint/transform-disable-layoutstate-expected.txt: Removed.
- platform/gtk/fast/repaint/transform-replaced-shadows-expected.txt: Removed.
- platform/gtk/fast/repaint/transform-rotate-and-remove-expected.txt: Removed.
- platform/gtk/fast/repaint/view-background-from-body-1-expected.txt: Removed.
- platform/gtk/fast/repaint/view-background-from-body-2-expected.txt: Removed.
- platform/gtk/fast/replaced/008-expected.txt: Removed.
- platform/gtk/fast/replaced/percent-height-in-anonymous-block-expected.txt: Removed.
- platform/gtk/fast/replaced/selection-rect-expected.txt: Removed.
- platform/gtk/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Removed.
- platform/gtk/fast/table/024-expected.txt: Removed.
- platform/gtk/fast/table/031-expected.txt: Removed.
- platform/gtk/fast/table/032-expected.txt: Removed.
- platform/gtk/fast/table/auto-100-percent-width-expected.txt: Removed.
- platform/gtk/fast/table/caption-relayout-expected.txt: Removed.
- platform/gtk/fast/table/div-as-col-span-expected.txt: Removed.
- platform/gtk/fast/table/fixed-granular-cols-expected.txt: Removed.
- platform/gtk/fast/table/fixed-with-auto-with-colspan-expected.txt: Removed.
- platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Removed.
- platform/gtk/fast/table/growCellForImageQuirk-expected.txt: Removed.
- platform/gtk/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
- platform/gtk/fast/table/height-percent-test-vertical-expected.txt: Removed.
- platform/gtk/fast/table/percent-widths-stretch-expected.txt: Removed.
- platform/gtk/fast/table/percent-widths-stretch-vertical-expected.txt: Removed.
- platform/gtk/fast/table/table-row-outline-paint-expected.txt: Removed.
- platform/gtk/fast/table/vertical-align-baseline-readjust-expected.txt: Removed.
- platform/gtk/fast/table/wide-colspan-expected.txt: Removed.
- platform/gtk/fast/table/wide-column-expected.txt: Removed.
- platform/gtk/fast/text/align-center-rtl-spill-expected.txt: Removed.
- platform/gtk/fast/text/stripNullFromText-expected.txt: Removed.
- platform/gtk/fast/text/wbr-pre-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/019-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/022-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/023-expected.txt: Removed.
- platform/gtk/fast/tokenizer/missing-style-end-tag-1-expected.txt: Removed.
- platform/gtk/fast/tokenizer/missing-style-end-tag-2-expected.txt: Removed.
- platform/gtk/fast/tokenizer/script-after-frameset-expected.txt: Removed.
- platform/gtk/fast/transforms/matrix-01-expected.txt: Removed.
- platform/gtk/fast/transforms/matrix-02-expected.txt: Removed.
- platform/gtk/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Removed.
- platform/gtk/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Removed.
- platform/gtk/fast/writing-mode/body-direction-propagation-blocked-expected.txt: Removed.
- platform/gtk/fast/writing-mode/body-direction-propagation-expected.txt: Removed.
- platform/gtk/fast/writing-mode/body-writing-mode-propagation-blocked-expected.txt: Removed.
- platform/gtk/fast/writing-mode/body-writing-mode-propagation-expected.txt: Removed.
- platform/gtk/fast/writing-mode/floats-in-block-layout-expected.txt: Removed.
- platform/gtk/fast/writing-mode/inline-direction-positioning-expected.txt: Removed.
- platform/gtk/fast/writing-mode/margin-collapse-expected.txt: Removed.
- platform/gtk/fast/writing-mode/root-lr-basic-expected.txt: Removed.
- platform/gtk/fast/writing-mode/self-collapsing-block-expected.txt: Removed.
- platform/gtk/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Removed.
- platform/gtk/js/dom/global-constructors-attributes-shared-worker-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug131020-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug157890-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug1818-3-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug1818-6-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug222336-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug222467-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug269566-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug277062-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug28933-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug2954-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug8032-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug83786-expected.txt: Removed.
- platform/gtk/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
- platform/gtk/transitions/transition-end-event-rendering-expected.txt: Removed.
- 1:40 AM Changeset in webkit [157500] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove more of the UNINTERRUPTED_SEQUENCE thing
https://bugs.webkit.org/show_bug.cgi?id=122885
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-16
Reviewed by Andreas Kling.
It was not completely removed by r157481, leading to build failure for sh4 architecture.
- jit/JIT.h:
- jit/JITInlines.h:
- 1:35 AM Changeset in webkit [157499] by
-
- 1 edit338 deletes in trunk/LayoutTests
Remove port-specific SVG test expectations that were identical to generic expectations.
<https://webkit.org/b/121551>
Reviewed by Antti Koivisto.
- platform/efl/fast/repaint/repaint-svg-after-style-change-expected.txt: Removed.
- platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt: Removed.
- platform/efl/svg/as-image/image-respects-pageScaleFactor-change-expected.txt: Removed.
- platform/efl/svg/as-image/svg-as-image-expected.txt: Removed.
- platform/efl/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
- platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-in-clip-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-evenodd-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-nonzero-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-recursive-call-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-transform-1-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-with-container-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Removed.
- platform/efl/svg/clip-path/clipper-placement-issue-expected.txt: Removed.
- platform/efl/svg/css/path-with-shadow-expected.txt: Removed.
- platform/efl/svg/css/shadow-and-opacity-expected.txt: Removed.
- platform/efl/svg/custom/pattern-scaling-expected.txt: Removed.
- platform/efl/svg/dom/css-transforms-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.txt: Removed.
- platform/efl/svg/filters/big-sized-filter-2-expected.txt: Removed.
- platform/efl/svg/filters/big-sized-filter-expected.txt: Removed.
- platform/efl/svg/filters/feImage-change-target-id-expected.txt: Removed.
- platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Removed.
- platform/efl/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Removed.
- platform/efl/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
- platform/efl/svg/filters/feImage-remove-target-expected.txt: Removed.
- platform/efl/svg/filters/feMerge-wrong-input-expected.txt: Removed.
- platform/efl/svg/filters/filter-empty-g-expected.txt: Removed.
- platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-display-none-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-parent-display-none-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/efl/svg/hixie/cascade/001-broken-expected.txt: Removed.
- platform/efl/svg/hixie/data-types/001-expected.txt: Removed.
- platform/efl/svg/hixie/dynamic/003-expected.txt: Removed.
- platform/efl/svg/hixie/dynamic/004-expected.txt: Removed.
- platform/efl/svg/hixie/dynamic/005-expected.txt: Removed.
- platform/efl/svg/hixie/dynamic/006-expected.txt: Removed.
- platform/efl/svg/hixie/error/001-expected.txt: Removed.
- platform/efl/svg/hixie/error/006-expected.txt: Removed.
- platform/efl/svg/hixie/error/007-expected.txt: Removed.
- platform/efl/svg/hixie/error/008-expected.txt: Removed.
- platform/efl/svg/hixie/error/009-expected.txt: Removed.
- platform/efl/svg/hixie/error/014-expected.txt: Removed.
- platform/efl/svg/hixie/error/014-test-expected.txt: Removed.
- platform/efl/svg/hixie/error/015-expected.txt: Removed.
- platform/efl/svg/hixie/error/016-expected.txt: Removed.
- platform/efl/svg/hixie/mixed/004-expected.txt: Removed.
- platform/efl/svg/hixie/mixed/005-expected.txt: Removed.
- platform/efl/svg/hixie/painting/001-expected.txt: Removed.
- platform/efl/svg/hixie/processing-model/005-expected.txt: Removed.
- platform/efl/svg/hixie/rendering-model/001-expected.txt: Removed.
- platform/efl/svg/hixie/rendering-model/002-expected.txt: Removed.
- platform/efl/svg/hixie/rendering-model/003a-expected.txt: Removed.
- platform/efl/svg/hixie/text/001-expected.txt: Removed.
- platform/efl/svg/hixie/transform/001-expected.txt: Removed.
- platform/efl/svg/hixie/use/001-expected.txt: Removed.
- platform/efl/svg/hixie/use/002-expected.txt: Removed.
- platform/efl/svg/hixie/use/002-test-expected.txt: Removed.
- platform/efl/svg/hixie/viewbox/001-expected.txt: Removed.
- platform/efl/svg/hixie/viewbox/002-expected.txt: Removed.
- platform/efl/svg/hixie/viewbox/003-expected.txt: Removed.
- platform/efl/svg/hixie/viewbox/004-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-foreignObject-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Removed.
- platform/efl/svg/repaint/repainting-after-animation-element-removal-expected.txt: Removed.
- platform/efl/svg/text/text-hkern-expected.txt: Removed.
- platform/efl/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
- platform/efl/svg/text/text-vkern-expected.txt: Removed.
- platform/efl/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
- platform/efl/svg/text/textPathBoundsBug-expected.txt: Removed.
- platform/efl/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-svg-as-image-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt: Removed.
- platform/gtk/svg/as-image/svg-as-image-expected.txt: Removed.
- platform/gtk/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-in-clip-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-evenodd-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-nonzero-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-recursive-call-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-transform-1-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-with-container-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Removed.
- platform/gtk/svg/clip-path/clipper-placement-issue-expected.txt: Removed.
- platform/gtk/svg/css/path-with-shadow-expected.txt: Removed.
- platform/gtk/svg/css/shadow-and-opacity-expected.txt: Removed.
- platform/gtk/svg/custom/SVGNumber-interface-expected.txt: Removed.
- platform/gtk/svg/custom/SVGPoint-interface-expected.txt: Removed.
- platform/gtk/svg/custom/SVGRect-interface-expected.txt: Removed.
- platform/gtk/svg/custom/attribute-namespace-check-expected.txt: Removed.
- platform/gtk/svg/custom/circular-marker-reference-3-expected.txt: Removed.
- platform/gtk/svg/custom/class-baseValue-expected.txt: Removed.
- platform/gtk/svg/custom/class-selector-expected.txt: Removed.
- platform/gtk/svg/custom/clip-path-with-css-transform-1-expected.txt: Removed.
- platform/gtk/svg/custom/clip-path-with-css-transform-2-expected.txt: Removed.
- platform/gtk/svg/custom/clip-path-with-transform-expected.txt: Removed.
- platform/gtk/svg/custom/conditional-processing-outside-switch-expected.txt: Removed.
- platform/gtk/svg/custom/convolution-crash-expected.txt: Removed.
- platform/gtk/svg/custom/create-metadata-element-expected.txt: Removed.
- platform/gtk/svg/custom/createImageElement-expected.txt: Removed.
- platform/gtk/svg/custom/createelement-expected.txt: Removed.
- platform/gtk/svg/custom/css-pixels-dpi-expected.txt: Removed.
- platform/gtk/svg/custom/dasharrayOrigin-expected.txt: Removed.
- platform/gtk/svg/custom/display-none-expected.txt: Removed.
- platform/gtk/svg/custom/dynamic-empty-path-expected.txt: Removed.
- platform/gtk/svg/custom/dynamic-viewBox-expected.txt: Removed.
- platform/gtk/svg/custom/empty-merge-expected.txt: Removed.
- platform/gtk/svg/custom/evt-onload-expected.txt: Removed.
- platform/gtk/svg/custom/fill-opacity-hsl-expected.txt: Removed.
- platform/gtk/svg/custom/fill-opacity-rgba-expected.txt: Removed.
- platform/gtk/svg/custom/fill-update-expected.txt: Removed.
- platform/gtk/svg/custom/fractional-rects-expected.txt: Removed.
- platform/gtk/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
- platform/gtk/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
- platform/gtk/svg/custom/gradient-attr-update-expected.txt: Removed.
- platform/gtk/svg/custom/gradient-rotated-bbox-expected.txt: Removed.
- platform/gtk/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Removed.
- platform/gtk/svg/custom/group-opacity-expected.txt: Removed.
- platform/gtk/svg/custom/hover-default-fill-expected.txt: Removed.
- platform/gtk/svg/custom/image-with-aspect-ratio-stretch-expected.txt: Removed.
- platform/gtk/svg/custom/inner-percent-expected.txt: Removed.
- platform/gtk/svg/custom/inner-svg-hit-test-expected.txt: Removed.
- platform/gtk/svg/custom/invalid-dasharray-expected.txt: Removed.
- platform/gtk/svg/custom/invalid-transforms-expected.txt: Removed.
- platform/gtk/svg/custom/js-update-container-expected.txt: Removed.
- platform/gtk/svg/custom/js-update-image-and-display-expected.txt: Removed.
- platform/gtk/svg/custom/js-update-image-and-display2-expected.txt: Removed.
- platform/gtk/svg/custom/js-update-image-and-display3-expected.txt: Removed.
- platform/gtk/svg/custom/large-bounding-box-percents-expected.txt: Removed.
- platform/gtk/svg/custom/marker-empty-path-expected.txt: Removed.
- platform/gtk/svg/custom/marker-referencePoint-expected.txt: Removed.
- platform/gtk/svg/custom/mask-changes-expected.txt: Removed.
- platform/gtk/svg/custom/mask-colorspace-expected.txt: Removed.
- platform/gtk/svg/custom/mask-excessive-malloc-expected.txt: Removed.
- platform/gtk/svg/custom/mask-inside-defs-expected.txt: Removed.
- platform/gtk/svg/custom/mask-on-multiple-objects-expected.txt: Removed.
- platform/gtk/svg/custom/mask-with-default-value-expected.txt: Removed.
- platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt: Removed.
- platform/gtk/svg/custom/outer-svg-unknown-feature-expected.txt: Removed.
- platform/gtk/svg/custom/painting-marker-07-f-inherit-expected.txt: Removed.
- platform/gtk/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
- platform/gtk/svg/custom/path-update-expected.txt: Removed.
- platform/gtk/svg/custom/pattern-no-pixelation-expected.txt: Removed.
- platform/gtk/svg/custom/pattern-scaling-expected.txt: Removed.
- platform/gtk/svg/custom/pattern-y-offset-expected.txt: Removed.
- platform/gtk/svg/custom/percentage-rect2-expected.txt: Removed.
- platform/gtk/svg/custom/poly-identify-expected.txt: Removed.
- platform/gtk/svg/custom/polyline-hittest-expected.txt: Removed.
- platform/gtk/svg/custom/polyline-invalid-points-expected.txt: Removed.
- platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt: Removed.
- platform/gtk/svg/custom/root-container-opacity-clip-viewBox-expected.txt: Removed.
- platform/gtk/svg/custom/rootelement-expected.txt: Removed.
- platform/gtk/svg/custom/rounded-rects-expected.txt: Removed.
- platform/gtk/svg/custom/sheet-title-expected.txt: Removed.
- platform/gtk/svg/custom/small-rect-scale-expected.txt: Removed.
- platform/gtk/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
- platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
- platform/gtk/svg/custom/svgpolyparser-extra-space-expected.txt: Removed.
- platform/gtk/svg/custom/text-gradient-no-content-expected.txt: Removed.
- platform/gtk/svg/custom/transform-ignore-after-invalid-expected.txt: Removed.
- platform/gtk/svg/custom/transform-invalid-expected.txt: Removed.
- platform/gtk/svg/custom/transform-removeAttributeNS-expected.txt: Removed.
- platform/gtk/svg/custom/transform-scale-parse-expected.txt: Removed.
- platform/gtk/svg/custom/transform-with-ending-space-expected.txt: Removed.
- platform/gtk/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Removed.
- platform/gtk/svg/custom/use-disappears-after-style-update-expected.txt: Removed.
- platform/gtk/svg/custom/use-empty-reference-expected.txt: Removed.
- platform/gtk/svg/custom/use-extern-href-expected.txt: Removed.
- platform/gtk/svg/custom/use-invalid-pattern-expected.txt: Removed.
- platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt: Removed.
- platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt: Removed.
- platform/gtk/svg/custom/use-symbol-overflow-expected.txt: Removed.
- platform/gtk/svg/custom/viewBox-hit-expected.txt: Removed.
- platform/gtk/svg/custom/viewport-clip-expected.txt: Removed.
- platform/gtk/svg/custom/viewport-no-width-height-expected.txt: Removed.
- platform/gtk/svg/custom/viewport-update-expected.txt: Removed.
- platform/gtk/svg/custom/viewport-update2-expected.txt: Removed.
- platform/gtk/svg/custom/visibility-override-clip-expected.txt: Removed.
- platform/gtk/svg/custom/visibility-override-expected.txt: Removed.
- platform/gtk/svg/custom/visibility-override-filter-expected.txt: Removed.
- platform/gtk/svg/custom/visibility-override-mask-expected.txt: Removed.
- platform/gtk/svg/custom/width-full-percentage-expected.txt: Removed.
- platform/gtk/svg/custom/xhtml-no-svg-renderer-expected.txt: Removed.
- platform/gtk/svg/custom/xml-stylesheet-expected.txt: Removed.
- platform/gtk/svg/filters/big-sized-filter-2-expected.txt: Removed.
- platform/gtk/svg/filters/big-sized-filter-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-change-target-id-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-remove-target-expected.txt: Removed.
- platform/gtk/svg/filters/feMerge-wrong-input-expected.txt: Removed.
- platform/gtk/svg/filters/filter-empty-g-expected.txt: Removed.
- platform/gtk/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-display-none-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-parent-display-none-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/gtk/svg/hixie/cascade/001-broken-expected.txt: Removed.
- platform/gtk/svg/hixie/data-types/001-expected.txt: Removed.
- platform/gtk/svg/hixie/dynamic/003-expected.txt: Removed.
- platform/gtk/svg/hixie/dynamic/004-expected.txt: Removed.
- platform/gtk/svg/hixie/dynamic/005-expected.txt: Removed.
- platform/gtk/svg/hixie/dynamic/006-expected.txt: Removed.
- platform/gtk/svg/hixie/error/001-expected.txt: Removed.
- platform/gtk/svg/hixie/error/006-expected.txt: Removed.
- platform/gtk/svg/hixie/error/007-expected.txt: Removed.
- platform/gtk/svg/hixie/error/008-expected.txt: Removed.
- platform/gtk/svg/hixie/error/009-expected.txt: Removed.
- platform/gtk/svg/hixie/error/014-expected.txt: Removed.
- platform/gtk/svg/hixie/error/014-test-expected.txt: Removed.
- platform/gtk/svg/hixie/error/015-expected.txt: Removed.
- platform/gtk/svg/hixie/error/016-expected.txt: Removed.
- platform/gtk/svg/hixie/painting/001-expected.txt: Removed.
- platform/gtk/svg/hixie/processing-model/005-expected.txt: Removed.
- platform/gtk/svg/hixie/rendering-model/001-expected.txt: Removed.
- platform/gtk/svg/hixie/rendering-model/002-expected.txt: Removed.
- platform/gtk/svg/hixie/rendering-model/003a-expected.txt: Removed.
- platform/gtk/svg/hixie/text/001-expected.txt: Removed.
- platform/gtk/svg/hixie/transform/001-expected.txt: Removed.
- platform/gtk/svg/hixie/use/001-expected.txt: Removed.
- platform/gtk/svg/hixie/use/002-expected.txt: Removed.
- platform/gtk/svg/hixie/use/002-test-expected.txt: Removed.
- platform/gtk/svg/hixie/viewbox/001-expected.txt: Removed.
- platform/gtk/svg/hixie/viewbox/002-expected.txt: Removed.
- platform/gtk/svg/hixie/viewbox/003-expected.txt: Removed.
- platform/gtk/svg/hixie/viewbox/004-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Removed.
- platform/gtk/svg/repaint/repainting-after-animation-element-removal-expected.txt: Removed.
- platform/gtk/svg/text/text-hkern-expected.txt: Removed.
- platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
- platform/gtk/svg/text/text-vkern-expected.txt: Removed.
- platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
- platform/gtk/svg/text/textPathBoundsBug-expected.txt: Removed.
- platform/gtk/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-image-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
- 1:25 AM Changeset in webkit [157498] by
-
- 1 edit13 deletes in trunk/LayoutTests
Remove Mac-specific test expectations that were identical to generic expectations.
<https://webkit.org/b/121551>
Reviewed by Antti Koivisto.
- platform/mac-lion/css3/filters/composited-during-animation-layertree-expected.txt: Removed.
- platform/mac-lion/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
- platform/mac-lion/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
- platform/mac-lion/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
- platform/mac-lion/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
- platform/mac-lion/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Removed.
- platform/mac-lion/http/tests/multipart/policy-ignore-crash-expected.txt: Removed.
- platform/mac-lion/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Removed.
- platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Removed.
- platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Removed.
- platform/mac-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Removed.
- platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Removed.
- platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Removed.
- platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Removed.
- 1:13 AM Changeset in webkit [157497] by
-
- 1 edit39 deletes in trunk/LayoutTests
Remove Windows-specific test expectations that were identical to generic expectations.
<https://webkit.org/b/121551>
Reviewed by Antti Koivisto.
- platform/win-7sp0/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
- platform/win-future/svg/batik/text/textPosition2-expected.txt: Removed.
- platform/win/css3/filters/effect-reference-expected.txt: Removed.
- platform/win/css3/filters/effect-reference-hw-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-009-expected.txt: Removed.
- platform/win/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
- platform/win/editing/inserting/insert-3800346-fix-expected.txt: Removed.
- platform/win/editing/selection/anchor-focus2-expected.txt: Removed.
- platform/win/editing/selection/anchor-focus3-expected.txt: Removed.
- platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
- platform/win/editing/selection/drag-text-delay-expected.txt: Removed.
- platform/win/editing/selection/extend-selection-home-end-expected.txt: Removed.
- platform/win/fast/block/positioning/016-expected.txt: Removed.
- platform/win/fast/block/positioning/025-expected.txt: Removed.
- platform/win/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
- platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
- platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
- platform/win/fast/canvas/canvas-render-layer-expected.txt: Removed.
- platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed.
- platform/win/fast/css/zoom-body-scroll-expected.txt: Removed.
- platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
- platform/win/fast/dom/icon-url-property-expected.txt: Removed.
- platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
- platform/win/fast/events/event-attribute-expected.txt: Removed.
- platform/win/fast/events/ondragenter-expected.txt: Removed.
- platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Removed.
- platform/win/fast/forms/implicit-submission-expected.txt: Removed.
- platform/win/fast/forms/range/slider-mouse-events-expected.txt: Removed.
- platform/win/fast/forms/select-popup-pagekeys-expected.txt: Removed.
- platform/win/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/win/fast/media/w3c/test_media_queries-expected.txt: Removed.
- platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
- platform/win/http/tests/misc/acid3-expected.txt: Removed.
- platform/win/media/media-can-play-ogg-expected.txt: Removed.
- platform/win/media/media-can-play-wav-audio-expected.txt: Removed.
- platform/win/media/video-colorspace-yuv420-expected.txt: Removed.
- platform/win/media/video-colorspace-yuv422-expected.txt: Removed.
- platform/win/media/video-size-intrinsic-scale-expected.txt: Removed.
- platform/win/plugins/netscape-dom-access-and-reload-expected.txt: Removed.
- platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
- platform/win/svg/custom/pattern-scaling-expected.txt: Removed.
- 12:32 AM Changeset in webkit [157496] by
-
- 3 edits in trunk/Source/WebCore
Fix the build after r157478.
Rubber-stamped by Tim Horton.
Due to the way WebCore.exp.in is used, it can't be used to export a differing set of symbols
for different architectures. We often work around this by tweaking code slightly to avoid
needing to export different symbols. However, in this case the symbol name itself encodes an
architecture-specific detail and there's no clear way to avoid the requirement to export it.
To deal with this case we turn to ld's support for wildcards in the symbol export list.
- WebCore.exp.in: Use wildcards in place of the number that represents by how much "this"
should be adjusted when calling through the vtable thunk. Also sort the remainder of the file.
- make-export-file-generator: Don't attempt to verify symbol names that contain wildcard characters.
Oct 15, 2013:
- 11:56 PM Changeset in webkit [157495] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Build fix after r157476.
- GNUmakefile.am:
- 11:46 PM Changeset in webkit [157494] by
-
- 3 edits2 adds in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155253.
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-10-15
- platform/efl/fast/forms/formmove3-expected.txt:
- platform/efl/fast/forms/input-align-image-expected.txt:
- platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/efl/fast/invalid/003-expected.txt:
- platform/efl/tables/mozilla/bugs/bug647-expected.txt:
- 11:35 PM Changeset in webkit [157493] by
-
- 6 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155253.
- platform/efl/fast/forms/formmove3-expected.txt:
- platform/efl/fast/forms/input-align-image-expected.txt:
- platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/efl/fast/invalid/003-expected.txt:
- platform/efl/tables/mozilla/bugs/bug647-expected.txt:
- 11:17 PM Changeset in webkit [157492] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155324.
- platform/efl/fast/forms/placeholder-position-expected.png:
- platform/efl/fast/forms/placeholder-position-expected.txt:
- 9:44 PM Changeset in webkit [157491] by
-
- 2 edits in trunk/Source/WebCore
Two more exports for 32-bit build fix.
The duality of CGFloat means that we use a different
version of getRGBA (and the cast operator)
on 32-bit systems.
- WebCore.exp.in:
- 9:36 PM Changeset in webkit [157490] by
-
- 4 edits in trunk
[EFL][WK2] Make SeccompFilters build again after r156349 and r156353
https://bugs.webkit.org/show_bug.cgi?id=122872
Patch by Sergio Correia <Sergio Correia> on 2013-10-15
Reviewed by Anders Carlsson.
Source/WebKit2:
- Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SeccompBrokerClient::dispatch): Fix usage of extinct 'create'
methods of ArgumentEncoder/ArgumentDecoder.
(WebKit::SeccompBroker::runLoop): Ditto.
Tools:
- TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
failing.
- 9:32 PM Changeset in webkit [157489] by
-
- 5 edits in trunk/Source/JavaScriptCore
Get rid of the StructureStubInfo::patch union
https://bugs.webkit.org/show_bug.cgi?id=122877
Reviewed by Sam Weinig.
Just simplifying code by getting rid of data structures that ain't used no more.
Note that I replace the patch union with a patch struct. This means we say things like
stubInfo.patch.valueGPR instead of stubInfo.valueGPR. I think that this extra
encapsulation makes the code more readable: the patch struct contains just those things
that you need to know to perform patching.
- bytecode/StructureStubInfo.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- jit/Repatch.cpp:
(JSC::repatchByIdSelfAccess):
(JSC::replaceWithJump):
(JSC::linkRestoreScratch):
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::getPolymorphicStructureList):
(JSC::patchJumpToGetByIdStub):
(JSC::tryBuildGetByIDList):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::tryRepatchIn):
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):
- 9:30 PM Changeset in webkit [157488] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening.
- platform/efl/TestExpectations: svg/filters/filter-hidden-content.svg is passed after r142955.
- 9:27 PM Changeset in webkit [157487] by
-
- 2 edits in trunk/Source/WebCore
Another shot at a build fix; apparently these
do need exporting for some reason, but are different
on 32-bit.
- WebCore.exp.in:
- 9:21 PM Changeset in webkit [157486] by
-
- 18 edits in trunk/Source/WebCore
GenerateIsReachable=ImplContext is confusing
https://bugs.webkit.org/show_bug.cgi?id=122864
Reviewed by Geoffrey Garen.
Renamed to ImplWebGLRenderingContext.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- html/canvas/EXTDrawBuffers.idl:
- html/canvas/EXTTextureFilterAnisotropic.idl:
- html/canvas/OESElementIndexUint.idl:
- html/canvas/OESStandardDerivatives.idl:
- html/canvas/OESTextureFloat.idl:
- html/canvas/OESTextureHalfFloat.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/WebGLCompressedTextureATC.idl:
- html/canvas/WebGLCompressedTexturePVRTC.idl:
- html/canvas/WebGLCompressedTextureS3TC.idl:
- html/canvas/WebGLDebugRendererInfo.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLDepthTexture.idl:
- html/canvas/WebGLLoseContext.idl:
- WebCore.xcodeproj/project.pbxproj: While at it, added OESElementIndexUint.idl
to Xcode project.
- 9:13 PM Changeset in webkit [157485] by
-
- 6 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155408.
- platform/efl/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/efl/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/efl/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- 9:08 PM Changeset in webkit [157484] by
-
- 3 edits in trunk/Source/WebKit2
Removed argument coders for FloatPoint3D in CoodinatedGraphicsArgumentCoders.
https://bugs.webkit.org/show_bug.cgi?id=122875
Reviewed by Gyuyoung Kim.
Argument coders for FloatPoint3D is added in WebCoreArgumentCoders after r157478
and it caused redefinition build error in EFL port.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
- 9:05 PM Changeset in webkit [157483] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; I don't know how to export.
This may not help.
- WebCore.exp.in:
- 8:59 PM Changeset in webkit [157482] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL: add support for Int52ToValue and fix putByVal of int52s.
https://bugs.webkit.org/show_bug.cgi?id=122873
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-15
Reviewed by Filip Pizlo.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileInt52ToValue):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
- 8:10 PM Changeset in webkit [157481] by
-
- 4 edits in trunk/Source/JavaScriptCore
Get rid of the UNINTERRUPTED_SEQUENCE thing
https://bugs.webkit.org/show_bug.cgi?id=122876
Reviewed by Mark Hahnenberg.
It doesn't make sense anymore. We now use the DFG's IC logic, which never needed that.
Moreover, we should resist the temptation to bring anything like this back. We don't
want to have inline caches that only work if the assembler lays out code in a specific
predetermined way.
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
- 7:19 PM Changeset in webkit [157480] by
-
- 12 edits in trunk/Source/JavaScriptCore
Baseline JIT should use the DFG GetById IC
https://bugs.webkit.org/show_bug.cgi?id=122861
Reviewed by Oliver Hunt.
This mostly just kills a ton of code.
Note that this doesn't yet do all of the simplifications that can be done, but it does
kill dead code. I'll have another change to simplify StructureStubInfo's unions and such.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
- jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- jit/JIT.h:
(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
- jit/JITInlines.h:
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
(JSC::JIT::callOperation):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_from_scope):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_from_scope):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/Repatch.cpp:
(JSC::repatchGetByID):
(JSC::buildGetByIDList):
- jit/ThunkGenerators.cpp:
- jit/ThunkGenerators.h:
- 5:34 PM Changeset in webkit [157479] by
-
- 12 edits in trunk
Add ENABLE_WEB_ANIMATIONS flag
https://bugs.webkit.org/show_bug.cgi?id=122871
Reviewed by Tim Horton.
Eventually might be http://dev.w3.org/fxtf/web-animations/
but this is just engine-internal work at the moment.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 5:20 PM Changeset in webkit [157478] by
-
- 23 edits4 adds2 deletes in trunk/Source
Add a PlatformCALayer subclass that proxies its property changes across the process boundary
https://bugs.webkit.org/show_bug.cgi?id=122773
Reviewed by Anders Carlsson.
PlatformCALayerRemote coordinates with RemoteLayerTreeDrawingArea and friends
to enable cross-process proxying of the hierarchy of compositing layers.
In the Web process, we have GraphicsLayerCARemote, which owns 1+ PlatformCALayerRemote(s).
Unlike PlatformCALayer{Mac, Win}, which own PlatformLayers (CALayer/CACFLayer),
PlatformCALayerRemote stores any changes to its properties in a struct, and keeps track of
which properties have changed since the last commit. Commits are scheduled and performed by
RemoteLayerTreeContext, on RemoteLayerTreeDrawingArea's behalf, and result in
RemoteLayerTreeTransaction encoding said property changes and throwing them across
to the UI process, where RemoteLayerTreeHost applies them to a tree of CALayers kept there.
This code can be enabled by running with the WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA
environment variable set.
No new tests, the new drawing area is not yet testable.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::decode):
(CoreIPC::encode):
- Shared/WebCoreArgumentCoders.h:
Add argument coders for FloatPoint3D.
- Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged):
(WebKit::RemoteLayerTreeTransaction::changedLayers):
(WebKit::RemoteLayerTreeTransaction::destroyedLayers):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::dumpChangedLayers):
Add support for background color and anchor point in the layer transaction.
Make layer position a 3D point because that's what it really is.
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
The logic in layerPropertiesChanged is moved into PlatformCALayerRemote.
- UIProcess/WebPageProxy.h:
Include PlatformLayer.h; it seems annoying to successfully forward-declare
PlatformLayer because of the difference in definition between Objective-C and C++.
Drive-by un-indent some namespace contents and use OBJC_CLASS.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::sizeDidChange):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didUpdateGeometry):
(WebKit::RemoteLayerTreeDrawingAreaProxy::sendUpdateGeometry):
Send geometry updates to the RemoteLayerTreeDrawingArea.
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(nullActionsDictionary):
(WebKit::RemoteLayerTreeHost::commit):
Apply layer property changes to the named sublayer.
(WebKit::RemoteLayerTreeHost::getOrCreateLayer):
Create CALayers instead of GraphicsLayers.
Ensure that they won't perform implicit animations.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):
This should take a PlatformLayer instead of a GraphicsLayer, since we don't have
GraphicsLayers in the UIProcess.
- WebKit2.xcodeproj/project.pbxproj:
Add GraphicsLayerCARemote and PlatformCALayerRemote, remove RemoteGraphicsLayer.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h: Removed.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm: Removed.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::setRootLayer):
(WebKit::RemoteLayerTreeContext::layerWillBeDestroyed):
(WebKit::RemoteLayerTreeContext::createGraphicsLayer):
(WebKit::RemoteLayerTreeContext::flushLayers):
Build our transaction while flushing; it has no reason to exist outside of that scope.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::graphicsLayerFactory):
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
(WebKit::RemoteLayerTreeDrawingArea::updateGeometry):
Fix a capitalization typo.
Update the WebPage's (and thus WebCore's) size when updateGeometry() is called.
- WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp: Added.
(WebKit::GraphicsLayerCARemote::~GraphicsLayerCARemote):
(WebKit::GraphicsLayerCARemote::filtersCanBeComposited):
(WebKit::GraphicsLayerCARemote::createPlatformCALayer):
Added. Delegate to PlatformCALayerRemote. Don't allow creation of a
GraphicsLayerCARemote given a PlatformLayer, because with UI process compositing,
there should be no PlatformLayer instances in the Web process.
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h: Added.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp: Added.
(generateLayerID):
Generate a layer ID for identification across processes.
(PlatformCALayerRemote::~PlatformCALayerRemote):
Inform the RemoteLayerTreeContext that we've been destroyed, so it can convey
that information to the UI process and the corresponding CALayer can be destroyed.
(PlatformCALayerRemote::recursiveBuildTransaction):
Recursively accumulate changes in layer state on a RemoteLayerTreeTransaction.
The rest of this file is mostly an empty implementation of PlatformCALayer.
A few properties are implemented so far; see below.
(PlatformCALayerRemote::setSublayers):
(PlatformCALayerRemote::removeAllSublayers):
(PlatformCALayerRemote::appendSublayer):
(PlatformCALayerRemote::insertSublayer):
Update our list of sublayers, and note that our children have changed.
recursiveBuildTransaction() will walk our sublayers and record their IDs in the transaction.
(PlatformCALayerRemote::bounds):
(PlatformCALayerRemote::setBounds):
(PlatformCALayerRemote::position):
(PlatformCALayerRemote::setPosition):
(PlatformCALayerRemote::anchorPoint):
(PlatformCALayerRemote::setAnchorPoint):
(PlatformCALayerRemote::backgroundColor):
(PlatformCALayerRemote::setBackgroundColor):
Trivial implementations of basic layer properties, storing the new state in
our LayerProperties struct and noting that they changed in the current commit.
Properties with getters will return the last value that was set on the LayerProperties,
so we don't clear the whole struct at the end of the transaction, just the mask of changed properties.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h: Added.
- WebCore.exp.in:
Export lots of GraphicsLayerCA stuff so we can inherit from it in WebKit2.
- WebCore.xcodeproj/project.pbxproj:
Make PlatformCAFilters.h a private header.
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::initialize):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::initialize):
- platform/graphics/ca/GraphicsLayerCA.h:
Defer creation of the main PlatformCALayer until just after the constructor is finished
so that GraphicsLayerCA subclasses can successfully override createPlatformCALayer.
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::platformLayer):
Make platformLayer virtual so that subclasses which don't have PlatformLayers can override.
- 4:56 PM Changeset in webkit [157477] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
[Windows] Unreviewed gardening of some forms tests.
- platform/win/fast/forms/search-styled-expected.txt: Added.
- platform/win/fast/forms/select-writing-direction-natural-expected.txt: Removed.
- 3:40 PM Changeset in webkit [157476] by
-
- 4 edits2 moves2 adds in trunk/Source/WebKit2
Move WebProcess/IndexedDB to WebProcess/Databases/IndexedDB
Rubberstamped by Alexey Proskuryakov.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp: Renamed from Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.cpp.
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h: Renamed from Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.h.
- 3:23 PM Changeset in webkit [157475] by
-
- 4 edits in trunk/Source/JavaScriptCore
[sh4] Some calls don't match sh4 ABI.
https://bugs.webkit.org/show_bug.cgi?id=122863
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-15
Reviewed by Michael Saboff.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- 3:16 PM Changeset in webkit [157474] by
-
- 52 edits8 adds in trunk/Source
[iOS] Upstream JavaScriptCore support for ARM64
https://bugs.webkit.org/show_bug.cgi?id=122762
Source/JavaScriptCore:
Reviewed by Oliver Hunt and Filip Pizlo.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/ToolExecutable.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/ARM64Assembler.h: Added.
- assembler/AbstractMacroAssembler.h:
(JSC::isARM64):
(JSC::AbstractMacroAssembler::Label::Label):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::CachedTempRegister::CachedTempRegister):
(JSC::AbstractMacroAssembler::CachedTempRegister::registerIDInvalidate):
(JSC::AbstractMacroAssembler::CachedTempRegister::registerIDNoInvalidate):
(JSC::AbstractMacroAssembler::CachedTempRegister::value):
(JSC::AbstractMacroAssembler::CachedTempRegister::setValue):
(JSC::AbstractMacroAssembler::CachedTempRegister::invalidate):
(JSC::AbstractMacroAssembler::invalidateAllTempRegisters):
(JSC::AbstractMacroAssembler::isTempRegisterValid):
(JSC::AbstractMacroAssembler::clearTempRegisterValid):
(JSC::AbstractMacroAssembler::setTempRegisterValid):
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::linkCode):
- assembler/LinkBuffer.h:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::isPtrAlignedAddressOffset):
(JSC::MacroAssembler::pushToSave):
(JSC::MacroAssembler::popToRestore):
(JSC::MacroAssembler::patchableBranchTest32):
- assembler/MacroAssemblerARM64.h: Added.
- assembler/MacroAssemblerARMv7.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):
- disassembler/ARM64/A64DOpcode.cpp: Added.
- disassembler/ARM64/A64DOpcode.h: Added.
- disassembler/ARM64Disassembler.cpp: Added.
- heap/MachineStackMarker.cpp:
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
- heap/Region.h:
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::debugCall):
- jit/CCallHelpers.h:
- jit/ExecutableAllocator.h:
- jit/FPRInfo.h:
(JSC::FPRInfo::toRegister):
(JSC::FPRInfo::toIndex):
(JSC::FPRInfo::debugName):
- jit/GPRInfo.h:
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):
- jit/JITInlines.h:
(JSC::JIT::restoreArgumentReferenceForTrampoline):
- jit/JITOperationWrappers.h:
- jit/JITOperations.cpp:
- jit/JITStubs.cpp:
(JSC::performPlatformSpecificJITAssertions):
(JSC::tryCachePutByID):
- jit/JITStubs.h:
(JSC::JITStackFrame::returnAddressSlot):
- jit/JITStubsARM64.h: Added.
- jit/JSInterfaceJIT.h:
- jit/Repatch.cpp:
(JSC::emitRestoreScratch):
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::emitPutReplaceStub):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):
- jit/ScratchRegisterAllocator.h:
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
- jsc.cpp:
(main):
- llint/LLIntOfflineAsmConfig.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/arm.rb:
- offlineasm/arm64.rb: Added.
- offlineasm/backends.rb:
- offlineasm/instructions.rb:
- offlineasm/risc.rb:
- offlineasm/transform.rb:
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::alignCallFrameSizeInBytes):
(JSC::Yarr::YarrGenerator::initCallFrame):
(JSC::Yarr::YarrGenerator::removeCallFrame):
(JSC::Yarr::YarrGenerator::generateEnter):
- yarr/YarrJIT.h:
Source/WTF:
Reviewed by Oliver Hunt.
- Configurations/Base.xcconfig:
- wtf/Atomics.h:
(WTF::weakCompareAndSwap):
(WTF::armV7_dmb):
- wtf/FastMalloc.cpp:
- wtf/Platform.h:
- wtf/dtoa.cpp:
- wtf/dtoa/utils.h:
- wtf/text/ASCIIFastPath.h:
(WTF::copyLCharsFromUCharSource):
- wtf/text/StringImpl.h:
- 3:05 PM Changeset in webkit [157473] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix 3 operand sub operation in C loop LLINT.
https://bugs.webkit.org/show_bug.cgi?id=122866.
Reviewed by Geoffrey Garen.
- offlineasm/cloop.rb:
- 3:01 PM Changeset in webkit [157472] by
-
- 3 edits in branches/safari-537.73-branch/LayoutTests
Merging gardening patch for layout tests.
- 2:59 PM Changeset in webkit [157471] by
-
- 3 edits in branches/safari-537-branch/LayoutTests
Merging gardening patch for layout tests.
- 2:13 PM Changeset in webkit [157470] by
-
- 3 edits3 adds in trunk
REGRESSION: Crash in XMLDocumentParser::startElementNs
https://bugs.webkit.org/show_bug.cgi?id=122817
Reviewed by Darin Adler.
Source/WebCore:
Exit early in startElementNs when listeners and handlers of synchronous events such as load event
removes the inserted node inside parserAppendChild.
Test: fast/parser/xhtml-synchronous-detach-crash.html
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
LayoutTests:
Add a regression test from https://chromium.googlesource.com/chromium/blink/+/57afab5d21cccd89f032b9a3e62f3a61c6a0e9c2
- fast/parser/resources/remove-parent.xhtml: Added.
- fast/parser/xhtml-synchronous-detach-crash-expected.txt: Added.
- fast/parser/xhtml-synchronous-detach-crash.html: Added.
- 2:11 PM Changeset in webkit [157469] by
-
- 6 edits24 adds in trunk/Source/WebKit2
Add a skeleton Database process for future usage by Indexed Database.
https://bugs.webkit.org/show_bug.cgi?id=122849
Reviewed by Sam Weinig.
This mostly our typical "Add a new process type" boilerplate.
- Configurations/DatabaseProcess.xcconfig: Added.
- Configurations/DatabaseService.Development.xcconfig: Added.
- Configurations/DatabaseService.xcconfig: Added.
- WebKit2.xcodeproj/project.pbxproj:
- WebKit2Prefix.h:
- DatabaseProcess/DatabaseProcess.cpp: Added.
(WebKit::DatabaseProcess::shared):
(WebKit::DatabaseProcess::DatabaseProcess):
(WebKit::DatabaseProcess::~DatabaseProcess):
(WebKit::DatabaseProcess::initializeConnection):
(WebKit::DatabaseProcess::shouldTerminate):
(WebKit::DatabaseProcess::didReceiveMessage):
(WebKit::DatabaseProcess::didClose):
(WebKit::DatabaseProcess::didReceiveInvalidMessage):
(WebKit::DatabaseProcess::initializeProcess):
(WebKit::DatabaseProcess::initializeProcessName):
(WebKit::DatabaseProcess::initializeSandbox):
- DatabaseProcess/DatabaseProcess.h: Added.
- DatabaseProcess/EntryPoint/mac/LegacyProcess/DatabaseProcessMain.mm: Added.
(DatabaseProcessMain):
- DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist: Added.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist: Added.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist: Added.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm: Added.
(DatabaseServiceInitializer):
- DatabaseProcess/mac/DatabaseProcessMac.mm: Added.
(WebKit::DatabaseProcess::initializeProcess):
(WebKit::DatabaseProcess::initializeProcessName):
(WebKit::DatabaseProcess::initializeSandbox):
- UIProcess/Databases/DatabaseProcessProxy.cpp: Added.
(WebKit::DatabaseProcessProxy::create):
(WebKit::DatabaseProcessProxy::DatabaseProcessProxy):
(WebKit::DatabaseProcessProxy::~DatabaseProcessProxy):
(WebKit::DatabaseProcessProxy::getLaunchOptions):
(WebKit::DatabaseProcessProxy::connectionWillOpen):
(WebKit::DatabaseProcessProxy::connectionWillClose):
(WebKit::DatabaseProcessProxy::didReceiveMessage):
(WebKit::DatabaseProcessProxy::didClose):
(WebKit::DatabaseProcessProxy::didReceiveInvalidMessage):
(WebKit::DatabaseProcessProxy::didFinishLaunching):
- UIProcess/Databases/DatabaseProcessProxy.h: Added.
- UIProcess/Databases/mac/DatabaseProcessProxyMac.mm: Added.
(WebKit::shouldUseXPC):
(WebKit::DatabaseProcessProxy::platformGetLaunchOptions):
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::processTypeAsString):
(WebKit::ProcessLauncher::getProcessTypeFromString):
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
(WebKit::createProcess):
- 2:08 PM Changeset in webkit [157468] by
-
- 8 edits2 adds in trunk/Source/JavaScriptCore
ObjCCallbackFunctionImpl shouldn't store a JSContext
https://bugs.webkit.org/show_bug.cgi?id=122531
Reviewed by Geoffrey Garen.
The m_context field in ObjCCallbackFunctionImpl is vestigial and is only incidentally correct
in the common case. It's also no longer necessary in that we can look up the current JSContext
by looking using the globalObject of the callee when the function callback is invoked.
Also added a new test that would cause us to crash previously. The test required making
JSContextGetGlobalContext public API so that clients can obtain a JSContext from the JSContextRef
in C API callbacks.
- API/JSContextRef.h:
- API/JSContextRefPrivate.h:
- API/ObjCCallbackFunction.mm:
(JSC::ObjCCallbackFunctionImpl::ObjCCallbackFunctionImpl):
(JSC::objCCallbackFunctionCallAsFunction):
(objCCallbackFunctionForInvocation):
- API/WebKitAvailability.h:
- API/tests/CurrentThisInsideBlockGetterTest.h: Added.
- API/tests/CurrentThisInsideBlockGetterTest.mm: Added.
(CallAsConstructor):
(ConstructorFinalize):
(ConstructorClass):
(+[JSValue valueWithConstructorDescriptor:inContext:]):
(-[JSContext valueWithConstructorDescriptor:]):
(currentThisInsideBlockGetterTest):
- API/tests/testapi.mm:
- JavaScriptCore.xcodeproj/project.pbxproj:
- debugger/Debugger.cpp: Had to add some fully qualified names to avoid conflicts with Mac OS X headers.
- 2:03 PM Changeset in webkit [157467] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build after r157457 for architecture with 4 argument registers.
https://bugs.webkit.org/show_bug.cgi?id=122860
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-15
Reviewed by Michael Saboff.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupStubArguments134):
- 1:47 PM Changeset in webkit [157466] by
-
- 3 edits1 delete in trunk/Source/WebCore
Web Inspector: Remove old frontend localizedStrings.js
https://bugs.webkit.org/show_bug.cgi?id=122846
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-15
Reviewed by Timothy Hatcher.
- Configurations/WebCore.xcconfig:
- English.lproj/localizedStrings.js: Removed.
- WebCore.xcodeproj/project.pbxproj:
Remove the file and references to it. We no longer need to exclude
localizedString.js from some builds.
- 1:41 PM Changeset in webkit [157465] by
-
- 4 edits in trunk/Source
Web Inspector: Remove Windows old front-end related code
https://bugs.webkit.org/show_bug.cgi?id=122845
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-15
Reviewed by Brent Fulgham.
Source/WebCore:
- WebCore.vcxproj/copyWebCoreResourceFiles.cmd:
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
- 1:28 PM Changeset in webkit [157464] by
-
- 4 edits1 add in trunk/Source/WebKit
Expose -[WebPluginPackage bundle] as SPI
https://bugs.webkit.org/show_bug.cgi?id=122814
Reviewed by Anders Carlsson.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Added WebPluginPackagePrivate.h.
Source/WebKit/mac:
- Plugins/WebPluginPackage.mm:
(-[WebPluginPackage bundle]): Defined.
- Plugins/WebPluginPackagePrivate.h: Declared bundle as a method in a
category on NSObject.
- 1:24 PM Changeset in webkit [157463] by
-
- 2 edits in branches/safari-537.73-branch/LayoutTests
Merge r157460.
- 1:23 PM Changeset in webkit [157462] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Merge r157460.
- 1:20 PM Changeset in webkit [157461] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r157460.
http://trac.webkit.org/changeset/157460
https://bugs.webkit.org/show_bug.cgi?id=122858
Mis-skip, test isn't actually failing. (Requested by rfong on
#webkit).
- platform/wk2/TestExpectations:
- 1:10 PM Changeset in webkit [157460] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Skip unexpected flakey test: webaudio/oscillator-sawtooth.html.
- platform/wk2/TestExpectations:
- 12:40 PM Changeset in webkit [157459] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: can't select text inside a text node
https://bugs.webkit.org/show_bug.cgi?id=122828
Reviewed by Timothy Hatcher.
Cancel the default user interaction when a drag action starts if the
element is being edited.
- UserInterface/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.onattach):
(WebInspector.DOMTreeElement.prototype.handleEvent):
- 11:45 AM Changeset in webkit [157458] by
-
- 117 edits4 adds in trunk
Add support for the column-fill property
https://bugs.webkit.org/show_bug.cgi?id=117693
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-10-15
Reviewed by David Hyatt.
Source/WebCore:
This is only supported in the (new) region based multicol implementation.
With column-fill support, a lot of multicol tests needed an update.
The old implementation behaved as if column-fill were 'auto', but the
initial value is 'balance', so now we need to be explicit about that.
For auto-height tests it doesn't really matter - such multicols are always
balanced anyway.
Tests: fast/multicol/newmulticol/fixed-height-fill-auto.html
fast/multicol/newmulticol/fixed-height-fill-balance.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ColumnFill):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- rendering/RenderMultiColumnBlock.h:
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator==):
- rendering/style/StyleMultiColData.h:
LayoutTests:
With column-fill support, a lot of multicol tests needed an update.
The old implementation behaved as if column-fill were 'auto', but the
initial value is 'balance', so now we need to be explicit about that.
For auto-height tests it doesn't really matter - such multicols are always
balanced anyway.
- compositing/geometry/composited-in-columns.html:
- fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html:
- fast/block/positioning/offsetLeft-offsetTop-multicolumn.html:
- fast/borders/border-antialiasing.html:
- fast/dynamic/float-moved-downwards-for-pagination-expected.html:
- fast/dynamic/float-moved-downwards-for-pagination.html:
- fast/dynamic/layer-no-longer-paginated.html:
- fast/events/document-elementFromPoint.html:
- fast/line-grid/line-grid-inside-columns.html:
- fast/line-grid/line-grid-into-columns.html:
- fast/multicol/break-properties.html:
- fast/multicol/cell-shrinkback.html:
- fast/multicol/client-rects.html:
- fast/multicol/column-count-with-rules.html:
- fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html:
- fast/multicol/flipped-blocks-hit-test.html:
- fast/multicol/float-paginate-complex.html:
- fast/multicol/float-paginate-empty-lines.html:
- fast/multicol/float-paginate.html:
- fast/multicol/float-truncation.html:
- fast/multicol/hit-test-above-or-below.html:
- fast/multicol/hit-test-end-of-column-with-line-height.html:
- fast/multicol/hit-test-end-of-column.html:
- fast/multicol/hit-test-float.html:
- fast/multicol/image-inside-nested-blocks-with-border.html:
- fast/multicol/layers-in-multicol.html:
- fast/multicol/layers-split-across-columns.html:
- fast/multicol/margin-collapse.html:
- fast/multicol/mixed-opacity-fixed-test.html:
- fast/multicol/mixed-opacity-test.html:
- fast/multicol/mixed-positioning-stacking-order.html:
- fast/multicol/nested-columns.html:
- fast/multicol/newmulticol/cell-shrinkback-expected.html:
- fast/multicol/newmulticol/cell-shrinkback.html:
- fast/multicol/newmulticol/column-rules-fixed-height-expected.html:
- fast/multicol/newmulticol/fixed-height-fill-auto-expected.html: Added.
- fast/multicol/newmulticol/fixed-height-fill-auto.html: Added.
- fast/multicol/newmulticol/fixed-height-fill-balance-expected.html: Added.
- fast/multicol/newmulticol/fixed-height-fill-balance.html: Added.
- fast/multicol/newmulticol/float-avoidance-expected.html:
- fast/multicol/newmulticol/float-avoidance.html:
- fast/multicol/newmulticol/float-multicol-expected.html:
- fast/multicol/newmulticol/float-multicol.html:
- fast/multicol/newmulticol/float-paginate-complex-expected.html:
- fast/multicol/newmulticol/float-paginate-complex.html:
- fast/multicol/newmulticol/float-paginate-empty-lines-expected.html:
- fast/multicol/newmulticol/float-paginate-empty-lines.html:
- fast/multicol/newmulticol/float-paginate-expected.html:
- fast/multicol/newmulticol/float-paginate.html:
- fast/multicol/newmulticol/layers-in-multicol-expected.html:
- fast/multicol/newmulticol/layers-in-multicol.html:
- fast/multicol/newmulticol/layers-split-across-columns-expected.html:
- fast/multicol/newmulticol/layers-split-across-columns.html:
- fast/multicol/newmulticol/positioned-split-expected.html:
- fast/multicol/newmulticol/positioned-split.html:
- fast/multicol/newmulticol/positioned-with-constrained-height-expected.html:
- fast/multicol/newmulticol/positioned-with-constrained-height.html:
- fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow.html:
- fast/multicol/orphans-relayout.html:
- fast/multicol/overflow-across-columns-percent-height.html:
- fast/multicol/overflow-across-columns.html:
- fast/multicol/overflow-content-expected.html:
- fast/multicol/overflow-content.html:
- fast/multicol/overflow-unsplittable.html:
- fast/multicol/pageLogicalOffset-vertical-expected.html:
- fast/multicol/pageLogicalOffset-vertical.html:
- fast/multicol/paginate-block-replaced.html:
- fast/multicol/positioned-outside-of-columns.html:
- fast/multicol/positioned-split.html:
- fast/multicol/positive-leading.html:
- fast/multicol/progression-reverse-overflow-expected.html:
- fast/multicol/progression-reverse-overflow.html:
- fast/multicol/progression-reverse.html:
- fast/multicol/scrolling-overflow.html:
- fast/multicol/seamless-flowed-through-columns-expected.html:
- fast/multicol/seamless-flowed-through-columns.html:
- fast/multicol/table-margin-collapse.html:
- fast/multicol/table-row-height-increase-expected.html:
- fast/multicol/table-row-height-increase.html:
- fast/multicol/table-vertical-align.html:
- fast/multicol/transform-inside-opacity.html:
- fast/multicol/unsplittable-inline-block.html:
- fast/multicol/vertical-lr/break-properties.html:
- fast/multicol/vertical-lr/column-count-with-rules.html:
- fast/multicol/vertical-lr/float-multicol.html:
- fast/multicol/vertical-lr/float-paginate-complex.html:
- fast/multicol/vertical-lr/float-paginate.html:
- fast/multicol/vertical-lr/float-truncation.html:
- fast/multicol/vertical-lr/image-inside-nested-blocks-with-border.html:
- fast/multicol/vertical-lr/nested-columns.html:
- fast/multicol/vertical-lr/rules-with-border-before.html:
- fast/multicol/vertical-lr/unsplittable-inline-block.html:
- fast/multicol/vertical-rl/break-properties.html:
- fast/multicol/vertical-rl/column-count-with-rules.html:
- fast/multicol/vertical-rl/float-avoidance.html:
- fast/multicol/vertical-rl/float-multicol.html:
- fast/multicol/vertical-rl/float-paginate-complex.html:
- fast/multicol/vertical-rl/float-paginate.html:
- fast/multicol/vertical-rl/float-truncation.html:
- fast/multicol/vertical-rl/image-inside-nested-blocks-with-border.html:
- fast/multicol/vertical-rl/nested-columns.html:
- fast/multicol/vertical-rl/rule-style.html:
- fast/multicol/vertical-rl/rules-with-border-before.html:
- fast/multicol/vertical-rl/unsplittable-inline-block.html:
- fast/multicol/widows-and-orphans.html:
- fast/regions/region-style-in-columns.html:
- fast/repaint/multicol-repaint.html:
- fast/sub-pixel/column-clipping.html:
- 11:33 AM Changeset in webkit [157457] by
-
- 15 edits in trunk/Source/JavaScriptCore
transition void cti_op_* methods to JIT operations.
https://bugs.webkit.org/show_bug.cgi?id=122617
Reviewed by Geoffrey Garen.
Converted the follow stubs to JIT operations:
cti_handle_watchdog_timer
cti_op_debug
cti_op_pop_scope
cti_op_profile_did_call
cti_op_profile_will_call
cti_op_put_by_index
cti_op_put_getter_setter
cti_op_tear_off_activation
cti_op_tear_off_arguments
cti_op_throw_static_error
cti_optimize
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
(JSC::CCallHelpers::setupThreeStubArgsGPR):
(JSC::CCallHelpers::setupStubArguments):
(JSC::CCallHelpers::setupStubArguments134):
- jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::emit_op_pop_scope):
(JSC::JIT::emit_op_push_name_scope):
(JSC::JIT::emit_op_throw_static_error):
(JSC::JIT::emit_op_debug):
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
(JSC::JIT::emitSlow_op_loop_hint):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::emit_op_pop_scope):
(JSC::JIT::emit_op_push_name_scope):
(JSC::JIT::emit_op_throw_static_error):
(JSC::JIT::emit_op_debug):
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_index):
(JSC::JIT::emit_op_put_getter_setter):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_index):
(JSC::JIT::emit_op_put_getter_setter):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 11:17 AM Changeset in webkit [157456] by
-
- 3 edits in trunk/Source/WebCore
Skip unnecessary null check in RenderText::textLength().
<https://webkit.org/b/122841>
Reviewed by Antti Koivisto.
RenderText will never have a null String in m_text, so textLength()
can grab at the StringImpl directly, avoiding a null check.
- 11:16 AM Changeset in webkit [157455] by
-
- 4 edits in trunk/Source/WebCore
FontGenericFamilies should not be ref-counted.
<https://webkit.org/b/122835>
Reviewed by Anders Carlsson.
FontGenericFamilies is singly-owned by Settings.
- 11:08 AM Changeset in webkit [157454] by
-
- 3 edits in trunk/Source/WebCore
[CSS Shapes] Move RenderBlock::layoutShapeInsideInfo into RenderBlock.cpp
http://bugs.webkit.org/show_bug.cgi?id=122843
Reviewed by Oliver Hunt.
Historically, layoutShapeInsideInfo was a static function in RenderBlockLineLayout, then it has changed to be a member of RenderBlock,
but at that time it hasn't been moved to RenderBlock.cpp. This patch moves it into RenderBlock.cpp next to the Shapes functions. I removed
an unnecessary CSS_SHAPES #ifdef as well from RenderBlock.cpp.
No new tests, no behavior change.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markShapeInsideDescendantsForLayout):
(WebCore::RenderBlock::layoutShapeInsideInfo):
- rendering/RenderBlockLineLayout.cpp:
- 11:05 AM Changeset in webkit [157453] by
-
- 7 edits3 adds in trunk/Tools
Add some API tests for Vector, RefPtr, and Ref
https://bugs.webkit.org/show_bug.cgi?id=122840
Reviewed by Andreas Kling.
- TestWebKitAPI/CMakeLists.txt: Added new files.
- TestWebKitAPI/GNUmakefile.am: Ditto.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
- TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
- TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
- TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
- TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
- 11:03 AM Changeset in webkit [157452] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] Introduce const pools in LLINT.
https://bugs.webkit.org/show_bug.cgi?id=122746
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-15
Reviewed by Michael Saboff.
In current implementation of LLINT for sh4, immediate values outside range -128..127 are
loaded this way:
mov.l .label, rx
bra out
nop
.balign 4
.label: .long immvalue
out:
This change introduces const pools for sh4 implementation to avoid lots of useless branches
and reduce code size. It also removes lines of dirty code, like jmpf and callf.
- offlineasm/instructions.rb: Remove jmpf and callf sh4 specific instructions.
- offlineasm/sh4.rb:
- 10:01 AM Changeset in webkit [157451] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix broken C Loop LLINT build.
https://bugs.webkit.org/show_bug.cgi?id=122839.
Reviewed by Michael Saboff.
- dfg/DFGFlushedAt.cpp:
- jit/JITOperations.h:
- 9:39 AM Changeset in webkit [157450] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Build fails.
https://bugs.webkit.org/show_bug.cgi?id=122830
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-15
Reviewed by Brent Fulgham.
- platform/network/NetworkStorageSessionStub.cpp:
(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Update to new return type.
- 6:02 AM Changeset in webkit [157449] by
-
- 5 edits in trunk/Source/WebCore
FileIconLoader should not be ref-counted.
<https://webkit.org/b/122827>
FileIconLoader is singly-owned by FileInputType.
Reviewed by Antti Koivisto.
- 4:45 AM Changeset in webkit [157448] by
-
- 3 edits in trunk/Source/WebCore
RenderText should cache RenderStyle in locals more.
<https://webkit.org/b/122823>
Reviewed by Antti Koivisto.
Now that fetching the RenderStyle has to go through the parent,
we should avoid unnecessary loads by caching style() in a local.
- 4:44 AM Changeset in webkit [157447] by
-
- 2 edits in trunk/Source/WebKit2
[Soup] Unreviewed buildfix after r157445 for ENABLE(NETWORK_PROCESS) builds.
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
- 4:25 AM Changeset in webkit [157446] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix the GTK+ build after r157445.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(didFailProvisionalLoadWithErrorForFrame):
- 3:24 AM Changeset in webkit [157445] by
-
- 48 edits1 copy3 moves1 delete in trunk/Source
Move PlatformCertificateInfo to WebCore and make the ResourceResponse primitives work in terms of that platform agnostic object
https://bugs.webkit.org/show_bug.cgi?id=118520
Reviewed by Anders Carlsson.
Added PlatformCertificateInfo getter and setter to ResourceErrorBase
and ResourceResponseBase so that getting and setting certificates
becomes cross platform.
Changed the existing platform specific certificate getters and setters
of ResourceError and ResourceResponse to use the
PlatformCertificateInfo member.
Original patch by Kwang Yul Seo <skyul@company100.net>
Source/WebCore:
The following things were fixed by Csaba Osztrogonác:
- trivial conflicts resolved in WebCore.exp.in, project.pbxproj, NetworkResourceLoader.cpp, WebPageProxy.h, WebFrameLoaderClient.cpp and PlatformEfl.cmake.
- trivial fix in the new AsynchronousNetworkLoaderClient.cpp
- style fixed (NULL -> 0 and smaller indentation in WebCoreArgumentCodersSoup.cpp)
- obsolete change removed from NetworkResourceLoader.cpp
- unneeded typo removed from ResourceHandleSoup.cpp
- Fixed the if guard of including RetainPtr.h in PlatformCertificateInfo.h to make Windows build happy.
- add PlatformCertificateInfoCFNet.cpp with empty constructor and destructor to make Windows build happy.
- resolved conflict in Source/WebCore/WebCore.xcodeproj/project.pbxproj after r156488
- renamed KURL to URL after r156550.
- removed obsolete Qt changes
- added back initializers for m_soupFlags
- included gio/gio.h instead of libsoup/soup.h in PlatformCertificateInfo.h
- removed unused class forward declarations and includes
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- Target.pri:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/PlatformCertificateInfo.h: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.h.
(WebCore::PlatformCertificateInfo::certificate):
(WebCore::PlatformCertificateInfo::setCertificate):
(WebCore::PlatformCertificateInfo::tlsErrors):
(WebCore::PlatformCertificateInfo::setTLSErrors):
- platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::platformCertificateInfo):
(WebCore::ResourceErrorBase::setPlatformCertificateInfo):
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::platformCertificateInfo):
(WebCore::ResourceResponseBase::setPlatformCertificateInfo):
- platform/network/cf/ResourceResponse.h:
- platform/network/mac/PlatformCertificateInfoMac.mm: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm.
(WebCore::PlatformCertificateInfo::PlatformCertificateInfo):
(WebCore::PlatformCertificateInfo::~PlatformCertificateInfo):
(WebCore::PlatformCertificateInfo::setCertificateChain):
(WebCore::PlatformCertificateInfo::certificateChain):
(WebCore::PlatformCertificateInfo::dump):
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::setCertificateChain):
(WebCore::ResourceResponse::certificateChain):
- platform/network/soup/PlatformCertificateInfoSoup.cpp:
(WebCore::PlatformCertificateInfo::PlatformCertificateInfo):
(WebCore::PlatformCertificateInfo::~PlatformCertificateInfo):
- platform/network/soup/ResourceError.h:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::tlsErrors):
(WebCore::ResourceError::setTLSErrors):
(WebCore::ResourceError::certificate):
(WebCore::ResourceError::setCertificate):
- platform/network/soup/ResourceErrorSoup.cpp:
(WebCore::ResourceError::platformCopy):
- platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::soupMessageCertificate):
(WebCore::ResourceResponse::setSoupMessageCertificate):
(WebCore::ResourceResponse::soupMessageTLSErrors):
(WebCore::ResourceResponse::setSoupMessageTLSErrors):
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::toSoupMessage):
(WebCore::ResourceResponse::updateFromSoupMessage):
Source/WebKit2:
The following things were fixed by Csaba Osztrogonác:
- trivial conflicts resolved in WebCore.exp.in, project.pbxproj, NetworkResourceLoader.cpp, WebPageProxy.h, WebFrameLoaderClient.cpp and PlatformEfl.cmake.
- trivial fix in the new AsynchronousNetworkLoaderClient.cpp
- style fixed (NULL -> 0 and smaller indentation in WebCoreArgumentCodersSoup.cpp)
- obsolete change removed from NetworkResourceLoader.cpp
- unneeded typo removed from ResourceHandleSoup.cpp
- Fixed the if guard of including RetainPtr.h in PlatformCertificateInfo.h to make Windows build happy.
- add PlatformCertificateInfoCFNet.cpp with empty constructor and destructor to make Windows build happy.
- resolve conflict in Source/WebCore/WebCore.xcodeproj/project.pbxproj after r156488
- rename KURL to URL after r156550.
- remove obsolete Qt changes
- added back initializers for m_soupFlags
- included gio/gio.h instead of libsoup/soup.h in PlatformCertificateInfo.h
- removed unused class forward declarations and includes
- GNUmakefile.list.am:
- NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/mac/NetworkProcessMac.mm:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithCertficateChain):
- Shared/Authentication/AuthenticationManager.h:
- Shared/Authentication/AuthenticationManager.messages.in:
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
- Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebCertificateInfo.h:
(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::::encode):
- Shared/WebCoreArgumentCoders.h:
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- Shared/soup/PlatformCertificateInfo.cpp: Removed.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- Target.pri:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_tls_info):
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::useCredential):
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
- 12:02 AM Changeset in webkit [157444] by
-
- 4 edits in trunk/Source/WebCore
Remove redundant Document::getElementById
https://bugs.webkit.org/show_bug.cgi?id=122813
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/4e8f1c5316415614b84370c602beae4a1008299f
This function simply calls virtual TreeScope::getElementById and Document inherits from TreeScope.
- WebCore.exp.in:
- dom/Document.cpp:
- dom/Document.h:
Oct 14, 2013:
- 10:55 PM Changeset in webkit [157443] by
-
- 4 edits4 adds in trunk
Source/WebCore: in safari,the background-color of input[type="search"] can't work
https://bugs.webkit.org/show_bug.cgi?id=119967
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-14
Reviewed by Ryosuke Niwa.
When input type=search is styled with css background property then
it does not change the background-color of field. Its happening becasue
search field is not counted as styled control. Thus theme ignores the
css background property. With this patch search field is also counted as
styled control so background property reflects on search field.
Test: fast/forms/search/search-field-background-color.html
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isControlStyled):Now search field is also
a styled control.
LayoutTests: in safari ,the background-color of input[type="search"] can't work
https://bugs.webkit.org/show_bug.cgi?id=119967
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-14
Reviewed by Ryosuke Niwa.
Added testcase to verify the background color of search field when
search field is styled with css background property.
- fast/forms/search/search-field-background-color-expected.txt: Added.
- fast/forms/search/search-field-background-color.html: Added.
- platform/mac/fast/forms/search-styled-expected.txt: Rebaselined.
- 10:06 PM Changeset in webkit [157442] by
-
- 1 edit22 moves1 add in trunk/LayoutTests
[CSS Shapes] Move shape-inside floats tests into their own subdirectory
https://bugs.webkit.org/show_bug.cgi?id=122761
Reviewed by Sam Weinig.
I'm going to add some new float tests soon. In order to keep our shapes tests organized,
I'm moving the shape-inside with floating content tests to their own subdirectory.
- fast/shapes/shape-inside/floats/shape-inside-floats-simple-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-floats-simple-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-floats-simple.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-floats-simple.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html.
- 9:08 PM Changeset in webkit [157441] by
-
- 3 edits in trunk/Source/WebCore
EventPath::updateTouchLists traverses through EventPath thrice
https://bugs.webkit.org/show_bug.cgi?id=122804
Reviewed by Benjamin Poulain.
Instead of traversing through EventPath for each TouchList, traverse through TouchList for every EventContext.
This paves our way to have one-pass traversal over EventPath, and evetually to remove EventContext altogether.
This change should also improve the cache hit rate since all Touch objects tend to be allocated at the same time
but this performance improvement is probably not observable.
- dom/EventContext.h:
- dom/EventDispatcher.cpp:
(WebCore::EventRelatedNodeResolver::EventRelatedNodeResolver): Added a new constructor that takes Touch and
and TouchListType. We need to store these two values in order to update EventContext later.
(WebCore::EventRelatedNodeResolver::touch): Added,
(WebCore::EventRelatedNodeResolver::touchListType): Added.
(WebCore::addRelatedNodeResolversForTouchList): Extracted from updateTouchListsInEventPath.
(WebCore::EventPath::updateTouchLists): Moved the loop over m_path here. Notice that the outer loop iterates
over m_path instead of touchList as done in updateTouchListsInEventPath. The inner loop goes through resolvers
and adds Touch objects each EventContext as needed.
- 8:48 PM Changeset in webkit [157440] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Below tests don't be failed anymore after enabling subpixel layout.
fast/spatial-navigation/snav-container-white-space.html
fast/spatial-navigation/snav-fully-aligned-horizontally.html
fast/spatial-navigation/snav-iframe-no-scrollable-content.html
- platform/efl/TestExpectations:
- 8:03 PM Changeset in webkit [157439] by
-
- 11 edits in trunk/Source/JavaScriptCore
Transition *switch* and *scope* JITStubs to JIT operations.
https://bugs.webkit.org/show_bug.cgi?id=122757.
Reviewed by Geoffrey Garen.
Transitioning:
cti_op_switch_char
cti_op_switch_imm
cti_op_switch_string
cti_op_resolve_scope
cti_op_get_from_scope
cti_op_put_to_scope
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 7:47 PM Changeset in webkit [157438] by
-
- 16 edits in trunk/Source/WebCore
Don't generate a wasteful isObservable check in isReachableFromOpaqueRoots
https://bugs.webkit.org/show_bug.cgi?id=122802
Reviewed by Mark Hahnenberg.
- bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Don't.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/JS/JSreadonly.cpp:
Updated results.
- 6:06 PM Changeset in webkit [157437] by
-
- 5 edits1 delete in trunk
Windows select element doesn't draw RTL properly.
https://bugs.webkit.org/show_bug.cgi?id=122785.
Reviewed by Brent Fulgham.
Problems include the popup items not drawing on the right hand side and
not respecting the direction or the directional override styling of the option.
The selected element (drawn in the actual select element) also doesn't respect
the style settings of the selected menu option.
Tests:
Covered by fast/text/international/pop-up-button-text-alignment-and-direction.html.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint):
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):
- platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
- 5:38 PM Changeset in webkit [157436] by
-
- 3 edits2 adds in trunk
Source/WebCore: AX: fieldset should have GroupRole and legend should be description.
https://bugs.webkit.org/show_bug.cgi?id=122534
Patch by Samuel White <Samuel White> on 2013-10-14
Reviewed by Chris Fleizach.
Changes fieldset to derive AXDescription from legend if one is available. Added
convenience method to AccessibilityObject to fetch element if available.
Test: accessibility/fieldset-element.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::alternativeText):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::element):
(WebCore::AccessibilityObject::isARIAHidden):
(WebCore::AccessibilityObject::isDOMHidden):
(WebCore::AccessibilityObject::defaultObjectInclusion):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isHidden):
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::getAttribute):
(WebCore::AccessibilitySlider::valueForRange):
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):
(WebCore::AccessibilitySlider::setValue):
(WebCore::AccessibilitySlider::inputElement):
- accessibility/AccessibilitySlider.h:
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::legend):
- html/HTMLFieldSetElement.h:
LayoutTests: Crash in WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>::createBidiRunsForLine
https://bugs.webkit.org/show_bug.cgi?id=122776
Reviewed by Darin Adler.
- fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash-expected.txt: Added.
- fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash.html: Added.
- 5:35 PM Changeset in webkit [157435] by
-
- 2 edits in trunk/Tools
Adding myself to CC list for some components.
- Scripts/webkitpy/common/config/watchlist:
- 5:23 PM Changeset in webkit [157434] by
-
- 12 edits2 adds6 deletes in trunk
AX: fieldset should have GroupRole and legend should be description.
https://bugs.webkit.org/show_bug.cgi?id=122534
Patch by Samuel White <Samuel White> on 2013-10-14
Reviewed by Chris Fleizach.
Source/WebCore:
Changes fieldset to derive AXDescription from legend if one is available. Added
convenience method to AccessibilityObject to fetch element if available.
Test: accessibility/fieldset-element.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::alternativeText):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::element):
(WebCore::AccessibilityObject::isARIAHidden):
(WebCore::AccessibilityObject::isDOMHidden):
(WebCore::AccessibilityObject::defaultObjectInclusion):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isHidden):
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::getAttribute):
(WebCore::AccessibilitySlider::valueForRange):
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):
(WebCore::AccessibilitySlider::setValue):
(WebCore::AccessibilitySlider::inputElement):
- accessibility/AccessibilitySlider.h:
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::legend):
- html/HTMLFieldSetElement.h:
LayoutTests:
legend no longer treated as titleUIElement so removing tests that check this functionality.
Added test to check that legend is used as AXDescription of fieldset if present.
- accessibility/fieldset-element.html: Added.
- accessibility/hidden-legend-expected.txt: Removed.
- accessibility/hidden-legend.html: Removed.
- accessibility/legend.html: Removed.
- platform/efl/accessibility/legend-expected.txt: Removed.
- platform/gtk/accessibility/legend-expected.txt: Removed.
- platform/mac/accessibility/fieldset-element-expected.txt: Added.
- platform/mac/accessibility/legend-expected.txt: Removed.
- platform/mac/accessibility/role-subrole-roledescription-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription.html:
- 5:05 PM Changeset in webkit [157433] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG PutById IC should use the ConcurrentJITLocker since it's now dealing with IC's that get read by the compiler thread
https://bugs.webkit.org/show_bug.cgi?id=122786
Reviewed by Mark Hahnenberg.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStub): Resetting a stub should acquire the lock since this is observable from the thread; but we should only acquire the lock if we're resetting outside of GC.
- jit/Repatch.cpp:
(JSC::repatchPutByID): Doing the PutById patching should hold the lock.
(JSC::buildPutByIdList): Ditto.
- 5:02 PM Changeset in webkit [157432] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Unreviewed build fix.
- WebCore.vcxproj/WebCoreCommon.props:
- 4:58 PM Changeset in webkit [157431] by
-
- 3 edits2 adds in trunk
Assertion failure in Range::processContentsBetweenOffsets
https://bugs.webkit.org/show_bug.cgi?id=122777
Reviewed by Darin Adler.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/c15de182774c7859c20d97126eb844ae97b792a4
This patch changes ASSERT statements for checking |endOffset| inbound in Range::processContentsBetweenOffsets()
to limit |endOffset|. This is necessary when DOMNodeRemovedFromDocument event handler splits text nodes,
Range::insertNode() on text node, in the range calling Range::deleteContents().
Test: fast/dom/Range/range-delete-contents-mutation-event-crash.html
- dom/Range.cpp:
(WebCore::Range::processContentsBetweenOffsets):
LayoutTests:
- fast/dom/Range/range-delete-contents-mutation-event-crash-expected.txt: Added.
- fast/dom/Range/range-delete-contents-mutation-event-crash.html: Added.
- 4:36 PM Changeset in webkit [157430] by
-
- 12 edits11 adds in trunk
Add an empty window.crypto.webkitSubtle
https://bugs.webkit.org/show_bug.cgi?id=122778
Reviewed by Mark Hahnenberg.
Source/WebCore:
Tests: security/crypto-subtle-gc-2.html
security/crypto-subtle-gc-3.html
security/crypto-subtle-gc.html
- DerivedSources.make: Process SubtleCrypto.idl.
- crypto: Added.
- WebCore.xcodeproj/project.pbxproj:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- bindings/js/JSSubtleCryptoCustom.cpp: Added. Empty for now, but we'll certainly
need custom bindings code here.
- crypto/SubtleCrypto.cpp: Added.
(WebCore::SubtleCrypto::SubtleCrypto):
(WebCore::SubtleCrypto::document):
- crypto/SubtleCrypto.h: Added.
- crypto/SubtleCrypto.idl: Added.
- page/Crypto.cpp:
(WebCore::Crypto::subtle):
- page/Crypto.h:
- page/Crypto.idl:
LayoutTests:
- TestExpectations: The feature isn't enabled anywhere yet, so skipping the new tests.
- security/crypto-subtle-gc-2-expected.txt: Added.
- security/crypto-subtle-gc-2.html: Added.
- security/crypto-subtle-gc-3-expected.txt: Added.
- security/crypto-subtle-gc-3.html: Added.
- security/crypto-subtle-gc-expected.txt: Added.
- security/crypto-subtle-gc.html: Added.
- 4:30 PM Changeset in webkit [157429] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add FTL support for LogicalNot(string)
https://bugs.webkit.org/show_bug.cgi?id=122765
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-14
Reviewed by Filip Pizlo.
This patch is tested by:
regress/script-tests/emscripten-cube2hash.js.ftl-eager
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
- 4:26 PM Changeset in webkit [157428] by
-
- 6 edits in trunk/Source/WebCore
Remove GestureEvent leftovers from WebCore
<https://webkit.org/b/122780>
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-10-14
Reviewed by Anders Carlsson.
- Removed some remaining references to PlatformGestureEvent, supposed to be removed by r157316
- TOUCH_ADJUSTMENT should be reworked after GestureEvent feature removal
- page/EventHandler.cpp:
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
- page/EventHandler.h:
- platform/PlatformEvent.h:
- platform/ScrollAnimatorNone.cpp:
- platform/ScrollableArea.h:
- 4:22 PM Changeset in webkit [157427] by
-
- 5 edits in trunk/Source/JavaScriptCore
[sh4] Fixes after r157404 and r157411.
https://bugs.webkit.org/show_bug.cgi?id=122782
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-14
Reviewed by Michael Saboff.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation): Add missing SH4_32BIT_DUMMY_ARG.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JITInlines.h:
(JSC::JIT::callOperation): Add missing SH4_32BIT_DUMMY_ARG.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_id): Remove unwanted BEGIN_UNINTERRUPTED_SEQUENCE.
- 4:17 PM Changeset in webkit [157426] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r157366
http://bugs.webkit.org/show_bug.cgi?id=122783
When TOUCH_AJUSTMENT is enabled build fails due to some
refactors in TextRender functions.
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-10-14
Reviewed by Anders Carlsson.
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::appendContextSubtargetsForNode):
- 4:08 PM Changeset in webkit [157425] by
-
- 5 edits3 adds in trunk
The content of the DOM panel for iframes is not updated until the "onload" event
https://bugs.webkit.org/show_bug.cgi?id=122653
Reviewed by Darin Adler.
Source/WebCore:
Test: http/tests/inspector-protocol/loading-iframe-document-node.html
Renamed InspectorDOMAgent::loadEventFired to InspectorDOMAgent::didCommitLoad and moved the call site
from InspectorInstrumentation::loadEventFiredImpl to InspectorInstrumentation::didCommitLoadImpl.
This is to make sure that it will invalidate the content of the iframe as soon as the frame navigates
to a different page. This way the new node can be retrieved as soon as the page has some content, and
not just when the page is fully loaded.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didCommitLoad): Renamed from loadEventFired, as it is now called from
didCommitLoadImpl instead.
(WebCore::InspectorDOMAgent::frameDocumentUpdated): Updated comment to point to the new function name.
- inspector/InspectorDOMAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::loadEventFiredImpl): Removed call do InspectorDOMAgent.loadEventFired.
(WebCore::InspectorInstrumentation::didCommitLoadImpl): Added call to InspectorDOMAgent.didCommitLoad.
LayoutTests:
Added test to check that immediately after the scripting context is created, the
inspector already has access to the nodeId of the document of the iframe.
- http/tests/inspector-protocol/loading-iframe-document-node-expected.txt: Added.
- http/tests/inspector-protocol/loading-iframe-document-node.html: Added.
- http/tests/inspector-protocol/resources/slow-test-page.html: Added.
- 2:59 PM Changeset in webkit [157424] by
-
- 14 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r157413.
http://trac.webkit.org/changeset/157413
https://bugs.webkit.org/show_bug.cgi?id=122779
Appears to have caused frequent crashes (Requested by ap on
#webkit).
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/DeferGC.cpp: Removed.
- heap/DeferGC.h:
- jit/JITStubs.cpp:
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/ConcurrentJITLock.h:
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSCellInlines.h:
(JSC::allocateCell):
- runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
- runtime/Structure.h:
- 2:45 PM Changeset in webkit [157423] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=122774.
<rdar://problem/6138855>.
Reviewed by Brent Fulgham.
Add a field to keep track of hovered over index.
Use index to determine whether or not to use the existing selected index on the mouse down event.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::PopupMenuWin):
(WebCore::PopupMenuWin::show):
(WebCore::PopupMenuWin::wndProc):
- platform/win/PopupMenuWin.h:
- 2:41 PM Changeset in webkit [157422] by
-
- 2 edits in trunk/Source/JavaScriptCore
COLLECT_ON_EVERY_ALLOCATION causes assertion failures
https://bugs.webkit.org/show_bug.cgi?id=122652
Reviewed by Filip Pizlo.
COLLECT_ON_EVERY_ALLOCATION wasn't accounting for the new GC deferral mechanism,
so we would end up ASSERTing during garbage collection.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateSlowCase):
- 2:11 PM Changeset in webkit [157421] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix the paths so that the test passes.
- js/regress/put-by-id.html:
- 2:08 PM Changeset in webkit [157420] by
-
- 7 edits in trunk/Source/JavaScriptCore
Separate out array iteration intrinsics
https://bugs.webkit.org/show_bug.cgi?id=122656
Reviewed by Michael Saboff.
Separate out the intrinsics for key and values iteration
of arrays.
This requires moving moving array iteration into the iterator
instance, rather than the prototype, but this is essentially
unobservable so we'll live with it for now.
- jit/ThunkGenerators.cpp:
(JSC::arrayIteratorNextThunkGenerator):
(JSC::arrayIteratorNextKeyThunkGenerator):
(JSC::arrayIteratorNextValueThunkGenerator):
- jit/ThunkGenerators.h:
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
- runtime/Intrinsic.h:
- runtime/JSArrayIterator.cpp:
(JSC::JSArrayIterator::finishCreation):
(JSC::createIteratorResult):
(JSC::arrayIteratorNext):
(JSC::arrayIteratorNextKey):
(JSC::arrayIteratorNextValue):
(JSC::arrayIteratorNextGeneric):
- runtime/VM.cpp:
(JSC::thunkGeneratorForIntrinsic):
- 1:49 PM Changeset in webkit [157419] by
-
- 18 edits3 adds in trunk/Source
Virtualize PlatformCALayer
https://bugs.webkit.org/show_bug.cgi?id=122672
Reviewed by Anders Carlsson.
No new tests, just a refactoring.
- WebCore.exp.in:
setGeometryFlipped is on PlatformCALayerMac now.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
Add PlatformCALayer.cpp, PlatformCALayerWin.h, and let VS do its
thing with some other files.
- WebCore.xcodeproj/project.pbxproj:
Add PlatformCALayer.cpp and PlatformCALayerMac.h.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::platformLayer):
Make a PlatformCALayerWin explicitly.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createPlatformCALayer):
Added. Decide whether to make a PlatformCALayer{Mac, Win} based on the platform.
Later, we will decide between other subclasses based on other things.
(WebCore::GraphicsLayerCA::filtersCanBeComposited):
Do the same thing for filtersCanBeComposited.
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setContentsToSolidColor):
(WebCore::GraphicsLayerCA::setContentsToMedia):
(WebCore::GraphicsLayerCA::setContentsToCanvas):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRects):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Use createPlatformCALayer instead of PlatformCALayer::create.
- platform/graphics/ca/mac/PlatformCAFiltersMac.mm:
For now, use the PlatformCALayerMac version of filtersCanBeComposited,
since this code is heavily tied to having CALayers in the Web process.
- platform/graphics/ca/GraphicsLayerCA.h:
Include PlatformCALayer.h here so we can get the LayerType enum.
(NOTE-to-be-removed: if there's a better way to do this, I'm open to
suggestions; I couldn't puzzle out nested 'enum class' stuff).
Add the createPlatformCALayers.
- platform/graphics/ca/PlatformCAAnimation.h:
Friend the subclasses too.
- platform/graphics/ca/PlatformCALayer.cpp: Added.
(WebCore::PlatformCALayer::~PlatformCALayer):
Pull the shared part of the PlatformCALayer destructor out.
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::platformLayer):
(WebCore::PlatformCALayer::setOwner):
(WebCore::PlatformCALayer::PlatformCALayer):
Virtualize all the things. Move platform specific members to their new subclasses.
- platform/graphics/ca/mac/PlatformCALayerMac.h: Added.
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
Move the PLATFORM(MAC) implementations from PlatformCALayer to PlatformCALayerMac.
(PlatformCALayer::platformCALayer):
The platformCALayer lookup function is static on PlatformCALayer, so it can't
be moved to the subclasses. It might be a good idea in the future to move towards
a platform-independent mechanism for looking up PlatformCALayers from PlatformLayers,
and to avoid needing to do this as often as we do now.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost):
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
Move the PLATFORM(WIN) implementations from PlatformCALayer to PlatformCALayerWin.
(PlatformCALayerWin::create):
(PlatformCALayer::platformCALayer):
- platform/graphics/ca/win/PlatformCALayerWin.h: Added.
- platform/graphics/win/GraphicsContext3DWin.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::createLayerForMovie):
Include PlatformCALayerWin.h and explicitly make PlatformCALayerWins here.
- FullscreenVideoController.cpp:
(FullscreenVideoController::FullscreenVideoController):
Include PlatformCALayerWin.h and explicitly make PlatformCALayerWins here.
- 1:44 PM Changeset in webkit [157418] by
-
- 3 edits in trunk/Source/WebCore
[cmake] MediaControlsApple is used only by Efl port and is on CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=122772
Reviewed by Anders Carlsson.
- CMakeLists.txt: Removed MediaControlsApple.cpp
- PlatformEfl.cmake: Added MediaControlsApple.cpp
- 1:28 PM Changeset in webkit [157417] by
-
- 6 edits2 adds in trunk
window.crypto doesn't preserve custom properties
https://bugs.webkit.org/show_bug.cgi?id=122770
Reviewed by Mark Hahnenberg.
Source/WebCore:
Test: security/crypto-gc.html
Generate isReachableFromOpaqueRoots that makes Crypto live as long as the document
lives (because that's when it's observable through window object).
- page/Crypto.cpp:
(WebCore::Crypto::Crypto):
(WebCore::Crypto::~Crypto):
(WebCore::Crypto::document):
- page/Crypto.h:
(WebCore::Crypto::create):
Made Crypto a ContextDestructionObserver, so that it can report its document to bindings.
Removed ScriptWrappable, because it seems to have served no purpose in this class.
- page/Crypto.idl: Added GenerateIsReachable. Removed ImplementationLacksVTable,
because the class now has a vtable, and can be checked for bindings integrity.
- page/DOMWindow.cpp: (WebCore::DOMWindow::crypto): Pass a document when creating
crypto.
LayoutTests:
- security/crypto-gc-expected.txt: Added.
- security/crypto-gc.html: Added.
- 1:11 PM Changeset in webkit [157416] by
-
- 4 edits in trunk/Source/WebCore
CTTE: NamedNodeMap always has a corresponding Element.
<https://webkit.org/b/122769>
Reviewed by Anders Carlsson.
Made NamedNodeMap::m_element a reference and remove an assertion
that it's never null.
- 12:53 PM Changeset in webkit [157415] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r157408): Crashes in RenderFullScreen::wrapRenderer().
Unreviewed crash fix for these two tests:
- fullscreen/full-screen-restrictions.html
- fullscreen/empty-anonymous-block-continuation-crash.html
- rendering/RenderFullScreen.cpp:
(RenderFullScreen::wrapRenderer):
Get the RenderArena from Document like we did before this patch.
- 12:35 PM Changeset in webkit [157414] by
-
- 4 edits2 adds in trunk
[CSS Shapes] Image valued shape-outside shapes should update the layout after the image has been loaded
https://bugs.webkit.org/show_bug.cgi?id=122340
Reviewed by Simon Fraser.
Source/WebCore:
Ensure that the an image-valued shape-outside layout is updated after the image has
been loaded.
Test: http/tests/css/css-image-valued-shape.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::imageChanged): Added code for the shape-outside case.
(WebCore::RenderBlock::updateShapeInsideInfoAfterStyleChange): Ditto.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::~RenderElement): Ditto.
(WebCore::RenderElement::setStyle): Ditto.
LayoutTests:
Verify that an image-valued shape-outside layout is updated after the image has been loaded.
- http/tests/css/css-image-valued-shape-expected.txt: Added.
- http/tests/css/css-image-valued-shape.html: Added.
- 12:34 PM Changeset in webkit [157413] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
llint_slow_path_put_by_id can deadlock on a ConcurrentJITLock
https://bugs.webkit.org/show_bug.cgi?id=122667
Reviewed by Filip Pizlo.
The issue this patch is attempting to fix is that there are places in our codebase
where we acquire the ConcurrentJITLock for a particular CodeBlock, then we do some
operations that can initiate a garbage collection. Garbage collection then calls
some methods of CodeBlock that also take the ConcurrentJITLock (because they don't
always necessarily run during garbage collection). This causes a deadlock.
To fix this issue, this patch adds a new RAII-style object (DisallowGC) that stores
into a thread-local field that indicates that it is unsafe to perform any operation
that could trigger garbage collection on the current thread. In debug builds,
ConcurrentJITLocker contains one of these DisallowGC objects so that we can eagerly
detect deadlocks.
This patch also adds a new type of ConcurrentJITLocker, GCSafeConcurrentJITLocker,
which uses the DeferGC mechanism to prevent collections from occurring while the
lock is held.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/DeferGC.cpp: Added.
- heap/DeferGC.h:
(JSC::DisallowGC::DisallowGC):
(JSC::DisallowGC::~DisallowGC):
(JSC::DisallowGC::isGCDisallowedOnCurrentThread):
(JSC::DisallowGC::initialize):
- jit/JITStubs.cpp:
(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/ConcurrentJITLock.h:
(JSC::ConcurrentJITLockerBase::ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::~ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::unlockEarly):
(JSC::GCSafeConcurrentJITLocker::GCSafeConcurrentJITLocker):
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSCellInlines.h:
(JSC::allocateCell):
- runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
- runtime/Structure.h:
- 12:24 PM Changeset in webkit [157412] by
-
- 3 edits in trunk/Source/WebCore
Remove some silly null checks in Element/NamedNodeMap.
<https://webkit.org/b/122767>
Reviewed by Darin Adler.
Make shouldIgnoreAttributeCase() take a const Element&, exposing
some unnecessary null checks.
- 11:39 AM Changeset in webkit [157411] by
-
- 19 edits3 adds in trunk
Baseline JIT should use the DFG's PutById IC
https://bugs.webkit.org/show_bug.cgi?id=122704
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Mostly no big deal, just removing the old Baseline JIT's put_by_id IC support and forcing
that JIT to use the DFG's (i.e. JITOperations) PutById IC.
The only complicated part was that the PutById operations assumed that we first did a
cell speculation, which the baseline JIT obviously won't do. So I changed all of those
slow paths to deal with EncodedJSValue's.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- jit/JIT.h:
(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
(JSC::PropertyStubCompilationInfo::slowCaseInfo):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOperationWrappers.h:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/Repatch.cpp:
(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateListBuildingPutByIdFunction):
(JSC::resetPutByID):
LayoutTests:
Reviewed by Mark Hahnenberg.
- js/regress/put-by-id-expected.txt: Added.
- js/regress/put-by-id.html: Added.
- js/regress/script-tests/put-by-id.js: Added.
(foo):
(bar):
- 11:29 AM Changeset in webkit [157410] by
-
- 2 edits in trunk/Source/WebCore
[Win] Build fix after r122737.
- dom/Node.h: Add explicit WebCore namespace to macro definition to work around
Visual Studio bug.
- 11:08 AM Changeset in webkit [157409] by
-
- 7 edits in trunk/Source/JavaScriptCore
FTL should have an inefficient but correct implementation of GetById
https://bugs.webkit.org/show_bug.cgi?id=122740
Reviewed by Mark Hahnenberg.
It took some effort to realize that the node->prediction() check in the DFG backends
are completely unnecessary since the ByteCodeParser will always insert a ForceOSRExit
if !prediction.
But other than that this was an easy patch.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
- 10:55 AM Changeset in webkit [157408] by
-
- 149 edits in trunk/Source/WebCore
Pass Document directly to anonymous renderer constructors.
<https://webkit.org/b/122752>
Reviewed by Antti Koivisto.
Added separate constructors for creating anonymous renderers that
take a Document& instead of a null Element*/Text*.
Removed setDocumentForAnonymous() and all createAnonymous() helpers.
...and RenderObject::m_node is now a Node&, wohoo!
- 10:50 AM Changeset in webkit [157407] by
-
- 7 edits8 moves1 add in trunk/LayoutTests
[CSSRegions] Move style-scoped* tests into fast/regions/style-scoped
https://bugs.webkit.org/show_bug.cgi?id=122741
Reviewed by Darin Adler.
Move files, adjust TestExpectations.
- fast/regions/style-scoped/style-scoped-in-flow-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-expected.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-container-style-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-container-style-expected.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-container-style.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-container-style.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-expected.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-region-styling.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling.html.
- fast/regions/style-scoped/style-scoped-in-flow.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow.html.
- platform/efl/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 10:16 AM Changeset in webkit [157406] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Efl][Soup] Make NetworkProcessMainUnix handle proxy settings.
https://bugs.webkit.org/show_bug.cgi?id=118388
Reviewed by Carlos Garcia Campos.
Original patch by Kwang Yul Seo <skyul@company100.net> .
Proxy configuration should honor the no_proxy environment variable
same to WebProcess. It is necessary not to change the current behaviour.
See https://bugs.webkit.org/show_bug.cgi?id=91747 for details.
The following things were fixed by Csaba Osztrogonác:
- moved session variable before #if not to have conflict with https://bugs.webkit.org/show_bug.cgi?id=118343
- added GRefPtr.h include
- fixed ifdef guards
- NetworkProcess/unix/NetworkProcessMainUnix.cpp:
(WebKit::NetworkProcessMain):
Copied from WebProcessMainEfl.cpp.
- 9:52 AM Changeset in webkit [157405] by
-
- 31 edits in trunk/Source/WebCore
CTTE: Add more node conversion helpers
https://bugs.webkit.org/show_bug.cgi?id=122737
Reviewed by Darin Adler.
- Factor NODE_TYPE_CASTS into TYPE_CASTS_BASE(ToClassName, FromClassName) to allow for DOCUMENT_TYPE_CASTS.
- Replace more static_casts<>.
- 9:42 AM Changeset in webkit [157404] by
-
- 16 edits in trunk/Source/JavaScriptCore
Transition misc cti_op_* JITStubs to JIT operations.
https://bugs.webkit.org/show_bug.cgi?id=122645.
Reviewed by Michael Saboff.
Stubs converted:
cti_op_check_has_instance
cti_op_create_arguments
cti_op_del_by_id
cti_op_instanceof
cti_to_object
cti_op_push_activation
cti_op_get_pnames
cti_op_load_varargs
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JIT.h:
(JSC::JIT::emitStoreCell):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_del_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_del_by_id):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 8:55 AM Changeset in webkit [157403] by
-
- 9 edits31 adds in trunk/LayoutTests
Unreviewed EFL gardening
Added new baselines for tests marked as skipped.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/compositing/overflow/nested-scrolling-expected.txt: Added.
- platform/efl/compositing/overflow/remove-overflow-crash2-expected.png: Added.
- platform/efl/compositing/overflow/remove-overflow-crash2-expected.txt: Added.
- platform/efl/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.
- platform/efl/editing/unsupported-content/list-delete-001-expected.png:
- platform/efl/editing/unsupported-content/list-delete-001-expected.txt: Added.
- platform/efl/editing/unsupported-content/list-delete-003-expected.png:
- platform/efl/editing/unsupported-content/list-delete-003-expected.txt: Added.
- platform/efl/editing/unsupported-content/list-type-after-expected.png:
- platform/efl/editing/unsupported-content/list-type-after-expected.txt: Added.
- platform/efl/editing/unsupported-content/table-delete-002-expected.png:
- platform/efl/editing/unsupported-content/table-delete-002-expected.txt: Added.
- platform/efl/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
- platform/efl/fast/table/click-near-anonymous-table-expected.png: Added.
- platform/efl/fast/table/click-near-anonymous-table-expected.txt: Added.
- platform/efl/fast/text/international/arabic-justify-expected.png: Added.
- platform/efl/fast/text/international/arabic-justify-expected.txt: Added.
- platform/efl/fast/text/international/bidi-linebreak-001-expected.png: Added.
- platform/efl/fast/text/international/bidi-linebreak-001-expected.txt: Added.
- platform/efl/fast/text/international/bidi-linebreak-002-expected.png: Added.
- platform/efl/fast/text/international/bidi-linebreak-002-expected.txt: Added.
- platform/efl/fast/text/international/bidi-linebreak-003-expected.png: Added.
- platform/efl/fast/text/international/bidi-linebreak-003-expected.txt: Added.
- platform/efl/fast/text/unicode-variation-selector-expected.png: Added.
- platform/efl/fast/text/unicode-variation-selector-expected.txt: Added.
- platform/efl/media/video-colorspace-yuv420-expected.png: Added.
- platform/efl/media/video-colorspace-yuv420-expected.txt: Added.
- platform/efl/media/video-colorspace-yuv422-expected.png: Added.
- platform/efl/media/video-colorspace-yuv422-expected.txt: Added.
- platform/efl/svg/as-image/image-respects-deviceScaleFactor-expected.png: Added.
- platform/efl/svg/as-image/image-respects-deviceScaleFactor-expected.txt: Added.
- platform/efl/svg/hixie/data-types/002-expected.png: Added.
- platform/efl/svg/hixie/data-types/002-expected.txt:
- platform/efl/svg/text/non-bmp-positioning-lists-expected.png: Added.
- platform/efl/svg/text/non-bmp-positioning-lists-expected.txt: Added.
- platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
- platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
- 8:46 AM Changeset in webkit [157402] by
-
- 2 edits in trunk/Source/WTF
Static assertions in WTF::adoptPtr should point to using adoptRef for ref-counted objects
https://bugs.webkit.org/show_bug.cgi?id=122745
Reviewed by Anders Carlsson.
- wtf/PassOwnPtr.h:
(WTF::adoptPtr): When the object's type is convertible to the RefCountedBase or ThreadSafeRefCountedBase type,
the static assertion should note that adoptRef should be used instead.
- 8:45 AM Changeset in webkit [157401] by
-
- 2 edits in trunk/Source/WebCore
Reintroduce PassRefPtr<Event> copy in ScopedEventQueue::dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=122742
Reviewed by Alexey Proskuryakov.
This is a follow-up to r157219 which introduced a workaround for the GCC's quirky behavior that
was resulting in crashes due to the PassRefPtr<Event> object passed to EventDispatcher::dispatchEvent
being copied and nullified first before retrieving the EventTarget of the Event object wrapped in that
PassRefPtr.
The implementation is now adjusted to first retrieve the pointer to the Event's EventTarget and store
it in a local variable. That variable is then passed as the first parameter to EventDispatcher::dispatchEvent,
and the PassRefPtr<Event> passed directly as the second parameter. Previously the pointer of that PassRefPtr
object was passed in, with a new PassRefPtr being created which would increase the reference count of the
ref-counted object. Passing in the original PassRefPtr avoids the unnecessary reference count increase by creating
a copy. That still nullifies the original PassRefPtr, but that's not a problem anymore.
- dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::dispatchEvent):
- 8:34 AM Changeset in webkit [157400] by
-
- 4 edits4 adds in trunk
[CSS Shapes] Shape-Margin should be animatable
https://bugs.webkit.org/show_bug.cgi?id=122524
Reviewed by Darin Adler.
Source/WebCore:
Mark content for relayout after shape-margin changes, and add shape-margin
to the list of animatable properties.
Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html
fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add
shape-margin to the map of animatable CSS properties.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Compare shape-margins,
and mark dependent content for relayout if they have changed.
LayoutTests:
Test that shape-margin can be set dynamically and content lays out correctly.
Also test that shape-margin can be manipulated through CSS Animations.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html: Added.
- 7:17 AM Changeset in webkit [157399] by
-
- 2 edits in trunk/LayoutTests
[EFL] Accessibility gardening
https://bugs.webkit.org/show_bug.cgi?id=122751
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-14
- platform/efl-wk2/TestExpectations: Add bug numbers and marked missing tests.
- 7:03 AM Changeset in webkit [157398] by
-
- 2 edits in trunk/Source/WebCore
Don't crash after OpenGL robustness reset
https://bugs.webkit.org/show_bug.cgi?id=122750
Patch by Arvid Nilsson <anilsson@blackberry.com> on 2013-10-14
Reviewed by George Staikos.
JIRA 517132.
Just log the incident and pretend like nothing happened.
No new tests, we don't have repeatable steps to reproduce a robustness
reset.
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::makeContextCurrent):
- 6:39 AM Changeset in webkit [157397] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Buildfix after r157393
https://bugs.webkit.org/show_bug.cgi?id=122749
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-14
Reviewed by Andreas Kling.
Buildfix with error enumeration value 'CSS_FR' not handled in switch.
- css/CSSCalculationValue.cpp:
(WebCore::hasDoubleValue):
- 6:08 AM Changeset in webkit [157396] by
-
- 3 edits in trunk/Source/WTF
WebKit Nightlies broken by r157374
https://bugs.webkit.org/show_bug.cgi?id=122736
Reviewed by Andreas Kling.
Add back a callOnMainThread overload that Safari is using.
- wtf/MainThread.cpp:
(WTF::callOnMainThread):
- wtf/MainThread.h:
- 5:48 AM Changeset in webkit [157395] by
-
- 2 edits5 adds in trunk/LayoutTests
Unreviewed. EFL Gardening.
Add baselines for new tests which was added by r156767.
- platform/efl/TestExpectations: Remove tests supported by this commit.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
- platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Added.
- 3:41 AM Changeset in webkit [157394] by
-
- 4 edits1 add in trunk
[EFL] Present replaced objects with 0xFFFC character
https://bugs.webkit.org/show_bug.cgi?id=122744
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-14
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Replaced elements should be emitted in GTK/EFL and
marked their presence with the replacement character.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::textIteratorBehaviorForTextRange):
LayoutTests:
Added new accessibility expectation after r156532.
- platform/efl-wk2/TestExpectations:
- platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
- 3:36 AM Changeset in webkit [157393] by
-
- 25 edits9 adds in trunk
[CSS Grid Layout] Implement support for <flex>
https://bugs.webkit.org/show_bug.cgi?id=115362
Reviewed by Andreas Kling.
From Blink r149134, r149480, r149532, r150287 and r156127 by <jchaffraix@chromium.org>
From Blink r157820 by <svillar@igalia.com>
Source/WebCore:
Added support for flexible lengths ('fr' unit) in CSS Grid Layout
code. This requires the addition of GridLength class to
encapsulate the knowledge of <flex> to the grid layout code.
Also updated the algorithm that computes the layout. It increases
the value of 1fr based on the grid tracks' usedBreath to fraction
ratio (called normalizedFractionValue). This enables increasing
the fraction value while updating the available space to account
for processed grid tracks. The algorithm stops when we run out of
grid tracks or available space (one grid item has an intrinsic
size too big). This matches the specs to the letter for the known
available space case (both the unknown case and the interaction
with 'span' are left out of this patch).
Tests: fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html
fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html
fast/css-grid-layout/flex-content-resolution-columns.html
fast/css-grid-layout/flex-content-resolution-rows.html
- GNUmakefile.list.am: Added GridLength.h to the build system.
- Target.pri: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridTrackBreadth): Replace Length by GridLength.
- css/CSSGrammar.y.in: Added FR support.
- css/CSSParser.cpp: Ditto.
(WebCore::CSSParser::parseGridBreadth):
(WebCore::CSSParser::detectNumberToken):
- css/CSSParserValues.cpp: Added FR support.
(WebCore::CSSParserValue::createCSSValue):
- css/CSSParserValues.h:
(WebCore::CSSParserString::operator[]):
(WebCore::CSSParserString::equalIgnoringCase):
- css/CSSPrimitiveValue.cpp: Added FR support.
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
- css/CSSPrimitiveValue.h: Added a couple of missing const.
(WebCore::CSSPrimitiveValue::isFlex):
- css/StyleResolver.cpp: Added FR support.
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackSize):
- rendering/RenderGrid.cpp:
(WebCore::GridTrackForNormalization::GridTrackForNormalization):
New helper struct to ease the computation of track breadths with
flexible lengths.
(WebCore::GridTrackForNormalization::operator=):
(WebCore::RenderGrid::computePreferredTrackWidth): Replaced Length by GridLength.
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Grow grid lines
having a fraction as the MaxTrackSizingFunction.
(WebCore::RenderGrid::computeUsedBreadthOfMinLength): Replaced Length by GridLength.
(WebCore::RenderGrid::computeUsedBreadthOfMaxLength): Ditto.
(WebCore::sortByGridNormalizedFlexValue):
(WebCore::RenderGrid::computeNormalizedFractionBreadth): Increase
the fraction value while updating the available space to account
for processed grid tracks.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::distributeSpaceToTracks): Never shrink track sizes.
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
- rendering/RenderGrid.h:
- rendering/style/GridLength.h: Added.
(WebCore::GridLength::GridLength):
(WebCore::GridLength::isLength):
(WebCore::GridLength::isFlex):
(WebCore::GridLength::length):
(WebCore::GridLength::flex):
(WebCore::GridLength::setFlex):
(WebCore::GridLength::operator==):
- rendering/style/GridTrackSize.h: Replaced Length by GridLength.
(WebCore::GridTrackSize::length):
(WebCore::GridTrackSize::setLength):
(WebCore::GridTrackSize::minTrackBreadth):
(WebCore::GridTrackSize::maxTrackBreadth):
(WebCore::GridTrackSize::setMinMax):
(WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth):
LayoutTests:
Added 4 new test cases to test the support for <flex> in CSS Grid
Layout code. Also updated some of the existing ones to check the
support for 'fr' units.
- fast/css-grid-layout/flex-and-minmax-content-resolution-columns-expected.txt: Added.
- fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html: Added.
- fast/css-grid-layout/flex-and-minmax-content-resolution-rows-expected.txt: Added.
- fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html: Added.
- fast/css-grid-layout/flex-content-resolution-columns-expected.txt: Added.
- fast/css-grid-layout/flex-content-resolution-columns.html: Added.
- fast/css-grid-layout/flex-content-resolution-rows-expected.txt: Added.
- fast/css-grid-layout/flex-content-resolution-rows.html: Added.
- fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
- fast/css-grid-layout/grid-columns-rows-get-set.html:
- fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt:
- fast/css-grid-layout/grid-dynamic-updates-relayout.html:
- fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
- fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
- 3:33 AM Changeset in webkit [157392] by
-
- 3 edits2 adds in trunk
Broken text rendering when input field has selection.
https://bugs.webkit.org/show_bug.cgi?id=122716
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-14
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: fast/text/text-rendering-with-input-selection.html.
fast/text/text-rendering-with-input-selection-expected.html.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Check that text has selection.
LayoutTests:
- fast/text/text-rendering-with-input-selection.html: Added.
- fast/text/text-rendering-with-input-selection-expected.html: Added.
- 2:43 AM Changeset in webkit [157391] by
-
- 3 edits2 adds in trunk
Unexpected word wrapping for wrapped content then raw content.
https://bugs.webkit.org/show_bug.cgi?id=121130
Reviewed by Antti Koivisto.
When deciding whether a line is considered empty, we need to check if the current
object is fully responsible for the currently uncommitted width. It helps differentiating
<span></span><span>abcd</span> from <span>a</span><span>bcd</span>, where in the first
case when we hit the second <span> the line is still considered empty, as opposed to the
second example.
Source/WebCore:
Test: fast/css/unexpected-word-wrapping-with-non-empty-spans.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Added.
- fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Added.
- 2:16 AM Changeset in webkit [157390] by
-
- 2 edits in trunk/Source/WebCore
Be more efficient about passing RenderStyle to attachRenderTree().
<https://webkit.org/b/122743>
Reviewed by Antti Koivisto.
Have attachRenderTree() and createRendererTreeIfNeeded() pass the
RenderStyle in a PassRefPtr to avoid churning the ref count.
- 2:00 AM Changeset in webkit [157389] by
-
- 6 edits2 adds in trunk
[CSS Grid Layout] 2 span positions are not resolved correctly
https://bugs.webkit.org/show_bug.cgi?id=119717
Reviewed by Andreas Kling.
From Blink r155397 by <jchaffraix@chromium.org>
Source/WebCore:
Test: fast/css-grid-layout/grid-item-bad-resolution-double-span.html
Two opposite 'span' or 'auto' positions should be resolved using
the auto placement algorithm. We were only checking for the 'auto'
case. This also covers the case of other positions that, according
to the spec, should be treated as 'auto'.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
LayoutTests:
Added a new test case to check bad grid items resolution with two
opposite span positions. Also added a real grid container to check
also the resolution code path in some other tests.
- fast/css-grid-layout/grid-item-area-get-set.html: Added a grid container.
- fast/css-grid-layout/grid-item-bad-resolution-double-span-expected.txt: Added.
- fast/css-grid-layout/grid-item-bad-resolution-double-span.html: Added.
- fast/css-grid-layout/grid-item-end-after-get-set.html: Added a grid container.
- fast/css-grid-layout/grid-item-start-before-get-set.html: Ditto.
- 12:58 AM Changeset in webkit [157388] by
-
- 9 edits in trunk/Source/WebCore
Use RenderElement instead of RenderObject in more places.
<https://webkit.org/b/122734>
Reviewed by Antti Koivisto.
Convert some sites to use RenderElement (or type inference) instead
of RenderObject for less branchy code.
Oct 13, 2013:
- 10:58 PM Changeset in webkit [157387] by
-
- 18 edits in trunk
Deprecate or remove deleteAllValues functions; there are only a few call sites left
https://bugs.webkit.org/show_bug.cgi?id=122738
Reviewed by Anders Carlsson.
Source/WebCore:
- platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::deleteAllCookiesAndDomains):
- platform/network/blackberry/rss/RSSParserBase.cpp:
(WebCore::RSSFeed::clear):
- platform/win/WCDataObject.cpp:
(WebCore::WCDataObject::~WCDataObject):
Renamed deleteAllValues to deprecatedDeleteAllValues.
Source/WebKit/blackberry:
- WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):
Renamed deleteAllValues to deprecatedDeleteAllValues.
Source/WebKit2:
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::pluginDestroyed): Renamed deleteAllValues to
deprecatedDeleteAllValues.
Source/WTF:
- wtf/Deque.h: Deleted deleteAllValues.
- wtf/HashMap.h: Ditto.
- wtf/HashSet.h: Ditto.
- wtf/ListHashSet.h: Ditto.
- wtf/Vector.h: Renamed deleteAllValues to deprecatedDeleteAllValues.
Tools:
- DumpRenderTree/win/DRTDataObject.cpp:
(DRTDataObject::~DRTDataObject):
- DumpRenderTree/win/UIDelegate.cpp:
(DRTUndoStack::~DRTUndoStack):
(DRTUndoStack::clear):
Renamed deleteAllValues to deprecatedDeleteAllValues.
- Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
- 10:02 PM Changeset in webkit [157386] by
-
- 3 edits in trunk/Tools
build.webkit.org/dashboard incorrectly shows interrupted builds as green
https://bugs.webkit.org/show_bug.cgi?id=122732
Reviewed by Tim Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
I don't see it occur any time in recent history, but judging from what happens for
status 5 (RETRY), we can just finish this function normally.
Record overall text description for iteration as BuildbotIteration.text.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
but no tests failed, make it yellow, and use buildbot-provided description for it.
- 5:11 PM Changeset in webkit [157385] by
-
- 104 edits in trunk/Source/WebCore
Merge NODE_TYPE_CASTS and ELEMENT_TYPE_CASTS
https://bugs.webkit.org/show_bug.cgi?id=122735
Reviewed by Antti Koivisto.
NODE_TYPE_CASTS and ELEMENT_TYPE_CASTS are identical. Let them become one
with one another.
- 3:06 PM Changeset in webkit [157384] by
-
- 2 edits in trunk/Source/WebCore
Uncrashify Document::head() too. (Why am I even awake?)
- 2:21 PM Changeset in webkit [157383] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r157381): Make Document::body() crash less when there is no documentElement.
Unreviewed.
- 1:45 PM Changeset in webkit [157382] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL OSR exit should perform zero extension on values smaller than 64-bit
https://bugs.webkit.org/show_bug.cgi?id=122688
Reviewed by Gavin Barraclough.
In the DFG we usually make the simplistic assumption that a 32-bit value in a 64-bit
register will have zeros on the high bits. In the few cases where the high bits are
non-zero, the DFG sort of tells us this explicitly.
But when working with llvm.webkit.stackmap, it doesn't work that way. Consider we might
emit LLVM IR like:
%2 = trunc i64 %1 to i32
stuff %2
call @llvm.webkit.stackmap(...., %2)
LLVM may never actually emit a truncation instruction of any kind. And that's great - in
many cases it won't be needed, like if 'stuff %2' is a 32-bit op that ignores the high
bits anyway. Hence LLVM may tell us that %2 is in the register that still had the value
from before truncation, and that register may have garbage in the high bits.
This means that on our end, if we want a 32-bit value and we want that value to be
zero-extended, we should zero-extend it ourselves. This is pretty easy and should be
cheap, so we should just do it and not make it a requirement that LLVM does it on its
end.
This makes all tests pass with JSC_ftlOSRExitUsesStackmap=true.
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStubWithOSRExitStackmap):
- ftl/FTLValueFormat.cpp:
(JSC::FTL::reboxAccordingToFormat):
- 12:21 PM Changeset in webkit [157381] by
-
- 3 edits in trunk/Source/WebCore
Rewrite Document::body and Document::head in modern style, way clearer and shorter
https://bugs.webkit.org/show_bug.cgi?id=122717
Reviewed by Andreas Kling.
- dom/Document.cpp:
(WebCore::Document::body): Use iterator to make this way easier to read.
(WebCore::Document::head): Ditto.
- html/HTMLTagNames.in: Added generateTypeHelpers for body and head.
- 12:17 PM Changeset in webkit [157380] by
-
- 5 edits5 copies in trunk
Roll depsHHHHChangeLogs.
- 11:52 AM Changeset in webkit [157379] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk-wk2/TestExpectations:
Add bug number to the failing animation tests.
- 11:39 AM Changeset in webkit [157378] by
-
- 4 edits in trunk/Source/WebCore
RenderLayerBacking should have RenderLayer& backpointer.
<https://webkit.org/b/122731>
Reviewed by Anders Carlsson.
RenderLayerBacking is always owned by a RenderLayer and so should
store its backpointer in a reference.
- 10:26 AM Changeset in webkit [157377] by
-
- 4 edits in trunk/LayoutTests
Removing input-file-entries.html from TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=122674
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-13
Reviewed by Anders Carlsson.
input-file-entries.html has been removed in
changeset 156692. so removing references to this file.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 10:10 AM Changeset in webkit [157376] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix the Lion build.
- Configurations/JavaScriptCore.xcconfig:
- 9:15 AM Changeset in webkit [157375] by
-
- 52 edits in trunk/Source/WebCore
Make element predicates and type casts work more consistently on more types
https://bugs.webkit.org/show_bug.cgi?id=122718
Reviewed by Antti Koivisto.
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::assertConnectedSubrameCountIsConsistent):
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::collectFrameOwners):
Updated for name change.
- dom/Document.cpp:
(WebCore::Document::adoptNode): Use a reference instead of a pointer.
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Updated for
typecast name change and also to cast a reference, since we don't overload
for pointers.
(WebCore::Document::updateHoverActiveState): Ditto.
- dom/Element.h: Made the isElementOfType functions take references instead
of pointers. Also use const in the type template argument. These changes go
hand in hand with the changes in the generated code and all the classes.
Also use a bit of nullptr.
- dom/ElementIterator.h:
(WebCore::findElementAncestorOfType): Got rid of the ElementTypeWithConst
naming since this works with or without const. Added const to the call site
for isElementOfType, because it works that way now.
- dom/ElementTraversal.h:
(WebCore::Traversal::firstChildTemplate): Add const to the type when calling
isElementOfType. Along with the corresponding changes, this makes these
templates work for const types.
(WebCore::Traversal::lastChildTemplate): Ditto.
(WebCore::Traversal::firstWithinTemplate): Ditto.
(WebCore::Traversal::lastWithinTemplate): Ditto.
(WebCore::Traversal::nextTemplate): Ditto.
(WebCore::Traversal::previousTemplate): Ditto.
(WebCore::Traversal::nextSiblingTemplate): Ditto.
(WebCore::Traversal::previousSiblingTemplate): Ditto.
(WebCore::Traversal::nextSkippingChildrenTemplate): Ditto.
- dom/Node.cpp:
(WebCore::Node::handleLocalEvents): Check isElementNode and then call the
isDisabledFormControl member function, since we no longer have a helper that
takes a node.
(WebCore::Node::willRespondToMouseMoveEvents): Ditto.
(WebCore::Node::willRespondToMouseClickEvents): Ditto.
(WebCore::Node::willRespondToTouchEvents): Ditto.
- dom/PseudoElement.h: Use some nullptr. Added an isPseudoElement function
that the ELEMENT_TYPE_CASTS macro can use, and also used that macro to make
the toPseudoElement functions instead of a hand-written local variant.
- dom/make_names.pl:
(printTypeHelpers): Added unimplemented versions of the element predicate
functions that return void to catch unnecessary runtime checks of types
that are already known at compile time. Added assertions to the pointer
overloads of the predicates. Maybe later we can delete them. Added const
to the isElementOf template arguments to make these work with both const
and non-const. Put overloads in a consistent order, most specific class
first, then less specific. Changed isElementOfType to take references
rather than pointers.
- editing/Editor.cpp:
(WebCore::Editor::selectionForCommand): Updated to pass a reference.
(WebCore::Editor::setBaseWritingDirection): Ditto.
(WebCore::findFirstMarkable): Ditto.
- html/FormAssociatedElement.h: Tweaked a comment.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto): Updated for name change and to
pass a reference.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::translate): Removed FIXME and const_cast since the
problem is fixed.
(WebCore::HTMLElement::directionality): Use a reference.
- html/HTMLElement.h: Use const in the type of the isElementOfType functions.
Use references for all the arguments, not pointers.
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded): Use documentVersion
instead of docVersion for local variable name. Use elementDescendants instead
of elementTraversal.
(WebCore::HTMLFieldSetElement::length): Use length instead of len for name.
- html/HTMLFormControlElement.h: Put predicates into the standard format and
did them on single lines. Added ELEMENT_TYPE_CASTS so we get standard casts.
- html/HTMLFrameElementBase.h: Ditto.
- html/HTMLFrameOwnerElement.h: Ditto, but changed the name to match the class,
so it's now isHTMLFrameOwnerElement and toHTMLFrameOwnerElement.
- html/HTMLLabelElement.cpp:
(WebCore::nodeAsSupportedLabelableElement): Updated to use references.
- html/HTMLMediaElement.h: Put predicates into the standard format and did
them on single lines. Added ELEMENT_TYPE_CASTS so we get standard casts.
- html/HTMLPlugInElement.h: Ditto. Also marked isPluginElement FINAL.
- html/HTMLPlugInImageElement.h: Ditto.
- html/HTMLTableCellElement.cpp: Removed old hand-written cast functions.
- html/HTMLTableCellElement.h: Did same predicate and ELEMENT_TYPE_CASTS
changes. Also fixed up the ordering of functions in the class.
- html/HTMLTextFormControlElement.cpp:
(WebCore::enclosingTextFormControl): Updated to use references and nullptr.
- html/HTMLTextFormControlElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::removedFrom): Call isHTMLMediaElement by its new name.
- html/LabelableElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
- html/track/WebVTTElement.h: Made isWebVTTElement private. Changed the argument
type of setLanguage to const AtomicString& to avoid excess reference count churn.
Did the predicate and type casts thing.
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create): Update for name changes and use references.
- mathml/MathMLElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
- page/FocusController.cpp:
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
- page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
Update for name change.
- platform/Pasteboard.h: Removed unneeded forward declaration.
- rendering/RenderWidget.h: Updated for name change.
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives): Use element iterator
and nullptr.
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler): Update for name changes.
- svg/SVGAnimateElement.cpp:
(WebCore::isSVGAnimateElement): Moved here since we don't want to inline such
a long list of tag names.
- svg/SVGAnimateElement.h: Marked a lot more virtual functions OVERRIDE.
Did predicate and ELEMENT_TYPE_CASTS changes, but did not make the predicate
be inlined.
- svg/SVGElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
- svg/SVGFilterPrimitiveStandardAttributes.h: Ditto.
- svg/SVGGradientElement.cpp:
(WebCore::isSVGGradientElement): Moved here since we don't want to inline
the two tag names.
- svg/SVGGradientElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
- svg/SVGGraphicsElement.h: Ditto.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::SVGImageElement): Took out assertion, since it
was asserting the class of the obejct we just created.
- svg/SVGPolyElement.cpp:
(WebCore::isSVGPolyElement): Moved here since we don't want to inline the
two tag names.
- svg/SVGPolyElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
- svg/SVGTextContentElement.h: Ditto.
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::connectConditions): Update for name changes,
to use references and nullptr, and to get rid of a non-helpful local.
- svg/animation/SVGSMILElement.h: Added a virtual function to check if a
given SVGElement is an SVGSMILElement so we don't have to check a long list
of tag names instead. Also did the predicate and ELEMENT_TYPE_CASTS changes.
- testing/Internals.cpp:
(WebCore::Internals::visiblePlaceholder): Updated to use references.
- 9:12 AM Changeset in webkit [157374] by
-
- 3 edits in trunk/Source/WTF
Change callOnMainThread to take an std::function
https://bugs.webkit.org/show_bug.cgi?id=122698
Reviewed by Darin Adler.
This will let us pass anything that can be converted to an std::function (including lambdas and
WTF::Function objects) to callOnMainThread.
- wtf/MainThread.cpp:
(WTF::callOnMainThread):
- wtf/MainThread.h:
- 9:00 AM Changeset in webkit [157373] by
-
- 13 edits in trunk/Source/WebCore
Text::renderer() should return RenderText
https://bugs.webkit.org/show_bug.cgi?id=122729
Reviewed by Andreas Kling.
Tighten typing.
- 8:57 AM Changeset in webkit [157372] by
-
- 5 edits in trunk/Source/WebCore
Devirtualize RenderView::viewRect().
<https://webkit.org/b/122730>
Reviewed by Antti Koivisto.
There's no need for viewRect() to be a virtual RenderObject function.
The single call site that didn't already access it through RenderView
can just go via view().
- 8:56 AM Changeset in webkit [157371] by
-
- 6 edits in trunk/Source/WebCore
Move setPseudoStyle() to RenderImage (from RenderElement.)
<https://webkit.org/b/122726>
Reviewed by Antti Koivisto.
Only RenderImages ever use setPseudoStyle() so move it there and
remove the non-image codepath.
- 8:04 AM Changeset in webkit [157370] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSlider always has an HTMLInputElement.
<https://webkit.org/b/122728>
Reviewed by Anders Carlsson.
This renderer is never anonymous and always has a corresponding
HTMLInputElement. Tighten this up by having the constructor take
the element by reference, and override element() with a stronger
return type.
- 7:46 AM Changeset in webkit [157369] by
-
- 4 edits in trunk/Source/WebCore
Remove two unused AX functions for getting a FrameView*.
<https://webkit.org/b/122724>
Reviewed by Anders Carlsson.
- 6:26 AM Changeset in webkit [157368] by
-
- 5 edits in trunk/Source/WebCore
Add traverseNextSkippingChildren to ElementIterators
https://bugs.webkit.org/show_bug.cgi?id=122727
Reviewed by Andreas Kling.
Also switch some code using ElementTraversal over to iterators.
- 4:39 AM Changeset in webkit [157367] by
-
- 11 edits in trunk/Source/WebCore
Rename InlineBox::remove() to removeFromParent
https://bugs.webkit.org/show_bug.cgi?id=122725
Reviewed by Andreas Kling.
Also make it clear from the code that all InlineTextBoxes have behavesLikeText set.
- 4:05 AM Changeset in webkit [157366] by
-
- 11 edits in trunk/Source/WebCore
Make absoluteQuads/Rects functions return Vectors
https://bugs.webkit.org/show_bug.cgi?id=122722
Reviewed by Andreas Kling.
- dom/Document.cpp:
(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale):
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale):
Take RenderStyle instead of RenderObject
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):
- dom/Range.cpp:
(WebCore::Range::textRects):
(WebCore::Range::textQuads):
(WebCore::Range::getBorderAndTextQuads):
Adapt to the changes.
- rendering/RenderObject.h:
Removed unnecessary adjustFloatQuad/RectForAbsoluteZoom functions, inline code to
adjustFloatQuads/RectForScrollAndAbsoluteZoomAndFrameScale.
- rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsClippedToEllipsis):
(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange):
- rendering/RenderText.h:
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::absoluteRects):
(WebCore::RenderTextLineBoxes::absoluteRectsForRange):
(WebCore::RenderTextLineBoxes::absoluteQuads):
(WebCore::RenderTextLineBoxes::absoluteQuadsForRange):
- rendering/RenderTextLineBoxes.h:
Use return value instead of an out-arg, except for the virtual versions.
- 4:01 AM Changeset in webkit [157365] by
-
- 6 edits in trunk/Source/WebCore
LiveNodeList: rootNode() and document() should return references.
<https://webkit.org/b/122720>
Reviewed by Antti Koivisto.
Tighten up this code a bit by having rootNode() and document()
return references. Also replaced some handwritten traversal
with a call to Node::lastDescendant().
- 3:59 AM Changeset in webkit [157364] by
-
- 2 edits in trunk/Source/WebCore
Document::createRenderTree() should assert that there is no arena.
<https://webkit.org/b/122723>
Reviewed by Antti Koivisto.
Calling createRenderTree() with a RenderArena already in place would
be a programming error.
- 3:16 AM Changeset in webkit [157363] by
-
- 13 edits5 deletes in trunk/Source
Remove dead ENABLE(CUSTOM_ELEMENTS) code.
<https://webkit.org/b/122721>
Reviewed by Antti Koivisto.
There are no ports building with this flag since April and the code
has bitrotted since. Remove it for now. If someone wants to resurrect
the feature someday, getting back to this point is trivial.
- 2:39 AM Changeset in webkit [157362] by
-
- 10 edits in trunk/Source/WebCore
Move absoluteRects/Quads to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122706
Reviewed by Andreas Kling.
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::absoluteRects):
(WebCore::RenderTextLineBoxes::absoluteRectsForRange):
(WebCore::RenderTextLineBoxes::absoluteQuads):
(WebCore::RenderTextLineBoxes::absoluteQuadsForRange):
These move.
(WebCore::RenderTextLineBoxes::selectionRectForRange):
(WebCore::RenderTextLineBoxes::setSelectionState):
Also moved a few smaller functions.
- 2:02 AM Changeset in webkit [157361] by
-
- 9 edits in trunk/Source
Remove dead code hiding behind ENABLE(TOUCH_EVENT_TRACKING).
<https://webkit.org/b/122719>
Reviewed by Antti Koivisto.
Nobody is building with this flag, and it has broken-looking code
behind it anyway. Nuke from orbit.
- 12:17 AM Changeset in webkit [157360] by
-
- 2 edits in trunk/Source/WebCore
RenderLayer: Check SVG bit instead of element namespace in isTransparent().
<https://webkit.org/b/118171>
Reviewed by Darin Adler.
Replace the (virtual) namespaceURI() check with an isSVGElement() bit check.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isTransparent):
- 12:08 AM Changeset in webkit [157359] by
-
- 12 edits in trunk/Tools
Remove Chromium specific code from flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=122714
Reviewed by Sam Weinig.
Also removed code related to GPU tests and virtual suites.
"Fallbacks map" was chromium only too, not sure why they needed special handling there.
- TestResultServer/model/jsonresults_unittest.py:
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- TestResultServer/static-dashboards/history.js:
- TestResultServer/static-dashboards/loader.js:
- TestResultServer/static-dashboards/ui.js:
- TestResultServer/templates/uploadform.html:
Oct 12, 2013:
- 11:55 PM Changeset in webkit [157358] by
-
- 2 edits in trunk/Source/WebCore
Use nullptr in Document.cpp
https://bugs.webkit.org/show_bug.cgi?id=122715
Reviewed by Sam Weinig.
- dom/Document.cpp:
(WebCore::widgetForElement):
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::dropChildren):
(WebCore::Document::getElementByAccessKey):
(WebCore::Document::doctype):
(WebCore::Document::createElement):
(WebCore::Document::createElementNS):
(WebCore::Document::registerElement):
(WebCore::Document::createCDATASection):
(WebCore::Document::createProcessingInstruction):
(WebCore::Document::createEntityReference):
(WebCore::Document::importNode):
(WebCore::Document::adoptNode):
(WebCore::Document::webkitGetNamedFlows):
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):
(WebCore::Document::setTitle):
(WebCore::Document::removeTitle):
(WebCore::Document::view):
(WebCore::Document::page):
(WebCore::Document::settings):
(WebCore::Document::createNodeIterator):
(WebCore::Document::createTreeWalker):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
(WebCore::Document::disconnectFromFrame):
(WebCore::Document::destroyRenderTree):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::scriptableDocumentParser):
(WebCore::Document::body):
(WebCore::Document::head):
(WebCore::Document::processBaseElement):
(WebCore::Document::findUnsafeParentScrollPropagationBoundary):
(WebCore::Document::cloneNode):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::removeFocusedNodeOfSubtree):
(WebCore::Document::setFocusedElement):
(WebCore::Document::getWindowAttributeEventListener):
(WebCore::Document::createEvent):
(WebCore::Document::getOverrideStyle):
(WebCore::Document::ownerElement):
(WebCore::Document::setInPageCache):
(WebCore::Document::parentDocument):
(WebCore::Document::createAttributeNS):
(WebCore::Document::initSecurityContext):
(WebCore::Document::resetHiddenFocusElementTimer):
(WebCore::Document::getCSSCanvasContext):
(WebCore::Document::enqueuePopstateEvent):
(WebCore::Document::takeAnyMediaCanStartListener):
(WebCore::Document::requestFullScreenForElement):
(WebCore::Document::webkitExitFullscreen):
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenRendererDestroyed):
(WebCore::Document::webkitPointerLockElement):
(WebCore::Document::seamlessParentIFrame):
(WebCore::Document::loader):
(WebCore::eventTargetElementForDocument):
(WebCore::nearestCommonHoverAncestor):
(WebCore::Document::ensureTemplateDocument):
Use nullptr in many places we were using 0.
- 11:54 PM Changeset in webkit [157357] by
-
- 17 edits in trunk/Source
Get rid of the toHTMLElement helper for casting FormAssociatedElement to HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=122713
Reviewed by Sam Weinig.
Source/WebCore:
Since we are using the function name toHTMLElement for casting to an HTMLElement
from a Node or Element, it's awkward to also use it for a quite different type of
type conversion on a FormAssociatedElement. We already have an asHTMLElement member
function, so lets use that.
- html/DOMFormData.cpp:
(WebCore::DOMFormData::DOMFormData): Use references instead of pointers, and
asHTMLElement instead of toHTMLElement.
- html/FormAssociatedElement.cpp: Made FormAttributeTargetObserver FINAL, made
its private inheritance explicit, made its constructor public so we can use it
with make_unique and got rid of its creation function. Also use reference instead
of a pointer.
(WebCore::FormAssociatedElement::FormAssociatedElement): Use nullptr.
(WebCore::FormAssociatedElement::~FormAssociatedElement): Ditto.
(WebCore::FormAssociatedElement::didMoveToNewDocument): Use asHTMLElement instead
of toHTMLElement and use a reference instead of a pointer.
(WebCore::FormAssociatedElement::insertedInto): Ditto.
(WebCore::FormAssociatedElement::removedFrom): Ditto.
(WebCore::FormAssociatedElement::formRemovedFromTree): Ditto.
(WebCore::FormAssociatedElement::resetFormOwner): Ditto.
(WebCore::FormAssociatedElement::formAttributeChanged): Ditto.
(WebCore::FormAssociatedElement::customError): Ditto.
(WebCore::FormAssociatedElement::resetFormAttributeTargetObserver): Use make_unique
instead of create here.
(WebCore::FormAssociatedElement::name): Use asHTMLElement.
(WebCore::FormAttributeTargetObserver::FormAttributeTargetObserver): Ditto.
(WebCore::FormAttributeTargetObserver::idTargetChanged): Updated since m_element is
now a reference.
- html/FormAssociatedElement.h: Removed some unneeded class declarations.
Made isFormAssociatedElement const. Use std::unique_ptr instead of OwnPtr.
- html/FormNamedItem.h: Made asHTMLElement return a reference, and overloaded it
for both const and non-const. Made isFormAssociatedElement const.
- html/HTMLFormControlElement.h: Updated for FormNamedItem changes. Removed an
unneeded class declaration.
- html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::virtualItemAfter): Use references, asHTMLElement,
and nullptr.
(WebCore::firstNamedItem): Ditto.
(WebCore::HTMLFormControlsCollection::namedItem): Ditto.
(WebCore::HTMLFormControlsCollection::updateNameCache): Ditto.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively): Use asHTMLElement and references.
(WebCore::HTMLFormElement::getTextFieldValues): Ditto.
(WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Ditto.
(WebCore::HTMLFormElement::formElementIndex): Ditto.
(WebCore::HTMLFormElement::assertItemCanBeInPastNamesMap): Ditto.
(WebCore::HTMLFormElement::elementFromPastNamesMap): Ditto, and nullptr.
- html/HTMLImageElement.h: Updated for FormNamedItem changes.
- html/HTMLObjectElement.h: Ditto.
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create): Use asHTMLElement and references.
Source/WebKit/blackberry:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState): Use asHTMLElement.
Source/WebKit/mac:
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation elementWithName:inForm:]): Use asHTMLElement.
(-[WebHTMLRepresentation controlsInForm:]): Ditto.
Source/WebKit/win:
- WebFrame.cpp:
(WebFrame::controlsInForm): Use asHTMLElement.
- 11:32 PM Changeset in webkit [157356] by
-
- 2 edits in trunk/Source/WebCore
Use nullptr instead of 0 in TreeScope.cpp
https://bugs.webkit.org/show_bug.cgi?id=122711
Reviewed by Andreas Kling.
- dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::clearDocumentScope):
(WebCore::TreeScope::getElementById):
(WebCore::TreeScope::getAllElementsById):
(WebCore::TreeScope::getElementByName):
(WebCore::TreeScope::ancestorInThisScope):
(WebCore::TreeScope::getImageMap):
(WebCore::nodeFromPoint):
(WebCore::TreeScope::labelElementForId):
(WebCore::TreeScope::getSelection):
(WebCore::TreeScope::findAnchor):
(WebCore::focusedFrameOwnerElement):
(WebCore::TreeScope::focusedElement):
(WebCore::commonTreeScope):
Use a lot more nullptr, and also rewrite one while loop as a for loop.
- 11:03 PM Changeset in webkit [157355] by
-
- 3 edits in trunk/Source/WebCore
Remove the not-much-used isShadowHost function from Element.h
https://bugs.webkit.org/show_bug.cgi?id=122710
Reviewed by Andreas Kling.
- dom/Element.h: Removed isShadowHost, which just checks if shadowRoot is null.
- page/FocusController.cpp:
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost): Added
individual assertions instead of just asserting isShadowHost.
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByIFrame): Broke an
assertion with && in it into two assertions.
(WebCore::hasCustomFocusLogic): Changed argument type to be Element& and take
a reference instead of a pointer.
(WebCore::isNonFocusableShadowHost): Made arguments references instead of pointers.
Replaced isShadowHost check with a direct check of whether shadowRoot returns null
or not, which seems nearly as clear.
(WebCore::isFocusableShadowHost): Ditto.
(WebCore::adjustedTabIndex): Ditto.
(WebCore::shouldVisit): Ditto.
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
Updated for changes above.
(WebCore::FocusController::advanceFocusInDocumentOrder): Ditto. Also some nullptr.
(WebCore::FocusController::findFocusableElementAcrossFocusScope): Ditto.
(WebCore::FocusController::findFocusableElementRecursively): Ditto.
(WebCore::FocusController::findElementWithExactTabIndex): Ditto.
(WebCore::nextElementWithGreaterTabIndex): Ditto.
(WebCore::previousElementWithLowerTabIndex): Ditto.
(WebCore::FocusController::nextFocusableElement): Ditto.
(WebCore::FocusController::previousFocusableElement): Ditto.
- 10:42 PM Changeset in webkit [157354] by
-
- 10 edits in trunk/Source/WebCore
Move querySelector from Node to ContainerNode and use references instead of pointers
https://bugs.webkit.org/show_bug.cgi?id=122709
Reviewed by Anders Carlsson.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::querySelector): Moved here from Node. Pass a reference instead
of a pointer to SelectorQuery. Changed return types to RefPtr and raw pointer instead of
PassRefPtr.
(WebCore::ContainerNode::querySelectorAll): Ditto.
- dom/ContainerNode.h: Added the new functions.
- dom/Element.cpp:
(WebCore::Element::webkitMatchesSelector): Use && instead of an if statement and a reference rather than
a pointer.
- dom/Node.cpp: Sorted includes, removed SelectorQuery.h, removed the querySelector functions.
(WebCore::Node::ownerDocument): Use document instead of doc and nullptr instead of 0.
- dom/Node.h: Removed the querySelector functions.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches): Take references instead of pointers.
(WebCore::SelectorDataList::matches): Ditto.
(WebCore::SelectorDataList::queryAll): Return a RefPtr instead of PassRefPtr.
(WebCore::SelectorDataList::queryFirst): Ditto. Also use nullptr.
(WebCore::selectorForIdLookup): Take references instead of pointers.
(WebCore::isTreeScopeRoot): Ditto.
(WebCore::SelectorDataList::executeFastPathForIdSelector): Ditto.
(WebCore::isSingleTagNameSelector): Ditto.
(WebCore::elementsForLocalName): Ditto. Also use iterators instead of traversal.
(WebCore::anyElement): Ditto.
(WebCore::SelectorDataList::executeSingleTagNameSelectorData): Ditto.
(WebCore::isSingleClassNameSelector): Ditto.
(WebCore::SelectorDataList::executeSingleClassNameSelectorData): Ditto.
(WebCore::SelectorDataList::executeSingleSelectorData): Ditto.
(WebCore::SelectorDataList::executeSingleMultiSelectorData): Ditto.
(WebCore::SelectorDataList::execute): Ditto.
(WebCore::SelectorQueryCache::add): Ditto.
- dom/SelectorQuery.h: Update to use ContainerNode, references, and RefPtr and raw pointers
rather than PassRefPtr.
- dom/TreeScope.cpp:
(WebCore::TreeScope::getElementById): Use nullptr instead of 0.
(WebCore::TreeScope::getAllElementsById): Ditto.
(WebCore::TreeScope::getElementByName): Ditto.
(WebCore::TreeScope::ancestorInThisScope): Ditto.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::assertNode): Use nullptr instead of 0.
(WebCore::InspectorDOMAgent::assertDocument): Ditto.
(WebCore::InspectorDOMAgent::assertElement): Ditto. Also use isElementNode instead of nodeType.
(WebCore::InspectorDOMAgent::assertEditableNode): Use nullptr instead of 0.
(WebCore::InspectorDOMAgent::assertEditableElement): Ditto.
(WebCore::InspectorDOMAgent::getDocument): Use document instead of doc.
(WebCore::InspectorDOMAgent::querySelector): Changed to pass a ContainerNode.
(WebCore::InspectorDOMAgent::querySelectorAll): Ditto.
- 10:01 PM Changeset in webkit [157353] by
-
- 8 edits in trunk/Source/WebCore
Move code to find elements in slider shadow tree into RangeInputType class, since it creates that tree
https://bugs.webkit.org/show_bug.cgi?id=122708
Reviewed by Anders Carlsson.
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect): Use HTMLInputElement::sliderThumbElement
to find the thumb, rather than using the sliderThumbElementOf function.
- html/InputType.h: Use nullptr instead of 0. Tweak formatting a bit.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent): Use typedSliderThumbElement function.
(WebCore::RangeInputType::handleTouchEvent): Ditto.
(WebCore::RangeInputType::createShadowSubtree): Fixed assertion to match the code below.
(WebCore::RangeInputType::sliderTrackElement): Moved next to the createShadowSubtree function
since it is finding an element in that subtree. Changed to do the work here instead of calling
a function in another file.
(WebCore::RangeInputType::typedSliderThumbElement): Added. Finds the slider thumb element,
and returns it as a reference with a specific type.
(WebCore::RangeInputType::sliderThumbElement): Changed to call typedSliderThumbElement, loosening
the type, and returning a pointer Changed to call typedSliderThumbElement, loosening
the type, and returning a pointer.
(WebCore::RangeInputType::minOrMaxAttributeChanged): Use typedSliderThumbElement.
(WebCore::RangeInputType::setValue): Ditto.
(WebCore::RangeInputType::listAttributeTargetChanged): Ditto.
- html/RangeInputType.h: Marked the class FINAL. Tweaked formatting a bit.
Added the typedSliderThumbElement function.
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint): Call the HTMLInputElement::sliderTrackElement
function instead of having the input element's shadow subtree hierarchy hard-coded here.
(WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Moved here from the header,
since it's a virtual function that won't be inlined.
- html/shadow/SliderThumbElement.h: Removed unneeded forward declarations. Made more virtual
functions private and added more OVERRIDE. Removed the toSliderThumbElement, sliderThumbElementOf,
and sliderTrackElementOf functions.
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout): Use HTMLInputElement::sliderThumbElement.
(WebCore::RenderSlider::inDragMode): Ditto.
- 10:00 PM Changeset in webkit [157352] by
-
- 11 edits1 delete in trunk/Source/WebCore
Remove unneeded extra memory allocation and indirection for ValidityState
https://bugs.webkit.org/show_bug.cgi?id=122705
Reviewed by Anders Carlsson.
- CMakeLists.txt: Removed ValidityState.cpp.
- GNUmakefile.list.am: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- html/FormAssociatedElement.cpp: Removed ValidityState.h include and the
FormAssociatedElement::validity function. That function is now an inline
in the ValidityState.h header.
- html/FormAssociatedElement.h: Added badInput function, the only function
from the ValidityState interface that was not already present here. Removed
m_validityState.
- html/HTMLFormControlElement.cpp: Removed include of ValidityState.h.
(WebCore::HTMLFormControlElement::isValidFormControlElement): Use the valid
function directly instead of indirectly through the validity state.
(WebCore::HTMLFormControlElement::setNeedsValidityCheck): Ditto.
- html/ValidityState.cpp: Removed.
- html/ValidityState.h: Removed the body of the ValidityState class and
made it effectively a "typedef" for FormAssociatedElement. It's actually
a derived class that adds no members, which is not quite right but will
work just fine for this.
(WebCore::FormAssociatedElement::validity): Implemented; just returns the
FormAssociatedElement, which the bindings expose as a ValidityState.
- html/ValidityState.idl: Use SkipVTableValidation instead of
ImplementationLacksVTable because FormAssociatedElement does have a vtable.
- 9:05 PM Changeset in webkit [157351] by
-
- 2 edits in trunk/Source/WebKit/mac
WebViews inside OS X screen savers have large caches, but should not
https://bugs.webkit.org/show_bug.cgi?id=122604
We use WebCacheModelDocumentViewer by default for apps linked against
modern WebKit, and WebCacheModelDocumentBrowser for apps linked
against legacy WebKit. ScreenSaverEngine.app doesn't link against
WebKit at all, and thus falls into the legacy case by accident because
NSVersionOfLinkTimeLibrary("WebKit") returns -1.
But WebViews inside screen savers are almost certainly not being used
as browsers, so this large-ish cache specified by
WebCacheModelDocumentBrowser is wasteful. This is likely true for all
apps that don't directly link against WebKit, so now we use
WebCacheModelDocumentViewer by default for those apps.
Reviewed by Darin Adler.
- WebView/WebPreferences.mm:
(cacheModelForMainBundle): Use WebCacheModelDocumentViewer by default
for apps that don't link against WebKit directly. Also converted to
use @autoreleasepool {} and early returns while I was in here.
- 6:18 PM Changeset in webkit [157350] by
-
- 10 edits in trunk/Source/WebCore
Rename toParentMediaElement to parentMediaElement, since it's not a type cast
https://bugs.webkit.org/show_bug.cgi?id=122707
Reviewed by Eric Carlson.
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControlsContainer::controllingVideoElement): Call the
function by its new name, and also remove unnecessary type casting.
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::parentMediaElement): Renamed from toParentMediaElement. Changed to use
nullptr. Removed an unnecessary null check.
- html/shadow/MediaControlElementTypes.h: Renamed from toParentMediaElement.
Changed the argument to the RenderObject overload to be a reference rather than
a pointer since it doesn't handle null.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler):
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
(WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
Updated to use the new name. Also use nullptr.
- html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlFullscreenFullscreenButtonElement::defaultEventHandler):
Updated to use the new name.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::determineFullScreenMultiplier):
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::paintMediaPlayButton):
(WebCore::RenderThemeBlackBerry::paintMediaRewindButton):
(WebCore::RenderThemeBlackBerry::paintMediaMuteButton):
(WebCore::RenderThemeBlackBerry::paintMediaFullscreenButton):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
Updated to use the new name.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaSliderTrack):
Updated to use the new name.
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaSliderTrack):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):
Updated to use the new name.
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart):
Call the function by its new name and with a reference instead of a pointer.
- 3:33 PM Changeset in webkit [157349] by
-
- 6 edits in trunk/Source/WebCore
Move positionForPoint to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122703
Reviewed by Andreas Kling.
- 3:23 PM Changeset in webkit [157348] by
-
- 4 edits in trunk/Source/WebCore
Remove unused ScrollingCoordinator hooks.
<https://webkit.org/b/122701>
Reviewed by Anders Carlsson.
Remove leftover ScrollingCoordinator hooks that were only used
by the Chromium port.
- 2:14 PM Changeset in webkit [157347] by
-
- 2 edits in trunk/Source/WebCore
[Soup] The NeverDestroyed<std::unique_ptr<NetworkStorageSession>> variable in defaultSession() should be static
https://bugs.webkit.org/show_bug.cgi?id=122700
Reviewed by Anders Carlsson.
- platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::defaultSession): The NeverDestroyed variable should be static to avoid its reinitialization every time
the function is called. This was exposed by r157337 and should fix the subsequent crashes.
- 1:33 PM Changeset in webkit [157346] by
-
- 4 edits in trunk/Source/WebCore
Move line dirtying code to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122699
Reviewed by Andreas Kling.
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::removeAllFromParent):
Also moved the removal loop.
(WebCore::RenderTextLineBoxes::dirtyAll):
(WebCore::RenderTextLineBoxes::dirtyRange):
- 11:40 AM Changeset in webkit [157345] by
-
- 5 edits in trunk/Source/WebCore
Move more code to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122697
Reviewed by Andreas Kling.
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::boundingBox):
(WebCore::RenderTextLineBoxes::visualOverflowBoundingBox):
(WebCore::RenderTextLineBoxes::hasRenderedText):
(WebCore::RenderTextLineBoxes::caretMinOffset):
(WebCore::RenderTextLineBoxes::caretMaxOffset):
Moved these.
- 11:34 AM Changeset in webkit [157344] by
-
- 8 edits in trunk/Source
Add a feature define for SubtleCrypto
https://bugs.webkit.org/show_bug.cgi?id=122683
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 11:26 AM Changeset in webkit [157343] by
-
- 3 edits in trunk/Source/WebCore
Generate tighter isFooElement() functions for HTML elements.
<https://webkit.org/b/122696>
Reviewed by Antti Koivisto.
Specialize HTML element type checking helpers to only compare the
localName and not the fully qualified tag name.
- 11:16 AM Changeset in webkit [157342] by
-
- 27 edits in trunk/Source
Replace static cast ASSERTs with ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=120803
Patch by Jessica Pease <jessica_n_pease@apple.com> on 2013-09-27
Reviewed by Andreas Kling.
No new tests because we're just changing assertions.
Source/WebCore:
- accessibility/AccessibilityMockObject.h:
(WebCore::toAccessibilityMockObject):
- bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
- dom/Element.cpp:
(WebCore::Element::elementRareData):
(WebCore::Element::synchronizeAttribute):
- dom/FocusEvent.h:
(WebCore::toFocusEvent):
- dom/MouseEvent.h:
(WebCore::toMouseEvent):
- dom/Node.cpp:
(WebCore::Node::rareData):
- dom/StyledElement.cpp:
(WebCore::StyledElement::ensureMutableInlineStyle):
- dom/TouchEvent.h:
(WebCore::toTouchEvent):
- editing/CompositeEditCommand.h:
(WebCore::toCompositeEditCommand):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):
- html/track/AudioTrack.h:
(WebCore::toAudioTrack):
- html/track/TextTrack.h:
(WebCore::toTextTrack):
- html/track/VideoTrack.h:
(WebCore::toVideoTrack):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
- loader/cache/CachedResourceClientWalker.h:
(WebCore::CachedResourceClientWalker::next):
- page/FrameView.h:
(WebCore::toFrameView):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::root):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxesFromBidiRuns):
- rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromEllipseElement):
(WebCore::updatePathFromLineElement):
(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::document):
Source/WebKit2:
- Shared/Plugins/NPObjectProxy.h:
(WebKit::NPObjectProxy::toNPObjectProxy):
- WebProcess/Plugins/Netscape/NPJSObject.h:
(WebKit::NPJSObject::toNPJSObject):
- 11:03 AM Changeset in webkit [157341] by
-
- 27 edits in trunk/Source
Replace bounds checking ASSERTs with ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=120893
Patch by Jessica Pease <jessica_n_pease@apple.com> on 2013-09-06
Reviewed by Darin Adler.
Source/WebCore:
- Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBKeyPathLexer::lex):
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyIDForJSCSSPropertyName):
- css/CSSFontSelector.cpp:
(WebCore::compareFontFaces):
- css/CSSParser.cpp:
(WebCore::CSSParser::rewriteSpecifiers):
- html/HTMLCollection.cpp:
(WebCore::traverseMatchingElementsForwardToOffset):
(WebCore::LiveNodeListBase::traverseChildNodeListForwardToOffset):
(WebCore::HTMLCollection::traverseForwardToOffset):
- html/HTMLFontElement.cpp:
(WebCore::parseFontSize):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseHTMLIntegerInternal):
(WebCore::parseHTMLNonNegativeIntegerInternal):
- inspector/InspectorStyleSheet.h:
(WebCore::InspectorStyleProperty::setRawTextFromStyleDeclaration):
- platform/graphics/StringTruncator.cpp:
(WebCore::centerTruncateToBuffer):
(WebCore::rightTruncateToBuffer):
(WebCore::truncateString):
- platform/graphics/TextRun.h:
(WebCore::TextRun::subRun):
- platform/text/BidiRunList.h:
(WebCore::::reverseRuns):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::selectionRectForTextFragment):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
- rendering/svg/SVGTextChunkBuilder.cpp:
(WebCore::SVGTextChunkBuilder::buildTextChunks):
- rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):
- rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
- svg/SVGPathByteStreamSource.h:
(WebCore::SVGPathByteStreamSource::readType):
Source/WebKit2:
- Shared/Plugins/PluginQuirks.h:
(WebKit::PluginQuirks::add):
Source/WTF:
- wtf/BumpPointerAllocator.h:
(WTF::BumpPointerPool::ensureCapacity):
(WTF::BumpPointerPool::alloc):
(WTF::BumpPointerPool::ensureCapacityCrossPool):
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- wtf/StringPrintStream.cpp:
(WTF::StringPrintStream::increaseSize):
- wtf/dtoa/utils.h:
(WTF::double_conversion::BufferReference::SubBufferReference):
- wtf/text/WTFString.cpp:
(WTF::String::fromUTF8):
- 10:41 AM Changeset in webkit [157340] by
-
- 9 edits2 adds in trunk/Source/WebCore
Factor line box code from RenderText to a class
https://bugs.webkit.org/show_bug.cgi?id=122694
Reviewed by Andreas Kling.
Create RenderTextLineBoxes and move some line box specific code there.
- 8:15 AM Changeset in webkit [157339] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix potential register trampling in JIT since r157313.
https://bugs.webkit.org/show_bug.cgi?id=122691
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-12
Reviewed by Michael Saboff.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- 7:51 AM Changeset in webkit [157338] by
-
- 5 edits in trunk/Source/WebCore
Replace RenderText::renderedTextLength with hasRenderedText
https://bugs.webkit.org/show_bug.cgi?id=122693
Reviewed by Andreas Kling.
- 7:15 AM Changeset in webkit [157337] by
-
- 37 edits in trunk/Source
Use unique_ptr instead of delete in a few places
https://bugs.webkit.org/show_bug.cgi?id=122639
Reviewed by Anders Carlsson.
Source/WebCore:
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::guidToDatabaseMap): Use NeverDestroyed instead of DEFINE_STATIC_LOCAL.
(WebCore::guidForOriginAndName): Ditto.
(WebCore::DatabaseBackendBase::DatabaseBackendBase): Removed unneeded initialization
of m_guid, which is set in the body of the constructor explicitly anyway. Use emptyString.
Use unique_ptr for the values in the map. Use the add idiom instead of the get/set idiom.
(WebCore::DatabaseBackendBase::closeDatabase): Use the find/remove idiom instead of the
get/remove idiom.
(WebCore::DatabaseBackendBase::performOpenAndVerify): Use auto here to avoid having to
use the map type by name.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont): Don't initialize m_fontData to 0; unique_ptr will do that.
(WebCore::CachedFont::~CachedFont): Don't delete m_fontData. unique_ptr will do that.
(WebCore::CachedFont::ensureCustomFontData): Add a get.
(WebCore::CachedFont::allClientsRemoved): Don't delete m_fontData. Use nullptr instead of 0.
- loader/cache/CachedFont.h: Changed m_fontData to a unique_ptr.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Don't initialize m_frameTimer to 0; unique_ptr will do that.
(WebCore::BitmapImage::startAnimation): Use make_unique to create the timer.
(WebCore::BitmapImage::stopAnimation): Don't delete m_frameTimer. Use nullptr instead of 0.
- platform/graphics/BitmapImage.h: Changed m_FrameTimer to a unique_ptr.
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::BitmapImage): Don't initialize m_frameTimer to 0; unique_ptr will do that.
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Don't call CGFontRelease on m_cgFont.
(WebCore::FontCustomPlatformData::fontPlatformData): Use get on m_cgFont.
(WebCore::createFontCustomPlatformData): Use nullptr instead of 0, and make_unique instead of new.
- platform/graphics/mac/FontCustomPlatformData.h: Chnaged m_cgFont to be a RetainPtr, and the
return value from createFontCustomPlatformData to be a unique_ptr.
- platform/graphics/blackberry/FontCustomPlatformData.h:
- platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/cairo/FontCustomPlatformData.h:
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/win/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.h:
Same thing on all the other platforms.
- platform/network/NetworkStorageSession.h: Changed return value of createPrivateBrowsingSession
to a unique_ptr, and made constructors public.
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Use make_unique.
- platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::defaultSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):
Same thing on all the other platforms.
Source/WebKit/mac:
- History/WebHistory.mm:
(-[WebHistoryPrivate init]): Use make_unique.
(-[WebHistoryPrivate dealloc]): Don't delete.
(-[WebHistoryPrivate finalize]): Don't delete.
(-[WebHistoryPrivate data]): Use get.
- WebCoreSupport/WebFrameNetworkingContext.mm:
(privateSession): Use NeverDestroyed here instead of a raw pointer.
(WebFrameNetworkingContext::ensurePrivateBrowsingSession): Use the
new function instead of direct global variable access.
(WebFrameNetworkingContext::destroyPrivateBrowsingSession): Ditto.
(WebFrameNetworkingContext::storageSession): Ditto.
- WebView/WebFrame.mm:
(-[WebFramePrivate dealloc]): Don't delete.
(-[WebFramePrivate finalize]): Don't delete.
(-[WebFrame _attachScriptDebugger]): Use make_unique.
(-[WebFrame _detachScriptDebugger]): Don't delete.
- WebView/WebFrameInternal.h: Use unique_ptr.
Source/WebKit/win:
- WebCoreSupport/WebFrameNetworkingContext.cpp:
(privateSession):
(identifierBase):
(WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::storageSession):
Source/WebKit2:
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::privateBrowsingStorageSession): Use NeverDestroyed and unique_ptr.
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession): Use std::move.
- Shared/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload): Use std::move. Also add instead of set.
(WebKit::DownloadManager::convertHandleToDownload): Ditto.
(WebKit::DownloadManager::downloadFinished): Don't delete.
- Shared/Downloads/DownloadManager.h: Changed m_downloads to hold unique_ptr instead
of raw pointers.
- Shared/SandboxExtension.h: Use std::unique_ptr for m_data.
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::HandleArray::HandleArray): Don't initialize m_data to 0.
(WebKit::SandboxExtension::HandleArray::~HandleArray): Don't delete m_data.
(WebKit::SandboxExtension::HandleArray::allocate): Use make_unique to allocate m_data.
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::privateSession): Use NeverDestroyed and unique_ptr.
(WebKit::identifierBase): Use NeverDestroyed.
(WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
Updated to use the above.
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession): Ditto.
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession): Ditto.
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts): Ditto.
(WebKit::WebFrameNetworkingContext::storageSession): Ditto.
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::privateSession):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):
(WebKit::WebFrameNetworkingContext::webFrameLoaderClient):
More of the same.
- 3:06 AM Changeset in webkit [157336] by
-
- 5 edits in trunk/Source/WebCore
Make LayoutState not arena-allocated.
<https://webkit.org/b/122649>
Reviewed by Antti Koivisto.
Let RenderView own a singly-linked chain of LayoutState objects
managed by unique_ptr.
- 2:25 AM Changeset in webkit [157335] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Add missing spaces in JITStubsSH4.h
https://bugs.webkit.org/show_bug.cgi?id=122690
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-12
Reviewed by Andreas Kling.
- jit/JITStubsSH4.h: Space between string concatenation is mandatory with C++11
- 2:19 AM Changeset in webkit [157334] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Add missing test32 implementation in macro assembler.
https://bugs.webkit.org/show_bug.cgi?id=122689
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-12
Reviewed by Andreas Kling.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::test32):
- 2:15 AM Changeset in webkit [157333] by
-
- 6 edits in trunk/Source/WebCore
Make RenderLayer not arena-allocated.
<https://webkit.org/b/87523>
Reviewed by Antti Koivisto.
Let RenderLayerModelObject store its RenderLayer in a unique_ptr.
Layers are relatively low-volume objects and this looks neutral
on our performance tests.
Re-landing this since the original commit exposed a problem with
the destruction order. This pattern:
m_someRenderer->destroy();
m_someRenderer = nullptr;
..is different from what we get with unique_ptr, which clears
the pointer storage before calling the destructor.
I believe that the new order is strictly better as it removes
one path to accessing an object that is undergoing destruction.
The exposed bug was in RLC::fixedRootBackgroundLayerChanged()
where we were dereferencing the RenderView's layer() without
checking, despite it being called below ~RenderLayer.
Oct 11, 2013:
- 11:03 PM Changeset in webkit [157332] by
-
- 2 edits in trunk/Source/WebCore
Move firstPositiveWidth/adjustLogicalLineTop functions where they're actually used
https://bugs.webkit.org/show_bug.cgi?id=122685
Reviewed by Darin Adler.
I'm working on the refactoring of RenderBlockLineLayout, progress tracked under bug #121261. For the better readability, I moved
firstPositiveWidth and adjustLogicalLineTop functions above pushShapeContentOverflowBelowTheContentBox, where these're actually used.
No new tests, no behavior change.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::firstPositiveWidth):
(WebCore::adjustLogicalLineTop):
- 9:52 PM Changeset in webkit [157331] by
-
- 3 edits in trunk/Source/WebCore
Extract an iterator/resolver class from calculateAdjustedNodes
https://bugs.webkit.org/show_bug.cgi?id=122687
Reviewed by Darin Adler.
Extracted EventRelatedNodeResolver out of calculateAdjustedNodes and replaced calls to calculateAdjustedNodes
in updateTouchListsInEventPath and setRelatedTarget by the use of this newly added class.
- dom/EventContext.h: Added some helper functions to TouchEventContext so that updateTouchListsInEventPath
could obtain respective TouchList* without having to hard-code the name.
- dom/EventDispatcher.cpp:
(WebCore::EventRelatedNodeResolver::EventRelatedNodeResolver): Added.
(WebCore::EventRelatedNodeResolver::moveToParentOrShadowHost): Extracted from calculateAdjustedNodes.
(WebCore::EventPath::updateTouchListsInEventPath): Updated to use EventRelatedNodeResolver. Also made this
a member function of EventPath.
(WebCore::EventPath::updateTouchLists): Removed local Vectors to TouchList now that updateTouchListsInEventPath
can obtain TouchList* on demand.
(WebCore::EventPath::setRelatedTarget): Upsed to use EventRelatedNodeResolver.
- 9:16 PM Changeset in webkit [157330] by
-
- 53 edits in trunk/Source
Change most call sites to call ICU directly instead of through WTF::Unicode
https://bugs.webkit.org/show_bug.cgi?id=122635
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- parser/Lexer.cpp:
(JSC::isNonLatin1IdentStart): Take a UChar since that's what the only caller wants to pass.
Use U_GET_GC_MASK instead of WTF::Unicode::category.
(JSC::isNonLatin1IdentPart): Ditto.
- parser/Lexer.h:
(JSC::Lexer::isWhiteSpace): Use u_charType instead of WTF::Unicode::isSeparatorSpace.
- runtime/JSFunction.cpp: Removed "using namespace" for WTF::Unicode, this will no longer
compile since this doesn't include anything that defines that namespace.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::isStrWhiteSpace): Use u_charType instead of WTF::Unicode::isSeparatorSpace.
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::atomPatternCharacter): Use u_tolower and u_toupper instead of
Unicode::toLower and Unicode::toUpper. Also added some assertions since this code assumes
it can convert any UChar to lowercase or uppercase in another UChar, with no risk of needing
a UChar32 for the result. I guess that's probably true, but it would be good to know in a
debug build if not.
Source/WebCore:
- Modules/indexeddb/IDBKeyPath.cpp:
(isIdentifierStartCharacter): Use U_GET_GC_MASK instead of WTF::Unicode::category.
(isIdentifierCharacter): Ditto.
- css/CSSParser.cpp:
(WebCore::makeLower): Use u_tolower instead of WTF::Unicode::toLower.
Also assert the character fits in a UChar.
- dom/Document.cpp:
(WebCore::isValidNameStart): Use U_GET_GC_MASK instead of WTF::Unicode::category,
and u_getIntPropertyValue instead of WTF::Unicode::decompositionType.
(WebCore::isValidNamePart): Ditto.
(WebCore::canonicalizedTitle): Ditto.
- editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent): Use u_isPunct instead of
WTF::Unicode::isPunct.
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::append): Use u_strFoldCase instead of WTF::Unicode::foldCase.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::directionality): Use UCharDirection instead of
WTF::Unicode::Direction.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::defaultEventHandler): Use u_isprint instead of
WTF::Unicode::isPrintableChar.
- html/TypeAhead.cpp:
(WebCore::stripLeadingWhiteSpace): Use u_charDirection instead of
WTF::Unicode::direction.
- html/track/TextTrackCue.cpp:
(WebCore::isCueParagraphSeparator): Use u_charType instead of
WTF::Unicode::category.
(WebCore::TextTrackCue::determineTextDirection): Use u_charDirection instead of
WTF::Unicode::direction.
- page/ContextMenuController.cpp:
(WebCore::selectionContainsPossibleWord): Use U_GET_GC_MASK instead of
WTF::Unicode::category.
- platform/graphics/Font.cpp:
(WebCore::Font::canReceiveTextEmphasis): Ditto.
- platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::glyphDataAndPageForCharacter): Use u_toupper instead of
WTF::Unicode::toUpper. Use u_charMirror instead of WTF::Unicode::mirroredChar.
- platform/graphics/GraphicsContext.cpp:
(WebCore::TextRunIterator::direction): Use u_charDirection instead of
WTF::Unicode::direction.
- platform/graphics/SVGGlyph.cpp:
(WebCore::charactersWithArabicForm): Use ublock_getCode instead of
WTF::Unicode::isArabicChar.
- platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks): Use
u_getCombiningClass instead of WTF::Unicode::combiningClass.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal): Use u_toupper instead of
WTF::Unicode::toUpper.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::collectComplexTextRuns): Added some
assertions about the user of u_toupper and tweaked coding style a bit.
- platform/text/BidiContext.cpp:
(WebCore::BidiContext::createUncached): Use UCharDirection instead of
WTF::Unicode::Direction.
(WebCore::BidiContext::create): Ditto.
(WebCore::copyContextAndRebaselineLevel): Ditto.
- platform/text/BidiContext.h:
(WebCore::BidiContext::dir): Ditto.
(WebCore::BidiContext::BidiContext): Ditto.
- platform/text/BidiResolver.h:
(WebCore::BidiStatus::BidiStatus): Ditto.
(WebCore::BidiEmbedding::BidiEmbedding): Ditto.
(WebCore::BidiEmbedding::direction): Ditto.
(WebCore::BidiCharacterRun::BidiCharacterRun): Ditto.
(WebCore::BidiResolver::BidiResolver): Ditto.
(WebCore::BidiResolver::setLastDir): Ditto.
(WebCore::BidiResolver::setLastStrongDir): Ditto.
(WebCore::BidiResolver::setEorDir): Ditto.
(WebCore::BidiResolver::dir): Ditto.
(WebCore::BidiResolver::setDir): Ditto.
(WebCore::BidiResolver::appendRun): Ditto.
(WebCore::BidiResolver::embed): Ditto.
(WebCore::BidiResolver::checkDirectionInLowerRaiseEmbeddingLevel): Ditto.
(WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Ditto.
(WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Ditto.
(WebCore::BidiResolver::commitExplicitEmbedding): Ditto.
(WebCore::BidiResolver::updateStatusLastFromCurrentDirection): Ditto.
(WebCore::BidiResolver::createBidiRunsForLine): Ditto.
- platform/text/SegmentedString.h:
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase): Use u_foldCase
instead of WTF::Unicode::foldCase.
- platform/text/TextBoundaries.cpp:
(WebCore::findNextWordFromIndex): Use u_isalnum instead of
WTF::Unicode::isAlphanumeric.
- platform/text/TextBoundaries.h:
(WebCore::requiresContextForWordBoundary): Use u_getIntPropertyValue directly
instead of WTF::Unicode::requiresComplexContextForWordBreaking.
- platform/text/mac/TextBoundaries.mm: Removed explicit use of WTF::Unicode,
which was unneeded and also will no longer compile.
- rendering/BidiRun.h:
(WebCore::BidiRun::BidiRun): Use UCharDirection instead of WTF::Unicode::Direction.
- rendering/InlineFlowBox.h: Ditto.
- rendering/InlineIterator.h:
(WebCore::embedCharFromDirection): Ditto.
(WebCore::notifyObserverWillExitObject): Ditto.
(WebCore::InlineIterator::direction): Ditto.
(WebCore::IsolateTracker::embed): Ditto.
(WebCore::InlineBidiResolver::appendRun): Ditto.
- rendering/RenderBlock.cpp:
(WebCore::isPunctuationForFirstLetter): Use U_GET_GC_MASK instead of
WTF::Unicode::category.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::determineDirectionality): Use u_charDirection instead of
WTF::Unicode::direction.
(WebCore::RenderBlockFlow::handleTrailingSpaces): Ditto.
(WebCore::statusWithDirection): Ditto.
(WebCore::LineBreaker::nextSegmentBreak): Use U_GET_GC_MASK instead of
WTF::Unicode::category.
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint): Use u_charDirection instead of
WTF::Unicode::direction.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::adjustInnerStyle): Use UCharDirection instead of
WTF::Unicode::Direction.
- rendering/RenderText.cpp:
(WebCore::makeCapitalized): Use u_totile instead of WTF::Unicode::toTitleCase.
Also added a comment about the fact that we need to use u_strToTitle instead.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineBreakBidiStatus): Use UCharDirection instead of
WTF::Unicode::Direction.
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::createStringWithMirroredCharacters): Use u_charMirror
instead of WTF::Unicode::mirroredChar.
- xml/XPathParser.cpp:
(WebCore::XPath::charCat): Use U_GET_GC_MASK instead of WTF::Unicode::category.
- platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::advance):
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint):
- platform/win/WebCoreTextRenderer.cpp:
(WebCore::isOneLeftToRightRun):
More of the same for Windows.
Source/WTF:
- wtf/text/StringHash.h:
(WTF::CaseFoldingHash::foldCase): Use u_foldCase instead of WTF::Unicode::foldCase.
(WTF::CaseFoldingHash::hash): Added an overload for a StringImpl& because why not.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::lower): Use u_tolower rather than WTF::Unicode::toLower. Also added
an assertion to check that the lowercase version is also part of Latin-1. If this
is not guaranteed it would be good to know in a debug build at least. Use u_strToLower
rather than WTF::Unicode::toLower. Also removed #if USE(ICU_UNICODE) around the
locale-specific version.
(WTF::StringImpl::upper): Use u_toupper and u_strToUpper, as above.
(WTF::StringImpl::foldCase): Use u_tolower and u_strFoldCase, as above.
(WTF::equalIgnoringCase): Use u_foldCase instead of WTF::Unicode::foldCase.
(WTF::StringImpl::defaultWritingDirection): Use u_charDirection and UCharDirection
instead of WTF::Unicode::direction and WTF::Unicode::Direction.
- wtf/text/StringImpl.h:
(WTF::equalIgnoringCase): Use u_memcasecmp instead of WTF::Unicode::umemcasecmp.
(WTF::isSpaceOrNewline): Use u_charDirection instead of WTF::Unicode::direction.
- wtf/text/WTFString.h:
(WTF::String::defaultWritingDirection): Use UCharDirection instead of WTF::Unicode::Direction.
- wtf/unicode/icu/UnicodeIcu.h: Removed almost everything.
- wtf/unicode/wchar/UnicodeWchar.cpp: Tried to do the right thing in this file, but
I did not actually compile it. Also, the implementations here aren't really sufficient
to make WebKit work broadly. There are many things that just aren't working with this
implementation, such as parsing that uses u_charType to figure out which characters are valid.
(unorm_normalize): Added.
(u_charDirection): Added.
(u_charMirror): Added.
(u_charType): Added.
(u_getCombiningClass): Added.
(u_getIntPropertyValue): Added.
(u_memcasecmp): Added.
(convertWithFunction): Changed to work with ICU-style status code instead of error bool.
(u_strFoldCase): Added.
(u_strToLower): Added.
(u_strToUpper): Added.
- wtf/unicode/wchar/UnicodeWchar.h: Ditto. Later this file should just be named like the
real ICU headers so the code can include it the same way it would ICU. But that will be
in a future patch.
- 7:21 PM Changeset in webkit [157329] by
-
- 7 edits3 adds in trunk
DFG: Add JIT support for LogicalNot(String/StringIdent)
https://bugs.webkit.org/show_bug.cgi?id=122627
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-11
Reviewed by Filip Pizlo.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileStringZeroLength):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
- 7:05 PM Changeset in webkit [157328] by
-
- 2 edits in trunk/Source/WebCore
Dramatically simplify calculateAdjustedNodes
https://bugs.webkit.org/show_bug.cgi?id=122680
Reviewed by Antti Koivisto.
Without insertion points, we never have to worry about entering a shadow DOM we've already climbed out of.
Deleted the logic to deal with insertion points in calculateAdjustedNodes accordingly.
- dom/EventDispatcher.cpp:
(WebCore::EventPath::EventPath):
(WebCore::calculateAdjustedNodes):
(WebCore::updateTouchListsInEventPath):
(WebCore::EventPath::updateTouchLists):
(WebCore::EventPath::setRelatedTarget):
- 6:35 PM Changeset in webkit [157327] by
-
- 5 edits in trunk/Source/JavaScriptCore
sunspider-1.0/math-spectral-norm.js.dfg-eager occasionally fails with Trap 5 (i.e int $3)
https://bugs.webkit.org/show_bug.cgi?id=122462
Reviewed by Mark Hahnenberg.
This fixes two bugs, both of which led to GetByVal on Int32 trapping because the
array no longer had Int32 shape but the check wasn't executed:
1) We weren't snapshotting the structures of mustHandleValues. This led to an awesome
race where if a mustHandleValue JSValue's structure changed on the main thread
between runs of the AI, the AI would contradict each other and things would just
get corrupted in funny ways.
2) The constant folder has a long standing bug! It will fold a node to a constant if
the AI proved it to be a constant. But it's possible that the original node also
proved things about the constant's structure. In that case "folding" to a
JSConstant actually loses information since JSConstant doesn't guarantee anything
about a constant's structure. There are various things we could do here to ensure
that a folded constant's structure doesn't change, and that if it does, we
deoptimize the code. But for now we can just make this sound by disabling folding
in this pathological case.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
- dfg/DFGGraph.h:
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::initialize):
- 6:33 PM Changeset in webkit [157326] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix handling of indirect stackmap locations in FTL OSR exit
https://bugs.webkit.org/show_bug.cgi?id=122666
Reviewed by Mark Hahnenberg.
With this change, the llvm.webkit.stackmap-based OSR exit only fails one test, down from
five tests previously.
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::gpr): It's OK to call this method when kind() == Indirect, so asserting that isGPR() is wrong; change to assert that involvesGPR().
(JSC::FTL::Location::restoreInto): Stack-related registers aren't saved to the scratch buffer, so use them directly.
- ftl/FTLLocation.h: Add comment about requirements for stack layout.
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStubWithOSRExitStackmap): Make enough room on the stack so that saveAllRegisters() has a scratchpad to save things to. Without this, saveAllRegisters() may clobber a spilled value.
- 6:22 PM Changeset in webkit [157325] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip tests that are already passing.
- platform/efl-wk2/TestExpectations:
- 5:43 PM Changeset in webkit [157324] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Fix for fast/xpath test regressions caused by r157205.
https://bugs.webkit.org/show_bug.cgi?id=122658.
Reviewed by Darin Adler.
- xml/XPathStep.h:
(WebCore::XPath::Step::NodeTest::NodeTest):
(WebCore::XPath::Step::NodeTest::operator=):
We were incorrectly setting the predicate list to null instead of the predicate list of the NodeTest being passed in.
- 4:09 PM Changeset in webkit [157323] by
-
- 13 edits in trunk
Remove preference support for picking the old Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=122655
Reviewed by Alexey Proskuryakov.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::localizedStringsURL):
(-[WebInspectorWindowController inspectorPagePath]):
Source/WebKit2:
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
- UIProcess/API/C/WKPreferencesPrivate.h:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::WebInspector):
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::WebInspector::localizedStringsURL):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformPreferencesDidChange):
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
- 3:59 PM Changeset in webkit [157322] by
-
- 2 edits in trunk/Tools
Fix 64-bit build on everything but Windows.
Rubber stamped by Brent Fulgham.
- Scripts/webkitdirs.pm:
(argumentsForConfiguration):
- 3:45 PM Changeset in webkit [157321] by
-
- 2 edits in trunk/Tools
Touch a file to see how auto-update works.
Rubber-stamped by Tim Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
- 3:12 PM Changeset in webkit [157320] by
-
- 6 edits3 adds in trunk/Source/WebKit2
Lay the groundwork for a multi-process aware Indexed DB implementation in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=122675
Reviewed by Alexey Proskuryakov.
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/IndexedDB/WebIDBFactoryBackend.cpp: Added.
(WebKit::WebIDBFactoryBackend::WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::~WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::getDatabaseNames):
(WebKit::WebIDBFactoryBackend::open):
(WebKit::WebIDBFactoryBackend::deleteDatabase):
- WebProcess/IndexedDB/WebIDBFactoryBackend.h: Added.
(WebKit::WebIDBFactoryBackend::create):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createIDBFactoryBackend): Return a WebIDBFactoryBackend.
- 2:14 PM Changeset in webkit [157319] by
-
- 19 edits1 delete in trunk/Source/WebKit2
Remove ENABLE(GESTURE_EVENTS) from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122673
Reviewed by Ryosuke Niwa.
- Shared/WebEvent.h:
- Shared/WebEventConversion.cpp:
- Shared/WebEventConversion.h:
- Shared/WebGestureEvent.cpp: Removed.
- Shared/mac/WebEventFactory.h:
- Shared/mac/WebEventFactory.mm:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- UIProcess/WebPageProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/EventDispatcher.cpp:
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebPage/EventDispatcher.messages.in:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- 2:01 PM Changeset in webkit [157318] by
-
- 2 edits in trunk/Source/WebCore
[CSS Shapes] Use the floatingObject's logical coordinates to determine its size in computeLogicalLocationForFloat
https://bugs.webkit.org/show_bug.cgi?id=122663
Reviewed by David Hyatt.
Covered by existing float tests in fast/shapes/shape-inside.
I'll add additional tests in bug #122664.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
- 12:18 PM Changeset in webkit [157317] by
-
- 7 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r157307.
http://trac.webkit.org/changeset/157307
https://bugs.webkit.org/show_bug.cgi?id=122671
Many assertion failures (Requested by ap on #webkit).
- jit/ThunkGenerators.cpp:
(JSC::arrayIteratorNextThunkGenerator):
- jit/ThunkGenerators.h:
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::createIteratorResult):
(JSC::arrayIteratorPrototypeNext):
- runtime/Intrinsic.h:
- runtime/JSArrayIterator.cpp:
(JSC::JSArrayIterator::finishCreation):
- runtime/VM.cpp:
(JSC::thunkGeneratorForIntrinsic):
- 12:16 PM Changeset in webkit [157316] by
-
- 17 edits3 deletes in trunk/Source
Remove gesture event support from WebCore
https://bugs.webkit.org/show_bug.cgi?id=122650
Reviewed by Ryosuke Niwa.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- dom/GestureEvent.cpp: Removed.
- dom/GestureEvent.h: Removed.
- dom/Node.cpp:
- dom/Node.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::sendContextMenuEventForKey):
- page/EventHandler.h:
- platform/PlatformGestureEvent.h: Removed.
- platform/Scrollbar.cpp:
- platform/Scrollbar.h:
- platform/mac/PlatformEventFactoryMac.h:
- platform/mac/PlatformEventFactoryMac.mm:
Source/WTF:
- wtf/FeatureDefines.h:
- wtf/nix/FeatureDefinesNix.h:
- 12:15 PM Changeset in webkit [157315] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening. Rebaseline after 157292.
- platform/gtk/editing/unsupported-content/table-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-003-expected.txt:
- 12:04 PM Changeset in webkit [157314] by
-
- 5 edits in trunk/Source/WebCore
Remove some dead code from PlatformCALayer*
https://bugs.webkit.org/show_bug.cgi?id=122641
Reviewed by Anders Carlsson.
Remove some unused getters from PlatformCALayer and its implementations.
No new tests, just removing dead code.
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
- 12:03 PM Changeset in webkit [157313] by
-
- 14 edits in trunk/Source/JavaScriptCore
Transition op_new_* JITStubs to JIT operations.
https://bugs.webkit.org/show_bug.cgi?id=122460.
Reviewed by Michael Saboff.
Also:
- Removed the redundant operationNewFunctionExpression(). It is identical to operationNewFunctionNoCheck().
- Sorted JIT operation signature keys in the comment in JITOperations.h.
- Removed the unused returnValue2Register definition for X86_64.
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewFunctionExpression):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emit_op_new_func_exp):
(JSC::JIT::emit_op_new_array):
(JSC::JIT::emit_op_new_array_with_size):
(JSC::JIT::emit_op_new_array_buffer):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_new_object):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JSInterfaceJIT.h:
- 11:59 AM Changeset in webkit [157312] by
-
- 2 edits in trunk/Tools
LeaksViewer fails to present recent results list if current build is still updating svn
https://bugs.webkit.org/show_bug.cgi?id=122670
Fixed an obvious mistake in the previous patch.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start):
- 11:56 AM Changeset in webkit [157311] by
-
- 2 edits in trunk/Tools
LeaksViewer fails to present recent results list if current build is still updating svn
https://bugs.webkit.org/show_bug.cgi?id=122670
Reviewed by Adam Roben.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
- 11:50 AM Changeset in webkit [157310] by
-
- 6 edits in trunk/Source
Confusing CGImageRef memory management in ImageBuffer::copyImage
https://bugs.webkit.org/show_bug.cgi?id=122605
Source/WebCore:
BitmapImage::create was adopting the CGImage passed into it, which
resulted in some strange contortions in ImageBuffer::copyImage that
made it look like it was leaking CGImages, when in fact it was just
relying on BitmapImage to adopt the extra references.
BitmapImage::create now retains the passed-in CGImage, and I updated
the two callers to it to expect that (one here, one in WebKit2). I
also changed ImageBuffer::copyNativeImage to return a RetainPtr to
reduce the number of adoptCF()s needed and make it harder to make
programming mistakes.
Reviewed by Simon Fraser.
No new tests because this is just a code cleanup.
- platform/graphics/ImageBuffer.h: Changed copyNativeImage to return a
RetainPtr<CGImageRef.
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::BitmapImage): Adopt the passed-in CGImage,
since we're taking ownership of it. (We release it in
FrameData::clear.)
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::copyImage): Updated for copyNativeImage's new
return type and to take into account BitmapImage::create's new
retaining semantics. This makes this function not have to be so clever
about retain counts.
(WebCore::ImageBuffer::copyNativeImage): Changed to return a
RetainPtr<CGImageRef>.
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
Updated for changes to copyNativeImage.
Source/WebKit2:
Reviewed by Simon Fraser.
- Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::createImage): BitmapImage::create now
retains the passed-in CGImage, so we don't need to dance around it
anymore. Also changed to use nullptr instead of 0 while I was in here.
- 11:01 AM Changeset in webkit [157309] by
-
- 5 edits6 adds in trunk
[CSS Shapes] Shape-Image-Threshold should be animatable
https://bugs.webkit.org/show_bug.cgi?id=122622
Reviewed by Darin Adler.
Source/WebCore:
Make the shape-image-threshold property respond to dynamic changes
made through JS or CSS animations. Responding to changes made to
shape-image-threshold is handled in RenderBox::updateShapeOutsideInfoAfterStyleChange,
while CSSPropertyAnimation.cpp adds the property to the list of
animatable properties.
Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-image-threshold.html
fast/shapes/shape-outside-floats/shape-outside-shape-image-threshold-animation.html
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add
shape-image-threshold to the list of animatable properties.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange): updateShapeOutsideInfoAfterStyleChange
needs to take two RenderStyle arguments to compare multiple shape properties,
rather than just the shape-outside property.
(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Compare
shape-image-threshold values to see if they changed, and invalidate the layout
if necessary.
- rendering/RenderBox.h:
LayoutTests:
Adding tests for dynamically changing shape-image threshold via JS and CSS
animations. Included are some SVG resources used as the shape image sources.
- fast/shapes/resources/svg-shape-002.svg: Added.
- fast/shapes/resources/svg-shape-003.svg: Added.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-image-threshold-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-image-threshold.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-shape-image-threshold-animation-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-shape-image-threshold-animation.html: Added.
- 10:57 AM Changeset in webkit [157308] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed gardening. Remove a Windows work-around that is not needed.
- dom/Range.cpp:
(WebCore::rangeOfContents): Move implementation back to source file.
- dom/Range.h: Remove inline I added to work around a compiler bug.
- 10:30 AM Changeset in webkit [157307] by
-
- 7 edits in trunk/Source/JavaScriptCore
Separate out array iteration intrinsics
https://bugs.webkit.org/show_bug.cgi?id=122656
Reviewed by Michael Saboff.
Separate out the intrinsics for key and values iteration
of arrays.
This requires moving moving array iteration into the iterator
instance, rather than the prototype, but this is essentially
unobservable so we'll live with it for now.
- jit/ThunkGenerators.cpp:
(JSC::arrayIteratorNextThunkGenerator):
(JSC::arrayIteratorNextKeyThunkGenerator):
(JSC::arrayIteratorNextValueThunkGenerator):
- jit/ThunkGenerators.h:
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
- runtime/Intrinsic.h:
- runtime/JSArrayIterator.cpp:
(JSC::JSArrayIterator::finishCreation):
(JSC::createIteratorResult):
(JSC::arrayIteratorNext):
(JSC::arrayIteratorNextKey):
(JSC::arrayIteratorNextValue):
(JSC::arrayIteratorNextGeneric):
- runtime/VM.cpp:
(JSC::thunkGeneratorForIntrinsic):
- 9:54 AM Changeset in webkit [157306] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r157297.
http://trac.webkit.org/changeset/157297
https://bugs.webkit.org/show_bug.cgi?id=122651
Caused crashes on multiple platform/mac-wk2/tiled-drawing
tests (Requested by ap on #webkit).
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::operator new):
(WebCore::RenderLayer::operator delete):
(WebCore::RenderLayer::destroy):
- rendering/RenderLayer.h:
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::RenderLayerModelObject):
(WebCore::RenderLayerModelObject::destroyLayer):
(WebCore::RenderLayerModelObject::ensureLayer):
- rendering/RenderLayerModelObject.h:
(WebCore::RenderLayerModelObject::layer):
- 9:53 AM Changeset in webkit [157305] by
-
- 3 edits24 adds in trunk/LayoutTests
[CSS Shapes] New positioning model: Negative margins
https://bugs.webkit.org/show_bug.cgi?id=118090
Reviewed by Darin Adler.
Tests for shape-outside with negative margins:
negative top margin
negative left margin
negative right margin
negative bottom margin
negative top margin vertical right-left writing mode
negative left margin vertical right-left writing mode
negative right margin vertical right-left writing mode
negative bottom margin vertical right-left writing mode
negative top margin vertical left-right writing mode
negative left margin vertical left-right writing mode
negative right margin vertical left-right writing mode
negative bottom margin vertical left-right writing mode
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 9:51 AM Changeset in webkit [157304] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Added new accessibility expectation after r154697
https://bugs.webkit.org/show_bug.cgi?id=122646
Unreviewed EFL gardening
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-11
- platform/efl-wk2/TestExpectations:
- platform/efl/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
- 9:46 AM Changeset in webkit [157303] by
-
- 2 edits in trunk/Tools
Unreviewed build fix for --64-bit target.
- Scripts/webkitdirs.pm:
(argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
been removed by this point.
(hasArgument): Remove unused temporary.
- 9:34 AM Changeset in webkit [157302] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::translate): Do a const_cast when creating the
lineage, since it doesn't yet work with const pointers.
- 8:26 AM Changeset in webkit [157301] by
-
- 4 edits in trunk/Source/JavaScriptCore
Pass VM instead of ExecState to JSGenericTypedArrayViewPrototype.
<https://webkit.org/b/122632>
Reviewed by Sam Weinig.
This code was only using the ExecState to find the VM.
- 8:07 AM Changeset in webkit [157300] by
-
- 4 edits in trunk/Source/WebCore
Do a bit of optimization and cleanup in the HTMLElement class
https://bugs.webkit.org/show_bug.cgi?id=122640
Reviewed by Andreas Kling.
- html/HTMLElement.cpp:
(WebCore::unicodeBidiAttributeForDirAuto): Take a reference.
(WebCore::HTMLElement::collectStyleForPresentationAttribute): Pass one.
(WebCore::mergeWithNextTextNode): Take a reference to a Text node instead
of a PassRefPtr to a Node. Also removed unnecessary check of parentNode.
Also update to new calling convention for mergeWithNextTextNode.
(WebCore::HTMLElement::setOuterHTML): Use parentElement instead of
parentNode, since Antti says that's the future, and either will work here.
Also use nullptr.
(WebCore::HTMLElement::textToFragment): Fix indentation and use nullptr.
(WebCore::HTMLElement::setOuterText): Use a RefPtr for the parent here,
since otherwise there is no guarantee it survives. Also use nullptr and
update to new calling convention for mergeWithNextTextNode.
(WebCore::HTMLElement::insertAdjacent): Use nullptr.
(WebCore::HTMLElement::insertAdjacentElement): Use nullptr.
(WebCore::contextElementForInsertion): Use nullptr.
(WebCore::HTMLElement::contentEditable): Use ASCIILiteral.
(WebCore::HTMLElement::setContentEditable): Use AtomicString::ConstructFromLiteral.
(WebCore::HTMLElement::draggable): Use fastGetAttribute.
(WebCore::HTMLElement::setDraggable): Use AtomicString::ConstructFromLiteral.
(WebCore::HTMLElement::setSpellcheck): Use AtomicString::ConstructFromLiteral.
(WebCore::HTMLElement::click): Use nullptr.
(WebCore::HTMLElement::accessKeyAction): Use nullptr.
(WebCore::HTMLElement::title): Use fastGetAttribute.
(WebCore::HTMLElement::translateAttributeMode): Use fastGetAttribute, isNull,
and isEmpty.
(WebCore::HTMLElement::translate): Use parentElement and toHTMLElement.
Use early-continue style instead of nesting the whole loop body inside an if.
(WebCore::setHasDirAutoFlagRecursively): Use nullptr.
(WebCore::HTMLElement::hasDirectionAuto): Use isNull.
(WebCore::HTMLElement::directionality): Use nullptr.
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged): Use nullptr.
(WebCore::HTMLElement::addHTMLLengthToStyle): Use longer variable names.
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::abbr): Use fastGetAttribute.
(WebCore::HTMLTableCellElement::axis): Ditto.
(WebCore::HTMLTableCellElement::headers): Ditto.
(WebCore::HTMLTableCellElement::scope): Ditto.
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::width): Ditto.
- 2:44 AM Changeset in webkit [157299] by
-
- 8 edits in trunk
Source/WebCore: Use after free in WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=121033
Patch by Darin Adler <Darin Adler> on 2013-10-10
Reviewed by Dean Jackson.
For safe iteration, use a set rather than a vector, and remove the clients from
the set if they are removed during iteration.
Test: fast/animation/request-animation-frame-remove-client.html
- platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor): Initialize the
m_clientsToBeNotified pointer to null.
(WebCore::DisplayRefreshMonitor::removeClient): If there is a m_clientsToBeNotified
set, remove from it as well as the real m_clients set.
(WebCore::DisplayRefreshMonitor::displayDidRefresh): Use a HashSet instead of a
vector for the copy of the clients set we iterate.
- platform/graphics/DisplayRefreshMonitor.h: Moved some of the BlackBerry-specific
part of this out of the header. Added a new HashSet pointer, m_clientsToBeNotified,
to be used to remove clients during the notification process. Also added a FIXME.
- platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Moved the
DisplayAnimationClient class in here.
LayoutTests: Use after free in WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded
http://webkit.org/b/121033
Update test to indicate it no longer crashes.
- TestExpectations: Mark test as passing.
- fast/animation/request-animation-frame-remove-client-expected.txt:
- fast/animation/request-animation-frame-remove-client.html:
- 2:43 AM Changeset in webkit [157298] by
-
- 4 edits2 adds in trunk
Use after free in WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded
http://webkit.org/b/121033
Reviewed by Darin Adler.
Source/WebCore:
Add an ASSERT to detect if an animation client will be removed
during the callback dispatch.
Test: fast/animation/request-animation-frame-remove-client.html
- platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::displayDidRefresh):
LayoutTests:
Test that assertion fires if you try to remove potential client while in a
animation dispatch.
- TestExpectations: Mark test as crashing.
- fast/animation/request-animation-frame-remove-client-expected.txt: Added.
- fast/animation/request-animation-frame-remove-client.html: Added.
- 2:39 AM Changeset in webkit [157297] by
-
- 5 edits in trunk/Source/WebCore
Make RenderLayer not arena-allocated.
<https://webkit.org/b/87523>
Reviewed by Antti Koivisto.
Let RenderLayerModelObject store its RenderLayer in a unique_ptr.
Layers are relatively low-volume objects and this looks neutral
on our performance tests.
- 1:35 AM Changeset in webkit [157296] by
-
- 11 edits in trunk
REGRESSION (r155607): Javascript site does not load visually on panerabread.com
https://bugs.webkit.org/show_bug.cgi?id=122461
Reviewed by Simon Fraser.
Do not modify the composited layer backing's internal layer structure directly
when the clipping behaviour changes.
When we directly create/destroy RenderLayerBacking::m_ancestorClippingLayer to
reflect the new clipping state, other, depending layers need updating. In order to
not to corrupt the internal hierarchy, mark the compositing layers dirty and let
the normal updating mechanism take care of creating/destroying the ancestor layers.
Source/WebCore:
Existing tests are extended.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::checkIfDescendantClippingContextNeedsUpdate):
(WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.h:
LayoutTests:
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html:
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html:
- platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
- platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
- 1:26 AM Changeset in webkit [157295] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] Fix build after r157209.
https://bugs.webkit.org/show_bug.cgi?id=122643
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-11
Reviewed by Ryosuke Niwa.
- assembler/MacroAssemblerSH4.h: Add framePointerRegister declaration.
- assembler/SH4Assembler.h: Add firstRegister() declaration.
(JSC::SH4Assembler::firstRegister):
Oct 10, 2013:
- 11:41 PM Changeset in webkit [157294] by
-
- 4 edits in trunk/Source/WebCore
Make EventPath private to EventDispatcher.cpp
https://bugs.webkit.org/show_bug.cgi?id=122638
Reviewed by Darin Adler.
Move the declaration of EventPath into EventDispatcher.cpp since EventPath is only used in this file.
Also make EventDispatcher a namespace since it is never instantiated since r157250.
- dom/EventDispatcher.cpp:
(WebCore::EventPath::isEmpty):
(WebCore::EventPath::size):
(WebCore::EventPath::contextAt):
(WebCore::EventPath::lastContextIfExists):
- dom/EventDispatcher.h:
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willDispatchEvent):
- 11:37 PM Changeset in webkit [157293] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL shouldn't pass i1's into llvm.webkit.stackmap's
https://bugs.webkit.org/show_bug.cgi?id=122629
<rdar://problem/15203037>
Reviewed by Sam Weinig and Nadav Rotem.
LLVM's stackmap support requires that we only pass operands with legal types (i.e. types
that are hardware-representable). i1, which the FTL previously used for Booleans, is not
legal.
We have two options: either add support in LLVM to legalize stackmap operands, or add
support to the FTL to legalize stackmap operands. It's easier to fix this in FTL, and
that's what this patch does.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
- 11:18 PM Changeset in webkit [157292] by
-
- 8 edits2 adds in trunk
contentEditable with "position:relative" paragraphs is buggy
https://bugs.webkit.org/show_bug.cgi?id=33950
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-10
Reviewed by Darin Adler.
Source/WebCore:
When paragraph is positioned(relative/absolute/fixed) then deleting
that paragraph cause wrong merging of other(below) paragraphs. This is
happening because positioned element is treated as special element and
on deletion complete paragraph element is removed. The ranges become
paragraph. This issue happens when all the content of special element
are deleted. So the merging of paragraph is avoided in this scenario.
Test: editing/deleting/deleting-relative-positioned-special-element.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializeStartEnd):Avoid merging
block when special candidate are included in deletion range
LayoutTests:
LayoutTests:
Added a testcase to verify that when paragraph is relative positioned
then deleting the all content of paragraph should not incorrectly collapse the
others(below) paragraphs.
And Rebaseline the test expectation.
- editing/deleting/5546763-expected.txt: Updated.
- editing/deleting/deleting-relative-positioned-special-element-expected.txt: Added.
- editing/deleting/deleting-relative-positioned-special-element.html: Added.
- editing/unsupported-content/table-delete-001.html: Adjusted to dump
as markup.
- editing/unsupported-content/table-delete-003.html: Adjusted to dump
as markup.
Below tests had wrong cursor position previously now corrected and
both expected file has been changed to markup dump.
- platform/mac/editing/unsupported-content/table-delete-001-expected.txt:
- platform/mac/editing/unsupported-content/table-delete-003-expected.txt:
- 11:17 PM Changeset in webkit [157291] by
-
- 3 edits in trunk/LayoutTests
Layout Test fast/css/font-face-download-error.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122636
Reviewed by Darin Adler.
- fast/css/font-face-download-error-expected.txt: TEST COMPLETE is now printed
after the test is complete.
- fast/css/font-face-download-error.html: Changed to properly wait for fonts to load.
Also, updated to use a proper async test implementation.
- 11:16 PM Changeset in webkit [157290] by
-
- 6 edits2 adds in trunk
Track controls show metadata and chapter tracks
https://bugs.webkit.org/show_bug.cgi?id=122468
Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-10
Reviewed by Darin Adler.
Source/WebCore:
Test: media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::sortedTrackListForMenu): Only show captions, descriptions and subtitles in the track controls.
LayoutTests:
Add a test to make sure we don't show metadata and chapter tracks in the track controls.
- media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles-expected.txt: Added.
- media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html: Added.
- platform/efl/TestExpectations: Skip, uses caption button, not track menu.
- platform/mac/TestExpectations: Skip, track menu tests all fail on Mac.
- platform/win/TestExpectations: Same.
- 9:55 PM Changeset in webkit [157289] by
-
- 4 edits3 adds in trunk/Source/WebKit2
[EFL][WK2] Separate dispatch context from WorkQueue.
https://bugs.webkit.org/show_bug.cgi?id=115332
Reviewed by Anders Carlsson.
Refactor WorkQueue to prevent dangling workqueue access.
Previously, the WorkQueue class had all context about dispatch.
WorkQueue had dispatch item queue and socket event handler,
and those were accessed on the work queue thread through WorkQueue
instance.
With reference countable WorkQueue concept, this implementation
complicates handling workqueue ref-counting and causes dangling
workqueue access problem.
To make it easy to handle WorkQueue reference count and to prevent
dangling access problem, DispatchQueue class is added to handle
dispatch tasks, and the WorkQueue instance and DispatchQueue thread
will have the reference count of the DispatchQueue instance to prevent
dangling access.
- Platform/WorkQueue.h:
- Platform/efl/DispatchQueueEfl.cpp: Added.
(DispatchQueue::ThreadContext::start):
(DispatchQueue::ThreadContext::ThreadContext):
(DispatchQueue::ThreadContext::function):
(DispatchQueue::create):
(DispatchQueue::DispatchQueue):
(DispatchQueue::~DispatchQueue):
(DispatchQueue::dispatch):
(DispatchQueue::stopThread):
(DispatchQueue::setSocketEventHandler):
(DispatchQueue::clearSocketEventHandler):
(DispatchQueue::performWork):
(DispatchQueue::performTimerWork):
(DispatchQueue::performFileDescriptorWork):
(DispatchQueue::insertTimerWorkItem):
(DispatchQueue::dispatchQueueThread):
(DispatchQueue::wakeUpThread):
(DispatchQueue::getNextTimeOut):
- Platform/efl/DispatchQueueEfl.h: Added.
- Platform/efl/DispatchQueueWorkItemEfl.h: Added.
(WorkItem::create):
(WorkItem::dispatch):
(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::expirationTimeSeconds):
(TimerWorkItem::hasExpired):
(TimerWorkItem::TimerWorkItem):
- Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
- PlatformEfl.cmake:
- 8:56 PM Changeset in webkit [157288] by
-
- 14 edits2 deletes in trunk/Source/WebCore
EventContext should be used only in EventDispatcher.cpp
https://bugs.webkit.org/show_bug.cgi?id=122631
Reviewed by Anders Carlsson.
Merged WindowEventContext into EventDispatcher. Moved the code to avoid dispatching load event on
window into dispatchEventInDOM so that WindowEventContext's constructor doesn't need Event.
Also replaced DOMWindow, Node, and EventPath arguments to InspectorInstrumentation::willDispatchEvent
by a single boolean indicating whether window, the origin, or the event path has an event listener.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/EventDispatcher.cpp:
(WebCore::WindowEventContext::window): Moved from WindowEventContext.
(WebCore::WindowEventContext::target): Ditto.
(WebCore::WindowEventContext::WindowEventContext): Ditto; removed the code to avoid dispatching load
event on window since that's checked in dispatchEventInDOM now.
(WebCore::WindowEventContext::handleLocalEvents): Ditto.
(WebCore::dispatchEventInDOM): Avoid calling handleLocalEvent on a load event with WindowEventContext.
(WebCore::EventDispatcher::dispatchEvent): Pass a boolean to indicate whether window, the origin, or
the event path contains any event listener to InspectorInstrumentation::willDispatchEvent to hide
EventPath from the inspector code.
- dom/EventDispatcher.h:
- dom/Node.cpp:
- dom/Node.h:
- dom/WindowEventContext.cpp: Removed.
- dom/WindowEventContext.h: Removed.
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willDispatchEventImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willDispatchEvent):
- 8:51 PM Changeset in webkit [157287] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r157205?): Leaks in XPath
https://bugs.webkit.org/show_bug.cgi?id=122609
Reviewed by Andreas Kling.
- xml/XPathGrammar.y: Fixed warnings by adding missing "$$ = $1" to various rules.
Added local unique_ptr for NodeTest and ArgumentList in three rules, so they
won't be leaked.
- 8:37 PM Changeset in webkit [157286] by
-
- 5 edits in trunk/Source/WebCore
Add toSVGColor|Paint() to cleanup static_cast<>, and use it
https://bugs.webkit.org/show_bug.cgi?id=122630
Reviewed by Andreas Kling.
SVGColor and SVGPaint can't use CSS_VALUE_TYPE_CASTS(), this cl adds
toSVGColor() and toSVGPaint() manually. Those functions will help to
detect bad type cast.
- css/CSSValue.cpp:
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- svg/SVGColor.h:
(WebCore::toSVGColor):
- svg/SVGPaint.h:
(WebCore::toSVGPaint):
- 6:47 PM Changeset in webkit [157285] by
-
- 11 edits2 deletes in trunk/Source/WebCore
Kill WebCore::BindingState.
<https://webkit.org/b/122606>
Reviewed by Darin Adler.
Just use JSC::ExecState directly instead.
- 6:47 PM Changeset in webkit [157284] by
-
- 2 edits in trunk/Tools
webkit-patch failure-reason has a quite low limit for 'too many failures'
https://bugs.webkit.org/show_bug.cgi?id=122556
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-10
Reviewed by Darin Adler.
- Scripts/webkitpy/tool/commands/queries.py:
(FailureReason._explain_failures_for_builder): adjust the number of too many failures
to match what the layout test runners use these days.
- 6:41 PM Changeset in webkit [157283] by
-
- 2 edits in trunk/Tools
webkit-patch failure-reason should allow specifying failures one is interested in
https://bugs.webkit.org/show_bug.cgi?id=122554
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-10
Reviewed by Darin Adler.
- Scripts/webkitpy/tool/commands/queries.py:
(FailureReason):
(FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
loop if the ones we're interested in been explained.
(FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
(FailureReason.execute): initialize failures to explain and the explained set.
- 6:14 PM Changeset in webkit [157282] by
-
- 17 edits2 deletes in trunk/Source/WebCore
Remove EventRetargeter.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=122625
Reviewed by Anders Carlsson.
Merged the remaining contents of EventRetargeter.h and EventRetargter.cpp into EventDispatcher.cpp.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/indieui/UIRequestEvent.cpp:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/Event.cpp:
- dom/Event.h:
- dom/EventDispatcher.cpp:
(WebCore::eventTargetRespectingTargetRules):
(WebCore::shouldEventCrossShadowBoundary):
(WebCore::nodeOrHostIfPseudoElement):
(WebCore::EventPath::EventPath):
(WebCore::buildRelatedNodeMap):
(WebCore::addRelatedNodeForUnmapedTreeScopes):
(WebCore::calculateAdjustedNodes):
(WebCore::updateTouchListsInEventPath):
(WebCore::EventPath::updateTouchLists):
(WebCore::EventPath::setRelatedTarget):
- dom/EventRetargeter.cpp: Removed.
- dom/EventRetargeter.h: Removed.
- dom/FocusEvent.cpp:
- dom/GestureEvent.h:
- dom/KeyboardEvent.h:
- dom/MouseEvent.cpp:
- dom/MouseEvent.h:
- dom/TouchEvent.cpp:
- dom/UIEvent.cpp:
- dom/WheelEvent.cpp:
- 5:51 PM Changeset in webkit [157281] by
-
- 2 edits in trunk/Source/WebKit
Windows build fix attempt.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 5:40 PM Changeset in webkit [157280] by
-
- 3 edits in trunk/Source/WebCore
Making the base implementation of isAudioStreamSource, in MediaStreamSource, return the correct value
https://bugs.webkit.org/show_bug.cgi?id=122612
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-10
Reviewed by Jer Noble.
There is no reason for this implementation, in the base class, to always return false
if we already have the information about the type of the source.
No new tests needed.
- Modules/webaudio/MediaStreamAudioSource.h:
- platform/mediastream/MediaStreamSource.h:
(WebCore::MediaStreamSource::isAudioStreamSource):
- 5:30 PM Changeset in webkit [157279] by
-
- 2 edits in trunk/Source/WebKit/mac
Always force layout before flushing compositing layers
https://bugs.webkit.org/show_bug.cgi?id=122626
Reviewed by Tim Horton.
[m_webView _flushCompositingChanges] only actually flushes compositing
layers if the FrameView does not need layout (FrameView::flushCompositingStateForThisFrame()
returns in this case). In this situation, flushLayers() does actually try
to force a layout, but on some platforms it's possible for something else
to dirty layout before the runloop observer fires again. This can result
in flushLayers() never actually managing to flush, which stalls visual
updates.
Fix by always calling -viewWillDraw (which updates layout) before flushing
layers. This now matches WebKit2 behavior.
- WebView/WebView.mm:
(LayerFlushController::flushLayers):
- 5:17 PM Changeset in webkit [157278] by
-
- 1 edit431 deletes in trunk/Source/WebCore
Web Inspector: Remove the old front-end from WebKit.
https://bugs.webkit.org/show_bug.cgi?id=122295
- inspector/front-end/AceTextEditor.js: Removed.
- inspector/front-end/AdvancedSearchController.js: Removed.
- inspector/front-end/ApplicationCacheItemsView.js: Removed.
- inspector/front-end/ApplicationCacheModel.js: Removed.
- inspector/front-end/AuditCategories.js: Removed.
- inspector/front-end/AuditController.js: Removed.
- inspector/front-end/AuditFormatters.js: Removed.
- inspector/front-end/AuditLauncherView.js: Removed.
- inspector/front-end/AuditResultView.js: Removed.
- inspector/front-end/AuditRules.js: Removed.
- inspector/front-end/AuditsPanel.js: Removed.
- inspector/front-end/BottomUpProfileDataGridTree.js: Removed.
- inspector/front-end/BreakpointManager.js: Removed.
- inspector/front-end/BreakpointsSidebarPane.js: Removed.
- inspector/front-end/CPUProfileView.js: Removed.
- inspector/front-end/CSSMetadata.js: Removed.
- inspector/front-end/CSSNamedFlowCollectionsView.js: Removed.
- inspector/front-end/CSSNamedFlowView.js: Removed.
- inspector/front-end/CSSSelectorProfileView.js: Removed.
- inspector/front-end/CSSStyleModel.js: Removed.
- inspector/front-end/CallStackSidebarPane.js: Removed.
- inspector/front-end/CanvasProfileView.js: Removed.
- inspector/front-end/Checkbox.js: Removed.
- inspector/front-end/CodeMirrorTextEditor.js: Removed.
- inspector/front-end/Color.js: Removed.
- inspector/front-end/CompilerScriptMapping.js: Removed.
- inspector/front-end/ConsoleMessage.js: Removed.
- inspector/front-end/ConsoleModel.js: Removed.
- inspector/front-end/ConsolePanel.js: Removed.
- inspector/front-end/ConsoleView.js: Removed.
- inspector/front-end/ContentProvider.js: Removed.
- inspector/front-end/ContentProviderBasedProjectDelegate.js: Removed.
- inspector/front-end/ContentProviders.js: Removed.
- inspector/front-end/ContextMenu.js: Removed.
- inspector/front-end/CookieItemsView.js: Removed.
- inspector/front-end/CookieParser.js: Removed.
- inspector/front-end/CookiesTable.js: Removed.
- inspector/front-end/DOMAgent.js: Removed.
- inspector/front-end/DOMBreakpointsSidebarPane.js: Removed.
- inspector/front-end/DOMCountersGraph.js: Removed.
- inspector/front-end/DOMExtension.js: Removed.
- inspector/front-end/DOMPresentationUtils.js: Removed.
- inspector/front-end/DOMStorage.js: Removed.
- inspector/front-end/DOMStorageItemsView.js: Removed.
- inspector/front-end/DOMSyntaxHighlighter.js: Removed.
- inspector/front-end/DataGrid.js: Removed.
- inspector/front-end/Database.js: Removed.
- inspector/front-end/DatabaseQueryView.js: Removed.
- inspector/front-end/DatabaseTableView.js: Removed.
- inspector/front-end/DebuggerModel.js: Removed.
- inspector/front-end/DebuggerScriptMapping.js: Removed.
- inspector/front-end/DefaultScriptMapping.js: Removed.
- inspector/front-end/DefaultTextEditor.js: Removed.
- inspector/front-end/Dialog.js: Removed.
- inspector/front-end/DirectoryContentView.js: Removed.
- inspector/front-end/DockController.js: Removed.
- inspector/front-end/Drawer.js: Removed.
- inspector/front-end/ElementsPanel.js: Removed.
- inspector/front-end/ElementsPanelDescriptor.js: Removed.
- inspector/front-end/ElementsTreeOutline.js: Removed.
- inspector/front-end/EmptyView.js: Removed.
- inspector/front-end/EventListenersSidebarPane.js: Removed.
- inspector/front-end/ExtensionAPI.js: Removed.
- inspector/front-end/ExtensionAuditCategory.js: Removed.
- inspector/front-end/ExtensionPanel.js: Removed.
- inspector/front-end/ExtensionRegistryStub.js: Removed.
- inspector/front-end/ExtensionServer.js: Removed.
- inspector/front-end/ExtensionView.js: Removed.
- inspector/front-end/FileContentView.js: Removed.
- inspector/front-end/FileManager.js: Removed.
- inspector/front-end/FileMapping.js: Removed.
- inspector/front-end/FileSystemMapping.js: Removed.
- inspector/front-end/FileSystemModel.js: Removed.
- inspector/front-end/FileSystemProjectDelegate.js: Removed.
- inspector/front-end/FileSystemView.js: Removed.
- inspector/front-end/FileUtils.js: Removed.
- inspector/front-end/FilteredItemSelectionDialog.js: Removed.
- inspector/front-end/FlameChart.js: Removed.
- inspector/front-end/FontView.js: Removed.
- inspector/front-end/GoToLineDialog.js: Removed.
- inspector/front-end/HAREntry.js: Removed.
- inspector/front-end/HandlerRegistry.js: Removed.
- inspector/front-end/HeapSnapshot.js: Removed.
- inspector/front-end/HeapSnapshotDataGrids.js: Removed.
- inspector/front-end/HeapSnapshotGridNodes.js: Removed.
- inspector/front-end/HeapSnapshotLoader.js: Removed.
- inspector/front-end/HeapSnapshotProxy.js: Removed.
- inspector/front-end/HeapSnapshotView.js: Removed.
- inspector/front-end/HeapSnapshotWorker.js: Removed.
- inspector/front-end/HeapSnapshotWorkerDispatcher.js: Removed.
- inspector/front-end/HelpScreen.js: Removed.
- inspector/front-end/ImageView.js: Removed.
- inspector/front-end/Images/addIcon.png: Removed.
- inspector/front-end/Images/applicationCache.png: Removed.
- inspector/front-end/Images/back.png: Removed.
- inspector/front-end/Images/breakpointBorder.png: Removed.
- inspector/front-end/Images/breakpointConditionalBorder.png: Removed.
- inspector/front-end/Images/breakpointConditionalCounterBorder.png: Removed.
- inspector/front-end/Images/breakpointCounterBorder.png: Removed.
- inspector/front-end/Images/checker.png: Removed.
- inspector/front-end/Images/closeButtons.png: Removed.
- inspector/front-end/Images/cookie.png: Removed.
- inspector/front-end/Images/database.png: Removed.
- inspector/front-end/Images/databaseTable.png: Removed.
- inspector/front-end/Images/debuggerContinue.png: Removed.
- inspector/front-end/Images/debuggerPause.png: Removed.
- inspector/front-end/Images/debuggerStepInto.png: Removed.
- inspector/front-end/Images/debuggerStepOut.png: Removed.
- inspector/front-end/Images/debuggerStepOver.png: Removed.
- inspector/front-end/Images/deleteIcon.png: Removed.
- inspector/front-end/Images/disclosureTriangleSmallDown.png: Removed.
- inspector/front-end/Images/disclosureTriangleSmallDownBlack.png: Removed.
- inspector/front-end/Images/disclosureTriangleSmallDownWhite.png: Removed.
- inspector/front-end/Images/disclosureTriangleSmallRight.png: Removed.
- inspector/front-end/Images/disclosureTriangleSmallRightBlack.png: Removed.
- inspector/front-end/Images/disclosureTriangleSmallRightDown.png: Removed.
- inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png: Removed.
- inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png: Removed.
- inspector/front-end/Images/disclosureTriangleSmallRightWhite.png: Removed.
- inspector/front-end/Images/domain.png: Removed.
- inspector/front-end/Images/errorIcon.png: Removed.
- inspector/front-end/Images/errorMediumIcon.png: Removed.
- inspector/front-end/Images/errorRedDot.png: Removed.
- inspector/front-end/Images/fileSystem.png: Removed.
- inspector/front-end/Images/forward.png: Removed.
- inspector/front-end/Images/frame.png: Removed.
- inspector/front-end/Images/glossyHeader.png: Removed.
- inspector/front-end/Images/glossyHeaderPressed.png: Removed.
- inspector/front-end/Images/glossyHeaderSelected.png: Removed.
- inspector/front-end/Images/glossyHeaderSelectedPressed.png: Removed.
- inspector/front-end/Images/goArrow.png: Removed.
- inspector/front-end/Images/graphLabelCalloutLeft.png: Removed.
- inspector/front-end/Images/graphLabelCalloutRight.png: Removed.
- inspector/front-end/Images/indexedDB.png: Removed.
- inspector/front-end/Images/indexedDBIndex.png: Removed.
- inspector/front-end/Images/indexedDBObjectStore.png: Removed.
- inspector/front-end/Images/localStorage.png: Removed.
- inspector/front-end/Images/namedFlowOverflow.png: Removed.
- inspector/front-end/Images/navigatorShowHideButton.png: Removed.
- inspector/front-end/Images/paneAddButtons.png: Removed.
- inspector/front-end/Images/paneBottomGrow.png: Removed.
- inspector/front-end/Images/paneBottomGrowActive.png: Removed.
- inspector/front-end/Images/paneElementStateButtons.png: Removed.
- inspector/front-end/Images/paneFilterButtons.png: Removed.
- inspector/front-end/Images/paneGrowHandleLine.png: Removed.
- inspector/front-end/Images/paneRefreshButtons.png: Removed.
- inspector/front-end/Images/paneSettingsButtons.png: Removed.
- inspector/front-end/Images/popoverArrows.png: Removed.
- inspector/front-end/Images/popoverBackground.png: Removed.
- inspector/front-end/Images/profileGroupIcon.png: Removed.
- inspector/front-end/Images/profileIcon.png: Removed.
- inspector/front-end/Images/profileSmallIcon.png: Removed.
- inspector/front-end/Images/profilesSilhouette.png: Removed.
- inspector/front-end/Images/programCounterBorder.png: Removed.
- inspector/front-end/Images/radioDot.png: Removed.
- inspector/front-end/Images/regionEmpty.png: Removed.
- inspector/front-end/Images/regionFit.png: Removed.
- inspector/front-end/Images/regionOverset.png: Removed.
- inspector/front-end/Images/resourceCSSIcon.png: Removed.
- inspector/front-end/Images/resourceDocumentIcon.png: Removed.
- inspector/front-end/Images/resourceDocumentIconSmall.png: Removed.
- inspector/front-end/Images/resourceJSIcon.png: Removed.
- inspector/front-end/Images/resourcePlainIcon.png: Removed.
- inspector/front-end/Images/resourcePlainIconSmall.png: Removed.
- inspector/front-end/Images/resourcesSizeGraphIcon.png: Removed.
- inspector/front-end/Images/resourcesTimeGraphIcon.png: Removed.
- inspector/front-end/Images/scriptsSilhouette.png: Removed.
- inspector/front-end/Images/searchNext.png: Removed.
- inspector/front-end/Images/searchPrev.png: Removed.
- inspector/front-end/Images/searchSmallBlue.png: Removed.
- inspector/front-end/Images/searchSmallBrightBlue.png: Removed.
- inspector/front-end/Images/searchSmallGray.png: Removed.
- inspector/front-end/Images/searchSmallWhite.png: Removed.
- inspector/front-end/Images/segment.png: Removed.
- inspector/front-end/Images/segmentEnd.png: Removed.
- inspector/front-end/Images/segmentHover.png: Removed.
- inspector/front-end/Images/segmentHoverEnd.png: Removed.
- inspector/front-end/Images/segmentSelected.png: Removed.
- inspector/front-end/Images/segmentSelectedEnd.png: Removed.
- inspector/front-end/Images/sessionStorage.png: Removed.
- inspector/front-end/Images/spinner.gif: Removed.
- inspector/front-end/Images/spinnerActive.gif: Removed.
- inspector/front-end/Images/spinnerActiveSelected.gif: Removed.
- inspector/front-end/Images/spinnerInactive.gif: Removed.
- inspector/front-end/Images/spinnerInactiveSelected.gif: Removed.
- inspector/front-end/Images/splitviewDimple.png: Removed.
- inspector/front-end/Images/splitviewDividerBackground.png: Removed.
- inspector/front-end/Images/statusbarButtonGlyphs.png: Removed.
- inspector/front-end/Images/statusbarButtonGlyphs2x.png: Removed.
- inspector/front-end/Images/statusbarResizerHorizontal.png: Removed.
- inspector/front-end/Images/statusbarResizerVertical.png: Removed.
- inspector/front-end/Images/successGreenDot.png: Removed.
- inspector/front-end/Images/thumbActiveHoriz.png: Removed.
- inspector/front-end/Images/thumbActiveVert.png: Removed.
- inspector/front-end/Images/thumbHoriz.png: Removed.
- inspector/front-end/Images/thumbHoverHoriz.png: Removed.
- inspector/front-end/Images/thumbHoverVert.png: Removed.
- inspector/front-end/Images/thumbVert.png: Removed.
- inspector/front-end/Images/tickMark.png: Removed.
- inspector/front-end/Images/timelineHollowPillBlue.png: Removed.
- inspector/front-end/Images/timelineHollowPillGray.png: Removed.
- inspector/front-end/Images/timelineHollowPillGreen.png: Removed.
- inspector/front-end/Images/timelineHollowPillOrange.png: Removed.
- inspector/front-end/Images/timelineHollowPillPurple.png: Removed.
- inspector/front-end/Images/timelineHollowPillRed.png: Removed.
- inspector/front-end/Images/timelineHollowPillYellow.png: Removed.
- inspector/front-end/Images/timelinePillBlue.png: Removed.
- inspector/front-end/Images/timelinePillGray.png: Removed.
- inspector/front-end/Images/timelinePillGreen.png: Removed.
- inspector/front-end/Images/timelinePillOrange.png: Removed.
- inspector/front-end/Images/timelinePillPurple.png: Removed.
- inspector/front-end/Images/timelinePillRed.png: Removed.
- inspector/front-end/Images/timelinePillYellow.png: Removed.
- inspector/front-end/Images/toolbarIcons.png: Removed.
- inspector/front-end/Images/toolbarIconsSmall.png: Removed.
- inspector/front-end/Images/toolbarItemSelected.png: Removed.
- inspector/front-end/Images/trackHoriz.png: Removed.
- inspector/front-end/Images/trackVert.png: Removed.
- inspector/front-end/Images/treeDownTriangleBlack.png: Removed.
- inspector/front-end/Images/treeDownTriangleWhite.png: Removed.
- inspector/front-end/Images/treeRightTriangleBlack.png: Removed.
- inspector/front-end/Images/treeRightTriangleWhite.png: Removed.
- inspector/front-end/Images/treeUpTriangleBlack.png: Removed.
- inspector/front-end/Images/treeUpTriangleWhite.png: Removed.
- inspector/front-end/Images/userInputIcon.png: Removed.
- inspector/front-end/Images/userInputPreviousIcon.png: Removed.
- inspector/front-end/Images/userInputResultIcon.png: Removed.
- inspector/front-end/Images/warningIcon.png: Removed.
- inspector/front-end/Images/warningMediumIcon.png: Removed.
- inspector/front-end/Images/warningOrangeDot.png: Removed.
- inspector/front-end/Images/warningsErrors.png: Removed.
- inspector/front-end/IndexedDBModel.js: Removed.
- inspector/front-end/IndexedDBViews.js: Removed.
- inspector/front-end/InspectElementModeController.js: Removed.
- inspector/front-end/InspectorBackend.js: Removed.
- inspector/front-end/InspectorBackendCommands.qrc: Removed.
- inspector/front-end/InspectorFrontendAPI.js: Removed.
- inspector/front-end/InspectorFrontendHostStub.js: Removed.
- inspector/front-end/InspectorView.js: Removed.
- inspector/front-end/IsolatedFileSystem.js: Removed.
- inspector/front-end/IsolatedFileSystemManager.js: Removed.
- inspector/front-end/JSHeapSnapshot.js: Removed.
- inspector/front-end/JavaScriptFormatter.js: Removed.
- inspector/front-end/JavaScriptSourceFrame.js: Removed.
- inspector/front-end/KeyboardShortcut.js: Removed.
- inspector/front-end/Linkifier.js: Removed.
- inspector/front-end/LiveEditSupport.js: Removed.
- inspector/front-end/MemoryStatistics.js: Removed.
- inspector/front-end/MetricsSidebarPane.js: Removed.
- inspector/front-end/NativeBreakpointsSidebarPane.js: Removed.
- inspector/front-end/NativeHeapSnapshot.js: Removed.
- inspector/front-end/NativeMemoryGraph.js: Removed.
- inspector/front-end/NavigatorOverlayController.js: Removed.
- inspector/front-end/NavigatorView.js: Removed.
- inspector/front-end/NetworkItemView.js: Removed.
- inspector/front-end/NetworkLog.js: Removed.
- inspector/front-end/NetworkManager.js: Removed.
- inspector/front-end/NetworkPanel.js: Removed.
- inspector/front-end/NetworkPanelDescriptor.js: Removed.
- inspector/front-end/NetworkRequest.js: Removed.
- inspector/front-end/NetworkUISourceCodeProvider.js: Removed.
- inspector/front-end/Object.js: Removed.
- inspector/front-end/ObjectPopoverHelper.js: Removed.
- inspector/front-end/ObjectPropertiesSection.js: Removed.
- inspector/front-end/OverridesView.js: Removed.
- inspector/front-end/OverviewGrid.js: Removed.
- inspector/front-end/Panel.js: Removed.
- inspector/front-end/PanelEnablerView.js: Removed.
- inspector/front-end/ParsedURL.js: Removed.
- inspector/front-end/Placard.js: Removed.
- inspector/front-end/Popover.js: Removed.
- inspector/front-end/PresentationConsoleMessageHelper.js: Removed.
- inspector/front-end/ProfileDataGridTree.js: Removed.
- inspector/front-end/ProfileLauncherView.js: Removed.
- inspector/front-end/ProfilesPanel.js: Removed.
- inspector/front-end/ProfilesPanelDescriptor.js: Removed.
- inspector/front-end/Progress.js: Removed.
- inspector/front-end/ProgressIndicator.js: Removed.
- inspector/front-end/PropertiesSection.js: Removed.
- inspector/front-end/PropertiesSidebarPane.js: Removed.
- inspector/front-end/RawSourceCode.js: Removed.
- inspector/front-end/RemoteObject.js: Removed.
- inspector/front-end/RequestCookiesView.js: Removed.
- inspector/front-end/RequestHTMLView.js: Removed.
- inspector/front-end/RequestHeadersView.js: Removed.
- inspector/front-end/RequestJSONView.js: Removed.
- inspector/front-end/RequestPreviewView.js: Removed.
- inspector/front-end/RequestResponseView.js: Removed.
- inspector/front-end/RequestTimingView.js: Removed.
- inspector/front-end/RequestView.js: Removed.
- inspector/front-end/Resource.js: Removed.
- inspector/front-end/ResourceScriptMapping.js: Removed.
- inspector/front-end/ResourceTreeModel.js: Removed.
- inspector/front-end/ResourceType.js: Removed.
- inspector/front-end/ResourceUtils.js: Removed.
- inspector/front-end/ResourceView.js: Removed.
- inspector/front-end/ResourceWebSocketFrameView.js: Removed.
- inspector/front-end/ResourcesPanel.js: Removed.
- inspector/front-end/RevisionHistoryView.js: Removed.
- inspector/front-end/RuntimeModel.js: Removed.
- inspector/front-end/SASSSourceMapping.js: Removed.
- inspector/front-end/ScopeChainSidebarPane.js: Removed.
- inspector/front-end/Script.js: Removed.
- inspector/front-end/ScriptFormatter.js: Removed.
- inspector/front-end/ScriptFormatterWorker.js: Removed.
- inspector/front-end/ScriptSnippetModel.js: Removed.
- inspector/front-end/ScriptsNavigator.js: Removed.
- inspector/front-end/ScriptsPanel.js: Removed.
- inspector/front-end/ScriptsPanelDescriptor.js: Removed.
- inspector/front-end/ScriptsSearchScope.js: Removed.
- inspector/front-end/SearchController.js: Removed.
- inspector/front-end/Section.js: Removed.
- inspector/front-end/Settings.js: Removed.
- inspector/front-end/SettingsScreen.js: Removed.
- inspector/front-end/ShortcutsScreen.js: Removed.
- inspector/front-end/ShowMoreDataGridNode.js: Removed.
- inspector/front-end/SidebarOverlay.js: Removed.
- inspector/front-end/SidebarPane.js: Removed.
- inspector/front-end/SidebarTreeElement.js: Removed.
- inspector/front-end/SidebarView.js: Removed.
- inspector/front-end/SimpleWorkspaceProvider.js: Removed.
- inspector/front-end/SnippetJavaScriptSourceFrame.js: Removed.
- inspector/front-end/SnippetStorage.js: Removed.
- inspector/front-end/SoftContextMenu.js: Removed.
- inspector/front-end/SourceCSSTokenizer.js: Removed.
- inspector/front-end/SourceCSSTokenizer.re2js: Removed.
- inspector/front-end/SourceFrame.js: Removed.
- inspector/front-end/SourceHTMLTokenizer.js: Removed.
- inspector/front-end/SourceHTMLTokenizer.re2js: Removed.
- inspector/front-end/SourceJavaScriptTokenizer.js: Removed.
- inspector/front-end/SourceJavaScriptTokenizer.re2js: Removed.
- inspector/front-end/SourceMap.js: Removed.
- inspector/front-end/SourceMapping.js: Removed.
- inspector/front-end/SourceTokenizer.js: Removed.
- inspector/front-end/Spectrum.js: Removed.
- inspector/front-end/SplitView.js: Removed.
- inspector/front-end/StatusBarButton.js: Removed.
- inspector/front-end/StyleSheetOutlineDialog.js: Removed.
- inspector/front-end/StylesSidebarPane.js: Removed.
- inspector/front-end/StylesSourceMapping.js: Removed.
- inspector/front-end/SuggestBox.js: Removed.
- inspector/front-end/TabbedEditorContainer.js: Removed.
- inspector/front-end/TabbedPane.js: Removed.
- inspector/front-end/TestController.js: Removed.
- inspector/front-end/TextEditor.js: Removed.
- inspector/front-end/TextEditorHighlighter.js: Removed.
- inspector/front-end/TextEditorModel.js: Removed.
- inspector/front-end/TextPrompt.js: Removed.
- inspector/front-end/TextUtils.js: Removed.
- inspector/front-end/TimelineFrameController.js: Removed.
- inspector/front-end/TimelineGrid.js: Removed.
- inspector/front-end/TimelineManager.js: Removed.
- inspector/front-end/TimelineModel.js: Removed.
- inspector/front-end/TimelineOverviewPane.js: Removed.
- inspector/front-end/TimelinePanel.js: Removed.
- inspector/front-end/TimelinePanelDescriptor.js: Removed.
- inspector/front-end/TimelinePresentationModel.js: Removed.
- inspector/front-end/Toolbar.js: Removed.
- inspector/front-end/TopDownProfileDataGridTree.js: Removed.
- inspector/front-end/UISourceCode.js: Removed.
- inspector/front-end/UISourceCodeFrame.js: Removed.
- inspector/front-end/UIString.js: Removed.
- inspector/front-end/UIUtils.js: Removed.
- inspector/front-end/UglifyJS/parse-js.js: Removed.
- inspector/front-end/UserAgentSupport.js: Removed.
- inspector/front-end/UserMetrics.js: Removed.
- inspector/front-end/View.js: Removed.
- inspector/front-end/ViewportControl.js: Removed.
- inspector/front-end/WatchExpressionsSidebarPane.js: Removed.
- inspector/front-end/WebKit.qrc: Removed.
- inspector/front-end/WorkerManager.js: Removed.
- inspector/front-end/WorkersSidebarPane.js: Removed.
- inspector/front-end/Workspace.js: Removed.
- inspector/front-end/ace/LICENSE.txt: Removed.
- inspector/front-end/ace/ace.js: Removed.
- inspector/front-end/ace/acedevtools.css: Removed.
- inspector/front-end/ace/mode_css.js: Removed.
- inspector/front-end/ace/mode_html.js: Removed.
- inspector/front-end/ace/mode_javascript.js: Removed.
- inspector/front-end/ace/theme_textmate.js: Removed.
- inspector/front-end/auditsPanel.css: Removed.
- inspector/front-end/breadcrumbList.css: Removed.
- inspector/front-end/breakpointsList.css: Removed.
- inspector/front-end/buildSystemOnly.js: Removed.
- inspector/front-end/canvasProfiler.css: Removed.
- inspector/front-end/cm/LICENSE: Removed.
- inspector/front-end/cm/closebrackets.js: Removed.
- inspector/front-end/cm/cmdevtools.css: Removed.
- inspector/front-end/cm/codemirror.css: Removed.
- inspector/front-end/cm/codemirror.js: Removed.
- inspector/front-end/cm/css.js: Removed.
- inspector/front-end/cm/htmlmixed.js: Removed.
- inspector/front-end/cm/javascript.js: Removed.
- inspector/front-end/cm/matchbrackets.js: Removed.
- inspector/front-end/cm/xml.js: Removed.
- inspector/front-end/cssNamedFlows.css: Removed.
- inspector/front-end/dataGrid.css: Removed.
- inspector/front-end/dialog.css: Removed.
- inspector/front-end/elementsPanel.css: Removed.
- inspector/front-end/externs.js: Removed.
- inspector/front-end/filteredItemSelectionDialog.css: Removed.
- inspector/front-end/flameChart.css: Removed.
- inspector/front-end/heapProfiler.css: Removed.
- inspector/front-end/helpScreen.css: Removed.
- inspector/front-end/indexedDBViews.css: Removed.
- inspector/front-end/inspector.css: Removed.
- inspector/front-end/inspector.html: Removed.
- inspector/front-end/inspector.js: Removed.
- inspector/front-end/inspectorCommon.css: Removed.
- inspector/front-end/inspectorSyntaxHighlight.css: Removed.
- inspector/front-end/jsdifflib.js: Removed.
- inspector/front-end/navigatorView.css: Removed.
- inspector/front-end/networkLogView.css: Removed.
- inspector/front-end/networkPanel.css: Removed.
- inspector/front-end/panelEnablerView.css: Removed.
- inspector/front-end/popover.css: Removed.
- inspector/front-end/profilesPanel.css: Removed.
- inspector/front-end/resourceView.css: Removed.
- inspector/front-end/resourcesPanel.css: Removed.
- inspector/front-end/revisionHistory.css: Removed.
- inspector/front-end/scriptsPanel.css: Removed.
- inspector/front-end/sidebarPane.css: Removed.
- inspector/front-end/spectrum.css: Removed.
- inspector/front-end/splitView.css: Removed.
- inspector/front-end/tabbedPane.css: Removed.
- inspector/front-end/test-runner.html: Removed.
- inspector/front-end/textEditor.css: Removed.
- inspector/front-end/textPrompt.css: Removed.
- inspector/front-end/timelinePanel.css: Removed.
- inspector/front-end/treeoutline.js: Removed.
- inspector/front-end/utilities.js: Removed.
- 5:07 PM Changeset in webkit [157277] by
-
- 2 edits in trunk/LayoutTests
Add failing expectations to some tests on Mac Lion.
- platform/mac-lion/TestExpectations:
- 5:05 PM Changeset in webkit [157276] by
-
- 2 edits in trunk/Source/WebKit/win
Fix build.
- Interfaces/WebKit.idl:
Oops, didn't mean to remove the uuid for WebURLResponse.
- 5:05 PM Changeset in webkit [157275] by
-
- 7 edits2 deletes in trunk
Web Inspector: Remove the old front-end from WebKit
https://bugs.webkit.org/show_bug.cgi?id=122295
Patch by Marcelo Morais <m.morais@samsung.com> on 2013-10-10
Reviewed by Timothy Hatcher.
.:
- Source/PlatformGTK.cmake: Removed. This file was using files from the
old inspector, not needed anymore.
Source/WebCore:
Updating the project files to remove all references from the old
inspector front-end.
- WebCore.vcxproj/WebCore.vcxproj: Removed the references for the old
inspector front-end.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- inspector/compile-front-end.py: Removed.
Source/WebKit:
- PlatformBlackBerry.cmake: Removed the references for the old
inspector front-end.
- 5:01 PM Changeset in webkit [157274] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix with ENABLE_DEVICE_ORIENTATION after r157215
Now, impl() return reference instead of a pointer.
- bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::JSDeviceMotionEvent::acceleration):
(WebCore::JSDeviceMotionEvent::accelerationIncludingGravity):
(WebCore::JSDeviceMotionEvent::rotationRate):
(WebCore::JSDeviceMotionEvent::interval):
(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):
- bindings/js/JSDeviceOrientationEventCustom.cpp:
(WebCore::JSDeviceOrientationEvent::alpha):
(WebCore::JSDeviceOrientationEvent::beta):
(WebCore::JSDeviceOrientationEvent::gamma):
(WebCore::JSDeviceOrientationEvent::absolute):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):
- 4:56 PM Changeset in webkit [157273] by
-
- 10 edits1 add in trunk
[MediaStream API] update MediaStream object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121939
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-10
Reviewed by Jer Noble.
Source/WebCore:
Test: fast/mediastream/MediaStream-clone.html
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::ended):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::cloneMediaStreamTrackVector):
(WebCore::MediaStream::contextDestroyed):
(WebCore::MediaStream::scheduledEventTimerFired):
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStream.idl:
LayoutTests:
- TestExpectations:
- fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
- fast/mediastream/MediaStream-add-remove-tracks.html:
- fast/mediastream/MediaStream-clone.html: Added.
- fast/mediastream/MediaStreamConstructor-expected.txt:
- fast/mediastream/MediaStreamConstructor.html:
- 4:51 PM Changeset in webkit [157272] by
-
- 2 edits in trunk/Source/WebCore
Calling setUsePresentationValue on MountainLion results in unrecognized selector
warnings
https://bugs.webkit.org/show_bug.cgi?id=122624
Reviewed by Tim Horton.
Only call setUsePresentationValue if the scrollbar supports updates on a secondary
thread.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
- 4:34 PM Changeset in webkit [157271] by
-
- 2 edits in trunk/Source/WebCore
Validate uniform input when setting texture sampler uniforms.
https://bugs.webkit.org/show_bug.cgi?id=122610.
Reviewed by Dean Jackson.
Covered by Khronos Conformance Suite 1.0.2.
Specifically, conformance/uniforms/uniform-samplers-test.html.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::uniform1i):
(WebCore::WebGLRenderingContext::uniform1iv):
- 4:31 PM Changeset in webkit [157270] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r157250
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
- 4:20 PM Changeset in webkit [157269] by
-
- 22 edits in trunk/Source/WebInspectorUI
Web Inspector: content views and managers should save/restore view state.
https://bugs.webkit.org/show_bug.cgi?id=122546
To restore the same content view and sidebars when re-opening the
inspector, a cookie is saved whenever a new content view is shown
in the main content browser. Previously, this cookie was created
and restored using navigation sidebar-specific logic. This has two
major flaws: non-default sidebars for a represented object are not
restored correctly; and it centralizes storage of view-specific
state such as subview selections.
This patch adds ContentView methods for saving a key for the
view's represented object, and saving/restoring any view-specific
state as the view is shown. The 'type' field of the cookie
specifies the manager which deserializes the cookie into a
represented object.
Patch by Brian J. Burg <Brian Burg> on 2013-10-10
Reviewed by Timothy Hatcher.
- UserInterface/ApplicationCacheFrameContentView.js:
(WebInspector.ApplicationCacheFrameContentView):
(WebInspector.ApplicationCacheFrameContentView.prototype.saveToCookie):
(WebInspector.ApplicationCacheFrameContentView.prototype._maybeUpdate):
(WebInspector.ApplicationCacheFrameContentView.prototype._updateStatus):
(WebInspector.ApplicationCacheFrameContentView.prototype.updateStatus):
(WebInspector.ApplicationCacheFrameContentView.prototype._updateCallback):
- UserInterface/ApplicationCacheManager.js:
(WebInspector.ApplicationCacheManager.prototype.networkStateUpdated):
(WebInspector.ApplicationCacheManager.prototype.applicationCacheStatusUpdated):
(WebInspector.ApplicationCacheManager.prototype.):
(WebInspector.ApplicationCacheManager.prototype.requestApplicationCache):
(WebInspector.ApplicationCacheManager.prototype.objectForCookie):
(WebInspector.ApplicationCacheManager.prototype._manifestForFrameLoaded):
(WebInspector.ApplicationCacheManager.prototype._framesWithManifestsLoaded):
(WebInspector.ApplicationCacheManager.prototype._frameManifestUpdated):
- UserInterface/BackForwardEntry.js:
(WebInspector.BackForwardEntry):
(WebInspector.BackForwardEntry.prototype._restoreFromCookie):
- UserInterface/ContentBrowser.js:
(WebInspector.ContentBrowser.prototype.showContentViewForRepresentedObject):
(WebInspector.ContentBrowser.prototype.showContentView):
- UserInterface/ContentView.js:
(WebInspector.ContentView.prototype.saveToCookie):
(WebInspector.ContentView.prototype.restoreFromCookie):
- UserInterface/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.showContentView):
- UserInterface/CookieStorageContentView.js:
(WebInspector.CookieStorageContentView.prototype.update):
(WebInspector.CookieStorageContentView.prototype.saveToCookie):
(WebInspector.CookieStorageContentView.prototype._rebuildTable):
(WebInspector.CookieStorageContentView.prototype._filterCookies):
- UserInterface/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView.prototype.saveToCookie):
- UserInterface/DatabaseContentView.js:
(WebInspector.DatabaseContentView.prototype.saveToCookie):
(WebInspector.DatabaseContentView.prototype._messagesClicked):
- UserInterface/DatabaseTableContentView.js:
(WebInspector.DatabaseTableContentView):
(WebInspector.DatabaseTableContentView.prototype.saveToCookie):
- UserInterface/FrameContentView.js:
(WebInspector.FrameContentView.prototype.saveToCookie):
(WebInspector.FrameContentView.prototype.restoreFromCookie):
- UserInterface/FrameResourceManager.js:
(WebInspector.FrameResourceManager.prototype.objectForCookie):
- UserInterface/InstrumentSidebarPanel.js:
(WebInspector.InstrumentSidebarPanel):
(WebInspector.InstrumentSidebarPanel.prototype.showTimeline):
(WebInspector.InstrumentSidebarPanel.prototype.shown):
(WebInspector.InstrumentSidebarPanel.prototype._timelinesTreeElementSelected):
- UserInterface/Main.js:
(WebInspector.loaded):
(WebInspector.contentLoaded):
(WebInspector.openURL):
(WebInspector._updateCurrentContentViewCookie):
(WebInspector._showContentViewForCookie.lastAttemptToRestoreFromCookie):
(WebInspector._showContentViewForCookie):
(WebInspector._resolveAndShowPendingContentViewCookie.delayedWork):
(WebInspector._resolveAndShowPendingContentViewCookie):
(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.createMessageTextView):
(WebInspector.linkifyStringAsFragment):
- UserInterface/NavigationSidebarPanel.js:
- UserInterface/ResourceClusterContentView.js:
(WebInspector.ResourceClusterContentView.prototype.saveToCookie):
(WebInspector.ResourceClusterContentView.prototype.restoreFromCookie):
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.showSourceCode):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
(WebInspector.ResourceSidebarPanel.prototype._domStorageObjectWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._databaseWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._cookieStorageObjectWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._frameManifestAdded):
- UserInterface/ScriptContentView.js:
(WebInspector.ScriptContentView.prototype.saveToCookie):
(WebInspector.ScriptContentView.prototype.restoreFromCookie):
- UserInterface/StorageManager.js:
(WebInspector.StorageManager.prototype.findMatchingObjectInArray):
(WebInspector.StorageManager.prototype.objectForCookie):
- UserInterface/TimelineManager.js:
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.get timelines):
(WebInspector.TimelineManager.prototype.objectForCookie):
- UserInterface/TimelinesContentView.js:
(WebInspector.TimelinesContentView.prototype.saveToCookie):
(WebInspector.TimelinesContentView.prototype.restoreFromCookie):
(WebInspector.TimelinesContentView.prototype._makeColumnScopeBar):
- 4:17 PM Changeset in webkit [157268] by
-
- 8 edits1 add in trunk
Create MediaStream object with ended attribute set if all tracks that are being used on its creation are ended
https://bugs.webkit.org/show_bug.cgi?id=122358
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-10
Reviewed by Jer Noble.
Source/WebCore:
Spec tells that if all tracks that belongs to a new MediaStream object being created are ended,
then the ended attribute of this MediaStream must be set to true.
http://www.w3.org/TR/mediacapture-streams/#widl-MediaStream-ended
Since there is no port supporting MediaStream yet, we are skipping this test for now.
Test: fast/mediastream/MediaStream-construct-with-ended-tracks.html
- Modules/mediastream/MediaStream.cpp:
(WebCore::createFromSourceVectors):
(WebCore::MediaStream::create):
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
- platform/mediastream/MediaStreamDescriptor.h:
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::MockMediaStreamCenter::createMediaStream):
LayoutTests:
Since there is no port supporting MediaStream yet, we are skipping this test for now.
- TestExpectations:
- fast/mediastream/MediaStream-construct-with-ended-tracks.html: Added.
- 4:16 PM Changeset in webkit [157267] by
-
- 13 edits in trunk
Further improve ArrayIterator performance
https://bugs.webkit.org/show_bug.cgi?id=122575
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
Add an assembly thunk for ArrayIterator.@@next so that we
can avoid marshalling costs when iterating arrays.
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::loadSpecificClassArgument):
- jit/ThunkGenerators.cpp:
(JSC::arrayIteratorNextThunkGenerator):
- jit/ThunkGenerators.h:
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
- runtime/Intrinsic.h:
- runtime/JSArrayIterator.h:
(JSC::JSArrayIterator::offsetOfIterationKind):
(JSC::JSArrayIterator::offsetOfIteratedObject):
(JSC::JSArrayIterator::offsetOfNextIndex):
- runtime/JSCJSValue.h:
(JSC::JSValue::offsetOfPayload):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::iteratorResultStructureOffset):
- runtime/VM.cpp:
(JSC::thunkGeneratorForIntrinsic):
LayoutTests:
Add a few new tests to make sure the new asm thunk correctly
handles non-arrays.
- js/array-iterators-expected.txt:
- js/script-tests/array-iterators.js:
- 4:10 PM Changeset in webkit [157266] by
-
- 17 edits in trunk
transition cti_op_* methods returning int to JIT operations.
https://bugs.webkit.org/show_bug.cgi?id=122563
Reviewed by Oliver Hunt.
Moved serveral operationCompare* functions from DFGOperations to JITOperations as well as changing
dfgConvertJSValueToBoolean to operationConvertJSValueToBoolean so that they can be shared with the baseline JIT.
Added JITOperation operationHasProperty(). Added needed callOperation helpers and transitioned baseline JIT code
to use the new operations.
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jlesseq):
(JSC::JIT::emitSlow_op_jgreater):
(JSC::JIT::emitSlow_op_jgreatereq):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitSlow_op_jngreater):
(JSC::JIT::emitSlow_op_jngreatereq):
(JSC::JIT::emit_compareAndJumpSlow):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareAndJumpSlow):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_next_pname):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 4:05 PM Changeset in webkit [157265] by
-
- 16 edits2 adds in trunk
Add SPI for telling WebKit to prefer pictograph glyphs over monochrome ones
https://bugs.webkit.org/show_bug.cgi?id=122608
Reviewed by Dan Bernstein.
Based on patches by Dan Bernstein.
Source/WebCore:
Test: fonts/font-fallback-prefers-pictographs.html
Created a mechanism to append a font to the end of a font's fallback
list, before the system fallback list. This mechanism is used when
Settings::fontFallbackPrefersPictographs() is true to insert a
pictograph font ahead of a monochrome one from the system fallback list.
- WebCore.exp.in: Moved
ZN7WebCore8Settings33setFontFallbackPrefersPictographsEb outside of
an iOS platform guard.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::fallbackFontDataCount): Retuned 1 if
pictograph fonts are preferred.
(WebCore::CSSFontSelector::getFallbackFontData): Returned the
pictograph font's FontData if it is preferred.
- css/CSSFontSelector.h:
- page/Settings.cpp:
(WebCore::Settings::Settings): Initialized
m_fontFallbackPrefersPictographs to false.
(WebCore::Settings::setFontFallbackPrefersPictographs): Set
m_fontFallbackPrefersPictographs and called
Page::setNeedsRecalcStyleInAllFrames().
- page/Settings.h:
(WebCore::Settings::fontFallbackPrefersPictographs):
- platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::realizeFontDataAt): Realized the selector's
fallback font if necessary.
- platform/graphics/FontSelector.h:
- style/StyleResolveTree.cpp:
(WebCore::Style::resolveTree): Removed iOS platform guards.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setFontFallbackPrefersPictographs): Set the
corresponding WebCore::Setting.
- testing/InternalSettings.h: Defined an internal setting for the test.
- testing/InternalSettings.idl: Ditto.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _setFontFallbackPrefersPictographs:]): Called
WebCore::Settings::setFontFallbackPrefersPictographs().
- WebView/WebViewPrivate.h:
LayoutTests:
- fonts/font-fallback-prefers-pictographs-expected.html: Added.
- fonts/font-fallback-prefers-pictographs.html: Added.
- 3:57 PM Changeset in webkit [157264] by
-
- 24 edits2 adds in trunk/Source/JavaScriptCore
OSR exit using llvm.webkit.stackmap should pass more tests
https://bugs.webkit.org/show_bug.cgi?id=122518
Reviewed by Mark Hahnenberg.
- Make the X86Assembler capable of dealing with all XMM registers.
- Make the StackMaps code on WebKit's side capable of dealing with XMM registers.
- Factor out most of the smarts of StackMaps::Location into a self-contained object. Previously you needed both StackMaps::Location and a StackMaps reference to do most things since the Location might have referred to a constant. Now you can just get a self-contained Location object.
- Fix a bug where OSR exit generation thunk generator was assuming that the call frame register is already in argumentGPR0. In the future, the call frame will just be the machine FP and we won't have to do anything special. But for now the "call frame" is just a normal value in LLVM IR and may end up in any register. Make the OSR exit generation thunk generator polymorphic over the call frame argument's Location.
- Move the stuff that depends on the polymorphic OSR exit generation thunk generator into the finalizer, since generating and linking one of those thunks requires a cache flush and we need to do that on the main thread.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::firstRegister):
(JSC::ARMv7Assembler::lastRegister):
(JSC::ARMv7Assembler::firstFPRegister):
(JSC::ARMv7Assembler::lastFPRegister):
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::firstFPRegister):
(JSC::AbstractMacroAssembler::lastFPRegister):
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::nextFPRegister):
- assembler/MacroAssemblerARMv7.h:
- assembler/MacroAssemblerX86Common.h:
- assembler/X86Assembler.h:
(JSC::X86Assembler::firstFPRegister):
(JSC::X86Assembler::lastFPRegister):
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLExitThunkGenerator.cpp:
(JSC::FTL::ExitThunkGenerator::emitThunk):
(JSC::FTL::ExitThunkGenerator::emitThunks):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h:
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLocation.cpp: Added.
(JSC::FTL::Location::forStackmaps):
(JSC::FTL::Location::dump):
(JSC::FTL::Location::involvesGPR):
(JSC::FTL::Location::isGPR):
(JSC::FTL::Location::gpr):
(JSC::FTL::Location::isFPR):
(JSC::FTL::Location::fpr):
(JSC::FTL::Location::restoreInto):
(WTF::printInternal):
- ftl/FTLLocation.h: Added.
(JSC::FTL::Location::Location):
(JSC::FTL::Location::forRegister):
(JSC::FTL::Location::forIndirect):
(JSC::FTL::Location::forConstant):
(JSC::FTL::Location::kind):
(JSC::FTL::Location::hasDwarfRegNum):
(JSC::FTL::Location::dwarfRegNum):
(JSC::FTL::Location::hasOffset):
(JSC::FTL::Location::offset):
(JSC::FTL::Location::hasConstant):
(JSC::FTL::Location::constant):
(JSC::FTL::Location::operator!):
(JSC::FTL::Location::isHashTableDeletedValue):
(JSC::FTL::Location::operator==):
(JSC::FTL::Location::hash):
(JSC::FTL::LocationHash::hash):
(JSC::FTL::LocationHash::equal):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):
- ftl/FTLSaveRestore.cpp:
(JSC::FTL::bytesForFPRs):
(JSC::FTL::requiredScratchMemorySizeInBytes):
(JSC::FTL::offsetOfFPR):
(JSC::FTL::saveAllRegisters):
(JSC::FTL::restoreAllRegisters):
- ftl/FTLSaveRestore.h:
- ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::Location::restoreInto):
- ftl/FTLStackMaps.h:
- ftl/FTLState.h:
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationWithoutStackMapThunkGenerator):
(JSC::FTL::osrExitGenerationWithStackMapThunkGenerator):
- ftl/FTLThunks.h:
(JSC::FTL::generateIfNecessary):
(JSC::FTL::Thunks::getOSRExitGenerationThunk):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 3:56 PM Changeset in webkit [157263] by
-
- 9 edits4 deletes in trunk/Source/WebKit
Remove WebScrollBar
https://bugs.webkit.org/show_bug.cgi?id=122623
Reviewed by Brent Fulgham.
Source/WebKit:
Remove files from VS projects.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters:
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
Source/WebKit/win:
WebScrollBar isn't used by anyone, remove it.
- ForEachCoClass.h:
- Interfaces/IWebScrollBarDelegatePrivate.idl: Removed.
- Interfaces/IWebScrollBarPrivate.idl: Removed.
- Interfaces/WebKit.idl:
- WebKitClassFactory.cpp:
(WebKitClassFactory::CreateInstance):
- WebScrollBar.cpp: Removed.
- WebScrollBar.h: Removed.
- 3:39 PM Changeset in webkit [157262] by
-
- 5 edits in trunk
Tools: Make sure that DataTypes.h is in the binary drop.
Rubber stamped by Michael Saboff.
- Scripts/export-llvm-build:
WebKitLibraries: Update the binary drops to the latest version of LLVM, built without -fvisibility=hidden
now that we have soft linking. Also include DataTypes.h in the drop.
Rubber stamped by Michael Saboff.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 3:27 PM Changeset in webkit [157261] by
-
- 2 edits in trunk/Source/WebKit/win
Build fix after http://trac.webkit.org/changeset/157253
- WebScrollBar.h:
- 3:19 PM Changeset in webkit [157260] by
-
- 24 edits16 adds2 deletes in trunk
FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
https://bugs.webkit.org/show_bug.cgi?id=122566
Source/JavaScriptCore:
Reviewed by Mark Rowe.
The JSC project now builds a libllvmForJSC.dylib. If FTL is enabled, this
gets copied into JavaScriptCore.framework/Versions/A/Libraries. JSC will
load the dylib by finding it using NSBundle APIs and then doing dlopen().
That will only happen lazily, when something happens that requires LLVM.
This mostly takes care of LLVM static initialization overhead by deferring
it until it's really needed.
This takes care of LLVM's exit-time destructors because inside
libllvmForJSC.dylib, we override cxa_atexit.
- Configurations/JavaScriptCore.xcconfig:
- Configurations/LLVMForJSC.xcconfig: Added.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- disassembler/LLVMDisassembler.cpp:
(JSC::tryToDisassembleWithLLVM):
- ftl/FTLAbbreviatedTypes.h:
- ftl/FTLAbbreviations.h:
(JSC::FTL::voidType):
(JSC::FTL::int1Type):
(JSC::FTL::int8Type):
(JSC::FTL::int16Type):
(JSC::FTL::int32Type):
(JSC::FTL::int64Type):
(JSC::FTL::intPtrType):
(JSC::FTL::floatType):
(JSC::FTL::doubleType):
(JSC::FTL::pointerType):
(JSC::FTL::structType):
(JSC::FTL::functionType):
(JSC::FTL::typeOf):
(JSC::FTL::mdKindID):
(JSC::FTL::mdString):
(JSC::FTL::mdNode):
(JSC::FTL::setMetadata):
(JSC::FTL::addFunction):
(JSC::FTL::setLinkage):
(JSC::FTL::setFunctionCallingConv):
(JSC::FTL::getParam):
(JSC::FTL::constInt):
(JSC::FTL::constReal):
(JSC::FTL::constIntToPtr):
(JSC::FTL::constBitCast):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildPhi):
(JSC::FTL::addIncoming):
(JSC::FTL::buildAlloca):
(JSC::FTL::buildAdd):
(JSC::FTL::buildSub):
(JSC::FTL::buildMul):
(JSC::FTL::buildDiv):
(JSC::FTL::buildRem):
(JSC::FTL::buildNeg):
(JSC::FTL::buildFAdd):
(JSC::FTL::buildFSub):
(JSC::FTL::buildFMul):
(JSC::FTL::buildFDiv):
(JSC::FTL::buildFRem):
(JSC::FTL::buildFNeg):
(JSC::FTL::buildAnd):
(JSC::FTL::buildOr):
(JSC::FTL::buildXor):
(JSC::FTL::buildShl):
(JSC::FTL::buildAShr):
(JSC::FTL::buildLShr):
(JSC::FTL::buildNot):
(JSC::FTL::buildLoad):
(JSC::FTL::buildStore):
(JSC::FTL::buildSExt):
(JSC::FTL::buildZExt):
(JSC::FTL::buildFPToSI):
(JSC::FTL::buildFPToUI):
(JSC::FTL::buildSIToFP):
(JSC::FTL::buildUIToFP):
(JSC::FTL::buildIntCast):
(JSC::FTL::buildFPCast):
(JSC::FTL::buildIntToPtr):
(JSC::FTL::buildPtrToInt):
(JSC::FTL::buildBitCast):
(JSC::FTL::buildICmp):
(JSC::FTL::buildFCmp):
(JSC::FTL::buildCall):
(JSC::FTL::setTailCall):
(JSC::FTL::buildExtractValue):
(JSC::FTL::buildSelect):
(JSC::FTL::buildBr):
(JSC::FTL::buildCondBr):
(JSC::FTL::buildSwitch):
(JSC::FTL::addCase):
(JSC::FTL::buildRet):
(JSC::FTL::buildUnreachable):
(JSC::FTL::dumpModule):
(JSC::FTL::verifyModule):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLFail.cpp:
(JSC::FTL::fail):
- ftl/FTLJITCode.h:
- ftl/FTLJITFinalizer.h:
- ftl/FTLLink.cpp:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
- ftl/FTLOutput.cpp:
(JSC::FTL::Output::Output):
(JSC::FTL::Output::~Output):
- ftl/FTLOutput.h:
(JSC::FTL::Output::appendTo):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
(JSC::FTL::State::~State):
- ftl/WebKitLLVMLibraryAnchor.cpp: Removed.
- jsc.cpp:
(jscmain):
- llvm: Added.
- llvm/InitializeLLVM.cpp: Added.
(JSC::initializeLLVM):
- llvm/InitializeLLVM.h: Added.
- llvm/InitializeLLVMMac.mm: Added.
(JSC::initializeLLVMImpl):
- llvm/InitializeLLVMPOSIX.cpp: Added.
(JSC::initializeLLVMPOSIX):
- llvm/InitializeLLVMPOSIX.h: Added.
- llvm/LLVMAPI.cpp: Added.
- llvm/LLVMAPI.h: Added.
- llvm/LLVMAPIFunctions.h: Added.
- llvm/LLVMHeaders.h: Added.
- llvm/library: Added.
- llvm/library/LLVMAnchor.cpp: Added.
- llvm/library/LLVMExports.cpp: Added.
(initializeAndGetJSCLLVMAPI):
- llvm/library/LLVMOverrides.cpp: Added.
(cxa_atexit):
- llvm/library/config_llvm.h: Added.
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/Options.h:
Source/WTF:
Reviewed by Mark Rowe.
Remove all LLVM stuff from WTF since to get LLVM you need to soft-link and it's
entirely the responsibility of JSC to do that.
Also fixed an export goof that I found after fixing the weak thingy script in JSC.
- WTF.xcodeproj/project.pbxproj:
- wtf/LLVMHeaders.h: Removed.
- wtf/text/CString.h:
(WTF::CStringHash::hash):
Tools:
Reviewed by Mark Rowe.
- Scripts/configure-llvm:
- 3:16 PM Changeset in webkit [157259] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Add timeout annotation to gtk-wk2-specific expectation for
editing/spelling/spellcheck-paste.html.
- platform/gtk-wk2/TestExpectations:
- 3:03 PM Changeset in webkit [157258] by
-
- 3 edits in trunk/Source/JavaScriptCore
currentThis and currentArguments crash if called from outside a callback
https://bugs.webkit.org/show_bug.cgi?id=122620
Reviewed by Filip Pizlo.
The documentation for these methods claims that they will return nil if called
from somewhere other than an API callback, but currently they both crash.
- API/JSContext.mm:
(+[JSContext currentThis]):
(+[JSContext currentArguments]):
- API/tests/testapi.mm:
- 3:00 PM Changeset in webkit [157257] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Fix changelog entry order.
- 2:59 PM Changeset in webkit [157256] by
-
- 2 edits in trunk/Source/JavaScriptCore
CallbackData unnecessarily caches the JSValue for currentThis
https://bugs.webkit.org/show_bug.cgi?id=122616
Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2013-10-10
Reviewed by Oliver Hunt.
CallbackData implements its own version of caching the JSValue* for the JSValueRef it stores.
+[JSValue valueWithJSValueRef:inContext:] already does caching, thus obviating the need for
CallbackData to do its own caching.
- API/JSContext.mm:
(+[JSContext currentThis]):
(-[JSContext beginCallbackWithData:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):
- API/JSContextInternal.h:
- 2:50 PM Changeset in webkit [157255] by
-
- 2 edits in trunk/Source/WebCore
Remove unused attribute in CoordinatedTile class
https://bugs.webkit.org/show_bug.cgi?id=122619
Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Noam Rosenthal.
No new tests, covered by existing ones.
- platform/graphics/texmap/coordinated/CoordinatedTile.h: Remove
m_localBuffer.
- 2:47 PM Changeset in webkit [157254] by
-
- 5 edits5 adds in trunk/Source/WebKit2
[WK2][Soup] Add platform specific stubs for NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=110115
Reviewed by Carlos Garcia Campos.
Original patch by Balazs Kelemen <kbalazs@webkit.org> and Kwang Yul Seo <skyul@company100.net>.
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- NetworkProcess/gtk/NetworkProcessSoup.cpp: Added.
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::platformSetCacheModel):
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
Stubs.
(WebKit::NetworkProcess::clearCacheForAllOrigins):
(WebKit::NetworkProcess::platformTerminate):
- NetworkProcess/soup/NetworkResourceLoadSchedulerSoup.cpp: Added.
(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost):
Added platform default based on the comment in ResourceRequestSoup.cpp.
- UIProcess/Network/soup/NetworkProcessProxySoup.cpp: Added.
(WebKit::NetworkProcessProxy::platformGetLaunchOptions):
Stub.
- UIProcess/soup/WebContextSoup.cpp: Added.
(WebKit::WebContext::platformInitializeNetworkProcess):
Stub.
- 2:44 PM Changeset in webkit [157253] by
-
- 28 edits in trunk/Source
Scrollbars are updated on the main thread rather than the scrolling thread
(causing scroll bars not to appear/update quickly in some cases)
https://bugs.webkit.org/show_bug.cgi?id=122585
-and corresponding-
<rdar://problem/10710775>
Reviewed by Simon Fraser.
Source/WebCore:
This patch does a few things in order to allow scrollbars to be updated on the
scrolling thread:
- This patch adds the ability to know if the lower-level APIs necessary to get
this to work right are available, AND if the content is actually capable of taking
advantage of this feature. This is currently implemented as
Scrollbar::supportsUpdateOnSecondaryThread() which makes use of a new
ScrollableArea function called updatesScrollLayerPositionOnMainThread()
- To update on the scrolling thread, the scrolling tree needs to know about the
ScrollbarPainters.
- Once it knows about them, it should update the presentation value whenever the
layer position changes.
- Presentation value is basically the same thing as double value. There is a bit
of code we maintain currently to compute that. This patch moves that code to a
static function on ScrollableArea that can be called from both the main thread and
the scrolling thread.
- ScrollbarPainter API needs to know about the layers we have created for the
vertical and horizontal scrollbars, then they will use those layers and the
presentation value that we set on the scrolling thread to move the layers around.
This is part of #1 above.
- page/FrameView.cpp:
(WebCore::FrameView::updatesScrollLayerPositionOnMainThread):
- page/FrameView.h:
This is part of #2. ScrollingStateScrollingNodes now have vertical and horizontal
ScrollbarPainters for Mac only.
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::ScrollingStateScrollingNode::verticalScrollbarPainter):
(WebCore::ScrollingStateScrollingNode::horizontalScrollbarPainter):
Also part of #2. Make sure to set the ScrollbarPainters for scrolling nodes when
appropriate.
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
Implement this function that was just stubbed out before. This is part of #5 in
that is will allow the ScrollbarPainter API to know about any layer changes.
(WebCore::ScrollingCoordinatorMac::scrollableAreaScrollbarLayerDidChange):
Back to #2, making sure we properly set the ScrollbarPainters to send over to the
scrolling thread.
(WebCore::ScrollingCoordinatorMac::setScrollbarPaintersForNode):
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
(WebCore::ScrollingStateScrollingNode::setScrollbarPainters):
This code achieves #3. It uses new ScrollbarPainter API to adjust the position of
the scrollbars from the scrolling thread.
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):
(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
This is for #5. ScrollbarPainter needs to know about our scrollbar layers.
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::verticalScrollbarLayerDidChange):
(WebCore::ScrollAnimator::horizontalScrollbarLayerDidChange):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::verticalScrollbarLayerDidChange):
(WebCore::ScrollableArea::horizontalScrollbarLayerDidChange):
This is for #4. This code computes the scrollbar’s value and current overhang
amount.
(WebCore::ScrollableArea::computeScrollbarValueAndOverhang):
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::layerForHorizontalScrollbar):
(WebCore::ScrollableArea::layerForVerticalScrollbar):
(WebCore::ScrollableArea::layerForScrolling):
This is for #1. We need to know if we have the ability to update scrollbars on a
different thread. We can do that only on certain versions of the OS, only when
threaded scrolling is enabled, and only when the current page is actually using
the scrolling thread to scroll.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::supportsUpdateOnSecondaryThread):
- platform/Scrollbar.h:
- platform/ScrollbarThemeClient.h:
New ScrollbarPainter APIs.
- platform/mac/NSScrollerImpDetails.h:
This is for #5, letting the ScrollbarPainter API know about the layers.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate convertRectToLayer:]):
(-[WebScrollbarPainterDelegate shouldUseLayerPerPartForScrollerImp:]):
Before we kick off a scroll animation, set the current painting characteristics so
they are up-to-date in case we are scrolling on the scrolling thread.
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::verticalScrollbarLayerDidChange):
(WebCore::ScrollAnimatorMac::horizontalScrollbarLayerDidChange):
Only paint the scrollbars through ScrollbarThemeMac if they are NOT being updated
by the scrolling thread.
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::setCurrentPaintCharacteristics):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):
Back to #1.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updatesScrollLayerPositionOnMainThread):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
- rendering/RenderListBox.h:
Source/WebKit2:
New pure virtual function.
- WebProcess/Plugins/PDF/PDFPlugin.h:
- 2:34 PM Changeset in webkit [157252] by
-
- 6 edits in trunk/Source/WebCore
[Win] Unreviewed build fix after r157228
The changes in r157228 trigger a bug in VS2010. This patch works around the compiler bug
to allow this platform to build.
- dom/Range.cpp: Move implementation to header file.
- dom/Range.h: Inline the method.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::open): Add stub method (with pointer arguments) to call the real
method with references.
- page/DOMWindow.h: Declare stub method taking pointer arguments to avoid compiler bug.
- testing/Internals.cpp:
(WebCore::Internals::openDummyInspectorFrontend): Use work-around method when building under
the buggy version of Visual Studio.
- 2:34 PM Changeset in webkit [157251] by
-
- 4 edits1 move2 adds in trunk/Source/WebKit2
[WK2] Port RemoteNetworkingContext for Soup
https://bugs.webkit.org/show_bug.cgi?id=110097
Reviewed by Darin Adler.
Original patch by Balazs Kelemen <kbalazs@webkit.org> and Kwang Yul Seo <skyul@company100.net>.
This should be a cross-platform interface so I lifted the header from
the mac directory. Removed mac specific arguments from constructor,
added setters instead. Moved platform things behind ifdefs and added
Soup specific bits.
The following things were fixed by Csaba Osztrogonác:
- solved conflicts in project.pbxproj
- removed the change in the non-existent SyncNetworkResourceLoader.cpp
- marked RemoteNetworkingContext class as FINAL
- reordered the members for platform specific initialization
- added initializers to m_needsSiteSpecificQuirks and m_localFileContentSniffingEnabled members on PLATFORM(MAC)
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::start):
- NetworkProcess/RemoteNetworkingContext.h: Renamed from Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.h.
(WebKit::RemoteNetworkingContext::create):
(WebKit::RemoteNetworkingContext::RemoteNetworkingContext):
(WebKit::RemoteNetworkingContext::setNeedsSiteSpecificQuirks):
(WebKit::RemoteNetworkingContext::setLocalFileContentSniffingEnabled):
- NetworkProcess/mac/RemoteNetworkingContext.mm:
- NetworkProcess/soup/RemoteNetworkingContextSoup.cpp: Added.
(WebKit::RemoteNetworkingContext::~RemoteNetworkingContext):
(WebKit::RemoteNetworkingContext::isValid):
(WebKit::RemoteNetworkingContext::initiatingPageID):
(WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::privateBrowsingSession):
- WebKit2.xcodeproj/project.pbxproj:
- 2:11 PM Changeset in webkit [157250] by
-
- 3 edits in trunk/Source/WebCore
Make all functions of EventDispatcher static
https://bugs.webkit.org/show_bug.cgi?id=122591
Reviewed by Antti Koivisto.
Now that EventDispatchMediator is gone, we don't have to have an EventDispatcher object.
Turn EventDispatcher into an empty class with a bunch of static functions.
We can convert it to a namespace or whatever later.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatchEvent):
- dom/EventDispatcher.h:
- 1:50 PM Changeset in webkit [157249] by
-
- 3 edits in trunk/Source/JavaScriptCore
CallbackData unnecessarily caches the JSValue for currentThis
https://bugs.webkit.org/show_bug.cgi?id=122616
Reviewed by Oliver Hunt.
CallbackData implements its own version of caching the JSValue* for the JSValueRef it stores.
+[JSValue valueWithJSValueRef:inContext:] already does caching, thus obviating the need for
CallbackData to do its own caching.
- API/JSContext.mm:
(+[JSContext currentThis]):
(-[JSContext beginCallbackWithData:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):
- API/JSContextInternal.h:
- 1:42 PM Changeset in webkit [157248] by
-
- 14 edits in trunk/Source
Convert some OwnPtr/PassOwnPtr in CoordinatedGraphics code to std::unique_ptr's
https://bugs.webkit.org/show_bug.cgi?id=122614
Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests, covered by existing ones.
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::paintToSurface):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::adjustContentsScale):
(WebCore::CoordinatedGraphicsLayer::createBackingStore):
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::createLayer):
(WebCore::CoordinatedGraphicsScene::deleteLayer):
(WebCore::CoordinatedGraphicsScene::ensureRootLayer):
(WebCore::CoordinatedGraphicsScene::purgeGLResources):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:
(WebCore::ThreadSafeCoordinatedSurface::ThreadSafeCoordinatedSurface):
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h:
- platform/graphics/texmap/coordinated/UpdateAtlas.cpp:
(WebCore::UpdateAtlas::buildLayoutIfNeeded):
(WebCore::UpdateAtlas::didSwapBuffers):
- platform/graphics/texmap/coordinated/UpdateAtlas.h:
(WebCore::UpdateAtlas::isInUse):
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 1:15 PM Changeset in webkit [157247] by
-
- 4 edits in trunk/Source/WebCore
Store uniform type information in WebGLUniformationLocation.
https://bugs.webkit.org/show_bug.cgi?id=122607.
Reviewed by Dean Jackson.
Covered by Khronos Conformance Suite 1.0.2.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::getUniformLocation):
- html/canvas/WebGLUniformLocation.cpp:
(WebCore::WebGLUniformLocation::create):
(WebCore::WebGLUniformLocation::WebGLUniformLocation):
(WebCore::WebGLUniformLocation::type):
- html/canvas/WebGLUniformLocation.h:
- 1:05 PM Changeset in webkit [157246] by
-
- 14 edits in trunk/LayoutTests
Web Inspector: Remove the old front-end from WebKit
https://bugs.webkit.org/show_bug.cgi?id=122295
Patch by Marcelo Morais <m.morais@samsung.com> on 2013-10-10
Reviewed by Timothy Hatcher.
Skipping the tests of the old Inspector UI for all ports.
- TestExpectations:
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac-lion/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/win-xp/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 1:05 PM Changeset in webkit [157245] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r157203): WebKit crashes after dispatching gesture event
https://bugs.webkit.org/show_bug.cgi?id=122615
Reviewed by Anders Carlsson.
Don't release the event until the end of the function where we call member functions on it.
- dom/Node.cpp:
(WebCore::Node::dispatchGestureEvent):
- 1:04 PM Changeset in webkit [157244] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, roll out r157193. It broke some builds.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 1:02 PM Changeset in webkit [157243] by
-
- 2 edits in trunk/Source/WebKit2
generate-message-receiver.py can't handle nested #ifs
https://bugs.webkit.org/show_bug.cgi?id=121877
Reviewed by Alexey Proskuryakov.
- Scripts/webkit2/parser.py:
(parse): Exit early until proper fix instead of generating buggy output.
- 12:49 PM Changeset in webkit [157242] by
-
- 5 edits in trunk/Source/WebCore
Move the rest of EventRetargeter functions to EventPath
https://bugs.webkit.org/show_bug.cgi?id=122586
Reviewed by Andreas Kling.
Moved the rest of EventRetargeter functiosn either static local or EventPath member functions.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
- dom/EventRetargeter.cpp:
(WebCore::EventPath::EventPath):
(WebCore::calculateAdjustedNodes): Made static local. Also takes const EventPath and returns the size
to which EventPath should be shrunk; this allows us to remove EventPath::shrink.
(WebCore::updateTouchListsInEventPath): Moved and renamed from EventRetargeter::adjustTouchList.
(WebCore::EventPath::updateTouchLists): Moved and renamed from EventRetargeter::adjustForTouchEvent.
(WebCore::EventPath::setRelatedTarget): Moved.
- dom/EventRetargeter.h:
(WebCore::eventTargetRespectingTargetRules): Renamed from EventRetargeter::eventTargetRespectingTargetRules.
- 12:48 PM Changeset in webkit [157241] by
-
- 33 edits in trunk
<rdar://problem/13341666> WebKit should always build against an SDK.
Have all projects default to building against the OS X Internal SDK for the Production
configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig:
- gtest/xcode/Config/ProductionProject.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- 12:43 PM Changeset in webkit [157240] by
-
- 2 edits in trunk/Source/WebKit2
[CoordinatedGraphics][CSS Shaders] marshal color and matrix custom filter parameters
https://bugs.webkit.org/show_bug.cgi?id=117904
Correctly encode and decode the "matrix" and "color" custom filter parameter types.
No port currently enables this code, however with this change the relevant layout tests now pass when enabled in EFL.
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-10-10
Reviewed by Noam Rosenthal.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- 12:25 PM Changeset in webkit [157239] by
-
- 4 edits in trunk/Source
Source/JavaScriptCore: <rdar://problem/13871507> JavaScriptCore fails to build with C++ 98 conformance changes
Reviewed by Andreas Kling.
- heap/VTableSpectrum.cpp:
(JSC::VTableSpectrum::dump): strrchr returns a const char* when passed one.
Update the type of the local variable to accommodate that.
Source/WebKit2: <rdar://problem/13871522> WebKit2 fails to build with C++ 98 conformance changes
Reviewed by Andreas Kling.
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::resolveSymlinksInPath): strrchr returns a const char* when passed one.
Update the type of the local variable to accommodate that.
- 12:22 PM Changeset in webkit [157238] by
-
- 4 edits in trunk/Source
[CSS Shapes] clampToUnsigned() should return unsigned, not int
https://bugs.webkit.org/show_bug.cgi?id=122601
Source/WebCore:
Reviewed by Andreas Kling.
Corrected the return type for clampToUnsigned() in MathExtras.h. It's now unsigned.
No new tests since this is just an internal refactoring of existing code.
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShape::marginIntervals): Use the redefined clampToUnsigned method.
Source/WTF:
Corrected the return type for clampToUnsigned() in MathExtras.h. It's now unsigned.
Reviewed by Andreas Kling.
- wtf/MathExtras.h:
(clampToUnsigned):
- 11:24 AM Changeset in webkit [157237] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening.
Move the tests that only fail in wk1 to their file, and unskip the
ones that are passing in all cases.
- platform/gtk-wk1/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 11:22 AM Changeset in webkit [157236] by
-
- 13 edits7 copies1 add in trunk
[CSS Shapes] New positioning model: Shape cropped to margin box
https://bugs.webkit.org/show_bug.cgi?id=118092
Reviewed by Alexandru Chiculita.
Source/WebCore:
Clip the shape to the margin box when it extends out the left or right
edges. Also added a few local variables to make the code easier to
read.
Tests: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-ref.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006.html
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
LayoutTests:
Add tests for shapes that extend out left/right of the margin box.
Fix polygon and image threshold tests so that they have a large enough
margin box so the shape isn't clipped.
Also update some of the top/bottom tests to have a better reference,
they should be more likely to break if the implementation fails now.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-ref-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-ref.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html:
- 11:20 AM Changeset in webkit [157235] by
-
- 6 edits in trunk/Source/WebCore
Avoid resizing the internal buffer of SharedBuffer when creating a PurgeableBuffer
https://bugs.webkit.org/show_bug.cgi?id=122516
Reviewed by Darin Adler.
Currently when we create a PurgeableBuffer from a SharedBuffer we may
resize the internal buffer of the SharedBuffer so that it can fit the
concatenated contents of all of its segments before copying this
internal buffer to the internal buffer of the PurgeableBuffer. Instead,
we can avoid resizing the internal buffer of SharedBuffer by allocating
a PurgeableBuffer and then copying the internal buffer of SharedBuffer
and its segments directly into it.
- platform/PurgeableBuffer.h:
(WebCore::PurgeableBuffer::createUninitialized): Add inline implementation
when building with ENABLE_PURGEABLE_MEMORY disabled.
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::createPurgeableBuffer): Implemented in terms of
SharedBuffer::{copyBufferAndClear, createUninitialized}().
(WebCore::SharedBuffer::copyBufferAndClear): Added.
(WebCore::SharedBuffer::buffer): Moved logic to copy segments/data array to
SharedBuffer::copyBufferAndClear() and modified this function to use it.
- platform/SharedBuffer.h:
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::copyBufferAndClear): Renamed; formerly called SharedBuffer::copyDataArrayAndClear.
- platform/mac/PurgeableBufferMac.cpp:
(WebCore::allocatePurgeableBuffer): Added.
(WebCore::PurgeableBuffer::createUninitialized): Added.
(WebCore::PurgeableBuffer::create): Moved logic to allocate a purgeable buffer into
PurgeableBuffer::createUninitialized() and modified this function to use it.
- 11:20 AM Changeset in webkit [157234] by
-
- 9 edits in trunk/Source/JavaScriptCore
Objective-C API: blocks aren't callable via 'new'
https://bugs.webkit.org/show_bug.cgi?id=122561
Reviewed by Oliver Hunt.
Currently the only way for clients to vend new native objects to JavaScript code
is via factory methods in the form of exported class methods or blocks. Blocks can
be called like normal functions from JavaScript code, but they cannot be invoked
with 'new'. This would give a simple way for clients to expose constructor-like
behavior to their JavaScript code.
This patch adds the ability for blocks to be invoked as if they were a constructor.
Blocks invoked as constructors are required to return an object. If the block doesn't
return an object then an error is thrown. The 'this' object is not provided to the
block and must be created within the block itself.
This patch also unifies the native 'construct' callback used in both the C and Obj-C
APIs under the APICallbackFunction struct, similar to how we unified the 'call' callback
between ObjCCallbackFunction and JSCallbackFunction before.
This patch also adds tests to make sure that different blocks generate objects that
correctly behave when queried with instanceof. It also makes sure that the correct
JS exception is thrown when a block fails to return an object.
- API/APICallbackFunction.h:
(JSC::APICallbackFunction::call):
(JSC::APICallbackFunction::construct):
- API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::getConstructData):
- API/JSCallbackConstructor.h:
(JSC::JSCallbackConstructor::constructCallback):
- API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::functionCallback):
- API/ObjCCallbackFunction.h:
(JSC::ObjCCallbackFunction::functionCallback):
(JSC::ObjCCallbackFunction::constructCallback):
- API/ObjCCallbackFunction.mm:
(JSC::objCCallbackFunctionCallAsConstructor):
(JSC::ObjCCallbackFunction::ObjCCallbackFunction):
(JSC::ObjCCallbackFunction::create):
(JSC::ObjCCallbackFunction::getConstructData):
- API/tests/testapi.mm:
- 11:14 AM Changeset in webkit [157233] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. plugins/document-open.html will some times timeout.
- platform/gtk-wk2/TestExpectations:
- 10:54 AM Changeset in webkit [157232] by
-
- 2 edits in trunk/Tools
Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
- Scripts/run-gtk-tests:
(TestRunner): skip TestInspectorServer.
- 10:41 AM Changeset in webkit [157231] by
-
- 3 edits2 adds in trunk
AX: VoiceOver speaking too much when group elements with tabindex=-1 are used
https://bugs.webkit.org/show_bug.cgi?id=122574
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Tests: accessibility/negative-tabindex-does-not-expose-label.html
Elements that expose tabindex=-1 are being identified as generic focusable elements for accessibility.
Which among other things, determines whether to create an accessible name for the object.
This has the negative effect of causing VoiceOver to speak way too much information when navigating inside
a <div> with this attribute.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
LayoutTests:
- accessibility/negative-tabindex-does-not-expose-label-expected.txt: Added.
- accessibility/negative-tabindex-does-not-expose-label.html: Added.
- 10:39 AM Changeset in webkit [157230] by
-
- 3 edits in trunk/Source/WebCore
Remove custom finalizer for Node JS wrappers.
<https://webkit.org/b/122603>
Reviewed by Geoff Garen.
Node can just use the auto-generated finalizer, the custom one was
identical to what the generator would output.
- 9:38 AM Changeset in webkit [157229] by
-
- 2 edits in trunk/LayoutTests
Remove duplicate entry for editing/spelling/spellcheck-paste.html.
- platform/gtk/TestExpectations:
- 9:31 AM Changeset in webkit [157228] by
-
- 11 edits in trunk/Source/WebCore
CTTE: activeDOMWindow() and firstDOMWindow() should return references.
<https://webkit.org/b/122598>
Reviewed by Anders Carlsson.
Now that wrappers vend references to their WebCore objects, follow
up and make these two return references as well.
- 9:19 AM Changeset in webkit [157227] by
-
- 2 edits in trunk/Source/WebCore
[ATK] Missing checks in returnIfWebKitAccessibleIsInvalid
https://bugs.webkit.org/show_bug.cgi?id=122600
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-10-10
Reviewed by Chris Fleizach.
Check that the AccessibilityObject associated to the ATK wrapper
is not NULL and contains a valid reference to the document before
calling AccessibilityObject::updateBackingStore().
- accessibility/atk/WebKitAccessibleUtil.h: Add extra checks.
- 8:43 AM Changeset in webkit [157226] by
-
- 6 edits in trunk/Source/WebCore
Clean up JSDOMWindowShell a little.
<https://webkit.org/b/122599>
Reviewed by Anders Carlsson.
- Have impl() return a DOMWindow& instead of a pointer.
- Store the DOMWrapperWorld in a Ref instead of a RefPtr.
- Reuse TRY_TO_UNWRAP_WITH_INTERFACE in EventTarget bindings.
- 8:35 AM Changeset in webkit [157225] by
-
- 12 edits in trunk/Source/WebKit2
Buildfix for non Mac platforms with enabled NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=121793
Reviewed by Anders Carlsson.
- Shared/ShareableResource.cpp:
- Shared/ShareableResource.h:
- Shared/WebResourceBuffer.cpp:
- Shared/WebResourceBuffer.h:
- WebKit2Prefix.h:
- WebProcess/Network/NetworkProcessConnection.cpp:
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Network/NetworkProcessConnection.messages.in:
- WebProcess/Network/WebResourceLoader.cpp:
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- 8:01 AM Changeset in webkit [157224] by
-
- 2 edits in trunk/Source/WebCore
Make XPathGrammar.y bison3-friendly again after r157205
https://bugs.webkit.org/show_bug.cgi?id=122595
Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Anders Carlsson.
No new tests, build fix.
- xml/XPathGrammar.y: Replace YYLEX_PARAM with %lex-param, as the
former was removed in bison3.
- 7:51 AM Changeset in webkit [157223] by
-
- 2 edits in trunk/Source/WebCore
SVGUseElement: Use iterative traversal to find disallowed elements.
<https://webkit.org/b/122596>
Reviewed by Antti Koivisto.
Rewrote subtreeContainsDisallowedElement() in SVGUseElement.cpp to
use iterative traversal with descendantsOfType<Element> instead of
recursing through the tree.
- 6:55 AM Changeset in webkit [157222] by
-
- 14 edits in trunk/Source/WebCore
Move RenderObject::layout() to RenderElement.
<https://webkit.org/b/122537>
Reviewed by Antti Koivisto.
RenderText will ASSERT_NOT_REACHED() in its layout(), so move this
to RenderElement. This allows us to use the fast firstChild()
instead of virtual dispatch.
The needsLayout() bit remains on RenderObject for now. Moving that
to RenderElement is a far more involved change.
- 6:42 AM Changeset in webkit [157221] by
-
- 3 edits2 adds in trunk
AX: Crash at WebCore::accessibleNameForNode when visiting Facebook
https://bugs.webkit.org/show_bug.cgi?id=122572
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Test: accessibility/aria-labeled-with-hidden-node.html
Handle the case where aria-labelledby references a non-rendered node.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::accessibleNameForNode):
LayoutTests:
- accessibility/aria-labeled-with-hidden-node-expected.txt: Added.
- accessibility/aria-labeled-with-hidden-node.html: Added.
- 6:39 AM Changeset in webkit [157220] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
dom/xhtml/level2/html/HTMLInputElement20.xhtml no longer crashes.
- platform/gtk/TestExpectations:
- 6:29 AM Changeset in webkit [157219] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r157210): Crashes in WebCore::ScopedEventQueue::dispatchEvent for platforms using GCC
https://bugs.webkit.org/show_bug.cgi?id=122592
Reviewed by Gustavo Noronha Silva.
- dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::dispatchEvent): When calling EventDispatcher::dispatchEvent(), the GCC-compiled code
first creates a copy of the PassRefPtr<Event> object that's being passed into the method call. The copy will be used
in that method while the original is left with a null pointer. Only after that is the original queried for its pointer
while trying to get the Event's target, resulting in a crash due to calling the Event::target() on a null pointer.
To avoid it, pass a naked Event pointer to the method call. This will create a new PassRefPtr object without nullifying
the original one.
- 6:19 AM Changeset in webkit [157218] by
-
- 3 edits2 adds in trunk/Tools
[GTK] Provide search functionality to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=117631
Patch by Andres Gomez <Andres Gomez> on 2013-10-10
Reviewed by Carlos Garcia Campos.
Adds a search bar to MiniBrowser with the minimum functionality
and a new button to the toolbar for showing the new search
bar. Typical keyboard shortcuts are also added.
- MiniBrowser/gtk/BrowserSearchBar.c: Added.
(doSearch):
(searchNext):
(searchPrevious):
(searchCloseButtonClickedCallback):
(searchEntryMenuIconPressedCallback):
(searchEntryClearIconReleasedCallback):
(searchEntryChangedCallback):
(searchEntryActivatedCallback):
(searchPrevButtonClickedCallback):
(searchNextButtonClickedCallback):
(searchMenuCheckButtonToggledCallback):
(browser_search_bar_init):
(browserSearchBarFinalize):
(browser_search_bar_class_init):
(browser_search_bar_new):
(browser_search_bar_add_accelerators):
(browser_search_bar_open):
(browser_search_bar_close):
- MiniBrowser/gtk/BrowserSearchBar.h: Added.
- MiniBrowser/gtk/BrowserWindow.c:
(webViewEnterFullScreen): Closes new search bar.
(webViewLeaveFullScreen): Opens new search bar if previously
visible.
(searchCallback): Added. Shows and hides the new search bar.
(browser_window_init): Added search button to the toolbar.
(browserWindowConstructed): Creates the new search bar.
- MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
- 5:27 AM Changeset in webkit [157217] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
Webkit - Updated Tamil translation
https://bugs.webkit.org/show_bug.cgi?id=120520
Patch by Shantha kumar <shkumar@redhat.com> on 2013-10-10
Reviewed by Gustavo Noronha Silva.
- ta.po: updated.
- 5:19 AM Changeset in webkit [157216] by
-
- 13 edits in trunk/Source/WebCore
Use more Element iterators in SVG code.
<http://webkit.org/b/121127>
Reviewed by Antti Koivisto.
Use childrenOfType to iterate over only SVGElement (or even more
specific) children in a bunch of places.
Also auto-generate type helpers for SVGElement and SVGStopElement.
- 5:01 AM Changeset in webkit [157215] by
-
- 141 edits in trunk/Source
JS DOM wrappers' impl() functions should return references.
<https://webkit.org/b/122497>
Reviewed by Antti Koivisto.
JS DOM wrappers always have a corresponding WebCore object during
their lifetime, so make impl() return a reference.
- 4:17 AM Changeset in webkit [157214] by
-
- 2 edits in trunk/Source/WebCore
Fix debug build after r157210
https://bugs.webkit.org/show_bug.cgi?id=122593
Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Andreas Kling.
No new tests, build fix.
- dom/EventContext.cpp:
(WebCore::TouchEventContext::handleLocalEvents): Fix ASSERT, now that
event is a reference instead of a pointer.
- 4:16 AM Changeset in webkit [157213] by
-
- 2 edits in trunk/Source/WebCore
Tighten some renderer access in Document.
<https://webkit.org/b/121865>
Reviewed by Antti Koivisto.
A bit of Node/Element and RenderObject/RenderElement tightening.
- 3:49 AM Changeset in webkit [157212] by
-
- 10 edits in trunk/Source
rangeOfContents() should take a Node&.
<https://webkit.org/b/122438>
Reviewed by Darin Adler.
All callers of rangeOfContents() either have a Node& already,
or do some kind of null-checking before calling it.
- 1:38 AM Changeset in webkit [157211] by
-
- 19 edits5 adds in trunk
[CSS Grid Layout] Implement support for grid-template
https://bugs.webkit.org/show_bug.cgi?id=103313
Reviewed by Dean Jackson.
Source/WebCore:
Based on Blink r153427, r155199 and r155712 by <jchaffraix@chromium.org>
Test: fast/css-grid-layout/grid-template-get-set.html
Recognize, parse, store and return properly the value of
grid-template. It required some extra parsing code because the
specs mandates to check that the defined grid areas are indeed
rectangular. Named grid areas are still not fully supported, will
be done in a follow up patch.
As validating involves building the grid areas a new CSSValue was
added to hold the computed value. Note that we have to track the
explicit size of the named grid areas as the named grid areas
(".") are not tracked in our HashMap of grid areas.
This change also involves moving GridCoordinate and GridSpan to a
separate file in order to share the code that describes the grid
area coordinates.
- CMakeLists.txt: Added new files to the build.
- GNUmakefile.list.am: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSGridTemplateValue.cpp: Added.
(WebCore::CSSGridTemplateValue::CSSGridTemplateValue):
(WebCore::stringForPosition):
(WebCore::CSSGridTemplateValue::customCSSText):
- css/CSSGridTemplateValue.h: Added.
(WebCore::CSSGridTemplateValue::create):
(WebCore::CSSGridTemplateValue::~CSSGridTemplateValue):
(WebCore::CSSGridTemplateValue::gridAreaMap):
(WebCore::CSSGridTemplateValue::rowCount):
(WebCore::CSSGridTemplateValue::columnCount):
(WebCore::toCSSGridTemplateValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTemplate): create the grid areas and
validate that they define rectangular sections.
- css/CSSParser.h:
- css/CSSPropertyNames.in: Added -webkit-grid-template.
- css/CSSValue.cpp:
(WebCore::CSSValue::equals): add support for the new CSSGridTemplateValue.
(WebCore::CSSValue::cssText): Ditto.
(WebCore::CSSValue::destroy): Ditto.
- css/CSSValue.h:
(WebCore::CSSValue::isGridTemplateValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::cachedGridCoordinate): Replaced RenderGrid::GridSpan by WebCore::GridSpan.
(WebCore::RenderGrid::resolveGridPositionsFromAutoPlacementPosition): Ditto.
(WebCore::RenderGrid::resolveGridPositionsFromStyle): Ditto.
(WebCore::RenderGrid::resolveGridPositionAgainstOppositePosition): Ditto.
(WebCore::RenderGrid::resolveNamedGridLinePositionAgainstOppositePosition): Ditto.
(WebCore::RenderGrid::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition): Ditto.
(WebCore::RenderGrid::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition): Ditto.
- rendering/RenderGrid.h: Took GridSpan and GridCoordinate out.
- rendering/style/GridCoordinate.h: Added.
(WebCore::GridSpan::create):
(WebCore::GridSpan::GridSpan):
(WebCore::GridSpan::operator==):
(WebCore::GridCoordinate::GridCoordinate):
(WebCore::GridCoordinate::operator==):
(WebCore::GridCoordinate::operator!=):
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
- rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):
LayoutTests:
From Blink r153427, r155199 and r155712 by <jchaffraix@chromium.org>
Added a test to verify that we properly recognize, parse, store
and return the value of grid-template.
- fast/css-grid-layout/grid-template-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-template-get-set.html: Added.
- 1:19 AM Changeset in webkit [157210] by
-
- 14 edits in trunk/Source/WebCore
Make EventDispatcher::dispatch comprehensible
https://bugs.webkit.org/show_bug.cgi?id=122588
Reviewed by Andreas Kling.
Merged EventDispatcher::dispatchEventAtCapturing, EventDispatcher::dispatchEventAtTarget,
EventDispatcher::dispatchEventAtBubbling, and EventDispatcher::dispatchEventPostProcess into EventDispatcher::dispatch,
and extracted static local callDefaultEventHandlersInTheBubblingOrder and dispatchEventInDOM out of it.
Also made handleLocalEvents of subclasses of EventContext and Node take Event& instead of Event*.
- dom/EventContext.cpp: The following functions now take Event& instead of Event*.
(WebCore::EventContext::handleLocalEvents):
(WebCore::MouseOrFocusEventContext::handleLocalEvents):
(WebCore::TouchEventContext::handleLocalEvents):
- dom/EventContext.h:
- dom/EventDispatcher.cpp:
(WebCore::callDefaultEventHandlersInTheBubblingOrder): Extracted from EventDispatcher::dispatchEventPostProcess,
which is now merged into EventDispatcher::dispatch.
(WebCore::dispatchEventInDOM): Extracted out of EventDispatcher::dispatch, EventDispatcher::dispatchEventAtCapturing,
EventDispatcher::dispatchEventAtTarget and EventDispatcher::dispatchEventAtBubbling. This function is responsible for
dispatching the event for capturing, at the target, and then bubbling through the event path chain.
(WebCore::EventDispatcher::dispatch): EventDispatcher::dispatchEventPostProcess got merged into this. The calls to
dispatchEventAtCapturing, dispatchEventAtTarget, and dispatchEventAtBubbling are replaced by a single call to
dispatchEventInDOM.
- dom/EventDispatcher.h:
- dom/FocusEvent.h:
(WebCore::toFocusEvent): Added the version that takes a reference.
- dom/MouseEvent.h:
(WebCore::toMouseEvent): Ditto.
- dom/TouchEvent.h:
(WebCore::toTouchEvent): Ditto.
- dom/Node.cpp:
(WebCore::Node::handleLocalEvents): Now takes Event& instead of Event*.
- dom/Node.h:
- dom/WindowEventContext.cpp:
(WebCore::WindowEventContext::handleLocalEvents): Ditto.
- dom/WindowEventContext.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::handleLocalEvents): Ditto.
- html/HTMLFormElement.h:
- 1:16 AM HaikuWebkit created by
- 1:03 AM WikiStart edited by
- (diff)
Oct 9, 2013:
- 9:24 PM Changeset in webkit [157209] by
-
- 27 edits4 adds in trunk/Source/JavaScriptCore
FTL should be able to do simple OSR exits using llvm.webkit.stackmap
https://bugs.webkit.org/show_bug.cgi?id=122538
Reviewed by Oliver Hunt.
This gives the FTL the ability to OSR exit using the llvm.webkit.stackmap intrinsic.
- The FTL compiles all OSR exit calls as calls to llvm.webkit.stackmap with a unique ID, passing a requested size that is big enough for own jump replacement.
- After LLVM compilation, we parse the new LLVM stackmap section.
- For all llvm.webkit.stackmaps that we used for OSR exits, we do a jumpReplacement, which targets exit thunks that we generate.
- If an exit thunk fires, it causes JSC to compile an exit off-ramp that uses a combination of the JSC-internal OSR exit accounting (FTL::ExitValue and friends) and LLVM stackmap's accounting of where data actually ended up (register, indirect, constant) to reconstruct bytecode state.
This still has shortcomings; for example it cannot handle XMM or YMM registers. Handling
YMM registers will require adding some basic YMM support to our assemblers - really we
just need the ability to move a YMM's value into a GPR.
This patch preserves all of the old, intrinsic-less, FTL OSR exit support. Hence it
manages to pass all existing FTL tests even despite its incompleteness. I think that's
the right way to go since this is already a big patch, and anyway it would be great to
keep the intrinsic-less FTL OSR exit support so long as the LLVM side of this hasn't
landed.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::firstRegister):
(JSC::AbstractMacroAssembler::lastRegister):
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::isStackRelated):
(JSC::MacroAssembler::firstRealRegister):
(JSC::MacroAssembler::nextRegister):
(JSC::MacroAssembler::secondRealRegister):
- assembler/MacroAssemblerX86Common.h:
- assembler/X86Assembler.h:
(JSC::X86Assembler::firstRegister):
(JSC::X86Assembler::lastRegister):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- ftl/FTLCArgumentGetter.cpp:
(JSC::FTL::CArgumentGetter::loadNextAndBox):
- ftl/FTLCArgumentGetter.h:
(JSC::FTL::CArgumentGetter::loadNextDoubleIntoGPR):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateCodeSection):
(JSC::FTL::mmAllocateDataSection):
(JSC::FTL::dumpDataSection):
(JSC::FTL::fixFunctionBasedOnStackMaps):
(JSC::FTL::compile):
- ftl/FTLExitThunkGenerator.cpp:
(JSC::FTL::ExitThunkGenerator::emitThunk):
(JSC::FTL::ExitThunkGenerator::emitThunks):
- ftl/FTLExitThunkGenerator.h:
- ftl/FTLExitValue.h:
(JSC::FTL::ExitValue::isInJSStackSomehow):
(JSC::FTL::ExitValue::valueFormat):
- ftl/FTLFail.cpp:
(JSC::FTL::fail):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLJITCode.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::generateExitThunks):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompilationInfo.h:
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStubWithOSRExitStackmap):
(JSC::FTL::compileStubWithoutOSRExitStackmap):
(JSC::FTL::compileFTLOSRExit):
- ftl/FTLSaveRestore.cpp: Added.
(JSC::FTL::bytesForGPRs):
(JSC::FTL::requiredScratchMemorySizeInBytes):
(JSC::FTL::offsetOfGPR):
(JSC::FTL::saveAllRegisters):
(JSC::FTL::restoreAllRegisters):
- ftl/FTLSaveRestore.h: Added.
- ftl/FTLStackMaps.cpp: Added.
(JSC::FTL::readObject):
(JSC::FTL::StackMaps::Constant::parse):
(JSC::FTL::StackMaps::Constant::dump):
(JSC::FTL::StackMaps::Location::parse):
(JSC::FTL::StackMaps::Location::dump):
(JSC::FTL::StackMaps::Location::involvesGPR):
(JSC::FTL::StackMaps::Location::isGPR):
(JSC::FTL::StackMaps::Location::gpr):
(JSC::FTL::StackMaps::Location::restoreInto):
(JSC::FTL::StackMaps::Record::parse):
(JSC::FTL::StackMaps::Record::dump):
(JSC::FTL::StackMaps::parse):
(JSC::FTL::StackMaps::dump):
(JSC::FTL::StackMaps::dumpMultiline):
(JSC::FTL::StackMaps::getRecordMap):
(WTF::printInternal):
- ftl/FTLStackMaps.h: Added.
- ftl/FTLState.h:
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationThunkGenerator):
- ftl/FTLValueFormat.cpp:
(JSC::FTL::reboxAccordingToFormat):
- ftl/FTLValueFormat.h:
- runtime/DataView.cpp:
(JSC::DataView::create):
- runtime/DataView.h:
(JSC::DataView::read):
- runtime/Options.h:
- 9:24 PM Changeset in webkit [157208] by
-
- 4 edits in trunk/Source/WTF
FTL should be able to do simple OSR exits using llvm.webkit.stackmap
https://bugs.webkit.org/show_bug.cgi?id=122538
Reviewed by Oliver Hunt.
- wtf/PrintStream.cpp:
(WTF::printInternal):
- wtf/PrintStream.h:
- wtf/RefCountedArray.h:
(WTF::RefCountedArray::byteSize):
- 8:26 PM Changeset in webkit [157207] by
-
- 2 edits in trunk/Source/WebCore
Another build fix after r157204.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatch):
- 8:19 PM Changeset in webkit [157206] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r157204.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatch):
- 7:46 PM Changeset in webkit [157205] by
-
- 22 edits in trunk/Source/WebCore
Use unique_ptr instead of deleteAllValues in XPath
https://bugs.webkit.org/show_bug.cgi?id=121082
Reviewed by Anders Carlsson.
- dom/Attr.h: Made the namespaceURI function public so it can be called by
code in XPath. Since the class is FINAL, calls won't do virtual dispatch.
- xml/XPathExpression.cpp:
(WebCore::XPathExpression::XPathExpression): Added. Use std::move.
(WebCore::XPathExpression::createExpression): Use the new Parser::parseStatement
and more std::move.
(WebCore::XPathExpression::~XPathExpression): Removed now-unneeded delete.
- xml/XPathExpression.h: Removed unused create function. Use std::unique_ptr.
- xml/XPathExpressionNode.cpp:
(WebCore::XPath::Expression::evaluationContext): Use NeverDestroyed instead of
DEFINE_STATIC_LOCAL.
(WebCore::XPath::Expression::setSubexpressions): Added. Used to set all the
subexpressions at once rather than adding one at a time.
- xml/XPathExpressionNode.h: Use plain unsigned instead of unsigned long.
Eliminated the ParseNode class, used only by the parser to delete objects,
which we now do with %destructor. Made more functions protected. Fixed the
capitalization of the word "subexpression". Made m_subexpressions be a Vector
of std::unique_ptr.
- xml/XPathFunctions.cpp: Marked all the classes FINAL and all their virtual
functions OVERRIDE. Reduced some of the boilerplate.
(WebCore::XPath::Function::setArguments): Passed in the name so we don't have
to store the function names in all the function objects.
(WebCore::XPath::FunId::evaluate): Use std::move instead of Value::adopt.
(WebCore::XPath::FunLocalName::evaluate): Use emptyString instead of "".
(WebCore::XPath::FunNamespaceURI::evaluate): Ditto.
(WebCore::XPath::FunName::evaluate): Ditto.
(WebCore::XPath::FunSubstringBefore::evaluate): Ditto.
(WebCore::XPath::FunSubstringAfter::evaluate): Ditto.
(WebCore::XPath::FunSubstring::evaluate): Ditto.
(WebCore::XPath::FunLang::evaluate): Use Value(false) so we can make the
constructor that takes a boolean explicit.
(WebCore::XPath::FunFalse::evaluate): Ditto.
(WebCore::XPath::populateFunctionMap): Changed idiom slightly to match other
maps we set up.
(WebCore::XPath::Function::create): Refactored createFunction into three
member functions of this name.
- xml/XPathFunctions.h: Made all the Function members private or protected
except for Function::create.
- xml/XPathGrammar.y: Changed the parser to use a reference instead of
a pointer, and to pass the reference through to yylex as well. Break up
the union into pieces and add %destructor as needed to make sure everything
gets deallocated if parsing fails. Added a new top level rule "Top" so that
we would not try to set the parse result multiple times during parsing.
Call setParseResult instead of setting m_topExpr directly. Use std::unique_ptr
to adopt pointers from the union. Removed all the register/unregister calls
that used to be used to manage storage. Also changed the four different node
types to be separate tokens instead of using string matching at this level
for them.
- xml/XPathNodeSet.cpp:
(WebCore::XPath::NodeSet::sort): Removed const_cast since m_isSorted and
m_nodes are now both marked mutable. Also set m_isSorted after sorting; this
was an oversight that hurt performance before.
(WebCore::XPath::NodeSet::traversalSort): Ditto.
(WebCore::XPath::NodeSet::firstNode): Use nullptr.
(WebCore::XPath::NodeSet::anyNode): Ditto.
- xml/XPathNodeSet.h: Removed unneeded extra includes. Removed the
WTF_MAKE_FAST_ALLOCATED for NodeSet since we never allocate these on the heap.
Added a constructor that takes a single node. Deleted the swap function, since
we now move instead of swap. Deleted the append function that takes a raw Node*,
since calling the PassRefPtr<Node> overload does the same thing. Removed the
unused reverse function. Marked both m_isSorted and m_nodes mutable so the
sort function can be const.
- xml/XPathParser.cpp: Moved the Token struct in here instead of the header.
(WebCore::XPath::populateAxisNamesMap):Renamed to match our normal naming scheme,
and changed to use add instead of set, use WTF_ARRAY_LENGTH, and not use a typedef.
(WebCore::XPath::parseAxisName): Related style changes, including renaming to
better reflect the way this works with a boolean.
(WebCore::XPath::Parser::nextTokenInternal): Updated to call parseAxisName,
and to produce four separate tokens for the four node type functions.
(WebCore::XPath::Parser::nextToken): Renamed local variable.
(WebCore::XPath::Parser::Parser): Made this a real constructor that takes arguments
and initializes all the fields. Deleted the unneeded reset function.
(WebCore::XPath::Parser::lex): Changed to take an argument of an appropriate type
instead of casting from void*. Also changed the string code to leak a StringImpl,
which is now what the grammar code expects.
(WebCore::XPath::Parser::expandQualifiedName): Renamed from expandQName. Changed
to set m_sawNamespaceError instead of relying on code in the grammar to do it.
(WebCore::XPath::Parser::parseStatement): Removed most of the code in this function.
Changed to a much simpler model. Also made this a static member function so it
takes care of creating the parser itself and does not need to call reset. Also
changed return value to be a std::unique_ptr to make ownership more clear.
- xml/XPathParser.h: Added a declaration of YYSTYPE. Removed unneeded forward
declarations and moved Token into the cpp file. Deleted most public functions,
leaving only parseStatement, the entry point, and the three functions needed by
the grammar, lex, expandQualifiedName, and setParseResult.
- xml/XPathPath.cpp:
(WebCore::XPath::Filter::Filter): Move in the arguments instead of copying them.
(WebCore::XPath::Filter::evaluate): Updated for name and type changes.
(WebCore::XPath::LocationPath::LocationPath): Ditto.
(WebCore::XPath::LocationPath::evaluate): Ditto. Also use std::move instead of
Value::adopt and instead of swap.
(WebCore::XPath::LocationPath::appendStep): Changed to take ownership of a
unique_ptr.
(WebCore::XPath::LocationPath::prependStep): Ditto. Renamed from insertFirstStep.
(WebCore::XPath::Path::Path): Move in the arguments.
- xml/XPathPath.h: Removed unneeded includes. Changed arugument types to use
std::unique_ptr to pass ownership in. Added override to all virtual functions.
Changed data members to use std::unique_ptr.
- xml/XPathPredicate.cpp:
(WebCore::XPath::StringExpression::StringExpression): Use move.
(WebCore::XPath::Negative::Negative): Added.
(WebCore::XPath::Negative::evaluate): Updated for name changes.
(WebCore::XPath::NumericOp::NumericOp): Use move.
(WebCore::XPath::NumericOp::evaluate): Tweak formatting.
(WebCore::XPath::EqTestOp::EqTestOp): Use move.
(WebCore::XPath::EqTestOp::evaluate): Updated for name changes.
(WebCore::XPath::LogicalOp::LogicalOp): Use move.
(WebCore::XPath::LogicalOp::shortCircuitOn): Made shorter.
(WebCore::XPath::LogicalOp::evaluate): Updated for name changes.
(WebCore::XPath::Union::Union): Added.
(WebCore::XPath::Union::evaluate): Updated for name changes.
(WebCore::XPath::evaluatePredicate): Updated for name changes, to use
ASCIILiteral, and to be a free function that takes an expression.
(WebCore::XPath::predicateIsContextPositionSensitive): Added.
Replaces the Predicate::isContextPositionSensitive function.
- xml/XPathPredicate.h: Made all the classes FINAL and added a lot of OVERRIDE.
Added a constructor for Negative and Union. Got rid of the Predicate class and
instead provided two functions that operate on an Expression.
- xml/XPathStep.cpp:
(WebCore::XPath::Step::Step): Use move instea dof copying.
(WebCore::XPath::Step::~Step): Removed calls to deleteAllValues.
(WebCore::XPath::Step::optimize): Use move instead of swap and copy. Also
operate directly on the data members of the node test instead of using functions
that just return references to those data members.
(WebCore::XPath::optimizeStepPair): Use references instead of pointers, move
instead of swap, and early return instead of nested if statements.
(WebCore::XPath::Step::predicatesAreContextListInsensitive): Use references.
(WebCore::XPath::Step::evaluate): Use references instead of pointers and move
instead of swap.
(WebCore::XPath::nodeMatchesBasicTest): Use references instead of pointers and
more specific types when possible.
(WebCore::XPath::nodeMatches): Ditto.
(WebCore::XPath::Step::nodesInAxis): Use references instead of pointers. Added
braces to match style. Use words instead of letters for local variable names.
- xml/XPathStep.h: Make almost everything in NodeTest private since callers
just set these up and Step is what actually uses them. Changed the predicate
vectors to be vectors of Predicate instead of Predicate*, since a Predicate
is just a wrapper around a single std::unique_ptr<Expression>. Changed to use
move instead of copy when making a Step and to use references instead of pointers.
- xml/XPathValue.cpp: Use std::numeric_limits explicitly instead of using using.
Got rid of Value::adopt.
(WebCore::XPath::Value::toNodeSet): Use NeverDestroyed instead of DEFINE_STATE_LOCAL.
Updated for name changes.
(WebCore::XPath::Value::modifiableNodeSet): Ditto.
(WebCore::XPath::Value::toBoolean): Ditto.
(WebCore::XPath::Value::toNumber): Ditto.
(WebCore::XPath::Value::toString): Ditto. Use ASCIILiteral.
- xml/XPathValue.h: Moved ValueData class inside the Value class and renamed
it Value::Data. Removed fancy trick that avoids turning pointers into bool, and
just take the risk. Made many, but not all, of the Value constructors explicit
since we normally are explicit at call sites. Removed unneeded unsigned long
overload of the constructor. Changed the NodeSet version of the constructor to
use std::move and use that instead of AdoptTag.
- 6:59 PM Changeset in webkit [157204] by
-
- 2 edits in trunk/Source/WebCore
Build fix. Add back the missing call to EventRetargeter::adjustForTouchEvent.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatch):
- 6:44 PM Changeset in webkit [157203] by
-
- 20 edits2 deletes in trunk/Source/WebCore
EventDispatchMediator is goner
https://bugs.webkit.org/show_bug.cgi?id=122581
Reviewed by Antti Koivisto.
Killed the death.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/Element.cpp:
(WebCore::Element::dispatchWheelEvent):
(WebCore::Element::dispatchKeyEvent):
(WebCore::Element::dispatchFocusEvent):
(WebCore::Element::dispatchBlurEvent):
- dom/EventDispatchMediator.cpp: Removed.
- dom/EventDispatchMediator.h: Removed.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchScopedEvent):
- dom/EventDispatcher.h:
- dom/KeyboardEvent.h:
- dom/MouseEvent.h:
- dom/Node.cpp:
(WebCore::Node::dispatchScopedEvent):
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchGestureEvent):
(WebCore::Node::dispatchTouchEvent):
(WebCore::Node::dispatchUIRequestEvent):
- dom/Node.h:
- dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::~ScopedEventQueue):
(WebCore::ScopedEventQueue::enqueueEvent):
(WebCore::ScopedEventQueue::dispatchAllEvents):
(WebCore::ScopedEventQueue::dispatchEvent):
- dom/ScopedEventQueue.h:
- dom/TouchEvent.cpp:
- dom/TouchEvent.h:
- dom/UIEvent.h:
- dom/WheelEvent.h:
- 6:37 PM Changeset in webkit [157202] by
-
- 2 edits in trunk/Source/WebCore
Kill some RenderObject::firstChildSlow/lastChildSlow usage.
<https://webkit.org/b/122582>
Reviewed by Antti Koivisto.
Use tighter typing in some random places to flush out unnecessary use
of virtual first/last child getters on RenderObject.
There are more of these opportunities, but I left them untouched to
avoid snowballing this patch.
- 6:23 PM Changeset in webkit [157201] by
-
- 2 edits in trunk/Tools
webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
https://bugs.webkit.org/show_bug.cgi?id=122552
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-09
Reviewed by Darin Adler.
- Scripts/webkitpy/common/checkout/commitinfo.py:
(CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
will cause UnicodeDecodeError for non-ascii characters.
- 6:23 PM Changeset in webkit [157200] by
-
- 2 edits in trunk/Source/WebCore
Fix some bad paths in the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=122583
Reviewed by Mark Rowe.
Fix paths for some storage quota-related files, and remove
reference to mediaControlsQuickTime.css which was removed in r156546.
- WebCore.xcodeproj/project.pbxproj:
- 6:17 PM Changeset in webkit [157199] by
-
- 7 edits16 adds in trunk
Web Inspector: [CSS Regions] Display the correct fragment boxes for content inside flow threads
https://bugs.webkit.org/show_bug.cgi?id=122291
Reviewed by Timothy Hatcher.
Source/WebCore:
Tests: inspector/elements/highlight-regions-flow-horiz-bt.html
inspector/elements/highlight-regions-flow-transform-horiz-bt.html
inspector/elements/highlight-regions-flow-transform-vert-lr.html
inspector/elements/highlight-regions-flow-transform-vert-rl.html
inspector/elements/highlight-regions-flow-transform.html
inspector/elements/highlight-regions-flow-vert-lr.html
inspector/elements/highlight-regions-flow-vert-rl.html
inspector/elements/highlight-regions-flow.html
Nodes inside a RenderFlowThread can be split across multiple regions. This patch adds the required
code to compute "fragments" for each region. Each fragment will display its own label.
There are a couple of changes:
- The node highlight object now has a "scroll" property to hold the main view's scroll offset.
- There's a "fragment" array to get a list of quads for each renderer fragment. Renderers outside
RenderFlowThreads will just have one fragment.
- ElementInfo now has two more properties: "regionFlowInfo" (renamed from former flowInfo) and "contentFlowInfo".
If the renderer is a RenderRegion it will have a regionFlowInfo. If the renderer is inside a RenderFlowThread
then it will have a "contentFlowInfo".
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::getHighlight): It should now take a "region" parameter to customize the output for a specific
containing region.
(WebCore::buildObjectForHighlight):
(WebCore::buildObjectForCSSRegionContentClip): We need to know how to clip the fragments inside regions.
(WebCore::buildObjectForRendererFragments): Extracted code from buildObjectForHighlight and added
the new regions lookup code.
(WebCore::buildObjectForElementInfo): Extracted from buildObjectForHighlight.
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawQuadHighlight):
- inspector/InspectorOverlayPage.css: There can be multiple labels on screen at once, so I've
created the #element-title-template element that we clone for each label. .element-title-container is now
holding all the .element-title elements, so that we can remove them all at once.
(.element-title-container):
(.element-title):
(#element-title-template):
(.tag-name):
(.node-id):
(.class-name):
- inspector/InspectorOverlayPage.html:
- inspector/InspectorOverlayPage.js:
(reset):
(_toggleOptionalValue):
(_createElementTitle): Creates an element populated with data read from elementInfo.
(_drawElementTitle): Added code to create more labels for multiple fragments.
(_drawRegionsHighlight):
(_drawFragmentHighlight):
(drawNodeHighlight): Consolidated the scroll property into a canvas.transform.
LayoutTests:
Added tests to check the result of the InspectorOverlay when it inspects nodes inside RenderFlowThreads.
- http/tests/inspector/elements-test.js:
- inspector/elements/highlight-regions-flow-expected.txt: Added.
- inspector/elements/highlight-regions-flow-horiz-bt-expected.txt: Added.
- inspector/elements/highlight-regions-flow-horiz-bt.html: Added.
- inspector/elements/highlight-regions-flow-transform-expected.txt: Added.
- inspector/elements/highlight-regions-flow-transform-horiz-bt-expected.txt: Added.
- inspector/elements/highlight-regions-flow-transform-horiz-bt.html: Added.
- inspector/elements/highlight-regions-flow-transform-vert-lr-expected.txt: Added.
- inspector/elements/highlight-regions-flow-transform-vert-lr.html: Added.
- inspector/elements/highlight-regions-flow-transform-vert-rl-expected.txt: Added.
- inspector/elements/highlight-regions-flow-transform-vert-rl.html: Added.
- inspector/elements/highlight-regions-flow-transform.html: Added.
- inspector/elements/highlight-regions-flow-vert-lr-expected.txt: Added.
- inspector/elements/highlight-regions-flow-vert-lr.html: Added.
- inspector/elements/highlight-regions-flow-vert-rl-expected.txt: Added.
- inspector/elements/highlight-regions-flow-vert-rl.html: Added.
- inspector/elements/highlight-regions-flow.html: Added.
- 5:53 PM Changeset in webkit [157198] by
-
- 2 edits in trunk/Source/WebCore
Layout assertion failure in WebCore::RenderView::paint
https://bugs.webkit.org/show_bug.cgi?id=121925
Reviewed by Tim Horton.
This fixes the assertion seen when running WK2 API tests.
If RenderLayerCompositor::flushPendingLayerChanges() was called before
the root layer was attached, it would set m_shouldFlushOnReattach
to do the flush later, after attaching (bypassing the runloop observer
that updated layout if necessary).
This could cause us to get to a CA commit without having updated
layout, hence the assertion.
Fix by having attachRootLayer() schedule a layer flush, rather than doing
one right away.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::attachRootLayer):
- 5:35 PM Changeset in webkit [157197] by
-
- 9 edits in trunk/Source/WebCore
Move float logical location/dimension methods to RenderBlockFlow
https://bugs.webkit.org/show_bug.cgi?id=122282
Reviewed by David Hyatt.
I recently moved the logical location and dimension methods from
RenderBlock to FloatingObject. This made it so that the methods needed
to take in the horizontal writing mode of the FloatingObject's
container in order to do their thing. When looking into how to fix
this, I came to understand why RenderBlock has methods to determine
the logical location and dimensions of its children, when the children
themselves have those methods: the methods on RenderBlock are for
determining the logical value in the writing mode of that RenderBlock,
and the method on the child is for determining the logical value in
the writing mode of the child.
Since the floating object list has moved from RenderBlock to
RenderBlockFlow, this change moves the logical dimension methods from
FloatingObject to RenderBlockFlow.
No new tests, no new behavior.
- rendering/FloatingObjects.cpp:
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FloatingObjects::FloatingObjects):
(WebCore::::updateOffsetIfNeeded):
(WebCore::::collectIfNeeded):
(WebCore::::getHeightRemaining):
- rendering/FloatingObjects.h:
- rendering/LineWidth.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::repaintOverhangingFloats):
(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObjectsBelow):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::hasOverhangingFloat):
(WebCore::RenderBlockFlow::addIntrudingFloats):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::logicalTopForFloat):
(WebCore::RenderBlockFlow::logicalBottomForFloat):
(WebCore::RenderBlockFlow::logicalLeftForFloat):
(WebCore::RenderBlockFlow::logicalRightForFloat):
(WebCore::RenderBlockFlow::logicalWidthForFloat):
(WebCore::RenderBlockFlow::logicalHeightForFloat):
(WebCore::RenderBlockFlow::logicalSizeForFloat):
(WebCore::RenderBlockFlow::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlockFlow::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlockFlow::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlockFlow::pixelSnappedLogicalRightForFloat):
(WebCore::RenderBlockFlow::setLogicalTopForFloat):
(WebCore::RenderBlockFlow::setLogicalLeftForFloat):
(WebCore::RenderBlockFlow::setLogicalHeightForFloat):
(WebCore::RenderBlockFlow::setLogicalWidthForFloat):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::adjustLogicalLineTopAndLogicalHeightIfNeeded):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::updateSegmentsForShapes):
(WebCore::LineBreaker::nextSegmentBreak):
(WebCore::RenderBlockFlow::positionNewFloatOnLine):
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
- rendering/shapes/ShapeOutsideInfo.h:
- 5:29 PM Changeset in webkit [157196] by
-
- 5 edits in trunk/Source/WebCore
Remove MouseEventDispatchMediator
https://bugs.webkit.org/show_bug.cgi?id=122580
Reviewed by Antti Koivisto.
Removed. Will remove EventDispatchMediator next.
- dom/Element.cpp:
(WebCore::Element::dispatchMouseEvent):
- dom/MouseEvent.cpp:
- dom/MouseEvent.h:
- dom/Node.cpp:
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchTouchEvent):
- 4:49 PM Changeset in webkit [157195] by
-
- 11 edits in trunk/Source/WebCore
Remove all subclasses of EventDispatchMediator except MouseEventDispatchMediator
https://bugs.webkit.org/show_bug.cgi?id=122579
Reviewed by Antti Koivisto.
Removed UIRequestEventDispatchMediator, GestureEventDispatchMediator, KeyboardEventDispatchMediator,
and WheelEventDispatchMediator. Moved the code in the respective mediateAndDispatchEvent functions
to their respective dispatch*Event functions in Node.cpp and Element.cpp.
- Modules/indieui/UIRequestEvent.cpp:
(WebCore::UIRequestEvent::eventInterface):
- Modules/indieui/UIRequestEvent.h:
- dom/Element.cpp:
(WebCore::deltaMode):
(WebCore::Element::dispatchWheelEvent):
(WebCore::Element::dispatchKeyEvent):
- dom/GestureEvent.cpp:
- dom/GestureEvent.h:
- dom/KeyboardEvent.cpp:
- dom/KeyboardEvent.h:
- dom/Node.cpp:
(WebCore::Node::dispatchGestureEvent):
(WebCore::Node::dispatchUIRequestEvent):
- dom/WheelEvent.cpp:
- dom/WheelEvent.h:
- 4:03 PM Changeset in webkit [157194] by
-
- 2 edits in trunk/Tools
Would like a link to dashboard from build.webkit.org main page
https://bugs.webkit.org/show_bug.cgi?id=122577
Reviewed by Tim Hatcher.
- BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
- 3:57 PM Changeset in webkit [157193] by
-
- 2 edits in trunk/Source/JavaScriptCore
Minor clean-ups in the JSC Xcode project.
Rubber stamped by Mark Rowe.
- When we copy the jsc binary into the framework, $(BUILT_PRODUCTS_DIR)/JavaScriptCore.framework/Resources/jsc is the *output* file not the input file. The input file is $(BUILT_PRODUCTS_DIR)/jsc.
- Correct capitalization of "JavaScriptcore.framework" in a comment in a shell script in the project.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 3:54 PM Changeset in webkit [157192] by
-
- 7 edits in trunk
[CSS Shapes] Lines that don't intersect shape-outside should ignore both left and right margins
https://bugs.webkit.org/show_bug.cgi?id=122570
Reviewed by Alexandru Chiculita.
Source/WebCore:
Due to an oversight, the left margin on left floats and the right
margin on right floats was having an effect on lines that did not
intersect the shape (but did intersect the margin box of the float).
By the spec, lines that do not intersect the shape should act as if
the float isn't there, so those margins should have no effect on
those lines. This patch fixes this.
No new tests, it is covered by the existing tests now that they have
been fixed to have the proper behavior.
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
LayoutTests:
Update tests to work with the proper behavior for margins. Yes, the
tests were not correct before.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html:
- 3:39 PM Changeset in webkit [157191] by
-
- 2 edits in trunk/Tools
[Win] Check for MathML fonts and warn user if they are missing.
https://bugs.webkit.org/show_bug.cgi?id=122568
Reviewed by Tim Horton.
- Scripts/webkitdirs.pm:
(checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
Windows-specific code I added previously.
(fontExists): Added
(checkInstalledTools): Add check for MathML fonts.
- 3:32 PM Changeset in webkit [157190] by
-
- 3 edits in trunk/Tools
http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
https://bugs.webkit.org/show_bug.cgi?id=122471
Reviewed by Tim Hatcher.
Added links to webkitpy, webkitperl and bindings-tests results.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.apiTestResultsURLForIteration):
(Buildbot.prototype.webkitpyTestResultsURLForIteration):
(Buildbot.prototype.webkitperlTestResultsURLForIteration):
(Buildbot.prototype.bindingsTestResultsURLForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- 3:03 PM Changeset in webkit [157189] by
-
- 3 edits in trunk/Tools
Move some functions from WebKitBuildbot to Buildbot class.
Suggested by Tim Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.javascriptTestResultsURLForIteration):
(Buildbot.prototype.apiTestResultsURLForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
- 2:58 PM Changeset in webkit [157188] by
-
- 3 edits in trunk/Tools
Add API tests to the Dashbord page.
https://bugs.webkit.org/show_bug.cgi?id=122283
Patch by Timothy Hatcher <timothy@apple.com> on 2013-10-09
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.apiTestResultsURLForIteration):
- 2:56 PM Changeset in webkit [157187] by
-
- 3 edits in trunk/Tools
Add API tests to the Dashbord page.
https://bugs.webkit.org/show_bug.cgi?id=122283
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.apiTestResultsURLForIteration):
- 2:45 PM Changeset in webkit [157186] by
-
- 5 edits8 adds in trunk
[CSS Shapes] Clip shape-outside to the bottom of the margin box
https://bugs.webkit.org/show_bug.cgi?id=122562
Reviewed by Alexandru Chiculita.
Source/WebCore:
The spec says that a shape-outside shape must be clipped to the
margin box. This implements clipping the bottom of the shape to the
bottom of the margin box.
Test: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-000.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-002.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
LayoutTests:
Test that the shape is properly clipped to the bottom of the float.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-000-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-000.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-002-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-002.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 2:34 PM Changeset in webkit [157185] by
-
- 2 edits in trunk/Tools
Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
https://bugs.webkit.org/show_bug.cgi?id=122515
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.update):
- 2:01 PM Changeset in webkit [157184] by
-
- 4 edits in trunk/Source/WebCore
[CoordinatedGraphics] ASSERTION FAILED: !m_flushingLayers (after r156291)
https://bugs.webkit.org/show_bug.cgi?id=122016
Patch by Sergio Correia <Sergio Correia> on 2013-10-09
Reviewed by Noam Rosenthal.
To prevent calling scheduleLayerFlush() inside flushCompositingState(),
we now only call m_client->notifyFlushRequired() - which will trigger
scheduleLayerFlush() - if we are not already flushing layer changes.
No new tests, covered by existing ones.
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::notifyFlushRequired): Check if we
are already flushing layer changes before calling notifyFlushRequired.
(WebCore::CompositingCoordinator::sizeDidChange): Use notifyFlushRequired()
from CompositingCoordinator instead of calling the one from m_client
directly.
(WebCore::CompositingCoordinator::createGraphicsLayer): Ditto.
(WebCore::CompositingCoordinator::detachLayer): Ditto.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::notifyFlushRequired): Added helper
to check whether we are flushing layer changes before calling client()'s
notifyFlushRequired(). It returns a boolean indicating whether it
called the client's method.
(WebCore::CoordinatedGraphicsLayer::didChangeLayerState): Use the
notifyFlushRequired() helper.
(WebCore::CoordinatedGraphicsLayer::didChangeAnimations): Ditto.
(WebCore::CoordinatedGraphicsLayer::didChangeChildren): Ditto.
(WebCore::CoordinatedGraphicsLayer::didChangeFilters): Ditto.
(WebCore::CoordinatedGraphicsLayer::didChangeImageBacking): Ditto.
(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay): Ditto.
(WebCore::CoordinatedGraphicsLayer::setContentsToCanvas): Ditto.
(WebCore::CoordinatedGraphicsLayer::flushCompositingState): Ditto.
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreHasPendingTileCreation):Ditto.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
Declaration of the notifyFlushRequired() helper.
- 2:00 PM Changeset in webkit [157183] by
-
- 4 edits3 adds in trunk
AX: VoiceOver double speaks all items in <li> nodes
https://bugs.webkit.org/show_bug.cgi?id=122564
Reviewed by Brent Fulgham.
Source/WebCore:
Test: platform/mac/accessibility/native-list-item-should-not-expose-label.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::visibleText):
LayoutTests:
Make a mac specific expectation for listitem-title on Mac.
Make a more directed test for Mac regarding listitem labeling.
- platform/mac/accessibility/lists-expected.txt:
- platform/mac/accessibility/listitem-title-expected.txt: Added.
- platform/mac/accessibility/native-list-item-should-not-expose-label-expected.txt: Added.
- platform/mac/accessibility/native-list-item-should-not-expose-label.html: Added.
- 1:44 PM Changeset in webkit [157182] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Many inspector protocol tests are timing out on the bots, unreproducible locally.
- platform/gtk/TestExpectations:
- 1:31 PM Changeset in webkit [157181] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. A couple of paste tests began timing out after
http://trac.webkit.org/changeset/156678.
- platform/gtk/TestExpectations:
- 1:26 PM Changeset in webkit [157180] by
-
- 3 edits2 adds in trunk
CoordinatedGraphics: Fix integer rounding when computing pixel alignment
https://bugs.webkit.org/show_bug.cgi?id=122565
Patch by Sergio Correia <Sergio Correia> on 2013-10-09
Reviewed by Noam Rosenthal.
Source/WebCore:
Replace roundedIntRect call in computePixelAlignment() with enclosingIntRect,
so that very small rectangles (after content scaling) don't appear to be empty,
creating a crash later.
Test: transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt.html
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::computePixelAlignment):
LayoutTests:
Added test that rotates 45 degrees a very long text in a dt tag that
might crash the browser depending on how it handles the integer
rounding when computing pixel alignment.
- transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt-expected.txt: Added.
- transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt.html: Added.
- 1:22 PM Changeset in webkit [157179] by
-
- 2 edits in trunk/Tools
http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
https://bugs.webkit.org/show_bug.cgi?id=122569
Reviewed by Tim Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
to be produced by the old Mozilla test harness that we don't use any more.
- 1:15 PM Changeset in webkit [157178] by
-
- 2 edits in trunk/Source/WebKit2
Set view to active in ViewClientEfl after WebProcess has relaunched
https://bugs.webkit.org/show_bug.cgi?id=118650
Patch by Sergio Correia <Sergio Correia> on 2013-10-09
Reviewed by Noam Rosenthal.
Once WebProcess relaunches, the underlying scene from the view is recreated
and is not active by default, which means it will be in `background'. In
practice, from that point on we are going to get a blank screen, unless we
set it to active.
In the normal flow, the view is set to active during its initialization; this
patch sets it to active also in ViewClientEfl, in the webProcessDidRelaunch
callback.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::webProcessDidRelaunch): Added WKViewSetIsActive call.
- 1:05 PM Changeset in webkit [157177] by
-
- 14 edits in trunk/Source/WebCore
Rename EventRetargeter::adjustForRelatedTarget to EventPath::setRelatedTarget
https://bugs.webkit.org/show_bug.cgi?id=122539
Reviewed by Darin Adler.
Renamed EventRetargeter::adjustForRelatedTarget to EventPath::setRelatedTarget and got rid of
EventDispatchMediators for focus events. We set the related target inside EventDispatcher's
dispatch via Event::relatedTarget, which is now virtual and overridden by mouse/focus events.
- dom/Element.cpp: The following functions no longer use FocusEventDispatchMediators.
(WebCore::Element::dispatchFocusInEvent):
(WebCore::Element::dispatchFocusOutEvent):
(WebCore::Element::dispatchFocusEvent):
(WebCore::Element::dispatchBlurEvent):
- dom/Event.h:
(WebCore::Event::relatedTarget): Added as a virtual function.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent): Cache Event*.
(WebCore::EventDispatcher::dispatch): Call setRelatedTargetToPath at the beginning to update
related targets in the path.
- dom/EventDispatcher.h:
- dom/EventRetargeter.cpp:
(WebCore::EventPath::EventPath): Initialize m_origin, used in EventPath::setRelatedTarget.
(WebCore::EventRetargeter::adjustTouchList):
(WebCore::EventPath::setRelatedTarget): Renamed from EventRetargeter::adjustForRelatedTarget.
Delegated the nullity checks to callers by taking references instead of pointers.
(WebCore::EventRetargeter::calculateAdjustedNodes):
- dom/EventRetargeter.h: Removed AdjustedNodes typedef. It's just a Vector of RefPtr<Node>.
- dom/FocusEvent.cpp: Removed FocusEventDispatchMediators for focus events.
- dom/FocusEvent.h:
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::toElement): Cache the related target now that relatedTarget() is virtual.
(WebCore::MouseEvent::fromElement): Ditto.
(WebCore::MouseEventDispatchMediator::mediateAndDispatchEvent): No longer sets the related
targets since that's done in EventDispatcher::dispatch now.
- dom/MouseEvent.h:
- dom/Node.cpp: Removed obnoxious Node::dispatchScopedEventDispatchMediator.
(WebCore::Node::dispatchScopedEvent):
- dom/Node.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Cache the related
target in a local variable now that relatedTarget() is virtual.
- 11:22 AM Changeset in webkit [157176] by
-
- 2 edits in trunk/Source/WTF
Change to std::unique_ptr breaks wtf/DataLog.cpp when DATA_LOG_TO_FILE set to 1
https://bugs.webkit.org/show_bug.cgi?id=122557
Reviewed by Filip Pizlo.
Changed the leakPtr() to release().
- wtf/DataLog.cpp:
(WTF::initializeLogFileOnce):
- 10:07 AM Changeset in webkit [157175] by
-
- 3 edits1 add in trunk/Tools
Add GTK 64 bits release to the buildbot dashboard
https://bugs.webkit.org/show_bug.cgi?id=122548
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-09
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
- 10:05 AM Changeset in webkit [157174] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] BeginPaint should only be called in response to WM_PAINT.
https://bugs.webkit.org/show_bug.cgi?id=122549
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-09
Reviewed by Brent Fulgham.
According to the documentation, the Win32 api function BeginPaint should only be called in response to a WM_PAINT message.
Currently, the WebView window procedure might call this function (via WebView::paint(0, 0)) for all types of messages.
Also, there is potential for double drawing. If some message is dispatched before WM_PAINT, WebView::paint(0, 0) will be called.
This call does not validate the area drawn, so later the WM_PAINT will arrive, drawing the same area.
This can be fixed by calling the Win32 function UpdateWindow(), which will do a synchronous window update, and validate the area.
- WebView.cpp:
(WebView::WebViewWndProc): Use Win32 function UpdateWindow() to draw invalid area.
- 10:02 AM Changeset in webkit [157173] by
-
- 2 edits in trunk/Source/JavaScriptCore
[arm] Inverted src and dest FP registers in DFG speculative JIT when using hardfp.
https://bugs.webkit.org/show_bug.cgi?id=122555
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-09
Reviewed by Michael Saboff.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
- 9:47 AM Changeset in webkit [157172] by
-
- 3 edits in trunk/LayoutTests
[EFL] Some accessibility tests are failing
https://bugs.webkit.org/show_bug.cgi?id=122553
Unreviewed EFL gardening
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-09
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 9:16 AM Changeset in webkit [157171] by
-
- 2 edits in trunk/Source/WebCore
AX: VoiceOver does not speak aria-expanded state on iOS
https://bugs.webkit.org/show_bug.cgi?id=122540
Expose aria-pressed state for iOS.
Reviewed by Mario Sanchez Prada.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityIsExpanded]):
- 8:33 AM Changeset in webkit [157170] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Update GObject DOM symbols file after r157163.
- bindings/gobject/webkitdom.symbols:
- 8:24 AM Changeset in webkit [157169] by
-
- 2 edits in trunk/Websites/planet.webkit.org
Add Frédéric Wang's blog to the planet
https://bugs.webkit.org/show_bug.cgi?id=122541
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-10-09
Reviewed by Martin Robinson.
- config.ini: Add my blog to the planet.
- 8:24 AM Changeset in webkit [157168] by
-
- 6 edits1 delete in trunk/Source/WebCore
Remove RunLoopMac.mm
https://bugs.webkit.org/show_bug.cgi?id=122527
Reviewed by Antti Koivisto.
RunLoop::setUseApplicationRunLoopOnMainRunLoop() is no longer used, so we can just use the run() and stop()
implementations from RunLoopCF.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/RunLoop.cpp:
- platform/RunLoop.h:
- platform/cf/RunLoopCF.cpp:
(WebCore::RunLoop::stop):
- platform/mac/RunLoopMac.mm: Removed.
- 7:54 AM Changeset in webkit [157167] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Add timeout as expected result for fast/history/go-back-to-iframe-with-plugin.html,
since it times out sometimes.
- platform/gtk/TestExpectations:
- 7:48 AM Changeset in webkit [157166] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Add timeout as expected result for mathml/very-large-stretchy-operators.html,
since it times out on the bots.
- platform/gtk/TestExpectations:
- 7:16 AM Changeset in webkit [157165] by
-
- 6 edits1 delete in trunk
[ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
https://bugs.webkit.org/show_bug.cgi?id=120638
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Implemented new atk_text_get_string_at_offset() API, introduced in
ATK 2.9.4 to simplify how text at a given offset is retrieved.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetStringAtOffset): New function implementing
the new API, which basically translates calls to the new API to
calls to the old API using 'at' positions and START boundaries.
(webkitAccessibleTextInterfaceInit): Hook the new function.
Source/WebKit/gtk:
Update ATK unit test to check the new API as well if the version
of ATK is new enough.
- tests/testatk.c:
(testGetStringFunction): New helper function, to check the new API.
(runGetStringTests): Ditto.
(testWebkitAtkGetStringAtOffset): New unit test, similar to the
one already present to check the old API but focused in the new one.
(testWebkitAtkGetStringAtOffsetNewlines): Ditto.
(testWebkitAtkGetStringAtOffsetTextarea): Ditto.
(testWebkitAtkGetStringAtOffsetTextInput): Ditto.
(testWebkitAtkGetStringAtOffsetWithPreformattedText): Ditto.
(testWebkitAtkGetStringAtOffsetWithSpecialCharacters): Ditto.
(testWebkitAtkGetStringAtOffsetWithWrappedLines): Ditto.
(testWebkitAtkGetStringAtOffsetWithEmbeddedObjects): Ditto.
(testWebkitAtkGetExtents): Add checks for the new API, if possible.
(testWebkitAtkLinksWithInlineImages): Ditto.
(main): Add the new unit tests to check the new API, if possible.
Tools:
- gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
can check both the old and new APIs to retrieve text at a given offset.
- 6:29 AM Changeset in webkit [157164] by
-
- 13 edits in trunk/Source/JavaScriptCore
Transition call and construct JITStubs to CCallHelper functions
https://bugs.webkit.org/show_bug.cgi?id=122453
Reviewed by Geoffrey Garen.
Transitioned cti_op_call_eval to operationCallEval. Migrated baseline JIT to use the same
call thunks as the DFG. Eliminated all of the "oldStyle" thunks and related functions.
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlink):
- jit/JIT.cpp:
(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITInlines.h:
(JSC::JIT::callOperationWithCallFrameRollbackOnException):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/ThunkGenerators.cpp:
- jit/ThunkGenerators.h:
- 6:07 AM Changeset in webkit [157163] by
-
- 3 edits in trunk/Source/WebCore
[GTK] mouse wheel events are not considered to be mouse events
https://bugs.webkit.org/show_bug.cgi?id=120648
Reviewed by Gustavo Noronha Silva.
Expose WheelEvent in the GObject DOM bindings API.
- bindings/gobject/GNUmakefile.am: Add new files to compilation.
- bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap): Create a WebKitDOMWheelEvent when the given Event
is a WheelEvent.
- 5:50 AM Changeset in webkit [157162] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r157157.
http://trac.webkit.org/changeset/157157
https://bugs.webkit.org/show_bug.cgi?id=122547
Caused crashes on several bots including gtk, mac-wk2 lion and
mountain lion (Requested by kov on #webkit).
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject):
(WebKit::NPRemoteObjectMap::pluginDestroyed):
- Shared/Plugins/NPRemoteObjectMap.h:
- 4:21 AM Changeset in webkit [157161] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] Fix lots of unused parameter warnings.
https://bugs.webkit.org/show_bug.cgi?id=122545
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-09
Reviewed by Csaba Osztrogonác.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::revertJumpReplacementToPatchableBranchPtrWithPatch):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::andlImm8r):
(JSC::SH4Assembler::orlImm8r):
(JSC::SH4Assembler::xorlImm8r):
(JSC::SH4Assembler::cmpEqImmR0):
(JSC::SH4Assembler::testlImm8r):
(JSC::SH4Assembler::movwPCReg):
(JSC::SH4Assembler::movwMemReg):
(JSC::SH4Assembler::movbMemReg):
(JSC::SH4Assembler::printInstr):
(JSC::SH4Assembler::printBlockInstr):
- 4:06 AM Changeset in webkit [157160] by
-
- 3 edits in trunk/LayoutTests
[EFL] accessibility/table-cells.html is failing
https://bugs.webkit.org/show_bug.cgi?id=122544
Unreviewed EFL gardening
Changed expectations so that they show proper name of the parent (the table)
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-09
- platform/efl-wk1/accessibility/table-cells-expected.txt:
- platform/efl-wk2/accessibility/table-cells-expected.txt:
- 2:16 AM Changeset in webkit [157159] by
-
- 4 edits in trunk
[sh4] Add sh4 support when building with CMake.
https://bugs.webkit.org/show_bug.cgi?id=122542
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-09
Reviewed by Csaba Osztrogonác.
.:
- CMakeLists.txt:
Source/JavaScriptCore:
- CMakeLists.txt:
Oct 8, 2013:
- 11:23 PM Changeset in webkit [157158] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix EFL buildbreak since r157152.
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::adjustForTouchEvent):
- 10:26 PM Changeset in webkit [157157] by
-
- 3 edits in trunk/Source/WebKit2
Remove use of deleteAllValues in NPRemoteObjectMap::pluginDestroyed
https://bugs.webkit.org/show_bug.cgi?id=122496
Reviewed by Andreas Kling.
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject): Don't call release when puttin objects
into the map.
(WebKit::NPRemoteObjectMap::pluginDestroyed): Instead of making an array of receivers
and deleting them all, remove all of the receivers from the map, which will take care
of deleting them. Also change the other loop to use a similar coding style.
- Shared/Plugins/NPRemoteObjectMap.h: Change the value type of m_registeredNPObjects
to be unique_ptr instead of a raw pointer.
- 7:36 PM Changeset in webkit [157156] by
-
- 2 edits in trunk/LayoutTests
Fix expectation for geolocation test that has been timing out.
- platform/gtk-wk2/TestExpectations:
- 7:07 PM Changeset in webkit [157155] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening. Move http/tests/loading/307-after-303-after-post.html failure
expectation to the global gtk expectations file, since it's also true for gtk-wk2.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 6:16 PM Changeset in webkit [157154] by
-
- 8 edits1 delete in trunk
Improved WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122536
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
Source/WebCore:
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::cookieJarPath):
Put cookies.dat into the AppData directory on Windows.
Tools:
- WinLauncher/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
(PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
- WinLauncher/PrintWebUIDelegate.h: Removed stubs.
- WinLauncher/WinLauncher.cpp:
(createCrashReport): Use the executable name instead of "WinLauncher".
- WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
- win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
- 5:45 PM Changeset in webkit [157153] by
-
- 2 edits in trunk/Source/WebCore
Remove the code erroneously in the previous commit.
- dom/EventDispatcher.h:
(WebCore::EventPath::contextAt):
- 5:41 PM Changeset in webkit [157152] by
-
- 8 edits in trunk/Source/WebCore
Turn EventPath into a real class
https://bugs.webkit.org/show_bug.cgi?id=122533
Reviewed by Antti Koivisto.
Turned EventPath into a real class and made EventRetargeter::calculateEventPath its constructor.
We can turn a lot of functions in EventRetargeter.cpp member functions of EventPath since many
of them manipulate EventPath in one way or another.
- dom/EventContext.h:
(WebCore::toMouseOrFocusEventContext):
(WebCore::toTouchEventContext):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
(WebCore::EventDispatcher::topEventContext):
(WebCore::EventPath::hasEventListeners):
- dom/EventDispatcher.h:
(WebCore::EventPath::isEmpty):
(WebCore::EventPath::size):
(WebCore::EventPath::item):
(WebCore::EventPath::targetRespectingTargetRules):
(WebCore::EventPath::shrink):
(WebCore::EventPath::lastContextIfExists):
- dom/EventRetargeter.cpp:
(WebCore::EventPath::EventPath):
(WebCore::EventRetargeter::adjustForTouchEvent):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes):
- dom/EventRetargeter.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::eventHasListeners):
- inspector/InspectorInstrumentation.h:
- 5:38 PM Changeset in webkit [157151] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. The 64 bits release bot has been made to use 8 bpp depth, so
fast/dom/Window/window-screen-properties.html won't pass there.
- platform/gtk/TestExpectations:
- 5:24 PM Changeset in webkit [157150] by
-
- 12 edits in trunk
Convert for-of iteration to in-band signalling so we can trivially avoid unnecessary object allocation
https://bugs.webkit.org/show_bug.cgi?id=122532
Reviewed by Michael Saboff.
Source/JavaScriptCore:
Switch for-of enumeration to use in band signalling to determine the end
of iteration. This allows us to trivially remove an otherwise unnecessary
object allocation, and paves the way for optimised thunks in future.
We can re-add explicit .next() functions in future that would marshall
the true iteration functions, but for now we'll ignore them.
This results in a huge improvement in the performance of for-of (in the order
of 2x) but there's still a long way to go in order to get the performance to
a satisfactory level.
- bytecompiler/NodesCodegen.cpp:
(JSC::ForOfNode::emitBytecode):
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::createIteratorResult):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
- runtime/CommonIdentifiers.h:
- runtime/Identifier.cpp:
(JSC::Identifier::addSlowCase):
- runtime/JSObject.h:
(JSC::JSFinalObject::create):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
LayoutTests:
Update tests to reflect our non-exposure of .next()
- js/array-iterators-expected.txt:
- js/script-tests/array-iterators.js:
- 5:21 PM Changeset in webkit [157149] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Unreviewed gardening. Make platform-specific expectation file apply only to gtk-wk1, since
gtk-wk2 gets the output right.
- platform/gtk-wk1/fast/loader/show-only-one-beforeunload-dialog-expected.txt: Renamed from LayoutTests/platform/gtk/fast/loader/show-only-one-beforeunload-dialog-expected.txt.
- 5:08 PM Changeset in webkit [157148] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Update gtk-wk2-specific expectations for a couple of
fast/dom/Window tests:
- fast/dom/Window/window-postmessage-clone.html (times out)
- fast/dom/Window/open-window-min-size.html (fails)
- platform/gtk-wk2/TestExpectations:
- 5:05 PM Changeset in webkit [157147] by
-
- 9 edits in trunk/Source
Source/JavaScriptCore: Fixed compile errors while compiling without the JIT enabled.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- jit/JITOperations.cpp:
Protected with #if ENABLE(JIT) like the rest of the JIT source.
Source/ThirdParty/ANGLE: Generate pdb files for debugging ANGLE DLLs.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- ANGLE.vcxproj/libEGLCommon.props:
- ANGLE.vcxproj/libGLESv2Common.props:
Generate debug information.
Source/WebCore: Enabled all necessary files for Win64 build.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj:
Enabled MediaPlayerPrivateFullscreenWindow and
RenderLayerModelObject to be built in Win64 build.
Source/WebKit: Fixed Win64 linking.
https://bugs.webkit.org/show_bug.cgi?id=122530
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added 64-bit linker symbols.
- 4:49 PM Changeset in webkit [157146] by
-
- 14 edits in trunk/Source
Consolidate findString functions
https://bugs.webkit.org/show_bug.cgi?id=122480
Reviewed by Darin Adler.
../WebCore:
- editing/Editor.cpp:
- editing/Editor.h:
- editing/EditorCommand.cpp:
(WebCore::executeFindString):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::find):
- page/Page.cpp:
- page/Page.h:
Fix a long standing FIXME.
../WebKit/efl:
- ewk/ewk_frame.cpp:
(ewk_frame_text_search):
- ewk/ewk_view.cpp:
(ewk_view_text_search):
../WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_search_text):
../WebKit/win:
- WebView.cpp:
(WebView::searchFor):
- 4:25 PM Changeset in webkit [157145] by
-
- 2 edits in trunk/LayoutTests
Upgrade accessibility/title-ui-element-correctness.html from crash (wk2-specific)
to fail (gtk-wide) expectation.
- platform/gtk-wk2/TestExpectations:
- 4:20 PM Changeset in webkit [157144] by
-
- 13 edits in trunk/Source/WebCore
Move m_floatingObjects to RenderBlockFlow from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=122512
Reviewed by David Hyatt.
Floats are part of block flow, not every RenderBlock can contain
floars. This change makes it so that RenderBlock no longer can contain
floats, only RenderBlockFlow can.
This also moves a bunch of line layout stuff over to RenderBlockFlow,
but makes no effort to move all of line layout, as all of that is
destined to move out of both RenderBlockFlow and RenderBlock into its
own class.
No new tests, no behavior change.
- rendering/InlineIterator.h:
(WebCore::InlineBidiResolver::appendRun):
- rendering/LineWidth.cpp:
(WebCore::LineWidth::LineWidth):
- rendering/LineWidth.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::splitFlow):
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::adjustForBorderFit):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::containsFloats):
(WebCore::RenderBlock::shouldSkipCreatingRunsForObject):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::logicalRightFloatOffsetForLine):
(WebCore::RenderBlock::logicalLeftFloatOffsetForLine):
(WebCore::RenderBlock::moveAllChildrenOnRemovalTo):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::clipOutFloatingObjects):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::containsFloat):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::styleWillChange):
(WebCore::RenderBlockFlow::deleteLineBoxTree):
(WebCore::RenderBlockFlow::moveAllChildrenOnRemovalTo):
(WebCore::RenderBlockFlow::addOverflowFromFloats):
(WebCore::RenderBlockFlow::computeOverflow):
(WebCore::RenderBlockFlow::repaintOverhangingFloats):
(WebCore::RenderBlockFlow::paintFloats):
(WebCore::RenderBlockFlow::clipOutFloatingObjects):
(WebCore::RenderBlockFlow::createFloatingObjects):
(WebCore::RenderBlockFlow::removeFloatingObjects):
(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObjectsBelow):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::newLine):
(WebCore::RenderBlockFlow::logicalLeftFloatOffsetForLine):
(WebCore::RenderBlockFlow::logicalRightFloatOffsetForLine):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::hasOverhangingFloat):
(WebCore::RenderBlockFlow::addIntrudingFloats):
(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlockFlow::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::hitTestFloats):
(WebCore::RenderBlockFlow::adjustForBorderFit):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::hasOverhangingFloats):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineBreaker::LineBreaker):
(WebCore::RenderBlockFlow::appendRunsForObject):
(WebCore::RenderBlockFlow::createLineBoxes):
(WebCore::RenderBlockFlow::constructLine):
(WebCore::RenderBlockFlow::setMarginsForRubyRun):
(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
(WebCore::RenderBlockFlow::computeBlockDirectionPositionsForLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlockFlow::handleTrailingSpaces):
(WebCore::RenderBlockFlow::appendFloatingObjectToLastLine):
(WebCore::constructBidiRunsForLine):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::restartLayoutRunsAndFloatsInRange):
(WebCore::pushShapeContentOverflowBelowTheContentBox):
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLine):
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):
(WebCore::RenderBlockFlow::adjustLogicalLineTopAndLogicalHeightIfNeeded):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::linkToEndLineIfNeeded):
(WebCore::RenderBlockFlow::repaintDirtyFloats):
(WebCore::RenderBlockFlow::checkFloatsInCleanLine):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::determineEndPosition):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlockFlow::matchedEndLine):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::updateSegmentsForShapes):
(WebCore::RenderBlockFlow::deleteEllipsisLineBoxes):
(WebCore::RenderBlockFlow::checkLinesForTextOverflow):
(WebCore::RenderBlockFlow::positionNewFloatOnLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::outermostBlockContainingFloatingObject):
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildrenTo):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::splitFlow):
- 4:05 PM Changeset in webkit [157143] by
-
- 2 edits in trunk/Source/WTF
Turn threaded scrolling on for all Mac ports.
Rubber-stamped by Simon Fraser and Sam Weinig.
- wtf/FeatureDefines.h:
- 4:01 PM Changeset in webkit [157142] by
-
- 3 edits130 moves in trunk/LayoutTests
[CSSRegions] Move autoheight* tests into fast/regions/auto-size
https://bugs.webkit.org/show_bug.cgi?id=122514
Reviewed by Sam Weinig.
Move tests, fix include paths, change TestExpectations when necessary.
- fast/regions/auto-size/abspos-autoheight-nested-region-expected.txt: Renamed from LayoutTests/fast/regions/abspos-autoheight-nested-region-expected.txt.
- fast/regions/auto-size/abspos-autoheight-nested-region.html: Renamed from LayoutTests/fast/regions/abspos-autoheight-nested-region.html.
- fast/regions/auto-size/autoheight-abspos-bottom-align-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-abspos-bottom-align-expected.txt.
- fast/regions/auto-size/autoheight-abspos-bottom-align.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-bottom-align.html.
- fast/regions/auto-size/autoheight-abspos-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-region-expected.html.
- fast/regions/auto-size/autoheight-abspos-region.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-region.html.
- fast/regions/auto-size/autoheight-allregions-expected.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-expected.html.
- fast/regions/auto-size/autoheight-allregions-nobreaks-expected.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-nobreaks-expected.html.
- fast/regions/auto-size/autoheight-allregions-nobreaks.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-nobreaks.html.
- fast/regions/auto-size/autoheight-allregions.html: Renamed from LayoutTests/fast/regions/autoheight-allregions.html.
- fast/regions/auto-size/autoheight-break-after-expected.html: Renamed from LayoutTests/fast/regions/autoheight-break-after-expected.html.
- fast/regions/auto-size/autoheight-break-after.html: Renamed from LayoutTests/fast/regions/autoheight-break-after.html.
- fast/regions/auto-size/autoheight-breakafteralways-maxheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-breakafteralways-maxheight-expected.html.
- fast/regions/auto-size/autoheight-breakafteralways-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-breakafteralways-maxheight.html.
- fast/regions/auto-size/autoheight-breakbefore-wrongheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-breakbefore-wrongheight-expected.txt.
- fast/regions/auto-size/autoheight-breakbefore-wrongheight.html: Renamed from LayoutTests/fast/regions/autoheight-breakbefore-wrongheight.html.
- fast/regions/auto-size/autoheight-breakbeforealways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-breakbeforealways-expected.html.
- fast/regions/auto-size/autoheight-breakbeforealways.html: Renamed from LayoutTests/fast/regions/autoheight-breakbeforealways.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines-2-expected.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-2-expected.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines-2.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-2.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines-expected.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-expected.html.
- fast/regions/auto-size/autoheight-correct-region-for-lines.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines.html.
- fast/regions/auto-size/autoheight-definedheight-changenotdetected-expected.html: Renamed from LayoutTests/fast/regions/autoheight-definedheight-changenotdetected-expected.html.
- fast/regions/auto-size/autoheight-definedheight-changenotdetected.html: Renamed from LayoutTests/fast/regions/autoheight-definedheight-changenotdetected.html.
- fast/regions/auto-size/autoheight-dynamic-update-expected.html: Renamed from LayoutTests/fast/regions/autoheight-dynamic-update-expected.html.
- fast/regions/auto-size/autoheight-dynamic-update.html: Renamed from LayoutTests/fast/regions/autoheight-dynamic-update.html.
- fast/regions/auto-size/autoheight-firstregion-breakalways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-firstregion-breakalways-expected.html.
- fast/regions/auto-size/autoheight-firstregion-breakalways.html: Renamed from LayoutTests/fast/regions/autoheight-firstregion-breakalways.html.
- fast/regions/auto-size/autoheight-flexbox-expected.html: Renamed from LayoutTests/fast/regions/autoheight-flexbox-expected.html.
- fast/regions/auto-size/autoheight-flexbox.html: Renamed from LayoutTests/fast/regions/autoheight-flexbox.html.
- fast/regions/auto-size/autoheight-floatright-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-floatright-region-expected.html.
- fast/regions/auto-size/autoheight-floatright-region.html: Renamed from LayoutTests/fast/regions/autoheight-floatright-region.html.
- fast/regions/auto-size/autoheight-horizontal-bt-expected.html: Renamed from LayoutTests/fast/regions/autoheight-horizontal-bt-expected.html.
- fast/regions/auto-size/autoheight-horizontal-bt.html: Renamed from LayoutTests/fast/regions/autoheight-horizontal-bt.html.
- fast/regions/auto-size/autoheight-inlineblock-normalflow-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-inlineblock-normalflow-region-expected.html.
- fast/regions/auto-size/autoheight-inlineblock-normalflow-region.html: Renamed from LayoutTests/fast/regions/autoheight-inlineblock-normalflow-region.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto-breaksignored-expected.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-breaksignored-expected.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto-breaksignored.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-breaksignored.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto-expected.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-expected.html.
- fast/regions/auto-size/autoheight-lastregion-overflowauto.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto.html.
- fast/regions/auto-size/autoheight-maxheight-mixed-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-mixed-break-expected.txt.
- fast/regions/auto-size/autoheight-maxheight-mixed-break.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-mixed-break.html.
- fast/regions/auto-size/autoheight-maxheight-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-region-expected.html.
- fast/regions/auto-size/autoheight-maxheight-region.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-region.html.
- fast/regions/auto-size/autoheight-maxheight-simple-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-break-expected.txt.
- fast/regions/auto-size/autoheight-maxheight-simple-break.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-break.html.
- fast/regions/auto-size/autoheight-maxheight-simple-nobreak-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-nobreak-expected.txt.
- fast/regions/auto-size/autoheight-maxheight-simple-nobreak.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-nobreak.html.
- fast/regions/auto-size/autoheight-middleregion-expected.html: Renamed from LayoutTests/fast/regions/autoheight-middleregion-expected.html.
- fast/regions/auto-size/autoheight-middleregion.html: Renamed from LayoutTests/fast/regions/autoheight-middleregion.html.
- fast/regions/auto-size/autoheight-minheight-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-minheight-region-expected.html.
- fast/regions/auto-size/autoheight-minheight-region.html: Renamed from LayoutTests/fast/regions/autoheight-minheight-region.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-hbt-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-hbt-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-hbt.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-hbt.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vlr-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vlr-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vlr.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vlr.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vrl-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vrl-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vrl.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vrl.html.
- fast/regions/auto-size/autoheight-minmaxheight-mixed-break.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break.html.
- fast/regions/auto-size/autoheight-minmaxheight-simple-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-break-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-simple-break.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-break.html.
- fast/regions/auto-size/autoheight-minmaxheight-simple-nobreak-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-nobreak-expected.txt.
- fast/regions/auto-size/autoheight-minmaxheight-simple-nobreak.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-nobreak.html.
- fast/regions/auto-size/autoheight-mixed-nested-complex-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-complex-regions-expected.txt.
- fast/regions/auto-size/autoheight-mixed-nested-complex-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-complex-regions.html.
- fast/regions/auto-size/autoheight-mixed-nested-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-regions-expected.txt.
- fast/regions/auto-size/autoheight-mixed-nested-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-regions.html.
- fast/regions/auto-size/autoheight-mixed-parallel-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-parallel-regions-expected.txt.
- fast/regions/auto-size/autoheight-mixed-parallel-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-parallel-regions.html.
- fast/regions/auto-size/autoheight-nested-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-nested-regions-expected.txt.
- fast/regions/auto-size/autoheight-nested-regions.html: Renamed from LayoutTests/fast/regions/autoheight-nested-regions.html.
- fast/regions/auto-size/autoheight-normalflow-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-normalflow-region-expected.html.
- fast/regions/auto-size/autoheight-normalflow-region.html: Renamed from LayoutTests/fast/regions/autoheight-normalflow-region.html.
- fast/regions/auto-size/autoheight-region-decrease-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-decrease-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-maxheight.html.
- fast/regions/auto-size/autoheight-region-decrease-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-decrease-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-minheight.html.
- fast/regions/auto-size/autoheight-region-decrease-width-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-width-expected.txt.
- fast/regions/auto-size/autoheight-region-decrease-width.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-width.html.
- fast/regions/auto-size/autoheight-region-increase-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-increase-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-maxheight.html.
- fast/regions/auto-size/autoheight-region-increase-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-increase-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-minheight.html.
- fast/regions/auto-size/autoheight-region-increase-width-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-width-expected.txt.
- fast/regions/auto-size/autoheight-region-increase-width.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-width.html.
- fast/regions/auto-size/autoheight-region-new-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-new-maxheight-vrl-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-vrl-expected.txt.
- fast/regions/auto-size/autoheight-region-new-maxheight-vrl.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-vrl.html.
- fast/regions/auto-size/autoheight-region-new-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight.html.
- fast/regions/auto-size/autoheight-region-new-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-new-minheight-vlr-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-vlr-expected.txt.
- fast/regions/auto-size/autoheight-region-new-minheight-vlr.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-vlr.html.
- fast/regions/auto-size/autoheight-region-new-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight.html.
- fast/regions/auto-size/autoheight-region-remove-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-remove-maxheight-expected.txt.
- fast/regions/auto-size/autoheight-region-remove-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-remove-maxheight.html.
- fast/regions/auto-size/autoheight-region-remove-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-remove-minheight-expected.txt.
- fast/regions/auto-size/autoheight-region-remove-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-remove-minheight.html.
- fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-regionlayoutupdate-multipletimes-expected.txt.
- fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html: Renamed from LayoutTests/fast/regions/autoheight-regionlayoutupdate-multipletimes.html.
- fast/regions/auto-size/autoheight-regions-mark-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-regions-mark-expected.txt.
- fast/regions/auto-size/autoheight-regions-mark.html: Renamed from LayoutTests/fast/regions/autoheight-regions-mark.html.
- fast/regions/auto-size/autoheight-secondregion-breakoutside-expected.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-breakoutside-expected.html.
- fast/regions/auto-size/autoheight-secondregion-breakoutside.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-breakoutside.html.
- fast/regions/auto-size/autoheight-secondregion-expected.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-expected.html.
- fast/regions/auto-size/autoheight-secondregion.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways-maxheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-maxheight-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-maxheight.html.
- fast/regions/auto-size/autoheight-singleregion-breakafteralways.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways.html.
- fast/regions/auto-size/autoheight-singleregion-breakaftermargin-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakaftermargin-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakaftermargin.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakaftermargin.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways-minheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-minheight-expected.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-minheight.html.
- fast/regions/auto-size/autoheight-singleregion-breakbeforealways.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways.html.
- fast/regions/auto-size/autoheight-singleregion-multiplebreaks-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-multiplebreaks-expected.html.
- fast/regions/auto-size/autoheight-singleregion-multiplebreaks.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-multiplebreaks.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto-breaksignored-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-breaksignored-expected.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto-breaksignored.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-breaksignored.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-expected.html.
- fast/regions/auto-size/autoheight-singleregion-overflowauto.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto.html.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-001-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-001-expected.txt.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-001.html: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-001.html.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-002-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-002-expected.txt.
- fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-002.html.
- fast/regions/auto-size/autoheight-vertical-lr-expected.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-lr-expected.html.
- fast/regions/auto-size/autoheight-vertical-lr.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-lr.html.
- fast/regions/auto-size/autoheight-vertical-rl-expected.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-rl-expected.html.
- fast/regions/auto-size/autoheight-vertical-rl.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-rl.html.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 3:40 PM Changeset in webkit [157141] by
-
- 4 edits in trunk/Websites/webkit.org
Refined power management in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122525
Reviewed by Gavin Barraclough.
Sync'd sunspider-1.0.2 to PerformanceTests/SunSpider/hosted/sunspider-1.0.2.
- perf/sunspider-1.0.2/sunspider-1.0.2/driver.html:
- perf/sunspider-1.0.2/sunspider-1.0.2/sunspider-test-contents.js:
- perf/sunspider-1.0.2/sunspider.css:
(#frameparent):
(#countdown):
- 3:40 PM Changeset in webkit [157140] by
-
- 4 edits in trunk/PerformanceTests/SunSpider
Refined power management in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122525
Reviewed by Gavin Barraclough.
- hosted/sunspider.css:
(#frameparent):
(#countdown):
- resources/TEMPLATE.html: Provide an explicit countdown element in the
parent, instead of hacking it into each child frame.
- resources/driver-TEMPLATE.html: Be more explicit about how we respond
to power management. Just moving setTimeout(0) inside the loop is a
little too subtle, and may not work across browsers.
Also, leave a little extra time after changing the countdown graphic,
to give the browser some time to paint.
- 2:57 PM Changeset in webkit [157139] by
-
- 2 edits in trunk/LayoutTests
Unreviewed followup to https://bugs.webkit.org/show_bug.cgi?id=122523
This test now passes, so updating expected file.
- fast/canvas/webgl/webgl-unprefixed-context-id-expected.txt:
- 2:17 PM Changeset in webkit [157138] by
-
- 4 edits2 adds in trunk
Support unprefixed WebGL context creation
https://bugs.webkit.org/show_bug.cgi?id=122523
<rdar://problem/15179463>
Reviewed by Simon Fraser.
Source/WebCore:
Add support for the unprefixed "webgl" canvas context type.
Test: fast/canvas/webgl/unprefixed-context.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::is3dType):
- inspector/InjectedScriptCanvasModuleSource.js:
LayoutTests:
Tests that we can create a context without the
"experimental-" prefix. Meanwhile, most of the other
WebGL tests should start to use the unprefixed
form automatically (the helper script attempts
"webgl" first).
- fast/canvas/webgl/unprefixed-context-expected.txt: Added.
- fast/canvas/webgl/unprefixed-context.html: Added.
- 2:05 PM Changeset in webkit [157137] by
-
- 15 edits in trunk/Source/WebKit2
WebProcess crash on SAP WebCycle web app
https://bugs.webkit.org/show_bug.cgi?id=122520
<rdar://problem/15030605>
Reviewed by Darin Adler.
Stop trying to use RunLoop to manage the top-level run loop and just have the child process and their
delegate subclasses start and stop the run loops. This fixes a bug with showModalDialog where we would
unintentionally call -[NSApp stop] when closing a modal dialog.
This also lets us move all knowledge of NSApplication from RunLoop. (Both the web process and plug-in process
need to use -[NSApp run] and -[NSApp stop:]).
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
(WebKit::PluginProcessMainDelegate::doPreInitializationWork):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop. Add a startRunLoop override that calls
-[NSApp run].
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(PluginServiceInitializer):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.
- PluginProcess/PluginProcess.h:
Add stopRunLoop() override on Mac.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::stopRunLoop):
Call -[NSApp stop:] and tickle the event system.
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::stopRunLoop):
Add default implementation that just calls RunLoop::main()->stop().
(WebKit::ChildProcess::terminate):
Call stopRunLoop().
- Shared/ChildProcess.h:
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
Add startRunLoop member function and call it instead of RunLoop::run().
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
(WebKit::ChildProcessMainDelegate::startRunLoop):
Call RunLoop::run().
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.
Add startRunLoop override that calls -[NSApp run].
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):
Call stopRunLoop().
- WebProcess/WebProcess.h:
Add stopRunLoop override.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::stopRunLoop):
Call -[NSApp stop:] and tickle the event system.
- 1:58 PM Changeset in webkit [157136] by
-
- 18 edits in trunk/Source/WebCore
Rename EventDispatchMediator::dispatchEvent to mediateAndDispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=122522
Reviewed by Darin Adler.
Renamed EventDispatchMediator::dispatchEvent to EventDispatchMediator::mediateAndDispatchEvent
to make the future refactoring easier.
- Modules/indieui/UIRequestEvent.cpp:
(WebCore::UIRequestEventDispatchMediator::mediateAndDispatchEvent):
- Modules/indieui/UIRequestEvent.h:
- dom/EventDispatchMediator.cpp:
(WebCore::EventDispatchMediator::mediateAndDispatchEvent):
- dom/EventDispatchMediator.h:
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::BlurEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::FocusInEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::FocusOutEventDispatchMediator::mediateAndDispatchEvent):
- dom/FocusEvent.h:
- dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::mediateAndDispatchEvent):
- dom/GestureEvent.h:
- dom/KeyboardEvent.cpp:
(WebCore::KeyboardEventDispatchMediator::mediateAndDispatchEvent):
- dom/KeyboardEvent.h:
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::mediateAndDispatchEvent):
- dom/MouseEvent.h:
- dom/TouchEvent.cpp:
(WebCore::TouchEventDispatchMediator::mediateAndDispatchEvent):
- dom/TouchEvent.h:
- dom/WheelEvent.cpp:
(WebCore::WheelEventDispatchMediator::mediateAndDispatchEvent):
- dom/WheelEvent.h:
- 1:42 PM Changeset in webkit [157135] by
-
- 2 edits in trunk/Source/WebCore
[MathML] Use of floating point floor/ceil on LayoutUnits seems wrong
https://bugs.webkit.org/show_bug.cgi?id=122367
Reviewed by Darin Adler.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::paintCharacter): Use member methods to compute
correct floor/ceil values for LayoutUnits.
- 1:38 PM Changeset in webkit [157134] by
-
- 2 edits in trunk/LayoutTests
Skip a new WebGL test along with the others.
- platform/gtk/TestExpectations:
- 1:34 PM Changeset in webkit [157133] by
-
- 3 edits2 adds in trunk
Video -> pixel buffer output should not manage color spaces
https://bugs.webkit.org/show_bug.cgi?id=122486
Reviewed by Tim Horton.
Source/WebCore:
On Mac, when we draw a video into a canvas or WebGL, the
output of the video should not be color managed. Instead, leave it
as DeviceRGB so that it matches other colors in those elements.
We'll hopefully solve this properly soon - making everything sRGB.
Test: media/video-canvas-drawing-output.html
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect): Pass on
a CGImageRef via CGImageCreateCopyWithColorSpace rather than the raw data.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): Tell CoreImage
to allocate a pixel buffer that is unmanaged.
LayoutTests:
- media/video-canvas-drawing-output-expected.txt: Added.
- media/video-canvas-drawing-output.html: Added.
- 1:30 PM Changeset in webkit [157132] by
-
- 2 edits in trunk/Source/WebCore
[MediaStream] Fix segfault in initializeMockSources()
https://bugs.webkit.org/show_bug.cgi?id=122517
Reviewed by Darin Adler.
Calling release() and a member function on the same RefPtr
as arguments to a function can lead to segfaults if the release
call is evaluated first.
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::initializeMockSources):
- 1:26 PM Changeset in webkit [157131] by
-
- 3 edits in trunk/Tools
Fix ruby LoadError when running run-javascriptcore-tests.
https://bugs.webkit.org/show_bug.cgi?id=122519.
Reviewed by Mark Hahnenberg.
The scripts needed to explicitly require 'rubygems' for older versions of ruby
(versions before 1.9).
- Scripts/jsc-stress-test-helpers/profiler-test-helper:
- Scripts/run-jsc-stress-tests:
- 1:25 PM Changeset in webkit [157130] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/gtk/TestExpectations: fast/backgrounds/background-opaque-images-over-color.html
failing.
- 1:03 PM Changeset in webkit [157129] by
-
- 4 edits in trunk
[CSSRegions] Regions with overflow: hidden should paint over positioned sibling
https://bugs.webkit.org/show_bug.cgi?id=122389
Reviewed by Alexandru Chiculita.
Source/WebCore:
As a follow-up from https://bugs.webkit.org/show_bug.cgi?id=122321, a region should not
be a normal flow layer when it has overflow clip. Change existing test by adding overflow:hidden
to the region element.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
LayoutTests:
Add overflow: hidden to the region to test that it does not move to the normal flow layers.
- fast/regions/layers/region-normalflow-stacking-context.html:
- 12:58 PM Changeset in webkit [157128] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening, these tests had a couple pixels shift at some point,
needing a new baseline.
- platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
- platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
- platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
- 12:44 PM Changeset in webkit [157127] by
-
- 2 edits in trunk/Source/WebCore
Simplify the loop in EventRetargeter::calculateEventPath
https://bugs.webkit.org/show_bug.cgi?id=122500
Reviewed by Antti Koivisto.
Replaced the convoluted loop by two nested loops to make semantics clear.
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::calculateEventPath):
- 12:27 PM Changeset in webkit [157126] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unskip editing/spelling/spelling-changed-text.html
https://bugs.webkit.org/show_bug.cgi?id=122502
Unreviewed gardening.
- platform/mac/TestExpectations:
spelling-changed.html is passing after r156901.
- 12:13 PM Changeset in webkit [157125] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. A couple of media-query tests rely on 3d transforms,
so skip them along with the 3d transforms tests.
- platform/gtk/TestExpectations:
- 11:25 AM Changeset in webkit [157124] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Leak: GdkEvent retured by gtk_get_current_event is not freed.
https://bugs.webkit.org/show_bug.cgi?id=122506
Reviewed by Gustavo Noronha Silva.
Gdk event returned by gtk_get_current_event should be freed after using it.
No functionality changed.
- platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::show):
- 11:03 AM Changeset in webkit [157123] by
-
- 6 edits in trunk/Source/WebCore
Use references in EventRetargeter::calculateEventPath and EventRetargeter::eventTargetRespectingTargetRules
https://bugs.webkit.org/show_bug.cgi?id=122494
Reviewed by Antti Koivisto.
Use referenecs instead of pointers in ventRetargeter's calculateEventPath and eventTargetRespectingTargetRules.
Also replace Vector<EventTarget*, 32> targetStack by a single pointer since we only append an item to
the vector when it's empty and we always use the last item.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::calculateEventPath):
- dom/EventRetargeter.h:
(WebCore::EventRetargeter::eventTargetRespectingTargetRules):
- dom/Node.cpp:
(WebCore::Node::dispatchScopedEventDispatchMediator):
- 10:59 AM Changeset in webkit [157122] by
-
- 2 edits in trunk/Tools
Unreviewed, add my new email to contributors.json.
Patch by Christophe Dumez <Christophe Dumez> on 2013-10-08
- Scripts/webkitpy/common/config/contributors.json:
- 10:33 AM Changeset in webkit [157121] by
-
- 8 edits2 adds in trunk
[CSSRegions] Computed z-Index should return 0 instead of auto for a region
https://bugs.webkit.org/show_bug.cgi?id=122405
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/regions/layers/region-zIndex-computedStyle.html
Adjust the z-index value for a region. Also, since a box with a z-Index
that is non-auto receives a layer, i removed the requiresLayer override
in RenderRegion and RenderMultiColumnSet.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- rendering/RenderMultiColumnSet.cpp:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.cpp:
- rendering/RenderRegion.h:
- rendering/style/RenderStyle.h:
LayoutTests:
- fast/regions/layers/region-zIndex-computedStyle-expected.txt: Added.
- fast/regions/layers/region-zIndex-computedStyle.html: Added.
- 10:33 AM Changeset in webkit [157120] by
-
- 5 edits2 adds in trunk
[CSS Regions] Widows don't work if the first line in a region is aligned with the top of the region
https://bugs.webkit.org/show_bug.cgi?id=122450
Reviewed by David Hyatt.
Source/WebCore:
The patch adds a new function updateRegionForLine that updates the containing region for a line and the
flag used to determine if it's the first line in that region. This is necessary because the code in
adjustLinePositionForPagination is not sufficient to determine when an unforced break occurs and the line
being positioned is the first one in the fragmentation container or not.
Test: fast/regions/regions-widows-float-top-aligned.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::adjustLinePositionForPagination): Added FIXME comment.
- rendering/RenderBlockFlow.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlockFlow::updateRegionForLine): New function used to update the containing region and
the first line flag.
LayoutTests:
Simple test veryfing that widows are correctly computed when there is a float affecting the lines
and when they are vertically aligned with the regions height.
- fast/regions/regions-widows-float-top-aligned-expected.html: Added.
- fast/regions/regions-widows-float-top-aligned.html: Added.
- 10:25 AM Changeset in webkit [157119] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSManagedValue should be able to store non-object JSValues
https://bugs.webkit.org/show_bug.cgi?id=122351
Reviewed by Oliver Hunt.
We decided not to support this because we thought it didn't make sense to have a
"weak" JSValue that wasn't an object.
Our general thought process was if you have a JSObject-ObjC object pair (i.e. an
Obj-C object that you exported to JavaScript-land), it makes more sense to store
a non-object JSValue on the JavaScript-land version of the object rather than as
an ivar in the Objective-C object.
In retrospect, this may not have been a good decision at least w.r.t. consistency
in client code. If you're storing a bag of JSValues off an Obj-C object, you'd
like to store all of them either in ObjC-land or JavaScript-land, but doing some
in one and some in the other doesn't sound too good. Also, what if the object you
want to hang these values off of doesn't have a corresponding object in JavaScript-
land in which to store them?
The solution is to fix JSManagedValue to be able to reference non-object JSValues.
Right now, all JSManagedValues contain a Weak<JSObject>. We'll change this so that
they can contain either a non-cell JSValue or a JSObject*, along with a weak
reference to the JSGlobalObject for reconstructing a JSValue later on.
- API/JSManagedValue.mm:
(PrimitiveOrObject::PrimitiveOrObject):
(PrimitiveOrObject::~PrimitiveOrObject):
(PrimitiveOrObject::clear):
(PrimitiveOrObject::isClear):
(PrimitiveOrObject::isSet):
(PrimitiveOrObject::isPrimitive):
(PrimitiveOrObject::isObject):
(PrimitiveOrObject::setPrimitive):
(PrimitiveOrObject::setObject):
(PrimitiveOrObject::object):
(PrimitiveOrObject::primitive):
(-[JSManagedValue initWithValue:]):
(-[JSManagedValue value]):
(-[JSManagedValue disconnectValue]):
- 10:16 AM Changeset in webkit [157118] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Adding ImageOnlyFailure expectations to:
- fast/regions/selection/selecting-text-ignoring-region-horiz-bt.html
- fast/regions/selection/selecting-text-ignoring-region-vert-lr.html
- fast/regions/selection/selecting-text-in-2-regions-horiz-bt.html
- fast/regions/selection/selecting-text-in-2-regions-vert-lr.html
- platform/gtk/TestExpectations:
- 10:12 AM Changeset in webkit [157117] by
-
- 2 edits in trunk/LayoutTests
Layout Test inspector/styles/add-new-rule-with-style-after-body.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122510
- platform/mac/TestExpectations: Marking as such.
- 10:05 AM Changeset in webkit [157116] by
-
- 2 edits in trunk/LayoutTests
Layout Test inspector/debugger/debugger-activation-crash2.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122509
- platform/mac/TestExpectations: Marking as such.
- 9:52 AM Changeset in webkit [157115] by
-
- 2 edits in trunk/LayoutTests
Layout Test compositing/video/video-reflection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122508
- platform/mac/TestExpectations: Marking as such.
- 9:47 AM Changeset in webkit [157114] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/track/track-cue-rendering.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122507
- platform/mac/TestExpectations: Marking as such.
- 9:43 AM Changeset in webkit [157113] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, rolling out r157080.
http://trac.webkit.org/changeset/157080
Not a proper baseline
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.png: Removed.
- platform/gtk/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.png: Removed.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.png: Removed.
- platform/gtk/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.png: Removed.
- 9:42 AM Changeset in webkit [157112] by
-
- 2 edits in trunk/Tools
Unreviewed build correction.
- Scripts/webkitpy/port/win.py:
(WinPort.write_registry_value): Use string representation of error message to avoid
format conversion problem.
- 9:38 AM Changeset in webkit [157111] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: media/video-layer-crash.html
https://bugs.webkit.org/show_bug.cgi?id=114744
- platform/mac/TestExpectations: Marking as such.
- 9:36 AM Changeset in webkit [157110] by
-
- 3 edits in trunk/Source/WebCore
Get EFL and GTK compiling with media stream enabled
https://bugs.webkit.org/show_bug.cgi?id=122505
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-08
Reviewed by Philippe Normand.
After r157068
No new tests needed.
- GNUmakefile.list.am:
- UseJSC.cmake:
- 9:31 AM Changeset in webkit [157109] by
-
- 3 edits in trunk/Source/WebKit/mac
WebNetscapePluginView should no longer use deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=122495
Reviewed by Anders Carlsson.
- Plugins/WebNetscapePluginView.h: Use unique_ptr for both the pointer to
the timers hash table, and for the values in the hash table.
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView stopTimers]): Rewrote loop so it works with unique_ptr.
(-[WebNetscapePluginView startTimers]): Ditto.
(-[WebNetscapePluginView fini]): Removed unneeded code to delete timers.
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): Make
the timers hash table with make-unique. Fixed the loop that chooses the timer
ID so it won't ever try to use a deleted value, although that never happens
in practice. Use HashMap::add instead of using both contains and set.
Rearranged code so we don't need to make a raw pointer for the timer.
(-[WebNetscapePluginView unscheduleTimer:]): Use remove instead of take/delete,
since remove takes care of the deletion automatically since we are using the
unique_ptr class.
- 8:56 AM Changeset in webkit [157108] by
-
- 3 edits2 adds in trunk
Composited layer that painted into composited ancestor is not repainted after moving
https://bugs.webkit.org/show_bug.cgi?id=114655
Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2013-10-08
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/repaint/absolute-painted-into-composited-ancestor.html
Composited layers are currently skipping repainting after layout,
if the repaint status is not NeedsFullRepaint. However, in case layers
were painted into composited ancestor, they need to repaint.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldRepaintAfterLayout):
LayoutTests:
Add a text repaint test to check the repainting of composited layer
that painted into composited ancestor.
- compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt: Added.
- compositing/repaint/absolute-painted-into-composited-ancestor.html: Added.
- 8:51 AM Changeset in webkit [157107] by
-
- 3 edits in trunk/Tools
[Win] Add checks for proper build and test environment
https://bugs.webkit.org/show_bug.cgi?id=122466
Reviewed by Darin Adler.
This patch makes two changes:
- Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or error messages so that people know what to fix to get things working.
- Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure the various environment settings are properly configured for our test environment.
- Scripts/webkitdirs.pm:
(checkInstalledTools): Add checks for some common Cygwin configuration problems that have
caused problems in the past.
(setupAppleWinEnv):
- Scripts/webkitpy/port/win.py:
(WinPort):
(WinPort.read_registry_string): Parameterize for run architecture and registry root.
(WinPort.write_registry_value): Parameterize registry writing by data type (string versus
DWORD, etc.)
(WinPort.write_registry_string): Revise to call new generic registry write function.
(WinPort.setup_crash_log_saving): Revise for new API
(WinPort.restore_crash_log_saving): Ditto
(WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
servers from running.
(WinPort.allow_error_dialogs): Ditto.
(WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
(WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
- 8:45 AM Changeset in webkit [157106] by
-
- 2 edits in trunk/Tools
[GStreamer] enable v4l2 plugin
https://bugs.webkit.org/show_bug.cgi?id=122503
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Enable the plugin, it now builds fine since
we updated our GStreamer version to 1.0.8.
- 8:28 AM Changeset in webkit [157105] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r157090.
http://trac.webkit.org/changeset/157090
https://bugs.webkit.org/show_bug.cgi?id=122504
Caused crashes in many plug-in tests (Requested by ap on
#webkit).
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject):
(WebKit::NPRemoteObjectMap::pluginDestroyed):
- Shared/Plugins/NPRemoteObjectMap.h:
- 8:15 AM Changeset in webkit [157104] by
-
- 2 edits in trunk
[GTK] Re-enable MathML for release builds
https://bugs.webkit.org/show_bug.cgi?id=122361
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-10-08
Reviewed by Darin Adler.
- Source/autotools/SetupWebKitFeatures.m4: Enable MathML for release builds.
- 8:12 AM Changeset in webkit [157103] by
-
- 5 edits in tags/Safari-538.1.3/Source
Versioning.
- 8:10 AM Changeset in webkit [157102] by
-
- 1 copy in tags/Safari-538.1.3
New Tag.
- 7:56 AM Changeset in webkit [157101] by
-
- 3 edits in trunk/Source/WebKit/mac
Eliminate use of deleteAllValues in ProxyInstance
https://bugs.webkit.org/show_bug.cgi?id=122499
Reviewed by Anders Carlsson.
- Plugins/Hosted/ProxyInstance.h: Use unique_ptr for map values in m_fields and m_methods.
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::~ProxyInstance): Removed calls to deleteAllValues.
(WebKit::ProxyInstance::methodNamed): Use make_unique and get to deal with map entries
that are unique_ptr. Also fixed a bug where this would do an expensive no-op if the map
already had an entry with a null in it. We would call the plug-in, but eventually
isNewEntry would be false so we would return null.
(WebKit::ProxyInstance::fieldNamed): Use make_unique and get to deal with map entries
that are unique_ptr.
- 7:39 AM Changeset in webkit [157100] by
-
- 5 edits2 deletes in trunk
Unreviewed. Rollout of r156536. ~5% regression in inline layout performance.
Source/WebCore:
- rendering/LineWidth.cpp:
- rendering/LineWidth.h:
(WebCore::LineWidth::addUncommittedWidth):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Removed.
- fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Removed.
- 5:57 AM Changeset in webkit [157099] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Unskip tests that are already passing.
- platform/efl-wk1/TestExpectations: Mark unskipped test as failing for WK1.
- platform/efl/TestExpectations:
- 5:07 AM Changeset in webkit [157098] by
-
- 12 edits in trunk/Source/WebCore
Use toCSSFooValue() instead of using static_cast<const CSSFooValue*>
https://bugs.webkit.org/show_bug.cgi?id=122491
Reviewed by Andreas Kling.
static_cast<const CSSFooValue*> wasn't cleanup. So, we need to use toCSSFooValue() for it.
To use toCSSValue() will help to detect bad type-cast.
Besides static_cast<const WebKitCSSFooValue*> helper functions need to be added to support this use.
No new tests, no behavior change.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyMatches):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::isFixedSize):
(WebCore::CSSImageGeneratorValue::isPending):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):
- css/CSSValue.cpp:
(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::hasFailedOrCanceledSubresources):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::serializeResolvingVariables):
(WebCore::CSSValue::cloneForCSSOM):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::PropertyReference::cssName):
- css/WebKitCSSSVGDocumentValue.h:
(WebCore::toWebKitCSSSVGDocumentValue):
- css/WebKitCSSTransformValue.h:
(WebCore::toWebKitCSSTransformValue):
- 4:39 AM Changeset in webkit [157097] by
-
- 2 edits in trunk/Source/WebCore
Get MediaStreamCenterGStreamer compiling again
https://bugs.webkit.org/show_bug.cgi?id=122482
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-08
Reviewed by Eric Carlson.
r157068 was including a nonexistent header
No new tests needed.
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
- 3:55 AM Changeset in webkit [157096] by
-
- 5 edits in trunk
[ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
https://bugs.webkit.org/show_bug.cgi?id=122104
Reviewed by Chris Fleizach.
Source/WebCore:
Map invalid state of an AccessibilityObject to the proper AtkState.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkStateSetFromCoreObject): Add the mapping.
Tools:
Updated stringAttributeValue to double check that the exposure of
aria-invalid as a state is consistent with its exposure as a text
attribute as well, when it applies (implementations of AtkText).
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringAttributeValue): Add double check.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
- 3:45 AM Changeset in webkit [157095] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Name for tables are now properly showing
up when exposing information for the parent of a table's cell.
- platform/gtk/accessibility/table-cells-expected.txt: Updated.
- 2:56 AM Changeset in webkit [157094] by
-
- 12 edits in trunk/LayoutTests
context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901
https://bugs.webkit.org/show_bug.cgi?id=122414
Reviewed by Ryosuke Niwa.
On Mac, first call of 'initSpellTest' from spelling/resources/util.js
often fails while checking spelling marker.
Use shouldBecomeDifferent instead of calling timers in the tests.
It should have been done at r156137 when shouldBecomeEqual/Different
was used in asynchronous spell checking tests.
- editing/spelling/resources/util.js:
Use shouldBecomeDifferent instead of timers.
- editing/spelling/context-menu-suggestions-multiword-selection-expected.txt:
- editing/spelling/context-menu-suggestions-subword-selection-expected.txt:
- editing/spelling/spelling-changed-text-expected.txt:
- editing/spelling/spelling-double-clicked-word-expected.txt:
- editing/spelling/spelling-exactly-selected-multiple-words-expected.txt:
- editing/spelling/spelling-exactly-selected-word-expected.txt:
- editing/spelling/spelling-should-select-multiple-words-expected.txt:
- editing/spelling/spelling-with-punctuation-selection-expected.txt:
- editing/spelling/spelling-with-whitespace-selection-expected.txt:
Rebaseline the tests which include util.js due to
shouldBecomeDifferent outputs more logs.
- platform/mac/TestExpectations:
Now context-menu-suggestions-multiword-selection.html and
context-menu-suggestions-subword-selection.html are passing for Mac.
- 2:41 AM Changeset in webkit [157093] by
-
- 2 edits in trunk/Source/JavaScriptCore
JavaScriptCore fails to build
https://bugs.webkit.org/show_bug.cgi?id=122440
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-08
Reviewed by Darin Adler.
Compilation fails in debug due to 'comparison of unsigned expression >= 0 is
always true'.
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::positionForCallFrame): Removed the offending ASSERTS.
- 2:01 AM Changeset in webkit [157092] by
-
- 1 edit32 moves1 add in trunk/LayoutTests
[CSSRegions] Move autosize and autowidth tests into fast/regions/auto-size
https://bugs.webkit.org/show_bug.cgi?id=122493
Reviewed by Andreas Kling.
Simple move, changed paths in 2 tests.
- fast/regions/auto-size/autosize-abspos-anchoredregion-expected.txt: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-expected.txt.
- fast/regions/auto-size/autosize-abspos-anchoredregion-vertlr-expected.txt: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-vertlr-expected.txt.
- fast/regions/auto-size/autosize-abspos-anchoredregion-vertlr.html: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-vertlr.html.
- fast/regions/auto-size/autosize-abspos-anchoredregion.html: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion.html.
- fast/regions/auto-size/autosize-region-container-resize-expected.html: Renamed from LayoutTests/fast/regions/autosize-region-container-resize-expected.html.
- fast/regions/auto-size/autosize-region-container-resize.html: Renamed from LayoutTests/fast/regions/autosize-region-container-resize.html.
- fast/regions/auto-size/autosize-region-window-resize-expected.html: Renamed from LayoutTests/fast/regions/autosize-region-window-resize-expected.html.
- fast/regions/auto-size/autosize-region-window-resize.html: Renamed from LayoutTests/fast/regions/autosize-region-window-resize.html.
- fast/regions/auto-size/autowidth-abspos-expected.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-expected.html.
- fast/regions/auto-size/autowidth-abspos-regionchain-expected.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-regionchain-expected.html.
- fast/regions/auto-size/autowidth-abspos-regionchain.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-regionchain.html.
- fast/regions/auto-size/autowidth-abspos.html: Renamed from LayoutTests/fast/regions/autowidth-abspos.html.
- fast/regions/auto-size/autowidth-attachedinvalidregion-expected.txt: Renamed from LayoutTests/fast/regions/autowidth-attachedinvalidregion-expected.txt.
- fast/regions/auto-size/autowidth-attachedinvalidregion.html: Renamed from LayoutTests/fast/regions/autowidth-attachedinvalidregion.html.
- fast/regions/auto-size/autowidth-float-expected.html: Renamed from LayoutTests/fast/regions/autowidth-float-expected.html.
- fast/regions/auto-size/autowidth-float.html: Renamed from LayoutTests/fast/regions/autowidth-float.html.
- fast/regions/auto-size/autowidth-inlineblock-expected.html: Renamed from LayoutTests/fast/regions/autowidth-inlineblock-expected.html.
- fast/regions/auto-size/autowidth-inlineblock.html: Renamed from LayoutTests/fast/regions/autowidth-inlineblock.html.
- fast/regions/auto-size/autowidth-nonreplaced-abspos-expected.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplaced-abspos-expected.html.
- fast/regions/auto-size/autowidth-nonreplaced-abspos.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplaced-abspos.html.
- fast/regions/auto-size/autowidth-nonreplacedblock-normalflow-expected.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplacedblock-normalflow-expected.html.
- fast/regions/auto-size/autowidth-nonreplacedblock-normalflow.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplacedblock-normalflow.html.
- fast/regions/auto-size/autowidth-normalflow-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-expected.html.
- fast/regions/auto-size/autowidth-normalflow-maxwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-maxwidth-expected.html.
- fast/regions/auto-size/autowidth-normalflow-maxwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-maxwidth.html.
- fast/regions/auto-size/autowidth-normalflow-minmaxwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minmaxwidth-expected.html.
- fast/regions/auto-size/autowidth-normalflow-minmaxwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minmaxwidth.html.
- fast/regions/auto-size/autowidth-normalflow-minwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minwidth-expected.html.
- fast/regions/auto-size/autowidth-normalflow-minwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minwidth.html.
- fast/regions/auto-size/autowidth-normalflow-vertrl-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-vertrl-expected.html.
- fast/regions/auto-size/autowidth-normalflow-vertrl.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-vertrl.html.
- fast/regions/auto-size/autowidth-normalflow.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow.html.
- 1:07 AM Changeset in webkit [157091] by
-
- 4 edits in trunk
[GTK] media/video-src-blob.html
https://bugs.webkit.org/show_bug.cgi?id=102586
Reviewed by Martin Robinson.
Source/WebCore:
Add support for loading videos using blob URLs.
Fixes media/video-src-blob.html.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart): Use BufferData buffering policy for blob
URLs.
(webKitWebSrcGetProtocols): Add blob to the list of supported
protocols.
(webKitWebSrcSetUri): Consider blob URLs as valid.
LayoutTests:
- platform/gtk/TestExpectations: Unskip
media/video-src-blob.html.
- 12:58 AM Changeset in webkit [157090] by
-
- 3 edits in trunk/Source/WebKit2
Remove use of deleteAllValues in NPRemoteObjectMap::pluginDestroyed
https://bugs.webkit.org/show_bug.cgi?id=122496
Reviewed by Andreas Kling.
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject): Don't call release when putting objects
into the map.
(WebKit::NPRemoteObjectMap::pluginDestroyed): Instead of making an array of receivers
and deleting them all, remove all of the receivers from the map, which will take care
of deleting them. Also change the other loop to use a similar coding style.
- Shared/Plugins/NPRemoteObjectMap.h: Change the value type of m_registeredNPObjects
to be unique_ptr instead of a raw pointer.
- 12:45 AM Changeset in webkit [157089] by
-
- 7 edits in trunk/Source/WebKit/mac
Change NetscapePluginInstanceProxy::m_replies to use unique_ptr instead of deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=122492
Reviewed by Andreas Kling.
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin): Use auto so this works with
unique_ptr instead of auto_ptr.
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCGetScriptableNPObjectReply): Use make_unique instead of using new directly.
(WKPCBooleanReply): Ditto.
(WKPCBooleanAndDataReply): Ditto.
(WKPCInstantiatePluginReply): Ditto.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: Changed m_replies to map to unique_ptr
instead of to a raw pointer.
(WebKit::NetscapePluginInstanceProxy::setCurrentReply): Changed to take a unique_ptr
instead of a raw pointer since this takes ownership of the pointer.
(WebKit::NetscapePluginInstanceProxy::waitForReply): Changed to return a unique_ptr
instead of a auto_ptr because that's better. Use unique_ptr inside the function
too to avoid the need for an explicit delete.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy): Removed the call to
deleteAllValues.
(WebKit::NetscapePluginInstanceProxy::cancelStreamLoad): Removed unneeded initialization
of a local variable that was already set in all code paths.
(WebKit::NetscapePluginInstanceProxy::wheelEvent): Use auto so this works with unique_ptr
instead of auto_ptr.
(WebKit::NetscapePluginInstanceProxy::print): Ditto.
(WebKit::NetscapePluginInstanceProxy::snapshot): Ditto. Ditto.
(WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Changed to return
a unique_ptr. Also removed an unneeded assertion.
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Use auto so this works
with unique_ptr instead of auto_ptr.
- Plugins/Hosted/ProxyInstance.h: Changed return type of waitForReply to unique_ptr.
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invoke): Use auto so this works with unique_ptr instead of auto_ptr.
(WebKit::ProxyInstance::supportsInvokeDefaultMethod): Ditto.
(WebKit::ProxyInstance::supportsConstruct): Ditto.
(WebKit::ProxyInstance::getPropertyNames): Ditto.
(WebKit::ProxyInstance::methodNamed): Ditto.
(WebKit::ProxyInstance::fieldNamed): Ditto.
(WebKit::ProxyInstance::fieldValue): Ditto.
(WebKit::ProxyInstance::setFieldValue): Ditto.
