Timeline
Nov 18, 2013:
- 11:53 PM Changeset in webkit [159487] by
-
- 23 edits2 copies1 add2 deletes in trunk/Source
Unreviewed, rolling out r159455.
http://trac.webkit.org/changeset/159455
https://bugs.webkit.org/show_bug.cgi?id=124568
broke two api tests (see bug 124564) (Requested by thorton on
#webkit).
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm:
(-[DOMNode renderedImage]):
(-[DOMRange renderedImageForcingBlackText:]):
- dom/Clipboard.cpp:
(WebCore::Clipboard::createDragImage):
- dom/ClipboardMac.mm:
(WebCore::Clipboard::createDragImage):
- page/DragController.cpp:
(WebCore::DragController::startDrag):
- page/Frame.cpp:
(WebCore::ScopedFramePaintingState::ScopedFramePaintingState):
(WebCore::ScopedFramePaintingState::~ScopedFramePaintingState):
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
- page/Frame.h:
- page/FrameSnapshotting.cpp: Removed.
- page/FrameSnapshotting.h: Removed.
- page/mac/FrameMac.mm: Copied from Source/WebCore/page/win/FrameWin.h.
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
- page/mac/FrameSnapshottingMac.h: Copied from Source/WebCore/page/win/FrameWin.h.
- page/mac/FrameSnapshottingMac.mm: Added.
(WebCore::imageFromRect):
(WebCore::selectionImage):
(WebCore::rangeImage):
(WebCore::snapshotDragImage):
- page/win/FrameWin.cpp:
(WebCore::Frame::dragImageForSelection):
(WebCore::Frame::nodeImage):
- page/win/FrameWin.h:
- platform/DragImage.cpp:
(WebCore::fitDragImageToMaxSize):
(WebCore::createDragImageForLink):
- platform/DragImage.h:
Source/WebKit/ios:
- WebCoreSupport/WebFrameIOS.mm:
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _selectionDraggingImage]):
(-[WebHTMLView selectionImageForcingBlackText:]):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::renderedImage):
- 11:52 PM Changeset in webkit [159486] by
-
- 4 edits in trunk/Source
[EFL] Initialize efreet before getting directories
https://bugs.webkit.org/show_bug.cgi?id=124560
Reviewed by Gyuyoung Kim.
efreet is used to get several directories including home dierectory since
r123731, but it does not call efreet_init/efreet_shutdown explicitly.
Source/WebKit/efl:
- ewk/ewk_main.cpp: Call efreet_init()/efreet_shutdown() explicitly.
(ewk_init):
(ewk_shutdown):
Source/WebKit2:
- UIProcess/API/efl/ewk_main.cpp: Call efreet_init()/efreet_shutdown() explicitly.
(ewk_init):
(ewk_shutdown):
- 11:20 PM Changeset in webkit [159485] by
-
- 12 edits in trunk
Use hw.activecpu for determining how many processes to spawn.
It's documented as the preferred way to determine the number of threads
or processes to create in a SMP aware application.
Rubber-stamped by Tim Horton.
Source/ThirdParty/ANGLE:
- ANGLE.xcodeproj/project.pbxproj:
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
Tools:
- Scripts/copy-webkitlibraries-to-product-directory:
- Scripts/run-jsc-stress-tests:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 10:47 PM Changeset in webkit [159484] by
-
- 5 edits in trunk/Tools
build.webkit.org/dashboard builder headers should link to the builder page
https://bugs.webkit.org/show_bug.cgi?id=124553
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.get overviewURL):
Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
(BuildbotBuilderQueueView.prototype.update):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype.update.appendBuild):
(BuildbotTesterQueueView.prototype.update):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
(.queue-view .queueLabel):
(.queue-view .queueLabel:not(:first-child)):
Make the header a link instead of a label, and wire it up to overviewURL.
- 10:30 PM Changeset in webkit [159483] by
-
- 14 edits1 delete in tags/Safari-538.7/Source/JavaScriptCore
Rollout r159351. <rdar://problem/15500057>
- 10:10 PM Changeset in webkit [159482] by
-
- 3 edits2 adds in trunk
AX: aria-labelledby should be used in preference to aria-labeledby
https://bugs.webkit.org/show_bug.cgi?id=62351
Reviewed by Chris Fleizach.
Source/WebCore:
Making sure aria-labelled by overrides the incorrectly spelled aria-labeledby attribute.
Test: accessibility/aria-labelledby-overrides-aria-labeledby.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::ariaLabeledByElements):
LayoutTests:
Added test to make sure aria-labelledby overrides aria-labeledby correctly.
- accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Added.
- accessibility/aria-labelledby-overrides-aria-labeledby.html: Added.
- 10:01 PM Changeset in webkit [159481] by
-
- 5 edits2 adds in trunk
use after free in WebCore::DocumentOrderedMap::remove / WebCore::TreeScope::removeElementById
https://bugs.webkit.org/show_bug.cgi?id=121324
Reviewed by Ryosuke Niwa.
Update the document ordered map for an image element before dispatching load or error events
when it's inserted into a document.
Source/WebCore:
Test: fast/dom/modify-node-and-while-in-the-callback-too-crash.html
- dom/DocumentOrderedMap.cpp: defensive fix to avoid use after free issues.
(WebCore::DocumentOrderedMap::remove):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedInto):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement): setting m_failedLoadURL makes
repeated updateFromElement calls return early.
LayoutTests:
- fast/dom/modify-node-and-while-in-the-callback-too-crash-expected.txt: Added.
- fast/dom/modify-node-and-while-in-the-callback-too-crash.html: Added.
- 9:14 PM Changeset in webkit [159480] by
-
- 3 edits in trunk/Source/WebKit/mac
Disable deprecation warnings related to NSCalendarDate in WebHistory.
Reviewed by Anders Carlsson.
- History/WebHistory.h: Use a #pragma to have the compiler treat this header as
a system header, even when not included from a system location. This has the effect
of suppressing warnings when including this header. It's a more general effect than
we're after but is also less invasive than disabling deprecation warnings around
the APIs that are defined in terms of NSCalendarDate. We'll hopefully revisit this
in the future.
- History/WebHistory.mm: Disable deprecation warnings around uses of NSCalendarDate.
- 8:55 PM Changeset in webkit [159479] by
-
- 5 edits in trunk/Source/WebCore
Upstream iOS's ResourceHandle implementation
https://bugs.webkit.org/show_bug.cgi?id=124554
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-18
Reviewed by Sam Weinig.
- platform/network/ResourceHandle.h:
(WebCore::ResourceHandle::quickLookHandle):
(WebCore::ResourceHandle::setQuickLookHandle):
- platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::connectionProperties):
(WebCore::ResourceHandleClient::shouldCacheResponse):
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::synthesizeRedirectResponseIfNecessary):
(WebCore::willSendRequest):
(WebCore::didReceiveResponse):
(WebCore::didReceiveDataArray):
(WebCore::didReceiveData):
(WebCore::didFinishLoading):
(WebCore::didFail):
(WebCore::willCacheResponse):
(WebCore::canRespondToProtectionSpace):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::willSendRequest):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandle::currentRequest):
(WebCore::ResourceHandle::connectionClientCallbacks):
- 7:50 PM Changeset in webkit [159478] by
-
- 5 edits in trunk/Source
Versioning.
- 7:47 PM Changeset in webkit [159477] by
-
- 1 copy in tags/Safari-538.7
New Tag.
- 6:41 PM Changeset in webkit [159476] by
-
- 3 edits in trunk/LayoutTests
[EFL] Layout tests need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124477
Unreviewed, EFL rebaseline.
EFL tests are rebaselined after r126683 and r140149.
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-18
- platform/efl/fast/block/float/016-expected.txt:
- platform/efl/fast/forms/textAreaLineHeight-expected.txt:
- 5:13 PM Changeset in webkit [159475] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Update WebInspectorUI to use the new "nodeIds" parameter for DOM.performSearch
https://bugs.webkit.org/show_bug.cgi?id=124544
Reviewed by Joseph Pecoraro.
Added the new DOM.performSearch "nodeIds" parameter and made the two implementations
of DOMTreeContentView provide the right context node ids.
DOMTreeContentView is just using the id of the document node while ContentFlowDOMTreeContentView
is passing the list of content nodes.
Note that adding an extra optional parameter to DOM.performSearch does not break iOS 6 and 7 compatibility.
- UserInterface/ContentFlowDOMTreeContentView.js:
(WebInspector.ContentFlowDOMTreeContentView.prototype.getSearchContextNodes):
- UserInterface/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype.performSearch.contextNodesReady):
(WebInspector.DOMTreeContentView.prototype.performSearch):
(WebInspector.DOMTreeContentView.prototype.getSearchContextNodes):
- UserInterface/FrameDOMTreeContentView.js:
(WebInspector.FrameDOMTreeContentView.prototype.getSearchContextNodes):
- UserInterface/InspectorBackendCommands.js:
- 5:00 PM Changeset in webkit [159474] by
-
- 2 edits in trunk/Source/WebKit2
Let's try this again.
- UIProcess/PageLoadState.cpp:
- 4:56 PM Changeset in webkit [159473] by
-
- 4 edits in trunk/Source
Unreviewed, rolling out r159430.
http://trac.webkit.org/changeset/159430
https://bugs.webkit.org/show_bug.cgi?id=124548
WebCore can know nothing about nor use files from WebKit/
(Requested by thorton on #webkit).
Source/WebCore:
- DerivedSources.make:
Source/WebKit/win:
- WebView.cpp:
(webKitVersionString):
- 4:50 PM Changeset in webkit [159472] by
-
- 2 edits in trunk/Source/WebKit2
Disable assertions in PageLoadState.cpp for now.
- UIProcess/PageLoadState.cpp:
- 4:46 PM Changeset in webkit [159471] by
-
- 2 edits in trunk/Source/WebKit2
TestWebKitAPI crashes when running under GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=124546
Reviewed by Tim Horton.
- UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::downloadFinished):
Grab the download ID before removing the DownloadProxy from the map.
- 4:45 PM Changeset in webkit [159470] by
-
- 4 edits in trunk/Source/WebCore
Remove IDBServerConnection's deprecatedBackingStore()
https://bugs.webkit.org/show_bug.cgi?id=124547
Reviewed by Tim Horton.
It is no longer needed, as the front end no longer knows about the backing store.
- Modules/indexeddb/IDBServerConnection.h:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
- 4:35 PM Changeset in webkit [159469] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARM64 CRASH: Debug builds crash in emitPointerValidation()
https://bugs.webkit.org/show_bug.cgi?id=124545
Reviewed by Filip Pizlo.
Changed emitPointerValidation() to use pushToSave() and popToRestore() as
all macro assemblers have an implementation of these functions.
- jit/ThunkGenerators.cpp:
(JSC::emitPointerValidation):
- 4:32 PM Changeset in webkit [159468] by
-
- 15 edits2 adds in trunk
AX: Add ability to fetch only visible table rows.
https://bugs.webkit.org/show_bug.cgi?id=124430
Reviewed by Chris Fleizach.
Source/WebCore:
Adding AccessibilityTable::visibleRows method to support AXVisibleRows attribute mac platform.
Test: platform/mac/accessibility/table-visible-rows.html
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::visibleRows):
- accessibility/AccessibilityTable.h:
- accessibility/AccessibilityTableRow.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
as the test guidelines state, our tests should be more focused and specific about what they test.
- DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementArrayAttributeValueCallback):
(AccessibilityUIElement::uiElementArrayAttributeValue):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementArrayAttributeValue):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::getUIElementsWithAttribute):
(WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
LayoutTests:
Adding test to make sure AXVisibleRows behaves correctly.
- platform/mac/accessibility/table-visible-rows-expected.txt: Added.
- platform/mac/accessibility/table-visible-rows.html: Added.
- 4:17 PM Changeset in webkit [159467] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Update localizedStrings, remove stale string
https://bugs.webkit.org/show_bug.cgi?id=124543
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-18
Reviewed by Jessie Berlin.
Remove stale localized strings after r124543 remove the old color picker.
- Localizations/en.lproj/localizedStrings.js:
- 4:07 PM Changeset in webkit [159466] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARM64: Update getHostCallReturnValue() to use architected frame pointer register
https://bugs.webkit.org/show_bug.cgi?id=124520
Reviewed by Filip Pizlo.
Changed from using the prior JSC specific x25 callframe register to the ARM64
architected x29 (fp) register. This change should have been done as part of
https://bugs.webkit.org/show_bug.cgi?id=123956.
- jit/JITOperations.cpp:
- 3:40 PM Changeset in webkit [159465] by
-
- 9 edits in trunk
Simplify and reformat the output of performance tests inside test runners
https://bugs.webkit.org/show_bug.cgi?id=124496
Reviewed by Antti Koivisto.
PerformanceTests:
As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output performance tests generate.
Also modernize the output to better support "metric" concept we introduced a while ago.
New output on Dromaeo/dom-attr looks like this:
Running 5 times
getAttribute -> [1105, 1108, 1134, 1137, 1154]
element.property -> [1634, 1655, 1685, 1696, 1723]
setAttribute -> [646.3536463536464, 651, 651, 656.3436563436563, 658]
element.property = value -> [934, 949, 963, 964, 974]
element.expando = value -> [419, 419.5804195804196, 421.57842157842157, 425.57442557442556, 429]
element.expando -> [501, 517, 519.4805194805194, 521.4785214785214, 525]
1: 117.40644785571585 runs/s
2: 118.84720469666297 runs/s
3: 119.80547640905021 runs/s
4: 120.51886194758805 runs/s
5: 121.51924380569295 runs/s
:Time -> [117.40644785571585, 118.84720469666297, 119.80547640905021, 120.51886194758805, 121.51924380569295] runs/s
mean: 119.619446942942 runs/s
median: 119.80547640905021 runs/s
stdev: 1.5769040458730506 runs/s
min: 117.40644785571585 runs/s
max: 121.51924380569295 runs/s
- Dromaeo/resources/dromaeorunner.js:
(DRT.progress): Use the new format for subtest reports.
- resources/runner.js:
(.): Declare verboseLogging, which is set to true outside of test runners.
(PerfTestRunner.logInfo): Use verboseLogging instead of directly checking window.testRunner.
(PerfTestRunner.logDetail): Added. Logs informative text with a label such as "mean: 123 s" with 4-space indentation.
(PerfTestRunner.logStatistics): Use logDetail.
(.start): Initialize verboseLogging. Also log "Running 20 times" as an informative log using logDetail.
(.ignoreWarmUpAndLog): Use logDetail for showing the progress. These logs were useless inside test runners anyway
because perftest didn't get to see any output until the test finished running.
(.finish): Call logStatistics with metric name as opposed to a label. Each metric name is now prefixed with ':' to be
distinguishable from subtests, making the new format forward compatible.
Tools:
As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
the first place.
Also modernize the output to adopt "metric" concept better and make it forward compatible
with subtests.
With this patch, performance tests written using runner.js only produces empty lines or
lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
<subtest name> -> [<value 1>, <value 2>, ...]
:<metric name> -> [<value 1>, <value 2>, ...]
This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest): Removed a bunch of regular expressions that are no longer used.
(PerfTest._run_with_driver): Just parse the values and description and treat everything
else as errors.
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTest.test_parse_output): Removed the junk.
(TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
which was removed in favor of the tests below.
(TestPerfTest.test_parse_output_with_running_five_times): Added.
(TestPerfTest.test_parse_output_with_detailed_info): Added.
(TestPerfTest.test_parse_output_with_statistics): Added.
(TestPerfTest.test_parse_output_with_description): Removed the junk.
(TestPerfTest.test_parse_output_with_subtests): Ditto.
(TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(EventTargetWrapperTestData): Ditto.
(SomeParserTestData): Ditto.
(MemoryTestData): Ditto.
LayoutTests:
Rebaseline the expected result now that the output has been simplified.
- fast/harness/perftests/runs-per-second-log-expected.txt:
- 3:40 PM Changeset in webkit [159464] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed build fix attempt on GTK and EFL port after r159461
- CMakeLists.txt: Added APINavigationData.cpp and removed WebNavigationData.cpp
- GNUmakefile.list.am: Ditto.
- 3:33 PM Changeset in webkit [159463] by
-
- 4 edits in trunk/Source/WebCore
At some scales, opaque compositing layers have garbage pixels around the edges
https://bugs.webkit.org/show_bug.cgi?id=124541
Reviewed by Dean Jackson.
Layers get marked as having opaque contents when their background is
known to paint the entire layer. However, this failed to take into
account two reasons why every pixel may not get painted.
First, subpixel layout can result in non-integral RenderLayer
bounds, which will get rounded up to an integral GraphicsLayer
size. When this happens we may not paint edge pixels.
Second, at non-integral scale factors, graphics context scaling
may cause us to not paint edge pixels.
Fix by only marking PlatformCALayers as having opaque contents
when the contentsScale of the layer is integral.
Not testable, because we can't guarantee to get garbage pixels
in a ref test, and layer dumps show GraphicsLayer's notion of
content opaqueness, not the one we set on the PlatformCALayer.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::isIntegral):
(WebCore::clampedContentsScaleForScale):
(WebCore::GraphicsLayerCA::updateRootRelativeScale):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateContentsOpaque):
(WebCore::GraphicsLayerCA::getTransformFromAnimationsWithMaxScaleImpact):
Drive-by typo fix.
(WebCore::GraphicsLayerCA::noteChangesForScaleSensitiveProperties):
- platform/graphics/ca/GraphicsLayerCA.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- 3:19 PM Changeset in webkit [159462] by
-
- 7 edits in trunk/Source/JavaScriptCore
put_to_scope[5] should not point to the structure if it's a variable access, but it should point to the WatchpointSet
https://bugs.webkit.org/show_bug.cgi?id=124539
Reviewed by Mark Hahnenberg.
This is in preparation for getting put_to_scope to directly invalidate the watchpoint set
on stores, which will allow us to run constant inference on all globals.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
- bytecode/Instruction.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- runtime/JSScope.cpp:
(JSC::abstractAccess):
(JSC::JSScope::abstractResolve):
- runtime/JSScope.h:
(JSC::ResolveOp::ResolveOp):
- runtime/SymbolTable.h:
(JSC::SymbolTableEntry::watchpointSet):
- 3:16 PM Changeset in webkit [159461] by
-
- 8 edits2 moves in trunk/Source/WebKit2
Rename WebNavigationData to API::NavigationData
https://bugs.webkit.org/show_bug.cgi?id=124542
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKNavigationDataRef.cpp:
(WKNavigationDataGetTypeID):
- UIProcess/API/Cocoa/WKNavigationData.mm:
(-[WKNavigationData dealloc]):
(-[WKNavigationData title]):
(-[WKNavigationData originalRequest]):
(-[WKNavigationData destinationURL]):
(-[WKNavigationData response]):
- UIProcess/API/Cocoa/WKNavigationDataInternal.h:
(WebKit::wrapper):
- UIProcess/API/mac/WKProcessGroup.mm:
- UIProcess/APINavigationData.cpp: Renamed from Source/WebKit2/UIProcess/WebNavigationData.cpp.
(API::NavigationData::NavigationData):
(API::NavigationData::~NavigationData):
- UIProcess/APINavigationData.h: Renamed from Source/WebKit2/UIProcess/WebNavigationData.h.
(API::NavigationData::create):
(API::NavigationData::title):
(API::NavigationData::url):
(API::NavigationData::originalRequest):
(API::NavigationData::response):
- UIProcess/WebHistoryClient.cpp:
(WebKit::WebHistoryClient::didNavigateWithNavigationData):
- WebKit2.xcodeproj/project.pbxproj:
- 3:08 PM Changeset in webkit [159460] by
-
- 14 edits2 adds in trunk
Add a quirk to not respect center text-align when positioning
<rdar://problem/15427571>
https://bugs.webkit.org/show_bug.cgi?id=124522
Reviewed by Simon Fraser.
Added fast/block/legacy-text-align-position-quirk.html
Source/WebCore:
- page/Settings.in:
Add the quirk setting.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::startAlignedOffsetForLine):
Don't pay attention to center text-align when the quirk is set.
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences useLegacyTextAlignPositionedElementBehavior]):
(-[WebPreferences setUseLegacyTextAlignPositionedElementBehavior:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesUseLegacyTextAlignPositionedElementBehavior):
(WKPreferencesSetUseLegacyTextAlignPositionedElementBehavior):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
LayoutTests:
- fast/block/legacy-text-align-position-quirk-expected.html: Added.
- fast/block/legacy-text-align-position-quirk.html: Added.
- 3:07 PM Changeset in webkit [159459] by
-
- 7 edits in trunk/Source/JavaScriptCore
APIEntryShims need some love
https://bugs.webkit.org/show_bug.cgi?id=124540
Reviewed by Filip Pizlo.
We were missing them in key places which some other hacking revealed. These could have manifested as
race conditions for VMs being used in multithreaded environments.
- API/JSContext.mm:
(-[JSContext setException:]):
(-[JSContext wrapperForObjCObject:]):
(-[JSContext wrapperForJSObject:]):
- API/JSContextRef.cpp:
(JSContextGroupRelease):
(JSGlobalContextRelease):
- API/JSManagedValue.mm:
(-[JSManagedValue initWithValue:]):
(-[JSManagedValue value]):
- API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCopyPropertyNames):
- API/JSValue.mm:
(containerValueToObject):
- API/JSWrapperMap.mm:
(tryUnwrapObjcObject):
- 2:43 PM Changeset in webkit [159458] by
-
- 3 edits in trunk/Source/WebKit2
Add State to PageLoadState
https://bugs.webkit.org/show_bug.cgi?id=124538
Reviewed by Tim Horton.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::PageLoadState):
(WebKit::PageLoadState::didStartProvisionalLoad):
(WebKit::PageLoadState::didReceiveServerRedirectForProvisionalLoad):
(WebKit::PageLoadState::didFailProvisionalLoad):
(WebKit::PageLoadState::didCommitLoad):
(WebKit::PageLoadState::didFinishLoad):
(WebKit::PageLoadState::didSameDocumentNavigation):
- UIProcess/PageLoadState.h:
- 2:40 PM Changeset in webkit [159457] by
-
- 1 copy in tags/Safari-537.73.11
New tag.
- 2:14 PM Changeset in webkit [159456] by
-
- 4 edits in trunk/Source/WebKit2
The PageLoadState object should keep track of the current URL
https://bugs.webkit.org/show_bug.cgi?id=124536
Reviewed by Dan Bernstein.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::didCommitLoad):
(WebKit::PageLoadState::didFinishLoad):
(WebKit::PageLoadState::didFailLoad):
(WebKit::PageLoadState::didSameDocumentNavigation):
- UIProcess/PageLoadState.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
- 2:10 PM Changeset in webkit [159455] by
-
- 23 edits2 adds3 deletes in trunk/Source
Consolidate various frame snapshot capabilities.
https://bugs.webkit.org/show_bug.cgi?id=124325
Patch by Brian J. Burg <Brian Burg> on 2013-11-18
Reviewed by Timothy Hatcher.
Source/WebCore:
Various snapshot creation methods had duplicated code and were split
between Frame, DragImage, and platform-specific implementationss.
This patch puts WebCore snapshot methods into FrameSnapshotting
and removes platform implementations where possible.
DragImage methods reuse snapshot methods where possible. Inspector
will be able to take snapshots without using drag images.
No new tests, this is a refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm:
(-[DOMNode renderedImage]):
(-[DOMRange renderedImageForcingBlackText:]):
- dom/Clipboard.cpp:
(WebCore::Clipboard::createDragImage):
- dom/ClipboardMac.mm:
(WebCore::Clipboard::createDragImage):
- page/DragController.cpp:
(WebCore::DragController::startDrag):
- page/Frame.cpp:
- page/Frame.h:
- page/FrameSnapshotting.cpp: Added.
(WebCore::ScopedFramePaintingState::ScopedFramePaintingState):
(WebCore::ScopedFramePaintingState::~ScopedFramePaintingState):
(WebCore::snapshotFrameRect): Move most buffer logic to here.
(WebCore::snapshotSelection): Moved from Frame.
(WebCore::snapshotNode): Moved from Frame.
- page/FrameSnapshotting.h: Added.
- page/mac/FrameMac.mm: Removed.
- page/mac/FrameSnapshottingMac.h: Removed.
- page/mac/FrameSnapshottingMac.mm: Removed.
- page/win/FrameWin.cpp: remove duplicate implementation.
- page/win/FrameWin.h: Fix an incorrect parameter name.
- platform/DragImage.cpp:
(WebCore::ScopedNodeDragState::ScopedNodeDragState):
(WebCore::ScopedNodeDragState::~ScopedNodeDragState):
(WebCore::createDragImageFromSnapshot): Boilerplate buffer conversion.
(WebCore::createDragImageForNode):
(WebCore::createDragImageForSelection):
(WebCore::ScopedFrameSelectionState::ScopedFrameSelectionState):
(WebCore::ScopedFrameSelectionState::~ScopedFrameSelectionState):
(WebCore::createDragImageForRange): Moved from Frame.
(WebCore::createDragImageForImage): Moved from FrameSnapshottingMac.
(WebCore::createDragImageForLink): use nullptr.
Source/WebKit/ios:
- WebCoreSupport/WebFrameIOS.mm: use new header file.
Source/WebKit/mac:
Use new platform-independent methods instead of Mac methods.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _selectionDraggingImage]):
(-[WebHTMLView selectionImageForcingBlackText:]):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::renderedImage): use createDragImageForNode.
- 1:49 PM Changeset in webkit [159454] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Crash when using media source
https://bugs.webkit.org/show_bug.cgi?id=124525
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-18
Reviewed by Philippe Normand.
No new tests because this is already covered by tests in media/media-source (which aren't enabled because the feature isn't done).
- platform/graphics/gstreamer/MediaSourceGStreamer.cpp:
(WebCore::MediaSourceGStreamer::MediaSourceGStreamer): Add missing adoptRef()
- 1:48 PM Changeset in webkit [159453] by
-
- 4 edits in trunk/Tools
Occasionally, hundreds of tests fail with small text diffs on Mavericks
https://bugs.webkit.org/show_bug.cgi?id=124312
Reviewed by Simon Fraser.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._set_up_run):
- Scripts/webkitpy/port/base.py:
(Port.to.reset_preferences):
- Scripts/webkitpy/port/mac.py:
(MacPort.reset_preferences):
Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
returning some of the functionality of 158652 after 159364 removed it.
- 1:44 PM Changeset in webkit [159452] by
-
- 2 edits in trunk/Source/WebKit2
URTBF after r159444.
- GNUmakefile.list.am:
- 1:28 PM Changeset in webkit [159451] by
-
- 4 edits in trunk/Source/WebKit2
PageLoadState should keep track of the provisional URL
https://bugs.webkit.org/show_bug.cgi?id=124535
Reviewed by Dan Bernstein.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::didStartProvisionalLoad):
(WebKit::PageLoadState::didReceiveServerRedirectForProvisionalLoad):
(WebKit::PageLoadState::didCommitLoad):
- UIProcess/PageLoadState.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
- 1:21 PM Changeset in webkit [159450] by
-
- 2 edits in trunk/Source/WebCore
Remove unneeded BackingStore-related #include from IDBFactoryBackendInterface
Rubberstamped by Beth Dakin.
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- 1:03 PM Changeset in webkit [159449] by
-
- 7 edits in trunk/Source/WebKit2
Move m_pendingAPIRequestURL to PageLoadState
https://bugs.webkit.org/show_bug.cgi?id=124531
Reviewed by Tim Horton.
- UIProcess/API/C/WKPage.cpp:
(WKPageCopyPendingAPIRequestURL):
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::pendingAPIRequestURL):
(WebKit::PageLoadState::setPendingAPIRequestURL):
(WebKit::PageLoadState::clearPendingAPIRequestURL):
- UIProcess/PageLoadState.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::activeURL):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::estimatedProgress):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageLoadState):
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::restoreFromSessionStateData):
- 12:52 PM Changeset in webkit [159448] by
-
- 6 edits in trunk/Source
Allow the FTL debug dumps to include the new size field
https://bugs.webkit.org/show_bug.cgi?id=124479
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::Location::parse):
(JSC::FTL::StackMaps::Location::dump):
- ftl/FTLStackMaps.h:
Source/WTF:
- wtf/PrintStream.cpp:
(WTF::printInternal):
- wtf/PrintStream.h:
- 12:42 PM Changeset in webkit [159447] by
-
- 11 edits in trunk/Source/WebCore
Change mediasource and mediastream modules to use nullptr
https://bugs.webkit.org/show_bug.cgi?id=124530
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-18
Reviewed by Tim Horton.
No new tests needed, no behavior change.
- Modules/mediasource/MediaSource.cpp:
- Modules/mediasource/SourceBuffer.cpp:
- Modules/mediastream/MediaStream.cpp:
- Modules/mediastream/RTCDTMFSender.cpp:
- Modules/mediastream/RTCDataChannel.cpp:
- Modules/mediastream/RTCIceCandidate.cpp:
- Modules/mediastream/RTCPeerConnection.cpp:
- Modules/mediastream/RTCSessionDescription.cpp:
- Modules/mediastream/RTCStatsResponse.cpp:
- Modules/mediastream/UserMediaRequest.cpp:
- 12:32 PM Changeset in webkit [159446] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed EFL build fix after r159444
- CMakeLists.txt: Added PageLoadState.cpp.
- 12:01 PM Changeset in webkit [159445] by
-
- 13 edits in trunk/Source/WebCore
Move execution of IDBCursorBackendOperations to the IDBServerConnection
https://bugs.webkit.org/show_bug.cgi?id=124463
Reviewed by Tim Horton.
This almost entirely removes knowledge of the backing store from the front end.
The primary change here is to give cursors a unique ID.
This way the IDBCursorBackend can reference itself by ID, while the
IDBServerConnection can handle mapping that ID to a backing store.
- Modules/indexeddb/IDBBackingStoreCursorInterface.h:
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBCursorBackend.cpp:
(WebCore::IDBCursorBackend::IDBCursorBackend):
(WebCore::IDBCursorBackend::deleteFunction):
(WebCore::IDBCursorBackend::prefetchReset):
(WebCore::IDBCursorBackend::close):
(WebCore::IDBCursorBackend::updateCursorData):
(WebCore::IDBCursorBackend::clearCursorData):
- Modules/indexeddb/IDBCursorBackend.h:
(WebCore::IDBCursorBackend::create):
(WebCore::IDBCursorBackend::key):
(WebCore::IDBCursorBackend::primaryKey):
(WebCore::IDBCursorBackend::value):
(WebCore::IDBCursorBackend::id):
(WebCore::IDBCursorBackend::transaction):
(WebCore::IDBCursorBackend::setSavedCursorID):
- Modules/indexeddb/IDBCursorBackendOperations.cpp:
(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):
(WebCore::CursorPrefetchIterationOperation::perform):
- Modules/indexeddb/IDBCursorBackendOperations.h:
(WebCore::CursorIterationOperation::key):
(WebCore::CursorIterationOperation::callbacks):
(WebCore::CursorAdvanceOperation::count):
(WebCore::CursorAdvanceOperation::callbacks):
(WebCore::CursorPrefetchIterationOperation::numberToFetch):
(WebCore::CursorPrefetchIterationOperation::callbacks):
- Modules/indexeddb/IDBServerConnection.h:
- Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h:
(WebCore::IDBBackingStoreCursorLevelDB::IDBBackingStoreCursorLevelDB):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::ObjectStoreKeyCursorImpl::create):
(WebCore::ObjectStoreKeyCursorImpl::clone):
(WebCore::ObjectStoreKeyCursorImpl::ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreCursorImpl::create):
(WebCore::ObjectStoreCursorImpl::clone):
(WebCore::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::IDBServerConnectionLevelDB):
(WebCore::IDBServerConnectionLevelDB::setIndexKeys):
(WebCore::IDBServerConnectionLevelDB::createObjectStore):
(WebCore::IDBServerConnectionLevelDB::createIndex):
(WebCore::IDBServerConnectionLevelDB::deleteIndex):
(WebCore::IDBServerConnectionLevelDB::get):
(WebCore::IDBServerConnectionLevelDB::put):
(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::count):
(WebCore::IDBServerConnectionLevelDB::deleteRange):
(WebCore::IDBServerConnectionLevelDB::clearObjectStore):
(WebCore::IDBServerConnectionLevelDB::deleteObjectStore):
(WebCore::IDBServerConnectionLevelDB::changeDatabaseVersion):
(WebCore::IDBServerConnectionLevelDB::cursorAdvance):
(WebCore::IDBServerConnectionLevelDB::cursorIterate):
(WebCore::IDBServerConnectionLevelDB::cursorPrefetchIteration):
(WebCore::IDBServerConnectionLevelDB::cursorPrefetchReset):
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
- 12:00 PM Changeset in webkit [159444] by
-
- 4 edits2 adds in trunk/Source/WebKit2
Add PageLoadState class
https://bugs.webkit.org/show_bug.cgi?id=124528
Reviewed by Dan Bernstein.
Trying to use the main frame load state as the page load state was a bad idea,
add a new PageLoadState and use it instead. Ultimately the long term plan is to
transition away from FrameLoadState entirely.
- UIProcess/PageLoadState.cpp: Added.
(WebKit::PageLoadState::PageLoadState):
(WebKit::PageLoadState::~PageLoadState):
(WebKit::PageLoadState::didStartProvisionalLoad):
- UIProcess/PageLoadState.h: Added.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
- UIProcess/WebPageProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- 11:59 AM Changeset in webkit [159443] by
-
- 4 edits in trunk/Source
[WTF] Media time should not have a constructor which accepts a single int or float.
https://bugs.webkit.org/show_bug.cgi?id=124470
Source/WebCore:
Reviewed by Eric Carlson.
Fix the compile error exposed by removing the default parameter in the MediaTime constructor.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::setTimestampOffset):
Source/WTF:
Having a constructor taking a single number value, as it's very easy to accidentially mis-
initialize a MediaTime with a double (automatically casted to a int64_t).
Reviewed by Eric Carlson.
- wtf/MediaTime.h:
- 11:53 AM Changeset in webkit [159442] by
-
- 10 edits in trunk/Source/WebCore
Change webaudio to use nullptr for null pointers
https://bugs.webkit.org/show_bug.cgi?id=124526
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-18
Reviewed by Anders Carlsson.
No new tests needed, no behavior change.
- Modules/webaudio/AudioBuffer.cpp:
- Modules/webaudio/AudioContext.cpp:
- Modules/webaudio/AudioNode.cpp:
- Modules/webaudio/ChannelMergerNode.cpp:
- Modules/webaudio/ChannelSplitterNode.cpp:
- Modules/webaudio/MediaStreamAudioSource.cpp:
- Modules/webaudio/OfflineAudioContext.cpp:
- Modules/webaudio/PeriodicWave.cpp:
- Modules/webaudio/ScriptProcessorNode.cpp:
- 11:44 AM Changeset in webkit [159441] by
-
- 2 edits in trunk/Source/WebKit2
[ASAN] WebKit2: Remove calls to dead DownloadAuthenticationClient code
https://bugs.webkit.org/show_bug.cgi?id=124367
Reviewed by Alexey Proskuryakov.
- Shared/Downloads/DownloadAuthenticationClient.cpp:
(WebKit::DownloadAuthenticationClient::receivedCredential):
(WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
(WebKit::DownloadAuthenticationClient::receivedCancellation):
Remove calls to nowhere:
WebKit::Download::cancelAuthenticationChallenge(WebCore::AuthenticationChallenge const&)
WebKit::Download::continueWithoutCredential(WebCore::AuthenticationChallenge const&)
WebKit::Download::useCredential(WebCore::AuthenticationChallenge const&, WebCore::Credential const&)
- 11:34 AM Changeset in webkit [159440] by
-
- 2 edits1 delete in trunk/Tools
Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=122909
Reviewed by Alexey Proskuryakov.
Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line .bubble):
(.status-line.good .bubble.pictogram):
- 11:10 AM Changeset in webkit [159439] by
-
- 7 edits in trunk/Source/WebKit2
Use a strong enum for frame load states
https://bugs.webkit.org/show_bug.cgi?id=124524
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKFrame.cpp:
(WKFrameGetFrameLoadState):
- UIProcess/FrameLoadState.cpp:
(WebKit::FrameLoadState::FrameLoadState):
(WebKit::FrameLoadState::didStartProvisionalLoad):
(WebKit::FrameLoadState::didReceiveServerRedirectForProvisionalLoad):
(WebKit::FrameLoadState::didFailProvisionalLoad):
(WebKit::FrameLoadState::didCommitLoad):
(WebKit::FrameLoadState::didFinishLoad):
(WebKit::FrameLoadState::didFailLoad):
- UIProcess/FrameLoadState.h:
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::activeURL):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::loadStateAtProcessExit):
- 11:00 AM Changeset in webkit [159438] by
-
- 2 edits in trunk/Source/WTF
URTBF after r159432 to make WinCairo build happy.
- wtf/text/WTFString.h:
- 10:54 AM Changeset in webkit [159437] by
-
- 9 edits in trunk/Source
Remove unnecessary COMPILER(CLANG) #ifdefs in Mac-only code
https://bugs.webkit.org/show_bug.cgi?id=124523
Reviewed by Dan Bernstein.
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::didCreateWindow):
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
(WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess):
(WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess):
Source/WebKit2:
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::beginModal):
- PluginProcess/mac/PluginProcessShim.mm:
- Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::getPluginProcessSerialNumber):
(WebKit::PluginProcessProxy::makePluginProcessTheFrontProcess):
(WebKit::PluginProcessProxy::makeUIProcessTheFrontProcess):
(WebKit::PluginProcessProxy::exitFullscreen):
- 10:46 AM Changeset in webkit [159436] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] Optimization, no need to erase background before paint.
https://bugs.webkit.org/show_bug.cgi?id=124453
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-18
Reviewed by Brent Fulgham.
As the paint will blit a bitmap onto the invalid area (no alpha),
there is no need to erase the background first, as this will be overwritten by the blit.
- WebView.cpp:
(WebView::WebViewWndProc): Avoid erasing background before paint.
- 10:45 AM Changeset in webkit [159435] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Basic authentication is not reused.
https://bugs.webkit.org/show_bug.cgi?id=124452
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-18
Reviewed by Brent Fulgham.
After a successful basic authentication, the credentials are not reused for later requests.
In the CFNetwork port, this is solved by trying basic authentication first, if credentials exists.
Also, when a 401 response is received, the first thing the CFNetwork port does, is to use
m_user/m_pass as credentials in the following request if they are set.
This can be done the same way for the Curl version.
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Try using m_user/m_pass as credentials first, if they are set.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::applyAuthenticationToRequest): Try basic authentication first, if credentials exists.
- 10:42 AM Changeset in webkit [159434] by
-
- 2 edits in trunk/Source/WebKit/mac
Ignore deprecation warnings for now.
- History/WebHistory.h:
- 10:35 AM Changeset in webkit [159433] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
- platform/efl/TestExpectations: Add failure expectations for CSS filters layout tests.
- 10:35 AM Changeset in webkit [159432] by
-
- 4 edits4 adds in trunk/Source/WebCore
[curl] Add file cache
https://bugs.webkit.org/show_bug.cgi?id=123333
Patch by Mátyás Mustoha <mmatyas@inf.u-szeged.hu> on 2013-11-18
Reviewed by Brent Fulgham.
Implementation of on disc file cache
for the curl network backend.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- platform/network/curl/CurlCacheEntry.cpp: Added.
(WebCore::CurlCacheEntry::CurlCacheEntry):
(WebCore::CurlCacheEntry::~CurlCacheEntry):
(WebCore::CurlCacheEntry::isCached):
(WebCore::CurlCacheEntry::requestHeaders):
(WebCore::CurlCacheEntry::saveCachedData):
(WebCore::CurlCacheEntry::loadCachedData):
(WebCore::CurlCacheEntry::saveResponseHeaders):
(WebCore::CurlCacheEntry::loadResponseHeaders):
(WebCore::CurlCacheEntry::setResponseFromCachedHeaders):
(WebCore::CurlCacheEntry::didFail):
(WebCore::CurlCacheEntry::didFinishLoading):
(WebCore::CurlCacheEntry::generateBaseFilename):
(WebCore::CurlCacheEntry::loadFileToBuffer):
(WebCore::CurlCacheEntry::invalidate):
(WebCore::CurlCacheEntry::parseResponseHeaders):
- platform/network/curl/CurlCacheEntry.h: Added.
(WebCore::CurlCacheEntry::isInMemory):
- platform/network/curl/CurlCacheManager.cpp: Added.
(WebCore::CurlCacheManager::getInstance):
(WebCore::CurlCacheManager::CurlCacheManager):
(WebCore::CurlCacheManager::~CurlCacheManager):
(WebCore::CurlCacheManager::setCacheDirectory):
(WebCore::CurlCacheManager::loadIndex):
(WebCore::CurlCacheManager::saveIndex):
(WebCore::CurlCacheManager::didReceiveResponse):
(WebCore::CurlCacheManager::didFinishLoading):
(WebCore::CurlCacheManager::isCached):
(WebCore::CurlCacheManager::requestHeaders):
(WebCore::CurlCacheManager::didReceiveData):
(WebCore::CurlCacheManager::saveResponseHeaders):
(WebCore::CurlCacheManager::invalidateCacheEntry):
(WebCore::CurlCacheManager::didFail):
(WebCore::CurlCacheManager::loadCachedData):
- platform/network/curl/CurlCacheManager.h: Added.
(WebCore::CurlCacheManager::getCacheDirectory):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::writeCallback):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::initializeHandle):
- 10:30 AM Changeset in webkit [159431] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Win] Link fails when DFG JIT is enabled.
https://bugs.webkit.org/show_bug.cgi?id=123614
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-18
Reviewed by Brent Fulgham.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Added new files.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
- 10:25 AM Changeset in webkit [159430] by
-
- 4 edits in trunk/Source
[Win] WebKit version in user agent string is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=124454
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-18
Reviewed by Brent Fulgham.
Source/WebCore:
- DerivedSources.make: Generate WebKitVersion.h
Source/WebKit/win:
- WebView.cpp:
(webKitVersionString): Create WebKit version string from WebKitVersion.h.
- 10:22 AM Changeset in webkit [159429] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Add missing implementation in MacroAssembler to fix build (broken since r159395).
https://bugs.webkit.org/show_bug.cgi?id=124484
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-18
Reviewed by Michael Saboff.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::branch8):
- 10:19 AM Changeset in webkit [159428] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARM64 CRASH: Improper offset in getHostCallReturnValue() to access callerFrame in CallFrame
https://bugs.webkit.org/show_bug.cgi?id=124481
Reviewed by Mark Lam.
Fixed the offset to access CallerFrame in the ARM64 version of getHostCallReturnValue() to be 0
to correspond with the change in CallFrame layout done in r158315.
- jit/JITOperations.cpp:
- 9:56 AM Changeset in webkit [159427] by
-
- 5 edits in trunk/Source/JavaScriptCore
Crash in virtualForThunkGenerator generated code on ARM64
https://bugs.webkit.org/show_bug.cgi?id=124447
Reviewed by Geoffrey Garen.
The baseline JIT generates slow path call code with the caller in regT0. The DFG
generates call code with the caller in nonArgGPR0. The virtualForThunkGenerator
generates code with the caller in nonArgGPR0. For X86 and X86_64, regT0 and nonArgGPR0
are the same CPU register, eax. For other platforms this isn't the case. The same
issue exists for JSVALUE32_64 ports as well, where there also is an issue with the callee
tag registers being regT1 and nonArgGPR1 in the various locations.
Changed nonArgGPR0, nonArgGPR1 and nonArgGPR2 for X86 and X86_64 to not match up with
regT0-2. Changing these registers will cause a crash on all ports should we have a
similar problem in the future. Changed the DFG call generating code to use regT0 and
regT1. Now all slow path call code is generated using regT0 and for JSVALUE32_64 regT1.
Added r12 to X86_64 as a new temp register (regT9) and moved r13 down to regT10.
The new temp register decreases the likelihood of inadvertant register overlap.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- jit/GPRInfo.h:
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
- jit/ThunkGenerators.cpp:
(JSC::virtualForThunkGenerator):
- 9:06 AM Changeset in webkit [159426] by
-
- 1 copy in releases/WebKitGTK/webkit-2.3.2
Tagging the WebKitGTK+ 2.3.2 release
- 8:58 AM Changeset in webkit [159425] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add missing load8/branch8 with AbsoluteAddress parameter to MIPS port.
[MIPS] Build fails since r159395.
https://bugs.webkit.org/show_bug.cgi?id=124491
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-11-18
Reviewed by Michael Saboff.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load8):
(JSC::MacroAssemblerMIPS::branch8):
- 8:54 AM Changeset in webkit [159424] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for the current set
of untriaged failures on the 64-bit WK2 builder.
- 8:35 AM Changeset in webkit [159423] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r159351): It made zillion tests assert on !CF platforms
https://bugs.webkit.org/show_bug.cgi?id=124490
Reviewed by Mark Hahnenberg.
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::sweep):
- 8:01 AM Changeset in webkit [159422] by
-
- 4 edits in trunk/Source/JavaScriptCore
Remove architecture specific code in LowLevelInterpreter.
https://bugs.webkit.org/show_bug.cgi?id=124501
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-18
Reviewed by Michael Saboff.
- llint/LowLevelInterpreter.asm: Use generic path instead of sh4 specific code.
- llint/LowLevelInterpreter32_64.asm: Merge sh4/mips path with arm path. The
"move t0, a0" is not needed for arm because t0 == a0 with this architecture.
- offlineasm/sh4.rb: Handle move opcode with pr register.
- 7:28 AM Changeset in webkit [159421] by
-
- 3 edits in trunk/PerformanceTests
[Performance tests] Interactive/SelectAll.html throws an exception
https://bugs.webkit.org/show_bug.cgi?id=124495
Reviewed by Antti Koivisto
Return a boolean indicating whether more values are needed or not in
PerfTestRunner.measureValueAsync so that runTest can terminate gracefully.
- Interactive/SelectAll.html:
(runTest): Don't schedule a timer for runTest if we've got enough values.
- resources/runner.js:
(PerfTestRunner.measureValueAsync): Returns true iff more values are needed.
- 6:52 AM Changeset in webkit [159420] by
-
- 4 edits in trunk
Unreviewed. Update NEWS and Versions.m4 for 2.3.2 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.3.2.
- 6:49 AM Changeset in webkit [159419] by
-
- 5 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/WebCore:
- GNUmakefile.am: Add inspector json files to EXTRA_DIST and
remove maketokenizer from EXTRA_DIST.
- GNUmakefile.list.am: Add missing header files.
Source/WTF:
- GNUmakefile.list.am: Add missing header file.
- 6:42 AM Changeset in webkit [159418] by
-
- 3 edits in trunk/Tools
Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
https://bugs.webkit.org/show_bug.cgi?id=124499
Reviewed by Csaba Osztrogonác.
Removed the code. I didn't like this hack back when it was added, and I don't like it today.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest._should_ignore_line):
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTest): Removed the unit test.
- 4:45 AM WebKitGTK/Debugging edited by
- Fix error, you cannot pass --debug to GtkLauncher (diff)
- 4:23 AM Changeset in webkit [159417] by
-
- 12 edits in trunk/Source/WebCore
Generate toHTMLDataList|Html|EmbedElement
https://bugs.webkit.org/show_bug.cgi?id=124482
Reviewed by Tim Horton.
To clean up static_cast<HTMLFoo*>, toHTMLEmbedElement, toHTMLHtmlElement, toHTMLDataListElement
are generated.
No new tests, no behavior changes.
- html/HTMLDataListElement.h:
- html/HTMLEmbedElement.h:
- html/HTMLHtmlElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::dataList):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::ownerDataListElement):
- html/HTMLTagNames.in:
- html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
- 3:48 AM Changeset in webkit [159416] by
-
- 18 edits in trunk/Source/WebCore
Clean up static_cast<HTMLFoo*> usage
https://bugs.webkit.org/show_bug.cgi?id=124480
Reviewed by Tim Horton.
Though there are toHTMLFoo(), some places are still using static_cast<>.
Additionally, toHTMLBodyElement() is supported from now.
No new tests, no behavior changes.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isRequired):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
- bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::nameGetter):
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginInstance):
- dom/Document.cpp:
(WebCore::Document::openSearchDescriptionURL):
(WebCore::Document::iconURLs):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
- html/HTMLBodyElement.h:
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::setBgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::setFgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::setAlinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::setLinkColor):
(WebCore::HTMLDocument::vlinkColor):
(WebCore::HTMLDocument::setVlinkColor):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::rendererIsNeeded):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::updateAncestorDisabledState):
(WebCore::HTMLFormControlElement::enclosingFormControlElement):
- html/HTMLFormElement.cpp:
(WebCore::submitElementFromEvent):
- html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::notifyFinished):
- html/HTMLLegendElement.cpp:
(WebCore::HTMLLegendElement::virtualForm):
- html/RadioNodeList.cpp:
(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
- 3:37 AM Changeset in webkit [159415] by
-
- 2 edits in trunk/Source/JavaScriptCore
[arm] Add missing implementation in MacroAssembler to fix build (broken since r159395).
https://bugs.webkit.org/show_bug.cgi?id=124488
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-18
Reviewed by Zoltan Herczeg.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch8):
- 3:31 AM Changeset in webkit [159414] by
-
- 5 edits4 adds in trunk/Source
[EFL] Add EWebKitConfig.cmake and EWebKit2Config.cmake
https://bugs.webkit.org/show_bug.cgi?id=124478
Reviewed by Gyuyoung Kim.
EWebKit is built using CMake but applications use *.pc to use it.
This patch provides EWebKitConfig.cmake and EWebKit2Config.cmake
for applications which use EWebkit and is compiled by CMake.
Source/WebKit:
- PlatformEfl.cmake:
Configure and install EWebKitConfig.cmake and EWebKitConfigVersion.cmake
Source/WebKit/efl:
- EWebKitConfig.cmake.in: Added.
- EWebKitConfigVersion.cmake.in: Added.
Source/WebKit2:
- PlatformEfl.cmake:
Configure and install EWebKit2Config.cmake and EWebKit2ConfigVersion.cmake
- efl/EWebKit2Config.cmake.in: Added.
- efl/EWebKit2ConfigVersion.cmake.in: Added.
- 3:22 AM Changeset in webkit [159413] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Update GObject DOM symbols file after r158760.
- bindings/gobject/webkitdom.symbols: Add
webkit_dom_text_track_get_id prototype.
- 3:19 AM Changeset in webkit [159412] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Cleaning up expectations for unexpectedly passing tests, either removing or updating them
to reflect the current status of the test.
- platform/gtk-wk1/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 3:05 AM Changeset in webkit [159411] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION(r158821): [GTK] API break due to removed properties in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=124489
Reviewed by Philippe Normand.
In r158821, several properties were changed from readonly to
CustomSetter. The GObject DOM bindings currently skips any
attribute having a custom getter or setter, and those properties
are not generated anymore. We should add support for generating
attributes having a custom getter or setter in GObject DOM
bindings generator, but to fix the ABI break now we bring the old
implementatiom back as custom implementation. This fixes the ABI
compatibility, but not the API since the GObject properties are
not generated.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_audio_track_get_kind):
(webkit_dom_audio_track_get_language):
(webkit_dom_text_track_get_kind):
(webkit_dom_text_track_get_language):
(webkit_dom_video_track_get_kind):
(webkit_dom_video_track_get_language):
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols:
- 2:22 AM Changeset in webkit [159410] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Update GObject DOM symbols file after r158662.
- bindings/gobject/webkitdom.symbols: Add missing prototypes.
- 2:19 AM Changeset in webkit [159409] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Addressing the current set of timing-out tests. Timeout expectations
are added where appropriate, with one js/regress/ test speculatively marked as slow.
- 2:01 AM Changeset in webkit [159408] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Update GObject DOM symbols file after r159208 and r159363.
- bindings/gobject/webkitdom.symbols: Add
webkit_dom_html_media_element_fast_seek prototype.
- 1:52 AM Changeset in webkit [159407] by
-
- 9 edits2 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Update the global constructors' attibutes baseline for the WK2 flavor of the GTK port.
Update baselines for tests under media/.
- platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
- platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
- platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
- platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
- platform/gtk/media/media-can-play-ogg-expected.txt:
- platform/gtk/media/video-controls-captions-trackmenu-localized-expected.txt:
- platform/gtk/media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles-expected.txt: Added.
- platform/gtk/media/video-controls-captions-trackmenu-sorted-expected.txt:
- platform/gtk/media/volume-bar-empty-when-muted-expected.txt: Added.
- 1:51 AM Changeset in webkit [159406] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION(r159363): [GTK] API break in webkit_dom_html_media_element_set_current_time
https://bugs.webkit.org/show_bug.cgi?id=124485
Reviewed by Philippe Normand.
In r159363 currentTime attribute was changed to not raise
exceptions. This breaks the API of GObject DOM bindings because we
use a GError parameter for exceptions that has been removed.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_media_element_set_current_time): Custom
implementation that receives a GError for backwards
compatibility.
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols: Add
webkit_dom_html_media_element_set_current_time prototype.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skip
webkit_dom_html_media_element_set_current_time since we are adding
a custom implementation.
- 1:20 AM Changeset in webkit [159405] by
-
- 6 edits9 adds in trunk/LayoutTests
Unreviewed GTK gardening. Updating GTK-specific baselines for tests under editing/, scrollingcoordinator/ and tables/.
- platform/gtk/editing/deleting/smart-delete-003-expected.txt:
- platform/gtk/editing/deleting/smart-delete-004-expected.txt:
- platform/gtk/editing/spelling/centering-misspelling-dots-expected.png: Added.
- platform/gtk/editing/spelling/centering-misspelling-dots-expected.txt: Added.
- platform/gtk/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.png: Added.
- platform/gtk/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.txt: Added.
- platform/gtk/editing/unsupported-content/table-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-003-expected.txt:
- platform/gtk/scrollingcoordinator: Added.
- platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
- platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
- platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
- platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- 12:51 AM Changeset in webkit [159404] by
-
- 19 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining various tests under fast/.
- platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
- platform/gtk/fast/block/float/016-expected.png:
- platform/gtk/fast/block/float/016-expected.txt:
- platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.png: Added.
- platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.txt:
- platform/gtk/fast/css/empty-pseudo-class-expected.txt:
- platform/gtk/fast/css/fieldset-display-row-expected.png:
- platform/gtk/fast/css/fieldset-display-row-expected.txt:
- platform/gtk/fast/css/first-child-pseudo-class-expected.txt:
- platform/gtk/fast/css/last-child-pseudo-class-expected.txt:
- platform/gtk/fast/css/only-child-pseudo-class-expected.txt:
- platform/gtk/fast/forms/basic-textareas-expected.png:
- platform/gtk/fast/forms/basic-textareas-expected.txt:
- platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
- platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:
- platform/gtk/fast/forms/textAreaLineHeight-expected.png:
- platform/gtk/fast/forms/textAreaLineHeight-expected.txt:
- platform/gtk/fast/parser/entity-comment-in-textarea-expected.png:
- platform/gtk/fast/parser/entity-comment-in-textarea-expected.txt:
- platform/gtk/fast/repaint/increasing-region-content-height-expected.txt: Added.
- 12:42 AM Changeset in webkit [159403] by
-
- 6 edits2 adds in trunk
Support exporting public RSASSA-PKCS1-v1_5 keys
https://bugs.webkit.org/show_bug.cgi?id=124475
Reviewed by Sam Weinig.
Source/WebCore:
Test: crypto/subtle/rsa-export-key.html
- bindings/js/JSCryptoKeySerializationJWK.h:
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::JSCryptoKeySerializationJWK::buildJSONForRSAComponents):
(WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON):
(WebCore::JSCryptoKeySerializationJWK::serialize):
Added said support (this part works with private keys too).
- crypto/keys/CryptoKeyRSA.h:
- crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::getPublicKeyComponents): Moved the logic for getting a
public key from private one here for reuse in keySizeInBits().
(WebCore::CryptoKeyRSA::isRestrictedToHash):
(WebCore::CryptoKeyRSA::keySizeInBits):
(WebCore::CryptoKeyRSA::exportData):
Exposed information necessary for JWK serialization.
LayoutTests:
- crypto/subtle/rsa-export-key-expected.txt: Added.
- crypto/subtle/rsa-export-key.html: Added.
- 12:27 AM Changeset in webkit [159402] by
-
- 20 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining CSS tests' expectations.
- platform/gtk/css1/box_properties/margin_right-expected.png:
- platform/gtk/css1/box_properties/margin_right-expected.txt:
- platform/gtk/css1/box_properties/padding-expected.png:
- platform/gtk/css1/box_properties/padding-expected.txt:
- platform/gtk/css1/box_properties/padding_left-expected.png:
- platform/gtk/css1/box_properties/padding_left-expected.txt:
- platform/gtk/css1/box_properties/padding_right-expected.png:
- platform/gtk/css1/box_properties/padding_right-expected.txt:
- platform/gtk/css1/box_properties/padding_top-expected.png:
- platform/gtk/css1/box_properties/padding_top-expected.txt:
- platform/gtk/css1/formatting_model/vertical_formatting-expected.png:
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
- platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/gtk/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
- platform/gtk/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
- platform/gtk/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
- platform/gtk/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
- platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.png:
- platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
- 12:25 AM Changeset in webkit [159401] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Process single tap using mouse move, down and up event.
https://bugs.webkit.org/show_bug.cgi?id=106864
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-11-18
Reviewed by Christophe Dumez.
Send mouse events to the web process to perform the clicking when
single tap gesture is recognized.
Additionally, add WKViewSendMouseDownEvent(), WKViewSendMouseUpEvent()
and WKViewSendMouseMoveEvent() to avoid using WK2 internals in the EFL
API implementation.
- UIProcess/API/C/efl/WKViewEfl.cpp:
(WKViewSendMouseDownEvent):
(WKViewSendMouseUpEvent):
(WKViewSendMouseMoveEvent):
- UIProcess/API/C/efl/WKViewEfl.h:
- UIProcess/API/efl/GestureRecognizer.cpp:
(WebKit::GestureHandler::handleSingleTap):
- UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::sendMouseEvent):
- UIProcess/efl/WebViewEfl.h:
Nov 17, 2013:
- 11:51 PM Changeset in webkit [159400] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] Fix revertJumpReplacementToBranchPtrWithPatch in MacroAssembler.
https://bugs.webkit.org/show_bug.cgi?id=124468
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-17
Reviewed by Michael Saboff.
Current implementation of revertJumpReplacementToBranchPtrWithPatch is wrong in
the sh4 MacroAssembler part, leading to random instabilities. This patch fixes it
and also renames the bad-named revertJumpToMove to revertJumpReplacementToBranchPtrWithPatch
in the SH4Assembler.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::revertJumpReplacementToBranchPtrWithPatch):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::replaceWithJump):
(JSC::SH4Assembler::revertJumpReplacementToBranchPtrWithPatch):
- 11:37 PM Changeset in webkit [159399] by
-
- 3 edits in trunk/WebKitLibraries
Update binary drops to include atrick's "Ran out of registers" fix in r194942.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 11:06 PM Changeset in webkit [159398] by
-
- 2 edits in trunk/Tools
Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
quite as easily.
With help from Andy Trick.
- Scripts/export-llvm-build:
- 9:42 PM Changeset in webkit [159397] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Add webgl crash tests because webgl is not supported
by EFL WK2 fully yet as well as not fully supported by Intel and AMD hardware.
- platform/efl-wk2/TestExpectations:
- 8:18 PM Changeset in webkit [159396] by
-
- 2 edits in trunk/LayoutTests
Layout Test platform/mac-wk2/plugins/slow/asynchronous-plugin-initialization-multiple.html is extremely flaky on Mac WK2 bots, especially debug
https://bugs.webkit.org/show_bug.cgi?id=124476
- platform/mac-wk2/TestExpectations:
Mark test as flaky.
- 6:10 PM Changeset in webkit [159395] by
-
- 18 edits in trunk/Source/JavaScriptCore
Simplify WatchpointSet state tracking
https://bugs.webkit.org/show_bug.cgi?id=124465
Reviewed by Sam Weinig.
We previously represented the state of watchpoint sets using two booleans. But that
makes it awkward to case over the state.
We also previously supported a watchpoint set being both watched and invalidated. We
never used that capability, and its presence was just purely confusing.
This turns the whole thing into an enum.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::branch8):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branch8):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::branch8):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branch8):
- bytecode/Watchpoint.cpp:
(JSC::WatchpointSet::WatchpointSet):
(JSC::WatchpointSet::add):
(JSC::WatchpointSet::notifyWriteSlow):
(JSC::InlineWatchpointSet::inflateSlow):
- bytecode/Watchpoint.h:
(JSC::WatchpointSet::state):
(JSC::WatchpointSet::isStillValid):
(JSC::WatchpointSet::startWatching):
(JSC::WatchpointSet::notifyWrite):
(JSC::WatchpointSet::addressOfState):
(JSC::InlineWatchpointSet::InlineWatchpointSet):
(JSC::InlineWatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::startWatching):
(JSC::InlineWatchpointSet::notifyWrite):
(JSC::InlineWatchpointSet::decodeState):
(JSC::InlineWatchpointSet::encodeState):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitVarInjectionCheck):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitVarInjectionCheck):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
- runtime/JSFunctionInlines.h:
(JSC::JSFunction::JSFunction):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- runtime/SymbolTable.cpp:
(JSC::SymbolTableEntry::attemptToWatch):
- runtime/SymbolTable.h:
- 5:46 PM Changeset in webkit [159394] by
-
- 39 edits9 adds2 deletes in trunk
FTL should have an explicit notion of bytecode liveness
https://bugs.webkit.org/show_bug.cgi?id=124181
Source/JavaScriptCore:
Reviewed by Sam Weinig.
This makes FTL OSR exit use bytecode liveness analysis to determine which variables
to include values for. The decision of how to get the values of variables is based on
forward propagation of MovHints and SetLocals.
This fixes a bunch of bugs (like https://bugs.webkit.org/show_bug.cgi?id=124138 but
also others that I noticed when I started writing more targetted tests) and allows us
to remove some sketchy code.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeBasicBlock.h:
- bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::isValidRegisterForLiveness):
(JSC::setForOperand):
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
(JSC::stepOverInstruction):
(JSC::computeLocalLivenessForBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint):
(JSC::BytecodeLivenessAnalysis::operandIsLiveAtBytecodeOffset):
(JSC::getLivenessInfo):
(JSC::BytecodeLivenessAnalysis::getLivenessInfoAtBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::computeFullLiveness):
- bytecode/BytecodeLivenessAnalysis.h:
- bytecode/BytecodeLivenessAnalysisInlines.h: Added.
(JSC::operandIsAlwaysLive):
(JSC::operandThatIsNotAlwaysLiveIsLive):
(JSC::operandIsLive):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::captureCount):
(JSC::CodeBlock::captureStart):
(JSC::CodeBlock::captureEnd):
- bytecode/CodeOrigin.cpp:
(JSC::InlineCallFrame::dumpInContext):
- bytecode/FullBytecodeLiveness.h: Added.
(JSC::FullBytecodeLiveness::FullBytecodeLiveness):
(JSC::FullBytecodeLiveness::getOut):
(JSC::FullBytecodeLiveness::operandIsLive):
(JSC::FullBytecodeLiveness::getLiveness):
- dfg/DFGAvailability.cpp: Added.
(JSC::DFG::Availability::dump):
(JSC::DFG::Availability::dumpInContext):
- dfg/DFGAvailability.h: Added.
(JSC::DFG::Availability::Availability):
(JSC::DFG::Availability::unavailable):
(JSC::DFG::Availability::withFlush):
(JSC::DFG::Availability::withNode):
(JSC::DFG::Availability::withUnavailableNode):
(JSC::DFG::Availability::nodeIsUndecided):
(JSC::DFG::Availability::nodeIsUnavailable):
(JSC::DFG::Availability::hasNode):
(JSC::DFG::Availability::node):
(JSC::DFG::Availability::flushedAt):
(JSC::DFG::Availability::operator!):
(JSC::DFG::Availability::operator==):
(JSC::DFG::Availability::merge):
(JSC::DFG::Availability::mergeNodes):
(JSC::DFG::Availability::unavailableMarker):
- dfg/DFGBasicBlock.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::Disassembler):
- dfg/DFGFlushFormat.cpp:
(WTF::printInternal):
- dfg/DFGFlushFormat.h:
(JSC::DFG::resultFor):
(JSC::DFG::useKindFor):
(JSC::DFG::dataFormatFor):
- dfg/DFGFlushedAt.cpp:
(JSC::DFG::FlushedAt::dump):
- dfg/DFGFlushedAt.h:
(JSC::DFG::FlushedAt::FlushedAt):
(JSC::DFG::FlushedAt::merge):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::livenessFor):
(JSC::DFG::Graph::isLiveInBytecode):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::baselineCodeBlockFor):
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
- dfg/DFGOSRAvailabilityAnalysisPhase.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGResurrectionForValidationPhase.cpp: Added.
(JSC::DFG::ResurrectionForValidationPhase::ResurrectionForValidationPhase):
(JSC::DFG::ResurrectionForValidationPhase::run):
(JSC::DFG::performResurrectionForValidation):
- dfg/DFGResurrectionForValidationPhase.h: Added.
- dfg/DFGSSAConversionPhase.cpp:
(JSC::DFG::SSAConversionPhase::run):
- dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::forFlushFormat):
- dfg/DFGVariableAccessData.h:
- ftl/FTLExitValue.cpp:
(JSC::FTL::ExitValue::dumpInContext):
- ftl/FTLInlineCacheSize.cpp:
(JSC::FTL::sizeOfGetById):
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::gpr):
(JSC::FTL::Location::fpr):
(JSC::FTL::Location::directGPR):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileZombieHint):
(JSC::FTL::LowerDFGToLLVM::compilePutById):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):
- ftl/FTLOutput.h:
(JSC::FTL::Output::alloca):
- ftl/FTLValueSource.cpp: Removed.
- ftl/FTLValueSource.h: Removed.
- llvm/LLVMAPIFunctions.h:
- runtime/DumpContext.cpp:
(JSC::DumpContext::DumpContext):
- runtime/DumpContext.h:
- runtime/Options.h:
- runtime/SymbolTable.h:
(JSC::SharedSymbolTable::captureStart):
(JSC::SharedSymbolTable::captureEnd):
(JSC::SharedSymbolTable::captureCount):
Tools:
Reviewed by Mark Hahnenberg.
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Mark Hahnenberg or Sam Weinig.
I totally added this test after the rest of the patch was r+'d. Under the right tier-up
modes this triggers one of the bugs that the rest of the patch is trying to avoid.
- js/regress/script-tests/weird-inlining-const-prop.js: Added.
(foo):
(bar):
(fuzz):
(testImpl):
(test):
- js/regress/weird-inlining-const-prop-expected.txt: Added.
- js/regress/weird-inlining-const-prop.html: Added.
- 5:18 PM Changeset in webkit [159393] by
-
- 4 edits2 adds in trunk
RSASSA-PKCS1-v1_5 JWK import doesn't check key size
https://bugs.webkit.org/show_bug.cgi?id=124472
Reviewed by Sam Weinig.
Source/WebCore:
Test: crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-small-key.html
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid): Added the checks.
(WebCore::JSCryptoKeySerializationJWK::keyDataRSAComponents): Check key size when
importing.
(WebCore::JSCryptoKeySerializationJWK::serialize): Updated a comment.
- crypto/keys/CryptoKeySerializationRaw.cpp: (WebCore::CryptoKeySerializationRaw::serialize):
Updated a comment.
LayoutTests:
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-small-key-expected.txt: Added.
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-small-key.html: Added.
- 5:17 PM Changeset in webkit [159392] by
-
- 6 edits in trunk
JWK crypto key export result is a DOM string instead of an array buffer
https://bugs.webkit.org/show_bug.cgi?id=124473
Reviewed by Sam Weinig.
Source/WebCore:
- bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::exportKey):
Fix it.
LayoutTests:
- crypto/subtle/aes-export-key.html:
- crypto/subtle/hmac-export-key.html:
- crypto/subtle/resources/common.js: (bytesToASCIIString): Added a function that
converts an ArrayBuffer to a string, assuming it's all ASCII.
- 5:12 PM Changeset in webkit [159391] by
-
- 20 edits in trunk/Source/WebCore
LayoutStateMaintainer should use references where possible
https://bugs.webkit.org/show_bug.cgi?id=124471
Reviewed by Dan Bernstein.
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/LayoutState.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedLayout):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::layout):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::pushFlowThreadLayoutState):
- rendering/RenderFlowThread.h:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::layout):
- rendering/RenderView.cpp:
(WebCore::RenderView::pushLayoutState):
(WebCore::RenderView::pushLayoutStateForCurrentFlowThread):
- rendering/RenderView.h:
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
(WebCore::LayoutStateMaintainer::pop):
- 1:41 PM Changeset in webkit [159390] by
-
- 32 edits in trunk/Source
Use uint8_t vectors for WebCrypto data
https://bugs.webkit.org/show_bug.cgi?id=124466
Reviewed by Sam Weinig.
Source/WebCore:
Using Vector<char> for crypto key data is somewhat non-idiomatic, and it gets simply
dangerous for bignums, because signed arithmetic is not appropriate for bignum digits.
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::generateSecWebSocketKey):
(WebCore::WebSocketHandshake::getExpectedWebSocketAccept):
No longer need to cast data to char* here.
- bindings/js/JSCryptoKeySerializationJWK.cpp:
- bindings/js/JSCryptoKeySerializationJWK.h:
- crypto/CryptoDigest.h:
- crypto/CryptoKey.h:
- crypto/keys/CryptoKeyAES.cpp:
- crypto/keys/CryptoKeyAES.h:
- crypto/keys/CryptoKeyDataOctetSequence.h:
- crypto/keys/CryptoKeyDataRSAComponents.cpp:
- crypto/keys/CryptoKeyDataRSAComponents.h:
- crypto/keys/CryptoKeyHMAC.cpp:
- crypto/keys/CryptoKeyHMAC.h:
- crypto/keys/CryptoKeyRSA.h:
- crypto/keys/CryptoKeySerializationRaw.cpp:
- crypto/keys/CryptoKeySerializationRaw.h:
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
- crypto/mac/CryptoDigestMac.cpp:
- crypto/mac/CryptoKeyMac.cpp:
- crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h:
Switched to Vector<uint8_t>.
- crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::getPublicKeyComponents): Extracted from buildAlgorithmDescription() and simplified.
(WebCore::CryptoKeyRSA::create): Switched to Vector<uint8_t>.
(WebCore::CryptoKeyRSA::buildAlgorithmDescription): No longer need to copy data just
to change type from Vector<char> to Vector<unsigned char>.
(WebCore::bigIntegerToUInt32): Ditto. No longer need to cast types when dealing with the bignum.
(WebCore::CryptoKeyRSA::generatePair): Improved an error message a little.
- fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::convertToDataURL):
- inspector/DOMPatchSupport.cpp: (WebCore::DOMPatchSupport::createDigest):
- inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::archive):
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::CGImageToDataURL):
No longer need to cast data to char* here.
Source/WTF:
Binary data can be UTF-8, in which case "char*" is idiomatic, or it can be arbitrary
binary data, in which case "uint8_t*" is more common.
Changed encode functions that took "const char *" to "const void*", and decode
functions that took "Vector<char>&" now take an adapter class.
The adapter relies on Vector<char> and Vector<uint8_t> classes having an identical layout.
- wtf/text/Base64.cpp:
(WTF::base64Encode):
(WTF::base64URLEncode):
(WTF::base64DecodeInternal):
(WTF::base64Decode):
(WTF::base64URLDecode):
- wtf/text/Base64.h:
(WTF::SignedOrUnsignedCharVectorAdapter):
(WTF::ConstSignedOrUnsignedCharVectorAdapter):
(WTF::base64Encode):
(WTF::base64URLEncode):
- 1:37 PM Changeset in webkit [159389] by
-
- 3 edits2 adds in trunk
REGRESSION (r158774): Iteration over element children is broken
https://bugs.webkit.org/show_bug.cgi?id=124145
Source/WebCore:
Reviewed by Anders Carlsson.
Mutation during traversal invalidates the position cache. After the mid-point we start
traversing backwards as it the shortest path. However backward traversal of children-only
HTMLCollection was wrong and would end up going to descendants.
Reduction by yannick.poirier@inverto.tv.
Test: fast/dom/htmlcollection-children-mutation.html
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::collectionTraverseBackward):
Traverse direct children only when m_shouldOnlyIncludeDirectChildren bit is set.
LayoutTests:
Reviewed by Anders Carlsson.
- fast/dom/htmlcollection-children-mutation-expected.txt: Added.
- fast/dom/htmlcollection-children-mutation.html: Added.
- 1:00 PM Changeset in webkit [159388] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the EFL build.
- UIProcess/efl/PagePolicyClientEfl.cpp:
(WebKit::PagePolicyClientEfl::decidePolicyForResponseCallback): No need to call
WKFrameCanShowMIMEType now that this information is passed in as a parameter.
- 12:30 PM Changeset in webkit [159387] by
-
- 19 edits in trunk
No way for policy client to determine if a the response’s MIME type can be shown
https://bugs.webkit.org/show_bug.cgi?id=124445
Reviewed by Sam Weinig.
Source/WebKit2:
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction): Added a fifth message parameter to this template.
- UIProcess/API/C/WKPage.h: Added a canShowMIMEType parameter to
WKPageDecidePolicyForResponseCallback and deprecated the old version.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(setUpPagePolicyClient): Include whether the response MIME type can be shown under a new key
in the action information dictionary.
- UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Declared
WKActionCanShowMIMETypeKey.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage): Updated for changes in the policy client.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForResponse): Added canShowMIMEType parameter, which is
passed to the policy client.
(WebKit::WebPageProxy::decidePolicyForResponseSync): Added canShowMIMEType parameter, which
is passed to the above function.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Added canShowMIMEType paramter to
DecidePolicyForResponseSync.
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForResponse): Added canShowMIMEType parameter, which
is passed to the client callback.
- UIProcess/WebPolicyClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse): Determine if the response
MIME type can be shown and pass this information along in the message to the UI process.
Tools:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(decidePolicyForResponse): Added canShowMIMEType parameter.
(-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
(WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
- WebKitTestRunner/TestController.h:
- 10:25 AM Changeset in webkit [159386] by
-
- 4 edits1 move in trunk/Source/WebCore
Move LineLayoutState.h into rendering/line
<https://webkit.org/b/124458>
Reviewed by Mihnea Ovidenie.
LineLayoutState is a helper class of RenderBlockLineLayout, so I'm moving it into line subdirectory.
No new tests, no behavior change.
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/line/LineLayoutState.h: Renamed from Source/WebCore/rendering/LineLayoutState.h.
(WebCore::FloatWithRect::FloatWithRect):
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::lineInfo):
(WebCore::LineLayoutState::endLineLogicalTop):
(WebCore::LineLayoutState::setEndLineLogicalTop):
(WebCore::LineLayoutState::endLine):
(WebCore::LineLayoutState::setEndLine):
(WebCore::LineLayoutState::lastFloat):
(WebCore::LineLayoutState::setLastFloat):
(WebCore::LineLayoutState::floats):
(WebCore::LineLayoutState::floatIndex):
(WebCore::LineLayoutState::setFloatIndex):
(WebCore::LineLayoutState::adjustedLogicalLineTop):
(WebCore::LineLayoutState::setAdjustedLogicalLineTop):
(WebCore::LineLayoutState::flowThread):
(WebCore::LineLayoutState::setFlowThread):
(WebCore::LineLayoutState::endLineMatched):
(WebCore::LineLayoutState::setEndLineMatched):
(WebCore::LineLayoutState::checkForFloatsFromLastLine):
(WebCore::LineLayoutState::setCheckForFloatsFromLastLine):
(WebCore::LineLayoutState::markForFullLayout):
(WebCore::LineLayoutState::isFullLayout):
(WebCore::LineLayoutState::usesRepaintBounds):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
- 9:29 AM Changeset in webkit [159385] by
-
- 3 edits2 adds in trunk
Simple line path does not respect visibility:hidden
https://bugs.webkit.org/show_bug.cgi?id=124467
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/text/text-visibility.html
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):
LayoutTests:
- fast/text/text-visibility-expected.html: Added.
- fast/text/text-visibility.html: Added.
Nov 16, 2013:
- 7:49 PM Changeset in webkit [159384] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of JSActivation.h.
Rubber stamped by Mark Hahnenberg.
- runtime/JSActivation.h:
- 7:41 PM Changeset in webkit [159383] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of JSVariableObject.h.
Rubber stamped by Mark Hahnenberg.
I'm about to do some damage to this file. I wanted to give it some sanity first.
- runtime/JSVariableObject.h:
- 3:19 PM Changeset in webkit [159382] by
-
- 3 edits1 add in trunk/Tools
Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=122909
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
(StatusLineView.prototype.set repeatCount):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line.good .bubble.pictogram):
Use an SVG image instead of an obscure font for the checkboxes so they
render identically on all platforms.
- 2:28 PM Changeset in webkit [159381] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Fix build (broken since r159346).
https://bugs.webkit.org/show_bug.cgi?id=124455
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-16
Reviewed by Oliver Hunt.
Fix LLINT implementation for sh4 architecture to handle properly load and store operations with pr register.
- offlineasm/sh4.rb:
- 11:14 AM Changeset in webkit [159380] by
-
- 2 edits in trunk/Source/WebCore
WebCrypto no longer uses sequences of ArrayBuffers
https://bugs.webkit.org/show_bug.cgi?id=124451
Build fix.
- crypto/mac/CryptoAlgorithmHMACMac.cpp: (WebCore::calculateSignature):
Now that the function became shorter, clang realized that a variable was used
uninitialized in an impossible code path.
- 10:58 AM Changeset in webkit [159379] by
-
- 48 edits in trunk
WebCrypto no longer uses sequences of ArrayBuffers
https://bugs.webkit.org/show_bug.cgi?id=124451
Reviewed by Sam Weinig.
Source/WebCore:
Covered by existing tests.
Changed all operations to take single CryptoOperationData objects.
- bindings/js/JSCryptoOperationData.cpp:
- bindings/js/JSCryptoOperationData.h:
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::digest):
- crypto/CryptoAlgorithm.cpp:
(WebCore::CryptoAlgorithm::encrypt):
(WebCore::CryptoAlgorithm::decrypt):
(WebCore::CryptoAlgorithm::sign):
(WebCore::CryptoAlgorithm::verify):
(WebCore::CryptoAlgorithm::digest):
- crypto/CryptoAlgorithm.h:
- crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
- crypto/algorithms/CryptoAlgorithmAES_CBC.h:
- crypto/algorithms/CryptoAlgorithmHMAC.h:
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
- crypto/algorithms/CryptoAlgorithmSHA1.cpp:
(WebCore::CryptoAlgorithmSHA1::digest):
- crypto/algorithms/CryptoAlgorithmSHA1.h:
- crypto/algorithms/CryptoAlgorithmSHA224.cpp:
(WebCore::CryptoAlgorithmSHA224::digest):
- crypto/algorithms/CryptoAlgorithmSHA224.h:
- crypto/algorithms/CryptoAlgorithmSHA256.cpp:
(WebCore::CryptoAlgorithmSHA256::digest):
- crypto/algorithms/CryptoAlgorithmSHA256.h:
- crypto/algorithms/CryptoAlgorithmSHA384.cpp:
(WebCore::CryptoAlgorithmSHA384::digest):
- crypto/algorithms/CryptoAlgorithmSHA384.h:
- crypto/algorithms/CryptoAlgorithmSHA512.cpp:
(WebCore::CryptoAlgorithmSHA512::digest):
- crypto/algorithms/CryptoAlgorithmSHA512.h:
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
- crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h:
LayoutTests:
Updated tests accordingly.
- crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
- crypto/subtle/aes-cbc-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-import-jwk.html:
- crypto/subtle/aes-cbc-wrong-key-class-expected.txt:
- crypto/subtle/aes-cbc-wrong-key-class.html:
- crypto/subtle/argument-conversion-expected.txt:
- crypto/subtle/argument-conversion.html:
- crypto/subtle/hmac-import-jwk.html:
- crypto/subtle/hmac-sign-verify-empty-key.html:
- crypto/subtle/hmac-sign-verify.html:
- crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html:
- crypto/subtle/sha-1-expected.txt:
- crypto/subtle/sha-1.html:
- crypto/subtle/sha-224-expected.txt:
- crypto/subtle/sha-224.html:
- crypto/subtle/sha-256-expected.txt:
- crypto/subtle/sha-256.html:
- crypto/subtle/sha-384-expected.txt:
- crypto/subtle/sha-384.html:
- crypto/subtle/sha-512-expected.txt:
- crypto/subtle/sha-512.html:
- 2:08 AM Changeset in webkit [159378] by
-
- 2 edits in trunk/Source/WebCore
Remove the include of LineWidth.h from SimpleLineLayoutFunctions.cpp
<https://webkit.org/b/124449>
Reviewed by Antti Koivisto.
I removed the include of LineWidth, since SimpleLineLayoutFunctions.cpp doesn't use it.
No new tests, no behavior change.
- rendering/SimpleLineLayoutFunctions.cpp:
Nov 15, 2013:
- 11:10 PM Changeset in webkit [159377] by
-
- 18 edits in trunk
Support exporting symmetric keys as JWK
https://bugs.webkit.org/show_bug.cgi?id=124442
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- runtime/JSONObject.h: Export JSONStringify.
Source/WebCore:
Error handling is not consistent yet - some errors cause exceptions, and others
result in rejected promises. This part of spec is incomplete, so I basically did
what was most straightforward in each case.
- bindings/js/JSCryptoKeySerializationJWK.h:
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::JSCryptoKeySerializationJWK::reconcileUsages): Updated a comment with a better link.
(WebCore::JSCryptoKeySerializationJWK::buildJSONForOctetSequence): A helper to building JWK.
(WebCore::JSCryptoKeySerializationJWK::addToJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::addBoolToJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::addJWKAlgorithmToJSON): Ditto. The code for
mapping is my best guess, this all needs to be specified.
(WebCore::JSCryptoKeySerializationJWK::addJWKUseToJSON): A helper to building JWK.
(WebCore::JSCryptoKeySerializationJWK::serialize): Build a JSON string for the key.
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::importKey): Updated a comment.
(WebCore::JSSubtleCrypto::exportKey): Use CryptoKeySerialization (also for raw keys,
for consistency).
- crypto/CryptoKey.h:
(WebCore::CryptoKey::algorithmIdentifier):
(WebCore::CryptoKey::usagesBitmap):
Exposed data needed for building JWK (it used to be only exposed in a form suitable
for DOM accessors).
- crypto/keys/CryptoKeyHMAC.h: Ditto, added an accessor for JWK.
- crypto/keys/CryptoKeySerializationRaw.cpp: (WebCore::CryptoKeySerializationRaw::serialize):
- crypto/keys/CryptoKeySerializationRaw.h:
Moved from JSSubtleCryptoCustom.cpp for consistency.
Source/WTF:
Base64URL encoding doesn't use '=' padding, and doesn't need any other options.
Added this mode for encode, and removed policy arguments from exposed functions.
- wtf/text/Base64.cpp:
(WTF::base64EncodeInternal):
(WTF::base64URLEncode):
(WTF::base64URLDecode):
- wtf/text/Base64.h:
(WTF::base64URLEncode):
LayoutTests:
- crypto/subtle/aes-export-key-expected.txt:
- crypto/subtle/aes-export-key.html:
- crypto/subtle/hmac-export-key-expected.txt:
- crypto/subtle/hmac-export-key.html:
- 7:25 PM Changeset in webkit [159376] by
-
- 4 edits in trunk/Source/JavaScriptCore
[Win] JavaScript crashes on 64-bit with JIT enabled.
https://bugs.webkit.org/show_bug.cgi?id=124409
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-15
Reviewed by Michael Saboff.
These are issues found with JIT on 64-bit:
- The registers rsi and rdi in callToJavaScript needs to be saved and restored. This is required by the Windows 64-bit ABI.
- The getHostCallReturnValue function needs to be updated according to it's GCC counterpart.
- The poke argument offset needs to be 20h, because Windows 64-bit ABI requires stack space allocated for the 4 argument registers.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Re-added JITStubsMSVC64.asm to project.
- jit/CCallHelpers.h: Set poke argument offset.
(JSC::CCallHelpers::setupArguments): Compile fix, added needed method.
- jit/JITStubsMSVC64.asm: Save and restore registers rsi and rdi.
Update getHostCallReturnValue according to the GCC version.
- 5:32 PM Changeset in webkit [159375] by
-
- 2 edits in trunk/Source/ThirdParty
Unreviewed, gtest project file cleanup.
- gtest/msvc/gtest-md.vcxproj:
- 5:28 PM Changeset in webkit [159374] by
-
- 3 edits1 delete in trunk/LayoutTests
Make results.html more sane
https://bugs.webkit.org/show_bug.cgi?id=124446
Reviewed by Sam Weinig.
Fix various issues with results.html:
- make it use page scrolling, not overflow scrolling
- remove -webkit-flex stuff that wasn't doing anything
- prettify the floating overlay for flagged tests
- pull some markup out of the JS and into the HTML
- remove the self-testing, which provides very little reward.
- fast/harness/resources/results-test.js: Removed.
- fast/harness/results-expected.txt:
- fast/harness/results.html:
- 5:16 PM Changeset in webkit [159373] by
-
- 6 edits2 adds in trunk/Source/WebCore
Move IDBCursorBackend operations into their own files
https://bugs.webkit.org/show_bug.cgi?id=124444
Reviewed by Tim Horton.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBCursorBackend.cpp:
- Modules/indexeddb/IDBCursorBackend.h:
(WebCore::IDBCursorBackend::cursorType):
(WebCore::IDBCursorBackend::deprecatedBackingStoreCursor):
(WebCore::IDBCursorBackend::deprecatedSetBackingStoreCursor):
(WebCore::IDBCursorBackend::deprecatedSetSavedBackingStoreCursor):
- Modules/indexeddb/IDBCursorBackendOperations.cpp: Added.
(WebCore::CallOnDestruct::CallOnDestruct):
(WebCore::CallOnDestruct::~CallOnDestruct):
(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):
(WebCore::CursorPrefetchIterationOperation::perform):
- Modules/indexeddb/IDBCursorBackendOperations.h: Added.
(WebCore::CursorIterationOperation::create):
(WebCore::CursorIterationOperation::CursorIterationOperation):
(WebCore::CursorAdvanceOperation::create):
(WebCore::CursorAdvanceOperation::CursorAdvanceOperation):
(WebCore::CursorPrefetchIterationOperation::create):
(WebCore::CursorPrefetchIterationOperation::CursorPrefetchIterationOperation):
- 5:10 PM Changeset in webkit [159372] by
-
- 3 edits in trunk/LayoutTests
results.html should have a link to historical results for a test/all failing tests
https://bugs.webkit.org/show_bug.cgi?id=124402
Reviewed by Simon Fraser.
- fast/harness/results.html:
- fast/harness/resources/results-test.js:
Add the link to timeout/crash results too.
- 4:55 PM Changeset in webkit [159371] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed EFL build fix after r159358.
- UIProcess/efl/PagePolicyClientEfl.cpp:
(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
- UIProcess/efl/PagePolicyClientEfl.h:
- 4:22 PM Changeset in webkit [159370] by
-
- 2 edits in trunk/LayoutTests
http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, frequently > 30 second timeout
https://bugs.webkit.org/show_bug.cgi?id=124373
- platform/mac/TestExpectations:
Mark test as timeout as well, since that happens sometimes too.
- 4:11 PM Changeset in webkit [159369] by
-
- 4 edits in trunk/Source
Copy ASAN flag settings to WebCore and JavaScriptCore intermediate build tools
https://bugs.webkit.org/show_bug.cgi?id=124362
Reviewed by David Kilzer.
Source/JavaScriptCore:
- Configurations/ToolExecutable.xcconfig:
Use ASAN_C*FLAGS.
Source/WebCore:
No new tests needed.
- WebCore.xcodeproj/project.pbxproj:
Use ASAN_C*FLAGS for WebCoreExportFileGenerator.
- 4:01 PM Changeset in webkit [159368] by
-
- 7 edits in trunk/Source/WebCore
[Mac][AVF] Allow video and audio tracks to be initialized with an AVAssetTrack.
https://bugs.webkit.org/show_bug.cgi?id=124421
Reviewed by Eric Carlson.
Currently, VideoTrackPrivateAVFObjC and AudioTrackPrivateAVFObjC are initialized with an
AVPlayerItemTrack, but most of its methods use the AVAssetTrack wrapped by the
AVPlayerItemTrack. Allow these objects to be alternatively initialized with an AVAssetTrack.
Add factory methods taking an AVAssetTrack:
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
(WebCore::AudioTrackPrivateAVFObjC::create):
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC):
(WebCore::AudioTrackPrivateAVFObjC::setAssetTrack):
(WebCore::AudioTrackPrivateAVFObjC::assetTrack):
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp:
(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC):
(WebCore::VideoTrackPrivateAVFObjC::setAssetTrack):
(WebCore::VideoTrackPrivateAVFObjC::assetTrack):
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
Use m_assetTrack instead of [m_playerItemTrack assetTrack]:
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h:
(WebCore::AVTrackPrivateAVFObjCImpl::assetTrack):
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::AVTrackPrivateAVFObjCImpl):
(WebCore::AVTrackPrivateAVFObjCImpl::enabled):
(WebCore::AVTrackPrivateAVFObjCImpl::setEnabled):
(WebCore::AVTrackPrivateAVFObjCImpl::audioKind):
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind):
(WebCore::AVTrackPrivateAVFObjCImpl::id):
(WebCore::AVTrackPrivateAVFObjCImpl::label):
(WebCore::AVTrackPrivateAVFObjCImpl::language):
(WebCore::AVTrackPrivateAVFObjCImpl::trackID):
- 3:50 PM Changeset in webkit [159367] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed Win build fix; setCurrentTime() no longer takes an exception parameter.
- FullscreenVideoController.cpp:
(FullscreenVideoController::setCurrentTime):
- 3:47 PM Changeset in webkit [159366] by
-
- 2 edits2 deletes in trunk/Source/JavaScriptCore
Remove JSChunk
https://bugs.webkit.org/show_bug.cgi?id=124435
Reviewed by Geoffrey Garen.
It's empty and has been since it was added 3 years ago.
- CMakeLists.txt:
- runtime/JSChunk.cpp: Removed.
- runtime/JSChunk.h: Removed.
- 3:44 PM Changeset in webkit [159365] by
-
- 9 edits in trunk/Source
Let IDBDatabaseBackend create IDBTransactionBackend's directly
https://bugs.webkit.org/show_bug.cgi?id=124438
Reviewed by Beth Dakin.
Source/WebCore:
Create IDBTransactionBackends directly:
- Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::createTransaction):
- Modules/indexeddb/IDBDatabaseBackend.h:
Remove maybeCreateTransactionBackend():
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
Source/WebKit2:
Remove maybeCreateTransactionBackend():
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- 3:42 PM Changeset in webkit [159364] by
-
- 3 edits in trunk/Tools
Occasionally, hundreds of tests fail with small text diffs on Mavericks
https://bugs.webkit.org/show_bug.cgi?id=124312
Reviewed by Alexey Proskuryakov.
Try reverting the part of r158652 that deleted all of the persistent
defaults, in the thought that there might be some sort of race between
processes causing some settings to be left in the wrong state.
- DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting):
- WebKitTestRunner/mac/main.mm:
(setDefaultsToConsistentValuesForTesting):
- 3:38 PM Changeset in webkit [159363] by
-
- 12 edits2 deletes in trunk
HTMLMediaElement should not throw an exception from setCurrentTime or fastSeek.
https://bugs.webkit.org/show_bug.cgi?id=124294
Reviewed by Eric Carlson.
Source/WebCore:
Update the seek logic to match the current specification. This means removing exception
throwing from both the .idl and the implementation.
Remove the ExceptionCode parameter from setCurrentTime and fastSeek:
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::fastSeek):
(HTMLMediaElement::seek):
(HTMLMediaElement::seekWithTolerance):
(HTMLMediaElement::setCurrentTime):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- html/MediaController.cpp:
(MediaController::setCurrentTime):
- html/MediaController.h:
- html/MediaController.idl:
- html/MediaControllerInterface.h:
Do not pass in an ExceptionCode placeholder when calling seek:
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::rewind):
(HTMLMediaElement::returnToRealtime):
(HTMLMediaElement::finishSeek):
(HTMLMediaElement::playInternal):
(HTMLMediaElement::mediaPlayerTimeChanged):
(HTMLMediaElement::mediaPlayerDurationChanged):
(HTMLMediaElement::applyMediaFragmentURI):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- html/MediaController.cpp:
(MediaController::bringElementUpToSpeed):
- html/MediaController.h:
- html/MediaController.idl:
- html/MediaControllerInterface.h:
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlSeekButtonElement::seekTimerFired):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlRewindButtonElement::defaultEventHandler):
(WebCore::MediaControlTimelineElement::defaultEventHandler):
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
LayoutTests:
- media/video-seek-no-src-exception-expected.txt: Removed.
- media/video-seek-no-src-exception.html: Removed.
- 3:22 PM Changeset in webkit [159362] by
-
- 11 edits in trunk/Source
Remove last vestiges of IDBBackingStore* from IDBTransactionBackend.
https://bugs.webkit.org/show_bug.cgi?id=124436
Reviewed by Tim Horton.
Source/WebCore:
- Modules/indexeddb/IDBFactoryBackendInterface.h: Removed createCursorBackend.
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp: Removed createCursorBackend.
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h: Removed createCursorBackend.
- Modules/indexeddb/IDBCursorBackend.h:
- Modules/indexeddb/IDBTransactionBackend.cpp:
- Modules/indexeddb/IDBTransactionBackend.h:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::openCursor):
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp: Removed createCursorBackend.
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- 3:21 PM Changeset in webkit [159361] by
-
- 2 edits in trunk/LayoutTests
Layout Test editing/selection/5057506.html frequently times out on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=124437
- platform/mac-wk2/TestExpectations:
Mark aforementioned test as a flaky-timeout.
- 2:47 PM Changeset in webkit [159360] by
-
- 15 edits2 deletes in trunk/Source
Remove VTableSpectrum
https://bugs.webkit.org/show_bug.cgi?id=124427
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/Heap.cpp:
(JSC::Heap::lastChanceToFinalize):
- heap/Heap.h:
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor):
- heap/SlotVisitor.cpp:
(JSC::visitChildren):
- heap/SlotVisitor.h:
- heap/VTableSpectrum.cpp: Removed.
- heap/VTableSpectrum.h: Removed.
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WTF:
- wtf/Platform.h:
- 2:24 PM Changeset in webkit [159359] by
-
- 9 edits2 moves in trunk/Source/WebCore
Make IDBIndexWriter a LevelDB specific concept
https://bugs.webkit.org/show_bug.cgi?id=124434
Reviewed by Tim Horton.
This includes renaming the class and moving it into the leveldb subdirectory.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::makeIndexWriters):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBIndexWriter.cpp.
(WebCore::IDBIndexWriterLevelDB::IDBIndexWriterLevelDB):
(WebCore::IDBIndexWriterLevelDB::writeIndexKeys):
(WebCore::IDBIndexWriterLevelDB::verifyIndexKeys):
(WebCore::IDBIndexWriterLevelDB::addingKeyAllowed):
- Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBIndexWriter.h.
(WebCore::IDBIndexWriterLevelDB::create):
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::setIndexKeys):
(WebCore::IDBServerConnectionLevelDB::put):
- 2:22 PM Changeset in webkit [159358] by
-
- 20 edits in trunk
Give the policy client the originating frame of a navigation action
https://bugs.webkit.org/show_bug.cgi?id=124431
Reviewed by Anders Carlsson.
Source/WebKit2:
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction): Added a seventh message parameter to this template.
- Shared/APIClientTraits.cpp: Defined API traits for WKPagePolicyClient, which now has two
versions.
- Shared/APIClientTraits.h: Declared APIClientTraits<WKPagePolicyClient>.
- UIProcess/API/C/WKPage.h: Added an originatingFrame parameter to
WKPageDecidePolicyForNavigationActionCallback and deprecated the old version. Bumped the
policy client version to 1.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(setUpPagePolicyClient): Include the originating frame’s URL under the a new key in the
action information dictionary.
- UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Declared
WKActionOriginatingFrameURLKey.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::decidePolicyForNavigationAction): Added originatingFrame parameter.
(WebKit::WebInspectorProxy::createInspectorPage): Updated to the new version of the policy
client interface.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction): Added originatingFrameID parameter
and passing the originating frame to the policy client.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Added originatingFrameID paremeter to
DecidePolicyForNavigationAction.
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction): Added originatingFrame
parameter, which is passed to the client callback.
- UIProcess/WebPolicyClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Determine the
originating frame for link activation and form submission actions and send its ID in the
DecidePolicyForNavigationAction message.
Tools:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(decidePolicyForNavigationAction): Added originatingFrame parameter.
(-[WK2BrowserWindowController awakeFromNib]): Updated for the new version of the policy
client.
- TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
(TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
(TestWebKitAPI::setPagePolicyClient): Updated for the new version of the policy client.
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
(TestWebKitAPI::TEST): Updated for the new version of the policy client.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions): Updated for the new version of the policy
client.
(WTR::TestController::decidePolicyForNavigationAction): Added originatingFrame parameter.
- WebKitTestRunner/TestController.h:
- 2:08 PM Changeset in webkit [159357] by
-
- 12 edits13 adds in trunk
Web Inspector: DOM.performSearch should accept a list of context nodes
https://bugs.webkit.org/show_bug.cgi?id=124390
Reviewed by Timothy Hatcher.
Source/WebCore:
Extracted the code in InspectorDOMAgent::performSearch into its own helper class
called InspectorNodeFinder. Also added a new array parameter called "nodeIds"
that can be used to limit the search results to just partial subtrees.
Tests: inspector-protocol/dom/dom-search-crash.html
inspector-protocol/dom/dom-search-with-context.html
inspector-protocol/dom/dom-search.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/protocol/DOM.json:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorNodeFinder.cpp: Added.
(WebCore::stripCharacters):
(WebCore::InspectorNodeFinder::InspectorNodeFinder):
(WebCore::InspectorNodeFinder::performSearch):
(WebCore::InspectorNodeFinder::searchUsingDOMTreeTraversal):
(WebCore::InspectorNodeFinder::matchesAttribute):
(WebCore::InspectorNodeFinder::matchesElement):
(WebCore::InspectorNodeFinder::searchUsingXPath):
(WebCore::InspectorNodeFinder::searchUsingCSSSelectors):
- inspector/InspectorNodeFinder.h: Added.
(WebCore::InspectorNodeFinder::results):
LayoutTests:
Added new inspector-protocol tests to check for the DOM.performSearch implementation.
Also, ported an existing test from the old "inspector" format.
- http/tests/inspector-protocol/resources/InspectorDOMListener.js: Added boilerplate code that
can be used to track node ids and class names.
(createDOMListener.createNodeAttributesMap):
(createDOMListener.collectNode):
(createDOMListener.onSetChildNodes):
(createDOMListener.onChildNodeRemoved):
(createDOMListener.onChildNodeInserted):
(createDOMListener.return.getNodeById):
(createDOMListener.return.getNodeIdentifier):
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorFrontendAPI.dispatchMessageAsync): Added a way to catch all the messages received in the inspector.
It is useful for debugging the test file.
(InspectorTest.addEventListener): Helper method to register multiple handlers for the same event.
- inspector-protocol/dom/dom-search-crash-expected.txt: Added.
- inspector-protocol/dom/dom-search-crash.html: Added.
- inspector-protocol/dom/dom-search-expected.txt: Added.
- inspector-protocol/dom/dom-search-with-context-expected.txt: Added.
- inspector-protocol/dom/dom-search-with-context.html: Added.
- inspector-protocol/dom/dom-search.html: Added.
- inspector-protocol/dom/resources/dom-search-crash-iframe.html: Cloned from inspector/dom/resources/dom-search-crash-iframe.html
- inspector-protocol/dom/resources/dom-search-iframe.html: Added.
- inspector-protocol/dom/resources/dom-search-queries.js: Added.
- 2:07 PM Changeset in webkit [159356] by
-
- 2 edits in trunk/LayoutTests
Make lint-test-expectations pass for platform/win
- platform/win/TestExpectations:
I always kept the stronger expectation in the case of duplicates.
- 1:59 PM Changeset in webkit [159355] by
-
- 5 edits in trunk/Source/WebCore
Remove IDBBackingStoreInterface.h includes that are no longer needed
https://bugs.webkit.org/show_bug.cgi?id=124433
Reviewed by Tim Horton.
- Modules/indexeddb/IDBCursorBackend.cpp:
- Modules/indexeddb/IDBCursorBackend.h:
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/IDBTransactionBackend.h:
- 1:40 PM Changeset in webkit [159354] by
-
- 8 edits1 move6 adds in trunk/Source/WebCore
Move BreakingContext and LineBreaker into their own files
<https://webkit.org/b/124336>
Reviewed by David Hyatt.
In this change I introduced 'line' subdirectory inside 'rendering', this directory will contain all the classes
which have been refactored from RenderBlockLineLayout.cpp. This change contains the separation of BreakingContext,
and the separation of LineBreaker classes. Since I wanted to keep the helper functions organized, I also added a
new file called LineInlineHeaders.h, which contains the functions which used in LineBreaker.h and BreakingContext.h.
I moved LineInfo class into line directory. It was necessary this time, since I added a cpp for it. I'll move the
rest of the line layout related helper classes later. (I wanted to minimize merge conflicts.)
No new tests, no behavior change.
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCoreCommon.props:
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::createRun):
- rendering/line/BreakingContextInlineHeaders.h: Added.
(WebCore::WordMeasurement::WordMeasurement):
(WebCore::TrailingObjects::TrailingObjects):
(WebCore::TrailingObjects::setTrailingWhitespace):
(WebCore::TrailingObjects::clear):
(WebCore::TrailingObjects::appendBoxIfNeeded):
(WebCore::deprecatedAddMidpoint):
(WebCore::startIgnoringSpaces):
(WebCore::stopIgnoringSpaces):
(WebCore::ensureLineBoxInsideIgnoredSpaces):
(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::currentObject):
(WebCore::BreakingContext::lineBreak):
(WebCore::BreakingContext::lineBreakRef):
(WebCore::BreakingContext::lineWidth):
(WebCore::BreakingContext::atEnd):
(WebCore::BreakingContext::clearLineBreakIfFitsOnLine):
(WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
(WebCore::BreakingContext::initializeForCurrentObject):
(WebCore::BreakingContext::increment):
(WebCore::BreakingContext::handleBR):
(WebCore::borderPaddingMarginStart):
(WebCore::borderPaddingMarginEnd):
(WebCore::shouldAddBorderPaddingMargin):
(WebCore::previousInFlowSibling):
(WebCore::inlineLogicalWidth):
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleFloat):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::BreakingContext::handleEmptyInline):
(WebCore::BreakingContext::handleReplaced):
(WebCore::firstPositiveWidth):
(WebCore::updateSegmentsForShapes):
(WebCore::iteratorIsBeyondEndOfRenderCombineText):
(WebCore::nextCharacter):
(WebCore::updateCounterIfNeeded):
(WebCore::measureHyphenWidth):
(WebCore::textWidth):
(WebCore::ensureCharacterGetsLineBox):
(WebCore::tryHyphenating):
(WebCore::BreakingContext::handleText):
(WebCore::textBeginsWithBreakablePosition):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
(WebCore::checkMidpoints):
(WebCore::BreakingContext::handleEndOfLine):
- rendering/line/LineBreaker.cpp: Added.
(WebCore::LineBreaker::reset):
(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):
- rendering/line/LineBreaker.h: Added.
(WebCore::LineBreaker::LineBreaker):
(WebCore::LineBreaker::lineWasHyphenated):
(WebCore::LineBreaker::positionedObjects):
(WebCore::LineBreaker::clear):
- rendering/line/LineInfo.cpp: Added.
(WebCore::LineInfo::setEmpty):
- rendering/line/LineInfo.h: Renamed from Source/WebCore/rendering/LineInfo.h.
(WebCore::LineInfo::LineInfo):
(WebCore::LineInfo::isFirstLine):
(WebCore::LineInfo::isLastLine):
(WebCore::LineInfo::isEmpty):
(WebCore::LineInfo::previousLineBrokeCleanly):
(WebCore::LineInfo::floatPaginationStrut):
(WebCore::LineInfo::runsFromLeadingWhitespace):
(WebCore::LineInfo::resetRunsFromLeadingWhitespace):
(WebCore::LineInfo::incrementRunsFromLeadingWhitespace):
(WebCore::LineInfo::setFirstLine):
(WebCore::LineInfo::setLastLine):
(WebCore::LineInfo::setPreviousLineBrokeCleanly):
(WebCore::LineInfo::setFloatPaginationStrut):
- rendering/line/LineInlineHeaders.h: Added.
(WebCore::hasInlineDirectionBordersPaddingOrMargin):
(WebCore::lineStyle):
(WebCore::requiresLineBoxForContent):
(WebCore::shouldCollapseWhiteSpace):
(WebCore::skipNonBreakingSpace):
(WebCore::alwaysRequiresLineBox):
(WebCore::requiresLineBox):
(WebCore::setStaticPositions):
- 12:57 PM Changeset in webkit [159353] by
-
- 16 edits in trunk/Source
Move execution of IDBTransactionBackendOperations to the IDBServerConnection
https://bugs.webkit.org/show_bug.cgi?id=124385
Reviewed by Tim Horton.
Source/WebCore:
Each IDBOperation has it’s ::perform() moved to a method on IDBServerConnection.
This almost removes all knowledge of the backing stores from the front end.
- Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::clearObjectStore):
(WebCore::IDBDatabaseBackend::runIntVersionChangeTransaction):
- Modules/indexeddb/IDBDatabaseBackend.h:
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::clear):
Add methods to reflect each transaction backend operation:
- Modules/indexeddb/IDBServerConnection.h:
Schedule certain operations with callbacks:
- Modules/indexeddb/IDBTransactionBackend.cpp:
(WebCore::IDBTransactionBackend::scheduleVersionChangeOperation):
(WebCore::IDBTransactionBackend::schedulePutOperation):
(WebCore::IDBTransactionBackend::scheduleOpenCursorOperation):
(WebCore::IDBTransactionBackend::scheduleCountOperation):
(WebCore::IDBTransactionBackend::scheduleDeleteRangeOperation):
(WebCore::IDBTransactionBackend::scheduleClearObjectStoreOperation):
- Modules/indexeddb/IDBTransactionBackend.h:
Make each operation’s perform() method defer to the IDBServerConnection (with a callback):
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::CreateIndexOperation::perform):
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::DeleteIndexOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::GetOperation::perform):
(WebCore::PutOperation::perform):
(WebCore::SetIndexesReadyOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
(WebCore::ClearObjectStoreOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::perform):
(WebCore::CreateObjectStoreAbortOperation::perform):
Add accessors to each operation’s data members so the IDBServerConnection has everything it needs:
- Modules/indexeddb/IDBTransactionBackendOperations.h:
(WebCore::CreateObjectStoreOperation::objectStoreMetadata):
(WebCore::DeleteObjectStoreOperation::objectStoreMetadata):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::create):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::version):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::callbacks):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::databaseCallbacks):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::VersionChangeOperation):
(WebCore::CreateObjectStoreAbortOperation::CreateObjectStoreAbortOperation):
(WebCore::CreateIndexOperation::objectStoreID):
(WebCore::CreateIndexOperation::idbIndexMetadata):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore::CreateIndexAbortOperation::CreateIndexAbortOperation):
(WebCore::DeleteIndexOperation::objectStoreID):
(WebCore::DeleteIndexOperation::idbIndexMetadata):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(WebCore::DeleteIndexAbortOperation::DeleteIndexAbortOperation):
(WebCore::GetOperation::objectStoreID):
(WebCore::GetOperation::indexID):
(WebCore::GetOperation::cursorType):
(WebCore::GetOperation::keyRange):
(WebCore::GetOperation::callbacks):
(WebCore::GetOperation::autoIncrement):
(WebCore::GetOperation::keyPath):
(WebCore::GetOperation::GetOperation):
(WebCore::PutOperation::create):
(WebCore::PutOperation::putMode):
(WebCore::PutOperation::objectStore):
(WebCore::PutOperation::key):
(WebCore::PutOperation::indexIDs):
(WebCore::PutOperation::indexKeys):
(WebCore::PutOperation::callbacks):
(WebCore::PutOperation::value):
(WebCore::PutOperation::PutOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::objectStoreID):
(WebCore::OpenCursorOperation::indexID):
(WebCore::OpenCursorOperation::direction):
(WebCore::OpenCursorOperation::cursorType):
(WebCore::OpenCursorOperation::taskType):
(WebCore::OpenCursorOperation::keyRange):
(WebCore::OpenCursorOperation::cursorDirection):
(WebCore::OpenCursorOperation::callbacks):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(WebCore::CountOperation::create):
(WebCore::CountOperation::objectStoreID):
(WebCore::CountOperation::indexID):
(WebCore::CountOperation::keyRange):
(WebCore::CountOperation::callbacks):
(WebCore::CountOperation::CountOperation):
(WebCore::DeleteRangeOperation::create):
(WebCore::DeleteRangeOperation::objectStoreID):
(WebCore::DeleteRangeOperation::callbacks):
(WebCore::DeleteRangeOperation::keyRange):
(WebCore::DeleteRangeOperation::DeleteRangeOperation):
(WebCore::ClearObjectStoreOperation::create):
(WebCore::ClearObjectStoreOperation::objectStoreID):
(WebCore::ClearObjectStoreOperation::callbacks):
(WebCore::ClearObjectStoreOperation::ClearObjectStoreOperation):
Implement each operation in terms of the appropriate backing store, then perform the callback:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::createObjectStore):
(WebCore::IDBServerConnectionLevelDB::createIndex):
(WebCore::IDBServerConnectionLevelDB::deleteIndex):
(WebCore::IDBServerConnectionLevelDB::get):
(WebCore::IDBServerConnectionLevelDB::put):
(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::count):
(WebCore::IDBServerConnectionLevelDB::deleteRange):
(WebCore::IDBServerConnectionLevelDB::clearObjectStore):
(WebCore::IDBServerConnectionLevelDB::deleteObjectStore):
(WebCore::IDBServerConnectionLevelDB::changeDatabaseVersion):
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
- 12:28 PM Changeset in webkit [159352] by
-
- 5 edits1 add in trunk/Tools
build.webkit.org/dashboard should provide a way to focus on a subset of bots
https://bugs.webkit.org/show_bug.cgi?id=122676
Reviewed by Timothy Hatcher.
Add a small 'hide' button next to every platform logo, and a 'show all'
button which only appears when at least one platform is hidden. Hidden
platforms persist using localStorage.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(updateHiddenPlatforms):
(documentReady.unhideButton):
(documentReady.hideButton):
(documentReady):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
(Settings.prototype.setObject):
(Settings.prototype.getObject):
(Settings.prototype.addSettingListener):
(Settings.prototype.fireSettingListener):
(Settings.prototype.toggleHiddenPlatform):
(Settings.prototype.clearHiddenPlatforms):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(div.cellButton):
(div.cellButton.hide):
(.hidden):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
- 11:53 AM Changeset in webkit [159351] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
-dealloc callbacks from wrapped Objective-C objects can happen at bad times
https://bugs.webkit.org/show_bug.cgi?id=123821
Reviewed by Darin Adler.
Currently with the JSC Obj-C API, JS wrappers for client Obj-C objects retain their associated Obj-C
object. When they are swept, they release their Obj-C objects which can trigger a call to that
object's -dealloc method. These -dealloc methods can then call back into the same VM, which is not
allowed during sweeping or VM shutdown.
We can handle this case by creating our own pool of Obj-C objects to be released when it is safe to do so.
This is accomplished by using DelayedReleaseScope, an RAII-style object that will retain all objects
that are unsafe to release until the end of the DelayedReleaseScope.
- API/APIShims.h:
(JSC::APICallbackShim::APICallbackShim):
(JSC::APICallbackShim::vmForDropAllLocks):
(JSC::APICallbackShim::execForDropAllLocks):
- API/JSAPIWrapperObject.mm:
(JSAPIWrapperObjectHandleOwner::finalize):
- API/ObjCCallbackFunction.mm:
(JSC::ObjCCallbackFunctionImpl::destroy):
(JSC::ObjCCallbackFunction::destroy):
- API/tests/testapi.mm:
(-[TinyDOMNode initWithVirtualMachine:]):
(-[TinyDOMNode dealloc]):
(-[TinyDOMNode appendChild:]):
(-[TinyDOMNode removeChildAtIndex:]):
(-[EvilAllocationObject initWithContext:]):
(-[EvilAllocationObject dealloc]):
(-[EvilAllocationObject doEvilThingsWithContext:]):
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/DelayedReleaseScope.h: Added.
(JSC::DelayedReleaseScope::DelayedReleaseScope):
(JSC::DelayedReleaseScope::~DelayedReleaseScope):
(JSC::DelayedReleaseScope::releaseSoon):
(JSC::MarkedSpace::releaseSoon):
- heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
- heap/Heap.h:
(JSC::Heap::releaseSoon):
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateSlowCase):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::lastChanceToFinalize):
(JSC::MarkedSpace::sweep):
- heap/MarkedSpace.h:
- 11:51 AM Changeset in webkit [159350] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/dom/Geolocation/notimer-after-unload.html is flaky and crashy on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=124425
- platform/mac-wk2/TestExpectations:
Mark as crash/pass/fail, since it does all three :(
- 11:34 AM Changeset in webkit [159349] by
-
- 11 edits1 add in trunk
Modifying RTCIceCandidate object construction to match the spec
https://bugs.webkit.org/show_bug.cgi?id=124369
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-15
Reviewed by Eric Carlson.
According to the spec the RTCIceCandidateInit parameter in RTCSessionDescription constructor is optional,
which must not be nullable, and, if passed, must be a valid Dictionary. If the keys are not present, the string
object that stores them in the RTCIceCandidate class, must be null in those cases. Also, if a key is present
and its value is not valid an exception must be raised.
Source/WebCore:
Existing test was updated.
- GNUmakefile.list.am:
- Modules/mediastream/RTCIceCandidate.cpp:
(WebCore::RTCIceCandidate::create):
- Modules/mediastream/RTCIceCandidate.idl:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSRTCIceCandidateCustom.cpp: Added.
(WebCore::JSRTCIceCandidateConstructor::constructJSRTCIceCandidate):
LayoutTests:
- fast/mediastream/RTCIceCandidate-expected.txt:
- fast/mediastream/RTCIceCandidate.html:
- 11:30 AM Changeset in webkit [159348] by
-
- 2 edits in trunk/LayoutTests
Layout Test webgl/1.0.2/conformance/ogles/GL/tan/tan_001_to_006.html fails on Intel
https://bugs.webkit.org/show_bug.cgi?id=124424
- platform/mac/TestExpectations:
Mark as flaky everywhere, since I have no way to mark it as failing on Intel
and passing elsewhere.
- 11:21 AM Changeset in webkit [159347] by
-
- 49 edits6 adds19 deletes in trunk
Unreviewed, rolling out r159337.
http://trac.webkit.org/changeset/159337
https://bugs.webkit.org/show_bug.cgi?id=124423
broke a bunch of fast/regions tests on EFL/GTK (Requested by
philn on #webkit).
Source/WebCore:
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
- rendering/InlineFlowBox.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::estimateRegionRangeForBoxChild):
(WebCore::RenderBlock::updateRegionRangeForBoxChild):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::hasNextPage):
(WebCore::RenderBlockFlow::relayoutForPagination):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::positionNewFloatOnLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::isUnsplittableForPagination):
(WebCore::RenderBox::overflowRectForPaintRejection):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderBoxModelObject.h:
- rendering/RenderBoxRegionInfo.h:
(WebCore::RenderBoxRegionInfo::createOverflow):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
(WebCore::RenderFlowThread::checkRegionsWithStyling):
(WebCore::RenderFlowThread::mapFromLocalToFlowThread):
(WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
- rendering/RenderFlowThread.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::intersectsDamageRect):
(WebCore::RenderLayer::repaintIncludingDescendants):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::addOverflowFromChildren):
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::createStyle):
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderOverflow.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::flowThreadPortionOverflowRect):
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
(WebCore::shouldPaintRegionContentsInPhase):
(WebCore::RenderRegion::paintObject):
(WebCore::RenderRegion::hitTestContents):
(WebCore::RenderRegion::computeOverflowFromFlowThread):
(WebCore::RenderRegion::repaintFlowThreadContent):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
(WebCore::RenderRegion::insertedIntoTree):
(WebCore::RenderRegion::ensureOverflowForBox):
(WebCore::RenderRegion::rectFlowPortionForBox):
(WebCore::RenderRegion::addLayoutOverflowForBox):
(WebCore::RenderRegion::addVisualOverflowForBox):
(WebCore::RenderRegion::layoutOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):
- rendering/RenderRegion.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paint):
LayoutTests:
- fast/regions/bottom-overflow-out-of-first-region-expected.html:
- fast/regions/bottom-overflow-out-of-first-region.html:
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html:
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html:
- fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
- fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
- fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
- fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
- fast/regions/float-pushed-width-change-2-expected.html:
- fast/regions/float-pushed-width-change-2.html:
- fast/regions/float-pushed-width-change-expected.html:
- fast/regions/float-pushed-width-change.html:
- fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Removed.
- fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Removed.
- fast/regions/outline-sides-in-region-expected.html:
- fast/regions/outline-sides-in-region.html:
- fast/regions/overflow-first-and-last-regions-expected.html: Removed.
- fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html: Removed.
- fast/regions/overflow-first-and-last-regions-in-container-hidden.html: Removed.
- fast/regions/overflow-first-and-last-regions.html: Removed.
- fast/regions/overflow-last-region-expected.html: Added.
- fast/regions/overflow-last-region.html: Added.
- fast/regions/overflow-nested-regions-expected.html: Removed.
- fast/regions/overflow-nested-regions.html: Removed.
- fast/regions/overflow-region-float-expected.html: Removed.
- fast/regions/overflow-region-float.html: Removed.
- fast/regions/overflow-region-inline-expected.html: Removed.
- fast/regions/overflow-region-inline.html: Removed.
- fast/regions/overflow-region-transform-expected.html: Removed.
- fast/regions/overflow-region-transform.html: Removed.
- fast/regions/overflow-scrollable-rotated-fragment-expected.html:
- fast/regions/overflow-scrollable-rotated-fragment.html:
- fast/regions/top-overflow-out-of-second-region-expected.html: Removed.
- fast/regions/top-overflow-out-of-second-region.html:
- fast/regions/webkit-flow-float-unable-to-push-expected.html:
- fast/regions/webkit-flow-float-unable-to-push.html:
- fast/repaint/increasing-region-content-height-expected.txt:
- fast/repaint/increasing-region-content-height.html:
- platform/gtk/fast/regions/text-region-split-vertical-rl-expected.txt: Added.
- platform/mac-wk2/TestExpectations:
- platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
- platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
- 11:07 AM Changeset in webkit [159346] by
-
- 5 edits in trunk/Source/JavaScriptCore
REGRESSION (r158586): callToJavaScript needs to save return PC to Sentinel frame
https://bugs.webkit.org/show_bug.cgi?id=124420
Reviewed by Filip Pizlo.
Save the return PC into the sentinel frame.
- jit/JITStubsMSVC64.asm:
- jit/JITStubsX86.h:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 10:32 AM Changeset in webkit [159345] by
-
- 6 edits2 adds in trunk
Hovering over text using simple line path should not cause switch to line boxes
https://bugs.webkit.org/show_bug.cgi?id=124418
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/text/simple-lines-hover.html
- rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteQuadsClippedToEllipsis):
(WebCore::RenderText::absoluteQuads):
Collect quads and rects directly from simple lines without requiring the line box switch.
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::collectTextAbsoluteRects):
(WebCore::SimpleLineLayout::collectTextAbsoluteQuads):
Add these.
- rendering/SimpleLineLayoutFunctions.h:
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::Run::start):
(WebCore::SimpleLineLayout::RunResolver::Run::end):
For future use.
LayoutTests:
- fast/text/simple-lines-hover-expected.html: Added.
- fast/text/simple-lines-hover.html: Added.
- 10:06 AM Changeset in webkit [159344] by
-
- 3 edits in trunk/LayoutTests
[CSS Shapes][CSS Regions] Simplify shape-inside-on-multiple-regions-with-negative-shape-top.html
https://bugs.webkit.org/show_bug.cgi?id=123808
Reviewed by Mihnea Ovidenie.
Use a rectangle instead of a complex polygon in the test.
- fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top-expected.html:
- fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top.html:
- 10:03 AM Changeset in webkit [159343] by
-
- 5 edits in trunk
MediaTime addition and subtraction operators have errors when the rhs is infinite.
https://bugs.webkit.org/show_bug.cgi?id=124413
Reviewed by Eric Carlson.
Source/WTF:
Correctly account for infinities that can occur on the right-hand side of addition or
subtraction operators.
- wtf/MediaTime.cpp:
(WTF::MediaTime::operator+):
(WTF::MediaTime::operator-):
Tools:
Add a test for operator+ and operator- where an infinite value appears
on the right-hand side:
- TestWebKitAPI/Tests/WTF/MediaTime.cpp:
(TestWebKitAPI::TEST):
Add a LLDB summary provider for MediaTime which displays the rational
time as well as the value in seconds:
- lldb/lldb_webkit.py:
(lldb_init_module):
(WTFMediaTime_SummaryProvider):
(WTFHashTableProvider.has_children):
(WTFMediaTimeProvider):
(WTFMediaTimeProvider.init):
(WTFMediaTimeProvider.timeValue):
(WTFMediaTimeProvider.timeScale):
(WTFMediaTimeProvider.isInvalid):
(WTFMediaTimeProvider.isPositiveInfinity):
(WTFMediaTimeProvider.isNegativeInfinity):
(WTFMediaTimeProvider.isIndefinite):
- 9:47 AM Changeset in webkit [159342] by
-
- 3 edits in trunk/Tools
Make it possible to select revision numbers on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124400
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype.revisionLinksForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(.selectable):
Add a child span to the trac link, which has '-webkit-user-select: all' on it.
This way, a Dashboard user can highlight revision numbers for easy copying,
and doesn't even have to be precise about the selection.
- 9:44 AM Changeset in webkit [159341] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add failure test expectations for failing tests.
- platform/efl/TestExpectations:
- 9:42 AM Changeset in webkit [159340] by
-
- 3 edits in trunk/LayoutTests
results.html should have a link to historical results for a test/all failing tests
https://bugs.webkit.org/show_bug.cgi?id=124402
Reviewed by Simon Fraser.
- fast/harness/results.html:
Add a new rightmost column, 'history'.
Clicking on the column header will open the flakiness dashboard
for the entire set of failing tests; clicking on the link
in a particular test's row will open it just for that single test.
- fast/harness/resources/results-test.js:
Update the harness test to expect the new number of columns.
- 9:32 AM Changeset in webkit [159339] by
-
- 4 edits2 adds in trunk/Tools
Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
https://bugs.webkit.org/show_bug.cgi?id=124399
Reviewed by Gustavo Noronha Silva.
Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
with the icons adjusted to have solid backgrounds, to not be squished, and to not
intersect the ring, similar to the Mac icons.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady.hideButton):
(documentReady):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.linux-gtk img.logo):
(table.queue-grid tr.platform.linux-efl img.logo):
- 8:15 AM Changeset in webkit [159338] by
-
- 2 edits in trunk/Source/WebKit2
Fixed incorrectly placed NETWORK_PROCESS guard in NetworkConnectionToWebProcess.cpp
https://bugs.webkit.org/show_bug.cgi?id=124398
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-15
Reviewed by Brady Eidson.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- 7:34 AM Changeset in webkit [159337] by
-
- 49 edits1 copy18 adds5 deletes in trunk
[CSS Regions] Implement visual overflow for first & last regions
https://bugs.webkit.org/show_bug.cgi?id=118665
Source/WebCore:
In order to properly propagate the visual overflow of elements flowed inside regions,
the responsiblity of painting and hit-testing content inside flow threads has been
moved to the flow thread layer's level.
Each region keeps the associated overflow with each box in the RenderBoxRegionInfo
structure, including one for the flow thread itself. This data is used during
painting and hit-testing.
Reviewed by David Hyatt.
Tests: fast/regions/overflow-first-and-last-regions-in-container-hidden.html
fast/regions/overflow-first-and-last-regions.html
fast/regions/overflow-nested-regions.html
fast/regions/overflow-region-float.html
fast/regions/overflow-region-inline.html
fast/regions/overflow-region-transform.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
- rendering/InlineFlowBox.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::estimateRegionRangeForBoxChild):
(WebCore::RenderBlock::updateRegionRangeForBoxChild):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::hasNextPage):
(WebCore::RenderBlockFlow::relayoutForPagination):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::positionNewFloatOnLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::isUnsplittableForPagination):
(WebCore::RenderBox::overflowRectForPaintRejection):
- rendering/RenderBox.h:
(WebCore::RenderBox::canHaveOutsideRegionRange):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderBoxModelObject.h:
- rendering/RenderBoxRegionInfo.h:
(WebCore::RenderBoxRegionInfo::createOverflow):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):
(WebCore::RenderFlowThread::mapFromLocalToFlowThread):
(WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
(WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):
(WebCore::RenderFlowThread::flipForWritingModeLocalCoordinates):
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):
(WebCore::RenderFlowThread::addRegionsVisualOverflow):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
- rendering/RenderFlowThread.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::expandClipRectForRegionAndReflection):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::intersectsDamageRect):
(WebCore::RenderLayer::updateDescendantsLayerListsIfNeeded):
(WebCore::RenderLayer::repaintIncludingDescendants):
(WebCore::RenderLayer::paintNamedFlowThreadInsideRegion):
(WebCore::RenderLayer::paintFlowThreadIfRegion):
(WebCore::RenderLayer::hitTestFlowThreadIfRegion):
- rendering/RenderLayer.h:
(WebCore::ClipRect::inflateX):
(WebCore::ClipRect::inflateY):
(WebCore::ClipRect::inflate):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::addOverflowFromChildren):
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::createStyle):
(WebCore::RenderNamedFlowFragment::namedFlowThread):
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderOverflow.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::flowThreadPortionOverflowRect):
(WebCore::RenderRegion::flowThreadPortionLocation):
(WebCore::RenderRegion::regionContainerLayer):
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
(WebCore::RenderRegion::computeOverflowFromFlowThread):
(WebCore::RenderRegion::repaintFlowThreadContent):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
(WebCore::RenderRegion::insertedIntoTree):
(WebCore::RenderRegion::ensureOverflowForBox):
(WebCore::RenderRegion::rectFlowPortionForBox):
(WebCore::RenderRegion::addLayoutOverflowForBox):
(WebCore::RenderRegion::addVisualOverflowForBox):
(WebCore::RenderRegion::layoutOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):
- rendering/RenderRegion.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paint):
LayoutTests:
Rebased some tests due to regions layers changes.
Updated some tests to increase clarity. Some of them were only passing because two
regions were close together and the fact that an element was being painted
inside the wrong region was not visible. Floats are now also unsplittable.
- bottom-overflow-out-of-first-region
- float-pushed-width-change-2
- float-pushed-width-change
- webkit-flow-float-unable-to-push
Changed top-overflow-out-of-second-region to reftest.
Added new tests for testing the visual overflow in different situations
(transformed, inline, opacity, floating).
Reviewed by David Hyatt.
- fast/regions/bottom-overflow-out-of-first-region-expected.html:
- fast/regions/bottom-overflow-out-of-first-region.html:
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html:
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html:
- fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
- fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
- fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
- fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
- fast/regions/float-pushed-width-change-2-expected.html:
- fast/regions/float-pushed-width-change-2.html:
- fast/regions/float-pushed-width-change-expected.html:
- fast/regions/float-pushed-width-change.html:
- fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Added.
- fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Added.
- fast/regions/layers/regions-promoted-to-layers-expected.txt: Added.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Added.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Added.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Added.
- fast/regions/outline-sides-in-region-expected.html:
- fast/regions/outline-sides-in-region.html:
- fast/regions/overflow-first-and-last-regions-expected.html: Added.
- fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html: Added.
- fast/regions/overflow-first-and-last-regions-in-container-hidden.html: Added.
- fast/regions/overflow-first-and-last-regions.html: Added.
- fast/regions/overflow-last-region-expected.html: Removed.
- fast/regions/overflow-last-region.html: Removed.
- fast/regions/overflow-nested-regions-expected.html: Added.
- fast/regions/overflow-nested-regions.html: Added.
- fast/regions/overflow-region-float-expected.html: Added.
- fast/regions/overflow-region-float.html: Added.
- fast/regions/overflow-region-inline-expected.html: Added.
- fast/regions/overflow-region-inline.html: Added.
- fast/regions/overflow-region-transform-expected.html: Added.
- fast/regions/overflow-region-transform.html: Added.
- fast/regions/overflow-scrollable-rotated-fragment-expected.html:
- fast/regions/overflow-scrollable-rotated-fragment.html:
- fast/regions/top-overflow-out-of-second-region-expected.html: Copied from LayoutTests/fast/regions/top-overflow-out-of-second-region.html.
- fast/regions/top-overflow-out-of-second-region.html:
- fast/regions/webkit-flow-float-unable-to-push-expected.html:
- fast/regions/webkit-flow-float-unable-to-push.html:
- platform/gtk/fast/regions/text-region-split-vertical-rl-expected.txt: Removed.
- platform/mac-wk2/TestExpectations:
- platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- 7:31 AM Changeset in webkit [159336] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Update TestExpectations files with failing tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 7:05 AM Changeset in webkit [159335] by
-
- 9 edits6 adds in trunk
[GStreamer] Add support for Media Source API
https://bugs.webkit.org/show_bug.cgi?id=99065
Source/WebCore:
The patch integrate a Media Source player for the GStreamer backend. The implementented architecture is:
- MediaPlayerPrivateGStreamer engine is modified to support Media Source URIs (change blob:// to mediasourceblob://), in addition to the existing support for web (http/https/blob) URIs
- Similar to the existing WebKitWebSrc gstreamer element that handles web URIs, a new gstreamer element named WebKitMediaSrc is implemented to handle Media Source URIs
- WebKitMediaSrc registers its URI protocol handler, allowing uridecodebin to dynamically create the appropriate source element.
- The WebKitMediaSrc element creates a bin with 2 appsrc: One for Audio and One for Video. Pads are dynamically linked at the reception of first video and audio buffers.
Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
Reviewed by Philippe Normand.
Tests: Activate http/tests/media/media-source and media/media-source tests
- GNUmakefile.am:
- GNUmakefile.list.am:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::initializeGStreamerAndRegisterWebKitElements):
(WebCore::MediaPlayerPrivateGStreamer::load):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gstreamer/MediaSourceGStreamer.cpp: Added.
(WebCore::MediaSourceGStreamer::open):
(WebCore::MediaSourceGStreamer::MediaSourceGStreamer):
(WebCore::MediaSourceGStreamer::~MediaSourceGStreamer):
(WebCore::MediaSourceGStreamer::addSourceBuffer):
(WebCore::MediaSourceGStreamer::setDuration):
(WebCore::MediaSourceGStreamer::markEndOfStream):
(WebCore::MediaSourceGStreamer::unmarkEndOfStream):
- platform/graphics/gstreamer/MediaSourceGStreamer.h: Added.
- platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp: Added.
(WebCore::SourceBufferPrivateGStreamer::SourceBufferPrivateGStreamer):
(WebCore::SourceBufferPrivateGStreamer::append):
(WebCore::SourceBufferPrivateGStreamer::abort):
(WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource):
- platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h: Added.
- platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp: Added.
(webKitMediaSrcAddSrc):
(webkit_media_src_init):
(webKitMediaSrcFinalize):
(webKitMediaSrcSetProperty):
(webKitMediaSrcGetProperty):
(webKitMediaVideoSrcStop):
(webKitMediaAudioSrcStop):
(webKitMediaVideoSrcStart):
(webKitMediaAudioSrcStart):
(webKitMediaSrcChangeState):
(webKitMediaSrcQueryWithParent):
(webKitMediaSrcUriGetType):
(webKitMediaSrcGetProtocols):
(webKitMediaSrcGetUri):
(webKitMediaSrcSetUri):
(webKitMediaSrcUriHandlerInit):
(webKitMediaVideoSrcNeedDataMainCb):
(webKitMediaAudioSrcNeedDataMainCb):
(webKitMediaVideoSrcNeedDataCb):
(webKitMediaAudioSrcNeedDataCb):
(webKitMediaVideoSrcEnoughDataMainCb):
(webKitMediaAudioSrcEnoughDataMainCb):
(webKitMediaVideoSrcEnoughDataCb):
(webKitMediaAudioSrcEnoughDataCb):
(webKitMediaVideoSrcSeekMainCb):
(webKitMediaAudioSrcSeekMainCb):
(webKitMediaVideoSrcSeekDataCb):
(webKitMediaAudioSrcSeekDataCb):
(webKitMediaSrcSetMediaPlayer):
(webKitMediaSrcSetPlayBin):
(MediaSourceClientGstreamer::MediaSourceClientGstreamer):
(MediaSourceClientGstreamer::~MediaSourceClientGstreamer):
(MediaSourceClientGstreamer::didReceiveDuration):
(MediaSourceClientGstreamer::didReceiveData):
(MediaSourceClientGstreamer::didFinishLoading):
(MediaSourceClientGstreamer::didFail):
- platform/graphics/gstreamer/WebKitMediaSourceGStreamer.h: Added.
Tools:
Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
Reviewed by Philippe Normand.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Patch by Stephane Jadaud <sjadaud@sii.fr> on 2013-11-15
Reviewed by Philippe Normand.
- platform/gtk/TestExpectations:
- 6:08 AM Changeset in webkit [159334] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Leak in ewk_frame_certificate_status_get()
https://bugs.webkit.org/show_bug.cgi?id=124401
Reviewed by Carlos Garcia Campos.
The SoupMessage object is being leaked. In in this case that
object is not even necessary since ResourceRequest already
provides a way to get the soup flags directly.
- ewk/ewk_frame.cpp:
(ewk_frame_certificate_status_get):
- 5:09 AM Changeset in webkit [159333] by
-
- 16 edits in trunk/Source/WebKit2
Cleanup the build from unused parameters in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124201
Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-15
Reviewed by Darin Adler.
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::getPluginModuleInformation):
- UIProcess/API/C/WKBatteryManager.cpp:
(WKBatteryManagerSetProvider):
(WKBatteryManagerProviderDidChangeBatteryStatus):
(WKBatteryManagerProviderUpdateBatteryStatus):
- UIProcess/API/C/WKBatteryStatus.cpp:
(WKBatteryStatusCreate):
- UIProcess/API/C/WKColorPickerResultListener.cpp:
(WKColorPickerResultListenerSetColor):
- UIProcess/API/C/WKContext.cpp:
(WKContextGetBatteryManager):
(WKContextGetDatabaseManager):
(WKContextGetNetworkInfoManager):
- UIProcess/API/C/WKDatabaseManager.cpp:
(WKDatabaseManagerSetClient):
(WKDatabaseManagerGetDatabasesByOrigin):
(WKDatabaseManagerGetDatabaseOrigins):
(WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):
(WKDatabaseManagerSetQuotaForOrigin):
- UIProcess/API/C/WKNetworkInfo.cpp:
(WKNetworkInfoCreate):
- UIProcess/API/C/WKNetworkInfoManager.cpp:
(WKNetworkInfoManagerSetProvider):
(WKNetworkInfoManagerProviderDidChangeNetworkInformation):
- UIProcess/API/C/WKOpenPanelParameters.cpp:
(WKOpenPanelParametersCopyCapture):
- UIProcess/API/C/WKVibration.cpp:
(WKVibrationSetProvider):
- UIProcess/API/efl/EwkView.cpp:
(EwkView::createNewPage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setVisibilityState):
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsPosition):
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didChangeViewportAttributes):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setDatabaseQuota):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
- 3:03 AM Changeset in webkit [159332] by
-
- 6 edits10 adds2 deletes in trunk/Source/WebInspectorUI
Web Inspector: New color picker
https://bugs.webkit.org/show_bug.cgi?id=124354
Reviewed by Timothy Hatcher.
Beginning of a new color picker. The focus of this new picker is to let you pick from
a color wheel as the primary mean of color picking, with additional slider controls for
the brightness and the opacity, better matching the default OS X color picker. This is the
basis for a color picker that will evolve to support the following:
- editable CSS value label (http://webkit.org/b/124356)
- picking a color anywhere on screen (http://webkit.org/b/124357)
- swatches based on other colors in page (http://webkit.org/b/124358)
Note also that the color wheel has not been tested on Retina displays
(see http://webkit.org/b/124355).
- UserInterface/CSSColorPicker.css: Removed.
- UserInterface/CSSColorPicker.js: Removed.
Previous color picker, now removed in favor of the new ColorPicker class.
- UserInterface/CSSStyleDeclarationTextEditor.js:
Adopt new class name for the color picker, add a little padding to the popover
target frame and set the base color after the picker has been presented.
- UserInterface/Color.js:
(WebInspector.Color.prototype._hslToRGB):
Simplified math.
(WebInspector.Color.rgb2hsv):
(WebInspector.Color.hsv2rgb):
New utilities to deal with HSV colors used in the ColorWheel.
- UserInterface/ColorPicker.css: Added.
- UserInterface/ColorPicker.js: Added.
(WebInspector.ColorPicker):
(WebInspector.ColorPicker.prototype.get element):
(WebInspector.ColorPicker.prototype.set brightness):
(WebInspector.ColorPicker.prototype.set opacity):
(WebInspector.ColorPicker.prototype.get color):
(WebInspector.ColorPicker.prototype.set color):
We set the _dontUpdateColor flag here such that we don't attempt to
notify about a color change at this point in case the selected color
is too saturated to be represented accurately on the color wheel and
we would end up changing the color by virtue of presenting the popover.
(WebInspector.ColorPicker.prototype.colorWheelColorDidChange):
(WebInspector.ColorPicker.prototype.sliderValueDidChange):
(WebInspector.ColorPicker.prototype._updateColor):
(WebInspector.ColorPicker.prototype._updateSliders):
- UserInterface/ColorWheel.css: Added.
- UserInterface/ColorWheel.js: Added.
The ColorWheel makes use of three different <canvas> elements to draw itself.
The "raw" canvas is used to draw the raw, un-tinted color wheel with poor
aliasing. The "raw" canvas is only drawn when the dimension is changed.
The "tinted" canvas is used to draw the "raw" canvas with a black overlay
based on the brightness set on the wheel. The "final" canvas, the only <canvas>
element attached to the DOM, is used to draw the "tinted" canvas into a circle
clip of a slightly narrower radius so that the drawn image is visually more pleasing
and can be displayed above virtually any background color.
We use color math to generate the color wheel, courtesy of Dean Jackson, and also to
figure out where to position the crosshair for the provided base color as well as
the opposite operation where we get the color under the mouse pointer.
The color wheel fires a single delegate method call colorWheelColorDidChange(colorWheel),
the colors themselves being retrieved via the public properties tintedColor and rawColor.
(WebInspector.ColorWheel):
(WebInspector.ColorWheel.prototype.set dimension):
(WebInspector.ColorWheel.prototype.get element):
(WebInspector.ColorWheel.prototype.get brightness):
(WebInspector.ColorWheel.prototype.set brightness):
(WebInspector.ColorWheel.prototype.get tintedColor):
(WebInspector.ColorWheel.prototype.set tintedColor):
(WebInspector.ColorWheel.prototype.get rawColor):
(WebInspector.ColorWheel.prototype.handleEvent):
(WebInspector.ColorWheel.prototype._handleMousedown):
(WebInspector.ColorWheel.prototype._handleMousemove):
(WebInspector.ColorWheel.prototype._handleMouseup):
(WebInspector.ColorWheel.prototype._pointInCircleForEvent):
(WebInspector.ColorWheel.prototype._pointInCircleForEvent.angleFromCenterToPoint):
(WebInspector.ColorWheel.prototype._pointInCircleForEvent.pointOnCircumference):
(WebInspector.ColorWheel.prototype._updateColorForMouseEvent):
(WebInspector.ColorWheel.prototype._setCrosshairPosition):
(WebInspector.ColorWheel.prototype._tintedColorToPointAndBrightness):
(WebInspector.ColorWheel.prototype._drawRawCanvas):
(WebInspector.ColorWheel.prototype._colorAtPointWithBrightness):
(WebInspector.ColorWheel.prototype._drawTintedCanvas):
(WebInspector.ColorWheel.prototype._draw):
- UserInterface/Images/SliderThumb.png: Added.
- UserInterface/Images/SliderThumb@2x.png: Added.
- UserInterface/Images/SliderThumbPressed.png: Added.
- UserInterface/Images/SliderThumbPressed@2x.png: Added.
Supporting artwork for the new Slider class.
- UserInterface/Main.html:
Remove the previous color picker class and add the new one, as well as the new Slider class.
- UserInterface/Slider.css: Added.
- UserInterface/Slider.js: Added.
New slider to match the look of the sliders used in the native OS X color picker. The most
interesting feature of these sliders is that they can be transformed using CSS in any way
and will still operate correctly due to always converting the mouse coordinates in the page
coordinate system to the coordinate system local to the backing element. For instance, the
color picker uses two sliders transformed to be displayed vertically.
As it stands these slides only support values between 0 and 1 and fire a single delegate
method call sliderValueDidChange(slider, newValue).
(WebInspector.Slider):
(WebInspector.Slider.prototype.get element):
(WebInspector.Slider.prototype.get value):
(WebInspector.Slider.prototype.set value):
(WebInspector.Slider.prototype.handleEvent):
(WebInspector.Slider.prototype._handleMousedown):
(WebInspector.Slider.prototype._handleMousemove):
(WebInspector.Slider.prototype._handleMouseup):
(WebInspector.Slider.prototype._localPointForEvent):
(WebInspector.Slider.prototype.get _maxX):
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
Update file names for the new color picker.
- 2:35 AM Changeset in webkit [159331] by
-
- 3 edits1 delete in trunk/LayoutTests
Unreviewed EFL gardening
Mark flaky and incorrectly passing tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed wrong test expectation.
- 2:23 AM Changeset in webkit [159330] by
-
- 4 edits in trunk
[GTK] Bumping GStreamer version to 1.2.1 for the dependencies
https://bugs.webkit.org/show_bug.cgi?id=124360
Reviewed by Philippe Normand.
Tools:
- gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
LayoutTests:
- platform/gtk/TestExpectations: Flagged
media/video-canvas-drawing-output.html
- 1:21 AM Changeset in webkit [159329] by
-
- 3 edits2 moves2 deletes in trunk/LayoutTests
[EFL] Layout tests with international text properties need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124389
Unreviewed, EFL rabaseline.
EFL international text rebaselined after r147668.
Move some expectation files to efl common place because those files in wk1 are
in exact accordance with files in wk2, and then delete the files in wk1 and wk2.
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-15
- platform/efl-wk1/fast/text/international/003-expected.txt: Removed.
- platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
- platform/efl-wk2/TestExpectations:
- platform/efl/fast/text/international/002-expected.txt:
- platform/efl/fast/text/international/003-expected.txt:
Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt.
- platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt:
Renamed from LayoutTests/platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt.
Nov 14, 2013:
- 8:58 PM Changeset in webkit [159328] by
-
- 2 edits in trunk/Tools
[Win] Improve support for command line builds of 64-bit JSC
https://bugs.webkit.org/show_bug.cgi?id=124380
Patch by Brent Fulgham <Brent Fulgham> on 2013-11-14
Reviewed by David Kilzer.
- Scripts/webkitdirs.pm:
(argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
(determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
what the "$configurationForVisualStudio" value is for.
- 6:50 PM Changeset in webkit [159327] by
-
- 47 edits in trunk/LayoutTests
Update WebCrypto tests
https://bugs.webkit.org/show_bug.cgi?id=124388
Reviewed by Anders Carlsson.
Updated tests for newer common.js. Changed some tests from just dumping results
to comparing them to known expected ones. Fixed a syntax error in
aes-cbc-invalid-length.html, so it now actually runs.
- crypto/subtle/resources/common.js: Update to a new version from Blink, because
it's much nicer than the old one, and it's good to be compatible at test level.
Moved crypto.subtle definition from webkitSubtle here to avoid repeating it in all
tests. Added a quick and dirty Promise.all implementation.
- crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-cbc-192-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-cbc-256-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt:
- crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
- crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html:
- crypto/subtle/aes-cbc-encrypt-decrypt.html:
- crypto/subtle/aes-cbc-generate-key.html:
- crypto/subtle/aes-cbc-import-jwk-expected.txt:
- crypto/subtle/aes-cbc-import-jwk.html:
- crypto/subtle/aes-cbc-invalid-length-expected.txt:
- crypto/subtle/aes-cbc-invalid-length.html:
- crypto/subtle/aes-cbc-wrong-key-class.html:
- crypto/subtle/aes-export-key-expected.txt:
- crypto/subtle/aes-export-key.html:
- crypto/subtle/argument-conversion-expected.txt:
- crypto/subtle/argument-conversion.html:
- crypto/subtle/hmac-export-key-expected.txt:
- crypto/subtle/hmac-export-key.html:
- crypto/subtle/hmac-generate-key.html:
- crypto/subtle/hmac-import-jwk-expected.txt:
- crypto/subtle/hmac-import-jwk.html:
- crypto/subtle/hmac-sign-verify-empty-key-expected.txt:
- crypto/subtle/hmac-sign-verify-empty-key.html:
- crypto/subtle/hmac-sign-verify-expected.txt:
- crypto/subtle/hmac-sign-verify.html:
- crypto/subtle/import-jwk-expected.txt:
- crypto/subtle/import-jwk.html:
- crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt:
- crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html:
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt:
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html:
- crypto/subtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt:
- crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html:
- crypto/subtle/sha-1-expected.txt:
- crypto/subtle/sha-1.html:
- crypto/subtle/sha-224-expected.txt:
- crypto/subtle/sha-224.html:
- crypto/subtle/sha-256-expected.txt:
- crypto/subtle/sha-256.html:
- crypto/subtle/sha-384-expected.txt:
- crypto/subtle/sha-384.html:
- crypto/subtle/sha-512-expected.txt:
- crypto/subtle/sha-512.html:
- 6:27 PM Changeset in webkit [159326] by
-
- 5 edits2 adds in trunk
XMLSerializer escapes < > & correctly inside <script> and <style> tags.
https://bugs.webkit.org/show_bug.cgi?id=123914
Patch by Victor Costan <costan@gmail.com> on 2013-11-14
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/dom/XMLSerializer-entities.html
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces): vim removed some whitespace.
(WebCore::MarkupAccumulator::entityMaskForText): Fixed the returned value for <script> etc in XML.
LayoutTests:
- fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: fix incorrect expectations.
- fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: use CDATA consistently.
- fast/dom/XMLSerializer-entities-expected.txt: Added.
- fast/dom/XMLSerializer-entities.html: Added.
- 6:11 PM Changeset in webkit [159325] by
-
- 12 edits in branches/safari-537.73-branch/LayoutTests
Rebaseline branch after r158468.
- 5:34 PM Changeset in webkit [159324] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: rangesIntersect(m_renderer.pixelSnappedLogicalTopForFloat(floatingObject), m_renderer.pixelSnappedLogicalBottomForFloat(floatingObject), m_lineTop, m_lineBottom) ../../Source/WebCore/rendering/FloatingObjects.cpp(463)
https://bugs.webkit.org/show_bug.cgi?id=124375
Reviewed by Alexandru Chiculita.
When moving the placed floats tree over to LayoutUnit, I forgot to
update these asserts, which causes issues on ports with subpixel
layout enabled.
No new tests, no behavior change.
- rendering/FloatingObjects.cpp:
(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::::collectIfNeeded):
- 4:55 PM Changeset in webkit [159323] by
-
- 5 edits in trunk
Clean up sequence handling in Blob constructor
https://bugs.webkit.org/show_bug.cgi?id=124343
Patch by Victor Costan <costan@gmail.com> on 2013-11-14
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Added test case to LayoutTests/fast/files/blob-constructor.html
- bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob):
Handle exceptions in sequences, eliminate double type-checking for
ArrayBuffer, ArrayBufferView and Blob parts.
LayoutTests:
- fast/files/blob-constructor-expected.txt:
- fast/files/script-tests/blob-constructor.js:
Add test with sequence that throws an error on property access.
(get Object):
- 4:28 PM Changeset in webkit [159322] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] WKBrowsingContextController's policy client implementation over-releases WKURLRequests and WKURLResponses
https://bugs.webkit.org/show_bug.cgi?id=124386
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(setUpPagePolicyClient): Changed to release the Cocoa objects we copy out of the WK objects
passed into the client callbacks, but not the WK objects themselves, which are not owned by
the callbacks.
- 4:12 PM Changeset in webkit [159321] by
-
- 19 edits in trunk
Make CLoop easier to build, and make it work
https://bugs.webkit.org/show_bug.cgi?id=124359
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Add --cloop to build-jsc, build-webkit and friends.
Also make CLoop build and work again - This meant adding a
couple of missing ENABLE(DFG_JIT) blocks, and fixing a few
other references.
- Configurations/FeatureDefines.xcconfig:
- bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/DFGExitProfile.cpp:
- dfg/DFGCapabilities.cpp:
- dfg/DFGCompilationKey.cpp:
- dfg/DFGCompilationMode.cpp:
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
Source/WebCore:
Add cloop configuration info to WebCore FeatureDefines
so that it's consistent with JSC
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Make building with the CLoop forcibly enabled manually
disable the JITs
- wtf/Platform.h:
Tools:
Add --cloop support to forcibly enable to CLoop build
- Scripts/build-jsc:
- Scripts/build-webkit:
- 4:11 PM Changeset in webkit [159320] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 4:11 PM Changeset in webkit [159319] by
-
- 2 edits in trunk/Source/WebKit2
Replace calls to deprecated CFPropertyList functions in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124384
Reviewed by Anders Carlsson.
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::sessionStateData): Replaced CFPropertyListWriteToStream() with CFPropertyListWrite().
(WebKit::WebPageProxy::restoreFromSessionStateData): Replaced CFPropertyListCreateFromXMLData() with CFPropertyListCreateWithData().
- 4:10 PM Changeset in webkit [159318] by
-
- 1 copy in tags/Safari-537.73.10
New Tag.
- 3:37 PM WebKitGTK/2.2.x edited by
- (diff)
- 3:33 PM WikiStart edited by
- Removed defunct links (including links to non-upstream ports) and spam (diff)
- 3:27 PM Changeset in webkit [159317] by
-
- 2 edits in trunk/LayoutTests
Change Fail->Failure in some recent expectations.
Suddenly, everything is clear.
- 3:26 PM Changeset in webkit [159316] by
-
- 2 edits in trunk/Tools
Add webkit slave.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:23 PM Changeset in webkit [159315] by
-
- 2 edits in trunk/LayoutTests
http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, frequently > 30 second timeout
https://bugs.webkit.org/show_bug.cgi?id=124373
- platform/mac/TestExpectations:
Mark test as flaky on Mountain Lion Release bot.
Marking as slow seems to have no effect on the notifyDone timeout, just the outer timeouts.
- 3:15 PM Changeset in webkit [159314] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] Avoid extra copy when drawing images
https://bugs.webkit.org/show_bug.cgi?id=124209
Patch by Aloisio Almeida Jr <aloisio.almeida@openbossa.org> on 2013-11-14
Reviewed by Martin Robinson.
To solve the bug #58309 a cairo subsurface is being used to limit the
source image boundaries.
In many cases, when a cairo subsurface is used for drawing an image,
it occurs an image copy, causing performance penalty. In the case of
the function PlatformContextCairo::drawSurfaceToContext, the image
copy always happens.
So, we should use the subsurface only when it's really necessary.
In cases where we're drawing the whole image, the subsurface is
unnecessary.
The proposed patch avoid the use of subsurfaces when sampling the whole
image.
No new tests. It's an enhancement. Already covered by existing tests.
- platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::drawSurfaceToContext):
- 3:03 PM Changeset in webkit [159313] by
-
- 3 edits in trunk/Tools
build.webkit.org/dashboard can’t open different results in two new tabs
https://bugs.webkit.org/show_bug.cgi?id=124383
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype.revisionLinksForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
(StatusLineView.prototype._clicked):
Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
real pseudo-target and instead acts as a named target and will end up causing all link clicks
to open in the same secondary tab).
- 2:20 PM Changeset in webkit [159312] by
-
- 3 edits in trunk/Source/WebKit2
generate-message-receiver.py can't handle nested #ifs
https://bugs.webkit.org/show_bug.cgi?id=121877
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-14
Reviewed by Darin Adler.
parser.py was modifieded to collect and combine conditions of nested #ifs.
messages_unittest.py extended to check these modifications.
- Scripts/webkit2/messages_unittest.py:
(LoadSomething):
(std):
(AddEvent):
(LoadSomethingElse):
- Scripts/webkit2/parser.py:
(combine_condition):
(bracket_if_needed):
(parse):
- 2:02 PM Changeset in webkit [159311] by
-
- 2 edits in trunk/Source/WebKit/mac
Reimplement getDayBoundaries using NSCalendar on 10.9
https://bugs.webkit.org/show_bug.cgi?id=124379
Reviewed by Dan Bernstein.
- History/WebHistory.mm:
(getDayBoundaries):
- 1:44 PM Changeset in webkit [159310] by
-
- 11 edits4 adds in trunk
Implement raw format for WebCrypto key export
https://bugs.webkit.org/show_bug.cgi?id=124376
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: crypto/subtle/aes-export-key.html
crypto/subtle/hmac-export-key.html
A CryptoKey just exports its native CryptoKeyData, which will also work nicely for
JWK format soon. For spki and pkcs8, we'll need to figure out the best way to
utilize platform library support for ASN.1, but we are not there yet.
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::exportKey):
- crypto/CryptoKey.h:
- crypto/SubtleCrypto.idl:
- crypto/keys/CryptoKeyAES.cpp:
(WebCore::CryptoKeyAES::exportData):
- crypto/keys/CryptoKeyAES.h:
- crypto/keys/CryptoKeyHMAC.cpp:
(WebCore::CryptoKeyHMAC::exportData):
- crypto/keys/CryptoKeyHMAC.h:
- crypto/keys/CryptoKeyRSA.h:
- crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::exportData):
Added a dummy implementation for RSA.
LayoutTests:
- crypto/subtle/aes-export-key-expected.txt: Added.
- crypto/subtle/aes-export-key.html: Added.
- crypto/subtle/hmac-export-key-expected.txt: Added.
- crypto/subtle/hmac-export-key.html: Added.
- 1:40 PM Changeset in webkit [159309] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] WKAction keys are not exported
https://bugs.webkit.org/show_bug.cgi?id=124378
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKBrowsingContextController.mm: Made the keys constant pointers.
- UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Exported the keys.
- 1:30 PM Changeset in webkit [159308] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Simply generated domain dispatch methods for domains with few commands
https://bugs.webkit.org/show_bug.cgi?id=124374
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-14
Reviewed by Timothy Hatcher.
- inspector/CodeGeneratorInspector.py:
(Generator.go):
(Generator.process_command):
- inspector/CodeGeneratorInspectorStrings.py:
- 1:26 PM Changeset in webkit [159307] by
-
- 18 edits6 adds in trunk
[CSS Shapes] Accept the new <box> value for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=124227
Reviewed by David Hyatt.
Source/WebCore:
The shape-outside property can now be set to the box values [margin/border/padding/content]-box.
This patch adds the parsing code required to accept the new values, and the layout code
to create a rectangle shape that has the size and position of the appropriate box.
Tests: fast/shapes/shape-outside-floats/shape-outside-boxes-001.html
fast/shapes/shape-outside-floats/shape-outside-boxes-002.html
fast/shapes/shape-outside-floats/shape-outside-boxes-003.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Output the new box values.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Accept the new box values.
- css/CSSValueKeywords.in: Add margin-box value.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyShape::applyValue): Accept the new box values.
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderLogicalWidth): Added new utility methods to help
with box sizing.
(WebCore::RenderBoxModelObject::borderLogicalHeight): Ditto.
(WebCore::RenderBoxModelObject::paddingLogicalWidth): Ditto.
(WebCore::RenderBoxModelObject::paddingLogicalHeight): Ditto.
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape): You can create a shape from a box's dimensions, rather
than always using a BasicShape or RasterShape value.
- rendering/shapes/Shape.h:
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape): Create the appropriate shape based on the box values.
- rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::setShapeSize): Adjust for the box size when using a box value.
(WebCore::ShapeInfo::logicalTopOffset): Ditto.
(WebCore::ShapeInfo::logicalLeftOffset): Ditto.
- rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::isEnabledFor): Enable for the box values.
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::isEnabledFor): Disable for shape-inside.
- rendering/style/ShapeValue.h:
(WebCore::ShapeValue::createBoxValue): Create the appropriate shape value for a box.
(WebCore::ShapeValue::box): Return the box value for this ShapeValue.
(WebCore::ShapeValue::ShapeValue): Create a ShapeValue from a box value.
LayoutTests:
Test the different box values with different writing modes.
- fast/shapes/parsing/parsing-shape-inside-expected.html: Adding box values as invalid.
- fast/shapes/parsing/parsing-shape-inside.html: Ditto.
- fast/shapes/parsing/parsing-shape-outside-expected.html: Adding box values as valid.
- fast/shapes/parsing/parsing-shape-outside.html: Ditto.
- fast/shapes/shape-outside-floats/shape-outside-boxes-001-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-boxes-001.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-boxes-002-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-boxes-002.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-boxes-003-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-boxes-003.html: Added.
- 1:26 PM Changeset in webkit [159306] by
-
- 3 edits in trunk/LayoutTests
Flaky Test: media/video-fast-seek.html
https://bugs.webkit.org/show_bug.cgi?id=124298
Reviewed by Eric Carlson.
Don't check for the precise results of currentTime, as MediaTime -> double
rounding will occasionally result in errors.
- media/video-fast-seek-expected.txt:
- media/video-fast-seek.html:
- 1:14 PM Changeset in webkit [159305] by
-
- 6 edits in trunk/Source/WebKit/mac
Stop using deprecated NSPropertyListSerialization methods
https://bugs.webkit.org/show_bug.cgi?id=124377
Reviewed by Mark Rowe.
- History/WebHistory.mm:
(-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCIdentifierInfo):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):
(WebKit::NetscapePluginInstanceProxy::marshalValue):
(WebKit::NetscapePluginInstanceProxy::marshalValues):
(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::getPropertyNames):
- 12:13 PM Changeset in webkit [159304] by
-
- 2 edits in trunk/LayoutTests
fullscreen/anonymous-block-merge-crash.html often times out in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=124318
- platform/mac/TestExpectations:
Used the wrong kind of failure for a notifyDone timeout.
- 12:12 PM Changeset in webkit [159303] by
-
- 2 edits in trunk/Source/WebCore
Rubber-stamped by Tim Horton.
Post-checkin review comment! StickToViewportBounds sounds better and more accurate
than StickToWindowBounds.
- platform/ScrollTypes.h:
- 12:10 PM Changeset in webkit [159302] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build failure; update MediaPlayerPrivateAVFFoundationCF::seekToTime after r159208.
After r159208, seekToTime takes tolerance parameters.
Patch by Jer Noble <jer.noble@apple.com> on 2013-11-13
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::seekToTime):
(WebCore::AVFWrapper::seekToTime):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
- 12:05 PM Changeset in webkit [159301] by
-
- 2 edits in trunk/LayoutTests
http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is slow, frequently > 30 second timeout
https://bugs.webkit.org/show_bug.cgi?id=124373
- platform/mac/TestExpectations:
Mark test as slow on Mountain Lion Release bot.
- 12:03 PM Changeset in webkit [159300] by
-
- 12 edits in trunk/Source/WebCore
Add a new mode where fixed elements don't constrain their positions during a
rubber band
https://bugs.webkit.org/show_bug.cgi?id=124260
Reviewed by Tim Horton.
This patch adds a new enum called ScrollBehaviorForFixedElements, which has
two values, StickToDocumentBounds or StickToWindowBounds. StickToDocumentBounds
corresponds to our current behavior, where fixed elements constrain
their positions during a rubber-band so that they stay stuck to the document.
The new mode, StickToWindowBounds, will cause fixed elements to always stay
fixed relative to the window.
scrollOffsetForFixedPosition() now takes a new parameter for the fixed behavior
so that it knows whether or not to constrain the position.
- page/FrameView.cpp:
(WebCore::FrameView::scrollOffsetForFixedPosition):
Right now, just return StickToDocumentBounds and retain existing behavior.
(WebCore::FrameView::scrollBehaviorForFixedElements):
- page/FrameView.h:
The scrolling thread needs to know about the fixed element scroll behavior,
so this code makes ScrollingStateScrollingNodes keep track of that
information to pass over to the scrolling thread.
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setScrollBehaviorForFixedElements):
- page/scrolling/ScrollingStateScrollingNode.h:
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
- page/scrolling/ScrollingTreeScrollingNode.h:
(WebCore::ScrollingTreeScrollingNode::scrollBehaviorForFixedElements):
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinatorMac::setScrollBehaviorForFixedElementsForNode):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Here is the new enum.
- platform/ScrollTypes.h:
Another place where we only want to constrain scroll position if that is the
mode we are in.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::customPositionForVisibleRectComputation):
- 11:56 AM Changeset in webkit [159299] by
-
- 3 edits2 adds in trunk
[Mac] HMAC sign/verify crashes when key is empty
https://bugs.webkit.org/show_bug.cgi?id=124372
Reviewed by Sam Weinig.
Source/WebCore:
Test: crypto/subtle/hmac-sign-verify-empty-key.html
- crypto/mac/CryptoAlgorithmHMACMac.cpp: (WebCore::calculateSignature): Give it
a non-null pointer then.
LayoutTests:
- crypto/subtle/hmac-sign-verify-empty-key-expected.txt: Added.
- crypto/subtle/hmac-sign-verify-empty-key.html: Added.
- 11:43 AM Changeset in webkit [159298] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION (r159276): Fix lots of crashes for arm_traditional architecture.
https://bugs.webkit.org/show_bug.cgi?id=124365
Reviewed by Oliver Hunt.
Crashes were caused by a mixup between regular registers and temporary registers in ARM_EXTRA_GPRS.
- llint/LowLevelInterpreter32_64.asm: Warning, t3 != a3. It's safer to use an implementation using aX
registers like the MIPS one for cCallX macros.
- offlineasm/arm.rb: Rearrange ARM_EXTRA_GPRS according to the new register distribution in LLINT.
- 11:16 AM Changeset in webkit [159297] by
-
- 2 edits in trunk/Tools
Remove duplicate entry.
- Scripts/webkitpy/common/config/contributors.json:
- 11:00 AM Changeset in webkit [159296] by
-
- 2 edits in trunk/Source/WebCore
Implement RSASSA-PKCS1-v1_5 sign/verify
https://bugs.webkit.org/show_bug.cgi?id=124335
Build fix.
- crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
- 10:57 AM Changeset in webkit [159295] by
-
- 5 edits2 adds in trunk
AX: Calling NSAccessibilityColumnsAttribute and NSAccessibilityRowsAttribute simply to get column/row count can be very expensive.
https://bugs.webkit.org/show_bug.cgi?id=124293
Reviewed by Chris Fleizach.
Source/WebCore:
Added ability to get accessibility table column or row count without fetching all columns or rows.
Test: platform/mac/accessibility/table-column-and-row-count.html
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
Added test to ensure NSAccessibilityColumnsAttribute and NSAccessibilityRowsAttribute
behave as expected. Also updated existing table tests to reflect this additional API.
- platform/mac/accessibility/table-column-and-row-count-expected.txt: Added.
- platform/mac/accessibility/table-column-and-row-count.html: Added.
- platform/mac/accessibility/table-detection-expected.txt:
- platform/mac/accessibility/table-with-rules-expected.txt:
- 10:51 AM Changeset in webkit [159294] by
-
- 6 edits in trunk
Versioning.
- 10:49 AM Changeset in webkit [159293] by
-
- 1 copy in tags/Safari-538.6
New Tag.
- 10:26 AM Changeset in webkit [159292] by
-
- 9 edits1 copy3 adds5 deletes in trunk
Implement RSASSA-PKCS1-v1_5 sign/verify
https://bugs.webkit.org/show_bug.cgi?id=124335
Reviewed by Sam Weinig.
Source/WebCore:
Test: crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html
- WebCore.xcodeproj/project.pbxproj: Added new files, removed Mac SHA algorithm files.
- crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
(WebCore::getCommonCryptoDigestAlgorithm):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
Implemented. These take two steps, first a digest is computed, and then it's signed.
- crypto/CryptoDigest.h: Added.
- crypto/mac/CryptoDigestMac.cpp: Added.
(WebCore::CryptoDigest::CryptoDigest):
(WebCore::CryptoDigest::~CryptoDigest):
(WebCore::CryptoDigest::create):
(WebCore::CryptoDigest::addBytes):
(WebCore::CryptoDigest::computeHash):
Added a cross-platform interface and Mac implementation to compute a digest. It
should be possible to use it outside WebCrypto if we need to (perhaps even merge
with WTF SHA-1 class).
The Mac implementation is kind of ugly, but at least it encapsulates the ugliness.
- crypto/algorithms/CryptoAlgorithmSHA1.cpp: (WebCore::CryptoAlgorithmSHA1::digest):
- crypto/algorithms/CryptoAlgorithmSHA224.cpp: (WebCore::CryptoAlgorithmSHA224::digest):
- crypto/algorithms/CryptoAlgorithmSHA256.cpp: (WebCore::CryptoAlgorithmSHA256::digest):
- crypto/algorithms/CryptoAlgorithmSHA384.cpp: (WebCore::CryptoAlgorithmSHA384::digest):
- crypto/algorithms/CryptoAlgorithmSHA512.cpp: (WebCore::CryptoAlgorithmSHA512::digest):
- crypto/mac/CryptoAlgorithmSHA1Mac.cpp: Removed.
- crypto/mac/CryptoAlgorithmSHA224Mac.cpp: Removed.
- crypto/mac/CryptoAlgorithmSHA256Mac.cpp: Removed.
- crypto/mac/CryptoAlgorithmSHA384Mac.cpp: Removed.
- crypto/mac/CryptoAlgorithmSHA512Mac.cpp: Removed.
These are all cross-platform now.
LayoutTests:
- crypto/subtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt: Added.
- crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html: Added.
- 10:21 AM Changeset in webkit [159291] by
-
- 3 edits4 adds in trunk
[CSS Shapes] Empty polygons with non-zero shape-padding cause an ASSERT crash
https://bugs.webkit.org/show_bug.cgi?id=124324
Reviewed by Andreas Kling.
Source/WebCore:
PolygonShape::shapePaddingBounds() and PolygonShape::shapeMarginBounds() no
longer attempt to compute a new FloatPolygon when the original is empty, i.e.
when it has less than three vertices.
Tests: fast/shapes/shape-inside/shape-inside-empty-polygon-crash.html
fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash.html
- rendering/shapes/PolygonShape.cpp:
(WebCore::PolygonShape::shapePaddingBounds): Don't compute a padding FloatPolygon if the original polygon is empty.
(WebCore::PolygonShape::shapeMarginBounds): Don't compute a margin FloatPolygon if the original polygon is empty.
LayoutTests:
- fast/shapes/shape-inside/shape-inside-empty-polygon-crash-expected.txt: Added.
- fast/shapes/shape-inside/shape-inside-empty-polygon-crash.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash.html: Added.
- 10:13 AM Changeset in webkit [159290] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r159276): rbp register overwritten in Win 64 version of callToJavascript stub
https://bugs.webkit.org/show_bug.cgi?id=124361
Reviewed by Oliver Hunt.
Swapped operand ordering to: mov rax, rbp
- jit/JITStubsMSVC64.asm:
- 9:45 AM Changeset in webkit [159289] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Cleaner Backend Method Calling Code Generation
https://bugs.webkit.org/show_bug.cgi?id=124333
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-14
Reviewed by Timothy Hatcher.
No change in functionality, just improved generated code.
- inspector/CodeGeneratorInspector.py:
(Generator.process_command):
- inspector/CodeGeneratorInspectorStrings.py:
- inspector/InspectorBackendDispatcher.cpp:
- inspector/InspectorBackendDispatcher.h:
- 8:52 AM Changeset in webkit [159288] by
-
- 4 edits in trunk/Source/JavaScriptCore
REGRESSION (r159276): Fix lots of crashes for sh4 architecture.
https://bugs.webkit.org/show_bug.cgi?id=124347
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-14
Reviewed by Michael Saboff.
Since r159276, we have (t4 == a0 == r4) and (t5 == a1 == r5) in LLINT for sh4.
This leads to argument register trampling in cCallX macros, especially with cCall2
macro when arg1 == t4.
- llint/LowLevelInterpreter32_64.asm: Use a new "setargs" pseudo-op to setup arguments for sh4.
- offlineasm/instructions.rb:
- offlineasm/sh4.rb: Lower "setargs" pseudo-op to setup argument registers and prevent register trampling issues.
- 8:49 AM Changeset in webkit [159287] by
-
- 7 edits in trunk/Tools
[ATK] Change WKTR/DRT AX methods to use nullptr
https://bugs.webkit.org/show_bug.cgi?id=124352
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-14
Reviewed by Anders Carlsson.
Change WKTR/DRT accessibility related methods to use nullptr.
- DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::AccessibilityController):
(AccessibilityController::elementAtPoint):
(AccessibilityController::removeNotificationListener):
(AccessibilityController::childElementById):
- DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
(AccessibilityNotificationHandler::AccessibilityNotificationHandler):
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::removeNotificationListener):
(AccessibilityUIElement::classList):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::logAccessibilityEvents):
(WTR::AccessibilityController::resetToConsistentState):
(WTR::childElementById):
(WTR::AccessibilityController::accessibleElementById):
(WTR::AccessibilityController::removeNotificationListener):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR::AccessibilityUIElement::supportedActions):
(WTR::AccessibilityUIElement::pathDescription):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
(WTR::AccessibilityUIElement::classList):
- 8:03 AM Changeset in webkit [159286] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Popovers may shrink unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=124350
Reviewed by Timothy Hatcher.
Because we always get the intersection of the preferred frame and the container frame to
ensure the popover fits within its container based on a preferred frame that would place
the arrow within the center of the attachment edge, we get in situations where we may
shrink the popover instead of shifting it to fit within the container frame. We now first
shift the preferred frame before getting its intersection with the container frame to
avoid such situations.
- UserInterface/Popover.js:
(WebInspector.Popover.prototype._bestMetricsForEdge):
- 7:38 AM Changeset in webkit [159285] by
-
- 2 edits in trunk/Tools
run-perf-tests should warn loudly if you're using a Debug build.
https://bugs.webkit.org/show_bug.cgi?id=105236
Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-14
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.run):
- 5:48 AM Changeset in webkit [159284] by
-
- 3 edits in trunk/Source/WebCore
Use [ImplementedAs=defaultStatus] for Window.defaultstatus
https://bugs.webkit.org/show_bug.cgi?id=124334
Reviewed by Christophe Dumez.
No new tests, this is just refactoring.
Use [ImplementedAs=defaultStatus] for Window.defaultstatus
and remove unnecessary code from DOMWindow.
Because 'defaultstatus' is an alias of defaultStatus.
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 5:28 AM Changeset in webkit [159283] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build for sh4 architectures (broken since r159276).
https://bugs.webkit.org/show_bug.cgi?id=124344
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-14
Reviewed by Csaba Osztrogonác.
- offlineasm/sh4.rb: There is no fp alias for r14 register for sh4.
- 4:50 AM Changeset in webkit [159282] by
-
- 2 edits in trunk/Tools
Fix Tools/Scripts/webkitpy/port/factory.py --help to display which configuration is default
https://bugs.webkit.org/show_bug.cgi?id=124143
Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-14
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/port/factory.py:
(configuration_options):
- 3:25 AM Changeset in webkit [159281] by
-
- 5 edits in trunk/Source/WebCore
Generate toSVGPolyline|gonElement() to replace static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=124341
Reviewed by Andreas Kling.
toSVGFoo() supports more plenty helper functions. So, toSVGFoo() needs
to be used instead of static_cast<>.
Additionally, cleanup other static_cast<> as well.
No new tests, no behavior changes.
- rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromEllipseElement):
(WebCore::updatePathFromLineElement):
(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):
- svg/SVGPolygonElement.h:
- svg/SVGPolylineElement.h:
- svg/svgtags.in: Add *generateTypeHelpers* keyword to polygon, polyline
- 3:07 AM Changeset in webkit [159280] by
-
- 4 edits in trunk/LayoutTests
[EFL] Layout tests with text areas need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124337
Unreviewed, EFL gatdening.
EFL text areas rebaselined after r129492.
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-14
- platform/efl/TestExpectations:
- platform/efl/fast/forms/basic-textareas-expected.txt:
- platform/efl/fast/forms/basic-textareas-quirks-expected.txt:
- 3:01 AM Changeset in webkit [159279] by
-
- 6 edits in trunk/Source
FontDescription copies should share families list, not duplicate it.
<https://webkit.org/b/124338>
Source/WebCore:
Turn FontDescription::m_families into a RefCountedArray<AtomicString>
instead of a Vector<AtomicString, 1>. This allows FontDescription to
share the families list between copies, instead of each object having
its own Vector.
Also, FontDescription itself shrinks by 16 bytes.
Reviewed by Antti Koivisto.
Source/WTF:
Add RefCountedArray::operator==.
Reviewed by Antti Koivisto.
- 1:12 AM Changeset in webkit [159278] by
-
- 9 edits2 moves in trunk/Source/WebKit2
[WK2] Move Coordinated Graphics related code out of DrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=124328
Reviewed by Andreas Kling.
Refactored for DrawingAreaProxy not to include Coordinated Graphics specific code.
- PlatformEfl.cmake:
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp: Moved from DrawingAreaProxy.cpp.
(WebKit::CoordinatedDrawingAreaProxy::updateViewport):
(WebKit::CoordinatedDrawingAreaProxy::contentsRect):
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h: Ditto.
(WebKit::CoordinatedDrawingAreaProxy::coordinatedLayerTreeHostProxy): Refactored to return reference instead of pointer.
(WebKit::CoordinatedDrawingAreaProxy::viewportVisibleRect):
(WebKit::CoordinatedDrawingAreaProxy::page):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
- UIProcess/CoordinatedGraphics/PageViewportController.cpp:
Renamed from Source/WebKit2/UIProcess/PageViewportController.cpp because it depends on Coordinated Graphics.
(WebKit::fuzzyCompare):
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::innerBoundedViewportScale):
(WebKit::PageViewportController::outerBoundedViewportScale):
(WebKit::PageViewportController::deviceScaleFactor):
(WebKit::isIntegral):
(WebKit::PageViewportController::pixelAlignedFloatPoint):
(WebKit::PageViewportController::boundContentsPositionAtScale):
(WebKit::PageViewportController::boundContentsPosition):
(WebKit::PageViewportController::didCommitLoad):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::pageTransitionViewportReady):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::didChangeViewportSize):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents): Added cast to access CoordinatedDrawingAreaProxy method.
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::visibleContentsSize):
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
(WebKit::PageViewportController::applyPositionAfterRenderingContents):
(WebKit::PageViewportController::updateMinimumScaleToFit):
- UIProcess/CoordinatedGraphics/PageViewportController.h:
Renamed from Source/WebKit2/UIProcess/PageViewportController.cpp because it depends on Coordinated Graphics.
(WebKit::PageViewportController::~PageViewportController):
(WebKit::PageViewportController::hadUserInteraction):
(WebKit::PageViewportController::allowsUserScaling):
(WebKit::PageViewportController::contentsLayoutSize):
(WebKit::PageViewportController::minimumScale):
(WebKit::PageViewportController::maximumScale):
(WebKit::PageViewportController::currentScale):
(WebKit::PageViewportController::setHadUserInteraction):
- UIProcess/CoordinatedGraphics/WebView.cpp: Added some casts to access CoordinatedDrawingAreaProxy methods.
(WebKit::WebView::coordinatedGraphicsScene): Simplified code using reference.
(WebKit::WebView::updateViewportSize):
- UIProcess/DrawingAreaProxy.cpp: Removed Coordinated Graphics macro and related codes.
- UIProcess/DrawingAreaProxy.h: Ditto.
- 1:04 AM Changeset in webkit [159277] by
-
- 5 edits in trunk/Source/WebCore
Introduce FILTER_TYPE_CASTS for child filter class
https://bugs.webkit.org/show_bug.cgi?id=124332
Reviewed by Andreas Kling.
To use TYPE_CASTS_BASE, define FILTER_TYPE_CASTS macro. Thanks to
it, static_cast<SVGFilter*> can be replaced by toSVGFilter().
No new tests, no behavior changes.
- platform/graphics/filters/Filter.h:
Add isSVGFilter() to check if casting object is SVGFilter object.
(WebCore::Filter::isSVGFilter):
- rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
- svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::platformApplySoftware):
- svg/graphics/filters/SVGFilter.h:
Nov 13, 2013:
- 11:39 PM Changeset in webkit [159276] by
-
- 23 edits in trunk/Source/JavaScriptCore
Change callToJavaScript thunk into an offline assembled stub
https://bugs.webkit.org/show_bug.cgi?id=124251
Reviewed by Geoffrey Garen.
Changed callToJavaScript and throwNotCaught into stubs generated by the offline assembler.
Added popCalleeSaves and pushCalleeSaves pseudo ops to the offline assembler to handle
the saving and restoring of callee save registers. Fixed callFrameRegister differences
between arm traditional (r11) and arm Thumb2 (r7) in GPRInfo.h. Also fixed implementation
of pop & push in arm.rb.
Since the offline assembler and therefore the LLInt don't work on Windows, the Windows stubs
are handled as inline assembly in JITStubsX86.h and JITStubsMSVC64.asm.
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- jit/GPRInfo.h:
(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):
- jit/JITCode.cpp:
(JSC::JITCode::execute):
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- jit/JITStubs.h:
- jit/JITStubsMSVC64.asm:
- jit/JITStubsX86.h:
- jit/ThunkGenerators.cpp:
- jit/ThunkGenerators.h:
- llint/LLIntThunks.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/arm.rb:
- offlineasm/arm64.rb:
- offlineasm/instructions.rb:
- offlineasm/mips.rb:
- offlineasm/registers.rb:
- offlineasm/sh4.rb:
- offlineasm/x86.rb:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 9:46 PM Changeset in webkit [159275] by
-
- 12 edits in trunk
Source/WebCore: Blob constructor accepts a sequence (array-like object) as first arg.
https://bugs.webkit.org/show_bug.cgi?id=124175
Patch by Victor Costan <costan@gmail.com> on 2013-11-13
Reviewed by Christophe Dumez.
Added test cases to fast/files/script-tests/blob-constructor.js.
- bindings/js/JSBlobCustom.cpp: Make the constructor work with sequences.
(WebCore::JSBlobConstructor::constructJSBlob):
- bindings/js/JSDOMBinding.h:
(WebCore::toJSSequence): Slightly better error message when conversion fails.
(WebCore::toJS): Whitespace.
(WebCore::jsArray): Whitespace.
LayoutTests: Blob constructor accepts a sequence (array-like object) as first arg.
https://bugs.webkit.org/show_bug.cgi?id=124175
Patch by Victor Costan <costan@gmail.com> on 2013-11-13
Reviewed by Christophe Dumez.
- crypto/subtle/argument-conversion-expected.txt: Updated sequence error expectations.
- fast/dom/Window/window-postmessage-args-expected.txt: Updated sequence error expectations.
- fast/events/constructors/message-event-constructor-expected.txt: Updated sequence error expectations.
- fast/events/message-port-multi-expected.txt: Updated sequence error expectations.
- fast/files/blob-constructor-expected.txt: Updated error text and added expectations.
- fast/files/script-tests/blob-constructor.js: Added sequence test cases.
- fast/workers/worker-context-multi-port-expected.txt: Updated sequence error expectations.
- fast/workers/worker-multi-port-expected.txt: Updated sequence error expectations.
- 9:06 PM Changeset in webkit [159274] by
-
- 5 edits in trunk/LayoutTests
[EFL] Layout tests with css3 selectors3 properties need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124266
Unreviewed, EFL gardening.
EFL css3 rebaselined after r111644.
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-13
- platform/efl-wk2/TestExpectations:
- platform/efl/css3/selectors3/html/css3-modsel-1-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-1-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-1-expected.txt:
- 7:08 PM Changeset in webkit [159273] by
-
- 5 edits in trunk/Source/WebKit
Unreviewed rollout of r159271, broke Mountain Lion build.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- History/WebHistory.h:
- History/WebHistory.mm:
- 7:01 PM Changeset in webkit [159272] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: InspectorBackendDispatcher improvements
https://bugs.webkit.org/show_bug.cgi?id=124330
Reviewed by Timothy Hatcher.
- inspector/InspectorBackendDispatcher.cpp:
(WebCore::InspectorBackendDispatcher::sendResponse):
(WebCore::InspectorBackendDispatcher::reportProtocolError):
- inspector/InspectorBackendDispatcher.h:
(WebCore::InspectorSupplementalBackendDispatcher::InspectorSupplementalBackendDispatcher):
- 6:58 PM Changeset in webkit [159271] by
-
- 5 edits in trunk/Source/WebKit
Deprecate WebHistory methods that use NSCalendarDate
https://bugs.webkit.org/show_bug.cgi?id=124329
<rdar://problem/15441122>
Reviewed by Mark Rowe.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Add a shell script phase that uses unifdef to remove the NSd_10_9 #define from
WebHistory on Mavericks.
Source/WebKit/mac:
- History/WebHistory.h:
Add NS_DEPRECATED_MAC to orderedLastVisitedDays and orderedItemsLastVisitedOnDay:.
In order to not break the Mountain Lion build, define NSd_10_9 if necessary.
- History/WebHistory.mm:
Ignore deprecation warnings in methods where NSCalendarDate is used.
- 6:39 PM Changeset in webkit [159270] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed Windows Build Fix after r159268.
Missed adding InspectorBackendDispatcher.h and cpp to the Windows build.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 6:28 PM Changeset in webkit [159269] by
-
- 10 edits in trunk/Source/WebKit2
Rename some ImmutableArray leftovers
https://bugs.webkit.org/show_bug.cgi?id=124320
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-13
Reviewed by Anders Carlsson.
ImmutableArray has been renamed to API::Array in r159234.
- Shared/API/c/WKContextMenuItem.cpp:
- Shared/WebContextMenuItem.cpp:
- Shared/WebContextMenuItem.h:
- UIProcess/API/C/WKBackForwardListRef.cpp:
- UIProcess/API/Cocoa/WKBackForwardList.mm:
- UIProcess/API/gtk/WebKitBackForwardList.cpp:
- UIProcess/API/gtk/WebKitWebViewGroup.cpp:
- UIProcess/WebBackForwardList.cpp:
- UIProcess/WebBackForwardList.h:
- 6:24 PM Changeset in webkit [159268] by
-
- 52 edits2 adds in trunk/Source/WebCore
Web Inspector: Generate Individual InspectorBackendDispatchers, add base InspectorBackendDispatcher
https://bugs.webkit.org/show_bug.cgi?id=124296
Reviewed by Timothy Hatcher.
No new tests, this is just refactoring without changing functionality.
Set of changes made:
- Add inspector/InspectorBackendDispatcher.{h,cpp}. This used to be almost entirely written in the code generator strings file, but make it actual source files because there is nothing changing in the code. Also clean this up a bit.
- Give the base dispatcher a list of domain dispatchers and a way to register.
- Make InspectorBackendDispatcher::dispatch read the domain of incoming request and pass the request on to the domain dispatcher.
- Create per-domain dispatcher classes named "InspectorFooBackendDispatcher"
- Convert "InspectorBackendDispatcher::FooCommandHandler" interfaces to "InspectorFooBackendDispatcherHandler" interfaces.
- Convert all "InspectorBackendDispatcherImpl::FooDomain_fooMethod" methods to "InspectorFooBackendDispatcher::fooMethod" methods. These can also remove their "if (!agent)" checks because that can never be the case anymore.
- Remove InspectorBackendDispatcherImpl, now that there are base and domain dispatchers.
- Add ASCIILiteral in many places in generated code where possible.
- In all agents, create dispatchers in didCreateFrontendAndBackend and clear them in willDestroyFrontendAndBackend, right alongside frontend dispatchers.
- inspector/CodeGeneratorInspector.py:
(DomainNameFixes.get_fixed_data.Res):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Generator):
(Generator.go):
(Generator.process_command):
(Generator.generate_send_method):
- inspector/CodeGeneratorInspectorStrings.py:
(void):
(HashMap):
(InspectorBackendDispatchers_h):
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didCreateFrontendAndBackend):
(WebCore::InspectorAgent::willDestroyFrontendAndBackend):
- inspector/InspectorAgent.h:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::didCreateFrontendAndBackend):
(WebCore::InspectorApplicationCacheAgent::willDestroyFrontendAndBackend):
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorBackendDispatcher.cpp: Added.
(WebCore::InspectorBackendDispatcher::CallbackBase::CallbackBase):
(WebCore::InspectorBackendDispatcher::CallbackBase::isActive):
(WebCore::InspectorBackendDispatcher::CallbackBase::sendFailure):
(WebCore::InspectorBackendDispatcher::CallbackBase::sendIfActive):
(WebCore::InspectorBackendDispatcher::create):
(WebCore::InspectorBackendDispatcher::registerDispatcherForDomain):
(WebCore::InspectorBackendDispatcher::dispatch):
(WebCore::InspectorBackendDispatcher::sendResponse):
(WebCore::InspectorBackendDispatcher::reportProtocolError):
(WebCore::InspectorBackendDispatcher::getPropertyValue):
(WebCore::AsMethodBridges::asInt):
(WebCore::AsMethodBridges::asDouble):
(WebCore::AsMethodBridges::asString):
(WebCore::AsMethodBridges::asBoolean):
(WebCore::AsMethodBridges::asObject):
(WebCore::AsMethodBridges::asArray):
(WebCore::InspectorBackendDispatcher::getInt):
(WebCore::InspectorBackendDispatcher::getDouble):
(WebCore::InspectorBackendDispatcher::getString):
(WebCore::InspectorBackendDispatcher::getBoolean):
(WebCore::InspectorBackendDispatcher::getObject):
(WebCore::InspectorBackendDispatcher::getArray):
- inspector/InspectorBackendDispatcher.h: Added.
(WebCore::InspectorSupplementalBackendDispatcher::InspectorSupplementalBackendDispatcher):
(WebCore::InspectorSupplementalBackendDispatcher::~InspectorSupplementalBackendDispatcher):
(WebCore::InspectorBackendDispatcher::~InspectorBackendDispatcher):
(WebCore::InspectorBackendDispatcher::clearFrontend):
(WebCore::InspectorBackendDispatcher::isActive):
(WebCore::InspectorBackendDispatcher::InspectorBackendDispatcher):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCanvasAgent::willDestroyFrontendAndBackend):
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::didCreateFrontendAndBackend):
(WebCore::InspectorConsoleAgent::willDestroyFrontendAndBackend):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMDebuggerAgent::willDestroyFrontendAndBackend):
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMStorageAgent::willDestroyFrontendAndBackend):
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDatabaseAgent::willDestroyFrontendAndBackend):
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDebuggerAgent::willDestroyFrontendAndBackend):
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorHeapProfilerAgent::willDestroyFrontendAndBackend):
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::didCreateFrontendAndBackend):
(WebCore::InspectorIndexedDBAgent::willDestroyFrontendAndBackend):
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInputAgent.cpp:
(WebCore::InspectorInputAgent::didCreateFrontendAndBackend):
(WebCore::InspectorInputAgent::willDestroyFrontendAndBackend):
- inspector/InspectorInputAgent.h:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::didCreateFrontendAndBackend):
(WebCore::InspectorLayerTreeAgent::willDestroyFrontendAndBackend):
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::didCreateFrontendAndBackend):
(WebCore::InspectorMemoryAgent::willDestroyFrontendAndBackend):
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorPageAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorPageAgent::getScriptExecutionStatus):
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorProfilerAgent::willDestroyFrontendAndBackend):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didCreateFrontendAndBackend):
(WebCore::InspectorResourceAgent::willDestroyFrontendAndBackend):
- inspector/InspectorResourceAgent.h:
- inspector/InspectorRuntimeAgent.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorWorkerAgent::willDestroyFrontendAndBackend):
- inspector/InspectorWorkerAgent.h:
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::didCreateFrontendAndBackend):
(WebCore::PageRuntimeAgent::willDestroyFrontendAndBackend):
- inspector/PageRuntimeAgent.h:
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::didCreateFrontendAndBackend):
(WebCore::WorkerRuntimeAgent::willDestroyFrontendAndBackend):
- inspector/WorkerRuntimeAgent.h:
- 5:59 PM Changeset in webkit [159267] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r159263): caused 50+ crashes on all mac webkit2 bots
https://bugs.webkit.org/show_bug.cgi?id=124327
Reviewed by Tim Horton.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject): Allocate extra memory for the WebError inside the WKNSError.
- 5:20 PM Changeset in webkit [159266] by
-
- 2 edits in trunk/LayoutTests
Layout Test animations/resume-after-page-cache.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=124321
- platform/mac/TestExpectations:
- 5:18 PM Changeset in webkit [159265] by
-
- 2 edits in trunk/Source/WebCore
Use NSCalendarIdentifierGregorian instead of NSGregorianCalendar on OS X 10.9 and iOS
https://bugs.webkit.org/show_bug.cgi?id=124323
Reviewed by Mark Rowe.
NSGregorianCalendar was deprecated in OS X 10.9 and iOS 7.
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::LocaleMac):
- 4:53 PM Changeset in webkit [159264] by
-
- 13 edits in trunk/Source/WebCore
Web Inspector: Rename InspectorBackendDispatcher.h to InspectorBackendDispatchers.h
https://bugs.webkit.org/show_bug.cgi?id=124257
Reviewed by Timothy Hatcher.
Soon each domain will generate its own dispatcher, and the generic
InspectorBackendDispatcher will no longer be generated, it will just
live in WebCore/inspector.
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.py:
- inspector/CodeGeneratorInspectorStrings.py:
(InspectorBackendDispatchers_h):
- inspector/InspectorBaseAgent.h:
- inspector/InspectorController.cpp:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/WorkerInspectorController.cpp:
- 4:49 PM Changeset in webkit [159263] by
-
- 3 edits2 adds in trunk/Source/WebKit2
[Cocoa] Add WKNSError
https://bugs.webkit.org/show_bug.cgi?id=124295
Reviewed by Anders Carlsson.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject): Allocate a WKNSError if the object is a WebError.
- Shared/Cocoa/WKNSError.h: Added.
(WebKit::wrapper): Added. Returns a WebError’s wrapper as an NSError.
- Shared/Cocoa/WKNSError.mm: Added.
(-[WKNSError _web_createTarget]): Override this WKObject method to return a copy of the
underlying CFError.
(-[WKNSError copyWithZone:]): Retains self.
- WebKit2.xcodeproj/project.pbxproj: Added new files.
- 4:46 PM Changeset in webkit [159262] by
-
- 2 edits in trunk/Source/WebKit2
Tweak the property syntax after https://bugs.webkit.org/show_bug.cgi?id=124317
Reviewed by Dan Bernstein.
- UIProcess/API/mac/WKViewPrivate.h:
- 4:44 PM Changeset in webkit [159261] by
-
- 6 edits in trunk/Source/JavaScriptCore
Fix the ARM64 build after recent JavaScriptCore changes
https://bugs.webkit.org/show_bug.cgi?id=124315
Reviewed by Michael Saboff.
Based on patches by myself, Filip Pizlo, Benjamin Poulain, and Michael Saboff.
- Configurations/JavaScriptCore.xcconfig: Hid the symbol for
std::bad_function_call.
- JavaScriptCore.xcodeproj/project.pbxproj: Marked
MacroAssemblerARM64.h and ARM64Assembler.h as Private headers.
- assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::executableOffsetFor):
- assembler/MacroAssemblerARM64.h: Removed ARM64's executableCopy(),
which was removed from other assembler backends in r157690.
(JSC::MacroAssemblerARM64::shouldBlindForSpecificArch): Added.
(JSC::MacroAssemblerARM64::lshift64): Added.
(JSC::MacroAssemblerARM64::mul64): Added.
(JSC::MacroAssemblerARM64::rshift64): Added.
(JSC::MacroAssemblerARM64::convertInt64ToDouble): Added.
(JSC::MacroAssemblerARM64::branchMul64): Added.
(JSC::MacroAssemblerARM64::branchNeg64): Added.
(JSC::MacroAssemblerARM64::scratchRegisterForBlinding): Added.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithDiv): Changed
SpeculateIntegerOperand to SpeculateInt32Operand,
nodeCanIgnoreNegativeZero() to bytecodeCanIgnoreNegativeZero(), and
nodeUsedAsNumber() to bytecodeUsesAsNumber().
(JSC::DFG::SpeculativeJIT::compileArithMod): Changed
nodeCanIgnoreNegativeZero() to bytecodeCanIgnoreNegativeZero().
- 4:22 PM Changeset in webkit [159260] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 4:20 PM Changeset in webkit [159259] by
-
- 1 copy in tags/Safari-537.73.9
New Tag.
- 4:07 PM Changeset in webkit [159258] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r159248. <rdar://problem/15464319>
- 3:57 PM Changeset in webkit [159257] by
-
- 3 edits in trunk/LayoutTests
fullscreen/anonymous-block-merge-crash.html often times out in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=124318
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
Mark test as timing out on WebKit1 only.
- 3:55 PM Changeset in webkit [159256] by
-
- 1 copy in tags/Safari-537.60.6
New Tag.
- 3:55 PM Changeset in webkit [159255] by
-
- 4 edits in trunk/Source/WebKit2
Move more state tracking to FrameLoadState
https://bugs.webkit.org/show_bug.cgi?id=124316
Reviewed by Simon Fraser.
- UIProcess/FrameLoadState.cpp:
(WebKit::FrameLoadState::didStartProvisionalLoad):
(WebKit::FrameLoadState::didReceiveServerRedirectForProvisionalLoad):
(WebKit::FrameLoadState::didFailProvisionalLoad):
(WebKit::FrameLoadState::didCommitLoad):
(WebKit::FrameLoadState::didFinishLoad):
(WebKit::FrameLoadState::didFailLoad):
(WebKit::FrameLoadState::didSameDocumentNotification):
(WebKit::FrameLoadState::setUnreachableURL):
- UIProcess/FrameLoadState.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFinishLoad):
(WebKit::WebFrameProxy::didFailLoad):
(WebKit::WebFrameProxy::didSameDocumentNavigation):
(WebKit::WebFrameProxy::setUnreachableURL):
- 3:53 PM Changeset in webkit [159254] by
-
- 3 edits in trunk/Source/WebKit2
Expose a private flag on WKView to indicate whether it's using a remote layer tree drawing area
https://bugs.webkit.org/show_bug.cgi?id=124317
Reviewed by Anders Carlsson.
Expose isUsingUISideCompositing on WKView in the private header,
which returns YES if the view is using a DrawingAreaTypeRemoteLayerTree.
- UIProcess/API/mac/WKView.mm:
(-[WKView isUsingUISideCompositing]):
- UIProcess/API/mac/WKViewPrivate.h:
- 3:36 PM Changeset in webkit [159253] by
-
- 3 edits in trunk/Source/WebKit2
Maybe the last attempt to fix the GTK build.
- UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
- UIProcess/API/gtk/WebKitContextMenuPrivate.h:
- 3:30 PM Changeset in webkit [159252] by
-
- 2 edits in trunk/Source/WebKit2
One more attempt to fix the GTK build.
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- 3:26 PM Changeset in webkit [159251] by
-
- 1 delete in tags/Safari-537.73.8/safari-537.73-branch
Remove Duplicate Tag.
- 3:25 PM Changeset in webkit [159250] by
-
- 1 delete in tags/Safari-537.73.7/safari-537.73-branch
Remove Duplicate Tag.
- 3:20 PM Changeset in webkit [159249] by
-
- 2 edits in trunk/Source/WebKit/mac
Removed deprecated download delegates.
https://bugs.webkit.org/show_bug.cgi?id=124309
<rdar://problem/13570414>
Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2013-11-13
Reviewed by Anders Carlsson.
- Misc/WebDownload.mm:
(-[WebDownloadInternal respondsToSelector:]):
Removed download:shouldBeginChildDownloadOfSource:delegate and
download:didBeginChildDownload.
- 3:18 PM Changeset in webkit [159248] by
-
- 2 edits in trunk/Source/WebKit2
Plug-in processes hang around for 10 sec after Safari quits
https://bugs.webkit.org/show_bug.cgi?id=124314
<rdar://problem/15460613>
Reviewed by Simon Fraser.
Call stopRunLoop instead of instead of RunLoop::stop().
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didClose):
- 3:11 PM Changeset in webkit [159247] by
-
- 20 edits in trunk/Source/WebKit2
URTBF after r159234.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Shared/efl/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebTouchEvent):
- UIProcess/API/C/WKGrammarDetail.cpp:
- UIProcess/API/C/efl/WKEventEfl.cpp:
- UIProcess/API/gtk/WebKitBackForwardList.cpp:
(webkitBackForwardListCreateList):
(webkitBackForwardListChanged):
(webkit_back_forward_list_get_back_list_with_limit):
(webkit_back_forward_list_get_forward_list_with_limit):
- UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
- UIProcess/API/gtk/WebKitContextMenu.cpp:
(webkitContextMenuCreate):
- UIProcess/API/gtk/WebKitContextMenuItem.cpp:
(webkitContextMenuItemCreate):
- UIProcess/API/gtk/WebKitContextMenuPrivate.h:
- UIProcess/API/gtk/WebKitCookieManager.cpp:
(webkitCookieManagerGetDomainsWithCookiesCallback):
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_get_mime_types):
(webkit_file_chooser_request_get_mime_types_filter):
(webkit_file_chooser_request_select_files):
(webkit_file_chooser_request_get_selected_files):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPopulateContextMenu):
- UIProcess/API/gtk/WebKitWebViewGroup.cpp:
(toImmutableArray):
(webkit_web_view_group_add_user_style_sheet):
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/WebGrammarDetail.cpp:
(WebKit::WebGrammarDetail::create):
(WebKit::WebGrammarDetail::WebGrammarDetail):
(WebKit::WebGrammarDetail::guesses):
- UIProcess/WebGrammarDetail.h:
- UIProcess/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::checkGrammarOfString):
(WebKit::WebTextCheckerClient::guessesForWord):
- UIProcess/efl/WebUIPopupMenuClient.cpp:
(WebUIPopupMenuClient::showPopupMenu):
- 3:10 PM Changeset in webkit [159246] by
-
- 3 edits in trunk/Source/WebCore
Remove Document::m_savedRenderView pointer.
<https://webkit.org/b/124310>
This pointer held a copy of m_renderView while the document was in
page cache, and null while it wasn't. It was not used for anything.
Reviewed by Anders Carlsson.
- 3:08 PM Changeset in webkit [159245] by
-
- 9 edits in trunk/Source/WebCore
Move setIndexKeys() to the IDBServerConnection
https://bugs.webkit.org/show_bug.cgi?id=124301
Reviewed by Anders Carlsson.
This is a big step towards moving knowledge of the backing store out of the frontend.
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::setIndexKeys):
- Modules/indexeddb/IDBServerConnection.h:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::setIndexKeys):
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::PutOperation::perform):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::makeIndexWriters):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- 3:04 PM Changeset in webkit [159244] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 2:58 PM Changeset in webkit [159243] by
-
- 63 edits in trunk/Source/WebCore
Web Inspector: Extract InspectorFrontendDispatchers from InspectorFrontend
https://bugs.webkit.org/show_bug.cgi?id=124246
Reviewed by NOBODY (OOPS!).
No new tests, this is just refactoring without changing functionality.
Set of changes made:
- Remove "class InspectorFrontend" that currently does nothing but hold sub-frontend dispatcher classes. Catches some stale code.
- Generate individual "class InspectorFooFrontendDispatcher" classes for domains that have events. Catches some unnecessary classes.
- Simplify the Base Agent interface from optional set/clearFrontend/register to required didCreateFrontendAndBackend/willDestroyFrontendAndBackend. New agents must implement this and this will be their cue to setup frontend and backend dispatchers.
- Base Agent no longer needs to be templated or have an Interface class.
- While we are changing subclass BaseAgent superclass calls, use ASCIILiteral
- In agents with events, convert "InspectorFrontend::Foo* m_frontend" to "unique_ptr<InspectorFooFrontendDispatcher> m_frontendDispatcher" and update uses as appropriate within the classes.
- In agents with events, create dispatchers in didCreateFrontendAndBackend and clear them in willDestroyFrontendAndBackend.
- inspector/CodeGeneratorInspector.py:
(Generator):
(Generator.go):
(Generator.process_event):
- inspector/CodeGeneratorInspectorStrings.py:
(InspectorFrontendChannel):
- inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::updateRepeatCountInConsole):
- inspector/ConsoleMessage.h:
- inspector/InjectedScriptHost.h:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::didCreateFrontendAndBackend):
(WebCore::InspectorAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::inspect):
- inspector/InspectorAgent.h:
(WebCore::InspectorAgent::hasFrontend):
- inspector/InspectorAgentRegistry.cpp:
(WebCore::InspectorAgentRegistry::append):
(WebCore::InspectorAgentRegistry::didCreateFrontendAndBackend):
(WebCore::InspectorAgentRegistry::willDestroyFrontendAndBackend):
- inspector/InspectorAgentRegistry.h:
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::didCreateFrontendAndBackend):
(WebCore::InspectorApplicationCacheAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
(WebCore::InspectorApplicationCacheAgent::networkStateChanged):
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorBaseAgent.h:
(WebCore::InspectorBaseAgent::discardAgent):
(WebCore::InspectorBaseAgent::InspectorBaseAgent):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorCSSAgent::mediaQueryResultChanged):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::regionOversetChanged):
(WebCore::InspectorCSSAgent::didRegisterNamedFlowContentElement):
(WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
(WebCore::InspectorCSSAgent::styleSheetChanged):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCanvasAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::frameNavigated):
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::clearMessages):
(WebCore::InspectorConsoleAgent::didCreateFrontendAndBackend):
(WebCore::InspectorConsoleAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::show):
(WebCore::InspectorController::close):
- inspector/InspectorController.h:
(WebCore::InspectorController::hasFrontend):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDOMAgent::setDocument):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::focusNode):
(WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
(WebCore::InspectorDOMAgent::didCommitLoad):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
(WebCore::InspectorDOMAgent::didModifyDOMAttr):
(WebCore::InspectorDOMAgent::didRemoveDOMAttr):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):
(WebCore::InspectorDOMAgent::characterDataModified):
(WebCore::InspectorDOMAgent::didPushShadowRoot):
(WebCore::InspectorDOMAgent::willPopShadowRoot):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMDebuggerAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMStorageAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDatabaseAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDatabaseAgent::enable):
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDatabaseResource.cpp:
(WebCore::InspectorDatabaseResource::bind):
- inspector/InspectorDatabaseResource.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDebuggerAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorDebuggerAgent::addMessageToConsole):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::scriptExecutionBlockedByCSP):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::failedToParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::didContinue):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
(WebCore::InspectorDebuggerAgent::reset):
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorHeapProfilerAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::didCreateFrontendAndBackend):
(WebCore::InspectorIndexedDBAgent::willDestroyFrontendAndBackend):
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInputAgent.cpp:
(WebCore::InspectorInputAgent::InspectorInputAgent):
(WebCore::InspectorInputAgent::didCreateFrontendAndBackend):
(WebCore::InspectorInputAgent::willDestroyFrontendAndBackend):
- inspector/InspectorInputAgent.h:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::didCreateFrontendAndBackend):
(WebCore::InspectorLayerTreeAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorLayerTreeAgent::layerTreeDidChange):
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::didCreateFrontendAndBackend):
(WebCore::InspectorMemoryAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::didCreateFrontendAndBackend):
(WebCore::InspectorPageAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):
(WebCore::InspectorPageAgent::frameNavigated):
(WebCore::InspectorPageAgent::frameDetached):
(WebCore::InspectorPageAgent::frameStartedLoading):
(WebCore::InspectorPageAgent::frameStoppedLoading):
(WebCore::InspectorPageAgent::frameScheduledNavigation):
(WebCore::InspectorPageAgent::frameClearedScheduledNavigation):
(WebCore::InspectorPageAgent::willRunJavaScriptDialog):
(WebCore::InspectorPageAgent::didRunJavaScriptDialog):
(WebCore::InspectorPageAgent::scriptsEnabled):
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
(WebCore::InspectorProfilerAgent::getHeapSnapshot):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorProfilerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorProfilerAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorProfilerAgent::takeHeapSnapshot):
(WebCore::InspectorProfilerAgent::toggleRecordButton):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didCreateFrontendAndBackend):
(WebCore::InspectorResourceAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::markResourceAsCached):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::didCreateWebSocket):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
(WebCore::InspectorResourceAgent::didSendWebSocketFrame):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrameError):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
- inspector/InspectorResourceAgent.h:
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
- inspector/InspectorRuntimeAgent.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::sendEvent):
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::dispatchMessageFromWorker):
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::didCreateFrontendAndBackend):
(WebCore::InspectorWorkerAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorWorkerAgent::enable):
(WebCore::InspectorWorkerAgent::disable):
(WebCore::InspectorWorkerAgent::didStartWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::workerGlobalScopeTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
- inspector/InspectorWorkerAgent.h:
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::didCreateFrontendAndBackend):
(WebCore::PageRuntimeAgent::willDestroyFrontendAndBackend):
(WebCore::PageRuntimeAgent::didCreateMainWorldContext):
(WebCore::PageRuntimeAgent::didCreateIsolatedContext):
(WebCore::PageRuntimeAgent::notifyContextCreated):
- inspector/PageRuntimeAgent.h:
- inspector/TimelineRecordFactory.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
- inspector/WorkerInspectorController.h:
(WebCore::WorkerInspectorController::hasFrontend):
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::didCreateFrontendAndBackend):
(WebCore::WorkerRuntimeAgent::willDestroyFrontendAndBackend):
- inspector/WorkerRuntimeAgent.h:
- inspector/protocol/Input.json:
- 2:56 PM Changeset in webkit [159242] by
-
- 1 copy in tags/Safari-537.73.8/safari-537.73-branch
New Tag.
- 2:56 PM Changeset in webkit [159241] by
-
- 1 copy in tags/Safari-537.73.8
New Tag.
- 2:52 PM Changeset in webkit [159240] by
-
- 2 edits in branches/safari-537.73-branch/LayoutTests
Change testcase to not rely on functions that are only available on trunk
- 2:25 PM Changeset in webkit [159239] by
-
- 2 edits in trunk/LayoutTests
compositing/regions/transform-transparent-positioned-video-inside-region.html is flaky on all bots
https://bugs.webkit.org/show_bug.cgi?id=124311
- platform/mac/TestExpectations:
Mark as flaky image fail.
- 2:22 PM Changeset in webkit [159238] by
-
- 5 edits in trunk/Source/WebCore
Rename FrameView's repaintFixedElementsAfterScrolling and updateFixedElementsAfterScrolling
https://bugs.webkit.org/show_bug.cgi?id=124306
Reviewed by Tim Horton.
FrameView::repaintFixedElementsAfterScrolling() didn't do any repainting, and didn't
just apply to fixed elements. Rename it to updateLayerPositionsAfterScrolling().
updateFixedElementsAfterScrolling() was also confusingly named; rename it
to updateCompositingLayersAfterScrolling().
- page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
(WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
(WebCore::FrameView::updateLayerPositionsAfterScrolling):
(WebCore::FrameView::shouldUpdateCompositingLayersAfterScrolling):
(WebCore::FrameView::updateCompositingLayersAfterScrolling):
- page/FrameView.h:
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollTo):
- platform/ScrollView.h:
(WebCore::ScrollView::updateLayerPositionsAfterScrolling):
(WebCore::ScrollView::updateCompositingLayersAfterScrolling):
- 2:19 PM Changeset in webkit [159237] by
-
- 3 edits in trunk/Source/WebCore
Generate casting helpers for SVGPaint and SVGColor.
<https://webkit.org/b/124285>
Use CSS_VALUE_TYPE_CASTS to generate type casting helpers for the
SVGPaint and SVGColor classes.
Reviewed by Anders Carlsson.
- 2:17 PM Changeset in webkit [159236] by
-
- 1 edit2 adds in trunk/Source/WebKit2
Fix build.
Not sure why these weren't added.
- Shared/APIArray.cpp: Added.
- Shared/APIArray.h: Added.
- 2:06 PM Changeset in webkit [159235] by
-
- 2 edits in trunk/Source/WebCore
Update ResourceHandleCF to use the didReceiveBuffer() callback
https://bugs.webkit.org/show_bug.cgi?id=124256
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-13
Reviewed by Alexey Proskuryakov.
Use didReceiveBuffer() instead of didReceiveData() to pass data back to
the ResourceHandleClient. This unify the update code with the NSURLConnection loader.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::didReceiveData):
(WebCore::ResourceHandle::handleDataArray):
- 2:05 PM Changeset in webkit [159234] by
-
- 84 edits2 deletes in trunk/Source/WebKit2
Rename ImmutableArray to API::Array
https://bugs.webkit.org/show_bug.cgi?id=124307
Reviewed by Andreas Kling.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(ensureObjectStream):
(-[WKRemoteObjectDecoder initWithInterface:rootObjectDictionary:WebKit::]):
- Shared/API/c/WKArray.cpp:
(WKArrayGetTypeID):
(WKArrayCreate):
(WKArrayCreateAdoptingValues):
- Shared/API/c/WKContextMenuItem.cpp:
- Shared/API/c/WKDictionary.cpp:
(WKDictionaryCopyKeys):
- Shared/API/c/WKMutableArray.cpp:
(WKMutableArrayCreate):
- Shared/API/c/WKRenderObject.cpp:
(WKRenderObjectGetChildren):
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toImpl):
- Shared/API/c/mac/WKWebArchive.cpp:
(WKWebArchiveCopySubresources):
(WKWebArchiveCopySubframeArchives):
- Shared/APIArray.cpp: Renamed from Source/WebKit2/Shared/ImmutableArray.cpp.
(API::Array::create):
(API::Array::createStringArray):
(API::Array::Array):
(API::Array::~Array):
- Shared/APIArray.h: Renamed from Source/WebKit2/Shared/ImmutableArray.h.
- Shared/Cocoa/WKNSArray.h:
(wrapper):
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray dealloc]):
(-[WKNSArray count]):
(-[WKNSArray objectAtIndex:]):
(-[WKNSArray API::]):
- Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::keys):
- Shared/ImmutableDictionary.h:
- Shared/SecurityOriginData.cpp:
(WebKit::performAPICallbackWithSecurityOriginDataVector):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebArchive.cpp:
(WebKit::WebArchive::create):
(WebKit::WebArchive::WebArchive):
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):
- Shared/WebArchive.h:
- Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::create):
(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):
- Shared/WebContextMenuItem.h:
- Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::acceptMIMETypes):
(WebKit::WebOpenPanelParameters::selectedFileNames):
- Shared/WebOpenPanelParameters.h:
- Shared/WebRenderLayer.cpp:
(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::createArrayFromLayerList):
(WebKit::WebRenderLayer::WebRenderLayer):
- Shared/WebRenderLayer.h:
(WebKit::WebRenderLayer::negativeZOrderList):
(WebKit::WebRenderLayer::normalFlowList):
(WebKit::WebRenderLayer::positiveZOrderList):
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::WebRenderObject):
(WebKit::WebRenderObject::~WebRenderObject):
- Shared/WebRenderObject.h:
(WebKit::WebRenderObject::children):
(WebKit::WebRenderObject::elementClassNames):
- UIProcess/API/C/WKBackForwardListRef.cpp:
- UIProcess/API/C/WKOpenPanelParameters.cpp:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextGetInfoForInstalledPlugIns):
- UIProcess/API/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList backListWithLimit:]):
(-[WKBackForwardList forwardListWithLimit:]):
- UIProcess/API/mac/WKBrowsingContextGroup.mm:
(createWKArray):
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::populateCopyOfNotificationPermissions):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/Notifications/WebNotificationProvider.cpp:
(WebKit::WebNotificationProvider::clearNotifications):
- UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsArray):
- UIProcess/Plugins/PlugInAutoStartProvider.h:
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::didGetSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
- UIProcess/Plugins/WebPluginSiteDataManager.h:
- UIProcess/StatisticsRequest.cpp:
(WebKit::StatisticsRequest::completedRequest):
- UIProcess/WebApplicationCacheManagerProxy.h:
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
- UIProcess/WebBackForwardList.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setPlugInAutoStartOrigins):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
- UIProcess/WebContext.h:
- UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::plugInInformationBecameAvailable):
- UIProcess/WebContextClient.h:
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
- UIProcess/WebFindClient.cpp:
(WebKit::WebFindMatchesClient::didFindStringMatches):
- UIProcess/WebFindClient.h:
- UIProcess/WebFrameProxy.h:
- UIProcess/WebKeyValueStorageManager.cpp:
(WebKit::didGetKeyValueStorageOrigins):
- UIProcess/WebKeyValueStorageManager.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didChangeBackForwardList):
- UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):
- UIProcess/WebMediaCacheManagerProxy.h:
- UIProcess/WebOpenPanelResultListenerProxy.cpp:
(WebKit::WebOpenPanelResultListenerProxy::chooseFiles):
- UIProcess/WebOpenPanelResultListenerProxy.h:
- UIProcess/WebOriginDataManagerProxy.h:
- UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
(WebKit::WebPageContextMenuClient::showContextMenu):
- UIProcess/WebPageGroup.cpp:
(WebKit::toStringVector):
(WebKit::WebPageGroup::addUserStyleSheet):
(WebKit::WebPageGroup::addUserScript):
- UIProcess/WebPageGroup.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::didFindStringMatches):
- UIProcess/WebPageProxy.h:
- UIProcess/WebResourceCacheManagerProxy.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleCopyOriginsWithApplicationCache):
- WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(contextMenuItems):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::originsWithApplicationCache):
(WebKit::toStringVector):
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
(WebKit::InjectedBundleBackForwardListItem::children):
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::findLargestFrameInFrameSet):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::childFrames):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::trackedRepaintRects):
- WebProcess/WebPage/WebPage.h:
- 1:40 PM Changeset in webkit [159233] by
-
- 26 edits24 adds1 delete in trunk/Source
Web Inspector: Split Inspector.json into individual domain json files
https://bugs.webkit.org/show_bug.cgi?id=124098
Reviewed by Timothy Hatcher.
Source/WebCore:
Split the Inspector domains into their own json file. Generate a
combined Inspector.json from all of the json files at build time
so that the CodeGenerator is unchanged.
- .gitattributes:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.py:
(TypeMap.init):
- inspector/Inspector.json: Removed.
- inspector/Scripts/generate-combined-inspector-json.py: Added.
- inspector/protocol/ApplicationCache.json: Added.
- inspector/protocol/CSS.json: Added.
- inspector/protocol/Canvas.json: Added.
- inspector/protocol/Console.json: Added.
- inspector/protocol/DOM.json: Added.
- inspector/protocol/DOMDebugger.json: Added.
- inspector/protocol/DOMStorage.json: Added.
- inspector/protocol/Database.json: Added.
- inspector/protocol/Debugger.json: Added.
- inspector/protocol/FileSystem.json: Added.
- inspector/protocol/HeapProfiler.json: Added.
- inspector/protocol/IndexedDB.json: Added.
- inspector/protocol/Input.json: Added.
- inspector/protocol/InspectorDomain.json: Added.
- inspector/protocol/LayerTree.json: Added.
- inspector/protocol/Memory.json: Added.
- inspector/protocol/Network.json: Added.
- inspector/protocol/Page.json: Added.
- inspector/protocol/Profiler.json: Added.
- inspector/protocol/Runtime.json: Added.
- inspector/protocol/Timeline.json: Added.
- inspector/protocol/Worker.json: Added.
Source/WebInspectorUI:
Removed now stale comments referring to the combined Inspector.json.
Make update-InspectorBackendCommands helper script generate a
combined Inspector.json to still work for tip of tree.
- Scripts/update-InspectorBackendCommands.rb:
- UserInterface/ApplicationCacheObserver.js:
- UserInterface/CSSObserver.js:
- UserInterface/CanvasObserver.js:
- UserInterface/ConsoleObserver.js:
- UserInterface/DOMObserver.js:
- UserInterface/DOMStorageObserver.js:
- UserInterface/DatabaseObserver.js:
- UserInterface/DebuggerObserver.js:
- UserInterface/InspectorBackendCommands.js:
- UserInterface/InspectorObserver.js:
- UserInterface/LayerTreeObserver.js:
- UserInterface/NetworkObserver.js:
- UserInterface/PageObserver.js:
- UserInterface/ProfilerObserver.js:
- UserInterface/Resource.js:
- UserInterface/RuntimeObserver.js:
- UserInterface/TimelineObserver.js:
- 1:33 PM Changeset in webkit [159232] by
-
- 2 edits in trunk/LayoutTests
Remove a crash expectation from a test that seems fixed by r159218.
- platform/mac/TestExpectations:
- 1:28 PM Changeset in webkit [159231] by
-
- 3 edits in trunk/Source/WebCore
Code cleanup: change FrameView::doLayoutWithFrameFlattening() to make it more explicit.
https://bugs.webkit.org/show_bug.cgi?id=124238
Reviewed by Simon Fraser.
Rename doLayoutWithFrameFlattening() and change its signature so that it's inline with
what it does.
Covered by existing tests.
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::startLayoutAtMainFrameViewIfNeeded):
- page/FrameView.h:
- 1:26 PM Changeset in webkit [159230] by
-
- 11 edits1 add in trunk
Modifying RTCSessionDescription object construction to match the spec
https://bugs.webkit.org/show_bug.cgi?id=124212
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-13
Reviewed by Eric Carlson.
According to the spec the RTCSessionDescriptionInit parameter in RTCSessionDescription constructor is optional,
which must not be nullable. If the 'type' and/or 'sdp' keys are not present, the string object that stores
them in the RTCSessionDescription class, must be null in those cases. Also, if an object that is not a
Dictionary is passed as argument to the constructor, an exception must be raised.
Source/WebCore:
Existing test was updated.
- GNUmakefile.list.am:
- Modules/mediastream/RTCSessionDescription.cpp:
(WebCore::RTCSessionDescription::create):
- Modules/mediastream/RTCSessionDescription.idl:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSRTCSessionDescriptionCustom.cpp: Added.
(WebCore::JSRTCSessionDescriptionConstructor::constructJSRTCSessionDescription):
LayoutTests:
- fast/mediastream/RTCSessionDescription-expected.txt:
- fast/mediastream/RTCSessionDescription.html:
- 1:26 PM Changeset in webkit [159229] by
-
- 2 edits2 deletes in trunk/Source/WebKit2
[GTK] Fix build after r159222
https://bugs.webkit.org/show_bug.cgi?id=124305
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-13
Reviewed by Tim Horton.
WebGraphicsContext and its API has been removed.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Shared/API/c/gtk/WKGraphicsContextGtk.cpp: Removed.
- Shared/API/c/gtk/WKGraphicsContextGtk.h: Removed.
- 1:22 PM Changeset in webkit [159228] by
-
- 2 edits in trunk/Source/WebKit2
Remove redundant return after r159173
https://bugs.webkit.org/show_bug.cgi?id=124303
Reviewed by Geoff Garen.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously):
Remove redundant return.
- 12:58 PM Changeset in webkit [159227] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed EFL build fix after r159222.
- CMakeLists.txt:
- 12:54 PM Changeset in webkit [159226] by
-
- 2 edits in trunk/Source/WebCore
Fix release build after r159224.
- WebCore.exp.in:
- 12:44 PM Changeset in webkit [159225] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix debug build.
- 12:44 PM Changeset in webkit [159224] by
-
- 4 edits in trunk/Source/WebCore
Remove ChromeClient::paintCustomOverhangArea
https://bugs.webkit.org/show_bug.cgi?id=124304
Reviewed by Beth Dakin.
This function always returns false now; get rid of it.
- page/Chrome.cpp:
- page/ChromeClient.h:
- page/FrameView.cpp:
(WebCore::FrameView::paintOverhangAreas):
- 12:30 PM Changeset in webkit [159223] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 12:29 PM Changeset in webkit [159222] by
-
- 6 edits6 deletes in trunk/Source/WebKit2
Remove WebGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=124302
Reviewed by Dan Bernstein.
WebGraphicsContext and its API "object", WKGraphicsContextRef was only used
for the overhang paint callback which has been removed.
- Shared/API/c/WKDeprecatedFunctions.cpp:
(WKGraphicsContextGetCGContext):
- Shared/API/c/WKGraphicsContext.cpp: Removed.
- Shared/API/c/WKGraphicsContext.h: Removed.
- Shared/API/c/cg/WKGraphicsContextCG.cpp: Removed.
- Shared/API/c/cg/WKGraphicsContextCG.h: Removed.
- Shared/APIObject.h:
- Shared/WebGraphicsContext.cpp: Removed.
- Shared/WebGraphicsContext.h: Removed.
- UIProcess/API/C/WebKit2_C.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- 12:29 PM Changeset in webkit [159221] by
-
- 1 copy in tags/Safari-537.73.7/safari-537.73-branch
New Tag.
- 12:29 PM Changeset in webkit [159220] by
-
- 1 copy in tags/Safari-537.73.7
New Tag.
- 12:23 PM Changeset in webkit [159219] by
-
- 7 edits in trunk
[MathML] The double bar vertical delimiter does not stretch properly
https://bugs.webkit.org/show_bug.cgi?id=123543
Reviewed by Chris Fleizach.
Source/WebCore:
- rendering/mathml/RenderMathMLOperator.cpp: Add stretching support for U+2225, which
is another version of the vertical bar.
LayoutTests:
- mathml/presentation/mo-stretch.html: Add ∥ to this test,
which covers the other version of the vertical bar.
- platform/gtk/mathml/presentation/mo-stretch-expected.png:
- platform/gtk/mathml/presentation/mo-stretch-expected.txt:
- 12:03 PM Changeset in webkit [159218] by
-
- 3 edits in trunk/Source/WebCore
ASSERTION FAILED: m_repaintRect == renderer().clippedOverflowRectForRepaint(renderer().containerForRepaint()) after r135816
https://bugs.webkit.org/show_bug.cgi?id=103432
Reviewed by Dave Hyatt.
RenderLayer caches repaint rects in m_repaintRect, and on updating layer
positions after scrolling, asserts that the cached rect is correct. However,
this assertion would sometimes fail if we were scrolling as a result of
doing adjustViewSize() in the middle of layout, because we haven't updated
layer positions post-layout yet.
Fix by having the poorly named FrameView::repaintFixedElementsAfterScrolling()
skip the layer updating if this FrameView is inside of adjusetViewSize() in
layout.
In order to know if we're inside view size adjusting, add a LayoutPhase
member to FrameView, replacing two existing bools that track laying out state.
Investigative work showed that there are many, many ways to re-enter FrameView::layout(),
which makes it hard (but desirable) to more assertions about state changes, but
indicated that saving and restoring the state (via TemporaryChange<LayoutPhase>)
was a good idea.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::layout):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
- page/FrameView.h:
- 12:03 PM Changeset in webkit [159217] by
-
- 2 edits in trunk/Source/WebKit2
WKArrayIsMutable should not be mangled
https://bugs.webkit.org/show_bug.cgi?id=124299
Reviewed by Andreas Kling.
- Shared/API/c/WKDeprecatedFunctions.cpp:
- 12:01 PM Changeset in webkit [159216] by
-
- 2 edits in trunk/Source/JavaScriptCore
r159210 added a period where there previously wasn't one, breaking >100 tests
Rubber-stamped by Oliver Hunt.
- parser/Parser.cpp:
(JSC::::logError):
Remove the extra period.
- 11:54 AM Changeset in webkit [159215] by
-
- 10 edits in trunk/LayoutTests
[Windows] Unreviewed gardening of some canvas tests.
- platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt:
- platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt:
- platform/win/fast/canvas/canvas-render-layer-expected.txt:
- platform/win/fast/canvas/canvas-scale-shadowBlur-expected.txt:
- platform/win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt:
- platform/win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt:
- platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt:
- platform/win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt:
- platform/win/fast/forms/range/slider-mouse-events-expected.txt:
- 11:44 AM Changeset in webkit [159214] by
-
- 3 edits in trunk/Source/WebCore
Delete unused TextPainter function
https://bugs.webkit.org/show_bug.cgi?id=124292
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-11-13
Reviewed by Tim Horton.
New tests are unnecessary since there is no behavior change
- rendering/TextPainter.cpp:
(WebCore::TextPainter::paintText):
- rendering/TextPainter.h:
- 11:33 AM Changeset in webkit [159213] by
-
- 25 edits in trunk/Source/WebCore
Check WebCrypto parameter types when casting
https://bugs.webkit.org/show_bug.cgi?id=124297
Reviewed by Sam Weinig.
Also changed existing toCryptoXXX functions to use TYPE_CASTS_BASE mechanism.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
And sure enough, there was a bug caught by the added checks.
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
- crypto/CryptoAlgorithmParameters.h:
(WebCore::CryptoAlgorithmParameters::ENUM_CLASS):
(WebCore::CryptoAlgorithmParameters::parametersClass):
- crypto/CryptoKey.h:
- crypto/CryptoKeyData.h:
- crypto/CryptoKeySerialization.h:
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::generateKey):
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::generateKey):
(WebCore::CryptoAlgorithmHMAC::importKey):
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::generateKey):
- crypto/keys/CryptoKeyAES.h:
- crypto/keys/CryptoKeyDataOctetSequence.h:
(WebCore::isCryptoKeyDataOctetSequence):
- crypto/keys/CryptoKeyDataRSAComponents.h:
(WebCore::isCryptoKeyDataRSAComponents):
- crypto/keys/CryptoKeyHMAC.h:
- crypto/keys/CryptoKeyRSA.h:
- crypto/keys/CryptoKeySerializationRaw.h:
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
- crypto/parameters/CryptoAlgorithmAesCbcParams.h:
- crypto/parameters/CryptoAlgorithmAesKeyGenParams.h:
- crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
- crypto/parameters/CryptoAlgorithmHmacParams.h:
- crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h:
- crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h:
- crypto/parameters/CryptoAlgorithmRsaSsaParams.h:
- 11:23 AM Changeset in webkit [159212] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Remove failure tests expectations after r159116.
- platform/efl/TestExpectations:
- 11:19 AM Changeset in webkit [159211] by
-
- 4 edits in trunk
crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html is failing on Maverics release bot
https://bugs.webkit.org/show_bug.cgi?id=124280
Reviewed by Anders Carlsson.
Source/WebCore:
- crypto/mac/CryptoKeyRSAMac.cpp: (WebCore::CryptoKeyRSA::buildAlgorithmDescription):
Don't be a muppet, initialize your variables.
LayoutTests:
- TestExpectations: Unskip.
- 11:12 AM Changeset in webkit [159210] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION (r158014): Many webpages throw stack overflow exceptions on iOS (because Parser::parseMemberExpression uses ~130K more stack)
https://bugs.webkit.org/show_bug.cgi?id=124177
Reviewed by Michael Saboff.
This patch pushes error handling into NEVER_INLINE functions to perform
the actual error message construction. This dramatically reduces the
stack usage of the Parser. For the large functions (such as parseMemberExpression)
the improvement is on the order of 2.5x reduction in stack usage. For
smaller functions the reduction is in the order of 5-6x.
- parser/Parser.cpp:
(JSC::::logError):
- parser/Parser.h:
- 10:51 AM Changeset in webkit [159209] by
-
- 4 edits in trunk/Source/WebKit2
Move provisional load state handling to FrameLoadState
https://bugs.webkit.org/show_bug.cgi?id=124291
Reviewed by Dan Bernstein.
- UIProcess/FrameLoadState.cpp:
(WebKit::FrameLoadState::didStartProvisionalLoad):
(WebKit::FrameLoadState::didReceiveServerRedirectForProvisionalLoad):
(WebKit::FrameLoadState::didFailProvisionalLoad):
- UIProcess/FrameLoadState.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameProxy::didFailProvisionalLoad):
- 10:30 AM Changeset in webkit [159208] by
-
- 13 edits2 adds in trunk
Add support for HTMLMediaElement.fastSeek()
https://bugs.webkit.org/show_bug.cgi?id=124262
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-fast-seek.html
Add the fastSeek() method to HTMLMediaElement, and use fastSeek() in
the JavaScript media controls.
Add the new fastSeek() method:
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::fastSeek): Call seekWithTolerance.
(HTMLMediaElement::seek): Call seekWithTolerance with 0 tolerance.
(HTMLMediaElement::seekWithTolerance): Renamed from seek().
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
Add seekWithTolerance() to MediaPlayer:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::seekWithTolerance): Pass to MediaPlayerPrivate.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::seekWithTolerance): Default implementation which
calls seek().
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::seek): Call seekWithTolerance with 0 tolerance.
(WebCore::MediaPlayerPrivateAVFoundation::seekWithTolerance): Renamed from seek().
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): Take tolerance parameters.
Use the new fastSeek() method while actively scrubbing.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls): Add mouse up and down handlers.
(Controller.prototype.handleTimeUpdate): Only update the timeline when not scrubbing.
(Controller.prototype.handleTimelineChange): Use fastSeek().
(Controller.prototype.handleTimelineMouseDown): Start scrubbing.
(Controller.prototype.handleTimelineMouseUp): Stop scrubbing.
LayoutTests:
- media/video-fast-seek-expected.txt: Added.
- media/video-fast-seek.html: Added.
- 10:17 AM Changeset in webkit [159207] by
-
- 5 edits in trunk/Source/WebCore
Generate casting helpers for scrolling tree classes.
<https://webkit.org/b/124286>
Added SCROLLING_STATE_NODE_TYPE_CASTS and used it to replace the
hand-written toFoo() casts for ScrollingStateNode subclasses.
Reviewed by Anders Carlsson.
- 9:59 AM Changeset in webkit [159206] by
-
- 3 edits in trunk/Source/WebKit2
One more fix after r159197.
- UIProcess/efl/EwkTouchEvent.h:
- UIProcess/efl/EwkTouchPoint.h:
- 9:47 AM Changeset in webkit [159205] by
-
- 4 edits in trunk/Source/WebCore
[CSS Shapes] Determining if a line is inside of a shape should only happen in one place
https://bugs.webkit.org/show_bug.cgi?id=121708
Reviewed by Andreas Kling.
The ShapeInfo::lineOverlapsShapeBounds() methods now delegate to the Shape object. The
logic for the Shape overlap test is now the same for ShapeInsideInfo and ShapeOutsideInfo.
No new tests, this is just a refactoring of existing code.
- rendering/shapes/Shape.h:
(WebCore::Shape::lineOverlapsShapeMarginBounds): Apply lineOverlapsLayoutRect() to the shape-margin bounds LayoutRect.
(WebCore::Shape::lineOverlapsShapePaddingBounds): Apply lineOverlapsLayoutRect() to the shape-padding bounds LayoutRect.
(WebCore::Shape::lineOverlapsLayoutRect): The common code for checking if a line and a LayoutRect overlap.
- rendering/shapes/ShapeInsideInfo.h: Use lineOverlapsShapePaddingBounds() for lineOverlapShapeBounds().
- rendering/shapes/ShapeOutsideInfo.h: Use lineOverlapsShapeMarginBounds() for lineOverlapShapeBounds().
- 9:43 AM Changeset in webkit [159204] by
-
- 14 edits in trunk/Source/WebKit2
[Gtk][EFL] Fix builds by updating Object::TypeX to Object::Type::X
https://bugs.webkit.org/show_bug.cgi?id=124289
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-13
Reviewed by Alexey Proskuryakov.
- Shared/API/c/WKContextMenuItem.cpp:
(WKContextMenuItemGetTypeID):
- Shared/WebBatteryStatus.h:
- Shared/WebNetworkInfo.h:
- UIProcess/API/C/WKGrammarDetail.cpp:
(WKGrammarDetailGetTypeID):
- UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerGetTypeID):
- UIProcess/CoordinatedGraphics/WebView.h:
- UIProcess/WebBatteryManagerProxy.h:
- UIProcess/WebNetworkInfoManagerProxy.h:
- UIProcess/WebTextChecker.h:
- UIProcess/WebVibrationProxy.h:
- UIProcess/WebViewportAttributes.h:
- UIProcess/efl/WebPopupItemEfl.h:
- UIProcess/soup/WebSoupRequestManagerProxy.h:
- 9:39 AM Changeset in webkit [159203] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Protect repatchCompact from flushConstantPool.
https://bugs.webkit.org/show_bug.cgi?id=124278
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-13
Reviewed by Michael Saboff.
Random crashes may occur with sh4 architecture, when a flushConstantPool occurs in
movlMemRegCompact. As in this case a branch opcode and the constant pool are put
before the movlMemRegCompact, the branch itself is patched when calling repatchCompact
instead of the mov instruction, which is really bad.
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::repatchCompact): Handle this specific case and add an ASSERT.
- 9:35 AM Changeset in webkit [159202] by
-
- 5 edits in trunk
Add a Vector constructor that takes an std::initializer_list
https://bugs.webkit.org/show_bug.cgi?id=124287
Reviewed by Antti Koivisto.
Source/WTF:
- wtf/Compiler.h:
- wtf/Vector.h:
(WTF::Vector::Vector):
Tools:
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
- 9:26 AM Changeset in webkit [159201] by
-
- 7 edits in trunk/Source/WebKit2
Remove prefixed template class processing from message receiver generator.
https://bugs.webkit.org/show_bug.cgi?id=123095
Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-11-13
Reviewed by Anders Carlsson.
There was a FIXME in messages.py to remove unprefixed WTF template classes,
but in the discussion of the bug report we concluded that in the messages.in
files we should follow the C++ naming convention where none of the WTF
classes require the WTF prefix.
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- Scripts/webkit2/messages.py:
(class_template_headers):
- Scripts/webkit2/messages_unittest.py:
(std):
- UIProcess/Storage/StorageManager.messages.in:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.messages.in:
- 9:13 AM Changeset in webkit [159200] by
-
- 3 edits in trunk/Source/WebKit2
URTBF after r159199 to make cmake and GTK build happy.
- CMakeLists.txt:
- GNUmakefile.list.am:
- 9:01 AM Changeset in webkit [159199] by
-
- 4 edits1 copy in trunk/Source/WebKit2
Add WKDeprecatedFunctions.cpp and move WKArrayIsMutable there
https://bugs.webkit.org/show_bug.cgi?id=124284
Reviewed by Andreas Kling.
- Shared/API/c/WKDeprecatedFunctions.cpp: Copied from Source/WebKit2/Shared/API/c/WKMutableArray.h.
(WKArrayIsMutable):
- Shared/API/c/WKMutableArray.cpp:
- Shared/API/c/WKMutableArray.h:
- WebKit2.xcodeproj/project.pbxproj:
- 8:23 AM Changeset in webkit [159198] by
-
- 3 edits in trunk/Source/WebCore
Restrict UserGestureIndicator to main thread
https://bugs.webkit.org/show_bug.cgi?id=124277
Reviewed by Andreas Kling.
Certain classes that interact with UserGestureIndicators, e.g.
the DOMTimer, can also live on worker threads. Since a
background thread cannot possible get a user gesture in the
first place, and to avoid races, we turn a UserGestureIndicator
on a background thread into a no-op.
- dom/UserGestureIndicator.cpp:
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::~UserGestureIndicator):
(WebCore::UserGestureIndicator::processingUserGesture):
- dom/UserGestureIndicator.h:
- 8:19 AM Changeset in webkit [159197] by
-
- 84 edits in trunk/Source/WebKit2
API::Object::Type should be a strongly typed enum
https://bugs.webkit.org/show_bug.cgi?id=124258
Reviewed by Tim Horton.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _handleMessageWithName:body:]):
- Shared/APIObject.h:
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
- Shared/ImmutableArray.h:
- Shared/ImmutableDictionary.h:
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebArchive.h:
- Shared/WebArchiveResource.h:
- Shared/WebBackForwardListItem.h:
- Shared/WebCertificateInfo.h:
- Shared/WebConnection.h:
- Shared/WebContextMenuItem.h:
- Shared/WebData.h:
- Shared/WebError.h:
- Shared/WebGeolocationPosition.h:
- Shared/WebGeometry.h:
- Shared/WebGraphicsContext.h:
- Shared/WebHitTestResult.h:
- Shared/WebImage.h:
- Shared/WebNumber.h:
- Shared/WebOpenPanelParameters.h:
- Shared/WebRenderLayer.h:
- Shared/WebRenderObject.h:
- Shared/WebSecurityOrigin.h:
- Shared/WebSerializedScriptValue.h:
- Shared/WebString.h:
- Shared/WebURL.h:
- Shared/WebURLRequest.h:
- Shared/WebURLResponse.h:
- Shared/WebUserContentURLPattern.h:
- Shared/mac/ObjCObjectGraph.h:
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
- UIProcess/Authentication/AuthenticationDecisionListener.h:
- UIProcess/Authentication/WebCredential.h:
- UIProcess/Authentication/WebProtectionSpace.h:
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/GeolocationPermissionRequestProxy.h:
- UIProcess/Notifications/NotificationPermissionRequest.h:
- UIProcess/Notifications/WebNotification.h:
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/Plugins/WebPluginSiteDataManager.h:
- UIProcess/WebApplicationCacheManagerProxy.h:
- UIProcess/WebBackForwardList.h:
- UIProcess/WebColorPickerResultListenerProxy.h:
- UIProcess/WebContext.h:
- UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebDatabaseManagerProxy.h:
- UIProcess/WebEditCommandProxy.h:
- UIProcess/WebFormSubmissionListenerProxy.h:
- UIProcess/WebFramePolicyListenerProxy.h:
- UIProcess/WebFrameProxy.h:
- UIProcess/WebGeolocationManagerProxy.h:
- UIProcess/WebGrammarDetail.h:
- UIProcess/WebIconDatabase.h:
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebKeyValueStorageManager.h:
- UIProcess/WebMediaCacheManagerProxy.h:
- UIProcess/WebNavigationData.h:
- UIProcess/WebOpenPanelResultListenerProxy.h:
- UIProcess/WebOriginDataManagerProxy.h:
- UIProcess/WebPageGroup.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPreferences.h:
- UIProcess/WebResourceCacheManagerProxy.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
- WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::load):
- WebProcess/WebPage/PageBanner.h:
- WebProcess/WebPage/PageOverlay.h:
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPageGroupProxy.h:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
- 8:10 AM Changeset in webkit [159196] by
-
- 6 edits in trunk/Source/WebKit2
Remove custom overhang area painting code
https://bugs.webkit.org/show_bug.cgi?id=124282
Reviewed by Andreas Kling.
This code was only used by the Mac port, to draw the linen background color on Lion.
We now do that on the GPU instead so get rid of this code.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 8:06 AM Changeset in webkit [159195] by
-
- 3 edits in branches/safari-537.73-branch/Source/WebCore
<rdar://problem/15292359>
Fix incorrect merge of r157299 made in r158605.
- platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::removeClient): Remember to remove clients
from m_clientsToBeNotified.
- platform/graphics/DisplayRefreshMonitor.h: Might as well make the code
more consistent with ToT while I'm here.
- 7:34 AM Changeset in webkit [159194] by
-
- 2 edits in trunk/Source/WebCore
Factor simple line creation loop to function
https://bugs.webkit.org/show_bug.cgi?id=124279
Reviewed by Andreas Kling.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::Style::Style):
Capture style that affects line layout to a struct.
(WebCore::SimpleLineLayout::textWidth):
(WebCore::SimpleLineLayout::measureWord):
(WebCore::SimpleLineLayout::createLineRuns):
Factor the line loop here.
(WebCore::SimpleLineLayout::createTextRuns):
- 7:32 AM Changeset in webkit [159193] by
-
- 2 edits in trunk/LayoutTests
- TestExpectations: Skip crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html
- 5:25 AM Changeset in webkit [159192] by
-
- 12 edits8 adds in trunk
Support overflow-wrap:break-word on simple line path
https://bugs.webkit.org/show_bug.cgi?id=124206
Source/WebCore:
Reviewed by Andreas Kling.
Pure text documents are rendered with break-word. It is also common in discussion board type sites.
This also makes many <textarea>'s rendered using the simple line path.
Tests: fast/forms/basic-textareas-quirks-simple-lines.html
fast/forms/linebox-overflow-in-textarea-padding-simple-lines.html
fast/forms/negativeLineHeight-simple-lines.html
fast/forms/textAreaLineHeight-simple-lines.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateShapeInsideInfoAfterStyleChange):
(WebCore::RenderBlock::markShapeInsideDescendantsForLayout):
Invalidate the cached line layout mode on shape-inside style change.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::createTextRuns):
LayoutTests:
Reviewed by Andreas Kling.
Force these to use line boxes, add ref test versions comparing the paths.
- fast/forms/basic-textareas-quirks-simple-lines-expected.html: Added.
- fast/forms/basic-textareas-quirks-simple-lines.html: Added.
- fast/forms/basic-textareas-quirks.html:
- fast/forms/linebox-overflow-in-textarea-padding-simple-lines-expected.html: Added.
- fast/forms/linebox-overflow-in-textarea-padding-simple-lines.html: Added.
- fast/forms/linebox-overflow-in-textarea-padding.html:
- fast/forms/negativeLineHeight-simple-lines-expected.html: Added.
- fast/forms/negativeLineHeight-simple-lines.html: Added.
- fast/forms/negativeLineHeight.html:
- fast/forms/textAreaLineHeight-simple-lines-expected.html: Added.
- fast/forms/textAreaLineHeight-simple-lines.html: Added.
- fast/forms/textAreaLineHeight.html:
- fast/parser/entity-comment-in-textarea.html: Made this independent of line layout mode.
- fast/replaced/width100percent-textarea.html:
- platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
- 5:17 AM Changeset in webkit [159191] by
-
- 5 edits in trunk/Source/WebCore
Turn some not-so-rare ElementRareData bits into Node flags.
<https://webkit.org/b/124275>
The following 4 bits seem to be the most commonly set:
- childrenAffectedByHover()
- childrenAffectedByFirstChildRules()
- childrenAffectedByLastChildRules()
- childrenAffectedByDirectAdjacentRules()
Turning them into Node flags means we don't have to allocate full
ElementRareData object in many cases. I also took this opportunity
to make Node's flag twiddling functions available to subclasses.
1.38 MB progression on HTML5-8266 locally.
Reviewed by Antti Koivisto.
- 4:42 AM Changeset in webkit [159190] by
-
- 43 edits in trunk/Source/WebKit2
[EFL][WK2] Convert some more OwnPtr/PassOwnPtr to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=124241
Patch by Sergio Correia <Sergio Correia> on 2013-11-13
Reviewed by Gyuyoung Kim.
The modified files are located under UIProcess/{efl,API/efl}.
- UIProcess/API/efl/EwkView.cpp:
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/GestureRecognizer.cpp:
- UIProcess/API/efl/GestureRecognizer.h:
- UIProcess/API/efl/ewk_back_forward_list_private.h:
- UIProcess/API/efl/ewk_color_picker_private.h:
- UIProcess/API/efl/ewk_context.cpp:
- UIProcess/API/efl/ewk_context_menu.cpp:
- UIProcess/API/efl/ewk_context_menu_item.cpp:
- UIProcess/API/efl/ewk_context_menu_item_private.h:
- UIProcess/API/efl/ewk_context_private.h:
- UIProcess/API/efl/ewk_cookie_manager.cpp:
- UIProcess/API/efl/ewk_cookie_manager_private.h:
- UIProcess/API/efl/ewk_database_manager_private.h:
- UIProcess/API/efl/ewk_favicon_database_private.h:
- UIProcess/API/efl/ewk_popup_menu.cpp:
- UIProcess/API/efl/ewk_popup_menu_item_private.h:
- UIProcess/API/efl/ewk_popup_menu_private.h:
- UIProcess/API/efl/ewk_settings_private.h:
- UIProcess/API/efl/ewk_storage_manager.cpp:
- UIProcess/API/efl/ewk_storage_manager_private.h:
- UIProcess/API/efl/ewk_view.cpp:
- UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
- UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
- UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
- UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
- UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
- UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
- UIProcess/efl/ContextHistoryClientEfl.h:
- UIProcess/efl/ContextMenuClientEfl.h:
- UIProcess/efl/DownloadManagerEfl.h:
- UIProcess/efl/FindClientEfl.h:
- UIProcess/efl/FormClientEfl.h:
- UIProcess/efl/PageLoadClientEfl.h:
- UIProcess/efl/PagePolicyClientEfl.h:
- UIProcess/efl/PageUIClientEfl.h:
- UIProcess/efl/PageViewportControllerClientEfl.h:
- UIProcess/efl/RequestManagerClientEfl.h:
- UIProcess/efl/VibrationClientEfl.cpp:
- UIProcess/efl/VibrationClientEfl.h:
- UIProcess/efl/ViewClientEfl.h:
- 4:26 AM Changeset in webkit [159189] by
-
- 2 edits in trunk/PerformanceTests
This was supposed to test overflow-wrap:break-word instead of word-break:break-all.
Rubber-stamped by Andreas Kling.
- Layout/line-layout-simple.html:
- 3:59 AM Changeset in webkit [159188] by
-
- 15 edits in trunk/Source/WebCore
Cleanup the build from unused parameters in WebCore
https://bugs.webkit.org/show_bug.cgi?id=124199.
Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-13
Reviewed by Csaba Osztrogonác.
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
- dom/Document.cpp:
(WebCore::Document::scriptedAnimationControllerSetThrottled):
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL):
- html/HTMLAnchorElement.cpp:
(WebCore::shouldProhibitLinks):
- html/parser/XSSAuditor.cpp:
(WebCore::isSemicolonSeparatedAttribute):
- inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::preflightFailure):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::animate):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
- platform/graphics/WidthIterator.cpp:
(WebCore::applyFontTransforms):
- rendering/RenderView.cpp:
(WebCore::RenderView::setIsInWindow):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
(WebCore::RenderStyle::changeRequiresLayerRepaint):
(WebCore::RenderStyle::changeRequiresRecompositeLayer):
- testing/Internals.cpp:
(WebCore::Internals::setHeaderHeight):
(WebCore::Internals::setCaptionsStyleSheetOverride):
- 3:51 AM Changeset in webkit [159187] by
-
- 6 edits in trunk/Source/WebCore
Refalize CSSCursorImageValue.
<https://webkit.org/b/124272>
Make CSSCursorImageValue constructor return a PassRef, and have it
take the image CSSValue as a PassRef (and store it internally in a
Ref<CSSValue>.)
Had to add a Ref version of compareCSSValuePtr() to make this work.
Reviewed by Antti Koivisto.
- 3:46 AM Changeset in webkit [159186] by
-
- 2 edits in trunk/Source/WebCore
RenderTableSection: Cell structures don't need allocation padding.
<https://webkit.org/b/124263>
The row structure data gets shrunk-to-fit once we get to layout,
but per-row cell structures get no such luxury. Fortuntely we know
ahead of time how many cells a row needs to accomodate, so we can
just use Vector::resizeToFit() instead of Vector::grow().
1.25 MB progression on HTML5-8266 locally.
Reviewed by Antti Koivisto.
- 3:45 AM Changeset in webkit [159185] by
-
- 2 edits in trunk/Source/WebCore
Avoid unnecessarily padding the FontDescription families vector.
<https://webkit.org/b/124267>
Use a bit of reserveInitialCapacity+uncheckedAppend grease to avoid
jumping all the way to capacity=16 when a style has more than just
a single font-family in it.
130 kB progression on HTML5-8266 locally.
Reviewed by Antti Koivisto.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyFontFamily::applyValue):
- 3:38 AM Changeset in webkit [159184] by
-
- 3 edits in trunk/Source/WebCore
Make remaining CSSPrimitiveValue constructors return PassRef.
<https://webkit.org/b/124270>
..and same with the corresponding CSSValuePool functions.
Reviewed by Antti Koivisto.
- 3:25 AM Changeset in webkit [159183] by
-
- 1 edit2 deletes in trunk/LayoutTests
Removing fast/mediastream/constructors.html LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=124259
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-13
Reviewed by Philippe Normand.
Apart from being wrong, it was testing the mediastream WebRTC objects constructors, which are already being
tested in each particular mediastream WebRTC object LayoutTest.
- fast/mediastream/constructors-expected.txt: Removed.
- fast/mediastream/constructors.html: Removed.
- 3:07 AM Changeset in webkit [159182] by
-
- 2 edits in trunk/Tools
Unreviewed GTK gardening. Updated rebaseline unit tests to include WK2 bot.
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory): Updated.
- 2:02 AM Changeset in webkit [159181] by
-
- 17 edits in trunk/Tools
[ATK] Support compilation of EFL/GTK without accessibility
https://bugs.webkit.org/show_bug.cgi?id=122448
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-13
Reviewed by Chris Fleizach.
Added missing HAVE(ACCESSIBILITY) guards and stubs to ATK's related files,
so that in case of turning off the HAVE_ACCESSIBILITY macro EFL/GTK would compile properly.
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/atk/AccessibilityCallbacks.h:
- DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
- DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::rootElement):
(WTR::AccessibilityController::focusedElement):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
- WebKitTestRunner/PlatformEfl.cmake:
- 1:31 AM Changeset in webkit [159180] by
-
- 21 edits7 copies7 adds in trunk
Implement key generation and JWK import for RSASSA-PKCS1-v1_5
https://bugs.webkit.org/show_bug.cgi?id=124236
Reviewed by Sam Weinig.
Source/WebCore:
Tests: crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html
crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSCryptoAlgorithmBuilder.cpp:
(WebCore::JSCryptoAlgorithmBuilder::add):
- bindings/js/JSCryptoAlgorithmBuilder.h:
- crypto/CryptoAlgorithmDescriptionBuilder.h:
Added a way to add an Uint8Array, as needed for RSA key.algorithm.publicExponent.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createAesCbcParams): Removed unneeded JSC prefixes.
(WebCore::createAesKeyGenParams): Ditto.
(WebCore::createHmacParams): Ditto.
(WebCore::createHmacKeyParams): Ditto.
(WebCore::createRsaKeyGenParams): Added.
(WebCore::createRsaSsaKeyParams): Added. WebCrypto currently doesn't specify any
parameters for importKey, so the structure remains blank (unlike with JWK).
(WebCore::createRsaSsaParams): Added (currently unused, will be sued for sign/verify soon).
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt): Removed unneeded JSC prefixes.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign): Added support for RSAES_PKCS1_v1_5.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest): Removed unneeded JSC prefixes.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey): Added support for RSAES_PKCS1_v1_5.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey): Removed unneeded JSC prefixes.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForWrapKey): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForUnwrapKey): Ditto.
- bindings/js/JSCryptoKeySerializationJWK.h:
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::getJSArrayFromJSON): Added.
(WebCore::getBigIntegerVectorFromJSON): Added.
(WebCore::createRSASSAKeyParameters): Create parameters for key import. The key
will remember which algorithm it's allowed to be used with.
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm): Added support for
RS256...RS512 (tha is, RSAES_PKCS1_v1_5 with SHA-256...SHA-512).
(WebCore::JSCryptoKeySerializationJWK::keyDataOctetSequence): Split out of keyData().
(WebCore::JSCryptoKeySerializationJWK::keyDataRSAComponents): Added code to read
RSA key components from JWK.
(WebCore::JSCryptoKeySerializationJWK::keyData): Call one of the above functions.
- crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Added.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
Placeholders.
- crypto/CryptoKey.h: (WebCore::CryptoKeyClass): Added RSA key class for poor man's RTTI.
- crypto/CryptoKeyData.h: (WebCore::CryptoKeyData::FormatRSAComponents): Added RSAComponents
for poor man's RTTI.
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp: (WebCore::CryptoAlgorithmAES_CBC::importKey):
- crypto/algorithms/CryptoAlgorithmHMAC.cpp: (WebCore::CryptoAlgorithmHMAC::importKey):
- crypto/keys/CryptoKeyAES.h:
(WebCore::isCryptoKeyAES):
(WebCore::toCryptoKeyAES):
- crypto/keys/CryptoKeyDataOctetSequence.h:
(WebCore::toCryptoKeyDataOctetSequence):
- crypto/keys/CryptoKeyHMAC.h:
(WebCore::isCryptoKeyHMAC):
(WebCore::toCryptoKeyHMAC):
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
Switched from "as" functions to "is" and "to" ones, as that's more idiomatic.
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp: Added.
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h: Added.
Glue code for importKey/generateKey for now.
- crypto/keys/CryptoKeyDataRSAComponents.cpp: Added.
(WebCore::CryptoKeyDataRSAComponents::CryptoKeyDataRSAComponents):
(WebCore::CryptoKeyDataRSAComponents::~CryptoKeyDataRSAComponents):
- crypto/keys/CryptoKeyDataRSAComponents.h: Added.
(WebCore::toCryptoKeyDataRSAComponents):
Added a structure to hold RSA key components, extracted from JWK or another format.
- crypto/keys/CryptoKeyRSA.h: Added.
- crypto/mac/CryptoKeyRSAMac.cpp: Added.
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Register RSASSA_PKCS1_v1_5.
- crypto/parameters/CryptoAlgorithmHmacKeyParams.h: Added a constructor to make
sure that hasLength is never left uninitialized, even when reading formats that
don't contain a length.
- crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h: Added.
- crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Added.
- crypto/parameters/CryptoAlgorithmRsaSsaParams.h: Added.
Added parameter structures that are needed for RSASSA_PKCS1_v1_5.
LayoutTests:
- crypto/subtle/resources/common.js:
(hexToArrayBuffer): Fixed a typo
(Base64URL.stringify):
(Base64URL.parse):
Added helpers to deal with Base64URL, as needed for JWK.
- crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt: Added.
- crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html: Added.
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt: Added.
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html: Added.
Nov 12, 2013:
- 11:24 PM Changeset in webkit [159179] by
-
- 10 edits in trunk
Disable WebCrypto on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=124261
Rubber-stamped by Sam Weinig.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
LayoutTests:
- platform/mac/TestExpectations:
- 10:52 PM Changeset in webkit [159178] by
-
- 10 edits in trunk/Source/WebCore
Manage XMLHttpRequestUpload, XSLImportRule, XMLErrors, XML pending callback classes through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=124224
Reviewed by Anders Carlsson.
Use std::unique_ptr to handle objects of various XML classes that were previously managed by OwnPtr.
This removes usage of OwnPtr and PassOwnPtr under Source/WebCore/xml/.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::upload):
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequestUpload.h:
- xml/XSLImportRule.h:
- xml/XSLStyleSheet.h:
- xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::loadChildSheet):
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::handleError):
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::PendingCallbacks::PendingCallbacks):
(WebCore::PendingCallbacks::appendStartElementNSCallback):
(WebCore::PendingCallbacks::appendEndElementNSCallback):
(WebCore::PendingCallbacks::appendCharactersCallback):
(WebCore::PendingCallbacks::appendProcessingInstructionCallback):
(WebCore::PendingCallbacks::appendCDATABlockCallback):
(WebCore::PendingCallbacks::appendCommentCallback):
(WebCore::PendingCallbacks::appendInternalSubsetCallback):
(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::PendingCallbacks::callAndRemoveFirstCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):
- 7:59 PM Changeset in webkit [159177] by
-
- 13 edits in trunk/Source/WebCore
Move basic IDBBackingStoreTransaction operations to IDBServerConnection
https://bugs.webkit.org/show_bug.cgi?id=124244
Reviewed by Tim Horton (and unofficially Anders Carlsson).
This patch:
- Makes IDBBackingStore the owner of an IDBBackingStoreTransaction.
- Adds the integer transaction ID to IDBBackingStoreTransaction for reference.
- Removes IDBTransactionBackend’s reliance on IDBBackingStoreTransaction by moving necessary methods to IDBServerConnection.
- Renames the IDBTransactionBackend::backingStoreTransaction() accessor to deprecatedBackingStoreTransaction to make it clear it’s on the way out.
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::setIndexKeys):
- Modules/indexeddb/IDBServerConnection.h:
- Modules/indexeddb/IDBTransactionBackend.cpp:
(WebCore::IDBTransactionBackend::IDBTransactionBackend):
(WebCore::IDBTransactionBackend::~IDBTransactionBackend):
(WebCore::IDBTransactionBackend::deprecatedBackingStoreTransaction):
(WebCore::IDBTransactionBackend::scheduleTask):
(WebCore::IDBTransactionBackend::abort):
(WebCore::IDBTransactionBackend::commit):
(WebCore::IDBTransactionBackend::taskTimerFired):
- Modules/indexeddb/IDBTransactionBackend.h:
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::CreateIndexOperation::perform):
(WebCore::DeleteIndexOperation::perform):
(WebCore::GetOperation::perform):
(WebCore::PutOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
(WebCore::ClearOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::perform):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::makeIndexWriters):
(WebCore::IDBBackingStoreLevelDB::generateKey):
(WebCore::IDBBackingStoreLevelDB::updateKeyGenerator):
(WebCore::IDBBackingStoreLevelDB::establishBackingStoreTransaction):
(WebCore::IDBBackingStoreLevelDB::deprecatedBackingStoreTransaction):
(WebCore::IDBBackingStoreLevelDB::removeBackingStoreTransaction):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp:
(WebCore::IDBBackingStoreTransactionLevelDB::IDBBackingStoreTransactionLevelDB):
(WebCore::IDBBackingStoreTransactionLevelDB::~IDBBackingStoreTransactionLevelDB):
(WebCore::IDBBackingStoreTransactionLevelDB::resetTransaction):
- Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::IDBServerConnectionLevelDB):
(WebCore::IDBServerConnectionLevelDB::deprecatedBackingStoreTransaction):
(WebCore::IDBServerConnectionLevelDB::openTransaction):
(WebCore::IDBServerConnectionLevelDB::beginTransaction):
(WebCore::IDBServerConnectionLevelDB::commitTransaction):
(WebCore::IDBServerConnectionLevelDB::resetTransaction):
(WebCore::IDBServerConnectionLevelDB::rollbackTransaction):
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
- 6:47 PM Changeset in webkit [159176] by
-
- 26 edits in trunk/Source/WebKit2
[GTK][EFL] More on renaming WebKit::APIObject to API::Object
https://bugs.webkit.org/show_bug.cgi?id=124255
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-12
Reviewed by Anders Carlsson.
In r159163 WebKit::APIObject has been renamed to API::Object.
This patch refactors the remaining files which were still
using WebKit::APIObject and WebKit::TypedAPIObject.
- Shared/WebBatteryStatus.h:
- Shared/WebNetworkInfo.h:
- UIProcess/API/C/WKGrammarDetail.cpp:
- UIProcess/API/gtk/WebKitContextMenuItem.cpp:
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
- UIProcess/API/gtk/WebKitWebViewGroup.cpp:
- UIProcess/CoordinatedGraphics/WebView.h:
- UIProcess/WebBatteryManagerProxy.cpp:
- UIProcess/WebBatteryManagerProxy.h:
- UIProcess/WebGrammarDetail.cpp:
- UIProcess/WebNetworkInfoManagerProxy.cpp:
- UIProcess/WebNetworkInfoManagerProxy.h:
- UIProcess/WebTextChecker.h:
- UIProcess/WebVibrationProxy.h:
- UIProcess/WebViewportAttributes.h:
- UIProcess/efl/EwkTouchEvent.h:
- UIProcess/efl/EwkTouchPoint.h:
- UIProcess/efl/WebPopupItemEfl.h:
- UIProcess/efl/WebUIPopupMenuClient.cpp:
- UIProcess/gtk/WebFullScreenClientGtk.h:
- UIProcess/gtk/WebInspectorClientGtk.h:
- UIProcess/soup/WebSoupRequestManagerProxy.cpp:
- UIProcess/soup/WebSoupRequestManagerProxy.h:
- WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:
- WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
- 6:44 PM Changeset in webkit [159175] by
-
- 2 edits in trunk/Tools
[EFL] Added libxss-dev to install-dependencies
https://bugs.webkit.org/show_bug.cgi?id=124254
Reviewed by Gyuyoung Kim.
libxss-dev is required to build EFL packages.
see building part in http://www.enlightenment.org/p.php?p=contribute
- efl/install-dependencies: Added libxss-dev to parameter of apt-get command.
- 6:38 PM Changeset in webkit [159174] by
-
- 2 edits in trunk/LayoutTests
Revert r159140, as it is theoretically fixed by r159173.
- platform/mac-wk2/TestExpectations:
- 6:24 PM Changeset in webkit [159173] by
-
- 5 edits in trunk/Source/WebKit2
fast/canvas/webgl/draw-arrays-out-of-bounds.html is flaky on Mavericks WK2 testers, fails about 20% of the time
https://bugs.webkit.org/show_bug.cgi?id=124223
<rdar://problem/15333977>
Reviewed by Tim Horton.
It's wrong to use DataReferences in sync IPC replies; the underlying MessageDecoder will be freed after the call to
sendSync returns and the DataReference will point to freed memory. Use a Vector<char> instead.
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/SynchronousNetworkLoaderClient.cpp:
(WebKit::SynchronousNetworkLoaderClient::didReceiveBuffer):
(WebKit::SynchronousNetworkLoaderClient::sendDelayedReply):
- NetworkProcess/SynchronousNetworkLoaderClient.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously):
- 6:19 PM Changeset in webkit [159172] by
-
- 2 edits in trunk/Source/WebCore
Fix the Mountain Lion build after r159171.
- platform/mac/HTMLConverter.mm:
(_dateForString): +[NSCalendar calendarWithIdentifier:] only exists on
10.9. Use -[NSCalendar initWithIdentifier:] instead.
- 6:04 PM Changeset in webkit [159171] by
-
- 5 edits in trunk/Source
[Mac] Fix some deprecation warnings
https://bugs.webkit.org/show_bug.cgi?id=124252
Reviewed by Mark Rowe.
Source/WebCore:
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create): Use CFPropertyListCreateWithData()
instead of CFPropertyListCreateFromXMLData().
(WebCore::LegacyWebArchive::rawDataRepresentation): Use
CFPropertyListWrite() instead of CFPropertyListWriteToStream().
- platform/mac/HTMLConverter.mm:
(_dateForString): Rewrite this method in terms of NSDateComponents and
NSCalendar instead of using CFGregorianDate.
Source/WebKit/mac:
- Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage pListForPath:createFile:]): Use +[NSPropertyListSerialization propertyListWithData:options:format:error:] instead of +[NSPropertyListSerialization propertyListFromData:mutabilityOption:format:errorDescription:].
- 5:59 PM Changeset in webkit [159170] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed try at fixing the GTK+ build.
- UIProcess/soup/WebSoupRequestManagerProxy.h: rename TypedAPIObject to API:TypedObject.
- 5:50 PM Changeset in webkit [159169] by
-
- 3 edits in trunk/Source/WebKit/mac
Remove -[WebHistoryItem _lastVisitedDate]
https://bugs.webkit.org/show_bug.cgi?id=124250
Reviewed by Mark Rowe.
This method is not called by anyone and NSCalendarDate is deprecated so get rid of it.
- History/WebHistoryItem.mm:
- History/WebHistoryItemPrivate.h:
- 5:40 PM Changeset in webkit [159168] by
-
- 14 edits1 move1 add in trunk/LayoutTests
[Windows] Unreviewed. More edits to Windows test expectations following r159157.
- platform/win/editing/selection/extend-selection-home-end-expected.txt:
- platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt:
- platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt:
- platform/win/fast/canvas/canvas-scale-shadowBlur-expected.txt:
- platform/win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt:
- platform/win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt:
- platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt:
- platform/win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt:
- platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
- platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
- platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt:
- platform/win/fast/forms/implicit-submission-expected.txt:
- platform/win/fast/forms/range: Added.
- platform/win/fast/forms/range/slider-mouse-events-expected.txt: Copied from platform/win/fast/forms/slider-mouse-events-expected.txt.
- platform/win/fast/forms/select-popup-pagekeys-expected.txt:
- platform/win/fast/forms/slider-mouse-events-expected.txt: Removed.
- 5:34 PM Changeset in webkit [159167] by
-
- 22 edits14 deletes in trunk
Unreviewed, rolling out r159160, r159161, and r159164.
http://trac.webkit.org/changeset/159160
http://trac.webkit.org/changeset/159161
http://trac.webkit.org/changeset/159164
https://bugs.webkit.org/show_bug.cgi?id=124253
Too many errors (make fewer) (Requested by ap on #webkit).
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCryptoAlgorithmBuilder.cpp:
- bindings/js/JSCryptoAlgorithmBuilder.h:
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createAesCbcParams):
(WebCore::createAesKeyGenParams):
(WebCore::createHmacParams):
(WebCore::createHmacKeyParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForWrapKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForUnwrapKey):
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
(WebCore::JSCryptoKeySerializationJWK::keyData):
- bindings/js/JSCryptoKeySerializationJWK.h:
- crypto/CryptoAlgorithmDescriptionBuilder.h:
- crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Removed.
- crypto/CryptoKey.h:
(WebCore::ENUM_CLASS):
- crypto/CryptoKeyData.h:
(WebCore::CryptoKeyData::ENUM_CLASS):
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::importKey):
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::importKey):
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp: Removed.
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h: Removed.
- crypto/keys/CryptoKeyAES.h:
(WebCore::asCryptoKeyAES):
- crypto/keys/CryptoKeyDataOctetSequence.h:
(WebCore::asCryptoKeyDataOctetSequence):
- crypto/keys/CryptoKeyDataRSAComponents.cpp: Removed.
- crypto/keys/CryptoKeyDataRSAComponents.h: Removed.
- crypto/keys/CryptoKeyHMAC.h:
(WebCore::asCryptoKeyHMAC):
- crypto/keys/CryptoKeyRSA.h: Removed.
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
- crypto/mac/CryptoKeyRSAMac.cpp: Removed.
- crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
- crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h: Removed.
- crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Removed.
- crypto/parameters/CryptoAlgorithmRsaSsaParams.h: Removed.
LayoutTests:
- crypto/subtle/resources/common.js:
(hexToArrayBuffer):
- crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt: Removed.
- crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html: Removed.
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt: Removed.
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html: Removed.
- platform/mac/TestExpectations:
- 5:32 PM Changeset in webkit [159166] by
-
- 3 edits in trunk/Source/WebCore
Make the placed floats tree use LayoutUnit instead of int
https://bugs.webkit.org/show_bug.cgi?id=124207
Reviewed by Alexandru Chiculita.
The dimensions of floats are in LayoutUnits, so it doesn't make sense
to be converting to ints for use in the placed floats tree.
Also add missed "explicit" to single argument FloatingObjects
constructor.
No new tests, no behavior change.
- rendering/FloatingObjects.cpp:
(WebCore::rangesIntersect):
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::ComputeFloatOffsetAdapter::lowValue):
(WebCore::ComputeFloatOffsetAdapter::highValue):
(WebCore::FindNextFloatLogicalBottomAdapter::FindNextFloatLogicalBottomAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::lowValue):
(WebCore::FindNextFloatLogicalBottomAdapter::highValue):
- rendering/FloatingObjects.h:
- rendering/RenderFlowThread.h:
- 5:24 PM Changeset in webkit [159165] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][GTK] Remove MutableArray leftovers from build systems
https://bugs.webkit.org/show_bug.cgi?id=124248
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-12
Reviewed by Anders Carlsson.
MutableArray.cpp and .h file has been removed by r159155.
- CMakeLists.txt:
- GNUmakefile.list.am:
- 5:13 PM Changeset in webkit [159164] by
-
- 5 edits in trunk
Implement key generation and JWK import for RSASSA-PKCS1-v1_5
https://bugs.webkit.org/show_bug.cgi?id=124236
Source/WebCore:
Build fix.
- crypto/mac/CryptoKeyRSAMac.cpp: (WebCore::CryptoKeyRSA::buildAlgorithmDescription):
ifdef out some code on Mountain Lion. Bug 124249 track fixing this.
LayoutTests:
- platform/mac/TestExpectations: Update expectations for Mountain Lion.
I'll investigate this later.
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html: Quickly fail is promise is rejected.
- 4:57 PM Changeset in webkit [159163] by
-
- 169 edits in trunk/Source/WebKit2
Rename APIObject to API::Object
https://bugs.webkit.org/show_bug.cgi?id=124247
Reviewed by Tim Horton.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _handleMessageWithName:body:]):
- Shared/API/c/WKArray.cpp:
(WKArrayCreate):
(WKArrayCreateAdoptingValues):
- Shared/API/c/WKContextMenuItem.cpp:
(WKContextMenuItemGetTypeID):
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
- Shared/API/c/WKType.cpp:
(WKGetTypeID):
(WKRetain):
(WKRelease):
- Shared/APIObject.cpp:
(API::Object::Object):
- Shared/APIObject.h:
(API::Object::~Object):
(API::TypedObject::~TypedObject):
(API::TypedObject::TypedObject):
- Shared/Cocoa/APIObject.mm:
(API::Object::ref):
(API::Object::deref):
(API::Object::newObject):
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray objectAtIndex:]):
(-[WKNSArray API::]):
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary objectForKey:]):
(-[WKNSDictionary API::]):
- Shared/Cocoa/WKObject.h:
- Shared/Cocoa/WKObject.mm:
(-[WKObject dealloc]):
(-[WKObject API::]):
- Shared/ImmutableArray.cpp:
(WebKit::ImmutableArray::create):
(WebKit::ImmutableArray::createStringArray):
(WebKit::ImmutableArray::ImmutableArray):
- Shared/ImmutableArray.h:
- Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::keys):
- Shared/ImmutableDictionary.h:
(WebKit::ImmutableDictionary::get):
- Shared/MutableDictionary.cpp:
(WebKit::MutableDictionary::add):
(WebKit::MutableDictionary::set):
- Shared/MutableDictionary.h:
- Shared/SecurityOriginData.cpp:
(WebKit::performAPICallbackWithSecurityOriginDataVector):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageEncoder::UserMessageEncoder):
(WebKit::UserMessageDecoder::baseDecode):
(WebKit::UserMessageDecoder::UserMessageDecoder):
- Shared/WebArchive.cpp:
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):
- Shared/WebArchive.h:
- Shared/WebArchiveResource.h:
- Shared/WebBackForwardListItem.h:
- Shared/WebCertificateInfo.h:
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
(WebKit::WebConnection::handleMessage):
- Shared/WebConnection.h:
- Shared/WebConnectionClient.cpp:
(WebKit::WebConnectionClient::didReceiveMessage):
- Shared/WebConnectionClient.h:
- Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):
(WebKit::WebContextMenuItem::userData):
(WebKit::WebContextMenuItem::setUserData):
- Shared/WebContextMenuItem.h:
- Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::userData):
(WebKit::WebContextMenuItemData::setUserData):
- Shared/WebContextMenuItemData.h:
- Shared/WebData.h:
- Shared/WebError.h:
- Shared/WebGeolocationPosition.h:
- Shared/WebGeometry.h:
- Shared/WebGraphicsContext.h:
- Shared/WebHitTestResult.h:
- Shared/WebImage.h:
- Shared/WebNumber.h:
- Shared/WebOpenPanelParameters.h:
- Shared/WebRenderLayer.cpp:
(WebKit::WebRenderLayer::createArrayFromLayerList):
- Shared/WebRenderLayer.h:
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::WebRenderObject):
- Shared/WebRenderObject.h:
- Shared/WebSecurityOrigin.h:
- Shared/WebSerializedScriptValue.h:
- Shared/WebString.h:
- Shared/WebURL.h:
- Shared/WebURLRequest.h:
- Shared/WebURLResponse.h:
- Shared/WebUserContentURLPattern.h:
- Shared/mac/ObjCObjectGraph.h:
- Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):
- UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerGetTypeID):
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextGetInfoForInstalledPlugIns):
- UIProcess/API/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList API::]):
- UIProcess/API/Cocoa/WKBackForwardListItem.mm:
(-[WKBackForwardListItem API::]):
- UIProcess/API/Cocoa/WKNavigationData.mm:
(-[WKNavigationData API::]):
- UIProcess/API/mac/WKBrowsingContextGroup.mm:
(createWKArray):
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
- UIProcess/Authentication/AuthenticationDecisionListener.h:
- UIProcess/Authentication/WebCredential.h:
- UIProcess/Authentication/WebProtectionSpace.h:
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/GeolocationPermissionRequestProxy.h:
- UIProcess/Notifications/NotificationPermissionRequest.h:
- UIProcess/Notifications/WebNotification.h:
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::refWebContextSupplement):
(WebKit::WebNotificationManagerProxy::derefWebContextSupplement):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/Notifications/WebNotificationProvider.cpp:
(WebKit::WebNotificationProvider::clearNotifications):
- UIProcess/Plugins/WebPluginSiteDataManager.h:
- UIProcess/StatisticsRequest.cpp:
(WebKit::StatisticsRequest::completedRequest):
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::refWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::derefWebContextSupplement):
- UIProcess/WebApplicationCacheManagerProxy.h:
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):
- UIProcess/WebBackForwardList.h:
- UIProcess/WebColorPickerResultListenerProxy.h:
- UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::encodeMessageBody):
(WebKit::WebConnectionToWebProcess::decodeMessageBody):
- UIProcess/WebConnectionToWebProcess.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveMessageFromInjectedBundle):
(WebKit::WebContext::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
- UIProcess/WebContext.h:
(WebKit::WebContext::setInjectedBundleInitializationUserData):
- UIProcess/WebContextInjectedBundleClient.cpp:
(WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle):
(WebKit::WebContextInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):
- UIProcess/WebContextInjectedBundleClient.h:
- UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::WebContextUserMessageDecoder):
(WebKit::WebContextUserMessageDecoder::decode):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::refWebContextSupplement):
(WebKit::WebCookieManagerProxy::derefWebContextSupplement):
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::refWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::derefWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
- UIProcess/WebDatabaseManagerProxy.h:
- UIProcess/WebEditCommandProxy.h:
- UIProcess/WebFormClient.cpp:
(WebKit::WebFormClient::willSubmitForm):
- UIProcess/WebFormClient.h:
- UIProcess/WebFrameListenerProxy.h:
- UIProcess/WebFrameProxy.h:
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::refWebContextSupplement):
(WebKit::WebGeolocationManagerProxy::derefWebContextSupplement):
- UIProcess/WebGeolocationManagerProxy.h:
- UIProcess/WebGrammarDetail.h:
- UIProcess/WebIconDatabase.h:
- UIProcess/WebIconDatabaseClient.h:
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::refWebContextSupplement):
(WebKit::WebKeyValueStorageManager::derefWebContextSupplement):
(WebKit::didGetKeyValueStorageOrigins):
- UIProcess/WebKeyValueStorageManager.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didCommitLoadForFrame):
(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::WebLoaderClient::didFinishLoadForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didSameDocumentNavigationForFrame):
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
(WebKit::WebLoaderClient::didFirstLayoutForFrame):
(WebKit::WebLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebLoaderClient::didLayout):
(WebKit::WebLoaderClient::didRemoveFrameFromHierarchy):
(WebKit::WebLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::WebLoaderClient::didRunInsecureContentForFrame):
(WebKit::WebLoaderClient::didDetectXSSForFrame):
(WebKit::WebLoaderClient::didChangeBackForwardList):
(WebKit::WebLoaderClient::willGoToBackForwardListItem):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::refWebContextSupplement):
(WebKit::WebMediaCacheManagerProxy::derefWebContextSupplement):
- UIProcess/WebMediaCacheManagerProxy.h:
- UIProcess/WebNavigationData.h:
- UIProcess/WebOpenPanelResultListenerProxy.h:
- UIProcess/WebOriginDataManagerProxy.cpp:
(WebKit::WebOriginDataManagerProxy::refWebContextSupplement):
(WebKit::WebOriginDataManagerProxy::derefWebContextSupplement):
- UIProcess/WebOriginDataManagerProxy.h:
- UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
(WebKit::WebPageContextMenuClient::showContextMenu):
- UIProcess/WebPageContextMenuClient.h:
- UIProcess/WebPageGroup.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::didChangeBackForwardList):
(WebKit::WebPageProxy::willGoToBackForwardListItem):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstLayoutForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebPageProxy::didLayout):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
(WebKit::WebPageProxy::didDisplayInsecureContentForFrame):
(WebKit::WebPageProxy::didRunInsecureContentForFrame):
(WebKit::WebPageProxy::didDetectXSSForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::unableToImplementPolicy):
(WebKit::WebPageProxy::willSubmitForm):
(WebKit::WebPageProxy::mouseDidMoveOverElement):
(WebKit::WebPageProxy::didFindStringMatches):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::internalShowContextMenu):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForResponse):
(WebKit::WebPolicyClient::unableToImplementPolicy):
- UIProcess/WebPolicyClient.h:
- UIProcess/WebPreferences.h:
- UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::refWebContextSupplement):
(WebKit::WebResourceCacheManagerProxy::derefWebContextSupplement):
- UIProcess/WebResourceCacheManagerProxy.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::mouseDidMoveOverElement):
- UIProcess/WebUIClient.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WKUserDataWrapper initWithUserData:API::]):
(-[WKUserDataWrapper API::]):
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundlePostSynchronousMessage):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(contextMenuItems):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
(WebKit::InjectedBundle::originsWithApplicationCache):
(WebKit::InjectedBundle::didReceiveMessage):
(WebKit::InjectedBundle::didReceiveMessageToPage):
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
(WebKit::InjectedBundleBackForwardListItem::children):
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
- WebProcess/InjectedBundle/InjectedBundleClient.cpp:
(WebKit::InjectedBundleClient::didReceiveMessage):
(WebKit::InjectedBundleClient::didReceiveMessageToPage):
- WebProcess/InjectedBundle/InjectedBundleClient.h:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::willSubmitForm):
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::willLoadURLRequest):
(WebKit::InjectedBundlePageLoaderClient::willLoadDataRequest):
(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):
(WebKit::InjectedBundlePageLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didSameDocumentNavigationForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveTitleForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRemoveFrameFromHierarchy):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didLayout):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForResponse):
(WebKit::InjectedBundlePagePolicyClient::unableToImplementPolicy):
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
- WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::InjectedBundleUserMessageEncoder):
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::InjectedBundleUserMessageDecoder):
(WebKit::InjectedBundleUserMessageDecoder::decode):
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::load):
- WebProcess/WebConnectionToUIProcess.cpp:
(WebKit::WebConnectionToUIProcess::encodeMessageBody):
(WebKit::WebConnectionToUIProcess::decodeMessageBody):
- WebProcess/WebConnectionToUIProcess.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::mouseDidMoveOverElement):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):
(WebKit::WebFrameLoaderClient::didDetectXSS):
- WebProcess/WebPage/PageBanner.h:
- WebProcess/WebPage/PageOverlay.h:
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):
(WebKit::WebContextMenu::menuItemsWithUserData):
(WebKit::WebContextMenu::items):
- WebProcess/WebPage/WebContextMenu.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::childFrames):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::trackedRepaintRects):
(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadDataImpl):
(WebKit::WebPage::postInjectedBundleMessage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPageGroupProxy.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::postInjectedBundleMessage):
- 4:53 PM Changeset in webkit [159162] by
-
- 11 edits2 adds1 delete in trunk/Source/WebCore
Web Inspector: Extract InspectorAgentRegistry from InspectorBaseAgent
https://bugs.webkit.org/show_bug.cgi?id=124190
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-12
Reviewed by Timothy Hatcher.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorAgentRegistry.cpp: Added.
(WebCore::InspectorAgentRegistry::append):
(WebCore::InspectorAgentRegistry::setFrontend):
(WebCore::InspectorAgentRegistry::clearFrontend):
(WebCore::InspectorAgentRegistry::registerInDispatcher):
(WebCore::InspectorAgentRegistry::discardAgents):
- inspector/InspectorAgentRegistry.h: Added.
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorBaseAgent.cpp: Removed.
- inspector/InspectorBaseAgent.h:
(WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):
(WebCore::InspectorBaseAgentInterface::~InspectorBaseAgentInterface):
- inspector/InspectorController.h:
- inspector/InspectorMemoryAgent.h:
- inspector/WorkerInspectorController.h:
- 4:40 PM Changeset in webkit [159161] by
-
- 2 edits in trunk/Source/WebCore
Implement key generation and JWK import for RSASSA-PKCS1-v1_5
https://bugs.webkit.org/show_bug.cgi?id=124236
Release build fix.
- bindings/js/JSCryptoAlgorithmBuilder.cpp: Include TypedArrayInlines.h
- 4:32 PM Changeset in webkit [159160] by
-
- 21 edits14 adds in trunk
Implement key generation and JWK import for RSASSA-PKCS1-v1_5
https://bugs.webkit.org/show_bug.cgi?id=124236
Reviewed by Sam Weinig.
Source/WebCore:
Tests: crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html
crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSCryptoAlgorithmBuilder.cpp:
(WebCore::JSCryptoAlgorithmBuilder::add):
- bindings/js/JSCryptoAlgorithmBuilder.h:
- crypto/CryptoAlgorithmDescriptionBuilder.h:
Added a way to add an Uint8Array, as needed for RSA key.algorithm.publicExponent.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createAesCbcParams): Removed unneeded JSC prefixes.
(WebCore::createAesKeyGenParams): Ditto.
(WebCore::createHmacParams): Ditto.
(WebCore::createHmacKeyParams): Ditto.
(WebCore::createRsaKeyGenParams): Added.
(WebCore::createRsaSsaKeyParams): Added. WebCrypto currently doesn't specify any
parameters for importKey, so the structure remains blank (unlike with JWK).
(WebCore::createRsaSsaParams): Added (currently unused, will be sued for sign/verify soon).
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt): Removed unneeded JSC prefixes.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign): Added support for RSAES_PKCS1_v1_5.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest): Removed unneeded JSC prefixes.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey): Added support for RSAES_PKCS1_v1_5.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey): Removed unneeded JSC prefixes.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForWrapKey): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForUnwrapKey): Ditto.
- bindings/js/JSCryptoKeySerializationJWK.h:
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::getJSArrayFromJSON): Added.
(WebCore::getBigIntegerVectorFromJSON): Added.
(WebCore::createRSASSAKeyParameters): Create parameters for key import. The key
will remember which algorithm it's allowed to be used with.
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm): Added support for
RS256...RS512 (tha is, RSAES_PKCS1_v1_5 with SHA-256...SHA-512).
(WebCore::JSCryptoKeySerializationJWK::keyDataOctetSequence): Split out of keyData().
(WebCore::JSCryptoKeySerializationJWK::keyDataRSAComponents): Added code to read
RSA key components from JWK.
(WebCore::JSCryptoKeySerializationJWK::keyData): Call one of the above functions.
- crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Added.
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
Placeholders.
- crypto/CryptoKey.h: (WebCore::CryptoKeyClass): Added RSA key class for poor man's RTTI.
- crypto/CryptoKeyData.h: (WebCore::CryptoKeyData::FormatRSAComponents): Added RSAComponents
for poor man's RTTI.
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp: (WebCore::CryptoAlgorithmAES_CBC::importKey):
- crypto/algorithms/CryptoAlgorithmHMAC.cpp: (WebCore::CryptoAlgorithmHMAC::importKey):
- crypto/keys/CryptoKeyAES.h:
(WebCore::isCryptoKeyAES):
(WebCore::toCryptoKeyAES):
- crypto/keys/CryptoKeyDataOctetSequence.h:
(WebCore::toCryptoKeyDataOctetSequence):
- crypto/keys/CryptoKeyHMAC.h:
(WebCore::isCryptoKeyHMAC):
(WebCore::toCryptoKeyHMAC):
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
Switched from "as" functions to "is" and "to" ones, as that's more idiomatic.
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp: Added.
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h: Added.
Glue code for importKey/generateKey for now.
- crypto/keys/CryptoKeyDataRSAComponents.cpp: Added.
(WebCore::CryptoKeyDataRSAComponents::CryptoKeyDataRSAComponents):
(WebCore::CryptoKeyDataRSAComponents::~CryptoKeyDataRSAComponents):
- crypto/keys/CryptoKeyDataRSAComponents.h: Added.
(WebCore::toCryptoKeyDataRSAComponents):
Added a structure to hold RSA key components, extracted from JWK or another format.
- crypto/keys/CryptoKeyRSA.h: Added.
- crypto/mac/CryptoKeyRSAMac.cpp: Added.
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Register RSASSA_PKCS1_v1_5.
- crypto/parameters/CryptoAlgorithmHmacKeyParams.h: Added a constructor to make
sure that hasLength is never left uninitialized, even when reading formats that
don't contain a length.
- crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h: Added.
- crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Added.
- crypto/parameters/CryptoAlgorithmRsaSsaParams.h: Added.
Added parameter structures that are needed for RSASSA_PKCS1_v1_5.
LayoutTests:
- crypto/subtle/resources/common.js:
(hexToArrayBuffer): Fixed a typo
(Base64URL.stringify):
(Base64URL.parse):
Added helpers to deal with Base64URL, as needed for JWK.
- crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt: Added.
- crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html: Added.
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt: Added.
- crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html: Added.
- 4:31 PM Changeset in webkit [159159] by
-
- 14 edits1 add in trunk/Source/WebCore
Move ValueToString out to its own header file to remove duplication
https://bugs.webkit.org/show_bug.cgi?id=124237
Reviewed by Alexandru Chiculita.
The ValueToString struct is used in many places for debugging. Move it
out to its own header file to remove all the duplicated definitions
and make it possible for the specializations to be placed in the
header files with the implementation of the classes they print.
No new tests, no behavior change.
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.h:
- platform/LayoutUnit.h:
- platform/PODInterval.h:
- platform/PODIntervalTree.h:
- platform/PODRedBlackTree.h:
- platform/ValueToString.h: Added.
- platform/graphics/FloatPolygon.h:
- rendering/FloatingObjects.cpp:
- rendering/FloatingObjects.h:
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.h:
- rendering/RenderFlowThread.h:
- 4:28 PM Changeset in webkit [159158] by
-
- 2 edits in trunk/Source/WebKit2
Fix GTK build after r159142
https://bugs.webkit.org/show_bug.cgi?id=124243
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-12
Reviewed by Anders Carlsson.
Use Vector + ImmutableArray instead of MutableArray
- UIProcess/API/gtk/WebKitContextMenuItem.cpp:
(webkitContextMenuItemCreate):
- 4:20 PM Changeset in webkit [159157] by
-
- 2 edits15 adds in trunk/LayoutTests
[Windows] Unreviewed gardening. Re-add someone Windows expections that were erroneously removed.
- platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.
- platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
- platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
- platform/win/fast/canvas/canvas-render-layer-expected.txt: Added.
- platform/win/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
- platform/win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
- platform/win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
- platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
- platform/win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
- platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
- platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
- platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
- platform/win/fast/forms/implicit-submission-expected.txt: Added.
- platform/win/fast/forms/select-popup-pagekeys-expected.txt: Added.
- platform/win/fast/forms/slider-mouse-events-expected.txt: Added.
- platform/win/media/media-can-play-wav-audio-expected.txt:
- 4:04 PM Changeset in webkit [159156] by
-
- 4 edits in trunk/Source/WebKit2
Remove ImmutableArray::isMutable
https://bugs.webkit.org/show_bug.cgi?id=124242
Reviewed by Dan Bernstein.
- Shared/API/c/WKMutableArray.cpp:
(WKArrayIsMutable):
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]):
- Shared/ImmutableArray.h:
- 3:37 PM Changeset in webkit [159155] by
-
- 10 edits2 deletes in trunk/Source/WebKit2
WKMutableArrayRef should be an ImmutableArray
https://bugs.webkit.org/show_bug.cgi?id=124239
Reviewed by Sam Weinig.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(ensureObjectStream):
- Shared/API/c/WKMutableArray.cpp:
(WKMutableArrayCreate):
- Shared/API/c/WKSharedAPICast.h:
- 3:14 PM Changeset in webkit [159154] by
-
- 1 edit in trunk/Source/WebCore/rendering/RenderBlock.cpp
Fix windows build bustage.
- 3:09 PM Changeset in webkit [159153] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Fix load32WithUnalignedHalfWords function in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=124233
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-12
Reviewed by Michael Saboff.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords): Do not claim scratch register too early.
Test already covered by fast/regex/pcre-test-1.
- 3:04 PM Changeset in webkit [159152] by
-
- 7 edits in trunk/Source/WebKit2
Remove more functionality from MutableArray
https://bugs.webkit.org/show_bug.cgi?id=124235
Reviewed by Beth Dakin.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeToObjectStream):
- Shared/API/c/WKMutableArray.cpp:
(WKArrayAppendItem):
(WKArrayRemoveItemAtIndex):
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]):
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::elements):
- Shared/MutableArray.cpp:
- Shared/MutableArray.h:
- 3:03 PM Changeset in webkit [159151] by
-
- 4 edits2 adds1 delete in trunk/Source/WebInspectorUI
Web Inspector: ContentFlowTreeContentView should use only one DOMTreeOutline
https://bugs.webkit.org/show_bug.cgi?id=124230
Reviewed by Timothy Hatcher.
Changed ContentFlowTreeContentView to use one DOMTreeOutline by just
populating it with root DOMTreeElements directly. That is very
similar to how DOMTreeOutline works when omitRootDOMNode is used.
Now that ContentFlowTreeContentView has only one DOMTreeOutline,
it makes sense to change its base class to be DOMTreeContentView instead.
Also, with that I've changed its name to ContentFlowDOMTreeContentView.
I had to move all the DOMTree document loading code from DOMTreeContentView to a
new class called FrameDOMTreeContentView. This is used to display the DOM of the
frame objects. FrameDOMTreeContentView is also inheriting from DOMTreeContentView.
Issues that are fixed as a side effect:
- Selection path components are now displaying all the sibling elements for contentFlow.contentNodes
(those are the nodes that have "-webkit-flow-into" set directly).
- Keyboard navigation works for the contentFlow.contentNodes.
- Search is implemented in DOMTreeContentView, so that code now works for flows too.
The DOMAgents's search API will use all the Documents to lookup for nodes, so it might
find DOM nodes that are not part of the flow. This is in line with the behavior for the
frames.
- UserInterface/ContentFlowDOMTreeContentView.js: Renamed from ContentFlowTreeContentView
to better reflect the inheritance from DOMTreeContentView.
(WebInspector.ContentFlowDOMTreeContentView):
(WebInspector.ContentFlowDOMTreeContentView.prototype.closed):
(WebInspector.ContentFlowDOMTreeContentView.prototype._createContentTrees):
(WebInspector.ContentFlowDOMTreeContentView.prototype._contentNodeWasAdded):
(WebInspector.ContentFlowDOMTreeContentView.prototype._contentNodeWasRemoved):
- UserInterface/ContentView.js:
(WebInspector.ContentView):
- UserInterface/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView):
(WebInspector.DOMTreeContentView.prototype.closed):
(WebInspector.DOMTreeContentView.prototype.):
(WebInspector.DOMTreeContentView.prototype._restoreSelectedNodeAfterUpdate):
(WebInspector.DOMTreeContentView.prototype._selectedNodeDidChange):
- UserInterface/FrameDOMTreeContentView.js: Added.
(WebInspector.FrameDOMTreeContentView):
(WebInspector.FrameDOMTreeContentView.prototype.get domTree):
(WebInspector.FrameDOMTreeContentView.prototype.closed):
(WebInspector.FrameDOMTreeContentView.prototype._rootDOMNodeAvailable):
(WebInspector.FrameDOMTreeContentView.prototype._rootDOMNodeInvalidated):
(WebInspector.FrameDOMTreeContentView.prototype._requestRootDOMNode):
- UserInterface/Main.html:
- 2:51 PM Changeset in webkit [159150] by
-
- 5 edits in trunk/Source/WebCore
Make RenderBlockRareData be in a hashtable instead of being a member variable.
https://bugs.webkit.org/show_bug.cgi?id=124056
Reviewed by Anders Carlsson.
Right now RenderBlock has 4 bytes taken up by a m_rareData member that is almost
never allocated. This is better off in a separate hash, so that RenderBlock can
get 4 bytes back.
Since RenderBlockFlow's rare data member was recently removed and folded into
RenderBlock, we need to undo that change and put the rare data member back in
RenderBlockFlow. RenderBlockFlowRareData inheriting from RenderBlockRareData
was not a good idea anyway, since RenderBlockFlows also very rarely need the
RenderBlockRareData members, and were thus paying a heavier cost when the rare
data was created than was necessary.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::hasRareData):
(WebCore::getRareData):
(WebCore::ensureRareData):
(WebCore::RenderBlock::ensureShapeInsideInfo):
(WebCore::RenderBlock::shapeInsideInfo):
(WebCore::RenderBlock::setShapeInsideInfo):
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageLogicalOffset):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::setPageLogicalOffset):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::setMaxMarginBeforeValues):
(WebCore::RenderBlockFlow::setMaxMarginAfterValues):
(WebCore::RenderBlockFlow::setMustDiscardMarginBefore):
(WebCore::RenderBlockFlow::setMustDiscardMarginAfter):
(WebCore::RenderBlockFlow::mustDiscardMarginBefore):
(WebCore::RenderBlockFlow::mustDiscardMarginAfter):
(WebCore::RenderBlockFlow::setBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::setDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::setRenderNamedFlowFragment):
(WebCore::RenderBlockFlow::ensureRareBlockFlowData):
(WebCore::RenderBlockFlow::materializeRareBlockFlowData):
- rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::shouldBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::lineBreakToAvoidWidow):
(WebCore::RenderBlockFlow::didBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::lineGridBox):
(WebCore::RenderBlockFlow::setLineGridBox):
(WebCore::RenderBlockFlow::renderNamedFlowFragment):
(WebCore::RenderBlockFlow::maxPositiveMarginBefore):
(WebCore::RenderBlockFlow::maxNegativeMarginBefore):
(WebCore::RenderBlockFlow::maxPositiveMarginAfter):
(WebCore::RenderBlockFlow::maxNegativeMarginAfter):
(WebCore::RenderBlockFlow::initMaxMarginValues):
(WebCore::RenderBlockFlow::hasRareBlockFlowData):
(WebCore::RenderBlockFlow::rareBlockFlowData):
- 2:20 PM Changeset in webkit [159149] by
-
- 7 edits in trunk/Source/WebKit2
Remove most uses of MutableArray
https://bugs.webkit.org/show_bug.cgi?id=124232
Reviewed by Sam Weinig.
- Shared/API/c/WKMutableArray.cpp:
(WKMutableArrayCreate):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebRenderLayer.h:
(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::WebRenderObject):
- Shared/WebRenderObject.h:
(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::WebRenderObject):
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):
- 1:51 PM Changeset in webkit [159148] by
-
- 2 edits in trunk/Source/WTF
[Win] Unreviewed gardening.
- WTF.vcxproj/WTF.vcxproj.filters: Tidy up filters so files show up
in their proper directories.
- 1:46 PM Changeset in webkit [159147] by
-
- 1 delete in tags/Safari-537.73.5/safari-537.73-branch
- 1:44 PM Changeset in webkit [159146] by
-
- 8 edits in trunk/Source
Build GStreamer files on Windows.
https://bugs.webkit.org/show_bug.cgi?id=124180
Reviewed by Brent Fulgham.
Source/WebCore:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.vcxproj/copyForwardingHeaders.cmd:
Include gstreamer files in WinCairo build.
Source/WTF:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.vcxproj/copy-files.cmd:
Include gobject files in WinCairo build.
- 1:33 PM Changeset in webkit [159145] by
-
- 2 edits in trunk/LayoutTests
Add fast/images/pdf-as-image-crop-box.html to the pile of tiny-color-mismatch tests.
- platform/mac-wk2/TestExpectations:
- 1:31 PM Changeset in webkit [159144] by
-
- 12 edits3 adds in trunk/Source/WebCore
Introduce IDBServerConnection (and start moving things to it).
https://bugs.webkit.org/show_bug.cgi?id=124193
Reviewed by Alexey Proskuryakov.
IDBServerConnection will be a purely asynchronous interface for database connections, transactions, and cursors.
Its interface will be 100% asynchronous and callback based - Perfect for an IPC divide.
Eventually none of the IDB<Foo>Backend classes will need IDBBackingStore<Foo> classes at all,
and they’ll all use IDBServerConnection directly.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBServerConnection.h: Added.
(WebCore::IDBServerConnection::~IDBServerConnection):
Concrete implementation that - for now - wraps an IDBBackingStoreLevelDB:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp: Added.
(WebCore::IDBServerConnectionLevelDB::IDBServerConnectionLevelDB):
(WebCore::IDBServerConnectionLevelDB::deprecatedBackingStore):
(WebCore::IDBServerConnectionLevelDB::isClosed):
(WebCore::IDBServerConnectionLevelDB::getOrEstablishIDBDatabaseMetadata):
(WebCore::IDBServerConnectionLevelDB::deleteDatabase):
(WebCore::IDBServerConnectionLevelDB::close):
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h: Added.
LevelDB created databases get LevelDB server connections:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::deleteDatabase):
(WebCore::IDBFactoryBackendLevelDB::open):
Replace most uses of IDBBackingStore with server connection:
- Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::create):
(WebCore::IDBDatabaseBackend::IDBDatabaseBackend):
(WebCore::IDBDatabaseBackend::openInternalAsync):
(WebCore::IDBDatabaseBackend::setIndexKeys):
(WebCore::IDBDatabaseBackend::openConnectionInternal):
(WebCore::IDBDatabaseBackend::deleteDatabaseAsync):
(WebCore::IDBDatabaseBackend::close):
- Modules/indexeddb/IDBDatabaseBackend.h:
(WebCore::IDBDatabaseBackend::serverConnection):
Change all the operations to access their DatabaseBackend’s server connection instead
if hanging on to a backing store directly:
- Modules/indexeddb/IDBTransactionBackend.cpp:
(WebCore::IDBTransactionBackend::IDBTransactionBackend):
(WebCore::IDBTransactionBackend::scheduleCreateObjectStoreOperation):
(WebCore::IDBTransactionBackend::scheduleDeleteObjectStoreOperation):
(WebCore::IDBTransactionBackend::scheduleCreateIndexOperation):
(WebCore::IDBTransactionBackend::scheduleDeleteIndexOperation):
(WebCore::IDBTransactionBackend::scheduleGetOperation):
(WebCore::IDBTransactionBackend::schedulePutOperation):
(WebCore::IDBTransactionBackend::scheduleOpenCursorOperation):
(WebCore::IDBTransactionBackend::scheduleCountOperation):
(WebCore::IDBTransactionBackend::scheduleDeleteRangeOperation):
(WebCore::IDBTransactionBackend::scheduleClearOperation):
- Modules/indexeddb/IDBTransactionBackend.h:
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::CreateIndexOperation::perform):
(WebCore::DeleteIndexOperation::perform):
(WebCore::GetOperation::perform):
(WebCore::PutOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
(WebCore::ClearOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::perform):
- Modules/indexeddb/IDBTransactionBackendOperations.h:
(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(WebCore::CountOperation::create):
(WebCore::CountOperation::CountOperation):
(WebCore::DeleteRangeOperation::create):
(WebCore::DeleteRangeOperation::DeleteRangeOperation):
(WebCore::ClearOperation::create):
(WebCore::ClearOperation::ClearOperation):
- Modules/indexeddb/IDBTransactionCoordinator.h:
- 1:17 PM Changeset in webkit [159143] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed gardening.
- WebCore.vcxproj/WebCore.vcxproj.filters: Correct filter file so that source
files show up in their proper directories in Visual Studio.
- 1:04 PM Changeset in webkit [159142] by
-
- 6 edits in trunk/Source/WebKit2
Use Vector + ImmutableArray instead of MutableArray
https://bugs.webkit.org/show_bug.cgi?id=124221
Reviewed by Andreas Kling.
- Shared/WebRenderLayer.cpp:
(WebKit::WebRenderLayer::createArrayFromLayerList):
- Shared/WebRenderLayer.h:
- UIProcess/Notifications/WebNotificationProvider.cpp:
(WebKit::WebNotificationProvider::clearNotifications):
- UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(contextMenuItems):
(WKBundlePageCopyContextMenuItems):
(WKBundlePageCopyContextMenuAtPointInWindow):
- 1:02 PM Changeset in webkit [159141] by
-
- 5 edits in trunk/Source/JavaScriptCore
Liveness analysis should take less memory in CodeBlock when it is unused
https://bugs.webkit.org/show_bug.cgi?id=124225
Reviewed by Mark Hahnenberg.
Basically, I turned CodeBlock::m_livenessAnalysis into a pointer that is null by
default.
- bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::BytecodeLivenessAnalysis::BytecodeLivenessAnalysis):
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint):
(JSC::BytecodeLivenessAnalysis::operandIsLiveAtBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::dumpResults):
(JSC::BytecodeLivenessAnalysis::compute):
- bytecode/BytecodeLivenessAnalysis.h:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::livenessAnalysis):
- 12:57 PM Changeset in webkit [159140] by
-
- 2 edits in trunk/LayoutTests
fast/canvas/webgl/draw-arrays-out-of-bounds.html is flaky on Mavericks WK2 testers, fails about 20% of the time
https://bugs.webkit.org/show_bug.cgi?id=124223
Mark as flaky on Mac-Mavericks-WebKit2.
- platform/mac-wk2/TestExpectations:
- 12:55 PM Changeset in webkit [159139] by
-
- 11 edits in trunk
Support unprefixed deconstructing assignment
https://bugs.webkit.org/show_bug.cgi?id=124172
Reviewed by Mark Lam.
Source/JavaScriptCore:
Add support for unprefixed descontructive assignment.
Happily non-reference types on the left hand side of an assignment
are a runtime error, so we're able to defer validation of the binding
pattern to codegen time when we're already doing a lot more work.
We're also able to predicate our attempt to parse on the existence of
'[' or '{' as they are not as common as other constructs.
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayPatternNode::emitDirectBinding):
- parser/ASTBuilder.h:
- parser/Parser.cpp:
(JSC::::createBindingPattern):
(JSC::::tryParseDeconstructionPatternExpression):
(JSC::::parseDeconstructionPattern):
(JSC::::parseForStatement):
(JSC::::parseAssignmentExpression):
- parser/Parser.h:
(JSC::Parser::createSavePoint):
(JSC::Parser::restoreSavePoint):
- parser/SyntaxChecker.h:
LayoutTests:
Add and expand testing of destructuring assignment
- js/basic-for-of-expected.txt:
- js/destructuring-assignment-expected.txt:
- js/parser-syntax-check-expected.txt:
- js/script-tests/basic-for-of.js:
- js/script-tests/destructuring-assignment.js:
(testDestructuring):
- js/script-tests/parser-syntax-check.js:
- 12:50 PM Changeset in webkit [159138] by
-
- 4 edits in trunk/Source/JavaScriptCore
Run JavaScriptCore Objective-C API tests on all supported platforms
https://bugs.webkit.org/show_bug.cgi?id=124214
Reviewed by Mark Hahnenberg.
Now that we support the API on iOS and on OS X 10.8, there's no reason
to limit the tests to OS X 10.9 (or greater).
- API/tests/CurrentThisInsideBlockGetterTest.h:
- API/tests/CurrentThisInsideBlockGetterTest.mm:
- API/tests/testapi.mm:
- 12:43 PM Changeset in webkit [159137] by
-
- 2 edits in trunk/LayoutTests
[Windows] Unreviewed gardening of some media tests.
- platform/win/TestExpectations:
- 12:35 PM Changeset in webkit [159136] by
-
- 13 edits4 adds in trunk/Source
CodeBlocks should be able to determine bytecode liveness
https://bugs.webkit.org/show_bug.cgi?id=118546
Reviewed by Filip Pizlo.
This will simplify some things in the DFG related to OSR exits and determining
which bytecode variables are live at which points during execution. It will
also be useful for making our conservative GC scan more precise. Currently it
doesn't properly account for liveness while the DFG is running, so it will be
off by default behing a runtime Options flag.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeBasicBlock.cpp: Added.
(JSC::isBranch): Used to determine the end of basic blocks.
(JSC::isUnconditionalBranch): Used to determine when a branch at the end of a
basic block can't possibly fall through to the next basic block in program order.
(JSC::isTerminal): Also used to detect the end of a block.
(JSC::isThrow):
(JSC::isJumpTarget): Used to correctly separate basic blocks. Any jump destination
must be the head of its own basic block.
(JSC::linkBlocks): Links two blocks together in a bi-direcitonal fashion.
(JSC::computeBytecodeBasicBlocks): Creates a set of basic blocks given a particular
CodeBlock and links them together.
- bytecode/BytecodeBasicBlock.h: Added.
(JSC::BytecodeBasicBlock::isEntryBlock): Entry blocks are a special basic blocks
that indicate the beginning of the function.
(JSC::BytecodeBasicBlock::isExitBlock): Exit blocks are a special basic block that
all blocks that exit the function have as a successor. Entry and exit blocks allows
the various code paths to be more regular.
(JSC::BytecodeBasicBlock::leaderBytecodeOffset): The leader bytecode offset is the
bytecode offset of the first instruction in the block.
(JSC::BytecodeBasicBlock::totalBytecodeLength): The total length of all the bytecodes
in this block.
(JSC::BytecodeBasicBlock::bytecodeOffsets): The bytecode offsets in this particular
basic block. This Vector allows us to iterate over the bytecodes in reverse order
which wouldn't be possible normally since they are of variable size.
(JSC::BytecodeBasicBlock::addPredecessor): Links a block to a specified predecessor.
Only creates one direction of the link.
(JSC::BytecodeBasicBlock::addSuccessor): Same as addPredecessor, but for successors.
(JSC::BytecodeBasicBlock::predecessors): Getter for predecessors.
(JSC::BytecodeBasicBlock::successors): Getter for successors.
(JSC::BytecodeBasicBlock::in): Getter for the liveness info at the head of the block.
(JSC::BytecodeBasicBlock::out): Getter for the liveness info at the tail of the block.
(JSC::BytecodeBasicBlock::BytecodeBasicBlock):
(JSC::BytecodeBasicBlock::addBytecodeLength): When creating basic blocks we call
this function when we want to add the next bytecode in program order to this block.
- bytecode/BytecodeLivenessAnalysis.cpp: Added.
(JSC::BytecodeLivenessAnalysis::BytecodeLivenessAnalysis):
(JSC::numberOfCapturedVariables): Convenience wrapper. Returns the
number of captured variables for a particular CodeBlock, or 0 if
the CodeBlock has no SymbolTable.
(JSC::captureStart): Ditto, but for captureStart().
(JSC::captureEnd): Ditto, but for captureEnd().
(JSC::isValidRegisterForLiveness): Returns true if the liveness analysis should
track the liveness of a particular operand. We ignore constants, arguments, and
captured variables. We ignore arguments because they're live for the duration of
a function call. We ignore captured variables because we also treat them as live
for the duration of the function. This could probably be improved to be more precise,
but it didn't seem worth it for now.
(JSC::setForOperand): Convenience wrapper that sets the bit in the provided bit
vector for the provided operand. It handles skipping over captured variables.
(JSC::computeUsesForBytecodeOffset): Computes which operands are used by a particular bytecode.
(JSC::computeDefsForBytecodeOffset): Computes which operands are defined by a particular
bytecode. Typically this is just the left-most operand.
(JSC::findBasicBlockWithLeaderOffset):
(JSC::findBasicBlockForBytecodeOffset): Scans over basic blocks to find the block
which contains a particular bytecode offset.
(JSC::computeLocalLivenessForBytecodeOffset): Computes block-local liveness from the
bottom of the block until a specified bytecode offset is reached.
(JSC::computeLocalLivenessForBlock): Computes liveness for the entire block and
stores the resulting liveness at the head.
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint): Runs backward flow liveness
analysis to fixpoint.
(JSC::BytecodeLivenessAnalysis::getLivenessInfoForNonCapturedVarsAtBytecodeOffset):
Slow path to get liveness info for non-captured, non-argument variable.
(JSC::BytecodeLivenessAnalysis::operandIsLiveAtBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::getLivenessInfoAtBytecodeOffset): Returns the liveness
info for both captured and non-captured vars at a particular bytecode offset.
(JSC::BytecodeLivenessAnalysis::dumpResults): Dumps the output of the liveness analysis.
Controlled by new flag in Options.h/.cpp.
(JSC::BytecodeLivenessAnalysis::compute): Creates bytecode basic blocks and runs
full liveness analysis.
- bytecode/BytecodeLivenessAnalysis.h: Added.
(JSC::BytecodeLivenessAnalysis::hasBeenComputed):
(JSC::BytecodeLivenessAnalysis::computeIfNecessary):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::livenessAnalysis):
- bytecode/PreciseJumpTargets.cpp: Refactored to be able to get the jump targets for
a particular bytecode offset for use during bytecode basic block construction.
(JSC::getJumpTargetsForBytecodeOffset):
(JSC::computePreciseJumpTargets):
(JSC::findJumpTargetsForBytecodeOffset):
- bytecode/PreciseJumpTargets.h:
- runtime/Options.cpp:
(JSC::Options::initialize):
- runtime/Options.h:
- 12:30 PM Changeset in webkit [159135] by
-
- 2 edits in trunk/LayoutTests
"AVF info: hasOfflineRenderer, board-id check : true" in media/track/track-forced-subtitles-in-band.html
https://bugs.webkit.org/show_bug.cgi?id=124219
Logging that happens unpredictably underneath us; marking the test as flaky on Mavericks for now.
- platform/mac/TestExpectations:
- 12:19 PM Changeset in webkit [159134] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed GTK build fix after r159129.
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_select_files): Use ImmutableArray::create() instead.
- UIProcess/API/gtk/WebKitWebViewGroup.cpp:
(toImmutableArray): Ditto.
- 12:16 PM Changeset in webkit [159133] by
-
- 3 edits in trunk/Source/WebKit2
Stop using WKArrayCreate internally
https://bugs.webkit.org/show_bug.cgi?id=124217
Reviewed by Andreas Kling.
- UIProcess/API/mac/WKBrowsingContextGroup.mm:
(createWKArray):
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]):
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyContextMenuItems):
- 12:05 PM Changeset in webkit [159132] by
-
- 1 edit2 adds in trunk/LayoutTests
Created test for testing repaint rects for elements inside relative-positioned regions.
[CSS Regions] clip rectangles are incorrectly computed in some positioned elements
https://bugs.webkit.org/show_bug.cgi?id=114722
Reviewed by Mihnea Ovidenie.
- fast/repaint/increasing-region-content-height-expected.txt: Added.
- fast/repaint/increasing-region-content-height.html: Added.
- 11:40 AM Changeset in webkit [159131] by
-
- 3 edits in trunk/Source/WebKit2
URTBF after r159129, use create() instead of adopt() everywhere.
- UIProcess/WebGrammarDetail.cpp:
(WebKit::WebGrammarDetail::guesses):
- UIProcess/efl/WebUIPopupMenuClient.cpp:
(WebUIPopupMenuClient::showPopupMenu):
- 11:40 AM Changeset in webkit [159130] by
-
- 2 edits in trunk/Tools
After http://trac.webkit.org/changeset/159109, update
rebaseline_unittest to use the new GTK bot names.
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory):
- 11:24 AM Changeset in webkit [159129] by
-
- 25 edits in trunk/Source/WebKit2
Simplify ImmutableArray creation
https://bugs.webkit.org/show_bug.cgi?id=124213
Reviewed by Andreas Kling.
Get rid of the various ImmutableArray::adopt functions and have a single create function instead.
Use std::move to avoid unnecessarily copying vector data.
- Shared/API/c/WKArray.cpp:
(WKArrayCreate):
(WKArrayCreateAdoptingValues):
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]):
- Shared/ImmutableArray.cpp:
(WebKit::ImmutableArray::create):
(WebKit::ImmutableArray::createStringArray):
(WebKit::ImmutableArray::ImmutableArray):
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::at):
(WebKit::ImmutableArray::size):
(WebKit::ImmutableArray::entries):
- Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::keys):
- Shared/MutableArray.cpp:
(WebKit::MutableArray::MutableArray):
(WebKit::MutableArray::append):
(WebKit::MutableArray::reserveCapacity):
(WebKit::MutableArray::removeItemAtIndex):
- Shared/SecurityOriginData.cpp:
(WebKit::performAPICallbackWithSecurityOriginDataVector):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebArchive.cpp:
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):
- Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextGetInfoForInstalledPlugIns):
- UIProcess/StatisticsRequest.cpp:
(WebKit::StatisticsRequest::completedRequest):
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
- UIProcess/WebKeyValueStorageManager.cpp:
(WebKit::didGetKeyValueStorageOrigins):
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didChangeBackForwardList):
- UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::showContextMenu):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::didFindStringMatches):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::originsWithApplicationCache):
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
(WebKit::InjectedBundleBackForwardListItem::children):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::childFrames):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::trackedRepaintRects):
- 11:21 AM Changeset in webkit [159128] by
-
- 2 edits in trunk/LayoutTests
Fix accessibility/aria-help after r159067.
It's failing everywhere because the path to its script is wrong.
- accessibility/aria-help.html:
- 11:18 AM Changeset in webkit [159127] by
-
- 2 edits in trunk/Source/WebKit2
The last URTBF after r159108 to make GTK happy.
- GNUmakefile.am:
- 11:06 AM Changeset in webkit [159126] by
-
- 2 edits in trunk/Source/WebKit2
One more URTBF after r159108, I hope the last one.
- GNUmakefile.am:
- 11:01 AM Changeset in webkit [159125] by
-
- 3 edits in trunk/Source/JavaScriptCore
[iOS] Define JSC_OBJC_API_ENABLED
https://bugs.webkit.org/show_bug.cgi?id=124192
Reviewed by Geoffrey Garen.
- API/JSBase.h: JSC_OBJC_API_ENABLED should evaluate to true if
TARGET_OS_IPHONE is true.
- API/JSValue.h: Ensure CG types referenced later in the file are defined.
- 10:55 AM Changeset in webkit [159124] by
-
- 2 edits in trunk/Source/WebKit2
Remote Layer Tree: Assertions during layer flushing after replaceSublayer()
https://bugs.webkit.org/show_bug.cgi?id=124194
Reviewed by Anders Carlsson.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::replaceSublayer):
Only remove the old layer from the children array once (via removeFromSuperlayer).
Update the superlayer backpointer on the new layer.
- 10:32 AM Changeset in webkit [159123] by
-
- 9 edits in trunk/Source/WebKit2
Add ImmutableArray::createStringArray
https://bugs.webkit.org/show_bug.cgi?id=124210
Reviewed by Andreas Kling.
Creating an ImmutableArray of WebStrings is a common operation, so add a
helper function to ImmutableArray that does this from a Vector of Strings.
- Shared/ImmutableArray.cpp:
(WebKit::ImmutableArray::createStringArray):
- Shared/ImmutableArray.h:
- Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::keys):
- Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::acceptMIMETypes):
(WebKit::WebOpenPanelParameters::selectedFileNames):
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::didGetSitesWithData):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):
- UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):
- 10:22 AM Changeset in webkit [159122] by
-
- 7 edits in trunk/Source
[WinCairo] Preparation for ENABLE(VIDEO).
https://bugs.webkit.org/show_bug.cgi?id=57420
Reviewed by Martin Robinson.
Source/WebCore:
- platform/FileSystem.h:
- platform/graphics/MediaPlayer.cpp:
- rendering/RenderMediaControls.cpp:
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustSliderThumbSize):
Separated CG code from GStreamer code.
Source/WebKit/win:
- FullscreenVideoController.cpp:
Don't compile if using GStreamer.
- 10:19 AM Changeset in webkit [159121] by
-
- 3 edits in trunk/PerformanceTests
Remove body onload handler from html5-8266.html that was causing
the test to sometimes finish before doing anything interesting.
Unskip Parser/HTML5-8266-FullRender.html now that it's stable.
Rubber-stamped by Antti Koivisto.
- Parser/resources/html5-8266.html:
- Skipped:
- 9:56 AM Changeset in webkit [159120] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Skip media/media-source tests, as EFL port does not support MEDIA_SOURCE.
- platform/efl/TestExpectations:
- 9:55 AM Changeset in webkit [159119] by
-
- 2 edits in trunk/Source/WebCore
Fix reported build warnings for GTK
https://bugs.webkit.org/show_bug.cgi?id=123439
Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-12
Reviewed by Carlos Garcia Campos.
There was a void method, that has return value in it's documentation, so I removed it.
- bindings/gobject/WebKitDOMCustom.h:
- 9:51 AM Changeset in webkit [159118] by
-
- 2 edits in trunk/Source/WebKit2
One more URTBF after r159108.
- GNUmakefile.am:
- 9:40 AM Changeset in webkit [159117] by
-
- 19 edits in trunk/Source/WebKit2
Begin cleaning up handling of ImmutableArray vectors
https://bugs.webkit.org/show_bug.cgi?id=124208
Reviewed by Andreas Kling.
Use range based for to iterate the loops. Use reserveInitialCapacity + uncheckedAppend
when appending vector elements.
- Shared/SecurityOriginData.cpp:
(WebKit::performAPICallbackWithSecurityOriginDataVector):
- Shared/WebArchive.cpp:
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):
- Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):
- Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::acceptMIMETypes):
(WebKit::WebOpenPanelParameters::selectedFileNames):
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextGetInfoForInstalledPlugIns):
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::didGetSitesWithData):
- UIProcess/StatisticsRequest.cpp:
(WebKit::StatisticsRequest::completedRequest):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
- UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):
- UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::showContextMenu):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::didFindStringMatches):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::originsWithApplicationCache):
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
(WebKit::InjectedBundleBackForwardListItem::children):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::trackedRepaintRects):
- 9:38 AM Changeset in webkit [159116] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix undefined reference issues in JavaScriptCore build.
https://bugs.webkit.org/show_bug.cgi?id=124152
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-11-12
Reviewed by Michael Saboff.
Missing includes added.
- runtime/SymbolTable.cpp:
- 9:33 AM Changeset in webkit [159115] by
-
- 7 edits in trunk/Source/WebCore
Manage StorageThread through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=124197
Reviewed by Anders Carlsson.
New StorageThread objects are crafted through std::make_unique. This removes the need for the static
StorageThread::create() method but requires that the StorageThread constructor is made public.
- storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::StorageSyncManager):
- storage/StorageSyncManager.h:
- storage/StorageThread.cpp:
- storage/StorageThread.h:
- storage/StorageTracker.cpp:
(WebCore::StorageTracker::StorageTracker):
- storage/StorageTracker.h:
- 9:30 AM Changeset in webkit [159114] by
-
- 4 edits in trunk/Source/WebCore
Remove unnecessary PassOwnPtr.h header includes under Source/WebCore/fileapi
https://bugs.webkit.org/show_bug.cgi?id=124196
Reviewed by Anders Carlsson.
PassOwnPtr is not used anywhere under Source/WebCore/fileapi/, so PassOwnPtr.h inclusions can be removed.
- fileapi/Blob.h:
- fileapi/FileThread.h:
- fileapi/FileThreadTask.h:
- 9:25 AM Changeset in webkit [159113] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/js/dom/global-constructors-attributes-expected.txt: Rebaseline after new constructors
were made available with enabling the Media Stream feature.
- 8:28 AM Changeset in webkit [159112] by
-
- 2 edits in trunk/Source/WebKit2
One more URTBF after r159108.
- CMakeLists.txt:
- 8:16 AM Changeset in webkit [159111] by
-
- 3 edits in trunk/Source/WebKit2
URTBF after r159108.
- CMakeLists.txt:
- GNUmakefile.list.am:
- 7:41 AM Changeset in webkit [159110] by
-
- 5 edits12 adds in trunk
Web Inspector: Crash when closing the Inspector while debugging an exception inside a breakpoint condition.
https://bugs.webkit.org/show_bug.cgi?id=124078
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
The crash would happen because the Debugger is not designed to support nested
breaks. For example, when the debugger handles a breakpoint and the Inspector
executes a console command that would hit the breakpoint again, the Debugger
will just ignore the breakpoint.
There were no checks for conditions and actions. Because of that conditions and actions
could trigger exceptions and breakpoints. This patch disables that functionality as it
cannot be supported without a bigger rewrite of the code.
- debugger/Debugger.cpp:
(JSC::TemporaryPausedState::TemporaryPausedState):
(JSC::TemporaryPausedState::~TemporaryPausedState):
(JSC::Debugger::hasBreakpoint):
(JSC::Debugger::pauseIfNeeded):
- debugger/Debugger.h:
LayoutTests:
Checking that the debugger will not crash nor stall when exceptions are throw while the debugger
is already paused. The cases when that can happen include breakpoint conditions, actions, eval
or runtime object inspection.
The current behavior was to ignore the exceptions or breakpoints while executing "console commands"
when the debugger was already paused. I'm extending this mechanism to breakpoint conditions and
actions as the Debugger is not designed to support nested "debugger breaks".
- http/tests/inspector-protocol/resources/protocol-test.js:
(closeTest): Avoid having internals.closeDummyInspectorFrontend and testRunner.notifyDone
in the same function. The debugger will not have a chance to exit the temporary EventLoop
before loading the next test.
- inspector-protocol/debugger/breakpoint-action-detach-expected.txt: Added.
- inspector-protocol/debugger/breakpoint-action-detach.html: Added.
- inspector-protocol/debugger/breakpoint-action-with-exception-expected.txt: Added.
- inspector-protocol/debugger/breakpoint-action-with-exception.html: Added.
- inspector-protocol/debugger/breakpoint-condition-detach-expected.txt: Added.
- inspector-protocol/debugger/breakpoint-condition-detach.html: Added.
- inspector-protocol/debugger/breakpoint-condition-with-exception-expected.txt: Added.
- inspector-protocol/debugger/breakpoint-condition-with-exception.html: Added.
- inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt: Added.
- inspector-protocol/debugger/breakpoint-eval-with-exception.html: Added.
- inspector-protocol/debugger/breakpoint-inside-conditons-and-actions-expected.txt: Added.
- inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html: Added.
- 7:23 AM Changeset in webkit [159109] by
-
- 2 edits in trunk/Tools
[GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py
https://bugs.webkit.org/show_bug.cgi?id=124144
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-12
Reviewed by Gustavo Noronha Silva.
Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
according to http://build.webkit.org/builders.
- Scripts/webkitpy/port/builders.py:
- 7:21 AM Changeset in webkit [159108] by
-
- 2 edits2 moves1 add in trunk/Source/WebKit2
Move StringReference to Platform/IPC
https://bugs.webkit.org/show_bug.cgi?id=124203
Reviewed by Antti Koivisto.
- Platform/IPC/StringReference.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/StringReference.cpp.
(CoreIPC::StringReference::toString):
(CoreIPC::StringReference::encode):
(CoreIPC::StringReference::decode):
(CoreIPC::StringReference::Hash::hash):
- Platform/IPC/StringReference.h: Renamed from Source/WebKit2/Platform/CoreIPC/StringReference.h.
(CoreIPC::StringReference::StringReference):
(CoreIPC::StringReference::isEmpty):
(CoreIPC::StringReference::size):
(CoreIPC::StringReference::data):
(CoreIPC::StringReference::operator==):
(CoreIPC::StringReference::Hash::equal):
- WebKit2.xcodeproj/project.pbxproj:
- 6:56 AM WebKitGTK/2.2.x edited by
- SVN r157631 is not actually needed to be merged since the problem it … (diff)
- 6:56 AM Changeset in webkit [159107] by
-
- 1 edit2 deletes in trunk/LayoutTests
Unreviewed GTK gardening. Share expectations for vertical text among WK1 and WK2.
- platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
- platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
- platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
- platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
- platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Removed.
- 6:53 AM Changeset in webkit [159106] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Mark 73 tests as failing/skipped after r158954.
- platform/efl/TestExpectations:
- 6:44 AM Changeset in webkit [159105] by
-
- 4 edits2 adds in trunk
Text on simple lines sometimes paints one pixel off
https://bugs.webkit.org/show_bug.cgi?id=124200
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/text/line-runs-simple-lines.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::adjustRunOffsets):
Don't round on run construction time.
(WebCore::SimpleLineLayout::createTextRuns):
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::Run::rect):
Instead round when generating rects.
(WebCore::SimpleLineLayout::RunResolver::Run::baseline):
Provide the baseline (used by painting) as unrounded FloatPoint.
LayoutTests:
- fast/text/line-runs-rounding-simple-lines-expected.html: Added.
- fast/text/line-runs-rounding-simple-lines.html: Added.
- 6:40 AM Changeset in webkit [159104] by
-
- 2 edits in trunk/Source/WebCore
Elements with class names automatically get unique ElementData.
<https://webkit.org/b/124184>
We were calling Element::ensureUniqueElementData() for all Elements
with a non-empty list of class names. Doing that on parser-fresh
Elements caused us to upgrade them to UniqueElementData despite not
needing it (ElementData::setClass() is a const function for caching
the "cooked" class and can be called on ShareableElementData.)
1.09 MB progression on HTML5 spec at <http://whatwg.org/c>
Reviewed by Antti Koivisto.
- 6:13 AM Changeset in webkit [159103] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
Webkit - Updated Tamil translation
https://bugs.webkit.org/show_bug.cgi?id=124142
Patch by Shantha kumar <shkumar@redhat.com> on 2013-11-12
Reviewed by Gustavo Noronha Silva.
- ta.po: updated.
- 6:03 AM Changeset in webkit [159102] by
-
- 3 edits in trunk/PerformanceTests
Neutralize external resource loads in the new HTML5 spec copy.
Skip Parser/HTML5-8266-FullRender.html until I can make it less flaky.
- Parser/resources/html5-8266.html:
- Skipped:
- 1:44 AM Changeset in webkit [159101] by
-
- 1 edit3 adds in trunk/PerformanceTests
Import a fresh version of the full HTML5 spec for perf testing.
Rubber-stamped by Antti Koivisto.
- Parser/HTML5-8266-FullRender.html: Added.
- Parser/HTML5-8266-ParseOnly.html: Added.
- Parser/resources/html5-8266.html: Added.
- 12:33 AM Changeset in webkit [159100] by
-
- 12 edits2 adds1 delete in trunk
JSC bindings generator should generate deletable JSC functions
https://bugs.webkit.org/show_bug.cgi?id=122422
Reviewed by Geoffrey Garen.
Source/WebCore:
The JSC functions that the JSC bindings generator generates should be deletable to conform to
the WebIDL specification, which instructs that the WebIDL operations must be configurable (which
translates to the JSC functions being deletable).
The generator will still produce a non-deletable JSC function for operations under almost all
Web-facing interfaces since they're annotated with the OperationsNotDeletable attribute. The
exception here is the Node interface that is having the attribute removed, with the provided
test case testing that all the functions on the Node prototype object are writable, enumerable
and configurable. This behavior conforms to the WebIDL specification and the behaviors of IE
and Firefox. Chrome at the moment still provides non-configurable functions.
Test: fast/dom/webidl-operations-on-node-prototype.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Enforce the non-deletable behavior of the JSC function if either the
operation's interface is annotated with the OperationsNotDeletable attribute or the operation itself
is annotated with the NotDeletable attribute.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Update the JSC generator test baselines.
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
- bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
- bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
- bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
- bindings/scripts/test/JS/JSTestTypedefs.cpp: Ditto.
- dom/Node.idl: Remove the OperationsNotDeletable attribute.
LayoutTests:
Test that all the functions on the Node prototype object (apart from the constructor) are
writable, enumerable and configurable, as expected for WebIDL operations. This matches the
WebIDL specification as well as IE and Firefox.
Other affected test cases and baselines are updated to reflect the new behavior.
- fast/dom/webidl-operations-on-node-prototype-expected.txt: Added.
- fast/dom/webidl-operations-on-node-prototype.html: Added.
- js/dom/getOwnPropertyDescriptor-expected.txt:
- js/resources/getOwnPropertyDescriptor.js:
- platform/mac/canvas/philip/tests/type.prototype-expected.txt: Removed.
- 12:21 AM Changeset in webkit [159099] by
-
- 3 edits in trunk/Source/JavaScriptCore
InvalidIndex shouldn't be private in GPRInfo and FPRInfo for sh4, mips and arm64 architectures.
https://bugs.webkit.org/show_bug.cgi?id=124156
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-12
Reviewed by Michael Saboff.
- jit/FPRInfo.h:
(JSC::FPRInfo::debugName):
- jit/GPRInfo.h:
(JSC::GPRInfo::debugName):
Nov 11, 2013:
- 11:56 PM Changeset in webkit [159098] by
-
- 2 edits in trunk/Source/WebKit2
Remote Layer Tree: Sporadic memory corruption during painting
https://bugs.webkit.org/show_bug.cgi?id=124191
Reviewed by Brady Eidson.
Fix a logic error (flipped the logic, didn't flip the operator)
made in the last version of r158982 that caused some crashes because
it allowed us to overrun the end of cgPaintingRects.
- Shared/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::drawInContext):
- 11:56 PM Changeset in webkit [159097] by
-
- 3 edits in trunk/Source/JavaScriptCore
CodeBlock: Un-segment some Vectors.
<https://webkit.org/b/124188>
Turn some SegmentedVectors into Vectors where the final item count
is known at CodeBlock construction time. This removes unnecessary
allocation and indirection.
I've got ~4.5 MB below SegmentedVector<ValueProfile>::ensureSegment
on Membuster3 (peak, before pressure signal) so this should help
take a bit of the edge off there.
Reviewed by Geoffrey Garen.
- 10:43 PM Changeset in webkit [159096] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r159088.
http://trac.webkit.org/changeset/159088
https://bugs.webkit.org/show_bug.cgi?id=124187
It broke the EFL build, because it removed a used function
(rs=thorton) (Requested by Ossy_night on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2013-11-11
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::urlAtProcessExit):
(WebKit::WebPageProxy::loadStateAtProcessExit):
- 10:35 PM Changeset in webkit [159095] by
-
- 7 edits in trunk/Source/WebCore
Make IDBTransaction tasks asynchronous
https://bugs.webkit.org/show_bug.cgi?id=124183
Reviewed by Tim Horton.
This is an almost zero-change in behavior.
The one thing that is different is that previously, IDBTransactionBackends would synchronously
run through their entire set of IDBOperation’s without ever returning control to the runloop.
Now, they start one task and then wait for its completion to schedule the start of the next task.
Change IDBOperation’s perform() to take a completion handler so it can be asynchronous.
Add an IDBSynchronousOperation class to handle "Abort" tasks, which never need to perform i/o
and therefore can be entirely synchronous.
- Modules/indexeddb/IDBOperation.h:
(WebCore::IDBSynchronousOperation::~IDBSynchronousOperation):
- Modules/indexeddb/IDBTransactionBackend.cpp:
(WebCore::IDBTransactionBackend::scheduleTask): "Abort tasks" are now IDBSynchronousOperations.
(WebCore::IDBTransactionBackend::abort):
(WebCore::IDBTransactionBackend::taskTimerFired): Instead of running through the entire set of tasks,
perform a single task asynchronously. The completion handler for the task will reset the task timer
to asynchronously start the next task.
- Modules/indexeddb/IDBTransactionBackend.h:
(WebCore::IDBTransactionBackend::scheduleTask): "Abort tasks" are now IDBSynchronousOperations.
Update all operations to take completion handlers.
For now, perform things synchronously like before, calling the completion handler when complete.
- Modules/indexeddb/IDBCursorBackend.cpp:
(WebCore::CallOnDestruct::CallOnDestruct): Helper class to make sure completion callbacks are always called perform() exits.
(WebCore::CallOnDestruct::~CallOnDestruct):
(WebCore::IDBCursorBackend::CursorIterationOperation::create):
(WebCore::IDBCursorBackend::CursorAdvanceOperation::create):
(WebCore::IDBCursorBackend::CursorPrefetchIterationOperation::create):
(WebCore::IDBCursorBackend::CursorAdvanceOperation::perform):
(WebCore::IDBCursorBackend::CursorIterationOperation::perform):
(WebCore::IDBCursorBackend::CursorPrefetchIterationOperation::perform):
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::CallOnDestruct::CallOnDestruct): Helper class to make sure completion callbacks are always called when perform() exits.
(WebCore::CallOnDestruct::~CallOnDestruct):
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::CreateIndexOperation::perform):
(WebCore::DeleteIndexOperation::perform):
(WebCore::GetOperation::perform):
(WebCore::PutOperation::perform):
(WebCore::SetIndexesReadyOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
(WebCore::ClearOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::perform):
- Modules/indexeddb/IDBTransactionBackendOperations.h:
(WebCore::CreateObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::create):
(WebCore::CreateObjectStoreAbortOperation::create):
(WebCore::DeleteObjectStoreAbortOperation::create):
(WebCore::IDBDatabaseBackend::VersionChangeAbortOperation::create):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexAbortOperation::create):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexAbortOperation::create):
(WebCore::GetOperation::create):
(WebCore::PutOperation::create):
(WebCore::SetIndexesReadyOperation::create):
(WebCore::OpenCursorOperation::create):
(WebCore::CountOperation::create):
(WebCore::DeleteRangeOperation::create):
(WebCore::ClearOperation::create):
- 10:15 PM Changeset in webkit [159094] by
-
- 2 edits in trunk/Source/WebKit2
URTBF after r159077 to make GTK build happy.
- GNUmakefile.list.am:
- 8:39 PM Changeset in webkit [159093] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove some unused generated code
https://bugs.webkit.org/show_bug.cgi?id=124179
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-11
Reviewed by Timothy Hatcher.
- inspector/CodeGeneratorInspectorStrings.py:
- 8:39 PM Changeset in webkit [159092] by
-
- 3 edits in trunk/Source/WebCore
Clean up static_cast<Element*> usage
https://bugs.webkit.org/show_bug.cgi?id=124133
Reviewed by Andreas Kling.
We need to use toFoo cast function instead of static_cast<>. Though there is toElement(),
static_cast<Element*> is still being used.
No new tests, no behavior changes.
- bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap):
- dom/ElementTraversal.h:
(WebCore::::lastWithinTemplate):
(WebCore::::nextTemplate):
(WebCore::::previousTemplate):
- 7:28 PM Changeset in webkit [159091] by
-
- 21 edits in trunk/Source/JavaScriptCore
Get rid of the lastResultRegister optimization in the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=124171
Rubber stamped by Mark Hahnenberg.
The baseline JIT no longer needs amazing throughput. And this optimization has caused
way too many OSR exit bugs. And it constrains how much we can do in the DFG/FTL. So,
I'm getting rid of it.
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::convertToForward):
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileZombieHint):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::convertToForward):
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
(JSC::JIT::appendCall):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_inc):
(JSC::JIT::emit_op_dec):
- jit/JITCall.cpp:
(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileLoadVarargs):
- jit/JITInlines.h:
(JSC::JIT::emitGetFromCallFrameHeaderPtr):
(JSC::JIT::emitGetFromCallFrameHeader32):
(JSC::JIT::emitGetFromCallFrameHeader64):
(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitLoad2):
(JSC::JIT::emitGetVirtualRegister):
(JSC::JIT::emitGetVirtualRegisters):
(JSC::JIT::emitPutVirtualRegister):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_new_func):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emit_op_catch):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_pname):
(JSC::JIT::emitResolveClosure):
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_init_global_const):
- jit/SlowPathCall.h:
(JSC::JITSlowPathCall::call):
- 5:55 PM Changeset in webkit [159090] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r158976): Web Inspector: unable to start docked or dock
https://bugs.webkit.org/show_bug.cgi?id=124148
Reviewed by Timothy Hatcher.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::canAttach): check for a level that is greater than 1 rather than 0
to deny attachment, since 1 is the first level of inspectors.
- 5:51 PM Changeset in webkit [159089] by
-
- 8 edits in trunk/Source
FrameFilter can just be an std::function instead
https://bugs.webkit.org/show_bug.cgi?id=124176
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.exp.in:
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
- loader/archive/cf/LegacyWebArchive.h:
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
(-[DOMNode webArchiveByFilteringSubframes:]):
Source/WebKit2:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::webArchiveData):
- 5:17 PM Changeset in webkit [159088] by
-
- 3 edits in trunk/Source/WebKit2
Remove unused Qt cruft
https://bugs.webkit.org/show_bug.cgi?id=124174
Reviewed by Tim Horton.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- UIProcess/WebPageProxy.h:
- 5:15 PM Changeset in webkit [159087] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 5:13 PM Changeset in webkit [159086] by
-
- 1 copy in tags/Safari-537.73.6
New Tag.
- 5:12 PM Changeset in webkit [159085] by
-
- 1 copy in tags/Safari-537.73.5/safari-537.73-branch
New Tag.
- 5:08 PM Changeset in webkit [159084] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r158927): curly-braces-escaping.html is broken on Mac WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124164
Reviewed by Alexey Proskuryakov.
Back out the change to use NSSecureCoding for encoding/decoding NSURLRequest and
NSURLResponse objects; turns out the NSURL encoding/decoding doesn't preserve the raw URL bytes.
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::encodePlatformData):
(CoreIPC::decodePlatformData):
- 4:52 PM Changeset in webkit [159083] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix on CMake Based port since r159077.
- CMakeLists.txt:
- 4:50 PM Changeset in webkit [159082] by
-
- 5 edits2 adds in trunk
REGRESSION (r155660): box-shadow causes overlay scrollbars to be in the wrong position when element is composited (85647)
https://bugs.webkit.org/show_bug.cgi?id=124090
Source/WebCore:
Reviewed by Beth Dakin.
After r155660 we did fewer layouts, so were left with overlay scrollbars in the
wrong locations because nothing would update them after RenderLayerBacking
computed a new offsetFromRenderer.
First part of the fix is to wean positionOverflowControlsLayers() off of
an absolute offset from the root. Do this by not using Widget::frameRect()
to position the layers, but instead RenderLayer::rectFor{Horizontal|Vertical}Scrollbar
which is what we used to position the scrollbars in the first place.
Second part of the fix is to call positionOverflowControlsLayers() from
RenderLayerBacking::updateGraphicsLayerGeometry() if the offsetFromRenderer
changed.
Test: compositing/overflow/overflow-scrollbar-layer-positions.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::positionOverflowControls):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
- rendering/RenderLayerBacking.h:
LayoutTests:
Reviewed by Beth Dakin.
Test, but it doesn't actually test the fix until we enable overlay scrollbars
in tests (bug 60716).
- compositing/overflow/overflow-scrollbar-layer-positions-expected.txt: Added.
- compositing/overflow/overflow-scrollbar-layer-positions.html: Added.
- 4:33 PM Changeset in webkit [159081] by
-
- 4 edits in trunk/Source/WebCore
[Win] m_isCompositeFontReference is uninitialized.
https://bugs.webkit.org/show_bug.cgi?id=124170
Reviewed by Tim Horton.
Initialize value to false, as is done in the other constructors for this data type.
- platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- platform/graphics/win/FontPlatformDataWin.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 4:21 PM Changeset in webkit [159080] by
-
- 2 edits1 add in trunk/LayoutTests
Actually land a result for the test that I added (and make it a text test).
- compositing/tiling/tiled-in-iframe-expected.txt: Added.
- compositing/tiling/tiled-in-iframe.html:
- 4:20 PM Changeset in webkit [159079] by
-
- 5 edits in trunk/Source/WebKit2
Remote Layer Tree: Implement Page Overlays
https://bugs.webkit.org/show_bug.cgi?id=124165
<rdar://problem/15199056>
Reviewed by Anders Carlsson.
Implement page overlays, very similar to how they work in TiledCoreAnimationDrawingArea,
but manipulating the PlatformCALayer tree instead of the CALayer tree directly.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::outOfTreeLayerWasAdded):
(WebKit::RemoteLayerTreeContext::outOfTreeLayerWillBeRemoved):
(WebKit::RemoteLayerTreeContext::flushLayers):
Add a list of out-of-tree GraphicsLayers which are flushed in addition
to the page's GraphicsLayer tree, and functions to manipulate this list.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
Make RemoteLayerTreeDrawingArea a GraphicsLayerClient, so we can get callbacks
from the GraphicsLayers that drive our page overlays.
Override the relevant page overlay functions.
Add storage for the root layer, view size, and a map of PageOverlay->GraphicsLayer.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
Store the root GraphicsLayer for later use.
(WebKit::RemoteLayerTreeDrawingArea::updateGeometry):
Update the size of the page overlays when the DrawingArea's geometry changes.
(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
Update the page overlay settings when necessary.
(WebKit::RemoteLayerTreeDrawingArea::didInstallPageOverlay):
Create a GraphicsLayer for our page overlay, set it up, and parent it.
Inform the RemoteLayerTreeContext that it will need to flush this GraphicsLayer,
since it's not a part of the page's GraphicsLayer tree.
(WebKit::RemoteLayerTreeDrawingArea::didUninstallPageOverlay):
Tear down our page overlay's GraphicsLayer.
(WebKit::RemoteLayerTreeDrawingArea::setPageOverlayNeedsDisplay):
(WebKit::RemoteLayerTreeDrawingArea::setPageOverlayOpacity):
(WebKit::RemoteLayerTreeDrawingArea::paintContents):
(WebKit::RemoteLayerTreeDrawingArea::deviceScaleFactor):
- 4:19 PM Changeset in webkit [159078] by
-
- 1 edit in branches/safari-537.73-branch/Tools/ChangeLog
svn auth test.
- 3:32 PM Changeset in webkit [159077] by
-
- 7 edits2 adds in trunk/Source/WebKit2
Add a FrameLoadState object and begin moving loading related members from WebFrameProxy
https://bugs.webkit.org/show_bug.cgi?id=124163
Reviewed by Beth Dakin.
- UIProcess/API/C/WKFrame.cpp:
(WKFrameGetFrameLoadState):
- UIProcess/FrameLoadState.cpp: Added.
(WebKit::FrameLoadState::FrameLoadState):
(WebKit::FrameLoadState::~FrameLoadState):
- UIProcess/FrameLoadState.h: Added.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameProxy::didFailProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFinishLoad):
(WebKit::WebFrameProxy::didFailLoad):
(WebKit::WebFrameProxy::didSameDocumentNavigation):
(WebKit::WebFrameProxy::setUnreachableURL):
- UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::frameLoadState):
(WebKit::WebFrameProxy::loadState):
(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):
(WebKit::WebFrameProxy::unreachableURL):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::activeURL):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::loadStateAtProcessExit):
- WebKit2.xcodeproj/project.pbxproj:
- 3:31 PM Changeset in webkit [159076] by
-
- 3 edits4 adds in trunk
[Mac] Characters too close together in complex Arabic text
https://bugs.webkit.org/show_bug.cgi?id=124057
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-11-11
Reviewed by Darin Adler.
Source/WebCore:
We weren't updating our total width variable with run's initial
advance information, leading to widths that were too narrow.
In addition, while initial advances for runs that aren't the first
run are accounted for by baking in the initial advances into the
previous character's advance, the initial advance for the first run
has to be accounted for in ComplexTextController::offsetForPosition.
Test: fast/text/complex-grapheme-cluster-with-initial-advance.html
Test: fast/text/selection-in-initial-advance-region.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Update
total width variable
(WebCore::ComplexTextController::offsetOfPosition): Account for
the first run's initial advance.
LayoutTests:
complex-grapheme-cluster-with-initial-advance adds a span around a word in some
complex Arabic text, and expects that the word spacing is the same as without the
span.
selection-in-initial-advance-region simulates a mouse drag across a complex text run
with an initial advance. This makes sure that ComplexTextController::offsetForPosition
doesn't crash when there is an initial advance.
- fast/text/complex-grapheme-cluster-with-initial-advance-expected.html: Added.
- fast/text/complex-grapheme-cluster-with-initial-advance.html: Added.
- fast/text/selection-in-initial-advance-region-expected.txt: added
- fast/text/selection-in-initial-advance-region.html: added
- 3:29 PM Changeset in webkit [159075] by
-
- 2 edits in trunk/Source/WebKit2
Remove #include from test input of the *Messages.in processing scripts.
https://bugs.webkit.org/show_bug.cgi?id=123563
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-11
Reviewed by Darin Adler.
- Scripts/webkit2/messages_unittest.py:
- 3:01 PM Changeset in webkit [159074] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove ConstantFoldingPhase's weirdo compile-time optimization
https://bugs.webkit.org/show_bug.cgi?id=124169
Reviewed by Mark Hahnenberg.
It turns out that this compile-time optimization doesn't optimize compile times
anymore. Kill it with fire.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 2:47 PM Changeset in webkit [159073] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix for Win64.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Fixed 64-bit linker symbols.
- 2:41 PM Changeset in webkit [159072] by
-
- 7 edits in trunk/Source/WebCore
Make IDBBackingStoreTransaction be RefCounted
https://bugs.webkit.org/show_bug.cgi?id=124168
Reviewed by Tim Horton.
This is necessarily to safely add a fully asynchronous interface into the IDB mechanism.
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBBackingStoreTransactionInterface.h:
- Modules/indexeddb/IDBTransactionBackend.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::createBackingStoreTransaction):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h:
- 2:39 PM Changeset in webkit [159071] by
-
- 9 edits2 adds in trunk
End of line whitespace should collapse with white-space:pre-wrap; overflow-wrap:break-word in all cases
https://bugs.webkit.org/show_bug.cgi?id=124158
Source/WebCore:
Reviewed by Dave Hyatt.
If a word just fits the line but the following space overflows we fail to collapse whitespaces
at the end of the line. This happens because with break-word we end up taking word breaking
code path that does not have pre-wrap whitespace handling.
This patch makes the behavior consistent and also matches Firefox.
Test: fast/text/break-word-pre-wrap.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::BreakingContext::handleText):
Don't take the word break code path if we are pre-wrap and the current character is space.
Instead proceed to break the line normally as this is a valid break position.
LayoutTests:
Reviewed by Dave Hyatt.
Added a specific test and updates the test results of some complex tests that demonstrate the same issue.
- fast/text/break-word-pre-wrap-expected.html: Added.
- fast/text/break-word-pre-wrap.html: Added.
- platform/mac/fast/forms/basic-textareas-expected.png:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- platform/mac/fast/forms/basic-textareas-quirks-expected.png:
- platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
- platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
- platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.txt:
- 2:25 PM Changeset in webkit [159070] by
-
- 9 edits3 adds in trunk
Web Inspector: [CSS Shapes] Highlight shape-outside when its element is selected in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=124071
Reviewed by Timothy Hatcher.
Source/WebCore:
Adding code to pass computed shape information (path and bounds) to the Inspector overlay
canvas, and the code to display it. The code creates a path based on ShapeInfo's computed
shape. The shape highlight draws whenever an element is highlighted, via selection in
the Inspector elements view.
Test: inspector-protocol/model/highlight-shape-outside.html
- inspector/InspectorOverlay.cpp:
(WebCore::localPointToRoot): Convert a local point to be relative to the root view.
(WebCore::appendPathCommandAndPoints): Helper for building a single segment's worth
of the overall path.
(WebCore::appendPathSegment): Build a single segment's worth of the overall path.
(WebCore::buildObjectForShapeOutside): Build an object to pass to the Inspector overlay
that represents the shape.
(WebCore::buildObjectForElementInfo): Call buildObjectForShapeOutside and pass the
resulting object along.
- inspector/InspectorOverlayPage.js:
(pathCommand): Draw a single path command.
(drawPath): Draw the overall path.
(_drawShapeHighlight): Draw the highlight for the given shapeInfo.
(drawNodeHighlight): Call _drawShapeHighlight.
- rendering/shapes/PolygonShape.h:
(WebCore::PolygonShape::polygon): Expose the underlying vertex information for a
PolygonShape.
- rendering/shapes/RasterShape.h:
- rendering/shapes/RectangleShape.h:
(WebCore::RectangleShape::logicalRx): Expose the logical radii for a shape.
(WebCore::RectangleShape::logicalRy): Ditto.
- rendering/shapes/Shape.h:
- rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::computedShapePhysicalBoundingBox): The physical bounds of a
shape in renderer coordinates.
(WebCore::ShapeInfo::shapeToRendererPoint): Convert shape coordinates to renderer
coordinates.
(WebCore::ShapeInfo::shapeToRendererSize): Ditto.
(WebCore::ShapeInfo::ShapeInfo):
LayoutTests:
Test that the information passed to the Inspector overlay properly corresponds to the
underlying shape. Retrieving the shape highlight information involves a series of
steps and has been abstracted into shape-info-helper.js, which supplies
Inspector.shapeOutsideInfo inside an Inspector test, and the ShapeInfoHelper.runShapesTest
method to begin a test.
- inspector-protocol/model/highlight-shape-outside-expected.txt: Added.
- inspector-protocol/model/highlight-shape-outside.html: Added.
- inspector-protocol/resources/shape-info-helper.js: Added.
(window.ShapeInfoHelper): Exposes ShapeInfoHelper.runShapesTest.
- 1:46 PM Changeset in webkit [159069] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make bytecode dumping use the right opcode names for inc/dec.
Rubber stamped by Mark Hahnenberg.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- 1:20 PM Changeset in webkit [159068] by
-
- 7 edits4 copies in trunk/Source/WebCore
Support WebCrypto KeyPair interface
https://bugs.webkit.org/show_bug.cgi?id=124161
Reviewed by Geoffrey Garen.
No new tests yet, will be tested once generateKey is implemented for any RSA algorithms.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
Added new files.
- bindings/js/JSDOMPromise.h: Support returning a key pair via a promise.
- bindings/js/JSCryptoKeyPairCustom.cpp: Added.
(WebCore::JSCryptoKeyPair::visitChildren):
- crypto/CryptoKey.idl:
CryptoKey wrapper is reachable through KeyPair, but it doesn't have (or need)
a back pointer.
- crypto/CryptoKeyPair.cpp: Added.
(WebCore::CryptoKeyPair::CryptoKeyPair):
(WebCore::CryptoKeyPair::~CryptoKeyPair):
- crypto/CryptoKeyPair.h: Added.
(WebCore::CryptoKeyPair::create):
(WebCore::CryptoKeyPair::publicKey):
(WebCore::CryptoKeyPair::privateKey):
- crypto/CryptoKeyPair.idl: Added.
- 1:09 PM Changeset in webkit [159067] by
-
- 3 edits1 move in trunk
AX: support helpText() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=40194
Reviewed by Chris Fleizach.
Tools:
Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::helpText):
LayoutTests:
Moving layout test back to its original location. Shouldn't be platform specific.
- accessibility/aria-help.html: Renamed from LayoutTests/platform/mac/accessibility/aria-help.html.
- 1:05 PM Changeset in webkit [159066] by
-
- 6 edits in trunk/LayoutTests
Unreviewed EFL gardening
Update test expectations after r158188.
- platform/efl/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
- platform/efl/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
- platform/efl/css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
- platform/efl/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
- platform/efl/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
- 1:04 PM Changeset in webkit [159065] by
-
- 2 edits in trunk/Source/WebCore
Fix build after r158967
https://bugs.webkit.org/show_bug.cgi?id=124160
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-11
Reviewed by Anders Carlsson.
After r158967, gcc debug builds with "-Werror=type-limits" enabled
fail. This patch fixes it.
- rendering/shapes/RasterShape.h:
(WebCore::RasterShapeIntervals::intervalsAt):
- 12:57 PM Changeset in webkit [159064] by
-
- 5 edits3 adds in trunk
DFG Int52 boxing code may clobber the source without telling anyone
https://bugs.webkit.org/show_bug.cgi?id=124137
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::boxInt52): This is called in places where source is expected to be unchanged. We never call this expecting super-amazing codegen. So, preserve the source's value the dumb way (by recovering it mathematically).
- jit/AssemblyHelpers.h: Document the invariant for boxInt52.
- jsc.cpp:
(GlobalObject::finishCreation): It's been super annoying that sometimes we say noInline() and sometimes we say neverInlineFunction(). The LayoutTests harnesses ensure that we have something called noInline(), but it's great to also ensure that the shell has it.
LayoutTests:
Reviewed by Mark Hahnenberg.
Write the test as a JSRegress test because we currently need a couple
recompiles to get the bug. JSRegress tests are meant to be longer-running
stress tests and they are usually run with different compilation thresholds, so
that ensures that we will actually hit the relevant code path.
- js/regress/int52-spill-expected.txt: Added.
- js/regress/int52-spill.html: Added.
- js/regress/script-tests/int52-spill.js: Added.
(bar):
(foo):
- 12:53 PM Changeset in webkit [159063] by
-
- 9 edits in trunk
ExtJS breaks with modern Array.prototype.values API due to use of with()
https://bugs.webkit.org/show_bug.cgi?id=123440
Reviewed by Beth Dakin.
Source/JavaScriptCore:
As with our attempt to make Arguments use the Array prototype, ExtJS has
a weird dependency on not adding new APIs to core types. In this case
Array.prototype.values. The fix is to remove it, and push for ES6 to drop
the API.
- runtime/ArrayPrototype.cpp:
LayoutTests:
Update tests for removal of Array.prototype.values, and add test to ensure that
it's gone.
- js/Object-getOwnPropertyNames-expected.txt:
- js/array-iterators-expected.txt:
- js/basic-for-of-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/array-iterators.js:
- js/script-tests/basic-for-of.js:
- 12:17 PM Changeset in webkit [159062] by
-
- 2 edits in trunk/LayoutTests
Fix layout test
- 11:58 AM Changeset in webkit [159061] by
-
- 238 edits in trunk/Source/WebCore
Remove the OperationsNotDeletable attribute from most of the WebIDL interfaces
https://bugs.webkit.org/show_bug.cgi?id=124151
Reviewed by Geoffrey Garen.
The OperationsNotDeletable attribute currently doesn't have any effect, but will soon enforce
non-configurability of operations on the interface that uses the attribute. Non-configurability
of operations is the default behavior at the moment, but will be changed to follow the WebIDL
specification which requires that the operations are configurable (i.e. -- in JSC terms -- deletable).
IE and Firefox already exhibit this behavior in the majority of cases, while Chrome and Opera don't.
The attribute remains in use on the Location interface to mimic the Unforgeable attribute which
also makes operations of an interface non-configurable. Unforgeable attribute will be used instead
when support for it will be added to the JSC bindings generator.
- Modules/battery/BatteryManager.idl:
- Modules/encryptedmedia/MediaKeySession.idl:
- Modules/encryptedmedia/MediaKeys.idl:
- Modules/gamepad/GamepadList.idl:
- Modules/geolocation/Geolocation.idl:
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBFactory.idl:
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBKeyRange.idl:
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/indexeddb/IDBTransaction.idl:
- Modules/indexeddb/IDBVersionChangeEvent.idl:
- Modules/mediacontrols/MediaControlsHost.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/RTCDTMFSender.idl:
- Modules/mediastream/RTCDataChannel.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/RTCStatsResponse.idl:
- Modules/networkinfo/NetworkInfoConnection.idl:
- Modules/notifications/Notification.idl:
- Modules/notifications/NotificationCenter.idl:
- Modules/proximity/DeviceProximityEvent.idl:
- Modules/quota/StorageInfo.idl:
- Modules/quota/StorageQuota.idl:
- Modules/speech/SpeechGrammarList.idl:
- Modules/speech/SpeechRecognition.idl:
- Modules/speech/SpeechRecognitionResult.idl:
- Modules/speech/SpeechRecognitionResultList.idl:
- Modules/speech/SpeechSynthesis.idl:
- Modules/webaudio/AnalyserNode.idl:
- Modules/webaudio/AudioBuffer.idl:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioListener.idl:
- Modules/webaudio/AudioNode.idl:
- Modules/webaudio/AudioParam.idl:
- Modules/webaudio/BiquadFilterNode.idl:
- Modules/webaudio/OscillatorNode.idl:
- Modules/webaudio/PannerNode.idl:
- Modules/webdatabase/Database.idl:
- Modules/webdatabase/DatabaseSync.idl:
- Modules/webdatabase/SQLResultSetRowList.idl:
- Modules/webdatabase/SQLTransaction.idl:
- Modules/webdatabase/SQLTransactionSync.idl:
- Modules/websockets/WebSocket.idl:
- crypto/CryptoKey.idl:
- crypto/SubtleCrypto.idl:
- css/CSSHostRule.idl:
- css/CSSMediaRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- css/CSSSupportsRule.idl:
- css/CSSValueList.idl:
- css/DOMWindowCSS.idl:
- css/FontLoader.idl:
- css/MediaList.idl:
- css/MediaQueryList.idl:
- css/MediaQueryListListener.idl:
- css/StyleMedia.idl:
- css/StyleSheet.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSFilterValue.idl:
- css/WebKitCSSKeyframesRule.idl:
- css/WebKitCSSMatrix.idl:
- css/WebKitCSSTransformValue.idl:
- dom/CharacterData.idl:
- dom/ChildNode.idl:
- dom/ClientRectList.idl:
- dom/Clipboard.idl:
- dom/CompositionEvent.idl:
- dom/CustomEvent.idl:
- dom/DOMCoreException.idl:
- dom/DOMImplementation.idl:
- dom/DOMNamedFlowCollection.idl:
- dom/DOMStringList.idl:
- dom/DOMStringMap.idl:
- dom/DataTransferItem.idl:
- dom/DataTransferItemList.idl:
- dom/DeviceMotionEvent.idl:
- dom/DeviceOrientationEvent.idl:
- dom/Document.idl:
- dom/DocumentFragment.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/EventException.idl:
- dom/EventListener.idl:
- dom/EventTarget.idl:
- dom/HashChangeEvent.idl:
- dom/KeyboardEvent.idl:
- dom/MessageEvent.idl:
- dom/MessagePort.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/MutationObserver.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeFilter.idl:
- dom/NodeIterator.idl:
- dom/NodeList.idl:
- dom/Range.idl:
- dom/RangeException.idl:
- dom/ShadowRoot.idl:
- dom/Text.idl:
- dom/TextEvent.idl:
- dom/TouchEvent.idl:
- dom/TouchList.idl:
- dom/TreeWalker.idl:
- dom/UIEvent.idl:
- dom/WebKitNamedFlow.idl:
- dom/WheelEvent.idl:
- fileapi/Blob.idl:
- fileapi/FileException.idl:
- fileapi/FileList.idl:
- fileapi/FileReader.idl:
- fileapi/FileReaderSync.idl:
- html/DOMFormData.idl:
- html/DOMSettableTokenList.idl:
- html/DOMTokenList.idl:
- html/DOMURL.idl:
- html/HTMLAllCollection.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLButtonElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLCollection.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLFormControlsCollection.idl:
- html/HTMLFormElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLKeygenElement.idl:
- html/HTMLMarqueeElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLOutputElement.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTableElement.idl:
- html/HTMLTableRowElement.idl:
- html/HTMLTableSectionElement.idl:
- html/HTMLTextAreaElement.idl:
- html/HTMLVideoElement.idl:
- html/MediaController.idl:
- html/RadioNodeList.idl:
- html/TimeRanges.idl:
- html/canvas/CanvasGradient.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/DOMPath.idl:
- html/canvas/EXTDrawBuffers.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLLoseContext.idl:
- html/canvas/WebGLRenderingContext.idl:
- html/track/AudioTrackList.idl:
- html/track/TextTrack.idl:
- html/track/TextTrackCue.idl:
- html/track/TextTrackCueList.idl:
- html/track/TextTrackList.idl:
- html/track/TextTrackRegionList.idl:
- html/track/VideoTrackList.idl:
- loader/appcache/DOMApplicationCache.idl:
- page/Console.idl:
- page/Crypto.idl:
- page/DOMSecurityPolicy.idl:
- page/DOMSelection.idl:
- page/DOMWindow.idl:
- page/EventSource.idl:
- page/History.idl:
- page/Navigator.idl:
- page/Performance.idl:
- page/PerformanceEntryList.idl:
- page/SpeechInputResultList.idl:
- page/WindowBase64.idl:
- page/WindowTimers.idl:
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPlugin.idl:
- plugins/DOMPluginArray.idl:
- storage/Storage.idl:
- storage/StorageEvent.idl:
- svg/SVGAngle.idl:
- svg/SVGAnimationElement.idl:
- svg/SVGColor.idl:
- svg/SVGCursorElement.idl:
- svg/SVGDocument.idl:
- svg/SVGElement.idl:
- svg/SVGElementInstanceList.idl:
- svg/SVGException.idl:
- svg/SVGFEDropShadowElement.idl:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFilterElement.idl:
- svg/SVGGraphicsElement.idl:
- svg/SVGLength.idl:
- svg/SVGLengthList.idl:
- svg/SVGMarkerElement.idl:
- svg/SVGMaskElement.idl:
- svg/SVGMatrix.idl:
- svg/SVGNumberList.idl:
- svg/SVGPaint.idl:
- svg/SVGPathElement.idl:
- svg/SVGPathSegList.idl:
- svg/SVGPatternElement.idl:
- svg/SVGPoint.idl:
- svg/SVGPointList.idl:
- svg/SVGSVGElement.idl:
- svg/SVGStringList.idl:
- svg/SVGTests.idl:
- svg/SVGTextContentElement.idl:
- svg/SVGTransform.idl:
- svg/SVGTransformList.idl:
- workers/DedicatedWorkerGlobalScope.idl:
- workers/Worker.idl:
- workers/WorkerGlobalScope.idl:
- workers/WorkerLocation.idl:
- xml/DOMParser.idl:
- xml/XMLHttpRequest.idl:
- xml/XMLHttpRequestException.idl:
- xml/XMLHttpRequestUpload.idl:
- xml/XMLSerializer.idl:
- xml/XPathEvaluator.idl:
- xml/XPathException.idl:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
- xml/XPathResult.idl:
- xml/XSLTProcessor.idl:
- 11:49 AM Changeset in webkit [159060] by
-
- 1 edit3 adds in trunk/LayoutTests
Add a testcase for a tiled layer inside an iframe
https://bugs.webkit.org/show_bug.cgi?id=124159
Reviewed by Tim Horton.
Add a test for a tiled compositing layer inside an iframe.
- compositing/tiling/resources/tiled-layer-tall.html: Added.
- compositing/tiling/tiled-in-iframe.html: Added.
- 11:18 AM Changeset in webkit [159059] by
-
- 10 edits in trunk
Remove block based APIs from the WebKit2 C API
https://bugs.webkit.org/show_bug.cgi?id=124157
Reviewed by Sam Weinig.
Source/WebKit2:
Remove most of the block based C APIs from WebKit2. We want to discourage people from using
them since any C API "objects" captured by blocks won't be implicitly retained which
can lead to dangling pointer bugs.
- UIProcess/API/C/WKDatabaseManager.cpp:
- UIProcess/API/C/WKDatabaseManager.h:
- UIProcess/API/C/WKFrame.cpp:
- UIProcess/API/C/WKFrame.h:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKPagePrivate.h:
Tools:
Update for WK2 changes.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(dumpSource):
(-[WK2BrowserWindowController dumpSourceToConsole:]):
- 10:21 AM Changeset in webkit [159058] by
-
- 1 copy in releases/WebKitGTK/webkit-2.2.2
Tagging the WebKitGTK+ 2.2.2 release
- 10:21 AM Changeset in webkit [159057] by
-
- 8 edits12 adds in trunk
[CSS Regions] Selection focusNode set to the "region" block, instead of the "source" block
https://bugs.webkit.org/show_bug.cgi?id=120769
Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-11-11
Reviewed by David Hyatt.
Source/WebCore:
When a point hits a Region block, current positionForPoint algorithm determines its
position in the DOM and returns either the start or end offset for such block, since
Region blocks have no children in the DOM.
It's necessary to map the point into Flow Thread coordinates in order to determine
the DOM position of the specific element rendered by the Region.
Top margin, padding and border points should be mapped to the beginning of the Region
block, while bottom points are mapped to the block end. The Left coordinate its just
adjusted to fit in the Flow Thread boundaries, since its not affected by the Flow
direction.
Besides, when inspecting the Flow Thread blocks looking for the last candidate box,
the Region originally associated to the point might be taken into account. Only the
blocks/boxes rendered by the Region are potential candidates.
Tests: fast/regions/selection/position-for-point-1-vert-lr.html
fast/regions/selection/position-for-point-1-vert-rl.html
fast/regions/selection/position-for-point-1.html
fast/regions/selection/position-for-point-vert-lr.html
fast/regions/selection/position-for-point-vert-rl.html
fast/regions/selection/position-for-point.html
- rendering/RenderBlock.cpp:
(WebCore::isChildHitTestCandidate):
(WebCore::RenderBlock::positionForPoint):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::positionForPoint): Added.
It just redirects the call to the associated RenderNamedFlowFragment instance.
- rendering/RenderBlockFlow.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::mapRegionPointIntoFlowThreadCoordinates): Added.
It performs the coordinates mapping.
(WebCore::RenderRegion::positionForPoint): Added.
It determines the corresponding LayoutPoint in the FlowThread the Region
is associated to, forwarding the call to the RenderBlock class using the
FlowThread's first child block and such new point.
- rendering/RenderRegion.h:
LayoutTests:
- fast/regions/resources/helper.js:
(selectContentFromIdToPos):
(selectContentFromIdToPosVert):
(.document.onmouseup):
(onMouseUpLogSelectionAndFocus):
- fast/regions/selection/position-for-point-1-expected.txt: Added.
- fast/regions/selection/position-for-point-1-vert-lr-expected.txt: Added.
- fast/regions/selection/position-for-point-1-vert-lr.html: Added.
- fast/regions/selection/position-for-point-1-vert-rl-expected.txt: Added.
- fast/regions/selection/position-for-point-1-vert-rl.html: Added.
- fast/regions/selection/position-for-point-1.html: Added.
- fast/regions/selection/position-for-point-expected.txt: Added.
- fast/regions/selection/position-for-point-vert-lr-expected.txt: Added.
- fast/regions/selection/position-for-point-vert-lr.html: Added.
- fast/regions/selection/position-for-point-vert-rl-expected.txt: Added.
- fast/regions/selection/position-for-point-vert-rl.html: Added.
- fast/regions/selection/position-for-point.html: Added.
- 10:19 AM Changeset in webkit [159056] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2
Unreviewed. Update NEWS and Versions.m4 for 2.2.2 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Add release notes.
- 10:14 AM Changeset in webkit [159055] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix CPU(ARM_TRADITIONAL) build after r159039.
https://bugs.webkit.org/show_bug.cgi?id=124149
Reviewed by Geoffrey Garen.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::firstRegister):
(JSC::ARMAssembler::lastRegister):
(JSC::ARMAssembler::firstFPRegister):
(JSC::ARMAssembler::lastFPRegister):
- assembler/MacroAssemblerARM.h:
- jit/FPRInfo.h:
- 10:00 AM Changeset in webkit [159054] by
-
- 4 edits in trunk/Source/WebKit
[Mac] .exp files are not source code
https://bugs.webkit.org/show_bug.cgi?id=124154
Reviewed by Andy Estes.
../WebKit:
- WebKit.xcodeproj/project.pbxproj: Removed WebKit.iOS.exp from the Compile Sources build
phase.
../WebKit/mac:
- Configurations/WebKit.xcconfig: Removed WebKit.iOS.exp from
EXCLUDED_SOURCE_FILE_NAMES_macosx.
- 9:37 AM Changeset in webkit [159053] by
-
- 4 edits in trunk/Source/WebCore
[curl] Remove unused includes.
https://bugs.webkit.org/show_bug.cgi?id=120415
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-11
Reviewed by Csaba Osztrogonác.
Original patch by 2013-08-28 Tamas Czene <tczene@inf.u-szeged.hu>
- platform/network/curl/ProxyServerCurl.cpp:
- platform/network/curl/ResourceHandleCurl.cpp:
- platform/network/curl/ResourceHandleManager.cpp:
- 9:37 AM Changeset in webkit [159052] by
-
- 5 edits in trunk/Tools
The feeder queue will not feed patches older than one week.
https://bugs.webkit.org/show_bug.cgi?id=107152
Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-11-11
Reviewed by Csaba Osztrogonác.
The feeder queue will not feed patches older than one week.
Unit test added to this scenario.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries._parse_attachment_ids_request_query):
Handle date parameter.
(BugzillaQueries):
(BugzillaQueries._fetch_attachment_ids_request_query):
Propagate date.
(BugzillaQueries.fetch_attachment_ids_from_review_queue):
Propagate date.
- Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
Handle date.
- Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_request_page_parsing):
Unit test added.
- Scripts/webkitpy/tool/bot/feeders.py:
(EWSFeeder.feed):
Query patch ids with date parameter (now - 1 week).
- 9:33 AM Changeset in webkit [159051] by
-
- 2 edits in trunk/Tools
Do not shut down ImageDiff server after every diff during the tests.
https://bugs.webkit.org/show_bug.cgi?id=124140
Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-11-11
Reviewed by Csaba Osztrogonác.
There was a FIXME: There is no need to shut down the ImageDiff
server after every diff. Shutdown is removed from that point.
- Scripts/webkitpy/port/image_diff.py:
(ImageDiffer._read):
- 9:28 AM Changeset in webkit [159050] by
-
- 2 edits in trunk/Source/WebCore
URTBF after r159027 to make Apple Windows build happy.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::sharedBufferGetBytesAtPosition):
- 2:38 AM WebKitGTK/2.2.x edited by
- (diff)
- 2:33 AM Changeset in webkit [159049] by
-
- 5 edits in trunk/Source/WebCore
Kill InlineFlowBox::rendererLineBoxes().
<https://webkit.org/b/124141>
We only ever used this to access the RenderLineBoxList for non-root
boxes, and those always have a RenderInline renderer.
Tighten things up by losing the virtual rendererLineBoxes() and
calling RenderInline::lineBoxes() directly.
Reviewed by Antti Koivisto.
- 2:13 AM Changeset in webkit [159048] by
-
- 9 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r159042 - [GTK] Crash when printing via javascript in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124043
Reviewed by Martin Robinson.
It happens because the print operation when started by the
WebProcess due to a DOM operation is supposed to be synchronous
and our print operation is always asynchronous. This is currently
handled only in the UI process because other ports print
synchronously in the WebProcess. In the GTK+ port we need to
notify the WebProcess that the print operation should run
synchronously when request by a DOM operation. Together with the
print settings and page setup we now send a print mode that can be
sync or async. When printing in sync mode we run a nested main loop
for the print operation, making sure that print sources have a
higher priority.
- Shared/PrintInfo.cpp:
(WebKit::PrintInfo::encode): Encode the print mode.
(WebKit::PrintInfo::decode): Decode the print mode.
- Shared/PrintInfo.h: Add PrintMode enum.
- Shared/gtk/PrintInfoGtk.cpp:
(WebKit::PrintInfo::PrintInfo): Initialize print mode.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted): Do not call endPrinting() when
printing synchronously because WebPageProxy already calls it right
after sending the message to the WebProcess.
(webkitPrintOperationPrintPagesForFrame): Create the PrintInfo
struct with a print mode.
(webkitPrintOperationSetPrintMode): Helper private function to set
the print mode of the print operation.
- UIProcess/API/gtk/WebKitPrintOperationPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPrintFrame): Set sync print mode when printing due
to a UIClient request.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Create a main loop when
printing synchronously.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
print mode.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Finish the
nested main loop when printing synchronously.
(WebKit::WebPrintOperationGtk::print): Run a nested main loop when
printing synchronously.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
(WebKit::WebPrintOperationGtk::printMode): Return the print mode.
- 2:11 AM WebKitGTK/2.2.x edited by
- (diff)
- 2:10 AM Changeset in webkit [159047] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r159041 - [GTK] [WebKit2] Crash when printing to a file via javascript
https://bugs.webkit.org/show_bug.cgi?id=122801
Reviewed by Martin Robinson.
This crash is caused by a GTK+ bug, but we can work around it by
ensuring the print dialog is always shown with a valid
GtkPrintSettings object.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialog):
- 2:07 AM WebKitGTK/2.2.x edited by
- (diff)
- 2:07 AM Changeset in webkit [159046] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r156892 - [GTK] Enable text edition UndoOperations support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122305
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-10-04
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
Replaced the notImplemented() function calls for
the corresponding implementation of the edit operations
provided by the DefaultUndoController class.
- GNUmakefile.list.am:
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):
- UIProcess/API/gtk/PageClientImpl.h:
- 2:05 AM WebKitGTK/2.2.x edited by
- (diff)
- 1:52 AM Changeset in webkit [159045] by
-
- 3 edits in releases/WebKitGTK/webkit-2.2/Source/WTF
Merge r158445 - HPPA build fixes
https://bugs.webkit.org/show_bug.cgi?id=123625
Original patch from John David Anglin <dave.anglin@bell.net>
Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.
- wtf/Platform.h:
- wtf/dtoa/utils.h:
- 1:50 AM WebKitGTK/2.2.x edited by
- (diff)
- 1:38 AM Changeset in webkit [159044] by
-
- 4 edits in trunk/Source/WebCore
Bring the LineFragmentationData back to RootInlineBox.
<https://webkit.org/b/124136>
Now that we have the simple line layout path, almost all the root
line boxes end up with some kind of fragmentation data, so we might
as well put the members back on RootInlineBox and avoid the extra
allocation (and indirection.)
1.74 MB progression on HTML5 spec at <http://whatwg.org/c>
Reviewed by Antti Koivisto.
- 1:22 AM Changeset in webkit [159043] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r158444 - Fix build on non-linux platforms
https://bugs.webkit.org/show_bug.cgi?id=123622
Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
- 1:20 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:30 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:30 AM Changeset in webkit [159042] by
-
- 9 edits in trunk/Source/WebKit2
[GTK] Crash when printing via javascript in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124043
Reviewed by Martin Robinson.
It happens because the print operation when started by the
WebProcess due to a DOM operation is supposed to be synchronous
and our print operation is always asynchronous. This is currently
handled only in the UI process because other ports print
synchronously in the WebProcess. In the GTK+ port we need to
notify the WebProcess that the print operation should run
synchronously when request by a DOM operation. Together with the
print settings and page setup we now send a print mode that can be
sync or async. When printing in sync mode we run a nested main loop
for the print operation, making sure that print sources have a
higher priority.
- Shared/PrintInfo.cpp:
(WebKit::PrintInfo::encode): Encode the print mode.
(WebKit::PrintInfo::decode): Decode the print mode.
- Shared/PrintInfo.h: Add PrintMode enum.
- Shared/gtk/PrintInfoGtk.cpp:
(WebKit::PrintInfo::PrintInfo): Initialize print mode.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted): Do not call endPrinting() when
printing synchronously because WebPageProxy already calls it right
after sending the message to the WebProcess.
(webkitPrintOperationPrintPagesForFrame): Create the PrintInfo
struct with a print mode.
(webkitPrintOperationSetPrintMode): Helper private function to set
the print mode of the print operation.
- UIProcess/API/gtk/WebKitPrintOperationPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPrintFrame): Set sync print mode when printing due
to a UIClient request.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Create a main loop when
printing synchronously.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
print mode.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Finish the
nested main loop when printing synchronously.
(WebKit::WebPrintOperationGtk::print): Run a nested main loop when
printing synchronously.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
(WebKit::WebPrintOperationGtk::printMode): Return the print mode.
- 12:24 AM Changeset in webkit [159041] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [WebKit2] Crash when printing to a file via javascript
https://bugs.webkit.org/show_bug.cgi?id=122801
Reviewed by Martin Robinson.
This crash is caused by a GTK+ bug, but we can work around it by
ensuring the print dialog is always shown with a valid
GtkPrintSettings object.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialog):
Nov 10, 2013:
- 11:43 PM Changeset in webkit [159040] by
-
- 6 edits in trunk/LayoutTests
[EFL] Layout tests with css1 box properties need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124135
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-10
Reviewed by Gyuyoung Kim.
EFL css1 rebaseline after r101343 for EFL gardening.
- platform/efl/css1/box_properties/margin_right-expected.txt:
- platform/efl/css1/box_properties/padding-expected.txt:
- platform/efl/css1/box_properties/padding_left-expected.txt:
- platform/efl/css1/box_properties/padding_right-expected.txt:
- platform/efl/css1/box_properties/padding_top-expected.txt:
- 11:30 PM Changeset in webkit [159039] by
-
- 26 edits in trunk/Source
Switch FTL GetById/PutById IC's over to using AnyRegCC
https://bugs.webkit.org/show_bug.cgi?id=124094
Source/JavaScriptCore:
Reviewed by Sam Weinig.
This closes the loop on inline caches (IC's) in the FTL. The goal is to have IC's
in LLVM-generated code that are just as efficient (if not more so) than what a
custom JIT could do. As in zero sources of overhead. Not a single extra instruction
or even register allocation pathology. We accomplish this by having two thingies in
LLVM. First is the llvm.experimental.patchpoint intrinsic, which is sort of an
inline machine code snippet that we can fill in with whatever we want and then
modify subsequently. But you have only two choices of how to pass values to a
patchpoint: (1) via the calling convention or (2) via the stackmap. Neither are good
for operands to an IC (like the base pointer for a GetById, for example). (1) is bad
because it results in things being pinned to certain registers a priori; a custom
JIT (like the DFG) will not pin IC operands to any registers a priori but will allow
the register allocator to do whatever it wants. (2) is bad because the operands may
be spilled or may be represented in other crazy ways. You generally want an IC to
have its operands in registers. Also, patchpoints only return values using the
calling convention, which is unfortunate since it pins the return value to a
register a priori. This is where the second thingy comes in: the AnyRegCC. This is
a special calling convention only for use with patchpoints. It means that arguments
passed "by CC" in the patchpoint can be placed in any register, and the register
that gets used is reported as part of the stackmap. It also means that the return
value (if there is one) can be placed in any register, and the stackmap will tell
you which one it was. Thus, patchpoints combined with AnyRegCC mean that you not
only get the kind of self-modifying code that you want for IC's, but you also get
all of the register allocation goodness that a custom JIT would have given you.
Except that you're getting it from LLVM and not a custom JIT. Awesome.
Even though all of the fun stuff is on the LLVM side, this patch was harder than
you'd expect.
First the obvious bits:
- IC patchpoints now use AnyRegCC instead of the C CC. (CC = calling convention.)
- FTL::fixFunctionBasedOnStackMaps() now correctly figures out which registers the IC is supposed to use instead of assuming C CC argument registers.
And then all of the stuff that broke and that this patch fixes:
- IC sizing based on generating a dummy IC (what FTLInlineCacheSize did) is totally bad on x86-64, where various register permutations lead to bizarre header bytes and eclectic SIB encodings. I changed that to have magic constants, for now.
- Slow path calls didn't preserve the CC return register.
- Repatch's scratch register allocation would get totally confused if the operand registers weren't one of the DFG-style "temp" registers. And by "totally confused" I mean that it would crash.
- We assumed that r10 is callee-saved. It's not. That one dude's PPT about x86-64 cdecl that I found on the intertubes was not a trustworthy source of information, apparently.
- Call repatching didn't know that the FTL does its IC slow calls via specially generated thunks. This was particularly fun to fix: basically, now when we relink an IC call in the FTL, we use the old call target to find the SlowPathCallKey, which tells us everything we need to know to generate (or look up) a new thunk for the new function we want to call.
- assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::isEmptyValue):
(JSC::MacroAssemblerCodePtr::isDeletedValue):
(JSC::MacroAssemblerCodePtr::hash):
(JSC::MacroAssemblerCodePtr::emptyValue):
(JSC::MacroAssemblerCodePtr::deletedValue):
(JSC::MacroAssemblerCodePtrHash::hash):
(JSC::MacroAssemblerCodePtrHash::equal):
- assembler/MacroAssemblerX86Common.h:
- assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::codeBlock):
- ftl/FTLAbbreviations.h:
(JSC::FTL::setInstructionCallingConvention):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLInlineCacheSize.cpp:
(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::forStackmaps):
- ftl/FTLLocation.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compilePutById):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLSlowPathCall.cpp:
- ftl/FTLSlowPathCallKey.h:
(JSC::FTL::SlowPathCallKey::withCallTarget):
- ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::Location::directGPR):
(JSC::FTL::StackMaps::Location::restoreInto):
- ftl/FTLStackMaps.h:
- ftl/FTLThunks.h:
(JSC::FTL::generateIfNecessary):
(JSC::FTL::keyForThunk):
(JSC::FTL::Thunks::keyForSlowPathCallThunk):
- jit/FPRInfo.h:
(JSC::FPRInfo::toIndex):
- jit/GPRInfo.h:
(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):
- jit/RegisterSet.cpp:
(JSC::RegisterSet::calleeSaveRegisters):
- jit/RegisterSet.h:
(JSC::RegisterSet::filter):
- jit/Repatch.cpp:
(JSC::readCallTarget):
(JSC::repatchCall):
(JSC::repatchByIdSelfAccess):
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::resetGetByID):
(JSC::resetPutByID):
- jit/ScratchRegisterAllocator.h:
(JSC::ScratchRegisterAllocator::lock):
Source/WTF:
Reviewed by Sam Weinig.
I needed to add another set operation, namely filter(), which is an in-place set
intersection.
- wtf/BitVector.cpp:
(WTF::BitVector::filterSlow):
- wtf/BitVector.h:
(WTF::BitVector::filter):
- 10:20 PM Changeset in webkit [159038] by
-
- 5 edits in trunk/Source/WebCore
Shrink RenderInline.
<https://webkit.org/b/124134>
Move the "always create line boxes" bit from RenderInline up to
RenderElement. I didn't do this earlier because there were no bits
free on RenderObject but thanks to RenderElement we now have tons!
540 kB progression on HTML5 spec at <http://whatwg.org/c>
Reviewed by Anders Carlsson.
- 8:58 PM Changeset in webkit [159037] by
-
- 2 edits in trunk/Source/WTF
[EFL] Build break on Ubuntu 13.10
https://bugs.webkit.org/show_bug.cgi?id=124131
Reviewed by Gyuyoung Kim.
Turned DisallowCType macros off on EFL port because gtest-internal.h uses isspace().
- wtf/DisallowCType.h: Added !PLATFORM(EFL) guard.
- 8:02 PM Changeset in webkit [159036] by
-
- 53 edits in trunk/Source/WebCore
Make childShouldCreateRenderer() take a Node reference
https://bugs.webkit.org/show_bug.cgi?id=124132
Reviewed by Andreas Kling.
The Node passed to childShouldCreateRenderer() is never null.
- 5:58 PM Changeset in webkit [159035] by
-
- 3 edits2 adds in trunk
CSS direction must be reset to ltr on <math> element.
<https://webkit.org/b/124121>
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-11-10
Reviewed by Darin Adler.
Source/WebCore:
Test: mathml/presentation/direction.html
- css/mathml.css:
(math): set direction: ltr; on the <math> element.
LayoutTests:
- mathml/presentation/direction-expected.html: Added.
- mathml/presentation/direction.html: Added.
- 4:22 PM Changeset in webkit [159034] by
-
- 5 edits in trunk/Source/WebCore
Reduce the size of RenderBlockFlow by making its rare data inherit from RenderBlockRareData
https://bugs.webkit.org/show_bug.cgi?id=124124
Reviewed by Anders Carlsson.
Reduce RenderBlockFlow by one word.
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
- rendering/RenderBlockFlow.h:
- 4:13 PM Changeset in webkit [159033] by
-
- 4 edits in trunk/Source/WebKit/efl
Cleanup the EFL --minimal build from unused parameters
https://bugs.webkit.org/show_bug.cgi?id=124048
Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-10
Reviewed by Gyuyoung Kim.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::createWindow):
- ewk/ewk_settings.cpp:
(ewk_settings_web_database_path_set):
- ewk/ewk_view.cpp:
(ewk_view_visibility_state_set):
(ewk_view_visibility_state_get):
- 3:32 PM Changeset in webkit [159032] by
-
- 5 edits in trunk/Source/WebCore
Use start/end instead of textOffset/textLength for simple text runs
https://bugs.webkit.org/show_bug.cgi?id=124130
Reviewed by Oliver Hunt.
The code reads better this way.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::createTextRuns):
- rendering/SimpleLineLayout.h:
(WebCore::SimpleLineLayout::Run::Run):
- rendering/SimpleLineLayoutFunctions.h:
(WebCore::SimpleLineLayout::findTextCaretMinimumOffset):
(WebCore::SimpleLineLayout::findTextCaretMaximumOffset):
(WebCore::SimpleLineLayout::containsTextCaretOffset):
(WebCore::SimpleLineLayout::isTextRendered):
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::Run::text):
- 2:28 PM Changeset in webkit [159031] by
-
- 11 edits3 moves6 adds in trunk
Implement Set iterators
https://bugs.webkit.org/show_bug.cgi?id=124129
Reviewed by Antti Koivisto.
Source/JavaScriptCore:
Add Set iterator classes and implementations
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/CommonIdentifiers.h:
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
- runtime/JSSetIterator.cpp: Added.
(JSC::JSSetIterator::finishCreation):
(JSC::JSSetIterator::visitChildren):
(JSC::JSSetIterator::createPair):
- runtime/JSSetIterator.h: Added.
(JSC::JSSetIterator::createStructure):
(JSC::JSSetIterator::create):
(JSC::JSSetIterator::next):
(JSC::JSSetIterator::JSSetIterator):
- runtime/SetIteratorConstructor.cpp: Added.
(JSC::SetIteratorConstructor::finishCreation):
- runtime/SetIteratorConstructor.h: Added.
(JSC::SetIteratorConstructor::create):
(JSC::SetIteratorConstructor::createStructure):
(JSC::SetIteratorConstructor::SetIteratorConstructor):
- runtime/SetIteratorPrototype.cpp: Added.
(JSC::SetIteratorPrototype::finishCreation):
(JSC::SetIteratorPrototypeFuncIterator):
(JSC::SetIteratorPrototypeFuncNext):
- runtime/SetIteratorPrototype.h: Added.
(JSC::SetIteratorPrototype::create):
(JSC::SetIteratorPrototype::createStructure):
(JSC::SetIteratorPrototype::SetIteratorPrototype):
- runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):
(JSC::setProtoFuncValues):
(JSC::setProtoFuncEntries):
(JSC::setProtoFuncKeys):
LayoutTests:
Move Set tests to more sensible location and add iterator tests
- js/basic-set-expected.txt: Renamed from LayoutTests/js/dom/basic-set-expected.txt.
- js/basic-set.html: Renamed from LayoutTests/js/dom/basic-set.html.
- js/script-tests/basic-set.js: Renamed from LayoutTests/js/dom/script-tests/basic-set.js.
(set new):
(otherString.string_appeared_here.set add):
(try.set forEach):
(set forEach):
(set gc):
- 2:17 PM Changeset in webkit [159030] by
-
- 9 edits10 adds in trunk
Implement white-space property on simple line layout path
https://bugs.webkit.org/show_bug.cgi?id=124122
Source/WebCore:
Reviewed by Andreas Kling.
Support all values of the white-space property and the tab-size property.
Tests: fast/forms/basic-textareas-simple-lines.html
fast/text/embed-at-end-of-pre-wrap-line-simple-lines.html
fast/text/whitespace/pre-wrap-line-test-simple-lines.html
fast/text/whitespace/pre-wrap-long-word-simple-lines.html
fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::isWhitespace):
(WebCore::SimpleLineLayout::skipWhitespaces):
(WebCore::SimpleLineLayout::textWidth):
(WebCore::SimpleLineLayout::measureWord):
(WebCore::SimpleLineLayout::createTextRuns):
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintDebugBorders):
(WebCore::SimpleLineLayout::paintFlow):
LayoutTests:
Reviewed by Andreas Kling.
The simple line layout produces slightly different runs in some pre-wrap cases compared
to the line box path (with less unnecessary boxes). To keep the test coverage this patch forces the
existing render tree dump based tests to use line boxes. It also adds new ref tests for
the same cases where the test uses the simple line path and the ref is forced on the line box path.
This ensures that the paths produce pixel-identical results.
- fast/forms/basic-textareas-simple-lines-expected.html: Added.
- fast/forms/basic-textareas-simple-lines.html: Added.
- fast/forms/basic-textareas.html:
- fast/text/embed-at-end-of-pre-wrap-line-simple-lines-expected.html: Added.
- fast/text/embed-at-end-of-pre-wrap-line-simple-lines.html: Added.
- fast/text/embed-at-end-of-pre-wrap-line.html:
- fast/text/whitespace/pre-wrap-line-test-simple-lines-expected.html: Added.
- fast/text/whitespace/pre-wrap-line-test-simple-lines.html: Added.
- fast/text/whitespace/pre-wrap-line-test.html:
- fast/text/whitespace/pre-wrap-long-word-simple-lines-expected.html: Added.
- fast/text/whitespace/pre-wrap-long-word-simple-lines.html: Added. New simple test for overflowing lines which was only covered by the very large basic-textareas.html.
- fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines-expected.html: Added.
- fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines.html: Added.
- fast/text/whitespace/pre-wrap-spaces-after-newline.html:
- 12:59 PM Changeset in webkit [159029] by
-
- 2 edits in trunk/Source/WebCore
Fix EFL build after r159027
https://bugs.webkit.org/show_bug.cgi?id=124127
Patch by Sergio Correia <Sergio Correia> on 2013-11-10
Reviewed by Anders Carlsson.
No new tests, build fix.
- page/Settings.in: Add std to numeric_limits, since we don't have
'using std' directives anymore.
- 11:50 AM Changeset in webkit [159028] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::computeColumnCountAndWidth):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
- 11:32 AM Changeset in webkit [159027] by
-
- 151 edits in trunk/Source/WebCore
Remove all 'std' using directives from WebCore
https://bugs.webkit.org/show_bug.cgi?id=124125
Reviewed by Sam Weinig.
As per the coding style guidelines.
- loader/CrossOriginPreflightResultCache.cpp:
(WebCore::CrossOriginPreflightResultCache::appendEntry):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
- loader/WorkerThreadableLoader.cpp:
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::loadCache):
- loader/appcache/ManifestParser.cpp:
(WebCore::parseManifest):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::deadCapacity):
(WebCore::MemoryCache::lruListFor):
- page/CaptionUserPreferencesMediaAF.cpp:
- page/Chrome.cpp:
- page/DOMTimer.cpp:
(WebCore::DOMTimer::intervalClampedToMinimum):
- page/FocusController.cpp:
- page/Frame.cpp:
(WebCore::Frame::resizePageRectsKeepingRatio):
- page/PageGroupLoadDeferrer.cpp:
- page/Settings.cpp:
- page/animation/AnimationBase.cpp:
(WebCore::solveStepsFunction):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::timeToNextService):
(WebCore::AnimationBase::fractionalTime):
(WebCore::AnimationBase::getTimeToNextEvent):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
- platform/DateComponents.cpp:
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
- platform/ScrollView.cpp:
(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollContents):
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::moveThumb):
- platform/ScrollbarThemeComposite.cpp:
(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::copyBufferAndClear):
(WebCore::SharedBuffer::getSomeData):
- platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::updateSharedTimer):
- platform/Timer.cpp:
(WebCore::TimerHeapLessThanFunction::operator()):
(WebCore::TimerBase::heapPop):
(WebCore::TimerBase::nextUnalignedFireInterval):
- platform/URL.cpp:
(WebCore::findHostnamesInMailToURL):
(WebCore::portAllowed):
- platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::setRate):
- platform/audio/AudioResamplerKernel.cpp:
(WebCore::AudioResamplerKernel::process):
- platform/audio/Distance.cpp:
(WebCore::DistanceEffect::gain):
- platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::process):
- platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::pan):
- platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::indexFromElevationAngle):
- platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::createForSubject):
- platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::HRTFKernel):
(WebCore::HRTFKernel::createInterpolatedKernel):
- platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend):
- platform/audio/Reverb.cpp:
- platform/audio/SincResampler.cpp:
(WebCore::SincResampler::process):
- platform/cf/URLCF.cpp:
- platform/graphics/Color.cpp:
(WebCore::makeRGB):
(WebCore::makeRGBA):
(WebCore::colorFloatToRGBAByte):
(WebCore::Color::light):
(WebCore::Color::dark):
- platform/graphics/CrossfadeGeneratedImage.cpp:
- platform/graphics/FloatQuad.cpp:
(WebCore::min4):
(WebCore::max4):
(WebCore::withinEpsilon):
- platform/graphics/FloatSize.cpp:
(WebCore::FloatSize::isZero):
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::floatWidthForSimpleText):
- platform/graphics/FontPlatformData.cpp:
- platform/graphics/GraphicsContext.cpp:
- platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::Radii::expand):
- platform/graphics/ShadowBlur.cpp:
(WebCore::calculateLobes):
(WebCore::computeSliceSizesFromRadii):
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::initCharWidths):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advanceInternal):
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setOpacity):
(WebCore::GraphicsLayerCA::setNeedsDisplay):
(WebCore::GraphicsLayerCA::setupAnimation):
(WebCore::clampedContentsScaleForScale):
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::getTileIndexRangeForRect):
(WebCore::TileController::computeTileCoverageRect):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::computeLineBoundsAndAntialiasingModeForText):
- platform/graphics/cg/ImageBufferCG.cpp:
- platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData):
- platform/graphics/cg/ImageSourceCG.cpp:
- platform/graphics/filters/FEDropShadow.cpp:
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::boxBlur):
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::calculateUnscaledKernelSize):
(WebCore::FEGaussianBlur::calculateStdDeviation):
- platform/graphics/gpu/Texture.cpp:
(WebCore::Texture::updateSubRect):
- platform/graphics/gpu/TilingData.cpp:
(WebCore::computeNumTiles):
(WebCore::TilingData::tileXIndexFromSrcCoord):
(WebCore::TilingData::tileYIndexFromSrcCoord):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::offsetForPosition):
(WebCore::ComplexTextController::advance):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::floatWidthForComplexText):
- platform/graphics/mac/FontMac.mm:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::duration):
- platform/graphics/mac/SimpleFontDataMac.mm:
- platform/graphics/transforms/Matrix3DTransformOperation.cpp:
- platform/graphics/transforms/MatrixTransformOperation.cpp:
- platform/graphics/transforms/PerspectiveTransformOperation.cpp:
- platform/graphics/transforms/RotateTransformOperation.cpp:
- platform/graphics/transforms/TransformOperations.cpp:
(WebCore::TransformOperations::blendByMatchingOperations):
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::clampEdgeValue):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetContentsSize):
(WebCore::ScrollView::platformSetScrollPosition):
- platform/mac/ScrollbarThemeMac.mm:
- platform/mac/ThemeMac.mm:
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController incrementVolume]):
(timeToString):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
- platform/network/ResourceRequestBase.cpp:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
- platform/network/cf/ResourceResponseCFNet.cpp:
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::initNSURLResponse):
- platform/text/TextBreakIteratorICU.cpp:
(WebCore::textClone):
(WebCore::textLatin1MoveInPrimaryContext):
(WebCore::textLatin1MoveInPriorContext):
(WebCore::textInChunkOrOutOfRange):
(WebCore::textOpenLatin1):
(WebCore::textUTF16MoveInPrimaryContext):
(WebCore::textUTF16MoveInPriorContext):
(WebCore::textOpenUTF16):
- platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::encode):
- platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::encode):
- platform/text/TextStream.cpp:
- platform/text/mac/LocaleMac.mm:
- platform/text/mac/TextCodecMac.cpp:
(WebCore::TextCodecMac::decode):
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::applyPreferredLogicalWidthQuirks):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::applyPreferredLogicalWidthQuirks):
- rendering/FloatingObjects.cpp:
(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffset):
- rendering/InlineBox.cpp:
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeMaxLogicalTop):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
(WebCore::InlineFlowBox::collectLeafBoxesInLogicalOrder):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::computeUnderlineOffset):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::paintChild):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::adjustIntrinsicLogicalWidthsForColumns):
(WebCore::updatePreferredWidth):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::marginBeforeEstimateForChild):
(WebCore::RenderBlockFlow::estimateLogicalTopPosition):
(WebCore::RenderBlockFlow::setCollapsedBottomMargin):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):
(WebCore::calculateMinimumPageHeight):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::adjustForBorderFit):
(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded):
(WebCore::RenderBlockFlow::updateLogicalHeight):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlockFlow::relayoutForPagination):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::updateLogicalWidthForLeftAlignedBlock):
(WebCore::updateLogicalWidthForRightAlignedBlock):
(WebCore::updateLogicalWidthForCenterAlignedBlock):
(WebCore::setLogicalWidthForTextRun):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::checkFloatsInCleanLine):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::tryHyphenating):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax):
(WebCore::RenderBox::constrainLogicalHeightByMinMax):
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
(WebCore::RenderBox::adjustBorderBoxLogicalWidthForBoxSizing):
(WebCore::RenderBox::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing):
(WebCore::RenderBox::adjustContentBoxLogicalHeightForBoxSizing):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::applyVisualEffectOverflow):
(WebCore::RenderBox::addLayoutOverflow):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::calculateAdjustedInnerBorder):
(WebCore::RenderBoxModelObject::paintBoxShadow):
(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::setImageSizeForAltText):
- rendering/RenderInline.cpp:
(WebCore::computeMargin):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clampScrollOffset):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::visibleContentRect):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::hitTestOverflowControls):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateLayerBounds):
- rendering/RenderLayerBacking.cpp:
- rendering/RenderLayerModelObject.cpp:
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::layout):
(WebCore::RenderListBox::computePreferredLogicalWidths):
(WebCore::RenderListBox::size):
(WebCore::RenderListBox::numVisibleItems):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollHeight):
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::marqueeSpeed):
(WebCore::RenderMarquee::computePosition):
(WebCore::RenderMarquee::timerFired):
- rendering/RenderMediaControls.cpp:
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::computeIntrinsicLogicalWidths):
(WebCore::RenderMenuList::computePreferredLogicalWidths):
- rendering/RenderMeter.cpp:
- rendering/RenderMultiColumnBlock.cpp:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset):
(WebCore::RenderMultiColumnSet::calculateBalancedHeight):
(WebCore::RenderMultiColumnSet::updateLogicalWidth):
- rendering/RenderNamedFlowFragment.cpp:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::caretMaxOffset):
- rendering/RenderProgress.cpp:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computePreferredLogicalWidths):
- rendering/RenderRubyBase.cpp:
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::getOverhang):
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::computeControlLogicalHeight):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::updateLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::computePreferredLogicalWidths):
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
(WebCore::RenderTableCell::logicalWidthFromColumns):
(WebCore::RenderTableCell::computePreferredLogicalWidths):
(WebCore::RenderTableCell::layout):
(WebCore::RenderTableCell::setOverrideLogicalContentHeightFromRowHeight):
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::alignLeftRightBorderPaintRect):
(WebCore::RenderTableCell::alignTopBottomBorderPaintRect):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::firstLineBaseline):
(WebCore::RenderTableSection::removeCachedCollapsedBorders):
(WebCore::RenderTableSection::setCachedCollapsedBorder):
(WebCore::RenderTableSection::cachedCollapsedBorder):
- rendering/RenderText.cpp:
(WebCore::makeCapitalized):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::maxWordFragmentWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computePreferredLogicalWidths):
- rendering/RenderTextControlSingleLine.cpp:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintMenuListButton):
- rendering/RenderWidget.cpp:
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):
(WebCore::RootInlineBox::blockDirectionPointInLine):
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::layout):
- rendering/style/RenderStyle.cpp:
(WebCore::calcConstraintScaleFor):
(WebCore::RenderStyle::setFontSize):
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowInsetExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):
- rendering/style/SVGRenderStyle.cpp:
- rendering/style/ShadowData.cpp:
(WebCore::calculateShadowExtent):
- rendering/svg/RenderSVGResourceFilter.cpp:
- rendering/svg/RenderSVGRoot.cpp:
- rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::localSelectionRect):
- svg/SVGAnimatedNumber.cpp:
- svg/SVGAnimatedNumberOptionalNumber.cpp:
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::startTimer):
(WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::simpleDuration):
(WebCore::SVGSMILElement::repeatingDuration):
(WebCore::SVGSMILElement::resolveActiveEnd):
(WebCore::SVGSMILElement::resolveInterval):
(WebCore::SVGSMILElement::resolveFirstInterval):
(WebCore::SVGSMILElement::resolveNextInterval):
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
- xml/XMLTreeViewer.cpp:
- xml/parser/XMLDocumentParser.cpp:
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::OffsetBuffer::readOutBytes):
- 8:59 AM Changeset in webkit [159026] by
-
- 23 edits in trunk/Source
[AX] Clean up static_cast<> to cast from AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=124032
Reviewed by Mario Sanchez Prada.
Source/WebCore:
ACCESSIBILITY_OBJECT_TYPE_CASTS can support more helpful casting functions.
So, we need to use them as much as possible. This patch cleans up all static_cast<> in accessibility.
This patch generates toAccessibilityFoo() in order to replace static_cast<> with it. Below toAccessibilityFoo()
are generated.
- toAccessibilityARIAGridRow()
- toAccessibilityImageMapLink()
- toAccessibilityListBox()
- toAccessibilityListBoxOption()
- toAccessibilityMenuListOption()
- toAccessibilityMenuListPopup()
- toAccessibilityScrollbar()
- toAccessibilitySlider()
No new tests, no behavior changes.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
- accessibility/AccessibilityARIAGridRow.h:
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::setSelectedChildren):
(WebCore::AccessibilityListBox::selectedChildren):
(WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
- accessibility/AccessibilityListBox.h:
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::addChildren):
(WebCore::AccessibilityMenuList::didUpdateActiveOption):
- accessibility/AccessibilityMenuListOption.h:
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
- accessibility/AccessibilityMenuListPopup.h:
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isListBoxOption):
(WebCore::AccessibilityObject::isSliderThumb):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
- accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::addChildScrollbar):
- accessibility/AccessibilityScrollbar.h:
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::addChildren):
- accessibility/AccessibilitySlider.h:
- accessibility/AccessibilitySpinButton.cpp:
(WebCore::AccessibilitySpinButton::addChildren):
- accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
(webkitAccessibleSelectionClearSelection):
(webkitAccessibleSelectionSelectAllSelection):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::didUpdateActiveOption):
Source/WebKit/win:
Use toAccessibilityListBox instead of using static_cast<AccessibilityListBox*>.
- AccessibleBase.cpp:
(AccessibleBase::accSelect):
- 8:34 AM Changeset in webkit [159025] by
-
- 2 edits in trunk/Source/WebCore
Rebaseline bindings tests after r158997.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- 6:52 AM Changeset in webkit [159024] by
-
- 11 edits in trunk/Source/WebCore
[GStreamer] Consolidate more code into TrackPrivateBaseGStreamer
https://bugs.webkit.org/show_bug.cgi?id=124020
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-10
Reviewed by Philippe Normand.
No new tests because this is just refactoring.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer): Don't pass playbin to TrackPrivateBaseGStreamer, and do pass a pointer to "this".
(WebCore::AudioTrackPrivateGStreamer::disconnect): Clear m_playbin().
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Move labelChanged() and languageChanged() to TrackPrivateBaseGStreamer. Move m_playbin to this class (along with disconnect() to clear it).
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp: Move tag handling, pad and index to TrackPrivateBaseGStreamer.
(WebCore::textTrackPrivateEventCallback):
(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):
(WebCore::InbandTextTrackPrivateGStreamer::disconnect):
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/TextCombinerGStreamer.cpp: Add WebKitTextCombinerPad with "tags" property, set in the same was as input-selector's pads.
(webkit_text_combiner_pad_init): Initialize tags to 0.
(webkitTextCombinerPadFinalize): Clear tags.
(webkitTextCombinerPadGetProperty): Handling "tags" property.
(webkitTextCombinerPadEvent): Changed to be a pad event function instead of a pad probe, and now intercepts tags and merges them (like input-selector pads do).
(webkitTextCombinerRequestNewPad): Using WebKitTextCombinerPad instead of just GhostPad.
(webkit_text_combiner_pad_class_init): Setup WebKitTextCombinerPad.
- platform/graphics/gstreamer/TextCombinerGStreamer.h: Remove superfluous code.
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer): Use "notify::active" so we don't need a playbin, and immediately check for tags after the constructor.
(WebCore::TrackPrivateBaseGStreamer::disconnect): Remove m_playbin.
(WebCore::TrackPrivateBaseGStreamer::getTag): Refactored out from notifyTrackOfTagsChanged.
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged): Simplify using m_owner (so we can call labelChanged() and languageChanged() directly), and use getTag() above.
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Add m_owner to we can access the owning track, and change some functions to match our needs better.
(WebCore::TrackPrivateBaseGStreamer::setActive): Add empty default since InbandTextTrackPrivateGStreamer doesn't need this.
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp: Same as AudioTrackPrivateGStreamer.
(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
(WebCore::VideoTrackPrivateGStreamer::disconnect):
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Same as AudioTrackPrivateGStreamer.
- 2:59 AM Changeset in webkit [159023] by
-
- 10 edits in trunk/Source/WebCore
Generate type casting helpers for Widget classes.
<https://webkit.org/b/124120>
Add a WIDGET_TYPE_CASTS macro and replace all the hand-written
toFoo() helpers we had for Widget subclasses. Fixed up a handful
of places that were still using static_cast.
Reviewed by Antti Koivisto.
- 2:58 AM Changeset in webkit [159022] by
-
- 3 edits in trunk/Source/WebCore
Remove unused FragmentationDisabler class.
<https://webkit.org/b/124118>
This RAII object was added in r144744 to avoid a crash when using
MathML inside CSS regions. Its only user was removed in r157070.
Reviewed by Antti Koivisto.
- 2:56 AM Changeset in webkit [159021] by
-
- 4 edits in trunk/Source/WebCore
Simplify some is-this-a-MathML-element? checks.
<https://webkit.org/b/124119>
As of r158198, the MathML-ness of an Element is determined by
a Node flag, so there's no need to cast to Element before checking
on this. Simplify accordingly.
Reviewed by Antti Koivisto.
- 12:57 AM Changeset in webkit [159020] by
-
- 3 edits in trunk/Source/WebCore
Remove RenderTheme::shouldOpenPickerWithF4Key().
Rubber-stamped by Anders Carlsson.
- 12:39 AM Changeset in webkit [159019] by
-
- 2 edits2 copies128 moves2 adds134 deletes in trunk/LayoutTests
Optimize baselines: svg/*
Unreviewed; run "webkit-patch optimize-baselines svg"
- platform/efl-wk2/svg/dom/SVGLengthList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-basics-expected.png.
- platform/efl/svg/wicd/sizing-flakiness-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
- platform/gtk/svg/as-image/svg-as-image-expected.png: Removed.
- platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Removed.
- platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Removed.
- platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Removed.
- platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Removed.
- platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Removed.
- platform/gtk/svg/custom/feDisplacementMap-01-expected.txt: Removed.
- platform/gtk/svg/custom/pattern-skew-transformed-expected.png: Removed.
- platform/gtk/svg/custom/radialGradient-focal-radius-expected.txt: Removed.
- platform/gtk/svg/custom/simple-text-double-shadow-expected.png: Removed.
- platform/gtk/svg/custom/simple-text-double-shadow-expected.txt: Removed.
- platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt: Removed.
- platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Removed.
- platform/gtk/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Removed.
- platform/gtk/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Removed.
- platform/gtk/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Removed.
- platform/gtk/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Removed.
- platform/gtk/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Removed.
- platform/gtk/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Removed.
- platform/gtk/svg/foreignObject/fO-display-none-expected.png: Removed.
- platform/gtk/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Removed.
- platform/gtk/svg/foreignObject/fO-parent-display-changes-expected.png: Removed.
- platform/gtk/svg/foreignObject/fO-parent-display-changes-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-parent-display-none-expected.png: Removed.
- platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Removed.
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Removed.
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Removed.
- platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Removed.
- platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.png: Removed.
- platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt: Removed.
- platform/gtk/svg/in-html/by-reference-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-foreignObject-expected.png: Removed.
- platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Removed.
- platform/gtk/svg/repaint/filter-repaint-expected.txt: Removed.
- platform/gtk/svg/repaint/image-href-change-expected.png: Removed.
- platform/gtk/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Removed.
- platform/gtk/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Removed.
- platform/gtk/svg/repaint/text-mask-update-expected.png: Removed.
- platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Removed.
- platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Removed.
- platform/gtk/svg/text/append-text-node-to-tspan-expected.txt: Removed.
- platform/gtk/svg/text/bidi-embedded-direction-expected.txt: Removed.
- platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt: Removed.
- platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
- platform/gtk/svg/text/bidi-text-query-expected.txt: Removed.
- platform/gtk/svg/text/bidi-tspans-expected.txt: Removed.
- platform/gtk/svg/text/ems-display-none-expected.txt: Removed.
- platform/gtk/svg/text/exs-display-none-expected.txt: Removed.
- platform/gtk/svg/text/font-size-below-point-five-expected.txt: Removed.
- platform/gtk/svg/text/modify-text-node-in-tspan-expected.txt: Removed.
- platform/gtk/svg/text/remove-text-node-from-tspan-expected.txt: Removed.
- platform/gtk/svg/text/remove-tspan-from-text-expected.txt: Removed.
- platform/gtk/svg/text/scaled-font-expected.txt: Removed.
- platform/gtk/svg/text/scaling-font-with-geometric-precision-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Removed.
- platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Removed.
- platform/gtk/svg/text/select-x-list-1-expected.txt: Removed.
- platform/gtk/svg/text/select-x-list-2-expected.txt: Removed.
- platform/gtk/svg/text/select-x-list-3-expected.txt: Removed.
- platform/gtk/svg/text/select-x-list-4-expected.txt: Removed.
- platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt: Removed.
- platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt: Removed.
- platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt: Removed.
- platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt: Removed.
- platform/gtk/svg/text/selection-doubleclick-expected.txt: Removed.
- platform/gtk/svg/text/small-fonts-2-expected.txt: Removed.
- platform/gtk/svg/text/small-fonts-3-expected.txt: Removed.
- platform/gtk/svg/text/small-fonts-expected.txt: Removed.
- platform/gtk/svg/text/text-align-01-b-expected.txt: Removed.
- platform/gtk/svg/text/text-align-02-b-expected.txt: Removed.
- platform/gtk/svg/text/text-align-03-b-expected.txt: Removed.
- platform/gtk/svg/text/text-align-04-b-expected.txt: Removed.
- platform/gtk/svg/text/text-align-05-b-expected.txt: Removed.
- platform/gtk/svg/text/text-align-06-b-expected.txt: Removed.
- platform/gtk/svg/text/text-altglyph-01-b-expected.txt: Removed.
- platform/gtk/svg/text/text-deco-01-b-expected.txt: Removed.
- platform/gtk/svg/text/text-fill-opacity-expected.txt: Removed.
- platform/gtk/svg/text/text-fonts-01-t-expected.txt: Removed.
- platform/gtk/svg/text/text-fonts-02-t-expected.txt: Removed.
- platform/gtk/svg/text/text-gradient-positioning-expected.txt: Removed.
- platform/gtk/svg/text/text-intro-05-t-expected.txt: Removed.
- platform/gtk/svg/text/text-midpoint-split-bug-expected.txt: Removed.
- platform/gtk/svg/text/text-path-01-b-expected.txt: Removed.
- platform/gtk/svg/text/text-path-middle-align-expected.txt: Removed.
- platform/gtk/svg/text/text-spacing-01-b-expected.txt: Removed.
- platform/gtk/svg/text/text-text-01-b-expected.txt: Removed.
- platform/gtk/svg/text/text-text-03-b-expected.txt: Removed.
- platform/gtk/svg/text/text-text-04-t-expected.txt: Removed.
- platform/gtk/svg/text/text-text-05-t-expected.txt: Removed.
- platform/gtk/svg/text/text-text-06-t-expected.txt: Removed.
- platform/gtk/svg/text/text-text-07-t-expected.txt: Removed.
- platform/gtk/svg/text/text-text-08-b-expected.txt: Removed.
- platform/gtk/svg/text/text-tref-01-b-expected.txt: Removed.
- platform/gtk/svg/text/text-tselect-01-b-expected.txt: Removed.
- platform/gtk/svg/text/text-tselect-02-f-expected.txt: Removed.
- platform/gtk/svg/text/text-tspan-01-b-expected.txt: Removed.
- platform/gtk/svg/text/text-ws-01-t-expected.txt: Removed.
- platform/gtk/svg/text/text-ws-02-t-expected.txt: Removed.
- platform/gtk/svg/text/tspan-dynamic-positioning-expected.txt: Removed.
- platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Removed.
- platform/gtk/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Removed.
- platform/gtk/svg/wicd/sizing-flakiness-expected.txt: Removed.
- platform/mac/svg/custom/feDisplacementMap-01-expected.txt: Removed.
- platform/mac/svg/custom/radialGradient-focal-radius-expected.txt: Removed.
- platform/mac/svg/custom/stroked-pattern-expected.txt: Removed.
- platform/mac/svg/text/selection-tripleclick-expected.txt: Removed.
- platform/win-future/svg/wicd/sizing-flakiness-expected.txt: Copied from LayoutTests/svg/wicd/sizing-flakiness-expected.txt.
- platform/win/svg/custom/pattern-scaling-expected.txt: Removed.
- svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt.
- svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt.
- svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt.
- svg/as-image/svg-as-image-expected.png: Renamed from LayoutTests/platform/efl/svg/as-image/svg-as-image-expected.png.
- svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png.
- svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png.
- svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png.
- svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png.
- svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png.
- svg/custom/feDisplacementMap-01-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/feDisplacementMap-01-expected.txt.
- svg/custom/pattern-skew-transformed-expected.png: Renamed from LayoutTests/platform/efl/svg/custom/pattern-skew-transformed-expected.png.
- svg/custom/radialGradient-focal-radius-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/radialGradient-focal-radius-expected.txt.
- svg/custom/simple-text-double-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/custom/simple-text-double-shadow-expected.png.
- svg/custom/simple-text-double-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/simple-text-double-shadow-expected.txt.
- svg/custom/stroked-pattern-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/stroked-pattern-expected.txt.
- svg/dom/SVGPathSegList-segment-modification-expected.txt: Renamed from LayoutTests/platform/efl/svg/dom/SVGPathSegList-segment-modification-expected.txt.
- svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Renamed from LayoutTests/platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt.
- svg/dom/SVGRectElement/rect-modify-rx-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGRectElement/rect-modify-rx-expected.png.
- svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png.
- svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png.
- svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png.
- svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png.
- svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
- svg/foreignObject/fO-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-display-none-expected.png.
- svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png.
- svg/foreignObject/fO-parent-display-changes-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-changes-expected.png.
- svg/foreignObject/fO-parent-display-changes-expected.txt: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-changes-expected.txt.
- svg/foreignObject/fO-parent-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-none-expected.png.
- svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png.
- svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.png.
- svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png.
- svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png.
- svg/foreignObject/svg-document-as-direct-child-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.png.
- svg/foreignObject/svg-document-as-direct-child-expected.txt: Renamed from LayoutTests/platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.txt.
- svg/in-html/by-reference-expected.txt: Renamed from LayoutTests/platform/efl/svg/in-html/by-reference-expected.txt.
- svg/overflow/overflow-on-foreignObject-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-foreignObject-expected.png.
- svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png.
- svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png.
- svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png.
- svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png.
- svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png.
- svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png.
- svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png.
- svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png.
- svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png.
- svg/repaint/filter-repaint-expected.txt: Renamed from LayoutTests/platform/efl/svg/repaint/filter-repaint-expected.txt.
- svg/repaint/image-href-change-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/image-href-change-expected.png.
- svg/repaint/inner-svg-change-viewBox-contract-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/inner-svg-change-viewBox-contract-expected.png.
- svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Renamed from LayoutTests/platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.txt.
- svg/repaint/text-mask-update-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/text-mask-update-expected.png.
- svg/stroke/zero-length-path-linecap-rendering-expected.txt: Renamed from LayoutTests/platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt.
- svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Renamed from LayoutTests/platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt.
- svg/text/append-text-node-to-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/append-text-node-to-tspan-expected.txt.
- svg/text/bidi-embedded-direction-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-embedded-direction-expected.txt.
- svg/text/bidi-reorder-value-lists-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-reorder-value-lists-expected.txt.
- svg/text/bidi-text-anchor-direction-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-text-anchor-direction-expected.txt.
- svg/text/bidi-text-query-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-text-query-expected.txt.
- svg/text/bidi-tspans-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-tspans-expected.txt.
- svg/text/ems-display-none-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/ems-display-none-expected.txt.
- svg/text/exs-display-none-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/exs-display-none-expected.txt.
- svg/text/font-size-below-point-five-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/font-size-below-point-five-expected.txt.
- svg/text/modify-text-node-in-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/modify-text-node-in-tspan-expected.txt.
- svg/text/remove-text-node-from-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/remove-text-node-from-tspan-expected.txt.
- svg/text/remove-tspan-from-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/remove-tspan-from-text-expected.txt.
- svg/text/scaled-font-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/scaled-font-expected.txt.
- svg/text/scaling-font-with-geometric-precision-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/scaling-font-with-geometric-precision-expected.txt.
- svg/text/select-textLength-spacing-squeeze-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-1-expected.txt.
- svg/text/select-textLength-spacing-squeeze-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-2-expected.txt.
- svg/text/select-textLength-spacing-squeeze-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-3-expected.txt.
- svg/text/select-textLength-spacing-squeeze-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-4-expected.txt.
- svg/text/select-textLength-spacing-stretch-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-1-expected.txt.
- svg/text/select-textLength-spacing-stretch-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-2-expected.txt.
- svg/text/select-textLength-spacing-stretch-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-3-expected.txt.
- svg/text/select-textLength-spacing-stretch-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-4-expected.txt.
- svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt.
- svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt.
- svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt.
- svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt.
- svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt.
- svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt.
- svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt.
- svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt.
- svg/text/select-x-list-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-1-expected.txt.
- svg/text/select-x-list-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-2-expected.txt.
- svg/text/select-x-list-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-3-expected.txt.
- svg/text/select-x-list-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-4-expected.txt.
- svg/text/select-x-list-with-tspans-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-1-expected.txt.
- svg/text/select-x-list-with-tspans-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-2-expected.txt.
- svg/text/select-x-list-with-tspans-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-3-expected.txt.
- svg/text/select-x-list-with-tspans-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-4-expected.txt.
- svg/text/selection-doubleclick-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/selection-doubleclick-expected.txt.
- svg/text/selection-tripleclick-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/selection-tripleclick-expected.txt.
- svg/text/small-fonts-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-2-expected.txt.
- svg/text/small-fonts-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-3-expected.txt.
- svg/text/small-fonts-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-expected.txt.
- svg/text/text-align-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-01-b-expected.txt.
- svg/text/text-align-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-02-b-expected.txt.
- svg/text/text-align-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-03-b-expected.txt.
- svg/text/text-align-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-04-b-expected.txt.
- svg/text/text-align-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-05-b-expected.txt.
- svg/text/text-align-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-06-b-expected.txt.
- svg/text/text-altglyph-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-altglyph-01-b-expected.txt.
- svg/text/text-deco-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-deco-01-b-expected.txt.
- svg/text/text-fill-opacity-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fill-opacity-expected.txt.
- svg/text/text-fonts-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fonts-01-t-expected.txt.
- svg/text/text-fonts-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fonts-02-t-expected.txt.
- svg/text/text-gradient-positioning-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-gradient-positioning-expected.txt.
- svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-intro-05-t-expected.txt.
- svg/text/text-midpoint-split-bug-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-midpoint-split-bug-expected.txt.
- svg/text/text-path-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-path-01-b-expected.txt.
- svg/text/text-path-middle-align-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-path-middle-align-expected.txt.
- svg/text/text-spacing-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-spacing-01-b-expected.txt.
- svg/text/text-text-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-01-b-expected.txt.
- svg/text/text-text-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-03-b-expected.txt.
- svg/text/text-text-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-04-t-expected.txt.
- svg/text/text-text-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-05-t-expected.txt.
- svg/text/text-text-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-06-t-expected.txt.
- svg/text/text-text-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-07-t-expected.txt.
- svg/text/text-text-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-08-b-expected.txt.
- svg/text/text-tref-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tref-01-b-expected.txt.
- svg/text/text-tselect-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tselect-01-b-expected.txt.
- svg/text/text-tselect-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tselect-02-f-expected.txt.
- svg/text/text-tspan-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tspan-01-b-expected.txt.
- svg/text/text-ws-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-ws-01-t-expected.txt.
- svg/text/text-ws-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-ws-02-t-expected.txt.
- svg/text/tspan-dynamic-positioning-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/tspan-dynamic-positioning-expected.txt.
- svg/transforms/text-with-mask-with-svg-transform-expected.txt: Renamed from LayoutTests/platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt.
- svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Renamed from LayoutTests/platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt.
- svg/wicd/sizing-flakiness-expected.txt:
Nov 9, 2013:
- 11:28 PM Changeset in webkit [159018] by
-
- 3 edits in trunk/Source/WebCore
CSSValuePool::createFontFamilyValue() should return PassRef.
<https://webkit.org/b/124114>
Unlike createFontFaceValue(), createFontFamilyValue() can never
fail to return an object and thus should return PassRef.
Reviewed by Anders Carlsson.
- 11:26 PM Changeset in webkit [159017] by
-
- 371 edits in trunk
RenderIFrame should display its name correctly in DRT output.
<https://webkit.org/b/124117>
Source/WebCore:
Nuke an age-old FIXME about making RenderIFrame show its true name
in DRT output. No more "RenderPartObject {IFRAME}"!
Reviewed by Anders Carlsson.
LayoutTests:
Rebaseline results now that RenderIFrame correctly dumps its name
as "RenderIFrame".
Reviewed by Anders Carlsson.
- compositing/iframes/composited-iframe-scroll-expected.txt:
- compositing/iframes/iframe-content-flipping-expected.txt:
- compositing/iframes/nested-iframe-scrolling-expected.txt:
- fast/css/replaced-element-implicit-size-expected.txt:
- fast/css/resize-corner-tracking-expected.txt:
- fast/dom/attr_dead_doc-expected.txt:
- fast/frames/content-opacity-1-expected.txt:
- fast/frames/content-opacity-2-expected.txt:
- fast/frames/iframe-scaling-with-scroll-expected.txt:
- fast/frames/iframe-text-contents-expected.txt:
- fast/frames/paint-iframe-background-expected.txt:
- fast/repaint/4774354-expected.txt:
- fast/repaint/iframe-scroll-repaint-expected.txt:
- fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
- fast/replaced/percent-height-in-anonymous-block-expected.txt:
- http/tests/misc/acid3-expected.txt:
- media/media-document-audio-repaint-expected.txt:
- platform/efl/compositing/iframes/composited-iframe-alignment-expected.txt:
- platform/efl/compositing/iframes/iframe-copy-on-scroll-expected.txt:
- platform/efl/compositing/iframes/iframe-in-composited-layer-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-004-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-005-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-007-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-011-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-012-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-014-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-018-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-019-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-021-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-025-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-026-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-028-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-032-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-033-expected.txt:
- platform/efl/css2.1/20110323/absolute-replaced-height-035-expected.txt:
- platform/efl/css2.1/20110323/block-replaced-height-004-expected.txt:
- platform/efl/css2.1/20110323/block-replaced-height-005-expected.txt:
- platform/efl/css2.1/20110323/block-replaced-height-007-expected.txt:
- platform/efl/css2.1/20110323/float-replaced-height-004-expected.txt:
- platform/efl/css2.1/20110323/float-replaced-height-005-expected.txt:
- platform/efl/css2.1/20110323/float-replaced-height-007-expected.txt:
- platform/efl/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
- platform/efl/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
- platform/efl/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
- platform/efl/css2.1/20110323/inline-replaced-height-004-expected.txt:
- platform/efl/css2.1/20110323/inline-replaced-height-005-expected.txt:
- platform/efl/css2.1/20110323/inline-replaced-height-007-expected.txt:
- platform/efl/editing/pasteboard/4631972-expected.txt:
- platform/efl/editing/selection/4776665-expected.txt:
- platform/efl/editing/selection/4960137-expected.txt:
- platform/efl/editing/selection/4975120-expected.txt:
- platform/efl/editing/selection/drag-in-iframe-expected.txt:
- platform/efl/editing/selection/drag-to-contenteditable-iframe-expected.txt:
- platform/efl/editing/selection/iframe-expected.txt:
- platform/efl/editing/selection/select-all-iframe-expected.txt:
- platform/efl/fast/block/basic/013-expected.txt:
- platform/efl/fast/block/positioning/window-height-change-expected.txt:
- platform/efl/fast/css/line-height-overflow-expected.txt:
- platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
- platform/efl/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
- platform/efl/fast/flexbox/016-expected.txt:
- platform/efl/fast/forms/basic-textareas-expected.txt:
- platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
- platform/efl/fast/forms/targeted-frame-submission-expected.txt:
- platform/efl/fast/frames/001-expected.txt:
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
- platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
- platform/efl/fast/frames/flattening/iframe-flattening-nested-expected.txt:
- platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
- platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
- platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt:
- platform/efl/fast/frames/frameElement-iframe-expected.txt:
- platform/efl/fast/frames/iframe-option-crash-expected.txt:
- platform/efl/fast/frames/iframe-scrolling-attribute-expected.txt:
- platform/efl/fast/frames/iframe-with-frameborder-expected.txt:
- platform/efl/fast/frames/onlyCommentInIFrame-expected.txt:
- platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
- platform/efl/fast/frames/viewsource-attribute-expected.txt:
- platform/efl/fast/frames/viewsource-on-image-file-expected.txt:
- platform/efl/fast/images/favicon-as-image-expected.txt:
- platform/efl/fast/overflow/scrollRevealButton-expected.txt:
- platform/efl/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-1-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-10-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-2-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-3-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-4-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-5-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-6-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-7-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-8-expected.txt:
- platform/efl/fast/repaint/line-flow-with-floats-9-expected.txt:
- platform/efl/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
- platform/efl/fast/replaced/007-expected.txt:
- platform/efl/fast/replaced/border-radius-clip-expected.txt:
- platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
- platform/efl/fast/replaced/replaced-breaking-expected.txt:
- platform/efl/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
- platform/efl/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
- platform/efl/fast/table/quote-text-around-iframe-expected.txt:
- platform/efl/fast/text/selection-hard-linebreak-expected.txt:
- platform/efl/http/tests/loading/simple-subframe-expected.txt:
- platform/efl/http/tests/local/file-url-sent-as-referer-expected.txt:
- platform/efl/http/tests/misc/acid3-expected.txt:
- platform/efl/http/tests/misc/favicon-as-image-expected.txt:
- platform/efl/http/tests/misc/frame-access-during-load-expected.txt:
- platform/efl/http/tests/misc/iframe404-expected.txt:
- platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt:
- platform/efl/http/tests/multipart/invalid-image-data-standalone-expected.txt:
- platform/efl/media/media-document-audio-repaint-expected.txt:
- platform/efl/svg/hixie/rendering-model/003-expected.txt:
- platform/efl/svg/in-html/by-reference-expected.txt:
- platform/efl/tables/mozilla/bugs/bug131020-expected.txt:
- platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
- platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
- platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-005-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-007-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-011-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-012-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-014-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-018-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-019-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-021-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-025-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-026-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-028-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-032-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-033-expected.txt:
- platform/gtk/css2.1/20110323/absolute-replaced-height-035-expected.txt:
- platform/gtk/css2.1/20110323/block-replaced-height-004-expected.txt:
- platform/gtk/css2.1/20110323/block-replaced-height-005-expected.txt:
- platform/gtk/css2.1/20110323/block-replaced-height-007-expected.txt:
- platform/gtk/css2.1/20110323/float-replaced-height-004-expected.txt:
- platform/gtk/css2.1/20110323/float-replaced-height-005-expected.txt:
- platform/gtk/css2.1/20110323/float-replaced-height-007-expected.txt:
- platform/gtk/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
- platform/gtk/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
- platform/gtk/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
- platform/gtk/css2.1/20110323/inline-replaced-height-004-expected.txt:
- platform/gtk/css2.1/20110323/inline-replaced-height-005-expected.txt:
- platform/gtk/css2.1/20110323/inline-replaced-height-007-expected.txt:
- platform/gtk/editing/execCommand/find-after-replace-expected.txt:
- platform/gtk/editing/execCommand/paste-1-expected.txt:
- platform/gtk/editing/pasteboard/4631972-expected.txt:
- platform/gtk/editing/pasteboard/copy-standalone-image-expected.txt:
- platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
- platform/gtk/editing/pasteboard/paste-2-expected.txt:
- platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
- platform/gtk/editing/selection/4776665-expected.txt:
- platform/gtk/editing/selection/4960137-expected.txt:
- platform/gtk/editing/selection/4975120-expected.txt:
- platform/gtk/editing/selection/drag-in-iframe-expected.txt:
- platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
- platform/gtk/editing/selection/iframe-expected.txt:
- platform/gtk/editing/selection/select-all-iframe-expected.txt:
- platform/gtk/fast/block/basic/013-expected.txt:
- platform/gtk/fast/block/positioning/window-height-change-expected.txt:
- platform/gtk/fast/css/line-height-overflow-expected.txt:
- platform/gtk/fast/css/resize-corner-tracking-expected.txt:
- platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
- platform/gtk/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
- platform/gtk/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
- platform/gtk/fast/flexbox/016-expected.txt:
- platform/gtk/fast/forms/basic-textareas-expected.txt:
- platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
- platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
- platform/gtk/fast/frames/001-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
- platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
- platform/gtk/fast/frames/frameElement-iframe-expected.txt:
- platform/gtk/fast/frames/iframe-option-crash-expected.txt:
- platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
- platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
- platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
- platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
- platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
- platform/gtk/fast/frames/viewsource-attribute-expected.txt:
- platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
- platform/gtk/fast/images/favicon-as-image-expected.txt:
- platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
- platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
- platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
- platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
- platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
- platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
- platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
- platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
- platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
- platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
- platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
- platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
- platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
- platform/gtk/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
- platform/gtk/fast/replaced/007-expected.txt:
- platform/gtk/fast/replaced/border-radius-clip-expected.txt:
- platform/gtk/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
- platform/gtk/fast/replaced/replaced-breaking-expected.txt:
- platform/gtk/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
- platform/gtk/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
- platform/gtk/fast/table/quote-text-around-iframe-expected.txt:
- platform/gtk/fast/text/selection-hard-linebreak-expected.txt:
- platform/gtk/http/tests/loading/simple-subframe-expected.txt:
- platform/gtk/http/tests/local/file-url-sent-as-referer-expected.txt:
- platform/gtk/http/tests/misc/favicon-as-image-expected.txt:
- platform/gtk/http/tests/misc/frame-access-during-load-expected.txt:
- platform/gtk/http/tests/misc/iframe404-expected.txt:
- platform/gtk/http/tests/misc/location-replace-crossdomain-expected.txt:
- platform/gtk/http/tests/multipart/invalid-image-data-standalone-expected.txt:
- platform/gtk/media/media-document-audio-repaint-expected.txt:
- platform/gtk/plugins/iframe-plugin-bgcolor-expected.txt:
- platform/gtk/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
- platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
- platform/gtk/svg/hixie/rendering-model/003-expected.txt:
- platform/gtk/svg/in-html/by-reference-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
- platform/iphone-simulator/text-autosizing/contenteditable-expected.txt:
- platform/mac-mountainlion/editing/selection/4975120-expected.txt:
- platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
- platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt:
- platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
- platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac-wk2/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
- platform/mac/compositing/iframes/composited-iframe-alignment-expected.txt:
- platform/mac/compositing/iframes/iframe-copy-on-scroll-expected.txt:
- platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-004-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-005-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-007-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-011-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-012-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-014-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-018-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-019-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-021-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-025-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-026-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-028-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-032-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-033-expected.txt:
- platform/mac/css2.1/20110323/absolute-replaced-height-035-expected.txt:
- platform/mac/css2.1/20110323/block-replaced-height-004-expected.txt:
- platform/mac/css2.1/20110323/block-replaced-height-005-expected.txt:
- platform/mac/css2.1/20110323/block-replaced-height-007-expected.txt:
- platform/mac/css2.1/20110323/float-replaced-height-004-expected.txt:
- platform/mac/css2.1/20110323/float-replaced-height-005-expected.txt:
- platform/mac/css2.1/20110323/float-replaced-height-007-expected.txt:
- platform/mac/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
- platform/mac/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
- platform/mac/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
- platform/mac/css2.1/20110323/inline-replaced-height-004-expected.txt:
- platform/mac/css2.1/20110323/inline-replaced-height-005-expected.txt:
- platform/mac/css2.1/20110323/inline-replaced-height-007-expected.txt:
- platform/mac/editing/execCommand/find-after-replace-expected.txt:
- platform/mac/editing/execCommand/paste-1-expected.txt:
- platform/mac/editing/pasteboard/4631972-expected.txt:
- platform/mac/editing/pasteboard/copy-standalone-image-expected.txt:
- platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
- platform/mac/editing/pasteboard/paste-2-expected.txt:
- platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
- platform/mac/editing/selection/4776665-expected.txt:
- platform/mac/editing/selection/4960137-expected.txt:
- platform/mac/editing/selection/4975120-expected.txt:
- platform/mac/editing/selection/drag-in-iframe-expected.txt:
- platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
- platform/mac/editing/selection/iframe-expected.txt:
- platform/mac/editing/selection/select-all-iframe-expected.txt:
- platform/mac/fast/block/basic/013-expected.txt:
- platform/mac/fast/block/positioning/window-height-change-expected.txt:
- platform/mac/fast/css/line-height-overflow-expected.txt:
- platform/mac/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
- platform/mac/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
- platform/mac/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
- platform/mac/fast/flexbox/016-expected.txt:
- platform/mac/fast/forms/basic-textareas-expected.txt:
- platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
- platform/mac/fast/forms/targeted-frame-submission-expected.txt:
- platform/mac/fast/frames/001-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
- platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
- platform/mac/fast/frames/frameElement-iframe-expected.txt:
- platform/mac/fast/frames/iframe-option-crash-expected.txt:
- platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt:
- platform/mac/fast/frames/iframe-with-frameborder-expected.txt:
- platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
- platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
- platform/mac/fast/frames/viewsource-attribute-expected.txt:
- platform/mac/fast/frames/viewsource-on-image-file-expected.txt:
- platform/mac/fast/images/favicon-as-image-expected.txt:
- platform/mac/fast/overflow/scrollRevealButton-expected.txt:
- platform/mac/fast/repaint/4774354-expected.txt:
- platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
- platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
- platform/mac/fast/replaced/007-expected.txt:
- platform/mac/fast/replaced/border-radius-clip-expected.txt:
- platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
- platform/mac/fast/replaced/replaced-breaking-expected.txt:
- platform/mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
- platform/mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
- platform/mac/fast/table/quote-text-around-iframe-expected.txt:
- platform/mac/fast/text/selection-hard-linebreak-expected.txt:
- platform/mac/http/tests/loading/simple-subframe-expected.txt:
- platform/mac/http/tests/local/file-url-sent-as-referer-expected.txt:
- platform/mac/http/tests/misc/acid3-expected.txt:
- platform/mac/http/tests/misc/favicon-as-image-expected.txt:
- platform/mac/http/tests/misc/frame-access-during-load-expected.txt:
- platform/mac/http/tests/misc/iframe404-expected.txt:
- platform/mac/http/tests/misc/location-replace-crossdomain-expected.txt:
- platform/mac/http/tests/multipart/invalid-image-data-standalone-expected.txt:
- platform/mac/plugins/update-widget-from-style-recalc-expected.txt:
- platform/mac/plugins/update-widget-from-style-recalc.html:
- platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
- platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
- platform/mac/svg/custom/embedding-external-svgs-expected.txt:
- platform/mac/svg/hixie/rendering-model/003-expected.txt:
- platform/mac/svg/in-html/by-reference-expected.txt:
- platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
- platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
- platform/win-xp/media/media-document-audio-repaint-expected.txt:
- platform/win/http/tests/misc/acid3-expected.txt:
- plugins/iframe-plugin-bgcolor-expected.txt:
- printing/iframe-print-expected.txt:
- scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
- scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
- svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
- tables/mozilla/bugs/bug137388-1-expected.txt:
- tables/mozilla/bugs/bug137388-2-expected.txt:
- tables/mozilla/bugs/bug137388-3-expected.txt:
- tables/mozilla/bugs/bug50695-2-expected.txt:
- 10:49 PM Changeset in webkit [159016] by
-
- 6 edits2 adds in trunk/Source/WebKit2
Use createCFURLFromBuffer when converting a String to a CFURL
https://bugs.webkit.org/show_bug.cgi?id=124113
Reviewed by Anders Carlsson.
- Shared/API/c/cf/WKURLCF.mm:
(WKURLCopyCFURL): Replaced some code with a call to createCFURLFromBuffer(), which does the
same thing.
- Shared/Cocoa/WKNSURLExtras.h: Added.
- Shared/Cocoa/WKNSURLExtras.mm: Added.
(+[NSURL _web_URLWithWTFString:relativeToURL:]): Added. Returns nil for the null String,
otherwise returns the result of createCFURLFromBuffer().
- UIProcess/API/Cocoa/WKBackForwardListItem.mm:
(-[WKBackForwardListItem URL]): Changed to use +_web_URLWithWTFString:relativeToURL:.
(-[WKBackForwardListItem originalURL]): Ditto.
- UIProcess/API/Cocoa/WKNavigationData.mm:
(-[WKNavigationData destinationURL]): Ditto.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController unreachableURL]): Ditto.
- WebKit2.xcodeproj/project.pbxproj: Added references to new files.
- 10:45 PM Changeset in webkit [159015] by
-
- 3 edits2 copies9 moves1 add13 deletes in trunk/LayoutTests
Optimize baselines: svg/W3C-SVG-1.1-SE
Unreviewed; run "webkit-patch optimize-baselines svg/W3C-SVG-1.1-SE"
- platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
- platform/win-future/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt.
- platform/win-future/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt.
- svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt.
- svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt.
- svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt.
- svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt.
- svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt.
- svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt.
- svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt.
- svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
- svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt.
- svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- 10:42 PM Changeset in webkit [159014] by
-
- 1 edit9 moves9 deletes in trunk/LayoutTests
Optimize baselines: svg/carto.net
Unreviewed; run "webkit-patch optimize-baselines svg/carto.net"
- platform/gtk/svg/carto.net/button-expected.txt: Removed.
- platform/gtk/svg/carto.net/colourpicker-expected.txt: Removed.
- platform/gtk/svg/carto.net/combobox-expected.txt: Removed.
- platform/gtk/svg/carto.net/scrollbar-expected.txt: Removed.
- platform/gtk/svg/carto.net/selectionlist-expected.txt: Removed.
- platform/gtk/svg/carto.net/slider-expected.txt: Removed.
- platform/gtk/svg/carto.net/tabgroup-expected.txt: Removed.
- platform/gtk/svg/carto.net/textbox-expected.txt: Removed.
- platform/gtk/svg/carto.net/window-expected.txt: Removed.
- svg/carto.net/button-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/button-expected.txt.
- svg/carto.net/colourpicker-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/colourpicker-expected.txt.
- svg/carto.net/combobox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/combobox-expected.txt.
- svg/carto.net/scrollbar-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/scrollbar-expected.txt.
- svg/carto.net/selectionlist-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/selectionlist-expected.txt.
- svg/carto.net/slider-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/slider-expected.txt.
- svg/carto.net/tabgroup-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/tabgroup-expected.txt.
- svg/carto.net/textbox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/textbox-expected.txt.
- svg/carto.net/window-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/window-expected.txt.
- 10:39 PM Changeset in webkit [159013] by
-
- 1 edit10 moves10 deletes in trunk/LayoutTests
Optimize baselines: svg/css
Unreviewed; run "webkit-patch optimize-baselines svg/css"
- platform/gtk/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
- platform/gtk/svg/css/clippath-with-shadow-expected.png: Removed.
- platform/gtk/svg/css/group-with-shadow-expected.txt: Removed.
- platform/gtk/svg/css/path-with-shadow-expected.png: Removed.
- platform/gtk/svg/css/shadow-with-large-radius-expected.png: Removed.
- platform/gtk/svg/css/shadow-with-negative-offset-expected.png: Removed.
- platform/gtk/svg/css/stars-with-shadow-expected.txt: Removed.
- platform/gtk/svg/css/text-gradient-shadow-expected.txt: Removed.
- platform/mac/svg/css/composite-shadow-example-expected.txt: Removed.
- platform/mac/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
- svg/css/circle-in-mask-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/circle-in-mask-with-shadow-expected.png.
- svg/css/clippath-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/clippath-with-shadow-expected.png.
- svg/css/composite-shadow-example-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-example-expected.txt.
- svg/css/composite-shadow-with-opacity-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-with-opacity-expected.txt.
- svg/css/group-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/group-with-shadow-expected.txt.
- svg/css/path-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/path-with-shadow-expected.png.
- svg/css/shadow-with-large-radius-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-large-radius-expected.png.
- svg/css/shadow-with-negative-offset-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-negative-offset-expected.png.
- svg/css/stars-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/stars-with-shadow-expected.txt.
- svg/css/text-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/text-gradient-shadow-expected.txt.
- 10:37 PM Changeset in webkit [159012] by
-
- 3 edits in trunk/Source/WebCore
SVGTextMetricsBuilder::walkTree() should take a RenderElement.
<https://webkit.org/b/124105>
Make walkTree() take a RenderElement so we can use the non-virtual
firstChild() internally. All call sites had pointers to compatible
objects already.
Reviewed by Anders Carlsson.
- 9:48 PM Changeset in webkit [159011] by
-
- 3 edits in trunk/Source/WebCore
RenderMathMLFenced should pass around operators in tighter types.
<https://webkit.org/b/124115>
Store operator renderers in RenderMathMLOperator pointers instead
of passing them around as RenderObject.
Reviewed by Martin Robinson.
- 9:47 PM Changeset in webkit [159010] by
-
- 6 edits in trunk/Source/WebCore
Use RENDER_OBJECT_TYPE_CASTS for more types.
<https://webkit.org/b/124112>
Generate toRenderFoo() type casting helpers for these classes:
- RenderCombineText
- RenderDetailsMarker
- RenderListMarker
- RenderVideo
- RenderView
Reviewed by Anders Carlsson.
- 9:08 PM Changeset in webkit [159009] by
-
- 13 edits in trunk/Source/WebCore
Move MathML type checking virtuals to RenderObject.
<https://webkit.org/b/124111>
Previously, checking the type of a MathML renderer would require
that you first check if it's a RenderMathMLBlock, and then casting
to that type to access the check you really wanted.
This change moves all the isRenderMathMLFoo() virtual functions
to RenderObject. I also made sure all the overloads were private
and marked them OVERRIDE/FINAL as appropriate.
Finally I replaced all the hand-written casting functions with
autogenerated ones using RENDER_OBJECT_TYPE_CASTS.
Reviewed by Anders Carlsson.
- 8:20 PM Changeset in webkit [159008] by
-
- 12 edits3 moves6 adds in trunk
Add Map Iterators
https://bugs.webkit.org/show_bug.cgi?id=124109
Reviewed by Andreas Kling.
Source/JavaScriptCore:
Added new Map iterator implementation. This is a mostly boilerplate patch
however there's a a little bit of additional logic added to the MapData iterator
to deal with the possibility of map mutation between creation of the iterator
and use of it. We'll be able to improve the performance of this substantially
by using intrinsics, however I'm pondering coming up with a better way to define
these thunks without requiring so much duplicated logic.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/CommonIdentifiers.h:
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
- runtime/JSMapIterator.cpp: Added.
(JSC::JSMapIterator::finishCreation):
(JSC::JSMapIterator::visitChildren):
(JSC::JSMapIterator::createPair):
- runtime/JSMapIterator.h: Added.
(JSC::JSMapIterator::createStructure):
(JSC::JSMapIterator::create):
(JSC::JSMapIterator::next):
(JSC::JSMapIterator::JSMapIterator):
- runtime/MapData.h:
(JSC::MapData::const_iterator::ensureSlot):
- runtime/MapIteratorConstructor.cpp: Added.
(JSC::MapIteratorConstructor::finishCreation):
- runtime/MapIteratorConstructor.h: Added.
(JSC::MapIteratorConstructor::create):
(JSC::MapIteratorConstructor::createStructure):
(JSC::MapIteratorConstructor::MapIteratorConstructor):
- runtime/MapIteratorPrototype.cpp: Added.
(JSC::MapIteratorPrototype::finishCreation):
(JSC::MapIteratorPrototypeFuncIterator):
(JSC::MapIteratorPrototypeFuncNext):
- runtime/MapIteratorPrototype.h: Added.
(JSC::MapIteratorPrototype::create):
(JSC::MapIteratorPrototype::createStructure):
(JSC::MapIteratorPrototype::MapIteratorPrototype):
- runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
(JSC::mapProtoFuncValues):
(JSC::mapProtoFuncEntries):
(JSC::mapProtoFuncKeys):
LayoutTests:
Moved map tests to a more sensible location, and added new iteration tests.
- js/basic-map-expected.txt: Renamed from LayoutTests/js/dom/basic-map-expected.txt.
- js/basic-map.html: Renamed from LayoutTests/js/dom/basic-map.html.
- js/script-tests/basic-map.js: Renamed from LayoutTests/js/dom/script-tests/basic-map.js.
(set shouldBe):
(set var):
- 7:39 PM Changeset in webkit [159007] by
-
- 7 edits in trunk
[MathML] Poor spacing around delimiters in MathML Torture Test 14
https://bugs.webkit.org/show_bug.cgi?id=122837
Reviewed by Brent Fulgham.
Instead of stretching the vertical bar with the stretchable version, just repeat
the normal vertical bar. This follows what Gecko does when rendering tall vertical
bars and also works around an issue with STIX fonts leading to poor spacing in
formulas.
Source/WebCore:
- rendering/mathml/RenderMathMLOperator.cpp: Stretch the vertical bar with the
normal variant.
LayoutTests:
- platform/gtk/mathml/presentation/mo-stretch-expected.png: Update to reflect new results.
- platform/gtk/mathml/presentation/mo-stretch-expected.txt: Ditto.
- platform/mac/mathml/presentation/mo-stretch-expected.png: Ditto.
- platform/mac/mathml/presentation/mo-stretch-expected.txt: Ditto.
- 7:36 PM Changeset in webkit [159006] by
-
- 2 edits1 copy20 moves1 add22 deletes in trunk/LayoutTests
Optimize baselines: svg/clip-path
Unreviewed; run "webkit-patch optimize-baselines svg/clip-path"
- platform/efl/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-in-clip-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-recursive-call-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-text-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-with-container-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
- platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
- platform/gtk/svg/clip-path/clipper-placement-issue-expected.png: Removed.
- platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
- platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
- platform/win-future/svg/clip-path/clip-path-pixelation-expected.txt: Copied from LayoutTests/svg/clip-path/clip-path-pixelation-expected.txt.
- svg/clip-path/clip-in-clip-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-in-clip-expected.png.
- svg/clip-path/clip-path-clipped-no-content-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.png.
- svg/clip-path/clip-path-pixelation-expected.txt:
- svg/clip-path/clip-path-recursive-call-by-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.png.
- svg/clip-path/clip-path-recursive-call-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-expected.png.
- svg/clip-path/clip-path-text-and-shape-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt.
- svg/clip-path/clip-path-text-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.txt.
- svg/clip-path/clip-path-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-expected.txt.
- svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.txt.
- svg/clip-path/clip-path-use-as-child2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child2-expected.png.
- svg/clip-path/clip-path-use-as-child3-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child3-expected.png.
- svg/clip-path/clip-path-use-as-child4-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child4-expected.png.
- svg/clip-path/clip-path-use-as-child5-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child5-expected.png.
- svg/clip-path/clip-path-with-container-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-container-expected.png.
- svg/clip-path/clip-path-with-different-unittypes-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.png.
- svg/clip-path/clip-path-with-different-unittypes2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.png.
- svg/clip-path/clip-path-with-invisibile-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.png.
- svg/clip-path/clip-path-with-text-clipped-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt.
- svg/clip-path/clipper-placement-issue-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clipper-placement-issue-expected.png.
- svg/clip-path/deep-nested-clip-in-mask-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt.
- svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt.
- 7:32 PM Changeset in webkit [159005] by
-
- 2 edits5 copies48 moves2 adds57 deletes in trunk/LayoutTests
Optimize baselines: svg/hixie
Unreviewed; run "webkit-patch optimize-baselines svg/hixie"
- platform/efl/svg/hixie/perf/007-expected.txt: Removed.
- platform/gtk/svg/hixie/dynamic/002-expected.png: Removed.
- platform/gtk/svg/hixie/dynamic/003-expected.png: Removed.
- platform/gtk/svg/hixie/dynamic/004-expected.png: Removed.
- platform/gtk/svg/hixie/dynamic/005-expected.png: Removed.
- platform/gtk/svg/hixie/dynamic/006-expected.png: Removed.
- platform/gtk/svg/hixie/error/001-expected.png: Removed.
- platform/gtk/svg/hixie/error/002-expected.png: Removed.
- platform/gtk/svg/hixie/error/002-expected.txt: Removed.
- platform/gtk/svg/hixie/error/003-expected.txt: Removed.
- platform/gtk/svg/hixie/error/006-expected.png: Removed.
- platform/gtk/svg/hixie/error/007-expected.png: Removed.
- platform/gtk/svg/hixie/error/008-expected.png: Removed.
- platform/gtk/svg/hixie/error/009-expected.png: Removed.
- platform/gtk/svg/hixie/error/010-expected.png: Removed.
- platform/gtk/svg/hixie/error/010-expected.txt: Removed.
- platform/gtk/svg/hixie/error/011-expected.png: Removed.
- platform/gtk/svg/hixie/error/011-expected.txt: Removed.
- platform/gtk/svg/hixie/error/014-expected.png: Removed.
- platform/gtk/svg/hixie/error/014-test-expected.png: Removed.
- platform/gtk/svg/hixie/error/015-expected.png: Removed.
- platform/gtk/svg/hixie/error/016-expected.png: Removed.
- platform/gtk/svg/hixie/error/017-expected.txt: Removed.
- platform/gtk/svg/hixie/intrinsic/001-expected.png: Removed.
- platform/gtk/svg/hixie/intrinsic/001-expected.txt: Removed.
- platform/gtk/svg/hixie/intrinsic/002-expected.png: Removed.
- platform/gtk/svg/hixie/intrinsic/002-expected.txt: Removed.
- platform/gtk/svg/hixie/links/002-expected.png: Removed.
- platform/gtk/svg/hixie/links/002-expected.txt: Removed.
- platform/gtk/svg/hixie/mixed/007-expected.png: Removed.
- platform/gtk/svg/hixie/painting/001-expected.png: Removed.
- platform/gtk/svg/hixie/perf/001-expected.txt: Removed.
- platform/gtk/svg/hixie/perf/002-expected.txt: Removed.
- platform/gtk/svg/hixie/perf/003-expected.txt: Removed.
- platform/gtk/svg/hixie/perf/004-expected.txt: Removed.
- platform/gtk/svg/hixie/perf/005-expected.txt: Removed.
- platform/gtk/svg/hixie/perf/006-expected.txt: Removed.
- platform/gtk/svg/hixie/perf/007-expected.txt: Removed.
- platform/gtk/svg/hixie/processing-model/003-expected.png: Removed.
- platform/gtk/svg/hixie/processing-model/004-expected.png: Removed.
- platform/gtk/svg/hixie/processing-model/005-expected.png: Removed.
- platform/gtk/svg/hixie/rendering-model/003a-expected.png: Removed.
- platform/gtk/svg/hixie/shapes/path/001-expected.txt: Removed.
- platform/gtk/svg/hixie/text/002-expected.txt: Removed.
- platform/gtk/svg/hixie/text/003a-expected.txt: Removed.
- platform/gtk/svg/hixie/text/003b-expected.txt: Removed.
- platform/gtk/svg/hixie/use/001-expected.png: Removed.
- platform/gtk/svg/hixie/use/002-expected.png: Removed.
- platform/gtk/svg/hixie/use/002-test-expected.png: Removed.
- platform/gtk/svg/hixie/viewbox/001-expected.png: Removed.
- platform/gtk/svg/hixie/viewbox/004-expected.png: Removed.
- platform/gtk/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
- platform/gtk/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
- platform/mac/svg/hixie/cascade/002-expected.txt: Removed.
- platform/mac/svg/hixie/perf/004-expected.txt: Removed.
- platform/mac/svg/hixie/perf/005-expected.txt: Removed.
- platform/mac/svg/hixie/perf/006-expected.txt: Removed.
- platform/win-future/svg/hixie/perf/007-expected.txt: Copied from LayoutTests/svg/hixie/perf/007-expected.txt.
- svg/hixie/cascade/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/cascade/002-expected.txt.
- svg/hixie/dynamic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/002-expected.png.
- svg/hixie/dynamic/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/003-expected.png.
- svg/hixie/dynamic/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/004-expected.png.
- svg/hixie/dynamic/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/005-expected.png.
- svg/hixie/dynamic/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/006-expected.png.
- svg/hixie/error/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/001-expected.png.
- svg/hixie/error/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.png.
- svg/hixie/error/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.txt.
- svg/hixie/error/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/003-expected.txt.
- svg/hixie/error/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/006-expected.png.
- svg/hixie/error/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/007-expected.png.
- svg/hixie/error/008-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/008-expected.png.
- svg/hixie/error/009-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/009-expected.png.
- svg/hixie/error/010-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.png.
- svg/hixie/error/010-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.txt.
- svg/hixie/error/011-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.png.
- svg/hixie/error/011-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.txt.
- svg/hixie/error/014-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-expected.png.
- svg/hixie/error/014-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-test-expected.png.
- svg/hixie/error/015-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/015-expected.png.
- svg/hixie/error/016-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/016-expected.png.
- svg/hixie/error/017-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/017-expected.txt.
- svg/hixie/intrinsic/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.png.
- svg/hixie/intrinsic/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.txt.
- svg/hixie/intrinsic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.png.
- svg/hixie/intrinsic/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.txt.
- svg/hixie/links/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.png.
- svg/hixie/links/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.txt.
- svg/hixie/mixed/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/mixed/007-expected.png.
- svg/hixie/painting/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/painting/001-expected.png.
- svg/hixie/perf/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/001-expected.txt.
- svg/hixie/perf/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/002-expected.txt.
- svg/hixie/perf/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/003-expected.txt.
- svg/hixie/perf/004-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/004-expected.txt.
- svg/hixie/perf/005-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/005-expected.txt.
- svg/hixie/perf/006-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/006-expected.txt.
- svg/hixie/perf/007-expected.txt:
- svg/hixie/processing-model/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/003-expected.png.
- svg/hixie/processing-model/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/004-expected.png.
- svg/hixie/processing-model/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/005-expected.png.
- svg/hixie/rendering-model/003a-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/rendering-model/003a-expected.png.
- svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/shapes/path/001-expected.txt.
- svg/hixie/text/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/002-expected.txt.
- svg/hixie/text/003a-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003a-expected.txt.
- svg/hixie/text/003b-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003b-expected.txt.
- svg/hixie/use/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/001-expected.png.
- svg/hixie/use/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-expected.png.
- svg/hixie/use/002-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-test-expected.png.
- svg/hixie/viewbox/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/001-expected.png.
- svg/hixie/viewbox/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/004-expected.png.
- svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.
- svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt.
- 5:27 PM Changeset in webkit [159004] by
-
- 7 edits in trunk/Source
Encode form data using the KeyedEncoder
https://bugs.webkit.org/show_bug.cgi?id=124107
Reviewed by Sam Weinig.
Source/WebCore:
- platform/KeyedCoding.h:
(WebCore::KeyedEncoder::encodeEnum):
- platform/network/FormData.cpp:
(WebCore::encodeElement):
(WebCore::FormData::encode):
- platform/network/FormData.h:
Source/WebKit2:
- Shared/cf/KeyedEncoder.cpp:
(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeDouble):
- Shared/cf/KeyedEncoder.h:
- 3:26 PM Changeset in webkit [159003] by
-
- 1 edit1 delete in trunk/Source/WebKit2
Remove an unused file.
Rubber-stamped by Andreas Kling.
- WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp: Removed.
- 1:41 PM Changeset in webkit [159002] by
-
- 2 edits in trunk/Source/WebCore
Modernize CanvasObserverProxy
https://bugs.webkit.org/show_bug.cgi?id=124106
Reviewed by Anders Carlsson.
- css/CSSCanvasValue.h:
- 12:59 PM Changeset in webkit [159001] by
-
- 101 edits7 moves1 add in trunk/Source
Move RunLoop from WebCore to WTF
https://bugs.webkit.org/show_bug.cgi?id=116606
Reviewed by Anders Carlsson.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- PlatformWin.cmake:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
Source/WebKit/mac:
- Carbon/CarbonWindowAdapter.mm:
(+[CarbonWindowAdapter initialize]):
- History/WebBackForwardList.mm:
(+[WebBackForwardList initialize]):
- History/WebHistoryItem.mm:
(+[WebHistoryItem initialize]):
- Misc/WebCache.mm:
(+[WebCache initialize]):
- Misc/WebElementDictionary.mm:
(+[WebElementDictionary initialize]):
- Misc/WebIconDatabase.mm:
(+[WebIconDatabase initialize]):
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(+[WebHostedNetscapePluginView initialize]):
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebBasePluginPackage.mm:
- Plugins/WebNetscapePluginView.mm:
(+[WebNetscapePluginView initialize]):
- WebCoreSupport/WebEditorClient.mm:
(+[WebUndoStep initialize]):
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebArchive.mm:
(+[WebArchivePrivate initialize]):
- WebView/WebDataSource.mm:
(+[WebDataSource initialize]):
- WebView/WebHTMLView.mm:
(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- WebView/WebResource.mm:
(+[WebResourcePrivate initialize]):
- WebView/WebTextIterator.mm:
(+[WebTextIteratorPrivate initialize]):
- WebView/WebView.mm:
(+[WebView initialize]):
- WebView/WebViewData.mm:
(+[WebViewPrivate initialize]):
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.cpp:
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- NetworkProcess/NetworkProcess.cpp:
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/mac/DiskCacheMonitor.h:
- NetworkProcess/unix/NetworkProcessMainUnix.cpp:
- Platform/CoreIPC/Connection.cpp:
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginProcess.cpp:
- PluginProcess/PluginProcess.h:
- PluginProcess/WebProcessConnection.cpp:
- PluginProcess/unix/PluginProcessMainUnix.cpp:
- Shared/ChildProcess.cpp:
- Shared/ChildProcess.h:
- Shared/ChildProcessProxy.cpp:
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
- Shared/Plugins/NPObjectProxy.cpp:
- Shared/WebKit2Initialize.cpp:
(WebKit::InitializeWebKit2):
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
- UIProcess/API/mac/FindIndicatorWindow.h:
- UIProcess/API/mac/WKPrintingView.mm:
- UIProcess/API/mac/WKView.mm:
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- UIProcess/Network/NetworkProcessProxy.cpp:
- UIProcess/Plugins/PluginProcessProxy.cpp:
- UIProcess/ResponsivenessTimer.cpp:
- UIProcess/ResponsivenessTimer.h:
- UIProcess/VisitedLinkProvider.h:
- UIProcess/WebContext.cpp:
- UIProcess/WebProcessProxy.cpp:
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
- WebProcess/Network/WebResourceLoadScheduler.h:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/PluginView.h:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/EventDispatcher.cpp:
- WebProcess/WebPage/PageOverlay.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.cpp:
- WebProcess/efl/WebProcessMainEfl.cpp:
- WebProcess/gtk/WebProcessMainGtk.cpp:
Source/WTF:
With this change RunLoop can be used in JavaScriptCore too.
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/PlatformBlackBerry.cmake:
- wtf/PlatformEfl.cmake:
- wtf/PlatformGTK.cmake:
- wtf/PlatformWin.cmake:
- wtf/RunLoop.cpp: Renamed from Source/WebCore/platform/RunLoop.cpp.
(WTF::RunLoop::Holder::Holder):
(WTF::RunLoop::Holder::runLoop):
(WTF::RunLoop::initializeMainRunLoop):
(WTF::RunLoop::current):
(WTF::RunLoop::main):
(WTF::RunLoop::isMain):
(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):
- wtf/RunLoop.h: Renamed from Source/WebCore/platform/RunLoop.h.
(WTF::RunLoop::TimerBase::startRepeating):
(WTF::RunLoop::TimerBase::startOneShot):
(WTF::RunLoop::TimerBase::isRepeating):
(WTF::RunLoop::Timer::Timer):
(WTF::RunLoop::Timer::fired):
- wtf/blackberry/RunLoopBlackBerry.cpp: Renamed from Source/WebCore/platform/blackberry/RunLoopBlackBerry.cpp.
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):
- wtf/cf/RunLoopCF.cpp: Renamed from Source/WebCore/platform/cf/RunLoopCF.cpp.
(WTF::RunLoop::performWork):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::runForDuration):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):
- wtf/efl/RunLoopEfl.cpp: Renamed from Source/WebCore/platform/efl/RunLoopEfl.cpp.
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::wakeUpEvent):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):
- wtf/gtk/RunLoopGtk.cpp: Renamed from Source/WebCore/platform/gtk/RunLoopGtk.cpp.
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::innermostLoop):
(WTF::RunLoop::pushNestedMainLoop):
(WTF::RunLoop::popNestedMainLoop):
(WTF::RunLoop::stop):
(WTF::RunLoop::queueWork):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::clearTimerSource):
(WTF::RunLoop::TimerBase::timerFiredCallback):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):
- wtf/win/RunLoopWin.cpp: Renamed from Source/WebCore/platform/win/RunLoopWin.cpp.
(WTF::RunLoop::RunLoopWndProc):
(WTF::RunLoop::wndProc):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::registerRunLoopMessageWindowClass):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::generateTimerID):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):
- 8:11 AM Changeset in webkit [159000] by
-
- 4 edits in trunk/Source/WebCore
Tighten typing in SVGResourcesCycleSolver a bit.
<https://webkit.org/b/124104>
Make the SVGResourcesCycleSolver constructor take a RenderElement&
and a SVGResources&.
While I was in the neighborhood, also converted one loop to use a
renderer iterator instead of walking siblings manually.
Finally used "auto" to clean up some overly wordy loops.
Reviewed by Anders Carlsson.
- 3:32 AM Changeset in webkit [158999] by
-
- 18 edits in trunk/Source/WebCore
Beat SVGRenderSupport with the RenderElement stick.
<https://webkit.org/b/124102>
Tighten up all the SVGRenderSupport helper functions by making them
take const RenderElements references instead of raw RenderObject
pointers as much as possible.
This tunes up a bunch of branchy style() calls.
The patch looks big but it's mostly mechanical. I just changed the
signatures and then worked backwards until everything built again.
Reviewed by Antti Koivisto.
- 3:17 AM Changeset in webkit [158998] by
-
- 10 edits in trunk/Source/WebCore
SVGTextLayoutAttributes always has a RenderSVGInlineText.
<https://webkit.org/b/124101>
No SVGTextLayoutAttributes object is without a RenderSVGInlineText
"context" so make context() return a reference.
Reviewed by Antti Koivisto.
- 3:16 AM Changeset in webkit [158997] by
-
- 13 edits2 deletes in trunk/Source/WebCore
Move BindingSecurity stuff under JSDOMBinding umbrella.
<https://webkit.org/b/124099>
We are hitting shouldAllowAccessToDOMWindow() pretty hard on the
demo here: <http://www.jasondavies.com/maps/rotate/>
Putting it together with the rest of the JSDOMBinding code takes
CPU time spent in there from 8.7% to 6.5%. The abstraction was
only used to support alternate JS engines in the past.
Reviewed by Antti Koivisto.
- 3:14 AM Changeset in webkit [158996] by
-
- 2 edits in trunk/PerformanceTests
Add subtest for word-break:break-all to Layout/line-layout-simple.html
https://bugs.webkit.org/show_bug.cgi?id=124103
Reviewed by Andreas Kling.
- Layout/line-layout-simple.html:
Combination "white-space:pre-wrap; word-break:break-all" is common for pure text.
Nov 8, 2013:
- 11:57 PM Changeset in webkit [158995] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed GTK build fix.
- GNUmakefile.list.am: Remove redundant build targets.
- 10:55 PM Changeset in webkit [158994] by
-
- 4 edits2 deletes in trunk/Source/JavaScriptCore
Remove dead FTL C ABI support
https://bugs.webkit.org/show_bug.cgi?id=124100
Reviewed by Jer Noble.
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/FTLCArgumentGetter.cpp: Removed.
- ftl/FTLCArgumentGetter.h: Removed.
- ftl/FTLOSRExitCompiler.cpp:
- jit/FPRInfo.h:
- 10:53 PM Changeset in webkit [158993] by
-
- 3 edits in trunk/WebKitLibraries
Update binary drops to a version that includes new stackmap fixes and exposes the new calling conventions.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 10:27 PM Changeset in webkit [158992] by
-
- 39 edits2 moves1 delete in trunk/Source
Merge IDBDatabaseBackendInterface and IDBDatabaseBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124088
Source/WebCore:
Reviewed by Tim Horton.
Source/WebKit2:
Reviewed by Tim Horton.
This abstraction is no longer meaningful in its current form in WebCore.
The current groundwork for the WK2 DatabaseProcess relied on this abstraction,
but that will be reworked in a future patch.
- DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.h:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::maybeCreateTransactionBackend):
(WebKit::WebIDBFactoryBackend::createCursorBackend):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:
(WebKit::WebProcessIDBDatabaseBackend::put):
(WebKit::WebProcessIDBDatabaseBackend::openCursor):
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
- 10:00 PM Changeset in webkit [158991] by
-
- 12 edits in trunk/LayoutTests
Updating LayoutTests that depend on RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=124097
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.
Needed to do not throw unwanted exception
- fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
- fast/mediastream/RTCPeerConnection-createAnswer.html:
- fast/mediastream/RTCPeerConnection-createOffer.html:
- fast/mediastream/RTCPeerConnection-datachannel.html:
- fast/mediastream/RTCPeerConnection-dtmf.html:
- fast/mediastream/RTCPeerConnection-events.html:
- fast/mediastream/RTCPeerConnection-ice.html:
- fast/mediastream/RTCPeerConnection-localDescription.html:
- fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
- fast/mediastream/RTCPeerConnection-remoteDescription.html:
- fast/mediastream/RTCPeerConnection-state.html:
- 8:40 PM Changeset in webkit [158990] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r158984.
No needs to include "KeyedEncoder.h".
WebKit/Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:31:26: fatal error: KeyedEncoder.h: No such file or directory
- WebProcess/WebPage/WebBackForwardListProxy.cpp: Removed #include line.
- 8:24 PM Changeset in webkit [158989] by
-
- 4 edits in trunk/Source/JavaScriptCore
FTL should support Phantom(FinalObject:)
https://bugs.webkit.org/show_bug.cgi?id=124092
Reviewed by Oliver Hunt.
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isType):
(JSC::FTL::LowerDFGToLLVM::isNotType):
(JSC::FTL::LowerDFGToLLVM::speculateFinalObject):
- 8:20 PM Changeset in webkit [158988] by
-
- 3 edits in trunk/Source/JavaScriptCore
Get rid of the FTL tail call APIs since they are unused
https://bugs.webkit.org/show_bug.cgi?id=124093
Reviewed by Oliver Hunt.
- ftl/FTLAbbreviations.h:
(JSC::FTL::buildCall):
- ftl/FTLOutput.h:
- 8:17 PM Changeset in webkit [158987] by
-
- 25 edits in trunk/LayoutTests
Improving readability of LayoutTests in fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=124095
Adding some indentation
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.
- fast/mediastream/MediaStream-add-remove-tracks.html:
- fast/mediastream/MediaStream-onended.html:
- fast/mediastream/MediaStreamConstructor.html:
- fast/mediastream/RTCIceCandidate.html:
- fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
- fast/mediastream/RTCPeerConnection-createAnswer.html:
- fast/mediastream/RTCPeerConnection-createOffer.html:
- fast/mediastream/RTCPeerConnection-datachannel.html:
- fast/mediastream/RTCPeerConnection-dtmf.html:
- fast/mediastream/RTCPeerConnection-events.html:
- fast/mediastream/RTCPeerConnection-ice.html:
- fast/mediastream/RTCPeerConnection-localDescription.html:
- fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
- fast/mediastream/RTCPeerConnection-remoteDescription.html:
- fast/mediastream/RTCPeerConnection-state.html:
- fast/mediastream/RTCPeerConnection-stats.html:
- fast/mediastream/RTCPeerConnection-statsSelector.html:
- fast/mediastream/RTCPeerConnection.html:
- fast/mediastream/RTCSessionDescription.html:
- fast/mediastream/argument-types.html:
- fast/mediastream/constructors.html:
- fast/mediastream/enabled.html:
- fast/mediastream/getusermedia.html:
- fast/mediastream/no-interface-object.html:
- 7:40 PM Changeset in webkit [158986] by
-
- 2 edits in trunk/Source/WebCore
Reindent JSDOMBinding.h (finally.)
Rubber-stamped by Sam Weinig.
- 7:24 PM Changeset in webkit [158985] by
-
- 64 edits in trunk/Source/WebCore
Change collectStyleForPresentationAttribute and related functions to take a MutableStylePropertySet by reference
https://bugs.webkit.org/show_bug.cgi?id=124096
Reviewed by Andreas Kling.
Pass MutableStylePropertySet by reference. It is never null.
- 5:51 PM Changeset in webkit [158984] by
-
- 7 edits in trunk/Source
Implement encoding of arrays of objects
https://bugs.webkit.org/show_bug.cgi?id=124091
Reviewed by Beth Dakin.
Source/WebCore:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the rest of the members.
- platform/KeyedCoding.h:
(WebCore::KeyedEncoder::encodeObjects):
Call beginArray, then beginArrayElement/endArrayElement for every element and lastly endArray.
Source/WebKit2:
Add a new array stack and push and pop from it accordingly.
- Shared/cf/KeyedEncoder.cpp:
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):
- Shared/cf/KeyedEncoder.h:
- 5:44 PM Changeset in webkit [158983] by
-
- 5 edits in trunk/Source/JavaScriptCore
FTL should support AllocatePropertyStorage
https://bugs.webkit.org/show_bug.cgi?id=124086
Reviewed by Oliver Hunt.
Also rationalized some offsets in the DFG.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAllocatePropertyStorage):
- 5:43 PM Changeset in webkit [158982] by
-
- 13 edits in trunk/Source
Remote Layer Tree: RemoteLayerBackingStore partial repaint is broken for the tile cache
https://bugs.webkit.org/show_bug.cgi?id=123944
Reviewed by Simon Fraser.
Ensure that the tile cache retrieves repaint rects from the tile layer,
not from the tiled backing layer.
Rework RemoteLayerBackingStore painting to fix some rounding issues
that would cause pixel cracks upon repaint, and to speed it up a bit.
- Shared/mac/RemoteLayerBackingStore.h:
Redefine RepaintRectList because we can't include WebLayer.h here yet.
Remove createBackingStore, which was never implemented.
Remove mapToContentCoordinates, because we don't need it on Mac.
(WebKit::RemoteLayerBackingStore::paintingRects): Added.
- Shared/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::setNeedsDisplay):
(RemoteLayerBackingStore::display):
Stop using mapToContentCoordinates.
(RemoteLayerBackingStore::drawInContext):
Use clipping instead of painting the image multiple times.
Never repaint more than the dirty region's bounds.
Don't waste time with all of the drawNativeImage code, just use CG.
Unindent the switch's cases.
Store the rects we're painting so that enumerateRectsBeingDrawn can get them.
Pixel-snap the rects we're painting.
Clip the context before going to paint.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::enumerateRectsBeingDrawn):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Retrieve the rects currently being painted from our backing store, and
transform them (mostly) according to the CTM, to match the transformation
that will have occurred underneath wkCALayerEnumerateRectsBeingDrawnWithBlock.
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::enumerateRectsBeingDrawn):
Allow the PlatformCALayer to decide how to enumerate rects to paint.
- WebCore.exp.in:
- platform/graphics/mac/WebLayer.h:
Add RepaintRectList, remove some unnecessary WebCore::s.
- platform/graphics/mac/WebLayer.mm:
(WebCore::collectRectsToPaint):
Factor collectRectsToPaint out; it just grabs the rects from
the layer and makes the decision whether to repaint the bounds
of the dirty region or just the subregions.
Move calls to collectRectsToPaint() to callers of drawLayerContents(),
so that TileController can collect rects from the appropriate source
(the Tile layer) and other layers just continue grabbing them from
their relevant layers.
Make sure that the list that comes from collectRectsToPaint() always
has at least one rect in it (appending the clip bounds if we don't
want to repaint subregions) so we can simplify logic in drawLayerContents.
(WebCore::drawLayerContents):
Remove code to support CompositingCoordinatesBottomUp, as it's only
used on Windows, so this Mac-specific code doesn't need to support it.
Simplify logic given that dirtyRects will always be non-empty.
(-[WebLayer drawInContext:]):
(-[WebSimpleLayer setNeedsDisplayInRect:]):
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::platformCALayerPaintContents):
Adopt collectRectsToPaint.
- 5:29 PM Changeset in webkit [158981] by
-
- 3 edits in trunk/Source/JavaScriptCore
Get rid of the bizarre Darwin/x86-only MacroAssembler::shouldBlindForSpecificArch(uintptr_t) overload
https://bugs.webkit.org/show_bug.cgi?id=124087
Reviewed by Michael Saboff.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlindPointerForSpecificArch):
(JSC::MacroAssembler::shouldBlind):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::shouldBlindForSpecificArch):
- 5:16 PM Changeset in webkit [158980] by
-
- 7 edits in trunk/Source
Implement more KeyedEncoder functionality
https://bugs.webkit.org/show_bug.cgi?id=124089
Reviewed by Beth Dakin.
Source/WebCore:
- bindings/js/SerializedScriptValue.h:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode):
- platform/KeyedCoding.h:
(WebCore::KeyedEncoder::encodeConditionalObject):
Source/WebKit2:
- Shared/cf/KeyedEncoder.cpp:
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeFloat):
- Shared/cf/KeyedEncoder.h:
- 5:13 PM Changeset in webkit [158979] by
-
- 3 edits2 adds in trunk
getCueAsHTML() on an empty cue should return a document fragment
https://bugs.webkit.org/show_bug.cgi?id=124084
Reviewed by Darin Adler.
Source/WebCore:
Test: media/track/track-cue-empty-cue-text.html
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::createDocumentFragmentFromCueText): Don't return early when the
passed an empty string.
LayoutTests:
- media/track/track-cue-empty-cue-text-expected.txt: Added.
- media/track/track-cue-empty-cue-text.html: Added.
- 4:51 PM Changeset in webkit [158978] by
-
- 7 edits in trunk/Source
KeyedEncoder should be able to encoder objects
https://bugs.webkit.org/show_bug.cgi?id=124085
Reviewed by Sam Weinig.
Source/WebCore:
- history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTree):
Encode the root object.
(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the target.
- history/HistoryItem.h:
Add new members.
- platform/KeyedCoding.h:
(WebCore::KeyedEncoder::encodeObject):
Call beginObject, call the functor and then call endObject().
Source/WebKit2:
Add a dictionary stack to KeyedEncoder that's pushed and popped by
beginObject/endObject.
- Shared/cf/KeyedEncoder.cpp:
(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):
- Shared/cf/KeyedEncoder.h:
- 4:42 PM Changeset in webkit [158977] by
-
- 6 edits in trunk/Source/JavaScriptCore
FTL should support NewArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=124067
Reviewed by Michael Saboff.
This expanded coverage and revealed some bugs.
This revealed a bug in FTL::OSRExitCompiler where it was assuming that it could save
the framePointer in regT3 even though DFG::reifyInlinedCallFrames() would clobber it.
It turns out that this can be fixed by just completely restoring the stack prior to
doing reifyInlineCallFrames().
I used this as an opportunity to simplify NewArray. That revealed a bug; whenever we say
lowJSValue() in there we need to use ManualOperandSpeculation since we're using it to
rebox values even when we also have to do some speculations. The speculations are done
at the top of compileNewArray().
This also revealed a bug in StringCharAt() for the OOB case.
- ftl/FTLAbstractHeapRepository.h:
(JSC::FTL::AbstractHeapRepository::forIndexingType):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayBuffer):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- 4:39 PM Changeset in webkit [158976] by
-
- 4 edits2 adds in trunk
Web Inspector: It should be possible to debug the Inspector code
https://bugs.webkit.org/show_bug.cgi?id=124065
Reviewed by Timothy Hatcher.
Source/WebKit2:
When the script is paused, the debugger will pause all the pages in the same PageGroup.
All the Inspector windows were created in the same PageGroup, so pausing one debugger
would stop the other too.
Added WebInspectorPageGroups to manage the PageGroups created for the Inspectors.
The WebInspectors will now use the inspection "level" to figure out which PageGroup to use.
The inspector that debugs the main page will use "WebInspectorPageGroupLevel1",
the second inspector (that debugs the first inspector) will use "WebInspectorPageGroupLevel2" ...
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorPageGroups::shared):
(WebKit::WebInspectorPageGroups::inspectorLevel):
(WebKit::WebInspectorPageGroups::isInspectorPageGroup):
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
(WebKit::WebInspectorPageGroups::inspectorPageGroupForLevel):
(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::inspectorPageGroup):
(WebKit::WebInspectorProxy::isInspectorPage):
(WebKit::WebInspectorProxy::canAttach):
- UIProcess/WebInspectorProxy.h:
LayoutTests:
Added test to check that a second inspector window can be used to debug the first one.
- inspector-protocol/debugger/nested-inspectors-expected.txt: Added.
- inspector-protocol/debugger/nested-inspectors.html: Added.
- 4:39 PM Changeset in webkit [158975] by
-
- 5 edits in trunk/Source/JavaScriptCore
It should be easy to disable blinding on a per-architecture basis
https://bugs.webkit.org/show_bug.cgi?id=124083
Reviewed by Michael Saboff.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::haveScratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::scratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::canBlind):
(JSC::AbstractMacroAssembler::shouldBlindForSpecificArch):
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlind):
(JSC::MacroAssembler::store32):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branchAdd32):
(JSC::MacroAssembler::branchMul32):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::canBlind):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::haveScratchRegisterForBlinding):
- 4:32 PM Changeset in webkit [158974] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 4:29 PM Changeset in webkit [158973] by
-
- 1 copy in tags/Safari-537.73.5
New Tag.
- 4:27 PM Changeset in webkit [158972] by
-
- 5 edits in trunk/Source/WebCore
Teach CanvasObserver about references
https://bugs.webkit.org/show_bug.cgi?id=124082
Reviewed by Anders Carlsson.
- css/CSSCanvasValue.cpp:
- css/CSSCanvasValue.h:
- html/HTMLCanvasElement.cpp:
- html/HTMLCanvasElement.h:
- 4:25 PM Changeset in webkit [158971] by
-
- 8 edits3 moves2 deletes in trunk/Source
Begin stubbing out a KeyedEncoder class in WebCore
https://bugs.webkit.org/show_bug.cgi?id=124079
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.exp.in:
Add symbol needed by WebCore.
- WebCore.xcodeproj/project.pbxproj:
Add new header file.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTree):
- history/HistoryItem.h:
Add an encodeBackForwardTree overload that takes a KeyedEncoder object. Encode the version.
- platform/KeyedCoding.h:
Add a KeyedEncoder class that just has a single encodeUInt32 member function for now.
Source/WebKit2:
- Shared/KeyedEncoder.h: Removed.
- Shared/cf/KeyedCodingValueCF.cpp: Removed.
- Shared/cf/KeyedEncoder.cpp: Added.
Remove old keyed encoders.
(WebKit::createDictionary):
Helper function to create a mutable dictionary.
(WebKit::KeyedEncoder::KeyedEncoder):
Create the root dictionary.
(WebKit::KeyedEncoder::encodeUInt32):
Create a CFNumberRef and add it to the dictionary.
- Shared/cf/KeyedEncoder.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::updateBackForwardItem):
Create a KeyedEncoder and encode the history tree.
- 4:18 PM Changeset in webkit [158970] by
-
- 2 edits in branches/safari-537.73-branch/Source/JavaScriptCore
Rollout r158882. <rdar://problem/15426318>
- 4:09 PM Changeset in webkit [158969] by
-
- 20 edits1 move1 add2 deletes in trunk/Source
Merge IDBTransactionBackendInterface and IDBTransactionBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124077
Reviewed by Alexey Proskuryakov.
Source/WebCore:
The abstraction is no longer needed.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBTransactionBackendInterface.h: Removed.
- Modules/indexeddb/IDBTransactionBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp.
- Modules/indexeddb/IDBTransactionBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h.
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBCursorBackend.cpp:
- Modules/indexeddb/IDBCursorBackend.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/IDBTransactionBackendOperations.h:
- Modules/indexeddb/IDBTransactionCoordinator.cpp:
- Modules/indexeddb/IDBTransactionCoordinator.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- 3:53 PM Changeset in webkit [158968] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r155660): Some Etherpad pages not scrollable with overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=124075
Reviewed by Beth Dakin.
In r155660 I removed some scrollbar-related layouts when scrollbars
are in overlay mode.
However, ScrollView::updateScrollbars() has a case where we still need
to do multiple pases, related to its "Never ever try to both gain/lose a
scrollbar in the same pass" comment. When we avoid making a new scrollbar
because the other was removed, we need to do another pass to bring the
correct scrollbar back.
Can't test overlay scrollbars in tests.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
- 3:46 PM Changeset in webkit [158967] by
-
- 4 edits4 adds in trunk
[CSS Shapes] Image valued shape-outside that extends vertically into the margin-box is top-clipped
https://bugs.webkit.org/show_bug.cgi?id=123769
Reviewed by Dirk Schulze.
Source/WebCore:
Remove the assumption that Y coordinates are >= 0 from the RasterShapeIntervals class
and correct its computeShapeMarginIntervals() method. The computeShapeMarginIntervals()
method now generates intervals with Y coordinates that begin at the image shape's
bounds.y - shape-margin, which may be less than 0.
The RasterShapeIntervals::intervalsAt() method now offsets its Y coordinate parameter
by the shape-margin. A non-const overload of the method was added to centralize all
access to m_intervalLists.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html
- rendering/shapes/RasterShape.cpp:
(WebCore::MarginIntervalGenerator::intervalAt): Don't clip X coordinates to 0 since they can extend into the margin-box.
(WebCore::RasterShapeIntervals::appendInterval): Use the non-const intervalsAt() method.
(WebCore::RasterShapeIntervals::uniteMarginInterval): Ditto.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals): See above.
- rendering/shapes/RasterShape.h:
(WebCore::RasterShapeIntervals::RasterShapeIntervals): Added a field for the margin.
(WebCore::RasterShapeIntervals::intervalsAt): Offset y coordinates by the margin; added a non-const overload.
LayoutTests:
Verify that lines overlap a shape-outside that extends into the top of the margin-box
do wrap around the top of the shape as well its side and bottom.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html: Added.
- 3:46 PM Changeset in webkit [158966] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: remove -webkit-min and -webkit-max from CSS completions
https://bugs.webkit.org/show_bug.cgi?id=124072
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-08
Reviewed by Timothy Hatcher.
-webkit-min and -webkit-max are not implemented in WebCore, despite mentions of it.
- UserInterface/CSSKeywordCompletions.js:
- 3:45 PM Changeset in webkit [158965] by
-
- 3 edits2 adds in trunk
Ended event should work also when playback rate is negative
https://bugs.webkit.org/show_bug.cgi?id=123879
Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-08
Reviewed by Eric Carlson.
Source/WebCore:
According to W3C specification playback is ended also when playback rate is
negative and position is the earliest possible position.
Test: media/video-ended-event-negative-playback.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
LayoutTests:
Tests if ended event is triggered for audio/video elements after
changing playback rate to negative.
- media/video-ended-event-negative-playback-expected.txt: Added.
- media/video-ended-event-negative-playback.html: Added.
- 3:36 PM Changeset in webkit [158964] by
-
- 25 edits1 add in trunk
Checking for TypeError in RTCPeerConnection object creation
https://bugs.webkit.org/show_bug.cgi?id=124049
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.
Source/WebCore:
If invalid parameters are passed on RTCPeerConnection creation we must throw a TypeError exception.
According to the spec it requires a Dictionary argument, the RTCConfiguration, which is mandatory.
Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.
Existing tests were updated.
- GNUmakefile.list.am:
- Modules/mediastream/RTCPeerConnection.idl:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSRTCPeerConnectionCustom.cpp: Added.
(WebCore::JSRTCPeerConnectionConstructor::constructJSRTCPeerConnection):
LayoutTests:
Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.
- fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
- fast/mediastream/RTCPeerConnection-createAnswer.html:
- fast/mediastream/RTCPeerConnection-createOffer.html:
- fast/mediastream/RTCPeerConnection-datachannel.html:
- fast/mediastream/RTCPeerConnection-dtmf.html:
- fast/mediastream/RTCPeerConnection-events.html:
- fast/mediastream/RTCPeerConnection-expected.txt:
- fast/mediastream/RTCPeerConnection-ice-expected.txt:
- fast/mediastream/RTCPeerConnection-ice.html:
- fast/mediastream/RTCPeerConnection-localDescription.html:
- fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
- fast/mediastream/RTCPeerConnection-remoteDescription.html:
- fast/mediastream/RTCPeerConnection-stats-expected.txt:
- fast/mediastream/RTCPeerConnection-stats.html:
- fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
- fast/mediastream/RTCPeerConnection-statsSelector.html:
- fast/mediastream/RTCPeerConnection.html:
- 3:24 PM Changeset in webkit [158963] by
-
- 4 edits in trunk/Source/WebCore
Use references instead of pointers to RenderBlockFlow in FloatingObjects and ComputeFloatOffsetAdapter
https://bugs.webkit.org/show_bug.cgi?id=124074
Reviewed by Sam Weinig.
Just a straightforward conversion from const pointers to const references.
Also, remove unneeded argument from FloatingObjects constructor.
No new tests, no behavior change.
- rendering/FloatingObjects.cpp:
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::FloatingObjects):
(WebCore::FloatingObjects::clearLineBoxTreePointers):
(WebCore::FloatingObjects::computePlacedFloatsTree):
(WebCore::shapeInfoForFloat):
(WebCore::::updateOffsetIfNeeded):
(WebCore::::collectIfNeeded):
(WebCore::::heightRemaining):
- rendering/FloatingObjects.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::createFloatingObjects):
- 3:23 PM Changeset in webkit [158962] by
-
- 6 edits in trunk/Source/WebCore
Teach SubframeLoader a bit about references
https://bugs.webkit.org/show_bug.cgi?id=124076
Reviewed by Anders Carlsson.
- html/HTMLAppletElement.cpp:
- html/HTMLFrameElementBase.cpp:
- html/HTMLMediaElement.cpp:
- loader/SubframeLoader.cpp:
- loader/SubframeLoader.h:
- 3:16 PM Changeset in webkit [158961] by
-
- 2 edits in trunk/Source/WebCore
Blind Windows build-fix attempt after r158959
- WebCore.vcxproj/WebCore.vcxproj:
- 3:10 PM Changeset in webkit [158960] by
-
- 5 edits in branches/safari-537.73-branch/Source/WebKit2
Merge r158101.
- 2:48 PM Changeset in webkit [158959] by
-
- 22 edits2 moves1 delete in trunk/Source
Merge IDBCursorBackendInterface and IDBCursorBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124068
Reviewed by Anders Carlsson.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBCursorBackendInterface.h: Removed.
- Modules/indexeddb/IDBCursorBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp.
- Modules/indexeddb/IDBCursorBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h.
- Modules/indexeddb/IDBCallbacks.h:
- Modules/indexeddb/IDBCursor.cpp:
- Modules/indexeddb/IDBCursor.h:
- Modules/indexeddb/IDBCursorWithValue.cpp:
- Modules/indexeddb/IDBCursorWithValue.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/IDBRequest.cpp:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
- Modules/indexeddb/IDBTransactionBackendImpl.h:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::createCursorBackend):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- 2:42 PM Changeset in webkit [158958] by
-
- 5 edits in trunk/Source/WebCore
Modernize FrameLoader a bit
https://bugs.webkit.org/show_bug.cgi?id=124073
Reviewed by Anders Carlsson.
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
Use std::unique_ptrs rather than OwnPtrs.
- loader/MixedContentChecker.cpp:
- loader/MixedContentChecker.h:
Switch to hold a Frame& rather than Frame*.
- 2:11 PM Changeset in webkit [158957] by
-
- 1 edit4 deletes in trunk/Source/JavaScriptCore
Remove more accidentally added files.
- 2:09 PM Changeset in webkit [158956] by
-
- 3 edits in trunk/Source/WebCore
Remove code guarded with ENABLE(STREAM)
https://bugs.webkit.org/show_bug.cgi?id=123667
Reviewed by Anders Carlsson.
Remove ENABLE(STREAM)-guarded code. This was added in the effort to provide Stream API support, but
no port enables the feature and the work on this feature has wound down after the Chromium port forked,
leaving this code unmaintained.
- fileapi/FileReaderLoader.cpp:
- fileapi/FileReaderLoader.h:
- 2:04 PM Changeset in webkit [158955] by
-
- 3 edits in trunk/Source/WebKit2
Remove a workaround for a bug in malloc on Symbian
https://bugs.webkit.org/show_bug.cgi?id=124069
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::~ArgumentDecoder):
(CoreIPC::ArgumentDecoder::initialize):
- Platform/CoreIPC/ArgumentDecoder.h:
- 2:01 PM Changeset in webkit [158954] by
-
- 6 edits in trunk/Source/WebCore
RenderBlockFlow::nextFloatLogicalBottomBelow should not use ShapeOutsideFloatOffsetMode
https://bugs.webkit.org/show_bug.cgi?id=123931
Reviewed by Sam Weinig.
Rewrite nextFloatLogicalBottomBelow to use the placed floats tree for
the search and to not need ShapeOutsideFloatOffsetMode anymore. This
moves almost all of the logic into FloatingObjects, making a small
reduction in the amount that RenderBlockFlow needs to know about the
implementation of FloatingObjects.
In addition, change ComputeFloatOffsetAdapter to take in LayoutUnits
and roundToInt itself so that all of it's callers can be simplified.
No new tests, no new behavior.
- rendering/FloatingObjects.cpp:
(WebCore::rangesIntersect):
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::FindNextFloatLogicalBottomAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::lowValue):
(WebCore::FindNextFloatLogicalBottomAdapter::highValue):
(WebCore::FindNextFloatLogicalBottomAdapter::nextLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::nextShapeLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
- rendering/FloatingObjects.h:
- rendering/LineWidth.cpp:
(WebCore::LineWidth::fitBelowFloats):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelowForBlock):
(WebCore::RenderBlockFlow::getClearDelta):
- rendering/RenderBlockFlow.h:
- 2:01 PM Changeset in webkit [158953] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r157459. <rdar://problem/15411420>
- 1:55 PM Changeset in webkit [158952] by
-
- 15 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r157137. <rdar://problem/15411426>
- 1:50 PM Changeset in webkit [158951] by
-
- 3 edits in tags/Safari-538.5/Source/WebCore
Merge r158923.
- 1:42 PM Changeset in webkit [158950] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r152867. <rdar://problem/15411424>
- 1:35 PM Changeset in webkit [158949] by
-
- 3 edits in trunk/Source/WebKit2
More build fixes.
- UIProcess/API/mac/WKBrowsingContextController.mm:
- UIProcess/API/mac/WKConnection.mm:
(didReceiveMessage):
- 1:22 PM Changeset in webkit [158948] by
-
- 3 edits in trunk/Source/WebKit2
More build fixes.
- UIProcess/API/mac/WKConnection.h:
- UIProcess/API/mac/WKConnection.mm:
(didReceiveMessage):
- 1:19 PM Changeset in webkit [158947] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the 32-bit build.
- Shared/API/Cocoa/WKBrowsingContextHandleInternal.h:
- 1:17 PM Changeset in webkit [158946] by
-
- 2 edits in trunk/Tools
Added myself as a contributor.
- 1:07 PM Changeset in webkit [158945] by
-
- 2 edits5 moves in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=124064
Some WebCrypto files are not in correct directories
Rubber-stamped by Anders Carlsson.
- WebCore.xcodeproj/project.pbxproj:
- crypto/CryptoAlgorithmAesCbcParams.h: Removed.
- crypto/CryptoAlgorithmAesKeyGenParams.h: Removed.
- crypto/CryptoKeyAES.cpp: Removed.
- crypto/CryptoKeyAES.h: Removed.
- crypto/CryptoKeyMac.cpp: Removed.
- crypto/keys/CryptoKeyAES.cpp: Copied from Source/WebCore/crypto/CryptoKeyAES.cpp.
- crypto/keys/CryptoKeyAES.h: Copied from Source/WebCore/crypto/CryptoKeyAES.h.
- crypto/mac/CryptoKeyMac.cpp: Copied from Source/WebCore/crypto/CryptoKeyMac.cpp.
- crypto/parameters/CryptoAlgorithmAesCbcParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesCbcParams.h.
- crypto/parameters/CryptoAlgorithmAesKeyGenParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesKeyGenParams.h.
- 1:05 PM Changeset in webkit [158944] by
-
- 6 edits in trunk/Source/WebKit2
Replace alignof with alignof.
Rubber-stamped by Beth Dakin.
- Platform/CoreIPC/ArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::decodeStringText):
- Platform/CoreIPC/ArgumentCoders.h:
(CoreIPC::SimpleArgumentCoder::encode):
(CoreIPC::SimpleArgumentCoder::decode):
- Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):
- WebProcess/WebPage/DecoderAdapter.cpp:
(WebKit::DecoderAdapter::decodeString):
- WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::encodeString):
- 1:01 PM Changeset in webkit [158943] by
-
- 10 edits14 adds1 delete in trunk
Implement JWK key import for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=124059
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-import-jwk.html
crypto/subtle/hmac-import-jwk.html
crypto/subtle/import-jwk.html
WebCrypto supports multiple key formats - raw, pkcs8, spki, jwk. The design is that
we'll transform these into parsed KeyData subclasses before passing to algorithms.
CryptoKeySerialization is a base class for handling all these formats.
- WebCore.xcodeproj/project.pbxproj: Added new files. Removed CryptoKeyFormat.h.
- bindings/js/JSCryptoKeySerializationJWK.h: Added.
- bindings/js/JSCryptoKeySerializationJWK.cpp: Added.
(WebCore::getStringFromJSON): A helper. Note that we can rely on the object being
a nice freshly parsed JSON, no getters or anything.
(WebCore::getBooleanFromJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::JSCryptoKeySerializationJWK):
(WebCore::JSCryptoKeySerializationJWK::~JSCryptoKeySerializationJWK):
(WebCore::createHMACParameters): A simple helper.
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm): WebCrypto API is weird,
you can have algorithm parameters both inside a JWK key and passed as importKey()
arguments. They need to agree, whatever that means for specific serialization's
algorithm options (not all necessarily have a 1-1 matching to WebCrypto).
(WebCore::JSCryptoKeySerializationJWK::reconcileUsages): Take an intersection of usages.
(WebCore::JSCryptoKeySerializationJWK::reconcileExtractable): Only extractable if
both JWK and the caller agree.
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid): Verify validity of JWK key.
(WebCore::JSCryptoKeySerializationJWK::keyData): Return an appropriate KeyData
subclass.
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::ENUM_CLASS): Moved CryptoKeyFormat here.
(WebCore::cryptoKeyFormatFromJSValue): Added a human readable string to an exception.
(WebCore::JSSubtleCrypto::importKey): Support multiple key formats, not just raw.
- crypto/CryptoAlgorithm.cpp: (WebCore::CryptoAlgorithm::importKey):
- crypto/CryptoAlgorithm.h:
Updated signature for importKey to one that makes more sense. Decoding formats all
the way from a binary blob is not something that CryptoAlgorithm subclasses should
do, we now pass a KeyData subclass instead.
Removed exportKey/wrapKey/unwrapKey altogether, because I don't yet know what the
signatures will be.
- crypto/CryptoKeyData.h: Added.
(WebCore::CryptoKeyData::ENUM_CLASS):
(WebCore::CryptoKeyData::CryptoKeyData):
(WebCore::CryptoKeyData::~CryptoKeyData):
(WebCore::CryptoKeyData::format):
A base class for passing key material to algorithms. Currently, only one type is
supported, that being OctetSequence for secret keys. Keys for RSA and EC are more
complicated, and secret/public ones are different too.
- crypto/CryptoKeyFormat.h: Removed. There are too many key format classes
confusingly floating around, and this was only needed in one file for parsing.
- crypto/CryptoKeySerialization.h: Added.
Base class for handling raw/pkcs8/spki/jwk keys.
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::importKey):
- crypto/algorithms/CryptoAlgorithmAES_CBC.h:
Updated to use CryptoKeyData.
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::importKey):
- crypto/algorithms/CryptoAlgorithmHMAC.h:
Updated to use CryptoKeyData.
- crypto/keys/CryptoKeyDataOctetSequence.cpp: Added.
(WebCore::CryptoKeyDataOctetSequence::CryptoKeyDataOctetSequence):
(WebCore::CryptoKeyDataOctetSequence::~CryptoKeyDataOctetSequence):
- crypto/keys/CryptoKeyDataOctetSequence.h: Added.
(WebCore::asCryptoKeyDataOctetSequence):
- crypto/keys/CryptoKeySerializationRaw.cpp: Added.
(WebCore::CryptoKeySerializationRaw::CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::~CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::reconcileAlgorithm):
(WebCore::CryptoKeySerializationRaw::reconcileUsages):
(WebCore::CryptoKeySerializationRaw::reconcileExtractable):
(WebCore::CryptoKeySerializationRaw::keyData):
- crypto/keys/CryptoKeySerializationRaw.h: Added.
Much code to pass around a Vector<char>.
LayoutTests:
- crypto/subtle/aes-cbc-import-jwk-expected.txt: Added.
- crypto/subtle/aes-cbc-import-jwk.html: Added.
- crypto/subtle/hmac-import-jwk-expected.txt: Added.
- crypto/subtle/hmac-import-jwk.html: Added.
- crypto/subtle/import-jwk-expected.txt: Added.
- crypto/subtle/import-jwk.html: Added.
- 12:42 PM Changeset in webkit [158942] by
-
- 3 edits in trunk/Source/WebKit2
Add a way to get a WKWebProcessPlugInBrowserContextController from a handle
https://bugs.webkit.org/show_bug.cgi?id=124063
Reviewed by Beth Dakin.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(+[WKWebProcessPlugInBrowserContextController lookUpBrowsingContextFromHandle:]):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
- 12:41 PM Changeset in webkit [158941] by
-
- 1 edit2 deletes in trunk/Source/JavaScriptCore
Remove accidentally added files.
- 12:27 PM Changeset in webkit [158940] by
-
- 2 edits6 adds in trunk/Source/JavaScriptCore
Fix minor (unobservable) bug in ArrayIterator::next()
https://bugs.webkit.org/show_bug.cgi?id=124061
Reviewed by Beth Dakin.
I noticed this while reading the array iterator code. Due to how
ArrayIterator::next() and our enumeration behaviour is implemented
this is not actually a code path that can be hit. But in order to
future proof this it should be correct.
- runtime/JSArrayIterator.cpp:
(JSC::arrayIteratorNext):
- 12:22 PM Changeset in webkit [158939] by
-
- 6 edits in trunk/Source/WebKit2
More work on WKBrowsingContextHandle
https://bugs.webkit.org/show_bug.cgi?id=124060
Reviewed by Beth Dakin.
Implement -hash and -isEqual: and add -[WKWebProcessPlugInBrowserContextController handle].
- Shared/API/Cocoa/WKBrowsingContextHandle.mm:
(-[WKBrowsingContextHandle hash]):
(-[WKBrowsingContextHandle isEqual:]):
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(decodeInvocation):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController mainFrameDocument]):
(-[WKWebProcessPlugInBrowserContextController selectedRange]):
(-[WKWebProcessPlugInBrowserContextController handle]):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
- 12:06 PM Changeset in webkit [158938] by
-
- 2 edits in tags/Safari-538.5/Tools
Unreviewed. Added myself as a committer.
- 12:03 PM Changeset in webkit [158937] by
-
- 24 edits4 adds in trunk/Source
Move breakpoint (and exception break) functionality into JSC::Debugger.
https://bugs.webkit.org/show_bug.cgi?id=121796.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are now numeric tokens.
- JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint record. Previously, this info is tracked in the ScriptBreakpoint record in ScriptDebugServer. The only element of ScriptBreakpoint that is not being tracked by JSC::Breakpoint is the ScriptBreakpointAction.
The ScriptBreakpointAction is still tracked by the ScriptDebugServer
in a list keyed on the corresponding BreakpointID.
The ScriptBreakpoint record is now only used as a means of passing
breakpoint paramaters to the ScriptDebugServer.
- ScriptDebugServer now no longer accesses the JSC::CallFrame* directly. It always goes through the DebuggerCallFrame.
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- debugger/Breakpoint.h: Added.
(JSC::Breakpoint::Breakpoint):
- Breakpoint class to track info for each breakpoint in JSC::Debugger.
- debugger/Debugger.cpp:
(JSC::DebuggerCallFrameScope::DebuggerCallFrameScope):
(JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope):
(JSC::Debugger::Debugger):
(JSC::Debugger::detach):
(JSC::Debugger::updateNeedForOpDebugCallbacks):
(JSC::Debugger::setBreakpoint):
(JSC::Debugger::removeBreakpoint):
(JSC::Debugger::hasBreakpoint):
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::setBreakpointsActivated):
(JSC::Debugger::setPauseOnExceptionsState):
(JSC::Debugger::setPauseOnNextStatement):
(JSC::Debugger::breakProgram):
(JSC::Debugger::continueProgram):
(JSC::Debugger::stepIntoStatement):
(JSC::Debugger::stepOverStatement):
(JSC::Debugger::stepOutOfFunction):
(JSC::Debugger::updateCallFrame):
(JSC::Debugger::updateCallFrameAndPauseIfNeeded):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::exception):
(JSC::Debugger::atStatement):
(JSC::Debugger::callEvent):
(JSC::Debugger::returnEvent):
(JSC::Debugger::willExecuteProgram):
(JSC::Debugger::didExecuteProgram):
(JSC::Debugger::didReachBreakpoint):
(JSC::Debugger::currentDebuggerCallFrame):
- debugger/Debugger.h:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::sourceID):
(JSC::DebuggerCallFrame::sourceIDForCallFrame):
- debugger/DebuggerCallFrame.h:
- debugger/DebuggerPrimitives.h: Added.
- define SourceID, noSourceID, BreakpointID, and noBreakpointID.
Source/WebCore:
No new tests.
- In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are now numeric tokens.
- JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint record. Previously, this info is tracked in the ScriptBreakpoint record in ScriptDebugServer. The only element of ScriptBreakpoint that is not being tracked by JSC::Breakpoint is the ScriptBreakpointAction.
The ScriptBreakpointAction is still tracked by the ScriptDebugServer
in a list keyed on the corresponding BreakpointID.
The ScriptBreakpoint record is now only used as a means of passing
breakpoint paramaters to the ScriptDebugServer.
- ScriptDebugServer now no longer accesses the JSC::CallFrame* directly. It always goes through the DebuggerCallFrame.
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/BreakpointID.h: Added.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::dispatchDidContinue):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::notifyDoneProcessingDebuggerEvents):
(WebCore::ScriptDebugServer::needPauseHandling):
(WebCore::ScriptDebugServer::handleBreakpointHit):
(WebCore::ScriptDebugServer::handleExceptionInBreakpointCondition):
(WebCore::ScriptDebugServer::handlePause):
- bindings/js/ScriptDebugServer.h:
- bindings/js/SourceID.h: Added.
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
- bindings/js/WorkerScriptDebugServer.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):
- inspector/InspectorDebuggerAgent.h:
- inspector/ScriptDebugListener.h:
Source/WebKit/mac:
- WebView/WebScriptDebugger.h:
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::WebScriptDebugger):
(WebScriptDebugger::handlePause):
- 11:49 AM Changeset in webkit [158936] by
-
- 5 edits3 copies in trunk/Source/WebKit2
Add A WKBrowsingContextHandle class
https://bugs.webkit.org/show_bug.cgi?id=124058
Reviewed by Sam Weinig.
The WKBrowsingContextHandle class represents a browsing context and can be sent across process boundaries.
- Shared/API/Cocoa/WKBrowsingContextHandle.h: Added.
- Shared/API/Cocoa/WKBrowsingContextHandle.mm: Added.
(-[WKBrowsingContextHandle _initWithPageID:]):
(-[WKBrowsingContextHandle encodeWithCoder:]):
(-[WKBrowsingContextHandle initWithCoder:]):
(+[WKBrowsingContextHandle supportsSecureCoding]):
- Shared/API/Cocoa/WKBrowsingContextHandleInternal.h: Added.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController handle]):
- UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
- UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:
(NS_ENUM):
- WebKit2.xcodeproj/project.pbxproj:
- 11:45 AM Changeset in webkit [158935] by
-
- 8 edits in trunk/Source/WebCore
InspectorConsoleAgent::didFinishXHRLoading ConsoleMessage should include a column number
https://bugs.webkit.org/show_bug.cgi?id=114316
Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-08
Reviewed by Timothy Hatcher.
InspectorConsoleAgent::didFinishXHRLoading creates a ConsoleMessage with a line number,
but it should also include a column number. It looks like ultimately the line number comes from
JSXMLHttpRequest::send, it should also be possible to get the column number at the time.
The column number would be needed by the Web Inspector to jump to the proper place in source code
to show where the XHR originated from.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::SendFunctor::SendFunctor):
(WebCore::SendFunctor::column):
(WebCore::SendFunctor::operator()):
(WebCore::JSXMLHttpRequest::send):
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didFinishXHRLoading):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::setLastSendLineAndColumnNumber):
(WebCore::XMLHttpRequest::didFinishLoading):
- xml/XMLHttpRequest.h:
- 11:38 AM Changeset in webkit [158934] by
-
- 3 edits4 adds in trunk
Left sidebar on cubic-bezier.com flickers
https://bugs.webkit.org/show_bug.cgi?id=123128
Source/WebCore:
Reviewed by Dean Jackson.
The logic that determined whether position:fixed elements outside the viewport
should be composited was incorrect if the fixed element also had a transform.
layer.calculateLayerBounds() only takes into account painted transforms (since they
affect layer bounds). So we need to compute the bounds relative to the layer
itself, then use localToContainerQuad() to map them to document coordinates,
but only to the RenderView so that we don't hit the page scale transform.
Tests: compositing/layer-creation/fixed-position-transformed-into-view.html
compositing/layer-creation/fixed-position-transformed-outside-view.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
LayoutTests:
Reviewed by Dean Jackson.
Tests with transformed, fixed elements which dump the layer tree to see
which layers get composited.
- compositing/layer-creation/fixed-position-transformed-into-view-expected.txt: Added.
- compositing/layer-creation/fixed-position-transformed-into-view.html: Added.
- compositing/layer-creation/fixed-position-transformed-outside-view-expected.txt: Added.
- compositing/layer-creation/fixed-position-transformed-outside-view.html: Added.
- 11:37 AM Changeset in webkit [158933] by
-
- 2 edits in trunk/Source/WTF
Make base64url decoding actually work
https://bugs.webkit.org/show_bug.cgi?id=124050
Reviewed by Sam Weinig.
- wtf/text/Base64.cpp: (WTF::base64DecodeInternal): Don't hardcode knowledge about
alphabet, put it into the map.
- 11:28 AM Changeset in webkit [158932] by
-
- 2 edits in trunk/LayoutTests
Fix layout test that was actually testing incorrect behaviour.
- 11:27 AM Changeset in webkit [158931] by
-
- 9 edits in trunk
[MathML] Center of stretched curly bracket not always vertically centered
https://bugs.webkit.org/show_bug.cgi?id=123715
Reviewed by Brent Fulgham.
Source/WebCore:
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Update an assertion and
handle the case where two glyph pieces abut.
(WebCore::RenderMathMLOperator::paint): Do not offset the center glyph by y().
LayoutTests:
- TestExpectations: Unskip mo-stretch.html. It was skipped originally,
because MathML is changing rapidly, but we need it to test these changes.
- mathml/presentation/mo-stretch.html: Update to show stretching characteristics
of all stretchable glyphs.
- platform/gtk/mathml/presentation/mo-stretch-expected.png:
- platform/gtk/mathml/presentation/mo-stretch-expected.txt:
- 11:10 AM Changeset in webkit [158930] by
-
- 3 edits in trunk/Source/WebKit2
Add WKRemoteObjectRegistry to WKConnection
https://bugs.webkit.org/show_bug.cgi?id=124054
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKConnection.h:
- UIProcess/API/mac/WKConnection.mm:
(-[WKConnection delegate]):
(-[WKConnection setDelegate:]):
(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):
- 10:47 AM Changeset in webkit [158929] by
-
- 3 edits3 adds in trunk
Map.forEach crashes on deleted values
https://bugs.webkit.org/show_bug.cgi?id=124017
Reviewed by Ryosuke Niwa.
Source/JavaScriptCore:
MapData iterator did not consider the case of the first entries
being holes. To fix this I've refactored iteration so that we
can perform an initialisation increment on construction, whle
retaining the useful assertion in MapData::const_iterator::operator++
- runtime/MapData.h:
(JSC::MapData::const_iterator::operator++):
(JSC::MapData::const_iterator::internalIncrement):
(JSC::MapData::const_iterator::const_iterator):
LayoutTests:
Test case
- js/map-iterate-first-entry-is-a-hole-expected.txt: Added.
- js/map-iterate-first-entry-is-a-hole.html: Added.
- js/script-tests/map-iterate-first-entry-is-a-hole.js: Added.
(set map0):
- 10:30 AM Changeset in webkit [158928] by
-
- 7 edits2 adds in trunk
[MSE] Bring SourceBuffer.append up to the most recent spec.
https://bugs.webkit.org/show_bug.cgi?id=123377
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-append-failed.html
Bring the MediaSource append() implementation up to the current spec.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::appendBufferInternal):
(WebCore::SourceBuffer::appendBufferTimerFired):
- platform/graphics/SourceBufferPrivate.h:
- platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockSourceBufferPrivate::append):
(WebCore::MockSourceBufferPrivate::evictCodedFrames):
(WebCore::MockSourceBufferPrivate::isFull):
- platform/mock/mediasource/MockSourceBufferPrivate.h:
LayoutTests:
- media/media-source/media-source-append-failed-expected.txt: Added.
- media/media-source/media-source-append-failed.html: Added.
- media/media-source/mock-media-source.js:
- 10:28 AM Changeset in webkit [158927] by
-
- 2 edits in trunk/Source/WebKit2
Encode and decode NSURLRequests using NSCoder
https://bugs.webkit.org/show_bug.cgi?id=124051
Reviewed by Sam Weinig.
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::archiveAndEncodeObject):
(CoreIPC::decodeAndUnarchiveObject):
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- 10:25 AM Changeset in webkit [158926] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(r158883): Fix crashes for ARM architecture.
https://bugs.webkit.org/show_bug.cgi?id=124038
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.
- jit/GPRInfo.h: Remove r11 from the temporary register set, use a free register for
nonPreservedNonReturnGPR and remove obsolete declaration of bucketCounterRegister.
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
- jit/JITOperations.cpp: Frame pointer register is r11 for ARM_TRADITIONAL and
- 10:24 AM Changeset in webkit [158925] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(r158883): Fix crashes for MIPS architecture.
https://bugs.webkit.org/show_bug.cgi?id=124044
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.
- jit/JITOperations.cpp: Frame pointer register is fp instead of s0 since r158883 for MIPS.
- jit/ThunkGenerators.cpp: Save and restore the new frame pointer register.
(JSC::returnFromJavaScript):
(JSC::callToJavaScript):
- 10:03 AM Changeset in webkit [158924] by
-
- 3 edits in branches/safari-537.73-branch/LayoutTests
Fix up failing layout tests that in branch due to recent accessibility patches.
Unreviewed.
- media/track/track-in-band-mode-expected.txt:
- platform/mac/accessibility/listitem-title-expected.txt:
- 9:55 AM Changeset in webkit [158923] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Crash at com.apple.WebCore: WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange + 26
https://bugs.webkit.org/show_bug.cgi?id=124031
Reviewed by Eric Carlson.
WTF::bind() causes errors when given a bare id pointer as a parameter,
when that parameter is casted to a specific NS type pointer (in this
case, a NSArray*) in order to pass it as a parameter to the bound
function.
Instead of passing around bare id pointers, wrap them in RetainPtr<>
objects before passing them to WTF::bind().
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
- 9:31 AM WebKitGTK/2.2.x edited by
- (diff)
- 9:12 AM Changeset in webkit [158922] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] JavaScript crash in getHostCallReturnValue.
https://bugs.webkit.org/show_bug.cgi?id=124040
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-08
Reviewed by Geoffrey Garen.
- jit/JITOperations.cpp: Update MSVC assembler code in getHostCallReturnValue according to gcc x86 version.
- 7:27 AM Changeset in webkit [158921] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add test expectations for failing tests.
- platform/efl/TestExpectations:
- 6:57 AM Changeset in webkit [158920] by
-
- 1 edit1 add in trunk/PerformanceTests
Add line layout performance test that exercises more cases
https://bugs.webkit.org/show_bug.cgi?id=124041
Reviewed by Anders Carlsson.
The existing line-layout.html covers the most basic left-aligned case only.
Add a test with more coverage for things that are mostly not yet supported by the simple
line layout path:
- centered text
- right aligned text
- justified text
- pre
- white-space:pre-wrap
- text with simple inlines
- text with br
- Layout/line-layout-simple.html: Added.
- 6:42 AM Changeset in webkit [158919] by
-
- 6 edits5 copies3 adds5 deletes in trunk/LayoutTests
[GTK] Add new GTK-specific layout test results for vertical text
https://bugs.webkit.org/show_bug.cgi?id=124000
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.
Rebaselined some expected results for tests that use vertical text.
These tests are now working fine after the fix from Bug 50619.
They have specific results for WebKit2 GTK+ because WebKit1 has a
permanent area in the bottom for the horizontal scroll bar.
This area reduces the layout area in WebKit1 and consequently the
results differ from WebKit2.
- fast/repaint/japanese-rl-selection-clear-expected.txt:
- fast/repaint/japanese-rl-selection-repaint-expected.txt:
- fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
- fast/text/international/vertical-text-glyph-test-expected.txt:
- fast/text/justify-ideograph-vertical-expected.txt:
- platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
- platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
- platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
- platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Removed.
- platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-clear-expected.txt.
- platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-repaint-expected.txt.
- platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Copied from LayoutTests/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
- platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/fast/text/international/vertical-text-glyph-test-expected.txt.
- platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/fast/text/justify-ideograph-vertical-expected.txt.
- 4:53 AM Changeset in webkit [158918] by
-
- 4 edits in trunk/Source/WebCore
Templated LChar/UChar paths for simple line layout
https://bugs.webkit.org/show_bug.cgi?id=124035
Reviewed by Andreas Kling.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseFor):
Use a templated function to check for illegal characters.
(WebCore::SimpleLineLayout::skipWhitespaces):
Make a template function.
(WebCore::SimpleLineLayout::textWidth):
Make a template function plus some argument changes.
(WebCore::SimpleLineLayout::createTextRuns):
Template function for creating runs while operating with either LChars or UChar.
Also simplified line breaking and text width measuring logic.
(WebCore::SimpleLineLayout::create):
Pick the template.
- rendering/break_lines.cpp:
- rendering/break_lines.h:
Move the implementation to the header (except for the table) so we can use the template
versions directly.
(WebCore::isBreakableSpace):
(WebCore::shouldBreakAfter):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
- 4:16 AM Changeset in webkit [158917] by
-
- 3 edits in trunk/LayoutTests
[EFL] accessibility/aria-link-supports-press.html
https://bugs.webkit.org/show_bug.cgi?id=111987
Unreviewed EFL gardening, passes after r158913.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08
- platform/efl-wk1/TestExpectations: test is no longer failing.
- platform/efl-wk2/TestExpectations: test is no longer failing.
- 3:26 AM Changeset in webkit [158916] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Fix typo (introduced in r158751).
https://bugs.webkit.org/show_bug.cgi?id=124033.
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Csaba Osztrogonác.
- jit/ThunkGenerators.cpp:
(JSC::callToJavaScript):
- 3:22 AM Changeset in webkit [158915] by
-
- 4 edits in trunk/Source/JavaScriptCore
[arm] Use specific PatchableJump implementation for CPU(ARM_TRADITIONAL).
https://bugs.webkit.org/show_bug.cgi?id=123891
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.
Although patchableBranch32 is implemented in MacroAssemblerARM.h, the used implementation
is the generic one in MacroAssembler.h. This patch fixes it and also implements the
patchableJump() function for CPU(ARM_TRADITIONAL). These specific implementations are
needed for this architecture backend to ensure that these jumps can be relinked.
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::patchableJump):
- jit/GPRInfo.h: Remove static_cast that are generating warnings in debug builds.
(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):
- 2:55 AM Changeset in webkit [158914] by
-
- 9 edits in trunk
AX: [ATK] <span> elements exposed through ATK when not needed
https://bugs.webkit.org/show_bug.cgi?id=123885
Reviewed by Chris Fleizach.
Source/WebCore:
As per SVN r158195, the way it's decided whether <span> elements
should be ignored or not has slightly changed, causing that the
GTK/EFL ports expose them in cases that they should be ignored,
such as for text elements that neither are focusable (e.g. by
explicitly setting tabindex) nor have a meaningful accessible name
suggesting they should be exposed.
As a result, the flattening that ATK based ports normally do for
this kind of elements (by folding them into their parents) do not
work correctly anymore, making two tests to fail:
platform/gtk/accessibility/spans-paragraphs-and-divs.html
platform/gtk/accessibility/spans.html
This patch encapsulates the part of the logic that affects this in
the computeAccessibilityIsIgnored() method, placing it in a
new method of AccessibilityObject that we can call from ATK's
accessibilityPlatformIncludesObject() to ensure we hide those
<span> elements when they don't fulfill those requirements.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasAttributesRequiredForInclusion):
New virtual method encapsulating part of the logic from the function
that computes whether accessibility should be ignored or not.
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::hasAttributesRequiredForInclusion):
Override of the new method adding additional checks, as extracted from
the original bits in computeAccessibilityIsIgnored().
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
Use the newly added function where we had the original code before.
- accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Make sure <span> elements are ignored if they are not focusable
and they don't have a meaningful accessible name.
LayoutTests:
Removed failure expectations for tests now passing.
- platform/gtk/TestExpectations: Removed expectations.
- 2:24 AM Changeset in webkit [158913] by
-
- 5 edits in trunk
[GTK] accessibility/aria-link-supports-press.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98355
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.
Tools:
Checking "jump" action for link elements. Action "jump" occurs when a link
element is pressed/clicked.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isPressActionSupported):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported):
LayoutTests:
Removed failure expectation.
- platform/gtk/TestExpectations: test is no longer failing.
- 1:43 AM Changeset in webkit [158912] by
-
- 2 edits in trunk/Tools
[JHBUILD] Jhbuild Makefile build bug workaround
https://bugs.webkit.org/show_bug.cgi?id=123971
Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-11-08
Reviewed by Ryosuke Niwa.
After Jhbuild repository is cloned (for instance when you use
Tools/Scripts/update-webkitefl-libs) it is built from sources.
If you have GREP_OPTIONS grep env variable set (for instance
GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
uses shell grep. For specific GREP_OPTIONS grep output will be
different than expected one by Jhbuild and there is an error
with Jhbuild build. Jhbuild will not be built and then WebKit
source also will not be built. This patch is a workaround to this
issue. It disables GREP_OPTIONS for Jhbuild build time.
- jhbuild/jhbuild-wrapper:
(install_jhbuild):
- 1:06 AM Changeset in webkit [158911] by
-
- 1 edit1 add in trunk/LayoutTests
Add back expectation for test that went missing in r158813.
- svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
- 12:16 AM Changeset in webkit [158910] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Add missing symbols to WebKitDOMEventTarget.symbols
https://bugs.webkit.org/show_bug.cgi?id=123990
Reviewed by Philippe Normand.
Add webkit_dom_event_target_add_event_listener_with_closure and
webkit_dom_event_target_remove_event_listener_with_closure to the
symbols files.
- bindings/gobject/WebKitDOMEventTarget.symbols:
- bindings/gobject/webkitdom.symbols:
- 12:14 AM Changeset in webkit [158909] by
-
- 2 edits in trunk/Tools
[GTK] Ignore deprecated macros when generating gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=123988
Reviewed by Philippe Normand.
- gtk/generate-gtkdoc:
(get_common_options): Ignore also WEBKIT_DEPRECATED and
WEBKIT_DEPRECATED_FOR decorators.
- 12:12 AM Changeset in webkit [158908] by
-
- 3 edits in trunk/Tools
[GTK] Pass the library namespace to gtkdoc-mkdb
https://bugs.webkit.org/show_bug.cgi?id=123900
Reviewed by Martin Robinson.
This fixes the generation of the index of symbols in the API
documentation.
- gtk/generate-gtkdoc:
(get_webkit2_options): Define namespace as WebKit.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Define namespace as WebKitDOM.
- gtk/gtkdoc.py:
(GTKDoc.init): Add namespace option.
(GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.
- 12:09 AM Changeset in webkit [158907] by
-
- 4 edits in trunk/Source/WebCore
[GTK] Use deprecation guards around deprecated API in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=123899
Reviewed by Martin Robinson.
Do not include deprecated API when compiling with
WEBKIT_DISABLE_DEPRECATED option.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
Nov 7, 2013:
- 10:08 PM Changeset in webkit [158906] by
-
- 2 edits in trunk/Source/WebCore
Enhance SQL journal_mode setting code to be less likely to log an error.
<rdar://problem/15418577> and https://bugs.webkit.org/show_bug.cgi?id=124018
Reviewed by Anders Carlsson.
Even though the docs says SQLITE_ROW will always be returned, apparently SQLITE_OK is sometimes returned.
Change the code to handle that.
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open): Save the statement result value, and accept SQLITE_OK as a non-error condition.
- 9:52 PM Changeset in webkit [158905] by
-
- 33 edits1 copy7 adds4 deletes in trunk/LayoutTests
[EFL] Layout tests with vertical texts need to be rebaselined
https://bugs.webkit.org/show_bug.cgi?id=123985
Unreviewed, EFL port needs to do rebaseline since r158848.
- platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Removed.
- platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
- platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Removed.
- platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
- platform/efl/TestExpectations:
- platform/efl/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/efl/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
- platform/efl/fast/block/lineboxcontain/block-with-ideographs-expected.txt:
- platform/efl/fast/dynamic/text-combine-expected.txt:
- platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
- platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
- platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
- platform/efl/fast/text/decorations-with-text-combine-expected.txt:
- platform/efl/fast/text/emphasis-combined-text-expected.txt:
- platform/efl/fast/text/emphasis-vertical-expected.txt:
- platform/efl/fast/text/international/text-combine-image-test-expected.txt: Added.
- platform/efl/fast/text/international/text-spliced-font-expected.txt:
- platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
- platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Added.
- platform/efl/fast/text/orientation-sideways-expected.txt:
- platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- platform/efl/fast/writing-mode/border-vertical-lr-expected.txt:
- platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
- platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
- platform/efl/fast/writing-mode/fallback-orientation-expected.txt:
- platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt:
- platform/efl/fast/writing-mode/japanese-lr-text-expected.txt:
- platform/efl/fast/writing-mode/japanese-rl-selection-expected.txt:
- platform/efl/fast/writing-mode/japanese-rl-text-expected.txt:
- platform/efl/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt:
- platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
- platform/efl/fast/writing-mode/text-orientation-basic-expected.txt:
- platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
- platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.txt:
- platform/efl/fast/writing-mode/vertical-font-fallback-expected.txt:
- 9:40 PM Changeset in webkit [158904] by
-
- 2 edits in trunk/Source/WebCore
Update an out-dated ASSERT in IconDatabase code.
<rdar://problem/15171118> and https://bugs.webkit.org/show_bug.cgi?id=124030.
Reviewed by Andreas Kling.
With the asynchronous interfaces that have been added and the support for WK2 that has been added,
this ASSERT can incorrectly fire if an icon is asked for before database cleanup is allowed.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL): Update an invalid ASSERT.
- 9:24 PM Changeset in webkit [158903] by
-
- 7 edits in trunk/Source/WebCore
RenderSVGResource helpers should take RenderStyle by const reference.
<https://webkit.org/b/124029>
Take const RenderStyle& instead of RenderStyle* in a few more places
so we can get rid of some ampersands and assertions.
Reviewed by Anders Carlsson.
- 9:21 PM Changeset in webkit [158902] by
-
- 11 edits in trunk/Source/WebCore
[AX] Generate toAccessibilityTableRow|Column|Cell to detect bad type casts
https://bugs.webkit.org/show_bug.cgi?id=123984
Reviewed by Mario Sanchez Prada.
As a step to let static_cast<> use TYPE_CASTS_BASE, AccessibilityTableRow|Column|Cell use
ACCESSIBILITY_OBJECT_TYPE_CASTS which can support more helper functions rather than manual
static_cast<>. This change will help to detect bad type casts further.
No new tests, no behavior changes.
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addTableCellChild):
(WebCore::AccessibilityARIAGrid::addChildren):
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cellForColumnAndRow):
- accessibility/AccessibilityTableCell.h:
- accessibility/AccessibilityTableColumn.h:
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
- accessibility/AccessibilityTableRow.h:
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(cellAtIndex):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper tableCellParent]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 8:05 PM Changeset in webkit [158901] by
-
- 13 edits in trunk/Source/JavaScriptCore
Get rid of the regT* definitions in JSInterfaceJIT.h.
https://bugs.webkit.org/show_bug.cgi?id=123806.
Reviewed by Geoffrey Garen.
JSInterfaceJIT now inherits from GPRInfo and FPRInfo, and relies on them
to provide all the register definitions.
- jit/GPRInfo.h:
(JSC::GPRInfo::toArgumentRegister):
- jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompile):
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_compareAndJumpSlow):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareAndJumpSlow):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITInlines.h:
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_end):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emitSlow_op_get_argument_by_val):
(JSC::JIT::emitSlow_op_loop_hint):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JSInterfaceJIT.h:
(JSC::JSInterfaceJIT::JSInterfaceJIT):
- jit/SlowPathCall.h:
(JSC::JITSlowPathCall::call):
- jit/ThunkGenerators.cpp:
- 7:55 PM Changeset in webkit [158900] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r154375): Image is oriented incorrectly
https://bugs.webkit.org/show_bug.cgi?id=123831
Reviewed by Antonio Gomes.
r154375 made that shouldRespectImageOrientation() isn't used by drawImage().
It causes an image isn't oriented correctly. This patch sets shouldRespectImageOrientation()
value by default.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
- 7:54 PM Changeset in webkit [158899] by
-
- 1 edit22 deletes in trunk/LayoutTests
Unreviewed, rolling out r158846.
http://trac.webkit.org/changeset/158846
r158846 was duplicating gardening against r158837.
- platform/efl/fullscreen/video-controls-override-expected.txt: Removed.
- platform/efl/http/tests/media/video-cookie-expected.txt: Removed.
- platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Removed.
- platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
- platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
- platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Removed.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Removed.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
- platform/efl/media/context-menu-actions-expected.txt: Removed.
- platform/efl/media/media-can-play-flac-audio-expected.txt: Removed.
- platform/efl/media/media-can-play-webm-expected.txt: Removed.
- platform/efl/media/media-volume-slider-rendered-below-expected.txt: Removed.
- platform/efl/media/media-volume-slider-rendered-normal-expected.txt: Removed.
- platform/efl/media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Removed.
- platform/efl/media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Removed.
- platform/efl/media/track/track-cue-mutable-text-expected.txt: Removed.
- platform/efl/media/track/track-cue-rendering-mode-changed-expected.txt: Removed.
- platform/efl/media/track/track-language-preference-expected.txt: Removed.
- platform/efl/media/track/video/video-track-mkv-theora-addtrack-expected.txt: Removed.
- platform/efl/media/track/video/video-track-mkv-theora-selected-expected.txt: Removed.
- platform/efl/media/video-controls-fullscreen-volume-expected.txt: Removed.
- platform/efl/media/video-controls-toggling-expected.txt: Removed.
- 7:50 PM Changeset in webkit [158898] by
-
- 3 edits2 adds in trunk
[CSS Shapes] Image shape-outside with vertical gaps is handled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=123934
Reviewed by Andreas Kling.
Source/WebCore:
RasterShapeIntervals::getExcludedIntervals() was returning an empty
list when the line overlapped any vertical gap in the image. This short-circuit
had been mistakenly copied from getIncludedIntervals(), where it makes sense.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShapeIntervals::getExcludedIntervals):
LayoutTests:
- fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html: Added.
- 7:07 PM Changeset in webkit [158897] by
-
- 2 edits in trunk/Source/WebCore
Make contents layer borders more visible
https://bugs.webkit.org/show_bug.cgi?id=124025
Reviewed by Tim Horton.
Layer borders for contents layers are impossible to see when the
contentsLayer has the same bounds as its parent; make the contents
layer border 4px thick to make it more visible.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setupContentsLayer):
- 6:57 PM Changeset in webkit [158896] by
-
- 1 edit31 moves1 add36 deletes in trunk/LayoutTests
Optimize baselines: svg/filters
Unreviewed; run "webkit-patch optimize-baselines svg/filters"
- platform/gtk/svg/filters/animate-fill-expected.png: Removed.
- platform/gtk/svg/filters/feColorMatrix-default-type-expected.png: Removed.
- platform/gtk/svg/filters/feColorMatrix-offset-expected.png: Removed.
- platform/gtk/svg/filters/feColorMatrix-values-expected.png: Removed.
- platform/gtk/svg/filters/feComposite-expected.txt: Removed.
- platform/gtk/svg/filters/feDisplacementMap-expected.txt: Removed.
- platform/gtk/svg/filters/feDropShadow-subregion-expected.png: Removed.
- platform/gtk/svg/filters/feDropShadow-zero-deviation-expected.png: Removed.
- platform/gtk/svg/filters/feDropShadow-zero-deviation-expected.txt: Removed.
- platform/gtk/svg/filters/feGaussianBlur-subregion-expected.png: Removed.
- platform/gtk/svg/filters/feGaussianBlur-zero-deviation-expected.png: Removed.
- platform/gtk/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-change-target-id-expected.png: Removed.
- platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-remove-target-expected.png: Removed.
- platform/gtk/svg/filters/feLighting-crash-expected.png: Removed.
- platform/gtk/svg/filters/feMerge-wrong-input-expected.png: Removed.
- platform/gtk/svg/filters/filter-empty-g-expected.png: Removed.
- platform/gtk/svg/filters/filter-hidden-content-expected.txt: Removed.
- platform/gtk/svg/filters/filter-on-filter-for-text-expected.png: Removed.
- platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt: Removed.
- platform/gtk/svg/filters/filter-on-tspan-expected.txt: Removed.
- platform/gtk/svg/filters/filter-refresh-expected.png: Removed.
- platform/gtk/svg/filters/filter-rounding-issues-expected.png: Removed.
- platform/gtk/svg/filters/filter-width-update-expected.txt: Removed.
- platform/gtk/svg/filters/filterRes-expected.txt: Removed.
- platform/gtk/svg/filters/filterRes2-expected.png: Removed.
- platform/gtk/svg/filters/filteredImage-expected.png: Removed.
- platform/gtk/svg/filters/sourceAlpha-expected.png: Removed.
- platform/gtk/svg/filters/sourceAlpha-expected.txt: Removed.
- platform/mac/svg/filters/feDisplacementMap-expected.txt: Removed.
- platform/mac/svg/filters/feDropShadow-zero-deviation-expected.txt: Removed.
- platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Removed.
- platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
- platform/mac/svg/filters/filter-hidden-content-expected.txt: Removed.
- platform/mac/svg/filters/filterRes-expected.txt: Removed.
- platform/win-future/svg/filters/feImage-reference-svg-primitive-expected.png: Renamed from LayoutTests/svg/filters/feImage-reference-svg-primitive-expected.png.
- svg/filters/animate-fill-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/animate-fill-expected.png.
- svg/filters/feColorMatrix-default-type-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-default-type-expected.png.
- svg/filters/feColorMatrix-offset-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-offset-expected.png.
- svg/filters/feColorMatrix-values-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-values-expected.png.
- svg/filters/feComposite-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feComposite-expected.txt.
- svg/filters/feDisplacementMap-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feDisplacementMap-expected.txt.
- svg/filters/feDropShadow-subregion-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-subregion-expected.png.
- svg/filters/feDropShadow-zero-deviation-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-zero-deviation-expected.png.
- svg/filters/feDropShadow-zero-deviation-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-zero-deviation-expected.txt.
- svg/filters/feGaussianBlur-subregion-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-subregion-expected.png.
- svg/filters/feGaussianBlur-zero-deviation-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.png.
- svg/filters/feGaussianBlur-zero-deviation-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.txt.
- svg/filters/feImage-change-target-id-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feImage-change-target-id-expected.png.
- svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt.
- svg/filters/feImage-remove-target-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feImage-remove-target-expected.png.
- svg/filters/feLighting-crash-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feLighting-crash-expected.png.
- svg/filters/feMerge-wrong-input-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feMerge-wrong-input-expected.png.
- svg/filters/filter-empty-g-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-empty-g-expected.png.
- svg/filters/filter-hidden-content-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-hidden-content-expected.txt.
- svg/filters/filter-on-filter-for-text-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-filter-for-text-expected.png.
- svg/filters/filter-on-filter-for-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-filter-for-text-expected.txt.
- svg/filters/filter-on-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-tspan-expected.txt.
- svg/filters/filter-refresh-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-refresh-expected.png.
- svg/filters/filter-rounding-issues-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-rounding-issues-expected.png.
- svg/filters/filter-width-update-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-width-update-expected.txt.
- svg/filters/filterRes-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filterRes-expected.txt.
- svg/filters/filterRes2-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filterRes2-expected.png.
- svg/filters/filteredImage-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filteredImage-expected.png.
- svg/filters/sourceAlpha-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/sourceAlpha-expected.png.
- svg/filters/sourceAlpha-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/sourceAlpha-expected.txt.
- 6:47 PM Changeset in webkit [158895] by
-
- 2 edits in trunk/Source/WebKit2
Encode and decode NSURLResponse objects using NSCoder
https://bugs.webkit.org/show_bug.cgi?id=124028
Reviewed by Andreas Kling.
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- 6:43 PM Changeset in webkit [158894] by
-
- 5 edits in trunk/Source/WebCore
InlineFlowBox always has a RenderBoxModelObject, take advantage.
<https://webkit.org/b/124024>
Since InlineFlowBox already has the branch-less renderer() returning
a RenderBoxModelObject&, avoid using InlineBox::boxModelObject()
wherever we have a tightly-typed box. One branch disappears from
every call site.
Deleted boxModelObject() on InlineFlowBox to prevent new code from
calling the less efficient function.
Reviewed by Anders Carlsson.
- 6:41 PM Changeset in webkit [158893] by
-
- 12 edits in trunk/Source/WebCore
CTTE: Scrolling tree nodes should always have a ScrollingTree&.
<https://webkit.org/b/124022>
Let ScrollingTreeNode and subclasses store the backpointer to the
tree as a ScrollingTree& reference.
Reviewed by Anders Carlsson.
- 6:22 PM Changeset in webkit [158892] by
-
- 3 edits in trunk/Source/WebKit2
Move m_destinationID to MessageDecoder
https://bugs.webkit.org/show_bug.cgi?id=124026
Reviewed by Andreas Kling.
- Platform/CoreIPC/ArgumentDecoder.h:
- Platform/CoreIPC/MessageDecoder.h:
(CoreIPC::MessageDecoder::destinationID):
- 5:55 PM Changeset in webkit [158891] by
-
- 5 edits in trunk/Source/JavaScriptCore
FTL should support NewArray
https://bugs.webkit.org/show_bug.cgi?id=124010
Reviewed by Oliver Hunt.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::allocateCell):
(JSC::FTL::LowerDFGToLLVM::allocateObject):
(JSC::FTL::LowerDFGToLLVM::allocateBasicStorageAndGetEnd):
(JSC::FTL::LowerDFGToLLVM::ArrayValues::ArrayValues):
(JSC::FTL::LowerDFGToLLVM::allocateJSArray):
- ftl/FTLOutput.h:
(JSC::FTL::Output::loadDouble):
(JSC::FTL::Output::storeDouble):
- 5:54 PM Changeset in webkit [158890] by
-
- 4 edits in trunk/Source/WebKit2
Get rid of the out-of-line memory attachment type
https://bugs.webkit.org/show_bug.cgi?id=124023
Reviewed by Andreas Kling.
We're only using out-of-line memory for when the message body is too big, so
isolate that code in Connection and get rid of the out of line attachment type.
- Platform/CoreIPC/Attachment.cpp:
(CoreIPC::Attachment::Attachment):
- Platform/CoreIPC/Attachment.h:
(CoreIPC::Attachment::port):
(CoreIPC::Attachment::disposition):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createMessageDecoder):
- 5:42 PM Changeset in webkit [158889] by
-
- 5 edits in trunk/Source
Lots of layers get solid color but transparent contents layers now
https://bugs.webkit.org/show_bug.cgi?id=123537
Source/WebCore:
Reviewed by Tim Horton.
We call rendererBackgroundColor() to determine the layer's background color,
but on most elements this returns the transparent color (a valid color).
This caused us to allocate a contentsLayer, and use the transparent color as its
backgroundColor, which was wasteful.
Fix by only making a background-color layer if the color is not transparent (zero alpha).
Also avoid making a new contents layer on every color change, and make sure that
we don't do implicit animations for backgroundColor, and some other properties
that were omitted by mistake.
Layer tree dumps don't dump content layers, so no way to test easily.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setContentsToSolidColor):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(nullActionsDictionary):
Source/WebKit2:
Reviewed by Tim Horton.
Add some properties to the list of things not to implicitly animate.
- Shared/mac/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::disableActionsForLayer):
- 5:29 PM Changeset in webkit [158888] by
-
- 2 edits in tags/Safari-538.5/Source/WebCore
Merge r158869 for <rdar://problem/15406440>.
- 5:12 PM Changeset in webkit [158887] by
-
- 3 edits in branches/safari-537.60-branch/Source/WebKit
Unreviewed. Windows WebKit makefile fixes.
No need to copy over WebKit.resources.
- WebKit.vcxproj/WebKit.make:
- WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
- 5:12 PM Changeset in webkit [158886] by
-
- 6 edits in branches/safari-537.73-branch/LayoutTests
Fix up failing layout tests that referenced wrong paths (due to ToT changes).
Unreviewed.
- accessibility/negative-tabindex-does-not-expose-label.html:
- media/track/track-cue-rendering-mode-changed-expected.txt:
- platform/mac/accessibility/native-list-item-should-not-expose-label.html:
- platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html:
- platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html:
- 5:07 PM Changeset in webkit [158885] by
-
- 3 edits in trunk/Source/WebKit
Unreviewed. Windows WebKit makefile fixes.
No need to copy over WebKit.resources.
- WebKit.vcxproj/WebKit.make:
- WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
- 3:46 PM Changeset in webkit [158884] by
-
- 8 edits in trunk/Source/WebKit
Remove a PLATFORM(IOS) from WebKit Private Header
https://bugs.webkit.org/show_bug.cgi?id=124014
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-07
Reviewed by Timothy Hatcher.
Source/WebKit/ios:
- WebKit.iOS.exp:
Source/WebKit/mac:
Make the previously iOS only WebInspectorDidStartSearchingForNode
and WebInspectorDidStopSearchingForNode notifications non iOS specific.
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::didSetSearchingForNode):
- WebInspector/WebInspector.h:
- WebInspector/WebInspector.mm:
- WebKit.exp:
- 3:45 PM Changeset in webkit [158883] by
-
- 14 edits in trunk/Source/JavaScriptCore
Change CallFrameRegister to architected frame pointer register
https://bugs.webkit.org/show_bug.cgi?id=123956
Reviewed by Geoffrey Garen.
Changed X86 and ARM variants as well as MIPS to use their respective architected
frame pointer registers. The freed up callFrameRegisteris are made available to
the DFG register allocator. Modified the FTL OSR exit compiler to use a temporary
register as a stand in for the destination callFrameRegister since the FTL frame
pointer register is needed to extract values from the FTL stack.
Reviewed by Geoffrey Garen.
- assembler/ARMAssembler.h:
- assembler/ARMv7Assembler.h:
- assembler/MacroAssemblerMIPS.h:
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::addressFor):
- jit/GPRInfo.h:
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
- jit/JITOperations.cpp:
- jit/JSInterfaceJIT.h:
- jit/ThunkGenerators.cpp:
(JSC::callToJavaScript):
- offlineasm/arm.rb:
- offlineasm/arm64.rb:
- offlineasm/mips.rb:
- offlineasm/x86.rb:
- 3:40 PM Changeset in webkit [158882] by
-
- 2 edits in branches/safari-537.60-branch/Source/JavaScriptCore
Rollout part of r146669 which caused a performance regression.
<rdar://problem/15265457>.
Rubberstamped by Filip Pizlo.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- 3:34 PM Changeset in webkit [158881] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: CSS Regions: Use a Map object to store the ContentFlows
https://bugs.webkit.org/show_bug.cgi?id=124015
Reviewed by Joseph Pecoraro.
Changed the Object hashmap to a Map based hashmap when storing the flows in DOMTreeManager.
- UserInterface/DOMTreeManager.js:
(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype.getNamedFlowCollection):
(WebInspector.DOMTreeManager.prototype.namedFlowRemoved):
(WebInspector.DOMTreeManager.prototype._sendNamedFlowUpdateEvents):
- 3:31 PM Changeset in webkit [158880] by
-
- 2 edits in trunk/Source/WebKit2
Remove more dead code
https://bugs.webkit.org/show_bug.cgi?id=124016
Reviewed by Beth Dakin.
We're always layer backed now so we never scroll using the PageClient.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::canScrollView):
(WebKit::PageClientImpl::scrollView):
- 3:26 PM Changeset in webkit [158879] by
-
- 4 edits in trunk/Source/WebInspectorUI
Fix up some sidebar switching details to make selections persist better.
Translate represented objects between sidebars so the same item can be reselected
as you switch between frames and main reources. Also fix some null checks that are
needed on selectedSidebarPanel.
https://bugs.webkit.org/show_bug.cgi?id=124001
Reviewed by Joseph Pecoraro.
- UserInterface/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype.treeElementForRepresentedObject): Added. Translate a Frame
representedObject into a main resource representedObject.
- UserInterface/Main.js:
(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar): Null check selectedSidebarPanel.
(WebInspector._updateNavigationSidebarForCurrentContentView): Fix a logic error to match other code.
allowedNavigationSidebarPanels.length needs to have a length before using contains.
(WebInspector._contentBrowserCurrentContentViewDidChange): Null check selectedSidebarPanel.
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject): Translate a main resource
representedObject into a Frame representedObject.
- 3:25 PM Changeset in webkit [158878] by
-
- 23 edits in branches/safari-537.73-branch/LayoutTests
AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479
Unreviewed.
A number of the rebaselines from the original merge must have failed to apply.
This rebaselines those tests that are failing with the new expected results.
- fullscreen/full-screen-crash-offsetLeft-expected.txt:
- fullscreen/full-screen-no-style-sharing-expected.txt:
- fullscreen/full-screen-stacking-context-expected.txt:
- fullscreen/video-controls-drag-expected.txt:
- fullscreen/video-controls-override-expected.txt:
- fullscreen/video-controls-timeline-expected.txt:
- fullscreen/video-cursor-auto-hide-expected.txt:
- fullscreen/video-specified-size-expected.txt:
- media/media-initialTime-expected.txt:
- media/media-startTime-expected.txt:
- media/media-volume-slider-rendered-below-expected.txt:
- media/media-volume-slider-rendered-normal-expected.txt:
- media/track/track-cue-mutable-text-expected.txt:
- media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt:
- media/video-controls-fullscreen-volume-expected.txt:
- media/video-controls-toggling-expected.txt:
- media/video-controls-visible-exiting-fullscreen-expected.txt:
- platform/mac/accessibility/media-element-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-hide-on-click-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
- 3:16 PM Changeset in webkit [158877] by
-
- 6 edits in trunk
DOMTokenList::add can add duplicated values if arguments had duplicated values
https://bugs.webkit.org/show_bug.cgi?id=123962
Reviewed by Benjamin Poulain.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/bd3822ad4ae3fc5d8f89f433a7bf04f697334305
In case we do element.classList.add('a', 'a') we need to ensure that we do not add the same token twice.
See http://dom.spec.whatwg.org/#dom-domtokenlist-add
- html/DOMTokenList.cpp:
(WebCore::DOMTokenList::add): Make sure filtered tokens are unique among themselves.
LayoutTests:
- fast/dom/HTMLElement/class-list-expected.txt:
- fast/dom/HTMLElement/class-list-quirks-expected.txt:
- fast/dom/HTMLElement/script-tests/class-list.js:
- 3:01 PM Changeset in webkit [158876] by
-
- 2 edits in trunk/Tools
Modify email order list for James Craig so his primary email is first.
- Scripts/webkitpy/common/config/contributors.json:
- 2:19 PM Changeset in webkit [158875] by
-
- 3 edits3 adds in trunk
Reproducible crash when using Map (affects Web Inspector)
https://bugs.webkit.org/show_bug.cgi?id=123940
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Trivial fix. Once again we get bitten by attempting to be clever when
growing while adding entries to indexing maps.
Now we simply do a find(), and then add() _after_ we've ensured there is
sufficient space in the MapData list.
- runtime/MapData.cpp:
(JSC::MapData::add):
LayoutTests:
Add testcases
- js/map-grow-with-holes-expected.txt: Added.
- js/map-grow-with-holes.html: Added.
- js/script-tests/map-grow-with-holes.js: Added.
(get map):
- 2:08 PM Changeset in webkit [158874] by
-
- 3 edits in trunk/Source/WebCore
Remove npr.org specific hack in HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=123859
Reviewed by Jer Noble.
Remove the site specific hack added in r57820, it is no longer necessary.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_dispatchingCanPlayEvent.
(HTMLMediaElement::play): Don't special case npr.org.
- html/HTMLMediaElement.h:
- 1:56 PM Changeset in webkit [158873] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the 32-bit build. Virtual thunks seem to have different
symbol names between 32- and 64-bit.
- WebCore.exp.in:
- 1:54 PM Changeset in webkit [158872] by
-
- 3 edits in trunk/Source/WebKit2
Don't repaint the view when the web process crashes
https://bugs.webkit.org/show_bug.cgi?id=124013
Reviewed by Dan Bernstein.
It's up to each individual port to decide whether the view should be repainted when the web process crashes.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::displayView):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- 1:51 PM Changeset in webkit [158871] by
-
- 2 edits1 move1 add1 delete in trunk/LayoutTests
Unreviewed EFL gardening
Remove failure test expectations from passing tests.
- platform/efl-wk2/fast/repaint/caret-with-transformation-expected.png: Removed.
- platform/efl/TestExpectations:
- platform/efl/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/efl/fast/repaint/caret-with-transformation-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/repaint/caret-with-transformation-expected.txt.
- 1:47 PM Changeset in webkit [158870] by
-
- 2 edits in trunk/Source/WebCore
Crash in HTMLMediaElement::contextDestroyed
https://bugs.webkit.org/show_bug.cgi?id=123963
Reviewed by Eric Carlson.
Merge https://chromium.googlesource.com/chromium/blink/+/177999cdb34b707465670f0feff723922939f278
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
- 1:43 PM Changeset in webkit [158869] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Crash at com.apple.WebCore: -[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:] + 2084
https://bugs.webkit.org/show_bug.cgi?id=124012
Reviewed by Eric Carlson.
The value of the 'duration' key is a NSConcreteValue wrapping a CMTime, not a NSNumber.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
- 1:39 PM Changeset in webkit [158868] by
-
- 3 edits2 adds in trunk
Crash when submitting form in a document with null encoding
https://bugs.webkit.org/show_bug.cgi?id=123975
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/bba01a7fff09e3053ada96ababac2a6e4261fe5f
The CString object which is passed to normalizeLineEndingsToCRLF() can be
a null string. It is created in FormDataList::appendString(), and it
produces a null CString if FormDataList::m_encoding is a null encoding.
Test: fast/forms/form-submit-in-image-document.html
- platform/text/LineEnding.cpp:
(internalNormalizeLineEndingsToCRLF):
LayoutTests:
- fast/forms/form-submit-in-image-document-expected.txt: Added.
- fast/forms/form-submit-in-image-document.html: Added.
- 1:37 PM Changeset in webkit [158867] by
-
- 8 edits in trunk/Source/WebCore
Use std::function for all policy continuation functions
https://bugs.webkit.org/show_bug.cgi?id=124011
Reviewed by Sam Weinig.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::responseReceived):
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::loadPostRequest):
- loader/PolicyCallback.cpp:
(WebCore::PolicyCallback::clear):
(WebCore::PolicyCallback::set):
(WebCore::PolicyCallback::call):
(WebCore::PolicyCallback::clearRequest):
(WebCore::PolicyCallback::cancel):
- loader/PolicyCallback.h:
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::checkContentPolicy):
- loader/PolicyChecker.h:
- 1:30 PM Changeset in webkit [158866] by
-
- 2 edits in trunk/Tools
[Gtk] Disable LTO when building cairo
https://bugs.webkit.org/show_bug.cgi?id=123954
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-07
Reviewed by Martin Robinson.
Cairo always uses LTO, when it detects compiler support.
LTO is buggy in many/all versions of GCC and shouldn't be enabled by
default. This patch disables LTO when building cairo library.
With gcc 4.7.3, for example, the build fails with the following message:
'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
- gtk/jhbuild.modules:
- 12:49 PM Changeset in webkit [158865] by
-
- 2 edits in trunk/Source/WebCore
Use SQLite journal mode WAL (WriteAheadLogging)
https://bugs.webkit.org/show_bug.cgi?id=124009
Reviewed by Anders Carlsson.
WriteAheadLogging journalling is better than the traditional rollback model.
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open): Use a PRAGMA to set journal_mode to WAL.
- 12:26 PM Changeset in webkit [158864] by
-
- 19 edits in trunk/LayoutTests
[GStreamer] Fix in-band track tests after r158743
https://bugs.webkit.org/show_bug.cgi?id=124007
Add a new line to a bunch of tests to match changes made in r158743.
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-07
Reviewed by Eric Carlson.
- media/track/audio/audio-track-mkv-vorbis-language-expected.txt:
- media/track/in-band/track-in-band-kate-ogg-addtrack-expected.txt:
- media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt:
- media/track/in-band/track-in-band-kate-ogg-kind-expected.txt:
- media/track/in-band/track-in-band-kate-ogg-language-expected.txt:
- media/track/in-band/track-in-band-kate-ogg-mode-expected.txt:
- media/track/in-band/track-in-band-kate-ogg-style-expected.txt:
- media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt:
- media/track/in-band/track-in-band-mkv-chapters-expected.txt:
- media/track/in-band/track-in-band-srt-mkv-addtrack-expected.txt:
- media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt:
- media/track/in-band/track-in-band-srt-mkv-kind-expected.txt:
- media/track/in-band/track-in-band-srt-mkv-language-expected.txt:
- media/track/in-band/track-in-band-srt-mkv-mode-expected.txt:
- media/track/in-band/track-in-band-srt-mkv-style-expected.txt:
- media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt:
- media/track/video/video-track-mkv-theora-language-expected.txt:
- media/track/video/video-track-mkv-theora-selected-expected.txt:
- 12:19 PM Changeset in webkit [158863] by
-
- 2 edits in trunk/Source/WebKit2
Report error on unknown template class usage.
https://bugs.webkit.org/show_bug.cgi?id=123096
Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-11-07
Reviewed by Darin Adler.
Report error when template class is not found in the dictionary.
- Scripts/webkit2/messages.py:
(class_template_headers):
(class_template_headers.template):
- 12:17 PM Changeset in webkit [158862] by
-
- 19 edits in trunk/Source
Cosmetic: rename xxxId to xxxID for ScriptId, SourceId, and BreakpointId.
https://bugs.webkit.org/show_bug.cgi?id=123945.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::sourceID):
(JSC::DebuggerCallFrame::sourceIDForCallFrame):
- debugger/DebuggerCallFrame.h:
Source/WebCore:
No new tests.
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::functionDetails):
- bindings/js/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::sourceID):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::updateCallFrame):
(WebCore::ScriptDebugServer::pauseIfNeeded):
- bindings/js/ScriptDebugServer.h:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::compileScript):
(WebCore::InspectorDebuggerAgent::runScript):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):
(WebCore::InspectorDebuggerAgent::reset):
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
- inspector/InspectorInstrumentation.h:
- inspector/ScriptDebugListener.h:
Source/WebKit/mac:
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::exception):
- 12:11 PM Changeset in webkit [158861] by
-
- 2 edits3 adds in trunk
Avoid invalid cairo matrix when drawing surfaces too small
https://bugs.webkit.org/show_bug.cgi?id=123810
Drawing surfaces too small makes inverse matrix with values too big,
when this happen, cairo context is not valid anymore and it stops to draw anything.
Patch by Cidorvan Leite <cidorvan.leite@openbossa.org> on 2013-11-07
Reviewed by Martin Robinson.
Test: fast/canvas/drawImage-with-small-values.html
- platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::drawSurfaceToContext):
- 11:45 AM Changeset in webkit [158860] by
-
- 9 edits2 adds in trunk
Simple line layout crashes with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=124002
Source/WebCore:
Reviewed by Simon Fraser.
Don't use simple line layout for flows using SVG fonts. They crash if kerning is enabled.
Test: fast/text/svg-font-simple-line-crash.html
- platform/graphics/Font.h:
(WebCore::Font::isSVGFont):
Add isSVGFont() so callers don't need to go via primaryFont().
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::constructTextRun):
- rendering/RenderBlock.cpp:
(WebCore::constructTextRunInternal):
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
Disallow SVG fonts.
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun):
- rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::constructTextRun):
(WebCore::SVGTextMetrics::SVGTextMetrics):
- rendering/svg/SVGTextRunRenderingContext.h:
Get rid of the abstract textRunNeedsRenderingContext in favor of just testing isSVGFont().
LayoutTests:
Reviewed by Simon Fraser.
- fast/text/svg-font-simple-line-crash-expected.txt: Added.
- fast/text/svg-font-simple-line-crash.html: Added.
- 11:34 AM Changeset in webkit [158859] by
-
- 12 edits in trunk/Source/WebCore
Allow customization of the contentsScale of TileController tiles
https://bugs.webkit.org/show_bug.cgi?id=124004
Reviewed by Tim Horton.
On some platorms, zooming out on pages with TiledBacking compositing
layers can cause very high memory use, because the TiledBacking retains
the original page scale while the zoom is in flight, but can be asked
to cover a large area.
Make it possible to reduce memory use in this case by allowing RenderLayerCompositor
to provide an additional scale factor for newly created tiles. Platforms can
then customize this to create low-res tiles when necessary.
- WebCore.exp.in:
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::contentsScaleMultiplierForNewTiles):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerContentsScaleMultiplierForNewTiles):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayerClient.h:
(WebCore::PlatformCALayerClient::platformCALayerContentsScaleMultiplierForNewTiles):
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
(WebCore::TileController::setScale):
(WebCore::TileController::createTileLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentsScaleMultiplierForNewTiles):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::contentsScaleMultiplierForNewTiles):
- rendering/RenderLayerCompositor.h:
- 11:33 AM Changeset in webkit [158858] by
-
- 2 edits in trunk/Source/JavaScriptCore
returnFromJavaScript() for ARM_THUMB2 uses push()s which should be pop()s
https://bugs.webkit.org/show_bug.cgi?id=124006
Rubber stamped by Mark Hahnenberg.
Changed the push() calls to pop().
- jit/ThunkGenerators.cpp:
(JSC::returnFromJavaScript):
- 11:23 AM Changeset in webkit [158857] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove unneeded moving of ESP to ECX in callToJavaScript for COMPILER(MSVC)
https://bugs.webkit.org/show_bug.cgi?id=123998
Reviewed by Mark Lam.
Dead code removal. Passing esp as the first "C" argument to a JavaScript
function is no longer needed.
- jit/ThunkGenerators.cpp:
(JSC::callToJavaScript):
- 11:04 AM Changeset in webkit [158856] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Win build fix after r158855; wrap shapeInfoForFloat() in an ENABLE(CSS_SHAPES) guard.
- rendering/FloatingObjects.cpp:
- 10:11 AM Changeset in webkit [158855] by
-
- 6 edits in trunk/Source/WebCore
Refactor logical left/right offset for line methods
https://bugs.webkit.org/show_bug.cgi?id=123898
Reviewed by David Hyatt.
Simplify the logical left/right offset for line methods and their
implementation, including the ComputeFloatOffsetAdapter. This also
reduces the number of line offset methods in RenderBlock.
No new tests, no behavior change.
- rendering/FloatingObjects.cpp:
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::ComputeFloatOffsetAdapter::offset): Add a method to return
the offset instead of using a confusing out parameter.
(WebCore::::shapeOffset): Method to return the offset modified by the
shape delta. Moving the computation to this method allowed for
simplification of the users of ComputeFloatOffsetAdapter.
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat): Added this
method so that ShapeOutsideFloatOffsetMode isn't needed. Returns the
offset based on the float margin box.
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat): Ditto.
(WebCore::FloatingObjects::logicalLeftOffset): This now only returns
the offset based on the shape's contour.
(WebCore::FloatingObjects::logicalRightOffset): Ditto.
(WebCore::::heightRemaining): Rename to properly follow the getter
naming convention.
- rendering/FloatingObjects.h:
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine): Update to remove
use of ShapeOutsideFloatOffsetMode and heightRemaining.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(WebCore::RenderBlock::logicalRightFloatOffsetForLine): Ditto.
(WebCore::RenderBlock::logicalLeftFloatOffsetForLine): Ditto.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::logicalLeftOffsetForPositioningFloat):
Positioning a float is the only case where the float margin box
should be used, and also the only case where heightRemaining is
needed. This handles that case.
(WebCore::RenderBlockFlow::logicalRightOffsetForPositioningFloat):
Ditto.
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat): Update to
use logical(Left|Right)OffsetForPositioningFloatOnLine.
(WebCore::RenderBlockFlow::logicalLeftFloatOffsetForLine): Update to
remove use for ShapeOutsideFloatOffsetMode and heightRemaining.
(WebCore::RenderBlockFlow::logicalRightFloatOffsetForLine): Ditto.
- rendering/RenderBlockFlow.h:
- 10:05 AM Changeset in webkit [158854] by
-
- 6 edits2 adds in trunk
Web Inspector: CSS Regions: Removing a content node of a ContentFlow from the DOM will send a 0 nodeId
https://bugs.webkit.org/show_bug.cgi?id=123577
Source/WebCore:
Reviewed by Timothy Hatcher.
Test: inspector-protocol/model/content-flow-content-removal.html
Do not send unregister events for the content nodes of a flow when the element is not part of the DOM
anymore. We already send an unbind event, so the inspector is already notified that the node was removed.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement):
Source/WebInspectorUI:
Reviewed by Timothy Hatcher.
Fixed the content node removal from the content flow.
- UserInterface/ContentFlowTreeContentView.js:
- UserInterface/DOMTreeManager.js:
(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload): Registered all the content nodes
in the _contentNodesToFlowsMap.
(WebInspector.DOMTreeManager.prototype._unbind): Added call to _removeContentNodeFromFlowIfNeeded.
(WebInspector.DOMTreeManager.prototype._removeContentNodeFromFlowIfNeeded): Called from _unbind to check
and remove a node from it's parent content flow if needed.
(WebInspector.DOMTreeManager.prototype.unregisteredNamedFlowContentElement):
LayoutTests:
Reviewed by Timothy Hatcher.
Added test to check that the notification that an element was removed from the ContentFlow is handled
correctly in the WebInspector even if the element is not part of the DOM anymore.
- inspector-protocol/model/content-flow-content-removal-expected.txt: Added.
- inspector-protocol/model/content-flow-content-removal.html: Added.
- 9:58 AM Changeset in webkit [158853] by
-
- 13 edits27 adds in trunk
[MSE] Add mock MediaSource classes for testing.
https://bugs.webkit.org/show_bug.cgi?id=123322
Reviewed by Eric Carlson.
Source/WebCore:
Tests: media/media-source/media-source-addsourcebuffer.html
media/media-source/media-source-append-buffer.html
media/media-source/media-source-canplaythrough.html
media/media-source/media-source-closed.html
media/media-source/media-source-play.html
media/media-source/media-source-track-enabled.html
media/media-source/media-source-tracks.html
Add mock implementation of platform MediaSource classes, allowing ports to test the
MediaSource API without having a platform implementation.
The MockMediaSource will support a byteformat defined in MockBox.h: a simple box-style media
format with an initialization segment containing a number of tracks, followed by a list of
samples.
Add a means to insert a new media engine factory at runtime, so the internals object can add
a MockMediaSourceMediaPlayer:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayerFactorySupport::callRegisterMediaEngine):
- platform/graphics/MediaPlayer.h:
- testing/Internals.cpp:
(WebCore::Internals::initializeMockMediaSource):
- testing/Internals.h:
- testing/Internals.idl:
For non-media-source supporting media engines, fail immediately when asked to load a media
source, so that the MockMediaSourceMediaPlayer will be instantiated as a fall-back:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::supportsType):
Add new files to the project:
- WebCore.xcodeproj/project.pbxproj:
- Source/WebCore/WebCore.exp.in:
Update the MediaSource implementation:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::monitorSourceBuffers): Add a link to the spec.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::buffered): Ditto.
(WebCore::SourceBuffer::setTimestampOffset): Ditto.
(WebCore::SourceBuffer::validateInitializationSegment): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Ditto. Also,
bring the implementation up to date with part of the spec.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Remove "Predicate" from
SampleIsRandomAccessPredicate.
Add utility classes to parse and represent the bytestream supported by the MockMediaSource:
- platform/mock/mediasource/MockBox.cpp: Added.
(WebCore::MockBox::MockBox):
(WebCore::MockBox::peekType):
(WebCore::MockBox::peekLength):
(WebCore::MockTrackBox::MockTrackBox):
(WebCore::MockTrackBox::type):
(WebCore::MockInitializationBox::MockInitializationBox):
(WebCore::MockInitializationBox::type):
(WebCore::MockSampleBox::MockSampleBox):
(WebCore::MockSampleBox::type):
- platform/mock/mediasource/MockBox.h: Added.
(WebCore::MockBox::length):
(WebCore::MockBox::type):
(WebCore::MockTrackBox::trackID):
(WebCore::MockTrackBox::codec):
(WebCore::MockTrackBox::kind):
(WebCore::MockInitializationBox::duration):
(WebCore::MockInitializationBox::tracks):
(WebCore::MockSampleBox::presentationTimestamp):
(WebCore::MockSampleBox::decodeTimestamp):
(WebCore::MockSampleBox::duration):
(WebCore::MockSampleBox::trackID):
(WebCore::MockSampleBox::flags):
(WebCore::MockSampleBox::isSync):
Add a MediaPlayerPrivate implementation which uses MockMediaSource:
- platform/mock/mediasource/MockMediaPlayerMediaSource.cpp: Added.
(WebCore::MockMediaPlayerMediaSource::registerMediaEngine):
(WebCore::MockMediaPlayerMediaSource::create):
(WebCore::mimeTypeCache):
(WebCore::MockMediaPlayerMediaSource::getSupportedTypes):
(WebCore::MockMediaPlayerMediaSource::supportsType):
(WebCore::MockMediaPlayerMediaSource::MockMediaPlayerMediaSource):
(WebCore::MockMediaPlayerMediaSource::~MockMediaPlayerMediaSource):
(WebCore::MockMediaPlayerMediaSource::load):
(WebCore::MockMediaPlayerMediaSource::cancelLoad):
(WebCore::MockMediaPlayerMediaSource::play):
(WebCore::MockMediaPlayerMediaSource::pause):
(WebCore::MockMediaPlayerMediaSource::naturalSize):
(WebCore::MockMediaPlayerMediaSource::hasVideo):
(WebCore::MockMediaPlayerMediaSource::hasAudio):
(WebCore::MockMediaPlayerMediaSource::setVisible):
(WebCore::MockMediaPlayerMediaSource::seeking):
(WebCore::MockMediaPlayerMediaSource::paused):
(WebCore::MockMediaPlayerMediaSource::networkState):
(WebCore::MockMediaPlayerMediaSource::readyState):
(WebCore::MockMediaPlayerMediaSource::buffered):
(WebCore::MockMediaPlayerMediaSource::didLoadingProgress):
(WebCore::MockMediaPlayerMediaSource::setSize):
(WebCore::MockMediaPlayerMediaSource::paint):
(WebCore::MockMediaPlayerMediaSource::currentTimeDouble):
(WebCore::MockMediaPlayerMediaSource::durationDouble):
(WebCore::MockMediaPlayerMediaSource::seekDouble):
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime):
(WebCore::MockMediaPlayerMediaSource::updateDuration):
(WebCore::MockMediaPlayerMediaSource::setReadyState):
- platform/mock/mediasource/MockMediaPlayerMediaSource.h: Added.
Add a mock implementation of MediaSourcePrivate, which uses MockSourceBuffer:
- platform/mock/mediasource/MockMediaSourcePrivate.cpp: Added.
(WebCore::MockMediaSourcePrivate::create):
(WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate):
(WebCore::MockMediaSourcePrivate::~MockMediaSourcePrivate):
(WebCore::MockMediaSourcePrivate::addSourceBuffer):
(WebCore::MockMediaSourcePrivate::removeSourceBuffer):
(WebCore::MockMediaSourcePrivate::duration):
(WebCore::MockMediaSourcePrivate::setDuration):
(WebCore::MockMediaSourcePrivate::markEndOfStream):
(WebCore::MockMediaSourcePrivate::unmarkEndOfStream):
(WebCore::MockMediaSourcePrivate::readyState):
(WebCore::MockMediaSourcePrivate::setReadyState):
(WebCore::MockMediaSourcePrivate::sourceBufferPrivateDidChangeActiveState):
(WebCore::MockSourceBufferPrivateHasAudio):
(WebCore::MockMediaSourcePrivate::hasAudio):
(WebCore::MockSourceBufferPrivateHasVideo):
(WebCore::MockMediaSourcePrivate::hasVideo):
- platform/mock/mediasource/MockMediaSourcePrivate.h: Added.
(WebCore::MockMediaSourcePrivate::activeSourceBuffers):
(WebCore::MockMediaSourcePrivate::player):
Add a mock implementation of SourceBufferPrivate, which uses MockBoxes to parse the
bytestream provided by SourceBuffer:
- platform/mock/mediasource/MockSourceBufferPrivate.cpp: Added.
(WebCore::MockMediaSample::create):
(WebCore::MockMediaSample::~MockMediaSample):
(WebCore::MockMediaSample::MockMediaSample):
(WebCore::MockMediaSample::platformSample):
(WebCore::MockMediaDescription::create):
(WebCore::MockMediaDescription::~MockMediaDescription):
(WebCore::MockMediaDescription::MockMediaDescription):
(WebCore::MockSourceBufferPrivate::create):
(WebCore::MockSourceBufferPrivate::MockSourceBufferPrivate):
(WebCore::MockSourceBufferPrivate::~MockSourceBufferPrivate):
(WebCore::MockSourceBufferPrivate::setClient):
(WebCore::MockSourceBufferPrivate::append):
(WebCore::MockSourceBufferPrivate::didReceiveInitializationSegment):
(WebCore::MockSourceBufferPrivate::didReceiveSample):
(WebCore::MockSourceBufferPrivate::abort):
(WebCore::MockSourceBufferPrivate::removedFromMediaSource):
(WebCore::MockSourceBufferPrivate::readyState):
(WebCore::MockSourceBufferPrivate::setReadyState):
(WebCore::MockSourceBufferPrivate::hasVideo):
(WebCore::MockSourceBufferPrivate::hasAudio):
- platform/mock/mediasource/MockSourceBufferPrivate.h: Added.
Create mock implementations of AudioTrackPrivate, VideoTrackPrivate, and TextTrackPrivate
which wrap the MockTrackBox class:
- platform/mock/mediasource/MockTracks.cpp: Added.
- platform/mock/mediasource/MockTracks.h: Added.
(WebCore::MockAudioTrackPrivate::create):
(WebCore::MockAudioTrackPrivate::~MockAudioTrackPrivate):
(WebCore::MockAudioTrackPrivate::id):
(WebCore::MockAudioTrackPrivate::MockAudioTrackPrivate):
(WebCore::MockTextTrackPrivate::create):
(WebCore::MockTextTrackPrivate::~MockTextTrackPrivate):
(WebCore::MockTextTrackPrivate::id):
(WebCore::MockTextTrackPrivate::MockTextTrackPrivate):
(WebCore::MockVideoTrackPrivate::create):
(WebCore::MockVideoTrackPrivate::~MockVideoTrackPrivate):
(WebCore::MockVideoTrackPrivate::id):
(WebCore::MockVideoTrackPrivate::MockVideoTrackPrivate):
LayoutTests:
- media/media-source/media-source-addsourcebuffer-expected.txt: Added.
- media/media-source/media-source-addsourcebuffer.html: Added.
- media/media-source/media-source-append-buffer-expected.txt: Added.
- media/media-source/media-source-append-buffer.html: Added.
- media/media-source/media-source-canplaythrough-expected.txt: Added.
- media/media-source/media-source-canplaythrough.html: Added.
- media/media-source/media-source-closed-expected.txt: Added.
- media/media-source/media-source-closed.html: Added.
- media/media-source/media-source-play-expected.txt: Added.
- media/media-source/media-source-play.html: Added.
- media/media-source/mock-media-source.js: Added.
- media/video-test.js:
- 9:56 AM Changeset in webkit [158852] by
-
- 4 edits2 adds in trunk
AX: DRT AccessibilityUIElement::isFocused methods should be finished.
https://bugs.webkit.org/show_bug.cgi?id=123774
Reviewed by Chris Fleizach.
Tools:
Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isFocused):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::isFocused):
LayoutTests:
Added Mac platform test so we can validate our AccessibilityUIElement convenience method expectations.
- platform/mac/accessibility/test-convenience-methods-expected.txt: Added.
- platform/mac/accessibility/test-convenience-methods.html: Added.
- 9:17 AM Changeset in webkit [158851] by
-
- 2 edits in trunk/Tools
Removed retrieveQMakespecVar function
https://bugs.webkit.org/show_bug.cgi?id=123996
Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.
- Scripts/webkitdirs.pm:
- 9:11 AM Changeset in webkit [158850] by
-
- 2 edits in trunk/Tools
Removed QMake related filters
https://bugs.webkit.org/show_bug.cgi?id=123992
Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline):
(TestRebaselineExpectations.test_rebaseline_expectations):
- 9:08 AM WebInspectorCodingStyleGuide edited by
- (diff)
- 8:21 AM Changeset in webkit [158849] by
-
- 34 edits2 moves in trunk/Source
Changing MediaStreamDescriptor to MediaStreamPrivate
https://bugs.webkit.org/show_bug.cgi?id=123935
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-07
Reviewed by Eric Carlson.
Source/WebCore:
No new tests needed.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::ended):
(WebCore::MediaStream::setEnded):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::removeRemoteSource):
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::registerURL):
(WebCore::MediaStreamRegistry::unregisterURL):
(WebCore::MediaStreamRegistry::lookupMediaStreamPrivate):
- Modules/mediastream/MediaStreamRegistry.h:
- Modules/mediastream/MediaStreamTrack.cpp:
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCreateStream):
(WebCore::UserMediaRequest::callSuccessHandler):
- Modules/mediastream/UserMediaRequest.h:
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::loadResource):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::toWebMediaStreamPrivate):
(WebCore::MediaPlayerPrivate::lookupMediaStream):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
- platform/mediastream/MediaStreamCenter.cpp:
- platform/mediastream/MediaStreamCreationClient.h:
- platform/mediastream/MediaStreamPrivate.cpp: Renamed from Source/WebCore/platform/mediastream/MediaStreamDescriptor.cpp.
(WebCore::MediaStreamPrivate::create):
(WebCore::MediaStreamPrivate::addSource):
(WebCore::MediaStreamPrivate::removeSource):
(WebCore::MediaStreamPrivate::addRemoteSource):
(WebCore::MediaStreamPrivate::removeRemoteSource):
(WebCore::MediaStreamPrivate::addRemoteTrack):
(WebCore::MediaStreamPrivate::removeRemoteTrack):
(WebCore::MediaStreamPrivate::MediaStreamPrivate):
(WebCore::MediaStreamPrivate::setEnded):
(WebCore::MediaStreamPrivate::addTrack):
(WebCore::MediaStreamPrivate::removeTrack):
- platform/mediastream/MediaStreamPrivate.h: Renamed from Source/WebCore/platform/mediastream/MediaStreamDescriptor.h.
(WebCore::MediaStreamPrivateClient::~MediaStreamPrivateClient):
(WebCore::MediaStreamPrivate::~MediaStreamPrivate):
(WebCore::MediaStreamPrivate::client):
(WebCore::MediaStreamPrivate::setClient):
(WebCore::MediaStreamPrivate::id):
(WebCore::MediaStreamPrivate::numberOfAudioSources):
(WebCore::MediaStreamPrivate::audioSources):
(WebCore::MediaStreamPrivate::numberOfVideoSources):
(WebCore::MediaStreamPrivate::videoSources):
(WebCore::MediaStreamPrivate::numberOfAudioTracks):
(WebCore::MediaStreamPrivate::audioTracks):
(WebCore::MediaStreamPrivate::numberOfVideoTracks):
(WebCore::MediaStreamPrivate::videoTracks):
(WebCore::MediaStreamPrivate::ended):
- platform/mediastream/MediaStreamSource.cpp:
- platform/mediastream/MediaStreamSource.h:
- platform/mediastream/RTCPeerConnectionHandler.h:
- platform/mediastream/RTCPeerConnectionHandlerClient.h:
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
- platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
- platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
- platform/mediastream/mac/MediaStreamCenterMac.cpp:
(WebCore::MediaStreamCenterMac::createMediaStream):
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::MockMediaStreamCenter::createMediaStream):
- platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::addStream):
(WebCore::RTCPeerConnectionHandlerMock::removeStream):
- platform/mock/RTCPeerConnectionHandlerMock.h:
Source/WebKit/blackberry:
- WebCoreSupport/UserMediaClientImpl.cpp:
(WebCore::toMediaStreamPrivate):
(WebCore::WebUserMediaRequestClientImpl::requestSucceeded):
- 7:18 AM Changeset in webkit [158848] by
-
- 92 edits in trunk
[GTK] Glyphs in vertical text tests are rotated 90 degrees clockwise
https://bugs.webkit.org/show_bug.cgi?id=50619
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-07
Reviewed by Martin Robinson.
Source/WebCore:
Implemented the OPENTYPE_VERTICAL feature for the GTK+ port. It resolves
the 90 degrees rotation problem of CJK characters when displaying
vertical text.
New tests are not required as the existing tests for vertical text will
work properly now.
- GNUmakefile.list.am: Added OpenTypeVerticalData.cpp and
OpenTypeVerticalData.h to platformgtk_sources.
- PlatformEfl.cmake: Added OpenTypeVerticalData.cpp.
- PlatformGTK.cmake: Added OpenTypeVerticalData.cpp.
- platform/graphics/FontCache.cpp: Originally the HashMap for
OpenTypeVerticalData was designed with FontFileKey as integer in the
Chromium port, which was an unique number provided by Skia. Since other
ports use FontFileKey as string, new generic hash functions had to be
implemented instead of using the specific ones for integers.
(WebCore::FontVerticalDataCacheKeyHash::hash): New hash function for
HashMap of OpenTypeVerticalData.
(WebCore::FontVerticalDataCacheKeyHash::equal): New function for
comparing hash indexes in the HashMap of OpenTypeVerticalData.
(WebCore::FontVerticalDataCacheKeyTraits::emptyValue): New function for
giving an empty FontFileKey.
(WebCore::FontVerticalDataCacheKeyTraits::constructDeletedValue): New
function to create a FontFileKey for deleted values.
(WebCore::FontVerticalDataCacheKeyTraits::isDeletedValue): New function
to check if a HashMap entry is available.
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Added font
orientation as a parameter to the FontPlatformData constructor.
- platform/graphics/freetype/FontPlatformData.h: Added m_orientation to
store the font orientation and m_horizontalOrientationMatrix to store
the Cairo matrix for horizontal orientation, which can be restored in
setOrientation().
(WebCore::FontPlatformData::FontPlatformData): Added font orientation as
a parameter.
(WebCore::FontPlatformData::orientation): Implemented this function
based on m_orientation.
- platform/graphics/freetype/FontPlatformDataFreeType.cpp: Added new
helper function rotateCairoMatrixForVerticalOrientation() to rotate the
Cairo matrix in case of vertical orientation.
(WebCore::FontPlatformData::FontPlatformData): Initialized
m_orientation.
(WebCore::FontPlatformData::operator=): Added m_orientation and
m_horizontalOrientationMatrix to the assignment operator.
(WebCore::FontPlatformData::operator==): Added m_orientation to the
equal operator.
(WebCore::FontPlatformData::initializeWithFontFace): Rotated and
translated fonts if orientation is vertical. Also stored the horizontal
Cairo matrix.
(WebCore::FontPlatformData::verticalData): Returned the vertical data
from the font cache.
(WebCore::FontPlatformData::openTypeTable): Loaded the font table into
a shared buffer.
(WebCore::FontPlatformData::setOrientation): Replaced the scaled font
data by rotating fonts according to the new orientation.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformInit): Set the glyph's height and
width according to the font orientation. It also sets EM.
(WebCore::SimpleFontData::platformCreateScaledFontData): Added
orientation to the FontPlatformData constructor.
(WebCore::SimpleFontData::platformWidthForGlyph): Returned the glyph's
width according the orientation.
- platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
(WebCore::CairoGetGlyphWidthAndExtents): Obtained the character advance
and extents according to the font orientation.
Source/Platform:
Added WebCore/platform/graphics/opentype to the include path.
- GNUmakefile.am:
Source/WTF:
Enabled OPENTYPE_VERTICAL by default on GTK+ and EFL ports, which are
currently using Freetype.
- wtf/Platform.h:
Source/WebKit:
Added WebCore/platform/graphics/opentype to the include path.
- PlatformEfl.cmake:
Source/WebKit2:
Added WebCore/platform/graphics/opentype to the include path.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
LayoutTests:
Updated existing test results that uses vertical texts.
- platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Updated.
- platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Updated.
- platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Updated.
- platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Updated.
- platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Updated.
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Updated.
- platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.png: Updated.
- platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Updated.
- platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Updated.
- platform/gtk/fast/dynamic/text-combine-expected.png: Updated.
- platform/gtk/fast/dynamic/text-combine-expected.txt: Updated.
- platform/gtk/fast/html/details-writing-mode-expected.png: Updated.
- platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.png: Updated.
- platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.png: Updated.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Updated.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Updated.
- platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Updated.
- platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Updated.
- platform/gtk/fast/ruby/base-shorter-than-text-expected.png: Updated.
- platform/gtk/fast/ruby/base-shorter-than-text-expected.txt: Updated.
- platform/gtk/fast/text/decorations-with-text-combine-expected.png: Updated.
- platform/gtk/fast/text/decorations-with-text-combine-expected.txt: Updated.
- platform/gtk/fast/text/emphasis-combined-text-expected.png: Updated.
- platform/gtk/fast/text/emphasis-combined-text-expected.txt: Updated.
- platform/gtk/fast/text/emphasis-vertical-expected.png: Updated.
- platform/gtk/fast/text/emphasis-vertical-expected.txt: Updated.
- platform/gtk/fast/text/international/text-combine-image-test-expected.png: Updated.
- platform/gtk/fast/text/international/text-combine-image-test-expected.txt: Updated.
- platform/gtk/fast/text/international/text-spliced-font-expected.png: Updated.
- platform/gtk/fast/text/international/text-spliced-font-expected.txt: Updated.
- platform/gtk/fast/text/international/vertical-text-glyph-test-expected.png: Updated.
- platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
- platform/gtk/fast/text/justify-ideograph-vertical-expected.png: Updated.
- platform/gtk/fast/text/justify-ideograph-vertical-expected.txt: Added.
- platform/gtk/fast/text/orientation-sideways-expected.png: Updated.
- platform/gtk/fast/text/orientation-sideways-expected.txt: Updated.
- platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Updated.
- platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Updated.
- platform/gtk/fast/writing-mode/border-vertical-lr-expected.png: Updated.
- platform/gtk/fast/writing-mode/border-vertical-lr-expected.txt: Updated.
- platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.png: Updated.
- platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt: Updated.
- platform/gtk/fast/writing-mode/broken-ideographic-font-expected.png: Updated.
- platform/gtk/fast/writing-mode/broken-ideographic-font-expected.txt: Updated.
- platform/gtk/fast/writing-mode/fallback-orientation-expected.png: Updated.
- platform/gtk/fast/writing-mode/fallback-orientation-expected.txt: Updated.
- platform/gtk/fast/writing-mode/japanese-lr-selection-expected.png: Updated.
- platform/gtk/fast/writing-mode/japanese-lr-selection-expected.txt: Updated.
- platform/gtk/fast/writing-mode/japanese-lr-text-expected.png: Updated.
- platform/gtk/fast/writing-mode/japanese-lr-text-expected.txt: Updated.
- platform/gtk/fast/writing-mode/japanese-rl-selection-expected.png: Updated.
- platform/gtk/fast/writing-mode/japanese-rl-selection-expected.txt: Updated.
- platform/gtk/fast/writing-mode/japanese-rl-text-expected.png: Updated.
- platform/gtk/fast/writing-mode/japanese-rl-text-expected.txt: Updated.
- platform/gtk/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Updated.
- platform/gtk/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Updated.
- platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Updated.
- platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Updated.
- platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Updated.
- platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Updated.
- platform/gtk/fast/writing-mode/text-orientation-basic-expected.png: Updated.
- platform/gtk/fast/writing-mode/text-orientation-basic-expected.txt:
- platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png: Updated.
- platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt: Updated.
- platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.png: Updated.
- platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.txt: Updated.
- platform/gtk/fast/writing-mode/vertical-font-fallback-expected.png: Updated.
- platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt: Updated.
- 5:43 AM Changeset in webkit [158847] by
-
- 1 edit2 moves1 delete in trunk/LayoutTests
Unreviewed GTK gardening. Expectations are finally the same for
WK1 and WK2 so, besides needing a rebaseline, we now can share them.
- platform/gtk-wk1/accessibility/table-attributes-expected.txt: Removed.
- platform/gtk-wk1/accessibility/table-sections-expected.txt: Removed.
- platform/gtk/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/accessibility/table-attributes-expected.txt.
- platform/gtk/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/accessibility/table-sections-expected.txt.
- 4:51 AM Changeset in webkit [158846] by
-
- 1 edit26 adds in trunk/LayoutTests
Unreviewed, Add new baselines to EFL port since r158743 as well as do rebaseline.
Because r158743 didn't update EFL port.
- platform/efl/fullscreen/video-controls-override-expected.txt: Added.
- platform/efl/http/tests/media/video-cookie-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
- platform/efl/media/context-menu-actions-expected.txt: Added.
- platform/efl/media/media-can-play-flac-audio-expected.txt: Added.
- platform/efl/media/media-can-play-webm-expected.txt: Added.
- platform/efl/media/media-volume-slider-rendered-below-expected.txt: Added.
- platform/efl/media/media-volume-slider-rendered-normal-expected.txt: Added.
- platform/efl/media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Added.
- platform/efl/media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Added.
- platform/efl/media/track/track-cue-mutable-text-expected.txt: Added.
- platform/efl/media/track/track-cue-rendering-mode-changed-expected.txt: Added.
- platform/efl/media/track/track-language-preference-expected.txt: Added.
- platform/efl/media/track/video/video-track-mkv-theora-addtrack-expected.txt: Added.
- platform/efl/media/track/video/video-track-mkv-theora-selected-expected.txt: Added.
- platform/efl/media/video-controls-fullscreen-volume-expected.txt: Added.
- platform/efl/media/video-controls-toggling-expected.txt: Added.
- 4:46 AM Changeset in webkit [158845] by
-
- 2 edits in trunk/Tools
[Efl] Disable LTO when building cairo
https://bugs.webkit.org/show_bug.cgi?id=123947
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-07
Reviewed by Gyuyoung Kim.
Cairo always uses LTO, when it detects compiler support.
LTO is buggy in many/all versions of GCC and shouldn't be enabled by
default. This patch disables LTO when building cairo library.
With gcc 4.7.3, for example, the build fails with the following message:
'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
- efl/jhbuild.modules:
- 4:29 AM Changeset in webkit [158844] by
-
- 7 edits in trunk/Source
[AX] Use toAccessibilityRenderObject() instead of using static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=123986
Reviewed by Mario Sanchez Prada.
Though there is toAccessibilityRenderObject(), static_cast<> are being used by many places.
To use toAccessibilityRenderObject() is more helpful to find bad type cast.
No new tests, no behavior changes.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::notificationPostTimerFired):
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
- accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetElement):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 4:10 AM Changeset in webkit [158843] by
-
- 6 edits in trunk/Source/WebCore
[AX] Use toAccessibilityTable() instead of using manual static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=123982
Reviewed by Mario Sanchez Prada.
Though there is toAccessibilityTable(), static_cast<> are being used by many places.
We need to use toAccessibilityTable().
No new tests, no behavior changes.
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
- accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::addChildren):
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(cell):
(cellAtIndex):
(webkitAccessibleTableGetIndexAt):
(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper tableParent]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
- 4:04 AM Changeset in webkit [158842] by
-
- 14 edits in trunk/Source/WebCore
Use tighter InlineBox subtypes in some places.
<https://webkit.org/b/123980>
RenderLineBreak and RenderBox line box wrappers are always going to
be InlineElementBox, so codify this with tighter types. Also made
the various positionLine() functions take tighter reference types.
All the casting to renderer-appropriate box types happens inside of
RenderBlockFlow::computeBlockDirectionPositionsForLine() and
propagates from there.
Reviewed by Antti Koivisto.
- 3:12 AM Changeset in webkit [158841] by
-
- 10 edits4 adds in trunk
AX: [ATK] Video and audio elements are not properly exposed
https://bugs.webkit.org/show_bug.cgi?id=123894
Reviewed by Chris Fleizach.
Source/WebCore:
Expose <audio> and <video> elements with ATK_ROLE_EMBEDDED, so we
can identify them properly from ATK/AT-SPI based ATs.
Tests: platform/gtk/accessibility/media-controls-panel-title.html
platform/efl/accessibility/media-emits-object-replacement.html
platform/gtk/accessibility/media-emits-object-replacement.html
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Add the new mapping.
Tools:
Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated.
LayoutTests:
Updated tests and expectations according to the new behavior.
Updated failing test to reflect the new reality.
- platform/gtk/accessibility/media-element-expected.txt: Updated.
Extended GTK specific test by adding an <audio> element besides
the <video> one and printing all the information about those
related to their media nature.
- platform/gtk/accessibility/media-controls-panel-title.html: Extended.
- platform/gtk/accessibility/media-controls-panel-title-expected.txt: Updated.
Added new tests for GTK and EFL to check that the replaced
character is being properly emitter for both <video> and <audio>
elements. Inspired in the ones in platform/mac, we use a different
approach here to print the test since we don't have the
textMarkerRangeForElement functionality in our DRT/WKTR, and
because we expect embedded objects to show up in the results in a
GTK/EFL specific way (using the "<obj>" string).
- platform/efl/accessibility/media-emits-object-replacement-expected.txt: Added.
- platform/efl/accessibility/media-emits-object-replacement.html: Added.
- platform/gtk/accessibility/media-emits-object-replacement-expected.txt: Added.
- platform/gtk/accessibility/media-emits-object-replacement.html: Added.
Removed tests with failure expectations that are now passing.
- platform/gtk/TestExpectations: Removed passing tests.
- 3:04 AM Changeset in webkit [158840] by
-
- 2 edits in trunk/Source/WebCore
Fix crash in BitmapImage::destroyDecodedData()
https://bugs.webkit.org/show_bug.cgi?id=116494
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.
Merge from https://chromium.googlesource.com/chromium/blink/+/6b6887bf53068f8537908e501fdc7317ad2c6d86
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedData):
- 2:53 AM Changeset in webkit [158839] by
-
- 6 edits in trunk
[CSS Grid Layout] CSSParser should reject <track-list> without a <track-size>
https://bugs.webkit.org/show_bug.cgi?id=118025
Reviewed by Andreas Kling.
Source/WebCore:
From Blink r152914 by <jchaffraix@chromium.org>
Make sure that we parse at least 1 <track-size> inside each
<track-list>. The old parser code allowed track-lists exclusively
made of <track-name>. The way it was implemented eases the future
addition of parsing for the repeat() function.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTrackList):
- css/StyleResolver.cpp:
(WebCore::createGridTrackList): ASSERT if we don't find any
<track-size> now that we detect their absence in the parser.
LayoutTests:
Added a new test that verifies that <track-list> exclusively made
of <track-name> are not supported.
- fast/css-grid-layout/named-grid-line-get-set-expected.txt:
- fast/css-grid-layout/named-grid-line-get-set.html:
- 2:45 AM Changeset in webkit [158838] by
-
- 13 edits in trunk
[CSS Grid Layout] Fix handling of 'inherit' and 'initial' for grid lines
https://bugs.webkit.org/show_bug.cgi?id=115401
Reviewed by Andreas Kling.
Source/WebCore:
From Blink r150585 by <jchaffraix@chromium.org>
Added support for 'inherit' and 'initial' special values to
grid-auto-{columns|rows} and grid-definition-{columns|rows}.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty): Resolve 'initial' and 'inherit'.
- rendering/style/RenderStyle.h: Added initialNamedGrid{Column|Row}Lines().
- rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData): Initialize m_namedGrid{Column|Row}Lines.
LayoutTests:
Added 'inherit' and 'initial' testing support to existing tests.
- fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt:
- fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
- fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
- fast/css-grid-layout/grid-auto-flow-get-set.html:
- fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
- fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
(testInherit): New helper function.
(testInitial): Ditto.
- fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
(testInherit): New helper function.
(testInitial): Ditto.
- 2:36 AM Changeset in webkit [158837] by
-
- 30 edits in trunk/LayoutTests
Unreviewed gardening
Adjust test expectations after r158743.
- fullscreen/video-controls-override-expected.txt:
- http/tests/media/video-cookie-expected.txt:
- media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt:
- media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt:
- media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt:
- media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt:
- media/context-menu-actions-expected.txt:
- media/media-can-play-flac-audio-expected.txt:
- media/media-volume-slider-rendered-below-expected.txt:
- media/media-volume-slider-rendered-normal-expected.txt:
- media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt:
- media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt:
- media/track/track-cue-mutable-text-expected.txt:
- media/track/track-cue-rendering-mode-changed-expected.txt:
- media/track/track-language-preference-expected.txt:
- media/track/video/video-track-mkv-theora-addtrack-expected.txt:
- media/video-controls-fullscreen-volume-expected.txt:
- media/video-controls-toggling-expected.txt:
- media/video-controls-visible-exiting-fullscreen-expected.txt:
- media/video-seek-past-end-paused-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt:
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt:
- platform/efl/media/media-can-play-webm-expected.txt:
- 2:27 AM Changeset in webkit [158836] by
-
- 1 edit35 moves35 deletes in trunk/LayoutTests
Optimize baselines: svg/batik
Unreviewed; run "webkit-patch optimize-baselines svg/batik"
- platform/gtk/svg/batik/filters/feTile-expected.txt: Removed.
- platform/gtk/svg/batik/filters/filterRegions-expected.txt: Removed.
- platform/gtk/svg/batik/masking/maskRegions-expected.txt: Removed.
- platform/gtk/svg/batik/paints/gradientLimit-expected.txt: Removed.
- platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Removed.
- platform/gtk/svg/batik/paints/patternRegionA-expected.txt: Removed.
- platform/gtk/svg/batik/paints/patternRegions-expected.txt: Removed.
- platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Removed.
- platform/gtk/svg/batik/text/longTextOnPath-expected.txt: Removed.
- platform/gtk/svg/batik/text/smallFonts-expected.txt: Removed.
- platform/gtk/svg/batik/text/textAnchor-expected.txt: Removed.
- platform/gtk/svg/batik/text/textAnchor2-expected.txt: Removed.
- platform/gtk/svg/batik/text/textAnchor3-expected.txt: Removed.
- platform/gtk/svg/batik/text/textDecoration-expected.txt: Removed.
- platform/gtk/svg/batik/text/textDecoration2-expected.txt: Removed.
- platform/gtk/svg/batik/text/textEffect-expected.txt: Removed.
- platform/gtk/svg/batik/text/textEffect2-expected.txt: Removed.
- platform/gtk/svg/batik/text/textEffect3-expected.txt: Removed.
- platform/gtk/svg/batik/text/textFeatures-expected.txt: Removed.
- platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Removed.
- platform/gtk/svg/batik/text/textLayout-expected.txt: Removed.
- platform/gtk/svg/batik/text/textLayout2-expected.txt: Removed.
- platform/gtk/svg/batik/text/textLength-expected.txt: Removed.
- platform/gtk/svg/batik/text/textOnPath-expected.txt: Removed.
- platform/gtk/svg/batik/text/textOnPath2-expected.txt: Removed.
- platform/gtk/svg/batik/text/textOnPath3-expected.txt: Removed.
- platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt: Removed.
- platform/gtk/svg/batik/text/textPCDATA-expected.txt: Removed.
- platform/gtk/svg/batik/text/textPosition-expected.txt: Removed.
- platform/gtk/svg/batik/text/textProperties-expected.txt: Removed.
- platform/gtk/svg/batik/text/textProperties2-expected.txt: Removed.
- platform/gtk/svg/batik/text/textStyles-expected.txt: Removed.
- platform/gtk/svg/batik/text/verticalText-expected.txt: Removed.
- platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt: Removed.
- platform/gtk/svg/batik/text/xmlSpace-expected.txt: Removed.
- svg/batik/filters/feTile-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/filters/feTile-expected.txt.
- svg/batik/filters/filterRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/filters/filterRegions-expected.txt.
- svg/batik/masking/maskRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/masking/maskRegions-expected.txt.
- svg/batik/paints/gradientLimit-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/gradientLimit-expected.txt.
- svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt.
- svg/batik/paints/patternRegionA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegionA-expected.txt.
- svg/batik/paints/patternRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegions-expected.txt.
- svg/batik/paints/patternRegions-positioned-objects-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt.
- svg/batik/text/longTextOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/longTextOnPath-expected.txt.
- svg/batik/text/smallFonts-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/smallFonts-expected.txt.
- svg/batik/text/textAnchor-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor-expected.txt.
- svg/batik/text/textAnchor2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor2-expected.txt.
- svg/batik/text/textAnchor3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor3-expected.txt.
- svg/batik/text/textDecoration-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textDecoration-expected.txt.
- svg/batik/text/textDecoration2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textDecoration2-expected.txt.
- svg/batik/text/textEffect-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect-expected.txt.
- svg/batik/text/textEffect2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect2-expected.txt.
- svg/batik/text/textEffect3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect3-expected.txt.
- svg/batik/text/textFeatures-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textFeatures-expected.txt.
- svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt.
- svg/batik/text/textLayout-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout-expected.txt.
- svg/batik/text/textLayout2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout2-expected.txt.
- svg/batik/text/textLength-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLength-expected.txt.
- svg/batik/text/textOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath-expected.txt.
- svg/batik/text/textOnPath2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath2-expected.txt.
- svg/batik/text/textOnPath3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath3-expected.txt.
- svg/batik/text/textOnPathSpaces-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPathSpaces-expected.txt.
- svg/batik/text/textPCDATA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textPCDATA-expected.txt.
- svg/batik/text/textPosition-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textPosition-expected.txt.
- svg/batik/text/textProperties-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textProperties-expected.txt.
- svg/batik/text/textProperties2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textProperties2-expected.txt.
- svg/batik/text/textStyles-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textStyles-expected.txt.
- svg/batik/text/verticalText-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/verticalText-expected.txt.
- svg/batik/text/verticalTextOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/verticalTextOnPath-expected.txt.
- svg/batik/text/xmlSpace-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/xmlSpace-expected.txt.
- 2:18 AM Changeset in webkit [158835] by
-
- 7 edits6 copies10 moves1 add22 deletes in trunk/LayoutTests
Optimize baselines: svg/as-background-image
Unreviewed; run "webkit-patch optimize-baselines svg/as-background-image"
- platform/efl/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
- platform/efl/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
- platform/efl/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
- platform/efl/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
- platform/efl/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
- platform/efl/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
- platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-expected.png: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Removed.
- platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.png: Removed.
- platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.txt: Removed.
- platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.png: Removed.
- platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.txt: Removed.
- platform/win-future/svg/as-background-image/svg-as-background-1-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-1-expected.txt.
- platform/win-future/svg/as-background-image/svg-as-background-2-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-2-expected.txt.
- platform/win-future/svg/as-background-image/svg-as-background-3-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-3-expected.txt.
- platform/win-future/svg/as-background-image/svg-as-background-4-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-4-expected.txt.
- platform/win-future/svg/as-background-image/svg-as-background-5-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-5-expected.txt.
- platform/win-future/svg/as-background-image/svg-as-background-6-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-6-expected.txt.
- svg/as-background-image/animated-svg-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/animated-svg-as-background-expected.txt.
- svg/as-background-image/svg-as-background-1-expected.txt:
- svg/as-background-image/svg-as-background-2-expected.txt:
- svg/as-background-image/svg-as-background-3-expected.txt:
- svg/as-background-image/svg-as-background-4-expected.txt:
- svg/as-background-image/svg-as-background-5-expected.txt:
- svg/as-background-image/svg-as-background-6-expected.txt:
- svg/as-background-image/svg-as-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-expected.png.
- svg/as-background-image/svg-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-expected.txt.
- svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-relative-size-expected.txt.
- svg/as-background-image/svg-as-background-with-viewBox-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.png.
- svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.txt.
- svg/as-background-image/svg-as-tiled-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-tiled-background-expected.png.
- svg/as-background-image/svg-as-tiled-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-tiled-background-expected.txt.
- svg/as-background-image/svg-width-100p-as-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.png.
- svg/as-background-image/svg-width-100p-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.txt.
- 2:12 AM Changeset in webkit [158834] by
-
- 5 edits in trunk/Source/WebCore
Clean up BidiRun a little bit.
<https://webkit.org/b/123964>
Make BidiRun's member variables private and add accessors for them.
In doing so, codify the following:
- BidiRun always has a corresponding RenderObject.
- The inline box is never cleared after being set.
Reviewed by Antti Koivisto.
- 2:11 AM Changeset in webkit [158833] by
-
- 7 edits in trunk/Source/WebCore
More CSSPrimitiveValue constructors should return PassRef.
<https://webkit.org/b/123953>
Make some more CSSPrimitiveValue constructor helpers (that are
known to never return null) return PassRef instead of PassRefPtr.
Reviewed by Antti Koivisto.
- 2:08 AM Changeset in webkit [158832] by
-
- 17 edits in trunk/Source/WebCore
Generate type casting helpers for line boxes and use them.
<https://webkit.org/b/123976>
Semi-automatically generate the full set of toFooInlineBox()
helpers with macros instead of having them (partially) hand-coded.
Replaced static_casts with the new helpers across the codebase.
Also made the isFooInlineBox() overrides private since they should
never be called when the type is already known.
Reviewed by Antti Koivisto.
- 2:04 AM Changeset in webkit [158831] by
-
- 425 edits4 adds in branches/safari-537.73-branch
Merge r158743
Source/WebCore:
2013-11-06 Chris Fleizach <Chris Fleizach>
AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479
Reviewed by Mario Sanchez Prada.
Video and audio elements don't appear as distinct objects in the AX hierarchy,
nor are they treated as replaceable objects when emitting the text. We should
treat these characters like attachments, for one. On the Mac platform, we should
also identify them with special subroles.
Tests: platform/mac/accessibility/media-emits-object-replacement.html
platform/mac/accessibility/media-role-descriptions.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isGenericFocusableElement):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
LayoutTests:
2013-11-06 Chris Fleizach <Chris Fleizach>
AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479
Reviewed by Mario Sanchez Prada.
Making media elements int replaced elements has the unfortunate side-effect
of causing a new line to be inserted into any test using a <video> or <audio> tag.
- compositing/video/video-poster-expected.txt:
- compositing/video/video-reflection-expected.txt:
- compositing/visibility/visibility-simple-video-layer-expected.txt:
- fast/css/first-letter-block-form-controls-crash-expected.txt:
- fast/css/relative-position-replaced-in-table-display-crash-expected.txt:
- fast/forms/access-key-for-all-elements-expected.txt:
- fast/forms/form-associated-element-crash3-expected.txt:
- fast/multicol/renderer-positioned-assert-crash-expected.txt:
- fast/regions/full-screen-video-from-region-expected.txt:
- fast/runin/nonblock-runin-expected.txt:
- fast/spatial-navigation/snav-media-elements-expected.txt:
- fullscreen/full-screen-crash-offsetLeft-expected.txt:
- fullscreen/full-screen-no-style-sharing-expected.txt:
- fullscreen/full-screen-stacking-context-expected.txt:
- fullscreen/video-controls-drag-expected.txt:
- fullscreen/video-controls-timeline-expected.txt:
- fullscreen/video-cursor-auto-hide-expected.txt:
- fullscreen/video-specified-size-expected.txt:
- http/tests/appcache/video-expected.txt:
- http/tests/media/pdf-served-as-pdf-expected.txt:
- http/tests/media/reload-after-dialog-expected.txt:
- http/tests/media/text-served-as-text-expected.txt:
- http/tests/media/video-accept-encoding-expected.txt:
- http/tests/media/video-buffered-range-contains-currentTime-expected.txt:
- http/tests/media/video-cross-site-expected.txt:
- http/tests/media/video-error-abort-expected.txt:
- http/tests/media/video-load-suspend-expected.txt:
- http/tests/media/video-play-progress-expected.txt:
- http/tests/media/video-play-stall-before-meta-data-expected.txt:
- http/tests/media/video-preload-expected.txt:
- http/tests/media/video-redirect-expected.txt:
- http/tests/media/video-referer-expected.txt:
- http/tests/media/video-served-as-text-expected.txt:
- http/tests/media/video-throttled-load-metadata-expected.txt:
- http/tests/misc/empty-urls-expected.txt:
- http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt:
- http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
- http/tests/security/local-video-poster-from-remote-expected.txt:
- http/tests/security/local-video-source-from-remote-expected.txt:
- http/tests/security/local-video-src-from-remote-expected.txt:
- http/tests/security/text-track-crossorigin-expected.txt:
- media/W3C/audio/events/event_canplay-expected.txt:
- media/W3C/audio/events/event_canplay_manual-expected.txt:
- media/W3C/audio/events/event_canplaythrough-expected.txt:
- media/W3C/audio/events/event_canplaythrough_manual-expected.txt:
- media/W3C/audio/events/event_loadeddata-expected.txt:
- media/W3C/audio/events/event_loadeddata_manual-expected.txt:
- media/W3C/audio/events/event_loadedmetadata-expected.txt:
- media/W3C/audio/events/event_loadedmetadata_manual-expected.txt:
- media/W3C/audio/events/event_loadstart-expected.txt:
- media/W3C/audio/events/event_loadstart_manual-expected.txt:
- media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt:
- media/W3C/audio/events/event_order_canplay_playing-expected.txt:
- media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt:
- media/W3C/audio/events/event_order_loadstart_progress-expected.txt:
- media/W3C/audio/events/event_pause_manual-expected.txt:
- media/W3C/audio/events/event_play-expected.txt:
- media/W3C/audio/events/event_play_manual-expected.txt:
- media/W3C/audio/events/event_playing-expected.txt:
- media/W3C/audio/events/event_playing_manual-expected.txt:
- media/W3C/audio/events/event_progress-expected.txt:
- media/W3C/audio/events/event_progress_manual-expected.txt:
- media/W3C/audio/events/event_timeupdate-expected.txt:
- media/W3C/audio/events/event_timeupdate_manual-expected.txt:
- media/W3C/audio/networkState/networkState_during_loadstart-expected.txt:
- media/W3C/audio/paused/paused_false_during_play-expected.txt:
- media/W3C/audio/paused/paused_true_during_pause-expected.txt:
- media/W3C/audio/readyState/readyState_during_canplay-expected.txt:
- media/W3C/audio/readyState/readyState_during_canplaythrough-expected.txt:
- media/W3C/audio/readyState/readyState_during_loadeddata-expected.txt:
- media/W3C/audio/readyState/readyState_during_loadedmetadata-expected.txt:
- media/W3C/audio/readyState/readyState_during_playing-expected.txt:
- media/W3C/video/canPlayType/canPlayType_application_octet_stream-expected.txt:
- media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt:
- media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt:
- media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3-expected.txt:
- media/W3C/video/canPlayType/canPlayType_bogus_type-expected.txt:
- media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
- media/W3C/video/canPlayType/canPlayType_method_exists-expected.txt:
- media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
- media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
- media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
- media/W3C/video/currentSrc/currentSrc_empty_if_no_src-expected.txt:
- media/W3C/video/currentSrc/currentSrc_property_exists-expected.txt:
- media/W3C/video/error/error_null-expected.txt:
- media/W3C/video/error/error_onerror_called_on_bogus_source-expected.txt:
- media/W3C/video/error/error_property_exists-expected.txt:
- media/W3C/video/events/event_canplay-expected.txt:
- media/W3C/video/events/event_canplay_manual-expected.txt:
- media/W3C/video/events/event_canplaythrough-expected.txt:
- media/W3C/video/events/event_canplaythrough_manual-expected.txt:
- media/W3C/video/events/event_loadeddata-expected.txt:
- media/W3C/video/events/event_loadeddata_manual-expected.txt:
- media/W3C/video/events/event_loadedmetadata-expected.txt:
- media/W3C/video/events/event_loadedmetadata_manual-expected.txt:
- media/W3C/video/events/event_loadstart-expected.txt:
- media/W3C/video/events/event_loadstart_manual-expected.txt:
- media/W3C/video/events/event_order_canplay_canplaythrough-expected.txt:
- media/W3C/video/events/event_order_canplay_playing-expected.txt:
- media/W3C/video/events/event_order_loadedmetadata_loadeddata-expected.txt:
- media/W3C/video/events/event_order_loadstart_progress-expected.txt:
- media/W3C/video/events/event_pause_manual-expected.txt:
- media/W3C/video/events/event_play-expected.txt:
- media/W3C/video/events/event_play_manual-expected.txt:
- media/W3C/video/events/event_playing-expected.txt:
- media/W3C/video/events/event_playing_manual-expected.txt:
- media/W3C/video/events/event_progress-expected.txt:
- media/W3C/video/events/event_progress_manual-expected.txt:
- media/W3C/video/events/event_timeupdate-expected.txt:
- media/W3C/video/events/event_timeupdate_manual-expected.txt:
- media/W3C/video/networkState/networkState_during_loadstart-expected.txt:
- media/W3C/video/networkState/networkState_during_progress-expected.txt:
- media/W3C/video/networkState/networkState_initial-expected.txt:
- media/W3C/video/networkState/networkState_property_exists-expected.txt:
- media/W3C/video/paused/paused_false_during_play-expected.txt:
- media/W3C/video/paused/paused_true_during_pause-expected.txt:
- media/W3C/video/preload/preload_property_exists-expected.txt:
- media/W3C/video/preload/preload_reflects_auto_value-expected.txt:
- media/W3C/video/preload/preload_reflects_bogus_value-expected.txt:
- media/W3C/video/preload/preload_reflects_empty-expected.txt:
- media/W3C/video/preload/preload_reflects_metadata-expected.txt:
- media/W3C/video/preload/preload_reflects_no_value-expected.txt:
- media/W3C/video/preload/preload_reflects_none-expected.txt:
- media/W3C/video/preload/preload_reflects_none_autoplay-expected.txt:
- media/W3C/video/readyState/readyState_during_canplay-expected.txt:
- media/W3C/video/readyState/readyState_during_canplaythrough-expected.txt:
- media/W3C/video/readyState/readyState_during_loadeddata-expected.txt:
- media/W3C/video/readyState/readyState_during_loadedmetadata-expected.txt:
- media/W3C/video/readyState/readyState_during_playing-expected.txt:
- media/W3C/video/readyState/readyState_initial-expected.txt:
- media/W3C/video/readyState/readyState_property_exists-expected.txt:
- media/W3C/video/src/src_reflects_attribute_not_source_elements-expected.txt:
- media/W3C/video/src/src_reflects_no_value-expected.txt:
- media/W3C/video/src/src_removal_does_not_trigger_loadstart-expected.txt:
- media/audio-mpeg-supported-expected.txt:
- media/audio-mpeg4-supported-expected.txt:
- media/audio-only-video-intrinsic-size-expected.txt:
- media/auto-play-in-sandbox-with-allow-scripts-expected.txt:
- media/before-load-member-access-expected.txt:
- media/broken-video-expected.txt:
- media/constructors-expected.txt:
- media/controls-css-overload-expected.txt:
- media/controls-drag-timebar-expected.txt:
- media/controls-layout-direction-expected.txt:
- media/controls-right-click-on-timebar-expected.txt:
- media/csp-blocks-video-expected.txt:
- media/event-attributes-expected.txt:
- media/media-blocked-by-beforeload-expected.txt:
- media/media-blocked-by-willsendrequest-expected.txt:
- media/media-can-play-mpeg-audio-expected.txt:
- media/media-can-play-mpeg4-video-expected.txt:
- media/media-can-play-octet-stream-expected.txt:
- media/media-can-play-type-expected.txt:
- media/media-can-play-wav-audio-expected.txt:
- media/media-captions-expected.txt:
- media/media-captions-no-controls-expected.txt:
- media/media-controller-expected.txt:
- media/media-controller-playback-expected.txt:
- media/media-controller-playbackrate-expected.txt:
- media/media-controller-time-clamp-expected.txt:
- media/media-controller-time-constant-expected.txt:
- media/media-controller-time-expected.txt:
- media/media-controller-timeupdate-expected.txt:
- media/media-controller-unpause-expected.txt:
- media/media-controls-invalid-url-expected.txt:
- media/media-ended-expected.txt:
- media/media-extension-with-fragment-expected.txt:
- media/media-fragments/TC0001-expected.txt:
- media/media-fragments/TC0002-expected.txt:
- media/media-fragments/TC0003-expected.txt:
- media/media-fragments/TC0004-expected.txt:
- media/media-fragments/TC0005-expected.txt:
- media/media-fragments/TC0006-expected.txt:
- media/media-fragments/TC0009-expected.txt:
- media/media-fragments/TC0011-expected.txt:
- media/media-fragments/TC0012-expected.txt:
- media/media-fragments/TC0014-expected.txt:
- media/media-fragments/TC0015-expected.txt:
- media/media-fragments/TC0017-expected.txt:
- media/media-fragments/TC0024-expected.txt:
- media/media-fragments/TC0027-expected.txt:
- media/media-fragments/TC0028-expected.txt:
- media/media-fragments/TC0029-expected.txt:
- media/media-fragments/TC0030-expected.txt:
- media/media-fragments/TC0031-expected.txt:
- media/media-fragments/TC0032-expected.txt:
- media/media-fragments/TC0033-expected.txt:
- media/media-fragments/TC0034-expected.txt:
- media/media-fragments/TC0035-expected.txt:
- media/media-fragments/TC0036-expected.txt:
- media/media-fragments/TC0037-expected.txt:
- media/media-fragments/TC0038-expected.txt:
- media/media-fragments/TC0039-expected.txt:
- media/media-fragments/TC0044-expected.txt:
- media/media-fragments/TC0051-expected.txt:
- media/media-fragments/TC0052-expected.txt:
- media/media-fragments/TC0053-expected.txt:
- media/media-fragments/TC0054-expected.txt:
- media/media-fragments/TC0055-expected.txt:
- media/media-fragments/TC0058-expected.txt:
- media/media-fragments/TC0059-expected.txt:
- media/media-fragments/TC0061-expected.txt:
- media/media-fragments/TC0062-expected.txt:
- media/media-fragments/TC0063-expected.txt:
- media/media-fragments/TC0064-expected.txt:
- media/media-fragments/TC0065-expected.txt:
- media/media-fragments/TC0066-expected.txt:
- media/media-fragments/TC0067-expected.txt:
- media/media-fragments/TC0068-expected.txt:
- media/media-fragments/TC0069-expected.txt:
- media/media-fragments/TC0070-expected.txt:
- media/media-fragments/TC0071-expected.txt:
- media/media-fragments/TC0072-expected.txt:
- media/media-fragments/TC0073-expected.txt:
- media/media-fragments/TC0074-expected.txt:
- media/media-fragments/TC0075-expected.txt:
- media/media-fragments/TC0076-expected.txt:
- media/media-fragments/TC0077-expected.txt:
- media/media-fragments/TC0078-expected.txt:
- media/media-fragments/TC0079-expected.txt:
- media/media-fragments/TC0080-expected.txt:
- media/media-fragments/TC0081-expected.txt:
- media/media-fragments/TC0082-expected.txt:
- media/media-fragments/TC0083-expected.txt:
- media/media-fragments/TC0084-expected.txt:
- media/media-fragments/TC0085-expected.txt:
- media/media-fragments/TC0086-expected.txt:
- media/media-fragments/TC0087-expected.txt:
- media/media-fragments/TC0088-expected.txt:
- media/media-fragments/TC0089-expected.txt:
- media/media-fragments/TC0090-expected.txt:
- media/media-fragments/TC0091-expected.txt:
- media/media-fragments/TC0092-expected.txt:
- media/media-fragments/TC0093-expected.txt:
- media/media-fragments/TC0094-expected.txt:
- media/media-fullscreen-inline-expected.txt:
- media/media-preload-no-delay-loadevent-expected.txt:
- media/no-autoplay-with-user-gesture-requirement-expected.txt:
- media/nodesFromRect-shadowContent-expected.txt:
- media/restore-from-page-cache-expected.txt:
- media/sources-fallback-codecs-expected.txt:
- media/track/add-and-remove-track-expected.txt:
- media/track/audio-track-expected.txt:
- media/track/opera/interfaces/TextTrack/addCue-expected.txt:
- media/track/opera/interfaces/TextTrack/removeCue-expected.txt:
- media/track/opera/interfaces/TextTrackCue/align-expected.txt:
- media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:
- media/track/opera/interfaces/TextTrackCue/id-expected.txt:
- media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt:
- media/track/opera/interfaces/TextTrackCue/startTime-expected.txt:
- media/track/opera/interfaces/TextTrackCue/track-expected.txt:
- media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt:
- media/track/opera/interfaces/TextTrackCueList/length-expected.txt:
- media/track/text-track-cue-is-reachable-expected.txt:
- media/track/text-track-is-reachable-expected.txt:
- media/track/track-active-cues-expected.txt:
- media/track/track-add-remove-cue-expected.txt:
- media/track/track-add-track-expected.txt:
- media/track/track-addtrack-kind-expected.txt:
- media/track/track-automatic-subtitles-expected.txt:
- media/track/track-css-all-cues-expected.txt:
- media/track/track-css-cue-lifetime-expected.txt:
- media/track/track-css-matching-default-expected.txt:
- media/track/track-css-matching-expected.txt:
- media/track/track-css-matching-lang-expected.txt:
- media/track/track-css-matching-timestamps-expected.txt:
- media/track/track-css-property-whitelist-expected.txt:
- media/track/track-css-user-override-expected.txt:
- media/track/track-cue-container-rendering-position-expected.txt:
- media/track/track-cue-empty-text-crash-expected.txt:
- media/track/track-cue-inline-assertion-crash-expected.txt:
- media/track/track-cue-mutable-expected.txt:
- media/track/track-cue-mutable-fragment-expected.txt:
- media/track/track-cue-negative-timestamp-expected.txt:
- media/track/track-cue-nothing-to-render-expected.txt:
- media/track/track-cue-overlap-snap-to-lines-not-set-expected.txt:
- media/track/track-cue-rendering-empty-cue-crash-expected.txt:
- media/track/track-cue-rendering-expected.txt:
- media/track/track-cue-rendering-on-resize-expected.txt:
- media/track/track-cue-rendering-rtl-expected.txt:
- media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
- media/track/track-cue-rendering-tree-is-removed-properly-expected.txt:
- media/track/track-cue-rendering-with-padding-expected.txt:
- media/track/track-cues-cuechange-expected.txt:
- media/track/track-cues-enter-exit-expected.txt:
- media/track/track-cues-missed-expected.txt:
- media/track/track-cues-pause-on-exit-expected.txt:
- media/track/track-cues-seeking-expected.txt:
- media/track/track-cues-sorted-before-dispatch-expected.txt:
- media/track/track-default-attribute-expected.txt:
- media/track/track-disabled-addcue-expected.txt:
- media/track/track-disabled-expected.txt:
- media/track/track-element-load-event-expected.txt:
- media/track/track-in-band-cues-added-once-expected.txt:
- media/track/track-in-band-duplicate-tracks-when-source-changes-expected.txt:
- media/track/track-in-band-expected.txt:
- media/track/track-in-band-legacy-api-expected.txt:
- media/track/track-in-band-style-expected.txt:
- media/track/track-kind-expected.txt:
- media/track/track-large-timestamp-expected.txt:
- media/track/track-legacyapi-with-automatic-mode-expected.txt:
- media/track/track-load-from-element-readyState-expected.txt:
- media/track/track-load-from-src-readyState-expected.txt:
- media/track/track-long-captions-file-expected.txt:
- media/track/track-mode-disabled-crash-expected.txt:
- media/track/track-mode-expected.txt:
- media/track/track-mode-not-changed-by-new-track-expected.txt:
- media/track/track-mode-triggers-loading-expected.txt:
- media/track/track-remove-active-cue-crash-expected.txt:
- media/track/track-remove-by-setting-innerHTML-expected.txt:
- media/track/track-remove-quickly-expected.txt:
- media/track/track-text-track-cue-list-expected.txt:
- media/track/track-texttracks-expected.txt:
- media/track/track-webvtt-tc000-empty-expected.txt:
- media/track/track-webvtt-tc001-utf8-expected.txt:
- media/track/track-webvtt-tc002-bom-expected.txt:
- media/track/track-webvtt-tc003-newlines-expected.txt:
- media/track/track-webvtt-tc004-magic-header-expected.txt:
- media/track/track-webvtt-tc005-header-comment-expected.txt:
- media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
- media/track/track-webvtt-tc007-cue-no-id-expected.txt:
- media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
- media/track/track-webvtt-tc009-timings-hour-expected.txt:
- media/track/track-webvtt-tc010-no-timings-expected.txt:
- media/track/track-webvtt-tc011-blank-lines-expected.txt:
- media/track/track-webvtt-tc013-settings-expected.txt:
- media/track/track-webvtt-tc014-alignment-expected.txt:
- media/track/track-webvtt-tc015-positioning-expected.txt:
- media/track/track-webvtt-tc016-align-positioning-expected.txt:
- media/track/track-webvtt-tc017-line-position-expected.txt:
- media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
- media/track/track-webvtt-tc019-cue-size-expected.txt:
- media/track/track-webvtt-tc020-cue-size-align-expected.txt:
- media/track/track-webvtt-tc021-valign-expected.txt:
- media/track/track-webvtt-tc022-entities-expected.txt:
- media/track/track-webvtt-tc023-markup-expected.txt:
- media/track/track-webvtt-tc024-timestamp-expected.txt:
- media/track/track-webvtt-tc025-class-markup-expected.txt:
- media/track/track-webvtt-tc026-voice-expected.txt:
- media/track/track-webvtt-tc027-empty-cue-expected.txt:
- media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
- media/track/track-word-breaking-expected.txt:
- media/track/tracklist-is-reachable-expected.txt:
- media/track/video-track-expected.txt:
- media/unsupported-rtsp-expected.txt:
- media/unsupported-tracks-expected.txt:
- media/video-append-source-expected.txt:
- media/video-autoplay-expected.txt:
- media/video-beforeload-remove-source-expected.txt:
- media/video-buffered-expected.txt:
- media/video-canvas-drawing-expected.txt:
- media/video-canvas-drawing-output-expected.txt:
- media/video-controls-captions-trackmenu-hide-on-click-outside-expected.txt:
- media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt:
- media/video-controls-expected.txt:
- media/video-controls-transformed-expected.txt:
- media/video-controls-with-mutation-event-handler-expected.txt:
- media/video-controls-zoomed-expected.txt:
- media/video-currentTime-delay-expected.txt:
- media/video-currentTime-expected.txt:
- media/video-currentTime-set-expected.txt:
- media/video-currentTime-set2-expected.txt:
- media/video-delay-load-event-expected.txt:
- media/video-display-aspect-ratio-expected.txt:
- media/video-dom-autoplay-expected.txt:
- media/video-dom-preload-expected.txt:
- media/video-dom-src-expected.txt:
- media/video-duration-known-after-eos-expected.txt:
- media/video-error-does-not-exist-expected.txt:
- media/video-load-networkState-expected.txt:
- media/video-load-preload-metadata-expected.txt:
- media/video-load-preload-none-expected.txt:
- media/video-load-readyState-expected.txt:
- media/video-load-require-user-gesture-expected.txt:
- media/video-loop-expected.txt:
- media/video-mouse-focus-expected.txt:
- media/video-muted-expected.txt:
- media/video-no-autoplay-expected.txt:
- media/video-pause-empty-events-expected.txt:
- media/video-pause-immediately-expected.txt:
- media/video-play-empty-events-expected.txt:
- media/video-play-pause-events-expected.txt:
- media/video-play-pause-exception-expected.txt:
- media/video-play-require-user-gesture-expected.txt:
- media/video-playbackrate-expected.txt:
- media/video-played-collapse-expected.txt:
- media/video-played-ranges-1-expected.txt:
- media/video-played-reset-expected.txt:
- media/video-plays-past-end-of-test-expected.txt:
- media/video-poster-blocked-by-willsendrequest-expected.txt:
- media/video-poster-delayed-expected.txt:
- media/video-poster-expected.txt:
- media/video-poster-scale-expected.txt:
- media/video-preload-expected.txt:
- media/video-replaces-poster-expected.txt:
- media/video-reverse-play-duration-expected.txt:
- media/video-seek-after-end-expected.txt:
- media/video-seek-by-small-increment-expected.txt:
- media/video-seek-multiple-expected.txt:
- media/video-seek-no-src-exception-expected.txt:
- media/video-seek-past-end-playing-expected.txt:
- media/video-seekable-expected.txt:
- media/video-seeking-expected.txt:
- media/video-set-rate-from-pause-expected.txt:
- media/video-single-valid-source-expected.txt:
- media/video-size-expected.txt:
- media/video-source-error-expected.txt:
- media/video-source-error-no-candidate-expected.txt:
- media/video-source-expected.txt:
- media/video-source-inserted-expected.txt:
- media/video-source-load-expected.txt:
- media/video-source-none-supported-expected.txt:
- media/video-source-type-expected.txt:
- media/video-src-blob-expected.txt:
- media/video-src-change-expected.txt:
- media/video-src-empty-expected.txt:
- media/video-src-expected.txt:
- media/video-src-invalid-poster-expected.txt:
- media/video-src-invalid-remove-expected.txt:
- media/video-src-none-expected.txt:
- media/video-src-plus-source-expected.txt:
- media/video-src-remove-expected.txt:
- media/video-src-set-expected.txt:
- media/video-src-source-expected.txt:
- media/video-timeupdate-during-playback-expected.txt:
- media/video-timeupdate-reverse-play-expected.txt:
- media/video-volume-expected.txt:
- media/video-width-height-expected.txt:
- platform/mac/accessibility/media-element-expected.txt:
- platform/mac/accessibility/media-emits-object-replacement-expected.txt: Added.
- platform/mac/accessibility/media-emits-object-replacement.html: Added.
- platform/mac/accessibility/media-role-descriptions-expected.txt: Added.
- platform/mac/accessibility/media-role-descriptions.html: Added.
- platform/mac/compositing/video/video-object-fit-expected.txt:
- platform/mac/fullscreen/video-controls-override-expected.txt:
- platform/mac/media/media-can-play-wav-audio-expected.txt:
- platform/mac/media/media-can-play-webm-expected.txt:
- platform/mac/media/video-seek-past-end-paused-expected.txt:
- 2:02 AM Changeset in webkit [158830] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build for architectures with 4 argument registers (broken since r158820).
https://bugs.webkit.org/show_bug.cgi?id=123969
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-07
Reviewed by Andreas Kling.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArguments):
- 1:32 AM Changeset in webkit [158829] by
-
- 4 edits in trunk/Source/WebCore
Simplify Attr by removing m_specified member variable and setter
https://bugs.webkit.org/show_bug.cgi?id=123965
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/597f44ec928e08820574728889adabc6d8ecd746
m_specified is always true in WebKit so simply return true in Attr::specified().
- dom/Attr.cpp:
(WebCore::Attr::Attr):
- dom/Attr.h:
- dom/Document.cpp:
(WebCore::Document::adoptNode):
- 1:21 AM Changeset in webkit [158828] by
-
- 2 edits in trunk/Tools
Change git_commit_from_svn_revision() to work in a pure git checkout
https://bugs.webkit.org/show_bug.cgi?id=111668
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-07
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.git_commit_from_svn_revision):
- 12:05 AM Changeset in webkit [158827] by
-
- 3 edits in trunk/Source/WebKit2
[Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE
https://bugs.webkit.org/show_bug.cgi?id=123919
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-07
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/PageClientImpl.cpp: Remove takeFocus().
- UIProcess/API/gtk/PageClientImpl.h: Remove takeFocus() and mark methods as OVERRIDE.
Nov 6, 2013:
- 10:41 PM Changeset in webkit [158826] by
-
- 5 edits in trunk/Source
Versioning.
- 10:39 PM Changeset in webkit [158825] by
-
- 1 copy in tags/Safari-538.5
New Tag.
- 10:01 PM Changeset in webkit [158824] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 9:59 PM Changeset in webkit [158823] by
-
- 1 copy in tags/Safari-537.73.4
New Tag.
- 9:38 PM Changeset in webkit [158822] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL should support CheckFunction
https://bugs.webkit.org/show_bug.cgi?id=123862
Reviewed by Sam Weinig.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckFunction):
- 9:26 PM Changeset in webkit [158821] by
-
- 35 edits8 copies in trunk/Source/WebCore
[MSE] Add MediaSource extensions to AudioTrack, VideoTrack, and TextTrack.
https://bugs.webkit.org/show_bug.cgi?id=123374
Reviewed by Eric Carlson.
No tests added; tests will be added when Mock implementations are added in a future patch.
Add new partial interfaces for added methods on AudioTrack, TextTrack, and VideoTrack:
- Modules/mediasource/AudioTrackMediaSource.idl: Add read-only sourceBuffer attribute.
- Modules/mediasource/TextTrackMediaSource.idl: Ditto.
- Modules/mediasource/VideoTrackMediaSource.idl: Ditto.
- Modules/mediasource/AudioTrackMediaSource.h:
(WebCore::AudioTrackMediaSource::sourceBuffer): Added static wrapper around non-static sourceBuffer().
- Modules/mediasource/TextTrackMediaSource.h:
(WebCore::TextTrackMediaSource::sourceBuffer): Ditto.
- Modules/mediasource/VideoTrackMediaSource.h:
(WebCore::VideoTrackMediaSource::sourceBuffer): Ditto.
Add support for writable kind & language attributes through a custom setter:
- bindings/js/JSAudioTrackCustom.cpp:
(WebCore::JSAudioTrack::setKind):
(WebCore::JSAudioTrack::setLanguage):
- bindings/js/JSTextTrackCustom.cpp:
(WebCore::JSTextTrack::setKind):
(WebCore::JSTextTrack::setLanguage):
- bindings/js/JSVideoTrackCustom.cpp:
(WebCore::JSVideoTrack::setKind):
(WebCore::JSVideoTrack::setLanguage):
- html/track/AudioTrack.idl:
- html/track/TextTrack.idl:
- html/track/VideoTrack.idl:
Add setter methods to the implementation classes:
- html/track/TextTrack.cpp:
(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setKind):
(WebCore::TextTrack::setLanguage):
- html/track/TextTrack.h:
- html/track/TrackBase.cpp:
(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::setKind):
(WebCore::TrackBase::setKindInternal):
- html/track/TrackBase.h:
(WebCore::TrackBase::setLanguage):
(WebCore::TrackBase::sourceBuffer):
(WebCore::TrackBase::setSourceBuffer):
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::VideoTrack):
(WebCore::VideoTrack::setKind):
(WebCore::VideoTrack::setLanguage):
- html/track/VideoTrack.h:
Implement the unimplemented portions of MediaSource and SourceBuffer:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::removeSourceBuffer):
- Modules/mediasource/MediaSourceBase.cpp:
(WebCore::MediaSourceBase::MediaSourceBase):
(WebCore::MediaSourceBase::setPrivateAndOpen):
(WebCore::MediaSourceBase::setReadyState):
(WebCore::MediaSourceBase::attachToElement):
- Modules/mediasource/MediaSourceBase.h:
(WebCore::MediaSourceBase::mediaElement):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::videoTracks):
(WebCore::SourceBuffer::audioTracks):
(WebCore::SourceBuffer::textTracks):
(WebCore::SourceBuffer::sourceBufferPrivateDidAddAudioTrack):
(WebCore::SourceBuffer::sourceBufferPrivateDidAddVideoTrack):
(WebCore::SourceBuffer::sourceBufferPrivateDidAddTextTrack):
(WebCore::SourceBuffer::sourceBufferPrivateDidChangeActiveState):
- Modules/mediasource/SourceBuffer.h:
- Modules/mediasource/SourceBuffer.idl:
Add new files to the project:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
And a smorgasbord of other utility changes:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource): Pass this when attaching.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Ditto.
- html/HTMLMediaSource.h:
- html/track/TextTrackList.cpp:
(TextTrackList::item): Make const.
- html/track/TextTrackList.h:
(WebCore::TextTrackList::lastItem): Added.
- platform/graphics/InbandTextTrackPrivate.h:
(WebCore::InbandTextTrackPrivate::create): Added.
(WebCore::MockSourceBufferPrivate::trackDidChangeEnabled):
- 9:05 PM Changeset in webkit [158820] by
-
- 12 edits in trunk/Source/JavaScriptCore
IC code should handle the call frame register not being the callFrameRegister
https://bugs.webkit.org/show_bug.cgi?id=123865
Reviewed by Geoffrey Garen.
For now, in the FTL, the call frame may be something other than our frame pointer,
since it's an argument passed in according to whatever convention LLVM picks.
This is temporary in two ways - pretty soon the callFrameRegister will be the actual
frame pointer and not some other register, and LLVM will not pass the frame pointer
as an argument to IC's.
- bytecode/StructureStubInfo.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLInlineCacheSize.cpp:
(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArguments):
- jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
- jit/JITInlineCacheGenerator.h:
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
- jit/Repatch.cpp:
(JSC::tryBuildGetByIDList):
(JSC::emitPutTransitionStub):
- 8:43 PM Changeset in webkit [158819] by
-
- 2 edits1 move in trunk/Source/WebKit2
Moved UIProcess/Cocoa to UIProcess/API/Cocoa.
Rubber-stamped by Anders Carlsson.
- UIProcess/API/Cocoa: Copied from Source/WebKit2/UIProcess/Cocoa.
- UIProcess/Cocoa: Removed.
- UIProcess/Cocoa/WKBackForwardList.h: Removed.
- UIProcess/Cocoa/WKBackForwardList.mm: Removed.
- UIProcess/Cocoa/WKBackForwardListInternal.h: Removed.
- UIProcess/Cocoa/WKBackForwardListItem.h: Removed.
- UIProcess/Cocoa/WKBackForwardListItem.mm: Removed.
- UIProcess/Cocoa/WKBackForwardListItemInternal.h: Removed.
- UIProcess/Cocoa/WKBrowsingContextHistoryDelegate.h: Removed.
- UIProcess/Cocoa/WKNavigationData.h: Removed.
- UIProcess/Cocoa/WKNavigationData.mm: Removed.
- UIProcess/Cocoa/WKNavigationDataInternal.h: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- 8:22 PM Changeset in webkit [158818] by
-
- 6 edits5 copies253 moves1 add263 deletes in trunk/LayoutTests
Optimize baselines: svg/W3C-SVG-1.1
Unreviewed; run "webkit-patch optimize-baselines svg/W3C-SVG-1.1"
- platform/efl/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Removed.
- platform/win-future/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt.
- platform/win-future/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt.
- platform/win-future/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt.
- platform/win-future/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt.
- platform/win-future/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt.
- platform/win-future/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt: Renamed from LayoutTests/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt.
- svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt.
- svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt.
- svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt.
- svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt.
- svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt.
- svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt.
- svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt.
- svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt.
- svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt.
- svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt.
- svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt.
- svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt.
- svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt.
- svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt.
- svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt.
- svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt.
- svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt.
- svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt.
- svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt.
- svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt.
- svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt.
- svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt.
- svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt.
- svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt.
- svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt.
- svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt.
- svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt.
- svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt.
- svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt.
- svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt.
- svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt.
- svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt.
- svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt.
- svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt.
- svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt.
- svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt.
- svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt.
- svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt.
- svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt.
- svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt.
- svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt.
- svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt.
- svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt.
- svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt.
- svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt.
- svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt.
- svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt.
- svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt.
- svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt.
- svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt.
- svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt.
- svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt.
- svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt.
- svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt.
- svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt.
- svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt.
- svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt.
- svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt.
- svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt.
- svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt.
- svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt.
- svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt.
- svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt.
- svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt.
- svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt.
- svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt.
- svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt.
- svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt.
- svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt.
- svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt.
- svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt.
- svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt.
- svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt.
- svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt.
- svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt.
- svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt.
- svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt.
- svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt.
- svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt.
- svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt.
- svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt.
- svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt.
- svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt.
- svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt.
- svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt.
- svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt.
- svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt.
- svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt.
- svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt.
- svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt.
- svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt.
- svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt.
- svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt.
- svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt.
- svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt.
- svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt.
- svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt.
- svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt.
- svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt.
- svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt.
- svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt.
- svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt.
- svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt.
- svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt.
- svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt.
- svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt.
- svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt.
- svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt.
- svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt.
- svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt.
- svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt.
- svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt.
- svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt.
- svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt.
- svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt.
- svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt.
- svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
- svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
- svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
- svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
- svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
- svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt.
- svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt.
- svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt.
- svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt.
- svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt.
- svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt.
- svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt.
- svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt.
- svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt.
- svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt.
- svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt.
- svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt.
- svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt.
- svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt.
- svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt.
- svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt.
- svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt.
- svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt.
- svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt.
- svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt.
- svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt.
- svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt.
- svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt.
- svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt.
- svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt.
- svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt.
- svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt.
- svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt.
- svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt.
- svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-01-b-expected.txt.
- svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-02-b-expected.txt.
- svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-03-b-expected.txt.
- svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-04-b-expected.txt.
- svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-05-b-expected.txt.
- svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-06-b-expected.txt.
- svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-08-b-expected.txt.
- svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt.
- svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt.
- svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt.
- svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt.
- svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt.
- svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt.
- svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt.
- svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt.
- svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt.
- svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
- svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-path-01-b-expected.txt.
- svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt.
- svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.txt.
- svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-03-b-expected.txt.
- svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-04-t-expected.txt.
- svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-05-t-expected.txt.
- svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-06-t-expected.txt.
- svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-07-t-expected.txt.
- svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-08-b-expected.txt.
- svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt.
- svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt.
- svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt.
- svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt.
- svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt.
- svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt.
- svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt.
- 7:53 PM Changeset in webkit [158817] by
-
- 2 edits in trunk/Source/WebKit2
[Gtk][EFL] Fix build after r158759
https://bugs.webkit.org/show_bug.cgi?id=123910
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Gyuyoung Kim.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
(WebKit::CoordinatedDrawingAreaProxy::incorporateUpdate): Remove call to flashBackingStoreUpdates().
- 7:49 PM Changeset in webkit [158816] by
-
- 2 edits in trunk/Source/WebInspectorUI
Properly null check positionToReveal in ResourceSidebarPanel.prototype.showSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=123921
Reviewed by Joseph Pecoraro.
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.showSourceCode):
- 7:49 PM Changeset in webkit [158815] by
-
- 3 edits2 adds in trunk
Applied background color is not retained after typing a characters
https://bugs.webkit.org/show_bug.cgi?id=117337
Patch by Vani Hegde <vani.hegde@samsung.com> on 2013-11-06
Reviewed by Ryosuke Niwa.
Source/WebCore:
While deleting a selection, only the inheritable style properties
applied on the selection were saved.
Since background color is considered as noninheritable style property,
on deleting the selection, background color set on it was being lost.
Hence on typing in new text, it would not have the applied
background color set.
Fixed by saving editing preoperties that are already in effect
on a selection before deleting it.
Test: editing/style/background-color-retained.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveTypingStyleState):
Modified as to save EditingPropertiesInEffect on a selection before
deleting it.
LayoutTests:
- editing/style/background-color-retained-expected.txt: Added.
- editing/style/background-color-retained.html: Added.
Test to make sure that background color applied on a
selection is retained after deleting the selection.
- 7:49 PM Changeset in webkit [158814] by
-
- 5 edits1 add in trunk/Websites/test-results
New flakiness dashboard should generate JSON in the background process
https://bugs.webkit.org/show_bug.cgi?id=123797
Reviewed by Alexey Proskuryakov.
- config.json: Add defaultBuildWaitInterval used by process-builds.php.
- init-database.sql: Add is_process column to builds table so that we can track of "unprocessed" builds.
- public/admin/process-builds.php: Added.
(process_latest_five_builds): Update flakiness states and generate JSONs for the latest five builds.
We go backwards in the time so that we don't end up infinite looping over a single build that fails.
(main): Call processed_builds with an exponential back off.
- public/api/report.php:
(store_results): No need to return build or builder ids.
(main): Don't update flakiness states or generate JSONs.
- public/include/test-results.php:
(add_build): Take the slave name; it doesn't make any sense to create a build without it and later
updating it in store_test_results.
(store_test_results): Once new test results are added, explicitly mark this build as unprocessed.
- 7:39 PM Changeset in webkit [158813] by
-
- 1 edit40 moves42 deletes in trunk/LayoutTests
Optimize baselines: svg/W3C-I18N
Unreviewed; run "webkit-patch optimize-baselines svg/W3C-I18N"
- platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Removed.
- platform/gtk/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
- svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt.
- svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt.
- svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt.
- svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt.
- svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt.
- svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt.
- svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt.
- svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt.
- svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt.
- svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt.
- svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt.
- svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt.
- svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt.
- svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt.
- svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt.
- svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt.
- svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt.
- svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt.
- svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt.
- svg/W3C-I18N/text-anchor-no-markup-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt.
- svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt.
- svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt.
- svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt.
- svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt.
- svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt.
- svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt.
- svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt.
- svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt.
- svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt.
- svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt.
- svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt.
- svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt.
- svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt.
- svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt.
- svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt.
- svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt.
- svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt.
- svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt.
- svg/W3C-I18N/tspan-direction-ltr-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt.
- svg/W3C-I18N/tspan-direction-rtl-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt.
- 7:32 PM Changeset in webkit [158812] by
-
- 6 edits in trunk/Source/WebCore
InlineBox: Make paint() and nodeAtPoint() pure virtuals.
<https://webkit.org/b/123937>
...and move the current implementations to InlineElementBox.
All subclasses were already overriding these functions so the move
is completely natural.
Reviewed by Anders Carlsson.
- 7:30 PM Changeset in webkit [158811] by
-
- 8 edits in trunk/Source/WebCore
Nothing should return std::unique_ptr<InlineBox>.
<https://webkit.org/b/123936>
Made RenderBox, RenderLineBreak and RenderListMarker return tightly
typed InlineElementBoxes instead.
Reviewed by Anders Carlsson.
- 7:26 PM Changeset in webkit [158810] by
-
- 4 edits3 copies24 moves2 adds28 deletes in trunk/LayoutTests
Optimize baselines: accessibility
Unreviewed; run "webkit-patch optimize-baselines accessibility"
- accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt.
- accessibility/aria-combobox-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-combobox-expected.txt.
- accessibility/aria-fallback-roles-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-fallback-roles-expected.txt.
- accessibility/aria-labelledby-overrides-aria-label-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-labelledby-overrides-aria-label-expected.txt.
- accessibility/aria-menubar-menuitems-expected.txt:
- accessibility/aria-option-role-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-option-role-expected.txt.
- accessibility/aria-roles-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-roles-expected.txt.
- accessibility/aria-tab-role-on-buttons-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-tab-role-on-buttons-expected.txt.
- accessibility/aria-tables-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-tables-expected.txt.
- accessibility/aria-toggle-button-with-title-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-toggle-button-with-title-expected.txt.
- accessibility/canvas-description-and-role-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/canvas-description-and-role-expected.txt.
- accessibility/canvas-fallback-content-expected.txt:
- accessibility/deleting-iframe-destroys-axcache-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt.
- accessibility/div-within-anchors-causes-crash-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/div-within-anchors-causes-crash-expected.txt.
- accessibility/file-upload-button-stringvalue-expected.txt: Renamed from LayoutTests/platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt.
- accessibility/img-alt-tag-only-whitespace-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/img-alt-tag-only-whitespace-expected.txt.
- accessibility/notification-listeners-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/notification-listeners-expected.txt.
- accessibility/paragraph-with-linebreaks-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/paragraph-with-linebreaks-expected.txt.
- accessibility/svg-image-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/svg-image-expected.txt.
- accessibility/svg-remote-element-expected.txt:
- platform/efl-wk1/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-attributes-expected.txt.
- platform/efl-wk1/accessibility/table-detection-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-detection-expected.txt.
- platform/efl-wk1/accessibility/table-one-cell-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-one-cell-expected.txt.
- platform/efl-wk1/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-sections-expected.txt.
- platform/efl-wk1/accessibility/table-with-rules-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-with-rules-expected.txt.
- platform/efl/accessibility/aria-menubar-menuitems-expected.txt: Removed.
- platform/efl/accessibility/canvas-fallback-content-expected.txt: Removed.
- platform/efl/accessibility/svg-remote-element-expected.txt: Removed.
- platform/gtk-wk1/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-attributes-expected.txt.
- platform/gtk-wk1/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-sections-expected.txt.
- platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Removed.
- platform/gtk/accessibility/aria-combobox-expected.txt: Removed.
- platform/gtk/accessibility/aria-fallback-roles-expected.txt: Removed.
- platform/gtk/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Removed.
- platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Removed.
- platform/gtk/accessibility/aria-option-role-expected.txt: Removed.
- platform/gtk/accessibility/aria-roles-expected.txt: Removed.
- platform/gtk/accessibility/aria-tab-role-on-buttons-expected.txt: Removed.
- platform/gtk/accessibility/aria-tables-expected.txt: Removed.
- platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
- platform/gtk/accessibility/canvas-description-and-role-expected.txt: Removed.
- platform/gtk/accessibility/canvas-fallback-content-expected.txt: Removed.
- platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Removed.
- platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Removed.
- platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Removed.
- platform/gtk/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
- platform/gtk/accessibility/notification-listeners-expected.txt: Removed.
- platform/gtk/accessibility/paragraph-with-linebreaks-expected.txt: Removed.
- platform/gtk/accessibility/svg-image-expected.txt: Removed.
- platform/gtk/accessibility/svg-remote-element-expected.txt: Removed.
- platform/mac/accessibility/aria-fallback-roles-expected.txt: Removed.
- platform/mac/accessibility/aria-menubar-menuitems-expected.txt: Copied from LayoutTests/accessibility/aria-menubar-menuitems-expected.txt.
- platform/mac/accessibility/aria-roles-expected.txt: Removed.
- platform/mac/accessibility/aria-tables-expected.txt: Removed.
- platform/mac/accessibility/canvas-fallback-content-expected.txt: Copied from LayoutTests/accessibility/canvas-fallback-content-expected.txt.
- platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
- platform/mac/accessibility/svg-image-expected.txt: Removed.
- platform/win-future/accessibility/svg-remote-element-expected.txt: Copied from LayoutTests/accessibility/svg-remote-element-expected.txt.
- 6:47 PM Changeset in webkit [158809] by
-
- 6 edits6 copies7 moves11 adds18 deletes in trunk/LayoutTests
Optimize baselines: media
Unreviewed; run "webkit-patch optimize-baselines media"
- media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt:
- media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt:
- media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt:
- media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt:
- media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt:
- media/media-can-play-webm-expected.txt: Renamed from LayoutTests/platform/efl/media/media-can-play-webm-expected.txt.
- media/video-controls-visible-audio-only-expected.txt: Renamed from LayoutTests/platform/efl/media/video-controls-visible-audio-only-expected.txt.
- platform/efl-wk2/media/video-layer-crash-expected.png: Renamed from LayoutTests/platform/efl/media/video-layer-crash-expected.png.
- platform/efl-wk2/media/video-transformed-expected.png: Renamed from LayoutTests/platform/efl/media/video-transformed-expected.png.
- platform/efl-wk2/media/video-zoom-expected.png: Renamed from LayoutTests/platform/efl/media/video-zoom-expected.png.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
- platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
- platform/gtk/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
- platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
- platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
- platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
- platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
- platform/gtk/media/media-can-play-webm-expected.txt: Removed.
- platform/gtk/media/video-controls-visible-audio-only-expected.txt: Removed.
- platform/mac/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Copied from LayoutTests/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt.
- platform/mac/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt.
- platform/mac/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt.
- platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt.
- platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt.
- platform/mac/media/video-controls-visible-audio-only-expected.txt: Removed.
- platform/win-7sp0/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt.
- platform/win-7sp0/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt.
- platform/win-7sp0/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt.
- platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
- platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
- platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
- platform/win/media/media-can-play-ogg-expected.txt: Removed.
- platform/win/media/video-colorspace-yuv420-expected.txt: Removed.
- platform/win/media/video-colorspace-yuv422-expected.txt: Removed.
- platform/win/media/video-size-intrinsic-scale-expected.txt: Removed.
- 6:02 PM Changeset in webkit [158808] by
-
- 4 edits in trunk/Source/WebKit2
Remote Layer Tree: RemoteLayerTreeDrawingArea doesn't make layers for fixedpos elements
https://bugs.webkit.org/show_bug.cgi?id=123943
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
Make fixed position elements create compositing layers and stacking contexts
in the RemoteLayerTreeDrawingArea just like they do in TiledCoreAnimationDrawingArea.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
Fix the comment, since we have long since achieved this goal.
- 5:41 PM Changeset in webkit [158807] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
kTraceBufferLen is unused in default builds
https://bugs.webkit.org/show_bug.cgi?id=123941
<rdar://problem/15409804>
Reviewed by Tim Horton.
kTraceBufferLen is not used in debug.cpp if TRACE_ENABLED is
not defined. This causes a warning in newer builds of clang.
For now, skip warnings on unused variables until we
update from ANGLE.
- src/compiler/debug.cpp: Add unused-variable ignore pragma.
- 5:20 PM Changeset in webkit [158806] by
-
- 2 edits in trunk/Source/WebKit2
Implement enough functionality so that NSURLRequest objects can be decoded
https://bugs.webkit.org/show_bug.cgi?id=123942
Reviewed by Andreas Kling.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder requiresSecureCoding]):
Add new method. Return YES.
(-[WKRemoteObjectDecoder decodeValueOfObjCType:at:]):
Add new method. This currently only handles 'i', but we'll add more variants as needed.
(-[WKRemoteObjectDecoder decodeBoolForKey:]):
Get a WebBoolean from the dictionary and return its value.
- 5:12 PM Changeset in webkit [158805] by
-
- 3 edits in trunk/Source/WebKit2
Encoded object stream should be sequential
https://bugs.webkit.org/show_bug.cgi?id=123939
Reviewed by Andreas Kling.
Reserve space in the object stream for objects that are to be encoded, otherwise
the object stream will not be sequential.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeToObjectStream):
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::entries):
- 4:48 PM Changeset in webkit [158804] by
-
- 2 edits in trunk/Source/WebKit2
Allow property list classes to exist in containers
https://bugs.webkit.org/show_bug.cgi?id=123938
Reviewed by Andreas Kling.
- Shared/API/Cocoa/WKRemoteObjectInterface.mm:
(isContainerClass):
Return whether a given class is a container class.
(propertyListClasses):
Return the set of property list classes.
(allowedArgumentClassesForMethod):
Allow all property list classes for container type arguments.
- 4:39 PM Changeset in webkit [158803] by
-
- 20 edits5 adds in trunk
[iOS] Upstream Letterpress effect
https://bugs.webkit.org/show_bug.cgi?id=123932
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Test: platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress.html
- Configurations/FeatureDefines.xcconfig: Add feature define ENABLE_LETTERPRESS disabled
by default. We only enable letterpress on iOS.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationFlagsToCSSValue): Add support for CSS value -webkit-letterpress.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTextDecoration): Ditto.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextDecoration): Ditto.
- css/CSSValueKeywords.in: Added CSS value -webkit-letterpress.
- platform/graphics/GraphicsContext.h:
- platform/graphics/mac/FontMac.mm:
(WebCore::fillVectorWithHorizontalGlyphPositions): Added.
(WebCore::shouldUseLetterpressEffect): Added.
(WebCore::showLetterpressedGlyphsWithAdvances): Added.
(WebCore::showGlyphsWithAdvances): Modified to call showLetterpressedGlyphsWithAdvances()
to show a letterpressed glyph. I also included additional iOS-specific changes.
(WebCore::Font::drawGlyphs):
- rendering/TextPaintStyle.cpp:
(WebCore::TextPaintStyle::TextPaintStyle):
(WebCore::computeTextPaintStyle): Modified to compute letterpress effect style.
(WebCore::updateGraphicsContext): Modified to apply/unapply letterpress effect drawing mode.
- rendering/TextPaintStyle.h:
- rendering/style/RenderStyleConstants.h:
Source/WebKit/mac:
Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.
- wtf/FeatureDefines.h:
LayoutTests:
- platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress-expected.txt: Added.
- platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress.html: Added.
- platform/iphone-simulator/iphone/resources/getComputedStyle-text-decoration-letterpress.js: Added.
- 4:20 PM Changeset in webkit [158802] by
-
- 3 edits in trunk/Source/WebCore
Crash in SliderThumbElement::dragFrom
https://bugs.webkit.org/show_bug.cgi?id=123873
Reviewed by Sam Weinig.
Moved Ref.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::dragFrom):
- 4:04 PM Changeset in webkit [158801] by
-
- 5 edits1 add in trunk/LayoutTests
LayoutTests/media/track/track-forced-subtitles-in-band.html always times out
https://bugs.webkit.org/show_bug.cgi?id=123412
Reviewed by Jer Noble.
- media/content/CC+Subtitles.mov: Added.
- media/track/track-forced-subtitles-in-band.html: Fail loudly if the caption track menu is
not found by the helper function. Wait for both 'seeked' and 'cuechange' events before
checking activeCues.
- media/trackmenu-test.js:
(getTrackListElement): Correct the caption menu pseudo-id.
(trackMenuList): Complain when the track menu is not found.
- platform/mac/TestExpectations: Remove track-forced-subtitles-in-band.html.
- 4:00 PM Changeset in webkit [158800] by
-
- 2 edits in trunk/Source/WebCore
Cleanup FontMac.mm
https://bugs.webkit.org/show_bug.cgi?id=123928
Reviewed by Andy Estes.
- platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances): Inline the value of variable isVertical as we
reference it exactly once and its value is sufficiently clear.
(WebCore::Font::drawGlyphs): Remove default case in switch block so that the compiler
checks that all cases are covered. Move definition of platformData to the top of the
function and use it whenever we want to access the platform font data
- 3:53 PM Changeset in webkit [158799] by
-
- 2 edits in trunk/Source/WebKit2
Fixed multiple API test failures after r158764.
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(setUpPagePolicyClient): If the delegate isn’t set or doesn’t respond to a selector, respond
with WKFramePolicyListenerUse().
- 3:08 PM Changeset in webkit [158798] by
-
- 5 edits in trunk/Source/WebCore
[WebGL] We should not allow generateMipMap on compressed textures
https://bugs.webkit.org/show_bug.cgi?id=123915
<rdar://problem/15201274>
Reviewed by Dean Jackson.
Found by existing conformance/extensions/webgl-compressed-texture-s3tc.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::compressedTexImage2D): Set compressed flag.
(WebCore::WebGLRenderingContext::compressedTexSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::generateMipmap): For Apple builds, check state
of compressed flag and generate appropriate WebGL error if necessary.
- html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::WebGLTexture): Set compressed flag to false by default
(WebCore::WebGLTexture::isCompressed): Added
(WebCore::WebGLTexture::setCompressed): Added
- html/canvas/WebGLTexture.h:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::generateMipmap): Switch implementation to use proper
glGenerateMipmaps, rather than the glGenerateMipmapsEXT method.
- 3:04 PM Changeset in webkit [158797] by
-
- 2 edits in trunk/Source/WebKit2
Move allowed classes handling to decodeObject
https://bugs.webkit.org/show_bug.cgi?id=123930
Reviewed by Andreas Kling.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(decodeObjectFromObjectStream):
Pass allowed classes through to decodeObject.
(decodeObject):
Update to take an NSSet of allowed classes. If the set is nil, use the current set.
(-[WKRemoteObjectDecoder decodeObjectOfClasses:forKey:]):
Pass classes to decodeObject.
- 2:44 PM Changeset in webkit [158796] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Changes to CodeGeneratorInspectorStrings.py should rebuild inspector generated files
https://bugs.webkit.org/show_bug.cgi?id=123925
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-06
Reviewed by Timothy Hatcher.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- 2:40 PM Changeset in webkit [158795] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged rr157966. <rdar://problem/15406689>
- 2:37 PM Changeset in webkit [158794] by
-
- 3 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r156675. <rdar://problem/15406691>
- 2:37 PM Changeset in webkit [158793] by
-
- 14 edits9 adds in trunk
Support iteration of the Arguments object
https://bugs.webkit.org/show_bug.cgi?id=123835
Reviewed by Mark Lam.
Source/JavaScriptCore:
Add an ArgumentsIterator object, and associated classes so that we can support
iteration of the arguments object.
This is a largely mechanical patch. The only gnarliness is in the
logic to avoid reifying the Arguments object in for(... of arguments)
scenarios.
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitEnumeration):
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::argumentsFuncIterator):
- runtime/Arguments.h:
- runtime/ArgumentsIteratorConstructor.cpp: Added.
(JSC::ArgumentsIteratorConstructor::finishCreation):
- runtime/ArgumentsIteratorConstructor.h: Added.
(JSC::ArgumentsIteratorConstructor::create):
(JSC::ArgumentsIteratorConstructor::createStructure):
(JSC::ArgumentsIteratorConstructor::ArgumentsIteratorConstructor):
- runtime/ArgumentsIteratorPrototype.cpp: Added.
(JSC::ArgumentsIteratorPrototype::finishCreation):
(JSC::argumentsIteratorPrototypeFuncIterator):
(JSC::argumentsIteratorPrototypeFuncNext):
- runtime/ArgumentsIteratorPrototype.h: Added.
(JSC::ArgumentsIteratorPrototype::create):
(JSC::ArgumentsIteratorPrototype::createStructure):
(JSC::ArgumentsIteratorPrototype::ArgumentsIteratorPrototype):
- runtime/CommonIdentifiers.h:
- runtime/JSArgumentsIterator.cpp: Added.
(JSC::JSArgumentsIterator::finishCreation):
- runtime/JSArgumentsIterator.h: Added.
(JSC::JSArgumentsIterator::createStructure):
(JSC::JSArgumentsIterator::create):
(JSC::JSArgumentsIterator::next):
(JSC::JSArgumentsIterator::JSArgumentsIterator):
- runtime/JSArrayIterator.cpp:
(JSC::createIteratorResult):
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
LayoutTests:
Add test cases
- js/arguments-iterator-expected.txt: Added.
- js/arguments-iterator.html: Added.
- js/script-tests/arguments-iterator.js: Added.
(shouldThrow.test):
(testAlias):
(testStrict):
(testReifiedArguments):
(testOverwrittenArguments):
(testNullArguments):
(testNonArrayLikeArguments):
- 2:37 PM Changeset in webkit [158792] by
-
- 2 edits in trunk/Source/WebKit2
Fix EFL build after r158753
https://bugs.webkit.org/show_bug.cgi?id=123923
r158753 renamed WKNavigationData.h as WKNavigationDataRef.h, so
update it in UIProcess/API/efl/ewk_navigation_data_private.h.
Patch by Sergio Correia <Sergio Correia> on 2013-11-06
Reviewed by Csaba Osztrogonác.
- UIProcess/API/efl/ewk_navigation_data_private.h:
- 2:31 PM Changeset in webkit [158791] by
-
- 4 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154550. <rdar://problem/15406685>
- 2:29 PM Changeset in webkit [158790] by
-
- 2 edits in trunk/Source/WebInspectorUI
Fix the display of query parameters when the value is missing.
https://bugs.webkit.org/show_bug.cgi?id=123920
Reviewed by Joseph Pecoraro.
- UserInterface/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel.prototype._createNameValueDataGrid):
- 2:27 PM Changeset in webkit [158789] by
-
- 1 edit in branches/safari-537.73-branch/Source/WebInspectorUI/UserInterface/External/CodeMirror/codemirror.js
Merge patch for <rdar://problem/15406685>.
- 2:08 PM Changeset in webkit [158788] by
-
- 8 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: CSS Regions: When a flow is clicked the content of flow needs to be displayed
https://bugs.webkit.org/show_bug.cgi?id=122927
Reviewed by Joseph Pecoraro.
ContentFlowTreeContentView is now used to display the content nodes of a ContentFlow. It is
very similar to the DOMTreeContentView class, but can handle multiple root nodes.
- UserInterface/ContentFlowTreeContentView.js: Added.
(WebInspector.ContentFlowTreeContentView):
(WebInspector.ContentFlowTreeContentView.prototype.get selectionPathComponents):
(WebInspector.ContentFlowTreeContentView.prototype.updateLayout):
(WebInspector.ContentFlowTreeContentView.prototype.shown):
(WebInspector.ContentFlowTreeContentView.prototype.hidden):
(WebInspector.ContentFlowTreeContentView.prototype.closed):
(WebInspector.ContentFlowTreeContentView.prototype._selectedNodeDidChange):
(WebInspector.ContentFlowTreeContentView.prototype._pathComponentSelected):
(WebInspector.ContentFlowTreeContentView.prototype._createContentNodeTree):
(WebInspector.ContentFlowTreeContentView.prototype._createContentTrees):
(WebInspector.ContentFlowTreeContentView.prototype._contentNodeWasAdded):
(WebInspector.ContentFlowTreeContentView.prototype._contentNodeWasRemoved):
- UserInterface/ContentView.js:
(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
- UserInterface/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.ondeselect): We need to remove the selected "dom node"
so that the element is not going to stay selected after the we move to a different DOM tree.
- UserInterface/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype.selectDOMNode):
- UserInterface/Main.html:
- UserInterface/Main.js:
(WebInspector.sidebarPanelForRepresentedObject):
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
- 2:04 PM Changeset in webkit [158787] by
-
- 17 edits4 copies in branches/safari-537.73-branch
Merged r158617. <rdar://problem/15391030>
- 1:57 PM Changeset in webkit [158786] by
-
- 2 edits in trunk/LayoutTests
Fix test case
- 1:54 PM Changeset in webkit [158785] by
-
- 2 edits in trunk/LayoutTests
Remove the flaky test expectation after r158720 now that the test is not flaky.
- platform/mac/TestExpectations:
- 1:52 PM Changeset in webkit [158784] by
-
- 2 edits in trunk/Source/WebKit2
Implement more decoding methods
https://bugs.webkit.org/show_bug.cgi?id=123922
Reviewed by Dan Bernstein.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectDecoder decodeObjectForKey:]):
Call decodeObjectOfClasses:forKey: passing nil as the classes set.
(-[WKRemoteObjectDecoder decodeInt64ForKey:]):
Try to get a WebUInt64 and return its value.
(-[WKRemoteObjectDecoder decodeDoubleForKey:]):
Try to get a WebDouble and return its value.
(-[WKRemoteObjectDecoder decodeBytesForKey:returnedLength:]):
Move this method next to the other decoding methods.
(-[WKRemoteObjectDecoder requiresSecureCoding]):
Ditto.
- 1:39 PM Changeset in webkit [158783] by
-
- 2 edits in trunk/Source/WTF
Disable "unused local typedefs" warning for GCC 4.7
https://bugs.webkit.org/show_bug.cgi?id=123913
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-06
Reviewed by Martin Robinson.
That warning was actually introduced in gcc 4.7.0.
See: http://gcc.gnu.org/gcc-4.7/changes.html
- wtf/Compiler.h:
- 1:31 PM Changeset in webkit [158782] by
-
- 6 edits in trunk/Source/WebKit2
[Gtk][EFL] Fix build after r158759
https://bugs.webkit.org/show_bug.cgi?id=123910
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/PageClientImpl.cpp: Remove flashBackingStoreUpdates().
- UIProcess/API/gtk/PageClientImpl.h: Same.
- UIProcess/CoordinatedGraphics/WebView.cpp: Same.
- UIProcess/CoordinatedGraphics/WebView.h: Same.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Don't call flashBackingStoreUpdates().
- 1:21 PM Changeset in webkit [158781] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed Mac build fix; include ResourceResponse.
- Shared/WebNavigationDataStore.h:
- 1:17 PM Changeset in webkit [158780] by
-
- 3 edits in trunk/Source/WebKit2
Decode invocation arguments
https://bugs.webkit.org/show_bug.cgi?id=123917
Reviewed by Sam Weinig.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectDecoder initWithInterface:rootObjectDictionary:WebKit::]):
Initialize the object stream.
(decodeObjectFromObjectStream):
Check that we're not reading past the end of the stream, then decode the object.
(decodeInvocationArguments):
Decode arguments from the object stream.
(decodeInvocation):
Call decodeInvocationArguments and set up the selector argument.
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::at):
(WebKit::ImmutableArray::size):
(WebKit::ImmutableArray::entries):
Constify.
- 12:56 PM Changeset in webkit [158779] by
-
- 6 edits in trunk/Source/WebKit2
[Cocoa] Add -[WKNavigationData response]
https://bugs.webkit.org/show_bug.cgi?id=123918
Reviewed by Sam Weinig.
- Shared/WebNavigationDataStore.h: Added a ResourceResponse data member.
(WebKit::WebNavigationDataStore::encode): Encode the response.
(WebKit::WebNavigationDataStore::decode): Decode the response.
- UIProcess/Cocoa/WKNavigationData.h: Declared new property.
- UIProcess/Cocoa/WKNavigationData.mm:
(-[WKNavigationData response]): Added.
- UIProcess/WebNavigationData.h:
(WebKit::WebNavigationData::response): Added.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateGlobalHistory): Set the response in the data store.
- 12:49 PM Changeset in webkit [158778] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r158629. <rdar://problem/15391028>
- 12:49 PM Changeset in webkit [158777] by
-
- 4 edits in trunk/Source/WebCore
Rename region line offset methods
https://bugs.webkit.org/show_bug.cgi?id=123897
Reviewed by Sam Weinig.
Because of the large number of overloads on the line offset methods,
it is very hard to read code using them, which also makes it harder to
move them out of RenderBlock. This patch renames the methods that take
a region as an argument to make it clearer when looking at the code
how the differ from the ones that don't.
No new tests, no behavior change.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLineInRegion):
(WebCore::RenderBlock::logicalRightOffsetForLineInRegion):
(WebCore::RenderBlock::logicalLeftOffsetForLineInRegion):
(WebCore::RenderBlock::startOffsetForLineInRegion):
(WebCore::RenderBlock::endOffsetForLineInRegion):
(WebCore::RenderBlock::availableLogicalWidthForLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
- 12:49 PM Changeset in webkit [158776] by
-
- 3 edits in trunk/Source/WebKit2
Fix the 32-bit build.
- UIProcess/API/mac/WKBrowsingContextController.h:
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController _initWithPageRef:]):
- 12:48 PM Changeset in webkit [158775] by
-
- 5 edits in trunk/Source/WebKit2
[Cocoa] Add -[WKBrowsingContextController unreachableURL]
https://bugs.webkit.org/show_bug.cgi?id=123909
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKBrowsingContextController.h: Declared unreachableURL property.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController unreachableURL]): Added.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unreachableURL): Added.
- UIProcess/WebPageProxy.h:
- 12:38 PM Changeset in webkit [158774] by
-
- 8 edits in trunk/Source/WebCore
HTMLCollection should use CollectionIndexCache
https://bugs.webkit.org/show_bug.cgi?id=123906
Reviewed by Ryosuke Niwa.
More code sharing.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
- dom/ChildNodeList.h:
- dom/CollectionIndexCache.h:
(WebCore::::nodeBeforeCached):
(WebCore::::nodeAfterCached):
(WebCore::::nodeAt):
Add a mechanism for disabling use of backward traversal.
- dom/LiveNodeList.h:
(WebCore::LiveNodeList::collectionCanTraverseBackward):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::isMatchingElement):
(WebCore::HTMLCollection::iterateForPreviousElement):
(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::nameShouldBeVisibleInDocumentAll):
(WebCore::firstMatchingChildElement):
(WebCore::nextMatchingSiblingElement):
(WebCore::HTMLCollection::firstElement):
(WebCore::HTMLCollection::traverseForward):
(WebCore::HTMLCollection::collectionFirst):
(WebCore::HTMLCollection::collectionLast):
(WebCore::HTMLCollection::collectionTraverseForward):
(WebCore::HTMLCollection::collectionTraverseBackward):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
- html/HTMLCollection.h:
(WebCore::HTMLCollection::collectionCanTraverseBackward):
Disable use of backward traversal for collections that use custom traversal.
- 12:32 PM Changeset in webkit [158773] by
-
- 4 edits3 adds in trunk
DFG CheckArray(NonArray) should prove that the child isn't an array
https://bugs.webkit.org/show_bug.cgi?id=123911
<rdar://problem/15202803>
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::isArrayType):
LayoutTests:
- js/dfg-check-array-non-array-expected.txt: Added.
- js/dfg-check-array-non-array.html: Added.
- js/script-tests/dfg-check-array-non-array.js: Added.
(foo):
(bar):
(baz):
- 12:31 PM Changeset in webkit [158772] by
-
- 2 edits in trunk/Source/WebKit2
Encode parameters as objects
https://bugs.webkit.org/show_bug.cgi?id=123912
Reviewed by Beth Dakin.
We want to ensure that the objects have the right types when decoded, so just encode them as objects.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeInvocation):
(-[WKRemoteObjectEncoder encodeValueOfObjCType:at:]):
- 12:27 PM Changeset in webkit [158771] by
-
- 6 edits in branches/safari-537.73-branch/Source/WebKit2
Merged r154763. <rdar://problem/15401612>
- 12:23 PM Changeset in webkit [158770] by
-
- 2 edits in branches/safari-537.73-branch/LayoutTests
Merged r158766. <rdar://problem/15390971>
- 12:22 PM Changeset in webkit [158769] by
-
- 5 edits in branches/safari-537.73-branch/Source/WebCore
Merged r155997. <rdar://problem/15390971>
- 12:20 PM Changeset in webkit [158768] by
-
- 3 edits in branches/safari-537.73-branch/WebKitLibraries
Merged r155996. <rdar://problem/15390971>
- 12:16 PM Changeset in webkit [158767] by
-
- 2 edits in trunk/Tools
Unreviewed webkitpy unit test fix; update baselines after r158765
- Scripts/webkitpy/port/win_unittest.py:
(WinPortTest.test_baseline_search_path):
- 12:10 PM Changeset in webkit [158766] by
-
- 2 edits in branches/safari-537.60-branch/LayoutTests
Merged r154392. <rdar://problem/15390971>
- 11:53 AM Changeset in webkit [158765] by
-
- 2 edits in trunk/Tools
[Win] run-webkit-tests on the win platform should fall back to mac-mountainlion, not mac-lion.
https://bugs.webkit.org/show_bug.cgi?id=123905
Reviewed by Brent Fulgham.
Now that the mac-lion results have been removed, the win port should fall back to
the mac-mountainlion results.
- Scripts/webkitpy/port/win.py:
(WinPort.default_baseline_search_path):
- 11:42 AM Changeset in webkit [158764] by
-
- 5 edits1 add in trunk/Source/WebKit2
Add WKBrowsingContextPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=123904
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKBrowsingContextController.h:
- UIProcess/API/mac/WKBrowsingContextController.mm:
Implement a WKPagePolicyClient in terms of the new WKBrowsingContextPolicyDelegate protocol.
- UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:
Added.
- UIProcess/API/mac/WebKit2.h:
Add new #include of WKBrowsingContextPolicyDelegate.h
- WebKit2.xcodeproj/project.pbxproj:
Add new file.
- 11:23 AM Changeset in webkit [158763] by
-
- 3 edits in trunk/Source/WebKit2
WKRemoteObjectInterface should keep track of allowed decodable classes
https://bugs.webkit.org/show_bug.cgi?id=123903
Reviewed by Sam Weinig.
- Shared/API/Cocoa/WKRemoteObjectInterface.mm:
(allowedArgumentClassesForMethod):
Helper function that returns a vector of sets of allowed classes for each method argument.
(initializeAllowedArgumentClasses):
Iterate over the methods in the protocol, get the extended method type encoding and create an
NSMethodSignature from it. Finally, pass the signature to allowedArgumentClassesForMethod.
(initializeAllowedArgumentClasses):
Call the other initializeAllowedArgumentClasses twice, once for required methods,
and once for optional methods.
(-[WKRemoteObjectInterface initWithProtocol:identifier:]):
Call initializeAllowedArgumentClasses.
(-[WKRemoteObjectInterface _allowedArgumentClassesForSelector:]):
Add new getter.
- Shared/API/Cocoa/WKRemoteObjectInterfaceInternal.h:
- 11:21 AM Changeset in webkit [158762] by
-
- 4 edits in trunk/Source/JavaScriptCore
JSExport doesn't support constructors
https://bugs.webkit.org/show_bug.cgi?id=123380
Reviewed by Geoffrey Garen.
Needed another linked-on-or-after check for when we're deciding whether
we should copy over init family methods.
Factored out the link time checks into a separate function so that they can be cached.
Factored out the check for init-family method selectors into helper function and changed it to
match the description in the clang docs, namely that there can be underscores at the beginning
and the first letter after 'init' part of the selector (if there is one) must be a capital letter.
Updated tests to make sure we don't treat "initialize" as an init-family method and that we do
treat "_init" as an init-family method.
- API/JSWrapperMap.h:
- API/JSWrapperMap.mm:
(isInitFamilyMethod):
(shouldSkipMethodWithName):
(copyMethodsToObject):
(allocateConstructorForCustomClass):
(supportsInitMethodConstructors):
- API/tests/testapi.mm:
(-[ClassA initialize]):
(-[ClassD initialize]):
- 11:01 AM Changeset in webkit [158761] by
-
- 2 edits in trunk/Tools
Fix a Mountain Lion test failure.
NSURLRequest doesn't conform to NSSecureCoding on Mountain Lion, so don't try to test encoding it.
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
(TestWebKitAPI::TEST):
- 10:54 AM WebInspector edited by
- (diff)
- 10:53 AM Changeset in webkit [158760] by
-
- 17 edits2 adds in trunk
Add "id" attribute to TextTrack
https://bugs.webkit.org/show_bug.cgi?id=123825
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-id.html
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::addTextTrack): Add emptyString() for track id.
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::AudioTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::AudioTrack::idChanged): Added, set id.
- html/track/AudioTrack.h: Move m_id to TrackBase.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::InbandTextTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::InbandTextTrack::idChanged): Added, set id.
- html/track/InbandTextTrack.h: Add idChanged().
- html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::LoadableTextTrack): Add emptyString() for track id.
(WebCore::LoadableTextTrack::id): Override to return the track element's id.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::captionMenuOffItem): Add empty string for track id.
(WebCore::TextTrack::captionMenuAutomaticItem): Add empty string for track id.
(WebCore::TextTrack::TextTrack): Pass id to TrackBase.
- html/track/TextTrack.h:
(WebCore::TextTrack::create): Add id parameter.
- html/track/TextTrack.idl: Add id attribute.
- html/track/TrackBase.cpp:
(WebCore::TrackBase::TrackBase): Add m_id.
- html/track/TrackBase.h: Add id attribute / m_id.
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::VideoTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::VideoTrack::idChanged): Added, set id.
- html/track/VideoTrack.h: Move m_id to TrackBase.
- platform/graphics/TrackPrivateBase.h: Add idChanged() callback.
LayoutTests:
- media/track/track-id-expected.txt: Added.
- media/track/track-id.html: Added.
- 10:51 AM Changeset in webkit [158759] by
-
- 8 edits in trunk/Source/WebKit2
Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=123902
Reviewed by Tim Horton.
Remove the PageClient::containingWindowGraphicsContext() as well as the
WKPageSetDebugPaintFlags and WKPageGetDebugPaintFlags API functions.
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::searchTheWeb):
- 10:18 AM Changeset in webkit [158758] by
-
- 10 edits in trunk/Source/WebCore
Move array position caching out from HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=123895
Reviewed by Darin Adler.
This caching complicates the logic but is used by a single subclass
(HTMLFormControlsCollection) only. The subclass can do the caching itself.
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::HTMLAllCollection):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::elementBeforeOrAfterCachedElement):
(WebCore::HTMLCollection::firstElement):
Renamed from traverseFirstElement.
(WebCore::HTMLCollection::traverseForwardToOffset):
(WebCore::HTMLCollection::invalidateCache):
Make cache invalidation virtual so we can clear HTMLTableRowsCollection index cache.
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):
Use traverseForwardToOffset instead traverseNextElement. This allows removal of traverseNextElement.
- html/HTMLCollection.h:
(WebCore::HTMLCollection::usesCustomForwardOnlyTraversal):
Renamed the enum and the accessor to be more informative.
(WebCore::HTMLCollection::setCachedElement):
(WebCore::HTMLCollection::customElementAfter):
Renamed from virtualItemAfter.
- html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::findFormAssociatedElement):
(WebCore::HTMLFormControlsCollection::customElementAfter):
Move the array position caching logic here.
(WebCore::HTMLFormControlsCollection::invalidateCache):
- html/HTMLFormControlsCollection.h:
- html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::HTMLNameCollection):
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::customElementAfter):
- html/HTMLTableRowsCollection.h:
- 10:17 AM Changeset in webkit [158757] by
-
- 6 edits in trunk
[ATK] accessibility/title-ui-element-correctness.html fails
https://bugs.webkit.org/show_bug.cgi?id=99825
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When calling setAtkRelationSetFromCoreObject a new ATK_LABELLED_BY_RELATION
is added, adding proper label element as a relation. When the document structure
has been changed and a different label should be linked as a relation, current ATK
implementation adds it as a next target on relation's target list, while
WTR/DumpRenderTree implementation takes only first one into account.
This patch adds a new function removing current relations before adding new ones.
Covered by existing tests.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(removeAtkRelationFromRelationSetByType):
(setAtkRelationSetFromCoreObject):
LayoutTests:
Remove failure test expectation for the test fixed by this patch.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 10:12 AM Changeset in webkit [158756] by
-
- 2 edits in trunk/Source/WebKit2
Promoted WKBrowsingContextHistoryDelegate.h to private.
Rubber-stamped by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj:
- 10:00 AM WebInspectorCodingStyleGuide edited by
- (diff)
- 9:57 AM WebInspectorCodingStyleGuide edited by
- (diff)
- 9:56 AM WebInspectorCodingStyleGuide created by
- 9:43 AM Changeset in webkit [158755] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Media elements wrongly exposed after r158743.
- platform/gtk/TestExpectations: Added failure expectations.
- 9:39 AM Changeset in webkit [158754] by
-
- 4 edits8 adds in trunk/LayoutTests
[ATK] Providing new table related accessibility expectations after r158742
https://bugs.webkit.org/show_bug.cgi?id=123893
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Chris Fleizach.
New baselines after added missing implementation in r158742.
- platform/efl-wk1/TestExpectations: Tests are no longer failing.
- platform/efl-wk2/TestExpectations: Tests are no longer failing.
- platform/efl-wk2/accessibility/table-attributes-expected.txt: Added.
- platform/efl-wk2/accessibility/table-sections-expected.txt: Added.
- platform/efl/accessibility/table-attributes-expected.txt: Added.
- platform/efl/accessibility/table-sections-expected.txt: Added.
- platform/gtk-wk2/accessibility/table-attributes-expected.txt: Added.
- platform/gtk-wk2/accessibility/table-sections-expected.txt: Added.
- platform/gtk/TestExpectations: Tests are no longer failing.
- platform/gtk/accessibility/table-attributes-expected.txt: Added.
- platform/gtk/accessibility/table-sections-expected.txt: Added.
- 9:36 AM Changeset in webkit [158753] by
-
- 10 edits2 moves4 adds in trunk/Source/WebKit2
[Cocoa] History delegate
https://bugs.webkit.org/show_bug.cgi?id=123837
Reviewed by Sam Weinig.
- Shared/Cocoa/APIObject.mm:
(WebKit::APIObject::newObject): Allocate a WKNavigationData if the object is a
WebNavigationData.
- Shared/Cocoa/WKNSString.h:
(WebKit::wrapper): Added. Returns a WebString’s wrapper as an NSString.
- Shared/Cocoa/WKNSURL.h:
(WebKit::wrapper): Added. Returns a WebURL’s wrapper as an NSURL.
- UIProcess/API/C/WKNavigationData.cpp: Renamed.
- UIProcess/API/C/WKNavigationData.h: Renamed.
- UIProcess/API/C/WKNavigationDataRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp.
- UIProcess/API/C/WKNavigationDataRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKNavigationData.h.
- UIProcess/API/mac/WKBrowsingContextController.h: Declared historyDelegate property.
- UIProcess/API/mac/WKProcessGroup.mm:
(didNavigateWithNavigationData): Added history client callback that calls the browsing
context’s history delegate.
(didPerformClientRedirect): Ditto.
(didPerformServerRedirect): Ditto.
(didUpdateHistoryTitle): Ditto.
(setUpHistoryClient): Added.
(-[WKProcessGroup initWithInjectedBundleURL:]): Added call to setUpHistoryClient.
(-[WKProcessGroup dealloc]): Clear the history client.
- UIProcess/Cocoa/WKBrowsingContextHistoryDelegate.h: Added.
- UIProcess/Cocoa/WKNavigationData.h: Added.
- UIProcess/Cocoa/WKNavigationData.mm: Added.
(-[WKNavigationData dealloc]): Calls the WebNavigationData destructor.
(-[WKNavigationData title]): Added.
(-[WKNavigationData originalRequest]): Added.
(-[WKNavigationData destinationURL]): Added.
(-[WKNavigationData _apiObject]): Returns the wrapped WebNavigationData.
- UIProcess/Cocoa/WKNavigationDataInternal.h: Added.
(WebKit::wrapper): Added. Returns a WebNavigationData’s wrapper as a WKNavigationData.
- WebKit2.xcodeproj/project.pbxproj: Updated for renames and additions.
- 9:31 AM WebKitGTK/2.2.x edited by
- Add two proposed merges for the next 2.2 release. (diff)
- 9:31 AM Changeset in webkit [158752] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening; Fix expected results for video-seek-with-negative-playback.html,
and modify the test to conform to media test style.
- media/video-seek-with-negative-playback-expected.txt:
- media/video-seek-with-negative-playback.html:
- 9:29 AM Changeset in webkit [158751] by
-
- 18 edits3 deletes in trunk/Source/JavaScriptCore
Change ctiTrampoline into a thunk
https://bugs.webkit.org/show_bug.cgi?id=123844
Reviewed by Filip Pizlo.
Converted ctiTrampoline and ctiOpThrowNotCaught into thunks named callToJavaScript
and returnFromJavaScript. Cleaned up and in some cases removed JITStubsXXX.h files
after removing ctiTrampoline and ctiOpThrowNotCaught. Added callJavaScriptJITFunction
to VM that is a function pointer to the callToJavaScript thunk.
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- jit/JITCode.cpp:
(JSC::JITCode::execute):
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JITStubsARM.h:
- jit/JITStubsARM64.h: Removed.
- jit/JITStubsARMv7.h:
- jit/JITStubsMIPS.h: Removed.
- jit/JITStubsMSVC64.asm:
- jit/JITStubsSH4.h: Removed.
- jit/JITStubsX86.h:
- jit/JITStubsX86_64.h:
- jit/JSInterfaceJIT.h:
- jit/ThunkGenerators.cpp:
(JSC::returnFromJavaScript):
(JSC::callToJavaScript):
- jit/ThunkGenerators.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 8:48 AM Changeset in webkit [158750] by
-
- 7 edits in trunk/Source
Add ENABLE(TEXT_SELECTION)
https://bugs.webkit.org/show_bug.cgi?id=123827
Reviewed by Ryosuke Niwa.
Source/WebCore:
Add compile-time guard, ENABLE(TEXT_SELECTION), to enable or
disable selection painting in WebCore (enabled by default).
On iOS we disable WebCore selection painting and have UIKit
paint the selection.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection): Only paint selection when
TEXT_SELECTION is enabled.
- rendering/LogicalSelectionOffsetCaches.h:
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
For now, add a ENABLE(TEXT_SELECTION)-guard around an assertion. Added
a FIXME comment to investigate the callers and either move the assertion
to the appropriate callers or structure the code such that we can remove
the assertion.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintSelection): Only paint selection when
TEXT_SELECTION is enabled.
- rendering/TextPaintStyle.cpp:
(WebCore::computeTextSelectionPaintStyle): Only compute the selection
paint style when TEXT_SELECTION is enabled. Otherwise, return a paint
style identical to the text paint style. Also, substitute nullptr for 0.
Source/WTF:
Enable selection painting by default on all ports except iOS.
- wtf/FeatureDefines.h:
- 8:45 AM Changeset in webkit [158749] by
-
- 2 edits in trunk/Source/WebCore
Unrevewied Windows build fix after r158736; add InlineElementBox.cpp to the RenderingAllInOne.cpp file.
- rendering/RenderingAllInOne.cpp:
- 8:38 AM Changeset in webkit [158748] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL should support StringCharCodeAt
https://bugs.webkit.org/show_bug.cgi?id=123854
Reviewed by Sam Weinig.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileStringCharCodeAt):
- 8:36 AM Changeset in webkit [158747] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix, style() return type is now a reference.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionFromStyle):
- 8:26 AM Changeset in webkit [158746] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed 32-bit Mac build fix; use an explicit FloatSize -> IntSize conversion function.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
- 8:15 AM Changeset in webkit [158745] by
-
- 6 edits in trunk/Source/WebCore
Playing many sounds with HTML5 Audio makes WebKit unresponsive
https://bugs.webkit.org/show_bug.cgi?id=116145
Reviewed by Eric Carlson.
Cache as much information as possible from AVPlayerItem to eliminate unneccesary
calls into AVFoundation.
Add WillChange/DidChange functions to handle the results of KVO notifications
from AVPlayerItem and AVPlayer:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatusDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackLikelyToKeepUpWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackLikelyToKeepUpDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferEmptyWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferEmptyDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferFullWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferFullDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasEnabledAudioDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::presentationSizeDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::durationDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::rateDidChange):
(WebCore::itemKVOProperties):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
Instruct the HTMLMediaElement to cache the currentTime value for 5 seconds:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(WebCore::MediaPlayerPrivateAVFoundationObjC::maximumDurationToCacheMediaTime):
Add and initialize member variables to hold these cached values:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):
Add a new Notification type which can take (and call) a Function object:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification):
(WebCore::MediaPlayerPrivateAVFoundation::Notification::function):
Implement queries in terms of the cached values of AVPlayerItem and AVPlayer
properties:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
(WebCore::MediaPlayerPrivateAVFoundationObjC::rate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMinTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationObjC::totalBytes):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks):
Invalidate the cached currentTime before calling scheduleTimeUpdate so that the
correct movieTime is saved in m_clockTimeAtLastUpdateEvent:
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::setReadyState):
- 7:54 AM Changeset in webkit [158744] by
-
- 18 edits4 adds in trunk
[CSS Grid Layout] Add support for named grid areas
https://bugs.webkit.org/show_bug.cgi?id=120045
Reviewed by Andreas Kling.
From Blink r155555, r155850 and r155889 by <jchaffraix@chromium.org>
Source/WebCore:
Added support for named grid areas. Basically a named grid area is
now a valid grid position. The shorthand parsing of grid-area was
split from the grid-{row|column} as the rules for expanding are
slightly different.
Unknown grid area names are treated as 'auto' as per the
specification. This means that for those cases we need to trigger
the auto-placement algorithm.
Tests: fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html
fast/css-grid-layout/grid-item-named-grid-area-resolution.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridPosition):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridPosition):
(WebCore::gridMissingGridPositionValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):
(WebCore::CSSParser::parseGridAreaShorthand):
(WebCore::CSSParser::parseSingleGridAreaLonghand):
- css/CSSParser.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustGridItemPosition):
(WebCore::createGridPosition):
- css/StyleResolver.h:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionFromStyle):
- rendering/style/GridPosition.h:
(WebCore::GridPosition::isNamedGridArea):
(WebCore::GridPosition::setNamedGridArea):
(WebCore::GridPosition::namedGridLine):
LayoutTests:
Added a couple of new tests to check that both known and unknown
named grid areas are properly handled.
Also extended some of the existing tests to use named grid areas
as any other possible grid position.
- fast/css-grid-layout/grid-item-area-get-set-expected.txt:
- fast/css-grid-layout/grid-item-area-get-set.html:
- fast/css-grid-layout/grid-item-bad-named-area-auto-placement-expected.txt: Added.
- fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html: Added.
- fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
- fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
- fast/css-grid-layout/grid-item-end-after-get-set.html:
- fast/css-grid-layout/grid-item-named-grid-area-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-item-named-grid-area-resolution.html: Added.
- fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
- fast/css-grid-layout/grid-item-start-before-get-set.html:
- fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js:
- 6:15 AM Changeset in webkit [158743] by
-
- 442 edits4 adds in trunk
AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Video and audio elements don't appear as distinct objects in the AX hierarchy,
nor are they treated as replaceable objects when emitting the text. We should
treat these characters like attachments, for one. On the Mac platform, we should
also identify them with special subroles.
Tests: platform/mac/accessibility/media-emits-object-replacement.html
platform/mac/accessibility/media-role-descriptions.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isGenericFocusableElement):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
LayoutTests:
Making media elements int replaced elements has the unfortunate side-effect
of causing a new line to be inserted into any test using a <video> or <audio> tag.
- compositing/video/video-poster-expected.txt:
- compositing/video/video-reflection-expected.txt:
- compositing/visibility/visibility-simple-video-layer-expected.txt:
- fast/css/first-letter-block-form-controls-crash-expected.txt:
- fast/css/relative-position-replaced-in-table-display-crash-expected.txt:
- fast/forms/access-key-for-all-elements-expected.txt:
- fast/forms/form-associated-element-crash3-expected.txt:
- fast/multicol/renderer-positioned-assert-crash-expected.txt:
- fast/regions/full-screen-video-from-region-expected.txt:
- fast/runin/nonblock-runin-expected.txt:
- fast/spatial-navigation/snav-media-elements-expected.txt:
- fullscreen/full-screen-crash-offsetLeft-expected.txt:
- fullscreen/full-screen-no-style-sharing-expected.txt:
- fullscreen/full-screen-stacking-context-expected.txt:
- fullscreen/video-controls-drag-expected.txt:
- fullscreen/video-controls-timeline-expected.txt:
- fullscreen/video-cursor-auto-hide-expected.txt:
- fullscreen/video-specified-size-expected.txt:
- http/tests/appcache/video-expected.txt:
- http/tests/media/pdf-served-as-pdf-expected.txt:
- http/tests/media/reload-after-dialog-expected.txt:
- http/tests/media/text-served-as-text-expected.txt:
- http/tests/media/video-accept-encoding-expected.txt:
- http/tests/media/video-buffered-range-contains-currentTime-expected.txt:
- http/tests/media/video-cross-site-expected.txt:
- http/tests/media/video-error-abort-expected.txt:
- http/tests/media/video-load-suspend-expected.txt:
- http/tests/media/video-play-progress-expected.txt:
- http/tests/media/video-play-stall-before-meta-data-expected.txt:
- http/tests/media/video-preload-expected.txt:
- http/tests/media/video-redirect-expected.txt:
- http/tests/media/video-referer-expected.txt:
- http/tests/media/video-served-as-text-expected.txt:
- http/tests/media/video-throttled-load-metadata-expected.txt:
- http/tests/misc/empty-urls-expected.txt:
- http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt:
- http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
- http/tests/security/local-video-poster-from-remote-expected.txt:
- http/tests/security/local-video-source-from-remote-expected.txt:
- http/tests/security/local-video-src-from-remote-expected.txt:
- http/tests/security/text-track-crossorigin-expected.txt:
- media/W3C/audio/events/event_canplay-expected.txt:
- media/W3C/audio/events/event_canplay_manual-expected.txt:
- media/W3C/audio/events/event_canplaythrough-expected.txt:
- media/W3C/audio/events/event_canplaythrough_manual-expected.txt:
- media/W3C/audio/events/event_loadeddata-expected.txt:
- media/W3C/audio/events/event_loadeddata_manual-expected.txt:
- media/W3C/audio/events/event_loadedmetadata-expected.txt:
- media/W3C/audio/events/event_loadedmetadata_manual-expected.txt:
- media/W3C/audio/events/event_loadstart-expected.txt:
- media/W3C/audio/events/event_loadstart_manual-expected.txt:
- media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt:
- media/W3C/audio/events/event_order_canplay_playing-expected.txt:
- media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt:
- media/W3C/audio/events/event_order_loadstart_progress-expected.txt:
- media/W3C/audio/events/event_pause_manual-expected.txt:
- media/W3C/audio/events/event_play-expected.txt:
- media/W3C/audio/events/event_play_manual-expected.txt:
- media/W3C/audio/events/event_playing-expected.txt:
- media/W3C/audio/events/event_playing_manual-expected.txt:
- media/W3C/audio/events/event_progress-expected.txt:
- media/W3C/audio/events/event_progress_manual-expected.txt:
- media/W3C/audio/events/event_timeupdate-expected.txt:
- media/W3C/audio/events/event_timeupdate_manual-expected.txt:
- media/W3C/audio/networkState/networkState_during_loadstart-expected.txt:
- media/W3C/audio/paused/paused_false_during_play-expected.txt:
- media/W3C/audio/paused/paused_true_during_pause-expected.txt:
- media/W3C/audio/readyState/readyState_during_canplay-expected.txt:
- media/W3C/audio/readyState/readyState_during_canplaythrough-expected.txt:
- media/W3C/audio/readyState/readyState_during_loadeddata-expected.txt:
- media/W3C/audio/readyState/readyState_during_loadedmetadata-expected.txt:
- media/W3C/audio/readyState/readyState_during_playing-expected.txt:
- media/W3C/video/canPlayType/canPlayType_application_octet_stream-expected.txt:
- media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt:
- media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt:
- media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3-expected.txt:
- media/W3C/video/canPlayType/canPlayType_bogus_type-expected.txt:
- media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
- media/W3C/video/canPlayType/canPlayType_method_exists-expected.txt:
- media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
- media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
- media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
- media/W3C/video/currentSrc/currentSrc_empty_if_no_src-expected.txt:
- media/W3C/video/currentSrc/currentSrc_property_exists-expected.txt:
- media/W3C/video/error/error_null-expected.txt:
- media/W3C/video/error/error_onerror_called_on_bogus_source-expected.txt:
- media/W3C/video/error/error_property_exists-expected.txt:
- media/W3C/video/events/event_canplay-expected.txt:
- media/W3C/video/events/event_canplay_manual-expected.txt:
- media/W3C/video/events/event_canplaythrough-expected.txt:
- media/W3C/video/events/event_canplaythrough_manual-expected.txt:
- media/W3C/video/events/event_loadeddata-expected.txt:
- media/W3C/video/events/event_loadeddata_manual-expected.txt:
- media/W3C/video/events/event_loadedmetadata-expected.txt:
- media/W3C/video/events/event_loadedmetadata_manual-expected.txt:
- media/W3C/video/events/event_loadstart-expected.txt:
- media/W3C/video/events/event_loadstart_manual-expected.txt:
- media/W3C/video/events/event_order_canplay_canplaythrough-expected.txt:
- media/W3C/video/events/event_order_canplay_playing-expected.txt:
- media/W3C/video/events/event_order_loadedmetadata_loadeddata-expected.txt:
- media/W3C/video/events/event_order_loadstart_progress-expected.txt:
- media/W3C/video/events/event_pause_manual-expected.txt:
- media/W3C/video/events/event_play-expected.txt:
- media/W3C/video/events/event_play_manual-expected.txt:
- media/W3C/video/events/event_playing-expected.txt:
- media/W3C/video/events/event_playing_manual-expected.txt:
- media/W3C/video/events/event_progress-expected.txt:
- media/W3C/video/events/event_progress_manual-expected.txt:
- media/W3C/video/events/event_timeupdate-expected.txt:
- media/W3C/video/events/event_timeupdate_manual-expected.txt:
- media/W3C/video/networkState/networkState_during_loadstart-expected.txt:
- media/W3C/video/networkState/networkState_during_progress-expected.txt:
- media/W3C/video/networkState/networkState_initial-expected.txt:
- media/W3C/video/networkState/networkState_property_exists-expected.txt:
- media/W3C/video/paused/paused_false_during_play-expected.txt:
- media/W3C/video/paused/paused_true_during_pause-expected.txt:
- media/W3C/video/preload/preload_property_exists-expected.txt:
- media/W3C/video/preload/preload_reflects_auto_value-expected.txt:
- media/W3C/video/preload/preload_reflects_bogus_value-expected.txt:
- media/W3C/video/preload/preload_reflects_empty-expected.txt:
- media/W3C/video/preload/preload_reflects_metadata-expected.txt:
- media/W3C/video/preload/preload_reflects_no_value-expected.txt:
- media/W3C/video/preload/preload_reflects_none-expected.txt:
- media/W3C/video/preload/preload_reflects_none_autoplay-expected.txt:
- media/W3C/video/readyState/readyState_during_canplay-expected.txt:
- media/W3C/video/readyState/readyState_during_canplaythrough-expected.txt:
- media/W3C/video/readyState/readyState_during_loadeddata-expected.txt:
- media/W3C/video/readyState/readyState_during_loadedmetadata-expected.txt:
- media/W3C/video/readyState/readyState_during_playing-expected.txt:
- media/W3C/video/readyState/readyState_initial-expected.txt:
- media/W3C/video/readyState/readyState_property_exists-expected.txt:
- media/W3C/video/src/src_reflects_attribute_not_source_elements-expected.txt:
- media/W3C/video/src/src_reflects_no_value-expected.txt:
- media/W3C/video/src/src_removal_does_not_trigger_loadstart-expected.txt:
- media/audio-mpeg-supported-expected.txt:
- media/audio-mpeg4-supported-expected.txt:
- media/audio-only-video-intrinsic-size-expected.txt:
- media/auto-play-in-sandbox-with-allow-scripts-expected.txt:
- media/before-load-member-access-expected.txt:
- media/broken-video-expected.txt:
- media/constructors-expected.txt:
- media/controls-css-overload-expected.txt:
- media/controls-drag-timebar-expected.txt:
- media/controls-layout-direction-expected.txt:
- media/controls-right-click-on-timebar-expected.txt:
- media/csp-blocks-video-expected.txt:
- media/event-attributes-expected.txt:
- media/media-blocked-by-beforeload-expected.txt:
- media/media-blocked-by-willsendrequest-expected.txt:
- media/media-can-play-mpeg-audio-expected.txt:
- media/media-can-play-mpeg4-video-expected.txt:
- media/media-can-play-octet-stream-expected.txt:
- media/media-can-play-type-expected.txt:
- media/media-can-play-wav-audio-expected.txt:
- media/media-captions-expected.txt:
- media/media-captions-no-controls-expected.txt:
- media/media-controller-expected.txt:
- media/media-controller-playback-expected.txt:
- media/media-controller-playbackrate-expected.txt:
- media/media-controller-time-clamp-expected.txt:
- media/media-controller-time-constant-expected.txt:
- media/media-controller-time-expected.txt:
- media/media-controller-timeupdate-expected.txt:
- media/media-controller-unpause-expected.txt:
- media/media-controls-invalid-url-expected.txt:
- media/media-ended-expected.txt:
- media/media-extension-with-fragment-expected.txt:
- media/media-fragments/TC0001-expected.txt:
- media/media-fragments/TC0002-expected.txt:
- media/media-fragments/TC0003-expected.txt:
- media/media-fragments/TC0004-expected.txt:
- media/media-fragments/TC0005-expected.txt:
- media/media-fragments/TC0006-expected.txt:
- media/media-fragments/TC0009-expected.txt:
- media/media-fragments/TC0011-expected.txt:
- media/media-fragments/TC0012-expected.txt:
- media/media-fragments/TC0014-expected.txt:
- media/media-fragments/TC0015-expected.txt:
- media/media-fragments/TC0017-expected.txt:
- media/media-fragments/TC0024-expected.txt:
- media/media-fragments/TC0027-expected.txt:
- media/media-fragments/TC0028-expected.txt:
- media/media-fragments/TC0029-expected.txt:
- media/media-fragments/TC0030-expected.txt:
- media/media-fragments/TC0031-expected.txt:
- media/media-fragments/TC0032-expected.txt:
- media/media-fragments/TC0033-expected.txt:
- media/media-fragments/TC0034-expected.txt:
- media/media-fragments/TC0035-expected.txt:
- media/media-fragments/TC0036-expected.txt:
- media/media-fragments/TC0037-expected.txt:
- media/media-fragments/TC0038-expected.txt:
- media/media-fragments/TC0039-expected.txt:
- media/media-fragments/TC0044-expected.txt:
- media/media-fragments/TC0051-expected.txt:
- media/media-fragments/TC0052-expected.txt:
- media/media-fragments/TC0053-expected.txt:
- media/media-fragments/TC0054-expected.txt:
- media/media-fragments/TC0055-expected.txt:
- media/media-fragments/TC0058-expected.txt:
- media/media-fragments/TC0059-expected.txt:
- media/media-fragments/TC0061-expected.txt:
- media/media-fragments/TC0062-expected.txt:
- media/media-fragments/TC0063-expected.txt:
- media/media-fragments/TC0064-expected.txt:
- media/media-fragments/TC0065-expected.txt:
- media/media-fragments/TC0066-expected.txt:
- media/media-fragments/TC0067-expected.txt:
- media/media-fragments/TC0068-expected.txt:
- media/media-fragments/TC0069-expected.txt:
- media/media-fragments/TC0070-expected.txt:
- media/media-fragments/TC0071-expected.txt:
- media/media-fragments/TC0072-expected.txt:
- media/media-fragments/TC0073-expected.txt:
- media/media-fragments/TC0074-expected.txt:
- media/media-fragments/TC0075-expected.txt:
- media/media-fragments/TC0076-expected.txt:
- media/media-fragments/TC0077-expected.txt:
- media/media-fragments/TC0078-expected.txt:
- media/media-fragments/TC0079-expected.txt:
- media/media-fragments/TC0080-expected.txt:
- media/media-fragments/TC0081-expected.txt:
- media/media-fragments/TC0082-expected.txt:
- media/media-fragments/TC0083-expected.txt:
- media/media-fragments/TC0084-expected.txt:
- media/media-fragments/TC0085-expected.txt:
- media/media-fragments/TC0086-expected.txt:
- media/media-fragments/TC0087-expected.txt:
- media/media-fragments/TC0088-expected.txt:
- media/media-fragments/TC0089-expected.txt:
- media/media-fragments/TC0090-expected.txt:
- media/media-fragments/TC0091-expected.txt:
- media/media-fragments/TC0092-expected.txt:
- media/media-fragments/TC0093-expected.txt:
- media/media-fragments/TC0094-expected.txt:
- media/media-fullscreen-inline-expected.txt:
- media/media-preload-no-delay-loadevent-expected.txt:
- media/no-autoplay-with-user-gesture-requirement-expected.txt:
- media/nodesFromRect-shadowContent-expected.txt:
- media/restore-from-page-cache-expected.txt:
- media/sources-fallback-codecs-expected.txt:
- media/track/add-and-remove-track-expected.txt:
- media/track/audio-track-expected.txt:
- media/track/opera/interfaces/TextTrack/addCue-expected.txt:
- media/track/opera/interfaces/TextTrack/removeCue-expected.txt:
- media/track/opera/interfaces/TextTrackCue/align-expected.txt:
- media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:
- media/track/opera/interfaces/TextTrackCue/id-expected.txt:
- media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt:
- media/track/opera/interfaces/TextTrackCue/startTime-expected.txt:
- media/track/opera/interfaces/TextTrackCue/track-expected.txt:
- media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt:
- media/track/opera/interfaces/TextTrackCueList/length-expected.txt:
- media/track/text-track-cue-is-reachable-expected.txt:
- media/track/text-track-is-reachable-expected.txt:
- media/track/track-active-cues-expected.txt:
- media/track/track-add-remove-cue-expected.txt:
- media/track/track-add-track-expected.txt:
- media/track/track-addtrack-kind-expected.txt:
- media/track/track-automatic-subtitles-expected.txt:
- media/track/track-css-all-cues-expected.txt:
- media/track/track-css-cue-lifetime-expected.txt:
- media/track/track-css-matching-default-expected.txt:
- media/track/track-css-matching-expected.txt:
- media/track/track-css-matching-lang-expected.txt:
- media/track/track-css-matching-timestamps-expected.txt:
- media/track/track-css-property-whitelist-expected.txt:
- media/track/track-css-user-override-expected.txt:
- media/track/track-cue-container-rendering-position-expected.txt:
- media/track/track-cue-empty-text-crash-expected.txt:
- media/track/track-cue-inline-assertion-crash-expected.txt:
- media/track/track-cue-mutable-expected.txt:
- media/track/track-cue-mutable-fragment-expected.txt:
- media/track/track-cue-negative-timestamp-expected.txt:
- media/track/track-cue-nothing-to-render-expected.txt:
- media/track/track-cue-overlap-snap-to-lines-not-set-expected.txt:
- media/track/track-cue-rendering-empty-cue-crash-expected.txt:
- media/track/track-cue-rendering-expected.txt:
- media/track/track-cue-rendering-on-resize-expected.txt:
- media/track/track-cue-rendering-rtl-expected.txt:
- media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
- media/track/track-cue-rendering-tree-is-removed-properly-expected.txt:
- media/track/track-cue-rendering-with-padding-expected.txt:
- media/track/track-cues-cuechange-expected.txt:
- media/track/track-cues-enter-exit-expected.txt:
- media/track/track-cues-missed-expected.txt:
- media/track/track-cues-pause-on-exit-expected.txt:
- media/track/track-cues-seeking-expected.txt:
- media/track/track-cues-sorted-before-dispatch-expected.txt:
- media/track/track-default-attribute-expected.txt:
- media/track/track-disabled-addcue-expected.txt:
- media/track/track-disabled-expected.txt:
- media/track/track-element-load-event-expected.txt:
- media/track/track-in-band-cues-added-once-expected.txt:
- media/track/track-in-band-duplicate-tracks-when-source-changes-expected.txt:
- media/track/track-in-band-expected.txt:
- media/track/track-in-band-legacy-api-expected.txt:
- media/track/track-in-band-style-expected.txt:
- media/track/track-kind-expected.txt:
- media/track/track-large-timestamp-expected.txt:
- media/track/track-legacyapi-with-automatic-mode-expected.txt:
- media/track/track-load-from-element-readyState-expected.txt:
- media/track/track-load-from-src-readyState-expected.txt:
- media/track/track-long-captions-file-expected.txt:
- media/track/track-mode-disabled-crash-expected.txt:
- media/track/track-mode-expected.txt:
- media/track/track-mode-not-changed-by-new-track-expected.txt:
- media/track/track-mode-triggers-loading-expected.txt:
- media/track/track-remove-active-cue-crash-expected.txt:
- media/track/track-remove-by-setting-innerHTML-expected.txt:
- media/track/track-remove-quickly-expected.txt:
- media/track/track-text-track-cue-list-expected.txt:
- media/track/track-texttracks-expected.txt:
- media/track/track-webvtt-tc000-empty-expected.txt:
- media/track/track-webvtt-tc001-utf8-expected.txt:
- media/track/track-webvtt-tc002-bom-expected.txt:
- media/track/track-webvtt-tc003-newlines-expected.txt:
- media/track/track-webvtt-tc004-magic-header-expected.txt:
- media/track/track-webvtt-tc005-header-comment-expected.txt:
- media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
- media/track/track-webvtt-tc007-cue-no-id-expected.txt:
- media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
- media/track/track-webvtt-tc009-timings-hour-expected.txt:
- media/track/track-webvtt-tc010-no-timings-expected.txt:
- media/track/track-webvtt-tc011-blank-lines-expected.txt:
- media/track/track-webvtt-tc013-settings-expected.txt:
- media/track/track-webvtt-tc014-alignment-expected.txt:
- media/track/track-webvtt-tc015-positioning-expected.txt:
- media/track/track-webvtt-tc016-align-positioning-expected.txt:
- media/track/track-webvtt-tc017-line-position-expected.txt:
- media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
- media/track/track-webvtt-tc019-cue-size-expected.txt:
- media/track/track-webvtt-tc020-cue-size-align-expected.txt:
- media/track/track-webvtt-tc021-valign-expected.txt:
- media/track/track-webvtt-tc022-entities-expected.txt:
- media/track/track-webvtt-tc023-markup-expected.txt:
- media/track/track-webvtt-tc024-timestamp-expected.txt:
- media/track/track-webvtt-tc025-class-markup-expected.txt:
- media/track/track-webvtt-tc026-voice-expected.txt:
- media/track/track-webvtt-tc027-empty-cue-expected.txt:
- media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
- media/track/track-word-breaking-expected.txt:
- media/track/tracklist-is-reachable-expected.txt:
- media/track/video-track-expected.txt:
- media/unsupported-rtsp-expected.txt:
- media/unsupported-tracks-expected.txt:
- media/video-append-source-expected.txt:
- media/video-autoplay-expected.txt:
- media/video-beforeload-remove-source-expected.txt:
- media/video-buffered-expected.txt:
- media/video-canvas-drawing-expected.txt:
- media/video-canvas-drawing-output-expected.txt:
- media/video-controls-captions-trackmenu-hide-on-click-outside-expected.txt:
- media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt:
- media/video-controls-expected.txt:
- media/video-controls-transformed-expected.txt:
- media/video-controls-with-mutation-event-handler-expected.txt:
- media/video-controls-zoomed-expected.txt:
- media/video-currentTime-delay-expected.txt:
- media/video-currentTime-expected.txt:
- media/video-currentTime-set-expected.txt:
- media/video-currentTime-set2-expected.txt:
- media/video-delay-load-event-expected.txt:
- media/video-display-aspect-ratio-expected.txt:
- media/video-dom-autoplay-expected.txt:
- media/video-dom-preload-expected.txt:
- media/video-dom-src-expected.txt:
- media/video-duration-known-after-eos-expected.txt:
- media/video-error-does-not-exist-expected.txt:
- media/video-load-networkState-expected.txt:
- media/video-load-preload-metadata-expected.txt:
- media/video-load-preload-none-expected.txt:
- media/video-load-readyState-expected.txt:
- media/video-load-require-user-gesture-expected.txt:
- media/video-loop-expected.txt:
- media/video-mouse-focus-expected.txt:
- media/video-muted-expected.txt:
- media/video-no-autoplay-expected.txt:
- media/video-pause-empty-events-expected.txt:
- media/video-pause-immediately-expected.txt:
- media/video-play-empty-events-expected.txt:
- media/video-play-pause-events-expected.txt:
- media/video-play-pause-exception-expected.txt:
- media/video-play-require-user-gesture-expected.txt:
- media/video-playbackrate-expected.txt:
- media/video-played-collapse-expected.txt:
- media/video-played-ranges-1-expected.txt:
- media/video-played-reset-expected.txt:
- media/video-plays-past-end-of-test-expected.txt:
- media/video-poster-blocked-by-willsendrequest-expected.txt:
- media/video-poster-delayed-expected.txt:
- media/video-poster-expected.txt:
- media/video-poster-scale-expected.txt:
- media/video-preload-expected.txt:
- media/video-replaces-poster-expected.txt:
- media/video-reverse-play-duration-expected.txt:
- media/video-seek-after-end-expected.txt:
- media/video-seek-by-small-increment-expected.txt:
- media/video-seek-multiple-expected.txt:
- media/video-seek-no-src-exception-expected.txt:
- media/video-seek-past-end-playing-expected.txt:
- media/video-seekable-expected.txt:
- media/video-seeking-expected.txt:
- media/video-set-rate-from-pause-expected.txt:
- media/video-single-valid-source-expected.txt:
- media/video-size-expected.txt:
- media/video-source-error-expected.txt:
- media/video-source-error-no-candidate-expected.txt:
- media/video-source-expected.txt:
- media/video-source-inserted-expected.txt:
- media/video-source-load-expected.txt:
- media/video-source-none-supported-expected.txt:
- media/video-source-type-expected.txt:
- media/video-src-blob-expected.txt:
- media/video-src-change-expected.txt:
- media/video-src-empty-expected.txt:
- media/video-src-expected.txt:
- media/video-src-invalid-poster-expected.txt:
- media/video-src-invalid-remove-expected.txt:
- media/video-src-none-expected.txt:
- media/video-src-plus-source-expected.txt:
- media/video-src-remove-expected.txt:
- media/video-src-set-expected.txt:
- media/video-src-source-expected.txt:
- media/video-timeupdate-during-playback-expected.txt:
- media/video-timeupdate-reverse-play-expected.txt:
- media/video-volume-expected.txt:
- media/video-width-height-expected.txt:
- platform/mac/accessibility/media-element-expected.txt:
- platform/mac/accessibility/media-emits-object-replacement-expected.txt: Added.
- platform/mac/accessibility/media-emits-object-replacement.html: Added.
- platform/mac/accessibility/media-role-descriptions-expected.txt: Added.
- platform/mac/accessibility/media-role-descriptions.html: Added.
- platform/mac/compositing/video/video-object-fit-expected.txt:
- platform/mac/fullscreen/video-controls-override-expected.txt:
- platform/mac/media/media-can-play-wav-audio-expected.txt:
- platform/mac/media/media-can-play-webm-expected.txt:
- platform/mac/media/video-seek-past-end-paused-expected.txt:
- 5:55 AM WebKitGtkLayoutTests edited by
- (diff)
- 5:55 AM Changeset in webkit [158742] by
-
- 3 edits in trunk/Tools
[ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118969
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.
Added missing implementation of attributesOfColumnHeaders, attributesOfRowHeaders, attributesOfVisibleCells.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::attributesOfChildren):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfVisibleCells):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
- 5:54 AM WebKitGtkLayoutTests edited by
- (diff)
- 5:52 AM WebKitGtkLayoutTests edited by
- (diff)
- 3:31 AM Changeset in webkit [158741] by
-
- 2 edits2 adds in trunk/LayoutTests
[ATK] accessibility/tabindex-elements-are-accessible.html is failing
https://bugs.webkit.org/show_bug.cgi?id=123884
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.
Added new accessibility expectation file. ATK represents paragraph's role as a ATK_ROLE_PARAGRAPH.
- platform/efl/TestExpectations: Test is no longer failing.
- platform/efl/accessibility/tabindex-elements-are-accessible-expected.txt: Added.
- platform/gtk/accessibility/tabindex-elements-are-accessible-expected.txt: Added.
- 3:17 AM Changeset in webkit [158740] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Tests failing after r158195
- platform/gtk/TestExpectations: Added failure expectations.
- 3:11 AM Changeset in webkit [158739] by
-
- 3 edits6 adds in trunk
Notify nodes removal to Range/Selection after dispatching blur and mutation event
https://bugs.webkit.org/show_bug.cgi?id=123880
Reviewed by Andreas Kling.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/b60576a0560d14f8757e58d55d37b7cefa48a6ac
In willRemoveChildren in ContainerNode.cpp, call Document::nodeChildrenWillBeRemoved after instead of
before dispatching mutation events because we need to update ranges created by those mutation event
listeners. willRemoveChild was fixed in r115686.
Tests: editing/selection/selection-change-in-blur-event-by-remove-children.html
editing/selection/selection-change-in-mutation-event-by-remove-children.html
fast/dom/Range/range-created-during-remove-children.html
- dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):
LayoutTests:
- editing/selection/selection-change-in-blur-event-by-remove-children-expected.txt: Added.
- editing/selection/selection-change-in-blur-event-by-remove-children.html: Added.
- editing/selection/selection-change-in-mutation-event-by-remove-children-expected.txt: Added.
- editing/selection/selection-change-in-mutation-event-by-remove-children.html: Added.
- fast/dom/Range/range-created-during-remove-children-expected.txt: Added.
- fast/dom/Range/range-created-during-remove-children.html: Added.
- 2:55 AM Changeset in webkit [158738] by
-
- 3 edits2 adds in trunk
Fix out-of-date offset in selection range code in range.surroundContents
https://bugs.webkit.org/show_bug.cgi?id=123871
Source/WebCore:
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/c89b413ff0fc4aafa0c71d180b0b1e131bb37707
The code in Range::insertNode assumeed that the start offset of the selection range within its container
doesn't change across a call to insertBefore on the container but this is wrong. This patch recomputes
the start offset when it is used after the insertBefore call.
Test: editing/selection/range-surroundContents-with-preceding-node.html
- dom/Range.cpp:
(WebCore::Range::insertNode):
LayoutTests:
Reviewed by Andreas Kling.
- editing/selection/range-surroundContents-with-preceding-node-expected.txt: Added.
- editing/selection/range-surroundContents-with-preceding-node.html: Added.
- 2:33 AM Changeset in webkit [158737] by
-
- 2 edits in trunk/LayoutTests
[GTK] accessibility/svg-group-element-with-title.html is failing
https://bugs.webkit.org/show_bug.cgi?id=114251
Unreviewed GTK gardening.
Removed failure expectation as the test is passing since r158664.
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-11-06
- platform/gtk/TestExpectations: The test is no longer failing.
- 2:26 AM Changeset in webkit [158736] by
-
- 13 edits2 adds in trunk/Source/WebCore
Add InlineElementBox and stop instantiating InlineBox directly.
<https://webkit.org/b/123882>
Make the InlineBox constructors protected and add a new class
called InlineElementBox on top. This is somewhat analogous to the
split between RenderText and RenderElement, and allows us to make
renderer() return a far tighter RenderBoxModelObject& instead
of a RenderObject&.
Moved over attachLine(), deleteLine() and extractLine() to start
things off. More things will follow.
Reviewed by Antti Koivisto.
- 2:21 AM Changeset in webkit [158735] by
-
- 2 edits in trunk
[EFL] Change required version of ATK to 2.10.0
https://bugs.webkit.org/show_bug.cgi?id=123883
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.
Changing a required version of ATK to 2.10.0
- Source/cmake/OptionsEfl.cmake:
- 1:32 AM Changeset in webkit [158734] by
-
- 3 edits2 adds in trunk
Source/WebCore: Seek for video doesn't work when playback rate is negative
https://bugs.webkit.org/show_bug.cgi?id=123791
In MediaPlayerPrivateGStreamer::seek negative playback rate was not taken to account.
Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-06
Reviewed by Philippe Normand.
Test: media/video-seek-with-negative-playback.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::seek):
LayoutTests: Test for seek not working properly with negative playback rate.
https://bugs.webkit.org/show_bug.cgi?id=123791
Seek method should work properly with negative playback rate.
Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-06
Reviewed by Philippe Normand.
- media/video-seek-with-negative-playback.html: Added.
- media/video-seek-with-negative-playback-expected.txt: Added.
- 12:19 AM Changeset in webkit [158733] by
-
- 2 edits in trunk/Source/WebCore
Reinstate an annoying assertion that I accidentally commented out.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousIconForPageURL):
- 12:14 AM Changeset in webkit [158732] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] Override label() and language() in Audio and VideoTrackPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=123836
The tests are currently flakey because we only get the label and language if we get
tags after the track client is set.
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Philippe Normand.
No new tests because the tests already exist (this fixes flakeyness).
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Override label() and language() to use m_label and m_language.
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Same.
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Make m_label and m_language protected so they can be used in the functions above.
- 12:13 AM Changeset in webkit [158731] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test for queries whose leftmost selector matches the root node
https://bugs.webkit.org/show_bug.cgi?id=123877
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/22981c70bf93e8a07ee7b4d68a4522aee21b26ce
so that we won't introduce the regression they had.
- fast/selectors/querySelector-leftmost-selector-matches-rootNode-expected.txt: Added.
- fast/selectors/querySelector-leftmost-selector-matches-rootNode.html: Added.
- 12:09 AM Changeset in webkit [158730] by
-
- 7 edits in trunk/Source/WebCore
RenderBlockFlow should only expose its line boxes as RootInlineBox.
<https://webkit.org/b/123878>
The line boxes attached directly to a RenderBlockFlow are always
RootInlineBox objects, so call sites should always use the tightly
typed firstRootBox() and lastRootBox().
This allows the compiler to devirtualize calls to member functions
of RootInlineBox that are marked FINAL.
Reviewed by Antti Koivisto.
- 12:05 AM Changeset in webkit [158729] by
-
- 3 edits2 adds in trunk
Assertion failure end < m_runCount in WebCore::BidiRunList<WebCore::BidiRun>::reverseRuns
https://bugs.webkit.org/show_bug.cgi?id=123863
Reviewed by Andreas Kling.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/cbaa92c763a37d89eeabd01658e522219299290c
Test: fast/text/bidi-reverse-runs-crash.html
- platform/text/BidiResolver.h:
(WebCore::BidiResolver<Iterator, Run>::createBidiRunsForLine): Don't reverse the runs if there's
nothing to be reversed.
LayoutTests:
- fast/text/bidi-reverse-runs-crash-expected.txt: Added.
- fast/text/bidi-reverse-runs-crash.html: Added.
- 12:02 AM Changeset in webkit [158728] by
-
- 2 edits in trunk/Source/WebCore
Address the review comment after r158724.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
Nov 5, 2013:
- 11:31 PM Changeset in webkit [158727] by
-
- 3 edits1 add in trunk
Widget's position change should not initiate layout, only when its size changes.
https://bugs.webkit.org/show_bug.cgi?id=123860
Reviewed by Andreas Kling.
RenderWidgets initiate unnecessary layouts while scrolling when they are embedded to
overflow:scroll containers. Scroll position change doesn't dirty the render tree
so it should not trigger layout either.
.:
- ManualTests/layouts-on-renderwidgets-while-scrolling.html: Added.
Source/WebCore:
Manual test added. Unfortunately we can't test against the number of layouts yet.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::updateWidgetGeometry):
(WebCore::RenderWidget::updateWidgetPosition):
- 11:30 PM Changeset in webkit [158726] by
-
- 3 edits8 adds in trunk/LayoutTests
Add more tests for formaction, formenctype, formmethod, formnovalidate, and formtarget attributes
https://bugs.webkit.org/show_bug.cgi?id=123876
Reviewed by Andreas Kling.
Merge tests from https://chromium.googlesource.com/chromium/blink/+/5f4ccd416fec39a6878af66e87bda191cc59ea7e
so that we won't introduce regressions they had.
- fast/forms/formaction-attribute-expected.txt:
- fast/forms/formaction-attribute.html:
- fast/forms/formmethod-attribute-input-2-expected.txt: Added.
- fast/forms/formmethod-attribute-input-2.html: Added.
- fast/forms/formtarget-attribute-input-2-expected.txt: Added.
- fast/forms/formtarget-attribute-input-2.html: Added.
- fast/forms/interactive-validation-formnovalidate-2-expected.txt: Added.
- fast/forms/interactive-validation-formnovalidate-2.html: Added.
- fast/forms/mailto/formenctype-attribute-input-2-expected.txt: Added.
- fast/forms/mailto/formenctype-attribute-input-2.html: Added.
- 11:20 PM Changeset in webkit [158725] by
-
- 2 edits in trunk/LayoutTests
Mac Mavericks rebaseline after r158714.
- platform/mac/fast/forms/textAreaLineHeight-expected.txt:
- 11:11 PM Changeset in webkit [158724] by
-
- 3 edits2 adds in trunk
Use-after-free in SliderThumbElement::dragFrom
https://bugs.webkit.org/show_bug.cgi?id=123873
Reviewed by Andreas Kling.
Source/WebCore:
Ref the SliderThumbElement since it could go away inside dragFrom.
Test: fast/forms/range/range-type-change-onchange-2.html
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
LayoutTests:
Merge https://chromium.googlesource.com/chromium/blink/+/04a23bfca2d04101a1828d36ff36c29f3a24f34b
- fast/forms/range/range-type-change-onchange-2-expected.txt: Added.
- fast/forms/range/range-type-change-onchange-2.html: Added.
- 10:14 PM Changeset in webkit [158723] by
-
- 3 edits in trunk/Source/WebCore
Change the order of conditions to avoid computing rendererIsEditable()
https://bugs.webkit.org/show_bug.cgi?id=123868
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/c89b413ff0fc4aafa0c71d180b0b1e131bb37707
When we need both Node::renderer() and Node::rendererIsEditable() conditions to be true to perform
some operation, it is more effective to check for renderer() first, so that if this condition fails
we can avoid unnecessary computation of rendererIsEditable().
- dom/Position.cpp:
(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
- 10:02 PM Changeset in webkit [158722] by
-
- 2 edits in trunk/Source/WebCore
simpleUserAgentStyleSheet doesn't have focus ring on anchor element
https://bugs.webkit.org/show_bug.cgi?id=123867
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/08ecc23c4d80be9969918c4baf0ac83dc6cb6cbd
- css/CSSDefaultStyleSheets.cpp:
- 10:00 PM Changeset in webkit [158721] by
-
- 3 edits2 adds in trunk
valueForBorderRadiusShorthand returns wrong values in some case
https://bugs.webkit.org/show_bug.cgi?id=123866
Reviewed by Andreas Kling.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/0933728126f2db06ab8e945efc98bffa2d42af1c
Because valueForBorderRadiusShorthand misses the followings:
- showHorizontalBottomRight depends on showHorizontalBottomLeft.
- showHorizontalTopRight depends on showHorizontalBottomRight (including showHorizontalBottomLeft).
See also http://dev.w3.org/csswg/css-backgrounds/#the-border-radius
Test: fast/css/getComputedStyle/getComputedStyle-borderRadius-2.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::getBorderRadiusShorthandValue):
LayoutTests:
- fast/css/getComputedStyle/getComputedStyle-borderRadius-2-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-borderRadius-2.html: Added.
- 9:50 PM Changeset in webkit [158720] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: transitions/cancel-transition.html
https://bugs.webkit.org/show_bug.cgi?id=114193
Reviewed by Simon Fraser.
Merge https://chromium.googlesource.com/chromium/blink/+/983dbbff6c46b6365540bf1451f25b31d72ce893
- transitions/cancel-transition.html:
- 9:21 PM Changeset in webkit [158719] by
-
- 2 edits in trunk/Source/WebCore
Protect DOM nodes in IndentOutdentCommand::tryIndentingAsListItem()
https://bugs.webkit.org/show_bug.cgi?id=123861
Reviewed by Benjamin Poulain.
Merge https://chromium.googlesource.com/chromium/blink/+/297442eb539a2b764fdad323de79099a70179186 partially.
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::tryIndentingAsListItem): Make selectedListItem, previousList, and nextList
RefPtr since they're are used after calling insertNodeBefore.
- 8:47 PM Changeset in webkit [158718] by
-
- 22 edits in trunk/Source/WebCore
Apply more unique_ptr to line box management.
<https://webkit.org/b/123857>
Make all of the functions that return newly-created line boxes
return them packed up in std::unique_ptrs.
There is one exception in RenderBlockLineLayout where the function
createInlineBoxForRenderer() is inconsistent about the ownership of
the returned object. This will be addressed by a subsequent patch.
We now "release" the line boxes into their various home structures,
so the pointer smartness doesn't go end-to-end just yet.
Reviewed by Anders Carlsson.
- 8:40 PM Changeset in webkit [158717] by
-
- 6 edits in trunk/Source/JavaScriptCore
FTL should support NewObject
https://bugs.webkit.org/show_bug.cgi?id=123849
Reviewed by Oliver Hunt.
- ftl/FTLAbstractHeapRepository.cpp:
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::allocate):
- 8:38 PM Changeset in webkit [158716] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL should support StringCharAt
https://bugs.webkit.org/show_bug.cgi?id=123855
Reviewed by Oliver Hunt.
This is just like GetByVal for String, so we reuse that code.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):
- 7:59 PM Changeset in webkit [158715] by
-
- 2 edits in trunk/Source/WebKit/win
Windows build fix attempt after r158704.
- FullscreenVideoController.cpp:
- 7:55 PM Changeset in webkit [158714] by
-
- 5 edits2 adds in trunk
getComputedStyle(x).lineHeight is affected by zooming
https://bugs.webkit.org/show_bug.cgi?id=123847
Reviewed by Benjamin Poulain.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/7957097afbab2899ababd0d9c8acbf6e3eddb870
Test: fast/css/line-height-zoom-get-computed-style.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::lineHeightFromStyle): Don't round line-height values.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyLineHeight::applyValue): Use the computed value instead of the used value.
LayoutTests:
Cleaned up the test.
- fast/css/line-height-zoom-get-computed-style-expected.txt: Added.
- fast/css/line-height-zoom-get-computed-style.html: Added.
- platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt: Rebaselined.
- 7:50 PM Changeset in webkit [158713] by
-
- 10 edits in trunk
AX: media controls accessibility needs more work
https://bugs.webkit.org/show_bug.cgi?id=123749
Patch by James Craig <jcraig@apple.com> on 2013-11-05
Reviewed by Jer Noble.
Updated some of the control labels/roles to improve accessibility.
- Volume slider is now keyboard/screenreader accessible.
- muteButton was a checkbox toggling checked state, now a button that toggles label "mute/unmute"
- fullscreenButton was a checkbox toggling checked state, now a button that toggles label "display/exit full screen"
- captionButton was a checkbox, now a popup button that launches the newly accessible menu.
Subtitles menu is now keyboard/screenreader accessible (uses roaming tabindex).
Render dump expectations changed because volume slider is now hidden via...
...opacity/size (to make accessible without hover) instead of display:none.
Updated existing test coverage.
Source/WebCore:
- Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-panel .volume-box):
(audio::-webkit-media-controls-panel .volume-box:active):
(audio::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-closed-captions-container .list):
(audio::-webkit-media-controls-closed-captions-container li:focus):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls):
(Controller.prototype.handleFullscreenChange):
(Controller.prototype.handleMuteButtonClicked):
(Controller.prototype.handleMinButtonClicked):
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderChange):
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.focusSiblingCaptionItem):
(Controller.prototype.handleCaptionItemKeyUp):
LayoutTests:
- platform/mac/accessibility/media-element-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/controls-after-reload-expected.txt:
- platform/mac/media/controls-strict-expected.txt:
- platform/mac/media/controls-styling-strict-expected.txt:
- platform/mac/media/controls-without-preload-expected.txt:
- 7:36 PM Changeset in webkit [158712] by
-
- 4 edits in trunk/Source/WebCore
Move some plugin-specific code from RenderWidget to RenderEmbeddedObject.
<https://webkit.org/b/123845>
All RenderWidgets representing plugins will be RenderEmbeddedObjects.
Move some of the plugin-specific logic to RenderEmbeddedObject since it
doesn't make sense for all RenderWidgets (frames, embedded documents)
to care about this.
Reviewed by Anders Carlsson.
- 6:48 PM Changeset in webkit [158711] by
-
- 3 edits in trunk/LayoutTests
Add a test to obtain offsetWidth of expanded table cell
https://bugs.webkit.org/show_bug.cgi?id=123843
Reviewed by Tim Horton.
Merge the test fix in https://chromium.googlesource.com/chromium/blink/+/b249d552497c0939d8277360b99dd3c56b0c9659.
- fast/table/table-cell-offset-width-expected.txt:
- fast/table/table-cell-offset-width.html:
- 6:40 PM Changeset in webkit [158710] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a test to obtain offsetWidth of expanded table cell
https://bugs.webkit.org/show_bug.cgi?id=123843
Reviewed by Tim Horton.
Merge the test from https://chromium.googlesource.com/chromium/blink/+/58a5fac292a5b3f79b00cdc71074fbf8be2ebc2b
so that we'll never introduce the regression they had.
- fast/table/table-cell-offset-width-expected.txt: Added.
- fast/table/table-cell-offset-width.html: Added.
- 6:39 PM Changeset in webkit [158709] by
-
- 2 edits in trunk/Source/WebCore
Fix the 32-bit build.
- WebCore.exp.in:
- 6:15 PM Changeset in webkit [158708] by
-
- 4 edits7 adds in trunk
Web Inspector: Moving an element while in the DOMNodeRemoved handler will hide it in the inspector
https://bugs.webkit.org/show_bug.cgi?id=123516
Reviewed by Timothy Hatcher.
Source/WebCore:
InspectorInstrumentation::willRemoveDOMNode was actually calling both willRemoveDOMNodeImpl and
didRemoveDOMNodeImpl, making the DOMAgent unbind the element even if it was still part of the DOM.
Because of that the DOMAgent was sending two events:
- When the element was about to be removed, just before JS "DOMNodeRemoved" was triggered.
- When the element was actually removed.
Note that inspector's event #2 will not know about the node, as it just removed it from the
internal hashmap, so it will just use a nodeID == 0 for it.
This patch adds a separate call to InspectorInstrumentation::didRemoveDOMNode, just before the
element is about to be removed. The InspectorInstrumentation::willRemoveDOMNode call is now only used
by the DOMDebugger to trigger the DOM breakpoints in the Web Inspector. That feature is not exposed
in the new Inspector UI, but can be used/tested using the protocol directly.
Tests: inspector-protocol/dom-debugger/node-removed.html
inspector-protocol/dom/dom-remove-events.html
inspector-protocol/dom/remove-multiple-nodes.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeBetween):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willRemoveDOMNode):
(WebCore::InspectorInstrumentation::didRemoveDOMNode):
LayoutTests:
Added tests to check that the DOM.childNodeRemoved inspector-protocol message is dispatched
correctly when DOM nodes are moved while inside the "DOMNodeRemoved" event handler.
- inspector-protocol/dom-debugger/node-removed-expected.txt: Added.
- inspector-protocol/dom-debugger/node-removed.html: Added. Checking that the DOMDebugger agent
is still sending the node-removed events.
- inspector-protocol/dom/dom-remove-events-expected.txt: Added.
- inspector-protocol/dom/dom-remove-events.html: Added. Test with a single DOM remove event.
- inspector-protocol/dom/remove-multiple-nodes-expected.txt: Added.
- inspector-protocol/dom/remove-multiple-nodes.html: Added. Test case when multiple children
are removed at once with parentNode.textContent = "String".
- 6:09 PM Changeset in webkit [158707] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove old unused code for hypothetical LLVM intrinsics
https://bugs.webkit.org/show_bug.cgi?id=123824
Reviewed by Oliver Hunt.
- ftl/FTLIntrinsicRepository.h:
- 6:07 PM Changeset in webkit [158706] by
-
- 5 edits in trunk/Source/JavaScriptCore
FTL should support String character access operations
https://bugs.webkit.org/show_bug.cgi?id=123783
Reviewed by Oliver Hunt.
Implements:
- string.length
- string[index]
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetIndexedPropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
- 6:03 PM Changeset in webkit [158705] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix on CMake based ports with GLES.
- CMakeLists.txt:
Added OPENGLES2_LIBRARIES and OPENGLES2_INCLUDE_DIR into the includes and
libraries list.
- 5:44 PM Changeset in webkit [158704] by
-
- 9 edits in trunk/Source/WebCore
platformCALayerDeviceScaleFactor should be const
https://bugs.webkit.org/show_bug.cgi?id=123842
Reviewed by Simon Fraser.
- WebCore.exp.in:
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::LayerClient::platformCALayerDeviceScaleFactor):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerDeviceScaleFactor):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayerClient.h:
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::platformCALayerDeviceScaleFactor):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDeviceScaleFactor):
Constify PlatformCALayerClient::platformCALayerDeviceScaleFactor.
- 5:39 PM Changeset in webkit [158703] by
-
- 1 edit2 adds in trunk/LayoutTests
text-decoration-skip: ink isn't tested with underlines that don't intersect the underlined text
https://bugs.webkit.org/show_bug.cgi?id=123839
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-11-05
Reviewed by Simon Fraser.
text-decoration-skip: ink uses a mask to determine where the underline can be drawn. Right now,
there is not a test that makes sure that the mask always gets applied to the location
where the underline will get drawn.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-non-intersecting-underline-expected.html: Added.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-non-intersecting-underline.html: Added.
- 5:26 PM Changeset in webkit [158702] by
-
- 3 edits in trunk/Source/WebCore
Subresource loads should not prevent page throttling
https://bugs.webkit.org/show_bug.cgi?id=123757
Reviewed by Alexey Proskuryakov.
The page-is-loading test for inhibiting process supression is currently
too conservative, preventing supression of pages with infinitely loading
resources (commonly XHRs). Instead, just rely on the FrameLoader being
active (with hysteresis).
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::init):
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
- loader/SubresourceLoader.h:
- remove m_activityAssertion from SubresourceLoader.
- 5:13 PM Changeset in webkit [158701] by
-
- 5 edits4 adds in trunk
[mac] PDFDocumentImage is too big if PDF has a crop box smaller than the media box
https://bugs.webkit.org/show_bug.cgi?id=123840
<rdar://problem/15308765>
Reviewed by Alexey Proskuryakov.
Test: fast/images/pdf-as-image-crop-box.html
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::size):
Use the crop box when determining the size of the image.
(WebCore::PDFDocumentImage::computeBoundsForCurrentPage):
- platform/graphics/cg/PDFDocumentImage.h:
- platform/graphics/mac/PDFDocumentImageMac.mm:
(WebCore::PDFDocumentImage::computeBoundsForCurrentPage):
Get rid of m_mediaBox, since we don't need it anymore.
(WebCore::PDFDocumentImage::drawPDFPage):
PDFKit does the translation by the crop box origin for us;
if we do it additionally, we'll be painting the wrong part of the image.
So, don't do the translation here.
- fast/images/pdf-as-image-crop-box-expected.html: Added.
- fast/images/pdf-as-image-crop-box.html: Added.
- fast/images/resources/green-1x1.pdf: Added.
- fast/images/resources/red-green-2x2-cropped-to-1x1.pdf: Added.
Add a test that ensures that PDFDocumentImage respects the PDF's crop box.
red-green-2x2-cropped-to-1x1 has a 2"x2" red square with a 1"x1" green
square centered in it, a media box of 2"x2", and a crop box of 1"x1"
offset by 0.5", 0.5". green-1x1 has a 1"x1" green square. The two images
should render the same if the crop box is being respected correctly.
- 4:58 PM Changeset in webkit [158700] by
-
- 5 edits1 copy in trunk/Source/WebKit2
Begin work on decoding invocations
https://bugs.webkit.org/show_bug.cgi?id=123838
Reviewed by Dan Bernstein.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeInvocation):
Declare the type string and selector keys as constants.
(encodeObject):
Make sure to encode the class name for NSInvocations as well.
(decodeInvocation):
Figure out the local and remove method signatures and make sure that they are equal.
- Shared/API/Cocoa/WKRemoteObjectInterface.mm:
(methodArgumentTypeEncodingForSelector):
Helper function that returns the type encoding for a given selector.
(-[WKRemoteObjectInterface _methodSignatureForSelector:]):
Helper function that returns a method signature for the method with the name referred to by selector.
- Shared/API/Cocoa/WKRemoteObjectInterfaceInternal.h: Added.
Add internal header.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]):
Pass the right object to the WKRemoteObjectDecoder initializer and decode the invocation.
- WebKit2.xcodeproj/project.pbxproj:
Add internal header.
- 3:58 PM Changeset in webkit [158699] by
-
- 4 edits in trunk/Source/WebKit2
WKRemoteObjectDecoder should know which interface it's decoding for
https://bugs.webkit.org/show_bug.cgi?id=123833
Reviewed by Andreas Kling.
Move the interface identifier out into the root object body dictionary and make
the encoded invocation a sibling of it. That way we can look up the interface before
creating the decoder.
Also, manage exported objects and interfaces in a separate hash map.
- Shared/API/Cocoa/WKRemoteObjectCoder.h:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectDecoder initWithInterface:rootObjectDictionary:WebKit::]):
(decodeInvocation):
(decodeObject):
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry registerExportedObject:interface:]):
(-[WKRemoteObjectRegistry unregisterExportedObject:interface:]):
(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
(-[WKRemoteObjectRegistry _handleMessageWithName:body:]):
(-[WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]):
- 3:45 PM Changeset in webkit [158698] by
-
- 8 edits1 add in trunk/Source/WebCore
Factor index cache for NodeLists and HTMLCollections to a class
https://bugs.webkit.org/show_bug.cgi?id=123823
Reviewed by Ryosuke Niwa.
Implement index cache class that can used by NodeLists and HTMLCollections that currently
each have implementations of their own.
This patch also implements ChildNodeList and LiveNodeList using CollectionIndexCache.
HTMLCollection is will be transitioned later.
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::length):
(WebCore::ChildNodeList::item):
The client calls to cache to for indexed and size access.
(WebCore::ChildNodeList::collectionFirst):
(WebCore::ChildNodeList::collectionLast):
(WebCore::ChildNodeList::collectionTraverseForward):
(WebCore::ChildNodeList::collectionTraverseBackward):
Cache calls back to these as needed to do the actual traversal.
(WebCore::ChildNodeList::invalidateCache):
- dom/ChildNodeList.h:
- dom/CollectionIndexCache.h: Added.
Templated cache class itself.
(WebCore::::CollectionIndexCache):
(WebCore::::nodeCount):
(WebCore::::nodeBeforeCached):
(WebCore::::nodeAfterCached):
(WebCore::::nodeAt):
(WebCore::::invalidate):
- dom/LiveNodeList.cpp:
(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::traverseMatchingElementsForward):
(WebCore::LiveNodeList::collectionFirst):
(WebCore::LiveNodeList::collectionLast):
(WebCore::LiveNodeList::collectionTraverseForward):
(WebCore::LiveNodeList::collectionTraverseBackward):
(WebCore::LiveNodeList::length):
(WebCore::LiveNodeList::item):
(WebCore::LiveNodeList::invalidateCache):
- dom/LiveNodeList.h:
(WebCore::LiveNodeList::LiveNodeList):
- 3:14 PM Changeset in webkit [158697] by
-
- 6 edits in trunk
Full width semicolon is wrong in vertical text.
https://bugs.webkit.org/show_bug.cgi?id=123814
<rdar://problem/15312541>
Reviewed by Benjamin Poulain.
Source/WebCore:
The full width semicolon should always be upright.
Adding it to the list of characters that should
ignore rotation.
- platform/graphics/FontGlyphs.cpp:
(WebCore::shouldIgnoreRotation):
LayoutTests:
Extended the existing test to include the full width
semicolon.
- platform/mac/fast/text/vertical-no-sideways.html:
- platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
- platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.txt
- 3:00 PM Changeset in webkit [158696] by
-
- 4 edits in trunk/Source/WebKit2
Add support for decoding NSStrings
https://bugs.webkit.org/show_bug.cgi?id=123829
Reviewed by Andreas Kling.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeObject):
(-[WKRemoteObjectDecoder allowsKeyedCoding]):
Always return YES.
(-[WKRemoteObjectDecoder containsValueForKey:]):
Look up the key in the current dictionary.
(-[WKRemoteObjectDecoder decodeBytesForKey:returnedLength:]):
Try to get the WebData object and return its data + size.
(-[WKRemoteObjectDecoder requiresSecureCoding]):
Return YES.
(checkIfClassIsAllowed):
Check if the class or any of its superclasses are are allowed.
(validateClass):
Call checkIfClassIsAllowed and validate that the class conforms to NSSecureCoding.
(decodeObject):
Get the class name, verify that the class exists and is allowed.
Allocate and initialize an object using initWithCoder:.
(-[WKRemoteObjectDecoder decodeObjectOfClasses:forKey:]):
Set the allowed classes, look up the object in _currentDictionary and call decodeObject.
(-[WKRemoteObjectDecoder allowedClasses]):
Return _allowedClasses.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
Declare interfaceIdentifier as a constant.
(-[WKRemoteObjectRegistry _invokeMessageWithBody:]):
Decode the interface identifier.
- Shared/ImmutableDictionary.h:
(WebKit::ImmutableDictionary::get):
(WebKit::ImmutableDictionary::size):
(WebKit::ImmutableDictionary::map):
Make member functions const.
- 2:51 PM Changeset in webkit [158695] by
-
- 2 edits in trunk/Source/JavaScriptCore
ObjCCallbackFunctionImpl's NSInvocation shouldn't retain its target or arguments
https://bugs.webkit.org/show_bug.cgi?id=123822
Reviewed by Geoffrey Garen.
Using -retainArguments on ObjCCallbackFunctionImpl's NSInvocation leads to memory leaks.
We should handle retaining/releasing the target ourselves, and we should never retain the arguments.
- API/ObjCCallbackFunction.mm:
(JSC::ObjCCallbackFunctionImpl::~ObjCCallbackFunctionImpl):
(JSC::ObjCCallbackFunctionImpl::name):
(objCCallbackFunctionForInvocation):
(objCCallbackFunctionForMethod):
(objCCallbackFunctionForBlock):
- 2:44 PM Changeset in webkit [158694] by
-
- 2 edits in trunk/Source/WebKit2
Fix Mountain Lion Debug bot after r158689
Unreviewed.
It looks like WebGeolocationManagerProxy::stopUpdating() and WebGeolocationManagerProxy::processDidClose()
are racing in some cases, causing the assertion to fail.
That case is handled properly in the last if() branch of WebGeolocationManagerProxy::removeRequester().
This patch remove the overzealous assertion.
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::removeRequester):
- 2:38 PM Changeset in webkit [158693] by
-
- 3 edits in trunk/Source/WebCore
Remove unused RenderWidget::notifyWidget().
Rubber-stamped by Anders Carlsson.
- 2:30 PM Changeset in webkit [158692] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build for architectures with 4 argument registers (broken since r158681).
https://bugs.webkit.org/show_bug.cgi?id=123826
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Michael Saboff.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
(JSC::CCallHelpers::setupArguments):
- 2:04 PM Changeset in webkit [158691] by
-
- 5 edits2 adds in trunk/Source/WebKit2
Remote Layer Tree: Apply layer changes to LayerTypeCustom layers to the custom layer in the Web process, not to the CALayerHost
https://bugs.webkit.org/show_bug.cgi?id=123818
Reviewed by Anders Carlsson.
Changes to the properties of a PlatformCALayer of type LayerTypeCustom are intended
to affect the custom CALayer; however, we were bundling them up with the transaction
and applying them to the CALayerHost, leading to important properties being lost.
Instead, apply them to the Web-process-side CALayer when building the transaction.
- Shared/mac/RemoteLayerTreePropertyApplier.h: Added.
- Shared/mac/RemoteLayerTreePropertyApplier.mm: Added.
(WebKit::cgColorFromColor):
(WebKit::toCAFilterType):
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
(WebKit::RemoteLayerTreePropertyApplier::disableActionsForLayer):
Move code to apply LayerProperties to a CALayer from RemoteLayerTreeHost.
Move code to disable actions on a CALayer from RemoteLayerTreeHost.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
(WebKit::RemoteLayerTreeHost::createLayer):
Use RemoteLayerTreePropertyApplier.
Hand it a map of LayerID->CALayer so that it can look up related layers
for children and mask layers.
- WebKit2.xcodeproj/project.pbxproj:
Add RemoteLayerTreePropertyApplier.{h,mm}
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::recursiveBuildTransaction):
Upon commit, apply changes to LayerTypeCustom layers to the platform layer.
Setting children or maskLayer won't work, since we don't know about other raw CALayers.
This is OK, since nothing uses those properties on custom layers.
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.cpp:
(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
Disable actions on the root custom layer.
- 1:21 PM Changeset in webkit [158690] by
-
- 4 edits in trunk/Source/WebKit2
Begin work on a WKRemoteObjectDecoder object
https://bugs.webkit.org/show_bug.cgi?id=123819
Reviewed by Dan Bernstein.
- Shared/API/Cocoa/WKRemoteObjectCoder.h:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectDecoder initWithRootObjectDictionary:]):
Add designated initializer.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _handleMessageWithName:body:]):
If the message has the expected name and body type, pass it along to -_invokeMessageWithBody:.
(-[WKRemoteObjectRegistry _invokeMessageWithBody:]):
Create a decoder.
- 1:17 PM Changeset in webkit [158689] by
-
- 18 edits5 adds in trunk
[WK2] Add a WebKit2 API for Geolocation's highAccuracy
https://bugs.webkit.org/show_bug.cgi?id=123786
Reviewed by Darin Adler.
Source/WebKit2:
This adds support for highAccuracy Geolocation with WebKit2.
The key is to track which page/requester need what kind of geolocation
in order to change between high and low accuracy as pages run and disappear.
WebGeolocationManager and WebGeolocationManagerProxy have very similar roles
but for different sources:
-WebGeolocationManager tracks which live page require high accuracy geolocation.
When the state changes, it forward the information to the UIProcess.
-WebGeolocationManagerProxy tracks which WebContent processes needs high accuracy.
- Shared/APIClientTraits.cpp:
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKGeolocationManager.h:
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::startUpdating):
(WebKit::WebGeolocationManagerProxy::removeRequester):
(WebKit::WebGeolocationManagerProxy::setEnableHighAccuracy):
- UIProcess/WebGeolocationManagerProxy.h:
(WebKit::WebGeolocationManagerProxy::isUpdating):
(WebKit::WebGeolocationManagerProxy::isHighAccuracyEnabled):
- UIProcess/WebGeolocationManagerProxy.messages.in:
- UIProcess/WebGeolocationProvider.cpp:
(WebKit::WebGeolocationProvider::setEnableHighAccuracy):
- UIProcess/WebGeolocationProvider.h:
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::setEnableHighAccuracyForPage):
- WebProcess/Geolocation/WebGeolocationManager.h:
(WebKit::WebGeolocationManager::isUpdating):
(WebKit::WebGeolocationManager::isHighAccuracyEnabled):
- WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
(WebKit::WebGeolocationClient::setEnableHighAccuracy):
Tools:
Add basic testing for the Geolocation API (start, stop and change accuracy).
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Added.
(TestWebKitAPI::operator<<):
(TestWebKitAPI::GeolocationStateTracker::~GeolocationStateTracker):
(TestWebKitAPI::GeolocationStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationStateTracker::startUpdatingCallback):
(TestWebKitAPI::GeolocationStateTracker::stopUpdatingCallback):
(TestWebKitAPI::GeolocationStateTracker::setEnableHighAccuracyCallback):
(TestWebKitAPI::decidePolicyForGeolocationPermissionRequestCallBack):
(TestWebKitAPI::setupGeolocationProvider):
(TestWebKitAPI::setupView):
(TestWebKitAPI::GeolocationBasicStateTracker::GeolocationBasicStateTracker):
(TestWebKitAPI::GeolocationBasicStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::GeolocationBasicWithHighAccuracyStateTracker):
(TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker):
(TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker):
(TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
(TestWebKitAPI::didFinishLoadForFrame):
- TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Added.
- TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Added.
- TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Added.
- TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Added.
- WebKitTestRunner/GeolocationProviderMock.cpp:
(WTR::GeolocationProviderMock::GeolocationProviderMock):
- 1:16 PM Changeset in webkit [158688] by
-
- 10 edits in trunk
Unreviewed, rolling out r158678.
http://trac.webkit.org/changeset/158678
https://bugs.webkit.org/show_bug.cgi?id=123820
Causes a new debug assertion failure on the Mavericks test
system. (Requested by bfulgham on #webkit).
Source/WebCore:
- rendering/mathml/RenderMathMLOperator.cpp:
LayoutTests:
- TestExpectations:
- mathml/presentation/mo-stretch.html:
- platform/gtk/TestExpectations:
- platform/gtk/mathml/presentation/mo-stretch-expected.png:
- platform/gtk/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/presentation/mo-stretch-expected.png:
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- 1:04 PM Changeset in webkit [158687] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix register allocation inside control flow in GetByVal String
https://bugs.webkit.org/show_bug.cgi?id=123816
Reviewed by Geoffrey Garen.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
- 1:03 PM Changeset in webkit [158686] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove FTL::LowerDFGToLLVM::compileJSConstant()
https://bugs.webkit.org/show_bug.cgi?id=123817
Reviewed by Geoffrey Garen.
- ftl/FTLLowerDFGToLLVM.cpp:
- 12:56 PM Changeset in webkit [158685] by
-
- 6 edits in trunk
Implement more NSCoder methods
https://bugs.webkit.org/show_bug.cgi?id=123815
Reviewed by Dan Bernstein.
Source/WebKit2:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeObject):
Assert that object is not nil.
(createEncodedObject):
Handle nil objects.
(-[WKRemoteObjectEncoder encodeValueOfObjCType:at:]):
Call the right object stream encoding function based on the object type.
(-[WKRemoteObjectEncoder encodeBool:forKey:]):
(-[WKRemoteObjectEncoder encodeInt64:forKey:]):
(-[WKRemoteObjectEncoder encodeDouble:forKey:]):
Create APIObjects and add them to the current dictionary.
Tools:
Add a method that takes an NSArray, an NSDictionary and an NSURLRequest.
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
(-[BundleObject testMethodWithArray:dictionary:request:]):
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
- 11:34 AM Changeset in webkit [158684] by
-
- 2 edits in trunk/Source/WebKit2
Encode the class name
https://bugs.webkit.org/show_bug.cgi?id=123813
Reviewed by Dan Bernstein.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeObject):
Get the Class using -[NSObject classForCoder] and encode its name in the object dictionary.
- 11:24 AM Changeset in webkit [158683] by
-
- 2 edits in trunk/Source/WebKit2
Clean up the WKRemoteObjectEncoder code
https://bugs.webkit.org/show_bug.cgi?id=123811
Reviewed by Dan Bernstein.
Add a new object stream array to be used for the non-keyed encoding values
and free functions for encoding values to the object stream. Simplify object encoding
by moving the dictionary creation out into a separate function and ditching the block based methods.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(ensureObjectStream):
Add helper function to create an object stream.
(encodeToObjectStream):
Add overloads for encoding values into the object streams.
(encodeInvocation):
Add helper function for encoding an NSInvocation.
(encodeObject):
Call encodeInvocation if needed, otherwise just use encodeWithCoder:.
(createEncodedObject):
Helper function that sets up a dictionary, encodes the object into the dictionary and then returns the dictionary.
(-[WKRemoteObjectEncoder encodeObject:forKey:]):
Call createEncodedObject.
- 11:16 AM Changeset in webkit [158682] by
-
- 4 edits2 adds in trunk
ASSERTION FAILED: isHTMLTitleElement(m_titleElement.get()) in WebCore::Document::setTitle
https://bugs.webkit.org/show_bug.cgi?id=122092
Reviewed by Darin Adler.
Source/WebCore:
Remove a bogus assert in Document::setTitle().
m_titleElement can be either of HTMLTitleElement or SVGTitleElement. The assertion was wrong.
Backported from Blink:
https://src.chromium.org/viewvc/blink?revision=158620&view=revision
Test: svg/custom/title-assertion.html
- dom/Document.cpp:
(WebCore::Document::setTitle):
- svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedInto):
LayoutTests:
- svg/custom/title-assertion-expected.txt: Added.
- svg/custom/title-assertion.html: Added.
- 10:56 AM Changeset in webkit [158681] by
-
- 13 edits in trunk/Source/JavaScriptCore
FTL should support PutById
https://bugs.webkit.org/show_bug.cgi?id=123784
Reviewed by Geoffrey Garen.
- ftl/FTLAbbreviations.h:
(JSC::FTL::buildCall):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCompile.cpp:
(JSC::FTL::generateICFastPath):
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLInlineCacheDescriptor.h:
(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
(JSC::FTL::GetByIdDescriptor::GetByIdDescriptor):
(JSC::FTL::PutByIdDescriptor::PutByIdDescriptor):
(JSC::FTL::PutByIdDescriptor::ecmaMode):
(JSC::FTL::PutByIdDescriptor::putKind):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compilePutById):
- ftl/FTLOutput.h:
(JSC::FTL::Output::call):
- ftl/FTLSlowPathCall.cpp:
(JSC::FTL::callOperation):
- ftl/FTLSlowPathCall.h:
- ftl/FTLState.h:
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArguments):
- runtime/Executable.h:
(JSC::ScriptExecutable::ecmaMode):
- 10:53 AM Changeset in webkit [158680] by
-
- 2 edits in trunk/Source/JavaScriptCore
GetById->GetByOffset and PutById->PutByOffset folding should mark haveStructures since it may result in structure transition watchpoints
https://bugs.webkit.org/show_bug.cgi?id=123788
Reviewed by Geoffrey Garen.
haveStructures is true if there are any currentlyKnownStructures that have
interesting values, since that's the only time when clobbering needs to do things.
It's a really important compile-time optimization. But that also means that anytime
we might cause currentlyKnownStructures to get set - like when we might insert some
structure transition watchpoints - we need to set haveStructures. We were forgetting
to do that for GetById->GetByOffset and PutById->PutByOffset because, I guess, we
forgot that those might insert structure transition watchpoints.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- 10:50 AM Changeset in webkit [158679] by
-
- 3 edits in trunk/Tools
Update ReducedFTL
https://bugs.webkit.org/show_bug.cgi?id=123805
Reviewed by Sam Weinig.
- Make ReducedFTL build with debug info.
- Give ReducedFTL a --loop mode that runs everything in a loop. Great for finding memory leaks and attaching a profiler.
- Reorder the passes so that they match the FTL.
- Make it possible to change the backend opt level and enable the fast isel.
- ReducedFTL/ReducedFTL.c:
(usage):
(roundUpSize):
(mmAllocateCodeSection):
(main):
- ReducedFTL/build.sh:
- 10:06 AM Changeset in webkit [158678] by
-
- 10 edits in trunk
[MathML] Poor spacing around delimiters in MathML Torture Test 14
https://bugs.webkit.org/show_bug.cgi?id=122837
Reviewed by Brent Fulgham.
Instead of stretching the vertical bar with the stretchable version, just repeat
the normal vertical bar. This follows what Gecko does when rendering tall vertical
bars and also works around an issue with STIX fonts leading to poor spacing in
formulas.
Source/WebCore:
- rendering/mathml/RenderMathMLOperator.cpp: Stretch the vertical bar with the
normal variant.
LayoutTests:
- mathml/presentation/mo-stretch.html: Reworked this test to show
stretching of all stretchable characters, which reveals a bug with
the double vertical bar (covered by http://wkbug.com/123543).
- platform/gtk/TestExpectations:
- platform/gtk/mathml/presentation/mo-stretch-expected.png:
- platform/gtk/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/presentation/mo-stretch-expected.png:
- platform/mac/mathml/presentation/mo-stretch-expected.txt:
- 10:05 AM Changeset in webkit [158677] by
-
- 3 edits in trunk/Source/JavaScriptCore
[mips] Make regTx registers match between JSInterfaceJIT and GPRInfo.
https://bugs.webkit.org/show_bug.cgi?id=123807
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Mark Lam.
- jit/GPRInfo.h:
(JSC::GPRInfo::toIndex):
- jit/JSInterfaceJIT.h:
- 10:02 AM Changeset in webkit [158676] by
-
- 3 edits3 adds in trunk
XSSAuditor should catch reflected srcdoc properties even without a <frame> tag injection
From Blink r160615 by <tsepez@chromium.org>
https://src.chromium.org/viewvc/blink?view=rev&revision=160615
Source/WebCore:
Test: http/tests/security/xssAuditor/iframe-srcdoc-property-blocked.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterIframeToken):
LayoutTests:
- http/tests/security/xssAuditor/iframe-srcdoc-property-blocked-expected.txt: Added.
- http/tests/security/xssAuditor/iframe-srcdoc-property-blocked.html: Added.
- http/tests/security/xssAuditor/resources/echo-frame-src.pl: Added.
- 8:23 AM Changeset in webkit [158675] by
-
- 2 edits6 adds in trunk/LayoutTests
Unreviewed EFL gardening
Add baselines for tests marked as missing.
- platform/efl-wk1/TestExpectations:
- platform/efl/css3/masking/mask-luminance-png-expected.txt: Added.
- platform/efl/fast/css/color-correction-untagged-images-expected.png: Added.
- platform/efl/fast/css/color-correction-untagged-images-expected.txt: Added.
- platform/efl/fast/regions/iframe-html-collected-expected.txt: Added.
- platform/efl/fast/repaint/hover-pseudo-borders-expected.png: Added.
- platform/efl/fast/repaint/hover-pseudo-borders-expected.txt: Added.
- 8:16 AM Changeset in webkit [158674] by
-
- 8 edits in trunk/Tools
AX: switch DRT AX methods to use nullptr
https://bugs.webkit.org/show_bug.cgi?id=123773
Reviewed by Andreas Kling.
Switch AX related code in DRT and WKTR to use nullptr.
- DumpRenderTree/AccessibilityUIElement.cpp:
(AccessibilityUIElement::startTextMarker):
(AccessibilityUIElement::endTextMarker):
- DumpRenderTree/mac/AccessibilityControllerMac.mm:
(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::uiElementAttributeValue):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::speak):
(AccessibilityUIElement::classList):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::rangeForLine):
(AccessibilityUIElement::rangeForPosition):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):
(AccessibilityUIElement::pathDescription):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::url):
(AccessibilityUIElement::textMarkerRangeForElement):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::previousTextMarker):
(AccessibilityUIElement::nextTextMarker):
(AccessibilityUIElement::stringForTextMarkerRange):
(AccessibilityUIElement::textMarkerRangeForMarkers):
(AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::accessibilityElementForTextMarker):
(AccessibilityUIElement::startTextMarker):
(AccessibilityUIElement::endTextMarker):
(AccessibilityUIElement::supportedActions):
(AccessibilityUIElement::mathPostscriptsDescription):
(AccessibilityUIElement::mathPrescriptsDescription):
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::accessibleElementById):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::startTextMarker):
(WTR::AccessibilityUIElement::endTextMarker):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::findAccessibleObjectById):
(WTR::AccessibilityController::accessibleElementById):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::classList):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR::AccessibilityUIElement::startTextMarker):
(WTR::AccessibilityUIElement::endTextMarker):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
(WTR::AccessibilityUIElement::pathDescription):
(WTR::AccessibilityUIElement::supportedActions):
- 8:06 AM Changeset in webkit [158673] by
-
- 1 edit1 delete in trunk/Source/WebCore
Delete maketokenizer.
https://bugs.webkit.org/show_bug.cgi?id=115155
Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-05
Reviewed by Zoltan Herczeg.
This script was used to generate the old flex based CSS tokenizer. It
was replaced by a custom tokenizer in r106217 but the script wasn't
removed. Since there is no mention of it in the original bug nor any
reference to maketokenizer in our build files, it's probably an
oversight.
Merge from blink:
https://chromium.googlesource.com/chromium/blink/+/2a1c8aaf867f707ccdcd8893446e907e2aa2e1c2
- css/maketokenizer: Removed.
- 7:34 AM Changeset in webkit [158672] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r158315): Fix register mixup in JIT::compileOpCall.
https://bugs.webkit.org/show_bug.cgi?id=123799
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Mark Lam.
Changeset r158315 is crashing architectures where JSInterfaceJIT::regT3 is
different from GPRInfo::regT3. This is the case for MIPS architecture.
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
- 7:33 AM Changeset in webkit [158671] by
-
- 2 edits in trunk
Remove leftover Qt related things from WebKitMacros.cmake
https://bugs.webkit.org/show_bug.cgi?id=123798
Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-05
Reviewed by Anders Carlsson.
- Source/cmake/WebKitMacros.cmake:
- 7:32 AM Changeset in webkit [158670] by
-
- 4 edits in trunk/Source/JavaScriptCore
[mips] Fix build for MIPS platforms.
https://bugs.webkit.org/show_bug.cgi?id=123796
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Michael Saboff.
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::linkCode): Add specific MIPS call to relocateJumps.
- assembler/MIPSAssembler.h: Remove executableCopy (because of r157690) and set relocateJumps function public.
(JSC::MIPSAssembler::firstRegister):
(JSC::MIPSAssembler::lastRegister):
(JSC::MIPSAssembler::firstFPRegister):
(JSC::MIPSAssembler::lastFPRegister):
(JSC::MIPSAssembler::buffer): Needed since r157690.
- assembler/MacroAssemblerMIPS.h: Add framePointerRegister.
(JSC::MacroAssemblerMIPS::revertJumpReplacementToPatchableBranchPtrWithPatch): Remove unused parameter warning.
- 7:31 AM Changeset in webkit [158669] by
-
- 2 edits in trunk/Tools
Remove leftover Qt related things from the flakiness_dashboard
https://bugs.webkit.org/show_bug.cgi?id=123800
Patch by László Langó <laszlo.lango@frontendart.com> on 2013-11-05
Reviewed by Anders Carlsson.
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
- 7:30 AM Changeset in webkit [158668] by
-
- 1 edit140 moves1 add in trunk/LayoutTests
[CSS Regions] Move cssom related tests into fast/regions/cssom
https://bugs.webkit.org/show_bug.cgi?id=123705
Reviewed by Sam Weinig.
Move tests related to http://dev.w3.org/csswg/css-regions/#cssom_view_and_css_regions into their own folder and adjust paths for resources used in tests.
They test the same functionality: CSSRegions and CSSOM-view.
- fast/regions/cssom/element-region-overset-state-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-expected.txt.
- fast/regions/cssom/element-region-overset-state-negative-letter-spacing-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt.
- fast/regions/cssom/element-region-overset-state-negative-letter-spacing.html: Renamed from LayoutTests/fast/regions/element-region-overset-state-negative-letter-spacing.html.
- fast/regions/cssom/element-region-overset-state-vertical-rl-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl-expected.txt.
- fast/regions/cssom/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt.
- fast/regions/cssom/element-region-overset-state-vertical-rl-negative-letter-spacing.html: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing.html.
- fast/regions/cssom/element-region-overset-state-vertical-rl.html: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl.html.
- fast/regions/cssom/element-region-overset-state.html: Renamed from LayoutTests/fast/regions/element-region-overset-state.html.
- fast/regions/cssom/flowed-content-bounding-client-rect-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-expected.txt.
- fast/regions/cssom/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt.
- fast/regions/cssom/flowed-content-bounding-client-rect-horizontal-bt.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html.
- fast/regions/cssom/flowed-content-bounding-client-rect-vertical-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt.
- fast/regions/cssom/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt.
- fast/regions/cssom/flowed-content-bounding-client-rect-vertical-rl.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical-rl.html.
- fast/regions/cssom/flowed-content-bounding-client-rect-vertical.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical.html.
- fast/regions/cssom/flowed-content-bounding-client-rect.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect.html.
- fast/regions/cssom/flowed-content-transform-bounding-client-rect-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-transform-bounding-client-rect-expected.txt.
- fast/regions/cssom/flowed-content-transform-bounding-client-rect.html: Renamed from LayoutTests/fast/regions/flowed-content-transform-bounding-client-rect.html.
- fast/regions/cssom/flowed-inline-content-bounding-client-rect-expected.txt: Renamed from LayoutTests/fast/regions/flowed-inline-content-bounding-client-rect-expected.txt.
- fast/regions/cssom/flowed-inline-content-bounding-client-rect.html: Renamed from LayoutTests/fast/regions/flowed-inline-content-bounding-client-rect.html.
- fast/regions/cssom/get-region-flow-ranges-absolute-pos-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-absolute-pos-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-absolute-pos.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-absolute-pos.html.
- fast/regions/cssom/get-region-flow-ranges-content-nodes-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-content-nodes-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-content-nodes.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-content-nodes.html.
- fast/regions/cssom/get-region-flow-ranges-display-none-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-display-none-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-display-none.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-display-none.html.
- fast/regions/cssom/get-region-flow-ranges-empty-regions-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-empty-regions-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-empty-regions.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-empty-regions.html.
- fast/regions/cssom/get-region-flow-ranges-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-fixed-pos-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-fixed-pos-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-fixed-pos.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-fixed-pos.html.
- fast/regions/cssom/get-region-flow-ranges-horiz-bt-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-horiz-bt-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-horiz-bt.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-horiz-bt.html.
- fast/regions/cssom/get-region-flow-ranges-inline-only-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-only-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-inline-only.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-only.html.
- fast/regions/cssom/get-region-flow-ranges-inline-svg-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-svg-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-inline-svg.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-svg.html.
- fast/regions/cssom/get-region-flow-ranges-text-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-text-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-text-vert-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text-vert-lr.html.
- fast/regions/cssom/get-region-flow-ranges-text.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text.html.
- fast/regions/cssom/get-region-flow-ranges-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-lr-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-vert-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-lr.html.
- fast/regions/cssom/get-region-flow-ranges-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-rl-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-vert-rl.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-rl.html.
- fast/regions/cssom/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-writing-modes-rl-rb-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr.html.
- fast/regions/cssom/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt.
- fast/regions/cssom/get-region-flow-ranges-writing-modes-tb-rl-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr.html.
- fast/regions/cssom/get-region-flow-ranges.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges.html.
- fast/regions/cssom/get-regions-by-content-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-expected.txt.
- fast/regions/cssom/get-regions-by-content-horiz-bt-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-bt-expected.txt.
- fast/regions/cssom/get-regions-by-content-horiz-bt.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-bt.html.
- fast/regions/cssom/get-regions-by-content-horiz-tb-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-tb-expected.txt.
- fast/regions/cssom/get-regions-by-content-horiz-tb.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-tb.html.
- fast/regions/cssom/get-regions-by-content-pseudo-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-pseudo-expected.txt.
- fast/regions/cssom/get-regions-by-content-pseudo.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-pseudo.html.
- fast/regions/cssom/get-regions-by-content-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-lr-expected.txt.
- fast/regions/cssom/get-regions-by-content-vert-lr.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-lr.html.
- fast/regions/cssom/get-regions-by-content-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-rl-expected.txt.
- fast/regions/cssom/get-regions-by-content-vert-rl.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-rl.html.
- fast/regions/cssom/get-regions-by-content.html: Renamed from LayoutTests/fast/regions/get-regions-by-content.html.
- fast/regions/cssom/get-regions-by-content2-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content2-expected.txt.
- fast/regions/cssom/get-regions-by-content2.html: Renamed from LayoutTests/fast/regions/get-regions-by-content2.html.
- fast/regions/cssom/offsetLeft-offsetTop-in-multiple-regions-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-multiple-regions-expected.txt.
- fast/regions/cssom/offsetLeft-offsetTop-in-multiple-regions.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-multiple-regions.html.
- fast/regions/cssom/offsetLeft-offsetTop-in-region-absolute-sticky-fixed-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed-expected.txt.
- fast/regions/cssom/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html.
- fast/regions/cssom/offsetLeft-offsetTop-in-region-float-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float-expected.txt.
- fast/regions/cssom/offsetLeft-offsetTop-in-region-float-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl-expected.txt.
- fast/regions/cssom/offsetLeft-offsetTop-in-region-float-vert-rl.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html.
- fast/regions/cssom/offsetLeft-offsetTop-in-region-float.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float.html.
- fast/regions/cssom/offsetLeft-offsetTop-inlines-region-in-element-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-inlines-region-in-element-expected.txt.
- fast/regions/cssom/offsetLeft-offsetTop-inlines-region-in-element.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-inlines-region-in-element.html.
- fast/regions/cssom/offsetParent-body-in-flow-thread-expected.txt: Renamed from LayoutTests/fast/regions/offsetParent-body-in-flow-thread-expected.txt.
- fast/regions/cssom/offsetParent-body-in-flow-thread.html: Renamed from LayoutTests/fast/regions/offsetParent-body-in-flow-thread.html.
- fast/regions/cssom/offsetParent-in-flow-thread-expected.txt: Renamed from LayoutTests/fast/regions/offsetParent-in-flow-thread-expected.txt.
- fast/regions/cssom/offsetParent-in-flow-thread.html: Renamed from LayoutTests/fast/regions/offsetParent-in-flow-thread.html.
- fast/regions/cssom/overset-break-expected.txt: Renamed from LayoutTests/fast/regions/overset-break-expected.txt.
- fast/regions/cssom/overset-break-nested-expected.txt: Renamed from LayoutTests/fast/regions/overset-break-nested-expected.txt.
- fast/regions/cssom/overset-break-nested.html: Renamed from LayoutTests/fast/regions/overset-break-nested.html.
- fast/regions/cssom/overset-break-with-sibling-expected.txt: Renamed from LayoutTests/fast/regions/overset-break-with-sibling-expected.txt.
- fast/regions/cssom/overset-break-with-sibling.html: Renamed from LayoutTests/fast/regions/overset-break-with-sibling.html.
- fast/regions/cssom/overset-break.html: Renamed from LayoutTests/fast/regions/overset-break.html.
- fast/regions/cssom/region-range-for-box-crash-expected.txt: Renamed from LayoutTests/fast/regions/region-range-for-box-crash-expected.txt.
- fast/regions/cssom/region-range-for-box-crash.html: Renamed from LayoutTests/fast/regions/region-range-for-box-crash.html.
- fast/regions/cssom/webkit-named-flow-collection-crash-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-crash-expected.txt.
- fast/regions/cssom/webkit-named-flow-collection-crash.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-crash.html.
- fast/regions/cssom/webkit-named-flow-collection-empty-getters-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-empty-getters-expected.txt.
- fast/regions/cssom/webkit-named-flow-collection-empty-getters.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-empty-getters.html.
- fast/regions/cssom/webkit-named-flow-collection-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-expected.txt.
- fast/regions/cssom/webkit-named-flow-collection.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection.html.
- fast/regions/cssom/webkit-named-flow-event-add-to-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt.
- fast/regions/cssom/webkit-named-flow-event-add-to-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-add-to-flow.html.
- fast/regions/cssom/webkit-named-flow-event-auto-height-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-auto-height-expected.txt.
- fast/regions/cssom/webkit-named-flow-event-auto-height.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-auto-height.html.
- fast/regions/cssom/webkit-named-flow-event-crash-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-crash-expected.txt.
- fast/regions/cssom/webkit-named-flow-event-crash.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-crash.html.
- fast/regions/cssom/webkit-named-flow-event-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-expected.txt.
- fast/regions/cssom/webkit-named-flow-event-no-regions-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-no-regions-expected.txt.
- fast/regions/cssom/webkit-named-flow-event-no-regions.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-no-regions.html.
- fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt.
- fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html.
- fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt.
- fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-overset-change.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html.
- fast/regions/cssom/webkit-named-flow-event-remove-from-dom-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt.
- fast/regions/cssom/webkit-named-flow-event-remove-from-dom.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-dom.html.
- fast/regions/cssom/webkit-named-flow-event-remove-from-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt.
- fast/regions/cssom/webkit-named-flow-event-remove-from-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-flow.html.
- fast/regions/cssom/webkit-named-flow-event-target-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-target-expected.txt.
- fast/regions/cssom/webkit-named-flow-event-target.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-target.html.
- fast/regions/cssom/webkit-named-flow-event-to-null-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-to-null-expected.txt.
- fast/regions/cssom/webkit-named-flow-event-to-null.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-to-null.html.
- fast/regions/cssom/webkit-named-flow-event.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event.html.
- fast/regions/cssom/webkit-named-flow-existing-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-existing-flow-expected.txt.
- fast/regions/cssom/webkit-named-flow-existing-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-existing-flow.html.
- fast/regions/cssom/webkit-named-flow-first-empty-region-index-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt.
- fast/regions/cssom/webkit-named-flow-first-empty-region-index.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-first-empty-region-index.html.
- fast/regions/cssom/webkit-named-flow-flow-added-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-flow-added-expected.txt.
- fast/regions/cssom/webkit-named-flow-flow-added.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-flow-added.html.
- fast/regions/cssom/webkit-named-flow-get-content-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-content-expected.txt.
- fast/regions/cssom/webkit-named-flow-get-content.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-content.html.
- fast/regions/cssom/webkit-named-flow-get-regions-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions-expected.txt.
- fast/regions/cssom/webkit-named-flow-get-regions-pseudo-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions-pseudo-expected.txt.
- fast/regions/cssom/webkit-named-flow-get-regions-pseudo.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions-pseudo.html.
- fast/regions/cssom/webkit-named-flow-get-regions.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions.html.
- fast/regions/cssom/webkit-named-flow-invalid-name-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-invalid-name-expected.txt.
- fast/regions/cssom/webkit-named-flow-invalid-name.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-invalid-name.html.
- fast/regions/cssom/webkit-named-flow-modified-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-modified-flow-expected.txt.
- fast/regions/cssom/webkit-named-flow-modified-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-modified-flow.html.
- fast/regions/cssom/webkit-named-flow-name-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-name-expected.txt.
- fast/regions/cssom/webkit-named-flow-name.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-name.html.
- fast/regions/cssom/webkit-named-flow-non-existing-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-non-existing-flow-expected.txt.
- fast/regions/cssom/webkit-named-flow-non-existing-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-non-existing-flow.html.
- fast/regions/cssom/webkit-named-flow-overset-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-overset-expected.txt.
- fast/regions/cssom/webkit-named-flow-overset.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-overset.html.
- fast/regions/cssom/webkit-named-flow-removed-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-removed-flow-expected.txt.
- fast/regions/cssom/webkit-named-flow-removed-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-removed-flow.html.
- fast/regions/cssom/webkit-named-flow-same-object-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-same-object-expected.txt.
- fast/regions/cssom/webkit-named-flow-same-object.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-same-object.html.
- 7:25 AM Changeset in webkit [158667] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Unbreaking GCC builds.
- html/HTMLCollection.cpp:
(WebCore::isMatchingElement): This inline function is not a template anymore.
- 6:50 AM Changeset in webkit [158666] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Two tests pass after r158575 and r15856.
- platform/gtk/TestExpectations: Removed passing tests.
- 6:35 AM Changeset in webkit [158665] by
-
- 4 edits in trunk/Source/WebCore
Make it compile.
- dom/LiveNodeList.h:
(WebCore::LiveNodeList::LiveNodeList):
(WebCore::LiveNodeList::~LiveNodeList):
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::adoptDocument):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::~HTMLCollection):
- 5:40 AM Changeset in webkit [158664] by
-
- 5 edits in trunk
[EFL] accessibility/svg-group-element-with-title.html is failing
https://bugs.webkit.org/show_bug.cgi?id=114151
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-11-05
Reviewed by Mario Sanchez Prada.
Tools:
atk_component_ref_accessible_at_point(), utilized in
AccessibilityUIElement::elementAtPoint(), is expected to 'get a reference to the
accessible child, if one exists, at the coordinate point specified' and not
explicitly return self in case of lack of child elements. This contradicts with
expected behavior of elementAtPoint(). Therefore, elementAtPoint() is
changed to return self regardless of coordinates specified, provided no child
element could be retrieved, effectively mimicing the behaviour of equivalent
Mac implementation in accessibilityHitTest().
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::elementAtPoint): Fixed.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::elementAtPoint): Fixed.
LayoutTests:
Removed failure expectation.
- platform/efl/TestExpectations: The test is no longer failing.
- 5:20 AM Changeset in webkit [158663] by
-
- 25 edits in trunk/Source/WebCore
HTMLCollection should not be NodeList
https://bugs.webkit.org/show_bug.cgi?id=123794
Reviewed by Andreas Kling.
HTMLCollection and NodeList are unrelated types in DOM yet our HTMLCollection inherits NodeList
for code sharing reasons. While some code does get shared the types are sufficiently different
that this results in lots of unnecessary branches, complexity and general awkwardness. Code sharing
can be better achieved by means other than inheritance.
This patch splits HTMLCollection from NodeList by copy-pasting and eliminating resulting redundancies.
Sharing comes later.
- dom/Attr.cpp:
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
- dom/ClassNodeList.cpp:
(WebCore::ClassNodeList::~ClassNodeList):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::childrenChanged):
(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::radioNodeList):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::registerNodeList):
(WebCore::Document::unregisterNodeList):
(WebCore::Document::registerCollection):
(WebCore::Document::unregisterCollection):
(WebCore::Document::ensureCachedCollection):
Add separate functions and map for registering HTMLCollections.
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::Element::ensureCachedHTMLCollection):
(WebCore::Element::cachedHTMLCollection):
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeList::rootNode):
(WebCore::isMatchingElement):
(WebCore::LiveNodeList::iterateForPreviousElement):
(WebCore::LiveNodeList::itemBefore):
(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::traverseMatchingElementsForwardToOffset):
(WebCore::LiveNodeList::traverseLiveNodeListFirstElement):
(WebCore::LiveNodeList::traverseLiveNodeListForwardToOffset):
(WebCore::LiveNodeList::isLastItemCloserThanLastOrCachedItem):
(WebCore::LiveNodeList::isFirstItemCloserThanCachedItem):
(WebCore::LiveNodeList::length):
(WebCore::LiveNodeList::item):
(WebCore::LiveNodeList::elementBeforeOrAfterCachedElement):
This code used to live in HTMLCollection.cpp. Copy-paste here and remove all branches not needed for NodeLists.
(WebCore::LiveNodeList::invalidateCache):
NodeLists have no name caches.
- dom/LiveNodeList.h:
(WebCore::LiveNodeList::LiveNodeList):
(WebCore::LiveNodeList::~LiveNodeList):
(WebCore::LiveNodeList::isRootedAtDocument):
(WebCore::LiveNodeList::type):
(WebCore::LiveNodeList::invalidateCache):
(WebCore::LiveNodeList::setCachedElement):
Merge LiveNodeListBase and LiveNodeList.
Remove fields and code supporting HTMLCollection.
(WebCore::shouldInvalidateTypeOnAttributeChange):
Move to global scope. This function is used both HTMLCollections and LiveNodeLists.
- dom/NameNodeList.cpp:
(WebCore::NameNodeList::~NameNodeList):
- dom/NameNodeList.h:
(WebCore::NameNodeList::create):
- dom/Node.cpp:
(WebCore::shouldInvalidateNodeListCachesForAttr):
(WebCore::Document::shouldInvalidateNodeListAndCollectionCaches):
(WebCore::Document::invalidateNodeListAndCollectionCaches):
(WebCore::Node::invalidateNodeListAndCollectionCachesInAncestors):
(WebCore::NodeListsNodeData::invalidateCaches):
- dom/Node.h:
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
(WebCore::NodeListsNodeData::addCachedCollection):
(WebCore::NodeListsNodeData::cachedCollection):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCacheWithName):
(WebCore::NodeListsNodeData::removeCachedCollection):
(WebCore::NodeListsNodeData::isEmpty):
(WebCore::NodeListsNodeData::adoptDocument):
(WebCore::NodeListsNodeData::namedCollectionKey):
(WebCore::NodeListsNodeData::namedNodeListKey):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList):
Add separate cache for HTMLCollections.
- dom/TagNodeList.cpp:
(WebCore::TagNodeList::TagNodeList):
(WebCore::TagNodeList::~TagNodeList):
- dom/TagNodeList.h:
(WebCore::TagNodeList::create):
(WebCore::HTMLTagNodeList::create):
- html/CollectionType.h:
Remove NodeList types.
- html/HTMLCollection.cpp:
(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::rootNode):
(WebCore::isMatchingElement):
(WebCore::HTMLCollection::iterateForPreviousElement):
(WebCore::HTMLCollection::itemBefore):
(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::traverseMatchingElementsForwardToOffset):
(WebCore::HTMLCollection::isLastItemCloserThanLastOrCachedItem):
(WebCore::HTMLCollection::isFirstItemCloserThanCachedItem):
(WebCore::HTMLCollection::setCachedElement):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::elementBeforeOrAfterCachedElement):
(WebCore::HTMLCollection::traverseFirstElement):
(WebCore::HTMLCollection::traverseNextElement):
(WebCore::HTMLCollection::traverseForwardToOffset):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::invalidateIdNameCacheMaps):
(WebCore::HTMLCollection::namedItem):
Remove NodeList specific branches and functions.
LiveNodeListBase functions are now HTMLCollection functions.
- html/HTMLCollection.h:
(WebCore::HTMLCollection::isRootedAtDocument):
(WebCore::HTMLCollection::invalidationType):
(WebCore::HTMLCollection::type):
(WebCore::HTMLCollection::ownerNode):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::document):
(WebCore::HTMLCollection::overridesItemAfter):
(WebCore::HTMLCollection::isElementCacheValid):
(WebCore::HTMLCollection::cachedElement):
(WebCore::HTMLCollection::cachedElementOffset):
(WebCore::HTMLCollection::isLengthCacheValid):
(WebCore::HTMLCollection::cachedLength):
(WebCore::HTMLCollection::setLengthCache):
(WebCore::HTMLCollection::setCachedElement):
(WebCore::HTMLCollection::isItemRefElementsCacheValid):
(WebCore::HTMLCollection::setItemRefElementsCacheValid):
(WebCore::HTMLCollection::rootType):
(WebCore::HTMLCollection::hasNameCache):
(WebCore::HTMLCollection::setHasNameCache):
Copy-paste functions and fields from former LiveNodeListBase.
- html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::~HTMLNameCollection):
- html/LabelableElement.cpp:
(WebCore::LabelableElement::labels):
- html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::~LabelsNodeList):
- html/LabelsNodeList.h:
- html/RadioNodeList.cpp:
(WebCore::RadioNodeList::~RadioNodeList):
- html/RadioNodeList.h:
(WebCore::RadioNodeList::create):
- 5:02 AM Changeset in webkit [158662] by
-
- 4 edits in trunk/Source/WebCore
[GTK] Add stubs for missing symbols in dom bindings
https://bugs.webkit.org/show_bug.cgi?id=123663
Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-05
Reviewed by Carlos Garcia Campos.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_head_element_get_profile):
(webkit_dom_html_head_element_set_profile):
(webkit_dom_processing_instruction_get_data):
(webkit_dom_processing_instruction_set_data):
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols:
- 2:48 AM Changeset in webkit [158661] by
-
- 2 edits in trunk/Source/WebCore
Main thread tasks in ThreadableBlobRegistry should use std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=122946
Reviewed by Darin Adler.
The new BlobRegistryContext objects don't have to be adopted into OwnPtr and then have OwnPtr's leaked pointer
passed into the WTF::callOnMainThread call - the pointer to the new heap-allocated object is passed in directly,
with the object ending up being managed by std::unique_ptr in the designated main thread task.
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::registerBlobURLTask):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::registerBlobURLFromTask):
(WebCore::unregisterBlobURLTask):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
- 2:17 AM Changeset in webkit [158660] by
-
- 2 edits in trunk/LayoutTests
[EFL] Update a test expected result.
https://bugs.webkit.org/show_bug.cgi?id=123792
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-05
Reviewed by Gyuyoung Kim.
Need to update some length properties in this expected file.
The test expected reseult is mismatched with return-values of eval() method in LayoutTests/resources/js-test-pre.js.
- platform/efl/js/dom/constructor-length-expected.txt:
- 1:39 AM Changeset in webkit [158659] by
-
- 5 edits in trunk
[CSS] Enable css-image-orientation on EFL and GTK ports.
https://bugs.webkit.org/show_bug.cgi?id=123698
Reviewed by Beth Dakin.
Source/WebCore:
r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
when enabling css-image-orientation. This fixes those wrong implementation as well as enables it on EFL
and GTK ports by default.
Test: fast/css/image-orientation/image-orientation.html
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::updateSize):
Tools:
r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
when enabling css-image-orientaiton. This fixes those wrong implementation as well as enables it on EFL
and GTK ports by default.
- Scripts/webkitperl/FeatureList.pm:
- 1:35 AM Changeset in webkit [158658] by
-
- 2 edits in trunk/LayoutTests
[EFL] accessibility/tabindex-elements-are-accessible.html is failing after r158195
https://bugs.webkit.org/show_bug.cgi?id=123741
Unreviewed EFL gardening.
Patch by Artur Moryc <a.moryc@samsung.com> on 2013-11-05
- platform/efl/TestExpectations: adding failing test
- 1:29 AM Changeset in webkit [158657] by
-
- 8 edits in trunk/Source/WebCore
RenderEmbeddedObject shouldn't know about fallback content.
<https://webkit.org/b/123781>
Stop caching the presence of fallback (DOM) content in a flag on
RenderEmbeddedObject and have SubframeLoader fetch it directly from
HTMLObjectElement instead.
Also made SubframeLoader::requestObject() take the owner element
by reference since we don't support owner-less embedded objects.
Reviewed by Antti Koivisto.
- 1:08 AM Changeset in webkit [158656] by
-
- 17 edits13 deletes in trunk/Source
[GStreamer] Remove NATIVE_FULLSCREEN_VIDEO support
https://bugs.webkit.org/show_bug.cgi?id=123437
Reviewed by Philippe Normand.
Source/WebCore:
Removed some dead code as no GStreamer port is using the native
fullscreen video support.
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- PlatformGTK.cmake: Removed compilation of deleted files.
- platform/graphics/MediaPlayer.h: Removed structures related to
GStreamer and NATIVE_FULLSCREEN_VIDEO.
- platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp: Removed.
- platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.h: Removed.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: Removed.
- platform/graphics/gstreamer/GStreamerGWorld.h: Removed.
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Removed
gst/video/video.h include.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::platformMedia):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Removed code related to GStreamer and NATIVE_FULLSCREEN_VIDEO.
- platform/graphics/gstreamer/PlatformVideoWindow.h: Removed.
- platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp: Removed.
- platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Removed.
- platform/graphics/gstreamer/PlatformVideoWindowMac.mm: Removed.
- platform/graphics/gstreamer/PlatformVideoWindowNix.cpp: Removed.
- platform/graphics/gstreamer/PlatformVideoWindowPrivate.h: Removed.
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender):
(webkitVideoSinkNew):
- platform/graphics/gstreamer/VideoSinkGStreamer.h: Removed code
related to GStreamer and NATIVE_FULLSCREEN_VIDEO.
- platform/graphics/gtk/FullscreenVideoControllerGtk.cpp: Removed.
- platform/graphics/gtk/FullscreenVideoControllerGtk.h: Removed.
Source/WebCore/platform/gtk/po:
- POTFILES.in: Removed FullscreenVideoControllerGtk.cpp.
- gl.po: Removed appearances of strings of
FullscreenVideoControllerGtk.cpp.
Source/WebKit/efl:
Removed some dead code as no GStreamer port is using the native
fullscreen video support.
- WebCoreSupport/FullscreenVideoControllerEfl.h: Removed.
Source/WebKit/gtk:
Removed some dead code as no GStreamer port is using the native
fullscreen video support.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):
- WebCoreSupport/ChromeClientGtk.h: Removed code related to
GStreamer and NATIVE_FULLSCREEN_VIDEO.
- 12:53 AM Changeset in webkit [158655] by
-
- 8 edits in trunk/Source/WebCore
Remove RenderWidget::viewCleared().
<https://webkit.org/b/123777>
This was some ancient hand-waving code from the KHTML era.
It was obviously confused (e.g RenderEmbeddedObject trying to handle
iframe owners, even though that setup is impossible.)
Reviewed by Anders Carlsson.
Nov 4, 2013:
- 11:55 PM Changeset in webkit [158654] by
-
- 21 edits2 copies4 adds in trunk/Source
IDB: Split backend Cursors and Transactions into their own files
https://bugs.webkit.org/show_bug.cgi?id=123789
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests (Rename, no change in behavior).
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBBackingStoreCursorInterface.h:
(WebCore::IDBBackingStoreCursorInterface::~IDBBackingStoreCursorInterface):
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBBackingStoreTransactionInterface.h: Added.
(WebCore::IDBBackingStoreTransactionInterface::~IDBBackingStoreTransactionInterface):
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
- Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/IDBIndexWriter.cpp:
(WebCore::IDBIndexWriter::writeIndexKeys):
(WebCore::IDBIndexWriter::verifyIndexKeys):
(WebCore::IDBIndexWriter::addingKeyAllowed):
- Modules/indexeddb/IDBIndexWriter.h:
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::createCursorBackend):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::GetOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
- Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.cpp: Added.
(WebCore::IDBBackingStoreCursorLevelDB::IDBBackingStoreCursorLevelDB):
(WebCore::IDBBackingStoreCursorLevelDB::firstSeek):
(WebCore::IDBBackingStoreCursorLevelDB::advance):
(WebCore::IDBBackingStoreCursorLevelDB::continueFunction):
(WebCore::IDBBackingStoreCursorLevelDB::haveEnteredRange):
(WebCore::IDBBackingStoreCursorLevelDB::isPastBounds):
- Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h: Added.
(WebCore::IDBBackingStoreCursorLevelDB::~IDBBackingStoreCursorLevelDB):
(WebCore::IDBBackingStoreCursorLevelDB::IDBBackingStoreCursorLevelDB):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::compareIndexKeys):
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):
(WebCore::IDBBackingStoreLevelDB::createObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteObjectStore):
(WebCore::IDBBackingStoreLevelDB::getRecord):
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::clearObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::createIndex):
(WebCore::IDBBackingStoreLevelDB::deleteIndex):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::findGreatestKeyLessThanOrEqual):
(WebCore::IDBBackingStoreLevelDB::findKeyInIndex):
(WebCore::IDBBackingStoreLevelDB::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStoreLevelDB::keyExistsInIndex):
(WebCore::ObjectStoreKeyCursorImpl::create):
(WebCore::ObjectStoreKeyCursorImpl::clone):
(WebCore::ObjectStoreKeyCursorImpl::ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreCursorImpl::create):
(WebCore::ObjectStoreCursorImpl::clone):
(WebCore::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
(WebCore::IDBBackingStoreLevelDB::createBackingStoreTransaction):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp: Added.
(WebCore::IDBBackingStoreTransactionLevelDB::IDBBackingStoreTransactionLevelDB):
(WebCore::IDBBackingStoreTransactionLevelDB::begin):
(WebCore::IDBBackingStoreTransactionLevelDB::commit):
(WebCore::IDBBackingStoreTransactionLevelDB::rollback):
- Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::createCursorBackend):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::createCursorBackend):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- 11:09 PM Changeset in webkit [158653] by
-
- 2 edits in trunk/Source/JavaScriptCore
internal-js-tests.yaml/Octane/stress-tests/pdfjs.js.default: ASSERTION FAILED: m_state.forNode(child).m_futurePossibleStructure.isSubsetOf(StructureSet(structure)) at DFGConstantFoldingPhase.cpp:249
https://bugs.webkit.org/show_bug.cgi?id=123778
Unreviewed, remove the other such assertion.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 11:05 PM Changeset in webkit [158652] by
-
- 7 edits in trunk
DumpRenderTree should reset its preferences file on launch
https://bugs.webkit.org/show_bug.cgi?id=29751
Reviewed by Dan Bernstein.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _retrieveKeyboardUIModeFromPreferences:]):
Further fix reading of AppleKeyboardUIMode - reading it from kCFPreferencesAnyApplication
domain meant that current application's domain was explcitly ignored, and the only
way to override the setting in DRT was through argument domain.
Source/WebKit2:
- UIProcess/mac/WKFullKeyboardAccessWatcher.mm:
(-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]):
Further fix reading of AppleKeyboardUIMode - reading it from kCFPreferencesAnyApplication
domain meant that current application's domain was explcitly ignored, and the only
way to override the setting in WTR was through argument domain.
Tools:
Using NSArgumentDomain was not a good idea. While it works with NSUserDefaults
and CFPreferencesCopyAppValue family of functions, it doesn't work with
CFPreferencesCopyValue(..., kCFPreferencesCurrentApplication, ...).
So, now we'll just set defaults in the current application.
- DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
- Delete the defaults.
- Removed CFPreferencesSetAppValue calls, as -setValuesForKeysWithDictionary: does the same.
- The comment about [NSUserDefaults standardUserDefaults] indirectly initializing NSApplication was incorrect.
- WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
Switched to -setValuesForKeysWithDictionary for consistency.
- 11:04 PM Changeset in webkit [158651] by
-
- 2 edits in trunk/Source/WebCore
Do not call setFrameRect on Widget unless its boundaries changed.
https://bugs.webkit.org/show_bug.cgi?id=123781
Reviewed by Andreas Kling.
Call Widget:setFrameRect only when the frame's rect actually changes. It also
cleans up the related weak reference code a bit.
Covered by existing tests.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
- 10:50 PM Changeset in webkit [158650] by
-
- 77 edits in trunk/Source/WebCore
[webcore/html] remove extra header includes from cpp files.
https://bugs.webkit.org/show_bug.cgi?id=123740
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-11-04
Reviewed by Darin Adler.
Removing redundant headers.
- html/BaseDateAndTimeInputType.cpp:
- html/ColorInputType.cpp:
- html/DOMFormData.cpp:
- html/DOMURL.cpp:
- html/DateInputType.cpp:
- html/DateTimeInputType.cpp:
- html/DateTimeLocalInputType.cpp:
- html/FTPDirectoryDocument.cpp:
- html/FileInputType.cpp:
- html/FormController.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLAreaElement.cpp:
- html/HTMLCanvasElement.cpp:
- html/HTMLCollection.cpp:
- html/HTMLDetailsElement.cpp:
- html/HTMLDocument.cpp:
- html/HTMLElement.cpp:
- html/HTMLFormControlsCollection.cpp:
- html/HTMLFormElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLLegendElement.cpp:
- html/HTMLMapElement.cpp:
- html/HTMLMediaElement.cpp:
- html/HTMLOptionElement.cpp:
- html/HTMLOptionsCollection.cpp:
- html/HTMLPlugInImageElement.cpp:
- html/HTMLProgressElement.cpp:
- html/HTMLSummaryElement.cpp:
- html/HTMLTemplateElement.cpp:
- html/HTMLVideoElement.cpp:
- html/HTMLViewSourceDocument.cpp:
- html/MediaController.cpp:
- html/MediaKeyEvent.cpp:
- html/MonthInputType.cpp:
- html/RangeInputType.cpp:
- html/StepRange.cpp:
- html/TextFieldInputType.cpp:
- html/TimeInputType.cpp:
- html/WeekInputType.cpp:
- html/canvas/CanvasRenderingContext.cpp:
- html/canvas/CanvasRenderingContext2D.cpp:
- html/canvas/CanvasStyle.cpp:
- html/canvas/OESVertexArrayObject.cpp:
- html/parser/BackgroundHTMLParser.cpp:
- html/parser/CSSPreloadScanner.cpp:
- html/parser/CompactHTMLToken.cpp:
- html/parser/HTMLConstructionSite.cpp:
- html/parser/HTMLDocumentParser.cpp:
- html/parser/HTMLElementStack.cpp:
- html/parser/HTMLFormattingElementList.cpp:
- html/parser/HTMLMetaCharsetParser.cpp:
- html/parser/HTMLParserIdioms.cpp:
- html/parser/HTMLPreloadScanner.cpp:
- html/parser/HTMLTokenizer.cpp:
- html/parser/HTMLTreeBuilder.cpp:
- html/parser/HTMLTreeBuilderSimulator.cpp:
- html/parser/HTMLViewSourceParser.cpp:
- html/parser/TextDocumentParser.cpp:
- html/parser/XSSAuditor.cpp:
- html/shadow/ContentDistributor.cpp:
- html/shadow/InsertionPoint.cpp:
- html/shadow/MediaControlElements.cpp:
- html/shadow/MediaControlsApple.cpp:
- html/shadow/MediaControlsBlackBerry.cpp:
- html/shadow/MediaControlsGtk.cpp:
- html/shadow/SliderThumbElement.cpp:
- html/track/AudioTrack.cpp:
- html/track/InbandGenericTextTrack.cpp:
- html/track/InbandTextTrack.cpp:
- html/track/InbandWebVTTTextTrack.cpp:
- html/track/TextTrack.cpp:
- html/track/TextTrackCueGeneric.cpp:
- html/track/TextTrackList.cpp:
- html/track/TextTrackRegion.cpp:
- html/track/TrackListBase.cpp:
- html/track/VideoTrack.cpp:
- html/track/WebVTTParser.cpp:
- 10:16 PM Changeset in webkit [158649] by
-
- 6 edits in trunk/Source/WebCore
IDB: deleteDatabase() interface should be asynchronous
https://bugs.webkit.org/show_bug.cgi?id=123787
Reviewed by Tim Horton.
No new tests (No behavior change for a tested port).
deleteDatabase now has no return value, but calls back to a bool function:
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::deleteDatabase):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
Refactor to account for the new async deleteDatabase:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::deleteDatabaseAsync):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- 10:06 PM Changeset in webkit [158648] by
-
- 5 edits in trunk
REGRESSION(r158586): plugins/refcount-leaks.html fails
https://bugs.webkit.org/show_bug.cgi?id=123765
Source/JavaScriptCore:
We were leaving a hole of one slot above a new frame when pushing the new frame on
the stack with pushFrame(). This unused slot can contain residual values that will
be marked during GC.
Reviewed by Filip Pizlo.
- interpreter/JSStackInlines.h:
(JSC::JSStack::pushFrame):
LayoutTests:
Reviewed by Filip Pizlo.
Reverted the test expectation changes after fixing the underlying issue.
- TestExpectations:
- platform/wk2/TestExpectations:
- 9:52 PM Changeset in webkit [158647] by
-
- 11 edits2 adds in trunk/Source/WebKit2
Remote Layer Tree: Make LayerTypeCustom remote-host CALayers from the Web process
https://bugs.webkit.org/show_bug.cgi?id=123766
Reviewed by Anders Carlsson.
Put each LayerTypeCustom layer into a CAContext, so that we can
host small CALayer trees (for video, plugins, etc.) from the Web process
to the UI process without proxying their (more complex) content.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
(WebKit::RemoteLayerTreeTransaction::dump):
Store, encode, and dump the CAContext ID of custom layers.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
Create a CALayerHost with the CAContext ID from the Web process.
- WebKit2.xcodeproj/project.pbxproj:
Add PlatformCALayerRemoteCustom.
- WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::createPlatformCALayer):
Call the newly-added custom-layer constructor.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::create):
(PlatformCALayerRemote::PlatformCALayerRemote):
Move the call to layerWasCreated() out to ::create(), so that all of
the constructors for this class and all subclasses have completed
before we call it (so that layerWasCreated() can store the context ID
in the created layer properties object).
(WebKit::PlatformCALayerRemote::hostingContextID):
Should never be reached on the base class, only PlatformCALayerRemoteCustom.
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.cpp: Added.
(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::~PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::hostingContextID):
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h: Added.
Add PlatformCALayerRemoteCustom, which owns a LayerHostingContext
which it will use to share a custom CALayer tree with the UI process.
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:
Drive-by remove an unnecessary include.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerWasCreated):
Store the CAContext ID with the layer creation properties so it can
be used to create a CALayerHost upon commit in the UI process.
- 9:41 PM Changeset in webkit [158646] by
-
- 2 edits in trunk/Source/JavaScriptCore
internal-js-tests.yaml/Octane/stress-tests/pdfjs.js.default: ASSERTION FAILED: m_state.forNode(child).m_futurePossibleStructure.isSubsetOf(StructureSet(structure)) at DFGConstantFoldingPhase.cpp:249
https://bugs.webkit.org/show_bug.cgi?id=123778
Reviewed by Geoffrey Garen.
This assertion was just wrong: ee do an execute() above the assertion. The assertion
is asserting that if we need a watchpoint (i.e. the best proven structure was not the
current structure) then it must be the future possible structure. But while that may
have been true before execute(), it won't be true after if the PutById was a
transition. Of course, this can only happen in the concurrent JIT in which case the
code would be invalidated anyway since we would only transform the code in a way that
leveraged the lack of a transition if we inserted a watchpoint, in which case we
would realize that the watchpoint had been fired during compilation.
Since this requires concurrent JIT awesomeness, I don't know how to test it.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 9:41 PM Changeset in webkit [158645] by
-
- 2 edits in trunk/Source/WebCore
Add Modules/indexeddb/leveldb to the WebCore.xcodeproj
Rubberstamped by Andreas Kling.
This will make hacking on IDB much easier for Mac developers as they won’t have
to constantly add and then subtract the leveldb subdirectory.
The USE(LEVELDB) flag is still disabled so these files won’t actually build by default.
- WebCore.xcodeproj/project.pbxproj:
- 9:39 PM Changeset in webkit [158644] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG CheckArray(String) should just be a Phantom(String:)
https://bugs.webkit.org/show_bug.cgi?id=123779
Reviewed by Geoffrey Garen.
This should be a speed-up since Phantom(String:) is smart enough to use the string
structure. It should also be a simplification since CheckArray(String) was totally
redundant.
Also FixupPhase was assuming that it may see CheckArray's. That's wrong. It can
create CheckArray's but it won't see them as input since no previous phase can
create them.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArray):
- 9:38 PM Changeset in webkit [158643] by
-
- 2 edits in trunk/Tools
Running FTL tests shouldn't reduce coverage on DFG tests
https://bugs.webkit.org/show_bug.cgi?id=123780
Reviewed by Geoffrey Garen.
- Scripts/run-jsc-stress-tests:
- 9:20 PM Changeset in webkit [158642] by
-
- 2 edits in trunk/Source/WebCore
Address review feedback I forgot to commit in r158641
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::processPendingOpenCalls):
- 9:08 PM Changeset in webkit [158641] by
-
- 6 edits in trunk/Source/WebCore
IDB: Make opening/establishing a database asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=123775
Reviewed by Andreas Kling.
No new tests (No behavior change for a tested port).
- Modules/indexeddb/IDBBackingStoreInterface.h: Add getOrEstablishIDBDatabaseMetadata with a callback, removing getIDBDatabaseMetaData, getObjectStores, and createIDBDatabaseMetaData in the process.
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::getOrEstablishIDBDatabaseMetadata): Adapted from getIDBDatabaseMetaData,
implement the asynchronous interface in terms of other LevelDB methods, always calling back synchronously.
(WebCore::IDBBackingStoreLevelDB::createIDBDatabaseMetaData):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::create):
(WebCore::IDBDatabaseBackendImpl::openInternalAsync): Broken off from openInternal.
(WebCore::IDBDatabaseBackendImpl::didOpenInternalAsync): Broken off from openInternal.
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::processPendingOpenCalls): Broken off to allow didOpenInternalAsync
to perform open callbacks in the failure case.
(WebCore::IDBDatabaseBackendImpl::openConnection): Always queue open connection calls, then immediately processPendingCalls.
(WebCore::IDBDatabaseBackendImpl::openConnectionInternal): Actually perform open connection calls.
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- 9:04 PM Changeset in webkit [158640] by
-
- 2 edits in trunk/Websites/test-results
Build fix. Update is_flaky when it's NULL.
- public/include/test-results.php:
- 8:12 PM Changeset in webkit [158639] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 8:11 PM Changeset in webkit [158638] by
-
- 1 copy in tags/Safari-537.73.3
New Tag.
- 8:05 PM Changeset in webkit [158637] by
-
- 3 edits in trunk/Websites/test-results
JSON generation on new flakiness dashboard is still too slow
https://bugs.webkit.org/show_bug.cgi?id=123776
Reviewed by Mark Rowe.
- init-database.sql: Added a constraint that result is unique for each (build, test) pair.
- public/include/test-results.php:
(ResultsJSONGenerator::generate): Don't sort results by latest_revision_time since that's done
in the client side anyway.
(update_flakiness_for_build): Don't update is_flaky flag if it's already set to the right value.
- 7:46 PM Changeset in webkit [158636] by
-
- 2 edits in branches/safari-537.60-branch/Tools
Merged r157995. <rdar://problem/15390113>
- 7:45 PM Changeset in webkit [158635] by
-
- 3 edits in branches/safari-537.60-branch/Tools
Merged r157815. <rdar://problem/15390113>
- 7:43 PM Changeset in webkit [158634] by
-
- 3 edits in branches/safari-537.60-branch/Tools
Merged r157687. <rdar://problem/15390113>
- 7:42 PM Changeset in webkit [158633] by
-
- 3 edits in branches/safari-537.60-branch/Tools
Merged r157553. <rdar://problem/15390113>
- 7:38 PM Changeset in webkit [158632] by
-
- 5 edits in branches/safari-537.60-branch/Tools
Merged r154450. <rdar://problem/15390113>
- 7:31 PM Changeset in webkit [158631] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderFrameBase's widget is always a FrameView.
<https://webkit.org/b/123771>
Delete widget() from RenderFrameBase and supplant a childView()
that returns FrameView*. Strip away unnecessary casts and asserts.
Reviewed by Antti Koivisto.
- 6:34 PM Changeset in webkit [158630] by
-
- 3 edits2 adds in trunk
[CSS Regions][CSS Shapes] Content in region doesn't respect shape-outside after initial layout pass
<https://webkit.org/b/114829>
Source/WebCore:
Although we set the size of a shape for shape-outside in RenderBlockFlow::insertFloatingObject based on the
float's size, the actual height of the float is not always resolved at that point. (Look at cases when the shape
has percentage based height or percentage based radius.) ShapeInfo::setShapeSize triggers a layout for 0 height
value, which will be overriden later, when RenderBlockFlow::positionNewFloats sets the actual size of the float (shape).
Thus it doesn't make sense to set the shape's size in insertFloatingObject and run those extra unnecessary layout passes,
since it'll be overriden anyways. I moved the shape size setting logic into RenderBlockFlow::positionNewFloats.
The problem showed up when we had a shape-outside ellipse with percentage based radius, and we inserted the content
with JavaScript into a region flow. The content has been layed out based on the 0 border radius, and relayout hasn't been
triggered when it flew into the flow. This change sets the shape size only when we already have the height of the float,
so the radius(es) can be resolved correctly, thus no unnecessary layout passes will happen and the layout will be correct as well.
Reviewed by David Hyatt.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::insertFloatingObject): Remove setting the size of the shape.
(WebCore::RenderBlockFlow::positionNewFloats): Set the size of the shape here.
LayoutTests:
Reviewed by David Hyatt.
- fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html: Added.
- 6:14 PM Changeset in webkit [158629] by
-
- 2 edits in trunk/Source/WebCore
AX: AXShowMenu doesn't always work.
https://bugs.webkit.org/show_bug.cgi?id=123649
Reviewed by Chris Fleizach.
No new tests, the change occurs in a code path that forces the context menu to show which
locks up DRT if we try to test it (platform menu is shown). The change itself gives the mouse
event handler a chance to handle our platform mouse event BEFORE the event ends up in the show
context menu machinery. This is necessary because without it, the element will not become
focused. Without focus, accessibility shows different/less menu items than a mouse click. The
end result is that context menus shown via accessibility are consistent with menus shown via click.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenuAt):
- 5:45 PM Changeset in webkit [158628] by
-
- 3 edits in trunk/Source/WTF
Implement base64url encoding from RFC 4648
https://bugs.webkit.org/show_bug.cgi?id=123767
Reviewed by Sam Weinig.
No tests yet, will be covered by JWK tests for WebCrypto.
- wtf/text/Base64.cpp:
(WTF::base64EncodeInternal):
(WTF::base64Encode):
(WTF::base64URLEncode):
(WTF::base64DecodeInternal):
(WTF::base64Decode):
(WTF::base64URLDecode):
- wtf/text/Base64.h:
(WTF::base64URLEncode):
- 5:45 PM Changeset in webkit [158627] by
-
- 4 edits2 adds in trunk
SMIL timers can still fire after the containing document has been torn down
<https://webkit.org/b/123291>
Reviewed by Darin Adler.
Source/WebCore:
Ensure that the timers get paused when the document is preparing to be torn down.
Test: svg/animations/smil-timers-not-disabled-crash.html
- dom/Document.cpp:
(WebCore::Document::dropChildren):
(WebCore::Document::commonTeardown):
(WebCore::Document::prepareForDestruction):
- dom/Document.h:
LayoutTests:
Add a test that triggers the crash; unfortunately it triggers it after
the test is done, causing the next test to time out or crash.
- svg/animations/smil-timers-not-disabled-crash-expected.txt: Added.
- svg/animations/smil-timers-not-disabled-crash.html: Added.
- 5:37 PM Changeset in webkit [158626] by
-
- 19 edits1 copy in trunk/Source/WebCore
Move duplicate code in TrackPrivate classes to a common base class
https://bugs.webkit.org/show_bug.cgi?id=123619
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-04
Reviewed by Darin Adler.
No new tests because this is just refactoring.
- GNUmakefile.list.am: Add TrackPrivateBase.
- WebCore.vcxproj/WebCore.vcxproj: Same.
- WebCore.vcxproj/WebCore.vcxproj.filters: Same.
- WebCore.xcodeproj/project.pbxproj: Same.
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::inbandTrackIndex): Renamed audioTrackIndex() to trackIndex().
(WebCore::AudioTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::AudioTrack::languageChanged): Same.
(WebCore::AudioTrack::willRemove): Same.
- html/track/AudioTrack.h: Update TrackPrivateBaseClient function signatures.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::inbandTrackIndex): Renamed textTrackIndex() to trackIndex().
(WebCore::InbandTextTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::InbandTextTrack::languageChanged): Same.
(WebCore::InbandTextTrack::willRemove): Same.
- html/track/InbandTextTrack.h: Update TrackPrivateBaseClient function signatures.
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::inbandTrackIndex): Renamed videoTrackIndex() to trackIndex().
(WebCore::VideoTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::VideoTrack::languageChanged): Same.
(WebCore::VideoTrack::willRemove): Same.
- html/track/VideoTrack.h: Update TrackPrivateBaseClient function signatures.
- platform/graphics/AudioTrackPrivate.h: Remove code that was moved to TrackPrivateBase.
- platform/graphics/InbandTextTrackPrivate.h: Same.
- platform/graphics/InbandTextTrackPrivateClient.h: Same.
- platform/graphics/VideoTrackPrivate.h: Same.
- platform/graphics/TrackPrivateBase.h: Refactored out duplicate code in AudioTrackPrivate, InbandTextTrackPrivate and VideoTrackPrivate.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Renamed textTrackIndex() to trackIndex().
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h: Same.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Renamed audioTrackIndex() to trackIndex().
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Renamed videoTrackIndex() to trackIndex90.
- 5:33 PM Changeset in webkit [158625] by
-
- 2 edits in trunk/Source/WebCore
FrameView destructor is worried about being retained by a renderer.
<https://webkit.org/b/123763>
There's no way we can be in ~FrameView() while also being owned by
a RenderWidget. Remove some overly paranoid code that was making sure
the renderer didn't have a reference on us.
Reviewed by Anders Carlsson.
- 5:33 PM Changeset in webkit [158624] by
-
- 4 edits in trunk
REGRESSION(r158311): media/media-fragments/TC0054.html and TC0061.html hit assertions
https://bugs.webkit.org/show_bug.cgi?id=123555
Reviewed by Darin Adler.
Source/WebCore:
No new tests, covered by existing tests.
- html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseFragments): Don't add a fragment with empty key or value as
they will not processed.
(WebCore::MediaFragmentURIParser::parseNPTFragment): Remove excess whitespace.
LayoutTests:
- TestExpectations: Remove media/media-fragments/TC0054.html and media/media-fragments/TC0061.html.
- 5:31 PM Changeset in webkit [158623] by
-
- 13 edits in trunk/Source/WebCore
Remove code duplications in createFontCustomPlatformData()
https://bugs.webkit.org/show_bug.cgi?id=123706
Reviewed by Darin Adler.
Move OpenTypeSanitizer and WOFF handling from the port specific
implementations in createFontCustomPlatformData() into the only
caller of this function CachedFont::ensureCustomFontData().
Also change the parameter passing the SharedBuffer from a
pointer to a reference since it is never null.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData):
- platform/graphics/blackberry/FontCustomPlatformData.h:
- platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/cairo/FontCustomPlatformData.h:
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/win/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.h:
- 5:31 PM Changeset in webkit [158622] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 5:28 PM Changeset in webkit [158621] by
-
- 1 copy in tags/Safari-537.60.5
New Tag.
- 5:26 PM Changeset in webkit [158620] by
-
- 2 edits in trunk/Source/WebCore
Fixing MediaStreamDescriptor addSource and addTrack methods
https://bugs.webkit.org/show_bug.cgi?id=123755
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-04
Reviewed by Eric Carlson.
We must store the track and source that is passed as parameter in a RefPtr,
otherwise we will refer to a null pointer.
No new tests needed.
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::addSource):
(WebCore::MediaStreamDescriptor::addTrack):
- 5:23 PM Changeset in webkit [158619] by
-
- 7 edits in trunk/Source
Remove PlatformCALayer::playerLayer
https://bugs.webkit.org/show_bug.cgi?id=123764
Reviewed by Sam Weinig.
Source/WebCore:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::clone):
Remove playerLayer(), fold it into clone().
Source/WebKit2:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Remove playerLayer().
- 5:12 PM Changeset in webkit [158618] by
-
- 5 edits in branches/safari-537.73-branch/Source/WebCore
Merged r155130. <rdar://problem/15109454>
- 4:47 PM Changeset in webkit [158617] by
-
- 17 edits4 adds in trunk
AX: Mail attachments at the start of an email are not output by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123697
Reviewed by Ryosuke Niwa.
Source/WebCore:
VoiceOver is expecting that "replaced elements" (attachments in a Mail message in this case) to be
represented by the replacement character when asking for a stringForRange.
However, when that replaced element is at the beginning of the document, the logic does not work because
there is a few code places that will take that first Position and advance it forward, not accounting for replaced elements.
When using the TextIterator normally, it does account for these, so that's why it's only affecting as at the beginning of the document.
Also a "replaced element" can be more than just renderer->isReplaced(), hence the externing of the isRendererReplacedElement method
and using that it in pertinent places.
Tests: platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html
platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html
- accessibility/AccessibilityObject.cpp:
(WebCore::replacedNodeNeedsCharacter):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(nsStringForReplacedNode):
- dom/Position.cpp:
(WebCore::Position::isCandidate):
- dom/PositionIterator.cpp:
- dom/Range.cpp:
(WebCore::Range::firstNode):
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
- editing/TextIterator.h:
LayoutTests:
Add two flavors of this. One where the replaced element has rendered children and one where it does not,
which go down two different code paths.
- platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start-expected.txt: Added.
- platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html: Added.
- platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start-expected.txt: Added.
- platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html: Added.
- 4:46 PM Changeset in webkit [158616] by
-
- 4 edits in trunk/Source/WebKit/wince
Change structure of frame tree in WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=121079
Patch by Zhuang Zhigang <zhuangzg@cn.fujitsu.com> on 2013-11-04
Reviewed by Darin Adler.
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::createFrame):
- WebView.cpp:
(WebView::createFrame):
- WebView.h:
- 4:46 PM Changeset in webkit [158615] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merged r154180. <rdar://problem/15387843>
- 4:41 PM Changeset in webkit [158614] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r158586): plugins/refcount-leaks.html fails
https://bugs.webkit.org/show_bug.cgi?id=123765
Add the test expectation.
- TestExpectations:
- platform/wk2/TestExpectations:
- 4:33 PM Changeset in webkit [158613] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebKit2
Merge change for <rdar://problem/15374298>.
- 4:15 PM Changeset in webkit [158612] by
-
- 6 edits in branches/safari-537.60-branch/Source/WebCore
Merged r157773. <rdar://problem/15387840>
- 4:12 PM Changeset in webkit [158611] by
-
- 7 edits in trunk/Source/WebCore
Use RenderAncestorIterator in a couple of places.
<https://webkit.org/b/123725>
Take the ancestorsOfType<RenderMoo>() thingy out for a spin.
Found a bunch of parent chain walking loops that were really just
looking for the first ancestor renderer of a certain type.
They were a perfect fit for this pattern:
if (auto svgRoot = ancestorsOfType<RenderSVGRoot>(renderer).first())
svgRoot->shakeMoneyMaker();
Quite a bit clearer than the previous:
for (auto ancestor = renderer.parent(); ancestor; ancestor = ancestor->parent()) {
if (ancestor->isSVGRoot())
toRenderSVGRoot(ancestor)->makeMoneyShaker();
}
Reviewed by Antti Koivisto.
- 4:09 PM Changeset in webkit [158610] by
-
- 2 edits in trunk/Source/WebKit2
WKRemoteObjectEncoder should escape keys
https://bugs.webkit.org/show_bug.cgi?id=123761
Reviewed by Tim Horton.
Keys that start with $ will be reserved for use by the coder, so prepend an extra
$ to keys that already start with $ to avoid clashes.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(escapeKey):
(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):
- 4:05 PM Changeset in webkit [158609] by
-
- 7 edits in branches/safari-537.73-branch/Source/WebCore
Merge r157773
- 4:05 PM Changeset in webkit [158608] by
-
- 3 edits6 adds in trunk
DFG NewArray/NewArrayBuffer shouldn't be constructing with negative indexing
https://bugs.webkit.org/show_bug.cgi?id=123760
<rdar://problem/15356705>
Reviewed by Mark Hahnenberg and Oliver Hunt.
Source/JavaScriptCore:
- dfg/DFGOperations.cpp:
LayoutTests:
- js/dfg-new-array-buffer-while-having-a-bad-time-expected.txt: Added.
- js/dfg-new-array-buffer-while-having-a-bad-time.html: Added.
- js/dfg-new-array-while-having-a-bad-time-expected.txt: Added.
- js/dfg-new-array-while-having-a-bad-time.html: Added.
- js/script-tests/dfg-new-array-buffer-while-having-a-bad-time.js: Added.
(foo):
- js/script-tests/dfg-new-array-while-having-a-bad-time.js: Added.
(foo):
- 3:59 PM Changeset in webkit [158607] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154180. <rdar://problem/15387809>
- 3:52 PM Changeset in webkit [158606] by
-
- 5 edits1 add in trunk/Source/WebCore
[MSE] Add a SourceBufferPrivateClient interface for platform -> html communication.
https://bugs.webkit.org/show_bug.cgi?id=123373
Reviewed by Eric Carlson.
To enable communication between SourceBuffer and SourceBufferPrivate without introducing
layering violations, add a new interface class SourceBufferPrivateInterface from which
SourceBuffer will inherit.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::SourceBuffer): Set the private's client.
(WebCore::SourceBuffer::~SourceBuffer): Clear the private's client.
(WebCore::SourceBuffer::sourceBufferPrivateDidEndStream): Added stub.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Hinno.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateHasAudio): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateHasVideo): Ditto.
- Modules/mediasource/SourceBuffer.h:
- WebCore.xcodeproj/project.pbxproj: Add new files to project.
- platform/graphics/SourceBufferPrivate.h:
- platform/graphics/SourceBufferPrivateClient.h: Added.
(WebCore::SourceBufferPrivateClient::~SourceBufferPrivateClient): Empty destructor.
- 3:47 PM Changeset in webkit [158605] by
-
- 8 edits in branches/safari-537.73-branch
Merge r157299
<rdar://problem/15292359>
- 3:44 PM Changeset in webkit [158604] by
-
- 4 edits in branches/safari-537.73-branch/Source
Merged r158602. <rdar://problem/15388203>
- 3:37 PM Changeset in webkit [158603] by
-
- 4 edits in branches/safari-537.60-branch/Source
Merged r158602. <rdar://problem/15373550>
- 3:26 PM Changeset in webkit [158602] by
-
- 4 edits in trunk/Source
../WebKit: [Win] Use VersionStamper for official builds
https://bugs.webkit.org/show_bug.cgi?id=123758
Reviewed by Tim Horton.
- WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Restore command to
call VersionStamper on final stage of build.
../WTF: [Win] User VersionStamper for official builds
https://bugs.webkit.org/show_bug.cgi?id=123758
Reviewed by Tim Horton.
- WTF.vcxproj/WTFPostBuild.cmd: Add missing command to run VersionStamper.exe.
- 3:15 PM Changeset in webkit [158601] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merge fixes for <rdar://problem/15168240>.
- 3:03 PM Changeset in webkit [158600] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] Update WebGeolocationManager to support multiple WebContent processes
https://bugs.webkit.org/show_bug.cgi?id=123658
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-04
Reviewed by Anders Carlsson.
Change WebGeolocationManagerProxy to track which WebProcessProxy needs geolocation.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::disconnectProcess):
WebContext::disconnectProcess does not handle ContextSupplement yet when using multiple
WebContent processes. Add an explicit call for WebGeolocationManagerProxy as a temporary
solution.
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::contextDestroyed):
(WebKit::WebGeolocationManagerProxy::processDidClose):
(WebKit::WebGeolocationManagerProxy::startUpdating):
(WebKit::WebGeolocationManagerProxy::stopUpdating):
(WebKit::WebGeolocationManagerProxy::removeRequester):
- UIProcess/WebGeolocationManagerProxy.h:
- UIProcess/WebGeolocationManagerProxy.messages.in:
- 2:53 PM Changeset in webkit [158599] by
-
- 27 edits in trunk/Source
[PluginProxy] Add a setting to disable video plugin proxy support in HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=123621
Reviewed by Eric Carlson.
Source/WebCore:
Add a new Setting which will disable the video plugin proxy. Enable support for AVFoundation
in iOS (which requries fixing a few compile errors resulting from classes and methods which
are not available on iOS.
- WebCore.exp.in: Export wkAVAssetResolvedURL.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement): Make conditional upon
new isVideoPluginProxyEnabled() setting.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
- html/HTMLMediaElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::createRenderer): Ditto.
(WebCore::HTMLVideoElement::attach): Ditto.
(WebCore::HTMLVideoElement::parseAttribute): Ditto.
(HTMLVideoElement::setDisplayMode): Ditto.
- html/HTMLVideoElement.h:
- page/Settings.cpp:
(WebCore::Settings::setVideoPluginProxyEnabled): Simple setter.
- page/Settings.h:
(WebCore::Settings::isVideoPluginProxyEnabled): Simple getter.
- platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Conditionally add MediaPlayerPrivateIOS and always add
MediaPlayerPriateAVFoundationObjC.
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::deliverNotification): Add default implementation.
(WebCore::MediaPlayerPrivateInterface::setMediaPlayerProxy): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Use new
HAS_ and USE_ macros instead of MAC_OS_MIN_VERNSION_REQUIRED.
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Use cachedCGColor instead
of CGColorGetConstantColor.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput): Use CVPixelBuffer pixel
format constant instead of QuickDraw constant.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): Draw to intermediary
CGImage on iOS.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
Source/WebKit/mac:
Add a new isVideoPluginProxyEnabled setting.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set isVideoPluginProxyEnabled preference.
(-[WebPreferences isVideoPluginProxyEnabled]): Pass through to Settings.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Set isVideoPluginProxyEnabled preference.
Source/WebKit2:
Add WebKit2 functions for setting then new isVideoPluginProxyEnabled preference.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetVideoPluginProxyEnabled):
(WKPreferencesGetVideoPluginProxyEnabled):
- UIProcess/API/C/WKPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WTF:
Enable WTF_USE_AVFOUNDATION and add some HAVE_AVFOUNDATION_* defines
to replace the existing MAC_OS_X_VERSION_MIN_REQUIRED macros in
MediaPlayerPrivateAVFoundationObjC.mm.
- wtf/Platform.h:
- 2:50 PM Changeset in webkit [158598] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r158561): fast/block/float/float-append-child-crash.html asserting.
The non-const ancestor iterator was walking siblings, not ancestors.
Rubber-stamped by Antti Koivisto.
- 2:49 PM Changeset in webkit [158597] by
-
- 6 edits in trunk/Source/WebCore
[MSE] [Mac] Disclaim support for MSE in AVFoundation and QTKit engines
https://bugs.webkit.org/show_bug.cgi?id=123593
Reviewed by Eric Carlson.
Immediately fail if asked to load a Media Source in engines which do not support
them.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::supportsType):
- 2:39 PM Changeset in webkit [158596] by
-
- 3 edits2 adds in trunk
[CSS Shapes] image valued shape element margin can cause an ASSERT fail
https://bugs.webkit.org/show_bug.cgi?id=123743
Reviewed by Andreas Kling.
Source/WebCore:
When margin-top is specified for a shape's element, the Y coordinates passed
to RasterShapeIntervals::getExcludedIntervals() may be negative. This is
because the incoming logical coordinates are relative to the content or
padding box, depending on the box-sizing property. The RasterShape::getExcludedIntervals()
method now clips the incoming Y coordinates to the shape's bounds before
accessing the shape's intervals.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash.html
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShapeIntervals::getExcludedIntervals):
LayoutTests:
Verify that an element with an image valued shape and a non-negative margin
does not cause an assertion failure.
- fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash.html: Added.
- 2:30 PM Changeset in webkit [158595] by
-
- 7 edits in trunk
More WKRemoteObjectRegistry work
https://bugs.webkit.org/show_bug.cgi?id=123754
Reviewed by Dan Bernstein.
Source/WebKit2:
- Shared/API/Cocoa/WKRemoteObjectCoder.h:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder rootObjectDictionary]):
Add a getter for the root object dictionary.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
Call _sendMessageWithBody:.
(-[WKRemoteObjectRegistry _sendMessageWithBody:]):
Call WebConnection::postMessage.
Tools:
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
(TestWebKitAPI::TEST):
Use the correct bundle test name. Call Util::run.
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
(-[BundleObject sayHello]):
(-[BundleObject testMethodWithString:double:integer:]):
Add BundleObject implementation. Register the bundle object with
the remote object registry. Call _handleMessageWithName:body: on the incoming message.
- 1:56 PM Changeset in webkit [158594] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r158404. <rdar://problem/15371809>
- 1:53 PM Changeset in webkit [158593] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r158061. <rdar://problem/15333281>
- 1:50 PM Changeset in webkit [158592] by
-
- 3 edits2 copies in branches/safari-537.73-branch
Merged r157436. <rdar://problem/15357233>
- 1:46 PM Changeset in webkit [158591] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154897. <rdar://problem/15168237>
- 1:44 PM Changeset in webkit [158590] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154851. <rdar://problem/15366090>
- 1:41 PM Changeset in webkit [158589] by
-
- 3 edits2 copies in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r153087. <rdar://problem/15366093>
- 1:38 PM Changeset in webkit [158588] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154851.
- 1:31 PM Changeset in webkit [158587] by
-
- 11 edits in trunk/Source/WebCore
Make LiveNodeListBase use Elements instead of Nodes
https://bugs.webkit.org/show_bug.cgi?id=123745
Reviewed by Anders Carlsson.
- WebCore.exp.in:
- dom/Element.cpp:
(WebCore::Element::firstElementChild):
(WebCore::Element::lastElementChild):
Switch to correct calls. ElementTraversal::previous and previousChild are no longer equivalent.
- dom/ElementTraversal.h:
(WebCore::::lastWithinTemplate):
(WebCore::::previousTemplate):
Fix ElementTraversal::lastWithin and previous. They had no real clients and didn't work correctly.
With LiveNodeListBase starting to use these they get excellent test coverage.
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::invalidateCache):
- dom/LiveNodeList.h:
(WebCore::LiveNodeListBase::LiveNodeListBase):
(WebCore::LiveNodeListBase::isElementCacheValid):
(WebCore::LiveNodeListBase::cachedElement):
(WebCore::LiveNodeListBase::cachedElementOffset):
(WebCore::LiveNodeListBase::setCachedElement):
Make the cache Element based.
Switch to Elements in all helpers.
Rename item -> element for clarity.
- dom/NodeIterator.cpp:
(WebCore::NodeIterator::NodePointer::moveToPrevious):
(WebCore::NodeIterator::updateForNodeRemoval):
This code expected the old inconsistent NodeTraversal::previous behavior where the traversal includes
the root as the last item. Drop the stayWithin parameter and handle the one case where it is needed here.
- dom/NodeTraversal.cpp:
(WebCore::NodeTraversal::last):
(WebCore::NodeTraversal::deepLastChild):
- dom/NodeTraversal.h:
Support ElementTraversal::previous/lastWithin.
(WebCore::NodeTraversal::previous):
This was slightly wrong too.
- html/HTMLCollection.cpp:
(WebCore::previousElement):
(WebCore::lastElement):
(WebCore::LiveNodeListBase::iterateForPreviousElement):
(WebCore::LiveNodeListBase::itemBefore):
(WebCore::LiveNodeListBase::isLastItemCloserThanLastOrCachedItem):
(WebCore::LiveNodeListBase::isFirstItemCloserThanCachedItem):
(WebCore::LiveNodeListBase::setCachedElement):
(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::elementBeforeOrAfterCachedElement):
- html/HTMLCollection.h:
(WebCore::HTMLCollection::isEmpty):
(WebCore::HTMLCollection::hasExactlyOneItem):
- 1:28 PM Changeset in webkit [158586] by
-
- 28 edits in trunk/Source
Eliminate HostCall bit from JSC Stack CallerFrame
https://bugs.webkit.org/show_bug.cgi?id=123642
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Replace the HostCallFrame bit or'ed to the CallerFrame value in a CallFrame with
a VM entry sentinel CallFrame. Logically, the VM entry sentinel call frame is
pushed on the stack before the callee frame when calling from native to JavaScript
code. The callee frame's CallerFrame points at the VM entry sentinel call frame
and the VM entry sentinel call frame's CallerFrame points to the real caller.
The VM entry sentinel call frame has a sentinel (1) in the CodeBlock to indicate
its a VM entry sentinel call frame. It's ScopeChain has vm.topCallFrame at the
time of the call. This allows for a complete stack walk as well as walking just
the contiguous JS frames.
The VM entry sentinel call frame and callee frame are currently allocated and
initialized in ExecState::init(), but this initialization will be moved to
ctiTrampoline when we actually move onto the native stack.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::noticeIncomingCall):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::callerFrame):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
- interpreter/CallFrame.h:
(JSC::ExecState::frameExtent):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):
(JSC::ExecState::init):
(JSC::ExecState::noCaller):
(JSC::ExecState::isVMEntrySentinel):
(JSC::ExecState::vmEntrySentinelCallerFrame):
(JSC::ExecState::initializeVMEntrySentinelFrame):
(JSC::ExecState::callerFrameSkippingVMEntrySentinel):
(JSC::ExecState::vmEntrySentinelCodeBlock):
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::Interpreter::getStackTrace):
- interpreter/Interpreter.h:
(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
- interpreter/JSStack.cpp:
(JSC::JSStack::~JSStack):
- interpreter/JSStackInlines.h:
(JSC::JSStack::getStartOfFrame):
(JSC::JSStack::pushFrame):
(JSC::JSStack::popFrame):
- interpreter/Register.h:
(JSC::Register::operator=):
(JSC::Register::callFrame):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::readFrame):
(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::readInlinedFrame):
(JSC::StackVisitor::Frame::print):
- interpreter/VMInspector.cpp:
(JSC::VMInspector::countFrames):
- jit/JIT.cpp:
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JITOperations.cpp:
- jit/JITStubsARM.h:
(JSC::ctiTrampoline):
- jit/JITStubsARM64.h:
- jit/JITStubsARMv7.h:
(JSC::ctiTrampoline):
- jit/JITStubsMIPS.h:
- jit/JITStubsMSVC64.asm:
- jit/JITStubsSH4.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86_64.h:
- jsc.cpp:
(functionDumpCallFrame):
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::throwException):
Source/WebCore:
Updated JavaScript stack walking as a result of the corresponding changes made in
JavaScriptCore.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::didExecuteProgram):
- 12:15 PM Changeset in webkit [158585] by
-
- 3 edits in trunk/Websites/test-results
Build fixes. In particular, we were missing the code to generate JSONs in report.php :(
- public/api/report.php:
- public/include/test-results.php:
- 12:12 PM Changeset in webkit [158584] by
-
- 41 edits in trunk
[css shapes] Fix support for shape-outside on a float with padding
https://bugs.webkit.org/show_bug.cgi?id=123590
Reviewed by Alexandru Chiculita.
Source/WebCore:
The line top was being improperly converted to the coordinates of the
shape, causing the shape to be positioned incorrectly when the float
had padding. This fixes that problem.
No new tests, covered by updates to existing ones.
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
LayoutTests:
Fix existing tests that depended on the incorrect behavior so that
they are now testing the proper thing. Also fix up the tests to make
them clearer and more robust.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 11:52 AM Changeset in webkit [158583] by
-
- 8 edits3 adds in trunk
JSArrayBufferViews of length 0 allocate 0 CopiedSpace bytes, which is invalid
https://bugs.webkit.org/show_bug.cgi?id=123746
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This patch disallows clients from allocating 0 bytes in CopiedSpace. We enforce this invariant
with an ASSERT in C++ code and a breakpoint in JIT code. Clients who care about 0-byte
allocations (like JSArrayBufferViews) must handle that case themselves, but we don't punish
anybody else for the rare case that somebody decides to allocate a 0-length typed array.
It also makes the allocation and copying cases consistent for CopiedSpace: no 0-byte allocations,
no 0-byte copying.
Also added a check so that JSArrayBufferViews don't try to copy their m_vector backing store when
their length is 0. Also sprinkled several ASSERTs throughout the JSArrayBufferView code to make sure that
when length is 0 m_vector is null.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewTypedArray):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicStorage):
- heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::tryAllocate):
- runtime/ArrayBuffer.h:
(JSC::ArrayBuffer::create):
- runtime/JSArrayBufferView.cpp:
(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::::visitChildren):
(JSC::::copyBackingStore):
(JSC::::slowDownAndWasteMemory):
LayoutTests:
Added a test to make sure that we don't crash when allocating a typed array with 0 length.
- js/script-tests/typedarray-zero-size.js: Added.
(foo):
- js/typedarray-zero-size-expected.txt: Added.
- js/typedarray-zero-size.html: Added.
- 10:45 AM Changeset in webkit [158582] by
-
- 17 edits6 copies in trunk
Implement generateKey for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123669
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-generate-key.html
crypto/subtle/hmac-generate-key.html
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createAesKeyGenParams): Added bindings for AesKeyGenParams.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): Handle
algorithms that generate AES and HMAC keys.
- bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::generateKey): Added.
- crypto/CryptoAlgorithmAesKeyGenParams.h: Added.
- crypto/CryptoKey.cpp: (WebCore::CryptoKey::randomData):
- crypto/CryptoKey.h:
- crypto/CryptoKeyMac.cpp: Added
Expose a function that produces random data for symmetric crypto keys. Cross-platform
implementation uses ARC4 code from WTF, while Mac uses a system function that
provides a FIPS validated random number generator.
- crypto/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::generate):
- crypto/CryptoKeyAES.h:
Added a function that creates AES keys.
- crypto/SubtleCrypto.idl: Added generateKey.
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::generateKey): Added.
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::generateKey): Added.
- crypto/keys/CryptoKeyHMAC.cpp: (WebCore::CryptoKeyHMAC::generate):
- crypto/keys/CryptoKeyHMAC.h:
Added a function that creates HMAC keys.
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: Removed generateKey stub, the implementation
ended up in cross-platform file.
- crypto/mac/CryptoAlgorithmHMACMac.cpp: Ditto.
LayoutTests:
- crypto/subtle/aes-cbc-generate-key-expected.txt: Added.
- crypto/subtle/aes-cbc-generate-key.html: Added.
- crypto/subtle/hmac-generate-key-expected.txt: Added.
- crypto/subtle/hmac-generate-key.html: Added.
- crypto/subtle/sha-1-expected.txt: Now that crypto.webkitSubtle.generateKey exists,
a different exception is raised.
- 10:42 AM Changeset in webkit [158581] by
-
- 4 edits in trunk/Source/WebCore
Revert SetCGFontRenderingMode() build fix for Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=123633
Reviewed by Darin Adler.
Reverts <http://trac.webkit.org/changeset/134380>, which
was a Chromium Mac build fix for <http://trac.webkit.org/changeset/134348>
(https://bugs.webkit.org/show_bug.cgi?id=101787). Chromium doesn't
build against top-of-tree WebKit.
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- 10:21 AM Changeset in webkit [158580] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] Refactor jumps in baseline JIT to return label after the jump.
https://bugs.webkit.org/show_bug.cgi?id=123734
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-04
Reviewed by Michael Saboff.
Current implementation of jumps in sh4 baseline JIT returns a label on the jump itself
and not after it. This is not correct and leads to issues like infinite loop the DFG
(https://bugs.webkit.org/show_bug.cgi?id=122597 for instance). This refactor fixes this
and also simplifies the link and relink procedures for sh4 jumps.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchDouble):
(JSC::MacroAssemblerSH4::branchTrue):
(JSC::MacroAssemblerSH4::branchFalse):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::extraInstrForBranch):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::bra):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::relinkJump):
- 10:03 AM Changeset in webkit [158579] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK][WK1] Enable CSS Regions if feature flag is set to TRUE
https://bugs.webkit.org/show_bug.cgi?id=123739
Reviewed by Martin Robinson.
In WK1 CSS Regions were always disabled even if you set the feature flag
ENABLE_CSS_REGIONS to TRUE. Enabling CSS Regions support in that case.
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings): Enable CSS Regions if feautre flag is
set to TRUE.
- 9:37 AM Changeset in webkit [158578] by
-
- 17 edits6 deletes in trunk
Unreviewed, rolling out r158526.
http://trac.webkit.org/changeset/158526
https://bugs.webkit.org/show_bug.cgi?id=123744
it broke the build (Requested by jessieberlin on #webkit).
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createAesCbcParams):
(WebCore::createHmacParams):
(WebCore::createHmacKeyParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
- bindings/js/JSSubtleCryptoCustom.cpp:
- crypto/CryptoAlgorithmAesKeyGenParams.h: Removed.
- crypto/CryptoKey.cpp:
- crypto/CryptoKey.h:
- crypto/CryptoKeyAES.cpp:
- crypto/CryptoKeyAES.h:
- crypto/CryptoKeyMac.cpp: Removed.
- crypto/SubtleCrypto.idl:
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
- crypto/keys/CryptoKeyHMAC.cpp:
- crypto/keys/CryptoKeyHMAC.h:
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::generateKey):
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::generateKey):
LayoutTests:
- crypto/subtle/aes-cbc-generate-key-expected.txt: Removed.
- crypto/subtle/aes-cbc-generate-key.html: Removed.
- crypto/subtle/hmac-generate-key-expected.txt: Removed.
- crypto/subtle/hmac-generate-key.html: Removed.
- crypto/subtle/sha-1-expected.txt:
- 8:08 AM Changeset in webkit [158577] by
-
- 2 edits in trunk/Tools
[EFL] Change ATK version to 2.10.0
https://bugs.webkit.org/show_bug.cgi?id=123727
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.
Provided new API to retrieve text at a given offset.
- efl/jhbuild.modules:
- 8:04 AM Changeset in webkit [158576] by
-
- 6 edits in trunk
[EFL] accessibility/textarea-line-for-index.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112015
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.
Tools:
Provided implementation for AccessibilityUIElement::lineForIndex().
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::lineForIndex): Implemented.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::lineForIndex): Implemented.
LayoutTests:
Removed failure expectations.
- platform/efl-wk1/TestExpectations: The test is no longer failing.
- platform/efl-wk2/TestExpectations: The test is no longer failing.
- 7:02 AM Changeset in webkit [158575] by
-
- 6 edits in trunk
[EFL] accessibility/button-press-action.html
https://bugs.webkit.org/show_bug.cgi?id=111993
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.
Tools:
Provided an implementation for AccessibilityUIElement::isPressActionSupported.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isPressActionSupported):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported):
LayoutTests:
Removed failure expectations.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- 6:58 AM Changeset in webkit [158574] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Remove redundant calls in CoordinatedGraphicsScene
https://bugs.webkit.org/show_bug.cgi?id=123737
Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-11-04
Reviewed by Noam Rosenthal.
Removing unused code left after few refactoring patches.
No new tests. Covered by existing ones.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
- 5:01 AM Changeset in webkit [158573] by
-
- 4 edits in trunk/Source/WebCore
CSSPrimitiveValue color constructors should return PassRef.
<https://webkit.org/b/123728>
Make CSSPrimitiveValue::createColor() and the corresponding
CSSValuePool helper functions return PassRef<CSSPrimitiveValue>.
Also made CSSValuePool slightly less stupid when hitting the upper
size limit on the color value cache: instead of throwing out cache
and rebuilding it from scratch, just remove one value at random.
Reviewed by Antti Koivisto.
- 4:55 AM Changeset in webkit [158572] by
-
- 3 edits in trunk/Source/WebCore
Some more RenderChildIterator deployment.
<https://webkit.org/b/123735>
Convert another handful of loops to use childrenOfType<RenderFoo>
iterators, mostly for skipping over uninteresting text renderers.
Reviewed by Antti Koivisto.
- 4:43 AM Changeset in webkit [158571] by
-
- 3 edits in trunk/Source/WebCore
LabelsNodeList always is always rooted at a LabelableElement.
<https://webkit.org/b/123730>
Tighten up LabelsNodeList by enforcing that it's only rooted to
a LabelableElement. Also marked the class FINAL and made its
create() helper return PassRef.
Reviewed by Antti Koivisto.
- 4:40 AM Changeset in webkit [158570] by
-
- 3 edits2 adds in trunk
REGRESSION: RenderStyle is leaked when not creating renderer for display:none
<https://webkit.org/b/123726>
Source/WebCore:
Explicitly drop the RenderStyle reference in RenderElement::createFor
if we decide to not create any renderer.
Reviewed by Antti Koivisto.
Test: fast/css/renderstyle-leak-with-display-none.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
LayoutTests:
Reviewed by Antti Koivisto.
- fast/css/renderstyle-leak-with-display-none-expected.txt: Added.
- fast/css/renderstyle-leak-with-display-none.html: Added.
- 4:25 AM Changeset in webkit [158569] by
-
- 65 edits in trunk/Source/WebCore
[webcore/dom] Remove extra header includes from cpp files.
https://bugs.webkit.org/show_bug.cgi?id=123720
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-11-04
Reviewed by Andreas Kling.
Removing redundant headers from dom related cpp files.
- dom/Attr.cpp:
- dom/CharacterData.cpp:
- dom/ChildListMutationScope.cpp:
- dom/ChildNodeList.cpp:
- dom/ContainerNode.cpp:
- dom/ContainerNodeAlgorithms.cpp:
- dom/DOMNamedFlowCollection.cpp:
- dom/DatasetDOMStringMap.cpp:
- dom/Document.cpp:
- dom/DocumentEventQueue.cpp:
- dom/DocumentMarkerController.cpp:
- dom/DocumentOrderedMap.cpp:
- dom/DocumentStyleSheetCollection.cpp:
- dom/Element.cpp:
- dom/ElementRareData.cpp:
- dom/Event.cpp:
- dom/EventContext.cpp:
- dom/EventDispatcher.cpp:
- dom/EventTarget.cpp:
- dom/ExceptionBase.cpp:
- dom/FocusEvent.cpp:
- dom/InlineStyleSheetOwner.cpp:
- dom/KeyboardEvent.cpp:
- dom/LiveNodeList.cpp:
- dom/MessageEvent.cpp:
- dom/MessagePort.cpp:
- dom/MouseRelatedEvent.cpp:
- dom/MutationEvent.cpp:
- dom/MutationObserver.cpp:
- dom/MutationObserverInterestGroup.cpp:
- dom/MutationObserverRegistration.cpp:
- dom/MutationRecord.cpp:
- dom/NameNodeList.cpp:
- dom/NamedFlowCollection.cpp:
- dom/NamedNodeMap.cpp:
- dom/Node.cpp:
- dom/NodeIterator.cpp:
- dom/NodeTraversal.cpp:
- dom/PositionIterator.cpp:
- dom/ProcessingInstruction.cpp:
- dom/Range.cpp:
- dom/RegisteredEventListener.cpp:
- dom/ScopedEventQueue.cpp:
- dom/ScriptElement.cpp:
- dom/ScriptRunner.cpp:
- dom/SelectorQuery.cpp:
- dom/ShadowRoot.cpp:
- dom/StyledElement.cpp:
- dom/TagNodeList.cpp:
- dom/Text.cpp:
- dom/TextEvent.cpp:
- dom/TouchEvent.cpp:
- dom/TreeScope.cpp:
- dom/TreeScopeAdopter.cpp:
- dom/TreeWalker.cpp:
- dom/UIEvent.cpp:
- dom/UserActionElementSet.cpp:
- dom/UserTypingGestureIndicator.cpp:
- dom/VisitedLinkState.cpp:
- dom/WebKitNamedFlow.cpp:
- 4:22 AM Changeset in webkit [158568] by
-
- 3 edits in trunk/Source/WebCore
HTMLAllCollection is always rooted at a Document.
<https://webkit.org/b/123724>
Tighten up HTMLAllCollection by making the constructor take a
Document& instead of a ContainerNode&. Drive-by application of
FINAL and PassRef also happened.
Reviewed by Antti Koivisto.
- 4:21 AM Changeset in webkit [158567] by
-
- 10 edits in trunk/Source/WebCore
Make more CSSValue subclass constructors return PassRef.
<https://webkit.org/b/123731>
Make the constructor helpers for the following classes return
PassRef instead of PassRefPtr:
- CSSFontValue
- CSSImageSetValue
- CSSUnicodeRangeValue
- WebKitCSSArrayFunctionValue
- WebKitCSSFilterValue
- WebKitCSSMatFunctionValue
- WebKitCSSMixFunctionValue
- WebKitCSSShaderValue
- WebKitCSSTransformValue
Reviewed by Antti Koivisto.
- 4:16 AM Changeset in webkit [158566] by
-
- 2 edits in trunk/Source/WebCore
Buildfix after r158182 for GCC 4.6
https://bugs.webkit.org/show_bug.cgi?id=123442
Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-04
Reviewed by Csaba Osztrogonác.
Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11)
- dom/ScopedEventQueue.h:
- 1:16 AM Changeset in webkit [158565] by
-
- 7 edits in trunk/Websites/test-results
Fix JSON generations on new flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123723
Reviewed by Andreas Kling.
Add is_flaky column on results table so that this column can be used to find flaky tests on a given builder
efficiently without having to through results for all tests in PHP. This column is updated in report.php
when a new build is added. Because is_flaky depends on the preceding and succeeding results, we must update
is_flaky flag on results for builds immediately before and after the new build as well.
To see why, suppose we had two consecutive results [PASS] [PASS]. If we were to insert [FAIL] result between
the two, those two results may also turn into flaky results if they were surrounded by [FAIL]. Similarly,
if we had [PASS] [FAIL] and the second result was marked flaky, inserting new [FAIL] must unmark it.
- init-database.sql: Added is_flaky column to results table with an index. Also added an index on
build_revisions.time as many queries filter results by this quantity. Also set the work_mem to 50MB avoid
disk thrashing while sorting results in various queries.
- public/api/failing-tests.php: Handle builder ids as well as names. Call generate() with failure types.
No longer generates *-failing.json since it's a subset of *-wrongexpectations.json to save time.
- public/api/report.php: Rewritten. Calls update_flakiness_after_inserting_build to update is_flaky flags
on the newly added results.
(store_results): Added.
(main): Added.
- public/include/test-results.php:
(ResultsJSONWriter):
(ResultsJSONWriter::add_results_for_test): Renamed from add_results_for_test_if_matches.
(ResultsJSONGenerator::generate): Takes the failure type. Instead of generating JSONs for all failure types
at once, generate one JSON for the specified type. We generate the list of test ids based on the failure type
and query results based on that. This dramatically cuts down the time spent in PHP.
(ResultsJSONGenerator::latest_build): Added.
(ResultsJSONGenerator::write_jsons): Takes single writer now.
(update_flakiness_for_build): Added.
(update_flakiness_after_inserting_build): Added.
- public/index.html:
(TestResultsView._populateBuilderPane): Emulate *-failing.json upon *-wrongexpectations.json.
(TestResultsView.fetchFailingTestsForBuilder): Ditto.
- public/main.css: Minor style tweaks.
(.testResults): Extend the border that wraps the test results as needed.
(.tooltip): Don't wrap text inside tooltips.
- 12:53 AM Changeset in webkit [158564] by
-
- 4 edits in trunk/Source/WebCore
HTMLTableRowsCollection is always rooted at a HTMLTableElement.
<https://webkit.org/b/123721>
Tighten up HTMLTableRowsCollection by making the create() helper
take a HTMLTableElement& and adding a HTMLSelectElement& getter.
Reviewed by Antti Koivisto.
- 12:51 AM Changeset in webkit [158563] by
-
- 4 edits in trunk/Source/WebCore
HTMLNameCollection and friends are always rooted at a Document.
<https://webkit.org/b/123722>
Tighten WindowNameCollection and DocumentNameCollection by making
their constructors take a Document&, and add a slightly better
document() than the one we inherit from LiveNodeListBase.
Also marked the classes FINAL and made create() helpers return
PassRef instead of PassRefPtr.
Reviewed by Antti Koivisto.
- 12:49 AM Changeset in webkit [158562] by
-
- 1 edit11 moves12 deletes in trunk/LayoutTests
Optimize baselines: svg/zoom
Unreviewed; run "webkit-patch optimize-baselines svg/zoom"
- platform/gtk/svg/zoom/page/zoom-background-images-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-image-expected.png: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Removed.
- platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
- platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Removed.
- platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Removed.
- svg/zoom/page/zoom-background-images-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-background-images-expected.txt.
- svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
- svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt.
- svg/zoom/page/zoom-mask-with-percentages-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt.
- svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.
- svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt.
- svg/zoom/page/zoom-svg-as-image-expected.png: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-as-image-expected.png.
- svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-float-border-padding-expected.txt.
- svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
- svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt.
- svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt.
- svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt.
- 12:46 AM Changeset in webkit [158561] by
-
- 13 edits1 add in trunk/Source/WebCore
Add an ancestor renderer iterator.
<https://webkit.org/b/123718>
Add ancestor iterators for renderers, analogous to element ancestor
iterators. They walk the chain of parent renderers, stopping at each
ancestor of a certain type.
Just like child renderer iterators, this requires isRendererOfType()
to be implemented for the targeted renderer class.
You use them like this:
auto frameSets = ancestorsOfType<RenderFrameSet>(*this);
for (auto frameSet = frameSets.begin(), end = frameSets.end(); frameSet != end; ++frameSet)
frameSet->thisOrThat();
To complete the patch, I put them to use in a couple of random places.
Reviewed by Antti Koivisto.
- 12:40 AM Changeset in webkit [158560] by
-
- 2 edits14 moves2 adds11 deletes in trunk/LayoutTests
Optimize baselines: fast/images
Unreviewed; run "webkit-patch optimize-baselines fast/images"
- fast/images/crossfade-client-not-removed-crash-expected.txt:
- fast/images/embed-image-expected.png: Renamed from LayoutTests/platform/efl/fast/images/embed-image-expected.png.
- fast/images/exif-orientation-css-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/exif-orientation-css-expected.txt.
- fast/images/exif-orientation-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/exif-orientation-expected.txt.
- fast/images/icon-decoding-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/icon-decoding-expected.txt.
- fast/images/image-in-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/image-in-map-expected.png.
- fast/images/image-in-map-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/image-in-map-expected.txt.
- fast/images/imagemap-focus-ring-zoom-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-zoom-expected.txt.
- fast/images/support-broken-image-delegate-expected.txt: Renamed from LayoutTests/platform/gtk/fast/images/support-broken-image-delegate-expected.txt.
- platform/efl-wk2/fast/images/imagemap-circle-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-circle-focus-ring-expected.png.
- platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-expected.png.
- platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png.
- platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png.
- platform/efl-wk2/fast/images/imagemap-polygon-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-polygon-focus-ring-expected.png.
- platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/gtk/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/gtk/fast/images/embed-image-expected.png: Removed.
- platform/gtk/fast/images/exif-orientation-css-expected.txt: Removed.
- platform/gtk/fast/images/icon-decoding-expected.txt: Removed.
- platform/gtk/fast/images/image-in-map-expected.png: Removed.
- platform/gtk/fast/images/image-in-map-expected.txt: Removed.
- platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.txt: Removed.
- platform/mac/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/mac/fast/images/exif-orientation-css-expected.txt: Removed.
- platform/mac/fast/images/exif-orientation-expected.txt: Removed.
- platform/win-7sp0/fast/images/support-broken-image-delegate-expected.txt: Renamed from LayoutTests/platform/win/fast/images/support-broken-image-delegate-expected.txt.
- 12:28 AM Changeset in webkit [158559] by
-
- 7 edits in trunk/Source/WebCore
[CSSRegions] Use auto keyword to clean-up for loops
https://bugs.webkit.org/show_bug.cgi?id=123699
Reviewed by Anders Carlsson.
Start using auto keyword for loops.
Also, since region breaks (forced breaks) can be added only on boxes,
i changed RenderFlowThread::addForcedRegionBreak to use a RenderBox* instead of RenderObject*.
No change in functionality, no new tests.
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::styleDidChange):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
(WebCore::FlowThreadController::updateFlowThreadsChainIfNecessary):
(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsNeedingTwoStepLayout):
(WebCore::FlowThreadController::resetFlowThreadsWithAutoHeightRegions):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoOverflowPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoFinalPhase):
(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsCountConsistent):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::hasCompositingRegionDescendant):
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::updateLayerToRegionMappings):
(WebCore::RenderFlowThread::updateLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::clearRenderBoxRegionInfoAndCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):
(WebCore::RenderFlowThread::regionInRange):
(WebCore::RenderFlowThread::checkRegionsWithStyling):
(WebCore::RenderFlowThread::objectInFlowRegion):
(WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::markRegionsForOverflowLayoutIfNeeded):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
(WebCore::RenderFlowThread::collectLayerFragments):
(WebCore::RenderFlowThread::fragmentsBoundingBox):
(WebCore::RenderFlowThread::addRegionsVisualEffectOverflow):
(WebCore::RenderFlowThread::addRegionsVisualOverflowFromTheme):
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):
(WebCore::RenderFlowThread::addRegionsLayoutOverflow):
(WebCore::RenderFlowThread::clearRegionsOverflow):
- rendering/RenderFlowThread.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::addRegionToList):
(WebCore::RenderNamedFlowThread::computeOversetStateForRegions):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
(WebCore::RenderNamedFlowThread::pushDependencies):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
- 12:12 AM GStreamer/GStreamerOnMac edited by
- (diff)
Nov 3, 2013:
- 11:10 PM Changeset in webkit [158558] by
-
- 3 edits in trunk/Source/WebCore
PingLoader objects unnecessarily pass through OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122942
Reviewed by Darin Adler.
There's no need to store new PingLoader objects into an OwnPtr just to leak them out a few lines later
into an unused variable. New objects are created through a new helper method and then left unmanaged as
they're guaranteed to destroy themselves when they receive a response of any kind.
- loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage): Call the new createPingLoader method to spawn the PingLoader.
(WebCore::PingLoader::sendPing): Ditto.
(WebCore::PingLoader::sendViolationReport): Ditto.
(WebCore::PingLoader::createPingLoader): A helper method that creates a new PingLoader object
- loader/PingLoader.h: Declare the new PingLoader::createPingLoader method.
- 11:02 PM MathML 3 testsuite results edited by
- updating msqrt tests 6,7,8 to reflect progress. (diff)
- 10:55 PM MathML 3 testsuite results edited by
- updating mrow test 2 to reflect progress. (diff)
- 10:54 PM Changeset in webkit [158557] by
-
- 7 edits in trunk/Source/WebCore
HTMLOptionsCollection is always rooted at a HTMLSelectElement.
<https://webkit.org/b/123719>
Tighten up HTMLOptionsCollection by making the constructor take
a HTMLSelectElement& and adding a HTMLSelectElement& getter instead
of casting all over the place. Removed now-pointless assertions.
Reviewed by Sam Weinig.
- 10:53 PM MathML 3 testsuite results edited by
- Updated test results for mover 7,8,10,11,12 to reflect progress. (diff)
- 10:50 PM MathML 3 testsuite results edited by
- Updated test results for mover 1-5 to reflect progress. (diff)
- 9:55 PM MathML 3 testsuite results edited by
- Updated mfrac results for tests 2,3, and 4. (diff)
- 8:24 PM Changeset in webkit [158556] by
-
- 3 edits3 adds in trunk
Generated color wheel displays incorrectly (regressed in r155567)
https://bugs.webkit.org/show_bug.cgi?id=123664
Source/JavaScriptCore:
Reviewed by Andreas Kling.
Interestingly, r155567 just "un-broke" the attempt to constant-fold ArithMod, but
that constant folding was just wrong to begin with. There is no evidence that this
constant folding rule is profitable. I'm removing it instead of trying to think
about what it means for it to be correct.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
LayoutTests:
Reviewed by Andreas Kling.
- js/dfg-mod-1-expected.txt: Added.
- js/dfg-mod-1.html: Added.
- js/script-tests/dfg-mod-1.js: Added.
(foo):
- 8:12 PM Changeset in webkit [158555] by
-
- 1 edit66 moves70 deletes in trunk/LayoutTests
Optimize baselines: fast/repaint
Unreviewed; run "webkit-patch optimize-baselines fast/repaint"
- fast/repaint/4774354-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/4774354-expected.txt.
- fast/repaint/absolute-position-changed-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/absolute-position-changed-expected.png.
- fast/repaint/block-selection-gap-stale-cache-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/block-selection-gap-stale-cache-2-expected.png.
- fast/repaint/block-selection-gap-stale-cache-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/block-selection-gap-stale-cache-expected.png.
- fast/repaint/box-shadow-inset-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/box-shadow-inset-repaint-expected.txt.
- fast/repaint/button-spurious-layout-hint-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/button-spurious-layout-hint-expected.png.
- fast/repaint/canvas-putImageData-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/canvas-putImageData-expected.png.
- fast/repaint/clip-with-layout-delta-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/clip-with-layout-delta-expected.txt.
- fast/repaint/content-into-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/content-into-overflow-expected.png.
- fast/repaint/erase-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/erase-overflow-expected.png.
- fast/repaint/fixed-after-scroll-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-after-scroll-expected.png.
- fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-and-absolute-position-scrolled-expected.png.
- fast/repaint/fixed-position-transparency-with-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-position-transparency-with-overflow-expected.png.
- fast/repaint/fixed-scale-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-scale-expected.png.
- fast/repaint/fixed-scroll-simple-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-scroll-simple-expected.png.
- fast/repaint/fixed-table-cell-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-cell-expected.png.
- fast/repaint/fixed-table-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-overflow-expected.png.
- fast/repaint/fixed-table-overflow-zindex-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-overflow-zindex-expected.png.
- fast/repaint/fixed-tranformed-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-tranformed-expected.png.
- fast/repaint/float-in-new-block-with-layout-delta-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
- fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.txt.
- fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.txt.
- fast/repaint/inline-block-resize-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-block-resize-expected.png.
- fast/repaint/inline-horizontal-bt-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-horizontal-bt-overflow-expected.txt.
- fast/repaint/inline-vertical-lr-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-lr-overflow-expected.png.
- fast/repaint/inline-vertical-lr-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-lr-overflow-expected.txt.
- fast/repaint/inline-vertical-rl-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-rl-overflow-expected.png.
- fast/repaint/inline-vertical-rl-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-rl-overflow-expected.txt.
- fast/repaint/intermediate-layout-position-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/intermediate-layout-position-clip-expected.png.
- fast/repaint/japanese-rl-selection-clear-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt.
- fast/repaint/japanese-rl-selection-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt.
- fast/repaint/layer-hide-when-needs-layout-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/layer-hide-when-needs-layout-expected.png.
- fast/repaint/layer-visibility-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/layer-visibility-expected.png.
- fast/repaint/line-in-scrolled-clipped-block-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/line-in-scrolled-clipped-block-expected.txt.
- fast/repaint/moving-shadow-on-path-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/moving-shadow-on-path-expected.txt.
- fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png.
- fast/repaint/overflow-clip-subtree-layout-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.png.
- fast/repaint/overflow-into-content-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-into-content-expected.png.
- fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png.
- fast/repaint/reflection-repaint-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/reflection-repaint-test-expected.txt.
- fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
- fast/repaint/repaint-during-scroll-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-during-scroll-expected.png.
- fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.txt.
- fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-absolute-layer-with-reflection-expected.png.
- fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
- fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-layer-with-reflection-expected.png.
- fast/repaint/scroll-fixed-reflected-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-reflected-layer-expected.png.
- fast/repaint/scroll-in-clipped-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-in-clipped-layer-expected.png.
- fast/repaint/scroll-in-fixed-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-in-fixed-layer-expected.png.
- fast/repaint/subtree-root-clip-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-2-expected.png.
- fast/repaint/subtree-root-clip-3-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-3-expected.png.
- fast/repaint/subtree-root-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-expected.png.
- fast/repaint/table-cell-vertical-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/table-cell-vertical-overflow-expected.txt.
- fast/repaint/table-col-background-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-col-background-expected.png.
- fast/repaint/table-outer-border-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-outer-border-expected.png.
- fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png.
- fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
- fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png.
- fast/repaint/table-row-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-row-expected.png.
- fast/repaint/table-section-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-section-overflow-expected.png.
- fast/repaint/transform-layout-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/transform-layout-repaint-expected.txt.
- fast/repaint/view-background-from-body-1-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/view-background-from-body-1-expected.png.
- fast/repaint/view-background-from-body-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/view-background-from-body-2-expected.png.
- platform/efl-wk2/fast/repaint/selection-after-delete-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-after-delete-expected.png.
- platform/efl-wk2/fast/repaint/selection-after-remove-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-after-remove-expected.png.
- platform/efl-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-gap-overflow-scroll-2-expected.png.
- platform/gtk/fast/repaint/4774354-expected.txt: Removed.
- platform/gtk/fast/repaint/absolute-position-changed-expected.png: Removed.
- platform/gtk/fast/repaint/block-selection-gap-stale-cache-2-expected.png: Removed.
- platform/gtk/fast/repaint/block-selection-gap-stale-cache-expected.png: Removed.
- platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.txt: Removed.
- platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
- platform/gtk/fast/repaint/canvas-putImageData-expected.png: Removed.
- platform/gtk/fast/repaint/clip-with-layout-delta-expected.txt: Removed.
- platform/gtk/fast/repaint/content-into-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/erase-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-after-scroll-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-scale-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-scroll-simple-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-table-cell-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-table-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-table-overflow-zindex-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-tranformed-expected.png: Removed.
- platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
- platform/gtk/fast/repaint/inline-block-resize-expected.png: Removed.
- platform/gtk/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.png: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
- platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png: Removed.
- platform/gtk/fast/repaint/layer-visibility-expected.png: Removed.
- platform/gtk/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Removed.
- platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
- platform/gtk/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
- platform/gtk/fast/repaint/overflow-into-content-expected.png: Removed.
- platform/gtk/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/reflection-repaint-test-expected.txt: Removed.
- platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
- platform/gtk/fast/repaint/repaint-during-scroll-expected.png: Removed.
- platform/gtk/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Removed.
- platform/gtk/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-fixed-reflected-layer-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-in-clipped-layer-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-in-fixed-layer-expected.png: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-2-expected.png: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-3-expected.png: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-expected.png: Removed.
- platform/gtk/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/table-col-background-expected.png: Removed.
- platform/gtk/fast/repaint/table-outer-border-expected.png: Removed.
- platform/gtk/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/table-row-expected.png: Removed.
- platform/gtk/fast/repaint/table-section-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/transform-layout-repaint-expected.txt: Removed.
- platform/gtk/fast/repaint/view-background-from-body-1-expected.png: Removed.
- platform/gtk/fast/repaint/view-background-from-body-2-expected.png: Removed.
- platform/mac-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- platform/mac/fast/repaint/box-shadow-inset-repaint-expected.txt: Removed.
- platform/mac/fast/repaint/float-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/float-overflow-right-expected.txt: Removed.
- platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
- platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- 7:21 PM Changeset in webkit [158554] by
-
- 5 edits in trunk
Source/JavaScriptCore: Unreviewed, it is no longer necessary to call DisablePrettyStackTrace.
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
WebKitLibraries: Update binary drops to a version that includes my pretty stack trace changes.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 7:01 PM Changeset in webkit [158553] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Wrappers' -copyWithZone: should copy if the collection is mutable
https://bugs.webkit.org/show_bug.cgi?id=123707
Reviewed by Geoff Garen and Anders Carlsson.
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]): If the array is mutable, make a copy.
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary copyWithZone:]): If the dictionary is mutable, make a copy.
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::entries): Added this accessor.
- 6:57 PM Changeset in webkit [158552] by
-
- 4 edits in trunk/Source/WebKit2
Reverted r158538.
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]):
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary copyWithZone:]):
- Shared/ImmutableArray.h:
- 4:39 PM Changeset in webkit [158551] by
-
- 5 edits in trunk/Source/WebCore
RenderTextFragment: Tighten first-letter logic.
<https://webkit.org/b/123714>
Reviewed by Antti Koivisto.
- editing/TextIterator.cpp:
(WebCore::firstRenderTextInFirstLetter):
Use iterator helper to find first RenderText child.
(WebCore::TextIterator::handleTextNodeFirstLetter):
Tightening through type inference.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
- rendering/RenderTextFragment.h:
The first letter renderer is always a RenderBoxModelObject,
so make the code deal in that instead of RenderObject.
- rendering/RenderChildIterator.h:
(WebCore::RenderChildIteratorAdapter::first):
(WebCore::RenderChildIteratorAdapter::last):
Remove excess ampersands that were keeping this from building.
- 4:35 PM Changeset in webkit [158550] by
-
- 2 edits2 copies12 moves2 adds13 deletes in trunk/LayoutTests
Optimize baselines: fast/forms
Unreviewed; run "webkit-patch optimize-baselines fast/forms"
- fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
- fast/forms/fieldset-with-float-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/fieldset-with-float-expected.txt.
- fast/forms/input-no-renderer-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/input-no-renderer-expected.txt.
- fast/forms/label/labelable-elements-expected.txt: Renamed from LayoutTests/platform/gtk/fast/forms/label/labelable-elements-expected.txt.
- fast/forms/range/slider-thumb-stylability-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/range/slider-thumb-stylability-expected.png.
- fast/forms/select-listbox-multiple-no-focusring-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-listbox-multiple-no-focusring-expected.txt.
- fast/forms/select-overflow-scroll-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-overflow-scroll-expected.txt.
- fast/forms/select-overflow-scroll-inherited-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-overflow-scroll-inherited-expected.txt.
- fast/forms/textfield-overflow-by-value-update-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/textfield-overflow-by-value-update-expected.png.
- fast/forms/textfield-overflow-by-value-update-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/textfield-overflow-by-value-update-expected.txt.
- platform/efl-wk2/fast/forms/validation-message-appearance-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/validation-message-appearance-expected.png.
- platform/gtk/fast/forms/fieldset-with-float-expected.txt: Removed.
- platform/gtk/fast/forms/input-no-renderer-expected.txt: Removed.
- platform/gtk/fast/forms/range/slider-thumb-stylability-expected.png: Removed.
- platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Removed.
- platform/gtk/fast/forms/select-overflow-scroll-expected.txt: Removed.
- platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt: Removed.
- platform/gtk/fast/forms/textfield-overflow-by-value-update-expected.png: Removed.
- platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Removed.
- platform/mac/fast/forms/label/labelable-elements-expected.txt: Removed.
- platform/mac/fast/forms/textfield-overflow-by-value-update-expected.txt: Removed.
- platform/win-7sp0/fast/forms/cursor-at-editable-content-boundary-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt.
- platform/win-7sp0/fast/forms/implicit-submission-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/implicit-submission-expected.txt.
- platform/win-7sp0/fast/forms/range/slider-mouse-events-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/range/slider-mouse-events-expected.txt.
- platform/win-7sp0/fast/forms/select-popup-pagekeys-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/select-popup-pagekeys-expected.txt.
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Removed.
- 4:15 PM Changeset in webkit [158549] by
-
- 4 edits in trunk/Source/WebCore
CSSPrimitiveValue identifier constructors should return PassRef.
<https://webkit.org/b/123712>
Make CSSPrimitiveValue::createIdentifier() and the corresponding
CSSValuePool helper return PassRef<CSSPrimitiveValue>.
Reviewed by Antti Koivisto.
- 4:13 PM Changeset in webkit [158548] by
-
- 4 edits in trunk/Source/WebCore
Use RenderChildIterator in two more loops.
<https://webkit.org/b/123713>
Switch two more renderer child traversal loops to childrenOfType.
Reviewed by Antti Koivisto.
- 3:43 PM Changeset in webkit [158547] by
-
- 2 edits36 moves2 adds36 deletes in trunk/LayoutTests
Optimize baselines: editing
Unreviewed; run "webkit-patch optimize-baselines editing"
- editing/deleting/delete-3775172-fix-expected.png: Renamed from LayoutTests/platform/efl/editing/deleting/delete-3775172-fix-expected.png.
- editing/deleting/delete-after-span-ws-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-001-expected.txt.
- editing/deleting/delete-after-span-ws-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-002-expected.txt.
- editing/deleting/delete-after-span-ws-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-003-expected.txt.
- editing/deleting/delete-at-start-or-end-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-at-start-or-end-expected.txt.
- editing/deleting/delete-br-002-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.txt.
- editing/deleting/delete-br-004-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-004-expected.txt.
- editing/deleting/delete-br-005-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-005-expected.txt.
- editing/deleting/delete-br-006-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-006-expected.txt.
- editing/deleting/delete-line-end-ws-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-line-end-ws-001-expected.txt.
- editing/deleting/delete-line-end-ws-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-line-end-ws-002-expected.txt.
- editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt:
- editing/inserting/insert-3851164-fix-expected.png: Renamed from LayoutTests/platform/efl/editing/inserting/insert-3851164-fix-expected.png.
- editing/selection/5195166-1-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/5195166-1-expected.txt.
- editing/selection/editable-links-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/editable-links-expected.txt.
- editing/selection/focus-body-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/focus-body-expected.txt.
- editing/selection/select-all-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-001-expected.txt.
- editing/selection/select-all-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-002-expected.txt.
- editing/selection/select-all-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-003-expected.txt.
- editing/selection/select-all-004-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-004-expected.txt.
- editing/selection/unrendered-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-001-expected.txt.
- editing/selection/unrendered-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-002-expected.txt.
- editing/selection/unrendered-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-003-expected.txt.
- editing/selection/unrendered-004-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-004-expected.txt.
- editing/selection/unrendered-005-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-005-expected.txt.
- editing/undo/5378473-expected.txt: Renamed from LayoutTests/platform/efl/editing/undo/5378473-expected.txt.
- editing/undo/undo-misspellings-expected.txt: Renamed from LayoutTests/platform/efl/editing/undo/undo-misspellings-expected.txt.
- editing/unsupported-content/table-delete-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-001-expected.txt.
- editing/unsupported-content/table-delete-003-expected.png: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-003-expected.png.
- editing/unsupported-content/table-delete-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-003-expected.txt.
- platform/efl-wk2/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Renamed from LayoutTests/platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt.
- platform/efl/editing/caret/caret-color-expected.txt: Renamed from LayoutTests/editing/caret/caret-color-expected.txt.
- platform/efl/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-3775172-fix-expected.png: Removed.
- platform/gtk/editing/deleting/delete-after-span-ws-001-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt: Removed.
- platform/gtk/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
- platform/gtk/editing/inserting/insert-3851164-fix-expected.png: Removed.
- platform/gtk/editing/selection/editable-links-expected.txt: Removed.
- platform/gtk/editing/selection/focus-body-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-001-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-002-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-003-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-004-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-001-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-002-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-003-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-004-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-005-expected.txt: Removed.
- platform/mac/editing/deleting/delete-at-start-or-end-expected.txt: Removed.
- platform/mac/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
- platform/mac/editing/inserting/insert-div-010-expected.txt: Renamed from LayoutTests/editing/inserting/insert-div-010-expected.txt.
- platform/mac/editing/selection/5195166-1-expected.txt: Removed.
- platform/mac/editing/style/unbold-in-bold-expected.txt: Renamed from LayoutTests/editing/style/unbold-in-bold-expected.txt.
- platform/mac/editing/undo/5378473-expected.txt: Removed.
- platform/mac/editing/undo/undo-misspellings-expected.txt: Removed.
- platform/mac/editing/unsupported-content/table-delete-001-expected.txt: Removed.
- platform/mac/editing/unsupported-content/table-delete-003-expected.png: Removed.
- platform/mac/editing/unsupported-content/table-delete-003-expected.txt: Removed.
- platform/win-7sp0/editing/selection/collapse-selection-in-bidi-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/collapse-selection-in-bidi-expected.txt.
- platform/win-7sp0/editing/selection/drag-text-delay-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/drag-text-delay-expected.txt.
- platform/win-7sp0/editing/selection/extend-selection-home-end-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/extend-selection-home-end-expected.txt.
- platform/win/editing/deleting/delete-br-002-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-004-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-005-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-006-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-009-expected.txt: Removed.
- platform/win/editing/inserting/insert-3800346-fix-expected.txt: Removed.
- platform/win/editing/selection/anchor-focus2-expected.txt: Removed.
- platform/win/editing/selection/anchor-focus3-expected.txt: Removed.
- 3:32 PM Changeset in webkit [158546] by
-
- 3 edits55 moves2 adds80 deletes in trunk/LayoutTests
Optimize baselines: tables
Unreviewed; run "webkit-patch optimize-baselines tables"
- platform/gtk/tables/mozilla/bugs/adforce_imgis_com-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-1-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-3-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-4-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug10269-1-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug10296-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug103533-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug11321-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug12908-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug13105-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug14159-3-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug149275-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug1818-6-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug196870-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug222336-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug222467-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug23072-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug23151-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug23994-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug26553-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug269566-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug27038-3-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug275625-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug277062-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug2886-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug28933-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug3037-1-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug3037-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug32447-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug34538-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug56405-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug641-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug75250-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug8032-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug8361-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug9024-expected.png: Removed.
- platform/gtk/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Removed.
- platform/gtk/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug120107-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1271-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug131020-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug13169-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug157890-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1818-3-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1818-6-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug196870-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug222336-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug222467-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug269566-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug277062-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug28933-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug29314-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2954-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug56201-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug8032-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug92647-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug27038-3-expected.txt: Removed.
- platform/mac/tables/mozilla/core/row_span-expected.txt: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
- platform/win-future/tables/mozilla/core/bloomberg-expected.txt: Renamed from LayoutTests/tables/mozilla/core/bloomberg-expected.txt.
- platform/win-future/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt: Renamed from LayoutTests/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt.
- platform/win/tables/mozilla/bugs/bug133756-1-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug133756-2-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug220536-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug8858-expected.txt: Removed.
- platform/win/tables/mozilla/core/row_span-expected.txt: Removed.
- platform/win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
- platform/win/tables/mozilla_expected_failures/bugs/bug65372-expected.txt: Removed.
- tables/mozilla/bugs/adforce_imgis_com-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/adforce_imgis_com-expected.txt.
- tables/mozilla/bugs/bug102145-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-1-expected.png.
- tables/mozilla/bugs/bug102145-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-2-expected.png.
- tables/mozilla/bugs/bug102145-3-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-3-expected.png.
- tables/mozilla/bugs/bug102145-4-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-4-expected.png.
- tables/mozilla/bugs/bug10269-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug10269-1-expected.png.
- tables/mozilla/bugs/bug10296-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug10296-2-expected.png.
- tables/mozilla/bugs/bug103533-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug103533-expected.png.
- tables/mozilla/bugs/bug11321-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug11321-expected.png.
- tables/mozilla/bugs/bug12908-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug12908-2-expected.png.
- tables/mozilla/bugs/bug13105-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug13105-expected.png.
- tables/mozilla/bugs/bug133756-1-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug133756-1-expected.txt.
- tables/mozilla/bugs/bug133756-2-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug133756-2-expected.txt.
- tables/mozilla/bugs/bug14159-3-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug14159-3-expected.png.
- tables/mozilla/bugs/bug149275-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug149275-2-expected.txt.
- tables/mozilla/bugs/bug1818-6-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug1818-6-expected.png.
- tables/mozilla/bugs/bug196870-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug196870-expected.png.
- tables/mozilla/bugs/bug220536-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug220536-expected.txt.
- tables/mozilla/bugs/bug222336-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug222336-expected.png.
- tables/mozilla/bugs/bug222467-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug222467-expected.png.
- tables/mozilla/bugs/bug23072-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23072-expected.png.
- tables/mozilla/bugs/bug23151-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23151-expected.txt.
- tables/mozilla/bugs/bug23994-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23994-expected.png.
- tables/mozilla/bugs/bug26553-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug26553-expected.txt.
- tables/mozilla/bugs/bug269566-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug269566-expected.png.
- tables/mozilla/bugs/bug27038-3-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug27038-3-expected.txt.
- tables/mozilla/bugs/bug275625-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug275625-expected.png.
- tables/mozilla/bugs/bug277062-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug277062-expected.png.
- tables/mozilla/bugs/bug2886-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug2886-2-expected.txt.
- tables/mozilla/bugs/bug28933-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug28933-expected.png.
- tables/mozilla/bugs/bug3037-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug3037-1-expected.png.
- tables/mozilla/bugs/bug3037-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug3037-2-expected.png.
- tables/mozilla/bugs/bug32447-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug32447-expected.png.
- tables/mozilla/bugs/bug34538-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug34538-expected.png.
- tables/mozilla/bugs/bug56405-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug56405-expected.png.
- tables/mozilla/bugs/bug641-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug641-2-expected.png.
- tables/mozilla/bugs/bug75250-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug75250-expected.png.
- tables/mozilla/bugs/bug8032-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug8032-2-expected.png.
- tables/mozilla/bugs/bug8361-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug8361-expected.png.
- tables/mozilla/bugs/bug8858-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug8858-expected.txt.
- tables/mozilla/bugs/bug9024-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug9024-expected.png.
- tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png.
- tables/mozilla/core/row_span-expected.txt:
- tables/mozilla/marvin/table_overflow_hidden_td-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt.
- tables/mozilla_expected_failures/bugs/bug128876-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug128876-expected.png.
- tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- tables/mozilla_expected_failures/bugs/bug178855-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug178855-expected.png.
- tables/mozilla_expected_failures/bugs/bug3517-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.png.
- tables/mozilla_expected_failures/bugs/bug65372-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug65372-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png.
- tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt.
- 2:26 PM Changeset in webkit [158545] by
-
- 3 edits in trunk/LayoutTests
Precision errors in Math.cbrt() on GTK, EFL
https://bugs.webkit.org/show_bug.cgi?id=123624
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-11-03
Reviewed by Csaba Osztrogonác.
Calculate cube roots of 8 and -8, expecting 2 and -2, respectively. Cube roots of those two
numbers don't contain precision errors on the GTK and EFL ports as is the case with 27 and -27.
- js/math-expected.txt:
- js/script-tests/math.js:
- 2:18 PM Changeset in webkit [158544] by
-
- 3 edits in trunk/Source/WebCore
CSSShadowValue constructor should return PassRef.
<https://webkit.org/b/123711>
Make CSSShadowValue::create() return a PassRef since it will never
return null.
Reviewed by Sam Weinig.
- 2:17 PM Changeset in webkit [158543] by
-
- 3 edits in trunk/Source/WebCore
CSSLineBoxContainValue constructor should return PassRef.
<https://webkit.org/b/123710>
Make CSSLineBoxContainValue::create() return a PassRef since it
will never return null.
Reviewed by Sam Weinig.
- 2:17 PM Changeset in webkit [158542] by
-
- 1 edit5 moves5 deletes in trunk/LayoutTests
Optimize baselines: fast/frames
Unreviewed; run "webkit-patch optimize-baselines fast/frames"
- fast/frames/002-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/002-expected.png.
- fast/frames/empty-cols-attribute-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/empty-cols-attribute-expected.png.
- fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Renamed from LayoutTests/platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.txt.
- fast/frames/frame-set-whitespace-attributes-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/frame-set-whitespace-attributes-expected.png.
- fast/frames/no-frame-borders-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/no-frame-borders-expected.png.
- platform/gtk/fast/frames/002-expected.png: Removed.
- platform/gtk/fast/frames/empty-cols-attribute-expected.png: Removed.
- platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Removed.
- platform/gtk/fast/frames/frame-set-whitespace-attributes-expected.png: Removed.
- platform/gtk/fast/frames/no-frame-borders-expected.png: Removed.
- 1:52 PM Changeset in webkit [158541] by
-
- 4 edits in trunk/Source/JavaScriptCore
Assertion failure in non-JIT'ed LLInt on ARM Thumb.
https://bugs.webkit.org/show_bug.cgi?id=97569.
Reviewed by Geoffrey Garen.
- assembler/MacroAssemblerCodeRef.h:
- Thumb2 alignment assertions do not apply to the C Loop LLINT because the arguments passed to those assertions are actually OpcodeIDs masquerading as addresses.
- llint/LLIntOfflineAsmConfig.h:
- Some of the #defines belong in the !ENABLE(LLINT_C_LOOP) section. Moving them there.
- llint/LowLevelInterpreter.cpp:
- Keep the compiler happy from some unreferenced C Loop labels.
- 1:32 PM Changeset in webkit [158540] by
-
- 29 edits in trunk/Source/WebCore
LiveNodeLists should have non-null ContainerNode as root
https://bugs.webkit.org/show_bug.cgi?id=123709
Reviewed by Andreas Kling.
After moving ChildNodeList off from LiveNodeList the root is now always at least a ContainerNode.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByTagNameNS):
(WebCore::ContainerNode::getElementsByName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::radioNodeList):
Also these move from Node to ContainerNode to make tighter typing work.
- 1:08 PM Changeset in webkit [158539] by
-
- 1 edit21 moves24 deletes in trunk/LayoutTests
Optimize baselines: fast/table
Unreviewed; run "webkit-patch optimize-baselines fast/table"
- fast/table/022-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/022-expected.txt.
- fast/table/024-expected.png: Renamed from LayoutTests/platform/efl/fast/table/024-expected.png.
- fast/table/031-expected.png: Renamed from LayoutTests/platform/efl/fast/table/031-expected.png.
- fast/table/032-expected.png: Renamed from LayoutTests/platform/efl/fast/table/032-expected.png.
- fast/table/034-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/034-expected.txt.
- fast/table/auto-100-percent-width-expected.png: Renamed from LayoutTests/platform/efl/fast/table/auto-100-percent-width-expected.png.
- fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Renamed from LayoutTests/platform/efl/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png.
- fast/table/div-as-col-span-expected.png: Renamed from LayoutTests/platform/efl/fast/table/div-as-col-span-expected.png.
- fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt.
- fast/table/giantCellspacing-expected.png: Renamed from LayoutTests/platform/efl/fast/table/giantCellspacing-expected.png.
- fast/table/giantCellspacing-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/giantCellspacing-expected.txt.
- fast/table/giantRowspan-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/giantRowspan-expected.txt.
- fast/table/giantRowspan2-expected.txt: Renamed from LayoutTests/platform/mac/fast/table/giantRowspan2-expected.txt.
- fast/table/percent-widths-stretch-vertical-expected.png: Renamed from LayoutTests/platform/efl/fast/table/percent-widths-stretch-vertical-expected.png.
- fast/table/table-before-child-style-update-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-before-child-style-update-expected.png.
- fast/table/table-row-before-child-style-update-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-before-child-style-update-expected.png.
- fast/table/table-row-style-not-updated-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-expected.png.
- fast/table/table-row-style-not-updated-with-after-content-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.png.
- fast/table/table-row-style-not-updated-with-before-content-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.png.
- fast/table/table-style-not-updated-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-style-not-updated-expected.png.
- fast/table/vertical-align-baseline-readjust-expected.png: Renamed from LayoutTests/platform/efl/fast/table/vertical-align-baseline-readjust-expected.png.
- platform/gtk/fast/table/022-expected.txt: Removed.
- platform/gtk/fast/table/024-expected.png: Removed.
- platform/gtk/fast/table/031-expected.png: Removed.
- platform/gtk/fast/table/032-expected.png: Removed.
- platform/gtk/fast/table/034-expected.txt: Removed.
- platform/gtk/fast/table/auto-100-percent-width-expected.png: Removed.
- platform/gtk/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Removed.
- platform/gtk/fast/table/div-as-col-span-expected.png: Removed.
- platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Removed.
- platform/gtk/fast/table/giantCellspacing-expected.png: Removed.
- platform/gtk/fast/table/giantCellspacing-expected.txt: Removed.
- platform/gtk/fast/table/giantRowspan-expected.txt: Removed.
- platform/gtk/fast/table/percent-widths-stretch-vertical-expected.png: Removed.
- platform/gtk/fast/table/table-before-child-style-update-expected.png: Removed.
- platform/gtk/fast/table/table-row-before-child-style-update-expected.png: Removed.
- platform/gtk/fast/table/table-row-style-not-updated-expected.png: Removed.
- platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.png: Removed.
- platform/gtk/fast/table/table-row-style-not-updated-with-before-content-expected.png: Removed.
- platform/gtk/fast/table/table-style-not-updated-expected.png: Removed.
- platform/gtk/fast/table/vertical-align-baseline-readjust-expected.png: Removed.
- platform/mac/fast/table/022-expected.txt: Removed.
- platform/mac/fast/table/giantCellspacing-expected.txt: Removed.
- platform/mac/fast/table/giantRowspan-expected.txt: Removed.
- platform/win/fast/table/giantRowspan-expected.txt: Removed.
- platform/win/fast/table/giantRowspan2-expected.txt: Removed.
- 12:41 PM Changeset in webkit [158538] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Wrappers' -copyWithZone: should copy if the collection is mutable
https://bugs.webkit.org/show_bug.cgi?id=123707
Reviewed by Geoff Garen.
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]): If the array is mutable, make a copy.
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary copyWithZone:]): If the dictionary is mutable, make a copy.
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::entries): Added this accessor.
- 12:19 PM Changeset in webkit [158537] by
-
- 5 edits in trunk/Source/WebCore
Switch createContextualFragment to element iterator
https://bugs.webkit.org/show_bug.cgi?id=123704
Reviewed by Andreas Kling.
- editing/FrameSelection.cpp:
(WebCore::scanForForm):
Use type helpers instead of hasTagName
- editing/markup.cpp:
(WebCore::collectElementsToRemoveFromFragment):
(WebCore::removeElementFromFragmentPreservingChildren):
(WebCore::createContextualFragment):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndex):
Use type helpers instead of hasTagName
- html/HTMLTagNames.in:
Generate type helpers for <html>.
- 11:52 AM Changeset in webkit [158536] by
-
- 11 edits in trunk/Source/WebCore
ChildNodeList should not be LiveNodeList
https://bugs.webkit.org/show_bug.cgi?id=123708
Reviewed by Sam Weinig.
ChildNodeList is a poor fit to be a LiveNodeList. It is heavily special-cased. It is also
the only subtype that returns non-Elements thus preventing tightening.
- bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
Support new types.
- dom/ChildNodeList.cpp:
(WebCore::EmptyNodeList::~EmptyNodeList):
(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::~ChildNodeList):
(WebCore::ChildNodeList::length):
(WebCore::childFromFirst):
(WebCore::childFromLast):
(WebCore::ChildNodeList::nodeBeforeCached):
(WebCore::ChildNodeList::nodeAfterCached):
(WebCore::ChildNodeList::item):
(WebCore::ChildNodeList::namedItem):
(WebCore::ChildNodeList::invalidateCache):
Implement the same caching optimizations as LiveNodeList with tighter, less generic code.
- dom/ChildNodeList.h:
Inherit ChildNodeList directly from NodeList.
Add new EmptyNodeList type. This is only ever used if NodeList is requested for a non-container node.
It allows tighter typing in ChildNodeList.
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeList::namedItem):
- dom/LiveNodeList.h:
(WebCore::LiveNodeListBase::LiveNodeListBase):
(WebCore::LiveNodeListBase::~LiveNodeListBase):
(WebCore::LiveNodeList::LiveNodeList):
Remove ChildNodeList specific code and branches.
- dom/Node.cpp:
(WebCore::Node::childNodes):
Return EmptyNodeList for non-containers.
- dom/NodeList.h:
(WebCore::NodeList::~NodeList):
(WebCore::NodeList::isLiveNodeList):
(WebCore::NodeList::isChildNodeList):
(WebCore::NodeList::isEmptyNodeList):
For isReachableFromOpaqueRoots.
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::ensureChildNodeList):
(WebCore::NodeListsNodeData::removeChildNodeList):
(WebCore::NodeListsNodeData::ensureEmptyChildNodeList):
(WebCore::NodeListsNodeData::removeEmptyChildNodeList):
(WebCore::NodeListsNodeData::NodeListsNodeData):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList):
EmptyNodeList support.
- html/CollectionType.h:
- html/HTMLCollection.cpp:
(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::isMatchingElement):
(WebCore::LiveNodeListBase::itemBefore):
(WebCore::LiveNodeListBase::traverseLiveNodeListFirstElement):
(WebCore::LiveNodeListBase::traverseLiveNodeListForwardToOffset):
(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::itemBeforeOrAfterCachedItem):
Remove ChildNodeList specific code and branches.
- 10:24 AM Changeset in webkit [158535] by
-
- 14 edits in trunk/Source/JavaScriptCore
FTL should use LLVM intrinsics for OSR exit, watchpoints, inline caches, and stack layout
https://bugs.webkit.org/show_bug.cgi?id=122318
Reviewed by Geoffrey Garen.
This all now works. This patch just updates our implementation to work with LLVM trunk,
and removes all of the old code that tried to do OSR exits and heap accesses without
the benefit of those intrinsics.
In particular:
- StackMaps parsing now uses the new, less compact, but more future-proof, format.
- Remove the ftlUsesStackmaps() option and hard-code ftlUsesStackmaps = true. Remove all code for ftlUsesStackmaps = false, since that was only there for back when we didn't have the intrinsics.
- Remove the other experimental OSR options (useLLVMOSRExitIntrinsic, ftlTrapsOnOSRExit, and FTLOSRExitOmitsMarshalling).
- Remove LowerDFGToLLVM's use of the ExitThunkGenerator since we don't need to generate the exit thunks until after we parse the stackmaps.
- Remove all of the exit thunk and compiler code for the no-stackmaps case.
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLExitThunkGenerator.cpp:
(JSC::FTL::ExitThunkGenerator::emitThunk):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::forStackmaps):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::callStackmap):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
- ftl/FTLOSRExitCompilationInfo.h:
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):
- ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::Location::parse):
(JSC::FTL::StackMaps::parse):
(WTF::printInternal):
- ftl/FTLStackMaps.h:
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationThunkGenerator):
- ftl/FTLThunks.h:
(JSC::FTL::Thunks::getOSRExitGenerationThunk):
- runtime/Options.h:
- 9:51 AM Changeset in webkit [158534] by
-
- 2 edits in trunk/Tools
Add test for ListHashSet::removeLast()
https://bugs.webkit.org/show_bug.cgi?id=121810
Reviewed by Anders Carlsson.
- TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
(TestWebKitAPI::TEST):
- 9:48 AM Changeset in webkit [158533] by
-
- 10 edits in trunk/Source
[WINCE] Replace OwnPtr with GDIObject
https://bugs.webkit.org/show_bug.cgi?id=123670
Reviewed by Anders Carlsson.
Source/WebCore:
- page/win/FrameGdiWin.cpp:
(WebCore::imageFromRect):
- platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FixedSizeFontData::create):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::getScaledFontHandle):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::createPen):
(WebCore::createBrush):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::drawRoundCorner):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawText):
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
- platform/graphics/wince/SharedBitmap.cpp:
(WebCore::SharedBitmap::createHandle):
(WebCore::SharedBitmap::draw):
(WebCore::SharedBitmap::clipBitmap):
(WebCore::drawPatternSimple):
(WebCore::SharedBitmap::drawPattern):
(WebCore::SharedBitmap::DCProvider::getDC):
- platform/graphics/wince/SharedBitmap.h:
Source/WebKit/wince:
- WebView.cpp:
(WebView::paint):
(WebView::handlePaint):
- WebView.h:
- 6:55 AM Changeset in webkit [158532] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK1] Some tests of editing/selection fail to render properly
https://bugs.webkit.org/show_bug.cgi?id=117574
Unreviewed, EFL gardening.
These tests are passed in wk1(and wk2), but skipped in wk1.
These tests have been reviewed since those are added.
Now these tests are operating properly, so those need to update the test expectations.
Also 'editing/selection/caret-and-focus-ring.html' is already changed a reason of failure by Bug no.123696
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-03
- platform/efl-wk1/TestExpectations:
- 3:19 AM Changeset in webkit [158531] by
-
- 1 edit36 moves30 deletes in trunk/LayoutTests
Optimize baselines: fast/text
Unreviewed; run "webkit-patch optimize-baselines fast/text"
- fast/text/decorations-transformed-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/decorations-transformed-expected.txt.
- fast/text/fixed-pitch-control-characters-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/fixed-pitch-control-characters-expected.txt.
- fast/text/international/001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/001-expected.txt.
- fast/text/international/vertical-text-glyph-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt.
- fast/text/international/vertical-text-metrics-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/vertical-text-metrics-test-expected.txt.
- fast/text/international/wrap-CJK-001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/wrap-CJK-001-expected.txt.
- fast/text/justify-ideograph-complex-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-complex-expected.txt.
- fast/text/justify-ideograph-simple-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-simple-expected.txt.
- fast/text/justify-ideograph-vertical-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-vertical-expected.txt.
- fast/text/selection-painted-separately-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/selection-painted-separately-expected.txt.
- fast/text/soft-hyphen-2-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/soft-hyphen-2-expected.txt.
- fast/text/soft-hyphen-3-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/soft-hyphen-3-expected.txt.
- fast/text/stripNullFromText-expected.png: Renamed from LayoutTests/platform/efl/fast/text/stripNullFromText-expected.png.
- fast/text/updateNewFont-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/updateNewFont-expected.txt.
- fast/text/whitespace/001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/001-expected.txt.
- fast/text/whitespace/013-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/013-expected.txt.
- fast/text/whitespace/014-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/014-expected.txt.
- fast/text/whitespace/017-expected.png: Renamed from LayoutTests/platform/efl/fast/text/whitespace/017-expected.png.
- fast/text/whitespace/017-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/017-expected.txt.
- fast/text/whitespace/029-expected.png: Renamed from LayoutTests/platform/efl/fast/text/whitespace/029-expected.png.
- fast/text/whitespace/029-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/029-expected.txt.
- fast/text/whitespace/pre-newline-box-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/pre-newline-box-test-expected.txt.
- fast/text/whitespace/tab-character-basics-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/tab-character-basics-expected.txt.
- platform/efl-wk1/fast/text/complex-text-opacity-expected.png: Renamed from LayoutTests/platform/efl/fast/text/complex-text-opacity-expected.png.
- platform/efl-wk1/fast/text/complex-text-opacity-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/complex-text-opacity-expected.txt.
- platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.png: Renamed from LayoutTests/platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.png.
- platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt.
- platform/efl-wk2/fast/text/atsui-pointtooffset-calls-cg-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png.
- platform/efl-wk2/fast/text/atsui-rtl-override-selection-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-rtl-override-selection-expected.png.
- platform/efl-wk2/fast/text/atsui-small-caps-punctuation-size-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.png.
- platform/efl-wk2/fast/text/hyphenate-character-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-character-expected.png.
- platform/efl-wk2/fast/text/hyphenate-first-word-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-first-word-expected.png.
- platform/efl-wk2/fast/text/hyphenate-limit-before-after-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-before-after-expected.png.
- platform/efl-wk2/fast/text/hyphenate-limit-lines-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-lines-expected.png.
- platform/efl-wk2/fast/text/hyphens-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphens-expected.png.
- platform/efl-wk2/fast/text/midword-break-before-surrogate-pair-2-expected.png: Renamed from LayoutTests/platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.png.
- platform/gtk/fast/text/decorations-transformed-expected.txt: Removed.
- platform/gtk/fast/text/fixed-pitch-control-characters-expected.txt: Removed.
- platform/gtk/fast/text/international/001-expected.txt: Removed.
- platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
- platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt: Removed.
- platform/gtk/fast/text/international/wrap-CJK-001-expected.txt: Removed.
- platform/gtk/fast/text/justify-ideograph-complex-expected.txt: Removed.
- platform/gtk/fast/text/justify-ideograph-simple-expected.txt: Removed.
- platform/gtk/fast/text/justify-ideograph-vertical-expected.txt: Removed.
- platform/gtk/fast/text/selection-painted-separately-expected.txt: Removed.
- platform/gtk/fast/text/soft-hyphen-2-expected.txt: Removed.
- platform/gtk/fast/text/soft-hyphen-3-expected.txt: Removed.
- platform/gtk/fast/text/stripNullFromText-expected.png: Removed.
- platform/gtk/fast/text/updateNewFont-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/001-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/017-expected.png: Removed.
- platform/gtk/fast/text/whitespace/017-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/029-expected.png: Removed.
- platform/gtk/fast/text/whitespace/029-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/pre-newline-box-test-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/tab-character-basics-expected.txt: Removed.
- platform/mac/fast/text/decorations-transformed-expected.txt: Removed.
- platform/mac/fast/text/fixed-pitch-control-characters-expected.txt: Removed.
- platform/mac/fast/text/selection-painted-separately-expected.txt: Removed.
- platform/mac/fast/text/soft-hyphen-2-expected.txt: Removed.
- platform/mac/fast/text/soft-hyphen-3-expected.txt: Removed.
- platform/mac/fast/text/whitespace/001-expected.txt: Removed.
- platform/mac/fast/text/whitespace/013-expected.txt: Removed.
- platform/mac/fast/text/whitespace/014-expected.txt: Removed.
- platform/mac/fast/text/whitespace/017-expected.txt: Removed.
- 3:13 AM Changeset in webkit [158530] by
-
- 5 edits in trunk/Source/WebCore
Add helpers for partial descendant traversal to element iterators
https://bugs.webkit.org/show_bug.cgi?id=123703
Reviewed by Andreas Kling.
- dom/ElementAncestorIterator.h:
(WebCore::lineageOfType):
lineageOfType definition didn't match the declaration.
- dom/ElementDescendantIterator.h:
(WebCore::::find):
(WebCore::::from):
Add find and from for getting begin iterator for partial traversals.
- editing/FrameSelection.cpp:
(WebCore::scanForForm):
(WebCore::FrameSelection::currentForm):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndex):
(WebCore::HTMLFormElement::findClosestFormAncestor):
Use them in a few places.
- 1:54 AM Changeset in webkit [158529] by
-
- 3 edits in trunk/Source/WebCore
Inline RenderStyle functions for getting/setting pseudo style bits.
<https://webkit.org/b/123702>
hasPseudoStyle() actually shows up on html5-full-render.html,
and it's pretty crazy to eat the cost of a function call just
to do some basic bit twiddling.
Reviewed by Antti Koivisto.
- 1:41 AM Changeset in webkit [158528] by
-
- 1 edit8 moves1 add5 deletes in trunk/LayoutTests
Optimize baselines: fast/canvas
Unreviewed; run "webkit-patch optimize-baselines fast/canvas"
- fast/canvas/canvas-empty-image-pattern-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-empty-image-pattern-expected.png.
- fast/canvas/canvas-incremental-repaint-2-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-incremental-repaint-2-expected.png.
- fast/canvas/canvas-render-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-render-layer-expected.png.
- fast/canvas/set-colors-expected.txt: Renamed from LayoutTests/platform/efl/fast/canvas/set-colors-expected.txt.
- platform/gtk/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
- platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.png: Removed.
- platform/gtk/fast/canvas/canvas-render-layer-expected.png: Removed.
- platform/gtk/fast/canvas/set-colors-expected.txt: Removed.
- platform/win-7sp0/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt.
- platform/win-7sp0/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt.
- platform/win-7sp0/fast/canvas/canvas-render-layer-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-render-layer-expected.txt.
- platform/win-7sp0/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt.
- platform/win-xp/fast/canvas/set-colors-expected.txt: Removed.
- 1:30 AM Changeset in webkit [158527] by
-
- 77 edits2 deletes in trunk
Remove HTMLMediaElement.initialTime
https://bugs.webkit.org/show_bug.cgi?id=123572
Reviewed by Eric Carlson.
Source/WebCore:
Patch based on one by: philipj@opera.com
Blink review URL: https://codereview.chromium.org/35033002
initialTime has been removed from the HTMLMediaElement.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_media_element_get_initial_time):
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols: Added phony function.
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl: Removed HTMLMediaElement::initialTime.
LayoutTests:
Blink review URL: https://codereview.chromium.org/35033002
Removed presence of initialTime in the tests.
- media/media-fragments/TC0001-expected.txt:
- media/media-fragments/TC0002-expected.txt:
- media/media-fragments/TC0003-expected.txt:
- media/media-fragments/TC0004-expected.txt:
- media/media-fragments/TC0005-expected.txt:
- media/media-fragments/TC0006-expected.txt:
- media/media-fragments/TC0009-expected.txt:
- media/media-fragments/TC0011-expected.txt:
- media/media-fragments/TC0012-expected.txt:
- media/media-fragments/TC0014-expected.txt:
- media/media-fragments/TC0015-expected.txt:
- media/media-fragments/TC0017-expected.txt:
- media/media-fragments/TC0024-expected.txt:
- media/media-fragments/TC0027-expected.txt:
- media/media-fragments/TC0028-expected.txt:
- media/media-fragments/TC0029-expected.txt:
- media/media-fragments/TC0030-expected.txt:
- media/media-fragments/TC0031-expected.txt:
- media/media-fragments/TC0032-expected.txt:
- media/media-fragments/TC0033-expected.txt:
- media/media-fragments/TC0034-expected.txt:
- media/media-fragments/TC0035-expected.txt:
- media/media-fragments/TC0036-expected.txt:
- media/media-fragments/TC0037-expected.txt:
- media/media-fragments/TC0038-expected.txt:
- media/media-fragments/TC0039-expected.txt:
- media/media-fragments/TC0044-expected.txt:
- media/media-fragments/TC0051-expected.txt:
- media/media-fragments/TC0052-expected.txt:
- media/media-fragments/TC0053-expected.txt:
- media/media-fragments/TC0054-expected.txt:
- media/media-fragments/TC0055-expected.txt:
- media/media-fragments/TC0058-expected.txt:
- media/media-fragments/TC0059-expected.txt:
- media/media-fragments/TC0061-expected.txt:
- media/media-fragments/TC0062-expected.txt:
- media/media-fragments/TC0063-expected.txt:
- media/media-fragments/TC0064-expected.txt:
- media/media-fragments/TC0065-expected.txt:
- media/media-fragments/TC0066-expected.txt:
- media/media-fragments/TC0067-expected.txt:
- media/media-fragments/TC0068-expected.txt:
- media/media-fragments/TC0069-expected.txt:
- media/media-fragments/TC0070-expected.txt:
- media/media-fragments/TC0071-expected.txt:
- media/media-fragments/TC0072-expected.txt:
- media/media-fragments/TC0073-expected.txt:
- media/media-fragments/TC0074-expected.txt:
- media/media-fragments/TC0075-expected.txt:
- media/media-fragments/TC0076-expected.txt:
- media/media-fragments/TC0077-expected.txt:
- media/media-fragments/TC0078-expected.txt:
- media/media-fragments/TC0079-expected.txt:
- media/media-fragments/TC0080-expected.txt:
- media/media-fragments/TC0081-expected.txt:
- media/media-fragments/TC0082-expected.txt:
- media/media-fragments/TC0083-expected.txt:
- media/media-fragments/TC0084-expected.txt:
- media/media-fragments/TC0085-expected.txt:
- media/media-fragments/TC0086-expected.txt:
- media/media-fragments/TC0087-expected.txt:
- media/media-fragments/TC0088-expected.txt:
- media/media-fragments/TC0089-expected.txt:
- media/media-fragments/TC0090-expected.txt:
- media/media-fragments/TC0091-expected.txt:
- media/media-fragments/TC0092-expected.txt:
- media/media-fragments/TC0093-expected.txt:
- media/media-fragments/TC0094-expected.txt:
- media/media-fragments/media-fragments.js:
(canplaythrough): Removed check for initialTime
- media/media-initialTime-expected.txt: Removed.
- media/media-initialTime.html: Removed.
Nov 2, 2013:
- 11:58 PM Changeset in webkit [158526] by
-
- 17 edits2 copies4 adds in trunk
Implement generateKey for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123669
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-generate-key.html
crypto/subtle/hmac-generate-key.html
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createAesKeyGenParams): Added bindings for AesKeyGenParams.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): Handle
algorithms that generate AES and HMAC keys.
- bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::generateKey): Added.
- crypto/CryptoAlgorithmAesKeyGenParams.h: Added.
- crypto/CryptoKey.cpp: (WebCore::CryptoKey::randomData):
- crypto/CryptoKey.h:
- crypto/CryptoKeyMac.cpp: Added
Expose a function that produces random data for symmetric crypto keys. Cross-platform
implementation uses ARC4 code from WTF, while Mac uses a system function that
provides a FIPS validated random number generator.
- crypto/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::generate):
- crypto/CryptoKeyAES.h:
Added a function that creates AES keys.
- crypto/SubtleCrypto.idl: Added generateKey.
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::generateKey): Added.
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::generateKey): Added.
- crypto/keys/CryptoKeyHMAC.cpp: (WebCore::CryptoKeyHMAC::generate):
- crypto/keys/CryptoKeyHMAC.h:
Added a function that creates HMAC keys.
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: Removed generateKey stub, the implementation
ended up in cross-platform file.
- crypto/mac/CryptoAlgorithmHMACMac.cpp: Ditto.
LayoutTests:
- crypto/subtle/aes-cbc-generate-key-expected.txt: Added.
- crypto/subtle/aes-cbc-generate-key.html: Added.
- crypto/subtle/hmac-generate-key-expected.txt: Added.
- crypto/subtle/hmac-generate-key.html: Added.
- crypto/subtle/sha-1-expected.txt: Now that crypto.webkitSubtle.generateKey exists,
a different exception is raised.
- 11:50 PM Changeset in webkit [158525] by
-
- 1 edit35 moves2 adds39 deletes in trunk/LayoutTests
Optimize baselines: css3
Unreviewed; run "webkit-patch optimize-baselines css3"
- css3/images/cross-fade-background-size-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-background-size-expected.txt.
- css3/images/cross-fade-blending-expected.png: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-blending-expected.png.
- css3/images/cross-fade-blending-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-blending-expected.txt.
- css3/images/cross-fade-invalidation-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-invalidation-expected.txt.
- css3/images/cross-fade-simple-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-simple-expected.txt.
- css3/images/cross-fade-sizing-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-sizing-expected.txt.
- css3/images/cross-fade-tiled-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-tiled-expected.txt.
- css3/selectors3/html/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-17-expected.png.
- css3/selectors3/html/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-177a-expected.png.
- css3/selectors3/html/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-18c-expected.png.
- css3/selectors3/html/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-27a-expected.png.
- css3/selectors3/html/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-27b-expected.png.
- css3/selectors3/html/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-61-expected.png.
- css3/selectors3/xhtml/css3-modsel-123b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-123b-expected.png.
- css3/selectors3/xhtml/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-17-expected.png.
- css3/selectors3/xhtml/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-177a-expected.png.
- css3/selectors3/xhtml/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-18c-expected.png.
- css3/selectors3/xhtml/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-27a-expected.png.
- css3/selectors3/xhtml/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-27b-expected.png.
- css3/selectors3/xhtml/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-61-expected.png.
- css3/selectors3/xhtml/css3-modsel-91-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-91-expected.png.
- css3/selectors3/xhtml/css3-modsel-92-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-92-expected.png.
- css3/selectors3/xml/css3-modsel-123b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-123b-expected.png.
- css3/selectors3/xml/css3-modsel-167-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-167-expected.png.
- css3/selectors3/xml/css3-modsel-167a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-167a-expected.png.
- css3/selectors3/xml/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-17-expected.png.
- css3/selectors3/xml/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-177a-expected.png.
- css3/selectors3/xml/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-18c-expected.png.
- css3/selectors3/xml/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-27a-expected.png.
- css3/selectors3/xml/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-27b-expected.png.
- css3/selectors3/xml/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-61-expected.png.
- css3/selectors3/xml/css3-modsel-91-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-91-expected.png.
- css3/selectors3/xml/css3-modsel-92-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-92-expected.png.
- platform/efl-wk1/css3/flexbox/flexbox-baseline-expected.png: Renamed from LayoutTests/platform/efl/css3/flexbox/flexbox-baseline-expected.png.
- platform/efl-wk1/css3/flexbox/flexbox-baseline-expected.txt: Renamed from LayoutTests/platform/efl/css3/flexbox/flexbox-baseline-expected.txt.
- platform/gtk/css3/images/cross-fade-blending-expected.png: Removed.
- platform/gtk/css3/images/cross-fade-blending-expected.txt: Removed.
- platform/gtk/css3/images/cross-fade-invalidation-expected.txt: Removed.
- platform/gtk/css3/images/cross-fade-simple-expected.txt: Removed.
- platform/gtk/css3/images/cross-fade-sizing-expected.txt: Removed.
- platform/gtk/css3/images/cross-fade-tiled-expected.txt: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-17-expected.png: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-177a-expected.png: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-18c-expected.png: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-27a-expected.png: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-27b-expected.png: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-61-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-123b-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-17-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-177a-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-18c-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-27a-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-27b-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-61-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-91-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-92-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-123b-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-167-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-167a-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-17-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-177a-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-18c-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-27a-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-27b-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-61-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-91-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-92-expected.png: Removed.
- platform/mac/css3/images/cross-fade-background-size-expected.txt: Removed.
- platform/mac/css3/images/cross-fade-blending-expected.txt: Removed.
- platform/mac/css3/images/cross-fade-invalidation-expected.txt: Removed.
- platform/mac/css3/images/cross-fade-simple-expected.txt: Removed.
- platform/mac/css3/images/cross-fade-sizing-expected.txt: Removed.
- platform/mac/css3/images/cross-fade-tiled-expected.txt: Removed.
- platform/win/css3/filters/effect-reference-expected.txt: Removed.
- platform/win/css3/filters/effect-reference-hw-expected.txt: Removed.
- 11:25 PM Changeset in webkit [158524] by
-
- 1 edit72 moves73 deletes in trunk/LayoutTests
Optimize baselines: css2.1
Unreviewed; run "webkit-patch optimize-baselines css2.1"
- css2.1/20110323/absolute-replaced-height-036-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/absolute-replaced-height-036-expected.png.
- css2.1/20110323/block-non-replaced-height-011-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-011-expected.png.
- css2.1/20110323/block-non-replaced-height-013-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-013-expected.png.
- css2.1/20110323/empty-inline-001-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/empty-inline-001-expected.png.
- css2.1/20110323/replaced-intrinsic-002-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-002-expected.png.
- css2.1/20110323/replaced-intrinsic-002-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-002-expected.txt.
- css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt.
- css2.1/t040105-atkeyw-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-00-b-expected.png.
- css2.1/t040105-atkeyw-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-01-b-expected.png.
- css2.1/t040105-atkeyw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-02-b-expected.png.
- css2.1/t040105-atrule-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-00-b-expected.png.
- css2.1/t040105-atrule-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-01-b-expected.png.
- css2.1/t040105-atrule-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-02-b-expected.png.
- css2.1/t040105-atrule-03-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-03-b-expected.png.
- css2.1/t040105-atrule-04-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-04-b-expected.png.
- css2.1/t040105-import-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-00-b-expected.png.
- css2.1/t040105-import-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-01-b-expected.png.
- css2.1/t040105-import-10-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-10-b-expected.png.
- css2.1/t0402-syntax-01-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-01-f-expected.png.
- css2.1/t0402-syntax-02-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-02-f-expected.png.
- css2.1/t0402-syntax-03-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-03-f-expected.png.
- css2.1/t0402-syntax-04-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-04-f-expected.png.
- css2.1/t0402-syntax-05-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-05-f-expected.png.
- css2.1/t0402-syntax-06-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-06-f-expected.png.
- css2.1/t040307-syntax-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040307-syntax-01-b-expected.png.
- css2.1/t0505-c16-descendant-02-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0505-c16-descendant-02-e-expected.png.
- css2.1/t0509-id-sel-syntax-01-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0509-id-sel-syntax-01-f-expected.png.
- css2.1/t0509-id-sel-syntax-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0509-id-sel-syntax-02-b-expected.png.
- css2.1/t0511-c21-pseud-link-00-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-00-e-expected.png.
- css2.1/t0511-c21-pseud-link-01-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-01-e-expected.png.
- css2.1/t0511-c21-pseud-link-02-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-02-e-expected.png.
- css2.1/t0511-c21-pseud-link-03-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-03-e-expected.png.
- css2.1/t051103-c21-focus-ln-00-e-i-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t051103-c21-focus-ln-00-e-i-expected.png.
- css2.1/t051103-c21-hover-ln-00-e-i-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t051103-c21-hover-ln-00-e-i-expected.png.
- css2.1/t0803-c5504-mrgn-l-02-c-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0803-c5504-mrgn-l-02-c-expected.png.
- css2.1/t0805-c5511-brdr-tw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5511-brdr-tw-02-b-expected.png.
- css2.1/t0805-c5512-brdr-rw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5512-brdr-rw-02-b-expected.png.
- css2.1/t0805-c5513-brdr-bw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5513-brdr-bw-02-b-expected.png.
- css2.1/t0805-c5514-brdr-lw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5514-brdr-lw-02-b-expected.png.
- css2.1/t0805-c5515-brdr-w-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5515-brdr-w-02-b-expected.png.
- css2.1/t1001-abs-pos-cb-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-01-b-expected.png.
- css2.1/t1001-abs-pos-cb-01-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-01-b-expected.txt.
- css2.1/t1001-abs-pos-cb-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-02-b-expected.png.
- css2.1/t1001-abs-pos-cb-02-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-02-b-expected.txt.
- css2.1/t1001-abs-pos-cb-03-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-03-b-expected.png.
- css2.1/t1001-abs-pos-cb-03-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-03-b-expected.txt.
- css2.1/t1001-abs-pos-cb-04-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-04-b-expected.png.
- css2.1/t1001-abs-pos-cb-04-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-04-b-expected.txt.
- css2.1/t1001-abs-pos-cb-05-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-05-b-expected.png.
- css2.1/t1001-abs-pos-cb-05-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-05-b-expected.txt.
- css2.1/t1001-abs-pos-cb-06-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-06-b-expected.png.
- css2.1/t1001-abs-pos-cb-06-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-06-b-expected.txt.
- css2.1/t1001-abs-pos-cb-07-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-07-b-expected.png.
- css2.1/t1001-abs-pos-cb-07-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-07-b-expected.txt.
- css2.1/t1001-abs-pos-cb-08-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-08-b-expected.png.
- css2.1/t1001-abs-pos-cb-08-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-08-b-expected.txt.
- css2.1/t1001-abs-pos-cb-09-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-09-b-expected.png.
- css2.1/t1001-abs-pos-cb-09-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-09-b-expected.txt.
- css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1205-c566-list-stl-01-c-g-expected.txt.
- css2.1/t140201-c532-bgcolor-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c532-bgcolor-01-b-expected.png.
- css2.1/t140201-c533-bgimage-01-b-g-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c533-bgimage-01-b-g-expected.png.
- css2.1/t140201-c536-bgpos-01-b-ag-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c536-bgpos-01-b-ag-expected.png.
- css2.1/t1508-c527-font-00-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-00-b-expected.txt.
- css2.1/t1508-c527-font-01-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-01-b-expected.txt.
- css2.1/t1508-c527-font-02-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-02-b-expected.txt.
- css2.1/t1508-c527-font-03-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-03-b-expected.txt.
- css2.1/t1508-c527-font-04-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-04-b-expected.txt.
- css2.1/t1508-c527-font-05-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-05-b-expected.txt.
- css2.1/t1508-c527-font-07-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-07-b-expected.txt.
- css2.1/t1508-c527-font-08-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-08-b-expected.txt.
- css2.1/t1508-c527-font-09-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-09-b-expected.txt.
- css2.1/t1508-c527-font-10-c-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-10-c-expected.txt.
- platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.png: Removed.
- platform/gtk/css2.1/20110323/block-non-replaced-height-011-expected.png: Removed.
- platform/gtk/css2.1/20110323/block-non-replaced-height-013-expected.png: Removed.
- platform/gtk/css2.1/20110323/empty-inline-001-expected.png: Removed.
- platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
- platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
- platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
- platform/gtk/css2.1/t040105-atkeyw-00-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atkeyw-01-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atkeyw-02-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atrule-00-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atrule-01-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atrule-02-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atrule-03-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atrule-04-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-import-00-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-import-01-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-import-10-b-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-01-f-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-02-f-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-03-f-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-04-f-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-05-f-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-06-f-expected.png: Removed.
- platform/gtk/css2.1/t040307-syntax-01-b-expected.png: Removed.
- platform/gtk/css2.1/t0505-c16-descendant-02-e-expected.png: Removed.
- platform/gtk/css2.1/t0509-id-sel-syntax-01-f-expected.png: Removed.
- platform/gtk/css2.1/t0509-id-sel-syntax-02-b-expected.png: Removed.
- platform/gtk/css2.1/t0511-c21-pseud-link-00-e-expected.png: Removed.
- platform/gtk/css2.1/t0511-c21-pseud-link-01-e-expected.png: Removed.
- platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.png: Removed.
- platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.png: Removed.
- platform/gtk/css2.1/t051103-c21-focus-ln-00-e-i-expected.png: Removed.
- platform/gtk/css2.1/t051103-c21-hover-ln-00-e-i-expected.png: Removed.
- platform/gtk/css2.1/t0803-c5504-mrgn-l-02-c-expected.png: Removed.
- platform/gtk/css2.1/t0805-c5511-brdr-tw-02-b-expected.png: Removed.
- platform/gtk/css2.1/t0805-c5512-brdr-rw-02-b-expected.png: Removed.
- platform/gtk/css2.1/t0805-c5513-brdr-bw-02-b-expected.png: Removed.
- platform/gtk/css2.1/t0805-c5514-brdr-lw-02-b-expected.png: Removed.
- platform/gtk/css2.1/t0805-c5515-brdr-w-02-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.txt: Removed.
- platform/gtk/css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Removed.
- platform/gtk/css2.1/t140201-c532-bgcolor-01-b-expected.png: Removed.
- platform/gtk/css2.1/t140201-c533-bgimage-01-b-g-expected.png: Removed.
- platform/gtk/css2.1/t140201-c536-bgpos-01-b-ag-expected.png: Removed.
- platform/gtk/css2.1/t1508-c527-font-00-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-01-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-02-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-03-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-04-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-05-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-07-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-08-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-09-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-10-c-expected.txt: Removed.
- platform/mac/css2.1/t1508-c527-font-00-b-expected.txt: Removed.
- 11:04 PM Changeset in webkit [158523] by
-
- 1 edit14 moves2 adds12 deletes in trunk/LayoutTests
Optimize baselines: fast/dom
Unreviewed; run "webkit-patch optimize-baselines fast/dom"
- fast/dom/HTMLHeadElement/textInHead1-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead1-expected.txt.
- fast/dom/HTMLHeadElement/textInHead2-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead2-expected.txt.
- fast/dom/HTMLHeadElement/textInHead3-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead3-expected.txt.
- fast/dom/HTMLHeadElement/textInHead4-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead4-expected.txt.
- fast/dom/HTMLHeadElement/textInHead5-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead5-expected.txt.
- fast/dom/HTMLMeterElement/meter-element-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-element-expected.txt.
- fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt.
- fast/dom/anchor-text-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/anchor-text-expected.txt.
- fast/dom/comment-not-documentElement-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/comment-not-documentElement-expected.txt.
- fast/dom/delete-contents-expected.png: Renamed from LayoutTests/platform/efl/fast/dom/delete-contents-expected.png.
- fast/dom/scroll-reveal-left-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/scroll-reveal-left-overflow-expected.txt.
- fast/dom/scroll-reveal-top-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/scroll-reveal-top-overflow-expected.txt.
- platform/gtk/fast/dom/HTMLHeadElement/textInHead1-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLHeadElement/textInHead2-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLHeadElement/textInHead3-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLHeadElement/textInHead4-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLHeadElement/textInHead5-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
- platform/gtk/fast/dom/anchor-text-expected.txt: Removed.
- platform/gtk/fast/dom/comment-not-documentElement-expected.txt: Removed.
- platform/gtk/fast/dom/delete-contents-expected.png: Removed.
- platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt: Removed.
- platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt: Removed.
- platform/win-7sp0/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt.
- platform/win-7sp0/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt.
- 10:35 PM Changeset in webkit [158522] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Add missing baselines to EFL wk1 TestExpectation.
- platform/efl-wk1/TestExpectations: Need to add new baseline since upgrading base OS.
- 9:13 PM Changeset in webkit [158521] by
-
- 13 edits in trunk
EnforceRange doesn't enforce range of a short
https://bugs.webkit.org/show_bug.cgi?id=123661
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Handle Web IDL short / unsigned short types as per the
specification:
Specifically, we used to treat short / unsigned short as 32bit
integers, which was wrong. We now properly handle them as 16bit
integers.
No new tests, added test cases to js/dom/webidl-type-mapping.html.
- WebCore.exp.in:
- bindings/js/JSDOMBinding.cpp:
(WebCore::toSmallerInt):
(WebCore::toSmallerUInt):
(WebCore::toInt8):
(WebCore::toUInt8):
(WebCore::toInt16):
(WebCore::toUInt16):
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
- testing/TypeConversions.h:
(WebCore::TypeConversions::testShort):
(WebCore::TypeConversions::setTestShort):
(WebCore::TypeConversions::testEnforceRangeShort):
(WebCore::TypeConversions::setTestEnforceRangeShort):
(WebCore::TypeConversions::testUnsignedShort):
(WebCore::TypeConversions::setTestUnsignedShort):
(WebCore::TypeConversions::testEnforceRangeUnsignedShort):
(WebCore::TypeConversions::setTestEnforceRangeUnsignedShort):
- testing/TypeConversions.idl:
Source/WebKit:
Export symbols to fix Windows build.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
LayoutTests:
Extend js/dom/webidl-type-mapping.html layout test to validate
Web IDL type mapping for short / unsigned short.
- js/dom/webidl-type-mapping-expected.txt:
- js/dom/webidl-type-mapping.html:
- 8:25 PM Changeset in webkit [158520] by
-
- 2 edits in trunk/Source/WTF
Fix compilation of DateMath.cpp with MSVC
https://bugs.webkit.org/show_bug.cgi?id=123680
Reviewed by Darin Adler.
- wtf/DateMath.cpp:
(WTF::appendTwoDigitNumber): Help the compiler finding the
correct overload by casting the characters to LChar.
- 8:24 PM Changeset in webkit [158519] by
-
- 6 edits in trunk/Source/WebCore
Cleanup OpenTypeUtilities
https://bugs.webkit.org/show_bug.cgi?id=123686
Reviewed by Darin Adler.
Merge the WinCE specific code into the general Windows code to
make the compilation of WinCE port on WinNT easier.
- platform/graphics/opentype/OpenTypeUtilities.cpp:
(WebCore::renameFont):
(WebCore::renameAndActivateFont):
- platform/graphics/opentype/OpenTypeUtilities.h:
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- 8:19 PM Changeset in webkit [158518] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add missing getHostCallReturnValue() for MSVC ARM
https://bugs.webkit.org/show_bug.cgi?id=123685
Reviewed by Darin Adler.
- jit/JITStubsARM.h:
- 8:18 PM Changeset in webkit [158517] by
-
- 1 edit26 moves34 deletes in trunk/LayoutTests
Optimize baselines: fast/css
Unreviewed; run "webkit-patch optimize-baselines fast/css"
- fast/css/background-image-with-baseurl-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/background-image-with-baseurl-expected.txt.
- fast/css/caption-width-absolute-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-absolute-position-expected.txt.
- fast/css/caption-width-absolute-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt.
- fast/css/caption-width-fixed-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-fixed-position-expected.txt.
- fast/css/caption-width-fixed-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt.
- fast/css/caption-width-relative-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-relative-position-expected.txt.
- fast/css/caption-width-relative-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt.
- fast/css/font-face-default-font-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-face-default-font-expected.txt.
- fast/css/font-face-in-media-rule-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-face-in-media-rule-expected.txt.
- fast/css/font-size-negative-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-size-negative-expected.txt.
- fast/css/imageTileOpacity-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/imageTileOpacity-expected.txt.
- fast/css/import_with_baseurl-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/import_with_baseurl-expected.txt.
- fast/css/line-height-determined-by-primary-font-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-determined-by-primary-font-expected.txt.
- fast/css/line-height-font-order-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-font-order-expected.txt.
- fast/css/line-height-negative-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-negative-expected.txt.
- fast/css/max-height-none-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/max-height-none-expected.txt.
- fast/css/min-width-with-spanned-cell-expected.png: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-expected.png.
- fast/css/min-width-with-spanned-cell-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-expected.txt.
- fast/css/min-width-with-spanned-cell-fixed-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.txt.
- fast/css/pseudo-first-line-border-width-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/pseudo-first-line-border-width-expected.txt.
- fast/css/replaced-element-implicit-size-expected.png: Renamed from LayoutTests/platform/efl/fast/css/replaced-element-implicit-size-expected.png.
- fast/css/vertical-align-lengths-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/vertical-align-lengths-expected.txt.
- fast/css/visibility-hit-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/visibility-hit-test-expected.txt.
- platform/efl-wk2/fast/css/font-smoothing-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-smoothing-expected.png.
- platform/efl-wk2/fast/css/font-weight-1-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-weight-1-expected.png.
- platform/efl-wk2/fast/css/input-search-padding-expected.png: Renamed from LayoutTests/platform/efl/fast/css/input-search-padding-expected.png.
- platform/gtk/fast/css/background-image-with-baseurl-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-absolute-position-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-fixed-position-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-relative-position-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
- platform/gtk/fast/css/font-face-in-media-rule-expected.txt: Removed.
- platform/gtk/fast/css/font-size-negative-expected.txt: Removed.
- platform/gtk/fast/css/imageTileOpacity-expected.txt: Removed.
- platform/gtk/fast/css/import_with_baseurl-expected.txt: Removed.
- platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt: Removed.
- platform/gtk/fast/css/line-height-font-order-expected.txt: Removed.
- platform/gtk/fast/css/line-height-negative-expected.txt: Removed.
- platform/gtk/fast/css/max-height-none-expected.txt: Removed.
- platform/gtk/fast/css/min-width-with-spanned-cell-expected.png: Removed.
- platform/gtk/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
- platform/gtk/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Removed.
- platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt: Removed.
- platform/gtk/fast/css/replaced-element-implicit-size-expected.png: Removed.
- platform/gtk/fast/css/vertical-align-lengths-expected.txt: Removed.
- platform/gtk/fast/css/visibility-hit-test-expected.txt: Removed.
- platform/mac/fast/css/caption-width-absolute-position-expected.txt: Removed.
- platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
- platform/mac/fast/css/caption-width-fixed-position-expected.txt: Removed.
- platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
- platform/mac/fast/css/caption-width-relative-position-expected.txt: Removed.
- platform/mac/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
- platform/mac/fast/css/font-face-default-font-expected.txt: Removed.
- platform/mac/fast/css/font-face-in-media-rule-expected.txt: Removed.
- platform/mac/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
- platform/mac/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Removed.
- platform/mac/fast/css/pseudo-first-line-border-width-expected.txt: Removed.
- platform/win/fast/css/zoom-body-scroll-expected.txt: Removed.
- 8:16 PM Changeset in webkit [158516] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MSVC warning about unary minus operator
https://bugs.webkit.org/show_bug.cgi?id=123674
Reviewed by Darin Adler.
Change some static_cast<> to silence the following warning of Microsoft compiler:
warning C4146: unary minus operator applied to unsigned type, result still unsigned
- jit/Repatch.cpp:
(JSC::emitPutTransitionStub):
- 7:36 PM Changeset in webkit [158515] by
-
- 7 edits in trunk/Source/WebCore
CSSFontFaceSrcValue constructors should return PassRef.
<https://webkit.org/b/123692>
Make functions that return non-null CSSFontFaceSrcValues return
PassRef instead of PassRefPtr. Tweak some call sites to be
slightly more efficient.
Reviewed by Anders Carlsson.
- 7:33 PM Changeset in webkit [158514] by
-
- 17 edits in trunk/Source/WebCore
CSSStyleSheet::contents() should return a reference.
<https://webkit.org/b/123689>
Make CSSStyleSheet::contents() return a StyleSheetContents& instead
of a pointer. The object was already stored in a Ref.
Reviewed by Anders Carlsson.
- 7:14 PM Changeset in webkit [158513] by
-
- 3 edits in trunk/Source/WebCore
CSSReflectValue constructor should return PassRef.
<https://webkit.org/b/123963>
Make CSSReflectValue::create() return a PassRef. Tweak one call
site to be slightly more efficient.
Reviewed by Anders Carlsson.
- 7:12 PM Changeset in webkit [158512] by
-
- 3 edits in trunk/Source/WebCore
CSSFontFeatureValue constructor should return PassRef.
<https://webkit.org/b/123691>
Make CSSFontFeatureValue::create() return PassRef, since it never
returns null. Tweak one call site to be slightly more efficient.
Reviewed by Anders Carlsson.
- 7:04 PM Changeset in webkit [158511] by
-
- 4 edits in trunk/Source/WebCore
Tighten typing in SVGResources::buildCachedResources().
<https://webkit.org/b/123690>
Make this function take a RenderElement&/SVGRenderStyle& pair instead
of a RenderObject*/SVGRenderStyle* pair. Also tweaked the code a bit,
removing ampersands and asserts as appropriate.
Reviewed by Anders Carlsson.
- 6:47 PM Changeset in webkit [158510] by
-
- 2 edits in trunk/Source/JavaScriptCore
Disable LLVM's pretty stack traces, which involve intercepting fatal signals
https://bugs.webkit.org/show_bug.cgi?id=123681
Reviewed by Geoffrey Garen.
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
- 6:33 PM Changeset in webkit [158509] by
-
- 10 edits1 add in trunk
LLVM assertion failures should funnel into WTF's crash handling
https://bugs.webkit.org/show_bug.cgi?id=123682
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Inside llvmForJSC, we override assertion-related functions and funnel them
into g_llvmTrapCallback(). We also now register a fatal error handler inside
the library and funnel that into g_llvmTrapCallback, and have
initializeAndGetJSCLLVMAPI() take such a callback as an argument.
Inside JSC, we no longer call LLVMInstallFatalErrorHandler() but instead we
pass WTFLogAlwaysAndCrash() as the trap callback for llvmForJSC.
- llvm/InitializeLLVM.cpp:
(JSC::initializeLLVM):
- llvm/InitializeLLVMPOSIX.cpp:
(JSC::initializeLLVMPOSIX):
- llvm/library/LLVMExports.cpp:
(llvmCrash):
(initializeAndGetJSCLLVMAPI):
- llvm/library/LLVMOverrides.cpp:
(raise):
(assert_rtn):
(abort):
- llvm/library/LLVMTrapCallback.h: Added.
Source/WTF:
Reviewed by Geoffrey Garen.
Give JSC some new toys to play with for crash handling.
- wtf/Assertions.cpp:
- wtf/Assertions.h:
Tools:
Reviewed by Geoffrey Garen.
Need to disable LLVM's crash overrides so that we can do our own crash overrides.
- Scripts/configure-llvm:
- 6:30 PM Changeset in webkit [158508] by
-
- 3 edits in trunk/WebKitLibraries
Unreviewed, update binary drops.
These include my LLVMDisablePrettyStackTrace() fix and are built with --enable-crash-overrides=no
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 5:32 PM Changeset in webkit [158507] by
-
- 4 edits in trunk/Source/JavaScriptCore
CodeBlock::jettison() shouldn't call baselineVersion()
https://bugs.webkit.org/show_bug.cgi?id=123675
Reviewed by Geoffrey Garen.
Fix more uses of baselineVersion().
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::jettison):
- bytecode/CodeBlock.h:
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:
(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):
- 5:29 PM Changeset in webkit [158506] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLVM asserts in internal-js-tests.yaml/Octane/stress-tests/mandreel.js
https://bugs.webkit.org/show_bug.cgi?id=123535
Reviewed by Geoffrey Garen.
Use double comparisons for doubles.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::doubleToInt32):
- 4:56 PM Changeset in webkit [158505] by
-
- 6 edits in trunk/Source/WebCore
CSSImageValue constructors should return PassRef.
<https://webkit.org/b/123688>
Make the CSSImageValue::create() helpers return PassRef.
Tightened call sites to avoid null checks and destructor calls.
Reviewed by Anders Carlsson.
- 3:17 PM Changeset in webkit [158504] by
-
- 2 edits in trunk/Source/WebCore
Fix compilation of SynchronousLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=123676
Reviewed by Darin Adler.
Assign a ResourceRequest varibale an empty ResourceRequest instead of 0.
The current solution only works for ports which can create a
ResourceRequest from a pointer, which might not be true for all ports.
- platform/network/SynchronousLoaderClient.cpp:
(WebCore::SynchronousLoaderClient::willSendRequest):
- 2:59 PM Changeset in webkit [158503] by
-
- 2 edits in trunk
[WINCE] Disable export macros
https://bugs.webkit.org/show_bug.cgi?id=123679
Reviewed by Darin Adler.
Avoid useless exports by turning of the export macros
since the WinCE port works as a static library only.
- Source/cmake/OptionsWinCE.cmake:
- 2:58 PM Changeset in webkit [158502] by
-
- 3 edits in trunk/Source/WebCore
Port LoggingWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=123678
Reviewed by Darin Adler.
This makes it easier to use a common list of files
for the different Windows ports later.
- PlatformWin.cmake:
- platform/win/LoggingWin.cpp:
(WebCore::logLevelString):
- 2:56 PM Changeset in webkit [158501] by
-
- 14 edits in trunk/Source/WebKit/wince
Add OVERRIDE keyword to WebCoreSupport classes
https://bugs.webkit.org/show_bug.cgi?id=123672
Reviewed by Darin Adler.
Also align the function parameters with the base classes
and remove useless functions.
- WebCoreSupport/ChromeClientWinCE.cpp:
- WebCoreSupport/ChromeClientWinCE.h:
- WebCoreSupport/ContextMenuClientWinCE.cpp:
- WebCoreSupport/ContextMenuClientWinCE.h:
- WebCoreSupport/DragClientWinCE.cpp:
(WebKit::DragClientWinCE::willPerformDragDestinationAction):
(WebKit::DragClientWinCE::willPerformDragSourceAction):
(WebKit::DragClientWinCE::actionMaskForDrag):
(WebKit::DragClientWinCE::startDrag):
- WebCoreSupport/DragClientWinCE.h:
- WebCoreSupport/EditorClientWinCE.h:
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):
- WebCoreSupport/FrameLoaderClientWinCE.h:
- WebCoreSupport/FrameNetworkingContextWinCE.h:
- WebCoreSupport/InspectorClientWinCE.cpp:
- WebCoreSupport/InspectorClientWinCE.h:
- WebCoreSupport/PlatformStrategiesWinCE.h:
- 2:56 PM Changeset in webkit [158500] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Wrappers mishandle NULL values in arrays and dictionaries
https://bugs.webkit.org/show_bug.cgi?id=123671
Reviewed by Darin Adler.
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray objectAtIndex:]): Represent a NULL object as NSNull.
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary objectForKey:]): Represent a NULL value as NSNull.
- Shared/ImmutableDictionary.h:
(WebKit::ImmutableDictionary::get): Added this overload that returns whether the key exists.
- 2:47 PM Changeset in webkit [158499] by
-
- 8 edits in trunk/Source
Fix UnicodeWchar after r157330.
https://bugs.webkit.org/show_bug.cgi?id=123668
Reviewed by Darin Adler.
Source/WebCore:
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::append):
- platform/graphics/wince/FontWinCE.cpp:
(WebCore::generateComponents):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawText):
- platform/text/wchar/TextBreakIteratorWchar.cpp:
(WebCore::isCharStop):
(WebCore::isLineStop):
(WebCore::isSentenceStop):
(WebCore::WordBreakIterator::next):
(WebCore::WordBreakIterator::previous):
Source/WTF:
- wtf/unicode/wchar/UnicodeWchar.cpp:
(unorm_normalize):
(u_strFoldCase):
(u_strToLower):
(u_strToUpper):
- wtf/unicode/wchar/UnicodeWchar.h:
(u_foldCase):
(u_isprint):
(u_isspace):
- 2:18 PM Changeset in webkit [158498] by
-
- 7 edits in trunk/Source
Make remaining StringImpl functions return PassRef.
<https://webkit.org/b/123683>
Okay, this seems to work well! Let's go all in and convert the
remaining StringImpl functions to return PassRef<StringImpl> instead
of PassRefPtr where we know that null is never returned.
Reviewed by Anders Carlsson.
- 2:18 PM Changeset in webkit [158497] by
-
- 8 edits in trunk/Source/WebCore
Use RenderChildIterator in a couple of places.
<https://webkit.org/b/123684>
Added isRendererOfType() for RenderBox and RenderBlock and switch
some loops over to using childrenOfType<>. Also sprinkled const
and references on touched code.
Reviewed by Antti Koivisto.
- 2:03 PM Changeset in webkit [158496] by
-
- 3 edits in trunk/Source/WebCore
Manage FileReaderLoader through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=123666
Reviewed by Anders Carlsson.
Construct FileReaderLoader objects through std::make_unique and store them in std::unique_ptr.
- fileapi/FileReader.cpp:
(WebCore::FileReader::readInternal):
- fileapi/FileReader.h:
- 12:51 PM Changeset in webkit [158495] by
-
- 10 edits2 adds in trunk/Source/WebCore
Add a child renderer iterator.
<https://webkit.org/b/123662>
Introduce an ElementIterator-style iterator for renderers and put
it to use in a childrenOfType() implementation.
It's used just like the Element iterators:
auto sections = childrenOfType<RenderTableSection>(*this);
for (auto section = sections.begin(), section = sections.end(); section != sections.end(); ++section)
section->thisOrThat();
Just like the DOM counterpart, it relies on a templatized helper:
bool isRendererOfType<T>(const RenderObject&)
This patch puts the iterator to use in a couple of random places.
Reviewed by Antti Koivisto.
- 11:19 AM Changeset in webkit [158494] by
-
- 4 edits12 copies8 adds in trunk
Implement remaining SHA variations for WebCrypto
https://bugs.webkit.org/show_bug.cgi?id=123659
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: crypto/subtle/sha-224.html
crypto/subtle/sha-256.html
crypto/subtle/sha-384.html
crypto/subtle/sha-512.html
- WebCore.xcodeproj/project.pbxproj:
- crypto/algorithms/CryptoAlgorithmSHA224.cpp: Added.
(WebCore::CryptoAlgorithmSHA224::CryptoAlgorithmSHA224):
(WebCore::CryptoAlgorithmSHA224::~CryptoAlgorithmSHA224):
(WebCore::CryptoAlgorithmSHA224::create):
(WebCore::CryptoAlgorithmSHA224::identifier):
- crypto/algorithms/CryptoAlgorithmSHA224.h: Added.
- crypto/algorithms/CryptoAlgorithmSHA256.cpp: Added.
(WebCore::CryptoAlgorithmSHA256::CryptoAlgorithmSHA256):
(WebCore::CryptoAlgorithmSHA256::~CryptoAlgorithmSHA256):
(WebCore::CryptoAlgorithmSHA256::create):
(WebCore::CryptoAlgorithmSHA256::identifier):
- crypto/algorithms/CryptoAlgorithmSHA256.h: Added.
- crypto/algorithms/CryptoAlgorithmSHA384.cpp: Added.
(WebCore::CryptoAlgorithmSHA384::CryptoAlgorithmSHA384):
(WebCore::CryptoAlgorithmSHA384::~CryptoAlgorithmSHA384):
(WebCore::CryptoAlgorithmSHA384::create):
(WebCore::CryptoAlgorithmSHA384::identifier):
- crypto/algorithms/CryptoAlgorithmSHA384.h: Added.
- crypto/algorithms/CryptoAlgorithmSHA512.cpp: Added.
(WebCore::CryptoAlgorithmSHA512::CryptoAlgorithmSHA512):
(WebCore::CryptoAlgorithmSHA512::~CryptoAlgorithmSHA512):
(WebCore::CryptoAlgorithmSHA512::create):
(WebCore::CryptoAlgorithmSHA512::identifier):
- crypto/algorithms/CryptoAlgorithmSHA512.h: Added.
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
- crypto/mac/CryptoAlgorithmSHA224Mac.cpp: Added.
(WebCore::CryptoAlgorithmSHA224::digest):
- crypto/mac/CryptoAlgorithmSHA256Mac.cpp: Added.
(WebCore::CryptoAlgorithmSHA256::digest):
- crypto/mac/CryptoAlgorithmSHA384Mac.cpp: Added.
(WebCore::CryptoAlgorithmSHA384::digest):
- crypto/mac/CryptoAlgorithmSHA512Mac.cpp: Added.
(WebCore::CryptoAlgorithmSHA512::digest):
LayoutTests:
- crypto/subtle/sha-224-expected.txt: Added.
- crypto/subtle/sha-224.html: Added.
- crypto/subtle/sha-256-expected.txt: Added.
- crypto/subtle/sha-256.html: Added.
- crypto/subtle/sha-384-expected.txt: Added.
- crypto/subtle/sha-384.html: Added.
- crypto/subtle/sha-512-expected.txt: Added.
- crypto/subtle/sha-512.html: Added.
- 10:54 AM Changeset in webkit [158493] by
-
- 2 edits in trunk/Source/WebKit2
Fixed release builds.
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary initWithObjects:forKeys:count:]):
- 10:33 AM Changeset in webkit [158492] by
-
- 12 edits in trunk/Source
Various small WinCE build fixes
Source/JavaScriptCore:
- jsc.cpp:
(main):
Source/WebCore:
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::append):
- platform/graphics/BitmapImage.h:
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- platform/graphics/wince/PlatformPathWinCE.h:
- platform/win/PopupMenuWin.h:
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
Source/WebKit/wince:
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::transitionToCommittedForNewPage):
- WebView.cpp:
- 10:26 AM Changeset in webkit [158491] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MSVC ARM build after r157581.
- jit/JITStubsARM.h:
- 9:59 AM Changeset in webkit [158490] by
-
- 3 edits in trunk/Source/WTF
StringImpl::upper() should return PassRef.
<https://webkit.org/b/123655>
Make upper() return PassRef<StringImpl>. Spotted and removed some
ref churning in implementations.
Reviewed by Darin Adler.
- 9:42 AM Changeset in webkit [158489] by
-
- 3 edits2 adds in trunk/Source/WebKit2
[Cocoa] Add WKNSDictionary
https://bugs.webkit.org/show_bug.cgi?id=123660
Reviewed by Anders Carlsson.
- Shared/Cocoa/APIObject.mm:
(WebKit::APIObject::newObject): Allocate a WKNSDictionary if the APIObject is a dictionary.
- Shared/Cocoa/WKNSDictionary.h: Added.
(WebKit::wrapper): Added. Returns an ImmutableDictionary’s wrapper as an NSDictionary.
- Shared/Cocoa/WKNSDictionary.mm: Added.
(-[WKNSDictionary dealloc]): Calls the ImmutableDictionary destructor.
(-[WKNSDictionary count]): Added.
(-[WKNSDictionary objectForKey:]): Added.
(-[WKNSDictionary keyEnumerator]): Added.
(-[WKNSDictionary copyWithZone:]): Retains self.
(-[WKNSDictionary _apiObject]): Returns the wrapped ImmutableDictionary.
- WebKit2.xcodeproj/project.pbxproj: Added references to new files.
- 9:04 AM Changeset in webkit [158488] by
-
- 3 edits in trunk/Source/WebKit2
Address some review comments noted in r158463
https://bugs.webkit.org/show_bug.cgi?id=123646
Reviewed by Darin Adler.
- Shared/mac/RemoteLayerBackingStore.mm:
Put our has_include ifs all on one line.
(createIOSurface):
IOSurfaceAlignProperty returns size_t, not unsigned long.
(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::drawInContext):
Create the frontImage in display() and hand it to drawInContext().
Use the GraphicsContext API instead of CG itself for clearRect().
When using ShareableBitmap, replace m_frontBuffer instead of
having a backBuffer local; the CGImageRef will retain the
ShareableBitmap it references.
Duplicate our drawInContext() calls so we don't have to allocate
a GraphicsContext on the heap in the IOSurface case.
Don't bother clearing frontContext; it'll happen for us at
the appropriate time. Instead, assert that it's still alive after
we drop our reference to the frontImage created from it.
- 7:34 AM Changeset in webkit [158487] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] invalid use of incomplete type 'class WTF::PassOwnPtr<WTF::Vector<unsigned char> >'
https://bugs.webkit.org/show_bug.cgi?id=123601
Reviewed by Carlos Garcia Campos.
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: Explicitly include the PassOwnPtr.h header
as certain configurations on the GTK port don't ensure that the header is included indirectly.
- 3:10 AM Changeset in webkit [158486] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] invalid application of 'sizeof' to incomplete type
https://bugs.webkit.org/show_bug.cgi?id=123502
Patch by Vitaly Katunin <vkatunin@luxoft.com> on 2013-11-02
Reviewed by Carlos Garcia Campos.
- Shared/WebCoreArgumentCoders.cpp:
Nov 1, 2013:
- 11:59 PM Changeset in webkit [158485] by
-
- 17 edits6 copies14 adds in trunk
Add WebCrypto AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123647
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-192-encrypt-decrypt.html
crypto/subtle/aes-cbc-256-encrypt-decrypt.html
crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html
crypto/subtle/aes-cbc-encrypt-decrypt.html
crypto/subtle/aes-cbc-invalid-length.html
crypto/subtle/aes-cbc-wrong-key-class.html
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::getProperty): Factored out a function to get a property as JSValue.
(WebCore::getHashAlgorithm): Use it.
(WebCore::createAesCbcParams): Added converter for AesCbcParams.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt): Support AES_CBC.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey): Support all
algorithms, all the new ones just have trivial dictionaries.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey): Ditto.
- bindings/js/JSCryptoOperationData.cpp: Added.
(WebCore::sequenceOfCryptoOperationDataFromJSValue):
(WebCore::cryptoOperationDataFromJSValue):
- bindings/js/JSCryptoOperationData.h: Added.
Moved CryptoOperationData bindings out of JSSubtleCryptoCustom.cpp, so that we
could use them in JSCryptoAlgorithmDictionary.cpp.
- bindings/js/JSDOMPromise.h: (WebCore::PromiseWrapper::reject): Added a specialization
to reject with null result. The spec doesn't actually say how algorithms fail.
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::encrypt): Added.
(WebCore::JSSubtleCrypto::decrypt): Ditto.
(WebCore::JSSubtleCrypto::sign): Style fix.
- crypto/CryptoAlgorithmAesCbcParams.h: Added.
- crypto/CryptoKey.h:
(WebCore::CryptoKeyClass):
- crypto/keys/CryptoKeyHMAC.h:
(WebCore::asCryptoKeyHMAC):
Added poor man's RTTI, so that we can safely upcast Keys passed fro JavaScript code.
- crypto/CryptoKeyAES.cpp: Added.
(WebCore::CryptoKeyAES::CryptoKeyAES):
(WebCore::CryptoKeyAES::~CryptoKeyAES):
(WebCore::CryptoKeyAES::buildAlgorithmDescription):
- crypto/CryptoKeyAES.h: Added.
(WebCore::asCryptoKeyAES):
AES keys are the same for all algorithms, but they still need to remember the algorithm.
- crypto/SubtleCrypto.idl: Added encrypt/decrypt.
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp: Added.
(WebCore::CryptoAlgorithmAES_CBC::CryptoAlgorithmAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::~CryptoAlgorithmAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::create):
(WebCore::CryptoAlgorithmAES_CBC::identifier):
(WebCore::CryptoAlgorithmAES_CBC::importKey):
(WebCore::CryptoAlgorithmAES_CBC::exportKey):
- crypto/algorithms/CryptoAlgorithmAES_CBC.h: Added.
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: Added.
(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
(WebCore::CryptoAlgorithmAES_CBC::generateKey):
Added.
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
Check key class before casting it to CryptoKeyHMAC.
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register AES-CBC
on Mac, so that it can be used.
Source/WTF:
- wtf/FixedArray.h: (WTF::FixedArray::data): Added a const version of the function.
- wtf/Vector.h: Added a comment to Vector constructor about how it is different
from std::vector.
LayoutTests:
Part of aes-cbc-encrypt-decrypt.html test was taken from Blink.
- crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt: Added.
- crypto/subtle/aes-cbc-192-encrypt-decrypt.html: Added.
- crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt: Added.
- crypto/subtle/aes-cbc-256-encrypt-decrypt.html: Added.
- crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt: Added.
- crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt: Added.
- crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html: Added.
- crypto/subtle/aes-cbc-encrypt-decrypt.html: Added.
- crypto/subtle/aes-cbc-invalid-length-expected.txt: Added.
- crypto/subtle/aes-cbc-invalid-length.html: Added.
- crypto/subtle/aes-cbc-wrong-key-class-expected.txt: Added.
- crypto/subtle/aes-cbc-wrong-key-class.html: Added.
- crypto/subtle/hmac-sign-verify-expected.txt:
- crypto/subtle/hmac-sign-verify.html:
Corrected a description.
- crypto/subtle/resources/common.js: (hexToArrayBuffer): Added a helper.
- 10:01 PM Changeset in webkit [158484] by
-
- 36 edits in trunk/Source/WebCore
SVGRenderStyle accessors should return references.
<https://webkit.org/b/123656>
RenderStyle::svgStyle() and accessSVGStyle() never return null,
so make them return references instead.
This flushed out a myriad of pointless null checks and assertions.
Reviewed by Anders Carlsson.
- 7:28 PM Changeset in webkit [158483] by
-
- 4 edits in trunk/LayoutTests
Update layout test results after CSS calc() simplification
https://bugs.webkit.org/show_bug.cgi?id=123654
Reviewed by Andreas Kling.
r156586 simplified CSS calc expressions.
Update layout test results for calc().
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt:
- fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js:
(valueSettingTest):
- platform/efl/TestExpectations: gardening
- 7:24 PM Changeset in webkit [158482] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL should use a simple optimization pipeline by default
https://bugs.webkit.org/show_bug.cgi?id=123638
Reviewed by Geoffrey Garen.
20% speed-up on imagine-gaussian-blur, when combined with --ftlUsesStackmaps=true.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- runtime/Options.h:
- 7:23 PM Changeset in webkit [158481] by
-
- 2 edits in trunk/Source/WebKit2
Remote Layer Tree: Crashes allocating incredibly large backing store for tiled backing layers
https://bugs.webkit.org/show_bug.cgi?id=123651
Reviewed by Simon Fraser.
- Shared/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::drawInContext):
We can't dirty the whole layer if we have no existing front buffer if
we have no paints, because that will lead to layers which were never
setNeedsDisplay()'d getting backing store. Added back an assertion
that will catch this, too.
- 7:13 PM Changeset in webkit [158480] by
-
- 13 edits in trunk/Source
Removing MediaStreamTrackVector and MediaStreamSourceVector typedefs
https://bugs.webkit.org/show_bug.cgi?id=123648
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.
Source/WebCore:
No new tests needed.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::cloneMediaStreamTrackVector):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::haveTrackWithSource):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::trackVectorForType):
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::callSuccessHandler):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource):
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
- platform/mediastream/MediaStreamDescriptor.h:
- platform/mediastream/MediaStreamSource.h:
Source/WebKit/blackberry:
- WebCoreSupport/UserMediaClientImpl.cpp:
(WebCore::toMediaStreamDescriptor):
(WebCore::UserMediaClientImpl::requestUserMedia):
- WebCoreSupport/UserMediaClientImpl.h:
- 7:09 PM Changeset in webkit [158479] by
-
- 4 edits in trunk/Source/WTF
Unreviewed extended attempt at Windows build fix after r158471.
- wtf/text/cf/AtomicStringCF.cpp:
- wtf/text/cf/StringCF.cpp:
- wtf/text/cf/StringImplCF.cpp:
- 6:53 PM Changeset in webkit [158478] by
-
- 2 edits in trunk/Source/WebCore
createFontFaceValue() should be smarter about overgrown cache.
<https://webkit.org/b/123643>
Instead of clearing the whole font-face value cache when it passes
128 entries, just delete one entry at random.
Reviewed by Geoffrey Garen.
- 6:51 PM Changeset in webkit [158477] by
-
- 2 edits in trunk/Source/WebCore
Fixing mac code to use new MediaStreamDescriptor create method
https://bugs.webkit.org/show_bug.cgi?id=123653
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.
No new tests needed.
- platform/mediastream/mac/MediaStreamCenterMac.cpp:
(WebCore::MediaStreamCenterMac::createMediaStream):
- 6:50 PM Changeset in webkit [158476] by
-
- 2 edits in trunk/Source/WebCore
Re-use existing RenderStyle local in textWidth().
<https://webkit.org/b/123392>
We already have the RenderStyle cached in a local here, so avoid
getting it from RenderText since that has to go via the parent.
Reviewed by Antti Koivisto.
- 6:49 PM Changeset in webkit [158475] by
-
- 4 edits in trunk/Source/WTF
Unreviewed attempt at Windows build fix after r158471.
- wtf/text/cf/AtomicStringCF.cpp:
- wtf/text/cf/StringCF.cpp:
- wtf/text/cf/StringImplCF.cpp:
- 6:45 PM Changeset in webkit [158474] by
-
- 6 edits in trunk/Source
Make more StringImpl construction helpers return PassRef.
<https://webkit.org/b/123652>
Tweak another handful of StringImpl constructor functions to return
PassRef<StringImpl> instead of PassRefPtr.
Reviewed by Anders Carlsson.
- 6:38 PM Changeset in webkit [158473] by
-
- 6 edits in trunk/Source
Neuter WTF_MAKE_FAST_ALLOCATED in GLOBAL_FASTMALLOC_NEW builds.
<https://webkit.org/b/123639>
Source/JavaScriptCore:
JSC::ParserArenaRefCounted really needed to have the new/delete
operators overridden, in order for JSC::ScopeNode to be able to
choose that "operator new" out of the two it inherits.
Reviewed by Anders Carlsson.
Source/WebCore:
WebCore::TimerBase really needed to have the new/delete operators
overridden, in order for WebCore::SuspendableTimer to be able to
choose that "operator new" out of the two it inherits.
Reviewed by Anders Carlsson.
Source/WTF:
When building with GLOBAL_FASTMALLOC_NEW, we don't need to expand
operator new/delete overrides in every class.
This change makes allocations group up nicely in Instruments,
instead of being split between "WTF::fastMalloc" and "operator new"
depending on whether the class had WTF_MAKE_FAST_ALLOCATED.
Reviewed by Anders Carlsson.
- 6:23 PM Changeset in webkit [158472] by
-
- 2 edits in trunk/Source/WebCore
CSSCanvasValue construction helper should return PassRef.
<https://webkit.org/b/123650>
Return PassRef instead of PassRefPtr from functions that return
ownership-passing pointers that are known to be non-null.
Reviewed by Anders Carlsson.
- 6:22 PM Changeset in webkit [158471] by
-
- 11 edits5 moves2 adds in trunk/Source
Move CF/Mac WTF String implementations down into WTF
https://bugs.webkit.org/show_bug.cgi?id=123635
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-01
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Source/WTF:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/text/AtomicString.h:
- wtf/text/StringImpl.h:
- wtf/text/WTFString.h:
- wtf/text/cf/AtomicStringCF.cpp: Renamed from Source/WebCore/platform/text/cf/AtomicStringCF.cpp.
(WTF::AtomicString::add):
- wtf/text/cf/StringCF.cpp: Renamed from Source/WebCore/platform/text/cf/StringCF.cpp.
(WTF::String::String):
(WTF::String::createCFString):
- wtf/text/cf/StringImplCF.cpp: Renamed from Source/WebCore/platform/text/cf/StringImplCF.cpp.
(garbageCollectionEnabled):
(WTF::StringWrapperCFAllocator::retain):
(WTF::StringWrapperCFAllocator::release):
(WTF::StringWrapperCFAllocator::copyDescription):
(WTF::StringWrapperCFAllocator::allocate):
(WTF::StringWrapperCFAllocator::reallocate):
(WTF::StringWrapperCFAllocator::deallocateOnMainThread):
(WTF::StringWrapperCFAllocator::deallocate):
(WTF::StringWrapperCFAllocator::preferredSize):
(WTF::StringWrapperCFAllocator::create):
(WTF::StringWrapperCFAllocator::allocator):
(WTF::StringImpl::createCFString):
- wtf/text/mac/StringImplMac.mm: Renamed from Source/WebCore/platform/text/mac/StringImplMac.mm.
(WTF::StringImpl::operator NSString *):
- wtf/text/mac/StringMac.mm: Renamed from Source/WebCore/platform/text/mac/StringMac.mm.
(WTF::String::String):
- 6:20 PM Changeset in webkit [158470] by
-
- 3 edits in trunk/Source/WebCore
Removing unnecessary early returns in addTrack, removeTrack and removeRemoteSource methods
https://bugs.webkit.org/show_bug.cgi?id=123644
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.
No new tests needed.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::removeRemoteSource):
(WebCore::MediaStream::trackVectorForType):
- Modules/mediastream/MediaStream.h:
- 6:03 PM Changeset in webkit [158469] by
-
- 2 edits in trunk/Source/WebCore
CSSAspectRatioValue construction helper should return PassRef.
<https://webkit.org/b/123645>
Return PassRef instead of PassRefPtr from functions that return
ownership-passing pointers that are known to be non-null.
Reviewed by Darin Adler.
- 5:55 PM Changeset in webkit [158468] by
-
- 16 edits8 adds in branches/safari-537.73-branch
Merge r157070
Source/WebCore:
2013-10-04 Ojan Vafai <ojan@chromium.org> and Martin Robinson <mrobinson@igalia.com>
[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416
Reviewed by David Hyatt.
Tests: mathml/presentation/mo-minus.html
mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html
MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.
Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.
With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.
- css/mathml.css: Not sure what this line-height:0 was here for, but it caused bugs with the new code
- mathml/MathMLTextElement.cpp: (WebCore::MathMLTextElement::attach): (WebCore): (WebCore::MathMLTextElement::childrenChanged): Need to update the anonymous render tree below <mo> elements when their children change or when the renderer is first attached.
- mathml/MathMLTextElement.h: (MathMLTextElement):
- rendering/mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::RenderMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h: Now that the preferred width doesn't depend on the height, we don't need to override computePreferredLogicalWidths at all.
- rendering/mathml/RenderMathMLFenced.cpp: (WebCore::RenderMathMLFenced::makeFences): (WebCore::RenderMathMLFenced::styleDidChange): Need to update the anonymous renderers for the anonymous RenderMathMLOperators.
- rendering/mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::expandedStretchHeight): Store the non-expanded stretch height so that we can detect when the height actually changed.
(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout
(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::computeLogicalHeight): Return the stretched operator height, if appropriate.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.
- rendering/mathml/RenderMathMLOperator.h: Update method declarations.
LayoutTests:
2013-10-04 Frédéric Wang <fred.wang@free.fr>
[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416
Reviewed by David Hyatt.
Add some reftests for stretchy operators.
- TestExpectations: The remaining MathML pixel tests are broken by this patch.
- LayoutTests/platform/gtk/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
- LayoutTests/platform/win/TestExpectations:
- mathml/presentation/mo-minus.html: Added.
- mathml/presentation/mo-minus-expected.html: Added.
- mathml/presentation/mo-stacked-glyphs-expected.html: Added.
- mathml/presentation/mo-stacked-glyphs.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar.html: Added.
- mathml/very-large-stretchy-operators-expected.txt: Added.
- mathml/very-large-stretchy-operators.html: Added.
- 4:46 PM Changeset in webkit [158467] by
-
- 6 edits2 adds in trunk
Initial implementation of text-decoration-skip ink
https://bugs.webkit.org/show_bug.cgi?id=121806
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-11-01
Reviewed by Darin Adler.
Source/WebCore:
text-decoration-skip: ink is implemented by the following steps:
- Before drawing any decorations, figure out the bounding box for the decorations that will be drawn
- Create an ImageBuffer with these dimensions
- Draw text into this ImageBuffer with a thicker stroke
- Apply the ImageBuffer as a mask to the context
- Draw decorations like normal
- Clean up
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::computeLineBoundsAndAntialiasingModeForText): Don't call GraphicsContext::roundToDevicePixels
when painting is disabled
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Pass the TextPainter to paintDecoration
(WebCore::computeUnderlineOffset): Small cleanup
(WebCore::getWavyStrokeControlPointDistance): Pulling out of strokeWavyTextDecoration()
(WebCore::getWavyStrokeStep): Ditto
(WebCore::strokeWavyTextDecoration): Use the previous 2 functions
(WebCore::getSingleDecorationBoundingBox): Pulling out repeated code into a function
(WebCore::getDecorationBoundingBox): Compute the bounding box for an underline which
hasn't been drawn yet
(WebCore::InlineTextBox::paintDecoration): Construct a mask and apply it to the GraphicsContext
- rendering/InlineTextBox.h: paintDecoration needs the TextPainter
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline): Redraw the underline when
text-decoration-skip changes
LayoutTests:
Adding a test which draws a very large "p" with text-decoration-skip:ink. The
viewport is restricted to be just hugging the place where an underline would
intersect the descender of the "p". This should look the same as if there was
no underline at all (because of the skipping underline).
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-expected.html: Added.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html: Added.
- 4:38 PM Changeset in webkit [158466] by
-
- 2 edits in trunk/LayoutTests
[CSS Shapes] Fix typo in simple-polygon.js LayoutTest helper
https://bugs.webkit.org/show_bug.cgi?id=123595
Reviewed by Darin Adler.
- fast/shapes/resources/simple-polygon.js:
(generatePolygonContentString): Fixed a typo: the lineHeight parameter generatePolygonContentString() is now lineHeight.
- 4:34 PM Changeset in webkit [158465] by
-
- 4 edits in trunk/Source/WebCore
CSS 'initial' and 'inherit' value constructors should return PassRef.
<https://webkit.org/b/123641>
Make the helpers involved in constructing CSS{Initial,Inherited}Value
all return PassRef instead of PassRefPtr. This avoids generating
pointless null checks at the call sites.
Reviewed by Darin Adler.
- 4:29 PM Changeset in webkit [158464] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r158334. <rdar://problem/15359442>
- 4:24 PM Changeset in webkit [158463] by
-
- 2 edits2 moves in trunk/Source/WebKit2
Remote Layer Tree: Move RemoteLayerBackingStore to Shared/
https://bugs.webkit.org/show_bug.cgi?id=123646
Reviewed by Darin Adler.
Move RemoteLayerBackingStore to Shared/, since it is
used on both the UI and Web process side of things.
- Shared/mac/RemoteLayerBackingStore.h: Renamed from Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.h.
- Shared/mac/RemoteLayerBackingStore.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.mm.
- WebKit2.xcodeproj/project.pbxproj:
- 4:24 PM Changeset in webkit [158462] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merged r158334. <rdar://problem/15359450>
- 3:22 PM Changeset in webkit [158461] by
-
- 25 edits4 deletes in trunk/Source/WebCore
Kill RenderArena.
<https://webkit.org/b/123634>
There are no remaining users of the RenderArena allocator.
Reviewed by Geoffrey Garen.
- 3:14 PM Changeset in webkit [158460] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] WKObject seems to be initializing its target in a thread-safe manner, but really is not
https://bugs.webkit.org/show_bug.cgi?id=123640
Reviewed by Darin Adler.
- Shared/Cocoa/WKObject.mm:
(initializeTargetIfNeeded): Removed misleading incorrect code.
- 3:10 PM Changeset in webkit [158459] by
-
- 8 edits in trunk/Source/JavaScriptCore
OSR exit profiling should be robust against all code being cleared
https://bugs.webkit.org/show_bug.cgi?id=123629
<rdar://problem/15365476>
Reviewed by Michael Saboff.
The problem here is two-fold:
1) A watchpoint (i.e. ProfiledCodeBlockJettisoningWatchpoint) may be fired after we
have cleared the CodeBlock for all or some Executables. This means that doing
codeBlock->baselineVersion() would either crash or return a bogus CodeBlock, since
there wasn't a baseline code block reachable from the Executable anymore. The
solution is that we shouldn't be asking for the baseline code block reachable from
the owning executable (what baselineVersion did), but instead we should be asking
for the baseline version reachable from the code block being watchpointed (basically
what CodeBlock::alternative() did).
2) If dealing with inlined code, baselienCodeBlockForOriginAndBaselineCodeBlock()
may return null, for the same reason as above - we might have cleared the baseline
codeblock for the executable that was inlined. The solution is to just not do
profiling if there isn't a baseline code block anymore.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::baselineAlternative):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::jettison):
- bytecode/CodeBlock.h:
- bytecode/CodeBlockJettisoningWatchpoint.cpp:
(JSC::CodeBlockJettisoningWatchpoint::fireInternal):
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:
(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):
- dfg/DFGOSRExitBase.cpp:
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::AssemblyHelpers):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::baselineCodeBlockFor):
- 2:29 PM Changeset in webkit [158458] by
-
- 2 edits in trunk/Tools
Teach check-for-webkit-framework-include-consistency to ignore stale iOS Private headers that might exist in build directories due to r158443
https://bugs.webkit.org/show_bug.cgi?id=123636
Reviewed by Andreas Kling.
- Scripts/check-for-webkit-framework-include-consistency:
- 2:28 PM Changeset in webkit [158457] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Create a unique identifier for WebPageGroup if the input name is empty
https://bugs.webkit.org/show_bug.cgi?id=123606
Reviewed by Andreas Kling.
Strengthen the "public" API of page group.
If someone uses WKBrowsingContextGroup with a nil or empty string, the related WKString
would be empty, and all the WKBrowsingContextGroup end up with the same identifier.
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
- 2:26 PM Changeset in webkit [158456] by
-
- 2 edits2 moves in trunk/Source/WebKit2
[Cocoa] Avoid some double-wrapping of strings and URLs
https://bugs.webkit.org/show_bug.cgi?id=123632
Reviewed by Anders Carlsson.
- Shared/API/c/cf/WKStringCF.cpp: Removed.
- Shared/API/c/cf/WKStringCF.mm: Copied from Source/WebKit2/Shared/API/c/cf/WKStringCF.cpp.
(wkNSStringClass): Added this helper.
(WKStringCreateWithCFString): If the passed-in CFString is already wrapping a WebString,
then retain it and return it.
- Shared/API/c/cf/WKURLCF.cpp: Removed.
- Shared/API/c/cf/WKURLCF.mm: Copied from Source/WebKit2/Shared/API/c/cf/WKURLCF.cpp.
(wkNSURLClass): Added this helper.
(WKURLCreateWithCFURL): If the passed-in CFURL is already wrapping a WebURL, then retain it
and return it.
- WebKit2.xcodeproj/project.pbxproj: Updated for renames.
- 2:23 PM Changeset in webkit [158455] by
-
- 5 edits in trunk
AX: Regression: media controls are no longer accessible
https://bugs.webkit.org/show_bug.cgi?id=121990
Patch by James Craig <jcraig@apple.com> on 2013-11-01
Reviewed by Jer Noble.
Source/WebCore:
Updated existing test coverage.
Added ARIA roles, attrs, and labels to the new media controls shadow DOM.
Localization will be handled in http://webkit.org/b/120956
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.UIString):
(Controller.prototype.createControls):
(Controller.prototype.handleLoadStart):
(Controller.prototype.handleError):
(Controller.prototype.handleAbort):
(Controller.prototype.handleSuspend):
(Controller.prototype.handleStalled):
(Controller.prototype.handleWaiting):
(Controller.prototype.handleFullscreenChange):
(Controller.prototype.handleMuteButtonClicked):
(Controller.prototype.handleMinButtonClicked):
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderChange):
(Controller.prototype.updatePlaying):
LayoutTests:
Removed failure expectation and updated expected render dump output.
- platform/mac/TestExpectations:
- platform/mac/accessibility/media-element-expected.txt:
- 2:06 PM Changeset in webkit [158454] by
-
- 4 edits in trunk/Source/WebKit
[iOS] Make some headers Private
https://bugs.webkit.org/show_bug.cgi?id=123626
Reviewed by Andreas Kling.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig: Exclude iOS Private headers from the Mac build.
- 2:04 PM Changeset in webkit [158453] by
-
- 7 edits in trunk/Source/WebCore
Take BidiRuns out of the arena.
<https://webkit.org/b/123630>
Stop arena-allocating BidiRun objects and use regular new/delete.
With this, there are no remaining clients of RenderArena.
It will be removed in a subsequent patch.
Reviewed by Anders Carlsson.
- 2:00 PM Changeset in webkit [158452] by
-
- 7 edits in trunk
Begin work on encoding argument types
https://bugs.webkit.org/show_bug.cgi?id=123631
Reviewed by Dan Bernstein.
Source/WebKit2:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder _encodeInvocation:forKey:]):
Encode argument types in an array.
(-[WKRemoteObjectEncoder _encodedObjectUsingBlock:]):
Add new helper method that encodes an object and returns the dictionary.
(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):
Implement this in terms of _encodedObjectUsingBlock:.
- Shared/MutableArray.cpp:
(WebKit::MutableArray::append):
- Shared/MutableArray.h:
Change append to take a PassRefPtr.
Tools:
Add another test method.
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
- 1:42 PM Changeset in webkit [158451] by
-
- 9 edits in trunk/Source/WebKit2
Rename InWindowState -> ViewState
https://bugs.webkit.org/show_bug.cgi?id=123584
Rubber stamped by Sam Weinig.
WebPageProxy::setViewState offers the option to wait for a reply. Previously this option
was only available via setIsInWindow, hence the mechanism to wait to the update has
'InWindowState' in method and variable names (i.e.
'WebPageProxy::waitForDidUpdateInWindowState'). Since the mechanism is now applicable to
all ViewState changes, rename to reflect this.
- UIProcess/API/mac/WKView.mm:
(-[WKView endDeferringViewInWindowChangesSync]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::waitForDidUpdateViewState):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::didUpdateViewState):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::didUpdateViewStateTimerFired):
(WebKit::WebPage::setViewState):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::didUpdateViewStateTimerFired):
- 1:15 PM Changeset in webkit [158450] by
-
- 21 edits in trunk
Expose setApplicationCacheOriginQuota via window.internals
https://bugs.webkit.org/show_bug.cgi?id=87838
Patch by Afonso R. Costa Jr. <afonso.costa@samsung.com> on 2013-11-01
Reviewed by Joseph Pecoraro.
Source/WebCore:
Also reset the default origin quota in resetToConsistentState().
- testing/Internals.cpp: Add setApplicationCacheOriginQuota.
(WebCore::Internals::resetToConsistentState): Reset the default origin
quota.
(WebCore::Internals::setApplicationCacheOriginQuota): Added.
- testing/Internals.h: Add setApplicationCacheOriginQuota.
- testing/Internals.idl: Ditto.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add
symbols for setApplicationCacheOriginQuota from Internals.
Tools:
- DumpRenderTree/TestRunner.cpp: Move setApplicationCacheOriginQuota
to window.internals
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h: Ditto.
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setApplicationCacheOriginQuota.
- DumpRenderTree/efl/TestRunnerEfl.cpp: Ditto.
- DumpRenderTree/gtk/TestRunnerGtk.cpp: Ditto.
- DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
- DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Ditto.
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
- WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
LayoutTests:
- http/tests/appcache/origin-quota-continued-download-multiple-manifests.html: Updated
to use setApplicationCacheOriginQuota from window.internals
- http/tests/appcache/origin-quota-continued-download.html: Ditto.
- http/tests/appcache/origin-quota.html: Ditto.
- 12:46 PM Changeset in webkit [158449] by
-
- 3 edits in trunk/Source/WebKit2
Remote Layer Tree: Vend layer contents via IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=123600
Reviewed by Anders Carlsson.
Address some review comments from Darin (and subsequently Anders).
- WebProcess/WebPage/mac/RemoteLayerBackingStore.h:
(WebKit::RemoteLayerBackingStore::surface):
No need for .get() here.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::ensureBackingStore):
All on one line for readability.
(createIOSurfaceContext):
This 'if' is meaningless.
(createIOSurface):
No need for a RetainPtr here, the dictionary is autoreleased.
(RemoteLayerBackingStore::display):
Snuggle 'context' up next to the other declarations.
- 12:35 PM Changeset in webkit [158448] by
-
- 5 edits in trunk/Source/WebKit2
Don't use the C API in WKRemoteObjectCoder
https://bugs.webkit.org/show_bug.cgi?id=123627
Reviewed by Dan Bernstein.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder init]):
(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):
- Shared/ImmutableDictionary.h:
- Shared/MutableDictionary.cpp:
(WebKit::MutableDictionary::add):
(WebKit::MutableDictionary::set):
- Shared/MutableDictionary.h:
- 12:18 PM Changeset in webkit [158447] by
-
- 16 edits in trunk
REGRESSION: Crashes in -[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:].
https://bugs.webkit.org/show_bug.cgi?id=123383.
Reviewed by Geoffrey Garen.
Tools:
Removed an inappropriate assertion in DumpRenderTree/mac/UIDelegate.mm and
added 2 attributes (databaseDefaultQuota and databaseMaxQuota) to allow
tests to set appropriate quota settings to exercise quota expansion tests
when needed.
- DumpRenderTree/TestRunner.cpp:
(TestRunner::TestRunner):
(getDatabaseDefaultQuotaCallback):
(getDatabaseMaxQuotaCallback):
(setDatabaseDefaultQuotaCallback):
(setDatabaseMaxQuotaCallback):
(TestRunner::staticValues):
- DumpRenderTree/TestRunner.h:
(TestRunner::databaseDefaultQuota):
(TestRunner::setDatabaseDefaultQuota):
(TestRunner::databaseMaxQuota):
(TestRunner::setDatabaseMaxQuota):
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededDatabaseQuota):
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
- DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::exceededDatabaseQuota):
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didExceedDatabaseQuota):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::TestRunner):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::databaseDefaultQuota):
(WTR::TestRunner::setDatabaseDefaultQuota):
(WTR::TestRunner::databaseMaxQuota):
(WTR::TestRunner::setDatabaseMaxQuota):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
LayoutTests:
Removed an inappropriate assertion in DumpRenderTree/mac/UIDelegate.mm and
added 2 attributes (databaseDefaultQuota and databaseMaxQuota) to allow
tests to set appropriate quota settings to exercise quota expansion tests
when needed.
- storage/websql/open-database-expand-quota.html:
- Set databaseDefaultQuota and databaseMaxQuota as needed for this test.
- storage/websql/open-database-over-quota-expected.txt:
- storage/websql/open-database-over-quota.html:
- Revert the change from r157874 which is no longer needed for this test.
- 12:10 PM Changeset in webkit [158446] by
-
- 2 edits in trunk/Source/WebKit
Reverted r158443. It broke the build.
- WebKit.xcodeproj/project.pbxproj:
- 11:59 AM Changeset in webkit [158445] by
-
- 3 edits in trunk/Source/WTF
HPPA build fixes
https://bugs.webkit.org/show_bug.cgi?id=123625
Original patch from John David Anglin <dave.anglin@bell.net>
Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.
- wtf/Platform.h:
- wtf/dtoa/utils.h:
- 11:48 AM Changeset in webkit [158444] by
-
- 2 edits in trunk/Source/WebKit2
Fix build on non-linux platforms
https://bugs.webkit.org/show_bug.cgi?id=123622
Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
- 11:37 AM Changeset in webkit [158443] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Make some headers Private
https://bugs.webkit.org/show_bug.cgi?id=123626
Reviewed by Sam Weinig.
- WebKit.xcodeproj/project.pbxproj:
- 11:30 AM Changeset in webkit [158442] by
-
- 2 edits in trunk/Source/WebCore
Explicitly initialize RefCounted base class in MediaStreamTrack's constructors
https://bugs.webkit.org/show_bug.cgi?id=123620
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-01
Reviewed by Andreas Kling.
No new tests needed.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack):
- 11:17 AM Changeset in webkit [158441] by
-
- 54 edits in trunk/LayoutTests
[css shapes] Pull in upstream fixes to shape-outside margin and clipping tests
https://bugs.webkit.org/show_bug.cgi?id=123588
Reviewed by Alexandru Chiculita.
Fix some typos in the tests, add better explanation, and generally
make the tests clearer.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 11:13 AM Changeset in webkit [158440] by
-
- 2 edits in trunk/Source/WebInspectorUI
Remove custom Function.prototype.bind() in favor of native version
https://bugs.webkit.org/show_bug.cgi?id=123608
Reviewed by Joseph Pecoraro.
- UserInterface/Utilities.js:
- 11:06 AM Changeset in webkit [158439] by
-
- 2 edits in trunk/Source/WebInspectorUI
Error trying to serialize a color created without an alpha component to RGBA or HSLA
https://bugs.webkit.org/show_bug.cgi?id=123623
Reviewed by Joseph Pecoraro.
Check whether we have .rgba and .hsla ivars before trying to retrieve them to serialize
the color to RGBA or HSLA format.
- UserInterface/Color.js:
(WebInspector.Color.prototype.toString):
- 11:03 AM Changeset in webkit [158438] by
-
- 6 edits in trunk/Source/WebCore
Adding addRemoteTrack and removeRemoteTrack functions to MediaStreamDescriptor and MediaStream
https://bugs.webkit.org/show_bug.cgi?id=123477
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.
When the backend report that a remote track has been added or removed by a remote peer, we must be able to add
it to its MediaStream
No new tests needed.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addTrack): Splitted in two parts that can be used by old addTrack and new addRemoteTrack.
(WebCore::MediaStream::removeTrack): Splitted in two parts that can be used by old removeTrack and new
removeRemoteTrack.
(WebCore::MediaStream::addRemoteSource): Reusing code in new addTrack method.
(WebCore::MediaStream::removeRemoteSource): Refactored.
(WebCore::MediaStream::addRemoteTrack): Added.
(WebCore::MediaStream::removeRemoteTrack): Added.
(WebCore::MediaStream::getTrackVectorForType): Helper method that returns a vector of tracks according to
track's type (Audio or Video).
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack):
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::addRemoteTrack): Added.
(WebCore::MediaStreamDescriptor::removeRemoteTrack): Added.
- platform/mediastream/MediaStreamDescriptor.h:
- 10:44 AM Changeset in webkit [158437] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [WK2] Crash in webkitWebViewLoadFailedWithTLSErrors
https://bugs.webkit.org/show_bug.cgi?id=123618
Patch by Brian Holt <brian.holt@samsung.com> on 2013-11-01
Reviewed by Mario Sanchez Prada.
The GOwnPtrSoup header was not included which meant that the
specialization for GOwnPtr<SoupURI> was not used and instead the
default freeOwnedGPtr which calls g_free is used and crashes.
- UIProcess/API/gtk/WebKitWebView.cpp:
- 9:30 AM Changeset in webkit [158436] by
-
- 30 edits6 copies1 move19 adds in trunk
[GStreamer] Support audio and video tracks
https://bugs.webkit.org/show_bug.cgi?id=117039
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-01
Reviewed by Philippe Normand.
Source/WebCore:
Tests: media/track/audio/audio-track-mkv-vorbis-addtrack.html
media/track/audio/audio-track-mkv-vorbis-enabled.html
media/track/audio/audio-track-mkv-vorbis-language.html
media/track/in-band/track-in-band-kate-ogg-addtrack.html
media/track/in-band/track-in-band-srt-mkv-addtrack.html
media/track/video/video-track-mkv-theora-addtrack.html
media/track/video/video-track-mkv-theora-language.html
media/track/video/video-track-mkv-theora-selected.html
- GNUmakefile.list.am: Add audio and video track files.
- PlatformEfl.cmake: Same.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::audioTrackEnabledChanged): Schedule "change" event.
(WebCore::HTMLMediaElement::videoTrackSelectedChanged): Same.
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::setEnabled): Call m_private->setEnabled
(WebCore::AudioTrack::enabledChanged): Added callback.
(WebCore::AudioTrack::labelChanged): Same.
(WebCore::AudioTrack::languageChanged): Same.
(WebCore::AudioTrack::willRemoveAudioTrackPrivate): Use ASSERT_UNUSED for consistence.
- html/track/AudioTrack.h: Add new enabled, label and language callbacks.
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::setSelected): Call m_private->setEnabled
(WebCore::VideoTrack::selectedChanged): Added callback.
(WebCore::VideoTrack::labelChanged): Same.
(WebCore::VideoTrack::languageChanged): Same.
(WebCore::VideoTrack::willRemoveVideoTrackPrivate): Use ASSERT_UNUSED for consistence.
- html/track/VideoTrack.h: Add new selected, label and language callbacks.
- platform/graphics/AudioTrackPrivate.h:
(WebCore::AudioTrackPrivate::setEnabled): Call m_client->enabledChanged
- platform/graphics/VideoTrackPrivate.h:
(WebCore::VideoTrackPrivate::setSelected): Call m_client->selectedChanged
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer): Add ASSERT(m_pad)
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfTagsChanged): Look at all tag events instead of just the first one.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateVideoSinkCapsChangedCallback): Separated callback when caps change from callback when number of videos change.
(WebCore::mediaPlayerPrivateVideoCapsChangeTimeoutCallback): Same.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): Initialize m_videoCapsTimerHandler.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): Disconnect audio and video tracks and remove callbacks.
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged): Separated callback when caps change from callback when number of videos change.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo): Create video tracks for each stream.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideoCaps): Separated callback when caps change from callback when number of videos change.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio): Create audio tracks for each stream.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Add audio and video tracks, and a pointer to keep track of the default audio stream.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp: Added.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Added.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Add GRefPtr<GstTagList>
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp: Added, handles tags and "active" property of audio and video tracks.
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Added.
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp: Added.
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Added.
LayoutTests:
- media/content/two-audio-and-video-tracks.mkv: Added.
- media/in-band-tracks.js: Renamed from LayoutTests/media/in-band-cues.js.
(testAddTrack): Tests addtrack events.
(testAttribute): Added "type" parameter so we can use this for audio and video tracks.
(testTextTrackMode): Renamed to make it clear that this only applies to text tracks.
(testCueStyle): Same.
(testTextTrackOrder): Same.
- media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Added.
- media/track/audio/audio-track-mkv-vorbis-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
- media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Added.
- media/track/audio/audio-track-mkv-vorbis-enabled.html: Added.
- media/track/audio/audio-track-mkv-vorbis-language-expected.txt: Added.
- media/track/audio/audio-track-mkv-vorbis-language.html: Copied from LayoutTests/media/track/in-band/track-in-band-kate-ogg-track-order.html.
- media/track/in-band/track-in-band-kate-ogg-addtrack-expected.txt: Added.
- media/track/in-band/track-in-band-kate-ogg-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
- media/track/in-band/track-in-band-kate-ogg-cues-added-once.html: Added.
- media/track/in-band/track-in-band-kate-ogg-kind.html: Added.
- media/track/in-band/track-in-band-kate-ogg-language.html: Added.
- media/track/in-band/track-in-band-kate-ogg-mode.html: Added.
- media/track/in-band/track-in-band-kate-ogg-style.html: Added.
- media/track/in-band/track-in-band-kate-ogg-track-order.html: Added.
- media/track/in-band/track-in-band-srt-mkv-addtrack-expected.txt: Added.
- media/track/in-band/track-in-band-srt-mkv-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
- media/track/in-band/track-in-band-srt-mkv-cues-added-once.html: Added.
- media/track/in-band/track-in-band-srt-mkv-kind.html: Added.
- media/track/in-band/track-in-band-srt-mkv-language.html: Added.
- media/track/in-band/track-in-band-srt-mkv-mode.html: Added.
- media/track/in-band/track-in-band-srt-mkv-style.html: Added.
- media/track/in-band/track-in-band-srt-mkv-track-order.html: Added.
- media/track/video/video-track-mkv-theora-addtrack-expected.txt: Added.
- media/track/video/video-track-mkv-theora-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
- media/track/video/video-track-mkv-theora-language-expected.txt: Added.
- media/track/video/video-track-mkv-theora-language.html: Copied from LayoutTests/media/track/in-band/track-in-band-kate-ogg-track-order.html.
- media/track/video/video-track-mkv-theora-selected-expected.txt: Added.
- media/track/video/video-track-mkv-theora-selected.html: Added.
- platform/mac/TestExpectations: Ignore audio and video track tests on mac.
- 7:40 AM Changeset in webkit [158435] by
-
- 2 edits in trunk/Source/WebInspectorUI
Remove custom Element.prototype.remove() in favor of native version
https://bugs.webkit.org/show_bug.cgi?id=123607
Reviewed by Timothy Hatcher.
- UserInterface/Utilities.js:
- 7:09 AM Changeset in webkit [158434] by
-
- 3 edits in trunk/Source/WebKit/win
[WIN] Reduce usage of CFSTR() in WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=121827
Reviewed by Brent Fulgham.
This moved the dependency on CF to a few functions only
and is a first step to make it compile without CF.
- WebPreferences.cpp:
- WebPreferences.h:
- 6:57 AM Changeset in webkit [158433] by
-
- 2 edits in trunk/Source/WTF
Buildfix for !USE(ICU_UNICODE) after 156968.
- wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault):
- 5:48 AM Changeset in webkit [158432] by
-
- 2 edits in trunk/Source/WebCore
Buildfix for !ENABLE(INSPECTOR) after 157288.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willDispatchEvent):
- 5:43 AM Changeset in webkit [158431] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Skip webgl tests because EFL port doesn't fully support webgl yet.
- platform/efl/TestExpectations:
- 5:09 AM Changeset in webkit [158430] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. css3 text tests are failing since r158389
- platform/efl/TestExpectations: Add failure tests.
- 4:54 AM Changeset in webkit [158429] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening. Tests passing after r158273 and r158352
and rebaseline needed after r158195.
- platform/gtk/TestExpectations: Removed tests now passing.
- platform/gtk/accessibility/media-element-expected.txt: Rebaseline.
- 3:59 AM Changeset in webkit [158428] by
-
- 13 edits in trunk
[ATK] Avoid explicit traversal of text controls and the render tree in AtkText implementation
https://bugs.webkit.org/show_bug.cgi?id=123153
Reviewed by Chris Fleizach.
Source/WebCore:
Remove functions from the AtkText implementation that manually
walk the render tree to compose the text for a exposed objects in
certain cases (e.g. anonymous blocks, text controls).
The reason for this change is that the current implementation
follows an error-prone approach, since by doing things like
manually walking the render tree from here we are not properly
considering all the possible scenarios that might happen when
traversing text. This, however, is a task that is better suited
for the TextIterator, which is already written to consider all
those cases and to emit the proper character in every single
situation: text nodes, replaced objects and so on.
So, by removing all that too specific code (textForObject() and
textForRenderer() mainly) from WebKitAccessibleInterfaceText.cpp
and relying in AccessibilityObject::textUnderElement(), which it
ends up using the TextIterator for certain cases, we have a much
better and robust method of retrieving the text associated with an
instance of AtkObject implementing the AtkText interface.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetText): Removed call to textForObject(), now that
we have just removed that function, together with textForRenderer().
Make AccessibilityRenderObject::textUnderElement() able to deal with
anonymous blocks directly, by creating a range based in the boundaries
defined by the first and last child renderers for that block. This will
make possible to treat an anonymous block as a whole instead of having
to rely in the concatenation of each of its children, as it does now.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Added a new code
path to deal with anonymous blocks for text renderers, or when including
all the children is explicitly requested.
Modified TextIterator so text for children of replaced objects are
ignored if we are emmiting the special character for those objects.
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleReplacedElement): Make sure no children are
handled a replaced object if m_emitsObjectReplacementCharacters is set.
- editing/TextIterator.h: Updated m_emitsObjectReplacementCharacters
description to reflect the new behavior.
LayoutTests:
Updated test expectations to properly reflect the new reality when it
comes to exposing replaced objects and anymous blocks.
- platform/gtk/accessibility/table-with-rules-expected.txt: Updated to
print <\n> explicitly for the two instances of <BR> that are present in the
test, that will be included as part of an anonymous block.
- platform/efl/accessibility/table-with-rules-expected.txt: Ditto.
- platform/efl-wk2/accessibility/table-with-rules-expected.txt: Ditto.
- platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated
expectations not to expect the text of a button to be shown.
- platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Ditto.
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Ditto.
- platform/gtk/TestExpectations: Removed replaced-objects-in-anonymous-blocks.html
from the list of expected failures, as it's now being properly exposed.
- 12:15 AM Changeset in webkit [158427] by
-
- 6 edits4 copies4 adds in trunk
Add a Mac WebCrypto implementation of HMAC importKey/sign/verify
https://bugs.webkit.org/show_bug.cgi?id=123598
Reviewed by Anders Carlsson.
Source/WebCore:
Test: crypto/subtle/hmac-sign-verify.html
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSSubtleCryptoCustom.cpp: Added property svn:eol-style.
(WebCore::createAlgorithmFromJSValue):
(WebCore::cryptoOperationDataFromJSValue):
(WebCore::cryptoKeyFormatFromJSValue):
(WebCore::cryptoKeyUsagesFromJSValue):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::digest):
(WebCore::JSSubtleCrypto::importKey):
- crypto/SubtleCrypto.idl:
- crypto/algorithms/CryptoAlgorithmHMAC.cpp: Added.
(WebCore::CryptoAlgorithmHMAC::CryptoAlgorithmHMAC):
(WebCore::CryptoAlgorithmHMAC::~CryptoAlgorithmHMAC):
(WebCore::CryptoAlgorithmHMAC::create):
(WebCore::CryptoAlgorithmHMAC::identifier):
(WebCore::CryptoAlgorithmHMAC::importKey):
(WebCore::CryptoAlgorithmHMAC::exportKey):
- crypto/algorithms/CryptoAlgorithmHMAC.h: Added.
- crypto/keys: Added.
- crypto/keys/CryptoKeyHMAC.cpp: Added.
(WebCore::CryptoKeyHMAC::CryptoKeyHMAC):
(WebCore::CryptoKeyHMAC::~CryptoKeyHMAC):
(WebCore::CryptoKeyHMAC::buildAlgorithmDescription):
- crypto/keys/CryptoKeyHMAC.h: Added.
- crypto/mac/CryptoAlgorithmHMACMac.cpp: Added.
(WebCore::getCommonCryptoAlgorithm):
(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
(WebCore::CryptoAlgorithmHMAC::generateKey):
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
LayoutTests:
- crypto/subtle/hmac-sign-verify-expected.txt: Added.
- crypto/subtle/hmac-sign-verify.html: Added.
- 12:15 AM Changeset in webkit [158426] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL][WK1] Rendering is broken when scrolled ewk_view_single repeatedly
https://bugs.webkit.org/show_bug.cgi?id=123609
Reviewed by Gyuyoung Kim.
ewk_view_single adds wrong updateRects except last one in scrolls_process,
because previous updateRects are not considered accumulated scrollOffsets.
- ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_scrolls_process):
Merged scrollOffsets to calculate updateRects once.
It will also reduce unnecessary memory copy operations.
Oct 31, 2013:
- 10:13 PM Changeset in webkit [158425] by
-
- 8 edits in trunk
JavaScript parser bug
https://bugs.webkit.org/show_bug.cgi?id=123506
Reviewed by Mark Lam.
Source/JavaScriptCore:
Add ParserState as an abstraction and use that to save and restore
the parser state around nested functions (We'll need to use this in
more places in future). Also fix a minor error typo this testcases
hit.
- parser/Parser.cpp:
(JSC::::parseFunctionInfo):
(JSC::::parseAssignmentExpression):
- parser/Parser.h:
(JSC::Parser::saveState):
(JSC::Parser::restoreState):
LayoutTests:
Update and add tests
- js/dom/assign-expected.txt:
- js/function-toString-parentheses-expected.txt:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 8:28 PM Changeset in webkit [158424] by
-
- 3 edits in trunk/LayoutTests
Update the test expectations for the bug 121452.
fast/frames/lots-of-objects.html and lots-of-iframes.html are timing out everywhere on Mac.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 7:47 PM Changeset in webkit [158423] by
-
- 2 edits in trunk/LayoutTests
Update the Mac test expectation for the mac-future.
- platform/mac/TestExpectations:
- 7:32 PM Changeset in webkit [158422] by
-
- 2 edits in trunk/Source/WebKit
Windows build fix attempt after r158421.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 7:05 PM Changeset in webkit [158421] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: Clean up a few Inspector interfaces
https://bugs.webkit.org/show_bug.cgi?id=123594
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
- WebCore.exp.in:
- inspector/InjectedScriptHost.cpp:
- inspector/InspectorBaseAgent.h:
(WebCore::InspectorBaseAgentInterface::name):
- inspector/InspectorConsoleAgent.cpp:
- inspector/InspectorConsoleAgent.h:
(WebCore::InspectorConsoleAgent::enabled):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::profilerEnabled):
- inspector/InspectorController.h:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
(WebCore::InspectorDebuggerAgent::enabled):
- inspector/InspectorRuntimeAgent.h:
(WebCore::InspectorRuntimeAgent::enabled):
- 6:45 PM Changeset in webkit [158420] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 6:42 PM Changeset in webkit [158419] by
-
- 1 copy in tags/Safari-537.73.2
New Tag.
- 6:27 PM Changeset in webkit [158418] by
-
- 2 edits in trunk/Source/WebKit2
Fix a typo/review comment from Dan, in http://trac.webkit.org/changeset/158413
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
- 6:16 PM Changeset in webkit [158417] by
-
- 11 edits in trunk/Source
Remote Layer Tree: Vend layer contents via IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=123600
Reviewed by Anders Carlsson.
- Configurations/WebKit2.xcconfig:
Link WebKit2 against IOSurface.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::dumpChangedLayers):
Dump the size of the backing store instead of the pointer of its
SharedBitmap, because that's slightly more useful.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
If a layer's backing store uses accelerated drawing, hand the IOSurface
to the CALayer for display.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::PlatformCALayerRemote):
Initialize contentsScale to 1 to match CA. Other properties will follow.
(PlatformCALayerRemote::ensureBackingStore):
Instead of replacing the RemoteLayerBackingStore when its properties
change, allow it to update them on the fly. Replacing them caused
us to throw away repaint rects when the accelerated drawing
flag was flipped.
(PlatformCALayerRemote::acceleratesDrawing):
(PlatformCALayerRemote::setAcceleratesDrawing):
Store the accelerated drawing flag and mark it dirty when it changes.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/RemoteLayerBackingStore.h:
(WebKit::RemoteLayerBackingStore::image):
Rename bitmap() to image() and have it create a CGImageRef from
the ShareableBitmap, ready for direct application to a CALayer.
(WebKit::RemoteLayerBackingStore::surface):
Return a IOSurface ready for direct application to a CALayer.
(WebKit::RemoteLayerBackingStore::acceleratesDrawing):
(WebKit::RemoteLayerBackingStore::hasFrontBuffer):
Return whether or not we have a front buffer/surface.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
Forward-declare some CGIOSurface SPI.
(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::ensureBackingStore):
Throw away our front image and reset flags if needed.
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
En/decode the front surface instead of the ShareableBitmap if needed,
using CoreIPC::MachPort. Destroy the port on receipt.
(createIOSurfaceContext):
Create a CGIOSurfaceContext from an IOSurface.
(createIOSurface):
Create an IOSurface of the given size.
(RemoteLayerBackingStore::image):
Return a CGImageRef, if we're not using accelerated drawing.
Moved from the header.
(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::drawInContext):
If using accelerated drawing, create and paint into an IOSurface.
Reorganize some code to make the copying-from-the-front-image code
work for both software and IOSurfaces.
Flush the context when completed, to ensure that any asynchronous
painting is complete before we vend the surface to the UI process.
- WebCore.exp.in:
Export sRGBColorSpaceRef.
- WebCore.xcodeproj/project.pbxproj:
Expose GraphicsContextCG.h.
- 6:11 PM Changeset in webkit [158416] by
-
- 3 edits in trunk/Source/WebCore
Remove unused Page::setDebuggerForAllPages
https://bugs.webkit.org/show_bug.cgi?id=123602
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
- page/Page.cpp:
- page/Page.h:
- 6:07 PM Changeset in webkit [158415] by
-
- 75 edits3 deletes in trunk/Source
Web Inspector: Remove InspectorState
https://bugs.webkit.org/show_bug.cgi?id=123547
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
- inspector/InspectorAgent.h:
(WebCore::InspectorAgent::create):
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
- inspector/InspectorApplicationCacheAgent.h:
(WebCore::InspectorApplicationCacheAgent::create):
- inspector/InspectorBaseAgent.cpp:
(WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):
- inspector/InspectorBaseAgent.h:
(WebCore::InspectorBaseAgent::InspectorBaseAgent):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
- inspector/InspectorCSSAgent.h:
(WebCore::InspectorCSSAgent::create):
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
- inspector/InspectorCanvasAgent.h:
(WebCore::InspectorCanvasAgent::create):
- inspector/InspectorClient.h:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
- inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::create):
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
- inspector/InspectorDOMStorageAgent.h:
(WebCore::InspectorDOMStorageAgent::create):
- inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
- inspector/InspectorDatabaseAgent.h:
(WebCore::InspectorDatabaseAgent::create):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::create):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
- inspector/InspectorIndexedDBAgent.h:
(WebCore::InspectorIndexedDBAgent::create):
- inspector/InspectorInputAgent.cpp:
(WebCore::InspectorInputAgent::InspectorInputAgent):
- inspector/InspectorInputAgent.h:
(WebCore::InspectorInputAgent::create):
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
- inspector/InspectorLayerTreeAgent.h:
(WebCore::InspectorLayerTreeAgent::create):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
(WebCore::InspectorMemoryAgent::create):
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::PageProfilerAgent::PageProfilerAgent):
(WebCore::InspectorProfilerAgent::create):
(WebCore::WorkerProfilerAgent::WorkerProfilerAgent):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
- inspector/InspectorResourceAgent.h:
(WebCore::InspectorResourceAgent::create):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
- inspector/InspectorRuntimeAgent.h:
- inspector/InspectorState.cpp: Removed.
- inspector/InspectorState.h: Removed.
- inspector/InspectorStateClient.h: Removed.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
- inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::create):
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::create):
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
- inspector/InspectorWorkerAgent.h:
- inspector/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::PageConsoleAgent):
- inspector/PageConsoleAgent.h:
(WebCore::PageConsoleAgent::create):
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::create):
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
- inspector/PageDebuggerAgent.h:
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
- inspector/PageRuntimeAgent.h:
(WebCore::PageRuntimeAgent::create):
- inspector/WorkerConsoleAgent.cpp:
(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
- inspector/WorkerConsoleAgent.h:
(WebCore::WorkerConsoleAgent::create):
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::create):
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
- inspector/WorkerDebuggerAgent.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
- inspector/WorkerInspectorController.h:
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
- inspector/WorkerRuntimeAgent.h:
(WebCore::WorkerRuntimeAgent::create):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postMessageToPageInspector):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
- workers/WorkerMessagingProxy.h:
- workers/WorkerReportingProxy.h:
Source/WebKit/blackberry:
- WebCoreSupport/InspectorClientBlackBerry.cpp:
- WebCoreSupport/InspectorClientBlackBerry.h:
- 6:01 PM Changeset in webkit [158414] by
-
- 2 edits in trunk/Source/WebKit/win
Compile fix for VS2012.
https://bugs.webkit.org/show_bug.cgi?id=123599
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-31
Reviewed by Brent Fulgham.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::WebFramePolicyListenerPrivate::WebFramePolicyListenerPrivate):
(WebFrameLoaderClient::cancelPolicyCheck):
(WebFrameLoaderClient::receivedPolicyDecision):
Use nullptr instead of 0 for m_policyFunction, which is a std::function.
- 5:48 PM Changeset in webkit [158413] by
-
- 4 edits3 adds in trunk/Source/WebKit2
Begin stubbing out the WKRemoteObjectCoder NSCoder subclass
https://bugs.webkit.org/show_bug.cgi?id=123596
Reviewed by Tim Horton.
- Shared/API/Cocoa/WKRemoteObject.mm:
(-[WKRemoteObject forwardInvocation:]):
Call through to the WKRemoteObjectRegistry.
- Shared/API/Cocoa/WKRemoteObjectCoder.h: Added.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm: Added.
(-[WKRemoteObjectEncoder init]):
Create a root WKDictionary.
(-[WKRemoteObjectEncoder dealloc]):
Assert that the current dictionary is the root dictionary; that we're back where we started.
(-[WKRemoteObjectEncoder allowsKeyedCoding]):
Return YES.
(-[WKRemoteObjectEncoder encodeObject:forKey:]):
Check that the object is valid and then encode it.
(-[WKRemoteObjectEncoder _encodeInvocation:forKey:]):
Encode the method type string and invocation selector.
(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
Create a WKDataRef and add it to the dictionary.
(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):
Create a new dictionary and call the block.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
Create an encoder and encode the invocation and interface.
- Shared/API/Cocoa/WKRemoteObjectRegistryInternal.h: Added.
Add IPI header.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 5:45 PM Changeset in webkit [158412] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL Int32ToDouble should handle the forward type check case where you need a recovery
https://bugs.webkit.org/show_bug.cgi?id=123605
Reviewed by Mark Hahnenberg.
If you have a Int32ToDouble that needs to do a type check and it's required to do a
forward exit, then it needs to manually pass in a value recovery for itself in the
OSR exit - since this is one of those forward-exiting nodes that doesn't have a
preceding MovHint.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileInt32ToDouble):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):
- 5:35 PM Changeset in webkit [158411] by
-
- 4 edits2 copies in branches/safari-537.73-branch
Merged r157183. <rdar://problem/15333287>
- 5:31 PM Changeset in webkit [158410] by
-
- 3 edits in trunk/Source/WebKit2
Address review comments.
- Shared/API/Cocoa/WKRemoteObject.h:
- Shared/API/Cocoa/WKRemoteObject.mm:
(-[WKRemoteObject conformsToProtocol:]):
- 5:05 PM Changeset in webkit [158409] by
-
- 5 edits1 add in trunk/Source/WebCore
Split PendingDeleteCall into its own header
https://bugs.webkit.org/show_bug.cgi?id=123597
Reviewed by Beth “Okay I guess so, bro” Dakin.
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- Modules/indexeddb/IDBPendingDeleteCall.h: Added.
(WebCore::IDBPendingDeleteCall::create):
(WebCore::IDBPendingDeleteCall::callbacks):
(WebCore::IDBPendingDeleteCall::IDBPendingDeleteCall):
- 5:01 PM Changeset in webkit [158408] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Convert some InspectorObject member variables to HashSet/HashMap
https://bugs.webkit.org/show_bug.cgi?id=123579
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
Make m_eventListenerBreakpoints and m_xhrBreakpoints HashSet.
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
Make m_javaScriptBreakpoints a HashMap.
- 4:56 PM Changeset in webkit [158407] by
-
- 6 edits1 copy1 add in trunk
Add a WKRemoteObject class
https://bugs.webkit.org/show_bug.cgi?id=123586
Reviewed by Dan Bernstein.
Source/WebKit2:
- Shared/API/Cocoa/WKRemoteObject.h: Added.
- Shared/API/Cocoa/WKRemoteObject.mm: Added.
(-[WKRemoteObject _initWithObjectRegistry:interface:]):
Add designated initializer.
(-[WKRemoteObject conformsToProtocol:]):
Check if the interface protocol conforms to our protocol.
(methodArgumentTypeEncodingForSelector):
Helper function that looks up a method in a given protocol and returns its type encoding.
(-[WKRemoteObject methodSignatureForSelector:]):
Try to find the method argument type encoding for the given selector and return its NSMethodSignature.
(-[WKRemoteObject forwardInvocation:]):
Add stub.
- Shared/API/Cocoa/WKRemoteObjectInterface.mm:
Remove a newline.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry remoteObjectProxyWithInterface:]):
Establish a mapping between interface identifiers and remote object proxies.
- WebKit2.xcodeproj/project.pbxproj:
Tools:
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
(TestWebKitAPI::TEST):
Add a conformsToProtocol: test.
- 4:30 PM Changeset in webkit [158406] by
-
- 19 edits9 copies in tags/Safari-538.4
- 4:23 PM Changeset in webkit [158405] by
-
- 4 edits2 adds in trunk
Correct the elapsedTime calculation in SVG animations
https://bugs.webkit.org/show_bug.cgi?id=119289
Patch by Youenn Fablet <youennf@gmail.com> on 2013-10-31
Reviewed by Brent Fulgham.
Merged from Blink: https://chromium.googlesource.com/chromium/blink/+/338f9badca7fb7880abdb0cecd5f02493c1f7d2e
Source/WebCore:
Test: svg/animations/getCurrentTime-pause-unpause.html
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::elapsed):
(WebCore::SMILTimeContainer::begin):
(WebCore::SMILTimeContainer::pause):
(WebCore::SMILTimeContainer::resume):
(WebCore::SMILTimeContainer::setElapsed):
- svg/animation/SMILTimeContainer.h:
LayoutTests:
- svg/animations/getCurrentTime-pause-unpause-expected.txt: Added.
- svg/animations/getCurrentTime-pause-unpause.html: Added.
- 4:12 PM Changeset in webkit [158404] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Breakpoints in auto-formatted JavaScript editors are not working
https://bugs.webkit.org/show_bug.cgi?id=123589
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
The internal this._ignoreCodeMirrorContentDidChangeEvent flag was being used
in two places that could be nested, meaning the flag was deleted while it
was still expected to be set. Change it instead to a counter, to handle nesting.
- UserInterface/TextEditor.js:
(WebInspector.TextEditor):
(WebInspector.TextEditor.prototype.set string):
(WebInspector.TextEditor.prototype.set formatted):
(WebInspector.TextEditor.prototype._contentChanged):
- 3:57 PM Changeset in webkit [158403] by
-
- 3 edits in tags/Safari-538.4/Source/WebCore
Merged r158391. <rdar://problem/15246606>
- 3:49 PM Changeset in webkit [158402] by
-
- 4 edits in trunk/Source/JavaScriptCore
FTL should implement InvalidationPoint in terms of llvm.stackmap
https://bugs.webkit.org/show_bug.cgi?id=113647
Reviewed by Mark Hahnenberg.
This is pretty straightforward now that InvalidationPoint has exactly the semantics
that agree with llvm.stackmap.
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::callStackmap):
- ftl/FTLOSRExitCompilationInfo.h:
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
- 3:38 PM Changeset in webkit [158401] by
-
- 9 edits in trunk
Source/JavaScriptCore: Implement basic ES6 Math functions
https://bugs.webkit.org/show_bug.cgi?id=123536
Reviewed by Michael Saboff.
Fairly trivial patch to implement the core ES6 Math functions.
This doesn't implement Math.hypot as it is not a trivial function.
I've also skipped Math.sign as I am yet to be convinced the spec
behaviour is good. Everything else is trivial.
- runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncACosh):
(JSC::mathProtoFuncASinh):
(JSC::mathProtoFuncATanh):
(JSC::mathProtoFuncCbrt):
(JSC::mathProtoFuncCosh):
(JSC::mathProtoFuncExpm1):
(JSC::mathProtoFuncFround):
(JSC::mathProtoFuncLog1p):
(JSC::mathProtoFuncLog10):
(JSC::mathProtoFuncLog2):
(JSC::mathProtoFuncSinh):
(JSC::mathProtoFuncTanh):
(JSC::mathProtoFuncTrunc):
Source/WTF: Implement basic ES6 Math functions
https://bugs.webkit.org/show_bug.cgi?id=123536
Reviewed by Michael Saboff.
Add basic implementations of necessary methods to MathExtras to
deal with MSVC not supplying them
- wtf/MathExtras.h:
(asinh):
(acosh):
(atanh):
(expm1):
(log1p):
(cbrt):
LayoutTests: Implement ES6 Math functions
https://bugs.webkit.org/show_bug.cgi?id=123536
Reviewed by Michael Saboff.
Add tests for new math functions
- js/Object-getOwnPropertyNames-expected.txt:
- js/math-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/math.js:
- 3:29 PM Changeset in webkit [158400] by
-
- 4 edits in trunk/Source/JavaScriptCore
FTL::Location::restoreInto() doesn't handle stack-related registers correctly if you're using it after pushing a new stack frame
https://bugs.webkit.org/show_bug.cgi?id=123591
Reviewed by Mark Hahnenberg.
This gets us to pass more tests with ftlUsesStackmaps.
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::restoreInto):
- ftl/FTLLocation.h:
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationWithStackMapThunkGenerator):
- 3:21 PM Changeset in webkit [158399] by
-
- 8 edits in branches/safari-537.73-branch/Source
Merged r157056. <rdar://problem/15357230>
- 2:59 PM Changeset in webkit [158398] by
-
- 3 edits in trunk/Source/WebCore
Manage line-grid RootInlineBox with unique_ptr.
<https://webkit.org/b/123583>
Use smart pointers for the RenderBlockFlow's optional line-grid box
instead of manual new/delete.
Reviewed by Antti Koivisto.
- 2:50 PM Changeset in webkit [158397] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r156481. <rdar://problem/15168249>
- 2:50 PM Changeset in webkit [158396] by
-
- 18 edits19 moves3 adds in trunk
Enable WebCrypto on Mac
https://bugs.webkit.org/show_bug.cgi?id=123587
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Do it.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig: Enable it.
- bindings/js/JSCryptoAlgorithmDictionary.cpp: Build fix.
- crypto/CryptoAlgorithmRegistry.cpp: (WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
Special case empty keys to avoid upsetting HashMap.
- crypto/algorithms/CryptoAlgorithmSHA1.cpp: (WebCore::CryptoAlgorithmSHA1::create):
Build fix. Can't use make_unique, because constructor is private.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Do it.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig: Do it.
LayoutTests:
- TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
Only skipping on specific platforms now.
- crypto: Added.
- crypto/crypto-gc-expected.txt: Copied from LayoutTests/security/crypto-gc-expected.txt.
- crypto/crypto-gc.html: Copied from LayoutTests/security/crypto-gc.html.
- crypto/crypto-random-values-expected.txt: Copied from LayoutTests/security/crypto-random-values-expected.txt.
- crypto/crypto-random-values-limits-expected.txt: Copied from LayoutTests/security/crypto-random-values-limits-expected.txt.
- crypto/crypto-random-values-limits.html: Copied from LayoutTests/security/crypto-random-values-limits.html.
- crypto/crypto-random-values-types-expected.txt: Copied from LayoutTests/security/crypto-random-values-types-expected.txt.
- crypto/crypto-random-values-types.html: Copied from LayoutTests/security/crypto-random-values-types.html.
- crypto/crypto-random-values.html: Copied from LayoutTests/security/crypto-random-values.html.
- crypto/subtle: Added.
- crypto/subtle/argument-conversion-expected.txt: Copied from LayoutTests/security/crypto-subtle-arguments-expected.txt.
- crypto/subtle/argument-conversion.html: Copied from LayoutTests/security/crypto-subtle-arguments.html.
- crypto/subtle/gc-2-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-2-expected.txt.
- crypto/subtle/gc-2.html: Copied from LayoutTests/security/crypto-subtle-gc-2.html.
- crypto/subtle/gc-3-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-3-expected.txt.
- crypto/subtle/gc-3.html: Copied from LayoutTests/security/crypto-subtle-gc-3.html.
- crypto/subtle/gc-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-expected.txt.
- crypto/subtle/gc.html: Copied from LayoutTests/security/crypto-subtle-gc.html.
- crypto/subtle/resources: Added.
- crypto/subtle/resources/common.js: Copied from LayoutTests/security/resources/common.js.
- crypto/subtle/sha-1-expected.txt: Copied from LayoutTests/security/crypto-subtle-sha1-expected.txt.
- crypto/subtle/sha-1.html: Copied from LayoutTests/security/crypto-subtle-sha1.html.
- security/crypto-gc-expected.txt: Removed.
- security/crypto-gc.html: Removed.
- security/crypto-random-values-expected.txt: Removed.
- security/crypto-random-values-limits-expected.txt: Removed.
- security/crypto-random-values-limits.html: Removed.
- security/crypto-random-values-types-expected.txt: Removed.
- security/crypto-random-values-types.html: Removed.
- security/crypto-random-values.html: Removed.
- security/crypto-subtle-arguments-expected.txt: Removed.
- security/crypto-subtle-arguments.html: Removed.
- security/crypto-subtle-gc-2-expected.txt: Removed.
- security/crypto-subtle-gc-2.html: Removed.
- security/crypto-subtle-gc-3-expected.txt: Removed.
- security/crypto-subtle-gc-3.html: Removed.
- security/crypto-subtle-gc-expected.txt: Removed.
- security/crypto-subtle-gc.html: Removed.
- security/crypto-subtle-sha1-expected.txt: Removed.
- security/crypto-subtle-sha1.html: Removed.
- security/resources/common.js: Removed.
Moved tests from security/ to crypto/.
- 2:29 PM Changeset in webkit [158395] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154897. <rdar://problem/15168237>
- 2:24 PM Changeset in webkit [158394] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r153087. <rdar://problem/15168237>
- 2:15 PM Changeset in webkit [158393] by
-
- 2 edits2 adds in trunk/Tools
build.webkit.org should have a clean build button
https://bugs.webkit.org/show_bug.cgi?id=123559
Reviewed by Darin Adler.
Add a new "clean" forced scheduler. When a build was created by this scheduler, CleanBuildIfScheduled
step executes clean-build script that removes the WebKitBuild directory.
Also added make-passwords-json.py which creates a fake passwords.json from config.json for testing purposes.
- BuildSlaveSupport/build.webkit.org-config/make-passwords-json.py: Added.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CleanBuildIfScheduled): Added.
(CleanBuildIfScheduled.start): Added. Don't do a clean build if if this build wasn't schecueld by
the clean build scheduler.
(DeleteStaleBuildFiles): Added.
(DeleteStaleBuildFiles.start): Added. Don't delete stale build files if this build was scheduled by
the clean build scheduler since everything in the WebKitBuild directory had already been removed.
(Factory.init): Always add CleanBuildIfScheduled. The step itself checks whether to run
clean-build script or hide itself.
(loadBuilderConfig): Added the new clean build scheduler. Also make ForceScheduler future proof; in newer
versions of buildbot, builderNames needs to be a list of regular strings.
- BuildSlaveSupport/clean-build: Added.
- 2:14 PM Changeset in webkit [158392] by
-
- 6 edits in trunk/Source/WebCore
Underline bounds cannot be queried before underline itself is drawn
https://bugs.webkit.org/show_bug.cgi?id=123310
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-31
Reviewed by Dean Jackson.
GraphicsContext's drawLineForText function is used to draw underlines,
strikethroughs, and overlines. Before drawing the line, this function
modifies the bounds given to it in order to make underlines crisp. However,
this means that it is impossible to know where an underline will be drawn
before drawing it. This patch pulls out this adjustment computation into
GraphicsContext::computeLineBoundsForText, then passes the result to
drawLineForText
Because there should be no observable difference, no tests need to be updated.
- platform/graphics/GraphicsContext.h: Signature of new computeLineBoundsForText
function
- platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::computeLineBoundsForText): Implement new function
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::computeLineBoundsForText): Ditto
(WebCore::GraphicsContext::drawLineForText): Use computeLineBoundsForText
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::computeLineBoundsAndAntialiasingModeForText): Static function that
performs the actual bounds computation
(WebCore::GraphicsContext::computeLineBoundsForText): Calls
computeLineBoundsAndAntialiasingModeForText
(WebCore::GraphicsContext::drawLineForText): Use new function
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::computeLineBoundsForText): Implement new function
- 2:03 PM Changeset in webkit [158391] by
-
- 3 edits in trunk/Source/WebCore
Repro scrolling crash with scrollbars that use setPresentationValue on the
scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=123549
-and corresponding-
<rdar://problem/15246606>
Reviewed by Brady Eidson.
Here's another speculative fix. If a scrollbar was removed, we would not properly
inform the scrolling thread. Instead of checking supportsUpdateOnSecondaryThread()
before calling setScrollbarPaintersFromScrollbars(), check it from within
setScrollbarPaintersFromScrollbars(), and this will allow the ScrollbarPainter to
be properly updated.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
(WebCore::ScrollingStateScrollingNode::setScrollbarPaintersFromScrollbars):
- 1:13 PM Changeset in webkit [158390] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed typo fix after 158386. (buildfix after r158365)
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::callSuccessHandler):
- 1:11 PM Changeset in webkit [158389] by
-
- 30 edits4 adds in trunk
Move CSS3 text decoration implementation behind ENABLE(CSS3_TEXT_DECORATION)
https://bugs.webkit.org/show_bug.cgi?id=123541
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-31
Reviewed by Tim Horton.
Source/WebCore:
Enabled CSS3 text decoration tests
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationStyleFlagsToCSSValue): Mapping internal
representation to a CSSValue
(WebCore::ComputedStyleExtractor::propertyValue): Ditto
- css/CSSParser.cpp: Moving parsing functions behind new flag
(WebCore::isColorPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::parseTextDecorationSkip):
(WebCore::CSSParser::parseTextUnderlinePosition):
- css/CSSParser.h:
- css/CSSPrimitiveValueMappings.h:
- css/CSSPropertyNames.in: Marking the new properties behind new flag
- css/CSSValueKeywords.in: Marking new values behind new flag
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/StylePropertyShorthand.cpp:
(WebCore::shorthandForProperty): Move text decoration shorthand
(WebCore::matchingShorthandsForLonghand):
- css/StylePropertyShorthand.h:
- css/StyleResolver.cpp:
(WebCore::isValidVisitedLinkProperty):
(WebCore::StyleResolver::applyProperty):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformStrokeStyle):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLine):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::createPen):
- rendering/InlineFlowBox.cpp:
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.cpp:
(WebCore::textDecorationStyleToStrokeStyle):
(WebCore::computeUnderlineOffset):
(WebCore::InlineTextBox::paintDecoration):
- rendering/RenderObject.cpp:
(WebCore::decorationColor):
- rendering/RootInlineBox.cpp:
- rendering/RootInlineBox.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
- platform/mac/TestExpectations: Enable CSS3 text decoration tests
(since CSS3_TEXT_DECORATION is enabled by default)
- 12:50 PM Changeset in webkit [158388] by
-
- 11 edits in trunk/Source/WebKit2
[WK2] Convert SeccompFilters to using unique_ptr instead of OwnPtr/PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122883
Patch by Sergio Correia <Sergio Correia> on 2013-10-31
Reviewed by Darin Adler.
- Shared/linux/SeccompFilters/OpenSyscall.cpp:
(WebKit::OpenSyscall::createFromOpenatContext):
(WebKit::OpenSyscall::createFromCreatContext):
(WebKit::OpenSyscall::execute):
- Shared/linux/SeccompFilters/OpenSyscall.h:
- Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SIGSYSHandler):
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBroker::runLoop):
- Shared/linux/SeccompFilters/SigactionSyscall.cpp:
(WebKit::SigactionSyscall::createFromContext):
- Shared/linux/SeccompFilters/SigactionSyscall.h:
- Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp:
(WebKit::SigprocmaskSyscall::createFromContext):
- Shared/linux/SeccompFilters/SigprocmaskSyscall.h:
- Shared/linux/SeccompFilters/Syscall.cpp:
(WebKit::Syscall::createFromContext):
(WebKit::Syscall::createFromDecoder):
(WebKit::SyscallResult::createFromDecoder):
- Shared/linux/SeccompFilters/Syscall.h:
- Shared/linux/SeccompFilters/SyscallPolicy.cpp:
- 12:31 PM Changeset in webkit [158387] by
-
- 7 edits9 adds in trunk
[WebCrypto] Add SHA-1
https://bugs.webkit.org/show_bug.cgi?id=123582
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: security/crypto-subtle-arguments.html
security/crypto-subtle-sha1.html
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::createAlgorithmFromJSValue):
(WebCore::sequenceOfCryptoOperationDataFromJSValue):
(WebCore::JSSubtleCrypto::digest):
- crypto/SubtleCrypto.idl:
Added bindings for crypto.digest.
- crypto/algorithms: Added.
- crypto/algorithms/CryptoAlgorithmSHA1.cpp: Added.
- crypto/algorithms/CryptoAlgorithmSHA1.h: Added.
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register SHA-1.
- crypto/mac/CryptoAlgorithmSHA1Mac.cpp: Added.
(WebCore::CryptoAlgorithmSHA1::digest): Performs the work synchronously, because
otherwise we'd have to copy the data first, which is crazy for something as simple
as hashing. We can change to a dispatch queue later if we find that it's actually
better to copy and do the work asynchronously.
LayoutTests:
- security/resources/common.js: Added from Blink.
(importTestKeys):
(asciiToArrayBuffer):
(printRejectedResult):
(printAcceptedResult):
(failAndFinishJSTest):
- security/crypto-subtle-arguments-expected.txt: Added.
- security/crypto-subtle-arguments.html: Added.
Added tests for how bindings treat crazy arguments. Heavily based on a test from Blink.
- security/crypto-subtle-sha1-expected.txt: Added.
- security/crypto-subtle-sha1.html: Added.
Test that SHA-1 works.
- TestExpectations: Skip these tests everywhere for now.
- 12:22 PM Changeset in webkit [158386] by
-
- 2 edits in trunk/Source/WebCore
One more speculative buildfix after r158365.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::callSuccessHandler):
- 12:20 PM Changeset in webkit [158385] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, really remove CachedTranscendentalFunction.h.
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- 12:19 PM Changeset in webkit [158384] by
-
- 22 edits6 adds1 delete in trunk
Remove CachedTranscendentalFunction because caching math functions is an ugly idea
https://bugs.webkit.org/show_bug.cgi?id=123574
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
This is performance-neutral because I also make Math.cos/sin intrinsic. This means that
we gain the "overhead" of actually computing sin and cos but we lose the overhead of
going through the native call thunks.
Caching transcendental functions is a really ugly idea. It works for SunSpider because
that benchmark makes very predictable calls into Math.sin. But I don't believe that this
is representative of any kind of reality, and so for sensible uses of Math.sin/cos all
that this was doing was adding more call overhead and some hashing overhead.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITOperations.h:
- runtime/CachedTranscendentalFunction.h: Removed.
- runtime/DateInstanceCache.h:
- runtime/Intrinsic.h:
- runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncSin):
- runtime/VM.h:
Tools:
Reviewed by Mark Hahnenberg.
Make it easier to see that a test doesn't have an -expected file.
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Mark Hahnenberg.
- js/dfg-cos-constant-expected.txt: Added.
- js/dfg-cos-constant.html: Added.
- js/dfg-sin-constant-expected.txt: Added.
- js/dfg-sin-constant.html: Added.
- js/script-tests/dfg-cos-constant.js: Added.
(foo):
- js/script-tests/dfg-sin-constant.js: Added.
(foo):
- 12:17 PM Changeset in webkit [158383] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r158348): Breaks Debug build
https://bugs.webkit.org/show_bug.cgi?id=123562
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-10-31
Reviewed by Brady Eidson.
Remove an unnecessary check that cause compilation failure.
No new tests since this just fixes the build failure.
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):
- 12:16 PM Changeset in webkit [158382] by
-
- 2 edits in trunk/Source/WebCore
One more speculative buildfix after r158365.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::didAddRemoteStream):
- 12:08 PM Changeset in webkit [158381] by
-
- 3 edits in trunk/Source/WebCore
Speculative buildfix after r158365.
- Modules/mediastream/VideoStreamTrack.cpp:
(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack):
- Modules/mediastream/VideoStreamTrack.h:
- 12:08 PM Changeset in webkit [158380] by
-
- 2 edits in tags/Safari-538.4/Source/WebCore
Merged r158375. <rdar://problem/15246606>
- 11:47 AM Changeset in webkit [158379] by
-
- 2 edits in trunk/Source/WebCore
Decorated text sometimes does not draw its decorations
https://bugs.webkit.org/show_bug.cgi?id=123539
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-31
Reviewed by Antti Koivisto.
Decorated text should opt-out of the simple line layout, because
SimpleLineLayout::paintFlow doesn't draw decorations
Fixes fast/css3-text/css3-text-decoration/text-decoration-color.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- 11:40 AM Changeset in webkit [158378] by
-
- 4 edits in tags/Safari-538.4/Source/JavaScriptCore
Merged r158341. <rdar://problem/15356238>
- 11:33 AM Changeset in webkit [158377] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: Remove last member variable uses of InspectorState from Agents
https://bugs.webkit.org/show_bug.cgi?id=123540
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
DOMDebuggerAgentState::eventListenerBreakpoints -> m_eventListenerBreakpoints.
DOMDebuggerAgentState::xhrBreakpoints -> m_xhrBreakpoints.
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
DebuggerAgentState::javaScriptBreakpoints -> m_javaScriptBreakpoints.
- inspector/InspectorPageAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
PageAgentState::pageAgentScriptsToEvaluateOnLoad -> m_scriptsToEvaluateOnLoad.
This is a lazily created InspectorObject member variable.
- inspector/InspectorResourceAgent.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
ResourceAgentState::extraRequestHeaders -> m_extraRequestHeaders.
This is a lazily created InspectorObject member variable.
- 11:29 AM Changeset in webkit [158376] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, one more build fix after r158365.
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
- 11:26 AM Changeset in webkit [158375] by
-
- 2 edits in trunk/Source/WebCore
Repro scrolling crash with scrollbars that use setPresentationValue on the
scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=123549
-and corresponding-
<rdar://problem/15246606>
Reviewed by Darin Adler.
Speculative fix. I think if we retain the ScrollbarPainters, we should avoid this
crash.
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
- 11:18 AM Changeset in webkit [158374] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, MediaStream build fix after r158365.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::clone):
- 11:13 AM Changeset in webkit [158373] by
-
- 4 edits in trunk/Tools
Run tests as if they are expected to pass when --force is given.
https://bugs.webkit.org/show_bug.cgi?id=112890
Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-10-31
Reviewed by Ryosuke Niwa.
The --force switch of new-run-webkit-tests is now forces all tests to
be run with 'PASS' as expected result.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.init):
(TestExpectations._add_expectations):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(_set_up_derived_options):
- 11:05 AM Changeset in webkit [158372] by
-
- 12 edits in trunk/Source/WebKit2
Change WebPage, WebPageProxy, WebPageCreationParameters to use ViewState
https://bugs.webkit.org/show_bug.cgi?id=123379
Reviewed by Darin Adler.
Visibility state of the Page should be stored and communicated consistently.
Remove individual visibility flags from WebPageProxy, WebPageCreationParameters,
and replace them with a ViewState, and add a ViewState member to WebPage.
Merge together all messages that convey and individual aspect of the ViewState.
Restructure WebPageProxy::viewStateDidChange to break the operation down into
three steps: 1) update m_viewState, 2) send the new ViewState to the WebProcess,
and 3) perform any further work necessary in the UIProcess.
This patch fixes a problem that if the web process crashes m_isVisible &
m_isInWindow in WebPageProxy were not updated, and could have held stale values
on reattach.
In WebPage, add a new message to update the entire ViewState - diff the prior
value against the new one to detect changes, call existing methods accordingly.
- Shared/ViewState.h:
- Add constants 'Reset', 'AllFlags'
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- Removed boolean visibility flags, added viewState.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- Constructor calls updateViewState to initialize m_viewState.
(WebKit::WebPageProxy::reattachToWebProcess):
- ViewStaet is not updated while detatched; recalculate.
(WebKit::WebPageProxy::initializeWebPage):
- m_isVisible -> isViewVisible()
(WebKit::WebPageProxy::updateViewState):
- Added, update m_viewState by querying the page client.
(WebKit::WebPageProxy::viewStateDidChange):
- Restructured to use m_viewState, reordered to combine messages.
(WebKit::WebPageProxy::creationParameters):
- Removed boolean visibility flags, added viewState.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::isInWindow):
(WebKit::WebPageProxy::isViewVisible):
- Removed boolean visibility flags, added viewState.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- initial state now passed as a ViewState.
(WebKit::WebPage::setIsInWindow):
- Remove code to send reply (this is handled by setViewState).
(WebKit::WebPage::setViewState):
- Set m_viewState - diff from prior & call methods to update.
- WebProcess/WebPage/WebPage.h:
- Added setViewState, m_viewState.
- WebProcess/WebPage/WebPage.messages.in:
- Add SetViewState, remove individual messages.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
- initial state now passed as a ViewState.
- 11:03 AM Changeset in webkit [158371] by
-
- 2 edits in trunk/Tools
2013-10-31 Geoffrey Garen <ggaren@apple.com>
Added Mark Lam as a reviewer.
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 11:02 AM Changeset in webkit [158370] by
-
- 4 edits in trunk/Source/WebKit/win
[WIN] Make WebHistory compile without USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=122010
Reviewed by Brent Fulgham.
Add an alternative code path for !USE(CF) to be able to
compile WebHistory without the CoreFoundation library.
- COMVariantSetter.h: Add support for setting a Vector.
- WebHistory.cpp:
(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
(WebHistory::removeAllItems):
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):
- WebHistory.h:
- 10:48 AM Changeset in webkit [158369] by
-
- 4 edits2 adds in trunk
WebPageCreationParameters should be consistent in Window.open
https://bugs.webkit.org/show_bug.cgi?id=123557
Reviewed by Sam Weinig.
When Window.open in called in WebKit2 the WebProcess sends a synchronous request to open
a page (WebPageProxy::createNewPage). The UIProcess creates a WebpageProxy, and responds
with instructions to the WebProcess to create the WebPage. The initial creation state of
the WebPage is communicated to the WebProcess via two routes (firstly an asynchronous
WebProcess::CreateWebPage message, and secondly in the synchronous response from
WebPageProxy::createNewPage). Unfortunately these responses are inconsistent with each
other. The creationParameters() for the page are calculated twice, and since the WKView
will be added to a window between the async message being sent and the synchronous reply
being returned the visibility state of the page can change.
To fix the inconsistency we can set the creation parameters at the point that the
WebPageProxy is instantiated. This will result in a functional change that is web
visible, since the page will initially be opened in a hidden/blurred state, and may
later become visible/focussed. This change is consistent with the direction we want to
evolve in. Whilst we will still probably require a synchronous message from the
WebProcess to the UIProcess on Window.open, we'll probably make this return much earlier
– having just created the WebPageProxy, but avoiding blocking the WebProcess over the
client delegate callback that opens the new window.
This fix results in a layout test result change, due to the change in behavior (page is
created blurred, and becomes focussed, resulting in a focus event being fired – rather
than the window opening directly into a focussed state). This is reported as a
progression (test is broken in WebKit1, fixed in WebKit2 after this change). In reality
the test is actually slightly broken in DRT/test-runner – the test runs differently than
in browser, since there is is no visible main window. In-browser this patch results in
no change in behavior on dom/Window/mozilla-focus-blur.html (the affected test).
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
- call initializeCreationParameters
(WebKit::WebPageProxy::initializeCreationParameters):
- calculate m_creationParameters
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::creationParameters):
- Added m_creationParameters, initializeCreationParameters, creationParameters returns m_creationParameters
LayoutTests:
- platform/mac-wk2/fast/dom/Window: Added.
- platform/mac-wk2/fast/dom/Window/mozilla-focus-blur-expected.txt: Added.
- This test now reports a pass on WebKit2
- 10:41 AM Changeset in webkit [158368] by
-
- 4 edits in trunk/Source/WebCore
Pass an Element by reference to the PseudoElement constructor
https://bugs.webkit.org/show_bug.cgi?id=123576
Reviewed by Andreas Kling.
- dom/Element.cpp:
(WebCore::Element::createPseudoElementIfNeeded):
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::PseudoElement):
- dom/PseudoElement.h:
- 10:39 AM Changeset in webkit [158367] by
-
- 2 edits in trunk/Source/WebCore
Fix a mis-merge.
- WebCore.xcodeproj/project.pbxproj: Remove duplicate CryptoAlgorithmRegistryMac.cpp.
- 10:33 AM Changeset in webkit [158366] by
-
- 3 edits4 adds in trunk/Source/WebCore
Add bindings code for crypto algorithm dictionaries
https://bugs.webkit.org/show_bug.cgi?id=123476
Reviewed by Sam Weinig.
JSCryptoAlgorithmDictionary reads the Algorithm, much like JSDictionary does in
simpler cases. We should see about bringing them closer together (perhaps replacing
with autogenerated code).
- crypto/parameters: Added.
- crypto/parameters/CryptoAlgorithmHmacKeyParams.h: Added.
- crypto/parameters/CryptoAlgorithmHmacParams.h: Added.
Added a couple specific dictionaries as an example.
- WebCore.xcodeproj/project.pbxproj: Added JSCryptoAlgorithmDictionary.
- bindings/js/JSCryptoAlgorithmDictionary.cpp: Added.
(WebCore::JSCryptoAlgorithmDictionary::getAlgorithmIdentifier):
(WebCore::getHashAlgorithm):
(WebCore::createHmacParams):
(WebCore::createHmacKeyParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
- bindings/js/JSCryptoAlgorithmDictionary.h: Added.
- 10:26 AM Changeset in webkit [158365] by
-
- 49 edits in trunk/Source/WebCore
Pass ScriptExecutionContext by reference to from the bindings constructors
https://bugs.webkit.org/show_bug.cgi?id=123575
Reviewed by Andreas Kling.
Since we null check the ScriptExecutionContext before creating the c++ class,
we should be passing by reference.
- 10:17 AM Changeset in webkit [158364] by
-
- 2 edits in trunk/Source/WebCore
Paint the input tag of range type on WinCE port.
https://bugs.webkit.org/show_bug.cgi?id=123199
Patch by Zhuang Zhigang <zhuangzg@cn.fujitsu.com> on 2013-10-31
Reviewed by Brent Fulgham.
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::paintSliderTrack):
(WebCore::RenderThemeWinCE::paintSliderThumb):
- 10:13 AM Changeset in webkit [158363] by
-
- 2 edits7 adds in trunk/Source/WebCore
Add a crypto algorithm abstraction
https://bugs.webkit.org/show_bug.cgi?id=123474
Reviewed by Sam Weinig.
This works slightly differently than WebCrypto implies. We have separate classes
for algorithm and its parameters, while WebCrypto puts them in the same dictionary.
- WebCore.xcodeproj/project.pbxproj: Added new files.
- crypto/CryptoAlgorithm.cpp: Added. As most algorithms don't implement most
operations, default implementations just raise an exception.
- crypto/CryptoAlgorithm.h: Added.
- crypto/CryptoAlgorithmParameters.h: Added. Base class for numerous future parameter
dictionaries, such as HmacParams or HmacKeyParams.
- crypto/CryptoAlgorithmRegistry.cpp: Added.
- crypto/CryptoAlgorithmRegistry.h: Added.
The registry decouples universal bindings code from algorithms that may or may not
be implemented on each platform.
- crypto/mac: Added.
- crypto/mac/CryptoAlgorithmRegistryMac.cpp: Added.
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Algorithms implemented
on Mac will be registered by this function.
- 9:50 AM Changeset in webkit [158362] by
-
- 7 edits in trunk
REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and xmlhttprequest-overridemimetype-content-type-header.html are failing
https://bugs.webkit.org/show_bug.cgi?id=123548
Reviewed by Brady Eidson.
Source/WebCore:
We had code that made sure that cached 200 responses weren't used for conditional
requests. But it didn't work the other way - cached 304 responses got reused for
subsequent unconditional requests!
Adding the test uncovered this bug.
- loader/cache/CachedRawResource.cpp: (WebCore::shouldIgnoreHeaderForCacheReuse):
Should never ignore conditional headers. Code in determineRevalidationPolicy
was already undoing this for conditional requests, but we also shouldn't use
WebCore cache if it holds a 304 response to conditional request.
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::determineRevalidationPolicy):
Even though the changed code is only for raw resources, I think that we can never
get a conditional request here any more.
LayoutTests:
- TestExpectations: Unskip tests that used to be affected by response-empty-arraybuffer.html
- http/tests/xmlhttprequest/response-empty-arraybuffer-expected.txt:
- http/tests/xmlhttprequest/response-empty-arraybuffer.html:
Fix a stupid typo. This test actually fully passes.
- 9:28 AM Changeset in webkit [158361] by
-
- 4 edits in trunk/Source/WebCore
CryptoAlgorithmDescriptionBuilder should support producing nested algorithms
https://bugs.webkit.org/show_bug.cgi?id=123461
Reviewed by Darin Adler.
To add a nested algorithm, clone a builder with createEmptyClone(), fill it,
and add it using add().
- bindings/js/JSCryptoAlgorithmBuilder.h:
- crypto/CryptoAlgorithmDescriptionBuilder.h:
- bindings/js/JSCryptoAlgorithmBuilder.cpp:
(WebCore::JSCryptoAlgorithmBuilder::createEmptyClone):
(WebCore::JSCryptoAlgorithmBuilder::add): Keep VM in a local variable for marginally
better performance.
- 8:35 AM Changeset in webkit [158360] by
-
- 12 edits in trunk/Source
[WK2][GTK] enable-media-stream Setting
https://bugs.webkit.org/show_bug.cgi?id=123145
Reviewed by Anders Carlsson.
Source/WebCore:
- page/Settings.in: new mediaStreamEnabled setting.
Source/WebKit2:
- Shared/WebPreferencesStore.h: New MediaStreamEnabled boolean preference.
- UIProcess/API/C/WKPreferences.cpp: MediaStreamEnabled getter and
setter functions.
(WKPreferencesSetMediaStreamEnabled):
(WKPreferencesGetMediaStreamEnabled):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/API/gtk/WebKitSettings.cpp: Add a enable-media-stream
property to the GTK WebKitSettings class. It will act as a facade
to the MediaStreamEnabled preference.
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_media_stream):
(webkit_settings_set_enable_media_stream):
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings): Test enable-media-stream websetting.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Allow WKTR to override the MediaStreamEnabled preference.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Update MediaStreamEnabled
along with the other settings.
- 8:29 AM Changeset in webkit [158359] by
-
- 10 edits in trunk/Source/WebCore
Manage SVGPathByteStream through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=123467
Reviewed by Anders Carlsson.
Manage SVGPathByteStream objects through std::unique_ptr. Constructors for the class are made public
so std::make_unique can be used with the class.
- svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):
- svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::createPath):
- svg/SVGAnimatedType.h:
- svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::SVGPathByteStream): Takes a const Data object that's then copied.
(WebCore::SVGPathByteStream::copy): Made const.
- svg/SVGPathByteStreamBuilder.cpp: Remove an unnecessary include.
- svg/SVGPathByteStreamBuilder.h: Ditto.
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
- svg/SVGPathElement.h:
- svg/SVGPathUtilities.cpp:
(WebCore::appendSVGPathByteStreamFromSVGPathSeg):
(WebCore::addToSVGPathByteStream):
- 8:29 AM Changeset in webkit [158358] by
-
- 4 edits in trunk/LayoutTests
[EFL] Rebaselining after r158186
https://bugs.webkit.org/show_bug.cgi?id=123571
Unreviewed gardening.
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-10-31
- 7:07 AM Changeset in webkit [158357] by
-
- 2 edits in trunk/Source/WebCore
Removing m_maxDeadCapacity condition in fast path in MemoryCache::prune().
https://bugs.webkit.org/show_bug.cgi?id=115631
Patch by Marcin Bychawski <m.bychawski@samsung.com> on 2013-10-31
Reviewed by Brent Fulgham.
If the m_maxDeadSize and m_deadSize are both 0, the method unnecessairly tries to prune resources.
No new tests, covered by existing ones.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::prune):
- 5:02 AM Changeset in webkit [158356] by
-
- 6 edits in trunk/Source
Web Inspector: Remove stale optional native memory instrumentation protocol params
https://bugs.webkit.org/show_bug.cgi?id=123552
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
- inspector/InspectorTimelineAgent.h:
Source/WebInspectorUI:
- UserInterface/InspectorBackendCommands.js:
- 2:14 AM Changeset in webkit [158355] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Undefined references to RenderObject::style() when disabling video support
https://bugs.webkit.org/show_bug.cgi?id=123492
Reviewed by Carlos Garcia Campos.
- platform/gtk/RenderThemeGtk2.cpp: Disabling video support removes indirect inclusion of the RenderElement.h
header, causing undefined references to RenderObject::style(). The RenderElement.h header should be included
instead of RenderObject.h as the former defines the RenderObject::style() inline and also includes the latter.
- platform/gtk/RenderThemeGtk3.cpp: Ditto.
- 1:55 AM Changeset in webkit [158354] by
-
- 1 edit4 adds in trunk/LayoutTests
[EFL] Add baselines for spelling tests added in r157900.
Unreviewed gardening.
- platform/efl/editing/spelling/centering-misspelling-dots-expected.png: Added.
- platform/efl/editing/spelling/centering-misspelling-dots-expected.txt: Added.
- platform/efl/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.png: Added.
- platform/efl/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.txt: Added.
- 1:44 AM Changeset in webkit [158353] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Add 5 printing tests to EFL TestExpectations.
EFL port doesn't fully support printing functionality yet.
- platform/efl/TestExpectations:
- 1:38 AM Changeset in webkit [158352] by
-
- 5 edits in trunk
[EFL] accessibility/textbox-role-reports-selection.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112017
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-31
Reviewed by Mario Sanchez Prada.
Source/WebCore:
getSelectionOffsetsForObject() now returns proper start/end offsets for
selections "touching" the object's front border.
No new tests, covered by existing ones.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getSelectionOffsetsForObject):
LayoutTests:
Removed failure expectations.
- platform/efl-wk1/TestExpectations: The test is no longer failing.
- platform/efl-wk2/TestExpectations: The test is no longer failing.
- 12:11 AM Changeset in webkit [158351] by
-
- 8 edits in trunk
.: [EFL][GLES] OpenGL should be an optional
https://bugs.webkit.org/show_bug.cgi?id=123399
Reviewed by Noam Rosenthal.
- Source/cmake/OptionsEfl.cmake:
Refactor the check routine of GL dependencies to use OpenGL as optional.
Source/WebCore: [EFL][GLES] OpenGL should be optional
https://bugs.webkit.org/show_bug.cgi?id=123399
Reviewed by Noam Rosenthal.
- CMakeLists.txt: Make OpenGL dependencies as optional.
- PlatformEfl.cmake:
Move OpenGL macro to OptionsEfl.cmake and make Xcomposite and XRender as optional.
- platform/graphics/OpenGLESShims.h:
Removed GL_COLOR_ATTACHMENT0_EXT because it was added to gl2ext.h since r153064
- platform/graphics/surfaces/GraphicsSurfaceToken.h:
Removed wrong GLX guard.
(WebCore::GraphicsSurfaceToken::GraphicsSurfaceToken):
(WebCore::GraphicsSurfaceToken::operator!=):
(WebCore::GraphicsSurfaceToken::isValid):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
Removed unnecessary OpenGLShims.h
Oct 30, 2013:
- 11:41 PM Changeset in webkit [158350] by
-
- 30 edits in trunk/Source/WebCore
[webcore/editing] remove extra header includes from cpp files.
https://bugs.webkit.org/show_bug.cgi?id=123524
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-30
Reviewed by Ryosuke Niwa.
Removing redundant header files.
- editing/AlternativeTextController.cpp:
- editing/ApplyBlockElementCommand.cpp:
- editing/ApplyStyleCommand.cpp:
- editing/BreakBlockquoteCommand.cpp:
- editing/DeleteButton.cpp:
- editing/DeleteButtonController.cpp:
- editing/DeleteSelectionCommand.cpp:
- editing/DictationCommand.cpp:
- editing/EditCommand.cpp:
- editing/EditingStyle.cpp:
- editing/EditorCommand.cpp:
- editing/FrameSelection.cpp:
- editing/IndentOutdentCommand.cpp:
- editing/InsertLineBreakCommand.cpp:
- editing/InsertParagraphSeparatorCommand.cpp:
- editing/MarkupAccumulator.h:
- editing/RemoveFormatCommand.cpp:
- editing/RenderedPosition.cpp:
- editing/ReplaceSelectionCommand.cpp:
- editing/SpellChecker.cpp:
- editing/SpellingCorrectionCommand.cpp:
- editing/SurroundingText.cpp:
- editing/TextCheckingHelper.cpp:
- editing/TextIterator.cpp:
- editing/TypingCommand.cpp:
- editing/VisibleSelection.cpp:
- editing/VisibleUnits.cpp:
- editing/WrapContentsInDummySpanCommand.cpp:
- editing/htmlediting.cpp:
- 11:32 PM Changeset in webkit [158349] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r158299.
http://trac.webkit.org/changeset/158299
https://bugs.webkit.org/show_bug.cgi?id=123558
caused assertion failures in fast/canvas/canvas-color-
serialization.html and fast/forms/input-text-paste-
maxlength.html (Requested by rniwa on #webkit).
- wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty):
- 11:27 PM Changeset in webkit [158348] by
-
- 16 edits in trunk/Source
IDB Database versions are uint64_t, not int64_t
https://bugs.webkit.org/show_bug.cgi?id=123556
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/IDBPendingOpenCall.h:
(WebCore::IDBPendingOpenCall::create):
(WebCore::IDBPendingOpenCall::version):
(WebCore::IDBPendingOpenCall::IDBPendingOpenCall):
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::open):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::open):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:
(WebKit::WebProcessIDBDatabaseBackend::openConnection):
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
- 11:25 PM Changeset in webkit [158347] by
-
- 2 edits in trunk/Source/WebCore
[Gtk] Build is failing after r158317
https://bugs.webkit.org/show_bug.cgi?id=123544
Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-30
Reviewed by Alexey Proskuryakov.
No new tests since this just fixes the build.
- GNUmakefile.list.am: Add JSCryptoKey.cpp and JSCryptoKey.h
- 10:51 PM Changeset in webkit [158346] by
-
- 2 edits in trunk/Source/WebCore
Manage EllipsisBox objects with unique_ptr.
<https://webkit.org/b/123554>
Use smart pointers to store ellipsis boxes instead of new/delete.
Reviewed by Anders Carlsson.
- 10:37 PM Changeset in webkit [158345] by
-
- 2 edits2 adds in trunk/Source/WebCore
[Gtk] Build is failing after r158317
https://bugs.webkit.org/show_bug.cgi?id=123544
Use a correct style for JSC includes.
- ForwardingHeaders/runtime/JSPromise.h: Added.
- ForwardingHeaders/runtime/JSPromiseResolver.h: Added.
- bindings/js/JSDOMPromise.h:
- 10:02 PM Changeset in webkit [158344] by
-
- 2 edits in trunk/LayoutTests
Add two crash expectations per bug 123555.
- 9:15 PM Changeset in webkit [158343] by
-
- 15 edits in trunk/Source/WebCore
Replace InlineBox::destroy() with regular virtual destruction.
<https://webkit.org/b/123550>
Move logic out of destroy() and its overloads into good ol' virtual
destructors instead.
Reviewed by Anders Carlsson.
- 9:11 PM Changeset in webkit [158342] by
-
- 3 edits in trunk/Tools
Teach the style checker about ENUM_CLASS
https://bugs.webkit.org/show_bug.cgi?id=123528
Reviewed by Andy Estes.
- Scripts/webkitpy/style/checkers/cpp.py:
(_EnumState.process_clean_line): Make content of an ENUM_CLASS declaration
equivalent to enum content for checking.
(check_braces): Allow semicolon at the end.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(NoNonVirtualDestructorsTest.test_enum_casing):
(NoNonVirtualDestructorsTest.test_enum_trailing_semicolon):
(WebKitStyleTest.test_braces):
Test it.
- 8:52 PM Changeset in webkit [158341] by
-
- 4 edits in trunk/Source/JavaScriptCore
Assertion failure in js/dom/global-constructors-attributes-dedicated-worker.html
https://bugs.webkit.org/show_bug.cgi?id=123551
<rdar://problem/15356238>
Reviewed by Mark Hahnenberg.
WatchpointSets have always had this "fire everything on deletion" policy because it
seemed like a good fail-safe at the time I first implemented WatchpointSets. But
it's actually causing bugs rather than providing safety:
- Everyone who registers Watchpoints with WatchpointSets have separate mechanisms for either keeping the WatchpointSets alive or noticing when they are collected. So this wasn't actually providing any safety.
One example of this is Structures, where:
- CodeBlocks that register Watchpoints on Structure's WatchpointSet will also register weak references to the Structure, and the GC will jettison a CodeBlock if the Structure(s) it cares about dies.
- StructureStubInfos that register Watchpoints on Structure's WatchpointSet will also be cleared by GC if the Structures die.
- The WatchpointSet destructor would get invoked from finalization/destruction. This would then cause CodeBlock::jettison() to be called on a CodeBlock, but that method requires doing things that access heap objects. This would usually cause problems on VM destruction, since then the CodeBlocks would still be alive but the whole heap would be destroyed.
This also ensures that CodeBlock::jettison() cannot cause a GC. This is safe since
that method doesn't really allocate objects, and it is likely necessary because
jettison() may be called from deep in the stack.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::jettison):
- bytecode/Watchpoint.cpp:
(JSC::WatchpointSet::~WatchpointSet):
- bytecode/Watchpoint.h:
- 8:37 PM Changeset in webkit [158340] by
-
- 2 edits in trunk/Source/WebKit2
Fixed a potential race condition around the initializtion of WKObject’s target.
Reviewed by Mark Rowe.
- Shared/Cocoa/WKObject.mm:
(initializeTargetIfNeeded): Removed the early return if _target is non-nil. As Mark pointed
out, when stores are reordered relative to other stores, it is possible for the early return
to occur while the object _target is pointing to is not yet valid.
- 8:07 PM Changeset in webkit [158339] by
-
- 2 edits in trunk/Tools
kill-old-processes should kill Web Socket script
https://bugs.webkit.org/show_bug.cgi?id=123546
Reviewed by Benjamin Poulain.
- BuildSlaveSupport/kill-old-processes:
(main):
- 7:36 PM Changeset in webkit [158338] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and
xmlhttprequest-overridemimetype-content-type-header.html are failing
https://bugs.webkit.org/show_bug.cgi?id=123548
Add the failing test expectation.
- 6:15 PM Changeset in webkit [158337] by
-
- 7 edits in trunk/Source/WebCore
Simplifying MediaStream and MediStreamDescriptor creation
https://bugs.webkit.org/show_bug.cgi?id=123443
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-30
Reviewed by Eric Carlson.
The internal process of creating a MediaStream and MediaStreamDescriptor was quite confusing and spread.
We can take advantage of the platform implementation of MediaStreamTrack (aka MediaStreamTrackPrivate)
and simplify the whole process.
A new constructor that receives vectors of MediaStreamTrackPrivate objects were added, then the check
if a source already exists or if the tracks are all ended are now made in MediaStreamDescriptor.
No new tests needed.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create): Removed unnecessary variables in one create method and using new
MediaStreamDescriptor::create method that receives vector of MediaStreamTrackPrivate objects as parameter.
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): Removed passing flag to
MediaStreamDescriptor create.
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::create): Removed EndedAtCreationFlag parameter, because this is being
handled inside constructor by analyzing the tracks or sources passed.
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor): Adding new constructor that receives vector of
MediaStreamTrackPrivate as parameter.
(WebCore::MediaStreamDescriptor::addTrack): Changed to store the track's source in the object.
(WebCore::MediaStreamDescriptor::removeTrack):
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::numberOfAudioTracks):
(WebCore::MediaStreamDescriptor::audioTracks):
(WebCore::MediaStreamDescriptor::numberOfVideoTracks):
(WebCore::MediaStreamDescriptor::videoTracks):
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::MockMediaStreamCenter::createMediaStream): Removing flag that is being passed to
MediaStreamDescriptor's create method.
- 6:07 PM Changeset in webkit [158336] by
-
- 5 edits in trunk/Source
Versioning.
- 6:04 PM Changeset in webkit [158335] by
-
- 1 copy in tags/Safari-538.4
New Tag.
- 5:50 PM Changeset in webkit [158334] by
-
- 2 edits in trunk/Source/WebCore
[Win] Legible Output callbacks should happen on notification queue
https://bugs.webkit.org/show_bug.cgi?id=123545
Reviewed by Eric Carlson.
Modify the callback creation for Legible Output items so that they
are made on our notification queue. The use of the main queue was a
holdover from some temporary code used during earlier development.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::AVFWrapper): Assert this happens on the main thread.
(WebCore::AVFWrapper::~AVFWrapper): Ditto.
(WebCore::destroyAVFWrapper): Ditto.
(WebCore::AVFWrapper::createPlayer): Ditto.
(WebCore::AVFWrapper::createPlayerItem): Ditto.
Also, instruct LegibleOutput callbacks to happen on our notification
queue, rather than the main thread.
(WebCore::AVFWrapper::createAVCFVideoLayer): Assert this happens on the main thread.
(WebCore::AVFWrapper::destroyVideoLayer): Ditto.
(WebCore::AVFWrapper::createImageGenerator): Ditto.
(WebCore::AVFWrapper::destroyImageGenerator): Ditto.
- 5:32 PM Changeset in webkit [158333] by
-
- 3 edits2 adds in trunk
XHR.response is null when requesting empty file as arraybuffer
https://bugs.webkit.org/show_bug.cgi?id=123457
Source/WebCore:
Reviewed by Sam Weinig.
Test: http/tests/xmlhttprequest/response-empty-arraybuffer.html
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseArrayBuffer): Don't do this.
LayoutTests:
Based on a Blink test by yusukesuzuki@chromium.org.
Reviewed by Sam Weinig.
Failures in expected results appear to mean that Blink caches XHR responses in more
cases. It's not directly related to the patch.
- http/tests/xmlhttprequest/response-empty-arraybuffer-expected.txt: Added.
- http/tests/xmlhttprequest/response-empty-arraybuffer.html: Added.
- 5:31 PM Changeset in webkit [158332] by
-
- 3 edits2 adds in trunk
AX: AXFocused not exposed on ARIA menuitems
https://bugs.webkit.org/show_bug.cgi?id=123494
Reviewed by Chris Fleizach.
Source/WebCore:
ARIA menuitems should expose AXFocused accessibility attribute.
Test: platform/mac/accessibility/aria-menuitem-focus.html
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
Adding test to make sure ARIA menuitems expose each piece of their focus state correctly.
- platform/mac/accessibility/aria-menuitem-focus-expected.txt: Added.
- platform/mac/accessibility/aria-menuitem-focus.html: Added.
- 5:26 PM Changeset in webkit [158331] by
-
- 32 edits in trunk/Source/WebCore
Web Inspector: Remove basic uses of InspectorState from agents
https://bugs.webkit.org/show_bug.cgi?id=123534
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-30
Reviewed by Timothy Hatcher.
- inspector/InspectorAgent.h:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::disable):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::inspect):
InspectorAgentState::inspectorAgentEnabled -> m_enabled.
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::enable):
Remove unused state.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::disable):
(WebCore::InspectorCSSAgent::startSelectorProfiler):
(WebCore::InspectorCSSAgent::stopSelectorProfilerImpl):
Remove unused states. Make CSSAgentState::isSelectorProfiling check profile object exists or not.
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
Remove unused state, member variable already existed.
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::disable):
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
ConsoleAgentState::consoleMessagesEnabled already had m_enabled.
ConsoleAgentState::monitoringXHR -> m_monitoringXHREnabled.
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::clearFrontend):
(WebCore::InspectorDOMAgent::setDocument):
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
DOMAgentState::documentRequested -> m_documentRequested.
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
DOMDebuggerAgentState::pauseOnAllXHRs -> m_pauseOnAllXHRsEnabled.
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
DOMStorageAgentState::domStorageAgentEnabled -> m_enabled.
- inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
Remove unused state, m_enabled already existed.
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::enabled):
(WebCore::InspectorDebuggerAgent::clearFrontend):
(WebCore::InspectorDebuggerAgent::setPauseOnExceptionsImpl):
DebuggerAgentState::pauseOnExceptionsState removed, never read.
DebuggerAgentState::debuggerEnabled -> m_enabled.
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::clearFrontend):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
HeapProfilerAgentState::profileHeadersRequested -> m_profileHeadersRequested.
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
Remove unused state, never read.
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::enable):
(WebCore::InspectorLayerTreeAgent::disable):
Remove unused state, did not need to be read.
- inspector/InspectorPageAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::webViewResized):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::deviceMetricsChanged):
(WebCore::InspectorPageAgent::setShowPaintRects):
(WebCore::InspectorPageAgent::setShowDebugBorders):
(WebCore::InspectorPageAgent::setShowFPSCounter):
(WebCore::InspectorPageAgent::setContinuousPaintingEnabled):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
(WebCore::InspectorPageAgent::applyScreenWidthOverride):
(WebCore::InspectorPageAgent::applyScreenHeightOverride):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::updateTouchEventEmulationInPage):
(WebCore::InspectorPageAgent::setTouchEmulationEnabled):
(WebCore::InspectorPageAgent::setEmulatedMedia):
(WebCore::InspectorPageAgent::applyEmulatedMedia):
PageAgentState::pageAgentScreenWidthOverride -> m_screenWidthOverride.
PageAgentState::pageAgentScreenHeightOverride -> m_screenHeightOverride.
PageAgentState::pageAgentFontScaleFactorOverride -> m_fontScaleFactorOverride.
PageAgentState::pageAgentFitWindow -> m_fitWindowOverride.
PageAgentState::pageAgentShowPaintRects -> m_showPaintRects.
PageAgentState::pageAgentEmulatedMedia -> m_emulatedMedia.
Remove other unused states.
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::enable):
(WebCore::InspectorProfilerAgent::disable):
(WebCore::InspectorProfilerAgent::getProfileHeaders):
(WebCore::InspectorProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):
(WebCore::InspectorProfilerAgent::enabled):
ProfilerAgentState::profileHeadersRequested -> m_profileHeadersRequested.
Remove other unused states.
- inspector/InspectorResourceAgent.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::~InspectorResourceAgent):
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::applyUserAgentOverride):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setUserAgentOverride):
(WebCore::InspectorResourceAgent::setCacheDisabled):
(WebCore::InspectorResourceAgent::mainFrameNavigated):
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
ResourceAgentState::resourceAgentEnabled -> m_enabled.
ResourceAgentState::cacheDisabled -> m_cacheDisabled.
ResourceAgentState::userAgentOverride -> m_userAgentOverride (this already existed and was unused).
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
(WebCore::InspectorTimelineAgent::setDOMCounters):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
TimelineAgentState::timelineAgentEnabled -> m_enabled.
TimelineAgentState::includeDomCounters -> m_includeDOMCounters.
Remove other unused states.
- inspector/InspectorWorkerAgent.h:
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::enable):
(WebCore::InspectorWorkerAgent::disable):
(WebCore::InspectorWorkerAgent::setAutoconnectToWorkers):
(WebCore::InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart):
(WebCore::InspectorWorkerAgent::didStartWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
WorkerAgentState::workerInspectionEnabled -> m_enabled.
WorkerAgentState::autoconnectToWorkers -> m_shouldPauseDedicatedWorkerOnStart.
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::disable):
Remove unused state, not read.
- 5:14 PM Changeset in webkit [158330] by
-
- 24 edits in trunk/Source
Remove code for Mac Lion
https://bugs.webkit.org/show_bug.cgi?id=123542
Reviewed by Anders Carlsson.
Source/WebCore:
Removed the code for Mac OS X 10.7.
- platform/graphics/ImageBuffer.h:
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::context):
(WebCore::ImageBuffer::flushContext):
- platform/graphics/cg/ImageBufferDataCG.h:
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::imageSourceOptions):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::scrollAnimationEnabledForSystem):
- platform/mac/ScrollElasticityController.mm:
(WebCore::reboundDeltaForElasticDelta):
- platform/mac/ThemeMac.mm:
(WebCore::updateStates):
(WebCore::paintCheckbox):
(WebCore::paintRadio):
(WebCore::paintButton):
- platform/mac/WebCoreNSCellExtras.h:
- platform/mac/WebCoreNSCellExtras.m:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::textField):
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView attachRootLayer:]):
- WebView/WebView.mm:
Source/WebKit2:
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- UIProcess/API/mac/WKView.mm:
(-[WKView viewWillMoveToWindow:]):
- WebProcess/com.apple.WebProcess.sb.in:
Source/WTF:
- wtf/Platform.h:
- 4:59 PM Changeset in webkit [158329] by
-
- 5 edits in trunk/Tools
Set svn:ignore for .pyc files created for test-webkitpy.
- Scripts/webkitpy/layout_tests/reftests: Added property svn:ignore.
- Scripts/webkitpy/performance_tests: Added property svn:ignore.
- Scripts/webkitpy/to_be_moved: Added property svn:ignore.
- Scripts/webkitpy/w3c: Added property svn:ignore.
- 4:50 PM Changeset in webkit [158328] by
-
- 1 edit1 delete in trunk/LayoutTests
Delete the expected results for Lion.
Rubber-stamped by Anders Carlsson.
- platform/mac-lion: Removed.
- 4:48 PM Changeset in webkit [158327] by
-
- 5 edits63 adds in trunk/Source/WebKit
[iOS] Upstream Source/WebKit/ios/
https://bugs.webkit.org/show_bug.cgi?id=123470
Reviewed by Sam Weinig.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/ios:
- DefaultDelegates/WebDefaultFormDelegate.h: Added.
- DefaultDelegates/WebDefaultFormDelegate.m: Added.
- DefaultDelegates/WebDefaultFrameLoadDelegate.h: Added.
- DefaultDelegates/WebDefaultFrameLoadDelegate.m: Added.
- DefaultDelegates/WebDefaultResourceLoadDelegate.h: Added.
- DefaultDelegates/WebDefaultResourceLoadDelegate.m: Added.
- DefaultDelegates/WebDefaultUIKitDelegate.h: Added.
- DefaultDelegates/WebDefaultUIKitDelegate.m: Added.
- Misc/EmojiFallbackFontSelector.cpp: Added.
- Misc/EmojiFallbackFontSelector.h: Added.
- Misc/MemoryMeasure.h: Added.
- Misc/MemoryMeasure.mm: Added.
- Misc/WebGeolocationCoreLocationProvider.h: Added.
- Misc/WebGeolocationCoreLocationProvider.mm: Added.
- Misc/WebGeolocationProviderIOS.h: Added.
- Misc/WebGeolocationProviderIOS.mm: Added.
- Misc/WebNSStringDrawing.h: Added.
- Misc/WebNSStringDrawing.mm: Added.
- Misc/WebNSStringExtrasIOS.h: Added.
- Misc/WebNSStringExtrasIOS.m: Added.
- Misc/WebNSStringExtrasIPhone.h: Added.
- Misc/WebUIKitSupport.h: Added.
- Misc/WebUIKitSupport.mm: Added.
- Storage/WebSQLiteDatabaseTrackerClient.h: Added.
- Storage/WebSQLiteDatabaseTrackerClient.mm: Added.
- WebCoreSupport/PopupMenuIOS.h: Added.
- WebCoreSupport/PopupMenuIOS.mm: Added.
- WebCoreSupport/SearchPopupMenuIOS.cpp: Added.
- WebCoreSupport/SearchPopupMenuIOS.h: Added.
- WebCoreSupport/WebCaretChangeListener.h: Added.
- WebCoreSupport/WebChromeClientIOS.h: Added.
- WebCoreSupport/WebChromeClientIOS.mm: Added.
- WebCoreSupport/WebFixedPositionContent.h: Added.
- WebCoreSupport/WebFixedPositionContent.mm: Added.
- WebCoreSupport/WebFixedPositionContentInternal.h: Added.
- WebCoreSupport/WebFrameIOS.h: Added.
- WebCoreSupport/WebFrameIOS.mm: Added.
- WebCoreSupport/WebFrameIPhone.h: Added.
- WebCoreSupport/WebGeolocation.mm: Added.
- WebCoreSupport/WebGeolocationInternal.h: Added.
- WebCoreSupport/WebGeolocationPrivate.h: Added.
- WebCoreSupport/WebMIMETypeRegistry.h: Added.
- WebCoreSupport/WebMIMETypeRegistry.mm: Added.
- WebCoreSupport/WebSelectionRect.h: Added.
- WebCoreSupport/WebSelectionRect.m: Added.
- WebCoreSupport/WebVisiblePosition.h: Added.
- WebCoreSupport/WebVisiblePosition.mm: Added.
- WebCoreSupport/WebVisiblePositionInternal.h: Added.
- WebKit.iOS.exp: Added.
- WebView/WebFrameViewWAKCompatibility.m: Added.
- WebView/WebMailDelegate.h: Added.
- WebView/WebPDFViewIOS.h: Added.
- WebView/WebPDFViewIOS.mm: Added.
- WebView/WebPDFViewIPhone.h: Added.
- WebView/WebPDFViewPlaceholder.h: Added.
- WebView/WebPDFViewPlaceholder.mm: Added.
- WebView/WebPlainWhiteView.h: Added.
- WebView/WebPlainWhiteView.mm: Added.
- WebView/WebUIKitDelegate.h: Added.
Source/WebKit/mac:
- Configurations/WebKit.xcconfig: Excluded some iOS files from the Mac build.
- 4:43 PM Changeset in webkit [158326] by
-
- 7 edits in trunk
85 inspector tests asserting in DrawingAreaProxyImpl::updateAcceleratedCompositingMode()
when there is a stale WebKitTestRunner preference
https://bugs.webkit.org/show_bug.cgi?id=115115
Reviewed by Darin Adler.
Source/WebCore:
- page/Settings.cpp:
(WebCore::Settings::setMockScrollbarsEnabled):
(WebCore::Settings::setUsesOverlayScrollbars):
Added FIXMEs.
Tools:
Delete stale preferences on launch.
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize): Now that we don't have preferences stored from
the previous run, we need th reinstate them before creating a WKView. Not all preferences
can be applied to an existing view retroactively.
(WTR::TestController::resetPreferencesToConsistentValues): Split out of resetStateToConsistentValues,
because there is no injected bundle yet when calling this function from initialize().
- WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): Delete
the preferences.
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
Added some FIXMEs.
- 4:13 PM Changeset in webkit [158325] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the !WK_API_ENABLED Mac build.
- Shared/Cocoa/APIObject.mm:
- 3:49 PM Changeset in webkit [158324] by
-
- 13 edits7 adds2 deletes in trunk/Source/WebKit2
[Cocoa] Make all API objects have Cocoa wrappers, and delegate refcounting to those wrappers
https://bugs.webkit.org/show_bug.cgi?id=123394
Reviewed by Darin Adler.
All wrappers conform to a new WKObject protocol and contain the wrapped object inline.
APIObject-derived classes override operator new to call newObject, which allocates the
wrapper and returns a pointer to the inline API object.
There are three kinds of wrapper classes: (a) classes that inherit directly from NSObject
and implement their API by calling the wrapped object (example: WKBackForwardList),
(b) internal classes that inherit from a class cluster, and implement the primitive methods
of the class cluster by calling the wrapped object (example: WKNSArray), and (c) internal
classes that inerit from the new WKObject class, and proxy to an object of some public type,
which is created from the wrapped object (example: WKNSURL).
- Shared/APIObject.h:
(WebKit::APIObject::wrapper): Added this getter.
(WebKit::TypedAPIObject::operator new): Added override that calls newObject.
- Shared/Cocoa/APIObject.mm: Added.
(WebKit::APIObject::ref): Retains the wrapper.
(WebKit::APIObject::deref): Releases the wrapper. When the wrapper is deallocated, it calls
the API object destructor.
(WebKit::APIObject::newObject): Allocates the wrapper and returns a pointer to the API
object inside the wrapper.
- Shared/Cocoa/WKNSArray.h:
(WebKit::wrapper): Added. Returns an ImmutableArray’s wrapper as an NSArray.
Replaced the RefPtr<ImmutableArray> ivar with space for an ImmutableArray to live inside
the wrapper.
(-[WKNSArray dealloc]): Calls the ImmutableArray destructor.
(-[WKNSArray count]): Updated for ivar change.
(-[WKNSArray objectAtIndex:]): Ditto.
(-[WKNSArray _apiObject]): Returns the wrapped ImmutableArray.
- Shared/Cocoa/WKNSObjectExtras.h: Removed.
- Shared/Cocoa/WKNSObjectExtras.mm: Removed.
- Shared/Cocoa/WKNSString.h: Added.
- Shared/Cocoa/WKNSString.mm: Added.
(-[WKNSString _web_createTarget]): Override this WKObject method to create an NSString from
the WebString.
(-[WKNSString copyWithZone:]): Retains self.
- Shared/Cocoa/WKNSURL.h: Added.
- Shared/Cocoa/WKNSURL.mm: Added.
(-[WKNSURL _web_createTarget]): Override this WKObject method to create an NSURL from
the WebURL.
(-[WKNSURL copyWithZone:]): Retains self.
- Shared/Cocoa/WKObject.h: Added.
- Shared/Cocoa/WKObject.mm: Added.
(-[WKObject dealloc]): Calls the destructor of the wrapped object and releases the target
object.
(initializeTargetIfNeeded): Helper function. Tries to create the target exactly once.
(-[WKObject isEqual:]): NSObject override that creates and compares to the target
object if necessary.
(-[WKObject hash]): NSObject override that creates and hashes the target object if
there is one.
(-[WKObject isKindOfClass:]): NSObject override that delegates to the target object.
(-[WKObject isMemberOfClass:]): Ditto.
(-[WKObject respondsToSelector:]): NSObject override that creates the target object if
necessary and returns whether it or self responds to the selector.
(-[WKObject conformsToProtocol:]): Similarly for protocols.
(-[WKObject forwardingTargetForSelector:]): NSObject override that creates the target object
if necessary and returns it as the target.
(-[WKObject description]): NSObject override that creates the target object if necessary and
forwards to it.
(-[WKObject _web_createTarget]): Added. The base implementation returns nil.
(-[WKObject _apiObject]): Returns the wrapped object.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController backForwardList]): Changed to return the existing wrapper.
(didChangeBackForwardList): Changed to use existing wrappers.
Replaced the RefPtr<WebBackForwardList> ivar with space for a WebBackForwardList to live
inside the wrapper.
(-[WKBackForwardList dealloc]): Call the WebBackForwardList destructor.
(toWKBackForwardListItem): Changed to us the existing wrapper.
(-[WKBackForwardList currentItem]): Updated for ivar change.
(-[WKBackForwardList backItem]): Ditto.
(-[WKBackForwardList forwardItem]): Ditto.
(-[WKBackForwardList itemAtIndex:]): Ditto.
(-[WKBackForwardList backListCount]): Ditto.
(-[WKBackForwardList forwardListCount]): Ditto,
(-[WKBackForwardList backListWithLimit:]): Ditto, and also changed to use the
ImmutableArray’s existing wrapper.
(-[WKBackForwardList forwardListWithLimit:]): Ditto.
(-[WKBackForwardList _apiObject]): Returns the WebBackForwardListItem.
- UIProcess/Cocoa/WKBackForwardListInternal.h:
(WebKit::wrapper): Added. Returns a WebBackForwardList’s wrapper as a WKBackForwardList.
- UIProcess/Cocoa/WKBackForwardListItem.mm:
Replaced the RefPtr<WebBackForwardListItem> ivar with space for a WebBackForwardListItem to
live inside the wrapper.
(-[WKBackForwardListItem dealloc]): Call the WebBackForwardListItem destructor.
(-[WKBackForwardListItem URL]): Updated for ivar change, and changed to make an NSURL
directly instead of going through a wrapper.
(-[WKBackForwardListItem title]): Updated for ivar change, and changed to use
String’s operator NSString*.
(-[WKBackForwardListItem originalURL]): Updated for ivar change, and changed to make an
NSURL directly instead of going through a wrapper.
(-[WKBackForwardListItem _apiObject]): Returns the WebBackForwardListItem.
(-[WKBackForwardListItem _item]): Ditto.
- UIProcess/Cocoa/WKBackForwardListItemInternal.h:
(WebKit::wrapper): Added. Returns a WebBackForwardListItem’s wrapper as a
WKBackForwardListItem.
- UIProcess/WebColorPickerResultListenerProxy.h: Changed into a TypedAPIObject.
- UIProcess/WebFormSubmissionListenerProxy.h:
(WebKit::WebFormSubmissionListenerProxy::operator new): Override to call newObject.
- UIProcess/WebFramePolicyListenerProxy.h:
(WebKit::WebFramePolicyListenerProxy::operator new): Ditto.
- WebKit2.xcodeproj/project.pbxproj: Updated for file additions and removals.
- 3:47 PM Changeset in webkit [158323] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, fix C Loop LLINT build.
- bytecode/CodeBlockJettisoningWatchpoint.cpp:
(JSC::CodeBlockJettisoningWatchpoint::fireInternal):
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:
(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):
- 3:34 PM Changeset in webkit [158322] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, fix FTL build.
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- 3:27 PM Changeset in webkit [158321] by
-
- 24 edits in trunk/Source/WebCore
Take line boxes out of the arena.
<https://webkit.org/b/123533>
Stop arena-allocating line boxes so we can move forward on improving
render tree memory management. This will also allow more rendering
code to take advantage of malloc optimizations.
This will likely regress performance on some micro-benchmarks, but
it's something we want to do sooner rather than later so we have time
to restabilize it. All improvements to the simple line layout's
coverage will help with recouping whatever is regressed.
BiDi runs are the only remaining user of the arena now.
Reviewed by Antti Koivisto
- 3:17 PM Changeset in webkit [158320] by
-
- 39 edits in trunk/Source/WebCore
Web Inspector: Remove InspectorAgent::restore functionality
https://bugs.webkit.org/show_bug.cgi?id=123525
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-30
Reviewed by Timothy Hatcher.
Remove unused InspectorAgent restore functionality.
- inspector/InspectorApplicationCacheAgent.cpp:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorBaseAgent.cpp:
- inspector/InspectorBaseAgent.h:
- inspector/InspectorCSSAgent.cpp:
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCanvasAgent.cpp:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorConsoleAgent.cpp:
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDatabaseAgent.cpp:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorHeapProfilerAgent.cpp:
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorLayerTreeAgent.cpp:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorPageAgent.cpp:
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.cpp:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorTimelineAgent.cpp:
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.cpp:
- inspector/InspectorWorkerAgent.h:
- inspector/PageRuntimeAgent.cpp:
- inspector/PageRuntimeAgent.h:
- inspector/WorkerInspectorController.cpp:
- inspector/WorkerInspectorController.h:
- 3:12 PM Changeset in webkit [158319] by
-
- 3 edits in trunk/Tools
Try to fix the 32-bit build.
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
- 3:07 PM Changeset in webkit [158318] by
-
- 4 edits in trunk
REGRESSION(r158288): media/media-can-play-mpeg4-video.html fails
https://bugs.webkit.org/show_bug.cgi?id=123530
Reviewed by Eric Carlson.
Source/WebCore:
Lower case the mime type before passing it along to MediaPlayer.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::selectNextSourceChild):
LayoutTests:
- 3:05 PM Changeset in webkit [158317] by
-
- 10 edits1 copy1 add in trunk/Source
Add a way to fulfill promises from DOM code
https://bugs.webkit.org/show_bug.cgi?id=123466
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj: Make JSPromise.h and JSPromiseResolver.h
private headers for WebCore to use.
- runtime/JSPromise.h:
- runtime/JSPromiseResolver.h:
Export functions that JSDOMPromise will use.
Source/WebCore:
This is not perfect, as it strongly ties DOM code to JavaScript. In the future, we
can make it better e.g. by subclassing, so that only a base interface would be exposed.
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- bindings/js/JSBindingsAllInOne.cpp:
- WebCore.xcodeproj/project.pbxproj:
Added JSDOMPromise.
- bindings/js/JSDOMPromise.cpp: Added.
- bindings/js/JSDOMPromise.h: Added.
(WebCore::PromiseWrapper::create):
(WebCore::PromiseWrapper::fulfill): A random set of specializations that I needed
in WebCrypto code so far.
(WebCore::PromiseWrapper::reject): Ditto.
- 2:51 PM Changeset in webkit [158316] by
-
- 7 edits3 copies1 add in trunk
Begin fleshing out an API test for WKRemoteObjectRegistry
https://bugs.webkit.org/show_bug.cgi?id=123531
Reviewed by Andreas Kling.
Source/WebKit2:
- Shared/API/Cocoa/WKRemoteObjectInterface.h:
Add WK_API_CLASS annotation.
- Shared/API/Cocoa/WKRemoteObjectRegistry.h:
Add WK_API_CLASS annotation.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
Add a WebConnection ivar.
(-[WKRemoteObjectRegistry _initWithConnectionRef:]):
Add SPI to create an WKRemoteObjectRegistry object with an existing WKConnectionRef.
(-[WKRemoteObjectRegistry _handleMessageWithName:body:]):
Add SPI that will be used to process incoming messages from an existing WKConnectionRef.
- Shared/API/Cocoa/WKRemoteObjectRegistryPrivate.h: Added.
Add SPI header.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
Tools:
Add a very simple test that doesn't really test anything for now.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Added.
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Added.
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Added.
- 2:26 PM Changeset in webkit [158315] by
-
- 23 edits in trunk/Source/JavaScriptCore
Adjust CallFrameHeader's ReturnPC and CallFrame locations to match the native ABI .
https://bugs.webkit.org/show_bug.cgi?id=123444.
Reviewed by Geoffrey Garen.
- Introduced an explicit CallerFrameAndPC struct.
- A CallFrame is expected to start with a CallerFrameAndPC struct.
- The Register class no longer supports CallFrame* and Instruction*.
These hides the differences between JSVALUE32_64 and JSVALUE64 in
terms of managing the callerFrame() and returnPC() values.
- Convert all uses of JSStack::CallerFrame and JSStack::ReturnPC to go through CallFrame to access the appropriate values and offsets. CallFrame, in turn, will access the callerFrame and returnPC via the CallerFrameAndPC struct.
- InlineCallFrame will provide offsets for its callerFrame and returnPC. It will make use of CallFrame::callerFrameOffset() and CallerFrame::returnPCOffset() to compute these.
- bytecode/CodeOrigin.h:
(JSC::InlineCallFrame::callerFrameOffset):
(JSC::InlineCallFrame::returnPCOffset):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileExceptionHandlers):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::calleeFrameSlot):
(JSC::DFG::SpeculativeJIT::calleeArgumentSlot):
(JSC::DFG::SpeculativeJIT::calleeFrameTagSlot):
(JSC::DFG::SpeculativeJIT::calleeFramePayloadSlot):
(JSC::DFG::SpeculativeJIT::calleeArgumentTagSlot):
(JSC::DFG::SpeculativeJIT::calleeArgumentPayloadSlot):
- Prefixed all the above with callee since they apply to the callee frame.
(JSC::DFG::SpeculativeJIT::calleeFrameCallerFrame):
- Added to set the callerFrame pointer in the callee frame.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLink.cpp:
(JSC::FTL::compileEntry):
(JSC::FTL::link):
- interpreter/CallFrame.h:
(JSC::ExecState::callerFrame):
(JSC::ExecState::callerFrameOffset):
(JSC::ExecState::returnPC):
(JSC::ExecState::hasReturnPC):
(JSC::ExecState::clearReturnPC):
(JSC::ExecState::returnPCOffset):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setReturnPC):
(JSC::ExecState::callerFrameAndPC):
- interpreter/JSStack.h:
- interpreter/Register.h:
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitPutToCallFrameHeader):
- Convert to using storePtr() here and simplify the code.
(JSC::AssemblyHelpers::emitGetCallerFrameFromCallFrameHeaderPtr):
(JSC::AssemblyHelpers::emitPutCallerFrameToCallFrameHeader):
(JSC::AssemblyHelpers::emitGetReturnPCFromCallFrameHeaderPtr):
(JSC::AssemblyHelpers::emitPutReturnPCToCallFrameHeader):
- Helpers to emit gets/puts of the callerFrame and returnPC.
(JSC::AssemblyHelpers::addressForByteOffset):
- jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JITCall.cpp:
(JSC::JIT::compileCallEval):
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileOpCall):
- jit/JITInlines.h:
(JSC::JIT::unmap):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
- jit/JITOperations.cpp:
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnJSValue):
(JSC::SpecializedThunkJIT::returnDouble):
(JSC::SpecializedThunkJIT::returnInt32):
(JSC::SpecializedThunkJIT::returnJSCell):
- jit/ThunkGenerators.cpp:
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::slowPathFor):
(JSC::nativeForGenerator):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LowLevelInterpreter.asm:
- Updated offsets and asserts to match the new CallFrame layout.
- 2:16 PM Changeset in webkit [158314] by
-
- 3 edits4 adds in trunk
contentEditable deleting lists when list items are block level
https://bugs.webkit.org/show_bug.cgi?id=122602
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-30
Reviewed by Ryosuke Niwa.
Source/WebCore:
When listitems are styled with display:block/float then inserting paragraph
twice at end of listitem delete entire list. Generally when listitem is empty
then we delete the listitem on inserting paragraph. In this issue, on inserting
first paragraph one empty listitem is created, and on inserting second paragraph
we try to delete that empty listitem. but it misbehave becasue of incomplete
definition of htmlediting::isLisItem() and entire list is deleted.
htmlediting::isListItem() check only render object to decide whether it is
list or not, so if any LI element is block level then isListItem return false.
Now after this patch if parent of current node is list element then node is
treated as listItem.
Test: editing/execCommand/hit-enter-twice-atendof-block-styled-listitem.html
- editing/htmlediting.cpp:
(WebCore::isListItem): Modified condition to check if parent node is list;
LayoutTests:
Testcase: When listitem is styled with display:block then inserting
paragraph twice at the end of listitem should not remove entire list.
- editing/execCommand/hit-enter-twice-atendof-block-styled-listitem-expected.txt: Added.
- editing/execCommand/hit-enter-twice-atendof-block-styled-listitem.html: Added.
TestCase: When listitem is made of custom tag(<item>) and css(display:list-item)
then inserting paragraph twice at the end of listitem should not remove entire list.
- editing/execCommand/hit-enter-twice-atendof-custom-listitem-expected.txt: Added.
- editing/execCommand/hit-enter-twice-atendof-custom-listitem.html: Added.
- 1:59 PM Changeset in webkit [158313] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix Mac.
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::RegisterAllocationOffset::checkOffsets):
(JSC::AbstractMacroAssembler::checkRegisterAllocationAgainstBranchRange):
- 1:57 PM Changeset in webkit [158312] by
-
- 3 edits in trunk/LayoutTests
Add a failing test expectation on media/media-can-play-mpeg4-video.html after r158288.
The failure is tracked by the bug 123530.
Also rebaseline Mountain Lion results.
- TestExpectations:
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- 1:51 PM Changeset in webkit [158311] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed. Update NEWS and Versions.m4 for 2.3.1 release.
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-10-29
- Source/autotools/Versions.m4: Bump version numbers.
- 1:40 PM Changeset in webkit [158310] by
-
- 7 edits in trunk/Source
Let Page::renderTreeSize() be the number of renderers.
<https://webkit.org/b/123518>
<rdar://problem/15348679>
The old metric was "number of bytes allocated in RenderArena" and
that was heading towards obsolescence, fast.
Instead, keep a count of RenderObjects instantiated on RenderView.
While a bit ugly, this lets us move forward with rendering memory
model improvements without breaking features.
Reviewed by Beth Dakin.
- 1:32 PM Changeset in webkit [158309] by
-
- 8 edits in trunk/Source
WebKit/win/WebKitGraphics.h:void WebDrawText(WebTextRenderInfo*); is never called
https://bugs.webkit.org/show_bug.cgi?id=123485
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-30
Reviewed by Brent Fulgham.
Source/WebCore:
WebDrawText is the only caller of WebCoreDrawTextAtPoint, so we can
delete that as well.
Because there is no behavior difference, no new tests are necessary.
- platform/win/WebCoreTextRenderer.cpp:
- platform/win/WebCoreTextRenderer.h:
Source/WebKit:
Deleting the function
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
Removed unused WebDrawText implementation.
- WebKitGraphics.cpp:
- WebKitGraphics.h:
- 1:22 PM Changeset in webkit [158308] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix Windows.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::jettison):
- 1:14 PM Changeset in webkit [158307] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix Windows.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addFrequentExitSite):
- 1:13 PM Changeset in webkit [158306] by
-
- 2 edits in trunk/Tools
Remove unnecessary touch
Rubber stamped by Mark Hahnenberg.
- Scripts/run-jsc-stress-tests:
- 1:03 PM Changeset in webkit [158305] by
-
- 3 edits in trunk/Tools
AX: Add Samuel White to accessibility watchlist cc rules
https://bugs.webkit.org/show_bug.cgi?id=123515
Reviewed by Chris Fleizach.
Adding myself and jcraig@apple.com (per his request) to the accessibility watchlist. Also
updating contributors.json with permission from bweinstein@apple.com to make this possible.
- Scripts/webkitpy/common/config/contributors.json:
- Scripts/webkitpy/common/config/watchlist:
- 12:58 PM Changeset in webkit [158304] by
-
- 35 edits10 adds2 deletes in trunk/Source/JavaScriptCore
Add InvalidationPoints to the DFG and use them for all watchpoints
https://bugs.webkit.org/show_bug.cgi?id=123472
Reviewed by Mark Hahnenberg.
This makes a fundamental change to how watchpoints work in the DFG.
Previously, a watchpoint was an instruction whose execution semantics were something
like:
if (watchpoint->invalidated)
exit
We would implement this without any branch by using jump replacement.
This is a very good optimization. But it's a bit awkward once you get a lot of
watchpoints: semantically we will have lots of these branches in the code, which the
compiler needs to reason about even though they don't actually result in any emitted
code.
Separately, we also had a mechanism for jettisoning a CodeBlock. This mechanism would
be invoked if a CodeBlock exited a lot. It would ensure that a CodeBlock wouldn't be
called into again, but it would do nothing for CodeBlocks that were already on the
stack.
This change flips jettisoning and watchpoint invalidation on their heads. Now, the jump
replacement has nothing to do with watchpoints; instead it's something that happens if
you ever jettison a CodeBlock. Jump replacement is now an all-or-nothing operation over
all of the potential call-return safe-exit-points in a CodeBlock. We call these
"InvalidationPoint"s. A watchpoint instruction is now "lowered" by having the DFG
collect all of the watchpoint sets that the CodeBlock cares about, and then registering
a CodeBlockJettisoningWatchpoint with all of them. That is, if the watchpoint fires, it
jettisons the CodeBlock, which in turn ensures that the CodeBlock can't be called into
(because the entrypoint now points to baseline code) and can't be returned into
(because returning exits to baseline before the next bytecode instruction).
This will allow for a sensible lowering of watchpoints to LLVM IR. It will also allow
for jettison() to be used effectively for things like breakpointing and single-stepping
in the debugger.
Well, basically, this mechanism just takes us into the HotSpot-style world where anyone
can, at any time and for any reason, request that an optimized CodeBlock is rendered
immediately invalid. You can use this for many cool things, I'm sure.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::jettison):
- bytecode/CodeBlock.h:
- bytecode/CodeBlockJettisoningWatchpoint.cpp: Added.
(JSC::CodeBlockJettisoningWatchpoint::fireInternal):
- bytecode/CodeBlockJettisoningWatchpoint.h: Added.
(JSC::CodeBlockJettisoningWatchpoint::CodeBlockJettisoningWatchpoint):
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
- bytecode/ExitKind.h:
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp: Added.
(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.h: Added.
(JSC::ProfiledCodeBlockJettisoningWatchpoint::ProfiledCodeBlockJettisoningWatchpoint):
- dfg/DFGAbstractHeap.h:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGClobberize.cpp:
(JSC::DFG::writesOverlap):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
(JSC::DFG::AbstractHeapOverlaps::AbstractHeapOverlaps):
(JSC::DFG::AbstractHeapOverlaps::operator()):
(JSC::DFG::AbstractHeapOverlaps::result):
- dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::invalidate):
- dfg/DFGCommonData.h:
(JSC::DFG::CommonData::CommonData):
- dfg/DFGDesiredWatchpoints.cpp:
(JSC::DFG::DesiredWatchpoints::addLazily):
(JSC::DFG::DesiredWatchpoints::reallyAdd):
- dfg/DFGDesiredWatchpoints.h:
(JSC::DFG::WatchpointForGenericWatchpointSet::WatchpointForGenericWatchpointSet):
(JSC::DFG::GenericDesiredWatchpoints::addLazily):
(JSC::DFG::GenericDesiredWatchpoints::reallyAdd):
(JSC::DFG::GenericDesiredWatchpoints::areStillValid):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGInvalidationPointInjectionPhase.cpp: Added.
(JSC::DFG::InvalidationPointInjectionPhase::InvalidationPointInjectionPhase):
(JSC::DFG::InvalidationPointInjectionPhase::run):
(JSC::DFG::InvalidationPointInjectionPhase::handle):
(JSC::DFG::InvalidationPointInjectionPhase::insertInvalidationCheck):
(JSC::DFG::performInvalidationPointInjection):
- dfg/DFGInvalidationPointInjectionPhase.h: Added.
- dfg/DFGJITCode.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
- dfg/DFGJumpReplacement.cpp: Added.
(JSC::DFG::JumpReplacement::fire):
- dfg/DFGJumpReplacement.h: Added.
(JSC::DFG::JumpReplacement::JumpReplacement):
- dfg/DFGNodeType.h:
- dfg/DFGOSRExitCompilationInfo.h:
- dfg/DFGOperations.cpp:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::reallyAdd):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitInvalidationPoint):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGWatchpointCollectionPhase.cpp: Added.
(JSC::DFG::WatchpointCollectionPhase::WatchpointCollectionPhase):
(JSC::DFG::WatchpointCollectionPhase::run):
(JSC::DFG::WatchpointCollectionPhase::handle):
(JSC::DFG::WatchpointCollectionPhase::handleEdge):
(JSC::DFG::WatchpointCollectionPhase::handleMasqueradesAsUndefined):
(JSC::DFG::WatchpointCollectionPhase::handleStringGetByVal):
(JSC::DFG::WatchpointCollectionPhase::addLazily):
(JSC::DFG::WatchpointCollectionPhase::globalObject):
(JSC::DFG::performWatchpointCollection):
- dfg/DFGWatchpointCollectionPhase.h: Added.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileGlobalVarWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):
- jit/JITOperations.cpp:
- jit/JumpReplacementWatchpoint.cpp: Removed.
- jit/JumpReplacementWatchpoint.h: Removed.
- 12:16 PM Changeset in webkit [158303] by
-
- 3 edits in trunk/Source/WebCore
URTBF after r158289.
- CMakeLists.txt:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::createCursorBackend):
- 12:10 PM Changeset in webkit [158302] by
-
- 3 edits in trunk/Tools
[WIN] Add executable entry points to DRT and WinLauncher
https://bugs.webkit.org/show_bug.cgi?id=121837
Reviewed by Brent Fulgham.
This allows to compile and run the executables without DLLLauncher.
- DumpRenderTree/win/DumpRenderTree.cpp:
(main):
(dllLauncherEntryPoint):
- WinLauncher/WinLauncher.cpp:
(wWinMain):
(dllLauncherEntryPoint):
- 12:10 PM Changeset in webkit [158301] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests should handle ".." in paths and "slow!" in cmd's
https://bugs.webkit.org/show_bug.cgi?id=123521
Reviewed by Mark Hahnenberg.
- Scripts/run-jsc-stress-tests:
- 12:07 PM Changeset in webkit [158300] by
-
- 2 edits in trunk/Source/WebCore
Build fails with EGLConfigSelector.cpp when OpenGL ES is not used
https://bugs.webkit.org/show_bug.cgi?id=119037
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-10-30
Reviewed by Brent Fulgham.
Build fix for EGLConfigSelector.cpp
No new tests, no behavior change.
- platform/graphics/surfaces/egl/EGLConfigSelector.cpp:
(WebCore::EGLConfigSelector::createConfig):
- 12:03 PM Changeset in webkit [158299] by
-
- 2 edits in trunk/Source/WTF
Remove PCRE workaround.
https://bugs.webkit.org/show_bug.cgi?id=123265
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-10-30
Reviewed by Brent Fulgham.
- wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty):
- 12:02 PM Changeset in webkit [158298] by
-
- 2 edits in trunk/LayoutTests
Add a flaky test expectation to media/track/track-in-band-legacy-api.html
The failure is tracked by the bug 123522.
- platform/mac/TestExpectations:
- 11:59 AM Changeset in webkit [158297] by
-
- 2 edits in trunk/Source/WebKit2
Remote Layer Tree: Lots of ASSERT(m_children.isEmpty()); on Poster Circle
https://bugs.webkit.org/show_bug.cgi?id=123517
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::setSublayers):
When setting our list of sublayers, remove all of the new layers from
their parents first.
- 11:56 AM Changeset in webkit [158296] by
-
- 2 edits in trunk/Source/WebCore
Explicitly initialize base class in MediStreamTrackPrivate copy constructor
https://bugs.webkit.org/show_bug.cgi?id=123473
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-30
Reviewed by Eric Carlson.
No new tests needed.
Ports that enable -Werror=extra must do that to compile.
- platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
- 11:52 AM Changeset in webkit [158295] by
-
- 2 edits in trunk/Source/WebCore
Mac build fix after r158291.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
- 11:49 AM Changeset in webkit [158294] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r158243.
http://trac.webkit.org/changeset/158243
https://bugs.webkit.org/show_bug.cgi?id=123520
Change was wrong (Requested by smfr on #webkit).
- platform/graphics/GraphicsContext.h:
- platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::drawLineForText):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForText):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLineForText):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawLineForText):
- platform/win/WebCoreTextRenderer.cpp:
(WebCore::doDrawTextAtPoint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintCompositionUnderline):
- 11:31 AM Changeset in webkit [158293] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added missing 32-bit and 64-bit linker symbols.
- 11:22 AM Changeset in webkit [158292] by
-
- 2 edits in trunk/Source/WebCore
Favicons are flipped in vertical direction in WinCairo builds.
https://bugs.webkit.org/show_bug.cgi?id=102077
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-30
Reviewed by Brent Fulgham.
- platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
- 11:18 AM Changeset in webkit [158291] by
-
- 9 edits in trunk/Source/WebCore
[MSE] Add MediaSource compatable loading functions to MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=123353
Reviewed by Eric Carlson.
Add methods to MediaPlayer to allow it to select the correct MediaPlayerFactory
when attempting to load a MediaSource URL.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::addSourceBuffer):
(WebCore::MediaSource::isTypeSupported):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::selectNextSourceChild):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::supportsType):
- platform/graphics/MediaPlayer.h:
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
Remove the isSupportedMediaSourceMIMEType() method:
- platform/MIMETypeRegistry.h:
- platform/efl/MIMETypeRegistryEfl.cpp:
- platform/mac/MIMETypeRegistryMac.mm:
- 11:04 AM Changeset in webkit [158290] by
-
- 2 edits in trunk/Tools
Mavericks: 128 tests are failing due to pixel differences
https://bugs.webkit.org/show_bug.cgi?id=123488
Reviewed by Simon Fraser.
Apple font preferences cannot be fully reset after they've been read, so we
need to set them using CFPreferences before initializing NSApplication.
In theory, this should be an issue on WebKit2 as well, but somehow it doesn't
appear to be. I guess we can figure out the reasons for this difference when/if
any observable problems start to occur.
- DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting): Only set defaults here, move other work
to prepareConsistentTestingEnvironment().
(main): Call setDefaultsToConsistentValuesForTesting before [NSApplication sharedApplication]
(which is unnecessary anyway since NSUserDefaults will implicitly call it, but seems
useful to keep in case we change out approach to defaults again).
- 11:02 AM Changeset in webkit [158289] by
-
- 7 edits2 moves in trunk/Source/WebCore
Unreviewed. Update NEWS and Versions.m4 for 2.3.1 release.
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-10-29
- Source/autotools/Versions.m4: Bump version numbers.
- 11:01 AM Changeset in webkit [158288] by
-
- 10 edits9 deletes in trunk
[MSE] Remove legacy Media Source APIs (WebKitMediaSource, WebKitSourceBuffer, WebKitSourceBufferList)
https://bugs.webkit.org/show_bug.cgi?id=123463
Reviewed by Eric Carlson.
Source/WebCore:
No new tests; updated test results.
Remove all reference to WebKitMediaSource, WebKitSourceBuffer, and WebKitSourceBufferList.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.list.am:
- Modules/mediasource/DOMURLMediaSource.idl:
- Modules/mediasource/WebKitMediaSource.cpp: Removed.
- Modules/mediasource/WebKitMediaSource.h: Removed.
- Modules/mediasource/WebKitMediaSource.idl: Removed.
- Modules/mediasource/WebKitSourceBuffer.cpp: Removed.
- Modules/mediasource/WebKitSourceBuffer.h: Removed.
- Modules/mediasource/WebKitSourceBuffer.idl: Removed.
- Modules/mediasource/WebKitSourceBufferList.cpp: Removed.
- Modules/mediasource/WebKitSourceBufferList.h: Removed.
- Modules/mediasource/WebKitSourceBufferList.idl: Removed.
- WebCore.xcodeproj/project.pbxproj:
- dom/EventTargetFactory.in:
LayoutTests:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 10:58 AM Changeset in webkit [158287] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix PrettyPrinting Tool Load from Saved URL
Reviewed by Timothy Hatcher.
- Tools/PrettyPrinting/index.html:
- 10:58 AM Changeset in webkit [158286] by
-
- 5 edits in trunk/Source/JavaScriptCore
JSExport doesn't support constructors
https://bugs.webkit.org/show_bug.cgi?id=123380
Reviewed by Geoffrey Garen.
Support for constructor-style callbacks for the Objective-C API to JSC is currently limited to
Objective-C blocks. Any clients who try to call the constructor of a JSExport-ed Objective-C class
are met with a type error stating that it cannot be called as a constructor.
It would be nice to expand JSExport's functionality to support this idiom. It is a natural
extension to JSExport and would increase the expressiveness and simplicity in both Objective-C and
JavaScript client code.
The way we'll do this is to expand the capabilities of ObjCCallbackFunction and associated classes.
Instead of constructing a normal C API object for the constructor, we'll instead allocate a full-blown
ObjCCallbackFunction object which can already properly handle being invoked as a constructor.
- API/JSWrapperMap.mm:
(copyMethodsToObject):
(allocateConstructorForCustomClass):
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]):
(tryUnwrapObjcObject):
- API/ObjCCallbackFunction.h:
(JSC::ObjCCallbackFunction::impl):
- API/ObjCCallbackFunction.mm:
(JSC::ObjCCallbackFunctionImpl::ObjCCallbackFunctionImpl):
(JSC::ObjCCallbackFunctionImpl::wrappedConstructor):
(JSC::ObjCCallbackFunctionImpl::isConstructible):
(JSC::ObjCCallbackFunction::getConstructData):
(JSC::ObjCCallbackFunctionImpl::name):
(JSC::ObjCCallbackFunctionImpl::call):
(objCCallbackFunctionForInvocation):
(objCCallbackFunctionForInit):
(tryUnwrapConstructor):
- API/tests/testapi.mm:
(-[TextXYZ initWithString:]):
(-[ClassA initWithA:]):
(-[ClassB initWithA:b:]):
(-[ClassC initWithA:]):
(-[ClassC initWithA:b:]):
- 10:55 AM Changeset in webkit [158285] by
-
- 2 edits in trunk/Source/WebCore
Unbreak the release build.
- rendering/SimpleLineLayoutFunctions.cpp:
- 10:54 AM Changeset in webkit [158284] by
-
- 2 edits in trunk/LayoutTests
A WebGL test times out sometimes.
- platform/mac/TestExpectations:
- 10:53 AM Changeset in webkit [158283] by
-
- 3 edits in trunk/Tools
Teach the style checker how to handle Objective-C categories and NS_ENUM
https://bugs.webkit.org/show_bug.cgi?id=123482
Reviewed by Dan Bernstein.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing_for_function_call): Allow a space before '(' in a line
starting with @interface or @implementation, since this is defining an
Objective-C category rather than a function.
(check_braces): The opening brace of an NS_ENUM should not be on its
own line.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests.
- 10:49 AM Changeset in webkit [158282] by
-
- 10 edits1 add in trunk/Source
[Win] Compile errors when enabling DFG JIT.
https://bugs.webkit.org/show_bug.cgi?id=120998
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-30
Reviewed by Brent Fulgham.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Added files.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
- dfg/DFGAllocator.h: Removed scope.
- dfg/DFGWorklist.cpp: Use new ThreadingOnce class instead of pthread_once.
(JSC::DFG::globalWorklist):
- heap/DeferGC.h: Link fix, member needs to be public.
- jit/JITOperationWrappers.h: Added required assembler macros.
Source/WTF:
- wtf/CompilationThread.cpp: Use new ThreadingOnce class instead of pthread_once.
(WTF::initializeCompilationThreads):
- wtf/ThreadingOnce.h: Added ThreadingOnce class encapsulating pthread_once functionality.
(WTF::ThreadingOnce::ThreadingOnce):
(WTF::ThreadingOnce::~ThreadingOnce):
(WTF::ThreadingOnce::callOnce):
- wtf/text/CString.h: Export needed symbols.
- 10:47 AM Changeset in webkit [158281] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add result caching for Math.cos
https://bugs.webkit.org/show_bug.cgi?id=123255
Patch by Iago Toral Quiroga <itoral@igalia.com> on 2013-10-30
Reviewed by Brent Fulgham.
- runtime/MathObject.cpp:
(JSC::mathProtoFuncCos):
- runtime/VM.h:
- 10:44 AM Changeset in webkit [158280] by
-
- 2 edits in trunk/Source/WebCore
Fix memory leaks in platform/image-encoders/JPEGImageEncoder.cpp
https://bugs.webkit.org/show_bug.cgi?id=118781
Patch by Liangjun Zeng <lizeng@blackberry.com> on 2013-10-30
Reviewed by Brent Fulgham.
We can find the function "jpeg_finish_compress" call the function "jpeg_abort" at the end.
And the comments of "jpeg_abort" is "Abort processing of a JPEG compression operation,
but don't destroy the object itself". (We can find these in the "jcapimin.c" of jpeg)
So the compression object destroy need be called.
No new tests because this doesn't change functionality.
- platform/image-encoders/JPEGImageEncoder.cpp:
(WebCore::compressRGBABigEndianToJPEG):
- 10:40 AM Changeset in webkit [158279] by
-
- 10 edits in trunk/Source
Add debug settings for simple line layout
https://bugs.webkit.org/show_bug.cgi?id=123514
Source/WebCore:
Reviewed by Andreas Kling.
- WebCore.exp.in:
- page/Settings.in:
Add simpleLineLayoutEnabled and simpleLineLayoutDebugBordersEnabled.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintDebugBorders):
(WebCore::SimpleLineLayout::paintFlow):
Source/WebKit2:
Reviewed by Andreas Kling.
Expose debug settings.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSimpleLineLayoutEnabled):
(WKPreferencesGetSimpleLineLayoutEnabled):
(WKPreferencesSetSimpleLineLayoutDebugBordersEnabled):
(WKPreferencesGetSimpleLineLayoutDebugBordersEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 10:33 AM Changeset in webkit [158278] by
-
- 2 edits in trunk/Source/WebKit/win
[WIN] Add missing USE(CFNETWORK) to WebError.h
https://bugs.webkit.org/show_bug.cgi?id=121834
Reviewed by Brent Fulgham.
WebError.cpp uses USE(CFNETWORK), so add it to the header too.
- WebError.h:
- 10:31 AM Changeset in webkit [158277] by
-
- 2 edits in trunk/Source/WebCore
[Curl] Cookies are sometimes not set in download request.
https://bugs.webkit.org/show_bug.cgi?id=123445
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-30
Reviewed by Brent Fulgham.
Sometimes cookies are not set in the download request because the cookie file cannot be opened,
it's already been opened by the ResourceHandleManager for writing.
This can be fixed by getting the cookie list from the share handle in ResourceHandleManager instead.
This will also improve performance, as there is no need to read and parse the cookie file for each download.
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::init): Use share handle to get cookie list.
- 10:29 AM Changeset in webkit [158276] by
-
- 2 edits in trunk/Source/WebKit/win
[Curl][Win] Suggested filename of download is not url decoded.
https://bugs.webkit.org/show_bug.cgi?id=123511
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-30
Reviewed by Brent Fulgham.
- WebDownloadCurl.cpp:
(WebDownload::didReceiveResponse): Url decode suggested filename.
- 10:21 AM Changeset in webkit [158275] by
-
- 3 edits in trunk/Source/WebCore
Unguard Element::childShouldCreateRenderer
https://bugs.webkit.org/show_bug.cgi?id=123496
Reviewed by Andreas Kling.
Make Element::childShouldCreateRenderer normally accessible. Guarding it with flags
just leaves potential build issues.
No new tests since no functionality changed.
- dom/Element.cpp:
(WebCore::Element::childShouldCreateRenderer):
- dom/Element.h:
- 9:44 AM Changeset in webkit [158274] by
-
- 2 edits4 adds in trunk/Source/WebKit2
Add stubbed out WKRemoteObjectRegistry class
https://bugs.webkit.org/show_bug.cgi?id=123512
Reviewed by Andreas Kling.
Also add a WKRemoteObjectInterface class that represents a remote object interface.
- Shared/API/Cocoa/WKRemoteObjectInterface.h: Added.
- Shared/API/Cocoa/WKRemoteObjectInterface.mm: Added.
(-[WKRemoteObjectInterface initWithProtocol:identifier:]):
(+[WKRemoteObjectInterface remoteObjectInterfaceWithProtocol:]):
- Shared/API/Cocoa/WKRemoteObjectRegistry.h: Added.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm: Added.
(-[WKRemoteObjectRegistry registerExportedObject:interface:]):
(-[WKRemoteObjectRegistry unregisterExportedObject:interface:]):
(-[WKRemoteObjectRegistry remoteObjectProxyWithInterface:]):
- WebKit2.xcodeproj/project.pbxproj:
- 9:06 AM Changeset in webkit [158273] by
-
- 6 edits in trunk
[EFL] accessibility/textarea-selected-text-range.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112016
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-30
Reviewed by Mario Sanchez Prada.
Tools:
Provided implementation for AccessibilityUIElement::selectedTextRange() and
AccessibilityUIElement::setSelectedTextRange().
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::selectedTextRange): Implemented.
(AccessibilityUIElement::setSelectedTextRange): Implemented
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::selectedTextRange): Implemented.
(WTR::AccessibilityUIElement::setSelectedTextRange): Implemented.
LayoutTests:
Removed failure expectations.
- platform/efl-wk1/TestExpectations: The test is no longer failing.
- platform/efl-wk2/TestExpectations: The test is no longer failing.
- 9:05 AM Changeset in webkit [158272] by
-
- 6 edits in trunk/Source
Disabled JIT on Win64.
https://bugs.webkit.org/show_bug.cgi?id=122472
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
Disabled building JITStubsMSVC64.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added missing 64-bit linker symbol.
Source/WTF:
- wtf/Platform.h:
Disabled JIT on Win64.
- 9:01 AM Changeset in webkit [158271] by
-
- 3 edits1 add in trunk/LayoutTests
[EFL] accessibility/svg-remote-element.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112013
Unreviewed EFL gardening. Passes after r158267.
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-30
- platform/efl-wk1/TestExpectations: The test is no longer failing.
- platform/efl-wk2/TestExpectations: The test is no longer failing.
- platform/efl/accessibility/svg-remote-element-expected.txt: Added.
- 8:53 AM Changeset in webkit [158270] by
-
- 12 edits in trunk/Source/WebCore
[MSE] Make MediaSourcePrivate, SourceBufferPrivate classes RefCounted.
https://bugs.webkit.org/show_bug.cgi?id=123350
Reviewed by Darin Adler.
Make the MediaSourcePrivate and SourceBufferPrivate classes RefCounted so that
they can be referenced both by MediaSource/SourceBuffer, and by the MediaPlayerPrivate
which creates them.
Change OwnPtr -> RefPtr everywhere:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::addSourceBuffer):
- Modules/mediasource/MediaSourceBase.cpp:
(WebCore::MediaSourceBase::setPrivateAndOpen):
(WebCore::MediaSourceBase::createSourceBufferPrivate):
- Modules/mediasource/MediaSourceBase.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::create):
(WebCore::SourceBuffer::SourceBuffer):
- Modules/mediasource/SourceBuffer.h:
- Modules/mediasource/WebKitMediaSource.cpp:
(WebCore::WebKitMediaSource::addSourceBuffer):
- Modules/mediasource/WebKitSourceBuffer.cpp:
(WebCore::WebKitSourceBuffer::create):
(WebCore::WebKitSourceBuffer::WebKitSourceBuffer):
- Modules/mediasource/WebKitSourceBuffer.h:
- html/HTMLMediaSource.h:
- platform/graphics/MediaSourcePrivate.h:
- platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::SourceBufferPrivate):
- 8:50 AM Changeset in webkit [158269] by
-
- 3 edits in trunk/Source/WebCore
Remove unused runtime enabled
https://bugs.webkit.org/show_bug.cgi?id=123509
Reviewed by Anders Carlsson.
Some of the runtime enabled features were only ever used by the V8 bindings
and can be removed as no WebKit code sets or reads them.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/generic/RuntimeEnabledFeatures.h:
- 7:12 AM Changeset in webkit [158268] by
-
- 7 edits in trunk/Source/WebCore
Make SimpleLineLayout::Layout a class
https://bugs.webkit.org/show_bug.cgi?id=123508
Reviewed by Mario Sanchez Prada.
Improve encapsulation.
- 5:34 AM Changeset in webkit [158267] by
-
- 6 edits1 add in trunk
[GTK] accessibility/svg-remote-element.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101185
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-30
Reviewed by Chris Fleizach.
Tools:
Implemented missing methods by mimicing existing functionality in
AccessibilityObject::clickPoint() using available ATK API.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::clickPointX): Implemented.
(AccessibilityUIElement::clickPointY): Implemented.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::clickPointX): Implemented.
(WTR::AccessibilityUIElement::clickPointY): Implemented.
LayoutTests:
Provided new test expectations since resulting discrepancies are believed to be
platform related.
- platform/gtk-wk2/TestExpectations: The test is no longer failing.
- platform/gtk/accessibility/svg-remote-element-expected.txt: Added.
- platform/gtk/TestExpectations: The test is no longer failing.
- 4:31 AM Changeset in webkit [158266] by
-
- 11 edits8 deletes in trunk/Tools
Removed Windows platform configurations from WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=123152
Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-10-30
Reviewed by Csaba Osztrogonác.
Removed Windows specific parts from the source files, Windows specific
subdirectory (win) and Visual Studio property files from the WebKitTestRunner,
as the platform is no longer supported by this tool.
- WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Removed.
- WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Removed.
- WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Removed.
- WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Removed.
- WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Removed.
- WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Removed.
- WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::rootElement):
(WTR::AccessibilityController::focusedElement):
- WebKitTestRunner/InjectedBundle/AccessibilityController.h:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::createWKURL):
- WebKitTestRunner/cg/TestInvocationCG.cpp:
- WebKitTestRunner/config.h:
- WebKitTestRunner/win/InjectedBundle.vcproj: Removed.
- WebKitTestRunner/win/InjectedBundleDebug.vsprops: Removed.
- WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Removed.
- WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Removed.
- WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Removed.
- WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Removed.
- WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Removed.
- WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Removed.
- WebKitTestRunner/win/InjectedBundleProduction.vsprops: Removed.
- WebKitTestRunner/win/InjectedBundleRelease.vsprops: Removed.
- WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Removed.
- WebKitTestRunner/win/PlatformWebViewWin.cpp: Removed.
- WebKitTestRunner/win/TestControllerWin.cpp: Removed.
- WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
- WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed.
- WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Removed.
- WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Removed.
- WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Removed.
- WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Removed.
- WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Removed.
- WebKitTestRunner/win/build-generated-files.sh: Removed.
- WebKitTestRunner/win/main.cpp: Removed.
- 4:16 AM Changeset in webkit [158265] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r158214): It made zillion tests crash on GTK and EFL
https://bugs.webkit.org/show_bug.cgi?id=123505
- rendering/SimpleLineLayout.h: Add WTF_MAKE_FAST_ALLOCATED
- 3:39 AM Changeset in webkit [158264] by
-
- 1 edit1 delete in trunk/LayoutTests
[EFL] Remove efl/accessibility/image-map1-expected.txt after r158104
https://bugs.webkit.org/show_bug.cgi?id=123504
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-30
- platform/efl/accessibility/image-map1-expected.txt: Removed.
- 1:50 AM Changeset in webkit [158263] by
-
- 3 edits in trunk/LayoutTests
Revert r158259 for EFL and GTK+. They're still failing everywhere according to the flakiness dashboard.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 1:45 AM Changeset in webkit [158262] by
-
- 2 edits in trunk/LayoutTests
Revert r158259 for Mac. They're definitely failing on Mac.
- platform/mac/TestExpectations:
- 1:40 AM Changeset in webkit [158261] by
-
- 3 edits in trunk/LayoutTests
Add more test expectations for the bug 121452.
fast/frames/lots-of-objects.html is failing on Mavericks WebKit2 builders in addition to Debug builders.
fast/frames/lots-of-iframes.html is also failing on the exactly same set of builders.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 1:31 AM Changeset in webkit [158260] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] webkit_web_context_allow_tls_certificate_for_host doc is missing Since tag
https://bugs.webkit.org/show_bug.cgi?id=123499
Reviewed by Philippe Normand.
- UIProcess/API/gtk/WebKitWebContext.cpp: Add Since: 2.4.
- 1:17 AM Changeset in webkit [158259] by
-
- 4 edits in trunk/LayoutTests
Unreviewed. Removed some grid layout tests that are passing now.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- 1:04 AM Changeset in webkit [158258] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] Store video-sink in a bin
https://bugs.webkit.org/show_bug.cgi?id=122831
Reviewed by Gustavo Noronha Silva.
For the upcoming mediastream playback support the player will
handle a non-playbin-based pipeline that will require a slightly
different video rendering chain. This patch generalizes the
encapsulation of the video sink in a bin, just like the audio sink
case.
No new tests, no change in functionality.
Oct 29, 2013:
- 11:58 PM Changeset in webkit [158257] by
-
- 2 edits in trunk/LayoutTests
More Mavericks specific test expectation updates.
- platform/mac/TestExpectations:
- 11:53 PM Changeset in webkit [158256] by
-
- 9 edits in trunk
Result of focus-option-control-on-page.html depends on system preferences
https://bugs.webkit.org/show_bug.cgi?id=123304
Reviewed by Simon Fraser.
Source/WebKit/mac:
- WebView/WebView.mm: (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
Read the preference from its correct domain. This doesn't affect behavior in practice
and isn't part of the fix, but it's a good opportunity to correct this code.
Source/WebKit2:
- UIProcess/mac/WKFullKeyboardAccessWatcher.mm:
(-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]):
Read the preference from its correct domain. This doesn't affect behavior in practice
and isn't part of the fix, but it's a good opportunity to correct this code.
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
Override a preference that WebKit reads to decide what Tab does, so that current
user default doesn't affect tests.
- WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
Ditto.
LayoutTests:
- platform/mac/TestExpectations: Remove Pass/Failure expectations, this test
should always pass now.
- 11:03 PM Changeset in webkit [158255] by
-
- 3 edits in trunk/Tools
It should be possible to specify extra tests to run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=123495
Reviewed by Oliver Hunt.
This adds two ways to specify additional tests: the option --extra-tests=<blah>, and
the environment variable EXTRA_JSC_TESTS.
Those two values (the command-line option and the environment variable) are passed
as extra arguments to run-jsc-stress-tests.
To make this extra super useful, run-jsc-stress-tests now allows yaml configuration
files to be recursive: if a "- collection:" line is found, the string is handled
just as if it was a command-line argument. This allows you to use --extra-tests=file
where file contains a bunch of "- collection:" lines, and this is equivalent to each
of those lines being a command-line argument.
- Scripts/run-javascriptcore-tests:
- Scripts/run-jsc-stress-tests:
- 10:39 PM Changeset in webkit [158254] by
-
- 11 edits in trunk
REGRESSION(r154614): Opening and closing a picture on Facebook resets scroll position
https://bugs.webkit.org/show_bug.cgi?id=122882
Reviewed by Anders Carlsson.
Source/WebCore:
scrollLeft and scrollTop have to continue to function in the strict mode for the Web compatiblity.
In particular, www.facebook.com and build.webkit.org depend on this behavior as of October 29th, 2013.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::scrollLeft):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::scrollTop):
(WebCore::HTMLBodyElement::setScrollTop):
LayoutTests:
- fast/dom/Element/body-scrollLeft-expected.txt:
- fast/dom/Element/body-scrollLeft.html:
- fast/dom/Element/body-scrollTop-expected.txt:
- fast/dom/Element/body-scrollTop.html:
- fast/dom/Element/scrollLeft-expected.txt:
- fast/dom/Element/scrollLeft.html:
- fast/dom/Element/scrollTop-expected.txt:
- fast/dom/Element/scrollTop.html:
- 10:33 PM Changeset in webkit [158253] by
-
- 7 edits4 moves in trunk/Source/WebCore
IDBTransactionBackend should be cross platform
https://bugs.webkit.org/show_bug.cgi?id=123449
Reviewed by Beth Dakin.
- Rename IDBTransactionBackendLevelDB to IDBTransactionBackendImpl
- Rename IDBTransactionBackendLevelDBOperations to IDBTransactionBackendOperations
- Move their files from the leveldb subdirectory to the indexeddb directory
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBTransactionBackendImpl.cpp: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp.
- Modules/indexeddb/IDBTransactionBackendImpl.h: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h.
- Modules/indexeddb/IDBTransactionBackendOperations.cpp: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp.
- Modules/indexeddb/IDBTransactionBackendOperations.h: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h.
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::maybeCreateTransactionBackend):
- 10:15 PM Changeset in webkit [158252] by
-
- 7 edits in trunk/Source/WebCore
Modernize DatasetDOMStringMap and ClassList a bit
https://bugs.webkit.org/show_bug.cgi?id=123491
Patch by Sam Weinig <sam@webkit.org> on 2013-10-29
Reviewed by Andreas Kling.
- dom/DatasetDOMStringMap.cpp:
- dom/DatasetDOMStringMap.h:
- dom/Element.cpp:
- dom/ElementRareData.h:
- html/ClassList.cpp:
- html/ClassList.h:
Pass the owner Element by reference and store in a std::unique_ptr.
- 9:34 PM Changeset in webkit [158251] by
-
- 2 edits in trunk/Source/WebCore
Attempted build-fix after http://trac.webkit.org/changeset/158234
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::createBackingStoreTransaction): Implement this!
- 9:15 PM Changeset in webkit [158250] by
-
- 5 edits in trunk/Source/WebCore
ElementData construction helpers should return PassRef.
<https://webkit.org/b/123487>
Make functions that create new ElementData objects return appropriate
PassRef pointers instead of PassRefPtr.
Reviewed by Anders Carlsson.
- 8:57 PM Changeset in webkit [158249] by
-
- 2 edits in trunk/Source/WebCore
GTK+ build fix attempt after r158220.
- GNUmakefile.list.am:
- 8:53 PM Changeset in webkit [158248] by
-
- 2 edits in trunk/LayoutTests
Update Mavericks test expectation, tracked by bugs 123489 and 123490.
- platform/mac/TestExpectations:
- 8:52 PM Changeset in webkit [158247] by
-
- 3 edits in trunk/Tools
Add Mavericks builders to the old flakiness dashboard.
- TestResultServer/static-dashboards/builders.jsonp:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- 8:11 PM Changeset in webkit [158246] by
-
- 18 edits in trunk/Source
Move IDBTransactionBackendLevelDB to generic IDBBackingStoreInterface
https://bugs.webkit.org/show_bug.cgi?id=123483
Reviewed by Andreas Kling.
Source/WebCore:
- Modules/indexeddb/IDBCursorBackendInterface.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
(WebCore::IDBCursorBackendLevelDB::IDBCursorBackendLevelDB):
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
(WebCore::IDBCursorBackendLevelDB::create):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::createCursorBackend):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::registerOpenCursor):
(WebCore::IDBTransactionBackendLevelDB::unregisterOpenCursor):
(WebCore::IDBTransactionBackendLevelDB::closeOpenCursors):
(WebCore::IDBTransactionBackendLevelDB::createCursorBackend):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
- WebCore.xcodeproj/project.pbxproj: Export a required header.
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::createCursorBackend): Stubbed out.
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:
(WebKit::WebProcessIDBDatabaseBackend::factoryBackend): Stubbed out.
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
- 8:05 PM Changeset in webkit [158245] by
-
- 4 edits in trunk/Source
StringImpl::isolatedCopy() should return PassRef.
<https://webkit.org/b/123484>
Make isolatedCopy() return a PassRef<StringImpl>.
Reviewed by Anders Carlsson.
- 7:40 PM Changeset in webkit [158244] by
-
- 2 edits in trunk/Source/WebCore
Remove mutable keyword from member variables of XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=123481
Reviewed by Andreas Kling.
No new tests, no change in functionality.
- xml/XMLHttpRequest.h: Remove mutable keyword as these are no longer used in const functions.
- 6:51 PM Changeset in webkit [158243] by
-
- 8 edits in trunk/Source/WebCore
Underline bounds cannot be queried before underline itself is drawn
https://bugs.webkit.org/show_bug.cgi?id=123310
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-29
Reviewed by Simon Fraser
GraphicsContext's drawLineForText function is used to draw underlines,
strikethroughs, and overlines. Before drawing the line, this function
modifies the bounds given to it in order to make underlines crisp. However,
this means that it is impossible to know where an underline will be drawn
before drawing it. This patch pulls out this adjustment computation into
InlineTextBox, then passes the result to drawLineForText.
Because there should be no observable difference, no tests need to be updated.
- platform/graphics/GraphicsContext.h: Changing the signature of drawLineForText
so it can accept bounds from our helper function
- platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::drawLineForText): Update to work with new
signature of drawLineForText
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForText): Ditto
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLineForText): Ditto
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawLineForText): Ditto
- platform/win/WebCoreTextRenderer.cpp:
(WebCore::doDrawTextAtPoint): Update the last call site of drawLineForText
- rendering/InlineTextBox.cpp:
(WebCore::computeBoundsForUnderline): Pure function that computes the adjusted
bounds of the underline about to be drawn
(WebCore::drawLineForText): calls computeBoundsForUnderline and then
GraphicsContext::drawLineForText
(WebCore::InlineTextBox::paintDecoration): Use new drawLineForText function
(WebCore::InlineTextBox::paintCompositionUnderline): Ditto
- 5:58 PM Changeset in webkit [158242] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r158198): editing/execCommand/insert-list-xml.xhtml fails
https://bugs.webkit.org/show_bug.cgi?id=123460
Reviewed by Ryosuke Niwa.
The original version of this test used a MathML document root,
and attempted to add HTML content to prove that a bad cast would
not be encountered when manipulating the MathML document via
JavaScript.
r158198 broke the test, because it enforced the requirements that
MathML nodes not generate renderers for non-MathML children.
This patch revises the test to use an SVG document, which does
permit child HTML nodes.
- TestExpectations: Remove temporary exclusion landed in r158216.
- editing/execCommand/insert-list-xml-expected.txt:
- editing/execCommand/insert-list-xml.xhtml:
- 5:52 PM Changeset in webkit [158241] by
-
- 2 edits in trunk/LayoutTests
Mountain Lion rebaseline after r158231.
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- 5:25 PM Changeset in webkit [158240] by
-
- 2 edits in trunk/Tools
Fix memory leak in Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp
https://bugs.webkit.org/show_bug.cgi?id=123478
Reviewed by Anders Carlsson.
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_Destroy): Add a missing free() for 'obj->evaluateScriptOnMouseDownOrKeyDown'.
- 4:33 PM Changeset in webkit [158239] by
-
- 2 edits in trunk/Source/WebCore
Beef up CryptoKey
https://bugs.webkit.org/show_bug.cgi?id=123462
Fix a mismerge, remove duplicate CryptoKeyType declaration.
- crypto/CryptoKey.h:
- 4:19 PM Changeset in webkit [158238] by
-
- 2 edits in trunk/Tools
Move the SEO bots from testers to archivers.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 4:15 PM Changeset in webkit [158237] by
-
- 23 edits in trunk
Change local variable register allocation to start at offset -1
https://bugs.webkit.org/show_bug.cgi?id=123182
Reviewed by Geoffrey Garen.
Adjusted the virtual register mapping down by one slot. Reduced
the CallFrame header slots offsets by one. They now start at 0.
Changed arity fixup to no longer skip passed register slot 0 as this
is now part of the CallFrame header.
- bytecode/VirtualRegister.h:
(JSC::operandIsLocal):
(JSC::operandIsArgument):
(JSC::VirtualRegister::localToOperand):
(JSC::VirtualRegister::operandToLocal):
Adjusted functions for shift in mapping from local to register offset.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- interpreter/CallFrame.h:
(JSC::ExecState::frameExtent):
(JSC::ExecState::offsetFor):
- interpreter/Interpreter.cpp:
(JSC::loadVarargs):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::executeCall):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LowLevelInterpreter.asm: Adjusted math to accomodate for shift in call frame slots.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::calleeFrameOffset):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
- interpreter/JSStackInlines.h:
(JSC::JSStack::pushFrame):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITOperations.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::llint_slow_path_stack_check):
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
Fixed offset calculation to use VirtualRegister and related calculation instead of
doing seperate calculations.
- interpreter/JSStack.h: Adjusted CallFrame slots down by one. Did some miscellaneous fixing of dumpRegisters() in the process of testing the fixes.
- jit/ThunkGenerators.cpp:
(JSC::arityFixup):
Changed arity fixup to no longer skip passed register slot 0 as this
is now part of the CallFrame header.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm: Changed arity fixup to no longer skip passed register slot 0 as this is now part of the CallFrame header. Updated op_enter processing for the change in local registers.
- runtime/JSGlobalObject.h: Removed the now unneeded extra slot in the global callframe
- 4:12 PM Changeset in webkit [158236] by
-
- 5 edits5 adds in trunk/Source/WebCore
Beef up CryptoKey
https://bugs.webkit.org/show_bug.cgi?id=123462
Reviewed by Sam Weinig.
- WebCore.xcodeproj/project.pbxproj: Added new files.
- crypto/CryptoAlgorithmIdentifier.h: Added an enum with all registered algorithms
(they don't have to be all implemented in any port).
- crypto/CryptoKey.cpp:
(WebCore::CryptoKey::CryptoKey): Initialize base class variables.
(WebCore::CryptoKey::type): Convert internal representation for bindings use.
(WebCore::CryptoKey::buildAlgorithmDescription): Ditto. This function is supposed
to be called by derived classes before adding other keyes.
(WebCore::CryptoKey::usages): Convert internal representation for bindings use.
- crypto/CryptoKey.h:
(WebCore::CryptoKey::extractable): Expose for bindings.
(WebCore::CryptoKey::allows): A faster way to check allowed key usage from C++ code.
- crypto/CryptoKey.idl: Added SkipVTableValidation, because validation doesn't work
with derived classes. Corrected "usages" attribute name.
- crypto/CryptoKeyFormat.h: Added.
- crypto/CryptoKeyType.h: Added.
- crypto/CryptoKeyUsage.h: Added.
Added enums used by CryptoKey.
- 4:03 PM Changeset in webkit [158235] by
-
- 4 edits26 adds in trunk
Adding Nix files in Source/Platform to trunk
https://bugs.webkit.org/show_bug.cgi?id=118331
Reviewed by Benjamin Poulain.
Source/Platform:
Add files part of Nix public API used to implement
backends for some WebKit subsystems on Application side.
- nix/public/AudioDevice.h: Added.
- nix/public/Canvas.h: Added.
- nix/public/Color.h: Added.
- nix/public/Common.h: Added.
- nix/public/FFTFrame.h: Added.
- nix/public/Gamepad.h: Added.
- nix/public/Gamepads.h: Added.
- nix/public/MediaPlayer.h: Added.
- nix/public/MultiChannelPCMData.h: Added.
- nix/public/Platform.h: Added.
- nix/public/Rect.h: Added.
- nix/public/Size.h: Added.
- nix/public/ThemeEngine.h: Added.
- nix/src/DefaultWebThemeEngine.cpp: Added.
- nix/src/DefaultWebThemeEngine.h: Added.
- nix/src/Platform.cpp: Added.
Source/WebCore:
Add Nix WebAudio implementation that just forward some calls to our API.
This patch is part of the upstream process, tests will be landed by other patches.
- platform/audio/nix/AudioBusNix.cpp: Added.
- platform/audio/nix/AudioDestinationNix.cpp: Added.
- platform/audio/nix/AudioDestinationNix.h: Added.
- platform/audio/nix/FFTFrameNix.cpp: Added.
- platform/nix/support/MultiChannelPCMData.cpp: Added.
Tools:
Add a special rule for Nix API files located at Source/Platform/nix.
- Scripts/webkitpy/style/checker.py:
2013-10-29 Nadav Rotem <nrotem@apple.com>
Add myself as a comitter.
https://bugs.webkit.org/show_bug.cgi?id=123455
Reviewed by Anders Carlsson.
- Scripts/webkitpy/common/config/contributors.json:
- 3:52 PM Changeset in webkit [158234] by
-
- 9 edits in trunk/Source/WebCore
Move IDBTransactionBackendLevelDB to generic IDBBackingStoreInterface::Transaction.
https://bugs.webkit.org/show_bug.cgi?id=123475
Reviewed by Tim Horton.
Currently it's using IDBBackingStoreLevelDB::Transaction, which hinders the goal of:
https://bugs.webkit.org/show_bug.cgi?id=123449 - IDBTransactionBackend should be cross platform
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBIndexWriter.cpp:
(WebCore::IDBIndexWriter::writeIndexKeys):
(WebCore::IDBIndexWriter::verifyIndexKeys):
(WebCore::IDBIndexWriter::addingKeyAllowed):
- Modules/indexeddb/IDBIndexWriter.h:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseIntVersion):
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseMetaData):
(WebCore::IDBBackingStoreLevelDB::createObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteObjectStore):
(WebCore::IDBBackingStoreLevelDB::getRecord):
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::clearObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::createIndex):
(WebCore::IDBBackingStoreLevelDB::deleteIndex):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::IDBBackingStoreLevelDB::findKeyInIndex):
(WebCore::IDBBackingStoreLevelDB::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStoreLevelDB::keyExistsInIndex):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
(WebCore::IDBTransactionBackendLevelDB::abort):
(WebCore::IDBTransactionBackendLevelDB::commit):
(WebCore::IDBTransactionBackendLevelDB::taskTimerFired):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
- 3:38 PM Changeset in webkit [158233] by
-
- 3 edits in trunk/Source/WebCore
Move InlineTextBox's text painting to it's own class
https://bugs.webkit.org/show_bug.cgi?id=123355
Reinstate the LGPL license. I incorrectly told Myles to
use another license on these new files.
- rendering/TextPainter.cpp:
- rendering/TextPainter.h:
- 3:29 PM Changeset in webkit [158232] by
-
- 8 edits2 adds in trunk/Source/WebCore
Move InlineTextBox's text painting to it's own class
https://bugs.webkit.org/show_bug.cgi?id=123355
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-29
Reviewed by Dean Jackson.
Implementing text-decoration-skip: ink requires drawing text
twice (once regularly, and once with a thick outline into a mask).
This patch pulls out the relevant text drawing code from
InlineTextBox into a new class, called TextPainter, which can be re-used
to draw text multiple times.
Because there should be no observable difference, no tests need to be updated.
- CMakeLists.txt: Adding new TextPainter class
- GNUmakefile.list.am: Adding new TextPainter class
- WebCore.vcxproj/WebCore.vcxproj: Adding new TextPainter class
- WebCore.vcxproj/WebCore.vcxproj.filters: Adding new TextPainter
class
- WebCore.xcodeproj/project.pbxproj: Adding new TextPainter class
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Moving text drawing code from
this function
- rendering/RenderingAllInOne.cpp: Adding new TextPainter class
- rendering/TextPainter.cpp: Added.
(WebCore::TextPainter::TextPainter):
(WebCore::drawTextOrEmphasisMarks):
(WebCore::paintTextWithShadows):
(WebCore::rotation):
(WebCore::TextPainter::paintText): New location for text drawing
code
(WebCore::TextPainter::paintTextInContext):
- rendering/TextPainter.h: Added.
(WebCore::SavedDrawingStateForMask::SavedDrawingStateForMask):
(WebCore::TextPainter::boxRect):
- 3:03 PM Changeset in webkit [158231] by
-
- 11 edits in trunk
[MSE] [Mac] Enable MediaSource on the Mac
https://bugs.webkit.org/show_bug.cgi?id=122484
Reviewed by Darin Adler.
Source/WebCore:
Enable ENABLE_MEDIA_SOURCE.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
Enable ENABLE_MEDIA_SOURCE.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Enable ENABLE_MEDIA_SOURCE.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Enable ENABLE_MEDIA_SOURCE.
- wtf/FeatureDefines.h:
- wtf/Platform.h: Force a clean build.
LayoutTests:
- platform/mac/js/dom/global-constructors-attributes-expected.txt: Added.
- 2:50 PM Changeset in webkit [158230] by
-
- 4 edits in trunk/Source/WebCore
Build fix after 158223; make TileController use float for scales.
This matches what we do in other places, and fixes the constant
issue with exporting symbols that include CGFloat.
- WebCore.exp.in:
- platform/graphics/ca/mac/TileController.h:
(WebCore::TileController::scale):
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::setScale):
- 2:45 PM Changeset in webkit [158229] by
-
- 2 edits in trunk/Source/WebCore
Try to keep MSVC happy.
- rendering/SimpleLineLayout.h:
(WebCore::SimpleLineLayout::Run::Run):
- 2:44 PM Changeset in webkit [158228] by
-
- 3 edits2 adds in trunk/Websites/webkit.org
Just updating the sample code for this potential blog post.
- blog-files/regions/pizza-is-amazing.png: Replaced.
- blog-files/regions/unstyled-article.png: Replaced.
- demos/regions/pizza-regions-manifesto-regionstyling.html:
- demos/regions/pizza-regions-manifesto.html:
- 2:41 PM Changeset in webkit [158227] by
-
- 5 edits2 copies in branches/safari-537.73-branch/Source/WebCore
Merge r155221.
2013-09-06 Brent Fulgham <Brent Fulgham>
[Windows] StructuredExceptionHandlerSuppressor Causes Bad Interactions with Support Libraries
https://bugs.webkit.org/show_bug.cgi?id=120901
Reviewed by Anders Carlsson.
Change from old "crash on any exception" implementation to a new version that leaves normal
exception handling infrastructure in place for use by support libraries. We check exceptions
and decide whether to abort or not based on the failure type.
- WebCore.vcxproj/WebCore.vcxproj: Add new implementation files.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- platform/graphics/ca/win/LayerChangesFlusher.cpp: (WebCore::LayerChangesFlusher::hookCallback): Allocate handler struct on stack.
- platform/win/StructuredExceptionHandlerSuppressor.cpp: Added. (exceptionShouldTerminateProgram): New. (exceptionHandler): New. (WebCore::StructuredExceptionHandlerSuppressor::StructuredExceptionHandlerSuppressor): Moved from header, and updated to add our new exception handler. (WebCore::StructuredExceptionHandlerSuppressor::~StructuredExceptionHandlerSuppressor): Moved from header.
- platform/win/StructuredExceptionHandlerSuppressor.h: Move implementation of constructor and destructor from header file.
- platform/win/makesafeseh.asm: Added.
- 2:30 PM Changeset in webkit [158226] by
-
- 4 edits in trunk/Source
More correct build fix after 158223.
Only fails in release because it's inline.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
- WebCore.exp.in:
- 2:25 PM Changeset in webkit [158225] by
-
- 4 edits in trunk/Source/WebCore
Use left/right instead of left/width for simple text runs
https://bugs.webkit.org/show_bug.cgi?id=123465
Reviewed by Andreas Kling.
This simplifies the code a bit.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::adjustRunOffsets):
(WebCore::SimpleLineLayout::create):
- rendering/SimpleLineLayout.h:
(WebCore::SimpleLineLayout::Run::Run):
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::Run::rect):
- 2:25 PM Changeset in webkit [158224] by
-
- 2 edits in trunk/Source/WebCore
Try fixing the Mac build (though I have no idea why
this wouldn't fail locally)...
- WebCore.exp.in:
- 2:04 PM Changeset in webkit [158223] by
-
- 14 edits2 adds in trunk/Source
Remote Layer Tree: Support tiled drawing and use it for the main frame
https://bugs.webkit.org/show_bug.cgi?id=123422
Reviewed by Simon Fraser.
Add a PlatformCALayerRemote subclass that behaves similarly to
WebTiledBackingLayer, forwarding relevant things (setNeedsDisplay, etc.)
to the TileController which it owns.
Teach the remote layer tree code enough to proxy these layers across,
and paint them in a manner similar to WebSimpleLayer (just calling
straight back to the TileController to paint).
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::setEdgeAntialiasingMask):
Add support for adjusting/encoding/decoding/dumping/applying edgeAntialiasingMask.
(WebKit::RemoteLayerTreeTransaction::dump):
Drive-by fix dumping of created layers to have one layer per line.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
Create CALayers for Simple, TiledBacking, PageTiledBacking, and TiledBackingTile layers.
- WebKit2.xcodeproj/project.pbxproj:
Add PlatformCALayerRemoteTiledBacking.{h, cpp}.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::create):
Create a PlatformCALayerRemoteTiledBacking for TiledBacking and PageTiledBacking layers.
(PlatformCALayerRemote::removeAllSublayers):
Fix removeAllSublayers to make a copy of the PlatformCALayerList before
mutating it, to avoid crashes when iterating a mutated list.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Definalize PlatformCALayerRemote so we can have PlatformCALayerRemoteTiledBacking.
Note that we will use a tiled backing layer in some cases.
Make the constructor protected, not private, so our subclass can use it.
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp: Added.
(PlatformCALayerRemoteTiledBacking::PlatformCALayerRemoteTiledBacking):
(PlatformCALayerRemoteTiledBacking::~PlatformCALayerRemoteTiledBacking):
(PlatformCALayerRemoteTiledBacking::setNeedsDisplay):
(PlatformCALayerRemoteTiledBacking::customSublayers):
(PlatformCALayerRemoteTiledBacking::setBounds):
(PlatformCALayerRemoteTiledBacking::isOpaque):
(PlatformCALayerRemoteTiledBacking::setOpaque):
(PlatformCALayerRemoteTiledBacking::acceleratesDrawing):
(PlatformCALayerRemoteTiledBacking::setAcceleratesDrawing):
(PlatformCALayerRemoteTiledBacking::setContentsScale):
(PlatformCALayerRemoteTiledBacking::setBorderWidth):
(PlatformCALayerRemoteTiledBacking::setBorderColor):
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h: Added.
Add a subclass of PlatformCALayerRemote which forwards operations
to TileController, very similar to what WebTiledBackingLayer does.
It also owns the TileController, and overrides customSublayers() and
tiledBacking() to return the right thing.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::display):
Teach RemoteLayerBackingStore about how to paint different kinds of layers.
Simple layers and Tile layers will call paintContents directly,
WebLayers will do what WebLayer does and use drawLayerContents.
Other kinds of layers won't paint at all right now.
I would like to centralize this behavior (and get rid of our CALayer
subclasses entirely, moving all that behavior to be shared between Mac,
Windows, and the remote layer tree), but that is a patch for another day.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::shouldUseTiledBackingForFrameView):
Force accelerated compositing on always when using the remote layer tree.
Use a TiledBacking for the main frame.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Drive-by OVERRIDE.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- 2:04 PM Changeset in webkit [158222] by
-
- 2 edits in trunk/Tools
Add myself as a comitter
- 1:48 PM Changeset in webkit [158221] by
-
- 4 edits1 copy1 delete in branches/safari-537.73-branch/Source/WebCore
Merge r155215.
2013-09-06 Brent Fulgham <Brent Fulgham>
[Windows] Unreviewed gardening: Spell 'Suppressor' properly
- WebCore.vcxproj/WebCore.vcxproj: Change StructuredExceptionHandlerSupressor to StructuredExceptionHandlerSuppressor
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto
- platform/graphics/ca/win/LayerChangesFlusher.cpp: (WebCore::LayerChangesFlusher::hookCallback): Ditto
- platform/win/StructuredExceptionHandlerSuppressor.h: Copied from platform/win/StructuredExceptionHandlerSupressor.h.
- platform/win/StructuredExceptionHandlerSupressor.h: Removed.
- 1:48 PM Changeset in webkit [158220] by
-
- 33 edits10 adds in trunk
[Mac MediaStream] implement AVFoundation backed MediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=123316
Source/WebCore:
Reviewed by Jer Noble
No new tests, existing tests updated.
- CMakeLists.txt: Add MediaStreamSourceStates.cpp.
- Modules/mediastream/MediaSourceStates.cpp:
(WebCore::MediaSourceStates::MediaSourceStates): m_SourceStates -> m_sourceStates.
(WebCore::MediaSourceStates::sourceType): Ditto.
(WebCore::MediaSourceStates::facingMode): Ditto.
- Modules/mediastream/MediaSourceStates.h: Ditto.
- Modules/mediastream/MediaSourceStates.idl: Mark some attributes as optional.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::addRemoteSource):
(WebCore::MediaStream::removeRemoteSource):
- Modules/mediastream/MediaStreamCapabilities.cpp:
(WebCore::MediaStreamCapabilities::sourceType): MediaSourceStates -> MediaStreamSourceStates
(WebCore::MediaStreamCapabilities::facingMode): Ditto.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack): Don't observe source changes directly, let the
private track do that. Change private track parameter to ref because it can't be NULL.
(WebCore::MediaStreamTrack::~MediaStreamTrack): Ditto.
(WebCore::MediaStreamTrack::setSource): Pass through to private track.
(WebCore::MediaStreamTrack::stopped): Ditto.
(WebCore::MediaStreamTrack::states): Ditto.
(WebCore::MediaStreamTrack::capabilities): Ditto.
(WebCore::MediaStreamTrack::applyConstraints): Ditto.
(WebCore::MediaStreamTrack::stopProducingData): Ditto.
(WebCore::MediaStreamTrack::trackReadyStateChanged): Renamed from sourceStateChanged. Don't
schedule an 'ended' event if called as a side effect of the stop() method having been
called as per spec.
(WebCore::MediaStreamTrack::trackMutedChanged): Renamed from sourceMutedChanged.
(WebCore::MediaStreamTrack::trackEnabledChanged): Renamed from sourceEnabledChanged.
(WebCore::MediaStreamTrack::stop): Pass through to private track.
- Modules/mediastream/MediaStreamTrack.h:
(WebCore::MediaStreamTrack::Observer::~Observer): Add virtual destructor.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::callSuccessHandler): Set track, not source, constraints.
- WebCore.xcodeproj/project.pbxproj: Add new files.
- bindings/js/JSMediaSourceStatesCustom.cpp:
(WebCore::JSMediaSourceStates::facingMode): Return jsUndefined when the facing mode
is Unknown.
- platform/mediastream/MediaStreamCenter.h: Remove unused class forward defines and
undefined method prototype.
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::addSource): ASSERT if source is kind None.
(WebCore::MediaStreamDescriptor::removeSource): Ditto.
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
- platform/mediastream/MediaStreamSource.cpp:
(WebCore::MediaStreamSource::setReadyState): Call startProducingData when readyState changes
to Live, stopProducingData when it changes to Ended.
(WebCore::MediaStreamSource::removeObserver): Call stop() when there are no more observers.
(WebCore::MediaStreamSource::setEnabled): If passed false, do nothing unless all observers
are disabled. Call startProducingData/stopProducingData when becoming enabled/disabled.
(WebCore::MediaStreamSource::stop): Don't bother checking to see if other observers have
stopped, the spec says that track.stop() should permanently stop the track's source.
- platform/mediastream/MediaStreamSource.h:
(WebCore::MediaStreamSource::name): Make virtual so derived classes can override.
(WebCore::MediaStreamSource::setName): Ditto.
(WebCore::MediaStreamSource::readyState): Ditto.
(WebCore::MediaStreamSource::enabled): Ditto.
(WebCore::MediaStreamSource::muted): Ditto.
(WebCore::MediaStreamSource::setReadonly): Ditto.
(WebCore::MediaStreamSource::remote): Ditto.
(WebCore::MediaStreamSource::setRemote): Ditto.
(WebCore::MediaStreamSource::startProducingData): Added.
(WebCore::MediaStreamSource::stopProducingData): Added.
- platform/mediastream/MediaStreamSourceCapabilities.h: Move MediaStreamSourceStates to
its own file.
- platform/mediastream/MediaStreamSourceStates.cpp: Added.
(WebCore::MediaStreamSourceStates::facingMode): Moved here from MediaSourceStates so the
strings are available to platform code.
(WebCore::MediaStreamSourceStates::sourceType): Ditto.
- platform/mediastream/MediaStreamSourceStates.h: Added, moved from MediaStreamSourceCapabilities.h.
- platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::create): Pass private track to constructor as PassRefPtr.
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate): Initialize member variables.
(WebCore::MediaStreamTrackPrivate::~MediaStreamTrackPrivate): Unregister as source observer.
(WebCore::MediaStreamTrackPrivate::setSource): Unregister/register as source observer.
(WebCore::MediaStreamTrackPrivate::setEnabled): Enable/disable source, call client.
(WebCore::MediaStreamTrackPrivate::stop): New. Set readyState to Ended, optionally stop source.
(WebCore::MediaStreamTrackPrivate::setReadyState): Inline the logic from shouldFireTrackReadyStateChanged.
(WebCore::MediaStreamTrackPrivate::constraints): New, passthrough to the source.
(WebCore::MediaStreamTrackPrivate::states): Ditto.
(WebCore::MediaStreamTrackPrivate::type): Ditto.
(WebCore::MediaStreamTrackPrivate::capabilities): Ditto.
(WebCore::MediaStreamTrackPrivate::applyConstraints): Ditto.
(WebCore::MediaStreamTrackPrivate::sourceReadyStateChanged): React to source changes.
(WebCore::MediaStreamTrackPrivate::sourceMutedChanged): Ditto.
(WebCore::MediaStreamTrackPrivate::sourceEnabledChanged): Ditto.
(WebCore::MediaStreamTrackPrivate::observerIsEnabled): Respond to source query.
(WebCore::MediaStreamTrackPrivate::observerIsStopped): Ditto.
- platform/mediastream/MediaStreamTrackPrivate.h:
- platform/mediastream/mac/AVAudioCaptureSource.h: Added.
- platform/mediastream/mac/AVAudioCaptureSource.mm: Added.
- platform/mediastream/mac/AVCaptureDeviceManager.h: Added.
- platform/mediastream/mac/AVCaptureDeviceManager.mm: Added.
- platform/mediastream/mac/AVMediaCaptureSource.h: Added.
- platform/mediastream/mac/AVMediaCaptureSource.mm: Added.
- platform/mediastream/mac/AVVideoCaptureSource.h: Added.
- platform/mediastream/mac/AVVideoCaptureSource.mm: Added.
- platform/mediastream/mac/MediaStreamCenterMac.cpp:
(WebCore::MediaStreamCenterMac::validateRequestConstraints): Implement.
(WebCore::MediaStreamCenterMac::createMediaStream): Ditto.
(WebCore::MediaStreamCenterMac::getMediaStreamTrackSources): Ditto.
- platform/mock/MockMediaStreamCenter.cpp:
(WebCore::initializeMockSources): Update for MediaStreamSourceStates changes.
(WebCore::MockMediaStreamCenter::createMediaStream):
LayoutTests:
Reviewed by Jer Noble.
- fast/mediastream/MediaStream-add-remove-tracks-expected.txt: Updated.
- fast/mediastream/MediaStream-add-remove-tracks.html: Ditto.
- fast/mediastream/MediaStreamConstructor-expected.txt: Ditto.
- fast/mediastream/MediaStreamConstructor.html: Ditto.
- fast/mediastream/MediaStreamTrack-getSources.html: Remove typo.
- fast/mediastream/MediaStreamTrack-expected.txt: Updated results.
- fast/mediastream/MediaStreamTrack.html: Update to test track.stop() behavior.
- 1:44 PM Changeset in webkit [158219] by
-
- 3 edits2 adds in trunk
Source/WebCore: [CSS Regions][CSS Shapes] Layout error when the shape has negative top coordinate and it's applied on the second region
<https://webkit.org/b/123346>
Reviewed by David Hyatt.
We have a layout error when there is a shape applied on the second region, and it has a negative 'top' coordinate.
Since shapeInsideInfo::shapeLogicalTop() can return negative numbers, we need to check for it, when we're positioning
the first line in the region.
Test: fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):
LayoutTests: [CSS Regions][CSS Shapes] Layout error when the shape has negative top coordinate and it's applied on the second region
<http://webkit.org/b/123346>
Reviewed by David Hyatt.
We have a layout error when there is a shape applied on the second region, and it has a negative 'top' coordinate.
Since shapeInsideInfo::shapeLogicalTop() can return negative numbers, we need to check for it, when we're positioning
the first line in the region.
- fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-multiple-regions-with-negative-shape-top.html: Added.
- 1:41 PM Changeset in webkit [158218] by
-
- 2 edits in trunk/Source/WebCore
Get IDBTransactionBackendLevelDBOperations *almost* ready to go cross platform.
https://bugs.webkit.org/show_bug.cgi?id=123451
Reviewed by NOBODY (My bad, non-reviewed, non-building code got in there)
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::processPendingCalls): Remove the auto line I was trying from review feedback.
- 1:38 PM Changeset in webkit [158217] by
-
- 19 edits2 adds in trunk/Source
Get IDBTransactionBackendLevelDBOperations *almost* ready to go cross platform.
https://bugs.webkit.org/show_bug.cgi?id=123451
Reviewed by Andreas Kling.
Source/WebCore:
This involves:
- Splitting out IDBTransactionBackendLevelDB::Operation into its own header
- Splitting out IDBDatabaseBackendImpl::PendingOpenCall into its own header
- Reworking the LevelDB Operations to handle the base class IDBTransactionBackendInterface
- Adding virtual methods in a few of the *Interface classes to support the above
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBCallbacks.h:
- Modules/indexeddb/IDBCursorBackendInterface.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setIndexKeys):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
- Modules/indexeddb/IDBOperation.h: Added.
(WebCore::IDBOperation::~IDBOperation):
- Modules/indexeddb/IDBPendingOpenCall.h: Added.
(WebCore::IDBPendingOpenCall::create):
(WebCore::IDBPendingOpenCall::callbacks):
(WebCore::IDBPendingOpenCall::databaseCallbacks):
(WebCore::IDBPendingOpenCall::version):
(WebCore::IDBPendingOpenCall::transactionId):
(WebCore::IDBPendingOpenCall::IDBPendingOpenCall):
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
(WebCore::IDBCursorBackendLevelDB::CursorIterationOperation::create):
(WebCore::IDBCursorBackendLevelDB::CursorAdvanceOperation::create):
(WebCore::IDBCursorBackendLevelDB::CursorPrefetchIterationOperation::create):
(WebCore::IDBCursorBackendLevelDB::IDBCursorBackendLevelDB):
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::scheduleTask):
(WebCore::IDBTransactionBackendLevelDB::abort):
(WebCore::IDBTransactionBackendLevelDB::taskTimerFired):
(WebCore::IDBTransactionBackendLevelDB::schedulePutOperation):
(WebCore::IDBTransactionBackendLevelDB::scheduleOpenCursorOperation):
(WebCore::IDBTransactionBackendLevelDB::scheduleCountOperation):
(WebCore::IDBTransactionBackendLevelDB::scheduleDeleteRangeOperation):
(WebCore::IDBTransactionBackendLevelDB::scheduleClearOperation):
(WebCore::IDBTransactionBackendLevelDB::createCursorBackend):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::CreateIndexOperation::perform):
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::DeleteIndexOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:
(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::create):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::VersionChangeOperation):
(WebCore::CreateObjectStoreAbortOperation::create):
(WebCore::CreateObjectStoreAbortOperation::CreateObjectStoreAbortOperation):
(WebCore::DeleteObjectStoreAbortOperation::create):
(WebCore::DeleteObjectStoreAbortOperation::DeleteObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::create):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::VersionChangeAbortOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore::CreateIndexAbortOperation::create):
(WebCore::CreateIndexAbortOperation::CreateIndexAbortOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(WebCore::DeleteIndexAbortOperation::create):
(WebCore::DeleteIndexAbortOperation::DeleteIndexAbortOperation):
(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(WebCore::SetIndexesReadyOperation::create):
(WebCore::SetIndexesReadyOperation::SetIndexesReadyOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(WebCore::CountOperation::create):
(WebCore::CountOperation::CountOperation):
(WebCore::DeleteRangeOperation::create):
(WebCore::DeleteRangeOperation::DeleteRangeOperation):
(WebCore::ClearOperation::create):
(WebCore::ClearOperation::ClearOperation):
Source/WebKit2:
Stub out more pure virtual methods.
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:
(WebKit::WebProcessIDBDatabaseBackend::backingStore):
(WebKit::WebProcessIDBDatabaseBackend::id):
(WebKit::WebProcessIDBDatabaseBackend::addObjectStore):
(WebKit::WebProcessIDBDatabaseBackend::removeObjectStore):
(WebKit::WebProcessIDBDatabaseBackend::addIndex):
(WebKit::WebProcessIDBDatabaseBackend::removeIndex):
(WebKit::WebProcessIDBDatabaseBackend::metadata):
(WebKit::WebProcessIDBDatabaseBackend::setCurrentVersion):
(WebKit::WebProcessIDBDatabaseBackend::hasPendingSecondHalfOpen):
(WebKit::WebProcessIDBDatabaseBackend::setPendingSecondHalfOpen):
- WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
- 1:27 PM Changeset in webkit [158216] by
-
- 2 edits in trunk/LayoutTests
Add a failing test expectation on editing/execCommand/insert-list-xml.xhtml
after r158198. The failure is tracked by the bug 123460.
- 1:26 PM Changeset in webkit [158215] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebKit/win
Merge r154764
2013-08-28 Brent Fulgham <Brent Fulgham>
[Windows] Provide useful error messages for WebKitErrorDomain errors
https://bugs.webkit.org/show_bug.cgi?id=120428
Reviewed by Anders Carlsson.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::cancelledError): Provide text for this error. (WebFrameLoaderClient::blockedError): Hook up WEB_UI_STRING for this error. (WebFrameLoaderClient::cannotShowURLError): Ditto (WebFrameLoaderClient::interruptedForPolicyChangeError): Ditto (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto (WebFrameLoaderClient::fileDoesNotExistError): Provide text for this error. (WebFrameLoaderClient::pluginWillHandleLoadError): Hook up WEB_UI_STRING for this error. (WebFrameLoaderClient::dispatchDidFailToStartPlugin): Ditto. (WebFrameLoaderClient::createJavaAppletWidget): Ditto. (WebFrameLoaderClient::webHistory): Remove blank line above method.
- 1:25 PM Changeset in webkit [158214] by
-
- 6 edits in trunk/Source/WebCore
Make SimpleLineLayout::Layout a variable size object
https://bugs.webkit.org/show_bug.cgi?id=123459
Reviewed by Andreas Kling.
Less memory, less indirection.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::create):
(WebCore::SimpleLineLayout::Layout::create):
(WebCore::SimpleLineLayout::Layout::Layout):
- rendering/SimpleLineLayout.h:
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::hitTestFlow):
- rendering/SimpleLineLayoutFunctions.h:
(WebCore::SimpleLineLayout::computeFlowFirstLineBaseline):
(WebCore::SimpleLineLayout::computeFlowLastLineBaseline):
(WebCore::SimpleLineLayout::findTextCaretMinimumOffset):
(WebCore::SimpleLineLayout::findTextCaretMaximumOffset):
(WebCore::SimpleLineLayout::containsTextCaretOffset):
(WebCore::SimpleLineLayout::isTextRendered):
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::end):
- 1:02 PM Changeset in webkit [158213] by
-
- 3 edits in trunk/Source/WTF
StringImpl::adopt() should return PassRef.
<https://webkit.org/b/123456>
Make the StringImpl::adopt() functions return a PassRef<StringImpl>.
Reviewed by Anders Carlsson.
- 12:52 PM Changeset in webkit [158212] by
-
- 5 edits in trunk/Source/WebCore
RenderObject::outlineStyleForRepaint() should return a reference.
<https://webkit.org/b/123453>
Kill a FIXME and make outlineStyleForRepaint() return a RenderStyle&.
Reviewed by Antti Koivisto.
- 12:49 PM Changeset in webkit [158211] by
-
- 4 edits in branches/safari-537.73-branch/Source/WebKit/win
Merge r154759
2013-08-27 Brent Fulgham <Brent Fulgham>
[Windows] Loader is not properly determining supported MIME types
https://bugs.webkit.org/show_bug.cgi?id=120383
Reviewed by Eric Carlson.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::canShowMIMEType): Modify to ask WebView if it can display the media type. Use new helper function to avoid converting a String to BSTR, only to immediatly be converted from BSTR back to String. (WebFrameLoaderClient::canShowMIMETypeAsHTML): Ditto.
- WebView.cpp: (WebView::canShowMIMEType): Move logic to a new (similarly named) helper function. (WebView::canShowMIMETypeAsHTML): Ditto.
- WebView.h: Add declaration for two new helper functions.
- 12:43 PM Changeset in webkit [158210] by
-
- 8 edits in trunk/Source/WebKit2
SessionState.h should not include WebBackForwardList.h
https://bugs.webkit.org/show_bug.cgi?id=123454
Reviewed by Geoff Garen.
WebBackForwardList is a UIProcess type, SessionState is in shared code.
Also, WebBackForwardListItemVector should be in WebBackForwardListItem.h, not WebBackForwardList.h
(the vector type is used in the WebProcess, the item header is shared but the list type is in the UIProcess).
- Shared/SessionState.cpp:
- fixed includes
- Shared/SessionState.h:
- WebBackForwardList.h -> WebBackForwardListItem.h
- Shared/WebBackForwardListItem.h:
- Moved WebBackForwardListVector from WebBackForwardList.h
- Shared/WebPageCreationParameters.h:
- fixed includes
- UIProcess/WebBackForwardList.h:
- Moved WebBackForwardListVector to WebBackForwardListItem.h
- WebProcess/WebPage/DrawingArea.cpp:
- fixed includes
- WebProcess/WebPage/WebPage.cpp:
- fixed includes
- 12:41 PM Changeset in webkit [158209] by
-
- 10 edits in trunk/Source/WebCore
Move more of SVG resources cache to using RenderElement.
<https://webkit.org/b/123452>
Make some more RenderSVGResourcesCache methods take RenderElement&
instead of RenderObject*.
Also removed a double hash lookup in removeResourcesFromRenderer().
Reviewed by Antti Koivisto.
- 12:34 PM Changeset in webkit [158208] by
-
- 8 edits in trunk/Source/JavaScriptCore
[arm] Fix lots of crashes because of 4th argument register trampling.
https://bugs.webkit.org/show_bug.cgi?id=123421
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-29
Reviewed by Michael Saboff.
r3 register is the 4th argument register for ARM and also a scratch
register in the baseline JIT for this architecture. We can use r6
instead, as this used to be the timeoutCheckRegister and it is no
longer used since r148119.
- assembler/ARMAssembler.h: Temp register is now r6 instead of r3 for ARM.
- assembler/MacroAssemblerARMv7.h: Temp register is now r6 instead of r3 for ARMv7.
- jit/GPRInfo.h: Add r3 properly in GPRInfo for ARM.
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
- jit/JITStubsARM.h:
(JSC::ctiTrampoline): Remove obsolete timeoutCheckRegister init.
- jit/JITStubsARMv7.h:
(JSC::ctiTrampoline): Remove obsolete timeoutCheckRegister init.
- jit/JSInterfaceJIT.h: Remove useless stuff.
- yarr/YarrJIT.cpp: Use r3 and not the new scratch register r6.
(JSC::Yarr::YarrGenerator::generateEnter): r8 register doesn't need to be saved.
(JSC::Yarr::YarrGenerator::generateReturn):
- 12:20 PM Changeset in webkit [158207] by
-
- 2 edits in trunk/Tools
Teach the WebKit2 testers to abort early by setting the shouldAbortEarly property to True.
https://bugs.webkit.org/show_bug.cgi?id=123450
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKit2Tests.start):
- 12:03 PM Changeset in webkit [158206] by
-
- 2 edits in trunk/LayoutTests
Mark some colorspace-sensitive tests as possibly passing.
- platform/mac-wk2/TestExpectations:
- 12:02 PM Changeset in webkit [158205] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix CPU(ARM_TRADITIONAL) build after r157690.
https://bugs.webkit.org/show_bug.cgi?id=123247
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-29
Reviewed by Michael Saboff.
Since r157690, the executableCopy function has been removed from AssemblerBuffer.h
and the copy of executable code occurs in the linkCode function (in LinkBuffer.cpp).
As the constant pool for jumps is updated in the executableCopy function of ARM_TRADITIONAL,
this part of code still needs to be called and absolute jumps must be corrected to anticipate
the copy of the executable code through memcpy.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::prepareExecutableCopy): Rename executableCopy to prepareExecutableCopy
and correct absolute jump values using the delta between the source and destination buffers.
- assembler/ARMAssembler.h:
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::linkCode): Call prepareExecutableCopy just before the memcpy.
- 11:56 AM Changeset in webkit [158204] by
-
- 2 edits in trunk/LayoutTests
xss-DENIED-xsl-document-redirect.xml is an XML file, not html.
- platform/mac-wk2/TestExpectations:
- 11:38 AM Changeset in webkit [158203] by
-
- 6 edits3 deletes in trunk/Source/WebCore
Web Inspector: Remove old Inspector.json version files and generators
https://bugs.webkit.org/show_bug.cgi?id=123426
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-29
Reviewed by Timothy Hatcher.
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- inspector/Inspector-0.1.json: Removed.
- inspector/Inspector-1.0.json: Removed.
- inspector/generate-inspector-protocol-version: Removed.
- 11:26 AM Changeset in webkit [158202] by
-
- 2 edits in trunk/LayoutTests
fast/forms/form-associated-element-removal.html can crash because of an underlying
media bug.
- platform/mac-wk2/TestExpectations:
- 11:04 AM Changeset in webkit [158201] by
-
- 6 edits in branches/safari-537.73-branch/Source
Cleanups to get r154508 to build cleanly in Actinium branch.
- 10:53 AM Changeset in webkit [158200] by
-
- 13 edits in trunk/Source/WebCore
[GTK] DOM bindings documentation errors
https://bugs.webkit.org/show_bug.cgi?id=123448
Reviewed by Carlos Garcia Campos.
- bindings/gobject/WebKitDOMCustom.h: Basic documentation for
return types.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction): Generate Returns documentation tag for
non-void return types and provide basic documentation.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
Reset tests results.
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
- bindings/scripts/test/GObject/WebKitDOMTestException.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
- bindings/scripts/test/GObject/WebKitDOMattribute.h:
- 10:47 AM Changeset in webkit [158199] by
-
- 4 edits in trunk/Tools
[Mac] Rationalize user defaults override code
https://bugs.webkit.org/show_bug.cgi?id=123436
Reviewed by Dan Bernstein.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues): Renamed from resetDefaultsToConsistentValues,
because this function only resets WebPreferences now.
(setDefaultsToConsistentValuesForTesting): Moved code for setting the defaults
here, because tests never change them, and they only need to be set once, not
before each test. Removed long obsolete workaround for HIToolbox preferences.
Don't call resetWebPreferencesToConsistentValues, because it will be called before
the first test anyway.
(main): Don't set AppleMagnifiedMode here, moved that to setDefaultsToConsistentValuesForTesting.
(resetWebViewToConsistentStateBeforeTesting): Moved TestRunner::setSerializeHTTPLoads
and setlocale calls out of resetWebPreferencesToConsistentValues().
Added AppleAquaAntiAliasingChanged notification that we had in WK2, because it's
also needed in WK1.
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize): Use literal syntax for defaults
dictionary.
- WebKitTestRunner/mac/main.mm:
(setDefaultsToConsistentValuesForTesting): Factored out of main(), and changed to
use NSArgumentDomain for everything.
- 10:40 AM Changeset in webkit [158198] by
-
- 11 edits2 adds in trunk
Source/WebCore: Invalid cast in WebCore::toRenderMathMLBlock
https://bugs.webkit.org/show_bug.cgi?id=121728
rdar://problem/15046151
Reviewed by Dean Jackson.
Tested by: mathml/arbitrary-markup.html
- dom/Element.h: Expose childShouldCreateRenderer for
MathML as well as SVG builds.
- dom/Node.h:
(WebCore::Node::isMathMLElement): Added.
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::create): Create as MathML Element.
(WebCore::MathMLElement::childShouldCreateRenderer):
Only allow the child to emit a renderer if it is a
MathML element.
- mathml/MathMLElement.h:
LayoutTests: [MathML] invalid cast in WebCore::toRenderMathMLBlock
https://bugs.webkit.org/show_bug.cgi?id=121728
Reviewed by Dean Jackson.
- mathml/arbitrary-markup-expected.txt: Added.
- mathml/arbitrary-markup.html: Added.
- mathml/mfenced-root-layer.html: Modified to avoid invalid
use of arbitrary markup inside mfenced element.
- mathml/mfenced-root-layer-expected.txt: Rebaselined.
- 10:17 AM Changeset in webkit [158197] by
-
- 8 edits in trunk/Source/WebCore
SVG: applyStrokeStyleToContext should take a RenderElement&.
<https://webkit.org/b/123447>
..and a RenderStyle& too, for that matter.
Reviewed by Anders Carlsson.
- rendering/svg/SVGRenderSupport.h:
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::applyStrokeStyleToContext):
Have this take a RenderElement& and RenderStyle& instead of
raw pointers. Tweaked a silly-looking loop.
- rendering/svg/RenderSVGShape.h:
- rendering/svg/RenderSVGShape.cpp:
Moved BoundingRectStrokeStyleApplier helper class into the
cpp file since it wasn't being used anywhere else.
- rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
- rendering/svg/RenderSVGResourceSolidColor.cpp:
(WebCore::RenderSVGResourceSolidColor::applyResource):
Remove ampersands.
- 10:00 AM Changeset in webkit [158196] by
-
- 5 edits in trunk/Source/WebCore
Multiple runs per line on simple line path
https://bugs.webkit.org/show_bug.cgi?id=123446
Reviewed by Andreas Kling.
By allowing multiple runs per line we can support text flows with consecutive whitespaces in the middle.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
Remove space test.
The improved test coverage found a few more cases that we need to disallow.
(WebCore::SimpleLineLayout::adjustRunOffsets):
Round the run positions and widths so they match line boxes.
Adjust for text-align.
(WebCore::SimpleLineLayout::create):
Split lines with consecutive spaces into runs.
- rendering/SimpleLineLayout.h:
(WebCore::SimpleLineLayout::Run::Run):
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::hitTestFlow):
(WebCore::SimpleLineLayout::collectFlowOverflow):
(WebCore::SimpleLineLayout::computeTextBoundingBox):
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::Iterator::resolver):
(WebCore::SimpleLineLayout::RunResolver::Iterator::lineIndex):
(WebCore::SimpleLineLayout::RunResolver::Run::Run):
(WebCore::SimpleLineLayout::RunResolver::Run::rect):
(WebCore::SimpleLineLayout::RunResolver::Run::baseline):
(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::Run::lineIndex):
(WebCore::SimpleLineLayout::RunResolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::RunResolver::Iterator::operator++):
Removed unnecessary operators.
(WebCore::SimpleLineLayout::RunResolver::Iterator::operator==):
(WebCore::SimpleLineLayout::RunResolver::Iterator::operator!=):
(WebCore::SimpleLineLayout::RunResolver::Iterator::operator*):
(WebCore::SimpleLineLayout::RunResolver::Iterator::simpleRun):
(WebCore::SimpleLineLayout::RunResolver::RunResolver):
(WebCore::SimpleLineLayout::RunResolver::begin):
(WebCore::SimpleLineLayout::RunResolver::end):
Resolver -> RunResolver
(WebCore::SimpleLineLayout::LineResolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator++):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator==):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator!=):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator*):
(WebCore::SimpleLineLayout::LineResolver::LineResolver):
(WebCore::SimpleLineLayout::LineResolver::begin):
(WebCore::SimpleLineLayout::LineResolver::end):
Add LineResolver around RunResolver. It resolves the line rectangles.
(WebCore::SimpleLineLayout::runResolver):
(WebCore::SimpleLineLayout::lineResolver):
- 9:40 AM Changeset in webkit [158195] by
-
- 6 edits2 adds in trunk
AX: elements with explicit tabindex should expose AXFocused as writable, since mouse clicks can focus it
https://bugs.webkit.org/show_bug.cgi?id=121335
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Re-order logic that determines if a <span> should appear as an accessible element.
The change is that if an element canSetFocus() it should always be in the AX tree.
Test: accessibility/tabindex-elements-are-accessible.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
LayoutTests:
- accessibility/tabindex-elements-are-accessible-expected.txt: Added.
- accessibility/tabindex-elements-are-accessible.html: Added.
New test to ensure that if tabindex is on an element, it is in the AX tree.
- platform/mac/accessibility/table-with-row-col-of-headers-expected.txt:
- platform/mac/accessibility/table-with-row-col-of-headers.html:
Update to reflect that if an ignored <table> has a tabindex, then it should at least be an AXGroup
- platform/mac/accessibility/update-children-when-aria-role-changes.html:
Update so that the <span> elements being used don't have tabindex, which forces them to be in the AX tree,
which changes the output of the test (basically we'd need to query the child of those elements instead).
- 9:32 AM Changeset in webkit [158194] by
-
- 4 edits in trunk
[GTK] enable media-stream in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=123144
Reviewed by Martin Robinson.
Source/WebCore:
- GNUmakefile.list.am: Add new MediaStream files to the GTK port build.
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable media-stream build
for the GTK+ port.
- 9:01 AM Changeset in webkit [158193] by
-
- 5 edits in trunk
AX: Webkit does not expose AXRequired on input type=file
https://bugs.webkit.org/show_bug.cgi?id=123376
Reviewed by Mario Sanchez Prada.
Source/WebCore:
File upload buttons should expose AXRequired, since they take an input state.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute):
(WebCore::AccessibilityNodeObject::alternativeText):
LayoutTests:
Modify existing test case to test for file upload buttons.
- accessibility/html5-required-attribute-expected.txt:
- accessibility/html5-required-attribute.html:
- 5:42 AM Changeset in webkit [158192] by
-
- 2 edits in trunk/Tools
EFL 32 bit buildbot doesn't work on dashboard
https://bugs.webkit.org/show_bug.cgi?id=123435
Reviewed by Csaba Osztrogonác.
32 bit buildbot doesn't work on dashboard because name is different from buildbot list.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- 3:39 AM Changeset in webkit [158191] by
-
- 1 copy in releases/WebKitGTK/webkit-2.3.1
Tagging the WebKitGTK+ 2.3.1 release
- 3:18 AM Changeset in webkit [158190] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Fix the ChangeLog landed in r158185. The RemoteLayerTreeTextStream class is affected, not RemoteLayerTreeTransaction.
- 3:12 AM Changeset in webkit [158189] by
-
- 4 edits in trunk
Unreviewed. Update NEWS and Versions.m4 for 2.3.1 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.3.1.
- 2:56 AM Changeset in webkit [158188] by
-
- 4 edits in trunk/Source
Re-enable simple line layout for EFL
https://bugs.webkit.org/show_bug.cgi?id=123402
Reviewed by Antti Koivisto.
Source/WebCore:
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor): 8-bit TextRun support is now enabled for EFL port, so the port
can use the simple line layout.
Source/WTF:
- wtf/FeatureDefines.h: Enable 8-bit TextRun support for EFL port.
- 2:32 AM Changeset in webkit [158187] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, follow-up to r158185. Export the required symbol.
This should fix the Mac debug build.
- WebCore.exp.in:
- 1:38 AM Changeset in webkit [158186] by
-
- 5 edits2 adds in trunk
Text selected with double-click gets unselected after DOM modification
https://bugs.webkit.org/show_bug.cgi?id=114227
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-29
Reviewed by Ryosuke Niwa.
Source/WebCore:
Before this patch when selection is done by double-click (start and base remain
same) and DOM is modified then selection gets vanished. This does not
happen when selection is done by dragging mouse. This happens because
on double-click base and extent remain the same and on DOM
modification we update the selection with base and extent, so we loose
the selection. Since in double-click case start/end contain the
correct selection, same should be used after dom modification to
update selection.
Test: editing/selection/double-click-selection-with-dom-mutation.html
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::textWasReplaced): use start/end to update
selection in case double click selection. Added a check for base !=
extent, if base != extent use base/extent to update the selection
otherwise use start/end with directionality check.
LayoutTests:
New Testcase to test that selection remain intact when selection is
created by double-click and then dom is modified.
- editing/selection/double-click-selection-with-dom-mutation-expected.txt: Added.
- editing/selection/double-click-selection-with-dom-mutation.html: Added.
Rebaselined the below test cases.
- platform/mac/editing/deleting/smart-delete-003-expected.txt:
- platform/mac/editing/deleting/smart-delete-004-expected.txt:
- 1:34 AM Changeset in webkit [158185] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed Mac debug build fix after r158183.
Remove the duplicated << overloaded operator from RemoteLayerTreeTransaction for printing out
a given FloatSize object. The RemoteLayerTreeTransaction inherits from TextStream, which already
provides that overloaded operator. Format of the output is a bit different so hopefully nothing
breaks further.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTextStream::operator<<):
- 1:23 AM Changeset in webkit [158184] by
-
- 16 edits2 copies4 moves5 adds23 deletes in trunk
[CSSRegions] Display anonymous regions in DRT
https://bugs.webkit.org/show_bug.cgi?id=122963
Reviewed by Alexandru Chiculita.
After https://bugs.webkit.org/show_bug.cgi?id=119135, css regions are modelled using an anonymous
RenderNamedFlowFragment object inside the block having a valid -webkit-flow-from.
This patch changes the way elements | pseudo-elements with -webkit-flow-from are displayed
in test dumps.
Source/WebCore:
Before:
RenderRegion {DIV} at (200,200) size 52x52 [border: (1px solid #000000)]
After:
RenderBlock (positioned) {DIV} at (200,200) size 52x52 [border: (1px solid #000000)]
RenderNamedFlowFragment at (1,1) size 50x50
Before:
Flow Threads
Thread with flow-name 'article'
Regions for flow 'article'
RenderRegion {DIV} #region_1
RenderRegion {DIV} #region_2
After:
Named flows
Named flow 'article'
Regions for named flow 'article'
RenderNamedFlowFragment (anonymous child of {DIV::before} #region_1)
RenderNamedFlowFragment (anonymous child of {DIV} #region_2)
Changed existing tests based on the new dumps.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::renderName):
- rendering/RenderNamedFlowFragment.h: Add a comment explaining the purpose of the class.
- rendering/RenderRegion.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::writeRenderRegionList): Adjust function to display info for anonymous regions too.
(WebCore::writeRenderNamedFlowThreads): Separate dump of valid and invalid regions for a named flow.
LayoutTests:
Changed expected files for mac port, removed expectations for gtk | efl and added [Missing]
in TestExpectations for these platforms. Results need to be generated again for the [Missing] lines.
- fast/regions/auto-size/autoheight-regions-mark-expected.txt: Removed.
- fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- fast/regions/flows-dependency-same-flow-expected.txt: Removed.
- platform/efl/TestExpectations:
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/region-dynamic-after-before-expected.txt: Removed.
- platform/efl/fast/regions/region-generated-content-before-after-expected.txt: Removed.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed.
- platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Removed.
- platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Removed.
- platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/gtk/TestExpectations:
- platform/gtk/fast/regions/flows-dependency-same-flow-expected.png: Removed.
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/gtk/fast/regions/region-dynamic-after-before-expected.txt: Removed.
- platform/gtk/fast/regions/region-generated-content-before-after-expected.txt: Removed.
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed.
- platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Removed.
- platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Removed.
- platform/mac/fast/regions/auto-size/autoheight-regions-mark-expected.png: Copied from LayoutTests/fast/regions/flows-dependency-same-flow-expected.png.
- platform/mac/fast/regions/auto-size/autoheight-regions-mark-expected.txt: Added.
- platform/mac/fast/regions/autoheight-regions-mark-expected.png: Removed.
- platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
- platform/mac/fast/regions/flows-dependency-same-flow-expected.png: Copied from LayoutTests/fast/regions/flows-dependency-same-flow-expected.png.
- platform/mac/fast/regions/flows-dependency-same-flow-expected.txt: Added.
- platform/mac/fast/regions/iframe-html-collected-expected.png: Renamed from LayoutTests/fast/regions/flows-dependency-same-flow-expected.png.
- platform/mac/fast/regions/iframe-html-collected-expected.txt: Renamed from LayoutTests/fast/regions/iframe-html-collected-expected.txt.
- platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
- platform/mac/fast/regions/region-dynamic-after-before-expected.txt:
- platform/mac/fast/regions/region-generated-content-before-after-expected.txt:
- platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
- platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Renamed from LayoutTests/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt.
- platform/mac/fast/repaint/region-painting-invalidation-expected.txt:
- platform/mac/fast/repaint/region-painting-via-layout-expected.txt: Renamed from LayoutTests/fast/repaint/region-painting-via-layout-expected.txt.
- 12:50 AM Changeset in webkit [158183] by
-
- 28 edits in trunk/Source/WebCore
Move writeIndent, overloaded << operators from RenderTreeAsText to TextStream
https://bugs.webkit.org/show_bug.cgi?id=116012
Reviewed by Simon Fraser.
The writeIndent method and overloaded << operators for writing out vectors and points and rectangles
of various types are not specific to the render tree nor do they depend on any rendering-specific interface.
- page/scrolling/ScrollingStateNode.cpp:
- page/scrolling/ScrollingStateNode.h:
(ScrollingStateNode): Remove the writeIndent declaration, it's functionally the same as the TextStream method.
- platform/graphics/GraphicsLayer.cpp:
- platform/graphics/GraphicsLayer.h:
(GraphicsLayer): Ditto.
- platform/graphics/filters/DistantLightSource.cpp: Remove the RenderTreeAsText.h inclusion or replace it with
the inclusion of the TextStream.h header where required. The writeIndent method is now declared there.
- platform/graphics/filters/FEBlend.cpp: Ditto.
- platform/graphics/filters/FEColorMatrix.cpp: Ditto.
- platform/graphics/filters/FEComponentTransfer.cpp: Ditto.
- platform/graphics/filters/FEComposite.cpp: Ditto.
- platform/graphics/filters/FEConvolveMatrix.cpp: Ditto.
- platform/graphics/filters/FECustomFilter.cpp: Ditto.
- platform/graphics/filters/FEDiffuseLighting.cpp: Ditto.
- platform/graphics/filters/FEDisplacementMap.cpp: Ditto.
- platform/graphics/filters/FEDropShadow.cpp: Ditto.
- platform/graphics/filters/FEFlood.cpp: Ditto.
- platform/graphics/filters/FEGaussianBlur.cpp: Ditto.
- platform/graphics/filters/FEMerge.cpp: Ditto.
- platform/graphics/filters/FEMorphology.cpp: Ditto.
- platform/graphics/filters/FEOffset.cpp: Ditto.
- platform/graphics/filters/FESpecularLighting.cpp: Ditto.
- platform/graphics/filters/FETurbulence.cpp: Ditto.
- platform/graphics/filters/SourceAlpha.cpp: Ditto.
- platform/graphics/filters/SourceGraphic.cpp: Ditto.
- platform/text/TextStream.cpp: Move the writeIndent and operators' definitions here.
(WebCore::operator<<):
(WebCore):
(WebCore::writeIndent):
- platform/text/TextStream.h: Move the writeIndent and operators' declarations here.
(WebCore):
(TextStream):
(WebCore::TextStream::operator<<):
- rendering/RenderTreeAsText.cpp: Move the writeIndent and operators' definitions into TextStream.
(WebCore):
- rendering/RenderTreeAsText.h: Move the writeIndent and operators' declarations into TextStream.
(WebCore):
- 12:42 AM Changeset in webkit [158182] by
-
- 4 edits in trunk/Source/WebCore
Clean up ScopedEventQueue
https://bugs.webkit.org/show_bug.cgi?id=123408
Reviewed by Darin Adler.
Clean up the ScopedEventQueue implementation. ScopedEventQueue::instance() should return a reference to a
NeverDestroyed<ScopedEventQueue> object. The static ScopedEventQueue::s_instance pointer is removed.
The ScopedEventQueue destructor, the dispatchAllEvents method and the scope level incrementation/decrementation
methods are made private. NeverDestroyed<ScopedEventQueue> and EventQueueScope are made friends of the
ScopedEventQueue class so they can access the constructor and the incrementation/decrementation methods, respectively.
ScopedEventQueue method definitions are reordered to follow the order of their declarations in the header file.
ScopedEventQueue::dispatchAllEvents() now uses std::move to efficiently dispatch and clear all currently queued events.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchScopedEvent):
- dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::instance):
(WebCore::ScopedEventQueue::dispatchAllEvents):
- dom/ScopedEventQueue.h:
(WebCore::EventQueueScope::EventQueueScope):
(WebCore::EventQueueScope::~EventQueueScope):
