Timeline
Jul 7, 2002:
- 2:57 AM Changeset in webkit [1518] by
-
- 20 edits in trunk
WebCore:
WebCore part of fix for Radar 2953431 - JavaScript window.close()
method is not working
- khtml/ecma/kjs_window.cpp: (Window::scheduleClose): In AppleChanges
- khtml/khtml_part.cpp: (KHTMLPart::openedByJS): Call kwq implementations, because we need to remember the openedByJS state across location changes, which in our case means replacing the part. (KHTMLPart::setOpenedByJS): Likewise.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::openedByJS): Implement by calling bridge. (KWQKHTMLPartImpl::setOpenedByJS): Likewise. (KWQKHTMLPartImpl::close): Likewise.
- kwq/KWQKHTMLPartImpl.h: Prototype new PartImpl methods.
- kwq/WebCoreBridge.h: Prototype new bridge methods.
WebKit:
WebCore part of fix for Radar 2953431 - JavaScript window.close()
method is not working
- WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge openedByScript]): Implement by calling controller. (-[IFWebCoreBridge setOpenedByScript:]): Likewise.
- WebView.subproj/IFWebControllerPrivate.h:
- WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _openedByScript]): Implement. (-[IFWebController _setOpenedByScript:]): Implement.
Jul 6, 2002:
- 12:41 AM Changeset in webkit [1517] by
-
- 7 edits in trunk/WebCore
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::write): Remove reference to nonexistent class in a comment.
- kwq/KWQKHTMLPartImpl.h: Remove unused and unimplemented getDataSource().
Jul 5, 2002:
- 11:06 AM Changeset in webkit [1516] by
-
- 10 edits in trunk/WebKit
Fix crashes I saw with zombies enabled caused by messing with windows that are
in the process of being destroyed.
- Plugins.subproj/IFPluginView.mm: (-[IFPluginView start]): Remove windowWillClose notification because we use viewDidMoveToWindow instead. (-[IFPluginView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
- WebView.subproj/IFHTMLView.mm: (-[IFHTMLView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
- WebView.subproj/IFHTMLViewPrivate.h: Need a boolean flag to tell window changes before the first time we are installed from window changes afterward.
- WebView.subproj/IFImageView.m: (-[IFImageView viewDidMoveToWindow]): Use this instead of viewWillMoveToWindow.
Jul 4, 2002:
- 6:15 PM Changeset in webkit [1515] by
-
- 5 edits in trunk/WebCore
Say "Go to" instead of "Link to" for links that won't open a new
window. Also, the code is now set up to change the status text
when modifier keys are pressed, but the code is disabled for now
because it's impossible to do reliably.
- khtml/khtml_part.cpp: (KHTMLPart::overURL): (KHTMLPart::khtmlMouseMoveEvent):
- khtml/khtml_part.h:
- 6:08 PM Changeset in webkit [1514] by
-
- 4 edits in trunk/WebKit
- WebView.subproj/IFHTMLView.mm: (-[IFHTMLView mouseMovedNotification:]): Pass the modifier flags along for mouse move events.
- 1:21 PM Changeset in webkit [1513] by
-
- 4 edits in trunk/WebKit
WebKit:
- WebView.subproj/IFDynamicScrollBarsView.h: Updated FIXME to mention bug number.
WebBrowser:
- finished a few details for 2953570 and 2953580 -- Open and Reveal in Downloads window don't handle missing-file case well
- fixed 2981774 -- Status bar text not centered vertically
- removed vestiges of ancient mechanism for swapping browser window view between webview & search modes
- English.lproj/Browser.nib: Made the status bar a few pixels shorter. We may decide that it looks bad for it to be a different height than the favorites bar, but Don wanted to try this. Also made IFWebView a direct subview of the window's contentView, and eliminated the extra views that were part of the ancient web/search mode mechanism.
- BrowserWindow.h: Removed tabView outlet.
- BrowserWindow.m: (-[BrowserWindow toggleFavoritesBarWithAnimation:]): (-[BrowserWindow toggleStatusBarWithAnimation:]): Made these methods use webView instead of tabView.
- DownloadMonitor.m: (-[DownloadMonitor _canOpenSelectedDownloads]): (-[DownloadMonitor _canStopSelectedDownloads]): (-[DownloadMonitor _canRevealSelectedDownloads]): (-[DownloadMonitor _canForgetSelectedDownloads]): Renamed these from "_totalSelectedAndXXXXable" and made them return BOOLs rather than ints, since that's all the callers cared about. Made them (except _canReveal) return as soon as a single valid entry is found (_canReveal has to make sure there is exactly one valid entry). Made _canOpen and _canReveal return YES even if file doesn't exist, so that the user will get the explanatory message if they click on Open or Reveal in this case.
(-[DownloadMonitor validateUserInterfaceItem:]):
Updated for method name and return-value changes; restructured so that it returns
as soon as the right selector is checked, rather than continuing to check against
other selectors.
(-[DownloadMonitor _showMissingFileErrorForOperation:andFile:]): Removed this
method; it was constructing messages using substitution patterns that might
not work in other languages.
(-[DownloadMonitor openSelectedDownloads:]):
Made the error message handle the multiple-missing-files case properly; let
all openable items be opened regardless of how many unopenable items there are
(formerly bailed at the first unopenable item). Moved sheet-displaying code
for this case into here.
(-[DownloadMonitor revealSelectedDownloads:]): Moved sheet-displaying code
for this case into here.
