Timeline
Jul 27, 2002:
- 9:14 AM Changeset in webkit [1686] by
-
- 19 edits in trunk/WebKit
WebKit:
Implemented click policy, support for option-click
Implemented dragging of links and images from WebHTMLView
- Misc.subproj/WebNSViewExtras.h:
- Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:]): added, moved from WebBrowser (-[NSView _web_dragOperationForDraggingInfo:]): don't accept drag if source == destination
- WebView.subproj/WebControllerPolicyHandler.h:
- WebView.subproj/WebControllerPolicyHandler.m: (-[WebPolicy URL]): needed for click policy (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
- WebView.subproj/WebControllerPrivate.h:
- WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:toPath:]): added, simply downloads a URL
- WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler downloadURL:]): calls [WebController _downloadURL:toPath:]
- WebView.subproj/WebDefaultPolicyHandler.m: (-[WebDefaultPolicyHandler clickPolicyForElement:button:modifierMask:]):
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): calls _continueAfterCheckingDragForEvent (-[WebHTMLView mouseUp:]): calls _continueAfterClickPolicyForEvent (-[WebHTMLView draggingSourceOperationMaskForLocal:]): added (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): added, starts download
- WebView.subproj/WebHTMLViewPrivate.h:
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView _elementAtPoint:]): (-[WebHTMLView _continueAfterClickPolicyForEvent:]): added, implements click policy (-[WebHTMLView _continueAfterCheckingDragForEvent:]): added, checks if mouse event is a drag
WebBrowser:
Support for option-click.
Moved _web_dragShouldBeginFromMouseDown:withExpiration: to WebKit
- BrowserWebController.m: (-[BrowserWebController clickPolicyForElement:button:modifierMask:]): support for option and command click
- FavoriteButton.m: (-[FavoriteButton mouseDown:]): call _web_dragShouldBeginFromMouseDown:withExpiration:
- LocationTextField.m: (-[LocationTextField mouseDown:]): call _web_dragShouldBeginFromMouseDown:withExpiration:
Jul 26, 2002:
- 6:37 PM Changeset in webkit [1685] by
-
- 4 edits in trunk/WebCore
WebFoundation:
Changing the default user agent to be Gecko. This fixes
the layout issues with livepage.apple.com. We simply
cannot support absolute positioning while claiming to
be Mac MSIE, since Mac MSIE incorrectly computes the containing
block and sites have to correct for that.
As per discussion with gramps, simply removing the plist lookup
for the agent and hardcoding it to Gecko for now.
- CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler defaultUserAgent]):
- ChangeLog:
- Defaults.plist:
WebCore:
Changing the default user agent to be Gecko. This fixes
the layout issues with livepage.apple.com. We simply
cannot support absolute positioning while claiming to
be Mac MSIE, since Mac MSIE incorrectly computes the containing
block and sites have to correct for that.
- ChangeLog:
- kwq/KWQKProtocolManager.mm: (KProtocolManager::userAgentForHost):
- 4:18 PM Changeset in webkit [1684] by
-
- 2 edits in trunk/WebKit
Fixed comment in changelog.
- 4:18 PM Changeset in webkit [1683] by
-
- 3 edits in trunk/WebKit
WebframeLoadType enum first value was explicitly set, so 0 was used.
I assumed 0 was unitialized, and depended on that to not execute some 'transitional'
back/forward. This problem broke back/forward.
- WebView.subproj/WebFramePrivate.h:
- 3:27 PM Changeset in webkit [1682] by
-
- 4 edits in trunk/WebCore
Fix for 2944382, NOWRAP was being incorrectly applied in KHTML.
It was being ignored incorrectly if a fixed width was specified
on a cell. This width on the cell is actually irrelevant and
should not have been checked, since NOWRAP will affect the
whole column and not just a specific cell.
- khtml/rendering/render_table.cpp: (RenderTableCell::calcMinMaxWidth):
- 3:17 PM Changeset in webkit [1681] by
-
- 8 edits in trunk/WebKit
WebKit:
WebKit part of fix for 3009404 -- Back/Forward menu items should use [ and ],
but command-arrows should still work too.
- WebView.subproj/WebController.h:
- added goForward to windowContext protocol. This is temporary, just like goBack here is temporary; they can be migrated into the new back-forward-in-WebKit design together.
- WebView.subproj/WebView.m: (-[WebView keyDown:]): call _goBack and _goForward for command-arrow keys
- WebView.subproj/WebViewPrivate.h,
- WebView.subproj/WebViewPrivate.m: (-[WebView _goForward]): add _goForward, parallel to _existing goBack.
WebBrowser:
WebBrowser part of fix for 3009404 -- Back/Forward menu items should use [ and ],
but command-arrows should still work too.
- fixed 3009385 -- standard command-arrow shortcuts don't work in Alexander outline views
- fixed 3009388 -- left and right arrow should collapse/expand in Alexander outline views
- BrowserWebController.m: (-[BrowserWebController goForward]): Added, parallel to existing goBack. This is a temporary place for this API, awaiting WebKit cleanup.
- Defaults.plist: Set NSAllowSimpleArrowItemExpandDefault to true; gotta love that this exists.
- English.lproj/MainMenu.nib: Change menu shortcuts for Back, Forward, and Last Search Results to use brackets instead of arrows
- Help/KeyShortcuts.html: Update to match arrow -> bracket changes.
- 12:59 PM Changeset in webkit [1680] by
-
- 6 edits in trunk/WebKit
Fixed crash in unknown_text
Fixed full-window plug-ins. I think darin broken this :)
Cleaned up WebPluginStream a bit
- Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase init]):
- Plugins.subproj/WebPluginStream.m: (-[WebPluginStream getFunctionPointersFromPluginView:]): (-[WebPluginStream initWithURL:pluginPointer:notifyData:attributes:]): (-[WebPluginStream startLoad]): (-[WebPluginStream stop]): (-[WebPluginStream setUpGlobalsWithHandle:]): (-[WebPluginStream receivedError:]): (-[WebPluginStream receivedData:withDataSource:]): (-[WebPluginStream receivedError:withDataSource:]): (-[WebPluginStream WebResourceHandle:dataDidBecomeAvailable:]): (-[WebPluginStream WebResourceHandleDidCancelLoading:]): (-[WebPluginStream WebResourceHandle:didFailLoadingWithResult:]):
- WebView.subproj/WebDataSourcePrivate.h:
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _mainHandle]): added, WebPluginStream needs this
Jul 25, 2002:
- 8:44 PM Changeset in webkit [1679] by
-
- 9 edits in trunk/WebKit
More incremental changes for back/forward migration.
- BackForwardListEntry.h:
- BackForwardListEntry.m:
More incremental changes for back/forward migration.
- History.subproj/WebBackForwardList.h:
- History.subproj/WebBackForwardList.m: (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList addEntry:]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goBackToIndex:]): (-[WebBackForwardList backEntry]): (-[WebBackForwardList currentEntry]): (-[WebBackForwardList forwardEntry]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goForwardToIndex:]): (-[WebBackForwardList canGoBack]): (-[WebBackForwardList canGoForward]): (-[WebBackForwardList description]):
- History.subproj/WebHistoryItem.h:
- History.subproj/WebHistoryItem.m: (-[WebHistoryItem initWithURL:title:]): (-[WebHistoryItem initWithURL:title:image:]): (-[WebHistoryItem initWithURL:target:title:image:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem target]): (-[WebHistoryItem setTarget:]): (-[WebHistoryItem setLastVisitedDate:]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem setScrollPoint:]):
- History.subproj/WebHistoryList.m:
- WebView.subproj/WebFramePrivate.h:
- WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate setLoadType:]): (-[WebFrame _setLoadType:]): (-[WebFrame _loadType]): (-[WebFrame _transitionToCommitted]):
- 7:26 PM Changeset in webkit [1678] by
-
- 12 edits4 adds in trunk/WebKit
Made some WebPolicy API's private
Added support for download link/image to disk
- Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]):
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebControllerPolicyHandler.h:
- WebView.subproj/WebControllerPolicyHandler.m: (-[WebPolicyPrivate dealloc]): (-[WebPolicy _setPolicyAction:]): (-[WebPolicy policyAction]): (-[WebPolicy path]): (-[WebPolicy _setPath:]): (-[WebPolicy dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]): (+[WebClickPolicy webPolicyWithClickAction:andPath:]):
- WebView.subproj/WebControllerPolicyHandlerPrivate.h: Added.
- WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler downloadURL:]): (-[WebDefaultContextMenuHandler downloadLinkToDisk:]): (-[WebDefaultContextMenuHandler openImageInNewWindow:]): (-[WebDefaultContextMenuHandler downloadImageToDisk:]):
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):
- 6:14 PM Changeset in webkit [1677] by
-
- 9 edits in trunk/WebKit
Fixed crasher caused by not retaining the content policy.
- WebView.subproj/WebControllerPolicyHandler.h:
- WebView.subproj/WebMainResourceClient.h:
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):
- 5:56 PM Changeset in webkit [1676] by
-
- 23 edits1 add in trunk/WebKit
WebKit:
Made policy APIs return a WebPolicy object.
Added click policy.
- Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]): (-[WebDownloadHandler finishedLoading]): (-[WebDownloadHandler cancel]):
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebController.h:
- WebView.subproj/WebController.m: (+[WebController defaultURLPolicyForURL:]):
- WebView.subproj/WebControllerPolicyHandler.h:
- WebView.subproj/WebControllerPolicyHandler.m: Added. (-[WebPolicy initWithPolicyAction:]): (-[WebPolicy policyAction]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]): (-[WebContentPolicy initWithContentPolicyAction:andPath:]): (-[WebContentPolicy dealloc]): (-[WebContentPolicy path]): (-[WebClickPolicy initWithClickPolicyAction:andPath:]): (+[WebClickPolicy webPolicyWithClickAction:andPath:]): (-[WebClickPolicy dealloc]): (-[WebClickPolicy path]):
- WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]):
- WebView.subproj/WebDataSource.h:
- WebView.subproj/WebDataSource.m: (-[WebDataSource contentPolicy]): (-[WebDataSource fileType]):
- WebView.subproj/WebDataSourcePrivate.h:
- WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setContentPolicy:]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _isReadyForData]):
- WebView.subproj/WebDefaultPolicyHandler.m: (-[WebDefaultPolicyHandler URLPolicyForURL:]): (-[WebDefaultPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultPolicyHandler unableToImplementFileURLPolicy:error:forDataSource:]): (-[WebDefaultPolicyHandler unableToImplementURLPolicy:error:forURL:]): (-[WebDefaultPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]): (-[WebDefaultPolicyHandler clickPolicyForElement:button:modifierMask:]):
- WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]):
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowDataSource:]):
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedProgressWithHandle:complete:]): (-[WebMainResourceClient receivedError:forHandle:]): (-[WebMainResourceClient WebResourceHandleDidFinishLoading:data:]): (-[WebMainResourceClient WebResourceHandle:dataDidBecomeAvailable:]):
WebBrowser:
Made policy APIs return a WebPolicy object.
- BrowserDocument.m: (-[BrowserDocument _stopNonDownloadingDataSource:]): (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]):
- BrowserWebController.m: (-[BrowserWebController URLPolicyForURL:]): (-[BrowserWebController unableToImplementURLPolicy:error:forURL:]): (-[BrowserWebController fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[BrowserWebController unableToImplementFileURLPolicy:error:forDataSource:]): (-[BrowserWebController contentPolicyForMIMEType:dataSource:]): (-[BrowserWebController unableToImplementContentPolicy:error:forDataSource:]): (-[BrowserWebController clickPolicyForElement:button:modifierMask:]):
- DownloadMonitor.m: (-[DownloadMonitor _monitorDownload:withProgress:error:dataSource:complete:]):
- DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithResource:progress:error:dataSource:]):
- 5:17 PM Changeset in webkit [1675] by
-
- 3 edits in trunk/WebCore
Remove bogus change log entry that I checked in by accident.
- 5:04 PM Changeset in webkit [1674] by
-
- 19 edits in trunk
top level:
- configure.in: Add DeploymentFat build style.
- JavaScriptCore.pbproj/project.pbxproj: Add DeploymentFat build style.
WebFoundation:
- WebFoundation.pbproj/project.pbxproj: Add DeploymentFat build style.
WebCore:
- WebCore.pbproj/project.pbxproj: Add DeploymentFat build style.
- fixed 3007532 -- Main documentation frame doesn't load on Apple docs page
This was caused by my recent fix for the "checkboxes in wrong place" bug.
While discussing that bug fix with Richard, I realized that I needed to do the
work at layout time, not print time. Luckily, this code ends up being simpler
than the original solution.
- khtml/rendering/render_replaced.cpp: (RenderWidget::resizeWidget): Take out size limits based on X limits. (RenderWidget::layout): Move widgets off into far away coordinate space when layout happens. They get moved back on to the right position during the print process.
- kwq/KWQKHTMLPartImpl.h:
- kwq/KWQKHTMLPartImpl.mm: Removed paint, buildViewsNotYetAddedSet, viewsNotYetAdded, and addedWidget.
- kwq/KWQScrollView.mm: (QScrollView::addChild): Removed call to addedWidget.
- kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Put the call to the renderer to print back in here, since it's simple again.
- kwq/KWQWidget.mm: (QWidget::internalSetGeometry): Left in a couple of asserts that were useful in narrowing this one down.
WebKit:
- WebKit.pbproj/project.pbxproj: Add DeploymentFat build style.
WebBrowser:
- WebBrowser.pbproj/project.pbxproj: Add DeploymentFat build style.
- 3:53 PM Changeset in webkit [1673] by
-
- 4 edits in trunk/WebCore
Floated images using "align" should have margins to prevent the text from running right
up against them. Matches IE and Mozilla behavior.
- khtml/css/html4.css:
- 3:36 PM Changeset in webkit [1672] by
-
- 4 edits in trunk/WebCore
Fix <blockquote> tags to have top and bottom margins of 1em. This matches the <blockquote>
behavior in Gecko.
- khtml/css/html4.css:
- 3:17 PM Changeset in webkit [1671] by
-
- 23 edits in trunk
WebFoundation:
WebFoundation part of fix for 3006054 -- assert error failingURL != nil
- CacheLoader.subproj/IFURLHandleC.h:
- CacheLoader.subproj/IFURLHandleC.m: (IFURLHandleBackgroundLoadFailedWithResultCode): Call absoluteString. (IFErrorGetFailingURL): Change result type to CFStringRef.
- CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler continueHeaderReadAfterFailureResponseAndCall:]): Call absoluteString.
- CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:isTerminal:]): Call absoluteString.
- Misc.subproj/WebError.h:
- Misc.subproj/WebError.m: (+[WebError errorWithCode:inDomain:failingURL:isTerminal:]): Change type of failingURL to NSString. (-[WebError initWithErrorCode:inDomain:failingURL:isTerminal:]): Change type of failingURL to NSString. (-[WebError failingURL]): Change type to NSString. (-[WebError description]): Don't call absoluteString.
WebCore:
- fixed 2965269 -- sizes reported to progress handler from KWQCheckCacheObjectStatus for images are wrong
- fixed 3006054 -- assert error failingURL != nil
- khtml/misc/loader.h: Add dataSize() and m_dataSize.
- khtml/misc/loader.cpp: (CachedImage::CachedImage): Initialize m_dataSize. (CachedImage::data): Update m_dataSize.
- kwq/kio/jobclasses.h:
- kwq/KWQKjobclasses.mm: Store a KURL instead of an NSURL, because KURL can hold any string.
- kwq/KWQLoaderImpl.mm: (KWQServeRequest): Send an error with [WebCoreBridge reportError:] if the URL is so bad we can't construct an NSURL from it. This is the only case in all our code where we need to have failingURL accept a string. (KWQCheckCacheObjectStatus): If the object is an image, use the dataSize() rather than size(). The size() is a (bad) estimate of how much memory is used in the case of an image, but we want to report the size of the original data.
- kwq/WebCoreBridge.h: Add a [reportError:] method.
WebKit:
WebKit part of fix for 3006054 -- assert error failingURL != nil
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportError:]): New. Passes the error to the controller associated with the dataSource.
- WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:dataSource:]): Call absoluteString. (-[WebSubresourceClient WebResourceHandleDidCancelLoading:]): Call absoluteString.
- WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Call absoluteString.
- WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Don't call absoluteString.
- WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowDataSource:]): Call absoluteString.
- WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandleDidCancelLoading:]): Call absoluteString.
WebBrowser:
WebBrowser part of fix for 3006054 -- assert error failingURL != nil
- BrowserWebController.m: (-[BrowserWebController receivedError:forResourceHandle:partialProgress:fromDataSource:]): Don't call absoluteString.
- DownloadProgressEntry.m: (-[DownloadProgressEntry stop]): Call absoluteString.
- LocationChangeError.m: (-[LocationChangeHandler specializedMessageForError:]): Don't call absoluteString. Also use _web_URLWithString to make a URL to parse out the host part. (-[LocationChangeHandler genericMessageForError:]): Don't call absoluteString.
- 3:11 PM Changeset in webkit [1670] by
-
- 4 edits in trunk/WebCore
Fix for huge white space problem on appleturns.com, bug 2947818. Vertical-align
was being applied to block-level elts in violation of the CSS2 spec. Vertical-align
is only supposed to apply to inline-level elts and table cells. getVerticalPosition
will now bail if the element is block-level.
- khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition):
- 12:50 PM Changeset in webkit [1669] by
-
- 4 edits in trunk/WebKit
WebKit:
Remove reloadImage until its implemented.
- WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
WebBrowser:
Remove reloadImage until its implemented.
- ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
- 12:38 PM Changeset in webkit [1668] by
-
- 15 edits in trunk
WebCore:
- kwq/WebCoreBridge.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): renamed
WebKit:
Renamed elementInfoAtPoint to elementAtPoint
- WebKit.pbproj/project.pbxproj:
- WebView.subproj/WebDefaultContextMenuHandler.h:
- WebView.subproj/WebDefaultContextMenuHandler.m: (+[WebDefaultContextMenuHandler addMenuItemWithTitle:action:target:toArray:]): renamed (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
- WebView.subproj/WebHTMLViewPrivate.h:
- WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]):
WebBrowser:
Added WebBrowser specific contextual menu items.
- BrowserDocument.h:
- BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument setSaveDataSource:]): set the current data source to save (-[BrowserDocument dataRepresentationOfType:]): uses the current data source
- ContextMenuHandler.h: Added.
- ContextMenuHandler.m: Added. (-[ContextMenuHandler dealloc]): (-[ContextMenuHandler _addMenuItemWithAction:fromArray:toArray:]): (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler _window]): (-[ContextMenuHandler _document]): (-[ContextMenuHandler addLinkToBookmarks:]): (-[ContextMenuHandler viewSource:]): (-[ContextMenuHandler savePageAs:]):
- WebBrowser.pbproj/project.pbxproj:
- 12:41 AM Changeset in webkit [1667] by
-
- 5 edits in trunk/WebCore
Fix for bug 2992158, the calendar on www.blog.org in the upper
right was shoved offscreen (and causing a horizontal scrollbar
to be necessary). KHTML was not recomputing the margins for
the table when it became displaced by the float. It was also
mispositioning the float itself.
- khtml/rendering/render_box.h:
- khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::addOverHangingFloats):