Timeline

Sep 17, 2002:

10:12 PM Changeset in webkit [2080] by darin

• 7 edits in trunk/WebCore

• fixed 3025022 -- Crash in KWQKHTMLPartImpl::redirectionTimerStartedOrStopped()

• kwq/WebCoreBridge.mm: (-[WebCoreBridge dealloc]): Set the bridge on the part to nil just in case someone else is holding a reference, so we won't try to dispatch methods to an already-deallocated bridge.

• fixed 3028476 -- illegal instruction crash in KWQTimerCallback timerFired

• khtml/ecma/kjs_window.cpp: (WindowQObject::parentDestroyed): Remove APPLE_CHANGES to avoid calling killTimers(); we can call it now that we have a working implementation.
• khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Remove APPLE_CHANGES that kills timers. All timers are killed by ~QObject now, just as in Qt. (KHTMLView::clear): Remove APPLE_CHANGES to avoid calling killTimers(); we can call it now that we have a working implementation.

• kwq/KWQObject.mm: (QObject::~QObject): Call killTimers(). (QObject::startTimer): Keep a dictionary keyed by QObject, with a dictionary of timers for each, rather than one global dictionary. This makes it efficient to kill all the timers for an object. (QObject::killTimer): Update for new level of dictionary. (QObject::killTimers): Kill all the timers in this object's timer dictionary rather than all timers in the world. (QObject::inherits): Add an ERROR for the case where the class name is unknown.

4:56 PM Changeset in webkit [2079] by darin

• 4 edits in trunk/WebCore

• fixed 3050818 -- Crash in relative-KURL constructor at site with _ in host name

• kwq/KWQKURL.mm: Change _ so that it's allowed in host names. (KURL::KURL): If base URL is invalid, make result invalid too.

4:38 PM Changeset in webkit [2078] by rjw

• 6 edits in trunk/WebCore

• khtml/khtmlview.cpp: (KHTMLView::viewportMouseTripleClickEvent): Added implementation. Same as viewportMouseReleaseEvent except dispatches additional MouseTripleClickEvent event.

(KHTMLView::viewportMouseDoubleClickEvent):
Send extra release event. This emulates Qt
behavior.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]): Don't send extra release event here, instead send it in viewportMouseDoubleClickEvent and also in viewportMouseTripleClickEvent so DOM doesn't get confused.

• kwq/KWQColor.mm: (QColor::hsv): Fixed marklar divide by 0 problemn.

3:50 PM Changeset in webkit [2077] by darin

• 4 edits in trunk/WebKit

Fix bug where image documents were broken.

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): loadStatus of 0 means the whole image is ready, not 0 scan lines; so check > 0, not >= 0.

• WebKit.pbproj/project.pbxproj: Let Project Builder be the boss of me.

3:18 PM Changeset in webkit [2076] by darin

• 16 edits in trunk/WebCore

WebCore:

• fixed 2936933 -- Pages that claim to be UTF-8 but contain invalid sequences do not render at all

Misc. speed improvements. Total 2.6% speedup for cvs-base.

Improvements for signals.

• kwq/KWQChar.mm: (QChar::isSpace): Add fast case for ASCII. (QChar::lower): Add fast case for ASCII. (QChar::upper): Add fast case for ASCII.

• kwq/qt/qcolor.h: Just store RGB values, not NSColor objects.
• kwq/KWQColor.mm: (QColor::QColor): No need to set color to nil. (QColor::name): Use QString::sprintf instead of NSString. (QColor::setNamedColor): Use KWQInvalidColor instead of nil. (QColor::getNSColor): Make an autoreleased NSColor.

• kwq/KWQKHTMLPartImpl.mm: (moveWidgetsAside): Use isWidget() instead of dynamic_cast.

• kwq/KWQSignal.h: use a QValueList instead of a fixed-size array.
• kwq/KWQSignal.mm: (KWQSignal::connect): Append to list. (KWQSignal::disconnect): Remove from list. (KWQSignal::call): Use the QValueList.

• kwq/KWQSlot.mm: (KWQSlot::call): Use static_cast instead of dynamic_cast where possible.

• kwq/qt/qstring.h: Add return value to forceUnicode.
• kwq/KWQString.mm: (QString::fromStringWithEncoding): Implemented using the Text Encoding Converter instead of CFString. (compareIgnoringCaseForASCIIOnly): New function. Faster find. (QString::find): Separate case-sensitive from case-insensitive and speed up both of them. (QString::stripWhiteSpace): Use the new forceUnicode for simplicity. (QString::simplifyWhiteSpace): Ditto. (QString::insert): Ditto. (QString::remove): Ditto. (QString::forceUnicode): Return the unicode pointer. (QString::fill): Use the new forceUnicode for simplicity.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge mouseUp:]): Fix two bugs. First, don't treat a slow click as a double click. Second, deliver a mouse release event even for a double click, as Qt does.

WebBrowser:

Don't update the tool tip rectangles every time we update the
background image. This makes things a little faster.

• TextFieldWithControls.h: Boolean for whether tool tip rectangles are up to date.
• TextFieldWithControls.m: (-[TextFieldWithControls updateToolTips]): Do work only if flag is NO. Set flag to YES when done. (-[TextFieldWithControls backgroundImage]): Don't update the tool tip rectangles here. (-[TextFieldWithControls setFrameOrigin:]): Mark the tool tip rectangles as out of date. (-[TextFieldWithControls setFrameSize:]): Mark the tool tip rectangles as out of date. (-[TextFieldWithControls drawRect:]): Update the tool tips if needed. (-[TextFieldWithControls showRightButton:]): Mark the tool tip rectangles as out of date. (-[TextFieldWithControls setLeftButtonImage:withOrigin:]): Ditto. (-[TextFieldWithControls setRightButtonImage:withOrigin:]): Ditto.

3:10 PM Changeset in webkit [2075] by rjw

• 18 edits in trunk

• History.subproj/WebHistory.h:
• History.subproj/WebHistory.m: (-[WebHistory addEntryForURLString:]): (-[WebHistory containsEntryForURLString:]): Added URL string API. We should remove use of NSURL from this API.

• History.subproj/WebHistoryPrivate.h:
• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate _entryForURLString:]): (-[WebHistoryPrivate containsEntryForURLString:]): Implementation of above.

• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer slowFloatWidthForCharacters:stringLength:fromCharacterPostion:numberOfCharacters:applyRounding:]): Use ((int)(x + (1.0 - FLT_EPSILON))) instead of ceil().

• khtml/css/cssstyleselector.cpp: Fixed bug in KHTML that incorrectly modified '' in fragment part of URL.

• kwq/KWQKHistoryProvider.mm: Use string based API to add entry. May eventually remove NSURL from history entirely.

• kwq/KWQKURL.mm: (KURL::canonicalURL): Simply return the urlString.

(KURL::parse):
Added "/" to http and https empty path URLs.

• kwq/KWQString.mm: (QString::mid): Optimize ascii case.

• kwq/WebCoreHistory.h:
• kwq/WebCoreHistory.m: (-[WebCoreHistory addEntryForURLString:]): Use string based API to add entry.

• kwq/kdecore/kurl.h: Defined methods to access canonical components, currently conditionally excluded.

No longer commit history in the browser, now done in WebKit.

• BrowserDocument.m:
• LocationChangeHandler.m: (-[LocationChangeHandler locationChangeCommittedForDataSource:]):

Sep 16, 2002:

6:24 PM Changeset in webkit [2074] by darin

• 3 edits in trunk/WebKit

• History.subproj/WebHistoryPrivate.m: Do that for real.

4:23 PM Changeset in webkit [2073] by rjw

• 5 edits in trunk/WebKit

Remove fix (according to John, partial fix) for 3051288.
Canonicalizing the URL strings used in the history db
is very slow! ~8% slower.

• History.subproj/WebHistoryPrivate.m: (-[WebHistoryPrivate addEntry:]): (-[WebHistoryPrivate removeEntry:]): (-[WebHistoryPrivate containsURL:]): (-[WebHistoryPrivate entryForURL:]):

• WebView.subproj/WebHTMLView.h: Removed cruft from header.

12:17 PM Changeset in webkit [2072] by hyatt

• 5 edits in trunk/WebCore

Fix the stylesheet loading regression on rubyfruit.

• khtml/html/html_headimpl.cpp: (HTMLStyleElementImpl::HTMLStyleElementImpl): (HTMLStyleElementImpl::childrenChanged): (HTMLStyleElementImpl::isLoading):
• khtml/html/html_headimpl.h:

8:09 AM Changeset in webkit [2071] by darin

• 3 edits in trunk/WebKit

• fixed 3050810 -- while an image is loading progressively, it draws white rather then page background

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer drawClippedToValidInRect:fromRect:]): Added. Used instead of a direct call to drawInRect:fromRect:operation:fraction:, this only draws the part of the image that is valid according to loadStatus. (-[WebImageRenderer nextFrame:]): Use drawClippedToValidInRect:fromRect:. (-[WebImageRenderer beginAnimationInRect:fromRect:]): Ditto. (-[WebImageRenderer tileInRect:fromPoint:]): Ditto.