Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 7, 2002:

5:00 PM Changeset in webkit [2271] by darin

• 5 edits in trunk/WebCore

• fixed 3037353 -- align="middle" elements not horizontally centered

• khtml/html/html_blockimpl.cpp: (HTMLDivElementImpl::parseAttribute):
• khtml/html/html_tableimpl.cpp: (HTMLTablePartElementImpl::parseAttribute): Handle "middle" same as center in these two places.

3:20 PM Changeset in webkit [2270] by darin

• 9 edits in trunk

WebFoundation:

WebFoundation part of implementation of multipart forms posting.

• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _addRequestMessageBody:]):
• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addRequestMessageBody:]): Remove obsolete support for non-NSData form data. Use the contentType in the request, if present.

• ProtocolHandlers.subproj/WebHTTPResourceRequest.h: Add contentType and setContentType methods; convenience for setting the Content-Type header.
• ProtocolHandlers.subproj/WebHTTPResourceRequest.m: (-[WebResourceRequest _headerForKey:]): Added. (-[WebResourceRequest userAgent]): Use _headerForKey. (-[WebResourceRequest referrer]): Ditto. (-[WebResourceRequest contentType]): Added. Use _headerForKey. (-[WebResourceRequest setContentType:]): Added.

• ProtocolHandlers.subproj/WebHTTPProtocolHandler.h: Remove requestData.
• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: Ditto.

WebCore:

WebCore part of implementation of multipart forms posting.

• kwq/WebCoreBridge.h: Add a contentType parameter to the bridge's [postWithURL:referrer:data:] method.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::submitForm): Extract the content type from the args, and pass it along to the bridge.

WebKit:

WebKit part of implementation of multipart forms posting.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge postWithURL:referrer:data:contentType:]): Add a contentType parameter to match change in WebCore API. Put the contentType value into the request.

3:01 PM Changeset in webkit [2269] by cblu

• 3 edits in trunk/WebKit

• Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase init]): Don't override document view and rep types for types that have already been registered.

2:06 PM Changeset in webkit [2268] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Add a port to the background thread's run loop so it will not exit
the run method constantly.

• Database.subproj/WebFileDatabase.m: (+[WebFileDatabase _syncLoop:])

2:06 PM Changeset in webkit [2267] by darin

• 4 edits in trunk/JavaScriptCore

Fixed absurdly high memory usage when looking at pages that use a lot of JavaScript.

• kjs/collector.cpp: (Collector::allocate): Implement a new policy of doing a garbage collect every 1000 allocations. The old policy was both complicated and misguided. (Collector::collect): Zero out the "number of allocations since last collect".

1:29 PM Changeset in webkit [2266] by darin

• 13 edits in trunk

WebCore:

• fixed 3011025 -- Page up/down is not working when text area has focus

• kwq/KWQTextArea.mm: (-[KWQTextArea needsPanelToBecomeKey]): Return YES so we are considered a valid key view even when in normal tabbing mode. This fixes a problem with tabbing backwards into a text area. (-[KWQTextAreaTextView scrollPageUp:]): Added. Passes a scrollPageUp: selector along the responder chain if we are already scrolled to the top. (-[KWQTextAreaTextView scrollPageDown:]): Ditto.

• kwq/KWQNSTextField.mm: Remove unnecessary overrides of textDidEndEditing. Turns out the real fix was to override display to do nothing as a workaround for bug 2753974.

WebKit:

WebKit part of the page up/down fix.

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView scrollPoint:]): If we are called from the handling of a page up or page down keyboard event, then ignore the specific scrolling requested, and do our idea of page up and page down. This guarantees that we will get the smarter idea of how to page from WebView instead of the one that's hardcoded into NSTextView.

• WebView.subproj/WebView.m: (-[WebView keyDown:]): Use scrollPageUp:, scrollPageDown:, scrollLineUp:, and scrollLineDown: instead of _pageUp, _pageDown, _lineUp, and _lineDown. This lets other classes see and use these selectors, which is useful when passing calls up the responder chain.
• WebView.subproj/WebViewPrivate.h: Remove the private methods that are being changed to match the NSResponder keyboard methods.
• WebView.subproj/WebViewPrivate.m: (-[WebView scrollPageUp:]): Rename from _pageUp, and also pass a scrollPageUp: selector along the responder chain if we are already scrolled to the top. (-[WebView scrollPageDown:]): Ditto. (-[WebView scrollLineUp:]): Rename from _lineUp. (-[WebView scrollLineDown:]): Rename from _lineDown.

1:02 PM Changeset in webkit [2265] by rjw

• 1 edit in trunk/WebCore/force-clean-timestamp

Force build, sorry. PB doesn't seem to be behaving.

12:38 PM Changeset in webkit [2264] by rjw

• 16 edits in trunk

'Re'play the delegate messages when an item is loaded from
the WebCore cache.

Note that the client will NOT receive a willSendRequest: message. The client
presumably already did any request substitution before the object was loaded
into the cache. Allowing the delegate to override the request and replace
the object in the WebCore cache would introduce significant complexity.

Fixes 3069138.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]):
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveResponse:]):

Added response to WebCore's CachedObject. This allows us to correctly
emulated the WebResourceLoadDelegate API when 're'loading an item
from the WebCore cache.

• khtml/misc/loader.cpp: (CachedObject::~CachedObject): (CachedObject::setResponse): (Loader::receivedResponse):
• khtml/misc/loader.h:
• kwq/KWQLoaderImpl.h:
• kwq/KWQLoaderImpl.mm: (-[WebCoreResourceLoader receivedResponse:]): (KWQCheckCacheObjectStatus): (KWQRetainResponse): (KWQReleaseResponse):
• kwq/WebCoreBridge.h:
• kwq/WebCoreResourceLoader.h:

11:35 AM Changeset in webkit [2263] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

Fixed problem in the disk cache where disk writes, once they start, were not being
preempted by future activity through the cache (as it should). The issue here is
that the disk cache was simply "borrowing" the thread that was used to call into
the disk cache to schedule a timer. This turned out to be bad, since that thread
was raised to maximum priority some time ago.

I fixed this by giving the disk cache its own (minimum priority) thread to
write files. This will insulate it from unrelated threading changes in other code.

• Database.subproj/WebFileDatabase.m: (+[WebFileDatabase _syncLoop:]) (databaseInit) (-[WebFileDatabase setTimer]) (-[WebFileDatabase setObject:forKey:])

Oct 6, 2002:

3:17 PM Changeset in webkit [2262] by darin

• 4 edits in trunk/JavaScriptCore

I noticed some broken lists at mapblast.com and tracked it down to this.

• kjs/array_object.cpp: (ArrayInstanceImp::put): Don't truncate the list; only extend the length if it's not already long enough. (ArrayProtoFuncImp::call): Fix some ifdef'd code so it compiles if you turn the ifdefs on.

12:23 PM Changeset in webkit [2261] by darin

• 4 edits in trunk/WebCore

• fixed 3046737 -- infinite loop in font name matching code on some pages

• kwq/KWQString.mm: (QString::replace): Removed the incorrect early exit if the passed in string was the empty string.

Oct 5, 2002:

8:27 AM Changeset in webkit [2260] by darin

• 3 edits in trunk/WebKit

• fixed 3068323 -- nil object inserted in dictionary exception on mouse move

• WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementAtPoint:]): Add some assertions in the hope of finding if my assumptions about this are wrong, and use the version of the dictionary setter that does nothing if it's passed nil when putting in the frame found by name.

Oct 4, 2002:

10:58 PM Changeset in webkit [2259] by darin

• 4 edits in trunk/WebCore

Tests:

• harness.c: (main): Stop using debug versions of frameworks. This was causing us problems we'd see only in the test programs, and we didn't see the text of the asserts. We can turn this back on again if we make it so we can see what's wrong.

• WebFoundation-Misc/ifnsurlextensions-test.chk: Update for new expected results that handle "../" properly.

• kde/kurl-test.chk: Update for canonicalization, which was added a while back without updating this test.

WebFoundation:

• fixed 3064420 -- NSURLExtras function does not resolve "../" URLs at top level the way the web expects

• Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithString:relativeToURL:]): Added code to detect URL results that have paths that start with /../ and remove the extra levels. Tested with the Tests directory.

• English.lproj/StringsNotToBeLocalized.txt: Added the string used as a localization exception.

WebCore:

• kwq/KWQKURL.mm: (KURL::parse): Fix code that adds "" to file URLs. The code was including the extra slashes as part of the path, which they are not. Verified with the tests in the Tests directory.

9:34 PM Changeset in webkit [2258] by darin

• 3 edits in trunk/WebKit

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Add a couple more localization exceptions for newly added strings.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Add a localization exception for the WebKit bundle identifier.

9:28 PM Changeset in webkit [2257] by darin

• 3 edits
  1 add in trunk/WebKit

WebFoundation:

• Misc.subproj/WebLocalizableStrings.h: Implement the real version of the UI_STRING macro. It uses the FRAMEWORK_NAME preprocessor define to find the appropriate bundle global, and passes that along with the key into the WebLocalizedString function.
• Misc.subproj/WebLocalizableStrings.m: Add the definition for the WebFoundationLocalizableStrings bundle global. (WebLocalizedString): Added. Locates the bundle, then creates a string object, then calls localizedStringForKey to find the localized version of the string in the bundle's localizable strings.
• WebFoundation.exp: Export WebLocalizedString.

• WebFoundation.pbproj/project.pbxproj: Add -DFRAMEWORK_NAME=WebFoundation.

WebKit:

• Misc.subproj/WebKitLocalizableStrings.m: Added. Contains the definition of the WebKitLocalizableStringsBundle.
• WebKit.pbproj/project.pbxproj: Add -DFRAMEWORK_NAME=WebKit.

8:31 PM Changeset in webkit [2256] by darin

• 5 edits in trunk

• fixed 2992187 -- Should use curly quotes in status bar messages, window titles, and error dialogs

• BrowserWindowController.m: (-[BrowserWindowController performQuickSearch:]): (-[BrowserWindowController goToToolbarLocation:]): Change the last two straight apostrophes to curly ones.

7:00 PM Changeset in webkit [2255] by rjw

• 4 edits
  9 adds in trunk/WebKit

Stubs for DOM level 2 core API.

• DOM.subproj/WebDOMDocument.h: Added.
• DOM.subproj/WebDOMDocument.m: Added.
• DOM.subproj/WebDOMElement.h: Added.
• DOM.subproj/WebDOMElement.m: Added.
• DOM.subproj/WebDOMNamedNodeMap.h: Added.
• DOM.subproj/WebDOMNamedNodeMap.m: Added.
• DOM.subproj/WebDOMNode.h: Added.
• DOM.subproj/WebDOMNode.m: Added.
• WebKit.pbproj/project.pbxproj:

• WebView.subproj/WebHTMLViewPrivate.m: tweak.

Removed import of header that was removed earlier.

• BookmarksController.m:

6:40 PM Changeset in webkit [2254] by darin

• 3 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Add the last few exceptions. We now have a completely-clean run of extract-localizable-strings in WebKit!

4:46 PM Changeset in webkit [2253] by darin

• 4 edits in trunk/WebKit

• fixed 3060140 -- REGRESSION: frames of animated gif drawn in wrong position.

I got the "fromRect" and "toRect" parameters backwards when I made the changes
to fix bug 3050810.

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer nextFrame:]): Reverse targetRect and imageRect.

• WebKit.pbproj/project.pbxproj: Mark some new files as UTF-8 because Project Builder asked me to.

3:43 PM Changeset in webkit [2252] by darin

• 2 edits
  2 deletes in trunk/WebKit

• Panels.subproj/WebPanelCookieAcceptHandler.h: Removed.
• Panels.subproj/WebPanelCookieAcceptHandler.m: Removed.

3:39 PM Changeset in webkit [2251] by rjw

• 3 edits in trunk/WebKit

Danger Will Robinson. We have to poseAsClass: as early as possible
so that any NSViews will be created with the appropriate poser.
This problem manifested itself with SimpleViewer failing
immediately. NSViews were created by loading a nib before
WebHTMLView class initialization occured. After posing the
already instantiated instances of NSView had a %NSView class,
causing many things to break.

• WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):

2:27 PM Changeset in webkit [2250] by darin

• 3 edits in trunk/JavaScriptCore

Fixed problems parsing numbers that are larger than a long with parseInt.

• kjs/config.h: Define HAVE_FUNC_STRTOLL.
• kjs/function.cpp: (GlobalFuncImp::call): Change parseInt to use strtoll if available.

2:07 PM Changeset in webkit [2249] by darin

• 5 edits in trunk/JavaScriptCore

• kjs/config.h: Define HAVE_FUNC_STRTOLL.
• kjs/function.cpp: (GlobalFuncImp::call): Change parseInt to use strtoll if available.

2:07 PM Changeset in webkit [2248] by rjw

• 6 edits in trunk/WebKit

Ensure that we return non-nil request from handle:willSendRequest:
even when WK's laod delegate is nil.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:willSendRequest:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]):

1:43 PM Changeset in webkit [2247] by darin

• 7 edits in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Add dprintf, NSLog, and NSException to the list of tokens that introduce non-localizable strings, and added handling for square brackets.

WebFoundation:

• CacheLoader.subproj/WebResourceLoad.m: (_loadSweeper):
• Database.subproj/WebFileDatabase.m: (-[WebFileReader initWithPath:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler createHTTPRequest]): Changed logging code to take advantage of the fact that we once-again support %@.

• ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addRequestMessageBody:]):
• ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _addRequestMessageBody:]): Fixed logging code to eliminate a leak.

• ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler debugStringForCacheAttributeValue:]): Changed this code to just call description instead of using string formatting.

• English.lproj/StringsNotToBeLocalized.txt: Add more exceptions. We now have a completely-clean run of extract-localizable-strings in WebFoundation!

• English.lproj/Localizable.strings: Re-generated.

WebKit:

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel loadNib]): Use ERROR instead of NSLog here. (-[WebAuthenticationPanel setUpForRequest:]): Mark some strings for localization.

• WebKit.pbproj/project.pbxproj: Change the encoding on a lot more files to UTF-8.

• English.lproj/StringsNotToBeLocalized.txt: Added some new exceptions.
• English.lproj/Localizable.strings: Re-generated.

WebBrowser:

More progress on localization.

• English.lproj/StringsNotToBeLocalized.txt: Added a few strings.

• GlobalHistory.m: (-[GlobalHistory outlineView:objectValueForTableColumn:byItem:]): Marked a string for localization.

• FrameProgressEntry.m: (-[FrameProgressEntry updateKeyFrom:to:dataSource:]): Added an assert in case we run into an issue like the one from earlier today.

• English.lproj/Localizable.strings: Re-generated.

1:32 PM Changeset in webkit [2246] by rjw

• 2 edits in trunk/WebKit/WebView.subproj

Actually checkin.

11:51 AM Changeset in webkit [2245] by rjw

• 4 edits
  2 deletes in trunk/WebKit

Changed WebDOMNode name to WebDebugDOMNode to make room for
real node.

• Debug/DOMTree.m: (-[DOMTreeDataSource initWithWebView:]): (-[DOMTree itemSelected:]):

Changed WebDOMNode name to WebDebugDOMNode to make room for
real node.

• WebKit.exp:
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebDOMNode.h: Removed.
• WebView.subproj/WebDOMNode.m: Removed.