Timeline

Dec 26, 2002:

10:40 PM Changeset in webkit [3189] by darin

• 3 edits in trunk/WebCore

WebFoundation:

Reviewed by Don.

• Misc.subproj/WebAssertions.h: Fixed CRASH macro to use 0xbbadbeef instead of 0xbadbeef to reduce the chance that the address will be valid once we have allocated a lot of memory.

WebCore:

Reviewed by Don.

• kwq/KWQAssertions.h: Fixed CRASH macro to use 0xbbadbeef instead of 0xbadbeef to reduce the chance that the address will be valid once we have allocated a lot of memory.

8:42 AM Changeset in webkit [3188] by darin

• 1 edit in trunk/WebKit/ChangeLog

Reviewed by Don, I mean.

Dec 25, 2002:

7:42 PM Changeset in webkit [3187] by darin

• 2 edits in trunk/WebKit

Reviewed by Darin.

• fixed 3133611 -- Java "ticker" applet renders badly when scrolling page

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView viewHasMoved:]): Call setWindow so we make a call to the plugin each time it moves, rather than just adjusting the data structure we had passed to it earlier.

12:09 PM Changeset in webkit [3186] by rjw

• 3 edits in trunk/WebCore

Fix for 3134543 (and widely reported dupes). Don't use render_text
widths cache except for whitespace == PRE. The problem was that additional
spaces in the RenderText's string were being inappropiately measured.
An alternate, more complex and risky, fix would account for the whitespace
properties during scanning of the RenderText width buffer. Considering
the scenario for which this optimization was added (3133261), this
simpler fix is adequate.

Reviewed by Darin and Don.

• khtml/rendering/render_text.cpp: (RenderText::computeWidths):

Dec 24, 2002:

2:51 PM Changeset in webkit [3185] by darin

• 3 edits in trunk/WebCore

Reviewed by Don.

• fixed 3135010 -- nil-dereference in KHTMLPart::xmlDocImpl() at channels.netscape.com

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::contentDocument): Add missing nil check. Also added lots of FIXME comments about problems I observed here.

11:49 AM Changeset in webkit [3184] by darin

• 2 edits in trunk/WebKit

Reviewed by Richard and Don.

• fixed 3132192 -- HOMEPAGE: Quicktime plug in with AVI content brings Plug-ins not found panel

• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Lower-case the key before searching for it. This is needed for both MIME types and extensions, since we want case insensitive comparison in both cases.

11:48 AM Changeset in webkit [3183] by darin

• 3 edits in trunk/WebCore

Reviewed by Richard and Don.

• fixed 3133207 -- crash in HTMLFrameElementImpl updateForNewURL at home.real.com

My previous attempt to fix this dealt with the case where a RenderFrame object was
not yet created, but not with the case where a RenderFrame object was created without
a corresponding part. Somehow I overlooked this last time when I was doing testing.
Testing this time confirms this takes care of the remaining problem at movies.real.com.

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Use the same kind of requestFrame call here as in attach when there's a RenderFrame, but no corresponding part. Maybe we can fix this an even more elegant way later.