Timeline

Mar 17, 2003:

4:44 PM Changeset in webkit [3852] by cblu

• 7 edits
  1 add in trunk/WebKit

WebKit:

Fixed: 3200647 - File I/O related download errors just says "error"

Reviewed by darin.

• Downloads.subproj/WebDownload.m: (+[WebDownloadPrivate initialize]): call _registerWebKitErrors
• English.lproj/Localizable.strings:
• Misc.subproj/WebKitErrors.h: cleaned-up, removed unused errors
• Misc.subproj/WebKitErrors.m: (+[WebError _registerWebKitErrors]): (registerErrors):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebView.m: (+[WebFrameView initialize]): call _registerWebKitErrors

WebBrowser:

Fixed: 3200647 - File I/O related download errors just says "error"

Reviewed by darin.

• DownloadProgressEntry.h:
• DownloadProgressEntry.m: (-[DownloadProgressEntry dictionaryRepresentation]): store the error domain

3:28 PM Changeset in webkit [3851] by darin

• 3 edits in trunk/WebKit

Reviewed by Chris and Richard.

• fixed 3200611 -- Progress indicator in tabs not shown for subframe loads

• WebView.subproj/WebDataSource.m: (-[WebDataSource isLoading]): Remove the early out for when we're in the WebFrameStateComplete state. The top frame being complete does not really tell us anything about whether subframes are complete, especially since they can have their locations changed without affecting the top level frame at all.

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

11:33 AM Changeset in webkit [3850] by cblu

• 2 edits in trunk/WebKit

Made data categories use the "_web_" prefix.

Reviewed by darin.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): (-[NSData _web_startsWithBlankLine]): (-[NSData _web_locationAfterFirstBlankLine]):

11:18 AM Changeset in webkit [3849] by cblu

• 2 edits in trunk/WebKit

WebFoundation:

Fixed: 3199105 - Accept carbon-style file URLs from plug-in POST requests
Fixed: 3148767 - POST (aka Flash Remoting) doesn't work from Flash

Reviewed by kocienda.

• Misc.subproj/WebNSDataExtras.h:
• Misc.subproj/WebNSDataExtras.m: (_findEOL): new (-[NSData _web_parseRFC822HeaderFields]): new
• Misc.subproj/WebNSStringExtras.h:
• Misc.subproj/WebNSStringExtras.m: (-[NSString _web_fixedCarbonPOSIXPath]): moved from WB (-[NSString _web_capitalizeRFC822HeaderFieldName]): new

WebKit:

Fixed: 3199105 - Accept carbon-style file URLs from plug-in POST requests
Fixed: 3148767 - POST (aka Flash Remoting) doesn't work from Flash

Reviewed by kocienda.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]): parse headers, handle carbon POSIX paths (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): call _postURLNotify (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): call _postURLNotify (-[NSData startsWithBlankLine]): new (-[NSData locationAfterFirstBlankLine]): new

WebBrowser:

Renamed canonicalizedCarbonPOSIXPath to _web_fixedCarbonPOSIXPath and moved it down to WF.

Reviewed by ken.

• AppController.m: (-[AppController handleURLEvent:withReplyEvent:]):
• BrowserNSStringExtras.h:
• BrowserNSStringExtras.m:

10:57 AM Changeset in webkit [3848] by mjs

• 2 edits in trunk/WebKit

Reviewed by Darin.

• fixed 3200259 - REGRESSION: Clicking on Flash links at homestarrunner.com creates blank windows

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadPluginRequest:]): Don't always make the window, only do it if the frame doesn't already exist. Duh.

10:20 AM Changeset in webkit [3847] by darin

• 3 edits in trunk/WebKit

Reviewed by Trey and Maciej.

• fixed 3199154 -- REGRESSION: world leaks on any page load test

• WebView.subproj/WebController.m: (-[WebController initWithView:frameName:groupName:]): Call through to initWithFrame, the designated initializer, not init. Calling [super init] results in calling our initWithFrame method, resulting in two calls to the _commonInitialization method.

9:53 AM Changeset in webkit [3846] by mjs

• 2 edits in trunk/WebKit

WebFoundation:

Reviewed by Trey.

• fixed 3199763 - Need to revise authentication API for form passwords
• fixed a bunch of crashing and wrongful Keychain saving bugs found while testing

• AuthenticationManager.subproj/WebAuthenticatingResource.h:
• AuthenticationManager.subproj/WebAuthenticatingResource.m: (-[WebAuthenticatingResourcePrivate dealloc]): (-[WebAuthenticatingResource _internalInit]): (-[WebAuthenticatingResource initWithURL:realm:receivesCredentialSecurely:]): (-[WebAuthenticatingResource initWithProxyHost:port:type:realm:receivesCredentialSecurely:]): (-[WebAuthenticatingResource initWithHTMLFormURL:]): (-[WebAuthenticatingResource isProxy]): (-[WebAuthenticatingResource isHTMLForm]): (-[WebAuthenticatingResource host]): (-[WebAuthenticatingResource port]): (-[WebAuthenticatingResource type]): (-[WebAuthenticatingResource hash]): (-[WebAuthenticatingResource isEqual:]):
• AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationHandlerDispatcher startAuthentication:]):
• AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager _usernameForRealm:URL:]): (-[WebAuthenticationManager _removePasswordForRealm:URL:]): (-[WebAuthenticationManager _removeProxyPasswordForURL:]): (-[WebAuthenticationManager _proxyResourceForURL:]): (-[WebAuthenticationManager _setDefaultUserInfoFromURL:]): (-[WebAuthenticationManager _invokeHandlersWithURL:realm:forRequest:failureCount:withCallback:context:]): (-[WebAuthenticationManager _invokeHandlersWithURL:proxy:forRequest:failureCount:withCallback:context:]): (-[WebAuthenticationManager WebAuthenticationRequest:useCredential:]):
• AuthenticationManager.subproj/WebAuthenticationRequest.h:
• AuthenticationManager.subproj/WebAuthenticationRequest.m: (-[WebAuthenticationRequestPrivate initWithResource:defaultUsername:previousFailureCount:delegate:]): (-[WebAuthenticationRequestPrivate dealloc]): (-[WebAuthenticationRequest _initWithResource:defaultUsername:previousFailureCount:delegate:]): (-[WebAuthenticationRequest resource]): (-[WebAuthenticationRequest defaultUsername]):
• AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
• AuthenticationManager.subproj/WebCredentialStorage.m: (-[WebCredentialStorage _rootResourceForResource:]): (-[WebCredentialStorage _resourceWithKeychainItem:isDefault:]): (-[WebCredentialStorage _saveCredential:forResource:isDefault:]): (-[WebCredentialStorage removeCredential:forResource:]): (-[WebCredentialStorage setDefaultCredential:forResource:]):
• Misc.subproj/WebNSURLExtras.h:
• Misc.subproj/WebNSURLExtras.m: (-[NSURL _web_URLByRemovingUserAndPath]):

WebKit:

Reviewed by Trey.

Adjusted for WebFoundation API changes.

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]):

9:41 AM Changeset in webkit [3845] by darin

• 2 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

8:59 AM Changeset in webkit [3844] by cblu

• 9 edits in trunk/WebKit

Fixed: 3199951 - Standalone plug-in content that is cancelled doesn't restart when switching tabs

Instead of creating and managing resourceData in WebMainResourceClient then passing the ownership to WebDataSource, just manage it in WebDataSource. We had the prior behavior because we didn't buffer downloads. Now, we always buffer. The fix for the bug is to retain the incomplete data even though the load ends in error.

Reviewed by darin.

• WebView.subproj/WebDataSource.h: updated headerdoc for the data method
• WebView.subproj/WebDataSource.m: (-[WebDataSource data]): just return resourceData
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedData:]): create resourceData if necessary, append data to it.
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): don't work with resourceData (-[WebMainResourceClient dealloc]): don't work with resourceData (-[WebMainResourceClient resource:didReceiveData:]): don't work with resourceData (-[WebMainResourceClient resourceDidFinishLoading:]): don't work with resourceData

Mar 16, 2003:

8:49 PM Changeset in webkit [3843] by mjs

• 3 edits in trunk/WebCore

Reviewed by Trey.

• fixed 3196050 - Hang in www.janegoodall.org dynamic menus

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::handleLocalEvents): Copy handlers before processing them, so we don't go into an infinite loop if a handler adds or removes handlers.

12:48 AM Changeset in webkit [3842] by trey

• 8 edits in trunk

JavaScriptCore:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

• JavaScriptCore.pbproj/project.pbxproj:

WebFoundation:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

• WebFoundation.pbproj/project.pbxproj:

WebCore:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

• WebCore.pbproj/project.pbxproj:

WebKit:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.
We strip manually as part of the install that we do ourselves.

Reviewed by Maciej.

• WebKit.pbproj/project.pbxproj:

WebBrowser:

3198135 - need to fix our projects so SYMROOT is not stripped

Tweaked stripping options: B&I build does not COPY_PHASE_STRIP.
Deployment build still does.

Reviewed by Maciej.

• WebBrowser.pbproj/project.pbxproj:

Mar 14, 2003:

6:37 PM Changeset in webkit [3841] by cblu

• 2 edits in trunk/WebKit

Backed out changes to WebBaseNetscapePluginView. Unintentional commit.

• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]):

6:29 PM Changeset in webkit [3840] by cblu

• 4 edits in trunk/WebKit

Fixed: 3198961 - REGRESSION: Stopping load of plug-in content is not reflected in UI

Reviewed by mjs.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancelWithError:]): call receivedError so [dataSource _receivedError:error complete:YES] is called

6:06 PM Changeset in webkit [3839] by rjw

• 3 edits in trunk/WebCore

Fixed 3197162. The regression was introduced with the change
to preferences. The old settings API was used to 'reset' the jscript
other properties of the part. This effectively always disabled
javascript and prevented properties from being restored to the js
property maps.

Reviewed by trey.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::saveWindowProperties): (KWQKHTMLPart::saveLocationProperties): (KWQKHTMLPart::restoreWindowProperties): (KWQKHTMLPart::restoreLocationProperties): (KWQKHTMLPart::openURLFromPageCache):

3:28 PM Changeset in webkit [3838]

• 13 copies in tags/Safari-66~1

This commit was manufactured by cvs2svn to create tag 'Safari-66~1'.

3:28 PM Changeset in webkit [3837] by mjs

• 10 edits in branches/Safari-66~1-branch

top level:

Reviewed by Maciej.

• remove leftover bits of NO_LICENSE

• acconfig.h: Remove NO_LICENSE.
• configure.in: Remove all the NO_LICENSE-related bits.

Tools:

• Scripts/byteswap: Fixed a bug in the tool that Trey spotted. It wouldn't swap newline characters correctly.

JavaScriptCore:

Reviewed by Ken.

• fixed 3193099 -- date parsing can't handle the time zone format that date formatting produces

• kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Allow a "GMT" prefix before the time zone offset.

Tests:

• TestURLs.h: Added more test URLs.
• kde/kurl-test.chk: Added test results for the new URLs.

WebFoundation:

Reviewed by trey.

Added _web_changeFileAttributes:atPath and factored _web_changeFinderAttributes out to its own method.

• Misc.subproj/WebNSFileManagerExtras.h:
• Misc.subproj/WebNSFileManagerExtras.m: (-[NSFileManager _web_changeFinderAttributes:forFileAtPath:]): was _web_createFileAtPath (-[NSFileManager _web_changeFileAttributes:atPath:]): call createFileAtPath, then _web_changeFinderAttributes (-[NSFileManager _web_createFileAtPath:contents:attributes:]): call changeFileAttributes, then _web_changeFinderAttributes

WebCore:

Reviewed by John.

• fixed 3166759 -- two fields both look like they have focus at webmail.iquest.net due to onblur

• kwq/KWQTextField.mm: (-[KWQTextField selectText:]): Don't call -[NSTextField selectText:] in the case where we already have an editor, because the NSTextField version will cause the field to relinquish first responder and then take it back, which will send both onblur and onfocus. (-[KWQSecureTextField selectText:]): Same fix for the secure text field.

WebKit:

Reviewed by Dave.

• fixed 3194221 - REGRESSION: search results loaded in wrong frame at directory.apple.com

• WebView.subproj/WebFramePrivate.m: (_postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:): Deliver targetted form posts correctly.

WebBrowser:

First step of preferences reorganization. I added new empty
panes for AutoFill and Tabs. I added an Advanced pane and
moved the existing Style Sheet and Proxies controls and code
there. I made no other code changes yet.

Reviewed by Maciej

• BookmarksController.m: (-[BookmarksController findOrCreateBookmarkSourceTitled:withUUID:index:]): Unrelated change -- once you've found the Bookmarks Menu or Bookmarks Bar folder, stop iterating. This code will be changed soon anyway due to 3192834.

• Preferences.subproj/AdvancedPreferences.tiff: Added.
• Preferences.subproj/AutoFillPreferences.tiff: Added.
• Preferences.subproj/TabsPreferences.tiff: Added. new images for new preference panes

• Preferences.subproj/AdvancedPreferences.h: Added.
• Preferences.subproj/AdvancedPreferences.m: Added. (-[AdvancedPreferences sendProxyTabEventToPSN:]): (-[AdvancedPreferences openProxyPreferences:]): (-[AdvancedPreferences setStyleSheetPathPreference:]): (-[AdvancedPreferences styleSheetPathPreference]): (-[AdvancedPreferences updateStyleSheetMenu]): (-[AdvancedPreferences takeStyleSheetFromMenuItem:]): (-[AdvancedPreferences disableUserStyleSheet:]): (-[AdvancedPreferences choseStyleSheetFromPanel:returnCode:contextInfo:]): (-[AdvancedPreferences chooseStyleSheetFromFileBrowser:]): (-[AdvancedPreferences initializeFromDefaults]): (-[AdvancedPreferences isResizable]): Just cut/pasted code to here from AppearancePreferences (style sheet) and GeneralPreferences (proxies)

• Preferences.subproj/AppearancePreferences.h:
• Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences initializeFromDefaults]): Cut out the style sheet code.

• Preferences.subproj/GeneralPreferences.h:
• Preferences.subproj/GeneralPreferences.m: (-[GeneralPreferences toggleAutoOpenDownloads:]): Cut out the proxies code.

• Preferences.subproj/AutoFillPreferences.h: Added.
• Preferences.subproj/AutoFillPreferences.m: Added. New empty husk of a class.

• Preferences.subproj/TabsPreferences.h: Added.
• Preferences.subproj/TabsPreferences.m: Added. New empty husk of a class.

• Preferences.subproj/English.lproj/AutoFillPreferences.nib: Added. New empty husk of a preference pane.

• Preferences.subproj/English.lproj/TabsPreferences.nib: Added. New empty husk of a preference pane.

• Preferences.subproj/English.lproj/AdvancedPreferences.nib: Added. New preference pane, contains style sheet and proxies controls that formerly lived elsewhere. (Also a silly dividing line.)

• Preferences.subproj/English.lproj/AppearancePreferences.nib: Removed style sheet control, shrunk window.

• Preferences.subproj/English.lproj/GeneralPreferences.nib: Removed proxies control, shrunk window.

• Preferences.subproj/WBPreferences.m: (-[WBPreferences init]): Create the three new panes.

• WebBrowser.pbproj/project.pbxproj: updated for new files.

• English.lproj/Localizable.strings: updated for names of new panes.

3:27 PM Changeset in webkit [3836] by hyatt

• 3 edits in trunk/WebCore

Make :target match the root element if no #fragment is specified in
the URL.

Reviewed by john

• khtml/css/cssstyleselector.cpp:

3:08 PM Changeset in webkit [3835] by mjs

• 4 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

• fixed 3190846 - REGRESSION: can't use Fidelity NetBenefits account

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): Treat javascript: URLs as about:blank for now. (HTMLFrameElementImpl::attach): Likewise.
• khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Make sure to send completed() signal after signals are connectd in synchronous load case.

1:53 PM Changeset in webkit [3834] by mjs

• 3 edits in trunk/WebKit

WebKit:

Reviewed by Don.

• revert premature controller --> webView renaming, it's causing problems with window opening and such.

• WebView.subproj/WebDefaultWindowOperationsDelegate.m:

WebBrowser:

Reviewed by Don.

• add controller: argument to a method that now needs it.

(informal protocols suck!)

• BrowserWebController.m: (-[BrowserWebController controller:runOpenPanelForFileButtonWithResultListener:]):

12:13 PM Changeset in webkit [3833] by hyatt

• 4 edits in trunk/WebCore

Fix for ew.com, hrweb and arstechnica forums. A <br> should
not create a nonempty line in the case where the previous line
didn't break cleanly. The fix is to have a new boolean that
tracks how the previous line broke and to have <br> check that
to figure out if it should set the line to be non-empty.

Reviewed by gramps

• khtml/rendering/bidi.cpp:

11:28 AM Changeset in webkit [3832] by cblu

• 7 edits in trunk/WebKit

Fixed: 3197872 - Standalone plug-in content isn't restarted when switching tabs
Fixed: 3189675 - assertion in plug-in code fails (nil window) with .swf page displaying standalone in a tab

We start plug-ins when they are added to the window and stop them when they are removed. To restart a plug-in, the data stream must be redelivered. This works in the embedded plug-in case, but in the standalone plug-in case, the stream is delivered by the machinery in WebKit. The stream is only delivered once. This fix addresses that.

Reviewed by trey.

• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]): reset the offset ivar (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): If we create a file for the plug-in, handle the case where the file is already created.
• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView isStarted]): added so the stream knows the state of the view
• Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView initWithFrame:]): tweak (-[WebNetscapePluginDocumentView viewDidMoveToWindow]): call redeliverStream if we are added back to the window (-[WebNetscapePluginDocumentView setDataSource:]): only start the plug-in if we are in a window, don't assert
• Plugins.subproj/WebNetscapePluginRepresentation.h:
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation dealloc]): release the retained data source and error (-[WebNetscapePluginRepresentation setDataSource:]): retain the data source (-[WebNetscapePluginRepresentation isPluginViewStarted]): new (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): only do work if isPluginViewStarted (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): retain the error, only do work if isPluginViewStarted (-[WebNetscapePluginRepresentation finishedLoadingWithDataSource:]): only do work if isPluginViewStarted

(-[WebNetscapePluginRepresentation redeliverStream]): call receivedData

with all the received data up to this point. Call receivedError:: or finishedLoadingWithDataSource: if the load is already complete.