Context Navigation

← Previous Period
Next Period →

Timeline

Apr 14, 2003:

10:31 PM Changeset in webkit [4104] by mjs

5 edits in trunk/WebCore

Reviewed by Trey.

fixed 3214900 - iBench JavaScript test times get progressively slower with each test run

The fix is to make sure to always cast NodeImpl * to DocumentImpl
*. Multiple inheritance means the pointer values need not be the
same.

khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::getDOMObjectForDocument): (ScriptInterpreter::putDOMObjectForDocument): (ScriptInterpreter::deleteDOMObjectsForDocument): (ScriptInterpreter::forgetDOMObjectsForDocument):
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_dom.cpp: (KJS::getDOMNode):

3:43 PM Changeset in webkit [4103] by hyatt

5 edits in trunk/WebCore

Reviewed by darin

ChangeLog:
khtml/css/cssstyleselector.cpp:
khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseComment):

2:43 PM Changeset in webkit [4102] by cblu

6 edits in trunk/WebKit

Log time spent loading each plug-in.

Reviewed by mjs.

Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconsForIconURLString:]): fixed logging code (-[WebIconDatabase _scaleIcon:toSize:]): fixed logging code
Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): log time spent loading a plug-in
Plugins.subproj/WebPluginController.m: (-[WebPluginController startAllPlugins]): only log if there are plug-ins to start (-[WebPluginController stopAllPlugins]): only log if there are plug-ins to stop (-[WebPluginController destroyAllPlugins]): only log if there are plug-ins to destroy

1:46 PM Changeset in webkit [4101] by trey

7 edits in trunk/WebKit

WebKit:

3150693 - open new window on "same page" doesn't give me the same frame content

The core is a new support method that loads a WebView given a HistoryItem, which
thus restores all frames of that item, and optionally the form and scroll state.

Reviewed by NOBODY (OOPS!).

History.subproj/WebHistoryItem.m: (-[WebHistoryItem copyWithZone:]): Copy the docState, scrollPosition, isTargetItem. No good reason to have left these out when I wrote this method.
WebView.subproj/WebFramePrivate.h:
WebView.subproj/WebFramePrivate.m: (-[WebFrame _saveDocumentAndScrollState]): New method to run the frame tree and save all form/scroll state to the current item.
WebView.subproj/WebView.m: _goToItem:withLoadType: moved to WebViewPrivate.m
WebView.subproj/WebViewPrivate.h:
WebView.subproj/WebViewPrivate.m: (-[WebView _goToItem:withLoadType:]): Moved from WebView.m, no change. (-[WebView _loadItem:showingInView:]): New method to load the view with the item.

WebBrowser:

3150693 - open new window on "same page" doesn't give me the same frame content

The basic idea is that we try to call the new _loadItem:showingInView:
method with a history item instead of just loading a URL.

Reviewed by NOBODY (OOPS!).

BrowserDocument.h:
BrowserDocument.m: (-[BrowserDocument goToHistoryItem:inView:]): Just pass through args to our current controller.
BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): If we can get a history item use that to do the load. Else use a URL like before.

11:48 AM Changeset in webkit [4100] by cblu

3 edits in trunk/WebCore

Fixed build failure.

Reviewed by darin.

khtml/rendering/render_table.cpp: (RenderTable::cellAbove):

11:03 AM Changeset in webkit [4099] by cblu

3 edits in trunk/WebKit

Fixed: 3162338 - Embedding SVG with <object type="image/svg+xml"> doesn't work

Reviewed by dave.

WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]): code moved from +[WebImageView supportedImageMIMETypes]
WebView.subproj/WebImageView.m: (+[WebImageView supportedImageMIMETypes]): return -[WebImageRendererFactory supportedMIMETypes]

11:01 AM Changeset in webkit [4098] by cblu

6 edits in trunk/WebCore

Fixed: 3162338 - Embedding SVG with <object type="image/svg+xml"> doesn't work

Whenever we encounter an OBJECT tag with a type that starts with "image/" we create a render image object instead of a render part object. The behavior is nice because this allows the render object to resize to the size of the image if no WIDTH and HEIGHT are supplied. For example, the image at the bottom of this page:

http://tantek.com/CSS/Examples/boxmodelhack.html

The problem is that we do this for image types that we can't handle and when there are plug-ins that *can* handle the types.

Reviewed by dave.

khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::rendererIsNeeded): call canRenderImageType instead of serviceType.startsWith (HTMLObjectElementImpl::createRenderer): call canRenderImageType instead of serviceType.startsWith (HTMLObjectElementImpl::attach): call canRenderImageType instead of serviceType.startsWith
kwq/KWQPixmap.h:
kwq/KWQPixmap.mm: (canRenderImageType): new, checks if the MIME type is supported by the image factory
kwq/WebCoreImageRendererFactory.h: added supportedMIMETypes to the WebCoreImageRendererFactory protocol

7:14 AM Changeset in webkit [4097]

2 copies
2 deletes in tags/JavaScriptCore-73

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-73'.

7:14 AM Changeset in webkit [4096] by darin

1 edit in branches/JavaScriptCore-73-tarball-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Update project file for tarball.

7:11 AM Changeset in webkit [4095]

4 copies
2 deletes in tags/WebCore-73

This commit was manufactured by cvs2svn to create tag 'WebCore-73'.

7:11 AM Changeset in webkit [4094] by darin

1 edit in branches/WebCore-73-tarball-branch/WebCore/WebCore.pbproj/project.pbxproj

Update project for tarball release.

12:10 AM Changeset in webkit [4093] by mjs

5 edits in trunk/WebCore

Reviewed by Trey.

fixed 3165326 - javascript getSelection not implemented

khtml/ecma/kjs_window.cpp: (Window::get): (WindowFunc::tryCall):
khtml/ecma/kjs_window.h:
khtml/ecma/kjs_window.lut.h:

Apr 13, 2003:

11:24 PM Changeset in webkit [4092] by mjs

3 edits in trunk/WebKit

WebKit:

Reviewed by Trey.

WebView.subproj/WebDefaultWindowOperationsDelegate.m: (-[WebDefaultWindowOperationsDelegate webView:setContentRect:]): Implemented in terms of webView:setFrame: to save clients work.

WebBrowser:

Reviewed by Trey.

fixed 3210715 - Window cannot resize smaller than 392px wide - mac.com Bookmarks

WindowController.m: (-[WindowController setFrameWithoutAutosaving:]): When setting size smaller than the current minimum, make it the new minimum. (-[WindowController webView:setContentRect:]): Removed.

10:18 PM Changeset in webkit [4091] by trey

6 edits in trunk/WebCore

3219720 - autofill mapping confused by tables, worse than MacIE (at store.apple.com)

If in scanning backwards we get to the end of a table row, we take a diversion
and scan the cell that is above the cell we started at.
Big improvement for store.apple.com.

Reviewed by Maciej

khtml/rendering/render_table.cpp: (RenderTable::cellAbove): New support routine to find the cell above another
khtml/rendering/render_table.h:
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsAboveCell): Get the cell above, scan its tree for matching text. (KWQKHTMLPart::searchForLabelsBeforeElement): Call above routine if we are working within a table

12:31 AM Changeset in webkit [4090]

4 copies in branches/Safari-73~1-branch

This commit was manufactured by cvs2svn to create branch
'Safari-73~1-branch'.

12:31 AM Changeset in webkit [4089]

4 copies in tags/Safari-73~1-anchor

This commit was manufactured by cvs2svn to create tag
'Safari-73~1-anchor'.

12:31 AM Changeset in webkit [4088]

4 copies in tags/Safari-73~1

This commit was manufactured by cvs2svn to create tag 'Safari-73~1'.

12:31 AM Changeset in webkit [4087] by mjs

6 edits in trunk/JavaScriptCore

Reviewed by Don.

JavaScriptCore part of fix for 3158769 - JavaScript triggers not as async as they used to be

Added a way to get the current interpreter lock count, so Sherlock
can unlock the interpreter inside JS method implementations that
spend a long time waiting for I/O, allowing more efficient
multi-threaded operation.

kjs/internal.cpp: (lockInterpreter): (unlockInterpreter): (InterpreterImp::lock): (InterpreterImp::lockCount):
kjs/internal.h:
kjs/interpreter.cpp: (Interpreter::lockCount):
kjs/interpreter.h:

Apr 12, 2003:

3:18 PM Changeset in webkit [4086] by cblu

3 edits in trunk/WebCore

Fixed: 3188070 - 6I32 EMBED tag with no SRC attribute doesn't load the plugin

Reviewed by dave.

khtml/khtml_part.cpp: (KHTMLPart::requestObject): allow URL-less parts

Apr 11, 2003:

6:17 PM Changeset in webkit [4085] by cblu

3 edits in trunk/WebKit

WebKit:

Removed WebKitErrorResourceLoadInterruptedByPolicyChange error because it isn't used.

Reviewed by john.

Misc.subproj/WebKitErrors.h:
Misc.subproj/WebKitErrors.m: (registerErrors):
WebKit.pbproj/project.pbxproj:

WebBrowser:

Fixed: 3109110 - clean up status bar after deciding to download
Fixed: 3090317 - Download progress feedback very bad after drag & drop .dmg URL to Alex

Reviewed by trey, john.

BrowserWebErrorExtras.h:
BrowserWebErrorExtras.m: (-[WebError isCancelledError]): new (-[WebError isPolicyChangeError]): new
FrameProgressEntry.m: (-[FrameProgressEntry stage]): use new error categories
LoadProgressMonitor.h:
LoadProgressMonitor.m: (-[LoadProgressMonitor reset]): new, set main entry to nil if we haven't previously committed (-[LoadProgressMonitor committedFrame:]): set committed bool
LocationChangeHandler.m: (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]): call [LoadProgressMonitor reset] for downloads

5:34 PM Changeset in webkit [4084] by trey

11 edits in trunk

WebCore:

3148002 - printing shouldn't depend on the size of the window

The basic strategy is copied from khtmlview's print method: We reset the width
of the document to the paper width minus margins, and relayout before paginating
and printing.

Reviewed by Richard.

khtml/rendering/render_root.cpp: (RenderRoot::layout): Always resize our view, even when doing a layout when in printing mode. It's necessary to change the view size because we rely on the AppKit built-in pagination, which operates using the view geometry.
kwq/KWQKHTMLPart.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::forceLayoutForPageWidth): New method to do a layout given a specific width.
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge _setPrintingMode:]): Helper routine to take the RenderRoot in and out of printing mode. (-[WebCoreBridge forceLayout]): Turn printing mode on/off. (-[WebCoreBridge forceLayoutForPageWidth:]): Turn printing mode on/off. New glue routine to call part. (-[WebCoreBridge drawRect:withPainter:]): Turn printing mode on/off. (-[WebCoreBridge drawRect:]): Test paintDevice type instead of graphics context to determine printing mode. The latter is still on when we are wrapping up the job and want to be setting things back to normal. (-[WebCoreBridge adjustFrames:]): Ditto. (-[WebCoreBridge adjustPageHeightNew:top:bottom:limit:]): Turn printing mode on/off.

WebKit:

3148002 - printing shouldn't depend on the size of the window

The basic strategy is copied from khtmlview's print method: We reset the width
of the document to the paper width minus margins, and relayout before paginating
and printing.

Reviewed by Richard.

WebKit.pbproj/project.pbxproj: Someone is using an old version...
WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView reflectScrolledClipView:]): Don't do the dynamic scrollbar update magic when printing.
WebView.subproj/WebHTMLView.m: (-[WebHTMLView layoutToPageWidth:]): New routine, basically the old layout method with a new parameter. If we're given an width, we call a different bridge method. (-[WebHTMLView layout]): Just call above method with width==0 (-[WebHTMLView drawRect:]): Protect setting/resetting of graphics context and additional clip with a DURING/HANDLER. I saw an assertion failure that could be explained by this, so this is mostly a beartrap for that problem. (-[WebHTMLView _setPrinting:pageWidth:]): Pass page width through to others. (-[WebHTMLView beginDocument]): If we are not in a frame set, do a layout using the page width. (-[WebHTMLView endDocument]): Pass 0 to new pageWidth: arg.

4:30 PM Changeset in webkit [4083] by darin

5 edits in trunk/WebCore

Reviewed by Richard.

fixed 3225472 -- www.sina.com.cn uses A3A0 for full-width space; used to work in Simplified Chinese (Mac OS)

kwq/KWQTextCodec.mm: (KWQTextDecoder::convertUsingTEC): Work around the problem in the Text Encoding Converter by changing all U+E5E5 to U+3000.

kwq/KWQString.h: Added replace(QChar, QChar), since Qt has it and I need it.
kwq/KWQString.mm: (QString::find): Fixed a bug where we'd yield a FATAL and return -1 on deployment if you searched for a non-ASCII character in a string that had ASCII valid and not Unicode valid. (QString::replace): Added replace(QChar, QChar).

2:38 PM Changeset in webkit [4082] by trey

2 edits in trunk/WebKit

3220349 - assertion failure in [WebFrame _recursiveGoToItem:...] hitting Back while loading movie

The problem was that when we go back we call stopLoading on the top frame, but
that has a bogus optimization to not do any work if state=Completed. That is a
bogus test if a subframe is doing a load. The fix is to just always tell the
dataSources to stopLoading. They already bail quickly when they are not loading,
so there is no significant additional cost.