Timeline

May 27, 2003:

5:20 PM Changeset in webkit [4438] by cblu

• 5 edits in trunk/WebKit

WebKit:

Don't load and save icons if the icon DB directory default is not set.

Reviewed by darin.

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): don't create the DB if the default is not set (-[WebIconDatabase _loadIconDictionaries]): don't load the dictionaries if the DB doesn't exist (-[WebIconDatabase _updateFileDatabase]): don't update the DB if it doesn't exist
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): don't load icons if the icon DB directory default is not set

WebBrowser:

Moved the icon DB to ~/Library/Safari/Icons

Reviewed by darin.

• AppController.m: (+[AppController initialize]): move the icon DB (+[AppController _settingsDirectoryPath]): made this a class method (-[AppController settingsDirectoryPath]): call the class method

4:22 PM Changeset in webkit [4437] by mjs

• 3 edits in trunk/WebCore

Rolled in fix from Safari-80~1-branch

2003-05-27 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

• WebKit.pbproj/project.pbxproj: Removed no longer needed and harmful flag.

4:22 PM Changeset in webkit [4436] by mjs

• 2 edits in trunk/WebKit

Rolled in fix from Safari-80~1-branch

2003-05-27 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

• WebKit.pbproj/project.pbxproj: Removed no longer needed and harmful flag.

4:12 PM Changeset in webkit [4435]

• 3 copies
  2 deletes in tags/WebKit-80~1

This commit was manufactured by cvs2svn to create tag 'WebKit-80~1'.

4:12 PM Changeset in webkit [4434] by mjs

• 2 edits in branches/Safari-80~1-branch/WebKit

Reviewed by Darin.

• WebKit.pbproj/project.pbxproj: Updated version to 80.1.

4:12 PM Changeset in webkit [4433]

• 6 copies
  2 deletes in tags/WebCore-80~1

This commit was manufactured by cvs2svn to create tag 'WebCore-80~1'.

4:12 PM Changeset in webkit [4432] by mjs

• 3 edits in branches/Safari-80~1-branch/WebCore

Reviewed by Darin.

• WebCore.pbproj/project.pbxproj: Updated version to 80.1.

4:11 PM Changeset in webkit [4431] by mjs

• 3 edits in branches/Safari-80~1-branch/WebCore

Reviewed by Darin.

• WebCore.pbproj/project.pbxproj: Removed no longer needed and harmful flag.

4:09 PM Changeset in webkit [4430] by mjs

• 2 edits in branches/Safari-80~1-branch/WebKit

Reviewed by Darin.

• WebKit.pbproj/project.pbxproj: Removed no longer needed and harmful flag.

3:03 PM Changeset in webkit [4429] by rjw

• 2 edits in trunk/WebKit

Fix for IB.

Reviewed by Eric Seymour.

• WebView.subproj/WebPreferences.m: (-[WebPreferences initWithIdentifier:]): Added retain to uniqued instance. (As we did recently for initWithCoder:).

2:50 PM Changeset in webkit [4428] by cblu

• 2 edits in trunk/WebKit

Fixed: 3270013 - Exception raised when visiting ​http://www.shutterfly.com/favicon.ico

Reviewed by john.

• WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithBytes:length:MIMEType:]): return nil if the image has no representations

1:50 PM Changeset in webkit [4427] by cblu

• 2 edits in trunk/WebKit

Fixed: 3242864 - repro assertion failure in WebIconDatabase.m for www.shutterfly.com

Reviewed by john.

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader connectionDidFinishLoading:]): don't set the icon on the DB if it has no representations

1:04 PM Changeset in webkit [4426] by hyatt

• 4 edits in trunk/WebCore

Fix for 3268589, static position miscomputed when the positioned object is the last item in its enclosing block and when its previous sibling is a text run that ends in a space. In this case we need to clear our trailingSpaceObject so that we don't mistakenly ignore the positioned object when building up bidi runs.

Fix for 3260053, table-layout of inherit not supported. This
caused a crash. The fix is to just add in the support for the inherit
value to the style selector.

Reviewed by john

• khtml/rendering/bidi.cpp:
• khtml/css/cssstyleselector.cpp

11:34 AM Changeset in webkit [4425] by rjw

• 3 edits in trunk/WebKit

Fixes for IB.

Reviewed by Eric Seymour.

• WebView.subproj/WebPreferences.m: (-[WebPreferences initWithCoder:]): Added retain to uniqued instance

• WebView.subproj/WebView.m: (-[WebView initWithCoder:]): (-[WebView setPreferences:]): Added release check to global uniquing dictionary.

May 26, 2003:

1:49 PM Changeset in webkit [4424] by sullivan

• 3 edits in trunk/WebCore

• fixed 3262849 -- jump to nil in KWQKHTMLPart::searchForLabelsAboveCell at techbargains.com

Reviewed by Dave

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::searchForLabelsAboveCell): check for nil result of cellAboveRenderer->element()