Timeline

Jun 7, 2003:

5:59 PM Changeset in webkit [4497] by darin

• 2 edits in trunk/WebKit

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

5:51 PM Changeset in webkit [4496] by darin

• 3 edits in trunk/WebKit

Rolled out Chris's fix for 3156169 because it was causing a lot of crashes
and problems with basic behavior. We can try again later.

One of the problems was that Back wasn't working. Another was that you could
not follow the link at the top of the page at kbb.com. More testing seemed to
reveal still more problems.

• WebView.subproj/WebFramePrivate.h: Rolled back to previous version.
• WebView.subproj/WebFramePrivate.m: Ditto.

Jun 6, 2003:

4:48 PM Changeset in webkit [4495] by rjw

• 2 edits in trunk/WebKit

Fixed 3283236. Remove use of forward declarations in public header because
CodeWarrior pukes on 'em.

Reviewed by Chris.

• WebView.subproj/WebDataSource.h:

4:22 PM Changeset in webkit [4494] by cblu

• 3 edits in trunk/WebKit

Fixed: <rdar://problem/3156169>: cmd-click opens new win but stops loading in prev win

Reviewed by darin.

• WebView.subproj/WebFramePrivate.h: added policyDataSource and policyLoadType as ivars
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): added ASSERT (-[WebFramePrivate setProvisionalDataSource:]): added ASSERT (-[WebFrame _isLoadComplete]): formatting tweak (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]): clear policyDataSource (-[WebFrame _checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): formatting tweak (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): retain policyDataSource (-[WebFrame _continueAfterNavigationPolicy:]): stop the load, set the load type, set the provisional data source in the "use" case (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): formatting tweak (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): don't reset things if something other than "use" has been chosen (-[WebFrame _loadDataSource:withLoadType:formState:]): DON'T stop the load, set the load type, set the provisional data source

3:53 PM Changeset in webkit [4493] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3282881>: Java plugin fails in carbon WebKit apps

Fixed by Mike Hay, reviewed by me.

• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase initIsCocoa]): (-[WebPluginDatabase isCocoa]): (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): don't load cocoa plug-ins if isCocoa.

10:47 AM Changeset in webkit [4492] by sheridan

• 3 edits in trunk

v83u, forgot to do this after the build on Tuesday

3:31 AM Changeset in webkit [4491] by hyatt

• 3 edits in trunk/WebCore

Fix for crash on an XHTML frameset page. It was assuming
that all docs were HTML. The bug # is 3277973.

Reviewed by john

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::updatePolicyBaseURL): (KWQKHTMLPart::setPolicyBaseURL):

Jun 5, 2003:

12:24 PM Changeset in webkit [4490] by hyatt

• 1 edit in trunk/WebCore/khtml/html/html_headimpl.h

* empty log message *

12:05 PM Changeset in webkit [4489]

• 1 copy
  79 deletes in branches/unlabeled-1.35.18

This commit was manufactured by cvs2svn to create branch
'unlabeled-1.35.18'.

12:05 PM Changeset in webkit [4488] by hyatt

• 4 edits in trunk/WebCore

Fix for 3281030, stylesheets can't be enabled properly via
script. Test case from Dirk. The fix is to make the setting
of the state happen independently of the attribute setting.

Reviewed by john

• khtml/dom/html_head.cpp: (HTMLLinkElement::setDisabled):
• khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::setDisabledState): (HTMLLinkElementImpl::parseAttribute):
• khtml/html/html_headimpl.h:

11:36 AM Changeset in webkit [4487] by cblu

• 3 edits in trunk/WebCore

Fixed: <rdar://problem/3268751>: REGRESSION: crash in KWQValueListImpl selecting connection speed at news.com

Reviewed by darin.

• kwq/KWQButton.mm: (QButton::clicked): Don't call clicked if the button was destroyed inside of sendConsumedMouseUpIfNeeded.

11:23 AM Changeset in webkit [4486] by sullivan

• 8 edits in trunk/WebKit

• fixed 3266216 -- repro crash in -[WebBaseResourceHandleDelegate connection:didReceiveData:] in GIA Application

The problem was that an NSURLConnection delegate object (in this
case a WebMainResourceClient) was being dealloc'ed during one of
its connection delegate methods. To prevent this kind of problem,
I added [self retain]/[self release] guards around the meat of
all of the connection delegate methods in which arbitrary code
could be run. Another approach would be to do this retain/release
pair in NSURLConnection, but Darin deemed it wiser not to muck with
Foundation at this point for this issue.

Reviewed by Darin

• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginConnectionDelegate connection:didReceiveResponse:]): guard with [self retain]/[self release] (-[WebNetscapePluginConnectionDelegate connection:didReceiveData:]): ditto (-[WebNetscapePluginConnectionDelegate connection:didFailWithError:]): ditto

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient connection:didReceiveResponse:]): ditto (-[WebSubresourceClient connection:didReceiveData:]): ditto

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate connection:willSendRequest:redirectResponse:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate connection:didCancelAuthenticationChallenge:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveResponse:]): ditto (-[WebBaseResourceHandleDelegate connection:didReceiveData:]): ditto. Also, commented out two assertions that fire illegitimately in the steps in this bug report. (-[WebBaseResourceHandleDelegate connection:didFailWithError:]): ditto

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:willSendRequest:redirectResponse:]): ditto (-[WebMainResourceClient connection:didReceiveResponse:]): ditto (-[WebMainResourceClient connection:didReceiveData:]): ditto

9:47 AM Changeset in webkit [4485] by darin

• 3 edits in trunk/WebCore

Reviewed by John.

• fixed 3279206 -- REGRESSION: new page does not load after selecting item from list and hitting 'Go' button

• khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::encoding): Use value() in a couple of places that were still directly using m_value.

8:41 AM Changeset in webkit [4484] by darin

• 3 edits in trunk/WebCore

Reviewed by John.

• fixed 3278079 -- REGRESSION: UTF-8 page claiming to be UTF-16 in XML header gives garbage characters

• khtml/misc/decoder.cpp: (Decoder::setEncoding): Add EncodingFromXMLHeader as one of the types where we know the encoding is an 8-bit one. The reason this is a regression is that we used to ignore the encoding in the XML header altogether.