⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 21, 2003:

12:42 PM Changeset in webkit [5842] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed a storage leak
  • WebView.subproj/WebFrame.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Move the release of the request out of an if statement, since it's always needed.
12:40 PM Changeset in webkit [5841] by darin
  • 4 edits in trunk/WebCore

Reviewed by Dave.

  • fixed a storage leak
  • khtml/rendering/render_style.h: Added a destructor and a private unimplemented assignment operator to StyleCSS3InheritedData, since the textShadow field that needs to be allocated and deallocated and the default destructor and assignment operator don't do that.
  • khtml/rendering/render_style.cpp: (StyleCSS3InheritedData::~StyleCSS3InheritedData): Added destructor that deletes the textShadow object.
  • fixed locking for JavaScript debugging tools in Caches window
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): Lock and unlock around call to JavaScriptCore. (+[WebCoreJavaScript garbageCollect]): Ditto.

Dec 19, 2003:

9:16 PM Changeset in webkit [5840] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3483130, repaint doesn't occur when font is decreased dynamically when at the bottom of
amazon.com.

Reviewed by john

  • khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setTextSizeMultiplier:]):
4:32 PM Changeset in webkit [5839] by kocienda
  • 8 edits in branches

Reviewed by me

Made out TreeWalker implementation less lame. It's not
done yet, but it's a lot better.

  • khtml/dom/dom2_traversal.cpp: (TreeWalker::root): (TreeWalker::whatToShow): (TreeWalker::filter): (TreeWalker::expandEntityReferences): (TreeWalker::currentNode): (TreeWalker::setCurrentNode):
  • khtml/dom/dom2_traversal.h:
  • khtml/editing/edit_caretimpl.cpp: (CaretImpl::adjustForEditing):
  • khtml/xml/dom2_traversalimpl.cpp: (TreeWalkerImpl::TreeWalkerImpl): (TreeWalkerImpl::operator=): (TreeWalkerImpl::~TreeWalkerImpl): (TreeWalkerImpl::setRoot): (TreeWalkerImpl::setFilter): (TreeWalkerImpl::setCurrentNode): (TreeWalkerImpl::parentNode): (TreeWalkerImpl::firstChild): (TreeWalkerImpl::lastChild): (TreeWalkerImpl::previousSibling): (TreeWalkerImpl::nextSibling): (TreeWalkerImpl::previousNode): (TreeWalkerImpl::nextNode): (TreeWalkerImpl::isAccepted): (firstDescendent): (lastDescendent):
  • khtml/xml/dom2_traversalimpl.h: (DOM::TreeWalkerImpl::root): (DOM::TreeWalkerImpl::whatToShow): (DOM::TreeWalkerImpl::filter): (DOM::TreeWalkerImpl::expandEntityReferences): (DOM::TreeWalkerImpl::currentNode): (DOM::TreeWalkerImpl::setWhatToShow): (DOM::TreeWalkerImpl::setExpandEntityReferences): (DOM::TreeWalkerImpl::assertNodeValid):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createTreeWalker):
  • khtml/xml/dom_docimpl.h:
3:06 PM Changeset in webkit [5838] by rjw
  • 2 edits in trunk/WebCore

Fixed 3515590. Return Undefined to JS for applet if
Java is disabled.

Reviewed by Chris.

  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance):
1:55 PM Changeset in webkit [5837] by rjw
  • 3 edits in trunk/JavaScriptCore

Fixed 3515597. When an error occurs we need
to make sure result values are zeroed.

Cleaned up logs by adding a newline.

Reviewed by John.

  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): (KJS::Bindings::getJNIEnv): (callJNIMethod): (callJNIMethodA): (KJS::Bindings::getJNIField):
  • bindings/jni_jsobject.cpp: (JSObject::convertValueToJObject):
1:25 PM Changeset in webkit [5836] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Chris.

<rdar://problem/3512545>: reproducible assertion failure in KWQKHTMLPart::addData scrolling to anchor while page loads

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollToAnchor): Don't pretend we finished loading, because we don't actually make anchor scrolling stop the current page load.
11:54 AM Changeset in webkit [5835] by kocienda
  • 41 edits in branches

Reviewed by me

Merged HEAD to branch

  • ChangeLog:
  • WebCore.pbproj/project.pbxproj:
  • khtml/css/css_valueimpl.h:
  • khtml/css/cssparser.cpp:
  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::updateDOMObjectDocument):
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript):
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::updateForNewURL): (HTMLFrameElementImpl::openURL): (HTMLFrameElementImpl::parseAttribute): (HTMLFrameElementImpl::setLocation): (HTMLIFrameElementImpl::parseAttribute): (HTMLIFrameElementImpl::openURL):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::click): (HTMLInputElementImpl::accessKeyAction):
  • khtml/html/html_inlineimpl.cpp: (HTMLAnchorElementImpl::isFocusable): (HTMLAnchorElementImpl::isMouseFocusable):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance):
  • khtml/html/html_objectimpl.h:
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::notifyFinished):
  • khtml/khtmlview.cpp: (KHTMLView::layout): (KHTMLView::dispatchMouseEvent):
  • khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText):
  • khtml/rendering/font.h:
  • khtml/rendering/render_form.cpp: (RenderFileButton::slotTextChanged): (RenderFileButton::click):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_inline.cpp: (RenderInline::absoluteRects):
  • khtml/rendering/render_inline.h:
  • khtml/rendering/render_object.cpp: (RenderObject::absoluteRects): (checkFloats): (RenderObject::removeFromObjectLists):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::absoluteRects): (RenderText::paintObject):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::setDocument): (NodeImpl::checkAddChild):
  • khtml/xml/dom_nodeimpl.h:
  • kwq/KWQAccObject.mm: (-[KWQAccObject anchorElement]): (-[KWQAccObject role]): (boundingBoxRect): (-[KWQAccObject position]): (-[KWQAccObject size]): (-[KWQAccObject accessibilityIsIgnored]):
  • kwq/KWQApplication.mm: (QDesktopWidget::screenNumber): (QDesktopWidget::screenGeometry):
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::click):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::getAppletInstanceForView): (KWQKHTMLPart::addPluginRootObject): (KWQKHTMLPart::cleanupPluginRootObjects):
  • kwq/KWQKWinModule.mm: (KWinModule::workArea):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeEmptyTextStyle):
9:59 AM Changeset in webkit [5834] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3515255>: Standalone image drag makes ocassionally makes 2 copies

Reviewed by john.

  • WebKit.pbproj/project.pbxproj: Xcode 1.1 file format change
  • WebView.subproj/WebImageView.h:
  • WebView.subproj/WebImageView.m: copied double-drag protection code from WebHTMLView (-[WebImageView mouseDown:]): set ignoringMouseDraggedEvents to NO (-[WebImageView mouseDragged:]): if ignoringMouseDraggedEvents, return (-[WebImageView draggedImage:endedAt:operation:]): set ignoringMouseDraggedEvents to YES
9:46 AM Changeset in webkit [5833] by vicki
  • 3 edits in trunk

* empty log message *

9:37 AM Changeset in webkit [5832]
  • 3 copies in tags/Safari-119

This commit was manufactured by cvs2svn to create tag 'Safari-119'.

9:37 AM Changeset in webkit [5831] by vicki
  • 6 edits in trunk

top level:

Reviewed by me

  • Site/Internal/Design/html-editing-tasks.fp5: Added.

Tools:

  • disallow installation on 10.3.2 and later; update strings with better error messages
  • Install_resources/InstallationCheck:
  • Install_resources/InstallationCheck.strings:

JavaScriptCore:

Ensure that all the symbols we export are in the KJS
namespace (3512245).

Also renamed JavaString.characters() to JavaString.UTF8String()
for enhanced clarity.

Added some sanity checking to constructor of JObjectWrapper.

Reviewed by Dave.

  • ChangeLog:
  • bindings/jni/jni_class.cpp:
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod): (JObjectWrapper::JObjectWrapper):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaField::JavaField): (JavaMethod::JavaMethod): (JavaMethod::signature):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaString::ascii): (KJS::Bindings::JavaString::UTF8String): (KJS::Bindings::JavaString::JavaString): (KJS::Bindings::JavaString::_commonInit): (KJS::Bindings::JavaString::uchars): (KJS::Bindings::JavaString::length): (KJS::Bindings::JavaString::ustring): (KJS::Bindings::JavaParameter::type): (KJS::Bindings::JavaField::name): (KJS::Bindings::JavaField::type): (KJS::Bindings::JavaMethod::name): (KJS::Bindings::JavaMethod::returnType):
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): (KJS::Bindings::getJNIEnv): (KJS::Bindings::callJNIVoidMethod): (KJS::Bindings::callJNIObjectMethod): (KJS::Bindings::callJNIBooleanMethod): (KJS::Bindings::callJNIByteMethod): (KJS::Bindings::callJNICharMethod): (KJS::Bindings::callJNIShortMethod): (KJS::Bindings::callJNIIntMethod): (KJS::Bindings::callJNILongMethod): (KJS::Bindings::callJNIFloatMethod): (KJS::Bindings::callJNIDoubleMethod): (KJS::Bindings::callJNIVoidMethodA): (KJS::Bindings::callJNIObjectMethodA): (KJS::Bindings::callJNIByteMethodA): (KJS::Bindings::callJNICharMethodA): (KJS::Bindings::callJNIShortMethodA): (KJS::Bindings::callJNIIntMethodA): (KJS::Bindings::callJNILongMethodA): (KJS::Bindings::callJNIFloatMethodA): (KJS::Bindings::callJNIDoubleMethodA): (KJS::Bindings::callJNIBooleanMethodA): (KJS::Bindings::getCharactersFromJString): (KJS::Bindings::releaseCharactersForJString): (KJS::Bindings::getCharactersFromJStringInEnv): (KJS::Bindings::releaseCharactersForJStringInEnv): (KJS::Bindings::getUCharactersFromJStringInEnv): (KJS::Bindings::releaseUCharactersForJStringInEnv): (KJS::Bindings::JNITypeFromClassName): (KJS::Bindings::signatureFromPrimitiveType): (KJS::Bindings::JNITypeFromPrimitiveType): (KJS::Bindings::getJNIField): (KJS::Bindings::convertValueToJValue):
  • bindings/jni/jni_utility.h:
  • bindings/jni_jsobject.cpp: (KJS::Bindings::JSObject::invoke): (KJS::Bindings::JSObject::JSObject): (KJS::Bindings::JSObject::call): (KJS::Bindings::JSObject::eval): (KJS::Bindings::JSObject::getMember): (KJS::Bindings::JSObject::setMember): (KJS::Bindings::JSObject::removeMember): (KJS::Bindings::JSObject::getSlot): (KJS::Bindings::JSObject::setSlot): (KJS::Bindings::JSObject::toString): (KJS::Bindings::JSObject::finalize): (KJS::Bindings::JSObject::createNative): (KJS::Bindings::JSObject::convertValueToJObject): (KJS::Bindings::JSObject::convertJObjectToValue): (KJS::Bindings::JSObject::listFromJArray):
  • bindings/jni_jsobject.h:
  • bindings/runtime.cpp:
  • bindings/runtime.h:
  • bindings/runtime_method.cpp:
  • bindings/runtime_method.h:

Tests:

LiveConnect: Added tests for JavaScript to Java
array access.

Reviewed by John.

  • LiveConnect/Blink/Blink.java: (Blink): (Blink.init):
  • LiveConnect/Blink/test.html:

WebCore:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

  • khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText):
  • khtml/rendering/font.h:
  • khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::paintObject):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeEmptyTextStyle):

WebKit:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

  • WebCoreSupport.subproj/WebTextRenderer.m: (reverseCharactersInRun): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

WebBrowser:

Reviewed by Chris

  • BrowserNSDataExtras.m: (-[NSData certificateFromMultipartData]): Fix off-by-one error in code to strip trailing CRLFs off certificate data.

WebKitExamples:

Fixed 3455347. WEBVIEW: Dragging links from a Carbon HIWebView crash with NSException raise
Written be Ed. This code is often copy/pasted by developers, so this problem propagates.

Reviewed by Richard.

  • CarbonWeb/CarbonWeb.pbproj/project.pbxproj:
  • CarbonWeb/TWebWindow.cp:

Dec 18, 2003:

3:14 PM Changeset in webkit [5830] by rjw
  • 11 edits in trunk

WebKit:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

  • WebCoreSupport.subproj/WebTextRenderer.m: (reverseCharactersInRun): (-[WebTextRenderer _ATSU_drawHighlightForRun:style:atPoint:]): (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]): (-[WebTextRenderer _ATSU_pointToOffset:style:position:reversed:]):

WebCore:

Fixed 3511415. We have to un-visually order visually ordered text
before passing to ATSU.

Reviewed by John.

  • khtml/rendering/font.cpp: (Font::drawHighlightForText): (Font::drawText):
  • khtml/rendering/font.h:
  • khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): (RenderText::paintObject):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::drawHighlightForText):
  • kwq/WebCoreTextRenderer.h:
  • kwq/WebCoreTextRendererFactory.m: (WebCoreInitializeEmptyTextStyle):
Note: See TracTimeline for information about the timeline view.