Context Navigation

Fixed 3525853. We weren't handling mapping to overloaded Java
methods very well. Even though this is undefined the other
browsers support it. Also fixed a bug with returning arrays
from Java functions.

Reviewed by John.

bindings/jni/jni_class.cpp: (JavaClass::_commonInit): (JavaClass::methodsNamed):
bindings/jni/jni_class.h:
bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.cpp: (JavaArray::convertJObjectToArray): (JavaField::valueFromInstance): (JavaMethod::signature): (JavaArray::valueAt):
bindings/jni/jni_runtime.h:
bindings/jni_jsobject.cpp: (JSObject::call): (JSObject::convertJObjectToValue):
bindings/runtime.cpp: (MethodList::addMethod): (MethodList::length): (MethodList::methodAt): (MethodList::~MethodList):
bindings/runtime.h: (KJS::Bindings::MethodList::MethodList):
bindings/runtime_method.cpp: (RuntimeMethodImp::RuntimeMethodImp): (RuntimeMethodImp::get): (RuntimeMethodImp::call):
bindings/runtime_method.h:
bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::hasProperty):

Tests:

Extending test to cover issues in 3525853.

Reviewed by John.

ChangeLog:
LiveConnect/Blink/Blink.java: (Blink.init): (Blink.getStrings): (Blink): (Blink.getManyNumbers): (Blink.overloadedFunction):
LiveConnect/Blink/Blink.pbproj/project.pbxproj:
LiveConnect/Blink/test.html:

10:59 AM Changeset in webkit [5918] by rjw

2 edits in trunk/JavaScriptCore

Fixed 3531229. Another place that needs the Push/PopLocalFrame
protection implemented for 3530401.

Reviewed by John.

bindings/runtime_method.cpp: (RuntimeMethodImp::call):

Jan 15, 2004:

5:58 PM Changeset in webkit [5917] by rjw

8 edits in trunk/JavaScriptCore

Fixed 3530401. JNI doesn't cleanup local refs created on the
main thread. IMO this is a bad bug in our JMI implementation.

To work-around the problem I explicitly delete all local refs.
Further, I've added Push/PopLocalFrame calls to catch any refs
that I may have missed. This will guarantee that we don't leak
any Java references.

Reviewed by John.

bindings/jni/jni_class.cpp: (JavaClass::_commonInit): (JavaClass::JavaClass):
bindings/jni/jni_instance.cpp: (JavaInstance::begin): (JavaInstance::end):
bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.cpp: (JavaConstructor::JavaConstructor): (JavaMethod::JavaMethod):
bindings/jni_jsobject.cpp: (JSObject::listFromJArray):
bindings/runtime.h: (KJS::Bindings::Instance::begin): (KJS::Bindings::Instance::end):
bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty): (RuntimeObjectImp::defaultValue):

4:53 PM Changeset in webkit [5916] by hyatt

2 edits in trunk/WebCore

Fix for 3530734, many java applets don't show up. Go ahead and just use the width/height from the style
system as the initial size when the width/height are fixed.

Reviewed by rjw

khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary):

4:14 PM Changeset in webkit [5915] by kocienda

7 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

A lot of clean up in the caret class now that the
old khtmlview functions have been moved in. Many
functions have been factored together and the
API now makes a lot more sense.

khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::setPosition): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::adjustPosition): (Caret::invalidate): (Caret::setVisible): (Caret::repaint): (Caret::paint): (Caret::timerEvent):
khtml/editing/edit_caret.h: (khtml::Caret::visible):
khtml/editing/htmlediting.cpp: (InputTextCommand::apply):
khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::moveCaretTo):
khtml/khtmlview.cpp: (KHTMLView::init): (KHTMLView::clear): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):

3:44 PM Changeset in webkit [5914] by rjw

1 edit in trunk/WebCore/kwq/KWQKHTMLPart.mm

I previously checked the fix for 3529426, but the fix was commented out. Oops.

1:36 PM Changeset in webkit [5913] by kocienda

15 edits
2 adds in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Purged all caret member functions from KHTMLView,
rolling them all into the Caret class.

khtml/dom/dom_node.cpp:
khtml/dom/dom_node.h:
khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::part): (Caret::view): (Caret::initCaret): (Caret::invalidate): (Caret::recalcAndStoreCaretPos): (Caret::caretOn): (Caret::caretOff): (Caret::showCaret): (Caret::hideCaret): (Caret::updateView): (Caret::placeCaret): (Caret::paintCaret): (Caret::timerEvent): (Caret::ensureNodeHasFocus):
khtml/editing/edit_caret.h: (khtml::Caret::node): (khtml::Caret::offset): (khtml::Caret::xPos): (khtml::Caret::yPos): (khtml::Caret::height): (khtml::Caret::visible): (khtml::Caret::displayed):
khtml/editing/htmlediting.cpp: (InputTextCommand::apply):
khtml/html/html_elementimpl.cpp:
khtml/khtml_part.cpp: (KHTMLPart::setSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::moveCaretTo):
khtml/khtml_part.h:
khtml/khtmlview.cpp: (KHTMLView::init): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::layout): (KHTMLView::focusNextPrevNode): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent): (KHTMLView::timerEvent): (KHTMLView::complete):
khtml/khtmlview.h:
khtml/rendering/render_object.h:
khtml/xml/dom_nodeimpl.cpp:
khtml/xml/dom_nodeimpl.h:
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint):

1:18 PM Changeset in webkit [5912] by rjw

2 edits in trunk/WebCore

Fixed 3529426. Exclude pages that contain Java applets from
the page cache. The means applets get the normal stop/destroy
messages that they expect when a user leaves a page.

Reviewed by John.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canCachePage):

11:06 AM Changeset in webkit [5911] by vicki

7 edits in trunk

JavaScriptCore:

Reviewed by Darin.

JavaScriptCore.pbproj/project.pbxproj: Update copyright date to 2004.

WebCore:

Reviewed by Darin.

WebCore.pbproj/project.pbxproj: Update copyright date to 2004.

WebKit:

Reviewed by Darin.

WebKit.pbproj/project.pbxproj: Update copyright date to 2004.
English.lproj/InfoPlist.strings: Update copyright date to 2004.

WebBrowser:

Reviewed by Darin.

WebBrowser.pbproj/project.pbxproj: Update copyright date to 2004.

8:29 AM Changeset in webkit [5910] by kocienda

1 edit
2 deletes in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Files now obsolete.

khtml/editing/edit_caretimpl.cpp: Removed.
khtml/editing/edit_caretimpl.h: Removed.

8:28 AM Changeset in webkit [5909] by kocienda

27 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

First batch of changes from my notes I wrote while chatting
with Dave. Many small improvements.

WebCore.pbproj/project.pbxproj:
khtml/css/cssparser.cpp: (CSSParser::parseValue):
khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/css/cssvalues.h:
khtml/css/cssvalues.in:
khtml/editing/edit_caret.cpp: (Caret::Caret): (Caret::~Caret): (Caret::node): (Caret::offset): (Caret::setPosition): (Caret::moveForwardByCharacter): (Caret::moveBackwardByCharacter): (Caret::adjustPosition): (Caret::notifyChanged):
khtml/editing/edit_caret.h: (khtml::Caret::Caret):
khtml/editing/edit_caretimpl.h:
khtml/editing/htmlediting.cpp: (EditCommand::pruneEmptyNodes): (InputTextCommand::apply): (DeleteTextCommand::apply):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseAttribute): (HTMLElementImpl::contentEditable): (HTMLElementImpl::setContentEditable): (HTMLElementImpl::defaultEventHandler):
khtml/khtml_part.cpp: (KHTMLPart::clear): (KHTMLPart::findTextNext): (KHTMLPart::setSelection): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::khtmlMouseMoveEvent): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::isEditingAtCaret): (KHTMLPart::caret): (KHTMLPart::moveCaretTo): (KHTMLPart::collapseSelectionToCaret):
khtml/khtml_part.h:
khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
khtml/khtmlview.cpp: (KHTMLViewPrivate::KHTMLViewPrivate): (KHTMLViewPrivate::~KHTMLViewPrivate): (KHTMLViewPrivate::caretViewContext): (KHTMLView::initCaret): (KHTMLView::caretOverrides): (KHTMLView::recalcAndStoreCaretPos): (KHTMLView::placeCaret):
khtml/rendering/render_br.cpp: (RenderBR::caretMinOffset): (RenderBR::caretMaxOffset):
khtml/rendering/render_br.h:
khtml/rendering/render_flow.cpp: (RenderFlow::caretPos):
khtml/rendering/render_line.cpp: (InlineBox::caretMinOffset): (InlineBox::caretMaxOffset):
khtml/rendering/render_line.h:
khtml/rendering/render_replaced.cpp: (RenderReplaced::caretMinOffset): (RenderReplaced::caretMaxOffset):
khtml/rendering/render_replaced.h:
khtml/rendering/render_style.cpp: (userModify): (StyleCSS3InheritedData): (StyleCSS3InheritedData::shadowDataEquivalent):
khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::setBitDefaults): (khtml::RenderStyle::userModify): (khtml::RenderStyle::setUserModify):
khtml/rendering/render_text.h:
kwq/KWQKHTMLPart.mm: (KHTMLPart::caretPositionChanged): (KWQKHTMLPart::paint):

8:26 AM Changeset in webkit [5908] by darin

2 edits in trunk/WebCore

Reviewed by Ken.

fixed 3529943: REGRESSION (119-120): nil-deref in KHTMLPart::javaEnabled when hitting back button

khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::getAppletInstance): Add missing nil check that the other call to javaEnabled has.

Jan 14, 2004:

5:41 PM Changeset in webkit [5907] by vicki

3 edits in trunk

change version numbers to "124u", since I spun WebBrowser-123 for the Info.plist change in rdar://problem/3529511

5:10 PM Changeset in webkit [5906] by rjw

2 edits in trunk/JavaScriptCore

Fixed 3529466. With recent changes to Java plugin we must no
longer call DeleteLocalRef(). Not a problem, it was an optimization anyway.

Reviewed by John.

bindings/jni/jni_instance.cpp: (JObjectWrapper::JObjectWrapper):

5:04 PM Changeset in webkit [5905] by vicki

3 edits in trunk

change version number to "123u". The tree is open for Safari-123

4:47 PM Changeset in webkit [5904]

3 copies in tags/Safari-122

This commit was manufactured by cvs2svn to create tag 'Safari-122'.

4:47 PM Changeset in webkit [5903] by vicki

6 edits in trunk

Safari-122 stamp (we'll have to change the release marker in WebBrowser after john's check in)

4:16 PM Changeset in webkit [5902] by hyatt

2 edits in trunk/WebCore

Fix for 3527819, marquee makes page layout too wide. Make sure marquees have a minimum width of 0.

Reviewed by john

khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth): (khtml::RenderBlock::calcInlineMinMaxWidth):

1:00 PM Changeset in webkit [5901] by rjw

2 edits in trunk/JavaScriptCore

Fixed 3529010.

Finalize may be called on an JSObject after we've already remove all our references. The assert in this case is firing because we've received a finalize call from Java for an instance that we no longer know about. The fix is to check in finalize that we're getting a call on an instance that we still care about.

Reviewed by John.

bindings/jni_jsobject.cpp: (addJavaReference): (removeJavaReference): (RootObject::removeAllJavaReferencesForRoot): (JSObject::invoke):

10:41 AM Changeset in webkit [5900] by kocienda

12 edits in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Did quite a lot of cleanup in the way that
the caret position is set programmatically.
The attempt was to funnel more code through
KHTMLPart::moveCaretTo.

khtml/editing/edit_caret.cpp:
khtml/editing/edit_caret.h:
khtml/editing/edit_caretimpl.cpp: (CaretImpl::moveForwardByCharacter): (CaretImpl::moveBackwardByCharacter): (CaretImpl::setNode): (CaretImpl::setPosition): (CaretImpl::adjustPosition):
khtml/editing/edit_caretimpl.h:
khtml/editing/htmlediting.cpp: (InputTextCommand::apply): (DeleteTextCommand::apply):
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isFocusable): (HTMLElementImpl::defaultEventHandler):
khtml/html/html_elementimpl.h:
khtml/khtml_part.cpp: (KHTMLPart::moveCaretTo): (KHTMLPart::collapseSelectionToCaret): (KHTMLPart::nextNodeWithRenderer):
khtml/khtml_part.h:
khtml/khtmlview.cpp: (KHTMLView::focusNextPrevNode): (KHTMLView::initCaret):
khtml/khtmlview.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed