⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 26, 2004:

10:27 PM Changeset in webkit [5988] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • follow-on to the text-align change I did earlier today
  • khtml/css/html4.css: Set input and textarea so they do not inherit text-align from their parent by doing "text-align: -khtml-auto". This fixes google.com among others.
9:55 PM Changeset in webkit [5987] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3539414>: pop-up windows appear very narrow because of bogus width (carad.com/ebaymotors)
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Check the "OK" result from toFloat in window.open, and omit any parameters that can't be parsed.
9:35 PM Changeset in webkit [5986] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3537371>: REGRESSION (100-125): optgroup labels are no longer indented as they were before
  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Move code that adds spaces after code that strips whitespace. Also simplify the code a bit by using DOMString::string().
5:47 PM Changeset in webkit [5985] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed <rdar://problem/3539286>: text with a transparent background color pastes as black on black
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Don't put color in the mutable string if it's entirely transparent.
  • kwq/KWQColor.mm: (QColor::getNSColor): Fix bug where we would return nil for RGBA of 0.
5:37 PM Changeset in webkit [5984] by darin
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3529120>: text-align style property not respected on input fields
  • khtml/rendering/render_form.h: Added textAlignment function.
  • khtml/rendering/render_form.cpp: (RenderFormElement::textAlignment): Added. Converts style alignment to Qt alignment. (RenderLineEdit::setStyle): Call textAlignment intead of using direction from style. (RenderTextArea::setStyle): Call textAlignment intead of using direction from style.
  • kwq/KWQLineEdit.h: Added KWQNSTextAlignmentForAlignmentFlags function.
  • kwq/KWQLineEdit.mm: (QLineEdit::setAlignment): Use KWQNSTextAlignmentForAlignmentFlags instead of code that handles only left and right alignment. (KWQNSTextAlignmentForAlignmentFlags): Added. Converts Qt alignment to NS alignment.
  • kwq/KWQTextEdit.mm: (QTextEdit::setAlignment): Use KWQNSTextAlignmentForAlignmentFlags instead of code that handles only left and right alignment.
5:29 PM Changeset in webkit [5983] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by Dave.

  • fixed <rdar://problem/3477707>: background image with apostrophe in name missing at ​http://www.nbc.com
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): Use addCSSImageProperty instead of addCSSProperty, obviating the need for the "url()" syntax (and fixing quoting issues).
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute): Ditto. (HTMLTablePartElementImpl::parseAttribute): Ditto.
  • khtml/html/html_elementimpl.h: Added addCSSStringProperty and addCSSImageProperty.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addCSSStringProperty): Added. Calls setStringProperty. Not used yet. (HTMLElementImpl::addCSSImageProperty): Added. Calls setImageProperty.
  • khtml/css/css_valueimpl.h: Added setStringProperty and setImageProperty.
  • khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::setStringProperty): Added. Sets a property without parsing. (CSSStyleDeclarationImpl::setImageProperty): Added. Sets a property without parsing. You'd think we'd be able to just use setStringProperty, but that's not how the image properties work.
5:29 PM Changeset in webkit [5982] by darin
  • 7 edits in trunk/WebCore

Reviewed by Dave.

  • fixed <rdar://problem/3538433>: HomePage: table background URL with a single quote in it does not work
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseAttribute): Use addCSSImageProperty instead of addCSSProperty, obviating the need for the "url()" syntax (and fixing quoting issues).
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute): Ditto. (HTMLTablePartElementImpl::parseAttribute): Ditto.
  • khtml/html/html_elementimpl.h: Added addCSSStringProperty and addCSSImageProperty.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addCSSStringProperty): Added. Calls setStringProperty. Not used yet. (HTMLElementImpl::addCSSImageProperty): Added. Calls setImageProperty.
  • khtml/css/css_valueimpl.h: Added setStringProperty and setImageProperty.
  • khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::setStringProperty): Added. Sets a property without parsing. (CSSStyleDeclarationImpl::setImageProperty): Added. Sets a property without parsing. You'd think we'd be able to just use setStringProperty, but that's not how the image properties work.
4:11 PM Changeset in webkit [5981] by darin
  • 6 edits in trunk

Tools:

  • CommitLogEditor/Makefile.am: Switch from pbxbuild to xcodebuild.
  • HotSpotFinder/Makefile.am: Switch from pbxbuild to xcodebuild.

JavaScriptCore:

  • Makefile.am: Switch from pbxbuild to xcodebuild.

Tests:

  • Makefile.am: Switch from pbxbuild to xcodebuild.
  • ObjcUnit/Makefile.am: Switch from pbxbuild to xcodebuild.
  • TestPlugin/Makefile.am: Switch from pbxbuild to xcodebuild.
  • WebFoundation-CacheLoader/Makefile.am: Switch from pbxbuild to xcodebuild.

WebCore:

  • Makefile.am: Switch from pbxbuild to xcodebuild.

WebKit:

  • Makefile.am: Switch from pbxbuild to xcodebuild.

WebBrowser:

  • Makefile.am: Switch from pbxbuild to xcodebuild.
2:42 PM Changeset in webkit [5980] by hyatt
  • 18 adds in trunk/LayoutTests/fast/css/namespaces

Namespace tests.

2:35 PM Changeset in webkit [5979] by darin
  • 3 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/3521379>: image dimensions uses lowercase x instead of multiplication sign
  • WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation title]): Change string to use multiplication sign instead of x.
  • English.lproj/Localizable.strings: Updated.
2:33 PM Changeset in webkit [5978] by hyatt
  • 17 edits
    2 adds in trunk/WebCore

Add CSS3 @namespace support. The whole way namespaces, element, and attribute names are being handled
right now is temporary. This code gives us a baseline of functionality (for regression testing) that we
can use when we implement namespaces "the right way."

Reviewed by darin

  • WebCore.pbproj/project.pbxproj:
  • khtml/css/css_base.cpp: (CSSSelector::specificity): (CSSSelector::selectorText):
  • khtml/css/css_base.h: (DOM::CSSNamespace::m_parent): (DOM::CSSNamespace::~CSSNamespace): (DOM::CSSNamespace::uri): (DOM::CSSNamespace::prefix): (DOM::CSSNamespace::namespaceForPrefix): (DOM::CSSSelector::CSSSelector):
  • khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::CSSStyleSheetImpl): (CSSStyleSheetImpl::addNamespace): (CSSStyleSheetImpl::determineNamespace):
  • khtml/css/css_stylesheetimpl.h: (DOM::CSSStyleSheetImpl::~CSSStyleSheetImpl):
  • khtml/css/cssparser.cpp: (CSSParser::CSSParser): (CSSParser::parseSheet):
  • khtml/css/cssparser.h:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::buildLists):
  • khtml/css/html4.css:
  • khtml/css/parser.cpp:
  • khtml/css/parser.y:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::attrId): (DocumentImpl::attrName): (DocumentImpl::tagId): (DocumentImpl::tagName): (DocumentImpl::namespaceURI):
  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::getAttributeItem):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkSetPrefix):
  • khtml/xml/dom_nodeimpl.h: (DOM::namespacePart): (DOM::localNamePart): (DOM::makeId):
  • khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::checkStyleSheet):
  • khtml/xml/xml_namespace_table.cpp: Added. (DOM::XmlNamespaceTable::getNamespaceID): (DOM::XmlNamespaceTable::getNamespaceURI):
  • khtml/xml/xml_namespace_table.h: Added. (DOM::XmlNamespaceEntry::m_uri):
2:31 PM Changeset in webkit [5977] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • fixed <rdar://problem/3532519>: <select> menus show label property instead of tag contents (ups.com time and cost site)
  • khtml/html/html_formimpl.cpp: (HTMLOptionElementImpl::text): Ignore the label property as a quirk. Neither WinIE nor Mozilla implement the label property, so neither shall we (except on strict pages, where we just go crazy and do everything "right").
2:20 PM Changeset in webkit [5976] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Hyatt

  • khtml/rendering/render_line.h: (khtml::InlineBox::isFirstLineStyle): Helper to return whether the line box has the first line style bit set.
  • khtml/rendering/render_text.cpp: (RenderText::caretPos): Noe correctly accounts for white space which can precede an inline text box.
1:56 PM Changeset in webkit [5975] by hyatt
  • 17 edits in trunk/WebCore

Remove incremental repainting ifdef.

  • khtml/khtmlview.h:
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock): (khtml::RenderBlock::layoutBlockChildren): (khtml::RenderBlock::repaintObjectsBeforeLayout): (khtml::RenderBlock::positionNewFloats):
  • khtml/rendering/render_block.h:
  • khtml/rendering/render_box.cpp: (RenderBox::computeAbsoluteRepaintRect): (RenderBox::repaintDuringLayoutIfMoved):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode):
  • khtml/rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock): (khtml::RenderFlexibleBox::placeChild):
  • khtml/rendering/render_flow.cpp: (RenderFlow::getAbsoluteRepaintRect):
  • khtml/rendering/render_image.cpp: (RenderImage::layout):
  • khtml/rendering/render_layer.cpp: (RenderLayer::RenderLayer): (RenderLayer::computeRepaintRects): (RenderLayer::updateLayerPositions): (RenderLayer::updateLayerPosition): (RenderLayer::paintLayer):
  • khtml/rendering/render_layer.h: (khtml::RenderLayer::relativePositionOffset):
  • khtml/rendering/render_object.cpp: (RenderObject::setNeedsLayout): (RenderObject::setChildNeedsLayout): (RenderObject::markContainingBlocksForLayout): (RenderObject::getAbsoluteRepaintRectIncludingFloats): (RenderObject::detach): (RenderObject::scheduleRelayout):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_table.cpp: (RenderTable::layout): (RenderTableSection::layoutRows):
11:24 AM Changeset in webkit [5974] by hyatt
  • 22 edits in trunk/WebCore

Preserve the integrity of the line box tree when elements get removed. Change RenderText over to using
the same data structures as inlines and blocks for maintaining its list of line boxes.

Reviewed by kocienda

  • khtml/khtml_part.cpp: (KHTMLPart::text): (KHTMLPart::customEvent):
  • khtml/khtml_selection.cpp: (KHTMLSelection::nextCharacterPosition): (firstRunAt): (lastRunAt):
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::layoutInlineChildren):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild):
  • khtml/rendering/render_box.cpp: (RenderBox::RenderBox): (RenderBox::detach): (RenderBox::position): (RenderBox::inlineBoxWrapper): (RenderBox::deleteLineBoxWrapper):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::removeChildNode):
  • khtml/rendering/render_flow.cpp: (RenderFlow::detach):
  • khtml/rendering/render_line.cpp: (InlineFlowBox::removeChild):
  • khtml/rendering/render_line.h: (khtml::InlineBox::nextOnLine): (khtml::InlineBox::prevOnLine): (khtml::InlineBox::setNextOnLine): (khtml::InlineBox::setPrevOnLine): (khtml::InlineRunBox::prevLineBox): (khtml::InlineRunBox::nextLineBox):
  • khtml/rendering/render_object.cpp: (RenderObject::isEditable): (RenderObject::inlineBoxWrapper): (RenderObject::deleteLineBoxWrapper):
  • khtml/rendering/render_object.h: (khtml::RenderObject::documentBeingDestroyed):
  • khtml/rendering/render_text.cpp: (RenderText::RenderText): (RenderText::detach): (RenderText::deleteTextBoxes): (RenderText::absoluteRects): (RenderText::findNextInlineTextBox): (RenderText::nodeAtPoint): (RenderText::checkSelectionPointIgnoringContinuations): (RenderText::caretPos): (RenderText::paintObject): (RenderText::paint): (RenderText::minXPos): (RenderText::xPos): (RenderText::yPos): (RenderText::height): (RenderText::createInlineBox): (RenderText::position): (RenderText::width): (RenderText::caretMinOffset): (RenderText::caretMaxOffset):
  • khtml/rendering/render_text.h: (khtml::InlineTextBox:::InlineRunBox): (khtml::InlineTextBox::nextTextBox): (khtml::InlineTextBox::prevTextBox): (khtml::RenderText::firstTextBox): (khtml::RenderText::lastTextBox):
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityIsIgnored]):
  • kwq/KWQDef.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString):
  • kwq/KWQRenderTreeDebug.cpp: (write):

Jan 24, 2004:

11:13 AM Changeset in webkit [5973] by hyatt
  • 2 edits in trunk/WebCore

Polish the error message from the xml tokenizer.

  • khtml/xml/xml_tokenizer.cpp: (XMLTokenizer::finish):

Jan 23, 2004:

4:59 PM Changeset in webkit [5972] by kocienda
  • 4 edits in trunk

WebCore:

Reviewed by Richard

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setShowsFirstResponder): Now adjusts caret visibility apprpropriately.

WebKit:

Reviewed by Richard

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateShowsFirstResponder]): Renamed from updateFocusRing: since it is now used to kill caret blink timer. (-[WebHTMLView windowDidBecomeKey:]): Now calls new updateShowsFirstResponder method. (-[WebHTMLView windowDidResignKey:]): Ditto.
11:34 AM Changeset in webkit [5971] by hyatt
  • 10 edits in trunk/WebCore

Stub out @namespace support. Implement the callbacks into the stylesheet that will enable us to
store namespace information for simple selectors.

Basically with this patch we no longer bomb when we encounter namespaced stylesheets, but we don't handle
them properly yet either.

Reviewed by kocienda

  • khtml/css/css_stylesheetimpl.cpp: (CSSStyleSheetImpl::addNamespace): (CSSStyleSheetImpl::determineNamespace):
  • khtml/css/css_stylesheetimpl.h:
  • khtml/css/cssparser.cpp: (DOM::CSSParser::lex):
  • khtml/css/cssparser.h:
  • khtml/css/parser.cpp:
  • khtml/css/parser.h:
  • khtml/css/parser.y:
  • khtml/css/tokenizer.cpp:
  • khtml/css/tokenizer.flex:
10:55 AM Changeset in webkit [5970] by kocienda
  • 49 edits
    13 adds in trunk/WebCore

Reviewed by Hyatt

Merged HTML editing progress to TOT from the branch
I have been maintaining.

  • khtml/dom/dom_position.cpp: Added.
  • khtml/dom/dom_position.h: Added.
  • khtml/editing/htmlediting.cpp: Added.
  • khtml/editing/htmlediting.h: Added.
  • khtml/khtml_selection.cpp: Added.
  • khtml/khtml_selection.h: Added.
9:27 AM Changeset in webkit [5969] by kocienda
  • 29 edits
    2 adds in branches/HTML-editing-hacks-branch/WebCore

Reviewed by me

Check in before moving to HEAD.
Many more cleanups and work on caret navigation.

  • WebCore.pbproj/project.pbxproj:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyRule):
  • khtml/editing/htmlediting.cpp: (EditCommand::deleteSelection): (EditCommand::pruneEmptyNodes): (EditCommand::removeNode): (InputTextCommand::apply): (DeleteTextCommand::apply):
  • khtml/editing/htmlediting.h:
  • khtml/html/html_elementimpl.cpp:
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_inlineimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::khtmlMousePressEvent): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent):
  • khtml/khtml_selection.cpp: (KHTMLSelection::setSelection): (KHTMLSelection::setBase): (KHTMLSelection::setExtent): (KHTMLSelection::alterSelection): (KHTMLSelection::clearSelection): (KHTMLSelection::setVisible): (KHTMLSelection::invalidate): (KHTMLSelection::update): (KHTMLSelection::repaint): (KHTMLSelection::expandSelection): (KHTMLSelection::calculateStartAndEnd): (KHTMLSelection::nextCharacterPosition): (startAndEndLineNodesIncludingNode):
  • khtml/khtml_selection.h: (KHTMLSelection::):
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintObject):
  • khtml/rendering/render_object.cpp: (RenderObject::nextRenderer): (RenderObject::previousRenderer): (RenderObject::isEditable): (RenderObject::nextEditable): (RenderObject::previousEditable): (RenderObject::backslashAsCurrencySymbol):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.h: (khtml::RenderStyle::initialUserModify):
  • khtml/rendering/render_text.cpp: (RenderText::setText): (RenderText::caretMaxOffset): (RenderText::precedesLineBreak): (RenderText::followsLineBreak):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::createAttributeMap): (ElementImpl::defaultEventHandler):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::isHTMLElement):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent):
Note: See TracTimeline for information about the timeline view.