⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 6, 2004:

6:20 PM Changeset in webkit [6046] by darin
  • 2 edits in trunk/WebKit
  • Resources/missing_image.tiff: Compressed with compress-tiffs; saved 15890 bytes.
5:19 PM Changeset in webkit [6045] by hyatt
  • 18 edits
    1 add in trunk/WebCore

Implemented a TokenizerString that can walk a list of substrings, so that data can be enqueued
in the list without having to do a copy. Speeds up voodooextreme by 20% or so, giving the overall
page-load tests get a 2% boost.

Reviewed by darin

  • WebCore.pbproj/project.pbxproj:
  • khtml/html/html_documentimpl.h:
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::begin): (khtml::HTMLTokenizer::processListing): (khtml::HTMLTokenizer::parseSpecial): (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::parseComment): (khtml::HTMLTokenizer::parseServer): (khtml::HTMLTokenizer::parseProcessingInstruction): (khtml::HTMLTokenizer::parseText): (khtml::HTMLTokenizer::parseEntity): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::notifyFinished): (khtml::HTMLTokenizer::setSrc): (khtml::HTMLTokenizer::setOnHold):
  • khtml/html/htmltokenizer.h: (khtml::Token::Token): (khtml::Token::~Token): (khtml::Token::addAttribute): (khtml::Token::reset):
  • khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventDoubleClick):
  • khtml/khtml_part.h:
  • khtml/misc/stringit.cpp: Added. (khtml::TokenizerString::length): (khtml::TokenizerString::clear): (khtml::TokenizerString::append): (khtml::TokenizerString::prepend): (khtml::TokenizerString::advanceSubstring): (khtml::TokenizerString::toString):
  • khtml/misc/stringit.h: (khtml::TokenizerSubstring::TokenizerSubstring): (khtml::TokenizerSubstring::clear): (khtml::TokenizerSubstring::appendTo): (khtml::TokenizerString::TokenizerString): (khtml::TokenizerString::push): (khtml::TokenizerString::isEmpty): (khtml::TokenizerString::advance): (khtml::TokenizerString::escaped): (khtml::TokenizerString::lineCount): (khtml::TokenizerString::resetLineCount): (khtml::TokenizerString::operator++): (khtml::TokenizerString::operator*): (khtml::TokenizerString::operator->): (khtml::TokenizerString::current):
  • khtml/xbl/xbl_docimpl.cpp:
  • khtml/xbl/xbl_docimpl.h: (XBL::):
  • khtml/xbl/xbl_tokenizer.h: (XBL::):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::tokenizer):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::write):
  • khtml/xml/xml_tokenizer.h:
  • kwq/KWQSignalStubs.mm:
  • kwq/KWQValueList.h: (QValueList::insert): (QValueList::fromLast):
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::clear): (KWQValueListImpl::insert): (KWQValueListImpl::fromLast):
4:52 PM Changeset in webkit [6044] by vicki
  • 3 edits in trunk

Back to '128u'. The tree is open!

4:48 PM Changeset in webkit [6043]
  • 3 copies in tags/Safari-127

This commit was manufactured by cvs2svn to create tag 'Safari-127'.

4:48 PM Changeset in webkit [6042] by vicki
  • 6 edits in trunk

Safari-127 stamp

2:33 PM Changeset in webkit [6041] by kocienda
  • 6 edits in trunk/WebCore

Reviewed by Chris

Steps no longer return int error codes. Steps are operations
that should succeed. (When was the last time that typing in
a text editor failed for reasons which could not have been
figured out ahead of time...like file permissions?).
If this does not work for the future, perhaps we can change
some or all of the many asserts in the code to throw C++
exceptions instead, which can be caught and handled at a
suitable level.

I also made some nice convenience functions to create and apply
EditStep objects, and moved the command code to use the new
functions.

  • khtml/editing/htmlediting.cpp: (EditStep::EditStep): (EditStep::~EditStep): (EditStep::reapply): (EditStep::beginApply): (EditStep::endApply): (EditStep::beginUnapply): (EditStep::endUnapply): (EditStep::beginReapply): (EditStep::endReapply): (CompositeEditStep::unapply): (CompositeEditStep::reapply): (CompositeEditStep::applyStep): (CompositeEditStep::insertNodeBefore): (CompositeEditStep::insertNodeAfter): (CompositeEditStep::appendNode): (CompositeEditStep::removeNode): (CompositeEditStep::splitTextNode): (CompositeEditStep::joinTextNodes): (CompositeEditStep::insertText): (CompositeEditStep::deleteText): (CompositeEditStep::moveSelectionTo): (CompositeEditStep::deleteSelection): (InsertNodeBeforeStep::InsertNodeBeforeStep): (InsertNodeBeforeStep::apply): (InsertNodeBeforeStep::unapply): (AppendNodeStep::AppendNodeStep): (AppendNodeStep::apply): (AppendNodeStep::unapply): (RemoveNodeStep::RemoveNodeStep): (RemoveNodeStep::apply): (RemoveNodeStep::unapply): (ModifyTextNodeStep::ModifyTextNodeStep): (ModifyTextNodeStep::splitTextNode): (ModifyTextNodeStep::joinTextNodes): (SplitTextNodeStep::apply): (SplitTextNodeStep::unapply): (JoinTextNodesStep::apply): (JoinTextNodesStep::unapply): (InsertTextStep::InsertTextStep): (InsertTextStep::apply): (InsertTextStep::unapply): (DeleteTextStep::DeleteTextStep): (DeleteTextStep::apply): (DeleteTextStep::unapply): (MoveSelectionToStep::MoveSelectionToStep): (MoveSelectionToStep::apply): (MoveSelectionToStep::unapply): (DeleteSelectionStep::apply): (EditCommand::EditCommand): (EditCommand::~EditCommand): (EditCommand::currentSelection): (InputTextCommand::apply): (DeleteTextCommand::apply):
  • khtml/editing/htmlediting.h: (khtml::MoveSelectionToStep::~MoveSelectionToStep): (khtml::EditCommand::cookie):
  • khtml/khtml_part.cpp: (KHTMLPart::applyCommand): (KHTMLPart::undoRedoEditing): (KHTMLPart::undoEditing): (KHTMLPart::redoEditing):
  • khtml/khtml_part.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::defaultEventHandler):
1:29 PM Changeset in webkit [6040] by rjw
  • 3 edits in trunk/JavaScriptCore

Fixed 3550242 and 3546977. The first diff prevents an assert from firing. The second diff prevents a JavaScript exception, caused be an invalid conversion, which has a downstream consequence of preventing a valid conversion.

Reviewed by John.

  • bindings/jni/jni_jsobject.cpp: (JSObject::toString):
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):

Feb 5, 2004:

4:28 PM Changeset in webkit [6039] by kocienda
  • 26 edits in trunk

WebCore:

Reviewed by Hyatt

This patch includes two major pieces of work.

  1. The KHTMLSelection object has been reworked to be a value object. Part-related state has been moved out to KHTMLPart. This change makes it much easier to program with these objects, since they can now be treating unambigously like built-in types. As part of this work, I did a pass over the API and improved some function names. A related part of work was to clean up the relationship between KHTMLSelection, KHTMLPart and DOMDocumentImpl, and cleared up how to change the selection when that is necessary. (There is now a small set of functions on KHTMLPart).
  1. Implemented undo/redo, and hooked into the Cocoa undo architecture. The notion of EditCommands has been enhanced by the addition of EditSteps, which are primitive operations out of which edit commands are built. Most of the existing operations have been updated to use this new design. The last couple will be updated soon, so that all supported editing operations will be undoable.
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/htmlediting.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isFocusable): Prevents children of content editable parents from receiving focus.
  • khtml/khtml_part.cpp: Modified to work with new KHTMLSelection class design. Also added some new code to work with new edit command architecture.
  • khtml/khtml_part.h:
  • khtml/khtml_selection.cpp: Reworked as a value class. Too much state was being stored in this object for it to be convenient to use as a value. That has been fixed.
  • khtml/khtml_selection.h:
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
  • khtml/khtmlview.cpp: Modified to work with new KHTMLSelection class design.
  • khtml/rendering/render_block.cpp: Modified to work with new KHTMLSelection class design. (khtml::RenderBlock::paintObject):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): (DocumentImpl::deleteSelection): (DocumentImpl::pasteHTMLString):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::defaultEventHandler): Modified to work with new edit command architecture.
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::registerCommandForUndo): Added hook to Cocoa undo/redo architecture.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge isSelectionEditable]): Modified to work with new edit command architecture. (-[WebCoreBridge moveCaretToPoint:]): Ditto (-[WebCoreBridge haveSelection]): Ditto (-[WebCoreBridge selectedHTML]): Ditto (-[WebCoreBridge setSelectionFrom:startOffset:to:endOffset:]): Ditto (-[WebCoreBridge reconstructedSource]): Ditto (-[WebCoreBridge undoRedoEditing:]): Added hook to Cocoa undo/redo architecture.

WebKit:

Reviewed by Hyatt

Added so that editing can hook into Cocoa undo architecture.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge registerCommandForUndo:]):

Feb 4, 2004:

7:15 PM Changeset in webkit [6038] by hyatt
  • 2 edits in trunk/WebKit

Fix deployment build bustage.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (ConsoleConnectionChangeNotifyProc):
5:45 PM Changeset in webkit [6037] by hyatt
  • 34 edits in trunk/WebCore

Improve rule matching in the style system. Filter out most rules up front, so that only a small
number of rules need to be walked for any given element. Yields a ~4-5% improvement on the PLT.

Reviewed by kocienda

  • khtml/css/css_base.cpp: (StyleBaseImpl::setParsedValue): (CSSSelector::specificity): (CSSSelector::extractPseudoType): (CSSSelector::operator == ):
  • khtml/css/css_base.h: (DOM::CSSSelector::CSSSelector): (DOM::CSSSelector::~CSSSelector): (DOM::CSSSelector::append): (DOM::CSSSelector::next): (DOM::CSSSelector::): (DOM::StyleBaseImpl::StyleBaseImpl):
  • khtml/css/css_ruleimpl.cpp: (CSSStyleRuleImpl::selectorText): (CSSRuleListImpl::insertRule):
  • khtml/css/css_ruleimpl.h: (DOM::CSSStyleRuleImpl::setSelector): (DOM::CSSStyleRuleImpl::selector):
  • khtml/css/css_stylesheetimpl.cpp:
  • khtml/css/css_stylesheetimpl.h:
  • khtml/css/css_valueimpl.cpp: (CSSStyleDeclarationImpl::getPropertyCSSValue): (CSSStyleDeclarationImpl::removeProperty): (CSSStyleDeclarationImpl::setProperty): (CSSStyleDeclarationImpl::setStringProperty): (CSSStyleDeclarationImpl::setImageProperty): (CSSStyleDeclarationImpl::setLengthProperty): (CSSStyleDeclarationImpl::cssText): (CSSStyleDeclarationImpl::setCssText):
  • khtml/css/css_valueimpl.h: (DOM::CSSStyleDeclarationImpl::node): (DOM::CSSProperty::CSSProperty): (DOM::CSSProperty::id): (DOM::CSSProperty::isImportant):
  • khtml/css/cssparser.cpp: (CSSParser::CSSParser): (ParseString::lower): (CSSParser::parseValue): (CSSParser::parseDeclaration): (CSSParser::addProperty): (CSSParser::parseShadow):
  • khtml/css/cssparser.h:
  • khtml/css/cssstyleselector.cpp: (khtml::): (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::init): (khtml::CSSStyleSelector::~CSSStyleSelector): (khtml::CSSStyleSelector::loadDefaultStyle): (khtml::CSSStyleSelector::addMatchedRule): (khtml::CSSStyleSelector::addMatchedDeclaration): (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::matchRulesForList): (khtml::operator >): (khtml::operator <=): (khtml::CSSStyleSelector::sortMatchedRules): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleForElement): (khtml::CSSStyleSelector::pseudoStyleForElement): (khtml::checkPseudoState): (khtml::CSSStyleSelector::checkSelector): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSRuleSet::CSSRuleSet): (khtml::CSSRuleSet::addToRuleSet): (khtml::CSSRuleSet::addRule): (khtml::CSSRuleSet::addRulesFromSheet): (khtml::CSSStyleSelector::applyDeclarations): (khtml::CSSStyleSelector::applyProperty): (khtml::CSSStyleSelector::smallerFontSize): (khtml::CSSStyleSelector::getColorFromPrimitiveValue):
  • khtml/css/cssstyleselector.h: (khtml::): (khtml::CSSRuleData::m_next): (khtml::CSSRuleData::~CSSRuleData): (khtml::CSSRuleData::position): (khtml::CSSRuleData::rule): (khtml::CSSRuleData::selector): (khtml::CSSRuleData::next): (khtml::CSSRuleDataList::CSSRuleDataList): (khtml::CSSRuleDataList::~CSSRuleDataList): (khtml::CSSRuleDataList::first): (khtml::CSSRuleDataList::last): (khtml::CSSRuleDataList::append): (khtml::CSSRuleSet::~CSSRuleSet): (khtml::CSSRuleSet::getIDRules): (khtml::CSSRuleSet::getClassRules): (khtml::CSSRuleSet::getTagRules): (khtml::CSSRuleSet::getUniversalRules):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/css/html4.css:
  • khtml/css/parser.cpp:
  • khtml/css/parser.h:
  • khtml/css/parser.y:
  • khtml/dom/dom_element.cpp: (Element::style):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::HTMLBodyElementImpl): (HTMLBodyElementImpl::~HTMLBodyElementImpl): (HTMLBodyElementImpl::createLinkDecl): (HTMLBodyElementImpl::parseAttribute):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLNamedAttrMapImpl::parseClassAttribute): (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::~HTMLElementImpl): (HTMLElementImpl::createInlineStyleDecl): (HTMLElementImpl::createMappedAttributeDecl): (HTMLElementImpl::parseAttribute): (HTMLElementImpl::getClassList): (HTMLElementImpl::addCSSProperty): (HTMLElementImpl::addCSSStringProperty): (HTMLElementImpl::addCSSImageProperty): (HTMLElementImpl::addCSSLength): (HTMLElementImpl::addHTMLColor): (HTMLElementImpl::removeCSSProperty):
  • khtml/html/html_elementimpl.h: (DOM::HTMLNamedAttrMapImpl::getClassList): (DOM::HTMLElementImpl::inlineStyleDecl): (DOM::HTMLElementImpl::attributeStyleDecl): (DOM::HTMLElementImpl::getInlineStyleDecl):
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::createSharedCellDecls): (HTMLTableCellElementImpl::additionalAttributeStyleDecl):
  • khtml/html/html_tableimpl.h:
  • khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::add): (DOM::AtomicString::remove):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::resetLinkColor): (DocumentImpl::resetVisitedLinkColor): (DocumentImpl::resetActiveLinkColor): (DocumentImpl::recalcStyleSelector):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::linkColor): (DOM::DocumentImpl::visitedLinkColor): (DOM::DocumentImpl::activeLinkColor): (DOM::DocumentImpl::setLinkColor): (DOM::DocumentImpl::setVisitedLinkColor): (DOM::DocumentImpl::setActiveLinkColor):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::ElementImpl): (ElementImpl::~ElementImpl): (ElementImpl::getClassList): (ElementImpl::getIDAttribute): (ElementImpl::cloneNode): (XMLElementImpl::cloneNode):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::inlineStyleDecl): (DOM::ElementImpl::attributeStyleDecl): (DOM::ElementImpl::getInlineStyleDecl): (DOM::ElementImpl::additionalAttributeStyleDecl): (DOM::NamedAttrMapImpl::id): (DOM::NamedAttrMapImpl::setID):
  • khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::DOMStringImpl): (DOM::DOMStringImpl::~DOMStringImpl): (DOM::DOMStringImpl::append): (DOM::DOMStringImpl::insert): (DOM::DOMStringImpl::truncate): (DOM::DOMStringImpl::remove): (DOM::DOMStringImpl::split):
  • khtml/xml/dom_stringimpl.h: (DOM::DOMStringImpl::DOMStringImpl):
2:22 PM Changeset in webkit [6036] by hyatt
  • 4 edits in trunk/WebCore

Fix line-height regression on altavista.

  • khtml/rendering/render_br.cpp: (RenderBR::RenderBR): (RenderBR::position): (RenderBR::lineHeight): (RenderBR::setStyle):
  • khtml/rendering/render_br.h:
  • khtml/rendering/render_flow.h: (khtml::RenderFlow::RenderFlow):
1:49 PM Changeset in webkit [6035] by kocienda
  • 9 edits in trunk/LayoutTests

Committed new tests for RenderBR change

1:33 PM Changeset in webkit [6034] by hyatt
  • 3 edits in trunk/WebCore

Fix a regression in the line-height of first-lines and inline-blocks.

Reviewed by darin

  • khtml/rendering/render_flow.cpp: (RenderFlow::lineHeight):
  • khtml/rendering/render_text.cpp: (RenderText::lineHeight):
10:45 AM Changeset in webkit [6033] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3546028>: Safari should not give plug-ins any time, thus use 0% CPU, when not in the currently active session

Reviewed by john.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView initialize]): observe CG changes (-[WebBaseNetscapePluginView addWindowObservers]): observe user switch notifications (-[WebBaseNetscapePluginView removeWindowObservers]): stop observing user switch notifications (-[WebBaseNetscapePluginView viewHasMoved:]): tweak (-[WebBaseNetscapePluginView windowWillClose:]): tweak (-[WebBaseNetscapePluginView windowBecameKey:]): tweak (-[WebBaseNetscapePluginView windowResignedKey:]): tweak (-[WebBaseNetscapePluginView windowDidMiniaturize:]): tweak (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): tweak (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]): new, stop null events (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]): new, restart null events (ConsoleConnectionChangeNotifyProc): new, post user switch notifications
Note: See TracTimeline for information about the timeline view.