Context Navigation

← Previous Period
Next Period →

Timeline

Feb 15, 2004:

11:54 AM Changeset in webkit [6091] by darin

2 edits in trunk/WebKit

Reviewed by Dave.

WebKit.pbproj/project.pbxproj: Tweak build styles a bit, fixing OptimizedWithSymbols, and removing redundant settings of things that match defaults in other build styles.

11:51 AM Changeset in webkit [6090] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

WebCore.pbproj/project.pbxproj: Tweak build styles a bit, fixing OptimizedWithSymbols, and removing redundant settings of things that match defaults in other build styles.

11:51 AM Changeset in webkit [6089] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Dave.

JavaScriptCore.pbproj/project.pbxproj: Tweak build styles a bit, fixing OptimizedWithSymbols, and removing redundant settings of things that match defaults in other build styles.

10:50 AM Changeset in webkit [6088] by darin

2 edits in trunk/WebCore

Reviewed by Dave.

fixed 3548533: crash in XMLHttpRequest::slotData using Orkut's rating system

khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::~XMLHttpRequest): Delete the QObject side, which has a side effect of disconnecting the signals which seem to be firing after the request is gone. There may be another way of addressing the crash by correcting some other problem with killing the job, but this demonstrably works and fixes a storage leak.

Feb 13, 2004:

6:10 PM Changeset in webkit [6087] by mjs

7 edits in trunk

WebCore:

Reviewed by John.

redo visited link history checking for a 2% speed improvement

kwq/KWQKHistoryProvider.mm: (KParts::HistoryProvider::contains): Don't make a KURL or an NSString. Punt on canonicalization and directly pass the internal Latin1 or unicode buffer.
kwq/KWQString.h:
kwq/KWQString.mm: (QString::hasFastLatin1): New method to check whether getting the latin1 buffer is fast (doesn't allocate).
kwq/WebCoreHistory.h: add new methods to look up by raw latin1 or unicode buffer instead of NSString.

WebKit:

Reviewed by John.

redo visited link history checking for a 2% speed improvement

History.subproj/WebHistory.m: (-[_WebCoreHistoryProvider containsItemForURLString:]): Removed. (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]): Implemented. For https and http URLs with empty path, add a slash. Make a CFString using the passed-in latin1 buffer without copying. (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]): Ditto for unicode. (matchLetter): New static helper function. (matchUnicodeLetter): Ditto.

2:39 PM Changeset in webkit [6086] by rjw

14 edits
13 adds in trunk/JavaScriptCore

rk towards the JavaScript ObjC bindings. The bindings now work for

simple scalar types. testbindings.mm is an illustration of how the
bindings work.

Reviewed by Ken.

JavaScriptCore.pbproj/project.pbxproj:
Makefile.am:
bindings/jni/jni_class.cpp: (JavaClass::methodsNamed):
bindings/jni/jni_class.h:
bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
bindings/jni/jni_instance.h:
bindings/jni/jni_runtime.h: (KJS::Bindings::JavaMethod::returnType):
bindings/make_testbindings: Added.
bindings/objc/objc_class.h: Added. (KJS::Bindings::ObjcClass::~ObjcClass): (KJS::Bindings::ObjcClass::ObjcClass): (KJS::Bindings::ObjcClass::operator=): (KJS::Bindings::ObjcClass::constructorAt): (KJS::Bindings::ObjcClass::numConstructors):
bindings/objc/objc_class.mm: Added. (ObjcClass::_commonDelete): (ObjcClass::_commonCopy): (ObjcClass::_commonInit): (_createClassesByIsAIfNecessary): (ObjcClass::classForIsA): (ObjcClass::ObjcClass): (ObjcClass::name): (ObjcClass::methodsNamed): (ObjcClass::fieldNamed):
bindings/objc/objc_header.h: Added.
bindings/objc/objc_instance.h: Added. (KJS::Bindings::ObjcInstance::getObject):
bindings/objc/objc_instance.mm: Added. (ObjcInstance::ObjcInstance): (ObjcInstance::~ObjcInstance): (ObjcInstance::operator=): (ObjcInstance::begin): (ObjcInstance::end): (ObjcInstance::getClass): (ObjcInstance::invokeMethod): (ObjcInstance::defaultValue): (ObjcInstance::stringValue): (ObjcInstance::numberValue): (ObjcInstance::booleanValue): (ObjcInstance::valueOf):
bindings/objc/objc_jsobject.h: Added.
bindings/objc/objc_jsobject.mm: Added.
bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcField::~ObjcField): (KJS::Bindings::ObjcField::ObjcField): (KJS::Bindings::ObjcField::operator=): (KJS::Bindings::ObjcMethod::ObjcMethod): (KJS::Bindings::ObjcMethod::~ObjcMethod): (KJS::Bindings::ObjcMethod::operator=):
bindings/objc/objc_runtime.mm: Added. (ObjcMethod::ObjcMethod): (ObjcMethod::name): (ObjcMethod::numParameters): (ObjcMethod::getMethodSignature): (ObjcField::ObjcField): (ObjcField::name): (ObjcField::type): (ObjcField::valueFromInstance): (ObjcField::setValueToInstance):
bindings/objc/objc_utility.h: Added. (KJS::Bindings::):
bindings/objc/objc_utility.mm: Added. (KJS::Bindings::JSMethodNameToObjCMethodName): (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue): (KJS::Bindings::objcValueTypeForType):
bindings/runtime.cpp: (MethodList::MethodList): (MethodList::operator=): (Instance::setValueOfField): (Instance::createBindingForLanguageInstance): (Instance::createRuntimeObject):
bindings/runtime.h:
bindings/runtime_method.cpp: (RuntimeMethodImp::RuntimeMethodImp): (RuntimeMethodImp::get): (RuntimeMethodImp::call):
bindings/runtime_method.h:
bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::hasProperty):
bindings/test.js: Added.
bindings/testbindings.mm: Added. (-[MySecondInterface init]): (-[MyFirstInterface init]): (-[MyFirstInterface dealloc]): (+[MyFirstInterface JavaScriptNameForSelector:]): (-[MyFirstInterface getInt]): (-[MyFirstInterface setInt:]): (-[MyFirstInterface getMySecondInterface]): (-[MyFirstInterface logMessage:]): (GlobalImp::className): (readJavaScriptFromFile): (main):

12:08 PM Changeset in webkit [6085] by vicki