⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 28, 2004:

9:23 PM Changeset in webkit [6733] by ouch
  • 4 edits in trunk/WebCore

Reviewed by gramps.

  • removed setShadowWithColor and change setShadow to work with optional attributes

it follows the same rules as setFill/StrokeColor

  • Fixed bug in setFillColor and setStrokeColor for CMYK colors (missing break in case).
  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
  • khtml/ecma/kjs_html.h: (KJS::Context2D::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
5:07 PM Changeset in webkit [6732] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _fontManagerOperationAsStyle]): First cut at figuring out what operation the font manager is doing without digging into its private data structures.
4:26 PM Changeset in webkit [6731] by darin
  • 16 edits in trunk

WebCore:

Reviewed by Ken.

  • various editing-related improvements
  • khtml/xml/dom_selection.h: Removed UP and DOWN directions, and added PARAGRAPH granularity.
  • khtml/xml/dom_selection.cpp: (DOM::Selection::modify): Got rid of the UP and DOWN directions, and made movement between lines happen when granularity is LINE. Added a new unimplemented granularity: PARAGRAPH. (DOM::Selection::validate): Remove some unneeded APPLE_CHANGES. The code need not be ifdef'd. (DOM::Selection::debugPosition): Ditto.
  • kwq/WebCoreBridge.h: Removed WebSelectUp and WebSelectDown, and added WebSelectByParagraph. Added stringForRange: and selectedDOMRangeWithGranularity:, and renamed replaceSelectionWithNewline to insertNewline because it has the insertText: semantic, not the replaceSelectionWithText: one.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stringForRange:]): Added. (-[WebCoreBridge selectedDOMRangeWithGranularity:]): Added. (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): Updated code to understand that vertical movement is based on granularity now, not direction. (-[WebCoreBridge replaceSelectionWithFragment:selectReplacement:]): Moved an ensureCaretVisible from the WebKit down here. I think perhaps this should go down even further in WebCore. (-[WebCoreBridge insertNewline]): Renamed, and moved ensureCaretVisible here. (-[WebCoreBridge insertText:]): Moved ensureCaretVisible here. (-[WebCoreBridge deleteKeyPressed]): Moved ensureCaretVisible here.
  • khtml/xml/dom_position.cpp: Some ifdef tweaks.
  • khtml/misc/helper.cpp: Namespace and formatting tweaks.
  • khtml/misc/helper.h: Removed some unused stuff.
  • khtml/dom/dom2_range.h: Make range constructor public so that anyone with a RangeImpl can easily make a Range.

WebKit:

Reviewed by Ken.

  • various editing-related improvements
  • fixed <rdar://problem/3655366>: (Editing: -selectParagraph: method unimplemented (WebKit editing API))
  • fixed <rdar://problem/3655367>: (Editing: -selectLine: method unimplemented (WebKit editing API))
  • fixed <rdar://problem/3655369>: (Editing: -selectWord: method unimplemented (WebKit editing API))
  • fixed <rdar://problem/3655392>: (Editing: -uppercaseWord: method unimplemented (WebKit editing API))
  • fixed <rdar://problem/3655393>: (Editing: -lowercaseWord: method unimplemented (WebKit editing API))
  • fixed <rdar://problem/3655394>: (Editing: -capitalizeWord: method unimplemented (WebKit editing API))
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _alterCurrentSelection:direction:granularity:]): Removed the call to ensureCaretVisible. This is now handled on the other side of the bridge. (-[WebHTMLView moveDown:]): Changed to use WebSelectByLine granularity instead of WebSelectDown direction. (-[WebHTMLView moveDownAndModifySelection:]): Ditto. (-[WebHTMLView moveUp:]): Ditto. (-[WebHTMLView moveUpAndModifySelection:]): Ditto. (-[WebHTMLView _expandSelectionToGranularity:]): Added. (-[WebHTMLView selectParagraph:]): Implemented by calling _expandSelectionToGranularity. (-[WebHTMLView selectLine:]): Ditto. (-[WebHTMLView selectWord:]): Ditto. (-[WebHTMLView _fontManagerOperationAsStyle]): Added. Placeholder for the job of figuring out what style change to make based on NSFontManager. (-[WebHTMLView changeFont:]): Implemented, but not really tested because guts are still missing due to lack of above method. (-[WebHTMLView insertTab:]): Removed the call to ensureCaretVisible. (-[WebHTMLView insertNewline:]): Removed the call to ensureCaretVisible. (-[WebHTMLView insertParagraphSeparator:]): Made this insert a newline for now. (-[WebHTMLView _changeWordCaseWithSelector:]): Added. (-[WebHTMLView uppercaseWord:]): Implemented by calling _changeWordCaseWithSelector. (-[WebHTMLView lowercaseWord:]): Ditto. (-[WebHTMLView capitalizeWord:]): Ditto. (-[WebHTMLView deleteBackward:]): Removed the call to ensureCaretVisible. (-[WebHTMLView checkSpelling:]): Put a pile of AppKit code in here as a placeholder. (-[WebHTMLView startSpeaking:]): Use the new stringForRange: method instead of outerText. That way we can handle cases where the entire document is selected. (-[WebHTMLView insertText:]): Removed the call to ensureCaretVisible.
2:40 PM Changeset in webkit [6730] by rjw
  • 4 edits in trunk/WebCore

setStrokeColor and setFillColor now support
old school web color string, oswcs+alpha, gray, gray+alpha,
rgba, and cmyka.

Reviewed by jay-lo.

  • khtml/css/cssparser.cpp: (CSSParser::parseColor): (CSSParser::parseColorFromValue):
  • khtml/css/cssparser.h: Made parseColor static public class method
  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
12:41 PM Changeset in webkit [6729] by cblu
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/3672129>: (selection deselects when clicking editable WebView in background window)

Fixed this problem by using NSTextView's approach of only allowing dragging on first mouse down.

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView acceptsFirstMouse:]): store the first mouse down (-[WebHTMLView mouseDown:]): Don't tell WebCore about the first mouse down event since only dragging can occur on the first mouse down. (-[WebHTMLView mouseDragged:]): Don't tell WebCore about the drags that occur after the first mouse down since only dragging can occur after the first mouse down.
  • WebView.subproj/WebHTMLViewInternal.h:
12:33 PM Changeset in webkit [6728] by hyatt
  • 15 edits in trunk/WebCore

Implement -khtml-user-select and add support for the property -khtml-user-drag (although someone will still
need to wire it up).

Reviewed by rjw

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.c: (hash_prop): (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/cssvalues.c: (hash_val): (findValue):
  • khtml/css/cssvalues.h:
  • khtml/css/cssvalues.in:
  • khtml/khtml_part.cpp: (KHTMLPart::handleMousePressEventDoubleClick): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection):
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::setSelection):
  • khtml/rendering/render_object.cpp: (RenderObject::shouldSelect):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_style.cpp: (userSelect): (StyleCSS3NonInheritedData::operator==): (RenderStyle::diff):
  • khtml/rendering/render_style.h: (khtml::): (khtml::RenderStyle::userDrag): (khtml::RenderStyle::userSelect): (khtml::RenderStyle::setUserDrag): (khtml::RenderStyle::setUserSelect): (khtml::RenderStyle::initialUserDrag): (khtml::RenderStyle::initialUserSelect):
11:33 AM Changeset in webkit [6727] by ouch
  • 4 edits in trunk/WebCore

added addArc and clip path routines.

Reviewed by sullivan.

  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
  • khtml/ecma/kjs_html.h: (KJS::Context2D::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
11:00 AM Changeset in webkit [6726] by kdecker
  • 1 edit in trunk/WebKit/ChangeLog
  • WebView.subproj/WebView.m: At Ken's suggestion, for better efficiency and safety, use _cmd rather than explicit selector names in the forwarding methods.
10:57 AM Changeset in webkit [6725] by kdecker
  • 1 edit in trunk/WebKit/ChangeLog
  • WebView.subproj/WebView.m: At Ken's suggestion, for better efficiency and safety, use _cmd rather than explicit selector names in the forwarding methods.
10:47 AM Changeset in webkit [6724] by kdecker
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Reviewed by Ken.

-revised generated error message content

  • kjs/error_object.cpp: (ErrorProtoFuncImp::call):
  • kjs/internal.cpp: (Parser::parse):
  • kjs/object.cpp: (KJS::Error::create):
10:21 AM Changeset in webkit [6723] by darin
  • 2 edits in trunk/WebKit
  • WebView.subproj/WebView.m: At Ken's suggestion, for better efficiency and safety, use _cmd rather than explicit selector names in the forwarding methods.
10:21 AM Changeset in webkit [6722] by kdecker
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Added addArcToPoint and addRect path routines.

Reviewed by sullivan.

  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
  • khtml/ecma/kjs_html.h: (KJS::Context2D::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
10:14 AM Changeset in webkit [6721] by darin
  • 9 edits
    1 add in trunk/WebKit

Reviewed by Ken.

  • implemented a few more editing operations, moved code from WebView to WebHTMLView
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge respondToChangedContents]): Call _updateFontPanel on the WebHTMLView, not the WebView. (-[WebBridge respondToChangedSelection]): Ditto.
  • WebView.subproj/WebHTMLView.m: Moved WebElementOrTextFilter class here from WebView and gave it a prefix so it won't conflict with developers' class names. (-[WebHTMLView _updateFontPanel]): Moved here from WebView.
  • WebView.subproj/WebView.m: (-[WebView toggleSmartInsertDelete:]): Added. (-[WebView toggleContinuousSpellChecking:]): Added. (-[WebView isContinuousGrammarCheckingEnabled]): Added. (-[WebView setContinuousGrammarCheckingEnabled:]): Added. (-[WebView toggleContinuousGrammarChecking:]): Added. (-[WebView setSmartInsertDeleteEnabled:]): Implemented. We have the flag now, although we still don't actually have smart insert and delete implemented. (-[WebView smartInsertDeleteEnabled]): Ditto. (-[WebView setContinuousSpellCheckingEnabled:]): Implemented. (-[WebView isContinuousSpellCheckingEnabled]): Implemented. (-[WebView spellCheckerDocumentTag]): Implemented. (-[WebView _preflightSpellCheckerNow:]): Added. (-[WebView _preflightSpellChecker]): Added. (-[WebView _continuousCheckingAllowed]): Added.
  • WebView.subproj/WebHTMLViewInternal.h: Added. We'll things here from WebHTMLViewPrivate so they are internal to the framework, rather than SPI.
  • WebKit.pbproj/project.pbxproj: Added WebHTMLViewInternal.h.
  • WebView.subproj/WebHTMLViewPrivate.h: Moved WebHTMLViewPrivate into the internal header. Despite its name, it's internal, not SPI.
  • WebView.subproj/WebViewPrivate.h: Moved WebViewPrivate into the internal header. Despite its name, it's internal, not SPI. Added a number of new operations which should be public API. We'll have to figure out what to do about API review and the WWDC deadline.
  • WebView.subproj/WebViewInternal.h: Removed _updateFontPanel method.
  • English.lproj/StringsNotToBeLocalized.txt: Update.
8:54 AM Changeset in webkit [6720] by ouch
  • 4 edits in trunk/WebCore

Added addArcToPoint and addRect path routines.

Reviewed by sullivan.

  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall):
  • khtml/ecma/kjs_html.h: (KJS::Context2D::):
  • khtml/ecma/kjs_html.lut.h: (KJS::):
7:19 AM Changeset in webkit [6719] by kocienda
  • 6 edits in trunk

Tests:

Reviewed by Maciej.

  • moved to new symlink technique for embedding frameworks
  • Blot/Blot.xcode/project.pbxproj: Call the new create-framework-symlinks script instead of copy-frameworks-to-dstroot.sh.
  • Blot/embed-frameworks.sh: Removed.
  • PDFViewer/PDFViewer.pbproj/project.pbxproj: Call the new create-framework-symlinks script instead using a copy files phase.

WebCore:

Reviewed by John

  • khtml/xml/dom_selection.cpp: (DOM::Selection::toRange): Add call to update document layout before returning a Range. This is done to ensure recently-done editing changes are reflected in the calculation of the Range. This change solves a specific problem with updating the font panel, where the wrong Range was used, resulting in an incorrect font. Also, defer converting positions to be range-compliant positions. The nodeIsBeforeNode function is not range-compliant-position-savvy.

WebKit:

Reviewed by John

The font panel now updates correctly, reflecting the current selection. There may
still be some bugs and corner cases to handle, but this will work for a general
implementation of the feature.

  • WebView.subproj/WebView.m: (+[ElementOrTextFilter filter]): Added. This filter will accept DOM elements and text nodes and skip everything else. This filter is used when walking a selection to determine the fonts in use. (-[ElementOrTextFilter acceptNode:]): DOM node filter implementation method. (-[WebView _fontFromStyle]): Removed, in lieu of new fontForCurrentPosition call on the bridge. (-[WebView _updateFontPanel]): Reworked to use a TreeWalker instead of a NodeIterator. This was done since the iterator must be rooted at the document root, but start iterating at the start of the selection. TreeWalker's setCurrentNode allows this to be done.
Note: See TracTimeline for information about the timeline view.