Timeline

Jul 27, 2004:

3:00 PM Changeset in webkit [7131] by kocienda

• 6 edits in trunk/WebCore

Reviewed by Hyatt

Fixed the problem where BR elements on lines by themselves don't paint when selected.

• khtml/khtml_part.cpp: (KHTMLPart::selectAll): Related fix. Include BR's when figuring out what "all" is.
• khtml/rendering/render_br.cpp: (RenderBR::paint): New function implementation. Teach BR's how to paint selections.
• khtml/rendering/render_br.h:
• khtml/rendering/render_text.cpp: (InlineTextBox::paintSelection): Fix some geometry calculations to be more readable (i.e. don't reuse function argument as a local). Also, improve the logic for determining whether to extend the selection to block boundaries. (RenderText::paint): Remove extendSelection argument from paintSelection. The logic to figure out extensions is now fully contained in paintSelection.
• khtml/rendering/render_text.h:

1:13 PM Changeset in webkit [7130] by sullivan

• 2 edits in trunk/WebKit

WebKit:

Reviewed by Trey.

WebKit part of fix for <rdar://problem/3622268> Reload failed pages when a
network problem is corrected, inc. using Network Diagnostics

• WebView.subproj/WebFrame.m: (-[WebFrame reload]): This method did not handle unreachableURLs at all. The reason Safari's Reload did work with unreachableURLs was that Safari does "reloadObeyingLocationField" which never actually calls -[WebFrame reload]. Fixed by creating a fresh request for the previously-unreachable URL.

WebBrowser:

Reviewed by Trey.

• part of fix for <rdar://problem/3622268> Reload failed pages when a network problem is corrected, inc. using Network Diagnostics

We don't actually use Network Diagnostics yet, but we now react to network
configuration changes by reloading any error pages. Using Network Diagnostics
is the remaining part of 3622268.

• NetworkController.h: Added. New file, copied and simplified from Message project.
• NetworkController.m: Added. New file, copied and simplified from Message project. (+[NetworkController sharedInstance]): returns singleton instance (-[NetworkController dealloc]): release ivars (-[NetworkController init]): call _listenForNetworkChanges (-[NetworkController _postNetworkChangeNotification:]): post notification that network configuration changed (_networkChangeCallBack): call _postNetworkChangeNotification after a delay to coalesce multiple SystemConfiguration callbacks (_listenForNetworkChanges): register with SystemConfiguration for network changes

• BrowserWebController.h: new ivar _registeredForNetworkConfigurationChanges
• BrowserWebController.m: (-[BrowserWebView dealloc]): if registered for network config changes, remove appropriate observer (-[BrowserWebView networkConfigurationDidChange:]): reload main frame if it's showing an unreachable URL (-[BrowserWebView showErrorPageForURL:withTitle:message:]): register for network config changes if necessary

• WebBrowser.pbproj/project.pbxproj: updated for new files and for including the SystemConfiguration framework

10:47 AM Changeset in webkit [7129] by hyatt

• 2 edits in trunk/WebCore

Fix for 3665211 (again). Make sure not to leave child line boxes pointing to deleted ancestor line boxes.

Reviewed by kocienda

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild):

Jul 26, 2004:

4:25 PM Changeset in webkit [7128] by rjw

• 3 edits in trunk/WebKit

Fixed 3739737. When setting the focus to a NSView, set the focus
carbon focus to kControlIndicatorPart. kControlIndicatorPart is a
placeholder value for use to indicate that Cocoa has the focus.

Reviewed by Ken.

• Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter makeFirstResponder:]):
• Carbon.subproj/HIWebView.m: (Click): (SetFocusPart):

4:13 PM Changeset in webkit [7127] by cblu

• 2 edits in trunk/WebCore

Fixed: WebView scrolls to the top after making an editing change via drag & drop

Fixed by Ken, reviewed by me.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge ensureCaretVisible]): do nothing if the selection is not a caret

4:13 PM Changeset in webkit [7126] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3689734> dragging to an editable WebView does not scroll document

Reviewed by rjw.

• WebView.subproj/WebView.m: (-[WebView documentViewAtWindowPoint:]): new, factored from draggingDocumentViewAtWindowPoint: (-[WebView _draggingDocumentViewAtWindowPoint:]): call documentViewAtWindowPoint: (-[WebView _autoscrollForDraggingInfo:timeDelta:]): forward call to the document view (-[WebView _shouldAutoscrollForDraggingInfo:]): ditto

4:09 PM Changeset in webkit [7125] by vicki

• 3 edits in trunk

change version number to 154u, 2.0

4:01 PM Changeset in webkit [7124]

• 3 copies in tags/Safari-153

This commit was manufactured by cvs2svn to create tag 'Safari-153'.

4:01 PM Changeset in webkit [7123] by vicki

• 6 edits in trunk

Safari-153 stamp

3:45 PM Changeset in webkit [7122] by mjs

• 2 edits
  9 adds in trunk

Reviewed by John.

<rdar://problem/3740855> REGRESSION: Flash incorrectly positioned at macromedia.com

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptExecution): Do the prepending-src trick as for inline script execution.

Added new layout tests covering this and other recent tokenizer
bugs.

• layout-tests/fast/tokenizer/001-expected.txt: Added.
• layout-tests/fast/tokenizer/001.html: Added.
• layout-tests/fast/tokenizer/002-expected.txt: Added.
• layout-tests/fast/tokenizer/002.html: Added.
• layout-tests/fast/tokenizer/003-expected.txt: Added.
• layout-tests/fast/tokenizer/003.html: Added.
• layout-tests/fast/tokenizer/resources/003-script.js: Added.

3:31 PM Changeset in webkit [7121] by kdecker

• 8 edits
  1 delete in trunk/JavaScriptCore

Changes done by Darin, reviewed by Kevin.

• changed testkjs to build in Xcode rather than from Makefile

• .cvsignore: Removed obsolete files from this list.
• Makefile.am: Removed code to build testkjs; we do this in Xcode now. Changed to build target "All" rather than default target. This makes us build the testkjs test tool.
• dummy.cpp: Removed.
• kjs/.cvsignore: Removed obsolete files from this list, including the testkjs tool, which is now built in the symroots directory.
• kjs/testkjs.cpp: Added copyright notice that was missing, since we have changed this file. Also this has the nice side effect of causing the tool to be rebuilt in the new location even if there are no other changes in your tree when you check this out.
• tests/mozilla/run-mozilla-tests: Invoke perl explicitly so this works without setting the execute bit on jsDriver.pl.

2:13 PM Changeset in webkit [7120] by rjw

• 5 edits in branches/Safari-1-0-branch/WebKit

Fix for 3739752. We now clear the carbon control focus when setting
the focus on a Cocoa NSView. When a carbon control receives a click we de-focus any Cocoa NSView. This fixes the problem, but we still
have 3739736, which may never be fixed for Jaguar.

Reviewed by Ken.

• Carbon.subproj/CarbonWindowAdapter.h:
• Carbon.subproj/CarbonWindowAdapter.m: (-[CarbonWindowAdapter relinquishFocus]): (-[CarbonWindowAdapter makeFirstResponder:]):
• Carbon.subproj/HIWebView.m: (Click): (OwningWindowChanged): (WindowHandler):
• WebKit.pbproj/project.pbxproj:

11:34 AM Changeset in webkit [7119]

• 21 copies
  3 deletes in tags/WebKit-125~4~2

This commit was manufactured by cvs2svn to create tag
'WebKit-125~4~2'.

11:34 AM Changeset in webkit [7118] by vicki

• 2 edits in branches/Safari-1-2-branch/WebKit

• WebKit-125.4.2 stamp

10:58 AM Changeset in webkit [7117] by darin

• 2 edits in branches/Safari-1-2-branch/WebKit

• fix 3721690 bug fix so it compiles

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Change this so it compiles.