Timeline
Aug 29, 2004:
- 2:47 PM Changeset in webkit [7397] by
-
- 6 edits in trunk/WebCore
Reviewed by John.
<rdar://problem/3778314> REGRESSION: Can't proceed to survey questions on Lominger's Apple website
Because we will stop parsing when there is a pending redirection,
avoid setting one if no navigation would actually take place
because the number of steps is out of range.
- khtml/khtml_part.cpp: (KHTMLPart::scheduleHistoryNavigation):
- kwq/KWQKHTMLPart.h:
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canGoBackOrForward):
- kwq/KWQKPartsBrowserInterface.h:
- kwq/WebCoreBridge.h:
Aug 27, 2004:
- 5:31 PM Changeset in webkit [7396] by
-
- 6 edits7 adds in trunk
Reviewed by Chris.
- fixed <rdar://problem/3778043> REGRESSION: innerHTML is broken, breaks automated iBench testing
- also fixed outerHTML, which would spill over past the node for whch it was supposed to get HTML
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::outerHTML):
- khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML):
- khtml/xml/dom_nodeimpl.cpp: (NodeImpl::toHTML): (NodeImpl::recursive_toString): (NodeImpl::recursive_toHTML):
- khtml/xml/dom_nodeimpl.h:
- kwq/WebCoreBridge.mm: (-[WebCoreBridge markupStringFromNode:nodes:]):
- added new layout tests to cover the problems I fixed
- layout-tests/fast/innerHTML/001-expected.txt: Added.
- layout-tests/fast/innerHTML/001.html: Added.
- layout-tests/fast/innerHTML/002-expected.txt: Added.
- layout-tests/fast/innerHTML/002.html: Added.
- layout-tests/fast/innerHTML/003-expected.txt: Added.
- layout-tests/fast/innerHTML/003.html: Added.
- 5:07 PM Changeset in webkit [7395] by
-
- 1 edit in trunk/WebCore/khtml/css/css_computedstyle.cpp
* empty log message *
- 5:06 PM Changeset in webkit [7394] by
-
- 3 edits in trunk/WebCore
Fix for 3739239, getComputedStyle of top not being implemented broke a site that checked for it.
Reviewed by kocienda
- khtml/css/css_computedstyle.cpp: (DOM::valueForLength): (DOM::CSSComputedStyleDeclarationImpl::getPositionOffsetValue): (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
- khtml/css/css_computedstyle.h:
- 3:39 PM Changeset in webkit [7393] by
-
- 2 edits in trunk/WebCore
Reviewed by Ken.
Tweaked option-tab handling to match good suggestion from Tim Omernick of OmniWeb
- kwq/KWQTextArea.mm: removed override of textDidChange: (-[KWQTextAreaTextView keyDown:]): moved option-tab handling that was in textDidChange to here. Rearranged existing code a little for clarity.
- 3:03 PM Changeset in webkit [7392] by
-
- 2 adds in trunk/LayoutTests/fast/frames
Adding layout test for contentWindow for iframe
- 2:52 PM Changeset in webkit [7391] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin.
Fix for:
<rdar://problem/3689949> Provide contentWindow access on an iframe
- khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): added cases for contentWindow for frames and iframes
- khtml/ecma/kjs_html.h: added contentWindow to the list of properties for frames and iframes
- khtml/ecma/kjs_html.lut.h: regenerated file
- khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::contentPart): factored out old contentDocument code to return KHTMLPart for frame (HTMLFrameElementImpl::contentDocument): now just gets the contentDocument from contentPart
- khtml/html/html_baseimpl.h: added declaration for contentPart
- 12:07 PM Changeset in webkit [7390] by
-
- 2 edits in trunk/WebKit
Reviewed by Chris
Fix for this bug:
<rdar://problem/3756997> WebKit aggressive in making pasted text into a URL, even when it's not much like a URL
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): Don't try so hard to coerce data on the pasteboard into a URL, and do not make an anchor with an href for any URLs that are explicitly present on the pasteboard. Also, move URL pasteboard type check beneath the RTF checks.
- 11:59 AM Changeset in webkit [7389] by
-
- 3 edits in trunk
back to 2.0, v162u for tip of tree
- 11:49 AM Changeset in webkit [7388]
-
- 3 copies in tags/Safari-161
This commit was manufactured by cvs2svn to create tag 'Safari-161'.
- 11:49 AM Changeset in webkit [7387] by
-
- 6 edits in trunk
Safari-161 stamp
- 10:26 AM Changeset in webkit [7386] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin
Fix for this bug:
<rdar://problem/3778059> Odd behaviour when editing between blockquote elements
- khtml/editing/htmlediting_impl.cpp: (khtml::CompositeEditCommandImpl::deleteUnrenderedText): This function should not move the selection out of the current block, ever. This is exactly what the bug reported. What was I thinking? Now, the code looks at the passed-in position and then the equivalent upstream and downstream positions to see if the selection can be placed there after the delete, and settles on the block containing the passed-in position as a fallback.
- layout-tests/editing/inserting/insert-3778059-fix-expected.txt: Added.
- layout-tests/editing/inserting/insert-3778059-fix.html: Added.
Aug 26, 2004:
- 6:40 PM Changeset in webkit [7385] by
-
- 4 edits in trunk/WebCore
Boiler plate for canvas gradients and patterns.
Reviewed by John.
- khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): (Context2D::tryPut): (Context2D::~Context2D): (KJS::GradientFunction::tryCall): (Gradient::Gradient): (Gradient::tryGet): (Gradient::getValueProperty): (Gradient::tryPut): (Gradient::putValue): (Gradient::~Gradient): (ImagePattern::ImagePattern): (ImagePattern::tryGet): (ImagePattern::getValueProperty): (ImagePattern::tryPut): (ImagePattern::putValue): (ImagePattern::~ImagePattern):
- khtml/ecma/kjs_html.h: (KJS::Gradient::toBoolean): (KJS::Gradient::classInfo): (KJS::Gradient::): (KJS::ImagePattern::toBoolean): (KJS::ImagePattern::classInfo): (KJS::ImagePattern::):
- khtml/ecma/kjs_html.lut.h: (KJS::):
- 6:02 PM Changeset in webkit [7384] by
-
- 2 edits in trunk/WebKit
Fixed build failure on Panther.
Reviewed by john.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): ifdef'd out call to AppKit SPI (-[WebHTMLView _attributeStringFromDOMRange:]): ditto
- 5:38 PM Changeset in webkit [7383] by
-
- 2 edits in trunk/WebKit
Tweak to last check-in.
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]):
- 5:10 PM Changeset in webkit [7382] by
-
- 4 edits in trunk/WebKit
Fixed:
<rdar://problem/3546412> support for pasting and drag and dropping of RTF and RTFD to editable WebViews
<rdar://problem/3745345> use AppKit for converting from DOM to RTF
Reviewed by rjw.
- DOM.subproj/WebDOMOperations.m: (-[DOMDocument _documentRange]): new
- DOM.subproj/WebDOMOperationsPrivate.h:
- WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): call AppKit SPI to get a document fragment from an attributed string (-[WebHTMLView string]): added a FIXME (-[WebHTMLView _attributeStringFromDOMRange:]): new, calls AppKit SPI that creates an attributed string from a DOM Range (-[WebHTMLView attributedString]): call _attributeStringFromDOMRange:, fallback to old code if it returns nil (-[WebHTMLView selectedAttributedString]): ditto
- 4:54 PM Changeset in webkit [7381] by
-
- 2 edits in trunk/WebCore
Reviewed by John
Fix for this bug:
<rdar://problem/3777899> REGRESSION (Mail): only first of several misspelled words separated by
carriage returns is marked
- khtml/editing/htmlediting_impl.cpp: (khtml::TypingCommandImpl::markMisspellingsAfterTyping): Give the spellchecker a slightly larger selection to work with while typing. This should preclude bugs of this type.
- 3:43 PM Changeset in webkit [7380] by
-
- 2 edits in trunk/WebCore
Reviewed by Chris
Fix for this bug:
<rdar://problem/3777804> Deleting all content in a document can result in giant tall-as-window insertion point
- khtml/rendering/render_box.cpp: (RenderBox::caretPos): Always use the font height for calculating the caret height in non-replaced elements (like blocks), rather than the height of the box.
- 3:20 PM Changeset in webkit [7379] by
-
- 1 edit1 add in trunk
Reviewed by me
Silly me. Forgot to add this file before.
- layout-tests/editing/inserting/insert-3775316-fix-expected.txt: Added.
- 3:19 PM Changeset in webkit [7378] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3774178> Plugin hooks for selected state aren't being called
Reviewed by darin.
- WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setIsSelected:forView:]): don't forget colons in method names
- 2:59 PM Changeset in webkit [7377] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3768439> can't click in WebView in Carbon WebKit apps (GetEventPlatformEventRecord returns false)
Reviewed by rjw.
- Carbon.subproj/HIWebView.m: (Click): use WebGetEventPlatformEventRecord not GetEventPlatformEventRecord (MouseUp): ditto (MouseMoved): ditto (MouseDragged): ditto (MouseWheelMoved): ditto (WindowHandler): ditto (HIWebViewEventHandler): ditto (UpdateObserver): ditto (WebGetEventPlatformEventRecord): Call GetEventPlatformEventRecord, if that fails fallback to the current event. This is code Eric Schlegel to me to use.
- 2:36 PM Changeset in webkit [7376] by
-
- 2 edits in trunk/WebCore
Fix for 3777172, crash from nested colgroup. Don't allow nested table sections or col groups.
Reviewed by darin
- khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
- 2:34 PM Changeset in webkit [7375] by
-
- 2 edits1 add in trunk
Reviewed by Hyatt
Fix for this bug:
<rdar://problem/3775316> document sprouts an extra newline character at the end
- khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): There was in insufficient check in the code which adds extra BR elements at the ends of blocks, which we do to work around the fact that BR elements, when they are the last element in a block, do not render. Now the code sees whether there already is one of these extra BR's in the document and won't add and "extra" extra.
- layout-tests/editing/inserting/insert-3775316-fix.html: Added.
- 10:37 AM Changeset in webkit [7374] by
-
- 4 edits in trunk/WebCore
Fix for 3710721 and 3504114, crashes because of bad ownership model for list markers.
Reviewed by mjs
- khtml/rendering/render_container.cpp: (RenderContainer::detach):
- khtml/rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListItem::detach): (RenderListItem::updateMarkerLocation):
- khtml/rendering/render_list.h:
- 9:46 AM Changeset in webkit [7373] by
-
- 4 edits in trunk/WebCore
Reviewed by John
- khtml/editing/htmlediting_impl.cpp: (khtml::ApplyStyleCommandImpl::doApply): Remove the StayInBlock modifier from the call to upstream when passing the start position to removeStyle(). This makes the start position sufficiently upstream so that all relevant style tags are removed. (khtml::ApplyStyleCommandImpl::removeStyle): Pass the start position to nodeFullySelected. (khtml::ApplyStyleCommandImpl::nodeFullySelected): Change interface so start position for calculation is passed in, rather than recalculating it every time.
- khtml/editing/htmlediting_impl.h: nodeFullySelected interface change.
- khtml/xml/dom_position.h: Add a comment about the working of upstream() and downstream().
- 9:17 AM Changeset in webkit [7372] by
-
- 2 edits in trunk
Reviewed by me
Fix garbled contenteditable attribute. I must have checked
this in with a typo.
- layout-tests/editing/deleting/delete-3775172-fix.html
