Timeline
Oct 1, 2004:
- 10:25 AM Changeset in webkit [7746] by
-
- 3 edits in trunk/WebCore
Reviewed by Ken (or arguably done by Ken, reviewed by Darin).
- fixed <rdar://problem/3823828> REGRESSION (Mail): Clicking past end of any line puts insertion point at beginning of next line
- khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): Check for an offset of 0 and a <br> and use UPSTREAM affinity in that case. This is a short term fix for something that needs a better longer-term fix.
- fixed <rdar://problem/3823816> REGRESSION (Mail): double-clicking first word on line also selects previous empty line
- khtml/editing/visible_units.cpp: (khtml::previousWordBoundary): Added a special case for <br>. While I'm not sure why this regressed, I'm sure this fix is good.
- 8:18 AM Changeset in webkit [7745] by
-
- 2 edits in trunk/WebCore
Reviewed by John.
- fixed <rdar://problem/3782117> CrashTracer: ..722 crashes at com.apple.WebCore: DOM::HTMLBodyElementImpl::insertedIntoDocument + 0x2c (AOL website)
- khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::insertedIntoDocument): Check for nil document case. (HTMLFrameElementImpl::isURLAllowed): Ditto. (HTMLFrameElementImpl::openURL): Ditto.
- 1:02 AM Changeset in webkit [7744] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
- fixed <rdar://problem/3822218> REGRESSION (164-165): images don't update on rollover on directv.com page
I introduced a major regression where various JavaScript window properties would not be found when I
fixed bug 3809600.
- khtml/ecma/kjs_window.h: Added hasProperty.
- khtml/ecma/kjs_window.cpp: (Window::hasProperty): Return true in all the cases where get returns something.
Sep 30, 2004:
- 11:43 PM Changeset in webkit [7743] by
-
- 5 edits in trunk/WebCore
Reviewed by Maciej.
- fixed <rdar://problem/3461499> JavaScript function document.open() is buggy with 2nd argument "replace"
Experiments with Firefox indicate that document.open() should not be treated as window.open() unless there
are more than two parameters. Also, Firefox does not implement the "replace" behavior, so we don't have
to worry about it either.
- khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): Only forward to window if there are more than two parameters, rather than if there are more than one.
- fixed <rdar://problem/3672933> oninput is firing at page load time for <input type=range>
- kwq/KWQSlider.mm: (QSlider::setValue): Don't emit a signal here. This follows the usual pattern, where a signal is only emitted for changes that are not explicitly requested by the caller.
- fixed <rdar://problem/3821167> leaks of something allocated by recalcStyle after loading altavista page from cvs-base
- khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Ref and deref the style we allocate so it's not left floating if setStyle decides not to ref it.
- fixed <rdar://problem/3821172> leak of HTML attribute string after loading the ESPN page from cvs-base
- khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): Use the DOMString version of the lower() operation so we don't end up leaving a DOMStringImpl * floating if AtomicString decides not to ref it.
- 5:24 PM Changeset in webkit [7742] by
-
- 15 edits in trunk
WebKit:
Fixed <rdar://problem/3821215> NPN hasMethod and hasProperty functions should take NPObjects, not NPClass
Also changed dashboard regions dictionary to use "control"
for scroller region label, instead of "scroller, per
request from ouch.
Reviewed by Chris.
- Plugins.subproj/npruntime.h:
- WebView.subproj/WebView.m: (-[WebView _addScrollerDashboardRegions:from:]):
Fixed <rdar://problem/3821215> NPN hasMethod and hasProperty functions should take NPObjects, not NPClass
Reviewed by Chris.
- bindings/NP_jsobject.cpp: (_NPN_GetProperty): (_NPN_HasProperty): (_NPN_HasMethod):
- bindings/c/c_class.cpp: (CClass::methodsNamed): (CClass::fieldNamed):
- bindings/c/c_class.h:
- bindings/c/c_instance.cpp: (CInstance::invokeMethod):
- bindings/jni/jni_class.cpp: (JavaClass::methodsNamed):
- bindings/jni/jni_class.h:
- bindings/npruntime.h:
- bindings/objc/objc_class.h:
- bindings/objc/objc_class.mm: (ObjcClass::methodsNamed):
- bindings/runtime.h:
- bindings/runtime_object.cpp: (RuntimeObjectImp::get): (RuntimeObjectImp::hasProperty):
- 5:18 PM Changeset in webkit [7741] by
-
- 2 edits in trunk/WebKit
Fixed: <rdar://problem/3498680> switching back and forth between tabs stops calling anything in a plug-in
Reviewed by darin.
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): call setWindowIfNecessary because the window may have changed (-[WebBaseNetscapePluginView updateAndSetWindow]): new (-[WebBaseNetscapePluginView setWindowIfNecessary]): was setWindow, this method now just sets the window (-[WebBaseNetscapePluginView start]): call updateAndSetWindow (-[WebBaseNetscapePluginView viewDidMoveToWindow]): ditto (-[WebBaseNetscapePluginView viewHasMoved:]): ditto
- 4:14 PM Changeset in webkit [7740] by
-
- 3 edits in trunk/WebKit
Fixed: <rdar://problem/3498668> switching out of tab doesn't send loseFocusEvent to plug-in
Reviewed by rjw.
- Plugins.subproj/WebBaseNetscapePluginView.h:
- Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setHasFocus:]): new, sends events to plug-in (-[WebBaseNetscapePluginView becomeFirstResponder]): call setHasFocus (-[WebBaseNetscapePluginView resignFirstResponder]): ditto (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): ditto
- 1:04 PM Changeset in webkit [7739] by
-
- 2 edits in trunk/WebCore
Fixed <rdar://problem/3822330> REGRESSION: crash on launch when homepage is set to about:blank
Added nil check.
- kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setDisplaysWithFocusAttributes):
- 12:48 PM Changeset in webkit [7738] by
-
- 2 edits in trunk/WebCore
Fixed: <rdar://problem/3792822> Safari is calling the Cocoa QuickTime plugin twice for the OBJECT and EMBED tags
Reviewed by hyatt.
- khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): call dispatchHTMLEvent after updateWidget instead of every time this method is called (HTMLObjectElementImpl::recalcStyle): ditto
- 11:56 AM Changeset in webkit [7737] by
-
- 2 edits in trunk/WebCore
- rolled out bad image change that caused performance regression
- khtml/rendering/render_image.cpp: (RenderImage::setPixmap): Don't reference the new image before doing the assignment. This forced an unwanted.
- 10:52 AM Changeset in webkit [7736] by
-
- 6 edits in trunk/WebKit
Fixed:
Assertion failure when loading standalone netscape plug-in content.
Document loads of WebKit plug-in content should be cancelled since the plug-in does its own loading.
Reviewed by john.
- Misc.subproj/WebKitErrors.m: removed deprecated method
- Misc.subproj/WebKitErrorsPrivate.h:
- Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView setDataSource:]): fixed the assertion statement
- Plugins.subproj/WebPluginDocumentView.h:
- Plugins.subproj/WebPluginDocumentView.m: (-[WebPluginDocumentView dealloc]): remove retained plug-in (-[WebPluginDocumentView setDataSource:]): retain the plug-in, cancel the laod
- 9:59 AM Changeset in webkit [7735] by
-
- 3 edits in trunk/WebCore
Reviewed by me, coded by Darin
- fixed <rdar://problem/3818305> REGRESSION (Mail): Shift + page up has no effect; should modify selection
- khtml/editing/selection.cpp: (khtml::Selection::modify): Fix problem where vertical distance was used as a distance threshold, but was a negative number. Now make it positive at the start of the function (and make a couple related changes).
