Timeline

Oct 15, 2004:

4:17 PM Changeset in webkit [7847] by cblu

• 3 edits in trunk/WebCore

Fixed: <rdar://problem/3841774> would like to get NSColor from DOM-CSS

Reviewed by john.

• kwq/DOM-CSS.mm: (-[DOMRGBColor _color]): new, returns getNSColor on KWQColor
• kwq/DOMPrivate.h:

2:07 PM Changeset in webkit [7846] by kocienda

• 2 edits
  4 adds in trunk

Reviewed by Hyatt

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::skipNonBreakingSpace): Also need to forego the skipping after a clean line break, in addition to the cases already checked for.
• layout-tests/editing/inserting/insert-br-007-expected.txt: Added.
• layout-tests/editing/inserting/insert-br-007.html: Added.
• layout-tests/editing/inserting/insert-br-008-expected.txt: Added.
• layout-tests/editing/inserting/insert-br-008.html: Added.

11:22 AM Changeset in webkit [7845] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (168u)

11:12 AM Changeset in webkit [7844]

• 2 copies in tags/Safari-167

This commit was manufactured by cvs2svn to create tag 'Safari-167'.

11:12 AM Changeset in webkit [7843] by vicki

• 6 edits in trunk

Safari-167 stamp

Oct 14, 2004:

5:01 PM Changeset in webkit [7842] by kocienda

• 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3839989> REGRESSION (Mail): Left arrow does nothing after inserting attachment

• khtml/editing/visible_position.cpp: (khtml::VisiblePosition::deepEquivalent): Remove code that attempted to bridge old-style position code to new-style VisiblePosition code. In retrospect, this code was misguided. Since we do a good job of insulating external code from the internal workings of VisiblePosition, the "hop ahead" being done here was not doing anyone any real good, and in the case of this bug, was doing harm. Simply removing this code makes the bug go away and does not cause any editing layout test regresssions.

4:51 PM Changeset in webkit [7841] by kocienda

• 3 edits
  2 adds in trunk

Reviewed by Hyatt

• khtml/rendering/bidi.cpp: (khtml::skipNonBreakingSpace): New helper. (khtml::RenderBlock::skipWhitespace): Do not skip non-breaking spaces that are at the start of a block. This was preventing users from typing spaces in empty documents.
• layout-tests/editing/inserting/insert-space-in-empty-doc-expected.txt: Added.
• layout-tests/editing/inserting/insert-space-in-empty-doc.html: Added.

2:52 PM Changeset in webkit [7840] by adele

• 2 edits in trunk/WebCore

Reviewed by Darin and Ken.

fix for <rdar://problem/3821070> null de-ref in DelectSelectionCommand::doApply()

This change shifts some code around so that the code that determines what typing style
is in effect is called before deleteUnrenderedText is called. Two asserts are also added
to ensure that start and end nodes of the selection are in the document.

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::doApply):

2:35 PM Changeset in webkit [7839] by adele

• 4 edits in trunk/WebCore

Reviewed by Ken

This change makes these three functions virtual so that the work is being done in KWQHTMLPart
instead of khtml_part, eliminating the need for the "#if APPLE_CHANGES" statements in the khtml code.

• khtml/khtml_part.cpp: (KHTMLPart::shouldBeginEditing): (KHTMLPart::shouldEndEditing): (KHTMLPart::isContentEditable):
• khtml/khtml_part.h:
• kwq/KWQKHTMLPart.h:

1:38 PM Changeset in webkit [7838] by kocienda

• 10 edits in trunk

WebCore:

Reviewed by John

Final fix for these bugs:

<rdar://problem/3806306> HTML editing puts spaces at start of line
<rdar://problem/3814252> HTML editing groups space with word causing wrapping

This change sets some new CSS properties that have been added to WebCore to
enable whitespace-handling and line-breaking features that make WebView work
more like a text editor.

• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Add and remove special editing CSS properties based on property value.
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setContentEditable): Add and remove special editing CSS properties based on attribute value.
• khtml/khtml_part.cpp: (KHTMLPart::applyEditingStyleToBodyElement): New helper. Calls applyEditingStyleToElement on body element. (KHTMLPart::removeEditingStyleFromBodyElement): New helper. Calls removeEditingStyleFromElement on body element. (KHTMLPart::applyEditingStyleToElement): Adds special editing CSS properties to passed in element. (KHTMLPart::removeEditingStyleFromElement): Removes special editing CSS properties from passed in element.
• khtml/khtml_part.h: Add new declarations.
• kwq/WebCoreBridge.h: Ditto.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge applyEditingStyleToBodyElement]): Call through to similarly-named function on KHTMLPart. (-[WebCoreBridge removeEditingStyleFromBodyElement]): Ditto. (-[WebCoreBridge applyEditingStyleToElement:]): Ditto. (-[WebCoreBridge removeEditingStyleFromElement:]): Ditto.

WebKit:

Reviewed by John

Final fix for these bugs:

<rdar://problem/3806306> HTML editing puts spaces at start of line
<rdar://problem/3814252> HTML editing groups space with word causing wrapping

This change sets some new CSS properties that have been added to WebCore to
enable whitespace-handling and line-breaking features that make WebView work
more like a text editor.

• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Turn on special editing CSS properties when loading an HTML document into a WebView that is editable.
• WebView.subproj/WebView.m: (-[WebView setEditable:]): Add and remove special editing CSS properties in current document being displayed.

12:51 PM Changeset in webkit [7837] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Ken.

• fixed <rdar://problem/3840052> Crash in removeBlockPlaceholderIfNeeded attaching file to empty document

• khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::removeBlockPlaceholderIfNeeded): needed a nil check to handle empty document case

10:14 AM Changeset in webkit [7836] by rjw

• 2 edits in trunk/WebKit

Fixed <rdar://problem/3823026> making isRoundingHackCharacter use -O3 and an 8-bit lookup-table will speed "XBS" test up by 3% (actually < 1%)

Careful testing shows a small performance gain on very large text files.
I saw large variations in timings, but taking the lowest PLT timing
with and without this change showed a 0.9% gain. Note the cvs-base showed
no improvement. The improvement was for the large page attached to the
bug.

Reviewed by Ken.

• WebCoreSupport.subproj/WebTextRenderer.m: (setupRoundingHackCharacterTable): (isRoundingHackCharacter): (+[WebTextRenderer initialize]):

7:31 AM Changeset in webkit [7835] by kocienda

• 2 edits in trunk/WebKit

Reviewed by me

Fix build breakage. These three functions need to return the values from their
calls to WebCGColorSpaceCreateXXX.

• WebCoreSupport.subproj/WebGraphicsBridge.m: (-[WebGraphicsBridge createRGBColorSpace]) (-[WebGraphicsBridge createGrayColorSpace]) (-[WebGraphicsBridge createCMYKColorSpace])