Timeline

Oct 18, 2004:

5:23 PM Changeset in webkit [7854] by darin

• 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

• fixed <rdar://problem/3807234> REGRESSION (152-153): can't get element by ID that was just written with document.write in separate JS file (lacoccinelle.net)

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): Use !isEmpty instead of count != 0, since it's cheaper. (khtml::HTMLTokenizer::write): Roll back to the old version of the check here. The fix is that we only want to look at loadingExtScript if m_executingScript is 0.

4:33 PM Changeset in webkit [7853] by adele

• 2 edits in branches/Safari-1-2-branch/WebKit

Reviewed by Dave.

This backs out the fix for <rdar://problem/3803113> WebFrame object leaked.

Back out rjw's fix for the frame leak, since it caused the onload handler to fire before
CSS and images had loaded.

• WebView.subproj/WebDataSource.m: (-[WebDataSource _finishedLoading]):

2:52 PM Changeset in webkit [7852] by kocienda

• 4 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3840907> textedit doesn't render italic or bold text in html documents

• khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::getStringValue): This function did not return string values for idents. Also changed the return value to be DOMString, rather than DOMStringImpl, to deal with the lifecycle issues associated with creating a string to be returned in the ident case.
• khtml/css/css_valueimpl.h: Change getStringValue to return DOMString rather than DOMStringImpl.
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Two calls of getStringValue needed updating.

10:56 AM Changeset in webkit [7851] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/3770135> hang loading page with EMBED tag pointing to same page (tridentantennas.co.uk)

Reviewed by kocienda.

• khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): use completeURL before comparing the URL of the plug-in with the base URL of the document when avoiding frame recursion

10:36 AM Changeset in webkit [7850] by cblu

• 2 edits in trunk/WebKit

Fixed: <rdar://problem/3840916> GC: -[WebNetscapePluginPackage initWithPath:] leaks an NSURL

Reviewed by kevin.

• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]): use executablePath on NSBundle instead of CFBundleCopyExecutableURL

10:30 AM Changeset in webkit [7849] by cblu

• 2 edits in trunk/WebKit

• DOM.subproj/DOMPrivate.h: change to copied header that was never committed

9:55 AM Changeset in webkit [7848] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Ken.

• fixed <rdar://problem/3810183> Make WebHTMLView respect return value of webView:doCommandBySelector:

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView doCommandBySelector:]): only do default action if delegate returns NO; this works with Mail as of Tiger 8A275.

Oct 15, 2004:

4:17 PM Changeset in webkit [7847] by cblu

• 3 edits in trunk/WebCore

Fixed: <rdar://problem/3841774> would like to get NSColor from DOM-CSS

Reviewed by john.

• kwq/DOM-CSS.mm: (-[DOMRGBColor _color]): new, returns getNSColor on KWQColor
• kwq/DOMPrivate.h:

2:07 PM Changeset in webkit [7846] by kocienda

• 2 edits
  4 adds in trunk

Reviewed by Hyatt

• khtml/rendering/bidi.cpp: (khtml::RenderBlock::skipNonBreakingSpace): Also need to forego the skipping after a clean line break, in addition to the cases already checked for.
• layout-tests/editing/inserting/insert-br-007-expected.txt: Added.
• layout-tests/editing/inserting/insert-br-007.html: Added.
• layout-tests/editing/inserting/insert-br-008-expected.txt: Added.
• layout-tests/editing/inserting/insert-br-008.html: Added.

11:22 AM Changeset in webkit [7845] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (168u)

11:12 AM Changeset in webkit [7844]

• 2 copies in tags/Safari-167

This commit was manufactured by cvs2svn to create tag 'Safari-167'.

11:12 AM Changeset in webkit [7843] by vicki

• 6 edits in trunk

Safari-167 stamp