⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 22, 2004:

5:19 PM Changeset in webkit [7885] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3851491> installedPlugins being called for a page without plugins

Reviewed by mjs.

  • WebView.subproj/WebFrameView.m: (+[WebFrameView _canShowMIMETypeAsHTML:]): call _viewTypesAllowImageTypeOmission instead of using ivar since the ivar is nil until _viewTypesAllowImageTypeOmission is called, this was causing [WebView canShowMIMEType:] to check plug-ins
3:26 PM Changeset in webkit [7884] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3844662> REGRESSION (Mail): Style changes can affect adjacent, unselected text

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::doApply): Move end position downstream to be sure we remove style from everything that could be affected. (khtml::ApplyStyleCommand::removeCSSStyle): Comma in intended function call was outside the braces, making it act as a comma operator, with a zero value as the right value!!! This made an important check always fail!!! It turns out that we do not want the constant at all, since that constant is only needed when checking a computed style, not an inline style as is being done here. (khtml::ApplyStyleCommand::removeStyle): Call nodeFullySelected with new interface. (khtml::ApplyStyleCommand::nodeFullySelected): Change interface and implementation to rely on RangeImpl::compareBoundaryPoints to perform the required check.
  • khtml/editing/htmlediting.h: Changed nodeFullySelected function interface.
1:07 PM Changeset in webkit [7883] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bugs:

<rdar://problem/3848343> REGRESSION (Mail, 166-168u): Typed text after space at end of line before block quote does not appear
<rdar://problem/3848224> REGRESSION (Mail): space typed at end of line vanishes after typing next character

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): When the khtmlLineBreak is in AFTER_WHITE_SPACE mode, as it is when we are editing, add in the space of the current character when calculating the width of committed plus uncommitted characters. If this value exceeds the width of the line, move up the line break object and call skipWhitespace to move past the end of the whitespace.
12:14 PM Changeset in webkit [7882] by vicki
  • 3 edits in trunk

versioning for TOT. the tree is open!

12:04 PM Changeset in webkit [7881]
  • 2 copies in tags/Safari-168

This commit was manufactured by cvs2svn to create tag 'Safari-168'.

12:04 PM Changeset in webkit [7880] by vicki
  • 6 edits in trunk

Safari-168 stamp

9:20 AM Changeset in webkit [7879] by kocienda
  • 6 edits in trunk

JavaScriptCore:

Reviewed by me

  • JavaScriptCore.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.

WebCore:

Reviewed by me

  • WebCore.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.

WebKit:

Reviewed by me

  • WebKit.pbproj/project.pbxproj: Add GCC_ENABLE_OBJC_GC and GCC_FAST_OBJC_DISPATCH flags.

Oct 21, 2004:

6:08 PM Changeset in webkit [7878] by hyatt
  • 2 edits
    2 adds in trunk

Reviewed by darin

Clean up the inline run function so that it doesn't return incorrect answers when making children non-inline.

<rdar://problem/3848724> REGRESSION (166-168u): RenderText::layout called, firing assertion that kills Mail
<rdar://problem/3848357> RenderText::layout called, firing assertion that kills Safari (www.apple.com/downloads/macosx)

  • khtml/rendering/render_block.cpp: (khtml::getInlineRun): (khtml::RenderBlock::makeChildrenNonInline):
5:00 PM Changeset in webkit [7877] by hyatt
  • 2 adds in trunk/LayoutTests/fast/dynamic

Add layout test for dynamic block/inline crash.

4:45 PM Changeset in webkit [7876] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3810389, crash because of continuation() craziness. Revert back to the old behavior of
making sure that all line boxes get deleted and recreated when inlines are split because of a block.

Reviewed darin

  • khtml/rendering/render_inline.cpp: (RenderInline::splitFlow):
2:19 PM Changeset in webkit [7875] by kocienda
  • 27 edits in trunk

Reviewed by Darin

Significant improvement to the way that whitespace is handled during editing.

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantText): New functions (there are actually two being added with this name) that delete "insignificant" unrendered text. (khtml::CompositeEditCommand::deleteInsignificantTextDownstream): Takes a position, calculates the downstream position to use as the endpoint for the deletion, and then calls deleteInsignificantText with this start and end. (khtml::DeleteSelectionCommand::doApply): Call new deleteInsignificantTextDownstream function. (khtml::InputNewlineCommand::doApply): Ditto. (khtml::InputTextCommand::input): Ditto.
  • khtml/editing/htmlediting.h: Add new declarations.

Modified layout test results:

  • layout-tests/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • layout-tests/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • layout-tests/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • layout-tests/editing/deleting/delete-selection-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-004-expected.txt:
  • layout-tests/editing/deleting/delete-trailing-ws-001-expected.txt:
  • layout-tests/editing/inserting/insert-3659587-fix-expected.txt:
  • layout-tests/editing/inserting/insert-3775316-fix-expected.txt:
  • layout-tests/editing/inserting/insert-3778059-fix-expected.txt:
  • layout-tests/editing/inserting/insert-br-001-expected.txt:
  • layout-tests/editing/inserting/insert-br-004-expected.txt:
  • layout-tests/editing/inserting/insert-br-005-expected.txt:
  • layout-tests/editing/inserting/insert-br-006-expected.txt:
  • layout-tests/editing/inserting/insert-tab-001-expected.txt:
  • layout-tests/editing/inserting/insert-tab-002-expected.txt:
  • layout-tests/editing/inserting/insert-tab-004-expected.txt:
  • layout-tests/editing/inserting/insert-text-with-newlines-expected.txt:
  • layout-tests/editing/inserting/typing-001-expected.txt:
  • layout-tests/editing/inserting/typing-around-br-001-expected.txt:
  • layout-tests/editing/inserting/typing-around-image-001-expected.txt:
  • layout-tests/editing/style/typing-style-003-expected.txt:
  • layout-tests/editing/undo/redo-typing-001-expected.txt:
  • layout-tests/editing/undo/undo-typing-001-expected.txt:
2:12 PM Changeset in webkit [7874] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3847054, assertion failure in RenderText::layout() on news.com page. Fix getInlineRun so that
it no longer breaks early (thus causing some children not to get properly wrapped by anonymous blocks).

Reviewed by darin

  • khtml/rendering/render_block.cpp: (khtml::getInlineRun):
10:04 AM Changeset in webkit [7873] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/3847994> REGRESSION: reproducible exception in WebImageRenderer releasePatternColor; afterwards get crash or no more browsing
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebInternalImage createRendererIfNeeded]): Replaced retainOrCopyIfNeeded with this. This returns nil if a copied renderer isn't needed, and returns a new renderer if a copy is. The old version was sometimes returning a WebInternalImage and other times a WebImageRenderer. (-[WebImageRenderer retainOrCopyIfNeeded]): Returns the result of createRendererIfNeeded or retains self and returns self.
Note: See TracTimeline for information about the timeline view.