Timeline

Oct 29, 2004:

4:51 PM Changeset in webkit [7920] by vicki

• 3 edits in trunk

versioning for TOT, Safari 2.0 (170u)

4:42 PM Changeset in webkit [7919]

• 2 copies in tags/Safari-169

This commit was manufactured by cvs2svn to create tag 'Safari-169'.

4:42 PM Changeset in webkit [7918] by vicki

• 6 edits in trunk

Safari-169 stamp

2:53 PM Changeset in webkit [7917] by darin

• 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

• fixed <rdar://problem/3751619> Safari crash in khtml::CircularSearchBuffer::append(QChar const&)

• khtml/editing/visible_text.cpp: (khtml::findPlainText): Fix exit condition to check for break before advancing one character; before it did it backwards.

2:48 PM Changeset in webkit [7916] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/3853262> REGRESSION(166-168) gmail gets blank page when loading

Reviewed by kocienda, adele.

• khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): remove infinite frame recursion check for iframes

1:16 PM Changeset in webkit [7915] by cblu

• 2 edits in trunk/WebKit

• WebKit.exp: added _WebPlugInModeKey, forgot to add it earlier

11:59 AM Changeset in webkit [7914] by darin

• 3 edits in trunk/WebCore

Reviewed by Chris.

• fixed <rdar://problem/3857395> clicking on calendar in Apple Travel site crashes Safari in invalidateClick (getthere.net)

• khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): Use a SharedPtr<KHTMLView> to make sure the KHTMLView is not deleted before this function finishes running. (KHTMLView::viewportMouseDoubleClickEvent): Ditto. (KHTMLView::viewportMouseReleaseEvent): Ditto. (KHTMLView::dispatchMouseEvent): Removed ref/deref pairs that aren't needed since dispatchEvent is guaranteed to do ref/deref as needed.

• kwq/KWQObject.mm: (QObject::startTimer): Fixed a comment.

11:11 AM Changeset in webkit [7913] by darin

• 2 edits in trunk/WebKit

• fixed <rdar://problem/3855573> Remove reference to "WebScriptMethods" from WebScriptObject.h comments

• Plugins.subproj/WebScriptObject.h: Removed unneeded #ifdef protection for multiple includes (since this is an Objective-C header and we use #import for those). Fixed comments as requested in the bug report to match the contents of the file.

Oct 28, 2004:

4:14 PM Changeset in webkit [7912] by cblu

• 3 edits in trunk/WebCore

Enabled XSLT on Panther. See intrigue mail for compiling instructions.

Reviewed by darin.

• WebCore.pbproj/project.pbxproj: link against xslt unconditionally, link against specific version of libxml on Panther
• WebCorePrefix.h: always use XSLT

3:35 PM Changeset in webkit [7911] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Chris

Fix for these bugs:

<rdar://problem/3854848> Tiger Mail Crash in WebCore - khtml::CompositeEditCommand::insertNodeAfter
<rdar://problem/3803832> REGRESSION (Mail): incorrect behavior after Return + Delete in quoted text

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Added node pointer class members to initialization list, zeroing them out. (khtml::DeleteSelectionCommand::canPerformSpecialCaseBRDelete): New special-case helper to handle a delete of content in special cases where the only thing selected is a BR. This code path is much simpler than the newly-named performGeneralDelete, and detects when no content merging should be done between blocks. This aspect of the change fixes 3854848. One of the special cases added fixes 3803832. (khtml::DeleteSelectionCommand::performGeneralDelete): Renamed, from performDelete. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Made this helper be a no-arg function, just like the other helpers in this class. (khtml::DeleteSelectionCommand::clearTransientState): Fix cut and paste error in deref code. (khtml::DeleteSelectionCommand::doApply): Updated for changed helpers.
• khtml/editing/htmlediting.h: Added new helper and changed an old one.

3:05 PM Changeset in webkit [7910] by cblu

• 2 edits in trunk/WebCore

Fixed: <rdar://problem/3856913> Panther-only crash in QString code copying front page of store.apple.com

Reviewed by darin.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): check that the renderer is a list item before making list item calls on it

1:07 PM Changeset in webkit [7909] by kocienda

• 3 edits in trunk/WebCore

Reviewed by Harrison

Reorganization of delete command functionality so that doApply is not
several hundred lines long. This is not a squeaky-clean cleanup, but
it is a step in the right direction. No functionality changes.

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): (khtml::DeleteSelectionCommand::initializePositionData): New helper. (khtml::DeleteSelectionCommand::saveTypingStyleState): Ditto. (khtml::DeleteSelectionCommand::performDelete): Ditto. (khtml::DeleteSelectionCommand::fixupWhitespace): Ditto. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Ditto. (khtml::DeleteSelectionCommand::calculateEndingPosition): Ditto. (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto. (khtml::DeleteSelectionCommand::clearTransientState): Ditto. (khtml::DeleteSelectionCommand::doApply): Factor out code into new helpers.
• khtml/editing/htmlediting.h:

9:38 AM Changeset in webkit [7908] by kocienda

• 2 edits in trunk/WebCore

Reviewed by me

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::DeleteSelectionCommand): Typo in initializer caused new mergeBlocksAfterDelete flag to be set improperly, causing layout regressions.