Context Navigation

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): My one-liner for this bug introduced layout test regressions: <rdar://problem/3926142> REGRESSION (Mail): Deleting text decreases quote level Rolling out until I can develop a real fix.

3:54 PM Changeset in webkit [8260] by harrison

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by Dave Hyatt.

Initial checkin of AXTextMarkerRef support.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): (DocumentImpl::setFocusNode):
kwq/KWQAccObject.h:
kwq/KWQAccObject.mm: (-[KWQAccObject detach]): (-[KWQAccObject anchorElement]): (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityActionDescription:]): (-[KWQAccObject accessibilityPerformAction:]): (-[KWQAccObject textMarkerRangeFromMarkers:andEndMarker:]): (-[KWQAccObject textMarkerForVisiblePosition:]): (-[KWQAccObject visiblePositionForTextMarker:]): (-[KWQAccObject AXTextMarkerRangeCopyStartMarkerWrapper:]): (-[KWQAccObject AXTextMarkerRangeCopyEndMarkerWrapper:]): (-[KWQAccObject visiblePositionForStartOfTextMarkerRange:]): (-[KWQAccObject visiblePositionForEndOfTextMarkerRange:]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject textMarkerRangeFromVisiblePositions:andEndPos:]): (-[KWQAccObject getSelectedTextMarkerRange]): (-[KWQAccObject doAXLineForTextMarker:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]): (-[KWQAccObject doAXStringForTextMarkerRange:]): (-[KWQAccObject doAXNextTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousTextMarkerForTextMarker:]): (-[KWQAccObject doAXLeftWordTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightWordTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject accessibilityAttributeValue:forParameter:]): (-[KWQAccObject accessibilityFocusedUIElement]): (-[KWQAccObject clearChildren]): (-[KWQAccObject accObjectID]): (-[KWQAccObject setAccObjectID:]): (-[KWQAccObject removeAccObjectID]):
kwq/KWQAccObjectCache.h:
kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::KWQAccObjectCache): (KWQAccObjectCache::~KWQAccObjectCache): (KWQAccObjectCache::getAccObjectID): (KWQAccObjectCache::removeAccObjectID): (KWQAccObjectCache::textMarkerForVisiblePosition): (KWQAccObjectCache::visiblePositionForTextMarker):

3:51 PM Changeset in webkit [8259] by harrison

5 edits in trunk/WebCore

ChangeLog

3:36 PM Changeset in webkit [8258] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/3884448> WebKit should turn on CG local font cache

Enable mutli-tier font caching. We should see a performance boost with this
change.

Reviewed by Chris.

WebCoreSupport.subproj/WebTextRendererFactory.m: (+[WebTextRendererFactory createSharedFactory]):

2:34 PM Changeset in webkit [8257] by rjw

4 edits in trunk/WebKit

Fix image decoding to separately decode image meta data from actual image bits. I
incorrectly consolidated decode of meta data and image bits resulting in a huge
performance regression.

Double size of WebCore cache on lower end machines. On the PLT run on machines with
256MB of memory, too many images were being evicted, causing a re-decode on the PLT.
Upping the lower limit of the cache size ensure that no images are evicted (this
goes hand-in-hand with the change to the minimum object size from 32K to 40K).

Reviewed by Ken.

WebCoreSupport.subproj/WebImageData.h:
WebCoreSupport.subproj/WebImageData.m: (+[WebImageData initialize]): (-[WebImageData _commonTermination]): (-[WebImageData _invalidateImages]): (-[WebImageData _invalidateImageProperties]): (-[WebImageData imageAtIndex:]): (-[WebImageData propertiesAtIndex:]): (-[WebImageData _cacheImages:allImages:]): (-[WebImageData decodeData:isComplete:callback:]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]):
WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):

12:34 PM Changeset in webkit [8256] by rjw

2 edits in trunk/WebKit

Fixed build problem caused by change to ImageIO API.

Reviewed by Adele.

WebCoreSupport.subproj/WebImageData.m:

Dec 19, 2004:

12:40 PM Changeset in webkit [8255] by darin

5 edits in trunk/WebKit

Reviewed by Kevin.

some garbage collection fixes

Misc.subproj/WebNSObjectExtras.h: (WebCFAutorelease): Replaced the old WebNSRetainCFRelease with this much-easier-to-understand function cribbed from what David Harrison did in WebCore.

Misc.subproj/WebKitNSStringExtras.m: (+[NSString _web_encodingForResource:]): Use CFRelease here to get rid of an unnecessary use of WebNSRetainCFRelease.
Misc.subproj/WebNSURLExtras.m: (+[NSURL _web_URLWithData:relativeToURL:]): Use WebCFAutorelease instead of WebNSRetainCFRelease and autorelease. (-[NSURL _web_URLWithLowercasedScheme]): Ditto. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Use WebCFAutorelease here; the old code would not work correctly under GC.
Plugins.subproj/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage preferredLocalizationName]): Use WebCFAutorelease here; the old code would not work correctly under GC.

12:35 PM Changeset in webkit [8254] by darin

2 edits in trunk/WebCore

kwq/KWQFoundationExtras.h: (KWQCFAutorelease): Added nil check.

12:30 PM Changeset in webkit [8253] by darin

3 edits in trunk/WebCore

Reviewed by Kevin.

a garbage collection fix

kwq/KWQFoundationExtras.h: (KWQCFAutorelease): Added a more-extensive comment and fixed the BUILDING_ON_PANTHER #ifndef to use #if (in practice, either is OK).
kwq/KWQKURL.mm: (KURL::getNSURL): Use KWQCFAutorelease instead of autorelease.

11:09 AM Changeset in webkit [8252] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3766915> PDF content needs search to work

Reviewed by kevin, john.

WebView.subproj/WebPDFView.m: (-[WebPDFView searchFor:direction:caseSensitive:wrap:]): implemented (-[WebPDFView takeFindStringFromSelection:]): new (-[WebPDFView jumpToSelection:]): new (-[WebPDFView validateUserInterfaceItem:]): new

Dec 17, 2004:

7:30 PM Changeset in webkit [8251] by rjw

1 edit in trunk/WebCore/khtml/misc/loader.cpp

Use 40K, not 40MB as min max cacheable object size.

5:31 PM Changeset in webkit [8250] by hyatt

3 edits in trunk/WebCore

Fix for 3923255, specified percentage heights of divs with overflow auto inside tables not honored.

Reviewed by kocienda

khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight):
khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):

4:43 PM Changeset in webkit [8249] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Kevin.

<rdar://problem/3926869> Opening caches window after running PLT causes crash

kjs/protected_values.cpp: (KJS::ProtectedValues::getProtectCount): Don't include simple numbers in the protected value table. (KJS::ProtectedValues::increaseProtectCount): Ditto. (KJS::ProtectedValues::decreaseProtectCount): Ditto.

4:38 PM Changeset in webkit [8248] by harrison

2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3924930> REGRESSION: triple click does not select to end of line

khtml/editing/visible_units.cpp: (khtml::endOfParagraph): When includeLineBreak is true, allow traversal to next node after enclosingBlockFlowElement.

4:16 PM Changeset in webkit [8247] by hyatt

1 edit in trunk/WebCore/kwq/KWQFoundationExtras.h

Fix Panther build bustage.

3:32 PM Changeset in webkit [8246] by kocienda

2 edits in trunk/WebCore

Reviewed by Vicki

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): Missed deleting some now-obsolete expcetion codes when I added the createBreakElement() function.

3:01 PM Changeset in webkit [8245] by rjw

3 edits in trunk/WebKit

Make image decoding as lazy as possible for non-threaded case; in some cases
can avoid unnecessary decoding work.

Reviewed by Chris.

WebCoreSupport.subproj/WebImageData.h:
WebCoreSupport.subproj/WebImageData.m: (-[WebImageData imageAtIndex:]): (-[WebImageData propertiesAtIndex:]): (-[WebImageData incrementalLoadWithBytes:length:complete:callback:]):

2:56 PM Changeset in webkit [8244] by rjw

2 edits in trunk/WebCore

Set the floor of max cacheable object size to 40K. This restores
the long standing floor. Lower floor deleteriously impacts the PLT.
Reviewed by Hyatt.

khtml/khtml_part.cpp: (KHTMLPart::checkCompleted):
khtml/misc/loader.cpp: (Cache::setSize):

2:21 PM Changeset in webkit [8243] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3926142> REGRESSION (Mail): Deleting text decreases quote level

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): Stop merging nodes when a <br> is hit. Formerly checked only for block boundary.

1:58 PM Changeset in webkit [8242] by harrison

2 edits in trunk/WebCore

Reviewed by Darin.

Add KWQCFAutorelease for autoreleasing CF objects.

kwq/KWQFoundationExtras.h: (KWQCFAutorelease): New.

1:56 PM Changeset in webkit [8241] by harrison

2 edits in trunk/WebCore

Reviewed by Darin.

Fix GC compatibility in getNSString.

kwq/KWQString.mm: (QString::getNSString):

Use NSString allocator instead of CFString, so that autorelease works under GC.

11:58 AM Changeset in webkit [8240] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3890973> REGRESSION (Mail): Deleting reorders remaining text

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::moveNodesAfterNode): Added check to ensure that moving content will not move it after the <body> element.

10:57 AM Changeset in webkit [8239] by kocienda

1 edit
8 adds in trunk

Reviewed by me

Added new layout tests covering cases from recent bug fixes.

layout-tests/editing/inserting/insert-div-018-expected.txt: Added.
layout-tests/editing/inserting/insert-div-018.html: Added.
layout-tests/editing/inserting/insert-div-019-expected.txt: Added.
layout-tests/editing/inserting/insert-div-019.html: Added.
layout-tests/editing/inserting/insert-div-020-expected.txt: Added.
layout-tests/editing/inserting/insert-div-020.html: Added.
layout-tests/editing/inserting/insert-div-021-expected.txt: Added.
layout-tests/editing/inserting/insert-div-021.html: Added.

10:31 AM Changeset in webkit [8238] by kocienda

3 edits in trunk

Reviewed by me

Changes in layout resulting from giving <p> elements no margin rather than 0.1em margin.

layout-tests/editing/inserting/insert-div-013-expected.txt
layout-tests/editing/inserting/insert-div-014-expected.txt

10:01 AM Changeset in webkit [8237] by kocienda

3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3925317> Increase quote in email and with cursor below the quote the new line appears above the quote

khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
khtml/editing/visible_position.cpp: Refine rules for whether to use the starting node or the starting block as the reference node for the insertion of the new block. (khtml::isLastVisiblePositionInBlock): Tweak rules again. Descendants of following blocks should answer true. I worked this all out on the whiteboard this time. This should be the last tweak.

8:29 AM Changeset in webkit [8236] by kdecker

2 edits in trunk/WebCore

Reviewed by Ken.

Fixed <rdar://problem/3824438> Need a clean way for Dashboard to detect when an XML parsing error occurs

khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::insertErrorMessageBlock): In the xml error report, instead of a generic <div>, use <parsererror> to match Mozilla.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed