⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 10, 2005:

3:40 PM Changeset in webkit [8333] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3943648> extra line is inserted after pressing return within quoted text of reply

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): This bug was the result of a simple coding mistake. A local variable was erroneously redefined in a deeper scope, and so the result calculated in that deeper scope was not available when tested.
3:28 PM Changeset in webkit [8332] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3946852> Option-e goes to next line

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Tweak case used to determine when merging content into the start line is done. We plan to change pretty substantially soon to better handle the problem described in <rdar://problem/3937352> Quote level not maintained when copied and pasted within a Mail message. In the meantime, this change does no harm, and fixes the bug.
10:47 AM Changeset in webkit [8331] by kocienda
  • 5 edits
    26 adds in trunk

Reviewed by Darin

Fix for this bug:

<rdar://problem/3907005> Applying block styles to a line of text can unexpectedly affect other lines

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): New function which moves "paragraphs" to their own blocks if needed so that a block style can be applied. (khtml::CompositeEditCommand::isMailBlockquote): Moved this function to base class so it can be used more generally. (khtml::ApplyStyleCommand::applyBlockStyle): Pass a node instead of a block to addBlockStyleIfNeeded(). (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): Now accepts a node instead of a block for styling. This function also now calls moveParagraphContentsToNewBlockIfNecessary() to make sure that only the current paragraph is styled. (khtml::SetNodeAttributeCommand::doUnapply): Should not assert on undo if old value of attribute was null. Should remove attributue instead.
  • khtml/editing/htmlediting.h: Touch function declarations accordingly.
  • layout-tests/editing/style/create-block-for-style-001-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-001.html: Added.
  • layout-tests/editing/style/create-block-for-style-002-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-002.html: Added.
  • layout-tests/editing/style/create-block-for-style-003-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-003.html: Added.
  • layout-tests/editing/style/create-block-for-style-004-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-004.html: Added.
  • layout-tests/editing/style/create-block-for-style-005-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-005.html: Added.
  • layout-tests/editing/style/create-block-for-style-006-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-006.html: Added.
  • layout-tests/editing/style/create-block-for-style-007-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-007.html: Added.
  • layout-tests/editing/style/create-block-for-style-008-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-008.html: Added.
  • layout-tests/editing/style/create-block-for-style-009-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-009.html: Added.
  • layout-tests/editing/style/create-block-for-style-010-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-010.html: Added.
  • layout-tests/editing/style/create-block-for-style-011-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-011.html: Added.
  • layout-tests/editing/style/create-block-for-style-012-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-012.html: Added.
  • layout-tests/editing/style/create-block-for-style-013-expected.txt: Added.
  • layout-tests/editing/style/create-block-for-style-013.html: Added.

Unrelated updates to these expected results.

  • layout-tests/editing/inserting/insert-div-007-expected.txt
  • layout-tests/editing/pasteboard/paste-text-013-expected.txt
10:38 AM Changeset in webkit [8330] by cblu
  • 3 edits in trunk/WebCore

Fixed: <rdar://problem/3936844> Mail: Messages with rich text do not print

Reviewed by john.

  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): don't do pagination work if printRect is not set
  • khtml/rendering/render_list.cpp: (RenderListMarker::paint): ditto
10:22 AM Changeset in webkit [8329] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • kwq/KWQTextUtilities.mm: (currentTextBreakLocaleID): Return empty string (AKA root locale) if locale pref can not be canonicalized.
9:07 AM Changeset in webkit [8328] by sullivan
  • 2 edits in trunk/WebCore

Fixed broken Panther build.

  • kwq/KWQTextUtilities.mm: (currentTextBreakLocaleID): This recently-added function was using code copy/pasted from CarbonCore UnicodeUtilities. That code used a Tiger-only function, CFLocaleCreateCanonicalLanguageIdentifierFromString. To fix the build, I added a BUILDING_ON_PANTHER #ifdef that avoids the call to the Tiger function. However, the Tiger-only code was wrong; the string generated using CFLocaleCreateCanonicalLanguageIdentifierFromString was not used at all, so I fixed that as well.

Jan 9, 2005:

1:42 PM Changeset in webkit [8327] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3786362> REGRESSION (Mail): pasted text loses one newline

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Tune check for need for insertParagraphSeparator when hasInterchangeNewline.
11:11 AM Changeset in webkit [8326] by darin
  • 2 edits in trunk/WebCore

Reviewed by Harrison.

  • fixed <rdar://problem/3939176> select() method does not work on <input type=search>
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::select): Changed if statement to a switch statement. Added SEARCH to the set of types that treat the renderer as a RenderLineEdit.
10:54 AM Changeset in webkit [8325] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

<rdar://problem/3905066> REGRESSION (Mail): Hitting return key with caret in front of space causes space to become lost (resize fixes)

Problem was that InsertParagraphSeparatorCommand::doApply() was not collapsing
whitespace to a single non-breaking space when splitting a text node.

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
10:40 AM Changeset in webkit [8324] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Ken.

Fixed: <rdar://problem/3924219> Calling setOuterHTML: on a DOMHTMLHtmlElement can crash a program

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): Added a nil check for fragments who don't have parents.

Jan 8, 2005:

8:09 PM Changeset in webkit [8323] by mjs
  • 4 edits in trunk

Reviewed by Darin.

<rdar://problem/3807144> REGRESSION (125-TOT): my bank's website doesn't work (Societe Generale, socgen.com)

  • Khtml/khtml_part.cpp: (KHTMLPart::checkCompleted): If the document is NULL, assume this frame has not started loading yet so it could not possibly be finishing here... (KHTMLPart::stop): ...unless the part is explicitly stopped and there is still no document, in this case we must have hit an error or been loading a non-HTML frame.
  • khtml/khtml_part.h:
12:42 PM Changeset in webkit [8322] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/3943415> REGRESSION (Mail): double-clicking past word selects previous word instead of only blank space

  • khtml/editing/selection.cpp: (khtml::Selection::validate): Tune word selections left/right choice to use right if on empty last line.

Jan 7, 2005:

4:17 PM Changeset in webkit [8321] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3942619> AX: Support sentence ax attributes

Needed to use the unicode utilities properly. Twas lame before.

  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary): (khtml::startOfWord): (khtml::endOfWord): (khtml::previousWordPosition): (khtml::nextWordPosition): (khtml::startOfSentence): (khtml::endOfSentence): (khtml::previousSentencePosition): (khtml::nextSentencePosition):
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeNames]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject doAXAttributedStringForTextMarkerRange:]):
  • kwq/KWQTextUtilities.mm: (currentTextBreakLocaleID): (KWQFindSentenceBoundary): (KWQFindNextSentenceFromIndex):
2:42 PM Changeset in webkit [8320] by kocienda
  • 2 edits
    4 adds in trunk

Reviewed by Kevin

Fix for these bugs:

<rdar://problem/3939523> in some cases, text does not retain style info after pressing return twice
<rdar://problem/3944492> after pressing return twice, text is bold when it shouldn't be

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::setFullTypingStyleBeforeInsertion): Merge the typing style with the computed style for the current position. Fixes both bugs.
  • khtml/editing/htmlediting.h:
  • layout-tests/editing/inserting/insert-div-023-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-023.html: Added.
  • layout-tests/editing/inserting/insert-div-024-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-024.html: Added.
12:38 PM Changeset in webkit [8319] by hyatt
  • 5 edits in trunk/LayoutTests/fast

Fix the layout tests.

12:22 PM Changeset in webkit [8318] by hyatt
  • 7 edits in trunk/WebCore

Fix for 3941364, make sure tables reset overflowWidth/Height when they lay out again. Fixes the odd scrolling
behavior on worldofwarcraft.com.

Reviewed by kevin

  • ChangeLog:
  • khtml/rendering/render_table.cpp: (RenderTable::layout):
12:13 PM Changeset in webkit [8317] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3848412> for forwarded message, tabbing to message view scrolls to bottom of view

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Don't scroll the focus node to visible if it is not in the document, or if it is not a descendent of the document element. In the case of the bug, since the selection has not yet been set up, the focus node passed here is the HTML element, and that does not yield a rect that is useful to us here. So now, in the case the bug mentions, we do nothing.
Note: See TracTimeline for information about the timeline view.