⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 14, 2005:

3:55 PM Changeset in webkit [8381] by darin
  • 5 edits in trunk/WebCore
  • khtml/css/cssproperties.c: Regenerated with gperf 3.0.1.
  • khtml/css/cssvalues.c: Regenerated with gperf 3.0.1.
  • khtml/misc/htmlattrs.c: Regenerated with gperf 3.0.1.
  • khtml/misc/htmltags.c: Regenerated with gperf 3.0.1.
12:09 PM Changeset in webkit [8380] by cblu
  • 5 edits in trunk/WebCore

Fixed: <rdar://problem/3886415> arrow keys don't work when the user hits Back to return to RSS page

Reviewed by hyatt.

(KWQKHTMLPart::openURLFromPageCache): restore mousePressNode
(KWQKHTMLPart::mousePressNode): new

  • kwq/KWQPageState.h:
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): save the mousePressNode (-[KWQPageState clear]): clear the mousePressNode (-[KWQPageState dealloc]): deref the mousePressNode (-[KWQPageState mousePressNode]): new

Jan 13, 2005:

6:14 PM Changeset in webkit [8379]
  • 25 copies
    2 deletes in tags/WebKit-85~8~5

This commit was manufactured by cvs2svn to create tag
'WebKit-85~8~5'.

6:14 PM Changeset in webkit [8378] by adele
  • 2 edits in branches/Safari-1-0-branch/WebKit

fixed mismatched_CFBundleShortVersionStrings verification failure by correcting

version string to 1.0.3

5:40 PM Changeset in webkit [8377] by adele
  • 2 edits in branches/Safari-1-0-branch/WebKit
  • bump WebKit version number to 85.8.5; the tag "WebKit-85~8~3" is already taken, and

version numbers with a "4" are not allowed because of Netscape 4 compatibility

5:30 PM Changeset in webkit [8376] by adele
  • 2 edits in branches/Safari-1-0-branch/WebKit

versioning for January 2005 Security Update, WebKit-85.8.3

5:24 PM Changeset in webkit [8375]
  • 23 copies
    2 deletes in tags/WebCore-85~6~6

This commit was manufactured by cvs2svn to create tag
'WebCore-85~6~6'.

5:24 PM Changeset in webkit [8374] by adele
  • 3 edits in branches/Safari-1-0-branch/WebCore

versioning for January 2005 Security Update, WebCore-85.6.6

5:01 PM Changeset in webkit [8373] by cblu
  • 6 edits in trunk/WebKit

Fixed: <rdar://problem/3932107> Safari does not load QT Cocoa plug-in if the WebPluginMIMETypes key is not in the info.plist

Fixing this bug required that we allow WebKit plug-ins (as well as Netscape plug-ins) support BP_CreatePluginMIMETypesPreferences
which allows plug-ins create an auxiliary MIME types file.

Reviewed by adele.

  • Plugins.subproj/WebBasePluginPackage.h:
  • Plugins.subproj/WebBasePluginPackage.m: (+[WebBasePluginPackage preferredLocalizationName]): moved from WebNetscapePluginPackage (-[WebBasePluginPackage pListForPath:createFile:]): ditto (-[WebBasePluginPackage getPluginInfoFromPLists]): ditto (-[WebBasePluginPackage isLoaded]): return isLoaded ivar (-[WebBasePluginPackage load]): if loaded, get BP_CreatePluginMIMETypesPreferences symbol
  • Plugins.subproj/WebNetscapePluginPackage.h:
  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): call super when done so BP_CreatePluginMIMETypesPreferences can be initialized
  • Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): call getPluginInfoFromPLists (-[WebPluginPackage load]): call super when done so BP_CreatePluginMIMETypesPreferences can be initialized
4:29 PM Changeset in webkit [8372] by adele
  • 12 edits in branches/Safari-1-0-branch

WebCore:

<rdar://problem/3939323> frame naming allows malicious site to bring up a window when you click on a link in another
<rdar://problem/3939484> scripts can cause other frames/windows to execute arbitrary script using javascript: URLs
<rdar://problem/3943552> WebKit needs to restrict access to certain window operations by domain

merged these fixes from Tiger:

2004-12-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Added opener bridge method to help WebKit implement security check
for named frame visibility.

  • khtml/khtml_part.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge opener]):

2004-12-06 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

  • fixed <rdar://problem/3903797> scripts can cause other frames/windows to execute arbitrary script using javascript: URLs

I changed all unprotected places that can navigate a different
window or frame from script to check for a javascript: URL, and if
found, to check for safety using cross-site-script rules.

I considered a few other possible exploits and made no change:

  • document.location is already protected because the document object itself is protected
  • frame.src, frame.location, iframe.src and targetted links are all safe because setting the URL of a frame to a javascript: URL executes the script in the context of the parent
  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): (Location::put): (LocationFunc::tryCall):

2004-12-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by John.

<rdar://problem/3929187> WebKit needs to restrict access to certain window operations by domain

  • khtml/ecma/kjs_window.cpp: (Window::get): Change most window functions to be restricted by XSS domain check.

The following files were changed to complete the merge. Added compareIgnoringCaseForASCIIOnly and startsWith functions
to match how it is in later versions.

  • kwq/KWQString.h:
  • kwq/KWQString.mm: (compareIgnoringCaseForASCIIOnly): (QString::startsWith): (QString::find):

WebKit:

<rdar://problem/3939323> frame naming allows malicious site to bring up a window when you click on a link in another

merged fix for this from Tiger:

2004-12-21 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

<rdar://problem/3888931> frame naming allows malicious site to bring up a window when you click on a link in another

Implement a security check on name frame visbility. This is the
same rule as mozilla. You can only target frames by name if you
are in the same window, have the same domain as the frame or an
ancestor, or if it's a top level window have the same domain as
the opener.

  • WebView.subproj/WebFrame.m: (-[WebFrame _shouldAllowAccessFrom:]): (-[WebFrame _descendantFrameNamed:sourceFrame:]): (-[WebFrame findFrameNamed:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebView.m: (-[WebView _findFrameInThisWindowNamed:sourceFrame:]): (-[WebView _findFrameNamed:sourceFrame:]):
  • WebView.subproj/WebViewPrivate.h:
4:17 PM Changeset in webkit [8371] by rjw
  • 1 edit in trunk/WebKit/Plugins.subproj/WebJavaPlugIn.h

Changed another place where the method name was incorrect in
the comment.

Reviewed (and found) by Darin.

4:11 PM Changeset in webkit [8370] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/3952809> WebJavaPlugIn.h comments need method name corrected (webPlugInCallJava)

Reviewed by Maciej.

  • Plugins.subproj/WebJavaPlugIn.h:
4:05 PM Changeset in webkit [8369] by vicki
  • 3 edits in trunk

Safari-179+ for TOT. The tree is open!

3:58 PM Changeset in webkit [8368]
  • 1 copy in tags/Safari-179

This commit was manufactured by cvs2svn to create tag 'Safari-179'.

3:58 PM Changeset in webkit [8367] by vicki
  • 6 edits in trunk

Safari-179 stamp

3:54 PM Changeset in webkit [8366] by vicki
  • 6 edits in trunk

Reviewed by Adele.

  • fix <rdar://problem/3946836> Safari about box lists 2004 instead of 2005
2:13 PM Changeset in webkit [8365] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/3951911> REGRESSION: Animated GIF images with loop counts no longer update

Draw last image after animation loop terminates. (We
were drawing the image at index+1, which doesn't exist!)

Reviewed by Darin.

  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _nextFrame:]):
2:02 PM Changeset in webkit [8364] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/3952084> REGRESSION: Links at projectseven.com now draw and update incorrectly during hover

Turn off use of new CGContextStrokeLineSegments API. We should
turn back on when 3952944 is fixed.

Reviewed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]):
1:17 PM Changeset in webkit [8363] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

fixed incorrect check-in date

11:45 AM Changeset in webkit [8362] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Ken Kocienda.

Better fix for 3905066.

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
11:41 AM Changeset in webkit [8361] by cblu
  • 4 edits in trunk/WebKit

Fixed: <rdar://problem/3937663> repro assertion failure and crash dragging image that has PDF source

Reviewed by adele.

  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): if [WebImageRenderer image] returns nil, fallback to code that uses a file icon as the drag image
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory supportedMIMETypes]): removed code that omits PDF and PostScript from the list since this omission is only needed in WebImageView
  • WebView.subproj/WebImageView.m: (+[WebImageView supportedImageMIMETypes]): added code that omits PDF and PostScript since we don't want WebImageView to render these types
11:09 AM Changeset in webkit [8360] by mjs
  • 12 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/3758033> REGRESSION (Mail): Support attributes in marked text (International input)

  • khtml/rendering/render_text.cpp: (InlineTextBox::paint): Support painting custom underline markers for marked text in place of generic yellow. (InlineTextBox::paintMarkedTextUnderline): New method that handles this.
  • khtml/rendering/render_text.h:
  • kwq/KWQKHTMLPart.h: Declare new methods and structs.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::clear): Clear marked test underlines. (KWQKHTMLPart::setMarkedTextRange): Takes attributes and ranges now. (convertAttributesToUnderlines): Converts NSAttributedString attributes to simplified and C++-friendly form. (KWQKHTMLPart::markedTextUsesUnderlines): New method. (KWQKHTMLPart::markedTextUnderlines): New method.
  • kwq/KWQPainter.mm: (QPainter::drawLineForText): Handle pen width.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setMarkedTextDOMRange:customAttributes:ranges:]): Take attributes and ranges.
  • kwq/WebCoreTextRenderer.h:

WebKit:

Reviewed by Darin.

<rdar://problem/3758033> REGRESSION (Mail): Support attributes in marked text (International input)

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawLineForCharacters:yOffset:width:color:thickness:]): Changed to support underline thickness. Also added a bit of a hack here to move thickness 2 underlines down by .5 pixels, since the rendering engine can't give a fractional pixel offset.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView validAttributesForMarkedText]): Support underline, underline color and marked clause attributes. Others that NSText supports are unimplemented for now. (-[WebHTMLView firstRectForCharacterRange:]): Remove needless logging. (-[WebHTMLView unmarkText]): Updated for new WebCore SPI. (-[WebHTMLView _extractAttributes:ranges:fromAttributedString:]): New method to pull the attributes and ranges out of an attributed string. (-[WebHTMLView setMarkedText:selectedRange:]): Extract attributes and pass to WebCore. (-[WebHTMLView insertText:]): Add comment noting that we don't really handle attributed strings here.
Note: See TracTimeline for information about the timeline view.