⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 17, 2005:

5:44 PM Changeset in webkit [8394] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/3949429> AX: word marker routines returns incorrect data for empty line
<rdar://problem/3949848> AX: paragraph marker routines do not work when given a paragraph end marker

Also fixed sentence support in the same way.

  • kwq/KWQAccObject.mm: (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextParagraphEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousParagraphStartTextMarkerForTextMarker:]): Move one position in desired direction before calling visible_units.cpp code.
5:33 PM Changeset in webkit [8393] by harrison
  • 8 edits in trunk

Updated expected test results.

<rdar://problem/3945880> line-ending space seems not to be present

  • layout-tests/editing/deleting/delete-ws-fixup-001-expected.txt:
  • layout-tests/editing/deleting/delete-ws-fixup-002-expected.txt:
  • layout-tests/editing/inserting/insert-div-020-expected.txt:
  • layout-tests/editing/inserting/insert-div-021-expected.txt:
  • layout-tests/editing/inserting/insert-div-022-expected.txt:
  • layout-tests/editing/inserting/insert-div-023-expected.txt:
  • layout-tests/editing/inserting/insert-div-024-expected.txt:
5:07 PM Changeset in webkit [8392] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt (bidi.cpp) and Darin Adler (selection.cpp).

<rdar://problem/3945880> line-ending space seems not to be present

  • khtml/editing/selection.cpp: (khtml::Selection::validate): Extend AFTER_WHITE_SPACE code to support white spac in the middle of paragraphs, not just the end.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): Pick left/rightness of word selection based on being at the end of paragraph (i.e. after a hard line break).
5:06 PM Changeset in webkit [8391] by darin
  • 2 edits in trunk/WebKit
  • DOM.subproj/DOMPrivate.h: Check in generated file.
4:43 PM Changeset in webkit [8390] by darin
  • 5 edits in trunk/WebCore

Reviewed by John Louch.

  • fixed <rdar://problem/3958503> need screenX and screenY to use WebKit windowFrame delegate
  • khtml/ecma/kjs_window.cpp: (Window::get): Change screenX and screenY to use frameGeometry instead of using mapToGlobal and screen in a complicated way.
  • kwq/KWQKHTMLView.mm: Removed unused mapToGlobal function.
  • kwq/KWQWindowWidget.h: Ditto.
  • kwq/KWQWindowWidget.mm: Ditto.
3:30 PM Changeset in webkit [8389] by hyatt
  • 2 adds in trunk/LayoutTests/fast/block/float

Add layout test for overflow float bug.

3:27 PM Changeset in webkit [8388] by hyatt
  • 2 edits in trunk/WebCore

Fix a screwup in rightmost/lowets position computation. 3955207. Make sure floats with layers are still checked.

Reviewed by kocienda

  • khtml/rendering/render_block.cpp
3:23 PM Changeset in webkit [8387] by darin
  • 7 edits
    1 add in trunk/WebKit

Reviewed by John and Richard.

  • fixed <rdar://problem/3907453> printing a multi-page PDF document from Safari doesn't produce correct output
  • WebView.subproj/WebFrameViewPrivate.h: Added.
  • WebView.subproj/WebFrameView.m: (-[WebFrameView canPrintHeadersAndFooters]): Added. Returnes NO for documents that can't print headers or footers, and delegates to the document view to answer the question. Defaults to NO, since only a view that actively does the work is compatible with our header and footer code. (-[WebFrameView printOperationWithPrintInfo:]): Added. Returns an NSPrintOperation set up for printing. The reason we return this rather than an NSView is that in the PDFView case, the print info is changed around before creating the NSPrintOperation, and also the PDFKit SPI works this way.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView canPrintHeadersAndFooters]): Added. Returns YES.
  • WebView.subproj/WebImageView.m: (-[WebImageView canPrintHeadersAndFooters]): Ditto.
  • WebView.subproj/WebTextView.m: (-[WebTextView canPrintHeadersAndFooters]): Ditto.
  • WebView.subproj/WebPDFView.m: (-[WebPDFView canPrintHeadersAndFooters]): Added. Returns NO. (-[WebPDFView printOperationWithPrintInfo:]): Added. Calls getPrintOperationForPrintInfo: autoRotate:YES on the PDFView.
  • WebKit.pbproj/project.pbxproj: Added WebFrameViewPrivate.h as a new private header.
3:08 PM Changeset in webkit [8386] by rjw
  • 1 edit in trunk/WebCore/khtml/ecma/kjs_binding.cpp

Fixed build snafu.

2:54 PM Changeset in webkit [8385] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

<rdar://problem/3953366> Problems with typing attributes in HTML compose

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Remove misguided "optimization" that tried to sense when typing style could be cleared without actually doing a style diff between before-delete and after-delete positions. Removing this extra check and running the general-purpose code fixes the bug.
2:41 PM Changeset in webkit [8384] by rjw
  • 26 edits in trunk

WebCore:

Fixed <rdar://problem/3753030> Need to ensure same origin for plugin binding invocations (origin security rules)

Keep track of originating execution context and target execution
context for native JS object wrappers, and perform appropriate
security checks.

Reviewed by David Harrison.

  • khtml/ecma/kjs_binding.cpp: (ScriptInterpreter::isGlobalObject): (ScriptInterpreter::isSafeScript): (ScriptInterpreter::interpreterForGlobalObject):
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_window.cpp: (Window::interpreter): (Window::isSafeScript):
  • khtml/ecma/kjs_window.h:
  • kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::windowScriptObject): (KWQKHTMLPart::windowScriptNPObject):
  • kwq/WebCoreBridge.mm: (rootForView): (-[WebCoreBridge init]):

JavaScriptCore:

Fixed <rdar://problem/3753030> Need to ensure same origin for plugin binding invocations (origin security rules)

Keep track of originating execution context and target execution
context for native JS object wrappers, and perform appropriate
security checks.

Reviewed by David Harrison.

  • bindings/NP_jsobject.cpp: (_isSafeScript): (_NPN_CreateScriptObject): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException):
  • bindings/NP_jsobject.h:
  • bindings/c/c_instance.cpp: (CInstance::CInstance): (CInstance::stringValue):
  • bindings/c/c_instance.h:
  • bindings/c/c_utility.cpp: (convertValueToNPVariant):
  • bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::valueOf):
  • bindings/jni/jni_instance.h:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject _initializeWithObjectImp:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): (-[WebScriptObject _initWithObjectImp:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): (-[WebScriptObject KJS::Bindings::]): (-[WebScriptObject _setOriginExecutionContext:KJS::Bindings::]): (-[WebScriptObject _isSafeScript]): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject stringRepresentation]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]): (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
  • bindings/objc/WebScriptObjectPrivate.h:
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_runtime.mm: (convertValueToObjcObject):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
  • bindings/runtime.cpp: (Instance::Instance): (Instance::operator=):
  • bindings/runtime.h: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::setExecutionContext): (KJS::Bindings::Instance::executionContext):
  • bindings/runtime_root.cpp: (RootObject::setInterpreter):
  • bindings/runtime_root.h:
  • kjs/interpreter.h: (KJS::Interpreter::isGlobalObject): (KJS::Interpreter::interpreterForGlobalObject): (KJS::Interpreter::isSafeScript):
2:20 PM Changeset in webkit [8383] by kocienda
  • 1 edit in trunk/WebCore/khtml/editing/htmlediting.cpp

Roll out unintended work-in-progress change

2:18 PM Changeset in webkit [8382] by kocienda
  • 11 edits
    8 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3786659> REGRESSION (Mail): editable WebViews don't work with
"size up" and "size down" NSFontManager changes

  • khtml/css/cssparser.cpp: (CSSParser::parseValue): Add support for parsing new font size delta property.
  • khtml/css/cssproperties.c: Generated file.
  • khtml/css/cssproperties.h: Ditto.
  • khtml/css/cssproperties.in: Add support for parsing new font size delta property.
  • khtml/editing/htmlediting.cpp: (khtml::isEmptyStyleSpan): New helper function. Code existed before, but now factored out for convenient use. (khtml::CompositeEditCommand::removeNodeAttribute): Does check on value to see it exists before creating and running command to do the removal. (khtml::ApplyStyleCommand::doApply): Now calls new applyRelativeFontStyleChange() function as part of its work. (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): New function that does the "heavy lifting" to handle relative font size changes. (khtml::ApplyStyleCommand::applyInlineStyle): Range check the start and end positions to make sure the start is before or equal to the end. Swap them if not true. I ran into this problem in some similar code in applyRelativeFontStyleChange(). Moving that goodness here too. (khtml::ApplyStyleCommand::splitTextAtEndIfNeeded): Uses a local variable to save a value used often. Code is the same, but reads better now. Function now returns bool as well, just like splitTextAtStartIfNeeded. I use the bool return value now (I obviously did not need it before). (khtml::ApplyStyleCommand::computedFontSize): New helper function. (khtml::ApplyStyleCommand::joinChildTextNodes): Ditto. (khtml::createStyleSpanElement): Ditto.
  • khtml/editing/htmlediting.h: Update header accordingly.
  • khtml/editing/jsediting.cpp: Add new command string to enable relative font size changes.
  • kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration _fontSizeDelta]): New convenience. (-[DOMCSSStyleDeclaration _setFontSizeDelta:]): Ditto.
  • kwq/DOMPrivate.h: Declare new conveniences.
  • layout-tests/editing/editing.js: Add new JS to enable relative font size changes, as well as explicit font size setting.
  • layout-tests/editing/style/relative-font-size-change-001-expected.txt: Added.
  • layout-tests/editing/style/relative-font-size-change-001.html: Added.
  • layout-tests/editing/style/relative-font-size-change-002-expected.txt: Added.
  • layout-tests/editing/style/relative-font-size-change-002.html: Added.
  • layout-tests/editing/style/relative-font-size-change-003-expected.txt: Added.
  • layout-tests/editing/style/relative-font-size-change-003.html: Added.
  • layout-tests/editing/style/relative-font-size-change-004-expected.txt: Added.
  • layout-tests/editing/style/relative-font-size-change-004.html: Added.

Jan 14, 2005:

3:55 PM Changeset in webkit [8381] by darin
  • 5 edits in trunk/WebCore
  • khtml/css/cssproperties.c: Regenerated with gperf 3.0.1.
  • khtml/css/cssvalues.c: Regenerated with gperf 3.0.1.
  • khtml/misc/htmlattrs.c: Regenerated with gperf 3.0.1.
  • khtml/misc/htmltags.c: Regenerated with gperf 3.0.1.
12:09 PM Changeset in webkit [8380] by cblu
  • 5 edits in trunk/WebCore

Fixed: <rdar://problem/3886415> arrow keys don't work when the user hits Back to return to RSS page

Reviewed by hyatt.

(KWQKHTMLPart::openURLFromPageCache): restore mousePressNode
(KWQKHTMLPart::mousePressNode): new

  • kwq/KWQPageState.h:
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]): save the mousePressNode (-[KWQPageState clear]): clear the mousePressNode (-[KWQPageState dealloc]): deref the mousePressNode (-[KWQPageState mousePressNode]): new
Note: See TracTimeline for information about the timeline view.