Timeline

Apr 18, 2005:

6:17 PM Changeset in webkit [9032] by darin

• 2 edits in trunk/WebKit

Reviewed by Hyatt.

• fixed <rdar://problem/4092614> REGRESSION (Tiger): progressively loaded background images "scroll around" instead of just appearing

• WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _imageSourceOptions]): Moved a global inside this function, since it's only used here. (-[WebImageData _cacheImages:allImages:]): Fixed a sizeof that was getting the size of the wrong thing. (-[WebImageData _isSizeAvailable]): Used calloc in a more consistent way. (drawPattern): Removed an unneeded cast. (-[WebImageData tileInRect:fromPoint:context:]): Here's the actual bug fix. Don't use the image size when deciding whether the image needs to be tiled as a pattern nor when creating the pattern: in both cases, use the tile size. The old way was wrong, and the new way works perfectly. Also removed uneeded error message when the image is not yet loaded enough to create a CGImageRef for it -- it's fine to draw nothing in that case.

3:36 PM Changeset in webkit [9031] by sullivan

• 7 edits in branches/experimental-ui-branch

WebCore:

WebCore support for notifying a form delegate when a
textarea's contents have changed (as opposed to a
textfield, which was already handled).

Reviewed by Maciej.

• kwq/WebCoreBridge.h: add textDidChange: method

• kwq/KWQTextArea.mm: (-[KWQTextArea textDidChange:]): call through to bridge

WebKit:

WebKit support for notifying a form delegate when a
textarea's contents have changed (as opposed to a
textfield, which was already handled).

Reviewed by Maciej.

• WebView.subproj/WebFormDelegate.h:
• WebView.subproj/WebFormDelegate.m: (-[WebFormDelegate textDidChange:inFrame:]): new form delegate method

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge textDidChange:]): new method, calls through to form delegate

WebBrowser:

Made form-text-changed confirmation work for textareas as well as textfields.

Reviewed by Maciej.

• BrowserWebController.m: (-[FormDelegate textDidChange:inFrame:]): implement this new FormDelegate method to set the dirty bit

• Confirmation sheet notes.html: updated

1:57 PM Changeset in webkit [9030] by hyatt

• 2 edits in trunk/WebCore

Fix min-height so that when it resolves to auto it does not use the box's intrinsic height.

• khtml/rendering/render_box.cpp: (RenderBox::calcHeight): (RenderBox::calcHeightUsing):

1:56 PM Changeset in webkit [9029] by hyatt

• 1 edit in trunk/LayoutTests/fast/table/border-collapsing/003-expected.txt

Fix layout test.

11:12 AM Changeset in webkit [9028] by hyatt

• 2 edits in trunk/WebCore

Back out fix for 4032346, since it is causing garbled image content on many sites.

The bug tracking the fix is 4069093.

(khtml::RenderBlock::matchedEndLine):

4:07 AM Changeset in webkit [9027] by hyatt

• 4 edits in trunk/WebCore

Fix the smile in the Acid2 test. Floats should not grow to contain other floats unless height is auto. Otherwise
the float should use the specified height.

Also fix row 14 of the Acid2 test. Although ambiguous, just modify the table cell baseline alignment code to align
to the bottom of the cell's content height if no suitable baseline could be found.

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlock):
• khtml/rendering/render_block.h: (khtml::RenderBlock::firstRootBox): (khtml::RenderBlock::lastRootBox):
• khtml/rendering/render_table.cpp: (RenderTableSection::calcRowHeight): (RenderTableCell::baselinePosition):