Timeline

Apr 29, 2005:

3:34 PM Changeset in webkit [9084] by darin

• 2 edits in trunk/WebCore

Reviewed by David Harrison.

• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayNode): Turn newlines into \n for better dumping.

1:13 PM Changeset in webkit [9083] by harrison

• 2 edits
  2 adds in trunk

Reviewed by Darin.

<rdar://problem/4083333> When deleting link at end of sentence, entire sentence gets deleted

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Work around bug #4103339 (whose real fix is somewhat risky), so this fix can get into a software update.

(khtml::DeleteSelectionCommand::handleGeneralDelete):
Add isAncestor check when comparing m_downstreamEnd.node() and m_startNode.

• layout-tests/editing/deleting/delete-4083333-fix-expected.txt: Added.
• layout-tests/editing/deleting/delete-4083333-fix.html: Added.

12:10 PM Changeset in webkit [9082] by darin

• 294 edits in trunk

Reviewed by Dave Harrison.

• changed layout tests to dump more minimal information about caret and selection

• kwq/KWQRenderTreeDebug.cpp: (nodePosition): Changed name; now does position relative to document. (writeSelection): Removed upstream/downstream code and changed format slightly.

• layout-tests/editing/*-expected.txt: Regenerated in new format.

10:28 AM Changeset in webkit [9081] by darin

• 7 edits
  4 adds in trunk

Reviewed by Chris Blumenberg.
Added two layout tests for regression testing.

• fixed <rdar://problem/4097849> REGRESSION (162-163): importNode creates non-HTML elements, thus style attributes (and some others) don't work

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Reorganized and partly rewrote this. The change that fixes the bug at hand is to explicitly use XHTML_NAMESPACE for HTML elements, since the old way of getting the namespace will return the null string for HTML elements, and createElementNS will not create an HTML element if passed a null string for the namespace. (DocumentImpl::processHttpEquiv): Removed some bogus getDocument() calls -- no need to call getDocument() in a document object. (DocumentImpl::attrName): Ditto. (DocumentImpl::tagName): Ditto. (DocumentImpl::setFocusNode): Ditto.

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::cloneNode): Moved the actual cloning here from ElementImpl::cloneNode, because XMLElementImpl already had its own version, and in here we can use createHTMLElement, which will work properly even in an XML document, and is also slightly more efficient.

• khtml/xml/dom_nodeimpl.h: Added a namespaceURI method function to go along with localName.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::namespaceURI): Added. Returns null string to be consistent with localName (only works on certain types of elements as documented).
• khtml/xml/dom_elementimpl.h: Removed ElementImpl::cloneNode (see above). Added an override of namespaceURI for XMLElementImpl.
• khtml/xml/dom_elementimpl.cpp: (XMLElementImpl::namespaceURI): Added. Returns the namespace (consistent with localName).

• layout-tests/fast/dom/importNodeHTML.html: Added. Tests both importNode and cloneNode (for comparison).
• layout-tests/fast/dom/importNodeHTML-expected.txt: Added.
• layout-tests/fast/dom/importNodeXML.xhtml: Added. XML version of the same test as above. Tests a different code path, so useful to have.
• layout-tests/fast/dom/importNodeXML-expected.txt: Added.

Apr 28, 2005:

6:13 PM Changeset in webkit [9080] by darin

• 7 edits in trunk/WebKit

Reviewed by Maciej.

• fixed problems preventing us from compiling with gcc 4.0

• WebKit.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.

• History.subproj/WebHistoryItem.m: (-[WebHistoryItem pageCache]): Changed return type to match the declaration.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed a BOOL that should have been a Boolean.
• WebCoreSupport.subproj/WebTextRenderer.m: Removed redundant copy of ROUND_TO_INT, also in a WebCore header. (-[WebTextRenderer _computeWidthForSpace]): Had to add cast because of difference in type of ROUND_TO_INT vs. CEIL_TO_INT. (pathFromFont): Added a cast to convert UInt8 * to char *.
• WebView.subproj/WebFrameView.m: (-[WebFrameView _setDocumentView:]): Fixed parameter type to match the declaration. (-[WebFrameView documentView]): Fixed return type to match the declaration.
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Initialized a variable to quiet an incorrect gcc 4.0 uninitialized variable warning. (-[WebHTMLView deleteToMark:]): Switched from @try style to NS_DURING style of exception handler because we can't pass -fobjc-exceptions just to Objective-C at the moment (see above). (-[WebHTMLView selectToMark:]): Ditto. (-[WebHTMLView swapWithMark:]): Ditto.

5:31 PM Changeset in webkit [9079] by darin

• 21 edits in trunk/WebCore

Reviewed by Dave Harrison.

• fixed problems preventing us from compiling with gcc 4.0

• WebCore.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.

• khtml/css/parser.y: Changed some rules that were using a float to pass around an enum to use an int instead to avoid a warning.
• khtml/css/parser.cpp: Regenerated.
• khtml/css/parser.h: Regenerated.

• khtml/ecma/kjs_dom.cpp: (DOMTextProtoFunc::tryCall): Rearranged a return statement to avoid an incorrect warning.
• khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Initialized a couple of variables to avoid an incorrect warning.
• khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Rearranged how we exit from the function to avoid an incorret warning.
• khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Changed some %d to %ld where the parameters where long ints.
• khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
• khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
• kwq/DOMEvents.mm: (-[DOMMouseEvent initMouseEvent:::::::::::::::]): Rearranged code to avoid a cast that was causing an incorrect warning.
• kwq/DOMUtility.mm: (createObjCDOMNode): Broke out as a separate function. (KJS::ScriptInterpreter::createObjcInstanceForValue): Rearranged code to avoid a namespace collision with KJS::DOMNode and the Objective-C DOMNode class.
• kwq/KWQFileButton.mm: Made fields of KWQFileButtonAdapter public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::matchLabelsAgainstElement): Rearranged a return statement to avoid an incorrect warning. (KWQKHTMLPart::imageFromRect): Rearranged how this function does its exception handling to avoid a "may be clobbered" warning.
• kwq/KWQKJavaAppletWidget.mm: Fixed incorrect import that said "KHTMLView.h" instead of "khtmlview.h".
• kwq/KWQObject.mm: Made fields of KWQObjectTimerTarget public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
• kwq/WebCoreBridge.mm: (partHasSelection): Used [bridge part] instead of getting directly at instance variable to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.

• WebCore-combined.exp: Regenerated.
• WebCore-tests.exp: Added some additional symbols needed by the tests under gcc 4.0.

5:22 PM Changeset in webkit [9078] by darin

• 9 edits in trunk/JavaScriptCore

Reviewed by Dave Harrison.

• fixed problems preventing us from compiling with gcc 4.0

• JavaScriptCore.pbproj/project.pbxproj: Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.

• bindings/jni/jni_jsobject.cpp: (JSObject::getSlot): Changed some %d to %ld where the parameters where long ints. (JSObject::setSlot): Ditto.
• bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): Ditto. (KJS::Bindings::getJNIEnv): Ditto.
• bindings/objc/objc_utility.mm: Fixed include of <JavascriptCore/internal.h> that needed the letter "S" capitalized.
• kjs/bool_object.cpp: (BooleanProtoFuncImp::call): Rearranged how this function returns to avoid incorrect gcc 4.0 warning.
• kjs/collector.cpp: (KJS::Collector::markStackObjectsConservatively): Changed code to check the alignment of the passed-in pointers to only require pointer-level alignment, not 8-byte alignment. Prevents a crash on garbage collect when compiled with gcc 4.0.
• kjs/nodes.cpp: (WhileNode::execute): Added a redundant return after an infinite loop to work around incorrect gcc 4.0 warning. (ForNode::execute): Ditto. (SwitchNode::execute):Rearranged how this function returns to avoid incorrect gcc 4.0 warning. (LabelNode::execute): Ditto.
• kjs/string_object.cpp: (replace): Ditto.

5:07 PM Changeset in webkit [9077] by darin

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix ChangeLog

5:07 PM Changeset in webkit [9076] by darin

• 2 edits in trunk/WebCore

• WebCore.pbproj/project.pbxproj: Add back the main_thread_malloc files, rolled out by accident.