Timeline

May 17, 2005:

10:55 AM Changeset in webkit [9177] by cblu

• 3 edits in trunk/WebKit

Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

Reviewed by mjs.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer] (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
• WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.

9:28 AM Changeset in webkit [9176] by cblu

• 5 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead

Reviewed by mjs.

• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): if the WebKit client has chosen to "use" a remote web archive, stop the load with an error

WebBrowser:

Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead

• BrowserWebView.m: (-[BrowserWebView webView:decidePolicyForMIMEType:request:frame:decisionListener:]): download remote web archives

May 16, 2005:

3:11 PM Changeset in webkit [9175] by darin

• 4 edits in trunk

WebCore:

• attempt to get things building under "Saffron" development tools

• WebCore.pbproj/project.pbxproj: Use BUILT_PRODUCTS_DIR instead of SYMROOT.

WebKit:

• attempt to get things building under "Saffron" development tools

• WebKit.pbproj/project.pbxproj: Use BUILT_PRODUCTS_DIR instead of SYMROOT.

3:03 PM Changeset in webkit [9174] by adele

• 5 edits in trunk

Tests:

Changes by Darin. Reviewed by myself.

Added new layoutTestController method to dump the document as text.

• DumpRenderTree/main.m: (-[LayoutTestController dumpAsText]): new method on layoutTestController to dump the innerText of the body instead of dumping the render tree; better for tests that are not really about layout (+[LayoutTestController isSelectorExcludedFromWebScript:]): added new dumpAsText selector (dump): changed name of showRenderTree since it now sometimes dumps text instead (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): calls new dump function (-[LayoutTestController notifyDone]): calls new dump function (dumpRenderTree): initializes global variables dumpAsText and waitLayoutTest

WebCore:

Changes by Darin. Reviewed by myself.

Changed the Render Tree debug code to write out an indication that the affinity is upstream
when writing out caret position. Updated the one layout test with output affected by the change.
Also updated one test to use the new dumpAsText method in dumpRenderTree.

• kwq/KWQRenderTreeDebug.cpp: (writeSelection): writes out affinity if it's upstream in the caret case
• layout-tests/editing/style/create-block-for-style-004-expected.txt: new results that contain the affinity
• layout-tests/fast/js/char-at.html: now calls layoutController.dumpAsText()
• layout-tests/fast/js/char-at-expected.txt: plain text result (replaces old render tree result)

12:19 PM Changeset in webkit [9173] by darin

• 14 edits in trunk/WebCore

Reviewed by Adele.

• fixed issues preventing us from compiling with newer versions of gcc 4.0

• khtml/dom/dom2_events.cpp: Add definitions of some static data member constants, as required by the C++ standard and the gcc 4.0 compiler.

• khtml/editing/selection.h: Specified KHTMLPart friend class as ::KHTMLPart, since if it's not explicitly qualified, it means DOM::KHTMLPart.

• khtml/dom/dom_string.cpp: (DOM::strcasecmp): Removed redundant and illegal DOM:: prefix. (DOM::operator==): Ditto.
• khtml/ecma/kjs_binding.cpp: (KJS::getStringOrNull): Removed redundant and illegal KJS:: prefix. (KJS::ValueToVariant): Ditto.
• khtml/ecma/kjs_css.cpp: (KJS::getCSSRuleConstructor): Ditto. (KJS::getCSSValueConstructor): Ditto. (KJS::getCSSPrimitiveValueConstructor): Ditto.
• khtml/ecma/kjs_events.cpp: (KJS::getEventConstructor): Ditto. (KJS::getEventExceptionConstructor): Ditto. (KJS::getMutationEventConstructor): Ditto.
• khtml/ecma/kjs_traversal.cpp: (KJS::getNodeFilterConstructor): Ditto.

• khtml/misc/loader_client.h: Added an empty virtual destructor to CachedObjectClient to quiet the compiler. This doesn't really do any good, but also does no harm.
• khtml/misc/loader.cpp: (CachedObjectClient::~CachedObjectClient): Added.

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::fillBlockSelectionGaps): Initialize a couple of variables that should have been initialized to 0. Not just about making the compiler happy -- warning found a real bug!

• kwq/KWQTextArea.mm: (RangeOfParagraph): Change else structure to work around compiler warning bug.

11:57 AM Changeset in webkit [9172] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Adele.

• fixed issues preventing us from compiling with newer versions of gcc 4.0

• kjs/ustring.cpp: (KJS::operator==): Remove redundant and illegal KJS:: prefix on this function's definition. (KJS::operator<): Ditto. (KJS::compare): Ditto.