⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 7, 2005:

4:27 PM Changeset in webkit [10484] by ggaren
  • 1 edit
    2 adds in trunk

-added layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4781
Date.setMonth fails with big values due to overflow

Fix is in JavaScriptCore.

Test cases added:

  • layout-tests/fast/js/date-big-setmonth-expected.txt: Added.
  • layout-tests/fast/js/date-big-setmonth.html: Added.
4:27 PM Changeset in webkit [10483] by ggaren
  • 2 edits in trunk/JavaScriptCore

-fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4781
Date.setMonth fails with big values due to overflow

Reviewed by darin.

  • kjs/date_object.cpp: (timetUsingCF): for consistency, changed return statement to invalidDate instead of LONG_MAX (KJS::fillStructuresUsingTimeArgs): modified for readability (KJS::fillStructuresUsingDateArgs): new function analogous to fillStructuresUsingTimeArgs (KJS::DateProtoFuncImp::callAsFunction): modified to use fillStructuresUsingDateArgs (KJS::DateObjectImp::construct): moved variable declaration to proper scope (KJS::DateObjectFuncImp::callAsFunction): moved variable declaration to proper scope
3:08 PM Changeset in webkit [10482] by ggaren
  • 2 edits in trunk/JavaScriptCore

-updated expected test results to reflect fix for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4698
kjs does not allow named functions in function expressions

  • tests/mozilla/expected.html:
11:10 AM Changeset in webkit [10481] by vicki
  • 2 edits
    1 add
    1 delete in trunk/WebCore

Reviewed by Justin.

  • fix <rdar://problem/4246096> REGRESSION links to named anchors don't scroll to the right place (4825)

This is really just a better fix for 4233844. Also consolidated manual-tests/scrollToAnchorWithNewline.html
and the test case from Bugzilla bug 4825 into manual-tests/scrollToAnchor.html.

Test cases added:

  • manual-tests/scrollToAnchor.html: Added.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getUpperLeftCorner): when calculating scroll position, skip child nodes of the anchor if they do not have text boxes.
1:00 AM Changeset in webkit [10480] by eseidel
  • 5 edits in trunk/WebCore

Bug #: 4868
Submitted by: Tobias Lidskog <​tobiaslidskog@mac.com>
Reviewed by: eseidel

  • kcanvas/KCanvasCreator.cpp: (KCanvasCreator::createCanvasPathData):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::contextForImage):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::~SVGDocumentImpl): Fixed several leaks. ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4868

Sep 6, 2005:

7:38 PM Changeset in webkit [10479] by darin
  • 4 edits in trunk/WebCore

Reviewed by John Sullivan.

  • fixed storage leaks; one of the leaks caused these 3 bugs:

<rdar://problem/4231952> leaks of DOMStringImpl called from HTMLTokenizer::processToken, seen running WebKit tests
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4797>

<rdar://problem/4233800> leak inside DOM::DocumentImpl::DocumentImpl, seen running webkit tests
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4795>

<rdar://problem/4232812> leaks of NodeImpl called from HTMLParser::textCreateErrorCheck, seen running webkit tests
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4796>

  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML): Put ref/deref around call to replaceChild to avoid leaking the node being replaced. (HTMLElementImpl::setOuterText): Put ref/deref around call to replaceChild to avoid leaking the node being replaced. Also changed removeChild calls to use remove instead, both for simplicity and to fix the leak without having to add a SharedPtr or ref/deref pair.
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::setCaption): Put ref/deref around call to replaceChild to avoid leaking the node being replaced. (DOM::HTMLTableElementImpl::setTHead): Ditto. (DOM::HTMLTableElementImpl::setTFoot): Ditto. (DOM::HTMLTableElementImpl::setTBody): Tweaked a bit to match the other functions as closely as possible. No leak here.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::remove): Added ref/deref to avoid leaking the node being removed. (DOM::NodeImpl::normalize): Changed two calls to removeChild to calls to remove to prevent leaks.
6:21 PM Changeset in webkit [12194] by ggaren
  • 1 edit
    3 adds
    1 delete in trunk/JavaScriptGlue

-upgraded project files to XCode 2.1

  • JavaScriptGlue.pbproj/project.pbxproj: Removed.
  • JavaScriptGlue.xcodeproj/.cvsignore: Added.
  • JavaScriptGlue.xcodeproj/project.pbxproj: Added.
4:53 PM Changeset in webkit [10478] by justing
  • 2 edits
    2 adds in trunk

Reviewed by harrison

Fixes <rdar://problem/3976872> REGRESSION (Mail): Pasted lines of plain text don't get the proper style if pasted into newlines

For style matched paste, style information was gathered incorrectly.

Test cases added:

  • layout-tests/editing/pasteboard/3976872-expected.txt: Added.
  • layout-tests/editing/pasteboard/3976872.html: Added.
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::doApply): Even though the startBlock (selection.start().node()->enclosingBlockFlowElement) is where manipulation begins on a paste, it can be missing necessary style information.
4:46 PM Changeset in webkit [10477] by ggaren
  • 2 edits in trunk/WebKit
  • fixed build bustage from last checkin.

Reviewed by haytt.

  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList pageCacheSize]): updated debug printf since we no longer have a variable called 'multiplier'
2:40 PM Changeset in webkit [10476] by hyatt
  • 3 edits in trunk/WebKit

Reduce the # of cached pages for a back/forward list. The old cache would cache the
following per tab:

1gb memory = 16 pages per tab/window
512mb memory = 8 pages per tab/window

<= 512mb memory = 4 pages per tab/window

This consumes far too much memory and is way too aggressive. The new cache sizes are
as follows:

1gb memory = 3 pages per tab/window

512mb memory = 2 pages per tab/window

< 512mb memory = 1 page per tab/window

Reviewed by john

  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList pageCacheSize]):
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):
3:19 AM Changeset in webkit [10475] by eseidel
  • 220 edits in trunk

Bug #: 4864
Submitted by: Tobias Lidskog <​tobiaslidskog@mac.com>
Reviewed by: eseidel

Don't create empty fill/stroke servers if fill/stroke
are specified as "none".
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4864

Test cases updated:

  • svg-tests/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/coords-units-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/filters-color-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/linkingCircle-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/linkingToc-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/paths-data-04-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/rects-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/rects_b-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/text-align-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/text-align-02-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/text-align-03-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/text-intro-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/text-tref-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/text-ws-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/toc-sv-expected.txt:
  • svg-tests/W3C-SVG-1.1/Resources/toc-svcmp-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/color-prop-02-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/coords-units-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/interact-order-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/linking-a-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/linking-a-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/linking-a-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • svg-tests/W3C-SVG-1.1/paths-data-04-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/paths-data-07-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/render-elems-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/render-elems-02-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/render-elems-03-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-group-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-group-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-intro-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-intro-02-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-intro-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-intro-04-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg-tests/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::updateFill): (KCanvasRenderingStyle::updateStroke):
2:18 AM Changeset in webkit [12193] by mjs
  • 3 edits in branches/Safari-2-0-branch/JavaScriptGlue

Reviewed by John.

  • fixed <rdar://problem/4234146> Denver Regression: for (x in y) broken in JavaScriptGlue (could cause crash)
  • UserObjectImp.cpp: (UserObjectImp::hasOwnProperty): Renamed from hasProperty and implemented in a lower-level way, to avoid relying on get.
  • UserObjectImp.h:
2:18 AM Changeset in webkit [12192]
  • 1 copy in branches/Safari-2-0-branch/JavaScriptGlue

This commit was manufactured by cvs2svn to create branch
'Safari-2-0-branch'.

1:10 AM Changeset in webkit [12191] by mjs
  • 21 adds in trunk/JavaScriptGlue

Rubber stamped by hyatt.

  • initial import of JavaScriptGlue into our repository
  • English.lproj/InfoPlist.strings: Added.
  • JSBase.cpp: Added. (JSBase::JSBase): (JSBase::~JSBase): (JSBase::Retain): (JSBase::Release): (JSBase::RetainCount): (JSBase::GetTypeID): (JSBase::CopyDescription): (JSBase::Equal):
  • JSBase.h: Added.
  • JSObject.cpp: Added. (JSUserObject::JSUserObject): (JSUserObject::~JSUserObject): (JSUserObject::CopyPropertyNames): (JSUserObject::CopyProperty): (JSUserObject::SetProperty): (JSUserObject::ImplementsCall): (JSUserObject::CallFunction): (JSUserObject::CopyCFValue): (JSUserObject::Equal): (JSUserObject::Mark): (JSUserObject::GetData):
  • JSObject.h: Added. (JSUserObject::DataType):
  • JSRun.cpp: Added. (JSRun::JSRun): (JSRun::~JSRun): (JSRun::Flags): (JSRun::GetSource): (JSRun::GlobalObject): (JSRun::GetInterpreter): (JSRun::Evaluate): (JSRun::CheckSyntax):
  • JSRun.h: Added. (JSInterpreter::JSInterpreter): (JSInterpreter::JSInterpreter::~JSInterpreter): (JSInterpreter::Flags):
  • JSUtils.cpp: Added. (CFStringToUString): (UStringToCFString): (CFStringToIdentifier): (IdentifierToCFString): (KJSValueToJSObject): (JSObjectKJSValue): (KJSValueToCFTypeInternal): (KJSValueToCFType): (GetCFNull):
  • JSUtils.h: Added. (RetainCFType): (ReleaseCFType):
  • JSValueWrapper.cpp: Added. (JSValueWrapper::JSValueWrapper): (JSValueWrapper::~JSValueWrapper): (JSValueWrapper::GetValue): (JSValueWrapper::GetExecState): (JSValueWrapper::GetJSObectCallBacks): (JSValueWrapper::JSObjectDispose): (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectCopyCFValue): (JSValueWrapper::JSObjectMark):
  • JSValueWrapper.h: Added.
  • JavaScriptGlue.cpp: Added. (JSSetCFNull): (JSGetCFNull): (JSRetain): (JSRelease): (JSCopyDescription): (JSEqual): (JSGetTypeID): (JSGetRetainCount): (JSObjectCreate): (JSObjectCreateInternal): (JSObjectCopyCFValue): (JSObjectGetData): (JSObjectCopyProperty): (JSObjectSetProperty): (JSObjectCallFunction): (JSRunCreate): (JSRunCopySource): (JSRunCopyGlobalObject): (JSRunEvaluate): (JSRunCheckSyntax): (JSCollect): (JSTypeGetCFArrayCallBacks): (JSCFRetain): (JSCFRelease): (JSObjectCreateWithCFType): (CFJSObjectDispose): (JSObjectCopyPropertyNames): (CFJSObjectCopyProperty): (CFJSObjectSetProperty): (CFJSObjectCopyCFValue): (CFJSObjectEqual): (CFJSObjectCopyPropertyNames): (JSCreateCFArrayFromJSArray): (JSCreateJSArrayFromCFArray): (JSLockInterpreter): (JSUnlockInterpreter):
  • JavaScriptGlue.exp: Added.
  • JavaScriptGlue.h: Added.
  • JavaScriptGlue.pbproj/project.pbxproj: Added.
  • UserObjectImp.cpp: Added. (UserObjectPrototypeImp::UserObjectPrototypeImp): (UserObjectPrototypeImp::GlobalUserObjectPrototypeImp): (UserObjectImp::UserObjectImp): (UserObjectImp::~UserObjectImp): (UserObjectImp::classInfo): (UserObjectImp::implementsCall): (UserObjectImp::call): (UserObjectImp::propList): (UserObjectImp::hasProperty): (UserObjectImp::get): (UserObjectImp::put): (UserObjectImp::GetJSUserObject): (UserObjectImp::toPrimitive): (UserObjectImp::toBoolean): (UserObjectImp::toNumber): (UserObjectImp::toString): (UserObjectImp::mark):
  • UserObjectImp.h: Added.

Sep 5, 2005:

4:12 PM Changeset in webkit [10474] by darin
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Carbon.subproj/HIWebView.m: Remove lots of unneeded declarations of private stuff. (Draw): Call WKNSWindowOverrideCGContext and WKNSWindowRestoreCGContext rather than calling a non-existent setCGContext: method on the context.
4:10 PM Changeset in webkit [10473] by darin
  • 2 edits
    2 adds in trunk

Reviewed by John Sullivan.

Test cases added:

  • layout-tests/fast/dom/Window/window-remove-event-listener.html: Added.
  • layout-tests/fast/dom/Window/window-remove-event-listener-expected.txt: Added.
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Fixed typo where window.removeEventListener would call addEventListener!
3:41 PM Changeset in webkit [10472] by darin
  • 4 edits in trunk

Reviewed by John Sullivan.

  • khtml/xml/dom_docimpl.cpp: (qualifiedNameIsValid): Added. (qualifiedNameIsMalformed): Added. (DOMImplementationImpl::createDocumentType): Added checks and exceptions using above functions. (DOMImplementationImpl::createDocument): Ditto.
  • layout-tests/dom/html/level2/core/createDocument08-expected.txt: Updated to expect success.
  • layout-tests/dom/html/level2/core/createDocumentType04-expected.txt: Ditto.
3:26 PM Changeset in webkit [10471] by sullivan
  • 4 edits in trunk

WebCore:

Reviewed by Dave Hyatt.

Test cases added: none, doesn't affect layout

  • fixed <rdar://problem/4211999> Safari quits when click-drag-hold an image that is set to automatically change.
  • khtml/khtmlview.cpp: (KHTMLView::updateDragAndDrop): add missing nil check

WebKit:

Reviewed by Dave Hyatt.

  • change related to <rdar://problem/4211999> Safari quits when click-drag-hold an image that is set to automatically change.
  • WebView.subproj/WebHTMLView.m: (-[NSArray namesOfPromisedFilesDroppedAtDestination:]): handle nil wrapper with ERROR and early return rather than ASSERT, since we now know of a way to reproduce this (written up as 4244861)
3:22 PM Changeset in webkit [10470] by darin
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • WebCoreSupport.subproj/WebImageData.m: (removeAnimatingRendererFromView): Added. (removeFromDictionary): Added. (-[WebImageData removeAnimatingRenderer:]): Rewrote using CF functions rather than NS functions so that we never retain the views, since this can be called from a view's dealloc method. (setNeedsDisplayInAnimationRect): Added. (-[WebImageData _nextFrame:]): Rewrote as above, even though in this case it can't be called from the dealloc method.
1:25 PM Changeset in webkit [10469] by darin
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • kwq/KWQTextField.mm: (-[KWQTextFieldController textView:shouldChangeTextInRange:replacementString:]): Allow a replacement string of nil.
10:18 AM Changeset in webkit [10468] by darin
  • 1 edit
    2 adds in trunk

Reviewed and landed by Darin.

  • added a test case that covers 8-digit hexadecimal entities
  • layout-tests/fast/parser/hex-entities-length.html: Added.
  • layout-tests/fast/parser/hex-entities-length-expected.txt: Added.

Sep 4, 2005:

9:01 PM Changeset in webkit [10467] by darin
  • 3 edits in trunk/WebCore

Reviewed by John Sullivan.

  • khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::paint): Don't try to paint if painting is disabled.
  • kwq/KWQPainter.mm: (QPainter::addClip): Do nothing if painting is disabled. (QPainter::addRoundedRectClip): Ditto. (QPainter::currentContext): Assert that painting is not disabled. (QPainter::beginTransparencyLayer): Do nothing if painting is disabled. (QPainter::endTransparencyLayer): Ditto. (QPainter::setShadow): Ditto. (QPainter::clearShadow): Ditto. (QPainter::initFocusRing): Ditto. (QPainter::addFocusRingRect): Ditto. (QPainter::drawFocusRing): Ditto.
8:43 PM Changeset in webkit [10466] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by John Sullivan.

Test cases added:

  • manual-tests/input-type-text-unconfirmed-inline-input.html: Added.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController controlTextDidBeginEditing:]): Call setWantsNotificationForMarkedText:YES on the field editor so we get "text did change" calls even for changes to the marked text. (-[KWQTextFieldController controlTextDidChange:]): Only call the bridge when we have changes and there is no marked text -- this is good because the bridge is used to implement form auto-fill and preserves the existing behavior. A more elegant future fix would be to notify the bridge more often and have the auto-fill code itself implement the "don't auto-fill when there is marked text" rule. (-[NSTextField _KWQ_currentEditor]): Change type to NSTextView so we can use this function to code NSTextView-specific stuff. The field editors are always subclasses of NSTextView.
2:38 PM Changeset in webkit [10465] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/identifier.cpp: Fix comment, add missing include. (Follow-on to changes from yesterday.)
1:56 PM Changeset in webkit [10464] by darin
  • 1 edit
    2 adds in trunk
  • added a layout test from Bugzilla for a bug that was fixed a while back
  • layout-tests/fast/parser/script-tag-with-trailing-slash-expected.txt: Added.
  • layout-tests/fast/parser/script-tag-with-trailing-slash.html: Added.
12:53 PM Changeset in webkit [10463] by darin
  • 3 edits in trunk/WebKitLibraries
  • WebKitSystemInterface.h: Update to latest
  • libWebKitSystemInterface.a: Ditto.
2:55 AM Changeset in webkit [10462] by darin
  • 3 edits in trunk/WebCore
  • temporarily disable LEAKS messages that are giving too many false positives we'll turn these back on again once we get them to really mean something.
  • khtml/xml/dom_elementimpl.cpp: (ElementImplCounter::~ElementImplCounter): Commented out the code to fprintf.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImplCounter::~NodeImplCounter): Ditto.
2:22 AM Changeset in webkit [10461] by eseidel
  • 2 edits
    1 delete in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none

No review needed, only affects SVG, removing unused files.

  • WebCore.xcodeproj/project.pbxproj: removed ksvg2/Scripts group.
  • ksvg2/scripts/ksvgstatus.xsl: Removed.
  • ksvg2/scripts/regressiontest.sh: Removed.
  • ksvg2/scripts/regressiontestsetup.sh: Removed.
2:10 AM Changeset in webkit [10460] by eseidel
  • 3 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: none

No review needed, only affects SVG, only replacing line endings.

  • ksvg2/svg/SVGFEBlendElementImpl.h: CRLF -> LF
  • ksvg2/svg/SVGFEFloodElementImpl.h: CRLF -> LF Fixed two files with windows line endings.
1:23 AM Changeset in webkit [10459] by darin
  • 2 edits in trunk/WebCore
  • fixed the build
  • khtml/rendering/break_lines.cpp: Added missing include of <qstring.h>.
12:42 AM Changeset in webkit [10458] by darin
  • 5 edits in trunk/WebCore

Reviewed and landed by Darin.

No test cases added because this is a performance fix. Existing test cases continue to work.

  • khtml/rendering/break_lines.h: Declare the new nextBreakablePosition and also define a new isBreakable function that adds an in/out "next breakable position" parameter.
  • khtml/rendering/break_lines.cpp: (khtml::nextBreakablePosition): Replaced the old isBreakable with this function.
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): Call the new version of isBreakable that uses the previously-found "next breakable" position until we pass it rather than analyzing each position separately to see if we can break there.
  • khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth): Call the new isBreakable, and also do some things to streamline and perhaps speed up: a) use an index withing the string rather than within the word when finding a word break, b) use a cached copy of the string base pointer and the string length rather than repeatedly dereferencing str, c) use a cached copy of the current character rather than repeatedly fetching it. Darin also changed one confusing use of ? : to just use && instead.
Note: See TracTimeline for information about the timeline view.