⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 5, 2006:

11:38 PM Changeset in webkit [13163] by ggaren
  • 2 edits in trunk/LayoutTests
  • Checked in new results for the test I just landed. Looks like I landed an old copy.
  • fast/dom/prototype-chain-expected.txt:
11:23 PM Changeset in webkit [13162] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo.

11:22 PM Changeset in webkit [13161] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix failure seen running editing layout tests
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Use selectNodeContents instead of rolling our own. It handles the "nothing at all" edget case properly.
11:18 PM Changeset in webkit [13160] by eseidel
  • 3 edits in trunk/WebCore

2006-03-05 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Make updateContents invalidate entire window for now.
Fix indentation in fileLoadTimer.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateContents):
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer):
10:26 PM Changeset in webkit [13159] by eseidel
  • 17 edits in trunk/WebCore

2006-03-05 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

Add missing files to vcproj (fix win32 build).
Also add svn:eol-style=native to new files.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
10:06 PM Changeset in webkit [13158] by darin
  • 2 edits in trunk/JavaScriptCore
9:55 PM Changeset in webkit [13157] by darin
  • 2 edits in trunk/WebCore
  • fix build
  • rendering/render_style.h: (compareEqual): Made it inline, fixed variable name.
9:52 PM Changeset in webkit [13156] by adele
  • 12 edits
    6 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6987
Implement maxlength for new text fields

  • fast/forms/input-appearance-maxlength-expected.txt: Added.
  • fast/forms/input-appearance-maxlength.html: Added.

WebCore:

Reviewed by Darin.

Test added:

  • fast/forms/input-appearance-maxlength.html
  • WebCore.xcodeproj/project.pbxproj: Added BeforeTextInsertedEventImpl.h, BeforeTextInsertedEventImpl.cpp, HTMLTextFieldInnerElementImpl.h, and HTMLTextFieldInnerElementImpl.cpp
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::init): initialize max length to 1024. (WebCore::HTMLInputElementImpl::defaultEventHandler): Added case to use the khtmlBeforeTextInsertedEvent to check for maxlength. (WebCore::HTMLInputElementImpl::parseMappedAttribute): Makes sure that maxlength is between 0 and 1024.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): After doing a test insert of the fragment, Send khtmlBeforeTextInsertedEvent to the root editable element so the event handler can update the text, and we can update the fragment.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Send khtmlBeforeTextInsertedEvent to the root editable element so the event handler can update the text if necessary.
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): If we've just applied a command, send the khtmlTextInsertedEvent to the root editable element. (WebCore::EditCommand::unapply): ditto. (WebCore::EditCommand::reapply): ditto.
  • khtml/html/HTMLTextFieldInnerElementImpl.h: Added this class to store a pointer to the input element for the text field and to handle default events. (DOM::HTMLTextFieldInnerElementImpl::shadowParentNode): Added. (DOM::HTMLTextFieldInnerElementImpl::setShadowParentNode): Added.
  • khtml/html/HTMLTextFieldInnerElementImpl.cpp: Added. (WebCore::HTMLTextFieldInnerElementImpl::HTMLTextFieldInnerElementImpl): (WebCore::HTMLTextFieldInnerElementImpl::~HTMLTextFieldInnerElementImpl): (WebCore::HTMLTextFieldInnerElementImpl::defaultEventHandler): Sends khtmlBeforeTextInsertedEvents to the shadowParentNode, and handles khtmlTextInsertedEvents by telling the renderer that the subtree has changed.
  • rendering/RenderTextField.cpp: Removed InputMutationListener since subtreeHasChanged is now called from the editing code. (WebCore::RenderTextField::~RenderTextField): removed event listener code. (WebCore::RenderTextField::updateFromElement): ditto. And creates HTMLTextFieldInnerElementImpl. (WebCore::RenderTextField::subtreeHasChanged): calls new text() method. (WebCore::RenderTextField::text): created to get a String of all text in the RenderTextField.
  • rendering/RenderTextField.h: Removed InputMutationListener class.
  • dom/EventNames.h: Added khtmlTextInserted and khtmlBeforeTextInserted.
  • dom/BeforeTextInsertedEventImpl.cpp: Added. (WebCore::BeforeTextInsertedEventImpl::BeforeTextInsertedEventImpl):
  • dom/BeforeTextInsertedEventImpl.h: Added. (WebCore::BeforeTextInsertedEventImpl::isBeforeTextInsertedEvent): (WebCore::BeforeTextInsertedEventImpl::text):
  • dom/dom2_eventsimpl.cpp: (WebCore::EventImpl::isBeforeTextInsertedEvent): Added.
  • dom/dom2_eventsimpl.h: Added isBeforeTextInsertedEvent.
9:47 PM Changeset in webkit [13155] by mjs
  • 2 edits in trunk/WebCore
  • fix build, give this a return type.
  • rendering/render_style.h: (compareEqual):
9:32 PM Changeset in webkit [13154] by ap
  • 2 edits in trunk/JavaScriptCore

Fix by Mitz Pettel and Alexey Proskuryakov, reviewed by Maciej and Hyatt.


  • kxmlcore/Platform.h: Corrected the define to enable USE(MULTIPLE_THREADS) on Mac OS X.
9:29 PM Changeset in webkit [13153] by darin
  • 6 edits
    2 copies in trunk/JavaScriptCore

Reviewed by Maciej.

  • kjs/Parser.cpp: Added.
  • kjs/Parser.h: Added.
  • kjs/internal.cpp: Removed the Parser class.
  • kjs/internal.h: Ditto. Also removed unnecessary declarations of classes not used in this header.
  • kjs/nodes.h: Added an include of "Parser.h".
  • kjs/function.h: Added a declaration of FunctionBodyNode.
8:56 PM Changeset in webkit [13152] by eseidel
  • 2 edits in trunk/WebCore

2006-03-05 Eric Seidel <​eseidel@apple.com>

Add "Font.h" to (try to) fix the no-svg build.

  • platform/mac/GraphicsContextMac.mm:
8:55 PM Changeset in webkit [13151] by mjs
  • 2 edits in trunk/WebCore

Rubber stamped by Darin.

  • fix win32 build by avoiding use of typeof
  • rendering/render_style.h: (compareEqual):
7:58 PM Changeset in webkit [13150] by ggaren
  • 21 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • JSC support for the fix for <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties
  • kjs/lookup.h: (1) Added the KJS_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro. The class definiton macro needs to know about the prototype's prototype so that the class constructor properly sets it. (2) Removed the KJS_IMPLEMENT_PROTOTYPE_WITH_PARENT macro. The class implementation macro does not need to know about the prototype's prototype, since getOwnPropertySlot should only look in the current object's property map, and not its prototype's.

LayoutTests:

Reviewed by Maciej.

  • Layout test for <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties
  • fast/dom/prototype-chain-expected.txt: Added.
  • fast/dom/prototype-chain.html: Added.

WebCore:

Reviewed by Maciej.

  • Second cut at fixing <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties


The approach here is for prototypes, in their constructor methods,
to set their own prototypes, preserving the prototype
chain in cases of multiple levels of inheritance. (Previously, our
code assumed that a prototype never had a prototype of its own,
and always used an empty object as a prototype's prototype).

  • bindings/scripts/CodeGeneratorJS.pm: Use the new DEFINE_PROTOTYPE_WITH_PROTOTYPE macro in place of the KJS_IMPLEMENT_PROTOTYPE_WITH_PARENT macro.
  • khtml/ecma/kjs_dom.cpp: Ditto.
  • khtml/ecma/kjs_dom.h: Ditto.
  • khtml/ecma/kjs_events.cpp: Ditto.

Touched these files to force a rebuild:

  • bindings/js/JSDOMCore.cpp:
  • bindings/js/JSDOMEvents.cpp:
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Entity.idl:
  • dom/MutationEvent.idl:
  • dom/Notation.idl:
  • dom/ProcessingInstruction.idl:
  • dom/Text.idl:
  • dom/WheelEvent.idl:
6:53 PM Changeset in webkit [13149] by mjs
  • 40 edits in trunk/WebCore

Reviewed by Darin.

  • css/css_base.cpp: (WebCore::CSSSelector::operator == ): (WebCore::CSSSelector::selectorText):
  • css/css_base.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::pseudoType): (WebCore::CSSSelector::relation):
  • css/css_grammar.y:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector):
  • kcanvas/KCanvasPath.cpp: (WebCore::operator<<):
  • kcanvas/KCanvasPath.h: (WebCore::KCClipData::windRule): (WebCore::KCClipDataList::addPath):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip):
  • khtml/ecma/kjs_html.h:
  • khtml/html/HTMLButtonElementImpl.h:
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setInputType):
  • khtml/html/HTMLInputElementImpl.h: (DOM::HTMLInputElementImpl::inputType):
  • khtml/html/html_tableimpl.h:
  • khtml/xbl/xbl_protohandler.cpp: (XBL::m_button):
  • khtml/xbl/xbl_protohandler.h:
  • ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::): (WebCore::SVGRenderStyle::NonInheritedFlags::): (WebCore::SVGRenderStyle::setBitDefaults):
  • ksvg2/svg/SVGAnimateTransformElementImpl.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::targetAttribute): (SVGAnimationElementImpl::setTargetAttribute):
  • ksvg2/svg/SVGAnimationElementImpl.h:
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value):
  • ksvg2/svg/SVGLengthImpl.h:
  • kwq/KWQKHTMLSettings.h:
  • loader/CachedImage.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::setCachePolicy): (WebCore::DocLoader::setShowAnimations):
  • loader/DocLoader.h: (WebCore::DocLoader::showAnimations):
  • platform/FontDescription.h: (WebCore::FontDescription::genericFamily):
  • platform/QString.cpp: (HandleNode::):
  • platform/QString.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::leftBottom): (WebCore::RenderBlock::rightBottom): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::addIntrudingFloats):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::selectionState): (WebCore::RenderBlock::FloatingObject::FloatingObject): (WebCore::RenderBlock::FloatingObject::type):
  • rendering/RenderTable.h: (WebCore::RenderTable::getRules):
  • rendering/bidi.cpp: (khtml::BidiContext::BidiContext): (khtml::operator==): (khtml::embed): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::RenderBlock::layoutInlineChildren):
  • rendering/bidi.h: (khtml::BidiContext::dir): (khtml::BidiContext::basicDir): (khtml::BidiRun::BidiRun):
  • rendering/render_canvasimage.h:
  • rendering/render_layer.h: (WebCore::Marquee::whiteSpace):
  • rendering/render_object.cpp: (WebCore::RenderObject::paintBorderImage):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::setSelectionState):
  • rendering/render_replaced.h: (WebCore::RenderReplaced::selectionState):
  • rendering/render_style.cpp: (WebCore::RenderStyle::getPseudoStyle):
  • rendering/render_style.h: (khtml::BorderValue::BorderValue): (khtml::BorderValue::style): (khtml::BorderValue::nonZero): (khtml::BorderValue::operator==): (khtml::OutlineValue::operator==): (khtml::CollapsedBorderValue::style): (khtml::BorderImage::horizontalRule): (khtml::BorderImage::verticalRule): (khtml::BorderData::borderLeftWidth): (khtml::BorderData::borderRightWidth): (khtml::BorderData::borderTopWidth): (khtml::BorderData::borderBottomWidth): (khtml::BackgroundLayer::backgroundClip): (khtml::BackgroundLayer::backgroundOrigin): (khtml::BackgroundLayer::backgroundRepeat): (khtml::RenderStyle::styleType): (khtml::RenderStyle::display): (khtml::RenderStyle::originalDisplay): (khtml::RenderStyle::position): (khtml::RenderStyle::floating): (khtml::RenderStyle::borderLeftStyle): (khtml::RenderStyle::borderLeftColor): (khtml::RenderStyle::borderRightStyle): (khtml::RenderStyle::borderRightColor): (khtml::RenderStyle::borderTopStyle): (khtml::RenderStyle::borderTopColor): (khtml::RenderStyle::borderBottomStyle): (khtml::RenderStyle::borderBottomColor): (khtml::RenderStyle::outlineWidth): (khtml::RenderStyle::outlineStyle): (khtml::RenderStyle::overflow): (khtml::RenderStyle::visibility): (khtml::RenderStyle::verticalAlign): (khtml::RenderStyle::unicodeBidi): (khtml::RenderStyle::clear): (khtml::RenderStyle::tableLayout): (khtml::RenderStyle::textAlign): (khtml::RenderStyle::textTransform): (khtml::RenderStyle::direction): (khtml::RenderStyle::whiteSpace): (khtml::RenderStyle::backgroundRepeat): (khtml::RenderStyle::backgroundClip): (khtml::RenderStyle::backgroundOrigin): (khtml::RenderStyle::emptyCells): (khtml::RenderStyle::captionSide): (khtml::RenderStyle::listStyleType): (khtml::RenderStyle::listStylePosition): (khtml::RenderStyle::cursor): (khtml::RenderStyle::pageBreakInside): (khtml::RenderStyle::pageBreakBefore): (khtml::RenderStyle::pageBreakAfter): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::appearance): (khtml::RenderStyle::boxAlign): (khtml::RenderStyle::boxDirection): (khtml::RenderStyle::boxLines): (khtml::RenderStyle::boxOrient): (khtml::RenderStyle::boxPack): (khtml::RenderStyle::boxSizing): (khtml::RenderStyle::marqueeBehavior): (khtml::RenderStyle::marqueeDirection): (khtml::RenderStyle::userModify): (khtml::RenderStyle::userDrag): (khtml::RenderStyle::userSelect): (khtml::RenderStyle::marginTopCollapse): (khtml::RenderStyle::marginBottomCollapse): (khtml::RenderStyle::wordWrap): (khtml::RenderStyle::nbspMode): (khtml::RenderStyle::khtmlLineBreak): (khtml::RenderStyle::matchNearestMailBlockquoteColor): (khtml::RenderStyle::setBorderLeftWidth): (khtml::RenderStyle::setBorderLeftStyle): (khtml::RenderStyle::setBorderLeftColor): (khtml::RenderStyle::setBorderRightWidth): (khtml::RenderStyle::setBorderRightStyle): (khtml::RenderStyle::setBorderRightColor): (khtml::RenderStyle::setBorderTopWidth): (khtml::RenderStyle::setBorderTopStyle): (khtml::RenderStyle::setBorderTopColor): (khtml::RenderStyle::setBorderBottomWidth): (khtml::RenderStyle::setBorderBottomStyle): (khtml::RenderStyle::setBorderBottomColor): (khtml::RenderStyle::setOutlineWidth): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::pseudoState):
12:36 PM Changeset in webkit [13148] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Fix a couple of things found while testing. Script now works (after landing my two pending patches).
12:25 PM Changeset in webkit [13147] by ggaren
  • 2 edits in trunk/WebCore
  • Rolled out the fix for <rdar://problem/4467143> because it's the wrong approach. Maciej and I discussed this on IRC.
  • khtml/ecma/kjs_dom.cpp: (KJS::): Don't use classInfo to express prototype inheritance. classInfo is only for representing a c++ superclass relationship.
11:59 AM Changeset in webkit [13146] by darin
  • 1 edit
    1 add in trunk/WebKitTools
  • check in a script to do a "big" rename in WebCore (can be run whenever we're ready to do it)
  • Scripts/do-webcore-rename: Added.
9:11 AM Changeset in webkit [13145] by eseidel
  • 2 edits in trunk/WebCore

2006-03-05 Eric Seidel <​eseidel@apple.com>

Move improperly placed #endif causing no-svg build to fail.

  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
6:36 AM Changeset in webkit [13144] by lypanov
  • 1 edit
    6 adds in trunk/LayoutTests

2006-03-05 Alexander Kellett <​lypanov@kde.org>

Reviewed by Eric.

  • missing results from previous commit
  • svg/custom/polyline-invalid-points-expected.checksum: Added.
  • svg/custom/polyline-invalid-points-expected.png: Added.
  • svg/custom/polyline-invalid-points-expected.txt: Added.
  • svg/custom/polyline-setattribute-points-null-expected.checksum: Added.
  • svg/custom/polyline-setattribute-points-null-expected.png: Added.
  • svg/custom/polyline-setattribute-points-null-expected.txt: Added.
6:33 AM Changeset in webkit [13143] by lypanov
  • 3 edits
    2 adds in trunk

2006-03-05 Alexander Kellett <​lypanov@kde.org>

Reviewed by Eric.

  • svg/custom/polyline-invalid-points.svg: Added.
  • svg/custom/polyline-setattribute-points-null.svg: Added.

2006-03-05 Alexander Kellett <​lypanov@kde.org>

Reviewed by Eric.

  • new tests: svg/custom/polyline-setattribute-points-null.svg svg/custom/polyline-invalid-points.svg
  • ksvg2/svg/svgpathparser.cpp: (SVGPolyParser::parsePoints):
3:27 AM Changeset in webkit [13142] by mjs
  • 3 edits
    3 deletes in trunk/WebCore

Rubber stamped by Eric.

  • remove no longer used KDOMSettings and KSVGSettings
  • WebCore+SVG/KDOMSettings.cpp: Removed.
  • WebCore+SVG/KDOMSettings.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/KSVGSettings.h: Removed.
  • ksvg2/svg/SVGStyledElementImpl.cpp:
3:12 AM Changeset in webkit [13141] by mjs
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): Close file when done.
2:30 AM Changeset in webkit [13140] by eseidel
  • 2 edits in trunk/WebCore

2006-03-05 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

  • platform/Font.cpp: (WebCore::Font::update): remove extra ref causing large leak.
2:10 AM Changeset in webkit [13139] by ap
  • 5 edits
    4 adds in trunk

Fix by Mitz Pettel, reviewed by Darin.

WebKitTools:

  • DumpRenderTree/DumpRenderTree.m: (-[EventSendingController mouseMoveToX:Y:]): Pass the correct windowNumber in the event.

LayoutTests:

  • fast/css/hover-subselector-expected.txt: Updated results.
  • fast/css/hover-subselector.html: Changed to work with the new mechanism.
  • fast/events/event-sender-mouse-moved-expected.checksum: Added.
  • fast/events/event-sender-mouse-moved-expected.png: Added.
  • fast/events/event-sender-mouse-moved-expected.txt: Added.
  • fast/events/event-sender-mouse-moved.html: Added.
1:43 AM Changeset in webkit [13138] by ap
  • 3 edits in trunk/JavaScriptCore

Patch by Andrew Wellington, reviewed by Eric.


  • Remove unused breakpoint bool from StatementNodes. No test provided as there is no functionality change.
  • kjs/nodes.cpp: (StatementNode::StatementNode):
  • kjs/nodes.h:
1:42 AM Changeset in webkit [13137] by eseidel
  • 5 edits in trunk/WebKitTools

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Take advantage of new GraphicsContext constructor to implement double buffering to avoid tearing.
Disable background erase to avoid tearing.
Fix potential memory smasher from extra long urls.

  • Spinneret/Spinneret/Spinneret.cpp: (MyRegisterClass):
  • Spinneret/Spinneret/Spinneret.vcproj:
  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): (WebKit::WebFrame::paint):
  • Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance):
1:41 AM Changeset in webkit [13136] by eseidel
  • 9 edits in trunk/WebCore

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Re-work ImageViewer to use GraphicsContext.
Add GraphicsContext(cairo_t*) constructor to make double-buffering easier.
Add one more stub to prevent slashdot from crashing.
Also fixed win32 build after Font change.

  • Viewer.vcproj:
  • Viewer/ImageView.cpp:
  • platform/Color.h:
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext):
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL):
1:35 AM Changeset in webkit [13135] by ap
  • 6 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Darin.

  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameSetElementImpl::HTMLFrameSetElementImpl): Removed unused m_resizing flag.
  • khtml/html/html_baseimpl.h:
  • manual-tests/bugzilla-4840.html: Added.
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::viewportMouseMoveEvent): (WebCore::FrameView::viewportMouseReleaseEvent): (WebCore::FrameView::setResizingFrameSet): New method. When a resizing frameset is set, mouse move and mouse release events target it instead of hit-testing.
  • page/FrameView.h:
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::setResizing): Inform the FrameView that we are resizing (or not).

Mar 4, 2006:

9:51 PM Changeset in webkit [13134] by hyatt
  • 23 edits
    2 adds
    2 deletes in trunk/WebCore

Fix for bug 7586, eliminate QFontMetrics.

Reviewed by eric

  • WebCore.xcodeproj/project.pbxproj:
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
  • kwq/KWQFontMetrics.h: Removed.
  • kwq/KWQFontMetrics.mm: Removed.
  • platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::~Font): (WebCore::Font::update): (WebCore::Font::width):
  • platform/Font.h: (WebCore::Font::operator==): (WebCore::Font::width): (WebCore::Font::height):
  • platform/FontRenderer.h: Added. (WebCore::FontRenderer::isFixedPitch):
  • platform/GraphicsContext.h:
  • platform/mac/FontMac.mm: Added. (WebCore::m_renderer): (WebCore::FontRenderer::getWebCoreFont): (WebCore::FontRenderer::getRenderer): (WebCore::FontRenderer::determinePitch): (WebCore::FontRenderer::update): (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
  • platform/mac/GraphicsContextMac.mm:
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedMinMaxWidth):
  • rendering/RenderText.h:
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/bidi.cpp: (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::checkLinesForTextOverflow):
  • rendering/render_box.cpp: (WebCore::RenderBox::caretRect):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight): (WebCore::RenderFlow::caretRect):
  • rendering/render_image.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically):
  • rendering/render_list.cpp: (WebCore::toHebrew): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::baselinePosition): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/render_object.cpp: (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::baselinePosition):
  • rendering/render_object.h:
  • rendering/render_style.h:
4:33 PM Changeset in webkit [13133] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Hang WebView pointer off of HWND (gets rid of global hack).
Remove MessageBox displayed on url change.

  • Spinneret/Spinneret/Spinneret.cpp: (WndProc): (MyEditProc):
  • Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::createWebView): (WebKit::WebViewWndProc):
4:28 PM Changeset in webkit [13132] by eseidel
  • 2 edits in trunk/WebCore

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Add urlSelected stub, adjust font metrics, and fix view size/move bug.

  • platform/win/TemporaryLinkStubs.cpp: (MouseEvent::MouseEvent): (FrameWin::urlSelected): (QFontMetrics::height): (QFontMetrics::xHeight): (QFontMetrics::ascent): (QFontMetrics::descent): (ScrollView::resizeContents): (ScrollView::setContentsPos):
3:07 PM Changeset in webkit [13131] by thatcher
  • 2 edits in trunk/WebKit/WebInspector

Forgot to save these files before I commited my last change.

3:07 PM Changeset in webkit [13130] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

Automatically kill httpd if it appears to be already running.

  • Scripts/run-webkit-tests:
3:05 PM Changeset in webkit [13129] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Eric.

  • stop background image loads from crashing
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage):
  • fix termination condition on file load loop
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer):
2:57 PM Changeset in webkit [13128] by thatcher
  • 9 edits in trunk/WebKit

Reviewed by Darin.


<rdar://problem/4411822> wrong element shown in Inspector inspecting main image at apple.com
<rdar://problem/4411908> in the Web Inspector, state of disclosure triangles should be preserved after search
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6616
Bug 6616: Double-clicking on a search result seems broken
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6709
Bug 6709: TypeError: Value undefined (result of expression treeScrollbar.refresh) is not object.

Code clean up and move more code into JavaScript.
Removes a few unused ObjC methods.
Many search fixes. Reveals the focused node when exiting the search.
Shows a "No Selection" screen when there are no search results.
Shows a node count for the number of results.
Fixes a couple of TypeErrors that show on the console.
Uses the system selection color in the Style pane tables.

12:37 PM Changeset in webkit [13127] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • Fixed <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

No test case yet because this is a preliminary step toward enabling my
uber test case for DOM support, which will cover this.

  • khtml/ecma/kjs_dom.cpp: (KJS::): Make DOMNode's classinfo reflect inheritance from DOMNodeProto, so a for in enumeration can properly walk the inheritance chain.
  • khtml/ecma/kjs_html.cpp: (KJS::): Used a script to sort classInfo data alphbetically. (KJS::KJS::HTMLElement::classInfo): Ditto.
3:02 AM Changeset in webkit [13126] by mjs
  • 3 edits in trunk/WebKitTools

Reviewed by Eric.

  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): Improved local file loading.
2:58 AM Changeset in webkit [13125] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix mistake in TransferJob::start that made it cause a crash

on non-file URLs

  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start):
2:26 AM Changeset in webkit [13124] by mjs
  • 10 edits in trunk/WebCore

Reviewed by Eric.

  • WebCore.vcproj/WebCore/WebCore.vcproj: add TransferJobWin to build.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): Set autoLoadImages to true.
  • platform/TransferJob.cpp: (WebCore::TransferJob::TransferJob): Pass this to internal constructor, so windows version can initialize timer
  • platform/TransferJob.h:
  • platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal): On windows, prepare a timer for file loads.
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFloatImage): If passed-in context is null, use our built-in context (this is probably not the best, but should work for now).
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::issueRedoCommand): Don't break. (WebCore::TransferJob::assembleResponseHeaders): ditto (FrameWin::saveDocumentState): ditto (FrameWin::clearUndoRedoOperations): ditto
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobInternal::~TransferJobInternal): Close file handle if we have one. (WebCore::TransferJob::~TransferJob): Empty. (WebCore::TransferJob::start): Open a windows file handle. (WebCore::TransferJob::fileLoadTimer): Load from windows file handle. (WebCore::TransferJob::cancel): Stop timer and close windows file handle if present.

Mar 3, 2006:

11:42 PM Changeset in webkit [13123] by eseidel
  • 5 edits
    2 adds in trunk/WebCore

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix QString crasher on Win32, also remove c-style casts from file.
Add a few more stubs to allow more layout tests to not crash.
Make dlls only copy when changed.
Add RenderThemeWin stubs.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • platform/QString.cpp: (QString::stripWhiteSpace): (QString::simplifyWhiteSpace): (QString::setLatin1): (QString::sprintf): (QString::insert): (QString::fill):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::usableScreenRect): (FrameWin::respondToChangedContents): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::clearUndoRedoOperations): (FrameWin::issueRedoCommand): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::saveDocumentState): (FrameWin::print): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::issueUndoCommand): (FrameWin::mimeTypeForFileName): (FrameWin::clearRecordedFormValues): (FrameWin::issuePasteCommand): (FrameWin::scheduleClose): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::issueTransposeCommand): (FrameWin::canPaste): (FrameWin::incomingReferrer): (FrameWin::canGoBackOrForward): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::createPlugin): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::openURLNotify): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (QListBox::setFont): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob): (QFontMetrics::QFontMetrics): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::ascent): (FrameWin::shouldChangeSelection): (FrameWin::generateFrameName): (FrameWin::createFrame): (RenderThemeWin::paintCheckbox): (RenderThemeWin::paintRadio): (RenderThemeWin::paintButton): (RenderThemeWin::paintTextField):
  • rendering/RenderThemeWin.cpp: Added. (WebCore::theme):
  • rendering/RenderThemeWin.h: Added.
11:29 PM Changeset in webkit [13122] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

A few more fixes to make run-webkit-tests really work on win32.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest):
  • Scripts/run-webkit-tests:
5:35 PM Changeset in webkit [13121] by eseidel
  • 5 edits in trunk/WebKitTools

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Make run-webkit-tests work on win32.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest): (dumpRenderTreeMain): (dumpRenderTreeToStdOut): (serializeToStdOut): (main):
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView):
3:33 PM Changeset in webkit [13120] by ggaren
  • 3 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Darin.

This regression was caused by my fix for 4448098. I failed to account for the
deleted entry sentinel in the mehtod that saves the contents of a property map to
the back/forward cache.

Manual test in WebCore/manual-tests/property-map-save-crash.html

  • kjs/property_map.cpp: (KJS::deletedSentinel): Use 1 instead of -1 to facilitate an easy bit mask (KJS::isValid): New function: checks if a key is null or the deleted sentinel (KJS::PropertyMap::~PropertyMap): Fixed up the branch logic here for readability and a slight performance win (KJS::PropertyMap::clear): (KJS::PropertyMap::rehash): (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): (KJS::PropertyMap::save): Check keys with isValid()

WebCore:

Test case for <rdar://problem/4465598> REGRESSION (TOT): Crash occurs at
​http://maps.google.com/?output=html ( KJS::Identifier::add(KJS::UString::Rep*)

  • manual-tests/property-map-save-crash.html: Added.
2:10 PM Changeset in webkit [13119] by lypanov
  • 2 edits in trunk/LayoutTests

2006-03-03 Alexander Kellett <​lypanov@kde.org>

  • local machine unfortunately shows slightly differing results to the build bots, reverting to fix the built bot.
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
11:43 AM Changeset in webkit [13118] by eseidel
  • 3 edits in trunk/WebCore

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

Fix clearly bogus cairo elipse drawing code.
Make QFontMetrics stubs slightly more sane.

  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawEllipse):
  • platform/win/TemporaryLinkStubs.cpp: (QFontMetrics::floatWidth): (QFontMetrics::height): (QFontMetrics::width): (QFontMetrics::isFixedPitch):
7:59 AM Changeset in webkit [13117] by darin
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • fast/innerHTML/innerHTML-custom-tag.html: Added.
  • fast/innerHTML/innerHTML-custom-tag-expected.txt: Added.
  • fast/innerHTML/005-expected.txt: Updated. Now matches the original document as expected. Old result had the <div> after a <pre> put on the same line.
  • editing/inserting/4278698-expected.txt: Updated because offset of node changed since we have one more text node (from after a /pre).
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Ditto.

WebCore:

Reviewed by Eric.

Test: fast/innerHTML/innerHTML-custom-tag.html

  • editing/markup.cpp: (WebCore::shouldSelfClose): Refined rule so that it doesn't try to do any self-closing tags in HTML documents at all; updated comment.
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Added a check of beginTag in the <pre> tag case. We were accidentally discarding a newline after a </pre> tag.
1:54 AM Changeset in webkit [13116] by eseidel
  • 5 edits
    2 adds in trunk/WebKitTools

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add WebFrame class (to hold Frame and FrameView).
Add Location bar support to Spinneret.

  • Spinneret/Spinneret/Spinneret.cpp: (resizeSubViews): (_tWinMain): (WndProc): (MyEditProc):
  • Spinneret/Spinneret/Spinneret.vcproj:
  • Spinneret/Spinneret/WebFrame.cpp: Added. (WebKit::WebFrame::WebFramePrivate::WebFramePrivate): (WebKit::WebFrame::WebFramePrivate::~WebFramePrivate): (WebKit::WebFrame::WebFrame): (WebKit::WebFrame::loadFilePath): (WebKit::WebFrame::loadHTMLString): (WebKit::WebFrame::paint): (WebKit::WebFrame::impl): (WebKit::WebFrame::viewImpl):
  • Spinneret/Spinneret/WebFrame.h: Added.
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebViewPrivate::~WebViewPrivate): (WebKit::WebView::WebView): (WebKit::WebView::windowHandle): (WebKit::WebView::mainFrame): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):
  • Spinneret/Spinneret/WebView.h:
1:44 AM Changeset in webkit [13115] by mjs
  • 3 edits
    1 copy in trunk/WebCore

Rubber stamped by Eric.

  • add new files to build, fix link stubs.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob):
  • platform/win/TransferJobWin.cpp: Added.
1:31 AM Changeset in webkit [13114] by mjs
  • 1 edit
    1 add in trunk/WebCore
  • add file I forgot in my last commit.
  • platform/TransferJobInternal.h: Added. (WebCore::TransferJobInternal::TransferJobInternal):
1:30 AM Changeset in webkit [13113] by eseidel
  • 10 edits
    2 adds in trunk/WebCore

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Wire up WidgetWin, CursorWin, ScrollViewWin.
Stub out methods for selection and cursors.

  • Viewer/ImageDocument.h:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp:
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::initScriptIfNeeded):
  • platform/IntRect.h: (WebCore::IntRect::IntRect):
  • platform/Widget.h:
  • platform/win/CursorWin.cpp: (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor):
  • platform/win/IntRectWin.cpp: (WebCore::IntRect::IntRect): (WebCore::IntRect::operator RECT):
  • platform/win/MouseEventWin.cpp:
  • platform/win/ScrollViewWin.cpp: Added. (WebCore::ScrollView::updateContents):
  • platform/win/TemporaryLinkStubs.cpp: (QTextEdit::textWithHardLineBreaks): (QLineEdit::setPlaceholderString): (QScrollBar::scroll): (GraphicsContext::beginTransparencyLayer): (Widget::setIsSelected): (QLineEdit::selectedText): (QComboBox::sizeHint): (KWQFileButton::focusPolicy): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QListBox::focusPolicy): (QLineEdit::focusPolicy): (WebCore::moveCursor): (ScrollView::scrollBy): (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::TransferJob): (WebCore::screenDepth): (WebCore::usableScreenRect): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::issuePasteCommand): (FrameWin::issueTransposeCommand): (QSlider::setFont): (QLineEdit::setFont): (QListBox::setFont): (QFontMetrics::QFontMetrics): (QComboBox::setFont): (QTextEdit::setFont): (QTextEdit::setWritingDirection): (QFontMetrics::setFontDescription): (QFontMetrics::checkSelectionPoint): (FrameWin::addMessageToConsole): (FrameWin::shouldChangeSelection): (ScrollView::resizeContents): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsX): (ScrollView::contentsY): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::viewportToContents):
  • platform/win/WidgetWin.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::windowHandle): (WebCore::Widget::setWindowHandle): (WebCore::Widget::setActiveWindow): (WebCore::Widget::frameGeometry): (WebCore::Widget::hasFocus): (WebCore::Widget::setFocus): (WebCore::Widget::clearFocus): (WebCore::Widget::font): (WebCore::Widget::setFont): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::mapFromGlobal):
1:19 AM Changeset in webkit [13112] by mjs
  • 11 edits
    1 copy
    3 moves
    2 deletes in trunk/WebCore

Reviewed by Eric.

  • move TransferJob from kwq to platform, separate platform from non-platform bits
  • ForwardingHeaders/kio/job.h: Removed.
  • ForwardingHeaders/kio/jobclasses.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm:
  • dom/xml_tokenizer.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • kwq/KWQKJobClasses.h: Removed.
  • kwq/KWQKJobClasses.mm: Removed.
  • kwq/KWQLoader.mm:
  • kwq/KWQResourceLoader.mm:
  • kwq/TransferJobClient.h: Removed.
  • loader/Cache.cpp:
  • loader/loader.cpp:
  • page/Frame.cpp:
  • platform/TransferJob.cpp: Added. (WebCore::TransferJob::TransferJob): (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::addMetaData):
  • platform/TransferJob.h: Added.
  • platform/TransferJobClient.h: Added.
  • platform/mac/TransferJobMac.mm: Added. (WebCore::TransferJobInternal::~TransferJobInternal): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::cancel):
  • xml/xmlhttprequest.cpp:
1:18 AM Changeset in webkit [13111] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • enough link stubs to "display" local copy of WebKit site w/o hitting breakpoint
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::setReadOnly): (QTextEdit::setCursorPosition): (QLineEdit::setCursorPosition): (QFontMetrics::width): (GraphicsContext::drawText): (GraphicsContext::drawLineForText):

Mar 2, 2006:

11:44 PM Changeset in webkit [13110] by mjs
  • 2 edits in trunk/WebCore

Rubber stamped by Eric.

  • remove function that is now gone
  • platform/win/TemporaryLinkStubs.cpp:
11:41 PM Changeset in webkit [13109] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Eric.


  • move logic to kick off load from KWQLoader function to a TransferJob method
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (WebCore::TransferJob::start):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
11:16 PM Changeset in webkit [13108] by mjs
  • 5 edits in trunk/WebCore

Rubber stamped by Eric.

  • remove unused loader parameter to KWQServeRequest.
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQServeRequest):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
10:58 PM Changeset in webkit [13107] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Eric.

  • remove one of the versions of KWQServeRequest.
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • platform/win/TemporaryLinkStubs.cpp: (Widget::isEnabled): (KWQServeRequest):
10:13 PM Changeset in webkit [13106] by mjs
  • 2 edits in trunk/WebCore

Rubber stamped by Eric.

  • win32 build fix.
  • platform/win/MouseEventWin.cpp:
9:37 PM Changeset in webkit [13105] by eseidel
  • 2 edits in trunk/WebKitSite

2006-03-02 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

  • quality/reporting.html: display a nicer message to those using 10.2
6:53 PM Changeset in webkit [13104] by justing
  • 5 edits in trunk/WebCore

Reviewed by eric


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3894>
uses of <cmath> should change to <math>

  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGLengthImpl.cpp:
5:52 PM Changeset in webkit [13103] by bdakin
  • 8 edits
    6 adds in trunk/LayoutTests

Reviewed by Darin, landed by Beth.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3230
CSS1: Words with inline elements get extra capital letters

Update existing tests for new results and add new test

5:46 PM Changeset in webkit [13102] by bdakin
  • 5 edits in trunk/WebCore

Reviewed by Darin, landed by Beth

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3230
CSS1: Words with inline elements get extra capital letters

Does not use UBreakIterator (yet?) for this, but a relatively
simple change that fixes our failure in the CSS1 test suite
(5.4.5).

1:46 PM Changeset in webkit [13101] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-02 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

  • Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::WebView): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):
  • Spinneret/Spinneret/WebView.h:
1:45 PM Changeset in webkit [13100] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Patch reviewed by sullivan
Test written by mitz


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

  • fast/lists/scrolled-marker-paint-expected.checksum: Added.
  • fast/lists/scrolled-marker-paint-expected.png: Added.
  • fast/lists/scrolled-marker-paint-expected.txt: Added.
  • fast/lists/scrolled-marker-paint.html: Added.

WebCore:

Reviewed by sullivan


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
1:41 PM Changeset in webkit [13099] by eseidel
  • 6 edits
    2 adds in trunk/WebCore

2006-03-02 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Add (partially stubbed out) mouse event handling for Win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/IntPoint.h:
  • platform/MouseEvent.h:
  • platform/win/IntPointWin.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator POINT):
  • platform/win/MouseEventWin.cpp: Added. (WebCore::MouseEvent::MouseEvent):
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::setMaxLength): (ScrollView::scrollBy): (WebCore::Widget::setFocus): (FrameWin::respondToChangedSelection): (FrameWin::runJavaScriptPrompt): (FrameWin::recordFormValue): (FrameWin::registerCommandForRedo): (FrameWin::runJavaScriptAlert): (FrameWin::runJavaScriptConfirm): (FrameWin::openURL): (FrameWin::registerCommandForUndo): (FrameWin::addMessageToConsole): (FrameWin::mimeTypeForFileName): (FrameWin::shouldChangeSelection): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::markMisspellings): (FrameWin::personalbarVisible): (FrameWin::objectContentType): (FrameWin::createFrame): (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::openURLNotify): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::setIconURL): (FrameWin::passSubframeEventToSubframe): (FrameWin::lastEventIsMouseUp): (BrowserExtensionWin::BrowserExtensionWin): (Widget::setCursor): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsX): (ScrollView::contentsY): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::viewportToContents): (TransferJob::TransferJob): (TransferJob::addMetaData):
11:40 AM Changeset in webkit [13098] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by mjs


<​http://tinymce.moxiecode.com/example_full.php?example=true>
TinyMCE: Undo still enabled after a location change, crashes if performed

  • editing/undo/undo-iframe-location-change-expected.txt: Added.
  • editing/undo/undo-iframe-location-change.html: Added.

WebCore:

Reviewed by mjs


<​http://tinymce.moxiecode.com/example_full.php?example=true>
TinyMCE: Undo still enabled after a location change, crashes if performed


Can't clear undo/redo operations registered by subframes in didOpenURL,
because subframes have already been detached.

  • page/Frame.cpp: (WebCore::Frame::didOpenURL): (WebCore::Frame::closeURL):
11:37 AM Changeset in webkit [13097] by thatcher
  • 1 copy in tags/WebCore-417.23/WebCore

New tag part two).

11:37 AM Changeset in webkit [13096] by thatcher
  • 1 add in tags/WebCore-417.23

New tag.

11:35 AM Changeset in webkit [13095] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.23

11:32 AM Changeset in webkit [13094] by thatcher
  • 7 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This also includes the ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7363 fix
<rdar://problem/4462712> REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail

2006-02-17 Vicki Murley <​vicki@apple.com>

Reviewed by Justin.


Get rid of handleFocusOut on text fields and textareas - move this functionality to the place
where we resign focus on the previous node in setFocusNode. Add isTextField on RenderObject
as one way to distinguish from contenteditable elements - Win IE does not fire onChange for
contenteditable elements, so we won't either. Also, expose the dirty bit variables previously
checked in handleFocusOut methods in isEdited() and setEdited().

Fixes the following bugs:
<rdar://problem/4315673> REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab (7227)
<rdar://problem/4447009> for text fields, onChange should fire before onBlur to match Win IE

Test case is on the way.

  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::setFocusNode): For textareas and text fields, fire a change event on the node that is resigning focus. Make sure the blur event fires after the change event - 4447009.
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::slotReturnPressed): Replace call to handleFocusOut with equivalent code. (WebCore::RenderLineEdit::isEdited): Added. (WebCore::RenderLineEdit::setEdited): Added. (WebCore::RenderTextArea::setEdited): Added.
  • rendering/render_form.h: (WebCore::RenderLineEdit::isTextField): Added. (WebCore::RenderTextArea::isTextArea): Make this non-virtual. (WebCore::RenderTextArea::isEdited): Added.
  • rendering/render_object.h: (WebCore::RenderObject::isEdited): Added. (WebCore::RenderObject::setEdited): Added. (WebCore::RenderObject::isTextField): Added.
  • rendering/render_replaced.h: Remove handleFocusOut().
  • rendering/render_replaced.cpp: Ditto. (WebCore::RenderWidget::eventFilter): Remove call to handleFocusOut(). Safe to do here, since we call setFocusNode immediately beforehand.
2:35 AM Changeset in webkit [13093] by mjs
  • 2 edits in trunk/JavaScriptCore
  • now fix mac build again
  • kjs/identifier.cpp:
2:20 AM Changeset in webkit [13092] by mjs
  • 3 edits in trunk/JavaScriptCore

Rubber stamped by Anders and Eric.

  • add fpconst.cpp to win32 build, it is now needed
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/fpconst.cpp:
2:10 AM Changeset in webkit [13091] by mjs
  • 5 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • fix windows build, broken by my last patch
  • kjs/JSImmediate.cpp:
  • kjs/identifier.cpp:
  • kxmlcore/FastMalloc.cpp:
  • kxmlcore/Platform.h:
1:21 AM Changeset in webkit [13090] by eseidel
  • 52 edits in trunk

Add svn:eol-style=native, and fix line endings.

1:12 AM Changeset in webkit [13089] by mjs
  • 62 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Darin.


  • Set up new prototype macros and avoid using #if without defined() in JSC


Added new PLATFORM macros and related, to make sure #if's all check if relevant macros
are defined, and to separate core OS-level dependencies from operating environment
dependencies so you can, e.g., build KDE on Mac or Windows.

  • kxmlcore/Platform.h: Added.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
  • bindings/objc/WebScriptObject.mm:
  • bindings/objc/objc_instance.mm: (ObjcInstance::end):
  • bindings/softlinking.h:
  • bindings/testbindings.mm: (main):
  • kjs/JSLock.cpp:
  • kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::markOtherThreadConservatively): (KJS::Collector::markStackObjectsConservatively):
  • kjs/config.h:
  • kjs/date_object.cpp: (gmtoffset): (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::makeTime):
  • kjs/dtoa.cpp:
  • kjs/fpconst.cpp: (KJS::sizeof): (KJS::):
  • kjs/grammar.y:
  • kjs/identifier.cpp:
  • kjs/internal.cpp:
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate): (KJS::Interpreter::createLanguageInstanceForValue):
  • kjs/interpreter.h:
  • kjs/lookup.cpp:
  • kjs/lookup.h:
  • kjs/math_object.cpp:
  • kjs/object.cpp:
  • kjs/object.h:
  • kjs/operations.cpp: (KJS::isNaN): (KJS::isInf): (KJS::isPosInf): (KJS::isNegInf):
  • kjs/operations.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::RegExp::~RegExp): (KJS::RegExp::match):
  • kjs/regexp.h:
  • kjs/testkjs.cpp: (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS):
  • kjs/ustring.cpp:
  • kjs/ustring.h:
  • kxmlcore/AlwaysInline.h:
  • kxmlcore/Assertions.cpp:
  • kxmlcore/Assertions.h:
  • kxmlcore/FastMalloc.cpp: (KXMLCore::):
  • kxmlcore/FastMalloc.h:
  • kxmlcore/FastMallocInternal.h:
  • kxmlcore/HashTable.h:
  • kxmlcore/TCPageMap.h:
  • kxmlcore/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
  • kxmlcore/TCSystemAlloc.cpp: (TCMalloc_SystemAlloc):
  • os-win32/stdint.h:

JavaScriptGlue:

Not reviewed, but I noticed these trivial extra changes were needed to avoid
breaking the build with my reviewed patch for:


​http://bugzilla.opendarwin.org/show_bug.cgi?id=7387


Add config.h, includes of it, and Platform.h forwarding header.

  • JSBase.cpp:
  • JSObject.cpp:
  • JSRun.cpp:
  • JSUtils.cpp:
  • JSValueWrapper.cpp:
  • JavaScriptGlue.cpp:
  • UserObjectImp.cpp:
  • config.h: Added.
  • kxmlcore/Platform.h: Added.

WebCore:

Reviewed by Darin.


Add Platform.h

  • ForwardingHeaders/kxmlcore/Platform.h: Added.
  • bridge/mac/WebCoreFrameNamespaces.m:
  • bridge/mac/WebCoreViewFactory.m:
  • bridge/mac/WebDashboardRegion.m:
  • config.h:
  • platform/Logging.cpp:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild):
  • platform/mac/WebCoreCookieAdapter.m:
  • platform/mac/WebCoreGraphicsBridge.m:
  • platform/mac/WebCoreHistory.m:
  • platform/mac/WebCoreImageRendererFactory.m:
  • platform/mac/WebCoreKeyGenerator.m:
  • platform/mac/WebCoreView.m:
12:39 AM Changeset in webkit [13088] by eseidel
  • 2 edits in trunk/WebCore

2006-03-02 Eric Seidel <​eseidel@apple.com>

  • WebCore.xcodeproj/project.pbxproj: update GraphicsContext.cpp path to fix build
12:21 AM Changeset in webkit [13087] by eseidel
  • 6 edits in trunk/WebKitTools

2006-03-01 Eric Seidel <​eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

Make spinneret take advantage of the new GraphicsContextCairo.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): updated to match style guidelines.
  • Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
  • Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::WebView): (WebKit::WebView::~WebView): (WebKit::WebView::drawRect): (WebKit::WndProc):
  • Spinneret/Spinneret/WebView.h:
12:20 AM Changeset in webkit [13086] by eseidel
  • 6 edits
    1 move in trunk/WebCore

2006-03-01 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Add first-stab GraphicsContextCairo.

Shuffle a few more link stubs around, remove uncessary WebCore
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/GraphicsContext.cpp: Added.
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::setColor): (WebCore::fillRectSourceOver): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setBrush): (WebCore::GraphicsContext::brush): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::setColorFromBrush): (WebCore::GraphicsContext::setColorFromPen): (WebCore::adjustLineToPixelBounderies): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawFloatImage): (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::addClip): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled):
  • platform/cairo/ImageCairo.cpp:
  • platform/cg/GraphicsContextCG.cpp: Removed.
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectAll): (Widget::mapFromGlobal): (QLineEdit::cursorPosition): (QTextEdit::setScrollBarModes): (QTextEdit::selectAll): (QComboBox::focusPolicy): (GraphicsContext::clearShadow): (QTextEdit::setCursorPosition): (GraphicsContext::drawText): (QLineEdit::setLiveSearch): (QComboBox::QComboBox): (Widget::lockDrawingFocus): (QTextEdit::setSelectionRange): (QSlider::QSlider): (ScrollView::scrollYOffset): (QComboBox::sizeHint): (QLineEdit::edited): (QTextEdit::text): (QSlider::value): (WebCore::Widget::setFocus): (WebCore::TransferJob::addMetaData): (FrameWin::respondToChangedContents): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::respondToChangedSelection): (FrameWin::clearUndoRedoOperations): (FrameWin::issueRedoCommand): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::runJavaScriptPrompt): (FrameWin::recordFormValue): (FrameWin::registerCommandForRedo): (FrameWin::runJavaScriptAlert): (FrameWin::runJavaScriptConfirm): (FrameWin::openURL): (FrameWin::saveDocumentState): (FrameWin::print): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::registerCommandForUndo): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::addMessageToConsole): (FrameWin::passWheelEventToChildWidget): (FrameWin::issueUndoCommand): (FrameWin::mimeTypeForFileName): (FrameWin::clearRecordedFormValues): (FrameWin::issuePasteCommand): (FrameWin::shouldChangeSelection): (FrameWin::scheduleClose): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::markMisspellings): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::lastEventIsMouseUp): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::issueTransposeCommand): (FrameWin::userAgent): (FrameWin::canPaste): (FrameWin::incomingReferrer): (FrameWin::objectContentType): (FrameWin::passSubframeEventToSubframe): (FrameWin::createFrame): (FrameWin::canGoBackOrForward): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::createPlugin): (FrameWin::generateFrameName): (QTextEdit::setWritingDirection): (QFontMetrics::checkSelectionPoint): (GraphicsContext::GraphicsContext): (QFontMetrics::isFixedPitch): (FrameWin::restoreDocumentState): (FrameWin::partClearedInBegin): (FrameWin::createEmptyDocument): (FrameWin::overrideMediaType): (FrameWin::setTitle): (FrameWin::handledOnloadEvents): (FrameWin::markedTextRange): (GraphicsContext::font): (GraphicsContext::setFont):
Note: See TracTimeline for information about the timeline view.