⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 16, 2006:

11:50 PM Changeset in webkit [13893] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • editing/selection/extend-by-word-002-expected.checksum: Updated.
  • editing/selection/extend-by-word-002-expected.png: Updated.
  • fast/lists/markers-in-selection-expected.checksum: Added.
  • fast/lists/markers-in-selection-expected.png: Added.
  • fast/lists/markers-in-selection-expected.txt: Added.
  • fast/lists/markers-in-selection.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/lists/markers-in-selection.html

  • rendering/RenderObject.h: Added selectionColorImageOverlayAlpha constant - the maximum opacity of the selection color when painted over images.
  • rendering/render_list.cpp: (WebCore::RenderListMarker::RenderListMarker): (WebCore::RenderListMarker::paint): Paint the selection highlight if selected: over the marker for image markers, under the marker for all other markers. (WebCore::RenderListMarker::setSelectionState): Added. (WebCore::RenderListMarker::selectionRect): Added. (WebCore::RenderListMarker::selectionColor): Added. Ensures that the selection color is transparent for image markers.
  • rendering/render_list.h: (WebCore::RenderListMarker::selectionState): (WebCore::RenderListMarker::canBeSelectionLeaf):
  • rendering/render_replaced.cpp (WebCore::RenderReplaced::selectionColor): Changed to use the selectionColorImageOverlayAlpha constant.
11:15 PM Changeset in webkit [13892] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/button-inner-block-reuse-expected.checksum: Added.
  • fast/forms/button-inner-block-reuse-expected.png: Added.
  • fast/forms/button-inner-block-reuse-expected.txt: Added.
  • fast/forms/button-inner-block-reuse.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/button-inner-block-reuse.html

Buttons have a distinguished anonymous child that holds all their other
descendants. Descendants ended up in a sibling anonymous block as the
initial anonymous child was being reused to hold the initial part of an
inline that got split.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::splitFlow): Check if the anonymous block's parent allows us to reuse it.
  • rendering/RenderObject.h: (WebCore::RenderObject::allowsReusingAnonymousChild): Added. Returns true.
  • rendering/render_button.h: (WebCore::RenderButton::allowsReusingAnonymousChild): Added. Returns false.
11:01 PM Changeset in webkit [13891] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

  • editing/pasteboard/drop-text-without-selection-expected.checksum: Added.
  • editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • editing/pasteboard/drop-text-without-selection-expected.txt: Added.
  • editing/pasteboard/drop-text-without-selection.html: Added.

WebCore:

Reviewed by Justin.

Test: editing/pasteboard/drop-text-without-selection.html

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge documentFragmentWithText:]): Changed to allow creating a fragment regardless of the selection.
10:46 PM Changeset in webkit [13890] by darin
  • 11 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

  • bridge/mac/WebCoreFrameBridge.h:
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): Added call to formControlIsBecomingFirstResponder:. (-[KWQPopUpButton resignFirstResponder]): Cleaned up.
  • kwq/KWQListBox.mm: Ditto. (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]):
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added call to formControlIsBecomingFirstResponder: and cleaned up. (-[KWQSlider resignFirstResponder]): Cleaned up.
  • platform/mac/WebCoreTextArea.mm: (-[WebCoreTextView becomeFirstResponder]): Added call to formControlIsBecomingFirstResponder:. (-[WebCoreTextView resignFirstResponder]): Cleaned up.
  • platform/mac/WebCoreTextField.mm: (-[KWQTextFieldController setHasFocus:]): Added call to formControlIsBecomingFirstResponder:.
  • manual-tests/textarea-focus.html: Added.

WebKit:

Reviewed by Darin.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge formControlIsBecomingFirstResponder:]): Added. Calls the ancestor WebHTMLView's _formControlIsBecomingFirstResponder:
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState:]): If a descendant is becoming first responder, enable focused appearance. (-[WebHTMLView _formControlIsBecomingFirstResponder:]): Added. Calls _updateFocusState, causing the frame to display with focus attributes.
  • WebView/WebHTMLViewInternal.h:
10:34 PM Changeset in webkit [13889] by darin
  • 7 edits
    1 add in trunk/WebCore

Reviewed by Adele and Justin.

Calling SelectionController::nodeWillBeRemoved from Document::notifyBeforeNodeRemoval
fixes the crash, which was happening because the call that was removing the text
node, removeChildren, does not send a "node removed" mutation event (it sends a
"subtree modified" mutation event instead). So this change alone fixes the crash.

But I also changed setInnerText to not blow away the text node each time the value
is changed, and that makes the test case behave even better -- you don't even lose
the selection; it works as it did with the NSTextField-based text field.

  • manual-tests/input-empty-on-focus.html: Added.
  • page/Frame.h: Tweaked a few comments and functions related to selection.
  • page/Frame.cpp: (WebCore::Frame::dragCaret): Made non-const.
  • dom/Document.cpp: (WebCore::Document::notifyBeforeNodeRemoval): Call nodeWillBeRemoved on the two selection controllers before removing a node from the document.
  • editing/SelectionController.h: Tweak formatting. Remove MutationListener class and m_mutationListener field.
  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Remove code to set up the mutation event listener. (WebCore::SelectionController::setSelection): Remove code to maintain the mutation event listener.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): In cases where the container has only a single child use replaceChild, and in cases where the HTML being inserted also has only a single child and both are text nodes use setData. It's common to use setInnerHTML to set something that's just text. (WebCore::HTMLElement::setInnerText): Same as above, but simpler since the thing we're replacing with is always text.
8:10 PM Changeset in webkit [13888] by darin
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • css/make-css-file-arrays.pl: Remove the "-" parameter from the invocation of cpp, which means "send output to stdout". It's optional on Mac OS X, and is causing a hang on Linux.
  • rendering/RenderArena.cpp: Added a missing include of <assert.h>.
2:36 PM Changeset in webkit [13887] by jdevalk
  • 3 edits in trunk/WebKitSite
  • Small textual change to my contact info;
  • Added bugreporting URL for non ADC members.
2:22 PM Changeset in webkit [13886] by jdevalk
  • 2 edits in trunk/WebKitSite

Added info on CIA, trac, build bot and webkit-unassigned

2:29 AM Changeset in webkit [13885] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (crashHandler): Added a handler for signals that are raised on a crash. Keeping separate from the existing handler for manual interruption (SIGINT/SIGHUP/SIGTERM), because I'm trying to find a way to prevent the Crash Reporter dialog from appearing on crash, and this code may change significantly.

(main): Install crashHandler.

(setDefaultColorProfileToRGB): Properly convert CFStringRef to a char buffer
(CFStringGetCStringPtr should NEVER EVER be used!).

Apr 15, 2006:

8:05 PM Changeset in webkit [13884] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

  • Scripts/install-win-extras: Try to fix the Windows build by fixing the URLs here. Seems xmlsoft.org's HTTP no longer has what we need.
7:28 PM Changeset in webkit [13883] by darin
  • 2 edits in trunk/WebCore
  • removed references to a couple files that are obsolete but were still in the Windows project file
  • WebCore.vcproj/WebCore/WebCore.vcproj: Remove kjs_views.h and .cpp.
7:20 PM Changeset in webkit [13882] by mjs
  • 8 edits
    1 move in branches/treecode/JavaScriptCore

Reviewed by Darin.


  • rename InterpreterState to Opcode
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/InterpreterState.h: Removed.
  • kjs/Opcode.h: Added. (KJS::):
  • kjs/TreeCode.cpp: (KJS::): (KJS::isEvaluateOpcode): (KJS::isEvaluateListOpcode): (KJS::isExecuteState): (KJS::pushEvaluate): (KJS::pushEvaluateList): (KJS::pushExecute): (KJS::InterpreterImp::runInterpreterLoop):
  • kjs/grammar.y:
  • kjs/internal.cpp: (KJS::printUnwindBarrier): (KJS::InterpreterImp::printStateStack): (KJS::InterpreterImp::unwindToNextBarrier):
  • kjs/internal.h: (KJS::InterpreterImp::State::State):
  • kjs/nodes.cpp: (Node::Node):
  • kjs/nodes.h: (KJS::Node::opcode): (KJS::ExprNode::ExprNode): (KJS::StatementNode::StatementNode): (KJS::JumpNode::JumpNode): (KJS::ForExprEndNode::ForExprEndNode):
6:26 PM Changeset in webkit [13881] by darin
  • 1 edit
    2 adds in trunk/LayoutTests
  • more results for tests landed without pixel-test results
  • fast/text/whitespace/pre-newline-box-test-expected.checksum: Added.
  • fast/text/whitespace/pre-newline-box-test-expected.png: Added.
12:27 PM Changeset in webkit [13880] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): Use isEmpty() instead of isNull() for checking the domain to determine if the document in a local file.
11:13 AM Changeset in webkit [13879] by darin
  • 1 edit
    7 adds in trunk/LayoutTests
  • added some results for some tests people added without expected results
  • svg/custom/class-selector-expected.txt: Added.
  • svg/custom/class-selector-expected.checksum: Added.
  • svg/custom/class-selector-expected.png: Added.
  • editing/selection/extend-by-sentence-001-expected.checksum: Added.
  • editing/selection/extend-by-sentence-001-expected.png: Added.
  • fast/dom/Element/null-offset-parent-expected.checksum: Added.
  • fast/dom/Element/null-offset-parent-expected.png: Added.
11:10 AM Changeset in webkit [13878] by darin
  • 2 edits in trunk/LayoutTests
  • updated a layout test result for Hyatt's prefix change
  • fast/inspector/style-expected.txt: Some background properties now have the "-webkit" prefix.

Apr 14, 2006:

10:38 PM Changeset in webkit [13877] by thatcher
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Timothy.

Bug 8389: support for Cocoa bindings - binding an NSTreeController to the WebView's DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8389

Adds a category to WebScriptObject with array accessors for KVC/KVO.

If super valueForKey: fails it will call valueForUndefinedKey:, which is
important because it causes the right behavior to happen with bindings using
the "Raises for Not Applicable Keys" flag and the "Not Applicable Placeholder"

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject valueForKey:]): (-[WebScriptObject count]): (-[WebScriptObject objectAtIndex:]): (-[WebUndefined description]): return "undefined"

WebKit:

Reviewed by Timothy.

Bug 8389: support for Cocoa bindings - binding an NSTreeController to the WebView's DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8389

Added a controller class, WebController, that is a subclass of
NSTreeController that has a new outlet/binding for the WebView.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]): notify bindings about the document change
  • WebView/WebView.m: (-[WebView _progressStarted:]): notify bindings about the document change (-[WebView _finalProgressComplete]): notify bindings about the document change (-[WebView _declaredKeys]): added a key for the main frame document (-[WebController init]): (-[WebController exposedBindings]): (-[WebController valueClassForBinding:]): (-[WebController setContent:]): (-[WebController webView]): (-[WebController setWebView:]): (-[WebView mainFrameDocument]): get the main frame's DOMDocument
  • WebView/WebViewPrivate.h: Adds mainFrameDocument to pending public.
5:53 PM Changeset in webkit [13876] by mjs
  • 1 edit
    1 add in branches/treecode/JavaScriptCore
  • missing part of last commit
  • kjs/Expr.h: Added.
5:28 PM Changeset in webkit [13875] by eseidel
  • 2 edits in branches/treecode/JavaScriptCore/kjs

Mark the list stack, fix assertion hit when collector runs out of memory. r=mjs

3:50 PM Changeset in webkit [13874] by hyatt
  • 31 edits in trunk/WebCore

CSS vendor-specific property/value cleanup. Properly qualify background-clip,
background-origin, border-image and the border-radius properties. Make sure
our overflow extensions of marquee and overlay are qualified as well. Rename
the -khtml- extension to -webkit.

Reviewed by beth

  • bindings/js/kjs_css.cpp: (KJS::cssPropertyName):
  • bindings/objc/DOMCSS.mm: (-[DOMCSSStyleDeclaration _fontSizeDelta]): (-[DOMCSSStyleDeclaration _setFontSizeDelta:]):
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _setAutofilled:]):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::valueForTextAlign): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSGrammar.y:
  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/css_base.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/css_valueimpl.cpp: (WebCore::):
  • css/css_valueimpl.h:
  • css/cssparser.cpp: (WebCore::CSSParser::parseRule): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::parseBackgroundShorthand): (WebCore::CSSParser::parseBackgroundColor): (WebCore::CSSParser::parseBackgroundProperty): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseShadow):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/cssstyleselector.h:
  • css/html4.css:
  • css/quirks.css:
  • css/tokenizer.flex:
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::removeInlineStyle):
  • editing/CompositeEditCommand.cpp: (WebCore::blockPlaceholderClassString):
  • editing/JSEditor.cpp:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::fixupNodeStyles): (WebCore::styleForNode):
  • editing/htmlediting.cpp: (WebCore::rebalanceWhitespaceInTextNode):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::addHTMLAlignment): (WebCore::HTMLElement::setContentEditable):
  • html/html_blockimpl.cpp: (WebCore::HTMLDivElement::parseMappedAttribute): (WebCore::HTMLParagraphElement::parseMappedAttribute): (WebCore::HTMLMarqueeElement::parseMappedAttribute):
  • html/html_inlineimpl.cpp: (WebCore::HTMLFontElement::parseMappedAttribute):
  • html/html_tableimpl.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute): (WebCore::HTMLTableCellElement::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::canMouseDownStartSelect):
  • page/Frame.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode):
3:01 PM Changeset in webkit [13873] by eseidel
  • 3 edits in trunk/WebCore

2006-04-14 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Fix win32 build.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • page/FramePrivate.h:
2:37 PM Changeset in webkit [13872] by eseidel
  • 4 edits in trunk/WebCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Fix build-warnings in cairo code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8176

  • platform/cairo/cairo/src/cairo-win32-surface.c: (_cairo_win32_print_gdi_error): (_cairo_win32_surface_create_for_dc): (_composite_alpha_blend): (cairo_win32_surface_create):
  • platform/cairo/pixman/src/iccolor.c: (pixman_pixel_to_color):
2:25 PM Changeset in webkit [13871] by mjs
  • 1 edit in branches/treecode/JavaScriptCore/ChangeLog

Updated ChangeLog to note this:

Makes treecode branch 10% faster.

2:25 PM Changeset in webkit [13870] by mjs
  • 11 edits in branches/treecode/JavaScriptCore

Reviewed by Darin.


  • changed expression grammar production rules to make flattened output


Expressions now form lists instead of trees, so that use of the
state stack can be avoided.

  • kjs/InterpreterState.h:
  • kjs/TreeCode.cpp: (KJS::InterpreterImp::runInterpreterLoop):
  • kjs/grammar.y:
  • kjs/internal.cpp:
  • kjs/internal.h: (KJS::Stack::fromLast): (KJS::Stack::swapLastTwo):
  • kjs/lexer.cpp:
  • kjs/nodes.cpp: (Node::throwError): (ForNode::processVarDecls): (ForInNode::ForInNode):
  • kjs/nodes.h: (KJS::ExprNode::ExprNode): (KJS::ExprNode::next): (KJS::ExprStatementEndNode::ExprStatementEndNode): (KJS::ExprStatementEndNode::streamTo): (KJS::ArgumentEndNode::ArgumentEndNode): (KJS::ArgumentEndNode::streamTo): (KJS::PropertyEndNode::PropertyEndNode): (KJS::PropertyEndNode::streamTo): (KJS::ElementEndNode::ElementEndNode): (KJS::ElementEndNode::streamTo): (KJS::NullNode::NullNode): (KJS::BooleanNode::BooleanNode): (KJS::NumberNode::NumberNode): (KJS::StringNode::StringNode): (KJS::RegExpNode::RegExpNode): (KJS::ThisNode::ThisNode): (KJS::ResolveNode::ResolveNode): (KJS::ArrayNode::ArrayNode): (KJS::PropertyNode::PropertyNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::BracketAccessorNode::BracketAccessorNode): (KJS::BracketAccessorNode::isBracketAccessorNode): (KJS::DotAccessorNode::DotAccessorNode): (KJS::DotAccessorNode::isDotAccessorNode): (KJS::ArgumentListNode::ArgumentListNode): (KJS::ArgumentListNode::streamTo): (KJS::ArgumentsNode::streamTo): (KJS::NewExprNode::NewExprNode): (KJS::FunctionCallNode::FunctionCallNode): (KJS::PostfixNode::PostfixNode): (KJS::PostfixBracketNode::PostfixBracketNode): (KJS::DeleteNode::DeleteNode): (KJS::DeleteBracketNode::DeleteBracketNode): (KJS::DeleteValueNode::DeleteValueNode): (KJS::VoidNode::VoidNode): (KJS::TypeOfResolveNode::TypeOfResolveNode): (KJS::TypeOfValueNode::TypeOfValueNode): (KJS::PrefixNode::PrefixNode): (KJS::PrefixBracketNode::PrefixBracketNode): (KJS::UnaryPlusNode::UnaryPlusNode): (KJS::NegateNode::NegateNode): (KJS::BitwiseNotNode::BitwiseNotNode): (KJS::LogicalNotNode::LogicalNotNode): (KJS::MultNode::MultNode): (KJS::AddNode::AddNode): (KJS::ShiftNode::ShiftNode): (KJS::RelationalNode::RelationalNode): (KJS::EqualNode::EqualNode): (KJS::BitOperNode::BitOperNode): (KJS::JumpNode::JumpNode): (KJS::NoOpNode::NoOpNode): (KJS::ReadModifyAssignNode::ReadModifyAssignNode): (KJS::AssignNode::AssignNode): (KJS::ReadModifyAssignBracketNode::ReadModifyAssignBracketNode): (KJS::AssignBracketNode::AssignBracketNode): (KJS::CommaNode::CommaNode): (KJS::VarDeclNode::VarDeclNode::VarDeclNode): (KJS::VarDeclEndNode::VarDeclEndNode): (KJS::VarDeclEndNode::streamTo): (KJS::ExprStatementNode::ExprStatementNode): (KJS::IfConditionEndNode::IfConditionEndNode): (KJS::IfConditionEndNode::streamTo): (KJS::DoWhileTestExprEndNode::DoWhileTestExprEndNode): (KJS::DoWhileTestExprEndNode::streamTo): (KJS::WhileTestExprEndNode::WhileTestExprEndNode): (KJS::WhileTestExprEndNode::streamTo): (KJS::ForNode::ForNode): (KJS::ForExprEndNode::ForExprEndNode): (KJS::ForExprEndNode::streamTo): (KJS::ReturnNode::ReturnNode): (KJS::ValueReturnEndNode::ValueReturnEndNode): (KJS::WithExprEndNode::WithExprEndNode): (KJS::WithExprEndNode::streamTo): (KJS::ThrowEndNode::ThrowEndNode): (KJS::FuncExprNode::FuncExprNode):
  • kjs/nodes2string.cpp: (ExprNode::streamTo): (ReturnNode::streamTo):
  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): bug fix (doIt): fix to avoid false positive leak reports (kjsmain): ditto
1:22 AM Changeset in webkit [13869] by hyatt
  • 2696 edits
    2 adds in trunk/LayoutTests

Land updated layout tests.

1:15 AM Changeset in webkit [13868] by hyatt
  • 13 edits in trunk/WebCore

Fix for 8333, make sure newlines in whitespace:pre (and friends) get
line boxes created for them. This resolves all the weird selection/navigation
issues that arise by not creating lines (and thus not having navigable positions
on those lines).

This checkin is also removing all of the layout test hacks that have piled
up, so layout test results are being regenerated completely.

Reviewed by eric

  • dom/Position.cpp: (WebCore::Position::downstream):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply):
  • editing/visible_units.cpp: (WebCore::startOfParagraph): (WebCore::endOfParagraph):
  • kwq/RenderTreeAsText.cpp: (getTagName): (operator<<):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): (WebCore::InlineTextBox::isLineBreak): (WebCore::InlineTextBox::nodeAtPoint): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/InlineTextBox.h:
  • rendering/RenderBR.cpp:
  • rendering/RenderBR.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::atLineWrap): (WebCore::RenderText::caretRect): (WebCore::RenderText::height): (WebCore::RenderText::inlineBox):
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::findNextLineBreak):
  • rendering/render_line.h: (WebCore::InlineBox::isLineBreak):

Apr 13, 2006:

6:17 PM Changeset in webkit [13867] by darin
  • 5 edits
    2 copies
    8 moves in trunk/WebCore

Reviewed by Geoff.

  • moved a few things out of kwq and cleaned up the Java-applet-related renderers
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file location and name changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • kwq/JavaAppletWidget.h: Moved.
  • kwq/JavaAppletWidget.mm: Moved.
  • kwq/RegularExpression.cpp: Moved.
  • kwq/RegularExpression.h: Moved.
  • kwq/RenderTreeAsText.cpp: Moved.
  • kwq/RenderTreeAsText.h: Moved.
  • rendering/render_applet.cpp: Moved.
  • rendering/render_applet.h: Moved.
  • bridge/JavaAppletWidget.h: Moved here.
  • bridge/mac/JavaAppletWidget.mm: Moved here.
  • platform/RegularExpression.cpp: Moved here.
  • platform/RegularExpression.h: Moved here.
  • rendering/RenderTreeAsText.cpp: Moved here.
  • rendering/RenderTreeAsText.h: Moved here.
  • rendering/RenderApplet.h: Moved here and made changes. Removed unused element() function.
  • rendering/RenderApplet.cpp: Moved here and made changes. (WebCore::RenderApplet::RenderApplet): Changed parameter type to be more precise (HTMLAppletElement). (WebCore::RenderApplet::intrinsicWidth): Removed unnecessary type cast and simplified. (WebCore::RenderApplet::intrinsicHeight): Ditto. (WebCore::RenderApplet::createWidgetIfNecessary): Straightened out the if statements and changed to use node() instead of element(). (WebCore::RenderApplet::layout): Removed unneeded check before calling createWidgetIfNecessary.
  • rendering/RenderEmptyApplet.h: Moved here and made changes. Removed unneeded overrides of intrinsicWidth and intrinsicHeight.
  • rendering/RenderEmptyApplet.cpp: Moved here and made changes. (WebCore::RenderEmptyApplet::RenderEmptyApplet): Added code to set the intrinsic width and height.
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::RenderWidget): Initialize m_widget with contructor syntax. (WebCore::RenderWidget::paint): Changed _tx and _ty to be just tx and ty. Rearranged the code so the transparent wash will draw even if m_widget is 0.
  • html/html_objectimpl.cpp: Update includes for new file names.
4:06 PM Changeset in webkit [13866] by eseidel
  • 10 edits in branches/treecode/JavaScriptCore

Removed (most) macros from TreeCode.cpp
Removed Imp from state names
Removed Interpreter ring (using interpreter map instead)
Removed push/pop/peek accessors for stacks.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8363
Reviewed by Darin.

2:24 PM Changeset in webkit [13865] by ggaren
  • 29 edits
    8 adds
    4 deletes in trunk

JavaScriptCore:

Reviewed by Darin.

  • kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject): Add the built-in object prototype to the end of the global object's prototype chain instead of just blowing away its existing prototype. We need to do this because the window object has a meaningful prototype now.

LayoutTests:

Layout test for document.defaultView

  • fast/dom/defaultView-expected.txt: Added.
  • fast/dom/defaultView.html: Added.
  • fast/events/event-view-toString-expected.txt: Updated to reflect new prototype chain for defaultView.

WebCore:

Reviewed by Darin.

  • Fixed <rdar://problem/4478467> document.defaultView should return the window object


Also made part of the window object autogenerated by IDL file.


  • DerivedSources.make: Added /page to IDL file search path, added JSDOMWindow.h, removed kjs_views.lut.h
  • WebCore.xcodeproj/project.pbxproj: Added missing files, removed obsolete files
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
  • bindings/js/kjs_views.cpp: Removed.
  • bindings/js/kjs_views.h: Removed.
  • bindings/js/kjs_window.cpp: Removed document property -- it now belongs to JSDOMWindow. Added toJS and toDOMWindow. (KJS::Window::Window): (KJS::Window::impl): (KJS::Window::getValueProperty): (KJS::Window::clear): Added call to setPrototype to ensure that the prototype gets cleared during navigation. (Previously this wasn't an issue because the window object had no real prototype.) (WebCore::toJS): (WebCore::toDOMWindow):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/objc/DOMCSS.mm: Added NULL checks for the AbstractView (Presumably this is an issue after the window is closed.) Typedef-ed AbstractView as DOMWindow. I could have just replaced AbstractView with DOMWindow, but I think it's clearer to say, "There's this thing called the AbstractView, but really it's just the window." (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules::]):
  • bindings/objc/DOMViews.mm:
  • bindings/objc/DOMViewsInternal.h:
  • bindings/scripts/CodeGeneratorJS.pm: Removed unused GetLegacyImplementationIncludes. Added support for DOMWindow and new "DoNotCache" attribute. Replaced C macros with text because (1) it makes the generated source easier to read and debug and (2) it made it much easier to implement the DoNotCache attribute.
  • bindings/scripts/IDLParser.pm: Return a hash reference instead of a hash, because otherwise an interface with more than one attribute returns too many arguments to be processed.
  • bridge/mac/FrameMac.mm:
  • dom/AbstractView.cpp: Removed.
  • dom/AbstractView.h: Removed.
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::defaultView):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/Position.cpp:
  • dom/UIEvent.idl:
  • dom/dom2_eventsimpl.h:
  • page/DOMWindow.cpp: Added. (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::frame): (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::document): (WebCore::DOMWindow::getComputedStyle): (WebCore::DOMWindow::getMatchedCSSRules):
  • page/DOMWindow.h: Added.
  • page/DOMWindow.idl: Added.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Disconnect the new DOMWindow object in addition to the Window object. Maybe we can unify this in the future. (WebCore::Frame::tree): (WebCore::Frame::domWindow):
  • page/Frame.h:
  • page/FramePrivate.h:
1:52 PM Changeset in webkit [13864] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Maciej.

  • projects/compat/hitlist.html: Added Google Calendar to the list in place of www.hangseng.com/ebanking
10:03 AM Changeset in webkit [13863] by ap
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

  • html/HTMLTokenizer.cpp: Only use fixUpChar() when handling entities. (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write):
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::convert): Remove the special case for Latin-1, because it is already handled via effectiveEncoding().
  • platform/StreamingTextDecoder.h: Remove convertLatin1().

LayoutTests:

Tests that Latin-1 is handled as windows-1252
(see ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7602). Some existing tests
already did cover this, but only indirectly.

  • fast/encoding/latin1-winlatin-expected.txt: Added.
  • fast/encoding/latin1-winlatin.html: Added.
8:50 AM Changeset in webkit [13862] by darin
  • 2 edits in trunk/WebCore
  • platform/mac/GraphicsContextMac.mm: Fix one no-SVG compile problem by adding a "using namespace std".
3:33 AM Changeset in webkit [13861] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.


  • fix testkjs to not show false-positive KJS::Node leaks in debug builds
  • kjs/testkjs.cpp: (doIt): (kjsmain):
12:48 AM Changeset in webkit [13860] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Refining the list of renames to be done soon.

12:07 AM Changeset in webkit [13859] by darin
  • 54 edits
    1 delete in trunk/WebCore

Rubber-stamped by Anders.

  • fix Windows build
  • WebCore.vcproj/Image\ Viewer/Image\ Viewer.vcproj: Add loader directory.
  • use std::min/max exclusively intead of kMin/Max
  • eliminate KWQDef.h since all it had left in it was kMin/Max
  • WebCore.vcproj/WebCore/WebCore.vcproj: Remove KWQDef.h.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • kwq/KWQDef.h: Removed.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): (WebCore::CSSStyleSelector::fontSizeForKeyword):
  • dom/Document.cpp: (WebCore::Document::minimumLayoutDelay): (WebCore::Document::addMarker):
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
  • dom/xml_tokenizer.cpp: (WebCore::OffsetBuffer::readOutBytes):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::CharacterIterator::string): (WebCore::findPlainText):
  • editing/htmlediting.cpp: (WebCore::rangeCompliantEquivalent):
  • editing/markup.cpp: (WebCore::renderedText):
  • editing/visible_units.cpp: (WebCore::startOfParagraph):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::enlargeBuffer): (WebCore::HTMLTokenizer::enlargeScriptBuffer):
  • html/html_imageimpl.cpp: (WebCore::HTMLAreaElement::getRegion):
  • html/html_tableimpl.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
  • kwq/KWQSlider.mm: (QSlider::setValue):
  • loader/Cache.cpp: (WebCore::Cache::setSize):
  • page/Frame.cpp: (WebCore::Frame::forceLayoutWithPageWidthRange):
  • platform/DeprecatedPtrListImpl.h:
  • platform/DeprecatedString.cpp: (ucstrcmp):
  • platform/DeprecatedString.h:
  • platform/DeprecatedValueListImpl.h:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::addRoundedRectClip):
  • platform/mac/WebCoreTextArea.mm: (-[WebCoreTextView _trackResizeFromMouseDown:]):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::isSelected): (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::selectionStartEnd): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintSpellingMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::paintMarkedTextUnderline):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowRect): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::setCollapsedBottomMargin): (WebCore::RenderBlock::handleBottomOfBlock): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::nearestFloatBottom): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::calcMinMaxWidth): (WebCore::RenderBlock::calcInlineMinMaxWidth): (WebCore::RenderBlock::calcBlocminMaxWidth):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcBorderBoxWidth): (WebCore::RenderBox::calcBorderBoxHeight): (WebCore::RenderBox::calcContentBoxWidth): (WebCore::RenderBox::calcContentBoxHeight): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues):
  • rendering/RenderCanvas.cpp: (WebCore::RenderCanvas::layout):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcMinMaxWidth): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox): (WebCore::RenderFlexibleBox::allowedChildFlex):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition): (WebCore::RenderFlow::paintOutlineForLine):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::absoluteBoundingBox): (WebCore::Marquee::marqueeSpeed): (WebCore::Marquee::computePosition): (WebCore::Marquee::timerFired):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition):
  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::minXPos): (WebCore::RenderText::width): (WebCore::RenderText::caretMinOffset): (WebCore::RenderText::caretMaxOffset):
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::checkLinesForOverflow):
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::setSelectionStart): (WebCore::RenderLineEdit::setSelectionEnd): (WebCore::RenderLineEdit::setSelectionRange): (WebCore::RenderFieldset::layoutLegend): (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderSelect::layout): (WebCore::RenderTextArea::calcMinMaxWidth): (WebCore::RenderSlider::updateFromElement):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_line.h: (WebCore::RootInlineBox::selectionHeight):
  • rendering/render_list.cpp: (WebCore::RenderListItem::positionListMarker):
  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::shouldPaint):
  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): Use min/max instead of kMin/kMax.
Note: See TracTimeline for information about the timeline view.