⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 23, 2006:

6:21 PM Changeset in webkit [14555] by brmorris
  • 1 edit
    2 deletes in S60/trunk

S60WebKit:

  • Corrected build.bat usage statement
  • Removed some irrelevant config files
6:08 PM Changeset in webkit [14554] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Correct reviewer from me to Tim.

5:59 PM Changeset in webkit [14553] by mjs
  • 9 edits in trunk/WebKit

Reviewed by Maciej.


  • more loader refactoring to simplify things and remove knowledge of WebView from WebSubresourceLoader
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): (-[WebSubresourceLoader didReceiveResponse:]):
  • WebView/WebDataSource.m: (-[WebDataSource _loadIcon]): (-[WebDataSource _startLoading]):
  • WebView/WebFrame.m: (-[WebFrame _loadRequest:archive:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebLoader.h:
  • WebView/WebLoader.m:
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader initWithDataSource:]): (-[WebMainResourceLoader didReceiveResponse:]):
5:24 PM Changeset in webkit [14552] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Timothy.

  • index.html: Link to Nokia's S60 WebKit.
4:32 PM Changeset in webkit [14551] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Eric.

Remove the recent idl files from the WebCore target to prevent them
from being copied into the framework resources.

  • WebCore.xcodeproj/project.pbxproj:
4:31 PM Changeset in webkit [14550] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Justin Garcia and Levi Weintraub.


  • fixed Bug 9072: REGRESSION: Misspelling marker incorrect in editing/deleting/delete-and-undo.html
  • dom/Document.cpp: (WebCore::Document::removeMarkers): One more time to get this right, ugh. There is still one case where we don't want to advance the iterator, and that's when we remove a marker and do not insert a replacement marker. So I undid my previous patch, and added it++ to each of the two cases that insert a replacement marker. Now the layout tests pass even with the pixel tests enabled.
3:48 PM Changeset in webkit [14549] by brmorris
  • 372 edits
    2668 adds in S60/trunk

S60WebKit ... migrated!

3:11 PM Changeset in webkit [14548] by hyatt
  • 3 edits
    1 add in trunk/WebCore

Implement CookieJar on Win32.

2:37 PM Changeset in webkit [14547] by thatcher
  • 1 copy in tags/WebKit-418.8/WebKit

Tag for WebKit 418.8 (part 2 of 2.)

2:37 PM Changeset in webkit [14546] by thatcher
  • 1 add in tags/WebKit-418.8

Tag for WebKit 418.8 (part 1 of 2.)

2:36 PM Changeset in webkit [14545] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

2:36 PM Changeset in webkit [14544] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-23 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4558301> REGRESSION (420+): After clearing history and closing bookmark view window,
attempting to select Safari's menu bar results in a crash

  • Misc/WebNSWindowExtras.m: (replacementPostWindowNeedsDisplay): My fix yesterday for 4557117 was not quite good enough. Now that we cancel the display timer for a window *before* it deallocates, we need to make sure that while a window deallocates, no new display timers are scheduled for that window. This is actually possible, as 4558301 demonstrates. Luckily, NSWindow sets a handy "windowDying" flag when it deallocates, so we can just check that flag and bail out of the throttle hack if it is set. This should fix the last of the crashes involving display timers scheduled for deallocated or deallocating windows.
2:21 PM Changeset in webkit [14543] by hyatt
  • 1 edit in trunk/WebCore/bridge/win/FrameWin.cpp

Fix post form submission on Win32.

1:45 PM Changeset in webkit [14542] by sullivan
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Newer Xcode removed some obsolete cruft


  • DumpRenderTree/TextInputController.m: (-[TextInputController textInput]): added (id) cast to make newer compiler happy
1:31 PM Changeset in webkit [14541] by hyatt
  • 7 edits in trunk/WebCore

Fix glyph width access on win32 to not depend on the UChar.

12:27 PM Changeset in webkit [14540] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4558301> REGRESSION (420+): After clearing history and closing bookmark view window,
attempting to select Safari's menu bar results in a crash

  • Misc/WebNSWindowExtras.m: (replacementPostWindowNeedsDisplay): My fix yesterday for 4557117 was not quite good enough. Now that we cancel the display timer for a window *before* it deallocates, we need to make sure that while a window deallocates, no new display timers are scheduled for that window. This is actually possible, as 4558301 demonstrates. Luckily, NSWindow sets a handy "windowDying" flag when it deallocates, so we can just check that flag and bail out of the throttle hack if it is set. This should fix the last of the crashes involving display timers scheduled for deallocated or deallocating windows.
12:18 PM Changeset in webkit [14539] by brmorris
  • 1 add in S60/trunk/patentlicense.txt

S60WebKit: adding patentlicense.txt

12:15 PM Changeset in webkit [14538] by thatcher
  • 4 edits in tags/Safari-521.10.1

Versioning

10:51 AM Changeset in webkit [14537] by lweintraub
  • 5 edits in trunk/WebCore

Reviewed by Hyatt.

Cleaned up changes to markup by adding the non-virtual
nodeNamePreservingCase accessor function.

  • dom/Element.cpp: (WebCore::Element::nodeNamePreservingCase):
  • dom/Element.h:
  • editing/markup.cpp: (WebCore::startMarkup): (WebCore::endMarkup):
10:47 AM Changeset in webkit [14536] by thatcher
  • 1 copy in tags/Safari-521.10.1

New tag.

10:35 AM Changeset in webkit [14535] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • dom/Document.cpp: (WebCore::Document::removeMarkers): Fix to my previous checkin (which broke a layout test). Advance the iterator position every time through the loop; formerly it was not advanced in the case where a marker was actually removed, causing an infinite loop in certain cases. Also modified a comment that was confusing the situation by falsely claiming that iterating over a just-inserted node would always be OK.
9:27 AM Changeset in webkit [14534] by andersca
  • 12 edits
    2 adds in trunk

WebCore:

2006-05-23 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
Weather2.css incorrectly treated as JavaScript file @ www.live.com


  • dom/Element.cpp: (WebCore::Element::getAttribute): (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute): (WebCore::Element::getAttributeNode): (WebCore::Element::hasAttribute): Use new getAttributeItem method.


  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::removeNamedItem): Use new getAttributeItem method.


(WebCore::NamedAttrMap::getAttributeItem):

  • dom/NamedAttrMap.h: New method which returns the attribute based on the nodeName.

LayoutTests:

2006-05-23 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Update tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
Weather2.css incorrectly treated as JavaScript file @ www.live.com


  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt: This fails in a different way now.


  • dom/xhtml/level3/core/nodelookupnamespaceuri17-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri20-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix17-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix20-expected.txt:
  • dom/xhtml/level3/core/noderemovechild28-expected.txt:
  • dom/xhtml/level3/core/noderemovechild29-expected.txt: These now pass.


  • fast/dom/attribute-namespaces-get-set-expected.txt: Added.
  • fast/dom/attribute-namespaces-get-set.html: Added. Add new tests.
8:40 AM Changeset in webkit [14533] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Eric.


  • remove knowledge of WebView from WebLoader in preparation for moving the code down
  • WebView/WebDataSource.m: (-[WebDataSource _defersCallbacks]): (-[WebDataSource _identifierForInitialRequest:]): (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]): (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource _didReceiveData:contentLength:forResource:]): (-[WebDataSource _didFinishLoadingForResource:]): (-[WebDataSource _didFailLoadingWithError:forResource:]): (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]): (-[WebDataSource _privateBrowsingEnabled]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebLoader.h:
  • WebView/WebLoader.m: (-[WebLoader releaseResources]): (-[WebLoader setDataSource:]): (-[WebLoader willSendRequest:redirectResponse:]): (-[WebLoader didReceiveAuthenticationChallenge:]): (-[WebLoader didCancelAuthenticationChallenge:]): (-[WebLoader didReceiveResponse:]): (-[WebLoader didReceiveData:lengthReceived:]): (-[WebLoader signalFinish]): (-[WebLoader didFinishLoading]): (-[WebLoader didFailWithError:]): (-[WebLoader willCacheResponse:]): (-[WebLoader cancelWithError:]):
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
  • WebView/WebView.m: (-[WebView _incrementProgressForIdentifier:response:]): (-[WebView _incrementProgressForIdentifier:data:]): (-[WebView _completeProgressForIdentifier:]):
  • WebView/WebViewInternal.h:

May 22, 2006:

6:36 PM Changeset in webkit [14532] by eseidel
  • 2 edits in trunk/WebCore

2006-05-22 Eric Seidel <​eric@eseidel.com>

Rubber-stamped by adele.

  • bindings/js/kjs_html.h: simple style cleanup.
4:55 PM Changeset in webkit [14531] by thatcher
  • 1 copy in tags/Safari-521.10

Tag for 521.10

4:46 PM Changeset in webkit [14530] by thatcher
  • 8 edits in /

Versioning.

4:30 PM Changeset in webkit [14529] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix when doing 'xcodebuild install'.

3:18 PM Changeset in webkit [14528] by thatcher
  • 1 edit in trunk/WebCore/platform/mac/WebCoreSystemInterface.h

Build fix.

3:10 PM Changeset in webkit [14527] by justing
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

Reviewed by levi


Fixed and reenabled this test.

  • editing/selection/drag-to-contenteditable-iframe-expected.checksum:
  • editing/selection/drag-to-contenteditable-iframe-expected.png:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe.html: Added.
  • editing/selection/drag-to-contenteditable-iframe.html-disabled: Removed.
2:51 PM Changeset in webkit [14526] by thatcher
  • 1 copy in tags/WebKit-418.7/WebKit

Tag for WebKit 418.7 (part 2 of 2.)

2:51 PM Changeset in webkit [14525] by thatcher
  • 1 add in tags/WebKit-418.7

Tag for WebKit 418.7 (part 1 of 2.)

2:51 PM Changeset in webkit [14524] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

2:41 PM Changeset in webkit [14523] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-22 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4557117> TOT REGRESSION: Repro crash in cancelPendingWindowDisplay --> _timerRelease when
opening file from file open dialog

Note that I could not reproduce this situation at all on any of my machines; I had to debug this on Geoff's
machine.

  • Misc/WebNSWindowExtras.m: (replacementDealloc): Cancel display timer before dealloc, not after. Cancelling the timer can cause a message to be sent to the window; best to do that before the window deallocates. (replacementFinalize): ditto
2:39 PM Changeset in webkit [14522] by thatcher
  • 1 edit in trunk/JavaScriptCore/wtf/MathExtras.h

Removes svn:executable from MathExtras.h. Caused a build verification failure.

2:20 PM Changeset in webkit [14521] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Anders Carlsson.


  • fixed Bug 9038: Rework Document::TextMarker mechanism to not use deprecated data structures

Changed Document::markersForNode and Document::MarkerMap to use Vector rather than
DeprecatedValueList and DeprecatedValueListIterator.


  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::copyMarkers): (WebCore::Document::removeMarkers): (WebCore::Document::markersForNode): (WebCore::Document::repaintMarkers): (WebCore::Document::shiftMarkers):


  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintAllMarkersOfType):
2:00 PM Changeset in webkit [14520] by thatcher
  • 5 edits in trunk/WebCore/platform

64-bit build fix, and removes the workaround for <rdar://problem/4294625>.

1:55 PM Changeset in webkit [14519] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4557117> TOT REGRESSION: Repro crash in cancelPendingWindowDisplay --> _timerRelease when
opening file from file open dialog

Note that I could not reproduce this situation at all on any of my machines; I had to debug this on Geoff's
machine.

  • Misc/WebNSWindowExtras.m: (replacementDealloc): Cancel display timer before dealloc, not after. Cancelling the timer can cause a message to be sent to the window; best to do that before the window deallocates. (replacementFinalize): ditto
1:21 PM Changeset in webkit [14518] by sfalken
  • 2 edits in trunk/WebKitTools

2006-05-22 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.


Fix build.

  • Spinneret/Spinneret.sln:
1:16 PM Changeset in webkit [14517] by sfalken
  • 2 edits in trunk/WebKitWin

2006-05-22 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.


Fix build.

  • WebKitWin.vcproj/WebKitWin.sln:
11:34 AM Changeset in webkit [14516] by lweintraub
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by eric.


  • editing/execCommand/createLink-expected.txt:
  • editing/execCommand/unlink-expected.txt:
  • editing/input/attributed-substring-from-range-lines-expected.txt:
  • fast/dom/Range/range-exceptions-expected.txt:
  • fast/dom/Range/resources/range-exceptions.js:
  • fast/innerHTML/005-expected.txt:
  • fast/innerHTML/innerHTML-custom-tag-expected.txt:
  • fast/innerHTML/innerHTML-cast.html: Added.
  • fast/innerHTML/innerHTML-cast-expected.txt: Added.
  • fast/xsl/xslt-processer-expected.txt:

WebCore:

Reviewed by Eric.


  • editing/markup.cpp: (WebCore::startMarkup): (WebCore::endMarkup):
11:20 AM Changeset in webkit [14515] by thatcher
  • 4 edits in trunk/JavaScriptCore

Reviewed by Eric, Kevin and Geoff.

Merge open source build fixes. <rdar://problem/4555500>

  • kjs/collector.cpp: look at the rsp register in x86_64 (KJS::Collector::markOtherThreadConservatively):
  • wtf/Platform.h: add x86_64 to the platform list
1:04 AM Changeset in webkit [14514] by hyatt
  • 1 edit in trunk/WebCore/platform/mac/FontCacheMac.mm

Fix Mac bustage.

May 21, 2006:

11:19 PM Changeset in webkit [14513] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontDataWin.cpp

Fix win32 bustage.

11:18 PM Changeset in webkit [14512] by hyatt
  • 5 edits
    3 adds in trunk/WebCore

Fix win32 bustage.

4:42 PM Changeset in webkit [14511] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::text): Reverting recent change to user innerText instead of textContent. For textareas, we need a better solution than textContent that also takes newlines into account, but this should fix this crasher.
12:51 AM Changeset in webkit [14510] by andersca
  • 1 edit
    1 add in trunk/WebCore

2006-05-21 Anders Carlsson <​acarlsson@apple.com>

Fix build.


  • ForwardingHeaders/wtf/MathExtras.h: Added.
12:18 AM Changeset in webkit [14509] by hyatt
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

Add mathextras to javascrtipcore project.

12:05 AM Changeset in webkit [14508] by hyatt
  • 1 edit in trunk/WebCore/platform/mac/FontPlatformData.h

Fix mac bustage. Minor snafu in constructor.

May 20, 2006:

11:58 PM Changeset in webkit [14507] by hyatt
  • 14 edits
    1 move
    2 adds in trunk/WebCore

Switch on Cairo-based text rendering on win32.

11:55 PM Changeset in webkit [14506] by hyatt
  • 1 add in trunk/JavaScriptCore/wtf/MathExtras.h

Add mathextras.h to wtf to give win32 roundf/lroundf support.

7:09 PM Changeset in webkit [14505] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Beth.


  • fix assertion failure on layout tests
  • WebView/WebDataSource.m: (-[WebDataSource _mainReceivedError:complete:]): Don't do anything if this data source is no longer connected to a frame. Used to be this couldn't happen because the WebView would have been nil, but we no longer go through the WebView.
3:42 PM Changeset in webkit [14504] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Anders.

Bug 9018: REGRESSION: resizing the top area of the inspector does not grow as expected
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9018


Use clientHeight now that offsetHeight includes the border and padding.
clientHeight should have been used initially.

2:22 PM Changeset in webkit [14503] by hyatt
  • 2 edits in trunk/WebKitWin

Fix Cairo double buffering.

1:19 PM Changeset in webkit [14502] by andersca
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2006-05-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8993
Support function declaration in case statements


  • kjs/grammar.y: Get rid of StatementList and use SourceElements instead.


  • kjs/nodes.cpp: (CaseClauseNode::evalStatements): (CaseClauseNode::processVarDecls): (CaseClauseNode::processFuncDecl): (ClauseListNode::processFuncDecl): (CaseBlockNode::processFuncDecl): (SwitchNode::processFuncDecl):
  • kjs/nodes.h: (KJS::CaseClauseNode::CaseClauseNode): (KJS::ClauseListNode::ClauseListNode): (KJS::ClauseListNode::getClause): (KJS::ClauseListNode::getNext): (KJS::ClauseListNode::releaseNext): (KJS::SwitchNode::SwitchNode): Add processFuncDecl for the relevant nodes.
  • kjs/nodes2string.cpp: (CaseClauseNode::streamTo): next got renamed to source.

LayoutTests:

2006-05-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • fast/js/function-declarations-in-switch-statement-expected.txt: Added.
  • fast/js/function-declarations-in-switch-statement.html: Added.
  • fast/js/resources/function-declarations-in-switch-statement.js: Added.
1:57 AM Changeset in webkit [14501] by ap
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • page/FrameView.cpp: (WebCore::selectCursor): Fallback to CURSOR_AUTO if the image is an error image.
  • manual-tests/custom-cursors.html: Added.
1:47 AM Changeset in webkit [14500] by ap
  • 3 edits
    4 adds in trunk

2006-05-20 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by ap.

Test: fast/table/empty-section-crash.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint): Return immediately if the section has 0 rows or 0 columns.
Note: See TracTimeline for information about the timeline view.